Re: [PATCH v4 20/37] mips: use sysbus_mmio_get_region() instead of internal fields

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 15:28, Marc-André Lureau wrote: > > Register the memory region with sysbus_init_mmio() and look it up with > sysbus_mmio_get_region() to avoid accessing internal device fields. > > Suggested-by: Peter Maydell > Signed-off-by: Marc-André Lureau > --- > hw/char/serial.c

Re: [PATCH v4 12/37] serial: start making SerialMM a sysbus device

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 15:27, Marc-André Lureau wrote: > > Memory mapped serial device is in fact a sysbus device. The following > patches will make use of sysbus facilities for resource and > registration. In particular, "serial-mm: use sysbus facilities" will > move internal serial realization

Re: [PATCH 07/15] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4

2019-11-21 Thread Janosch Frank
On 11/21/19 2:50 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:26 -0500 > Janosch Frank wrote: > >> Now that we know the protection state off the cpus, we can start >> handling all diag 308 subcodes in the protected state. > > "As we now have access to the protection state of the cpus,

Re: [PATCH 08/15] s390x: protvirt: KVM intercept changes

2019-11-21 Thread Cornelia Huck
On Wed, 20 Nov 2019 06:43:27 -0500 Janosch Frank wrote: > Secure guests no longer intercept with code 4 for an instruction > interception. Instead they have codes 104 and 108 for secure > instruction interception and secure instruction notification > respectively. > > The 104 mirrors the 4, but

Re: [PATCH 08/15] s390x: protvirt: KVM intercept changes

2019-11-21 Thread Janosch Frank
On 11/21/19 3:07 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:27 -0500 > Janosch Frank wrote: > >> Secure guests no longer intercept with code 4 for an instruction >> interception. Instead they have codes 104 and 108 for secure >> instruction interception and secure instruction

Re: [PATCH v2 2/6] block: truncate: Don't make backing file data visible

2019-11-21 Thread Kevin Wolf
Am 21.11.2019 um 13:21 hat Max Reitz geschrieben: > On 21.11.19 12:34, Kevin Wolf wrote: > > Am 21.11.2019 um 09:59 hat Max Reitz geschrieben: > >> On 20.11.19 19:44, Kevin Wolf wrote: > >>> When extending the size of an image that has a backing file larger than > >>> its old size, make sure that

Re: [PATCH 05/15] s390x: protvirt: Sync PV state

2019-11-21 Thread Thomas Huth
On 20/11/2019 12.43, Janosch Frank wrote: > We do not always have the SIE intercept code handy at each place where > we do emulation. Unfortunately emulation for secure guests often > differ slightly from normal emulation and we need to make decisions > based on the protected state of the VCPU. >

Re: [Qemu-devel] [PATCH v4 04/14] qapi: Allow optional discriminators

2019-11-21 Thread Markus Armbruster
Max Reitz writes: > Optional discriminators are fine, as long as there is a default value. > > Signed-off-by: Max Reitz > --- > scripts/qapi/common.py | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py >

Re: [RFC v4 PATCH 13/49] multi-process: introduce proxy object

2019-11-21 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:08:54AM -0400, Jagannathan Raman wrote: > diff --git a/hw/proxy/qemu-proxy.c b/hw/proxy/qemu-proxy.c > new file mode 100644 > index 000..baba4da > --- /dev/null > +++ b/hw/proxy/qemu-proxy.c > @@ -0,0 +1,247 @@ > +/* > + * Copyright 2019, Oracle and/or its

Re: [PATCH 02/15] s390x: Beautify diag308 handling

2019-11-21 Thread David Hildenbrand
On 20.11.19 12:43, Janosch Frank wrote: Let's improve readability by: * Using constants for the subcodes * Moving parameter checking into a function * Removing subcode > 6 check as the default case catches that Signed-off-by: Janosch Frank --- target/s390x/diag.c | 54

Re: [PATCH 02/15] s390x: Beautify diag308 handling

2019-11-21 Thread Janosch Frank
On 11/21/19 12:21 PM, David Hildenbrand wrote: > On 20.11.19 12:43, Janosch Frank wrote: >> Let's improve readability by: >> * Using constants for the subcodes >> * Moving parameter checking into a function >> * Removing subcode > 6 check as the default case catches that >> >> Signed-off-by:

Re: [PATCH] Hexagon: Swap SIGRGMAX-1 and SIGRTMIN+1

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 12:54, Taylor Simpson wrote: > > How was this solved for other targets? It hasn't been, yet. Other targets only run guest code that doesn't care about this signal number being unavailable. thanks -- PMM

Re: [PATCH 11/15] RFC: s390x: Exit on vcpu reset error

2019-11-21 Thread David Hildenbrand
On 20.11.19 12:43, Janosch Frank wrote: If a vcpu is not properly reset it might be better to just end the VM. Signed-off-by: Janosch Frank --- target/s390x/kvm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c index 190400df55..0210b54157

Re: [PATCH 01/15] s390x: Cleanup cpu resets

2019-11-21 Thread Thomas Huth
On 20/11/2019 12.43, Janosch Frank wrote: > Let's move the resets into one function and switch by type, so we can > use fallthroughs for shared reset actions. > > Signed-off-by: Janosch Frank > --- > hw/s390x/s390-virtio-ccw.c | 3 + > target/s390x/cpu.c | 111

Re: [PATCH] vhost-user-fs: remove "vhostfd" property

2019-11-21 Thread Stefan Hajnoczi
On Sat, Nov 16, 2019 at 03:20:16PM +0400, Marc-André Lureau wrote: > The property doesn't make much sense for a vhost-user device. > > Signed-off-by: Marc-André Lureau > --- > hw/virtio/vhost-user-fs.c | 1 - > include/hw/virtio/vhost-user-fs.h | 1 - > 2 files changed, 2 deletions(-)

Re: [PATCH 07/15] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4

2019-11-21 Thread Cornelia Huck
On Wed, 20 Nov 2019 06:43:26 -0500 Janosch Frank wrote: > Now that we know the protection state off the cpus, we can start > handling all diag 308 subcodes in the protected state. "As we now have access to the protection state of the cpus, we can implement special handling of diag 308 subcodes

Re: [PATCH] vhost-user-input: use free(elem) instead of g_free(elem)

2019-11-21 Thread Stefan Hajnoczi
On Wed, Nov 20, 2019 at 11:48:56AM +, Daniel P. Berrangé wrote: > On Tue, Nov 19, 2019 at 11:16:26AM +, Stefan Hajnoczi wrote: > > The virtqueue element returned by vu_queue_pop() is allocated using > > malloc(3) by virtqueue_alloc_element(). Use the matching free(3) > > function instead

[PATCH v3] target/i386: add VMX features to named CPU models

2019-11-21 Thread Paolo Bonzini
This allows using "-cpu Haswell,+vmx", which we did not really want to support in QEMU but was produced by Libvirt when using the "host-model" CPU model. This was produced from the output of scripts/kvm/vmxcap using the following very ugly Python script: bits = { 'INS/OUTS

Re: [PATCH 03/15] s390x: protvirt: Add diag308 subcodes 8 - 10

2019-11-21 Thread Thomas Huth
On 20/11/2019 12.43, Janosch Frank wrote: > For diag308 subcodes 8 - 10 we have a new ipib of type 5. The ipib > holds the address and length of the secure execution header, as well > as a list of guest components. > > Each component is a block of memory, for example kernel or initrd, > which

Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion

2019-11-21 Thread Markus Armbruster
Richard Henderson writes: > On 11/20/19 6:30 PM, Fangrui Song wrote: >> On 2019-11-20, Juan Quintela wrote: >>> Markus Armbruster wrote: Fangrui Song writes: [...] > diff --git a/util/cutils.c b/util/cutils.c > index fd591cadf0..2b4484c015 100644 > --- a/util/cutils.c >

Re: [RFC 0/4] POC: Generating realistic block errors

2019-11-21 Thread Kevin Wolf
Am 21.11.2019 um 11:30 hat Stefan Hajnoczi geschrieben: > On Thu, Nov 14, 2019 at 09:47:48AM -0600, Tony Asleson wrote: > > On 9/20/19 12:28 PM, Tony Asleson wrote: > > > On 9/20/19 4:22 AM, Stefan Hajnoczi wrote: > > >> blkdebug is purely at the QEMU block layer level. It is not aware of > > >>

Re: [PATCH v2 2/6] block: truncate: Don't make backing file data visible

2019-11-21 Thread Kevin Wolf
Am 20.11.2019 um 22:15 hat Eric Blake geschrieben: > On 11/20/19 12:44 PM, Kevin Wolf wrote: > > When extending the size of an image that has a backing file larger than > > its old size, make sure that the backing file data doesn't become > > visible in the guest, but the added area is properly

Re: [RFC v4 PATCH 20/49] multi-process: add qdev_proxy_add to create proxy devices

2019-11-21 Thread Stefan Hajnoczi
On Thu, Oct 24, 2019 at 05:09:01AM -0400, Jagannathan Raman wrote: > diff --git a/hw/proxy/qemu-proxy.c b/hw/proxy/qemu-proxy.c > index 3b84055..fc1c731 100644 > --- a/hw/proxy/qemu-proxy.c > +++ b/hw/proxy/qemu-proxy.c > @@ -337,7 +337,8 @@ static void init_proxy(PCIDevice *dev, char *command, >

Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion

2019-11-21 Thread Richard Henderson
On 11/20/19 6:30 PM, Fangrui Song wrote: > On 2019-11-20, Juan Quintela wrote: >> Markus Armbruster wrote: >>> Fangrui Song writes: >>> The warning will be enabled by default in clang 10. It is not available for clang <= 9. qemu/migration/migration.c:2038:24: error: implicit

Re: [PATCH 05/15] s390x: protvirt: Sync PV state

2019-11-21 Thread Cornelia Huck
On Wed, 20 Nov 2019 06:43:24 -0500 Janosch Frank wrote: > We do not always have the SIE intercept code handy at each place where > we do emulation. Unfortunately emulation for secure guests often > differ slightly from normal emulation and we need to make decisions > based on the protected state

Re: [PATCH v4 06/37] serial: initial qom-ification

2019-11-21 Thread Peter Maydell
On Wed, 20 Nov 2019 at 15:25, Marc-André Lureau wrote: > > Make SerialState a device (the following patches will introduce IO/MM > sysbus serial devices) > > None of the serial_{,mm}_init() callers actually free the returned > value (even if they did, it would be quite harmless), so we can change

Re: [Qemu-devel] [PATCH v2 1/2] net: assert that tx packets have nonzero size

2019-11-21 Thread Alexander Bulekov
On 191107 1221, Jason Wang wrote: > > On 2019/7/22 下午9:24, Oleinik, Alexander wrote: > > Virtual devices should not try to send zero-sized packets. The caller > > should check the size prior to calling qemu_sendv_packet_async. > > > > Signed-off-by: Alexander Oleinik > > --- > > v2: > >*

[PATCH v4 4/5] blockdev: honor bdrv_try_set_aio_context() context requirements

2019-11-21 Thread Sergio Lopez
bdrv_try_set_aio_context() requires that the old context is held, and the new context is not held. Fix all the occurrences where it's not done this way. Suggested-by: Max Reitz Signed-off-by: Sergio Lopez --- blockdev.c | 67 ++ 1 file

Re: [PATCH 09/15] s390x: protvirt: SCLP interpretation

2019-11-21 Thread Cornelia Huck
On Wed, 20 Nov 2019 06:43:28 -0500 Janosch Frank wrote: > SCLP for a protected guest is done over the SIDAD, so we need to use > the s390_cpu_virt_mem_* functions to access the SIDAD instead of guest > memory when reading/writing SCBs. > > To not confuse the sclp emulation, we set 0x42000 as

Re: [PATCH for-4.2 2/2] i386: Add -noTSX aliases for hle=off, rtm=off CPU models

2019-11-21 Thread Kashyap Chamarthy
On Wed, Nov 20, 2019 at 01:49:12PM -0300, Eduardo Habkost wrote: > We have been trying to avoid adding new aliases for CPU model > versions, but in the case of changes in defaults introduced by > the TAA mitigation patches, the aliases might help avoid user > confusion when applying host software

Re: [PATCH 06/15] s390x: protvirt: Support unpack facility

2019-11-21 Thread Janosch Frank
On 11/21/19 12:27 PM, David Hildenbrand wrote: > On 20.11.19 12:43, Janosch Frank wrote: >> @@ -357,6 +353,35 @@ static void s390_machine_reset(MachineState *machine) >> run_on_cpu(cs, s390_do_cpu_initial_reset, RUN_ON_CPU_NULL); >> run_on_cpu(cs, s390_do_cpu_load_normal,

Re: [PATCH 09/15] s390x: protvirt: SCLP interpretation

2019-11-21 Thread Janosch Frank
On 11/21/19 3:11 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:28 -0500 > Janosch Frank wrote: > >> SCLP for a protected guest is done over the SIDAD, so we need to use >> the s390_cpu_virt_mem_* functions to access the SIDAD instead of guest >> memory when reading/writing SCBs. >> >> To

Re: [Qemu-devel] [PATCH v4 03/14] qapi: Introduce default values for struct members

2019-11-21 Thread Markus Armbruster
Max Reitz writes: > With this change, it is possible to give default values for struct > members, as follows: > > What you had to do so far: > > # @member: Some description, defaults to 42. > { 'struct': 'Foo', > 'data': { '*member': 'int' } } > > What you can do now: > > {

Re: [PATCH 02/15] s390x: Beautify diag308 handling

2019-11-21 Thread Cornelia Huck
On Wed, 20 Nov 2019 06:43:21 -0500 Janosch Frank wrote: > Let's improve readability by: > * Using constants for the subcodes > * Moving parameter checking into a function > * Removing subcode > 6 check as the default case catches that > > Signed-off-by: Janosch Frank > --- >

Re: [PATCH 15/15] s390x: protvirt: Handle SIGP store status correctly

2019-11-21 Thread David Hildenbrand
On 20.11.19 12:43, Janosch Frank wrote: Status storing is obviously not done by qemu anymore. Signed-off-by: Janosch Frank --- target/s390x/sigp.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/target/s390x/sigp.c b/target/s390x/sigp.c index

Re: [PATCH v2] exynos4210_gic: Suppress gcc9 format-truncation warnings

2019-11-21 Thread Richard Henderson
On 11/21/19 2:38 AM, David Gibson wrote: > exynos4210_gic_realize() prints the number of cpus into some temporary > buffers, but it only allows 3 bytes space for it. That's plenty: > existing machines will only ever set this value to EXYNOS4210_NCPUS > (2). But the compiler can't always figure

Re: [PATCH 11/15] RFC: s390x: Exit on vcpu reset error

2019-11-21 Thread David Hildenbrand
On 21.11.19 13:19, Janosch Frank wrote: On 11/21/19 1:14 PM, David Hildenbrand wrote: On 20.11.19 12:43, Janosch Frank wrote: If a vcpu is not properly reset it might be better to just end the VM. Signed-off-by: Janosch Frank --- target/s390x/kvm.c | 2 ++ 1 file changed, 2

Re: [PATCH 11/15] RFC: s390x: Exit on vcpu reset error

2019-11-21 Thread Janosch Frank
On 11/21/19 1:14 PM, David Hildenbrand wrote: > On 20.11.19 12:43, Janosch Frank wrote: >> If a vcpu is not properly reset it might be better to just end the VM. >> >> Signed-off-by: Janosch Frank >> --- >> target/s390x/kvm.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git

Re: [PATCH v2 2/6] block: truncate: Don't make backing file data visible

2019-11-21 Thread Max Reitz
On 21.11.19 12:34, Kevin Wolf wrote: > Am 21.11.2019 um 09:59 hat Max Reitz geschrieben: >> On 20.11.19 19:44, Kevin Wolf wrote: >>> When extending the size of an image that has a backing file larger than >>> its old size, make sure that the backing file data doesn't become >>> visible in the

Re: [PATCH 04/15] Header sync protvirt

2019-11-21 Thread Janosch Frank
On 11/21/19 1:59 PM, Cornelia Huck wrote: > On Wed, 20 Nov 2019 06:43:23 -0500 > Janosch Frank wrote: > >> Let's sync all the protvirt header changes >> >> Signed-off-by: Janosch Frank >> --- >> linux-headers/asm-s390/kvm.h | 3 ++- >> linux-headers/linux/kvm.h| 42

[PATCH v2] target/i386: add VMX features to named CPU models

2019-11-21 Thread Paolo Bonzini
This allows using "-cpu Haswell,+vmx", which we did not really want to support in QEMU but was produced by Libvirt when using the "host-model" CPU model. This was produced from the output of scripts/kvm/vmxcap using the following very ugly Python script: bits = { 'INS/OUTS

Re: [PATCH v2 3/6] iotests: Add qemu_io_log()

2019-11-21 Thread Alberto Garcia
On Wed 20 Nov 2019 07:44:58 PM CET, Kevin Wolf wrote: > Add a function that runs qemu-io and logs the output with the > appropriate filters applied. > > Signed-off-by: Kevin Wolf > Reviewed-by: Eric Blake > Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Berto

Re: [PATCH v2 4/6] iotests: Fix timeout in run_job()

2019-11-21 Thread Alberto Garcia
On Wed 20 Nov 2019 07:44:59 PM CET, Kevin Wolf wrote: > run_job() accepts a wait parameter for a timeout, but it doesn't > actually use it. The only thing that is missing is passing it to > events_wait(), so do that now. > > Signed-off-by: Kevin Wolf > Reviewed-by: Eric Blake > Reviewed-by:

Re: [PATCH v2 5/6] iotests: Support job-complete in run_job()

2019-11-21 Thread Alberto Garcia
On Wed 20 Nov 2019 07:45:00 PM CET, Kevin Wolf wrote: > Automatically complete jobs that have a 'ready' state and need an > explicit job-complete. Without this, run_job() would hang for such > jobs. > > Signed-off-by: Kevin Wolf > Reviewed-by: Eric Blake > Reviewed-by: Vladimir

Re: [qemu-web PATCH] Add a blog post about the QEMU-related presentation of KVM Forum 2019

2019-11-21 Thread Kashyap Chamarthy
On Thu, Nov 21, 2019 at 12:52:07PM +0100, Thomas Huth wrote: > There have been quite a lot of QEMU-related talks at KVM Forum this > year - let's provide a summary for the people who could not attend. > > Signed-off-by: Thomas Huth > --- > Note: For some talks it's hard to decide whether they

Re: [PATCH 07/15] s390x: protvirt: Handle diag 308 subcodes 0,1,3,4

2019-11-21 Thread Cornelia Huck
On Thu, 21 Nov 2019 15:04:31 +0100 Janosch Frank wrote: > On 11/21/19 2:50 PM, Cornelia Huck wrote: > > On Wed, 20 Nov 2019 06:43:26 -0500 > > Janosch Frank wrote: > > > > >> run_on_cpu(cs, s390_do_cpu_load_normal, RUN_ON_CPU_NULL); > >> break; > >> case

Re: [PATCH v6] Implement backend program convention command for vhost-user-blk

2019-11-21 Thread Stefan Hajnoczi
On Thu, Nov 21, 2019 at 09:58:26AM +0800, Micky Yun Chan wrote: > diff --git a/docs/interop/vhost-user.json b/docs/interop/vhost-user.json > index da6aaf51c8..d25c3a957f 100644 > --- a/docs/interop/vhost-user.json > +++ b/docs/interop/vhost-user.json > @@ -54,6 +54,37 @@ >] > } > > +## > +#

Re: [PATCH 06/15] s390x: protvirt: Support unpack facility

2019-11-21 Thread David Hildenbrand
On 21.11.19 15:25, Janosch Frank wrote: On 11/21/19 12:27 PM, David Hildenbrand wrote: On 20.11.19 12:43, Janosch Frank wrote: @@ -357,6 +353,35 @@ static void s390_machine_reset(MachineState *machine) run_on_cpu(cs, s390_do_cpu_initial_reset, RUN_ON_CPU_NULL);

Re: [PATCH v4 00/14] block: Try to create well-typed json:{} filenames

2019-11-21 Thread Markus Armbruster
Markus Armbruster writes: > Max Reitz writes: > >> On 13.09.19 13:49, Max Reitz wrote: >>> Another gentle ping. >> >> And another. > > Conflicts with the refactoring merged in commit 69717d0f890. Please > accept my apologies for the inconvenience caused by the excessive delay. > > I'll try to

[PULL 2/4] target/i386: add support for MSR_IA32_TSX_CTRL

2019-11-21 Thread Paolo Bonzini
The MSR_IA32_TSX_CTRL MSR can be used to hide TSX (also known as the Trusty Side-channel Extension). By virtualizing the MSR, KVM guests can disable TSX and avoid paying the price of mitigating TSX-based attacks on microarchitectural side channels. Reviewed-by: Eduardo Habkost Signed-off-by:

[PULL 3/4] i386: Add new versions of Skylake/Cascadelake/Icelake without TSX

2019-11-21 Thread Paolo Bonzini
From: Eduardo Habkost One of the mitigation methods for TAA[1] is to disable TSX support on the host system. Linux added a mechanism to disable TSX globally through the kernel command line, and many Linux distributions now default to tsx=off. This makes existing CPU models that have HLE and

[Bug 1848556] Re: qemu-img check failing on remote image in Eoan

2019-11-21 Thread Christian Ehrhardt 
This was tonight first accepted and then immediately rejected as it was surpassed by a security fix. => Rebased and uploaded 1:4.0+dfsg-0ubuntu9.2 to eoan-unapproved again. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[PATCH v2] ppc/pnv: Create BMC devices at machine init

2019-11-21 Thread Cédric Le Goater
The BMC of the OpenPOWER systems monitors the machine state using sensors, controls the power and controls the access to the PNOR flash device containing the firmware image required to boot the host. QEMU models the power cycle process, access to the sensors and access to the PNOR device. But,

Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion

2019-11-21 Thread Fangrui Song
On 2019-11-21, Markus Armbruster wrote: Richard Henderson writes: On 11/20/19 6:30 PM, Fangrui Song wrote: On 2019-11-20, Juan Quintela wrote: Markus Armbruster wrote: Fangrui Song writes: [...] diff --git a/util/cutils.c b/util/cutils.c index fd591cadf0..2b4484c015 100644 ---

Re: [PATCH] Fix incorrect int->float conversions caught by clang -Wimplicit-int-float-conversion

2019-11-21 Thread Eric Blake
On 11/19/19 2:49 PM, Fangrui Song wrote: Can we simply drop the offending line statement instead? Fixed in the new patch. The first val * mul above this range is 0x1p64.  Rejecting it is correct, because it overflows yint64_t. I am not subscribed, so apologize that this email may be

[PATCH 3/4] colo: Introduce high-level test

2019-11-21 Thread Lukas Straub
Add high-level test relying on the colo resource-agent to test all failover cases while checking guest network connectivity Signed-off-by: Lukas Straub --- scripts/colo-resource-agent/crm_master | 44 +++ tests/acceptance/colo.py | 444 + 2 files changed,

Re: [PATCH v6] Implement backend program convention command for vhost-user-blk

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/21/19 2:58 AM, Micky Yun Chan wrote: From: michan FYI your email setup is still incorrect. This patch is to add standard commands defined in docs/interop/vhost-user.rst For vhost-user-* program Signed-off-by: Micky Yun Chan (michiboo) ---

Re: [PATCH 1/4] block/quorum.c: stable children names

2019-11-21 Thread Lukas Straub
On Thu, 21 Nov 2019 12:04:58 -0600 Eric Blake wrote: > On 11/21/19 11:49 AM, Lukas Straub wrote: > > If we remove the child with the highest index from the quorum, > > decrement s->next_child_index. This way we get stable children > > names as long as we only remove the last child. > > > >

Re: [PATCH v35 01/13] target/avr: Add outward facing interfaces and core CPU logic

2019-11-21 Thread Philippe Mathieu-Daudé
Hi Michael, On 10/29/19 10:24 PM, Michael Rolnik wrote: This includes: - CPU data structures - object model classes and functions - migration functions - GDB hooks Co-developed-by: Michael Rolnik Co-developed-by: Sarah Harris Signed-off-by: Michael Rolnik Signed-off-by: Sarah Harris

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/21/19 9:19 AM, Helge Deller wrote: On 20.11.19 23:20, Aleksandar Markovic wrote: On Wed, Nov 20, 2019 at 10:13 PM Aleksandar Markovic wrote: On Wed, Nov 20, 2019 at 3:58 PM Helge Deller wrote: Improve strace output of various syscalls which either have none or only int-type

Re: [PATCH 4/5] spapr: Handle irq backend changes with VFIO PCI devices

2019-11-21 Thread Cédric Le Goater
On 21/11/2019 01:56, David Gibson wrote: > pseries machine type can have one of two different interrupt controllers in > use depending on feature negotiation with the guest. Usually this is > invisible to devices, because they route to a common set of qemu_irqs which > in turn dispatch to the

Re: [qemu-web PATCH] Add a blog post about the QEMU-related presentation of KVM Forum 2019

2019-11-21 Thread Thomas Huth
On 21/11/2019 17.04, Paolo Bonzini wrote: > On 21/11/19 14:59, Eric Blake wrote: >> On 11/21/19 5:52 AM, Thomas Huth wrote: >>> There have been quite a lot of QEMU-related talks at KVM Forum this >>> year - let's provide a summary for the people who could not attend. >>> >>> Signed-off-by: Thomas

Re: [PATCH] kvm: Reallocate dirty_bmap when we change a slot

2019-11-21 Thread Peter Xu
On Thu, Nov 21, 2019 at 04:56:45PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > kvm_set_phys_mem can be called to reallocate a slot by something the > guest does (e.g. writing to PAM and other chipset registers). > This can happen in the middle of a migration,

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/21/19 6:00 PM, Aleksandar Markovic wrote: On Thursday, November 21, 2019, Philippe Mathieu-Daudé mailto:phi...@redhat.com>> wrote: On 11/21/19 9:19 AM, Helge Deller wrote: On 20.11.19 23:20, Aleksandar Markovic wrote: On Wed, Nov 20, 2019 at 10:13 PM Aleksandar

[PATCH 2/4] colo: Introduce resource agent

2019-11-21 Thread Lukas Straub
Introduce a resource agent which can be used in a Pacemaker cluster to manage qemu COLO. Signed-off-by: Lukas Straub --- scripts/colo-resource-agent/colo | 1026 ++ 1 file changed, 1026 insertions(+) create mode 100755 scripts/colo-resource-agent/colo diff --git

[PATCH 0/4] colo: Introduce resource agent and high-level test

2019-11-21 Thread Lukas Straub
Hello Everyone, These patches introduce a resource agent for use with the Pacemaker CRM and a high-level test utilizing it for testing qemu COLO. The resource agent manages qemu COLO including continuous replication. Currently the second test case (where the peer qemu is frozen) fails on primary

[PATCH 4/4] MAINTAINERS: Add myself as maintainer for COLO resource agent

2019-11-21 Thread Lukas Straub
While I'm not going to have much time for this, I'll still try to test and review patches. Signed-off-by: Lukas Straub --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d6de200453..aad8356149 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

Re: [PATCH 1/4] block/quorum.c: stable children names

2019-11-21 Thread Eric Blake
On 11/21/19 11:49 AM, Lukas Straub wrote: If we remove the child with the highest index from the quorum, decrement s->next_child_index. This way we get stable children names as long as we only remove the last child. Signed-off-by: Lukas Straub --- block/quorum.c | 6 ++ 1 file changed,

Re: [PATCH v4 12/37] serial: start making SerialMM a sysbus device

2019-11-21 Thread Marc-André Lureau
Hi On Thu, Nov 21, 2019 at 10:24 PM Peter Maydell wrote: > > On Thu, 21 Nov 2019 at 18:15, Marc-André Lureau > wrote: > > > > On Thu, Nov 21, 2019 at 5:47 PM Peter Maydell > > wrote: > > > > > > On Wed, 20 Nov 2019 at 15:27, Marc-André Lureau > > > wrote: > > > > > > > > Memory mapped serial

Re: [PATCH] RISC-V: virt: This is a "sifive,test1" test finisher

2019-11-21 Thread Palmer Dabbelt
On Thu, 21 Nov 2019 10:55:32 PST (-0800), alistai...@gmail.com wrote: On Wed, Nov 20, 2019 at 6:40 PM Palmer Dabbelt wrote: On Sun, 10 Nov 2019 13:10:33 PST (-0800), da...@gibson.dropbear.id.au wrote: > On Fri, Nov 08, 2019 at 10:13:16AM -0800, Palmer Dabbelt wrote: >> On Fri, 08 Nov 2019

Re: [PATCH v2 2/6] block: truncate: Don't make backing file data visible

2019-11-21 Thread Max Reitz
On 21.11.19 15:33, Kevin Wolf wrote: > Am 21.11.2019 um 13:21 hat Max Reitz geschrieben: >> On 21.11.19 12:34, Kevin Wolf wrote: >>> Am 21.11.2019 um 09:59 hat Max Reitz geschrieben: On 20.11.19 19:44, Kevin Wolf wrote: > When extending the size of an image that has a backing file larger

Re: [Qemu-devel] [PATCH 0/2] hw/timer/m48t59: Convert to trace events

2019-11-21 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > ping? Did this fall through the cracks? > On 6/26/19 2:20 PM, Philippe Mathieu-Daudé wrote: >> Another trivial cleanup series. >> >> Philippe Mathieu-Daudé (2): >> MAINTAINERS: Add missing m48t59 files to the PReP section >> hw/timer/m48t59: Convert debug

[PULL 1/4] target/i386: add VMX features to named CPU models

2019-11-21 Thread Paolo Bonzini
This allows using "-cpu Haswell,+vmx", which we did not really want to support in QEMU but was produced by Libvirt when using the "host-model" CPU model. Without this patch, no VMX feature is _actually_ supported (only the basic instruction set extensions are) and KVM fails to load in the guest.

Re: [Qemu-devel] [PATCH v8 00/11] Measure Tiny Code Generation Quality

2019-11-21 Thread Markus Armbruster
vandersonmr writes: > This patch is part of Google Summer of Code (GSoC) 2019. > More about the project can be found in: > https://wiki.qemu.org/Internships/ProjectIdeas/TCGCodeQuality > > The goal of this patch is to add infrastructure to collect > execution and JIT statistics during the

Re: [PATCH] ppc/pnv: Create BMC devices at machine init

2019-11-21 Thread Cédric Le Goater
On 21/11/2019 16:36, Corey Minyard wrote: > On Mon, Nov 18, 2019 at 10:22:22AM +0100, Cédric Le Goater wrote: >> The BMC of the OpenPOWER systems monitors the machine state using >> sensors, controls the power and controls the access to the PNOR flash >> device containing the firmware image

Re: [PULL 0/4] x86 updates for QEMU 4.2-rc

2019-11-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1574350609-29518-1-git-send-email-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 0/4] x86 updates for QEMU 4.2-rc Type: series Message-id:

Re: [PATCH 0/5] vfio/spapr: Handle changes of master irq chip for VFIO devices

2019-11-21 Thread Alex Williamson
On Thu, 21 Nov 2019 11:56:02 +1100 David Gibson wrote: > Due to the way feature negotiation works in PAPR (which is a > paravirtualized platform), we can end up changing the global irq chip > at runtime, including it's KVM accelerate model. That causes > complications for VFIO devices with

Re: [PULL 0/3] Fixes 20191121 patches

2019-11-21 Thread Peter Maydell
axel.org/qemu tags/fixes-20191121-pull-request > > for you to fetch changes up to c55c974486b0dadf97fe47e2e789d5dba9b77138: > > ui/gtk: fix gettext message's charset. (2019-11-21 09:42:30 +0100) > >

Re: [PATCH v4 12/37] serial: start making SerialMM a sysbus device

2019-11-21 Thread Peter Maydell
On Thu, 21 Nov 2019 at 18:15, Marc-André Lureau wrote: > > On Thu, Nov 21, 2019 at 5:47 PM Peter Maydell > wrote: > > > > On Wed, 20 Nov 2019 at 15:27, Marc-André Lureau > > wrote: > > > > > > Memory mapped serial device is in fact a sysbus device. The following > > > patches will make use of

Re: [PULL 0/4] x86 updates for QEMU 4.2-rc

2019-11-21 Thread Peter Maydell
On Thu, 21 Nov 2019 at 15:39, Paolo Bonzini wrote: > > The following changes since commit 39e2821077e6dcf788b7c2a9ef50970ec7995437: > > Update version for v4.2.0-rc2 release (2019-11-19 19:34:10 +) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Aleksandar Markovic
> > Ahah very easy indeed :) Not noticing it shows how busy I am with > > firmware world than I forgot linux-user can be a simpler/powerful > > way to easily test stuff, as the Hexagon recent port also demonstrated. > > > > > > Hexagon port doesn't have anything to do with this patch

Re: [PATCH v1 1/1] hw/arm: versal: Add the CRP as unimplemented

2019-11-21 Thread Edgar E. Iglesias
Hi Peter, Can we consider this patch for 4.2? Thanks, Edgar On Fri, Nov 15, 2019 at 04:47:34PM +0100, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Add the CRP as unimplemented thus avoiding bus errors when > guests access these registers. > > Signed-off-by: Edgar E. Iglesias >

Re: [PATCH v2] linux-user/strace: Add missing signal strings

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/20/19 3:55 PM, Helge Deller wrote: Add the textual representations of some missing target signals. Signed-off-by: Helge Deller diff --git a/linux-user/strace.c b/linux-user/strace.c index 3d4d684450..de43238fa4 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -146,6 +146,19

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Aleksandar Markovic
ū On Thursday, November 21, 2019, Philippe Mathieu-Daudé wrote: > On 11/21/19 9:19 AM, Helge Deller wrote: > >> On 20.11.19 23:20, Aleksandar Markovic wrote: >> >>> On Wed, Nov 20, 2019 at 10:13 PM Aleksandar Markovic >>> wrote: >>> On Wed, Nov 20, 2019 at 3:58 PM Helge Deller

Re: [PATCH v2] ppc/pnv: Create BMC devices at machine init

2019-11-21 Thread Corey Minyard
On Thu, Nov 21, 2019 at 05:23:40PM +0100, Cédric Le Goater wrote: > The BMC of the OpenPOWER systems monitors the machine state using > sensors, controls the power and controls the access to the PNOR flash > device containing the firmware image required to boot the host. > > QEMU models the power

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Aleksandar Markovic
On Thursday, November 21, 2019, Philippe Mathieu-Daudé wrote: > On 11/21/19 6:00 PM, Aleksandar Markovic wrote: > >> On Thursday, November 21, 2019, Philippe Mathieu-Daudé > > wrote: >> >> On 11/21/19 9:19 AM, Helge Deller wrote: >> >> On 20.11.19 23:20,

Re: [PATCH-for-4.2?] vmstate-static-checker: Fix for current python

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/21/19 7:53 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Python 3.7.5 on f31 doesn't seem to like the old type=file syntax on argparse. Looks 4.2 worth to me. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Dr. David Alan Gilbert ---

Re: [PATCH] RISC-V: virt: This is a "sifive,test1" test finisher

2019-11-21 Thread Alistair Francis
On Wed, Nov 20, 2019 at 6:40 PM Palmer Dabbelt wrote: > > On Sun, 10 Nov 2019 13:10:33 PST (-0800), da...@gibson.dropbear.id.au wrote: > > On Fri, Nov 08, 2019 at 10:13:16AM -0800, Palmer Dabbelt wrote: > >> On Fri, 08 Nov 2019 10:04:47 PST (-0800), Peter Maydell wrote: > >> > On Fri, 8 Nov 2019

Re: [PATCH v1 1/1] hw/arm: versal: Add the CRP as unimplemented

2019-11-21 Thread Peter Maydell
On Thu, 21 Nov 2019 at 15:28, Edgar E. Iglesias wrote: > > Hi Peter, > > Can we consider this patch for 4.2? Sure, it looks pretty safe. I've applied it to my queue for rc3. thanks -- PMM

Re: [PATCH 5/5] spapr: Work around spurious warnings from vfio INTx initialization

2019-11-21 Thread Cédric Le Goater
On 21/11/2019 01:56, David Gibson wrote: > Traditional PCI INTx for vfio devices can only perform well if using > an in-kernel irqchip. Therefore, vfio_intx_update() issues a warning > if an in kernel irqchip is not available. > > We usually do have an in-kernel irqchip available for pseries

Re: [PATCH v2] linux-user/strace: Improve output of various syscalls

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/21/19 6:35 PM, Aleksandar Markovic wrote: On Thursday, November 21, 2019, Philippe Mathieu-Daudé mailto:phi...@redhat.com>> wrote: On 11/21/19 6:00 PM, Aleksandar Markovic wrote: On Thursday, November 21, 2019, Philippe Mathieu-Daudé mailto:phi...@redhat.com>

Re: [PATCH v2] linux-user/strace: Add missing signal strings

2019-11-21 Thread Aleksandar Markovic
On Thu, Nov 21, 2019 at 6:27 PM Laurent Vivier wrote: > > Le 20/11/2019 à 15:55, Helge Deller a écrit : > > Add the textual representations of some missing target signals. > > > > Signed-off-by: Helge Deller > > > > diff --git a/linux-user/strace.c b/linux-user/strace.c > > index

[PATCH] vmstate-static-checker: Fix for current python

2019-11-21 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Python 3.7.5 on f31 doesn't seem to like the old type=file syntax on argparse. Signed-off-by: Dr. David Alan Gilbert --- scripts/vmstate-static-checker.py | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/vmstate-static-checker.py

[PULL 0/4] x86 updates for QEMU 4.2-rc

2019-11-21 Thread Paolo Bonzini
The following changes since commit 39e2821077e6dcf788b7c2a9ef50970ec7995437: Update version for v4.2.0-rc2 release (2019-11-19 19:34:10 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to

Re: [qemu-web PATCH] Add a blog post about the QEMU-related presentation of KVM Forum 2019

2019-11-21 Thread Paolo Bonzini
On 21/11/19 14:59, Eric Blake wrote: > On 11/21/19 5:52 AM, Thomas Huth wrote: >> There have been quite a lot of QEMU-related talks at KVM Forum this >> year - let's provide a summary for the people who could not attend. >> >> Signed-off-by: Thomas Huth >> --- >>   Note: For some talks it's hard

Re: [Qemu-devel] [PATCH 0/2] hw/timer/m48t59: Convert to trace events

2019-11-21 Thread Philippe Mathieu-Daudé
On 11/21/19 4:28 PM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: ping? Did this fall through the cracks? Certainly =) Thanks for noticing. This now need a (trivial) rebase. I'll respin for 5.0. On 6/26/19 2:20 PM, Philippe Mathieu-Daudé wrote: Another trivial cleanup

[PATCH] kvm: Reallocate dirty_bmap when we change a slot

2019-11-21 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" kvm_set_phys_mem can be called to reallocate a slot by something the guest does (e.g. writing to PAM and other chipset registers). This can happen in the middle of a migration, and if we're unlucky it can now happen between the split 'sync' and 'clear'; the clear

Re: [PATCH v2] linux-user/strace: Add missing signal strings

2019-11-21 Thread Laurent Vivier
Le 20/11/2019 à 15:55, Helge Deller a écrit : > Add the textual representations of some missing target signals. > > Signed-off-by: Helge Deller > > diff --git a/linux-user/strace.c b/linux-user/strace.c > index 3d4d684450..de43238fa4 100644 > --- a/linux-user/strace.c > +++

[PATCH 1/4] block/quorum.c: stable children names

2019-11-21 Thread Lukas Straub
If we remove the child with the highest index from the quorum, decrement s->next_child_index. This way we get stable children names as long as we only remove the last child. Signed-off-by: Lukas Straub --- block/quorum.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/quorum.c

Re: [PATCH] ppc/pnv: Create BMC devices at machine init

2019-11-21 Thread Corey Minyard
On Wed, Nov 20, 2019 at 09:05:07AM +1100, David Gibson wrote: > On Tue, Nov 19, 2019 at 07:49:33AM +0100, Cédric Le Goater wrote: > > On 19/11/2019 01:52, David Gibson wrote: > > > On Mon, Nov 18, 2019 at 10:22:22AM +0100, Cédric Le Goater wrote: > > >> The BMC of the OpenPOWER systems monitors

<    1   2   3   >