Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-11-26 Thread David Hildenbrand
> Am 26.11.2019 um 08:54 schrieb Christian Borntraeger : > >  > >> On 25.11.19 18:20, David Hildenbrand wrote: >> >> As soon as dynamic feature groups are used, the CPU model becomes >> migration-unsafe. Upper layers can expand these models to migration-safe >> and static variants, allowing

Re: [PATCH 4/4] qom/object: Use common get/set uint helpers

2019-11-26 Thread Marc-André Lureau
Hi On Mon, Nov 25, 2019 at 7:37 PM Felipe Franciosi wrote: > > Several objects implemented their own uint property getters and setters, > despite them being straightforward (without any checks/validations on > the values themselves) and identical across objects. This makes use of > an enhanced

Re: virtiofsd: Where should it live?

2019-11-26 Thread Marc-André Lureau
Hi David On Mon, Nov 25, 2019 at 10:50 PM Dr. David Alan Gilbert wrote: > > Hi, > There's been quite a bit of discussion about where virtiofsd, our > implemenation of a virtiofs daemon, should live. I'd like to get > this settled now, because I'd like to tidy it up for the next > qemu cycle.

[RFC net-next 13/18] virtio_net: use XDP attachment helpers

2019-11-26 Thread Prashant Bhole
Next patches will introduce virtio_net XDP offloading. In that case we need to manage offloaded and non-offload program. In order to make it consistent this patch introduces use of XDP attachment helpers. Signed-off-by: Prashant Bhole --- drivers/net/virtio_net.c | 30

Re: [PATCH 1/4] qom/object: enable setter for uint types

2019-11-26 Thread Marc-André Lureau
Hi On Mon, Nov 25, 2019 at 7:40 PM Felipe Franciosi wrote: > > Traditionally, the uint-specific property helpers only offer getters. > When adding object (or class) uint types, one must therefore use the > generic property helper if a setter is needed. > > This enhances the uint-specific

Re: [PATCH 2/4] ich9: fix getter type for sci_int property

2019-11-26 Thread Marc-André Lureau
On Mon, Nov 25, 2019 at 7:37 PM Felipe Franciosi wrote: > > When QOM APIs were added to ich9 in 6f1426ab, the getter for sci_int was > written using uint32_t. However, the object property is uint8_t. This > fixes the getter for correctness. > > Signed-off-by: Felipe Franciosi Good catch! (I

Re: [PATCH 3/4] ich9: Simplify ich9_lpc_initfn

2019-11-26 Thread Marc-André Lureau
On Mon, Nov 25, 2019 at 7:37 PM Felipe Franciosi wrote: > > Currently, ich9_lpc_initfn simply serves as a caller to > ich9_lpc_add_properties. This simplifies the code a bit by eliminating > ich9_lpc_add_properties altogether and executing its logic in the parent > object initialiser function. >

[PULL 5/5] hvf: more accurately match SDM when setting CR0 and PDPTE registers

2019-11-26 Thread Paolo Bonzini
From: Cameron Esfahani More accurately match SDM when setting CR0 and PDPTE registers. Clear PDPTE registers when resetting vcpus. Signed-off-by: Cameron Esfahani Message-Id: <464adb39c8699fb8331d8ad6016fc3e2eff53dbc.1574625592.git.di...@apple.com> Signed-off-by: Paolo Bonzini ---

[PULL 2/5] hvf: non-RAM, non-ROMD memory ranges are now correctly mapped in

2019-11-26 Thread Paolo Bonzini
From: Cameron Esfahani If an area is non-RAM and non-ROMD, then remove mappings so accesses will trap and can be emulated. Change hvf_find_overlap_slot() to take a size instead of an end address: it wouldn't return a slot because callers would pass the same address for start and end. Don't

[PULL 0/5] i386 patches for QEMU 4.2-rc

2019-11-26 Thread Paolo Bonzini
The following changes since commit 65e05c82bdc6d348155e301c9d87dba7a08a5701: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2019-11-25 15:47:44 +) are available in the Git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch

[RFC net-next 16/18] bpf: export function __bpf_map_get

2019-11-26 Thread Prashant Bhole
From: Jason Wang __bpf_map_get is necessary to get verify whether an fd corresponds to a bpf map, without adding a refcount on that map. After exporting it can be used by a kernel module. Signed-off-by: Jason Wang Signed-off-by: Prashant Bhole --- kernel/bpf/syscall.c | 1 + 1 file changed,

Re: virtiofsd: Where should it live?

2019-11-26 Thread Daniel P . Berrangé
On Mon, Nov 25, 2019 at 06:50:21PM +, Dr. David Alan Gilbert wrote: > Hi, > There's been quite a bit of discussion about where virtiofsd, our > implemenation of a virtiofs daemon, should live. I'd like to get > this settled now, because I'd like to tidy it up for the next > qemu cycle. > >

Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

2019-11-26 Thread Daniel P . Berrangé
On Tue, Nov 26, 2019 at 11:04:41AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, Nov 25, 2019 at 08:20:23AM +0100, Markus Armbruster wrote: > >> Tao Xu writes: > >> > >> > Add do_strtomul() to convert string according to different suffixes. > >> > > >> > Reviewed-by:

Re: [PATCH for-5.0 v4 0/5] iotests: Test failing mirror complete

2019-11-26 Thread Max Reitz
On 08.11.19 13:34, Max Reitz wrote: > Hi, > > v3 of this series was this: > > https://lists.nongnu.org/archive/html/qemu-block/2019-10/msg00868.html > > In the meantime, I’ve merged the first patch, so the subject of the > series has changed. > > In v4, I’ve tried to address Vladimir’s concern

Re: API definition for LUKS key management [V2]

2019-11-26 Thread Maxim Levitsky
On Mon, 2019-11-25 at 19:45 +0100, Max Reitz wrote: > On 22.11.19 15:22, Maxim Levitsky wrote: > > Hi! > > > > This is the second version of the proposed QMP API for key management, > > after discussion with Keven and Max. > > > > Will this work? > > > > Adding Peter Krempa to CC, to hear his

[RFC net-next 11/18] tun: run xdp prog when tun is read from file interface

2019-11-26 Thread Prashant Bhole
It handles the case when qemu performs read on tun using file operations. Signed-off-by: Prashant Bhole --- drivers/net/tun.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 084ca95358fe..639921c10e32 100644 --- a/drivers/net/tun.c

[RFC 3/3] virtio-net: add support for offloading an ebpf map

2019-11-26 Thread Prashant Bhole
From: Jason Wang This change is a part of XDP offload feature. It handles offloading of eBPF map from the guest. A command handler for VIRTIO_NET_CTRL_EBPF now checks for subcommand VIRTIO_NET_CTRL_EBPF_MAP and. The control buffer consists of struct virtio_net_ctrl_ebpf_map followed by map

Re: [PATCH] target/arm: Honor HCR_EL2.TID3 trapping requirements

2019-11-26 Thread Richard Henderson
On 11/23/19 11:56 AM, Marc Zyngier wrote: > +static CPAccessResult access_aa64idreg(CPUARMState *env, const ARMCPRegInfo > *ri, > + bool isread) > +{ > +if ((arm_current_el(env) < 2) && (arm_hcr_el2_eff(env) & HCR_TID3)) { > +return

[RFC net-next 12/18] virtio-net: store xdp_prog in device

2019-11-26 Thread Prashant Bhole
From: Jason Wang This is a preparation for adding XDP offload support in virtio_net driver. By storing XDP program in virtionet_info will make it consistent with the offloaded program which will introduce in next patches. Signed-off-by: Jason Wang Co-developed-by: Prashant Bhole

[RFC net-next 14/18] virtio_net: add XDP prog offload infrastructure

2019-11-26 Thread Prashant Bhole
From: Jason Wang This patch prepares virtio_net of XDP offloading. It adds data structures, blank callback implementations for bpf_prog_offload_ops. It also implements ndo_init, ndo_uninit operations for setting up offload related data structures. Signed-off-by: Jason Wang Co-developed-by:

Re: [PATCH v17 02/14] util/cutils: Use qemu_strtold_finite to parse size

2019-11-26 Thread Tao Xu
On 11/25/2019 2:56 PM, Markus Armbruster wrote: Tao Xu writes: Support full 64bit precision, modify related test cases. That's not true in general: long double need not be any wider than double. It might be true on the host machines we support, but I don't know. If we decide to rely on

Re: [PATCH v2 15/20] nvme: add support for scatter gather lists

2019-11-26 Thread Klaus Birkelund
On Mon, Nov 25, 2019 at 02:10:37PM +, Beata Michalska wrote: > On Mon, 25 Nov 2019 at 06:21, Klaus Birkelund wrote: > > > > On Tue, Nov 12, 2019 at 03:25:18PM +, Beata Michalska wrote: > > > Hi Klaus, > > > > > > On Tue, 15 Oct 2019 at 11:57, Klaus Jensen wrote: > > > > > > > > +#define

[PULL 4/5] hvf: correctly handle REX prefix in relation to legacy prefixes

2019-11-26 Thread Paolo Bonzini
From: Cameron Esfahani In real x86 processors, the REX prefix must come after legacy prefixes. REX before legacy is ignored. Update the HVF emulation code to properly handle this. Fix some spelling errors in constants. Fix some decoder table initialization issues found by Coverity.

Re: [PATCH] throttle-groups: fix memory leak in throttle_group_set_limits

2019-11-26 Thread Alberto Garcia
On Tue 26 Nov 2019 09:17:02 AM CET, pannengy...@huawei.com wrote: > --- a/block/throttle-groups.c > +++ b/block/throttle-groups.c > @@ -912,6 +912,7 @@ static void throttle_group_set_limits(Object *obj, > Visitor *v, > unlock: > qemu_mutex_unlock(>lock); > ret: > +

[RFC net-next 05/18] vhost_net: user tap recvmsg api to access ptr ring

2019-11-26 Thread Prashant Bhole
Currently vhost_net directly accesses ptr ring of tap driver to fetch Rx packet pointers. In order to avoid it this patch modifies tap driver's recvmsg api to do additional task of fetching Rx packet pointers. A special struct tun_msg_ctl is already being passed via msg_control for tun Rx XDP

Re: [PATCH 0/5] ARM virt: Add NVDIMM support

2019-11-26 Thread Andrew Jones
On Tue, Nov 26, 2019 at 09:56:55AM +0100, Igor Mammedov wrote: > On Mon, 25 Nov 2019 16:25:54 + > Shameerali Kolothum Thodi wrote: > > > -Name (MEMA, 0xBFBFD000) > > > +Name (MEMA, 0x) > > > > > > However value here is suspicious. If I recall right it should > > > point to

[RFC 1/3] configure: add libbpf support

2019-11-26 Thread Prashant Bhole
This is a preparation to add libbpf support for Qemu. When it is enabled Qemu can load eBPF programs and manipulated eBPF maps libbpf APIs. When configured with --enable-libbpf, availability of libbpf is checked. If it exists then CONFIG_LIBBPF is defined and the qemu binary is linked with

[RFC net-next 04/18] tuntap: check tun_msg_ctl type at necessary places

2019-11-26 Thread Prashant Bhole
tun_msg_ctl is used by vhost_net to communicate with tuntap. We will introduce another type in soon. As a preparation this patch adds conditions to check tun_msg_ctl type at necessary places. Signed-off-by: Prashant Bhole --- drivers/net/tap.c | 7 +-- drivers/net/tun.c | 6 +- 2 files

Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

2019-11-26 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Nov 25, 2019 at 08:20:23AM +0100, Markus Armbruster wrote: >> Tao Xu writes: >> >> > Add do_strtomul() to convert string according to different suffixes. >> > >> > Reviewed-by: Eduardo Habkost >> > Signed-off-by: Tao Xu >> >> What's the actual change here?

[RFC net-next 00/18] virtio_net XDP offload

2019-11-26 Thread Prashant Bhole
Note: This RFC has been sent to netdev as well as qemu-devel lists This series introduces XDP offloading from virtio_net. It is based on the following work by Jason Wang: https://netdevconf.info/0x13/session.html?xdp-offload-with-virtio-net Current XDP performance in virtio-net is far from what

Re: [PATCH for-4.2 0/2] Fix bitmap migration

2019-11-26 Thread Max Reitz
On 25.11.19 13:52, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > We've faced a bug in rhev-2.12.0-33.el7-based Qemu. > In upstream, bug introduced in 4.0 by 74da6b943565c45 > "block/dirty-bitmaps: implement inconsistent bit" commit. > At this commit we started to load inconsistent bitmap

Re: [QUESTION] What is the best license option for new files introduced in QEMU?

2019-11-26 Thread Markus Armbruster
Aleksandar Markovic writes: > I read LICENSE file, but I read also recent contributions, and it is > not clear to me what version of GPL is best/recommended for new file > just being introduced to QEMU: The situation is confusing. It's a mess of our own making. > * GPL 2.0 > * GPL 2.0 (or

[RFC 2/3] virtio-net: add support for offloading XDP program

2019-11-26 Thread Prashant Bhole
From: Jason Wang This feature involves offloading of XDP program and ebpf map from the guest to the host. This patch takes care of offloadin of program. A handler for VIRTIO_NET_CTRL_EBPF command is added in virtio-net. The control buffer consist of struct virtio_net_ctrl_ebpf_prog and followed

[RFC net-next 17/18] virtio_net: implment XDP map offload functionality

2019-11-26 Thread Prashant Bhole
From: Jason Wang This patch implements: * Handling of BPF_OFFLOAD_MAP_ALLOC, BPF_OFFLOAD_MAP_FREE: Allocate driver specific map data structure. Set up struct virtio_net_ctrl_ebpf_map and send the control buffer to Qemu with class VIRTIO_NET_CTRL_EBPF, cmd VIRTIO_NET_CTRL_EBPF_MAP. The cmd

[RFC net-next 10/18] tun: handle XDP_TX action of offloaded program

2019-11-26 Thread Prashant Bhole
When offloaded program returns XDP_TX, we need to inject the packet in Rx path of tun. This patch injects such packets in Rx path using tun_xdp_one. Signed-off-by: Prashant Bhole --- drivers/net/tun.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/tun.c

[PATCH] MAINTAINERS: Update Yuval Shaia's email address

2019-11-26 Thread Yuval Shaia
Use gmail account for maintainer tasks. Signed-off-by: Yuval Shaia --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5e5e3e52d6..4297b54fcb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2640,7 +2640,7 @@ F:

[RFC net-next 08/18] tun: run offloaded XDP program in Tx path

2019-11-26 Thread Prashant Bhole
run offloaded XDP program as soon as packet is removed from the ptr ring. Since this is XDP in Tx path, the traditional handling of XDP actions XDP_TX/REDIRECT isn't valid. For this reason we call do_xdp_generic_core instead of do_xdp_generic. do_xdp_generic_core just runs the program and leaves

[RFC net-next 09/18] tun: add a way to inject Tx path packet into Rx path

2019-11-26 Thread Prashant Bhole
In order to support XDP_TX from offloaded XDP program, we need a way to inject Tx path packet into Rx path. Let's modify the Rx path function tun_xdp_one() for this purpose. This patch adds a parameter to pass information whether packet has virtio_net header. When header isn't present, it is

Re: [PATCH v2 12/20] nvme: bump supported specification version to 1.3

2019-11-26 Thread Klaus Birkelund
On Mon, Nov 25, 2019 at 12:13:15PM +, Beata Michalska wrote: > On Mon, 18 Nov 2019 at 09:48, Klaus Birkelund wrote: > > > > On Tue, Nov 12, 2019 at 03:05:06PM +, Beata Michalska wrote: > > > Hi Klaus, > > > > > > On Tue, 15 Oct 2019 at 11:52, Klaus Jensen wrote: > > > > > > > > +static

[PULL 3/5] hvf: remove TSC synchronization code because it isn't fully complete

2019-11-26 Thread Paolo Bonzini
From: Cameron Esfahani The existing code in QEMU's HVF support to attempt to synchronize TSC across multiple cores is not sufficient. TSC value on other cores can go backwards. Until implementation is fixed, remove calls to hv_vm_sync_tsc(). Pass through TSC to guest OS. Signed-off-by:

[PULL 1/5] target/i386: add two missing VMX features for Skylake and CascadeLake Server

2019-11-26 Thread Paolo Bonzini
They are present in client (Core) Skylake but pasted wrong into the server SKUs. Reported-by: Dr. David Alan Gilbert Signed-off-by: Paolo Bonzini --- target/i386/cpu.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index

Re: [PULL 0/5] i386 patches for QEMU 4.2-rc

2019-11-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191126085936.1689-1-pbonz...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH 2/4] ich9: fix getter type for sci_int property

2019-11-26 Thread Felipe Franciosi
Hi > On Nov 25, 2019, at 4:43 PM, Philippe Mathieu-Daudé wrote: > > On 11/25/19 4:36 PM, Felipe Franciosi wrote: >> When QOM APIs were added to ich9 in 6f1426ab, the getter for sci_int was >> written using uint32_t. However, the object property is uint8_t. This >> fixes the getter for

[RFC net-next 07/18] tun: set offloaded xdp program

2019-11-26 Thread Prashant Bhole
From: Jason Wang This patch introduces an ioctl way to set an offloaded XDP program to tun driver. This ioctl will be used by qemu to offload XDP program from virtio_net in the guest. Signed-off-by: Jason Wang Signed-off-by: Prashant Bhole --- drivers/net/tun.c | 19

Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

2019-11-26 Thread Markus Armbruster
Tao Xu writes: > Add do_strtomul() to convert string according to different suffixes. > > Reviewed-by: Eduardo Habkost > Signed-off-by: Tao Xu > --- > > No changes in v17. > > Changes in v15: > - Add a new patch to refactor do_strtosz() (Eduardo) > --- > util/cutils.c | 72

Re: [RFC 0/3] Qemu: virtio-net XDP offload

2019-11-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191126100914.5150-1-prashantbhole.li...@gmail.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST

Re: [EXTERNAL]Re: [PATCH v2 2/5] MAINTAINERS: Adjust maintainership for Fulong 2E board

2019-11-26 Thread BALATON Zoltan
On Mon, 25 Nov 2019, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 11/14/19 2:50 PM, Philippe Mathieu-Daudé wrote: --- But let's wait to see what Huacai Chen thinks of it, before posting it. Aleksandar, can you stay as co-maintainer? The patch would be: -- 8< --    Fulong 2E +M: Philippe

Re: [PATCH] linux-user: Improve strace output for read() and getcwd()

2019-11-26 Thread Laurent Vivier
Le 25/11/2019 à 21:54, Aleksandar Markovic a écrit : >>> 4. NEW PROPOSAL : >>> >>> early: read(3,0xff80038c,512) >>> late: = 512 >>> [(3,"\177ELF\1\2\1\3\0\0\0\0\0\0\0\0\0\3\0\17\0\0\0\1\0\2bl\0\0\04"...,512)] >>> early: getcwd(0x18180,4096) >>> late: = 9 [("/usr/bin",4096)] >>> >>> In other

Re: [PATCH 0/5] ARM virt: Add NVDIMM support

2019-11-26 Thread Igor Mammedov
On Mon, 25 Nov 2019 16:25:54 + Shameerali Kolothum Thodi wrote: > Hi Igor, > > > -Original Message- > > From: Igor Mammedov [mailto:imamm...@redhat.com] > > Sent: 25 November 2019 15:46 > > To: Shameerali Kolothum Thodi > > Cc: Auger Eric ; qemu-devel@nongnu.org; > >

Re: [PATCH 4/4] qom/object: Use common get/set uint helpers

2019-11-26 Thread Felipe Franciosi
> On Nov 26, 2019, at 8:39 AM, Marc-André Lureau > wrote: > > Hi Heya, thanks for the review. > > On Mon, Nov 25, 2019 at 7:37 PM Felipe Franciosi wrote: >> >> Several objects implemented their own uint property getters and setters, >> despite them being straightforward (without any

[RFC net-next 15/18] virtio_net: implement XDP prog offload functionality

2019-11-26 Thread Prashant Bhole
From: Jason Wang This patch implements bpf_prog_offload_ops callbacks and adds handling for XDP_SETUP_PROG_HW. Handling of XDP_SETUP_PROG_HW involves setting up struct virtio_net_ctrl_ebpf_prog and appending program instructions to it. This control buffer is sent to Qemu with class

[RFC 0/3] Qemu: virtio-net XDP offload

2019-11-26 Thread Prashant Bhole
Note: This RFC has been sent to netdev as well as qemu-devel lists This patchset implements XDP offload feature in qemu. The successful operation of this feature depends on availability of XDP offload feature in guest, qemu and host. When this feature isn't available in qemu or host, the request

[RFC net-next 02/18] net: core: rename netif_receive_generic_xdp() to do_generic_xdp_core()

2019-11-26 Thread Prashant Bhole
From: Jason Wang In skb generic path, we need a way to run XDP program on skb but to have customized handling of XDP actions. netif_receive_generic_xdp will be more helpful in such cases than do_xdp_generic. This patch prepares netif_receive_generic_xdp() to be used as general purpose function

[RFC net-next 06/18] tuntap: remove usage of ptr ring in vhost_net

2019-11-26 Thread Prashant Bhole
Remove usage of ptr ring of tuntap in vhost_net and remove the functions exported from tuntap drivers to get ptr ring. Signed-off-by: Prashant Bhole --- drivers/net/tap.c | 13 - drivers/net/tun.c | 13 - drivers/vhost/net.c| 31

Re: [PATCH] fence: introduce a file-based self-fence mechanism

2019-11-26 Thread Marc-André Lureau
On Mon, Nov 25, 2019 at 8:14 PM Felipe Franciosi wrote: > > This introduces a self-fence mechanism to Qemu, causing it to die if a > heartbeat condition is not met. Currently, a file-based heartbeat is > available and can be configured as follows: > > -object

[PATCH] throttle-groups: fix memory leak in throttle_group_set_limits

2019-11-26 Thread pannengyuan
From: PanNengyuan This avoid a memory leak when qom-set is called to set throttle_group limits, here is an easy way to reproduce: 1. run qemu-iotests as follow and check the result with asan: ./check -qcow2 184 Following is the asan output backtrack: Direct leak of 912 byte(s) in 3

Re: [PATCH v17 02/14] util/cutils: Use qemu_strtold_finite to parse size

2019-11-26 Thread Markus Armbruster
Tao Xu writes: > On 11/25/2019 2:56 PM, Markus Armbruster wrote: >> Tao Xu writes: >> >>> Support full 64bit precision, modify related test cases. >> >> That's not true in general: long double need not be any wider than >> double. >> >> It might be true on the host machines we support, but I

[RFC net-next 18/18] virtio_net: restrict bpf helper calls from offloaded program

2019-11-26 Thread Prashant Bhole
Since we are offloading this program to the host, some of the helper calls will not make sense. For example get_numa_node_id. Some helpers can not be used because we don't handle them yet. So let's allow a small set of helper calls for now. Signed-off-by: Prashant Bhole ---

[RFC net-next 03/18] net: core: export do_xdp_generic_core()

2019-11-26 Thread Prashant Bhole
From: Jason Wang Let's export do_xdp_generic as a general purpose function. It will just run XDP program on skb but will not handle XDP actions. Signed-off-by: Jason Wang Signed-off-by: Prashant Bhole --- include/linux/netdevice.h | 2 ++ net/core/dev.c| 6 +++--- 2 files

[RFC net-next 01/18] bpf: introduce bpf_prog_offload_verifier_setup()

2019-11-26 Thread Prashant Bhole
From: Jason Wang Background: This change was initiated from virtio_net XDP offload work. As per the implementation plan, a copy of original program with map fds from guest replaced with map fds from host needs to be offloaded to the host. To implement this fd replacement, insn_hook() must

Re: [RFC 0/3] Qemu: virtio-net XDP offload

2019-11-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191126100914.5150-1-prashantbhole.li...@gmail.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

2019-11-26 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Nov 26, 2019 at 11:04:41AM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Mon, Nov 25, 2019 at 08:20:23AM +0100, Markus Armbruster wrote: >> >> Tao Xu writes: >> >> >> >> > Add do_strtomul() to convert string according to different

Re: [PULL 0/4] Net patches

2019-11-26 Thread Peter Maydell
On Mon, 25 Nov 2019 at 15:40, Jason Wang wrote: > > The following changes since commit 122e6d2a9c1bf8aa1d51409c15809a82621515b1: > > Merge remote-tracking branch 'remotes/gkurz/tags/9p-fix-2019-11-23' into > staging (2019-11-25 13:39:45 +) > > are available in the git repository at: > >

[RFC 07/10] R300 fixes

2019-11-26 Thread aaron . zakhrov
From: Aaron Dominick --- hw/display/r300.c | 9 + hw/display/r300.h | 6 ++ 2 files changed, 15 insertions(+) diff --git a/hw/display/r300.c b/hw/display/r300.c index 653474c3aa..074dbf5b2d 100644 --- a/hw/display/r300.c +++ b/hw/display/r300.c @@ -878,6 +878,15 @@ static void

[PULL 0/2] Block patches for 4.2.0-rc3

2019-11-26 Thread Max Reitz
The following changes since commit 4ecc984210ca1bf508a96a550ec8a93a5f833f6c: Merge remote-tracking branch 'remotes/palmer/tags/riscv-for-master-4.2-rc3' into staging (2019-11-26 12:36:40 +) are available in the Git repository at: https://github.com/XanClic/qemu.git

Re: [PATCH] blockjob: Fix error message for negative speed

2019-11-26 Thread Alberto Garcia
On Tue 26 Nov 2019 02:42:22 PM CET, Kevin Wolf wrote: > The error message for a negative speed uses QERR_INVALID_PARAMETER, > which implies that the 'speed' option doesn't even exist: > > {"error": {"class": "GenericError", "desc": "Invalid parameter 'speed'"}} > > Make it use

[PULL for 4.2 0/3] a few vm-test fixes

2019-11-26 Thread Alex Bennée
The following changes since commit 65e05c82bdc6d348155e301c9d87dba7a08a5701: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2019-11-25 15:47:44 +) are available in the Git repository at: https://github.com/stsquad/qemu.git tags/pull-rc3-testing-261119-1 for

[PULL 2/3] tests/vm/ubuntu: include language pack to silence locale warnings

2019-11-26 Thread Alex Bennée
The iotests in particular don't like the output being spammed with warnings about locales. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé diff --git a/tests/vm/ubuntu.i386 b/tests/vm/ubuntu.i386 index 38f740eabf7..18b1ea2b72c 100755 --- a/tests/vm/ubuntu.i386 +++

Re: [PATCH 1/4] qom/object: enable setter for uint types

2019-11-26 Thread Felipe Franciosi
Heya > On Nov 26, 2019, at 8:40 AM, Marc-André Lureau > wrote: > > Hi > > On Mon, Nov 25, 2019 at 7:40 PM Felipe Franciosi wrote: >> >> Traditionally, the uint-specific property helpers only offer getters. >> When adding object (or class) uint types, one must therefore use the >> generic

Re: virtiofsd: Where should it live?

2019-11-26 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Nov 25, 2019 at 06:50:21PM +, Dr. David Alan Gilbert wrote: > > Hi, > > There's been quite a bit of discussion about where virtiofsd, our > > implemenation of a virtiofs daemon, should live. I'd like to get > > this settled now,

[RFC 06/10] Fix MC STATUS resgister

2019-11-26 Thread aaron . zakhrov
From: Aaron Dominick --- hw/display/r300.c | 15 --- hw/display/r300.h | 1 + 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/display/r300.c b/hw/display/r300.c index 94e90b7a95..653474c3aa 100644 --- a/hw/display/r300.c +++ b/hw/display/r300.c @@ -278,6 +278,10

Re: [PATCH v17 03/14] util/cutils: refactor do_strtosz() to support suffixes list

2019-11-26 Thread Eduardo Habkost
On Tue, Nov 26, 2019 at 11:04:41AM +0100, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, Nov 25, 2019 at 08:20:23AM +0100, Markus Armbruster wrote: > >> Tao Xu writes: > >> > >> > Add do_strtomul() to convert string according to different suffixes. > >> > > >> > Reviewed-by:

[RFC 00/10] R300 QEMU device V2

2019-11-26 Thread aaron . zakhrov
From: Aaron Dominick I have removed the botched patches and have got the code working upto the GART initialization. I am not sure how to implement the GART. I am guessing it should be an IOMMU device but I think that is a bit much for an emulated card. The earlier problem of display probing

[PATCH v2] target/arm: Allow loading elf from aliased ROM regions

2019-11-26 Thread Jean-Hugues Deschênes
With this patch, we allow loading a ROM image at an aliased address, when it is located in a memory region for which an alias exists. Changes since v1: - Removes unnecessary "else rom = NULL" clause after having verified mr. Signed-off-by: Jean-Hugues Deschenes --- target/arm/cpu.c | 31

Re: [Virtio-fs] [PATCH 4/4] virtiofsd: Implement blocking posix locks

2019-11-26 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > On Fri, Nov 22, 2019 at 05:47:32PM +, Dr. David Alan Gilbert wrote: > > [..] > > > +static int virtio_send_notify_msg(struct fuse_session *se, struct iovec > > > *iov, > > > + int count) > > > +{ > > > +struct

[PULL 0/4] target-arm queue

2019-11-26 Thread Peter Maydell
repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20191126 for you to fetch changes up to 6a4ef4e5d1084ce41fafa7d470a644b0fd3d9317: target/arm: Honor HCR_EL2.TID3 trapping requirements (2019-11-26 13:55:37 +

[PULL 1/4] target/arm: Fix handling of cortex-m FTYPE flag in EXCRET

2019-11-26 Thread Peter Maydell
From: Jean-Hugues Deschênes According to the PushStack() pseudocode in the armv7m RM, bit 4 of the LR should be set to NOT(CONTROL.PFCA) when an FPU is present. Current implementation is doing it for armv8, but not for armv7. This patch makes the existing logic applicable to both code paths.

[PULL 2/4] hw/arm: versal: Add the CRP as unimplemented

2019-11-26 Thread Peter Maydell
From: "Edgar E. Iglesias" Add the CRP as unimplemented thus avoiding bus errors when guests access these registers. Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Reviewed-by: Luc Michel Message-id: 20191115154734.26449-2-edgar.igles...@gmail.com Signed-off-by: Peter Maydell

Re: [PATCH] error: Fix -msg timestamp default

2019-11-26 Thread Markus Armbruster
Markus Armbruster writes: > -msg parameter "timestamp" defaults to "off" if you don't specify msg, > and to "on" if you do. Messed up right in commit 5e2ac51917 "add > timestamp to error_report()". Mostly harmless, because "timestamp" is > the only parameter, so "if you do" is "-msg ''", which

Re: [RFC 0/8] ATI R300 emulated graphics card

2019-11-26 Thread BALATON Zoltan
Hello, On Tue, 26 Nov 2019, aaron.zakh...@gmail.com wrote: From: Aaron Dominick Hello, I thought of working on an emulated R300 GPU for QEMU video acceleration on vintage operating systems (Windows 9x-XP) Good idea, :-) I very welcome any contribution to this. The following patch series

Re: [PULL] RISC-V Patches for 4.2-rc3

2019-11-26 Thread Peter Maydell
On Mon, 25 Nov 2019 at 20:59, Palmer Dabbelt wrote: > > The following changes since commit 65e05c82bdc6d348155e301c9d87dba7a08a5701: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2019-11-25 15:47:44 +) > > are available in the Git repository at: > >

[PULL 2/2] iotests: add new test cases to bitmap migration

2019-11-26 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Add optional pre-shutdown: shutdown/launch vm before migration. This leads to storing persistent bitmap to the storage, which breaks migration with dirty-bitmaps capability enabled and shared storage until fixed by previous commit. Signed-off-by: Vladimir

Re: [PATCH v17 01/14] util/cutils: Add Add qemu_strtold and qemu_strtold_finite

2019-11-26 Thread Markus Armbruster
Tao Xu writes: > Hi Markus, > > Do you have any comments on this patch and 02/14 05/14 06/14. > Thank you! These provide a new QAPI built-in type 'time'. It's like 'uint64' with an implied nanoseconds unit, and additional convenience syntax in the opts visitor and the keyval qobject input

[PULL 3/4] target/arm: Fix ISR_EL1 tracking when executing at EL2

2019-11-26 Thread Peter Maydell
From: Marc Zyngier The ARMv8 ARM states when executing at EL2, EL3 or Secure EL1, ISR_EL1 shows the pending status of the physical IRQ, FIQ, or SError interrupts. Unfortunately, QEMU's implementation only considers the HCR_EL2 bits, and ignores the current exception level. This means a

[Bug 1853826] Re: ELF loader fails to load shared object on ThunderX2 running RHEL7

2019-11-26 Thread Assad Hashmi
For info, a similar type of failure has been seen when loading libarmflang.so on DynamoRIO: https://github.com/DynamoRIO/dynamorio/issues/3385 It's to do with the .dynstr section being mapped incorrectly causing a SIGBUS. ** Bug watch added: github.com/DynamoRIO/dynamorio/issues #3385

Re: [RFC 0/8] ATI R300 emulated graphics card

2019-11-26 Thread Andrew Randrianasulu
Hello, Aaron! While I can't help with coding (or even answering questions!) I recall mr. Zoltan worked on emulating earlier ATI cards (r128/rv100) and pointed me at this project: https://github.com/xenia-project/xenia/tree/master/src/xenia/gpu this basically about xbox 360, but GPU inside it

Re: [RFC 0/8] ATI R300 emulated graphics card

2019-11-26 Thread Aaron Zakhrov
Yeah sorry about the double patches. That was because of a botched rebase. It applied my commits twice. I am working on cleaning up the header files and other fixes. > Are you aware of my project page for ATI VGA emulation here: Yes I am. Your code got me through the initial setup. On Tue,

[PATCH] blockjob: Fix error message for negative speed

2019-11-26 Thread Kevin Wolf
The error message for a negative speed uses QERR_INVALID_PARAMETER, which implies that the 'speed' option doesn't even exist: {"error": {"class": "GenericError", "desc": "Invalid parameter 'speed'"}} Make it use QERR_INVALID_PARAMETER_VALUE instead: {"error": {"class": "GenericError",

Re: [PATCH 1/4] block/quorum.c: stable children names

2019-11-26 Thread Alberto Garcia
On Thu 21 Nov 2019 07:34:45 PM CET, Lukas Straub wrote: >> > diff --git a/block/quorum.c b/block/quorum.c >> > index df68adcfaa..6100d4108a 100644 >> > --- a/block/quorum.c >> > +++ b/block/quorum.c >> > @@ -1054,6 +1054,12 @@ static void quorum_del_child(BlockDriverState *bs, >> > BdrvChild

Re: API definition for LUKS key management [V2]

2019-11-26 Thread Kevin Wolf
Am 25.11.2019 um 19:45 hat Max Reitz geschrieben: > On 22.11.19 15:22, Maxim Levitsky wrote: > > Hi! > > > > This is the second version of the proposed QMP API for key management, > > after discussion with Keven and Max. > > > > Will this work? > > > > Adding Peter Krempa to CC, to hear his

Re: [PULL 0/1] Linux user for 4.2 patches

2019-11-26 Thread Peter Maydell
On Mon, 25 Nov 2019 at 16:34, Laurent Vivier wrote: > > The following changes since commit 2061735ff09f9d5e67c501a96227b470e7de69b1: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2019-11-21 17:18:40 +) > > are available in the Git repository at: > >

[PULL 1/3] tests/vm/centos: fix centos build target

2019-11-26 Thread Alex Bennée
To be able to run the docker tests centos has here we have to install python3 as well as the basic tools. Signed-off-by: Alex Bennée Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Philippe Mathieu-Daudé diff --git a/tests/vm/centos b/tests/vm/centos index 53976f1c4c9..b9e851f2d33

[PULL 3/3] tests/vm/ubuntu: update i386 image to 18.04

2019-11-26 Thread Alex Bennée
The current image is broken while running qtests but the bug go away when built with a newer Ubuntu i386 image. I was unable to replicate the crash on Debian Buster for i386 either so I'm concluding it is a distro problem. Let's paper over that crack by updating our 32 bir test image.

Re: [PATCH 1/4] qom/object: enable setter for uint types

2019-11-26 Thread Marc-André Lureau
Hi On Tue, Nov 26, 2019 at 4:03 PM Felipe Franciosi wrote: > > Heya > > > On Nov 26, 2019, at 8:40 AM, Marc-André Lureau > > wrote: > > > > Hi > > > > On Mon, Nov 25, 2019 at 7:40 PM Felipe Franciosi wrote: > >> > >> Traditionally, the uint-specific property helpers only offer getters. > >>

[RFC 08/10] Got GPU init working. Stops at probing display

2019-11-26 Thread aaron . zakhrov
From: Aaron Dominick --- hw/display/ati.c | 9 +- hw/display/r300.c | 571 +- hw/display/r300.h | 77 ++- 3 files changed, 544 insertions(+), 113 deletions(-) diff --git a/hw/display/ati.c b/hw/display/ati.c index db3b254316..1d36233163

Re: [PATCH] target/arm: Honor HCR_EL2.TID3 trapping requirements

2019-11-26 Thread Peter Maydell
On Mon, 25 Nov 2019 at 17:49, Marc Zyngier wrote: > I also had a look at TID0, but couldn't find any of the Jazelle > stuff in QEMU... We implement only "minimal Jazelle", ie the minimal set of registers needed to be architecturally compliant for an implementation without Jazelle. thanks -- PMM

[PULL 4/4] target/arm: Honor HCR_EL2.TID3 trapping requirements

2019-11-26 Thread Peter Maydell
From: Marc Zyngier HCR_EL2.TID3 mandates that access from EL1 to a long list of id registers traps to EL2, and QEMU has so far ignored this requirement. This breaks (among other things) KVM guests that have PtrAuth enabled, while the hypervisor doesn't want to expose the feature to its guest.

Re: [RFC 00/10] R300 QEMU device V2

2019-11-26 Thread Daniel P . Berrangé
On Tue, Nov 26, 2019 at 06:14:27PM +0530, aaron.zakh...@gmail.com wrote: > From: Aaron Dominick > > I have removed the botched patches and have got the code working upto the > GART initialization. > I am not sure how to implement the GART. I am guessing it should be an IOMMU > device but I

Re: virtiofsd: Where should it live?

2019-11-26 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi David > > On Mon, Nov 25, 2019 at 10:50 PM Dr. David Alan Gilbert > wrote: > > > > Hi, > > There's been quite a bit of discussion about where virtiofsd, our > > implemenation of a virtiofs daemon, should live. I'd like to get > >

Re: [PATCH v2 2/2] s390x/cpumodel: Introduce dynamic feature groups

2019-11-26 Thread Christian Borntraeger
re-adding ccs from the cover-letter >>> On 25.11.19 18:20, David Hildenbrand wrote: >>> >>> As soon as dynamic feature groups are used, the CPU model becomes >>> migration-unsafe. Upper layers can expand these models to migration-safe >>> and static variants, allowing them to be migrated. >> >> I

  1   2   3   >