[PATCH v3 04/18] hw/i386: Introduce initialize_topo_info to initialize X86CPUTopoInfo

2019-12-03 Thread Babu Moger
Initialize all the parameters in one function initialize_topo_info. Signed-off-by: Babu Moger Reviewed-by: Eduardo Habkost --- hw/i386/pc.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index

[PATCH v3 09/18] i386: Add CPUX86Family type in CPUX86State

2019-12-03 Thread Babu Moger
Add CPUX86Family type in CPUX86State. This will be used to differentiate generic x86 and x86 EPYC based cpu models. Signed-off-by: Babu Moger --- hw/i386/pc.c |4 target/i386/cpu.c |1 + target/i386/cpu.h |7 +++ 3 files changed, 12 insertions(+) diff --git

[PATCH v3 12/18] numa: Split the numa initialization

2019-12-03 Thread Babu Moger
To generate the apic id for EPYC cpu models correctly, we need to know the number of numa nodes in advance. At present numa node initialization and cpu initialization happens at the same time. Apic id generation happens during the cpu initialization. At this point it is not known how many numa

[PATCH v3 08/18] hw/i386: Update structures for nodes_per_pkg

2019-12-03 Thread Babu Moger
Update structures X86CPUTopoIDs and CPUX86State to hold the nodes_per_pkg. This is required to build EPYC mode topology. Signed-off-by: Babu Moger --- hw/i386/pc.c |4 include/hw/i386/topology.h |1 + target/i386/cpu.c |1 + target/i386/cpu.h |

[PATCH v3 05/18] machine: Add SMP Sockets in CpuTopology

2019-12-03 Thread Babu Moger
Store the smp sockets in CpuTopology. The socket information required to build the apic id in EPYC mode. Right now socket information is not passed to down when decoding the apic id. Add the socket information here. Signed-off-by: Babu Moger Reviewed-by: Eduardo Habkost --- hw/core/machine.c

Re: [PATCH] net/imx_fec: Updating the IMX_FEC IP to support loopback mode.

2019-12-03 Thread Jason Wang
On 2019/11/30 上午12:04, Philippe Mathieu-Daudé wrote: On Fri, Nov 29, 2019 at 4:59 PM Wasim, Bilal wrote: Thanks for the pointers philippe.. Is the patch okay to be merged without it or do I need to do a re-submission with the updated username ? If there are no review comments on your

Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread pannengyuan
On 2019/12/4 1:38, Vladimir Sementsov-Ogievskiy wrote: > Hi! > > First, please, when sending more than one patch, create a cover-letter. Also, > summarize (in cover letter) what was changed since previous version. In previous version, I only send one patch(2/2 in this version), so I only add a

Re: [PATCH V3 1/2] block/nbd: extract the common cleanup code

2019-12-03 Thread pannengyuan
On 2019/12/4 3:00, Eric Blake wrote: > On 11/29/19 1:25 AM, pannengy...@huawei.com wrote: >> From: PanNengyuan >> >> The BDRVNBDState cleanup code is common in two places, add >> nbd_free_bdrvstate_prop() function to do these cleanups (suggested by >> Stefano Garzarella). >> >> Signed-off-by:

Re: for 4.2 ??? Re: [PATCH V3 2/2] block/nbd: fix memory leak in nbd_open()

2019-12-03 Thread pannengyuan
On 2019/12/4 2:54, Eric Blake wrote: > On 12/3/19 11:52 AM, Vladimir Sementsov-Ogievskiy wrote: >> It's just a memory leak, but it's a regression in 4.2. >> >> Should we take it into 4.2? > > Sorry, I was on holiday and then jury service, so I missed any chance at > getting this into -rc3. 

Re: [PULL v2 4/6] spapr: Add /chosen to FDT only at reset time to preserve kernel and initramdisk

2019-12-03 Thread Alexey Kardashevskiy
On 04/12/2019 03:09, Laurent Vivier wrote: > > Bad reply, the problem is with > > "spapr: Render full FDT on ibm,client-architecture-support" https://git.qemu.org/?p=SLOF.git;a=blob;f=board-qemu/slof/fdt.fs;h=3e4c1b34b8af2dcebde57e548c94417e5e20e1cc;hb=HEAD#l265 A "bit ugly" became really

Re: [PULL v2 4/6] spapr: Add /chosen to FDT only at reset time to preserve kernel and initramdisk

2019-12-03 Thread Alexey Kardashevskiy
On 04/12/2019 15:23, Alexey Kardashevskiy wrote: > > > On 04/12/2019 03:09, Laurent Vivier wrote: >> >> Bad reply, the problem is with >> >> "spapr: Render full FDT on ibm,client-architecture-support" > > >

Re: [PATCH] virtio-serial-bus: fix memory leak while attach virtio-serial-bus

2019-12-03 Thread pannengyuan
On 2019/12/3 16:32, Laurent Vivier wrote: > On 03/12/2019 01:53, pannengyuan wrote: >> >> >> On 2019/12/2 21:58, Laurent Vivier wrote: >>> On 02/12/2019 12:15, pannengy...@huawei.com wrote: From: PanNengyuan ivqs/ovqs/c_ivq/c_ovq is forgot to cleanup in

Re: [PULL 2/2] seabios: update to pre-1.13 snapshot again

2019-12-03 Thread Gerd Hoffmann
On Tue, Dec 03, 2019 at 03:00:43PM +0200, Sam Eiderman wrote: > Hi, > > Maybe we should add: > > CONFIG_HOST_BIOS_GEOMETRY=n > > to rom/config.seabios-128k and recreate the 128k image? Can do that when updating to 1.13-final (which is not yet tagged). cheers, Gerd

Re: [PATCH 4/5] hw/arm/virt: Add FW_CFG_RAM_SIZE and FW_CFG_MAX_CPUS into fw_cfg

2019-12-03 Thread Xiang Zheng
On 2019/12/3 20:32, Peter Maydell wrote: > On Tue, 3 Dec 2019 at 12:29, Xiang Zheng wrote: >> >> I'm not sure whether it's neccesary to add FW_CFG_RAM_SIZE and >> FW_CFG_MAX_CPUS into fw_cfg on virt machine. This patch just makes >> the fw_cfg-test happy. >> >> Signed-off-by: Xiang Zheng >>

Re: [PATCH 1/5] tests: fw_cfg: Rename pc_fw_cfg_* to fw_cfg_*

2019-12-03 Thread Xiang Zheng
On 2019/12/3 20:34, Peter Maydell wrote: > On Tue, 3 Dec 2019 at 12:29, Xiang Zheng wrote: >> >> Rename pc_fw_cfg_* to fw_cfg_* to make them common for other >> architectures so that we can run fw_cfg tests on aarch64. >> >> Signed-off-by: Xiang Zheng > >> -static inline QFWCFG

Re: [PATCH 0/5] tests: Enable fw_cfg tests on AArch64

2019-12-03 Thread Xiang Zheng
On 2019/12/3 21:01, Thomas Huth wrote: > On 03/12/2019 13.27, Xiang Zheng wrote: >> There are quite a few tests disabled on AArch64 such as fw_cfg-tests. >> This patch series fix some problems in test code and adapt it to >> virt machine. >> >> Xiang Zheng (5): >> tests: fw_cfg: Rename

Re: [PATCH] scripts: Fix undefinited name 'file' error for python3

2019-12-03 Thread Han Han
Anyone help to review it? On Tue, Nov 26, 2019 at 1:54 PM Han Han wrote: > ping > > On Wed, Nov 13, 2019 at 9:17 PM Han Han wrote: > >> In python3, 'file' is no longer a keyword for file type object. So it >> will can error when run the scripts by python3: >> >> $ python3

Re: [PATCH 7/6] Makefile: Make Makefile depend on generated qga files, too

2019-12-03 Thread Markus Armbruster
Eric Blake writes: > On 11/29/19 3:59 AM, Markus Armbruster wrote: >> Generated .h need to be generated before compiling any .c using them. >> To know which .h a .c uses, we need to compile it. >> >> Since commit 4115852bb0 "build: do not sprinkle around >> GENERATED_HEADERS dependencies", we

<    1   2   3