Re: [PATCH] scripts: Fix undefinited name 'file' error for python3

On Wed, Dec 4, 2019 at 4:23 PM Thomas Huth wrote: > On 04/12/2019 07.48, Han Han wrote: > > Anyone help to review it? > > Hi! > > When sending patches to the qemu-devel mailing list, please always make > sure to put the corresponding maintainers on CC:, otherwise your mails > might get lost in

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

> From: Pan Nengyuan > > Devices tend to maintain vq pointers, allow deleting them trough a vq > pointer. > > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Pan Nengyuan > --- > Changes v2 to v1: > - add a new function virtio_delete_queue to cleanup vq through a vq pointer > --- >

Re: [PATCH v6 3/9] qdev: add clock input support to devices.

On 12/2/19 3:34 PM, Peter Maydell wrote: > On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote: >> >> Add functions to easily add input or output clocks to a device. >> A clock objects is added as a child of the device. > > "object" > >> The api is very similar the gpio's one. > > "API"; "to

Re: qom device lifecycle interaction with hotplug/hotunplug ?

On Tue, Dec 03, 2019 at 06:40:04PM -0300, Eduardo Habkost wrote: +jfreimann, +mst On Sat, Nov 30, 2019 at 11:10:19AM +, Peter Maydell wrote: On Fri, 29 Nov 2019 at 20:05, Eduardo Habkost wrote: > So, to summarize the current issues: > > 1) realize triggers a plug operation implicitly. >

Re: [PATCH v2 00/18] Error handling fixes

On 04.12.19 10:36, Markus Armbruster wrote: > v2: > * Old PATCH 01-03 have been merged for 4.2 > * PATCH 05-15: Commit message rephrased [David], R-bys kept Thanks! -- Thanks, David / dhildenb

[PATCH v2 03/18] io: Fix Error usage in a comment

Cc: "Daniel P. Berrangé" Signed-off-by: Markus Armbruster --- include/io/task.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/io/task.h b/include/io/task.h index 5cb9faf9f2..1abbfb8b65 100644 --- a/include/io/task.h +++ b/include/io/task.h @@ -119,7 +119,7 @@

Re: [PATCH v2 00/18] Error handling fixes

Neglected to mention: I'm fine with taking care of getting the whole series merged. Maintainers, feel free to take "your" parts through your tree regardless. Whatever is left after a while I'll take through mine.

Re: [PATCH v4 14/40] target/arm: Recover 4 bits from TBFLAGs

Richard Henderson writes: > We had completely run out of TBFLAG bits. > Split A- and M-profile bits into two overlapping buckets. > This results in 4 free bits. > > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 52 --- >

[PATCH] travis.yml: Drop libcap-dev

Commit b1553ab12fe0 converted virtfs-proxy-helper to using libcap-ng. There aren't any users of libcap anymore. No need to install libcap-dev. Signed-off-by: Greg Kurz --- Yet another follow-up to Paolo's patch to use libcap-ng instead of libcap. Like with the docker and the gitlab CI patches,

[PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter"

This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8. In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc accordingly. --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

I was unable to compile the qemu-git package and I currently have not time to investigate that. But I updated to 4.1.1. I just started my Windows 10 VM with that and after a short time of use the image was corrupted again. Here is my full start parameter set. Maybe there is something wrong or I

[PATCH v2 02/18] crypto: Fix typo in QCryptoTLSSession's comment

Cc: "Daniel P. Berrangé" Signed-off-by: Markus Armbruster --- include/crypto/tlssession.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/crypto/tlssession.h b/include/crypto/tlssession.h index e01e1a9dc2..15b9cef086 100644 --- a/include/crypto/tlssession.h +++

[PATCH v2 17/18] hw/intc/s390: Simplify error handling in kvm_s390_flic_realize()

Cc: Halil Pasic Cc: Cornelia Huck Cc: Christian Borntraeger Signed-off-by: Markus Armbruster Reviewed-by: Cornelia Huck Acked-by: Halil Pasic --- hw/intc/s390_flic_kvm.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/intc/s390_flic_kvm.c

[PATCH v2 15/18] s390x/cpumodel: Fix query-cpu-definitions error API violations

qmp_query_cpu_definitions() passes @errp to get_max_cpu_model(), then frees any error it gets back. This effectively ignores errors. Dereferencing @errp is wrong; see the big comment in error.h. Passing @errp is also wrong, because it works only as long as @errp is neither @error_fatal nor

[PATCH] i386: pass CLZERO to guests with EPYC CPU model on AMD ZEN platform

CLZERO CPUID should be passed on to the guests that use EPYC or EPYC-IBPB CPU model when the AMD ZEN based host supports it. This change makes it recognize this CPUID for guests which use EPYC or EPYC-IBPB CPU model. Signed-off-by: Ani Sinha --- target/i386/cpu.c | 2 ++ 1 file changed, 2

Re: [PULL v2 4/6] spapr: Add /chosen to FDT only at reset time to preserve kernel and initramdisk

On 04/12/2019 05:40, Alexey Kardashevskiy wrote: > > > On 04/12/2019 15:23, Alexey Kardashevskiy wrote: >> >> >> On 04/12/2019 03:09, Laurent Vivier wrote: >>> >>> Bad reply, the problem is with >>> >>> "spapr: Render full FDT on ibm,client-architecture-support" >> >> >>

[ANNOUNCE] libslirp 4.1.0 is now available

Hi, We are pleased to announce the availability of libslirp 4.1.0 release. You can grab the tarball & read the changelog from the gitlab release page here: https://gitlab.freedesktop.org/slirp/libslirp/releases Highlights include: * new slirp_new() API, more flexible than slirp_init() *

Re: [PATCH v4 10/40] target/arm: Rename ARMMMUIdx_S1NSE* to ARMMMUIdx_Stage1_E*

Richard Henderson writes: > This is part of a reorganization to the set of mmu_idx. > The EL1&0 regime is the only one that uses 2-stage translation. > Spelling out Stage avoids confusion with Secure. > > Signed-off-by: Richard Henderson > diff --git a/target/arm/helper.c

Re: [PATCH 00/21] Error handling fixes, may contain 4.2 material

"Michael S. Tsirkin" writes: > On Sat, Nov 30, 2019 at 08:42:19PM +0100, Markus Armbruster wrote: >> PATCH 2-4 fix crash bugs. Including them would be a no-brainer at >> -rc0. But we're post -rc3, and even for crash bugs we require a >> certain likelihood of users getting bitten. >> >> Jens,

Re: [PATCH] travis.yml: Drop libcap-dev

On 12/4/19 9:01 AM, Greg Kurz wrote: Commit b1553ab12fe0 converted virtfs-proxy-helper to using libcap-ng. There aren't any users of libcap anymore. No need to install libcap-dev. Signed-off-by: Greg Kurz --- Yet another follow-up to Paolo's patch to use libcap-ng instead of libcap. Like with

[PATCH v2 13/18] s390x/cpumodel: Fix realize() error API violations

get_max_cpu_model() dereferences @errp when kvm_s390_get_host_cpu_model() fails, apply_cpu_model() dereferences it when kvm_s390_apply_cpu_model() fails, and s390_realize_cpu_model() dereferences it when get_max_cpu_model() or check_compatibility() fail. That's wrong; see the big comment in

[PATCH v2 18/18] tests-blockjob: Use error_free_or_abort()

Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/test-blockjob.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/test-blockjob.c b/tests/test-blockjob.c index e670a20617..4eeb184caf 100644 --- a/tests/test-blockjob.c +++ b/tests/test-blockjob.c @@

Re: [PATCH v2 03/18] io: Fix Error usage in a comment

On Wed, Dec 04, 2019 at 10:36:10AM +0100, Markus Armbruster wrote: > Cc: "Daniel P. Berrangé" > Signed-off-by: Markus Armbruster > --- > include/io/task.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com

Re: [PATCH v4 08/40] target/arm: Rename ARMMMUIdx*_S12NSE* to ARMMMUIdx*_E10_*

Richard Henderson writes: > This is part of a reorganization to the set of mmu_idx. > This emphasizes that they apply to the EL1&0 regime. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/cpu.h | 8 > target/arm/internals.h | 4 ++--

Re: [PATCH v2 3/3] virtio-serial-bus: fix memory leak while attach virtio-serial-bus

On 04/12/2019 08:31, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > ivqs/ovqs/c_ivq/c_ovq is forgot to cleanup in > virtio_serial_device_unrealize, the memory leak stack is as bellow: > > Direct leak of 1290240 byte(s) in 180 object(s) allocated from: > #0 0x7fc9bfc27560 in calloc

Re: virtiofsd: Where should it live?

Hi, > > | ... > > +- qemu-edid > > Has its own MAINTAINERS section, together with hw/display/edit* and > include/hw/display/edid.h. I'm not sure moving it hw/display/ is a good > idea. Gerd? Sort-of makes sense. My personal preference would be a tools/ directory for all those

[PATCH v2 12/18] s390x/cpumodel: Fix feature property error API violations

s390x-cpu property setters set_feature() and set_feature_group() dereference @errp when the visitor fails. That's wrong; see the big comment in error.h. Introduced in commit 0754f60429 "s390x/cpumodel: expose features and feature groups as properties". No caller actually passes null. Fix

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

On 04/12/2019 08:31, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > Devices tend to maintain vq pointers, allow deleting them trough a vq pointer. > > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Pan Nengyuan > --- > Changes v2 to v1: > - add a new function virtio_delete_queue

[PATCH v2 11/18] s390x/event-facility: Fix realize() error API violations

sclp_events_bus_realize() dereferences @errp when object_property_set_bool() fails. That's wrong; see the big comment in error.h. Introduced in commit f6102c329c "s390/sclp: rework sclp event facility initialization + device realization". No caller actually passes null. Fix anyway: splice in a

Re: [PATCH v4 09/40] target/arm: Rename ARMMMUIdx_S2NS to ARMMMUIdx_Stage2

Richard Henderson writes: > The EL1&0 regime is the only one that uses 2-stage translation. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/cpu.h | 4 +-- > target/arm/internals.h | 2 +- > target/arm/helper.c| 57

Re: [PATCH] travis.yml: Drop libcap-dev

On 04/12/2019 09.01, Greg Kurz wrote: > Commit b1553ab12fe0 converted virtfs-proxy-helper to using libcap-ng. There > aren't any users of libcap anymore. No need to install libcap-dev. > > Signed-off-by: Greg Kurz > --- > > Yet another follow-up to Paolo's patch to use libcap-ng instead of

Re: [RFC] QEMU Gating CI

On 03/12/2019 15.07, Alex Bennée wrote: [...] >> GitLab Jobs and Pipelines >> - >> >> GitLab CI is built around two major concepts: jobs and pipelines. The >> current GitLab CI configuration in QEMU uses jobs only (or putting it >> another way, all jobs in a single

Re: [PATCH v2 01/18] crypto: Fix certificate file error handling crash bug

On Wed, Dec 04, 2019 at 10:36:08AM +0100, Markus Armbruster wrote: > qcrypto_tls_creds_load_cert() passes uninitialized GError *gerr by > reference to g_file_get_contents(). When g_file_get_contents() fails, > it'll try to set a GError. Unless @gerr is null by dumb luck, this > logs a

Re: [PATCH v2 03/13] s390x: protvirt: Support unpack facility

On 04/12/2019 12.32, Janosch Frank wrote: > On 12/4/19 11:48 AM, Thomas Huth wrote: >> On 29/11/2019 10.47, Janosch Frank wrote: >>> When a guest has saved a ipib of type 5 and call diagnose308 with >>> subcode 10, we have to setup the protected processing environment via >>> Ultravisor calls. The

Re: [PATCH v4 12/40] target/arm: Rename ARMMMUIdx*_S1E3 to ARMMMUIdx*_SE3

Richard Henderson writes: > This is part of a reorganization to the set of mmu_idx. > The EL3 regime only has a single stage translation, and > is always secure. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/cpu.h | 4 ++-- >

Re: [PATCH v4 13/40] target/arm: Rename ARMMMUIdx_S1E2 to ARMMMUIdx_E2

Richard Henderson writes: > This is part of a reorganization to the set of mmu_idx. > The non-secure EL2 regime only has a single stage translation; > there is no point in pointing out that the idx is for stage1. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- >

Re: [PATCH v3 2/4] s390x: Add missing vcpu reset functions

On 12/3/19 6:44 PM, Cornelia Huck wrote: > On Tue, 3 Dec 2019 08:28:11 -0500 > Janosch Frank wrote: > >> Up to now we only had an ioctl to reset vcpu data QEMU couldn't reach >> for the initial reset, and that was also called for the clear >> reset. To be architecture compliant, we also need to

[PATCH v2 04/18] tests: Clean up initialization of Error *err variables

Declaring a local Error *err without initializer looks suspicious. Fuse the declaration with the initialization to avoid that. Signed-off-by: Markus Armbruster --- tests/test-qobject-output-visitor.c | 8 tests/test-string-output-visitor.c | 4 ++-- 2 files changed, 6 insertions(+), 6

Re: [PATCH v2 2/3] virtio-balloon: fix memory leak while attach virtio-balloon device

On 04/12/2019 08:31, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > ivq/dvq/svq/free_page_vq is forgot to cleanup in > virtio_balloon_device_unrealize, the memory leak stack is as follow: > > Direct leak of 14336 byte(s) in 2 object(s) allocated from: > #0 0x7f99fd9d8560 in calloc

Re: [PATCH v6 5/9] qdev-clock: introduce an init array to ease the device construction

On 12/2/19 4:13 PM, Peter Maydell wrote: > On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote: >> >> Introduce a function and macro helpers to setup several clocks >> in a device from a static array description. >> >> An element of the array describes the clock (name and direction) as >> well as

Re: [PATCH v4 11/40] target/arm: Rename ARMMMUIdx_S1SE* to ARMMMUIdx_SE*

Richard Henderson writes: > This is part of a reorganization to the set of mmu_idx. > The Secure regimes all have a single stage translation; > there is no point in pointing out that the idx is for stage1. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- >

Re: virtiofsd: Where should it live?

Daniel P. Berrangé writes: > On Tue, Dec 03, 2019 at 11:06:44AM +, Peter Maydell wrote: >> On Tue, 3 Dec 2019 at 10:53, Dr. David Alan Gilbert >> wrote: >> > >> > We seem to be coming to the conclusion something that: >> > >> > a) It should live in the qemu tree >> > b) It shouldn't

Re: [PATCH] travis.yml: Drop libcap-dev

On Wed, 4 Dec 2019 09:07:42 +0100 Thomas Huth wrote: > On 04/12/2019 09.01, Greg Kurz wrote: > > Commit b1553ab12fe0 converted virtfs-proxy-helper to using libcap-ng. There > > aren't any users of libcap anymore. No need to install libcap-dev. > > > > Signed-off-by: Greg Kurz > > --- > > > >

[PATCH v3] travis.yml: Run tcg tests with tci

So far we only have compile coverage for tci. But since commit 2f160e0f9797c7522bfd0d09218d0c9340a5137c ("tci: Add implementation for INDEX_op_ld16u_i64") has been included now, we can also run the "tcg" and "qtest" tests with tci, so let's enable them in Travis now. Since we don't gain much

Re: [PATCH] scripts: Fix undefinited name 'file' error for python3

On 04/12/2019 07.48, Han Han wrote: > Anyone help to review it? Hi! When sending patches to the qemu-devel mailing list, please always make sure to put the corresponding maintainers on CC:, otherwise your mails might get lost in the high traffic of the mailing list. For this case, it would have

Re: [PATCH v3 2/4] s390x: Add missing vcpu reset functions

On Wed, 4 Dec 2019 10:00:45 +0100 Janosch Frank wrote: > On 12/3/19 6:44 PM, Cornelia Huck wrote: > > On Tue, 3 Dec 2019 08:28:11 -0500 > > Janosch Frank wrote: > > > >> Up to now we only had an ioctl to reset vcpu data QEMU couldn't reach > >> for the initial reset, and that was also

Re: [PATCH 02/10] hw: arm: add Xunlong Orange Pi PC machine

On 12/3/19 8:33 PM, Niek Linnenbank wrote: Hello Philippe, Thanks for your quick review comments! I'll start working on a v2 of the patches and include the changes you suggested. Thanks, but I'd suggest to wait few more days to give time to others reviewers. Else having multiple versions of

[PATCH v2 06/18] hw/acpi: Fix legacy CPU plug error API violations

legacy_acpi_cpu_plug_cb() dereferences @errp when acpi_set_cpu_present_bit() fails. That's wrong; see the big comment in error.h. Introduced in commit cc43364de7 "acpi/cpu-hotplug: introduce helper function to keep bit setting in one place". No caller actually passes null, and

[PATCH v2 00/18] Error handling fixes

v2: * Old PATCH 01-03 have been merged for 4.2 * PATCH 05-15: Commit message rephrased [David], R-bys kept Cc: "Daniel P. Berrangé" Cc: "Michael S. Tsirkin" Cc: Christian Borntraeger Cc: Corey Minyard Cc: Cornelia Huck Cc: David Hildenbrand Cc: Halil Pasic Cc: Igor Mammedov Cc: Michael

[PATCH v2 10/18] memory-device: Fix memory pre-plug error API violations

memory_device_get_free_addr() dereferences @errp when memory_device_check_addable() fails. That's wrong; see the big comment in error.h. Introduced in commit 1b6d6af21b "pc-dimm: factor out capacity and slot checks into MemoryDevice". No caller actually passes null. Fix anyway: splice in a

[Bug 1855072] [NEW] ARM: HCR.TVM traps are not implemented

Public bug reported: On AARCH64, setting HCR.TVM to 1 is supposed to trap all writes to CTLR_EL1, TTBR0_EL1, TTBR1_EL1, TCR_EL1, ESR_EL1, FAR_EL1, AFSR0_EL1, AFSR1_EL1, MAIR_EL1, AMAIR_EL1, and CONTEXTIDR_EL1. However, it currently has no effect (QEMU emulator version 4.1.1). It is also likely

Re: Network connection with COLO VM

On 12/3/2019 9:25 PM, Dr. David Alan Gilbert wrote: * Daniel Cho (daniel...@qnap.com) wrote: Hi Dave, We could use the exist interface to add netfilter and chardev, it might not have the problem you said. However, the netfilter and chardev on the primary at the start, that means we could

Re: [PATCH] virtio-serial-bus: fix memory leak while attach virtio-serial-bus

On 04/12/2019 04:02, pannengyuan wrote: > > > On 2019/12/3 16:32, Laurent Vivier wrote: >> On 03/12/2019 01:53, pannengyuan wrote: >>> >>> >>> On 2019/12/2 21:58, Laurent Vivier wrote: On 02/12/2019 12:15, pannengy...@huawei.com wrote: > From: PanNengyuan > >

[PATCH v2 09/18] qga: Fix guest-get-fsinfo error API violations

build_guest_fsinfo_for_virtual_device() dereferences @errp when build_guest_fsinfo_for_device() fails. That's wrong; see the big comment in error.h. Introduced in commit 46d4c5723e "qga: Add guest-get-fsinfo command". No caller actually passes null. Fix anyway: splice in a local Error *err,

[PATCH v2 07/18] hw/core: Fix fit_load_fdt() error handling violations

fit_load_fdt() passes @errp to fit_image_addr(), then recovers from ENOENT failures. Passing @errp is wrong, because it works only as long as @errp is neither @error_fatal nor @error_abort. Messed up in commit 3eb99edb48 "loader-fit: Wean off error_printf()". No caller actually passes such

Re: [PATCH v2 02/18] crypto: Fix typo in QCryptoTLSSession's comment

On Wed, Dec 04, 2019 at 10:36:09AM +0100, Markus Armbruster wrote: > Cc: "Daniel P. Berrangé" > Signed-off-by: Markus Armbruster > --- > include/crypto/tlssession.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Daniel P. Berrangé Regards, Daniel -- |:

Re: [PATCH v6 3/9] qdev: add clock input support to devices.

On 12/4/19 10:05 AM, Damien Hedde wrote: On 12/2/19 3:34 PM, Peter Maydell wrote: On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote: [...] +/** + * qdev_pass_clock: + * @dev: the device to forward the clock to + * @name: the name of the clock to be added (can't be NULL) + * @container: the

Re: [PATCH v2 03/13] s390x: protvirt: Support unpack facility

On 29/11/2019 10.47, Janosch Frank wrote: > When a guest has saved a ipib of type 5 and call diagnose308 with > subcode 10, we have to setup the protected processing environment via > Ultravisor calls. The calls are done by KVM and are exposed via an API. > > The following steps are necessary: >

[PATCH] target/i386: relax assert when old host kernels don't include msrs

Commit 20a78b02d315 ("target/i386: add VMX features") unconditionally add vmx msr entry although older host kernels don't include them. But old host kernel + newest qemu will cause a qemu crash as follows: qemu-system-x86_64: error: failed to set MSR 0x480 to 0x0 target/i386/kvm.c:2932:

[PATCH v2 01/18] crypto: Fix certificate file error handling crash bug

qcrypto_tls_creds_load_cert() passes uninitialized GError *gerr by reference to g_file_get_contents(). When g_file_get_contents() fails, it'll try to set a GError. Unless @gerr is null by dumb luck, this logs a ERROR_OVERWRITTEN_WARNING warning message and leaves @gerr unchanged.

[PATCH v2 08/18] hw/ipmi: Fix realize() error API violations

isa_ipmi_bt_realize(), ipmi_isa_realize(), pci_ipmi_bt_realize(), and pci_ipmi_kcs_realize() dereference @errp when IPMIInterfaceClass method init() fails. That's wrong; see the big comment in error.h. Introduced in commit 0719029c47 "ipmi: Add an ISA KCS low-level interface", then imitated in

[PATCH v2 14/18] s390x/cpumodel: Fix query-cpu-model-FOO error API violations

cpu_model_from_info() is a helper for qmp_query_cpu_model_expansion(), qmp_query_cpu_model_comparison(), qmp_query_cpu_model_baseline(). It dereferences @errp when the visitor or the QOM setter fails. That's wrong; see the big comment in error.h. Introduced in commit 137974cea3 's390x/cpumodel:

[PATCH v2 16/18] error: Clean up unusual names of Error * variables

Local Error * variables are conventionally named @err or @local_err, and Error ** parameters @errp. Naming local variables like parameters is confusing. Clean that up. Naming parameters like local variables is also confusing. Left for another day. Signed-off-by: Markus Armbruster

[Bug 1846427] Re: 4.1.0: qcow2 corruption on savevm/quit/loadvm cycle

I don't see anything suspicious in that command line. My only idea for a different configuration to test would be discard=off, which would remove a few code paths that could contain a bug. Anyway, I think it's pretty clear now that you're hitting a different bug than Michael. Maybe it would be

[PATCH v2 05/18] exec: Fix file_ram_alloc() error API violations

When os_mem_prealloc() fails, file_ram_alloc() calls qemu_ram_munmap() and returns null. Except it doesn't when its @errp argument is null, because it checks for failure with (errp && *errp). Introduced in commit 056b68af77 "fix qemu exit on memory hotplug when allocation fails at prealloc

Re: [PATCH v4 15/40] target/arm: Expand TBFLAG_ANY.MMUIDX to 4 bits

Richard Henderson writes: > We are about to expand the number of mmuidx to 10, and so need 4 bits. > For the benefit of reading the number out of -d exec, align it to the > penultimate nibble. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/cpu.h | 12

Re: Custom logic gates on user space emulation

Hello Alex, Thank you for your response, if I am on the right path I want to add hadamard or one of pauli gate to gnu assembler then I want to run this extended GAS via qemu using user space emulation. i.e. https://en.wikipedia.org/wiki/Quantum_logic_gate#Hadamard_(H)_gate. The idea is there are

Re: [PATCH v6 7/9] hw/misc/zynq_slcr: add clock generation for uarts

On 12/2/19 4:20 PM, Peter Maydell wrote: > On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote: >> >> Switch the slcr to multi-phase reset and add some clocks: >> + the main input clock (ps_clk) >> + the reference clock outputs for each uart (uart0 & 1) >> >> The clock frequencies are computed

Re: virtiofsd: Where should it live?

Am 04.12.2019 um 09:17 hat Gerd Hoffmann geschrieben: > Hi, > > > > | ... > > > +- qemu-edid > > > > Has its own MAINTAINERS section, together with hw/display/edit* and > > include/hw/display/edid.h. I'm not sure moving it hw/display/ is a good > > idea. Gerd? > > Sort-of makes

Re: [PATCH v6 8/9] hw/char/cadence_uart: add clock support

On 12/2/19 4:24 PM, Peter Maydell wrote: > On Wed, 4 Sep 2019 at 13:56, Damien Hedde wrote: >> >> Switch the cadence uart to multi-phase reset and add the >> reference clock input. >> >> The input clock frequency is added to the migration structure. >> >> The reference clock controls the

Re: [PATCH v3] travis.yml: Run tcg tests with tci

On 04/12/2019 14.48, Alex Bennée wrote: > > Thomas Huth writes: > >> So far we only have compile coverage for tci. But since commit >> 2f160e0f9797c7522bfd0d09218d0c9340a5137c ("tci: Add implementation >> for INDEX_op_ld16u_i64") has been included now, we can also run the >> "tcg" and "qtest"

Re: [PATCH 0/6] Enable Travis builds on arm64, ppc64le and s390x

On 27/11/2019 09.50, Thomas Huth wrote: > On 25/11/2019 11.28, Alex Bennée wrote: >> >> Alex Bennée writes: >> >>> Thomas Huth writes: >>> Travis recently added build hosts for arm64, ppc64le and s390x, so this is a welcome addition to our Travis testing matrix.

Re: [PATCH v4 19/40] target/arm: Add regime_has_2_ranges

Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/arm/internals.h | 16 > target/arm/helper.c| 23 ++- > target/arm/translate-a64.c | 3 +-- > 3 files changed, 23 insertions(+), 19

Re: [PATCH v3] travis.yml: Run tcg tests with tci

Thomas Huth writes: > On 04/12/2019 14.48, Alex Bennée wrote: >> >> Thomas Huth writes: >> >>> So far we only have compile coverage for tci. But since commit >>> 2f160e0f9797c7522bfd0d09218d0c9340a5137c ("tci: Add implementation >>> for INDEX_op_ld16u_i64") has been included now, we can

Re: [PATCH v2 3/3] virtio-serial-bus: fix memory leak while attach virtio-serial-bus

On 12/4/19 1:31 AM, pannengy...@huawei.com wrote: From: Pan Nengyuan ivqs/ovqs/c_ivq/c_ovq is forgot to cleanup in s/is // virtio_serial_device_unrealize, the memory leak stack is as bellow: below Direct leak of 1290240 byte(s) in 180 object(s) allocated from: #0 0x7fc9bfc27560

Re: [PATCH v3 2/4] s390x: Add missing vcpu reset functions

On Tue, 3 Dec 2019 08:28:11 -0500 Janosch Frank wrote: > Up to now we only had an ioctl to reset vcpu data QEMU couldn't reach > for the initial reset, and that was also called for the clear > reset. To be architecture compliant, we also need to clear local > interrupts on a normal reset. Do

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

04.12.2019 16:03, Markus Armbruster wrote: > Markus Armbruster writes: > >> Vladimir Sementsov-Ogievskiy writes: >> >>> 29.11.2019 17:35, Markus Armbruster wrote: > [...] I pushed my fixups to git://repo.or.cz/qemu/armbru.git branch error-prep for your convenience. The commit

Re: [PATCH v3 2/4] s390x: Add missing vcpu reset functions

On 04.12.19 16:07, David Hildenbrand wrote: > On 04.12.19 15:59, Cornelia Huck wrote: >> On Tue, 3 Dec 2019 08:28:11 -0500 >> Janosch Frank wrote: >> >>> Up to now we only had an ioctl to reset vcpu data QEMU couldn't reach >>> for the initial reset, and that was also called for the clear >>>

Re: [PATCH v3 2/4] s390x: Add missing vcpu reset functions

On 04.12.19 15:59, Cornelia Huck wrote: > On Tue, 3 Dec 2019 08:28:11 -0500 > Janosch Frank wrote: > >> Up to now we only had an ioctl to reset vcpu data QEMU couldn't reach >> for the initial reset, and that was also called for the clear >> reset. To be architecture compliant, we also need to

Re: [PATCH] target/i386: relax assert when old host kernels don't include msrs

Hi Paolo On Wed, 4 Dec 2019 at 21:53, Paolo Bonzini wrote: > > On 04/12/19 14:33, Catherine Ho wrote: > > Hi Paolo > > [sorry to resend it, seems to reply it incorrectly] > > > > On Wed, 4 Dec 2019 at 19:23, Paolo Bonzini > > wrote: > > > > On 04/12/19 09:50,

Re: [PATCH] target/i386: relax assert when old host kernels don't include msrs

On 04/12/19 09:50, Catherine Ho wrote: > Commit 20a78b02d315 ("target/i386: add VMX features") unconditionally > add vmx msr entry although older host kernels don't include them. > > But old host kernel + newest qemu will cause a qemu crash as follows: > qemu-system-x86_64: error: failed to set

Re: [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter"

Patchew URL: https://patchew.org/QEMU/20191204085628.2892-1-h...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter" Type: series Message-id:

Re: [PATCH] Revert "qemu-options.hx: Update for reboot-timeout parameter"

Han Han writes: > This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8. > > In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc > accordingly. > --- > qemu-options.hx | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qemu-options.hx

Re: [PATCH v2 08/13] s390x: protvirt: Add new VCPU reset functions

On 12/4/19 12:58 PM, Thomas Huth wrote: > On 29/11/2019 10.48, Janosch Frank wrote: >> CPU resets for protected guests need to be done via Ultravisor >> calls. Hence we need a way to issue these calls for each reset. >> >> As we formerly had only one reset function and it was called for >>

Re: [PATCH 7/6] Makefile: Make Makefile depend on generated qga files, too

On 12/4/19 12:56 AM, Markus Armbruster wrote: +++ b/Makefile @@ -130,6 +130,15 @@ GENERATED_QAPI_FILES += qapi/qapi-doc.texi generated-files-y += $(GENERATED_QAPI_FILES) +GENERATED_QGA_FILES := qga-qapi-types.c qga-qapi-types.h +GENERATED_QGA_FILES += qga-qapi-visit.c qga-qapi-visit.h

Re: [PATCH 7/6] Makefile: Make Makefile depend on generated qga files, too

Eric Blake writes: > On 12/4/19 12:56 AM, Markus Armbruster wrote: > +++ b/Makefile @@ -130,6 +130,15 @@ GENERATED_QAPI_FILES += qapi/qapi-doc.texi generated-files-y += $(GENERATED_QAPI_FILES) +GENERATED_QGA_FILES := qga-qapi-types.c qga-qapi-types.h

[Bug 1852196] Re: update edk2 submodule & binaries to edk2-stable201911

** Changed in: qemu Assignee: Laszlo Ersek (Red Hat) (lersek) => Philippe Mathieu-Daudé (philmd) ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH v2 04/18] tests: Clean up initialization of Error *err variables

On 12/4/19 10:36 AM, Markus Armbruster wrote: Declaring a local Error *err without initializer looks suspicious. Fuse the declaration with the initialization to avoid that. Signed-off-by: Markus Armbruster --- tests/test-qobject-output-visitor.c | 8

Re: [PATCH 10/10] arm: allwinner-h3: add EMAC ethernet device

On 12/3/19 10:33 AM, KONRAD Frederic wrote: Le 12/2/19 à 10:09 PM, Niek Linnenbank a écrit : The Allwinner H3 System on Chip includes an Ethernet MAC (EMAC) which provides 10M/100M/1000M Ethernet connectivity. This commit adds support for the Allwinner H3 EMAC, including emulation for the

Re: [PATCH 10/10] arm: allwinner-h3: add EMAC ethernet device

Le 12/4/19 à 4:14 PM, Philippe Mathieu-Daudé a écrit : On 12/3/19 10:33 AM, KONRAD Frederic wrote: Le 12/2/19 à 10:09 PM, Niek Linnenbank a écrit : The Allwinner H3 System on Chip includes an Ethernet MAC (EMAC) which provides 10M/100M/1000M Ethernet connectivity. This commit adds support

[PATCH v2 2/7] iotests: Skip test 060 if it is not possible to create large files

Test 060 fails in the arm64, s390x and ppc64le LXD containers on Travis (which we will hopefully enable in our CI soon). These containers apparently do not allow large files to be created. The repair process in test 060 creates a file of 64 GiB, so test first whether such large files are possible

Re: [PATCH v2 04/18] tests: Clean up initialization of Error *err variables

On 12/4/19 3:36 AM, Markus Armbruster wrote: Declaring a local Error *err without initializer looks suspicious. Fuse the declaration with the initialization to avoid that. Signed-off-by: Markus Armbruster --- tests/test-qobject-output-visitor.c | 8

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

On 12/4/19 1:31 AM, pannengy...@huawei.com wrote: From: Pan Nengyuan Devices tend to maintain vq pointers, allow deleting them trough a vq pointer. through Signed-off-by: Michael S. Tsirkin Signed-off-by: Pan Nengyuan --- Also, don't forget to send a 0/3 cover letter (any series

Re: [PATCH 02/11] target/arm: Add arm_mmu_idx_is_stage1

On 12/3/19 11:53 PM, Richard Henderson wrote: Use a common predicate for querying stage1-ness. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- target/arm/internals.h | 11 +++ target/arm/helper.c| 8 +++- 2 files changed, 14 insertions(+), 5

[PATCH v2 3/7] iotests: Skip test 079 if it is not possible to create large files

Test 079 fails in the arm64, s390x and ppc64le LXD containers on Travis (which we will hopefully enable in our CI soon). These containers apparently do not allow large files to be created. Test 079 tries to create a 4G sparse file, which is apparently already too big for these containers, so check

[PATCH v2 7/7] travis.yml: Enable builds on arm64, ppc64le and s390x

Travis recently added the possibility to test on these architectures, too, so let's enable them in our travis.yml file to extend our test coverage. Unfortunately, the libssh in this Ubuntu version (bionic) is in a pretty unusable Frankenstein state and libspice-server-dev is not available here,

Re: [PATCH v2 12/13] s390x: protvirt: Disable address checks for PV guest IO emulation

On 29/11/2019 10.48, Janosch Frank wrote: > IO instruction data is routed through SIDAD for protected guests, so > adresses do not need to be checked, as this is kernel memory. > > Signed-off-by: Janosch Frank > --- > target/s390x/ioinst.c | 26 +++--- > 1 file changed, 19

Re: [PATCH v6] error: rename errp to errp_in where it is IN-argument

Markus Armbruster writes: > Vladimir Sementsov-Ogievskiy writes: > >> 29.11.2019 17:35, Markus Armbruster wrote: [...] >>> I pushed my fixups to git://repo.or.cz/qemu/armbru.git branch error-prep >>> for your convenience. The commit messages of the fixed up commits need >>> rephrasing, of

Re: [PATCH v4 18/40] target/arm: Reorganize ARMMMUIdx

Richard Henderson writes: > Prepare for, but do not yet implement, the EL2&0 regime. > This involves adding the new MMUIdx enumerators and adjusting > some of the MMUIdx related predicates to match. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- >

[PATCH 3/5] hw/arm/smmuv3: Align stream table base address to table size

Per the specification, and as observed in hardware, the SMMUv3 aligns the SMMU_STRTAB_BASE address to the size of the table by masking out the respective least significant bits in the ADDR field. Apply this masking logic to our smmu_find_ste() lookup function per the specification. ref. ARM IHI

  1   2   3   >