[PULL v2 05/32] virtio-input: convert to new virtio_delete_queue

2020-01-07 Thread Michael S. Tsirkin
Seems cleaner than using VQ index values. Signed-off-by: Michael S. Tsirkin --- hw/input/virtio-input.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/input/virtio-input.c b/hw/input/virtio-input.c index ec54e46ad6..9c013afddb 100644 --- a/hw/input/virtio-input.c

[PULL v2 16/32] hmat acpi: Build Memory Side Cache Information Structure(s)

2020-01-07 Thread Michael S. Tsirkin
From: Liu Jingqi This structure describes memory side cache information for memory proximity domains if the memory side cache is present and the physical device forms the memory side cache. The software could use this information to effectively place the data in memory to maximize the

[PULL v2 25/32] hw: fix using 4.2 compat in 5.0 machine types for i440fx/q35

2020-01-07 Thread Michael S. Tsirkin
From: Denis Plotnikov 5.0 machine type uses 4.2 compats. This seems to be incorrect, since the latests machine type by now is 5.0 and it should use its own compat or shouldn't use any relying on the defaults. Seems, like this appeared because of some problems on merge/rebase. Signed-off-by:

[PULL v2 13/32] numa: Extend CLI to provide memory side cache information

2020-01-07 Thread Michael S. Tsirkin
From: Liu Jingqi Add -numa hmat-cache option to provide Memory Side Cache Information. These memory attributes help to build Memory Side Cache Information Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT). Before using hmat-cache option, enable HMAT with -machine hmat=on.

[PULL v2 09/32] Implement backend program convention command for vhost-user-blk

2020-01-07 Thread Michael S. Tsirkin
From: Micky Yun Chan This patch is to add standard commands defined in docs/interop/vhost-user.rst For vhost-user-* program Signed-off-by: Micky Yun Chan (michiboo) Message-Id: <20191209015331.5455-1-chanmicky...@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin

[PULL v2 11/32] numa: Extend CLI to provide initiator information for numa nodes

2020-01-07 Thread Michael S. Tsirkin
From: Tao Xu In ACPI 6.3 chapter 5.2.27 Heterogeneous Memory Attribute Table (HMAT), The initiator represents processor which access to memory. And in 5.2.27.3 Memory Proximity Domain Attributes Structure, the attached initiator is defined as where the memory controller responsible for a memory

[PULL v2 18/32] tests/bios-tables-test: add test cases for ACPI HMAT

2020-01-07 Thread Michael S. Tsirkin
From: Tao Xu ACPI table HMAT has been introduced, QEMU now builds HMAT tables for Heterogeneous Memory with boot option '-numa node'. Add test cases on PC and Q35 machines with 2 numa nodes. Because HMAT is generated when system enable numa, the following tables need to be added for this test:

[PULL v2 06/32] intel_iommu: fix bug to read DMAR_RTADDR_REG

2020-01-07 Thread Michael S. Tsirkin
From: Yi Sun Should directly read DMAR_RTADDR_REG but not using 's->root'. Because 's->root' is modified in 'vtd_root_table_setup()' so that the first 12 bits are omitted. This causes the guest iommu debugfs cannot show pasid tables. Signed-off-by: Yi Sun Message-Id:

Re: [PATCH v2] hw/usb: Introduce Kconfig switches for the CCID card devices

2020-01-07 Thread Gerd Hoffmann
On Wed, Dec 11, 2019 at 11:20:29AM +0100, Thomas Huth wrote: > In our downstream distribution of QEMU, we need more fine-grained > control on the set of CCID card devices that we want to include. > So let's introduce some proper Kconfig switches that it is easier > to disable them without

Re: [PATCH qemu v2] spapr: Kill SLOF

2020-01-07 Thread David Gibson
On Tue, Jan 07, 2020 at 03:44:35PM +1100, Alexey Kardashevskiy wrote: > > > On 06/01/2020 15:19, David Gibson wrote: > >> + > >> +static uint32_t client_package_to_path(const void *fdt, uint32_t phandle, > >> + uint32_t buf, uint32_t len) > >> +{ > >> +

Re: [PATCH v3 2/2] tests/ide-test: Create a single unit-test covering more PRDT cases

2020-01-07 Thread Kevin Wolf
Am 23.12.2019 um 18:51 hat Alexander Popov geschrieben: > Fuzzing the Linux kernel with syzkaller allowed to find how to crash qemu > using a special SCSI_IOCTL_SEND_COMMAND. It hits the assertion in > ide_dma_cb() introduced in the commit a718978ed58a in July 2015. > Currently this bug is not

Re: [PATCH qemu v2] spapr: Kill SLOF

2020-01-07 Thread David Gibson
On Mon, Jan 06, 2020 at 11:34:13PM +1100, Alexey Kardashevskiy wrote: > > > On 06/01/2020 19:50, David Gibson wrote: > > On Mon, Jan 06, 2020 at 05:28:55PM +1100, Alexey Kardashevskiy wrote: > > > > > > > > > On 06/01/2020 15:19, David Gibson wrote: > > > > On Mon, Jan 06, 2020 at 10:42:42AM

[PATCH 2/5] hw/arm: ast2600: Wire up the eMMC controller

2020-01-07 Thread Cédric Le Goater
From: Andrew Jeffery Initialise another SDHCI model instance for the AST2600's eMMC controller and use the SDHCI's num_slots value introduced previously to determine whether we should create an SD card instance for the new slot. Signed-off-by: Andrew Jeffery Reviewed-by: Cédric Le Goater

[PULL v2 15/32] hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)

2020-01-07 Thread Michael S. Tsirkin
From: Liu Jingqi This structure describes the memory access latency and bandwidth information from various memory access initiator proximity domains. The latency and bandwidth numbers represented in this structure correspond to rated latency and bandwidth for the platform. The software could use

[PULL v2 10/32] virtio: don't enable notifications during polling

2020-01-07 Thread Michael S. Tsirkin
From: Stefan Hajnoczi Virtqueue notifications are not necessary during polling, so we disable them. This allows the guest driver to avoid MMIO vmexits. Unfortunately the virtio-blk and virtio-scsi handler functions re-enable notifications, defeating this optimization. Fix virtio-blk and

[PULL v2 07/32] virtio: update queue size on guest write

2020-01-07 Thread Michael S. Tsirkin
Some guests read back queue size after writing it. Update the size immediatly upon write otherwise they get confused. In particular this is the case for seabios. Reported-by: Roman Kagan Suggested-by: Denis Plotnikov Cc: qemu-sta...@nongnu.org Signed-off-by: Michael S. Tsirkin ---

[PULL v2 14/32] hmat acpi: Build Memory Proximity Domain Attributes Structure(s)

2020-01-07 Thread Michael S. Tsirkin
From: Liu Jingqi HMAT is defined in ACPI 6.3: 5.2.27 Heterogeneous Memory Attribute Table (HMAT). The specification references below link: http://www.uefi.org/sites/default/files/resources/ACPI_6_3_final_Jan30.pdf It describes the memory attributes, such as memory side cache attributes and

[PULL v2 24/32] vhost-user-scsi: reset the device if supported

2020-01-07 Thread Michael S. Tsirkin
From: Raphael Norwitz If the vhost-user-scsi backend supports the VHOST_USER_F_RESET_DEVICE protocol feature, then the device can be reset when requested. If this feature is not supported, do not try a reset as this will send a VHOST_USER_RESET_OWNER that the backend is not expecting,

Re: [PATCH 4/5] hw/arm/aspeed: add a 'execute-in-place' property to boot directly from CE0

2020-01-07 Thread Philippe Mathieu-Daudé
On 1/7/20 8:34 AM, Cédric Le Goater wrote: The overhead for the OpenBMC firmware images using the a custom U-Boot is around 2 seconds, which is fine, but with a U-Boot from mainline, it takes an extra 50 seconds or so to reach Linux. A quick survey on the number of reads performed on the flash

Re: [PATCH] xhci: recheck slot status

2020-01-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200107083606.12393-1-kra...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: N/A. Internal error while reading log file The full log is available at

Re: [PATCH v1 00/59] trivial unneeded labels cleanup

2020-01-07 Thread Max Reitz
On 06.01.20 19:23, Daniel Henrique Barboza wrote: > Hello, > > This is the type of cleanup I've contributed to Libvirt > during the last year. Figured QEMU also deserves the same > care. > > The idea here is remove unneeded labels. By 'unneeded' I > mean labels that does nothing but a 'return'

Re: [PATCH v3 11/12] pnv/psi: Add device reset hook

2020-01-07 Thread Greg Kurz
On Tue, 7 Jan 2020 11:23:44 +1100 David Gibson wrote: > On Mon, Jan 06, 2020 at 03:56:44PM +0100, Cédric Le Goater wrote: > > From: Greg Kurz > > > > And call it from a QEMU reset handler. This allows each PNV child class to > > override the reset hook if needed, eg. POWER8 doesn't but POWER9

Re: [PATCH for-5.0 v11 08/20] virtio-iommu: Implement translate

2020-01-07 Thread Jean-Philippe Brucker
On Mon, Jan 06, 2020 at 12:58:50PM -0500, Peter Xu wrote: > On Mon, Jan 06, 2020 at 06:06:34PM +0100, Jean-Philippe Brucker wrote: > > On Fri, Dec 20, 2019 at 11:51:00AM -0500, Peter Xu wrote: > > > On Fri, Dec 20, 2019 at 05:26:42PM +0100, Jean-Philippe Brucker wrote: > > > > There is at the

Re: [PATCH v2] accel/kvm: Make "kernel_irqchip" default on

2020-01-07 Thread Paolo Bonzini
On 28/12/19 11:43, Xiaoyao Li wrote: > Commit 11bc4a13d1f4 ("kvm: convert "-machine kernel_irqchip" to an > accelerator property") moves kernel_irqchip property from "-machine" to > "-accel kvm", but it forgets to set the default value of > kernel_irqchip_allowed and kernel_irqchip_split. > >

Re: [PATCH 056/104] virtiofsd: add security guide document

2020-01-07 Thread Daniel P . Berrangé
On Mon, Jan 06, 2020 at 05:53:55PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrangé (berra...@redhat.com) wrote: > > On Thu, Dec 12, 2019 at 04:38:16PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: Stefan Hajnoczi > > > > > > Many people want to know: what's up with

[Bug 1856706] Re: target/mips/op_helper.c:971:duplicated branches ?

2020-01-07 Thread Philippe Mathieu-Daudé
** Tags added: mips -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1856706 Title: target/mips/op_helper.c:971:duplicated branches ? Status in QEMU: New Bug description:

Re: Making QEMU easier for management tools and applications

2020-01-07 Thread Michal Privoznik
On 1/7/20 10:36 AM, Kevin Wolf wrote: The easy way out would be tying libvirt to a specific QEMU version. And I'm only half joking. If libvirt didn't exist yet and we needed a management library for QEMU, what we would build now would probably not look much like libvirt looks today. We wouldn't

Re: [PATCH] hw/rtc/mc146818: Add missing dependency on ISA Bus

2020-01-07 Thread Paolo Bonzini
On 24/12/19 12:16, Philippe Mathieu-Daudé wrote: > The MC146818 sits on an ISA bus. Since it can not be used > without it, select ISA in the Kconfig. > > Fixes: 82f5181777e > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/rtc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH 077/104] virtiofsd: fix error handling in main()

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:37PM +, Dr. David Alan Gilbert (git) wrote: > From: Liu Bo > > Neither fuse_parse_cmdline() nor fuse_opt_parse() goes to the right place > to do cleanup. > > Signed-off-by: Liu Bo > --- > tools/virtiofsd/passthrough_ll.c | 5 +++-- > 1 file changed, 3

[PATCH] trace: update qemu-trace-stap to Python 3

2020-01-07 Thread Stefan Hajnoczi
qemu-trace-stap does not support Python 3 yet: $ scripts/qemu-trace-stap list path/to/qemu-system-x86_64 Traceback (most recent call last): File "scripts/qemu-trace-stap", line 175, in main() File "scripts/qemu-trace-stap", line 171, in main args.func(args) File

[PULL v2 28/32] virtio-mmio: update queue size on guest write

2020-01-07 Thread Michael S. Tsirkin
From: Denis Plotnikov Some guests read back queue size after writing it. Always update the on size write otherwise they might be confused. Cc: qemu-sta...@nongnu.org Signed-off-by: Denis Plotnikov Message-Id: <20191224081446.17003-1-dplotni...@virtuozzo.com> Reviewed-by: Michael S. Tsirkin

[PULL v2 23/32] vhost-user: add VHOST_USER_RESET_DEVICE to reset devices

2020-01-07 Thread Michael S. Tsirkin
From: Raphael Norwitz Add a VHOST_USER_RESET_DEVICE message which will reset the vhost user backend. Disabling all rings, and resetting all internal state, ready for the backend to be reinitialized. A backend has to report it supports this features with the VHOST_USER_PROTOCOL_F_RESET_DEVICE

[PULL v2 27/32] tests: add virtio-scsi and virtio-blk seg_max_adjust test

2020-01-07 Thread Michael S. Tsirkin
From: Denis Plotnikov It tests proper seg_max_adjust settings for all machine types except 'none', 'isapc', 'microvm' Signed-off-by: Denis Plotnikov Message-Id: <20191220140905.1718-3-dplotni...@virtuozzo.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[PULL v2 30/32] virtio-net: delete also control queue when TX/RX deleted

2020-01-07 Thread Michael S. Tsirkin
From: Yuri Benditovich https://bugzilla.redhat.com/show_bug.cgi?id=1708480 If the control queue is not deleted together with TX/RX, it later will be ignored in freeing cache resources and hot unplug will not be completed. Cc: qemu-sta...@nongnu.org Signed-off-by: Yuri Benditovich Message-Id:

Re: [PATCH 2/3] gitlab-ci.yml: Add a job to build EDK2 firmware binaries

2020-01-07 Thread Philippe Mathieu-Daudé
On 1/6/20 7:46 PM, Philippe Mathieu-Daudé wrote: Add a GitLab job to build the EDK2 firmware binaries. This job is only built when the roms/edk2/ submodule is updated, when a git-ref starts with 'edk2' or when the last commit contains 'EDK2'. GitLab CI generates an artifacts.zip file containing

[PULL v2 31/32] intel_iommu: a fix to vtd_find_as_from_bus_num()

2020-01-07 Thread Michael S. Tsirkin
From: Liu Yi L Ensure the return value of vtd_find_as_from_bus_num() is NULL by enforcing vtd_bus=NULL. This would help caller of vtd_find_as_from_bus_num() to decide if any further operation on the returned vtd_bus. Cc: qemu-sta...@nongnu.org Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Yi

Re: [PATCH RFC] i386/kvm: fix enlightened VMCS with fine-grained VMX feature enablement

2020-01-07 Thread Paolo Bonzini
On 02/01/20 21:39, Vitaly Kuznetsov wrote: > When enlightened VMCS is enabled, certain VMX controls disappear, e.g. > posted interrupts for PINBASED_CTLS. With fine-grained VMX feature > enablement QEMU tries to do KVM_SET_MSRS with default (matching CPU > model) values and fails as KVM doesn't

Re: [PATCH 03/14] hw/i386/Kconfig: Let the MicroVM machine select the SERIAL_ISA config

2020-01-07 Thread Philippe Mathieu-Daudé
On 1/7/20 11:00 AM, Paolo Bonzini wrote: On 31/12/19 19:32, Philippe Mathieu-Daudé wrote: When configured with --without-default-devices, the build fails: LINKx86_64-softmmu/qemu-system-x86_64 /usr/bin/ld: hw/i386/microvm.o: in function `microvm_devices_init':

Re: [PATCH] scripts/git.orderfile: Display decodetree before C source

2020-01-07 Thread Stefano Garzarella
On Mon, Dec 30, 2019 at 09:28:56AM +0100, Philippe Mathieu-Daudé wrote: > To avoid scrolling each instruction when reviewing tcg > helpers written for the decodetree script, display the > .decode files (similar to header declarations) before > the C source (implementation of previous

Re: [PULL v2 0/9] Add dbus-vmstate

2020-01-07 Thread Peter Maydell
On Mon, 6 Jan 2020 at 14:46, Marc-André Lureau wrote: > > The following changes since commit b0b74e1f17508cb8cef8afd698558db1bd8999cc: > > Merge remote-tracking branch > 'remotes/ehabkost/tags/python-next-pull-request' into staging (2020-01-06 > 11:39:55 +) > > are available in the Git

[PATCH v2 1/3] migration-test: Add migration multifd test

2020-01-07 Thread Juan Quintela
We set multifd-channels. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Thomas Huth Tested-by: Wei Yang Signed-off-by: Juan Quintela --- tests/migration-test.c | 56 ++ 1 file changed, 56 insertions(+) diff --git

Re: [PATCH 04/14] hw/i386: Restrict fw_cfg to the PC machines

2020-01-07 Thread Paolo Bonzini
On 31/12/19 19:32, Philippe Mathieu-Daudé wrote: > Only the PC-based machines use the fw_cfg device. In particular, > the MicroVM machine does not use it. Only compile/link it when > machines require it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Sergio Lopez > --- >

Re: [PATCH v1] hw: fix using 4.2 compat in 5.0 machine types for i440fx/q35

2020-01-07 Thread Paolo Bonzini
On 07/01/20 10:24, Cornelia Huck wrote: > On Mon, 23 Dec 2019 10:28:56 +0300 > Denis Plotnikov wrote: > >> 5.0 machine type uses 4.2 compats. This seems to be incorrect, since >> the latests machine type by now is 5.0 and it should use its own >> compat or shouldn't use any relying on the

Re: [PATCH 2/3] gitlab-ci.yml: Add a job to build EDK2 firmware binaries

2020-01-07 Thread Laszlo Ersek
On 01/06/20 19:46, Philippe Mathieu-Daudé wrote: > Add a GitLab job to build the EDK2 firmware binaries. > This job is only built when the roms/edk2/ submodule is updated, > when a git-ref starts with 'edk2' or when the last commit contains > 'EDK2'. keyword "or"; okay. > > GitLab CI generates

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-07 Thread Yuri Benditovich
On Mon, Jan 6, 2020 at 12:37 PM Yuri Benditovich < yuri.benditov...@daynix.com> wrote: > > On Mon, Jan 6, 2020 at 11:58 AM Michael S. Tsirkin wrote: > >> I guess it somehow has to do with the following: >> >> if (proxy->disable_legacy == ON_OFF_AUTO_AUTO) { >> proxy->disable_legacy =

[Bug 1851972] Re: pc-q35-4.1 and AMD Navi 5700/XT incompatible

2020-01-07 Thread Philippe Mathieu-Daudé
Paolo Bonzini commented on IRC: AMD avic requires kernel_irqchip=split. Can you try using it? (released QEMU uses -machine ...,kernel_irqchip=split, git QEMU expects -accel kernel_irqchip=split). -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [PATCH v2] hppa: allow max ram size upto 4Gb

2020-01-07 Thread Igor Mammedov
On Mon, 6 Jan 2020 18:03:49 +0100 Helge Deller wrote: > On 06.01.20 17:24, Igor Mammedov wrote: > > On Mon, 6 Jan 2020 12:28:51 +0100 > > Helge Deller wrote: > > > >> On 06.01.20 11:48, Igor Mammedov wrote: > >>> On Sat, 4 Jan 2020 16:00:19 +0100 > >>> Philippe Mathieu-Daudé wrote: > >>>

[PATCH v2 2/3] migration: Make sure that we don't call write() in case of error

2020-01-07 Thread Juan Quintela
If we are exiting due to an error/finish/ Just don't try to even touch the channel with one IO operation. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- migration/ram.c | 25 + 1 file changed, 25 insertions(+)

Re: [PATCH v1 57/59] linux-user/syscall.c: fix trailing whitespaces and style

2020-01-07 Thread Peter Maydell
On Mon, 6 Jan 2020 at 19:19, Daniel Henrique Barboza wrote: > > There are trailing whitespaces in this file that, if removed > by a text editor that refuses to let the traiing whitespace > alone, which happens to be the editor I am using, will cause > checkpatch.pl to warn about styling problems

Re: [PATCH 1/2] travis.yml: avocado: Print logs of non-pass tests only

2020-01-07 Thread Alex Bennée
Wainer dos Santos Moschetta writes: > The acceptance tests build on Travis is configured to print > the entire Avocado's job log in case any test fail. Usually one is > interested on failed tests only though. So this change the Travis > configuration in order to show the log of tests which

[PATCH v2 0/3] Fix multifd + cancel + multifd

2020-01-07 Thread Juan Quintela
Hi In the v2 series: - get the multifd test patch - drop the ->shutdown fix it break postcopy recovery test. Still trying to determine if the problem is inside the recover test or the recover code. - upgrade the migrate_cancel test Please review. [v1] This series: - create a test that

Re: [PATCH v2 3/7] configure: Do not force pie=no for non-x86

2020-01-07 Thread Philippe Mathieu-Daudé
On 12/18/19 11:34 PM, Richard Henderson wrote: PIE is supported on many other hosts besides x86. The default for non-x86 is now the same as x86: pie is used if supported, and may be forced via --enable/--disable-pie. The original commit (40d6444e91c) said: "Non-x86 are not changed, as they

Re: [PATCH 066/104] virtiofsd: passthrough_ll: add renameat2 support

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:26PM +, Dr. David Alan Gilbert (git) wrote: > From: Miklos Szeredi > > No glibc support yet, so use syscall(). It exists in glibc in my Fedora 31 install. Presumably this is related to an older version > Signed-off-by: Miklos Szeredi > --- >

Re: [PATCH v2 0/4] tcg: Include tcg files using tcg/ dirname, reduce cpp search path list

2020-01-07 Thread Paolo Bonzini
On 01/01/20 12:22, Philippe Mathieu-Daudé wrote: > Noticed we could clean this while reviewing Richard patch last night: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg667606.html > > Since v1: > - moved headers to include/tcg/ (Paolo) > - include in .inc.c relative to parent (Stefan) >

Re: [PATCH 062/104] virtiofsd: Handle hard reboot

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:22PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Handle a > mount > hard reboot (without unmount) > mount > > we get another 'init' which FUSE doesn't normally expect. > > Signed-off-by: Dr. David Alan Gilbert > --- >

Re: [Qemu-devel] [PATCH v3] RISC-V: Select FPU gdb xml file based on the supported extensions

2020-01-07 Thread Alex Bennée
Georg Kotheimer writes: > The size of the FPU registers depends solely on the floating point > extensions supported by the target architecture. > However, in the previous implementation the floating point register > size was derived from whether the target architecture is 32-bit or > 64-bit. >

Re: [PATCH v1 44/59] 9p-local.c: remove unneeded label in local_unlinkat_common()

2020-01-07 Thread Christian Schoenebeck
On Montag, 6. Januar 2020 19:24:10 CET Daniel Henrique Barboza wrote: > 'err_out' can be replaced by 'return ret' in the error conditions > the jump was being made. > > CC: Greg Kurz > Signed-off-by: Daniel Henrique Barboza > --- > hw/9pfs/9p-local.c | 12 +--- > 1 file changed, 5

Re: [PATCH 064/104] vhost-user: Print unexpected slave message types

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:24PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > When we receive an unexpected message type on the slave fd, print > the type. > > Signed-off-by: Dr. David Alan Gilbert > --- > hw/virtio/vhost-user.c | 2 +- > 1 file changed, 1

[PULL v2 26/32] virtio: make seg_max virtqueue size dependent

2020-01-07 Thread Michael S. Tsirkin
From: Denis Plotnikov Before the patch, seg_max parameter was immutable and hardcoded to 126 (128 - 2) without respect to queue size. This has two negative effects: 1. when queue size is < 128, we have Virtio 1.1 specfication violation: (2.6.5.3.1 Driver Requirements) seq_max must be <=

[PULL v2 29/32] virtio: reset region cache when on queue deletion

2020-01-07 Thread Michael S. Tsirkin
From: Yuri Benditovich https://bugzilla.redhat.com/show_bug.cgi?id=1708480 Fix leak of region reference that prevents complete device deletion on hot unplug. Cc: qemu-sta...@nongnu.org Signed-off-by: Yuri Benditovich Message-Id: <20191226043649.14481-2-yuri.benditov...@daynix.com> Reviewed-by:

Re: [kvm-unit-tests PATCH 14/16] arm/run: Allow Migration tests

2020-01-07 Thread Thomas Huth
On 16/12/2019 15.02, Eric Auger wrote: > Let's link getchar.o to use puts and getchar from the > tests. > > Then allow tests belonging to the migration group to > trigger the migration from the test code by putting > "migrate" into the uart. Then the code can wait for the > migration completion

[PATCH] hw/arm/acpi: Pack the SRAT processors structure by node_id ascending order

2020-01-07 Thread Zeng Tao
When booting the guest linux with the following numa configuration: -numa node,node_id=1,cpus=0-3 -numa node,node_id=0,cpus=4-7 We can get the following numa topology in the guest system: Architecture: aarch64 Byte Order:Little Endian CPU(s):8 On-line CPU(s)

Re: [PATCH v2 1/2] usb-host: remove 'remote wakeup' flag from configuration descriptor

2020-01-07 Thread Gerd Hoffmann
> > > GlobalProperty hw_compat_4_1[] = { > > > { "virtio-pci", "x-pcie-flr-init", "off" }, > > > +{ "usb-host", "suppress-remote-wake", "off" }, > > > }; > > > const size_t hw_compat_4_1_len = G_N_ELEMENTS(hw_compat_4_1); > > > > In case this doesn't get merged in QEMU 4.2.0, the patch

Re: [PATCH 2/5] hw/arm: ast2600: Wire up the eMMC controller

2020-01-07 Thread Philippe Mathieu-Daudé
On 1/7/20 8:34 AM, Cédric Le Goater wrote: From: Andrew Jeffery Initialise another SDHCI model instance for the AST2600's eMMC controller and use the SDHCI's num_slots value introduced previously to determine whether we should create an SD card instance for the new slot. Signed-off-by: Andrew

Re: [PATCH 03/14] hw/i386/Kconfig: Let the MicroVM machine select the SERIAL_ISA config

2020-01-07 Thread Paolo Bonzini
On 31/12/19 19:32, Philippe Mathieu-Daudé wrote: > When configured with --without-default-devices, the build fails: > > LINKx86_64-softmmu/qemu-system-x86_64 > /usr/bin/ld: hw/i386/microvm.o: in function `microvm_devices_init': > hw/i386/microvm.c:157: undefined reference to

Priority of -accel (was: [PATCH] tests/qemu-iotests: Update tests to recent desugarized -accel option)

2020-01-07 Thread Thomas Huth
On 06/01/2020 14.09, Philippe Mathieu-Daudé wrote: > Commit 6f6e1698a6 desugarized "-machine accel=" to a list > of "-accel" options. Since now "-machine accel" and "-accel" > became incompatible, update the iotests to the new format. > > Error reported here: >

Re: [PATCH] hw/arm/acpi: Pack the SRAT processors structure by node_id ascending order

2020-01-07 Thread Michael S. Tsirkin
On Tue, Jan 07, 2020 at 05:18:49PM +0800, Zeng Tao wrote: > When booting the guest linux with the following numa configuration: > -numa node,node_id=1,cpus=0-3 > -numa node,node_id=0,cpus=4-7 > We can get the following numa topology in the guest system: > Architecture: aarch64 > Byte

[Bug 1858046] Re: qemu-aarch64 hangs on cptofs during a build of NixOS SD card image

2020-01-07 Thread Philippe Mathieu-Daudé
** Tags added: linux-user -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1858046 Title: qemu-aarch64 hangs on cptofs during a build of NixOS SD card image Status in QEMU: New Bug description:

[PATCH v2 3/3] migration-test: Make sure that multifd and cancel works

2020-01-07 Thread Juan Quintela
Test that this sequerce works: - launch source - launch target - start migration - cancel migration - relaunch target - do migration again Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- - Wait for 1st trhead to move to cancelled before

[PATCH v2 0/1] block/rbd: Add support for ceph namespaces

2020-01-07 Thread Florian Florensa
Happy new year everyone, please find attached the v2 of the patch, updated with the input from Stefano, Jason and Eric. What has changed from v1 : - renamed the variables from nspace to namespace - made the argument in qapi optional - add the `(Since 5.0)` tag in qapi documentation Florian

Re: [PATCH 3/3] gitlab-ci-edk2.yml: Use ccache

2020-01-07 Thread Laszlo Ersek
On 01/06/20 19:46, Philippe Mathieu-Daudé wrote: > By using ccache we reduce the job duration from > 40 minutes 26 seconds to 32 minutes 6 seconds. > > Running after script... > $ ccache --show-stats > cache hit (direct) 6604 > files in cache 12090 >

Re: [PATCH v2 2/3] migration: Make sure that we don't call write() in case of error

2020-01-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > If we are exiting due to an error/finish/ Just don't try to even > touch the channel with one IO operation. > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Juan Quintela > --- > migration/ram.c | 25

Re: [PATCH v1 30/59] util/module.c: remove unneeded label in module_load_file()

2020-01-07 Thread Thomas Huth
On 06/01/2020 19.23, Daniel Henrique Barboza wrote: > 'out' can be replaced by the apropriate return values set > in 'ret' for each case. > > CC: Paolo Bonzini > Signed-off-by: Daniel Henrique Barboza > --- > util/module.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) >

Re: [PATCH 078/104] virtiofsd: cleanup allocated resource in se

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:38PM +, Dr. David Alan Gilbert (git) wrote: > From: Liu Bo > > This cleans up unfreed resources in se on quiting, including > se->virtio_dev, se->vu_socket_path, se->vu_socketfd. > > Signed-off-by: Liu Bo > --- > tools/virtiofsd/fuse_lowlevel.c | 7 +++ >

Re: [PATCH v2 3/3] migration-test: Make sure that multifd and cancel works

2020-01-07 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Test that this sequerce works: > > - launch source > - launch target > - start migration > - cancel migration > - relaunch target > - do migration again > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Juan

Re: [PATCH 086/104] virtiofsd: use fuse_lowlevel_is_virtio() in fuse_session_destroy()

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:46PM +, Dr. David Alan Gilbert (git) wrote: > From: Stefan Hajnoczi > > vu_socket_path is NULL when --fd=FDNUM was used. Use > fuse_lowlevel_is_virtio() instead. > > Signed-off-by: Stefan Hajnoczi > pull request 10 Extraneous line > --- >

Re: [PATCH v2] hppa: allow max ram size upto 4Gb

2020-01-07 Thread Helge Deller
On 07.01.20 12:21, Igor Mammedov wrote: > On Mon, 6 Jan 2020 18:03:49 +0100 >> So, I'd suggest to drop your wrong patch #43. > As you noted in your first reply, patch is correct. You probably got me wrong. Your patch #43 is wrong, and your fixup patch to some degree reverts it back again. In

[PULL v2 19/32] ACPI: add expected files for HMAT tests (acpihmat)

2020-01-07 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin --- tests/bios-tables-test-allowed-diff.h | 8 tests/data/acpi/pc/APIC.acpihmat | Bin 0 -> 128 bytes tests/data/acpi/pc/DSDT.acpihmat | Bin 0 -> 6455 bytes tests/data/acpi/pc/HMAT.acpihmat | Bin 0 -> 280 bytes

[PULL v2 20/32] virtio-mmio: Clear v2 transport state on soft reset

2020-01-07 Thread Michael S. Tsirkin
From: Jean-Philippe Brucker At the moment when the guest writes a status of 0, we only reset the virtio core state but not the virtio-mmio state. The virtio-mmio specification says (v1.1 cs01, 4.2.2.1 Device Requirements: MMIO Device Register Layout): Upon reset, the device MUST clear all

Re: [kvm-unit-tests PATCH 01/16] libcflat: Add other size defines

2020-01-07 Thread Thomas Huth
On 16/12/2019 15.02, Eric Auger wrote: > Introduce additional SZ_256, SZ_8K, SZ_16K macros that will > be used by ITS tests. > > Signed-off-by: Eric Auger > --- > lib/libcflat.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/libcflat.h b/lib/libcflat.h > index ea19f61..7092af2

Re: [PATCH] hw/timer/Kconfig: Intel 8254 PIT depends of ISA bus

2020-01-07 Thread Paolo Bonzini
On 06/01/20 18:19, Philippe Mathieu-Daudé wrote: > Since i8254_common.c calls isa_register_ioport() from "hw/isa/isa.h" > we can not select it when ISA_BUS is disabled. Add a 'depends on' > clause. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/timer/Kconfig | 1 + > 1 file changed, 1

[PULL v2 04/32] virtio-serial-bus: fix memory leak while attach virtio-serial-bus

2020-01-07 Thread Michael S. Tsirkin
From: Pan Nengyuan ivqs/ovqs/c_ivq/c_ovq is forgot to cleanup in virtio_serial_device_unrealize, the memory leak stack is as bellow: Direct leak of 1290240 byte(s) in 180 object(s) allocated from: #0 0x7fc9bfc27560 in calloc (/usr/lib64/libasan.so.3+0xc7560) #1 0x7fc9bed6f015 in

Re: [PATCH] hw/ppc/prep: Remove the deprecated "prep" machine and the OpenHackware BIOS

2020-01-07 Thread Thomas Huth
On 03/12/2019 08.29, Thomas Huth wrote: > It's been deprecated since QEMU v3.1. The 40p machine should be > used nowadays instead. > > Signed-off-by: Thomas Huth > --- > .gitmodules| 3 - > MAINTAINERS| 1 - > Makefile | 2 +- >

Re: [PATCH] x86: Check for machine state object class before typecasting it

2020-01-07 Thread Paolo Bonzini
On 30/12/19 14:17, Michal Prívozník wrote: > On 12/30/19 10:45 AM, Philippe Mathieu-Daudé wrote: >> On 12/30/19 10:35 AM, Michal Prívozník wrote: >>> On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: On 12/30/19 9:00 AM, Michal Privoznik wrote: > In v4.2.0-246-ged9e923c3c the SMM

Re: [PATCH 00/14] hw: Fix various --without-default-devices issues

2020-01-07 Thread Paolo Bonzini
On 31/12/19 19:32, Philippe Mathieu-Daudé wrote: > Various fixes when configured with --without-default-devices > and building each machine individually. > Adding the corresponding CI tests is out of the scope of this > series. > > This series is pushed on top of "hw/i386: Allow building >

RE: [PATCH] hw/arm/acpi: Pack the SRAT processors structure by node_id ascending order

2020-01-07 Thread Zengtao (B)
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, January 07, 2020 5:33 PM > To: Zengtao (B) > Cc: qemu-devel@nongnu.org; qemu-triv...@nongnu.org; Shannon Zhao; > Peter Maydell; Igor Mammedov; qemu-...@nongnu.org > Subject: Re: [PATCH] hw/arm/acpi:

Re: [PATCH 04/14] hw/i386: Restrict fw_cfg to the PC machines

2020-01-07 Thread Paolo Bonzini
On 31/12/19 19:32, Philippe Mathieu-Daudé wrote: > Only the PC-based machines use the fw_cfg device. In particular, > the MicroVM machine does not use it. Only compile/link it when > machines require it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Sergio Lopez > --- >

Re: [PATCH 3/3] gitlab-ci-edk2.yml: Use ccache

2020-01-07 Thread Philippe Mathieu-Daudé
On 1/7/20 11:19 AM, Laszlo Ersek wrote: On 01/06/20 19:46, Philippe Mathieu-Daudé wrote: By using ccache we reduce the job duration from 40 minutes 26 seconds to 32 minutes 6 seconds. Running after script... $ ccache --show-stats cache hit (direct) 6604 files in

Re: [PATCH 04/14] hw/i386: Restrict fw_cfg to the PC machines

2020-01-07 Thread Michael S. Tsirkin
On Tue, Jan 07, 2020 at 11:01:48AM +0100, Paolo Bonzini wrote: > On 31/12/19 19:32, Philippe Mathieu-Daudé wrote: > > Only the PC-based machines use the fw_cfg device. In particular, > > the MicroVM machine does not use it. Only compile/link it when > > machines require it. > > > > Signed-off-by:

Re: [PATCH 2/2] target/mips: Correct data on deprecated r4k machine

2020-01-07 Thread Thomas Huth
On 19/12/2019 15.15, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Change the release since r4k machine is deprecated from 4.2 to 5.0. > > Signed-off-by: Aleksandar Markovic > --- > qemu-deprecated.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [RFC PATCH] qapi: Incorrect attempt to fix building with MC146818RTC=n

2020-01-07 Thread Paolo Bonzini
On 31/12/19 19:49, Philippe Mathieu-Daudé wrote: > When configured with --without-default-devices and setting > MC146818RTC=n, the build fails: > > LINKx86_64-softmmu/qemu-system-x86_64 > /usr/bin/ld: qapi/qapi-commands-misc-target.o: in function > `qmp_marshal_rtc_reset_reinjection':

Re: [PATCH] scripts/git.orderfile: Display decodetree before C source

2020-01-07 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > To avoid scrolling each instruction when reviewing tcg > helpers written for the decodetree script, display the > .decode files (similar to header declarations) before > the C source (implementation of previous declarations). > > Signed-off-by: Philippe

Re: [PATCH 065/104] contrib/libvhost-user: Protect slave fd with mutex

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:25PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > In future patches we'll be performing commands on the slave-fd driven > by commands on queues, since those queues will be driven by individual > threads we need to make sure they

Re: [PATCH v2 0/3] Fix multifd + cancel + multifd

2020-01-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200107104914.1814-1-quint...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. The full log is

Re: [PATCH 069/104] virtiofsd: rename unref_inode() to unref_inode_lolocked()

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:29PM +, Dr. David Alan Gilbert (git) wrote: > From: Miklos Szeredi > > Signed-off-by: Miklos Szeredi > Signed-off-by: Stefan Hajnoczi > --- > tools/virtiofsd/passthrough_ll.c | 15 --- > 1 file changed, 8 insertions(+), 7 deletions(-)

Re: [PATCH 060/104] virtiofsd: Add timestamp to the log with FUSE_LOG_DEBUG level

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:20PM +, Dr. David Alan Gilbert (git) wrote: > From: Masayoshi Mizuma > > virtiofsd has some threads, so we see a lot of logs with debug option. > It would be useful for debugging if we can see the timestamp. > > Add nano second timestamp, which got by

Re: [PATCH 083/104] virtiofsd: fix incorrect error handling in lo_do_lookup

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:43PM +, Dr. David Alan Gilbert (git) wrote: > From: Eric Ren > > Signed-off-by: Eric Ren > --- > tools/virtiofsd/passthrough_ll.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o-

Re: [PATCH 063/104] virtiofsd: Kill threads when queues are stopped

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:23PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Kill the threads we've started when the queues get stopped. > > Signed-off-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_virtio.c | 37

Re: [PATCH 088/104] virtiofsd: make lo_release() atomic

2020-01-07 Thread Daniel P . Berrangé
On Thu, Dec 12, 2019 at 04:38:48PM +, Dr. David Alan Gilbert (git) wrote: > From: Stefan Hajnoczi > > Hold the lock across both lo_map_get() and lo_map_remove() to prevent > races between two FUSE_RELEASE requests. In this case I don't see a > serious bug but it's safer to do things

[PULL v2 17/32] tests/numa: Add case for QMP build HMAT

2020-01-07 Thread Michael S. Tsirkin
From: Tao Xu Check configuring HMAT usecase Acked-by: Markus Armbruster Suggested-by: Igor Mammedov Signed-off-by: Tao Xu Message-Id: <20191213011929.2520-8-tao3...@intel.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Reviewed-by: Igor Mammedov ---

  1   2   3   4   5   6   >