Re: [PATCH v2 1/3] Fixed assert in vhost_user_set_mem_table_postcopy

2020-02-06 Thread Michael S. Tsirkin
On Wed, Jan 15, 2020 at 09:57:04PM -0500, Raphael Norwitz wrote: > The current vhost_user_set_mem_table_postcopy() implementation > populates each region of the VHOST_USER_SET_MEM_TABLE message without > first checking if there are more than VHOST_MEMORY_MAX_NREGIONS already > populated. This can

Re: [PATCH v2 2/2] ppc/pnv: Fix PCI_EXPRESS dependency

2020-02-06 Thread Thomas Huth
On 06/02/2020 00.20, Laurent Vivier wrote: > When PHB4 bridge has been added, the dependencies to PCIE_PORT has been > added to XIVE_SPAPR and indirectly to PSERIES. > The build of the PowerNV machine is fine while we also build the PSERIES > machine. > If we disable the PSERIES machine, the

Re: [PATCH] monitor: fix memory leak in monitor_fdset_dup_fd_find_remove

2020-02-06 Thread Laurent Vivier
Le 15/01/2020 à 08:20, kuhn.chen...@huawei.com a écrit : > From: Chen Qun > > When remove dup_fd in monitor_fdset_dup_fd_find_remove function, > we need to free mon_fdset_fd_dup. ASAN shows memory leak stack: > > Direct leak of 96 byte(s) in 3 object(s) allocated from: > #0 0xfffd37b033b3

Re: [PATCH v3 09/21] quorum: Add QuorumChild.to_be_replaced

2020-02-06 Thread Max Reitz
On 05.02.20 16:38, Kevin Wolf wrote: > Am 30.01.2020 um 22:44 hat Max Reitz geschrieben: >> We will need this to verify that Quorum can let one of its children be >> replaced without breaking anything else. >> >> Signed-off-by: Max Reitz >> --- >> block/quorum.c | 25 + >>

Re: [PATCH] qemu-options: replace constant 1 with HAS_ARG

2020-02-06 Thread Laurent Vivier
Le 04/02/2020 à 17:56, John Snow a écrit : > This is the only instance of a non-zero constant not using a symbolic > constant. > --- > qemu-options.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 224a8e8712..ff3e806977 100644

Re: [PATCH v2 01/33] block: Add BlockDriver.is_format

2020-02-06 Thread Max Reitz
On 05.02.20 14:51, Eric Blake wrote: > On 2/4/20 11:08 AM, Max Reitz wrote: >> We want to unify child_format and child_file at some point.  One of the >> important things that set format drivers apart from other drivers is >> that they do not expect other format nodes under them (except in the >>

Re: [PATCH] aspeed/i2c:fix uninitialized variable warning

2020-02-06 Thread Thomas Huth
On 06/02/2020 05.07, kuhn.chen...@huawei.com wrote: > From: Chen Qun > > Fix warning: > hw/i2c/aspeed_i2c.c: In function ‘aspeed_i2c_bus_write’: > glib/glib-autocleanups.h:28:3: warning: ‘cmd_flags’ may be > used uninitialized in this function [-Wmaybe-uninitialized] >g_free (*pp); >

Re: VW ELF loader

2020-02-06 Thread Paolo Bonzini
On 05/02/20 07:06, David Gibson wrote: > On Tue, Feb 04, 2020 at 12:26:32AM +0100, Paolo Bonzini wrote: >> Il mar 4 feb 2020, 00:20 Alexey Kardashevskiy ha scritto: >>> Speaking seriously, what would I put into the guest? >> >> Only things that would be considered drivers. Ignore the partitions

Re: [PATCH] hw/smbios/smbios: Remove unused include

2020-02-06 Thread Laurent Vivier
Le 09/01/2020 à 12:25, Philippe Mathieu-Daudé a écrit : > Nothing from "sysemu/cpus.h" is used by smbios.c, remove the include. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/smbios/smbios.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c >

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-06 Thread Cornelia Huck
On Wed, 5 Feb 2020 13:21:26 -0500 "Jason J. Herne" wrote: > This fixes vfio-ccw when booting non-Linux operating systems. Without this > struct being packed, a few extra bytes of low core memory get overwritten when > we assign a value to memory address 0 in jump_to_IPL_2. This is enough to >

Re: qmp-shell for GSoC/Outreachy?

2020-02-06 Thread Daniel P . Berrangé
On Thu, Feb 06, 2020 at 10:40:37AM +0100, Markus Armbruster wrote: > > If the user screwsup, it should give an error that prompts the user > > to the parameter they got wrong. > > > > Output from commands should normally be pretty formatted (with an option > > to display raw json for those needing

Re: [PATCH v2 2/3] Refactor vhost_user_set_mem_table functions

2020-02-06 Thread Michael S. Tsirkin
On Wed, Jan 15, 2020 at 09:57:05PM -0500, Raphael Norwitz wrote: > vhost_user_set_mem_table() and vhost_user_set_mem_table_postcopy() have > gotten convoluted, and have some identical code. > > This change moves the logic populating the VhostUserMemory struct and > fds array from

Re: [PATCH v2 0/3] vhost-user: Lift Max Ram Slots Limitation

2020-02-06 Thread Michael S. Tsirkin
On Wed, Jan 15, 2020 at 09:57:03PM -0500, Raphael Norwitz wrote: > In QEMU today, a VM with a vhost-user device can hot add memory a > maximum of 8 times. See these threads, among others: > > [1] https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01046.html >

Re: [PATCH v1 00/13] Ram blocks with resizable anonymous allocations under POSIX

2020-02-06 Thread Michael S. Tsirkin
On Mon, Feb 03, 2020 at 07:31:12PM +0100, David Hildenbrand wrote: > We already allow resizable ram blocks for anonymous memory, however, they > are not actually resized. All memory is mmaped() R/W, including the memory > exceeding the used_length, up to the max_length. > > When resizing,

Re: [PATCH v1 07/13] util/mmap-alloc: Factor out populating of memory to mmap_populate()

2020-02-06 Thread David Hildenbrand
On 05.02.20 20:56, Murilo Opsfelder Araújo wrote: > Hello, David. > > On 2/3/20 3:31 PM, David Hildenbrand wrote: >> We want to populate memory within a reserved memory region. Let's factor >> that out. >> >> Cc: "Michael S. Tsirkin" >> Cc: Greg Kurz >> Cc: Murilo Opsfelder Araujo >> Cc:

Re: qmp-shell for GSoC/Outreachy?

2020-02-06 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * John Snow (js...@redhat.com) wrote: >> I'm forking the subject as I believe Markus wanted to focus on the >> machine interface aspect. >> >> I feel that a new human interface is *related* to that goal: the >> splitting of, and commitment to, separate human

Re: [PATCH for-5.0 3/4] Remove the core bluetooth code

2020-02-06 Thread Daniel P . Berrangé
On Wed, Feb 05, 2020 at 08:13:19PM +0100, Philippe Mathieu-Daudé wrote: > On 2/5/20 6:51 PM, Daniel P. Berrangé wrote: > > On Wed, Feb 05, 2020 at 06:40:31PM +0100, Aleksandar Markovic wrote: > >> On Sat, Feb 1, 2020 at 7:53 PM Philippe Mathieu-Daudé > >> wrote: > >>> > >> @@ -1151,10

Re: [PATCH for-5.0 v2 10/23] quorum: Implement .bdrv_recurse_can_replace()

2020-02-06 Thread Max Reitz
On 05.02.20 16:55, Kevin Wolf wrote: > Am 11.11.2019 um 17:02 hat Max Reitz geschrieben: >> Signed-off-by: Max Reitz >> --- >> block/quorum.c | 62 ++ >> 1 file changed, 62 insertions(+) >> >> diff --git a/block/quorum.c b/block/quorum.c >> index

RE: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-06 Thread Shameerali Kolothum Thodi
> -Original Message- > From: David Hildenbrand [mailto:da...@redhat.com] > Sent: 05 February 2020 16:41 > To: Shameerali Kolothum Thodi ; > Igor Mammedov > Cc: peter.mayd...@linaro.org; xiaoguangrong.e...@gmail.com; > m...@redhat.com; shannon.zha...@gmail.com; qemu-devel@nongnu.org; >

Re: VW ELF loader

2020-02-06 Thread Paolo Bonzini
On 05/02/20 06:58, David Gibson wrote: >> Yes, SLOF is big and slow. petitboot is not petit at all either, and >> has the disadvantage that you have to find a way to run GRUB afterwards. > Well, not usually. Petitboot parses grub configuration itself, which > means that generally from the OS /

Re: [PATCH v3 2/2] hw/timer/m48t59: Convert debug printf()s to trace events

2020-02-06 Thread Laurent Vivier
Le 17/01/2020 à 17:58, Philippe Mathieu-Daudé a écrit : > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/rtc/m48t59-internal.h | 5 - > hw/rtc/m48t59.c | 11 +-- > hw/rtc/trace-events | 6 ++ > 3 files changed, 11 insertions(+), 11 deletions(-) > > diff --git

Re: [PULL 00/16] testing updates

2020-02-06 Thread Peter Maydell
On Tue, 4 Feb 2020 at 18:40, Alex Bennée wrote: > > The following changes since commit 7bd9d0a9e26c7a3c67c0f174f0009ba19969b158: > > Merge remote-tracking branch > 'remotes/huth-gitlab/tags/pull-request-2020-02-04' into staging (2020-02-04 > 16:12:31 +) > > are available in the Git

Re: [PATCH v2 3/3] Lift max memory slots limit imposed by vhost-user

2020-02-06 Thread Michael S. Tsirkin
On Wed, Jan 15, 2020 at 09:57:06PM -0500, Raphael Norwitz wrote: > The current vhost-user implementation in Qemu imposes a limit on the > maximum number of memory slots exposed to a VM using a vhost-user > device. This change provides a new protocol feature > VHOST_USER_F_CONFIGURE_SLOTS which,

Re: [PATCH v1 08/13] util/mmap-alloc: Prepare for resizable mmaps

2020-02-06 Thread David Hildenbrand
On 06.02.20 00:00, Murilo Opsfelder Araújo wrote: > Hello, David. > > On Monday, February 3, 2020 3:31:20 PM -03 David Hildenbrand wrote: >> When shrinking a mmap we want to re-reserve the already populated area. >> When growing a memory region, we want to populate starting with a given >>

Re: [PATCH 09/17] block: Refactor bdrv_has_zero_init{,_truncate}

2020-02-06 Thread Max Reitz
On 05.02.20 19:39, Eric Blake wrote: > On 2/5/20 11:22 AM, Max Reitz wrote: > >> And thus callers which just want the trivially obtainable BDRV_ZERO_TRUNCATE info have to wait for the BDRV_ZERO_OPEN inquiry, even though they don’t care about that flag. >>> >>> True, but only to a

[PATCH] tests/plugin: prevent uninitialized warning

2020-02-06 Thread kuhn.chenqun
From: Chen Qun According to the glibc function requirements, we need initialise the variable. Otherwise there will be compilation warnings: glib-autocleanups.h:28:3: warning: ‘out’ may be used uninitialized in this function [-Wmaybe-uninitialized] g_free (*pp); ^~~~ Reported-by:

Re: [PATCH] MAINTAINERS: Cover hppa-softmmu.mak in the HP-PARISC Machines section

2020-02-06 Thread Laurent Vivier
Le 29/01/2020 à 20:03, Philippe Mathieu-Daudé a écrit : > Modifications to default-configs/hppa-softmmu.mak should be > reviewed by the hppa-softmmu users (currently a single machine). > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > >

Re: [PATCH] hw/pci/pci_bridge: Fix typo in comment

2020-02-06 Thread Laurent Vivier
Le 05/02/2020 à 19:51, Julia Suvorova a écrit : > Signed-off-by: Julia Suvorova > --- > include/hw/pci/pci_bridge.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/pci/pci_bridge.h b/include/hw/pci/pci_bridge.h > index ba488818d2..99c674e949 100644 > ---

Re: [PATCH] tests/plugin: prevent uninitialized warning

2020-02-06 Thread Thomas Huth
On 06/02/2020 10.32, kuhn.chen...@huawei.com wrote: > From: Chen Qun > > According to the glibc function requirements, we need initialise > the variable. Otherwise there will be compilation warnings: > > glib-autocleanups.h:28:3: warning: ‘out’ may be > used uninitialized in this function

Re: [PATCH 2/2] aspeed/i2c: Prevent uninitialized warning

2020-02-06 Thread Laurent Vivier
Le 21/01/2020 à 10:28, mreza...@redhat.com a écrit : > From: Miroslav Rezanina > > Compiler reports uninitialized warning for cmd_flags variable. > > Adding NULL initialization to prevent this warning. > > Signed-off-by: Miroslav Rezanina > --- > hw/i2c/aspeed_i2c.c | 2 +- > 1 file changed,

Re: [PATCH v2] qxl: introduce hardware revision 5

2020-02-06 Thread Maxim Levitsky
On Thu, 2020-02-06 at 08:43 +0100, Gerd Hoffmann wrote: > The only difference to hardware revision 4 is that the device doesn't > switch to VGA mode in case someone happens to touch a VGA register, > which should make things more robust in configurations with multiple > vga devices. > > Swtiching

Re: [PATCH 00/17] Improve qcow2 all-zero detection

2020-02-06 Thread Max Reitz
On 05.02.20 20:21, Eric Blake wrote: > On 2/5/20 11:04 AM, Max Reitz wrote: >> OK, I expected users to come in a separate patch. > > I can refactor that better in v2. > >> >>> That's the use case: when copying into a destination file, it's useful >>> to know if the destination already reads as

Re: [PATCH] aspeed/i2c:fix uninitialized variable warning

2020-02-06 Thread Laurent Vivier
Le 06/02/2020 à 09:21, Thomas Huth a écrit : > On 06/02/2020 05.07, kuhn.chen...@huawei.com wrote: >> From: Chen Qun >> >> Fix warning: >> hw/i2c/aspeed_i2c.c: In function ‘aspeed_i2c_bus_write’: >> glib/glib-autocleanups.h:28:3: warning: ‘cmd_flags’ may be >> used uninitialized in this function

Re: [EXTERNAL] Re: [PATCH] MAINTAINERS: update Leif Lindholm's address

2020-02-06 Thread Laurent Vivier
Le 17/01/2020 à 14:18, Leif Lindholm a écrit : > On Thu, Jan 16, 2020 at 19:25:52 +0100, Philippe Mathieu-Daudé wrote: >> On 1/16/20 6:42 PM, Leif Lindholm wrote: >>> Update address to reflect new employer. >>> >>> Signed-off-by: Leif Lindholm >>> --- >>> MAINTAINERS | 2 +- >>> 1 file

Re: [PATCH] hw/bt: Remove empty Kconfig file

2020-02-06 Thread Laurent Vivier
Le 23/01/2020 à 07:45, Thomas Huth a écrit : > While removing the bluetooth code some weeks ago, I had to leave the > hw/bt/Kconfig file around. Otherwise some of the builds would have been > broken since the generated dependency files tried to include it before > they were rebuilt. Meanwhile, all

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-06 Thread Christian Borntraeger
On 05.02.20 19:21, Jason J. Herne wrote: > This fixes vfio-ccw when booting non-Linux operating systems. Without this > struct being packed, a few extra bytes of low core memory get overwritten when > we assign a value to memory address 0 in jump_to_IPL_2. This is enough to > cause some

Re: [PATCH] qemu-img: Place the '-i aio' option in alphabetical order

2020-02-06 Thread Laurent Vivier
Le 05/02/2020 à 18:17, Philippe Mathieu-Daudé a écrit : > Cc'ing qemu-trivial@ > > On 2/5/20 5:30 PM, Julia Suvorova wrote: >> The '-i AIO' option was accidentally placed after '-n' and '-t'. Move it >> after '--flush-interval'. >> >> Signed-off-by: Julia Suvorova >> --- >>  

Re: [PATCH v2 4/4] Add the NVMM acceleration enlightenments

2020-02-06 Thread Kamil Rytarowski
On 03.02.2020 12:54, Philippe Mathieu-Daudé wrote: >> @@ -2029,6 +2072,19 @@ static void qemu_whpx_start_vcpu(CPUState *cpu) >>   #endif >>   } >> >> +static void qemu_nvmm_start_vcpu(CPUState *cpu) >> +{ >> +    char thread_name[VCPU_THREAD_NAME_SIZE]; >> + >> +    cpu->thread =

Re: [PATCH v2 1/3] Fixed assert in vhost_user_set_mem_table_postcopy

2020-02-06 Thread Michael S. Tsirkin
On Thu, Feb 06, 2020 at 03:17:04AM -0500, Michael S. Tsirkin wrote: > On Wed, Jan 15, 2020 at 09:57:04PM -0500, Raphael Norwitz wrote: > > The current vhost_user_set_mem_table_postcopy() implementation > > populates each region of the VHOST_USER_SET_MEM_TABLE message without > > first checking if

Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups

2020-02-06 Thread Dr. David Alan Gilbert
* John Snow (js...@redhat.com) wrote: > > > On 1/28/20 11:47 AM, Dr. David Alan Gilbert wrote: > > * John Snow (js...@redhat.com) wrote: > >> > >> > >> On 1/27/20 3:43 PM, Peter Krempa wrote: > >>> On Mon, Jan 27, 2020 at 14:39:02 -0500, John Snow wrote: > > > On 1/27/20 5:36 AM,

Re: [PATCH v1 00/13] Ram blocks with resizable anonymous allocations under POSIX

2020-02-06 Thread David Hildenbrand
On 06.02.20 10:27, Michael S. Tsirkin wrote: > On Mon, Feb 03, 2020 at 07:31:12PM +0100, David Hildenbrand wrote: >> We already allow resizable ram blocks for anonymous memory, however, they >> are not actually resized. All memory is mmaped() R/W, including the memory >> exceeding the used_length,

Re: [PATCH] hw/i386/vmmouse: Fix crash when using the vmmouse on a machine without vmport

2020-02-06 Thread Laurent Vivier
Le 29/01/2020 à 12:29, Thomas Huth a écrit : > QEMU currently crashes when the user tries to use the "vmmouse" on a > machine without vmport, e.g.: > > $ x86_64-softmmu/qemu-system-x86_64 -machine microvm -device vmmouse > Segmentation fault (core dumped) > > or: > > $

[PATCH v7 00/41] target/arm: Implement ARMv8.1-VHE

2020-02-06 Thread Richard Henderson
Version 7 has one more tweak to the vhe tlb flushing that Peter asked for. All patches have reviews. r~ Alex Bennée (1): target/arm: check TGE and E2H flags for EL0 pauth traps Richard Henderson (40): target/arm: Define isar_feature_aa64_vh target/arm: Enable HCR_E2H for VHE

[PATCH v7 01/41] target/arm: Define isar_feature_aa64_vh

2020-02-06 Thread Richard Henderson
Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/cpu.h | 5 + 1 file changed, 5 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 608fcbd0b7..2a53f5d09b 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -3685,6

Re: [PATCH v2 04/33] block: Add BdrvChildRole to BdrvChild

2020-02-06 Thread Max Reitz
On 05.02.20 16:33, Eric Blake wrote: > On 2/4/20 11:08 AM, Max Reitz wrote: >> For now, it is always set to 0.  Later patches in this series will >> ensure that all callers pass an appropriate combination of flags. > > Sneaky - this re-adds the field you dropped as part of a rename in 2/33. >  

[PATCH v7 04/41] target/arm: Add TTBR1_EL2

2020-02-06 Thread Richard Henderson
At the same time, add writefn to TTBR0_EL2 and TCR_EL2. A later patch will update any ASID therein. Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- v5: Do not update TCR_EL2 yet; delay that til we handle ASIDs. --- target/arm/helper.c | 13 - 1

[PATCH v7 19/41] target/arm: Reorganize ARMMMUIdx

2020-02-06 Thread Richard Henderson
Prepare for, but do not yet implement, the EL2&0 regime. This involves adding the new MMUIdx enumerators and adjusting some of the MMUIdx related predicates to match. Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/cpu-param.h | 2 +-

[PATCH v7 25/41] target/arm: Add the hypervisor virtual counter

2020-02-06 Thread Richard Henderson
Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/cpu-qom.h | 1 + target/arm/cpu.h | 11 + target/arm/cpu.c | 3 ++- target/arm/helper.c | 56 4 files changed, 65 insertions(+), 6

[PATCH v7 35/41] target/arm: Update get_a64_user_mem_index for VHE

2020-02-06 Thread Richard Henderson
The EL2&0 translation regime is affected by Load Register (unpriv). The code structure used here will facilitate later changes in this area for implementing UAO and NV. Tested-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/cpu.h | 9

Re: [PATCH] mailmap: Add entry about me

2020-02-06 Thread Philippe Mathieu-Daudé
Hello, I suggest changing the subject to: "mailmap: Add entry for Yu-Chen Lin" On 12/6/19 3:15 PM, Philippe Mathieu-Daudé wrote: Cc'ing qemu-trivial@ On 12/6/19 3:09 PM, Yu-Chen Lin wrote: I have two mail address, add entries for showing author and email correctly. Signed-off-by: Yu-Chen

[PATCH v7 34/41] target/arm: check TGE and E2H flags for EL0 pauth traps

2020-02-06 Thread Richard Henderson
From: Alex Bennée According to ARM ARM we should only trap from the EL1&0 regime. Tested-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/pauth_helper.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [PATCH] pc-bios/s390x: Pack ResetInfo struct

2020-02-06 Thread Thomas Huth
On 06/02/2020 11.09, Christian Borntraeger wrote: > > > On 05.02.20 19:21, Jason J. Herne wrote: >> This fixes vfio-ccw when booting non-Linux operating systems. Without this >> struct being packed, a few extra bytes of low core memory get overwritten >> when >> we assign a value to memory

[PATCH v7 29/41] target/arm: Add VHE timer register redirection and aliasing

2020-02-06 Thread Richard Henderson
Apart from the wholesale redirection that HCR_EL2.E2H performs for EL2, there's a separate redirection specific to the timers that happens for EL0 when running in the EL2&0 regime. Tested-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/helper.c | 181

Re: [PATCH v2 09/33] block: Add generic bdrv_inherited_options()

2020-02-06 Thread Max Reitz
On 05.02.20 17:48, Eric Blake wrote: > On 2/4/20 11:08 AM, Max Reitz wrote: >> After the series this patch belongs to, we want to have a common >> BdrvChildClass that encompasses all of child_file, child_format, and >> child_backing.  Such a single class needs a single .inherit_options() >>

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-06 Thread David Hildenbrand
On 06.02.20 11:20, Shameerali Kolothum Thodi wrote: > > >> -Original Message- >> From: David Hildenbrand [mailto:da...@redhat.com] >> Sent: 05 February 2020 16:41 >> To: Shameerali Kolothum Thodi ; >> Igor Mammedov >> Cc: peter.mayd...@linaro.org; xiaoguangrong.e...@gmail.com; >>

[PATCH 2/2] aspeed/smc: Fix User mode select/unselect scheme

2020-02-06 Thread Cédric Le Goater
The Aspeed SMC Controller can operate in different modes : Read, Fast Read, Write and User modes. When the User mode is configured, it selects automatically the SPI slave device until the CE_STOP_ACTIVE bit is set to 1. When any other modes are configured the device is unselected. The HW logic

[PATCH 1/2] aspeed/smc: Add some tracing

2020-02-06 Thread Cédric Le Goater
Signed-off-by: Cédric Le Goater --- Makefile.objs | 1 + hw/ssi/aspeed_smc.c | 17 + hw/ssi/trace-events | 9 + 3 files changed, 27 insertions(+) create mode 100644 hw/ssi/trace-events diff --git a/Makefile.objs b/Makefile.objs index 26b9cff95436..9e4ba95794e9

[PATCH 0/2] aspeed/smc: fix data corruption on witherspoon machines

2020-02-06 Thread Cédric Le Goater
Hello, We have been seeing a squashfs corruption on the witherspoon-bmc machine for quite some time. It boots but quickly after boot corruption errors start to fill the console. This machine has two BMC chips with UBIfs on them. The romulus-bmc machine has a similar problem when both PNOR are

RE: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-06 Thread Shameerali Kolothum Thodi
> -Original Message- > From: David Hildenbrand [mailto:da...@redhat.com] > Sent: 06 February 2020 10:56 > To: Shameerali Kolothum Thodi ; > Igor Mammedov > Cc: peter.mayd...@linaro.org; xiaoguangrong.e...@gmail.com; > m...@redhat.com; shannon.zha...@gmail.com; qemu-devel@nongnu.org; >

Re: [PATCH v2 25/33] block: Make filter drivers use child_of_bds

2020-02-06 Thread Max Reitz
On 06.02.20 00:02, Eric Blake wrote: > On 2/4/20 11:08 AM, Max Reitz wrote: >> Note that some filters have secondary children, namely blkverify (the >> image to be verified) and blklogwrites (the log).  This patch does not >> touch those children. > > I would have guessed blkdebug; but I guess

Re: [PATCH v2 22/33] block: Make backing files child_of_bds children

2020-02-06 Thread Max Reitz
On 05.02.20 23:45, Eric Blake wrote: > On 2/4/20 11:08 AM, Max Reitz wrote: >> Signed-off-by: Max Reitz > > Another sparse commit message (a recurring theme of this series). The > subject line says 'what', and the patch appears to be faithful to that, > but if a future bisection lands here, even

Re: [PATCH v2 1/6] ui: add show-cursor option

2020-02-06 Thread Markus Armbruster
Gerd Hoffmann writes: > When enabled, this forces showing the mouse cursor, i.e. do > not allow the guest to hide it. Defaults to off. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Ján Tomko > --- > qapi/ui.json | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/qapi/ui.json

Re: [PATCH v1 08/13] util/mmap-alloc: Prepare for resizable mmaps

2020-02-06 Thread Murilo Opsfelder Araújo
Hello, David. On Thursday, February 6, 2020 5:52:26 AM -03 David Hildenbrand wrote: > On 06.02.20 00:00, Murilo Opsfelder Araújo wrote: > > Hello, David. > > > > On Monday, February 3, 2020 3:31:20 PM -03 David Hildenbrand wrote: > >> When shrinking a mmap we want to re-reserve the already

Re: [PATCH v11 2/2] docs: qcow2: introduce compression type feature

2020-02-06 Thread Max Reitz
On 31.01.20 19:15, Vladimir Sementsov-Ogievskiy wrote: > 31.01.2020 20:49, Eric Blake wrote: >> On 1/31/20 11:34 AM, Alberto Garcia wrote: >>> On Fri 31 Jan 2020 03:46:12 PM CET, Eric Blake wrote: > +    If the incompatible bit "Compression type" is > set: the field > + 

Re: [PATCH] mailmap: Add entry about me

2020-02-06 Thread Yu-Chen Lin
Hi, Thank you for your suggestion, I will send v2 with new subject. Also, I will ack in v2 mail by my Synology account. Thanks. Philippe Mathieu-Daudé 於 2020年2月6日 週四 下午7:08寫道: > Hello, > > I suggest changing the subject to: > "mailmap: Add entry for Yu-Chen Lin" > > On 12/6/19 3:15 PM,

[PULL 00/17] Block patches

2020-02-06 Thread Max Reitz
The following changes since commit 418fa86dd465b4fd8394373cf83db8fa65d7611c: Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-040220-1' into staging (2020-02-04 18:55:06 +) are available in the Git repository at: https://github.com/XanClic/qemu.git

[PULL 01/17] qcow2: Assert that host cluster offsets fit in L2 table entries

2020-02-06 Thread Max Reitz
From: Alberto Garcia The standard cluster descriptor in L2 table entries has a field to store the host cluster offset. When we need to get that offset from an entry we use L2E_OFFSET_MASK to ensure that we only use the bits that belong to that field. But while that mask is used every time we

[PULL 02/17] block: Use a GString in bdrv_perm_names()

2020-02-06 Thread Max Reitz
From: Alberto Garcia This is a bit more efficient than having to allocate and free memory for each new permission. The default size (30) is enough for "consistent read, write, resize". Signed-off-by: Alberto Garcia Message-id: 20200110171518.22168-1-be...@igalia.com Reviewed-by: Eric Blake

Re: [PATCH] mailmap: Add entry about me

2020-02-06 Thread Philippe Mathieu-Daudé
On 2/6/20 1:50 PM, Yu-Chen Lin wrote: Hi, Thank you for your suggestion, I will send v2 with new subject. Also, I will ack in v2 mail by my Synology account. Well I have to split https://www.mail-archive.com/qemu-devel@nongnu.org/msg671676.html for the same reasons, so I can include your

Re: [RFC PATCH 2/2] GitLab CI: crude mapping of PMM's scripts to jobs

2020-02-06 Thread Philippe Mathieu-Daudé
On 2/6/20 2:03 PM, Philippe Mathieu-Daudé wrote: On 2/3/20 4:23 AM, Cleber Rosa wrote: This is a crude and straightforward mapping of Peter's "remake-merge-builds" and "pull-buildtest" scripts. Some characteristics were removed for simplicity sake (but eventually will), including:   * number

[PULL 11/17] qcow2: Don't round the L1 table allocation up to the sector size

2020-02-06 Thread Max Reitz
From: Alberto Garcia The L1 table is read from disk using the byte-based bdrv_pread() and is never accessed beyond its last element, so there's no need to allocate more memory than that. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz Message-id:

[PULL 12/17] qcow2: Tighten cluster_offset alignment assertions

2020-02-06 Thread Max Reitz
From: Alberto Garcia qcow2_alloc_cluster_offset() and qcow2_get_cluster_offset() always return offsets that are cluster-aligned so don't just check that they are sector-aligned. The check in qcow2_co_preadv_task() is also replaced by an assertion for the same reason. Signed-off-by: Alberto

Re: [PATCH v2 0/6] ui: rework -show-cursor option

2020-02-06 Thread Gerd Hoffmann
On Thu, Feb 06, 2020 at 11:52:05AM +, Peter Maydell wrote: > On Thu, 6 Feb 2020 at 11:29, Gerd Hoffmann wrote: > > > > > > This cover letter is missing a description of what the patchset does... > > The closest thing the patchset seems to get to documentation is the > oneliner in ui.json: >

Re: [PATCH v1 06/13] util/mmap-alloc: Factor out reserving of a memory region to mmap_reserve()

2020-02-06 Thread David Hildenbrand
On 06.02.20 12:55, Richard Henderson wrote: > On 2/3/20 6:31 PM, David Hildenbrand wrote: >> We want to reserve a memory region without actually populating memory. >> Let's factor that out. >> >> Cc: "Michael S. Tsirkin" >> Cc: Greg Kurz >> Cc: Murilo Opsfelder Araujo >> Cc: Eduardo Habkost >>

[PATCH] .readthedocs.yml: specify some minimum python requirements

2020-02-06 Thread Alex Bennée
QEMU is all about the Python 3 now so lets also hint that to ReadTheDocs in its config file. Signed-off-by: Alex Bennée --- .readthedocs.yml | 17 + 1 file changed, 17 insertions(+) create mode 100644 .readthedocs.yml diff --git a/.readthedocs.yml b/.readthedocs.yml new file

[PATCH v7 14/41] target/arm: Rename ARMMMUIdx_S1E2 to ARMMMUIdx_E2

2020-02-06 Thread Richard Henderson
This is part of a reorganization to the set of mmu_idx. The non-secure EL2 regime only has a single stage translation; there is no point in pointing out that the idx is for stage1. Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/cpu.h | 4

[PATCH v7 16/41] target/arm: Expand TBFLAG_ANY.MMUIDX to 4 bits

2020-02-06 Thread Richard Henderson
We are about to expand the number of mmuidx to 10, and so need 4 bits. For the benefit of reading the number out of -d exec, align it to the penultimate nibble. Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/cpu.h | 16 1 file

[PATCH v7 09/41] target/arm: Rename ARMMMUIdx*_S12NSE* to ARMMMUIdx*_E10_*

2020-02-06 Thread Richard Henderson
This is part of a reorganization to the set of mmu_idx. This emphasizes that they apply to the EL1&0 regime. The ultimate goal is -- Non-secure regimes: ARMMMUIdx_E10_0, ARMMMUIdx_E20_0, ARMMMUIdx_E10_1, ARMMMUIdx_E2, ARMMMUIdx_E20_2, -- Secure regimes:

[PATCH v7 05/41] target/arm: Update CNTVCT_EL0 for VHE

2020-02-06 Thread Richard Henderson
The virtual offset may be 0 depending on EL, E2H and TGE. Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/helper.c | 40 +--- 1 file changed, 37 insertions(+), 3 deletions(-) diff --git a/target/arm/helper.c

[PATCH v7 20/41] target/arm: Add regime_has_2_ranges

2020-02-06 Thread Richard Henderson
Create a predicate to indicate whether the regime has both positive and negative addresses. Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- target/arm/internals.h | 18 ++ target/arm/helper.c| 23 ++-

[PATCH v7 31/41] target/arm: Flush tlbs for E2&0 translation regime

2020-02-06 Thread Richard Henderson
Tested-by: Alex Bennée Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v5: Flush all EL2 regimes with TLBI ALLE2 (pmm). v7: Flush all EL2 regimes with TLBI VAE2 (pmm). --- target/arm/helper.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff

[PATCH v2 0/6] ui: rework -show-cursor option

2020-02-06 Thread Gerd Hoffmann
Gerd Hoffmann (6): ui: add show-cursor option ui/gtk: implement show-cursor option ui/sdl: implement show-cursor option ui/cocoa: implement show-cursor option ui: wire up legacy -show-cursor option ui: deprecate legacy -show-cursor option include/sysemu/sysemu.h | 1 - ui/gtk.c

Re: [PATCH v3 1/2] MAINTAINERS: Cc the qemu-...@nongnu.org for the ARM machines

2020-02-06 Thread Laurent Vivier
Le 20/01/2020 à 19:59, Philippe Mathieu-Daudé a écrit : > Not all ARM machines sections Cc the qemu-...@nongnu.org list, > fix this. > > Reviewed-by: Alistair Francis > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Also fix STM32F405 (commit 529fc5fd3) > and Netduino Plus 2 (commit

[PATCH v2 4/6] ui/cocoa: implement show-cursor option

2020-02-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/cocoa.m | 4 1 file changed, 4 insertions(+) diff --git a/ui/cocoa.m b/ui/cocoa.m index fbb5b1b45f81..f7b323044582 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -125,6 +125,7 @@ typedef struct { NSWindow *normalWindow, *about_window; static

Re: [PATCH v1 02/13] exec: Factor out setting ram settings (madvise ...) into qemu_ram_apply_settings()

2020-02-06 Thread Richard Henderson
On 2/3/20 6:31 PM, David Hildenbrand wrote: > Factor all settings out into qemu_ram_apply_settings(). > > For memory_try_enable_merging(), the important bit is that it won't be > called with XEN - which is now still the case as new_block->host will > remain NULL. > > Cc: Richard Henderson > Cc:

Re: [PATCH v1 06/13] util/mmap-alloc: Factor out reserving of a memory region to mmap_reserve()

2020-02-06 Thread Richard Henderson
On 2/3/20 6:31 PM, David Hildenbrand wrote: > We want to reserve a memory region without actually populating memory. > Let's factor that out. > > Cc: "Michael S. Tsirkin" > Cc: Greg Kurz > Cc: Murilo Opsfelder Araujo > Cc: Eduardo Habkost > Cc: "Dr. David Alan Gilbert" > Signed-off-by: David

[PATCH v3 4/4] Add the NVMM acceleration enlightenments

2020-02-06 Thread Kamil Rytarowski
From: Maxime Villard Implements the NVMM accelerator cpu enlightenments to actually use the nvmm-all accelerator on NetBSD platforms. Signed-off-by: Maxime Villard Signed-off-by: Kamil Rytarowski Reviewed-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé --- cpus.c|

[PATCH v3 2/4] Add the NetBSD Virtual Machine Monitor accelerator.

2020-02-06 Thread Kamil Rytarowski
From: Maxime Villard Introduces the configure support for the new NetBSD Virtual Machine Monitor that allows for hypervisor acceleration from usermode components on the NetBSD platform. Signed-off-by: Maxime Villard Signed-off-by: Kamil Rytarowski Reviewed-by: Sergio Lopez Reviewed-by:

Re: qmp-shell for GSoC/Outreachy?

2020-02-06 Thread Daniel P . Berrangé
On Thu, Feb 06, 2020 at 01:11:58PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Feb 06, 2020 at 10:40:37AM +0100, Markus Armbruster wrote: > >> > If the user screwsup, it should give an error that prompts the user > >> > to the parameter they got wrong. > >> > > >>

[PULL 08/12] qemu-options: replace constant 1 with HAS_ARG

2020-02-06 Thread Laurent Vivier
From: John Snow This is the only instance of a non-zero constant not using a symbolic constant. Reviewed-by: Eric Blake Signed-off-by: John Snow Message-Id: <20200204165638.25051-1-js...@redhat.com> Signed-off-by: Laurent Vivier --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1

[PULL 10/12] hw/pci/pci_bridge: Fix typo in comment

2020-02-06 Thread Laurent Vivier
From: Julia Suvorova Signed-off-by: Julia Suvorova Reviewed-by: Stefan Hajnoczi Message-Id: <20200205185123.210209-1-jus...@redhat.com> Signed-off-by: Laurent Vivier --- include/hw/pci/pci_bridge.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PULL 02/12] monitor: fix memory leak in monitor_fdset_dup_fd_find_remove

2020-02-06 Thread Laurent Vivier
From: Chen Qun When remove dup_fd in monitor_fdset_dup_fd_find_remove function, we need to free mon_fdset_fd_dup. ASAN shows memory leak stack: Direct leak of 96 byte(s) in 3 object(s) allocated from: #0 0xfffd37b033b3 in __interceptor_calloc (/lib64/libasan.so.4+0xd33b3) #1

[PULL 11/12] aspeed/i2c: Prevent uninitialized warning

2020-02-06 Thread Laurent Vivier
From: Miroslav Rezanina Compiler reports uninitialized warning for cmd_flags variable. Adding NULL initialization to prevent this warning. Signed-off-by: Miroslav Rezanina Reviewed-by: Thomas Huth Message-Id: <07957dcab31f65de3dd30efa91e6b9152ac79879.1579598240.git.mreza...@redhat.com>

[PULL 07/12] MAINTAINERS: Cover hppa-softmmu.mak in the HP-PARISC Machines section

2020-02-06 Thread Laurent Vivier
From: Philippe Mathieu-Daudé Modifications to default-configs/hppa-softmmu.mak should be reviewed by the hppa-softmmu users (currently a single machine). Signed-off-by: Philippe Mathieu-Daudé Acked-by: Helge Deller Message-Id: <20200129190316.16901-1-phi...@redhat.com> Signed-off-by: Laurent

[PULL 15/17] qcow2: Use BDRV_SECTOR_SIZE instead of the hardcoded value

2020-02-06 Thread Max Reitz
From: Alberto Garcia This replaces all remaining instances in the qcow2 code. Signed-off-by: Alberto Garcia Message-id: b5f74b606c2d9873b12d29acdb7fd498029c4025.1579374329.git.be...@igalia.com Reviewed-by: Max Reitz Signed-off-by: Max Reitz --- block/qcow2.c | 8 +--- 1 file changed, 5

[PULL 05/17] iotests: remove 'linux' from default supported platforms

2020-02-06 Thread Max Reitz
From: John Snow verify_platform will check an explicit whitelist and blacklist instead. The default will now be assumed to be allowed to run anywhere. For tests that do not specify their platforms explicitly, this has the effect of enabling these tests on non-linux platforms. For tests that

[PULL 10/17] iotests: Enable more tests in the 'auto' group to improve test coverage

2020-02-06 Thread Max Reitz
From: Thomas Huth According to Kevin, tests 030, 040 and 041 are among the most valuable tests that we have, so we should always run them if possible, even if they take a little bit longer. According to Max, it would be good to have a test for iothreads and migration. 127 and 256 seem to be

[PULL 2/3] docs: Fix typo in qemu-nbd -P replacement

2020-02-06 Thread Eric Blake
The suggested replacement for the deprecated 'qemu-nbd -P' refers to 'file.backing.opt' instead of 'file.file.opt'; using the example verbatim results in: qemu-nbd: Failed to blk_new_open 'driver=raw,offset=1m,size=100m,file.driver=qcow2,file.backing.driver=file,file.backing.filename=file4': A

[PATCH 0/1] target/arm: Reduce aa64_va_parameter overhead

2020-02-06 Thread Richard Henderson
Based-on: <20200206105448.4726-1-richard.hender...@linaro.org> ("target/arm: Implement ARMv8.1-VHE") It's not really dependent on VHE, but there's a minor patch conflict which I've resolved in favor of the larger patch set. r~ Richard Henderson (1): target/arm: Split out

Re: [PATCH 02/13] qcrypto-luks: implement encryption key management

2020-02-06 Thread Daniel P . Berrangé
On Thu, Feb 06, 2020 at 02:20:11PM +0100, Markus Armbruster wrote: > One more question regarding the array in > > { 'struct': 'QCryptoBlockAmendOptionsLUKS', > 'data' : { > 'keys': ['LUKSKeyslotUpdate'], > '*unlock-secret' : 'str' } } > > Why an array?

  1   2   3   4   5   6   >