Re: [PATCH RFC 02/14] migration: judge whether or not the RDMA is used for migration

2020-02-13 Thread Juan Quintela
Zhimin Feng wrote: > Signed-off-by: Zhimin Feng > --- > migration/migration.c | 10 ++ > migration/migration.h | 1 + > 2 files changed, 11 insertions(+) > > diff --git a/migration/migration.c b/migration/migration.c > index 10a13e0c79..819089a7ea 100644 > --- a/migration/migration.c >

Re: [RFC 2/2] pci-expender-bus:Add pcie-root-port to pxb-pcie under arm.

2020-02-13 Thread Michael S. Tsirkin
On Thu, Feb 13, 2020 at 03:49:52PM +0800, Yubo Miao wrote: > From: miaoyubo > > Since devices could not directly plugged into pxb-pcie, Hmm is this different from the root port? intergrated devices do exist for that actually. > under arm, how is arm special? > one > pcie-root port is plugged

Re: [PATCH] migration/postcopy: not necessary to discard all RAM at the beginning

2020-02-13 Thread Dr. David Alan Gilbert
* Wei Yang (richardw.y...@linux.intel.com) wrote: > ram_discard_range() unmap page for specific range. To be specific, this > clears related page table entries so that userfault would be triggered. > But this step is not necessary at the very beginning. > > ram_postcopy_incoming_init() is called

Re: VW ELF loader

2020-02-13 Thread Paolo Bonzini
On 13/02/20 02:43, Alexey Kardashevskiy wrote: > > Ok. So, I have made a small firmware which does OF CI, loads GRUB and > instantiates RTAS: > https://github.com/aik/of1275 > Quite raw but gives the idea. > > It does not contain drivers and still relies on QEMU to hook an OF path > to a

[PATCH v3 5/9] linux-user: mips: Update syscall numbers to kernel 5.5 level

2020-02-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Update mips syscall numbers based on Linux kernel tag v5.5. CC: Aurelien Jarno CC: Aleksandar Rikalo Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier --- linux-user/mips/syscall_nr.h | 45 +++ linux-user/mips64/syscall_nr.h | 50

[PATCH v3 6/9] linux-user: sh4: Update syscall numbers to kernel 5.5 level

2020-02-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Update sh4 syscall numbers based on Linux kernel v5.5. CC: Aurelien Jarno Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier --- linux-user/sh4/syscall_nr.h | 48 + 1 file changed, 48 insertions(+) diff --git

[PATCH v3 2/9] linux-user: arm: Update syscall numbers to kernel 5.5 level

2020-02-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Update arm syscall numbers based on Linux kernel v5.5. CC: Peter Maydell Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier --- linux-user/arm/syscall_nr.h | 44 1 file changed, 44 insertions(+) diff --git

Re: [PATCH v2] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init

2020-02-13 Thread Philippe Mathieu-Daudé
On 2/13/20 3:56 AM, kuhn.chen...@huawei.com wrote: From: Chen Qun It's easy to reproduce as follow: virsh qemu-monitor-command vm1 --pretty '{"execute": "device-list-properties", "arguments":{"typename":"exynos4210.uart"}}' ASAN shows memory leak stack: #1 0xfffd896d71cb in g_malloc0

Re: [RFC 1/2] arm: acpi: pci-expender-bus: Make arm to support PXB-PCIE

2020-02-13 Thread Michael S. Tsirkin
On Thu, Feb 13, 2020 at 03:49:51PM +0800, Yubo Miao wrote: > From: miaoyubo > > Currently virt machine is not supported by pxb-pcie, > and only one main host bridge described in ACPI tables. > Under this circumstance, different io numas for differnt devices > is not possible, in order to present

[PULL 3/6] migration/rdma: rdma_accept_incoming_migration fix error handling

2020-02-13 Thread Juan Quintela
From: "Dr. David Alan Gilbert" rdma_accept_incoming_migration is called from an fd handler and can't return an Error * anywhere. Currently it's leaking Error's in errp/local_err - there's no point putting them in there unless we can report them. Turn most into fprintf's, and the last into an

[PULL 2/6] migration: Optimization about wait-unplug migration state

2020-02-13 Thread Juan Quintela
From: Keqian Zhu qemu_savevm_nr_failover_devices() is originally designed to get the number of failover devices, but it actually returns the number of "unplug-pending" failover devices now. Moreover, what drives migration state to wait-unplug should be the number of "unplug-pending" failover

[PULL 0/6] Pull migration patches

2020-02-13 Thread Juan Quintela
The following changes since commit e18e5501d8ac692d32657a3e1ef545b14e72b730: Merge remote-tracking branch 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20200210' into staging (2020-02-10 18:09:14 +) are available in the Git repository at: https://github.com/juanquintela/qemu.git

[PULL 4/6] tests/migration: Add some slack to auto converge

2020-02-13 Thread Juan Quintela
From: "Dr. David Alan Gilbert" There's an assert in autoconverge that checks that we quit the iteration when we go below the expected threshold. Philippe saw a case where this assert fired with the measured value slightly over the threshold. (about 3k out of a few million). I can think of two

Re: [PATCH v2 fixed 00/16] Ram blocks with resizable anonymous allocations under POSIX

2020-02-13 Thread David Hildenbrand
On 12.02.20 19:03, David Hildenbrand wrote: > On 12.02.20 14:42, David Hildenbrand wrote: >> We already allow resizable ram blocks for anonymous memory, however, they >> are not actually resized. All memory is mmaped() R/W, including the memory >> exceeding the used_length, up to the max_length.

Re: [PATCH v2 1/2] spapr: Disable legacy virtio devices for pseries-5.0 and later

2020-02-13 Thread Greg Kurz
On Thu, 13 Feb 2020 11:58:36 +1100 David Gibson wrote: > PAPR specifies a kind of odd, paravirtualized PCI bus, which looks to > the guess mostly like classic PCI, even if some of the individual > devices on the bus are PCI Express. One consequence of that is that > virtio-pci devices still

Re: The issues about architecture of the COLO checkpoint

2020-02-13 Thread Dr. David Alan Gilbert
* Daniel Cho (daniel...@qnap.com) wrote: > Hi Hailiang, > > 1. > OK, we will try the patch > “0001-COLO-Optimize-memory-back-up-process.patch”, > and thanks for your help. > > 2. > We understand the reason to compare PVM and SVM's packet. However, the > empty of SVM's packet queue might

Re: [PATCH v2 0/2] spapr: Use vIOMMU translation for virtio by default

2020-02-13 Thread Greg Kurz
On Thu, 13 Feb 2020 11:58:35 +1100 David Gibson wrote: > Upcoming Secure VM support for pSeries machines introduces some > complications for virtio, since the transfer buffers need to be > explicitly shared so that the hypervisor can access them. > > While it's not strictly speaking dependent

Re: [PATCH v2 5/9] linux-user: mips: Update syscall numbers to kernel 5.5 level

2020-02-13 Thread Aleksandar Markovic
 > > + MIPS_SYS(sys_clock_gettime64, 2) > > + MIPS_SYS(sys_clock_settime64, 4) > > + MIPS_SYS(sys_clock_adjtime64, 2) /* 405 */ > > + MIPS_SYS(sys_clock_getres_time64, 4) > > According to > https://github.com/strace/strace/blob/master/linux/syscallent-common-32.h: > > [BASE_NR + 406] = { 2, 0,

[PATCH v3 4/9] linux-user: microblaze: Update syscall numbers to kernel 5.5 level

2020-02-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Update microblaze syscall numbers based on Linux kernel v5.5. CC: Edgar E. Iglesias Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier --- linux-user/microblaze/syscall_nr.h | 45 ++ 1 file changed, 45 insertions(+)

Re: [PATCH v5 4/8] multifd: Add multifd-zlib-level parameter

2020-02-13 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Jan 30, 2020 at 09:03:00AM +0100, Markus Armbruster wrote: >> Juan Quintela writes: >> >> > It will indicate which level use for compression. >> > >> > Signed-off-by: Juan Quintela >> >> This is slightly confusing (there is no zlib compression), unless

Re: [PATCH v2 1/2] target/arm: Fix select for aa64_va_parameters_both

2020-02-13 Thread Peter Maydell
On Thu, 13 Feb 2020 at 13:12, Peter Maydell wrote: > > On Tue, 11 Feb 2020 at 19:42, Richard Henderson > wrote: > > > > Select should always be 0 for a regime with one range. > > > > Signed-off-by: Richard Henderson > > This change makes sense, and matches what aa32_va_parameters() does, > but

Re: [PATCH v9 22/23] fuzz: add virtio-scsi fuzz target

2020-02-13 Thread Stefan Hajnoczi
On Tue, Feb 11, 2020 at 03:35:09PM -0500, Alexander Bulekov wrote: > diff --git a/tests/qtest/fuzz/virtio_scsi_fuzz.c > b/tests/qtest/fuzz/virtio_scsi_fuzz.c > new file mode 100644 > index 00..f62f512a26 > --- /dev/null > +++ b/tests/qtest/fuzz/virtio_scsi_fuzz.c > @@ -0,0 +1,214 @@ > +/*

Re: [PATCH] block: make BlockConf.*_size properties 32-bit

2020-02-13 Thread Roman Kagan
On Thu, Feb 13, 2020 at 06:47:10AM -0600, Eric Blake wrote: > On 2/13/20 2:01 AM, Roman Kagan wrote: > > On Wed, Feb 12, 2020 at 03:44:19PM -0600, Eric Blake wrote: > > > On 2/11/20 5:54 AM, Roman Kagan wrote: > > > > Devices (virtio-blk, scsi, etc.) and the block layer are happy to use > > > >

Re: [PATCH v3 12/13] hw/arm/raspi: Use a unique raspi_machine_class_init() method

2020-02-13 Thread Peter Maydell
On Sat, 8 Feb 2020 at 16:57, Philippe Mathieu-Daudé wrote: > > With the exception of the ignore_memory_transaction_failures > flag set for the raspi2, both machine_class_init() methods > are now identical. Merge them to keep a unique method. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH v5 7/8] multifd: Add multifd-zstd-level parameter

2020-02-13 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela >> --- >> migration/migration.c | 15 +++ >> monitor/hmp-cmds.c| 4 >> qapi/migration.json | 29 ++--- >> 3 files changed, 45

Re: [PATCH v3 12/13] hw/arm/raspi: Use a unique raspi_machine_class_init() method

2020-02-13 Thread Philippe Mathieu-Daudé
On 2/13/20 2:59 PM, Peter Maydell wrote: On Sat, 8 Feb 2020 at 16:57, Philippe Mathieu-Daudé wrote: With the exception of the ignore_memory_transaction_failures flag set for the raspi2, both machine_class_init() methods are now identical. Merge them to keep a unique method. Signed-off-by:

Re: [PATCH v3 12/13] hw/arm/raspi: Use a unique raspi_machine_class_init() method

2020-02-13 Thread Peter Maydell
On Thu, 13 Feb 2020 at 14:16, Philippe Mathieu-Daudé wrote: > On 2/13/20 2:59 PM, Peter Maydell wrote: > > The natural way to implement this is to have the .class_data > > be a pointer to a struct which is in an array and defines > > relevant per-class stuff, the same way we do in > >

Re: [PATCH RFC 03/14] migration/rdma: Create multiFd migration threads

2020-02-13 Thread Juan Quintela
Zhimin Feng wrote: > Creation of the multifd send threads for RDMA migration, > nothing inside yet. > > Signed-off-by: Zhimin Feng > --- > migration/multifd.c | 33 +--- > migration/multifd.h | 2 + > migration/qemu-file.c | 5 +++ > migration/qemu-file.h | 1 + >

Re: [PATCH v2] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2020-02-13 Thread Stefan Hajnoczi
On Thu, Feb 13, 2020 at 12:28:25PM +0300, Denis Plotnikov wrote: > > > On 13.02.2020 12:08, Stefan Hajnoczi wrote: > > On Thu, Feb 13, 2020 at 11:08:35AM +0300, Denis Plotnikov wrote: > > > On 12.02.2020 18:43, Stefan Hajnoczi wrote: > > > > On Tue, Feb 11, 2020 at 05:14:14PM +0300, Denis

Re: [PATCH] block: make BlockConf.*_size properties 32-bit

2020-02-13 Thread Eric Blake
On 2/13/20 2:01 AM, Roman Kagan wrote: On Wed, Feb 12, 2020 at 03:44:19PM -0600, Eric Blake wrote: On 2/11/20 5:54 AM, Roman Kagan wrote: Devices (virtio-blk, scsi, etc.) and the block layer are happy to use 32-bit for logical_block_size, physical_block_size, and min_io_size. However, the

Re: [PATCH v2 2/2] target/arm: Split out aa64_va_parameter_tbi, aa64_va_parameter_tbid

2020-02-13 Thread Peter Maydell
On Tue, 11 Feb 2020 at 19:42, Richard Henderson wrote: > > For the purpose of rebuild_hflags_a64, we do not need to compute > all of the va parameters, only tbi. Moreover, we can compute them > in a form that is more useful to storing in hflags. > > This eliminates the need for

Re: [PATCH] console: make QMP screendump use coroutine

2020-02-13 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> Thanks to the QMP coroutine support, the screendump handler can >> trigger a graphic_hw_update(), yield and let the main loop run until >> update is done. Then the handler is resumed, and the ppm_save() will >> write the screen image to disk in the coroutine

Re: [PATCH/RFC 0/1] Vhost User Cross Cable: Intro

2020-02-13 Thread Nikos Dragazis
On Tue, 14 Jan 2020 at 10:20 Stefan Hajnoczi wrote: > On Fri, Jan 10, 2020 at 10:34 AM Marc-André Lureau > wrote: > > On Wed, Jan 8, 2020 at 5:57 AM V. wrote: > > Hi V., > I think I remember you from Etherboot/gPXE days :). > > > > 3. > > > Now if Cross Cable is actually a new and (after a

Re: [RFC v3 14/25] intel_iommu: add virtual command capability support

2020-02-13 Thread Peter Xu
On Thu, Feb 13, 2020 at 02:40:45AM +, Liu, Yi L wrote: > > From: Peter Xu > > Sent: Wednesday, February 12, 2020 5:57 AM > > To: Liu, Yi L > > Subject: Re: [RFC v3 14/25] intel_iommu: add virtual command capability > > support > > > > On Wed, Jan 29, 2020 at 04:16:45AM -0800, Liu, Yi L

Re: [PATCH RFC 00/14] *** multifd for RDMA v2 ***

2020-02-13 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200213093755.370-1-fengzhim...@huawei.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH 2/2] util: add util function buffer_zero_avx512()

2020-02-13 Thread Paolo Bonzini
On 13/02/20 08:52, Robert Hoo wrote: > + > +} > +#pragma GCC pop_options > +#endif > + > + > /* Note that for test_buffer_is_zero_next_accel, the most preferred > * ISA must have the least significant bit. > */ > -#define CACHE_AVX21 > -#define CACHE_SSE42 > -#define CACHE_SSE24 >

Re: [RESEND RFC PATCH v2 1/2] target/arm: Allow to inject SError interrupt

2020-02-13 Thread Gavin Shan
On 2/13/20 4:39 PM, Richard Henderson wrote: On 2/12/20 7:49 PM, Gavin Shan wrote: On 2/12/20 10:34 PM, Peter Maydell wrote: Yeah, this is on my list to look at; Richard Henderson also could have a look at it. From a quick scan I suspect you may be missing handling for AArch32. [Thanks for

Re: [PATCH] hw/arm: ast2400/ast2500: Wire up EHCI controllers

2020-02-13 Thread Peter Maydell
On Thu, 6 Feb 2020 at 18:34, Guenter Roeck wrote: > > Initialize EHCI controllers on AST2400 and AST2500 using the existing > TYPE_PLATFORM_EHCI. After this change, booting ast2500-evb into Linux > successfully instantiates a USB interface. > > ehci-platform 1e6a3000.usb: EHCI Host Controller >

Re: [PATCH v9 02/23] softmmu: move vl.c to softmmu/

2020-02-13 Thread Stefan Hajnoczi
On Tue, Feb 11, 2020 at 03:34:49PM -0500, Alexander Bulekov wrote: > Signed-off-by: Alexander Bulekov > --- > Makefile.objs | 2 -- > Makefile.target | 1 + > softmmu/Makefile.objs | 2 ++ > vl.c => softmmu/vl.c | 0 > 4 files changed, 3 insertions(+), 2 deletions(-) Please

Re: [PATCH 2/2] util: add util function buffer_zero_avx512()

2020-02-13 Thread Robert Hoo
On Thu, 2020-02-13 at 11:30 +0100, Paolo Bonzini wrote: > On 13/02/20 08:52, Robert Hoo wrote: > > + > > +} > > +#pragma GCC pop_options > > +#endif > > + > > + > > /* Note that for test_buffer_is_zero_next_accel, the most > > preferred > > * ISA must have the least significant bit. > > */ >

[Bug 1863096] [NEW] vhost-user multi-queues interrupt failed when Qemu reconnection happens

2020-02-13 Thread Cheng Jiang
Public bug reported: After upgrade qemu to v4.2.0, vhost-user multi-queues interrupt failed with event idx interrupt mode when reconnection happens. Test Environment: DPDK version: DPDK v19.11 Other software versions: qemu 4.2.0. OS: Linux 4.15.0-20-generic Compiler: gcc (Ubuntu 7.3.0-16ubuntu3)

Re: [PATCH v5 0/6] small vhost changes and in-band notifications

2020-02-13 Thread Johannes Berg
On Thu, 2020-01-23 at 09:17 +0100, Johannes Berg wrote: > Hi, > > Here's a repost of all the patches I sent back in August, with the > in-band notifications rebased over the reset patch, so IDs have now > changed a bit. Ping? The patches still apply on top of latest qemu. I wanted to send some

Re: [PATCH] migration-test: fix some memleaks in migration-test

2020-02-13 Thread Laurent Vivier
On 11/02/2020 09:45, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > spotted by asan, 'check-qtest-aarch64' runs fail if sanitizers is enabled. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan > --- > tests/qtest/migration-test.c | 14 -- > 1 file changed, 12

Re: [PATCH] docs: Fix virtiofsd.1 location

2020-02-13 Thread Paolo Bonzini
On 12/02/20 18:51, Peter Maydell wrote: > On Wed, 12 Feb 2020 at 16:51, Philippe Mathieu-Daudé > wrote: >> We stopped testing in-tree builds 2 months ago: >> >> commit bc4486fb233573e77b6e9ad6d6379afb5e37ad8c >> Author: Paolo Bonzini >> Date: Wed Dec 11 15:33:49 2019 +0100 >> >> ci:

Re: [RESEND RFC PATCH v2 1/2] target/arm: Allow to inject SError interrupt

2020-02-13 Thread Peter Maydell
On Thu, 13 Feb 2020 at 03:49, Gavin Shan wrote: > On 2/12/20 10:34 PM, Peter Maydell wrote: > > Yeah, this is on my list to look at; Richard Henderson also could > > have a look at it. From a quick scan I suspect you may be missing > > handling for AArch32. > Yes, the functionality is only

Re: [RESEND RFC PATCH v2 2/2] target/arm: Support NMI injection

2020-02-13 Thread Peter Maydell
On Wed, 5 Feb 2020 at 11:06, Gavin Shan wrote: > > This supports QMP/HMP "nmi" command by injecting SError interrupt to > guest, which is expected to crash with that. Currently, It's supported > on two CPU models: "host" and "max". > > Signed-off-by: Gavin Shan > --- > hw/arm/virt.c |

Re: [PATCH v2 5/9] linux-user: mips: Update syscall numbers to kernel 5.5 level

2020-02-13 Thread Laurent Vivier
Le 13/02/2020 à 02:46, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > Update mips syscall numbers based on Linux kernel tag v5.5. > > CC: Aurelien Jarno > CC: Aleksandar Rikalo > Signed-off-by: Aleksandar Markovic > --- > linux-user/mips/syscall_nr.h | 45

[PULL 1/5] linux-user: add missing TARGET_SIGRTMIN for hppa

2020-02-13 Thread Laurent Vivier
This signal is defined for all other targets and we will need it later Signed-off-by: Laurent Vivier [pm: that this was actually an ABI change in the hppa kernel (at kernel version 3.17, kernel commit 1f25df2eff5b25f52c139d). Before that SIGRTMIN was 37... All our other HPPA TARGET_SIG* values

[PULL 5/5] linux-user: implement TARGET_SO_PEERSEC

2020-02-13 Thread Laurent Vivier
"The purpose of this option is to allow an application to obtain the security credentials of a Unix stream socket peer. It is analogous to SO_PEERCRED (which provides authentication using standard Unix credentials of pid, uid and gid), and extends this concept to other security models." --

[PULL 4/5] linux-user: fix use of SIGRTMIN

2020-02-13 Thread Laurent Vivier
Some RT signals can be in use by glibc, it's why SIGRTMIN (34) is generally greater than __SIGRTMIN (32). So SIGRTMIN cannot be mapped to TARGET_SIGRTMIN. Instead of swapping only SIGRTMIN and SIGRTMAX, map all the range [TARGET_SIGRTMIN ... TARGET_SIGRTMAX - X] to [__SIGRTMIN + X ...

[PULL 3/5] linux-user: fix TARGET_NSIG and _NSIG uses

2020-02-13 Thread Laurent Vivier
Valid signal numbers are between 1 (SIGHUP) and SIGRTMAX. System includes define _NSIG to SIGRTMAX + 1, but QEMU (like kernel) defines TARGET_NSIG to TARGET_SIGRTMAX. Fix all the checks involving the signal range. Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell Tested-by: Taylor

[PULL 0/5] Linux user for 5.0 patches

2020-02-13 Thread Laurent Vivier
The following changes since commit e18e5501d8ac692d32657a3e1ef545b14e72b730: Merge remote-tracking branch 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20200210' into staging (2020-02-10 18:09:14 +) are available in the Git repository at: git://github.com/vivier/qemu.git

Re: [PATCH v5 0/6] small vhost changes and in-band notifications

2020-02-13 Thread Michael S. Tsirkin
On Thu, Feb 13, 2020 at 02:26:10PM +0100, Johannes Berg wrote: > On Thu, 2020-01-23 at 09:17 +0100, Johannes Berg wrote: > > Hi, > > > > Here's a repost of all the patches I sent back in August, with the > > in-band notifications rebased over the reset patch, so IDs have now > > changed a bit. >

Re: [RFC 2/2] pci-expender-bus:Add pcie-root-port to pxb-pcie under arm.

2020-02-13 Thread Daniel P . Berrangé
On Thu, Feb 13, 2020 at 03:49:52PM +0800, Yubo Miao wrote: > From: miaoyubo > > Since devices could not directly plugged into pxb-pcie, under arm, one > pcie-root port is plugged into pxb-pcie. Due to the bus for each pxb-pcie > is defined as 2 in acpi dsdt tables(one for pxb-pcie, one for

Re: [PATCH v3 03/13] hw/arm/raspi: Extract the version from the board revision

2020-02-13 Thread Philippe Mathieu-Daudé
On 2/13/20 2:40 PM, Peter Maydell wrote: On Sat, 8 Feb 2020 at 16:57, Philippe Mathieu-Daudé wrote: The board revision encode the board version. Add a helper to extract the version, and use it. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/raspi.c | 31 +++

Re: [PATCH v3 00/13] hw/arm/raspi: Dynamically create machines based on the board revision

2020-02-13 Thread Peter Maydell
On Sat, 8 Feb 2020 at 16:57, Philippe Mathieu-Daudé wrote: > > Hi, > > This series is a preparatory to easily add the raspi0/raspi1/raspi4 > boards (see [1]). > > Igor has been working in his "refactor main RAM allocation to use > hostmem backend" series, and now v4 [2] is almost reviewed. > >

Re: [PATCH v5 7/8] multifd: Add multifd-zstd-level parameter

2020-02-13 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Juan Quintela (quint...@redhat.com) wrote: > >> Signed-off-by: Juan Quintela > >> --- > >> migration/migration.c | 15 +++ > >> monitor/hmp-cmds.c| 4 > >> qapi/migration.json | 29

Re: [PATCH] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init

2020-02-13 Thread Markus Armbruster
Eduardo Habkost writes: > On Wed, Feb 12, 2020 at 08:39:55AM +0100, Philippe Mathieu-Daudé wrote: >> Cc'ing Eduardo & Markus. >> >> On 2/12/20 7:44 AM, Chenqun (kuhn) wrote: >> > > -Original Message- >> > > From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com] >> > > Sent: Wednesday,

Re: [PATCH] migration-test: fix some memleaks in migration-test

2020-02-13 Thread Juan Quintela
wrote: > From: Pan Nengyuan > > spotted by asan, 'check-qtest-aarch64' runs fail if sanitizers is enabled. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Juan Quintela

Re: [PATCH] acpi: cpuhp: document CPHP_GET_CPU_ID_CMD command

2020-02-13 Thread Michael S. Tsirkin
On Wed, Feb 12, 2020 at 11:27:34PM +0100, Laszlo Ersek wrote: > Michael, > > On 01/29/20 15:06, Igor Mammedov wrote: > > Commit 3a61c8db9d25 introduced CPHP_GET_CPU_ID_CMD command but > > did not sufficiently describe it. Fix it by adding missing command > > documentation. > > > > Fixes:

Re: [PATCH v2] hw/arm: ast2600: Wire up EHCI controllers

2020-02-13 Thread Peter Maydell
On Fri, 7 Feb 2020 at 17:45, Guenter Roeck wrote: > > Initialize EHCI controllers on AST2600 using the existing > TYPE_PLATFORM_EHCI. After this change, booting ast2600-evb > into Linux successfully instantiates a USB interface after > the necessary changes are made to its devicetree files. > >

Re: [PATCH v2 fixed 13/16] numa: Teach ram block notifiers about resizable ram blocks

2020-02-13 Thread Paul Durrant
On Wed, 12 Feb 2020 at 14:44, David Hildenbrand wrote: > > We want to actually resize ram blocks (make everything between > used_length and max_length inaccessible) - however, not all ram block > notifiers will support that. Let's teach the notifier that ram blocks > are indeed resizable, but

Re: [PATCH v2] virtio: increase virtuqueue size for virtio-scsi and virtio-blk

2020-02-13 Thread Denis Plotnikov
On 13.02.2020 14:45, Stefan Hajnoczi wrote: On Thu, Feb 13, 2020 at 12:28:25PM +0300, Denis Plotnikov wrote: On 13.02.2020 12:08, Stefan Hajnoczi wrote: On Thu, Feb 13, 2020 at 11:08:35AM +0300, Denis Plotnikov wrote: On 12.02.2020 18:43, Stefan Hajnoczi wrote: On Tue, Feb 11, 2020 at

Re: [PATCH v2 1/2] target/arm: Fix select for aa64_va_parameters_both

2020-02-13 Thread Peter Maydell
On Tue, 11 Feb 2020 at 19:42, Richard Henderson wrote: > > Select should always be 0 for a regime with one range. > > Signed-off-by: Richard Henderson This change makes sense, and matches what aa32_va_parameters() does, but I think we need to update some of the callsites. (1) In

Re: [PATCH v2 1/2] target/arm: Fix select for aa64_va_parameters_both

2020-02-13 Thread Peter Maydell
On Thu, 13 Feb 2020 at 13:12, Peter Maydell wrote: > > On Tue, 11 Feb 2020 at 19:42, Richard Henderson > wrote: > > > > Select should always be 0 for a regime with one range. > > > > Signed-off-by: Richard Henderson > > This change makes sense, and matches what aa32_va_parameters() does, > but

[RFC 1/2] arm: acpi: pci-expender-bus: Make arm to support PXB-PCIE

2020-02-13 Thread Yubo Miao
From: miaoyubo Currently virt machine is not supported by pxb-pcie, and only one main host bridge described in ACPI tables. Under this circumstance, different io numas for differnt devices is not possible, in order to present io numas to the guest, especially for host pssthrough devices.

Re: [PATCH] tracing: only allow -trace to override -D if set

2020-02-13 Thread Stefan Hajnoczi
On Wed, Feb 12, 2020 at 11:31:00PM +0100, Philippe Mathieu-Daudé wrote: > On 2/12/20 4:34 PM, Stefan Hajnoczi wrote: > > On Tue, Feb 11, 2020 at 11:10:54AM +, Alex Bennée wrote: > > > Otherwise any -D settings the user may have made get ignored. > > > > > > Signed-off-by: Alex Bennée > > >

Re: [PATCH v15 8/9] hw/arm/virt: Add the virtio-iommu device tree mappings

2020-02-13 Thread Auger Eric
Hi Peter, Michael, On 2/11/20 6:31 PM, Auger Eric wrote: > Hi Peter, > > On 2/11/20 4:00 PM, Peter Maydell wrote: >> On Sat, 8 Feb 2020 at 12:01, Eric Auger wrote: >>> >>> Adds the "virtio,pci-iommu" node in the host bridge node and >>> the RID mapping, excluding the IOMMU RID. >>> >>> This is

[PATCH] uapi: fix userspace breakage, use __BITS_PER_LONG for swap

2020-02-13 Thread Christian Borntraeger
QEMU has a funny new build error message when I use the upstream kernel headers: CC block/file-posix.o In file included from /home/cborntra/REPOS/qemu/include/qemu/timer.h:4, from /home/cborntra/REPOS/qemu/include/qemu/timed-average.h:29, from

Re: [PATCH RFC 01/14] migration: add the 'migrate_use_rdma_pin_all' function

2020-02-13 Thread Juan Quintela
Zhimin Feng wrote: > Signed-off-by: Zhimin Feng Reviewed-by: Juan Quintela

[PATCH v3 0/9] linux-user: Update syscall numbers to kernel 5.5 level

2020-02-13 Thread Aleksandar Markovic
From: Aleksandar Markovic v2->v3: - corrected number of arguments for two mips syscalls v1->v2: - corrected mips parts based on Laurent's review This series is a spin-off of another larger linux-user series that become too large to handle, hence these patches related to syscall numbers

[PATCH v3 3/9] linux-user: m68k: Update syscall numbers to kernel 5.5 level

2020-02-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Update m68k syscall numbers based on Linux kernel v5.5. CC: Laurent Vivier Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier --- linux-user/m68k/syscall_nr.h | 50 +++- 1 file changed, 49 insertions(+), 1

[PATCH v3 1/9] linux-user: alpha: Update syscall numbers to kernel 5.5 level

2020-02-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Update alpha syscall numbers based on Linux kernel v5.5. CC: Richard Henderson Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier --- linux-user/alpha/syscall_nr.h | 35 +++ 1 file changed, 35 insertions(+) diff --git

Re: [PATCH v3 0/9] linux-user: Update syscall numbers to kernel 5.5 level

2020-02-13 Thread Laurent Vivier
Le 13/02/2020 à 13:29, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > v2->v3: > > - corrected number of arguments for two mips syscalls > > v1->v2: > > - corrected mips parts based on Laurent's review > > This series is a spin-off of another larger linux-user series > that

[PULL 5/6] migration-test: fix some memleaks in migration-test

2020-02-13 Thread Juan Quintela
From: Pan Nengyuan spotted by asan, 'check-qtest-aarch64' runs fail if sanitizers is enabled. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Juan Quintela Reviewed-by: Laurent Vivier Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 14 -- 1

[PULL 6/6] git: Make submodule check only needed modules

2020-02-13 Thread Juan Quintela
If one is compiling more than one tree from the same source, it is possible that they need different submodules. Change the check to see that all modules that we are interested in are updated, discarding the ones that we don't care about. Signed-off-by: Juan Quintela --- v1->v2: patchw

[PULL 1/6] migration: Maybe VM is paused when migration is cancelled

2020-02-13 Thread Juan Quintela
From: Zhimin Feng If the migration is cancelled when it is in the completion phase, the migration state is set to MIGRATION_STATUS_CANCELLING. The VM maybe wait for the 'pause_sem' semaphore in migration_maybe_pause function, so that VM always is paused. Reported-by: Euler Robot Signed-off-by:

Re: [PATCH v3 03/13] hw/arm/raspi: Extract the version from the board revision

2020-02-13 Thread Peter Maydell
On Sat, 8 Feb 2020 at 16:57, Philippe Mathieu-Daudé wrote: > > The board revision encode the board version. Add a helper > to extract the version, and use it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/raspi.c | 31 +++ > 1 file changed, 27

Re: [PULL 00/10] Ui 20200212 patches

2020-02-13 Thread Peter Maydell
On Wed, 12 Feb 2020 at 16:18, Gerd Hoffmann wrote: > > The following changes since commit e18e5501d8ac692d32657a3e1ef545b14e72b730: > > Merge remote-tracking branch > 'remotes/dgilbert-gitlab/tags/pull-virtiofs-20200210' into staging > (2020-02-10 18:09:14 +) > > are available in the Git

Re: [PATCH v9 01/23] checkpatch: replace vl.c in the top of repo check

2020-02-13 Thread Stefan Hajnoczi
On Tue, Feb 11, 2020 at 03:34:48PM -0500, Alexander Bulekov wrote: > 524b4c2c5c moves vl.c into softmmu/ , breaking the checkpatch 524b4c2c5c is a local git sha1. That commit will have a different sha1 when applied to qemu.git/master. Saying "The next patch" instead would be fine. However,

[PULL 2/5] linux-user: cleanup signal.c

2020-02-13 Thread Laurent Vivier
No functional changes. Prepare the field for future fixes. Remove memset(.., 0, ...) that is useless on a static array Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Tested-by: Taylor Simpson Message-Id:

[PATCH v3 8/9] linux-user: xtensa: Update syscall numbers to kernel 5.5 level

2020-02-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Update xtensa syscall numbers based on Linux kernel v5.5. CC: Max Filippov Acked-by: Max Filippov Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier --- linux-user/xtensa/syscall_nr.h | 38 -- 1 file changed, 36

Re: [PULL] RISC-V Patches for the 5.0 Soft Freeze, Part 2

2020-02-13 Thread Bin Meng
Hi Palmer, On Thu, Feb 13, 2020 at 1:30 AM Palmer Dabbelt wrote: > > The following changes since commit 81a23caf47956778c5a5056ad656d1ef92bf9659: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2020-02-10 17:08:51 +) > > are available in the Git

[PATCH v3 9/9] linux-user: xtensa: Remove unused constant TARGET_NR_syscall_count

2020-02-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Currently, there is no usage of TARGET_NR_syscall_count for target xtensa, and there is no obvious indication if there is some planned usage in future. CC: Max Filippov Acked-by: Max Filippov Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier ---

[PATCH v3 7/9] linux-user: x86_64: Update syscall numbers to kernel 5.5 level

2020-02-13 Thread Aleksandar Markovic
From: Aleksandar Markovic Update x86_64 syscall numbers based on Linux kernel v5.5. CC: Paolo Bonzini CC: Richard Henderson CC: Eduardo Habkost Signed-off-by: Aleksandar Markovic Reviewed-by: Laurent Vivier --- linux-user/x86_64/syscall_nr.h | 24 1 file changed,

Re: [PATCH v2] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init

2020-02-13 Thread Peter Maydell
On Thu, 13 Feb 2020 at 10:09, Philippe Mathieu-Daudé wrote: > > On 2/13/20 3:56 AM, kuhn.chen...@huawei.com wrote: > > From: Chen Qun > > > > It's easy to reproduce as follow: > > virsh qemu-monitor-command vm1 --pretty '{"execute": > > "device-list-properties", > >

[RFC 0/2] pci_expander_brdige:acpi:Support pxb-pcie for ARM

2020-02-13 Thread Yubo Miao
From: miaoyubo Currently pxb-pcie is not supported by arm and only one main host bridge is described in acpi tables, which means it is not impossible to present different io numas for different devices. This series of patches make arm to support PXB-PCIE. Users can configure pxb-pcie with

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-02-13 Thread Ike Panhc
** Tags added: ikeradar -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1805256 Title: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images Status in kunpeng920:

[RFC 2/2] pci-expender-bus:Add pcie-root-port to pxb-pcie under arm.

2020-02-13 Thread Yubo Miao
From: miaoyubo Since devices could not directly plugged into pxb-pcie, under arm, one pcie-root port is plugged into pxb-pcie. Due to the bus for each pxb-pcie is defined as 2 in acpi dsdt tables(one for pxb-pcie, one for pcie-root-port), only one device could be plugged into one pxb-pcie.

[PATCH v2 2/2] tests/tcg/multiarch: Add tests for implemented alsa sound timer ioctls

2020-02-13 Thread Filip Bozuta
This patch adds tests for following 14 implemented alsa timer ioctls: * SNDRV_TIMER_IOCTL_PVERSION* SNDRV_TIMER_IOCTL_INFO * SNDRV_TIMER_IOCTL_NEXT_DEVICE * SNDRV_TIMER_IOCTL_PARAMS * SNDRV_TIMER_IOCTL_TREAD * SNDRV_TIMER_IOCTL_STATUS * SNDRV_TIMER_IOCTL_GINFO *

[PATCH v2 0/2] tests/tcg/multiarch: Add tests for implemented real

2020-02-13 Thread Filip Bozuta
This series covers tests for implemented rtc and alsa timer ioctls. The names of ioctls that are covered by these tests can be found in patch descriptions. The functionalities of each ioctl that is tested can be found in patches that implement them. Some of the features that are accessible

[PATCH v2 1/2] tests/tcg/multiarch: Add tests for implemented rtc ioctls

2020-02-13 Thread Filip Bozuta
This patch adds tests for following 22 implemented rtc ioctls: * RTC_AIE_ON * RTC_ALM_SET * RTC_WKALM_SET * RTC_AIE_OFF* RTC_ALM_READ * RTC_WKALM_RD * RTC_UIE_ON * RTC_RD_TIME * RTC_PLL_GET * RTC_UIE_OFF* RTC_SET_TIME * RTC_PLL_SET * RTC_PIE_ON *

Re: Question about (and problem with) pflash data access

2020-02-13 Thread Guenter Roeck
On 2/13/20 1:51 AM, Paolo Bonzini wrote: On 13/02/20 08:40, Alexey Kardashevskiy wrote: memory-region: system    - (prio 0, i/o): system -01ff (prio 0, romd): omap_sx1.flash0-1 -01ff (prio 0,

Re: [PATCH v2 0/4] arm64: Add the cpufreq device to show cpufreq info to guest

2020-02-13 Thread fangying
On 2020/2/13 16:18, Andrew Jones wrote: On Thu, Feb 13, 2020 at 03:36:26PM +0800, Ying Fang wrote: On ARM64 platform, cpu frequency is retrieved via ACPI CPPC. A virtual cpufreq device based on ACPI CPPC is created to present cpu frequency info to the guest. The default frequency is set to

[PULL 00/46] target-arm queue

2020-02-13 Thread Peter Maydell
'remotes/kraxel/tags/ui-20200212-pull-request' into staging (2020-02-13 11:06:32 +) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20200213 for you to fetch changes up to dc7a88d0810ad272bdcd2e0869359af78fdd9114: target

[PULL 15/46] target/arm: Mask CPSR_J when Jazelle is not enabled

2020-02-13 Thread Peter Maydell
From: Richard Henderson The J bit signals Jazelle mode, and so of course is RES0 when the feature is not enabled. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell Message-id: 20200208125816.14954-7-richard.hender...@linaro.org Signed-off-by: Peter Maydell ---

[PULL 03/46] bios-tables-test: prepare to change ARM virt ACPI DSDT

2020-02-13 Thread Peter Maydell
From: Heyi Guo We are going to change ARM virt ACPI DSDT table, which will cause make check to fail, so temporarily add related golden masters to ignore list. Signed-off-by: Heyi Guo Reviewed-by: Michael S. Tsirkin Message-id: 20200204014325.16279-2-guoh...@huawei.com Signed-off-by: Peter

[PULL 32/46] hw/char/exynos4210_uart: Fix memleaks in exynos4210_uart_init

2020-02-13 Thread Peter Maydell
From: Chen Qun It's easy to reproduce as follow: virsh qemu-monitor-command vm1 --pretty '{"execute": "device-list-properties", "arguments":{"typename":"exynos4210.uart"}}' ASAN shows memory leak stack: #1 0xfffd896d71cb in g_malloc0 (/lib64/libglib-2.0.so.0+0x571cb) #2 0xaaad270beee3 in

[PULL 26/46] target/arm: Add ID_AA64MMFR2_EL1

2020-02-13 Thread Peter Maydell
From: Richard Henderson Add definitions for all of the fields, up to ARMv8.5. Convert the existing RESERVED register to a full register. Query KVM for the value of the register for the host. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id:

[PULL 08/46] arm/acpi: simplify the description of PCI _CRS

2020-02-13 Thread Peter Maydell
From: Heyi Guo The original code defines a named object for the resource template but then returns the resource template object itself; the resulted output is like below: Method (_CRS, 0, NotSerialized) // _CRS: Current Resource Settings { Name (RBUF, ResourceTemplate () {

  1   2   3   4   >