Re: [PATCH] hw/ide: Remove status register read side effect

2020-02-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200221065015.337915-1-jasper.low...@bt.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH v2 0/2] docs: rstfy some s390 docs

2020-02-21 Thread Cornelia Huck
On Thu, 13 Feb 2020 17:29:40 +0100 Cornelia Huck wrote: > https://qemu.readthedocs.io/en/latest/index.html collects various > documents from the QEMU docs/ subdirectory; however, none of the > s390 files are currently included. Therefore, I set out to convert > the existing files to rst and hook

Re: [PATCH] maint: Include top-level *.rst files early in git diff

2020-02-21 Thread Stefano Garzarella
On Thu, Feb 20, 2020 at 10:22:13AM -0600, Eric Blake wrote: > We are converting more doc files to *.rst rather than *.texi. Most > doc files are already listed early in diffs due to our catchall > docs/*, but a few top-level files get missed by that glob. > > Signed-off-by: Eric Blake > --- >

Re: [Virtio-fs] [PATCH] virtiofsd: Remove fuse.h and struct fuse_module

2020-02-21 Thread Stefan Hajnoczi
On Fri, Feb 21, 2020 at 02:55:15PM +0800, Xiao Yang wrote: > All code in fuse.h and struct fuse_module are not used by virtiofsd > so removing them is safe. > > Signed-off-by: Xiao Yang > --- > tools/virtiofsd/fuse.h | 1229 -- > tools/virtiofsd/fuse_i.h |

Re: [PATCH 1/2] riscv: roms: Add 32-bit OpenSBI firmware image for sifive_u

2020-02-21 Thread Philippe Mathieu-Daudé
On 2/21/20 6:54 AM, Anup Patel wrote: On Fri, Feb 21, 2020 at 8:08 AM Bin Meng wrote: Hi Philippe, On Fri, Feb 21, 2020 at 1:31 AM Philippe Mathieu-Daudé wrote: Hi Bin, On 2/20/20 3:42 PM, Bin Meng wrote: Although the real world SiFive HiFive Unleashed board is a 64-bit hardware

Re: [PATCH] hw/char/pl011: Output characters using best-effort mode

2020-02-21 Thread Marc Zyngier
Hi Gavin, On 2020-02-21 04:24, Gavin Shan wrote: Hi Peter and Marc, On 2/20/20 9:10 PM, Peter Maydell wrote: On Thu, 20 Feb 2020 at 09:10, Marc Zyngier wrote: On 2020-02-20 06:01, Gavin Shan wrote: This fixes the issue by using newly added API qemu_chr_fe_try_write_all(), which provides

Re: [PATCH v1 06/13] migrate/ram: Discard new RAM when growing RAM blocks and the VM is stopped

2020-02-21 Thread David Hildenbrand
On 19.02.20 17:17, David Hildenbrand wrote: > In case we grow our RAM after ram_postcopy_incoming_init() (e.g., when > synchronizing the RAM block state with the migration source), the resized > part would not get discarded. Let's perform that when being notified > about a resize while postcopy

Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy

2020-02-21 Thread David Hildenbrand
On 20.02.20 21:17, Peter Xu wrote: > On Thu, Feb 20, 2020 at 04:16:02PM +0100, David Hildenbrand wrote: >> On 19.02.20 17:17, David Hildenbrand wrote: >>> Resizing while migrating is dangerous and does not work as expected. >>> The whole migration code works on the usable_length of ram blocks and

Re: [PATCH v7 02/11] error: auto propagated local_err

2020-02-21 Thread Vladimir Sementsov-Ogievskiy
21.02.2020 12:19, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of functions with an errp OUT parameter. It has three goals: 1. Fix issue with error_fatal and error_prepend/error_append_hint: user can't see

[PATCH v5 4/4] target/riscv: add vector configure instruction

2020-02-21 Thread LIU Zhiwei
vsetvl and vsetvli are two configure instructions for vl, vtype. TB flags should update after configure instructions. The (ill, lmul, sew ) of vtype and the bit of (VSTART == 0 && VL == VLMAX) will be placed within tb_flags. Signed-off-by: LIU Zhiwei --- MAINTAINERS

Re: [PATCH v4 02/16] s390x: protvirt: Add diag308 subcodes 8 - 10

2020-02-21 Thread Cornelia Huck
On Thu, 20 Feb 2020 07:56:24 -0500 Janosch Frank wrote: > For diag308 subcodes 8 - 10 we have a new ipib of type 5. The ipib > holds the address and length of the secure execution header, as well > as a list of guest components. > > Each component is a block of memory, for example kernel or

Re: Race condition in overlayed qcow2?

2020-02-21 Thread dovgaluk
Vladimir Sementsov-Ogievskiy писал 2020-02-20 12:36: 20.02.2020 12:05, Vladimir Sementsov-Ogievskiy wrote: 20.02.2020 11:31, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-19 19:07: 19.02.2020 17:32, dovgaluk wrote: I encountered a problem with record/replay of QEMU execution and

Re: [PATCH v1 10/13] migrate/ram: Handle RAM block resizes during postcopy

2020-02-21 Thread David Hildenbrand
On 21.02.20 09:35, David Hildenbrand wrote: > On 20.02.20 21:54, Peter Xu wrote: >> On Wed, Feb 19, 2020 at 05:17:22PM +0100, David Hildenbrand wrote: >>> Resizing while migrating is dangerous and does not work as expected. >>> The whole migration code works on the usable_length of ram blocks and

Re: [PATCH v3 08/20] Remove unnecessary cast when using the address_space API

2020-02-21 Thread Cornelia Huck
On Thu, 20 Feb 2020 14:05:36 +0100 Philippe Mathieu-Daudé wrote: > This commit was produced with the included Coccinelle script > scripts/coccinelle/exec_rw_const. > > Two lines in hw/net/dp8393x.c that Coccinelle produced that > were over 80 characters were re-wrapped by hand. > >

Re: [PATCH v1 13/13] migrate/ram: Tolerate partially changed mappings in postcopy code

2020-02-21 Thread David Hildenbrand
On 20.02.20 22:07, Peter Xu wrote: > On Thu, Feb 20, 2020 at 12:24:42PM +0100, David Hildenbrand wrote: >> On 19.02.20 17:17, David Hildenbrand wrote: >>> When we partially change mappings (e.g., mmap over parts of an existing >>> mmap) where we have a userfaultfd handler registered, the handler

Re: [PATCH] rcu_queue: add QSLIST functions

2020-02-21 Thread Stefan Hajnoczi
On Thu, Feb 20, 2020 at 11:38:28AM +0100, Paolo Bonzini wrote: > QSLIST is the only family of lists for which we do not have RCU-friendly > accessors, > add them. > > Signed-off-by: Paolo Bonzini > --- > include/qemu/queue.h | 15 +++-- > include/qemu/rcu_queue.h | 47

[PATCH v3] util/async: make bh_aio_poll() O(1)

2020-02-21 Thread Stefan Hajnoczi
The ctx->first_bh list contains all created BHs, including those that are not scheduled. The list is iterated by the event loop and therefore has O(n) time complexity with respected to the number of created BHs. Rewrite BHs so that only scheduled or deleted BHs are enqueued. Only BHs that

Re: [PATCH] virtiofsd: Remove fuse.h and struct fuse_module

2020-02-21 Thread Philippe Mathieu-Daudé
On 2/21/20 7:55 AM, Xiao Yang wrote: All code in fuse.h and struct fuse_module are not used by virtiofsd so removing them is safe. Signed-off-by: Xiao Yang --- tools/virtiofsd/fuse.h | 1229 -- tools/virtiofsd/fuse_i.h | 16 - 2 files changed, 1245

Re: [PATCH v3] util/async: make bh_aio_poll() O(1)

2020-02-21 Thread Stefan Hajnoczi
On Fri, Feb 21, 2020 at 9:40 AM Stefan Hajnoczi wrote: > > The ctx->first_bh list contains all created BHs, including those that > are not scheduled. The list is iterated by the event loop and therefore > has O(n) time complexity with respected to the number of created BHs. > > Rewrite BHs so

Re: [PATCH] hw/char/pl011: Enable TxFIFO and async transmission

2020-02-21 Thread Paolo Bonzini
On 21/02/20 05:49, Gavin Shan wrote: > @@ -306,6 +362,7 @@ static const VMStateDescription vmstate_pl011 = { > VMSTATE_UINT32(int_enabled, PL011State), > VMSTATE_UINT32(int_level, PL011State), > VMSTATE_UINT32_ARRAY(read_fifo, PL011State, 16), > +

Re: [PATCH v1 10/13] migrate/ram: Handle RAM block resizes during postcopy

2020-02-21 Thread David Hildenbrand
On 20.02.20 21:54, Peter Xu wrote: > On Wed, Feb 19, 2020 at 05:17:22PM +0100, David Hildenbrand wrote: >> Resizing while migrating is dangerous and does not work as expected. >> The whole migration code works on the usable_length of ram blocks and does >> not expect this to change at random

Re: [PATCH v1 1/2] linux-user: Protect more syscalls

2020-02-21 Thread Philippe Mathieu-Daudé
On 2/21/20 12:18 AM, Alistair Francis wrote: New y2038 safe 32-bit architectures (like RISC-V) don't support old syscalls with a 32-bit time_t. The kernel defines new *_time64 versions of these syscalls. Add some more #ifdefs to syscall.c in linux-user to allow us to compile without these old

Re: [PATCH] hw/char/pl011: Enable TxFIFO and async transmission

2020-02-21 Thread Philippe Mathieu-Daudé
Cc'ing Igor & Drew. On 2/21/20 7:28 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200221044908.266883-1-gs...@redhat.com/ > === TEST SCRIPT BEGIN === #!/bin/bash make docker-image-centos7 V=1 NETWORK=1 time make docker-test-quick@centos7 SHOW_ENV=1 J=14 NETWORK=1 ===

Re: [PATCH] hw/char/pl011: Enable TxFIFO and async transmission

2020-02-21 Thread Philippe Mathieu-Daudé
On 2/21/20 10:37 AM, Philippe Mathieu-Daudé wrote: Cc'ing Igor & Drew. On 2/21/20 7:28 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200221044908.266883-1-gs...@redhat.com/ > === TEST SCRIPT BEGIN === #!/bin/bash make docker-image-centos7 V=1 NETWORK=1 time make

[PATCH v5 1/4] target/riscv: add vector extension field in CPURISCVState

2020-02-21 Thread LIU Zhiwei
The 32 vector registers will be viewed as a continuous memory block. It avoids the convension between element index and (regno, offset). Thus elements can be directly accessed by offset from the first vector base address. Signed-off-by: LIU Zhiwei --- target/riscv/cpu.h | 12 1

Re: [PATCH qemu v7 0/5] spapr: Kill SLOF

2020-02-21 Thread Paolo Bonzini
On 21/02/20 01:18, Alexey Kardashevskiy wrote: > I am not quite sure I understood the request. Write my own small > firmware and replace GRUB with it? The firmware from 5/5 reads first 2 > sectors and the entire PReP, I could add there stuff if that helps (I > have "work in progress" patch for

Re: [PATCH v3 19/20] Let cpu_[physical]_memory() calls pass a boolean 'is_write' argument

2020-02-21 Thread Cornelia Huck
On Thu, 20 Feb 2020 14:05:47 +0100 Philippe Mathieu-Daudé wrote: > Use an explicit boolean type. > > This commit was produced with the included Coccinelle script > scripts/coccinelle/exec_rw_const. > > Signed-off-by: Philippe Mathieu-Daudé > --- > scripts/coccinelle/exec_rw_const.cocci | 14

Re: [PATCH] target: i386: Check float overflow about register stack

2020-02-21 Thread Paolo Bonzini
On 21/02/20 04:45, cheng...@emindsoft.com.cn wrote: > static inline void fpush(CPUX86State *env) > { > -env->fpstt = (env->fpstt - 1) & 7; > -env->fptags[env->fpstt] = 0; /* validate stack entry */ > +set_fpstt(env, env->fpstt - 1, false, true); On overflow fpstt is ~0, so this

Re: [PATCH] hw/char/pl011: Enable TxFIFO and async transmission

2020-02-21 Thread Gavin Shan
On 2/21/20 7:25 PM, Paolo Bonzini wrote: On 21/02/20 05:49, Gavin Shan wrote: @@ -306,6 +362,7 @@ static const VMStateDescription vmstate_pl011 = { VMSTATE_UINT32(int_enabled, PL011State), VMSTATE_UINT32(int_level, PL011State), VMSTATE_UINT32_ARRAY(read_fifo,

Re: [PATCH v4] Implement the Screamer sound chip for the mac99 machine type

2020-02-21 Thread Howard Spoelstra
Hi, It might be worth mentioning that any testing of your screamer implementation with MacOS/OSX guests on the mac99 machine needs a custom-built openbios. Where possible I'll compare your screamer with the current screamer implementation built from: git clone -b screamer

Re: [PATCH v7 02/11] error: auto propagated local_err

2020-02-21 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > Here is introduced ERRP_AUTO_PROPAGATE macro, to be used at start of > functions with an errp OUT parameter. > > It has three goals: > > 1. Fix issue with error_fatal and error_prepend/error_append_hint: user > can't see this additional information, because

Re: [PATCH v7 01/11] qapi/error: add (Error **errp) cleaning APIs

2020-02-21 Thread Vladimir Sementsov-Ogievskiy
21.02.2020 10:38, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Add functions to clean Error **errp: call corresponding Error *err cleaning function an set pointer to NULL. New functions: error_free_errp error_report_errp warn_report_errp Signed-off-by: Vladimir

[PATCH v5 2/4] target/riscv: implementation-defined constant parameters

2020-02-21 Thread LIU Zhiwei
vlen is the vector register length in bits. elen is the max element size in bits. vext_spec is the vector specification version, default value is v0.7.1. Signed-off-by: LIU Zhiwei --- target/riscv/cpu.c | 7 +++ target/riscv/cpu.h | 5 + 2 files changed, 12 insertions(+) diff --git

[PATCH v5 0/4] target-riscv: support vector extension part 1

2020-02-21 Thread LIU Zhiwei
This is the first part of v5 patchset. The changelog of v5 is only coverd the part1. Features: * support specification riscv-v-spec-0.7.1. * support basic vector extension. * support Zvlsseg. * support Zvamo. * not support Zvediv as it is changing. * SLEN always equals VLEN. *

[PATCH v5 3/4] target/riscv: support vector extension csr

2020-02-21 Thread LIU Zhiwei
The v0.7.1 specification does not define vector status within mstatus. A future revision will define the privileged portion of the vector status. Signed-off-by: LIU Zhiwei --- target/riscv/cpu_bits.h | 15 + target/riscv/csr.c | 75 - 2 files

Re: [PATCH v4 16/16] docs: Add protvirt docs

2020-02-21 Thread Cornelia Huck
On Thu, 20 Feb 2020 07:56:38 -0500 Janosch Frank wrote: > Lets add some documentation for the Protected VM functionality. > > Signed-off-by: Janosch Frank > --- > docs/protvirt.rst | 53 +++ > 1 file changed, 53 insertions(+) > create mode 100644

Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy

2020-02-21 Thread David Hildenbrand
On 21.02.20 11:10, David Hildenbrand wrote: > On 21.02.20 10:18, David Hildenbrand wrote: >> On 20.02.20 21:17, Peter Xu wrote: >>> On Thu, Feb 20, 2020 at 04:16:02PM +0100, David Hildenbrand wrote: On 19.02.20 17:17, David Hildenbrand wrote: > Resizing while migrating is dangerous and

Re: [PATCH rc4 06/29] target/avr: Add defintions of AVR core types

2020-02-21 Thread Michael Rolnik
Hi all. How is it going? Regards, Michael. On Mon, Feb 10, 2020 at 9:39 AM Michael Rolnik wrote: > Hi all. > > When I decided to implement AVR 8 bit CPU support for QEMU I found this > document > >

[Bug 1722884] Re: keyboard input while mouse moving triggers mouse failure

2020-02-21 Thread Geoffrey McRae
I tracked this down and fixed it last year, your issue is unrelated. https://github.com/qemu/qemu/commit/143c04c7e0639e53086519592ead15d2556bfbf2 #diff-3b5bd599c018d558b135bd19647a00c6 https://github.com/qemu/qemu/commit/7abe7eb29494b4e4a11ec99ae5623083409a2f1e

Re: [PATCH v3 2/4] luks: implement .bdrv_measure()

2020-02-21 Thread Stefan Hajnoczi
On Wed, Feb 19, 2020 at 04:46:34PM +0100, Max Reitz wrote: > On 11.02.20 17:03, Stefan Hajnoczi wrote: > > Add qemu-img measure support in the "luks" block driver. > > > > Signed-off-by: Stefan Hajnoczi > > --- > > block/crypto.c | 62 ++ > > 1

Re: [RFC v3 2/3] acpi:pci-expender-bus: Add pxb support for arm

2020-02-21 Thread Michael S. Tsirkin
On Fri, Feb 21, 2020 at 02:35:11PM +0800, Yubo Miao wrote: > From: miaoyubo > > Currently virt machine is not supported by pxb-pcie, > and only one main host bridge described in ACPI tables. > In this patch,PXB-PCIE is supproted by arm and certain > resource is allocated for each pxb-pcie in

Re: [PATCH v3 1/4] luks: extract qcrypto_block_calculate_payload_offset()

2020-02-21 Thread Stefan Hajnoczi
On Wed, Feb 19, 2020 at 02:03:50PM +0100, Max Reitz wrote: > On 11.02.20 17:03, Stefan Hajnoczi wrote: > > The qcow2 .bdrv_measure() code calculates the crypto payload offset. > > This logic really belongs in crypto/block.c where it can be reused by > > other image formats. > > > > The "luks"

Re: [RFC v3 3/3] ACPI/unit-test: Add a new test for pxb-pcie for arm

2020-02-21 Thread Michael S. Tsirkin
On Fri, Feb 21, 2020 at 02:35:12PM +0800, Yubo Miao wrote: > From: miaoyubo > > Currently, pxb-pcie could be defined by the cmdline like > --device pxb-pcie,id=pci.9,bus_nr=128 > However pxb-pcie is not described in acpi tables for arm. > > The formal two patches support pxb-pcie for arm,

Re: [PATCH v4] Implement the Screamer sound chip for the mac99 machine type

2020-02-21 Thread Programmingkid
> On Feb 21, 2020, at 4:13 AM, Howard Spoelstra wrote: > > Hi, > > It might be worth mentioning that any testing of your screamer implementation > with MacOS/OSX guests on the mac99 machine needs a custom-built openbios. > > Where possible I'll compare your screamer with the current

Re: [PATCH] tcg: gdbstub: Fix single-step issue on arm target

2020-02-21 Thread Changbin Du
On Thu, Feb 20, 2020 at 10:24:37PM +0100, Luc Michel wrote: > I'm curious, I never experienced this behaviour from GDB. What GDB and > QEMU versions are you using? > > On my side (GDB 9.1), even without 'vContSupported+' in the 'qSupported' > answer, GDB sends a 'vCont?' packet on the first

Re: [PATCH] pcie_root_port: Add disable_hotplug option

2020-02-21 Thread Daniel P . Berrangé
On Tue, Feb 18, 2020 at 12:18:04PM -0500, Laine Stump wrote: > On 2/18/20 11:17 AM, Julia Suvorova wrote: > > Make hot-plug/hot-unplug on PCIe Root Ports optional to allow libvirt > > to manage it and restrict unplug for the entire machine. This is going > > to prevent user-initiated unplug in

Re: [PATCH] console: make QMP screendump use coroutine

2020-02-21 Thread Kevin Wolf
Am 20.02.2020 um 17:01 hat Markus Armbruster geschrieben: > >> > void qmp_screendump(const char *filename, bool has_device, const char > >> > *device, > >> > bool has_head, int64_t head, Error **errp) > >> > { > >> > QemuConsole *con; > >> > DisplaySurface

Re: [PATCH v1 05/13] migrate/ram: Handle RAM block resizes during precopy

2020-02-21 Thread David Hildenbrand
On 21.02.20 10:18, David Hildenbrand wrote: > On 20.02.20 21:17, Peter Xu wrote: >> On Thu, Feb 20, 2020 at 04:16:02PM +0100, David Hildenbrand wrote: >>> On 19.02.20 17:17, David Hildenbrand wrote: Resizing while migrating is dangerous and does not work as expected. The whole migration

[Bug 1857811] Re: qemu user static binary seems to lack support for network namespace.

2020-02-21 Thread Laurent Vivier
Yes, it's fixed in v4.2.0, and with the help of your test program I've bisect to the fix: commit 1645fb5a1e537f85eda744bfa6e9d3dda047ba28 Author: Shu-Chun Weng Date: Thu Oct 17 17:19:20 2019 -0700 Fix unsigned integer underflow in fd-trans.c In any of these `*_for_each_*`

Re: [PATCH] maint: Include top-level *.rst files early in git diff

2020-02-21 Thread Peter Maydell
On Thu, 20 Feb 2020 at 16:22, Eric Blake wrote: > > We are converting more doc files to *.rst rather than *.texi. Most > doc files are already listed early in diffs due to our catchall > docs/*, but a few top-level files get missed by that glob. > > Signed-off-by: Eric Blake > --- > > Both

Re: [PATCH] console: make QMP screendump use coroutine

2020-02-21 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > [...] > >> Collecting several users before building infrastructure makes sense when > >> the design of the infrastructure isn't obvious, or when the need for

Re: [PATCH/RFC 0/1] Vhost User Cross Cable: Intro

2020-02-21 Thread Stefan Hajnoczi
On Thu, Feb 13, 2020 at 03:48:59PM +0200, Nikos Dragazis wrote: > On Tue, 14 Jan 2020 at 10:20 Stefan Hajnoczi > wrote: > > On Fri, Jan 10, 2020 at 10:34 AM Marc-André Lureau > > wrote: > > > On Wed, Jan 8, 2020 at 5:57 AM V. wrote: > > > > Hi V., > > I think I remember you from Etherboot/gPXE

Re: [GSoC/Outreachy] Arduino complete setup visualization and emulation

2020-02-21 Thread Stefan Hajnoczi
On Tue, Feb 11, 2020 at 10:51:19AM +, Stefan Hajnoczi wrote: > On Mon, Feb 10, 2020 at 08:58:28PM +0100, Philippe Mathieu-Daudé wrote: Ping? QEMU has been accepted as a mentoring organization. Please post a final version of this project idea on the wiki:

[PATCH v4 3/4] qemu-img: allow qemu-img measure --object without a filename

2020-02-21 Thread Stefan Hajnoczi
In most qemu-img sub-commands the --object option only makes sense when there is a filename. qemu-img measure is an exception because objects may be referenced from the image creation options instead of an existing image file. Allow --object without a filename. Signed-off-by: Stefan Hajnoczi

[PATCH v4 2/4] luks: implement .bdrv_measure()

2020-02-21 Thread Stefan Hajnoczi
Add qemu-img measure support in the "luks" block driver. Signed-off-by: Stefan Hajnoczi Reviewed-by: Max Reitz --- block/crypto.c | 62 ++ 1 file changed, 62 insertions(+) diff --git a/block/crypto.c b/block/crypto.c index 24823835c1..23e9c74d6f

[PATCH v4 1/4] luks: extract qcrypto_block_calculate_payload_offset()

2020-02-21 Thread Stefan Hajnoczi
The qcow2 .bdrv_measure() code calculates the crypto payload offset. This logic really belongs in crypto/block.c where it can be reused by other image formats. The "luks" block driver will need this same logic in order to implement .bdrv_measure(), so extract the

[PATCH v4 0/4] luks: add qemu-img measure support

2020-02-21 Thread Stefan Hajnoczi
v4: * This revision is what German speakers call "das Tüpfelchen auf dem I". "The icing on the cake" is the English equivalent. Since I like cake and don't want it to be half-baked, and because I like my metaphors shaken, not stirred, I went ahead with the extra revision so I could

Re: [PULL 00/13] Linux user for 5.0 patches

2020-02-21 Thread Peter Maydell
On Thu, 20 Feb 2020 at 09:22, Laurent Vivier wrote: > > The following changes since commit 6c599282f8ab382fe59f03a6cae755b89561a7b3: > > Merge remote-tracking branch > 'remotes/armbru/tags/pull-monitor-2020-02-15-v2' into staging (2020-02-17 > 13:32:25 +) > > are available in the Git

Re: [PATCH 2/2] vhost-use-blk: convert to new virtio_delete_queue

2020-02-21 Thread Stefan Hajnoczi
On Thu, Feb 13, 2020 at 09:28:07AM +0800, pannengy...@huawei.com wrote: > diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c > index 2eba8b9db0..ed6a5cc03b 100644 > --- a/hw/block/vhost-user-blk.c > +++ b/hw/block/vhost-user-blk.c > @@ -420,9 +420,10 @@ static void

Re: [PATCH 1/2] vhost-user-blk: delete virtioqueues in unrealize to fix memleaks

2020-02-21 Thread Stefan Hajnoczi
On Thu, Feb 13, 2020 at 09:28:06AM +0800, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > virtio queues forgot to delete in unrealize, and aslo error path in > realize, this patch fix these memleaks, the leak stack is as follow: > > Direct leak of 114688 byte(s) in 16 object(s) allocated

Re: [PATCH] hw/char/pl011: Output characters using best-effort mode

2020-02-21 Thread Paolo Bonzini
On 21/02/20 11:21, Peter Maydell wrote: > Before you do that, I would suggest investigating: > * is this a problem we've already had on x86 and that there is a >standard solution for Disconnected sockets always lose data (see tcp_chr_write in chardev/char-socket.c). For connected sockets,

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

2020-02-21 Thread David Gibson
On Fri, Feb 21, 2020 at 03:09:46PM +1100, Alexey Kardashevskiy wrote: > > > On 18/02/2020 16:48, Philippe Mathieu-Daudé wrote: > > On 2/17/20 11:46 PM, David Gibson wrote: > >> On Mon, Feb 17, 2020 at 11:24:11AM +0100, Philippe Mathieu-Daudé wrote: > >>> On 2/17/20 10:26 AM, Philippe

Re: [PATCH v1 00/13] migrate/ram: Fix resizing RAM blocks while migrating

2020-02-21 Thread David Hildenbrand
On 19.02.20 17:17, David Hildenbrand wrote: > This is the follow up of > "[PATCH RFC] memory: Don't allow to resize RAM while migrating" [1] > > This series contains some (slightly modified) patches also contained in: > "[PATCH v2 fixed 00/16] Ram blocks with resizable anonymous

Re: Race condition in overlayed qcow2?

2020-02-21 Thread Vladimir Sementsov-Ogievskiy
21.02.2020 12:49, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-20 12:36: 20.02.2020 12:05, Vladimir Sementsov-Ogievskiy wrote: 20.02.2020 11:31, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-19 19:07: 19.02.2020 17:32, dovgaluk wrote: I encountered a problem with

Re: [PATCH] hw/char/pl011: Output characters using best-effort mode

2020-02-21 Thread Peter Maydell
On Fri, 21 Feb 2020 at 04:24, Gavin Shan wrote: > If above analysis is correct and the first approach doesn't work out. We have > to > consider the 2nd approach - adding option to backend to allow losing data. I'm > going to add "allow-data-lost" option for TYPE_CHARDEV_SOCKET. With the >

Re: [PATCH v2 2/4] virtio-scsi: default num_queues to -smp N

2020-02-21 Thread Stefan Hajnoczi
On Wed, Feb 12, 2020 at 11:18:32AM +, Stefan Hajnoczi wrote: > On Tue, Feb 11, 2020 at 11:31:17AM -0500, Michael S. Tsirkin wrote: > > On Tue, Feb 11, 2020 at 04:20:41PM +, Stefan Hajnoczi wrote: > > > On Mon, Feb 03, 2020 at 12:39:49PM +0100, Sergio Lopez wrote: > > > > On Mon, Feb 03,

Re: [GSoC/Outreachy] Arduino complete setup visualization and emulation

2020-02-21 Thread Philippe Mathieu-Daudé
On 2/21/20 11:56 AM, Stefan Hajnoczi wrote: On Tue, Feb 11, 2020 at 10:51:19AM +, Stefan Hajnoczi wrote: On Mon, Feb 10, 2020 at 08:58:28PM +0100, Philippe Mathieu-Daudé wrote: Ping? QEMU has been accepted as a mentoring organization. Please post a final version of this project idea on

[PATCH v4 4/4] iotests: add 282 luks qemu-img measure test

2020-02-21 Thread Stefan Hajnoczi
This test exercises the block/crypto.c "luks" block driver .bdrv_measure() code. Signed-off-by: Stefan Hajnoczi Reviewed-by: Max Reitz --- tests/qemu-iotests/282 | 93 ++ tests/qemu-iotests/282.out | 30 tests/qemu-iotests/group | 1 + 3

[Bug 1863601] Re: unable to type "|" character in french keyboard.

2020-02-21 Thread Daniel Berrange
Can you provide more information here. What command line have you launched QEMU with ? How are you interacting with QEMU (serial console, GTK UI, VNC, SPICE ?) If VNC/SPICE, what client app are you using ? -- You received this bug notification because you are a member of qemu- devel-ml, which

Re: [PATCH v4] Implement the Screamer sound chip for the mac99 machine type

2020-02-21 Thread Howard Spoelstra
On Fri, Feb 21, 2020 at 12:30 PM Programmingkid wrote: > > > On Feb 21, 2020, at 4:13 AM, Howard Spoelstra > wrote: > > > > Hi, > > > > It might be worth mentioning that any testing of your screamer > implementation with MacOS/OSX guests on the mac99 machine needs a > custom-built openbios. > >

Re: [PATCH v2] gdbstub: Fix single-step issue by confirming 'vContSupported+' feature to gdb

2020-02-21 Thread Luc Michel
On 2/21/20 1:25 AM, Changbin Du wrote: > Recently when debugging an arm32 system on qemu, I found sometimes the > single-step command (stepi) is not working. This can be reproduced by > below steps: > 1) start qemu-system-arm -s -S .. and wait for gdb connection. > 2) start gdb and connect to

Re: [PATCH] hw/char/pl011: Output characters using best-effort mode

2020-02-21 Thread Peter Maydell
On Fri, 21 Feb 2020 at 11:44, Paolo Bonzini wrote: > > On 21/02/20 11:21, Peter Maydell wrote: > > Before you do that, I would suggest investigating: > > * is this a problem we've already had on x86 and that there is a > >standard solution for > Disconnected sockets always lose data (see

Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll

2020-02-21 Thread Stefan Hajnoczi
On Wed, Feb 19, 2020 at 12:13:40PM +0100, Paolo Bonzini wrote: > On 14/02/20 18:17, Stefan Hajnoczi wrote: > > +while ((node = QLIST_FIRST(ready_list))) { > > +QLIST_SAFE_REMOVE(node, node_ready); > > Why does this need safe remove? Yes, it's necessary. QLIST_SAFE_REMOVE() has two

Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll

2020-02-21 Thread Paolo Bonzini
On 21/02/20 13:59, Stefan Hajnoczi wrote: > 1. It doesn't crash if the node is currently not on a list. > 2. It clears the node's linked list pointers so that future linked >list operations (like QLIST_SAFE_REMOVE()) aren't accidentally >performed on stale pointers. > > The node has a long

[PULL 06/52] target/arm: Flush high bits of sve register after AdvSIMD EXT

2020-02-21 Thread Peter Maydell
From: Richard Henderson Writes to AdvSIMD registers flush the bits above 128. Buglink: https://bugs.launchpad.net/bugs/1863247 Signed-off-by: Richard Henderson Message-id: 20200214194643.23317-2-richard.hender...@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell ---

[PULL 02/52] aspeed/scu: Implement chip ID register

2020-02-21 Thread Peter Maydell
From: Joel Stanley This returns a fixed but non-zero value for the chip id. Signed-off-by: Joel Stanley Reviewed-by: Andrew Jeffery Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Message-id: 20200121013302.43839-3-j...@jms.id.au Signed-off-by: Peter Maydell ---

[PULL 04/52] mainstone: Make providing flash images non-mandatory

2020-02-21 Thread Peter Maydell
From: Guenter Roeck Up to now, the mainstone machine only boots if two flash images are provided. This is not really necessary; the machine can boot from initrd or from SD without it. At the same time, having to provide dummy flash images is a nuisance and does not add any real value. Make it

[PULL 08/52] target/arm: Flush high bits of sve register after AdvSIMD ZIP/UZP/TRN

2020-02-21 Thread Peter Maydell
From: Richard Henderson Writes to AdvSIMD registers flush the bits above 128. Signed-off-by: Richard Henderson Message-id: 20200214194643.23317-4-richard.hender...@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/translate-a64.c | 1 + 1 file changed, 1

[PULL 18/52] target/arm: Factor out PMU register definitions

2020-02-21 Thread Peter Maydell
Pull the code that defines the various PMU registers out into its own function, matching the pattern we have already for the debug registers. Apart from one style fix to a multi-line comment, this is purely movement of code with no changes to it. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by:

[PULL 20/52] target/arm: Use FIELD macros for clearing ID_DFR0 PERFMON field

2020-02-21 Thread Peter Maydell
We already define FIELD macros for ID_DFR0, so use them in the one place where we're doing direct bit value manipulation. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Peter Maydell Message-id: 20200214175116.9164-8-peter.mayd...@linaro.org ---

[PULL 38/52] target/arm: Vectorize USHL and SSHL

2020-02-21 Thread Peter Maydell
From: Richard Henderson These instructions shift left or right depending on the sign of the input, and 7 bits are significant to the shift. This requires several masks and selects in addition to the actual shifts to form the complete answer. That said, the operation is still a small

[PULL 31/52] target/arm: Test correct register in aa32_pan and aa32_ats1e1 checks

2020-02-21 Thread Peter Maydell
The isar_feature_aa32_pan and isar_feature_aa32_ats1e1 functions are supposed to be testing fields in ID_MMFR3; but a cut-and-paste error meant we were looking at MVFR0 instead. Fix the functions to look at the right register; this requires us to move at least id_mmfr3 to the ARMISARegisters

[PULL 29/52] target/arm: Correct definition of PMCRDP

2020-02-21 Thread Peter Maydell
The PMCR_EL0.DP bit is bit 5, which is 0x20, not 0x10. 0x10 is 'X'. Correct our #define of PMCRDP and add the missing PMCRX. We do have the correct behaviour for handling the DP bit being set, so this fixes a guest-visible bug. Fixes: 033614c47de Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] hw/char/pl011: Output characters using best-effort mode

2020-02-21 Thread Paolo Bonzini
On 21/02/20 13:44, Peter Maydell wrote: > On Fri, 21 Feb 2020 at 11:44, Paolo Bonzini wrote: >> >> On 21/02/20 11:21, Peter Maydell wrote: >>> Before you do that, I would suggest investigating: >>> * is this a problem we've already had on x86 and that there is a >>>standard solution for >>

[PULL 25/52] target/arm: Read debug-related ID registers from KVM

2020-02-21 Thread Peter Maydell
Now we have isar_feature test functions that look at fields in the ID_AA64DFR0_EL1 and ID_DFR0 ID registers, add the code that reads these register values from KVM so that the checks behave correctly when we're using KVM. No isar_feature function tests ID_AA64DFR1_EL1 or DBGDIDR yet, but we add

[PULL 46/52] target/arm: Set MVFR0.FPSP for ARMv5 cpus

2020-02-21 Thread Peter Maydell
From: Richard Henderson We are going to convert FEATURE tests to ISAR tests, so FPSP needs to be set for these cpus, like we have already for FPDP. Signed-off-by: Richard Henderson Message-id: 20200214181547.21408-5-richard.hender...@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter

[PATCH 1/3] hw/dma/sparc32_dma: Make espdma_memory_[read/write] static

2020-02-21 Thread Philippe Mathieu-Daudé
No code use the espdma_memory_[read/write] functions outside of hw/dma/sparc32_dma.c, make them static. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sparc/sparc32_dma.h | 2 -- hw/dma/sparc32_dma.c | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PULL 40/52] target/arm: Convert PMULL.64 to gvec

2020-02-21 Thread Peter Maydell
From: Richard Henderson The gvec form will be needed for implementing SVE2. Tested-by: Alex Bennée Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson Message-id: 20200216214232.4230-4-richard.hender...@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.h| 4 +---

[PULL 47/52] target/arm: Add isar_feature_aa32_simd_r16

2020-02-21 Thread Peter Maydell
From: Richard Henderson Use this in the places that were checking ARM_FEATURE_VFP, and are obviously testing for the existance of the register set as opposed to testing for some particular instruction extension. Signed-off-by: Richard Henderson Message-id:

[PULL 4/6] tools/virtiofsd/fuse_lowlevel: Fix fuse_out_header::error value

2020-02-21 Thread Dr. David Alan Gilbert (git)
From: Philippe Mathieu-Daudé Fix warning reported by Clang static code analyzer: CC tools/virtiofsd/fuse_lowlevel.o tools/virtiofsd/fuse_lowlevel.c:195:9: warning: Value stored to 'error' is never read error = -ERANGE; ^ ~~~ Fixes: 3db2876 Reported-by:

[PULL 5/6] virtiofsd: Remove fuse.h and struct fuse_module

2020-02-21 Thread Dr. David Alan Gilbert (git)
From: Xiao Yang All code in fuse.h and struct fuse_module are not used by virtiofsd so removing them is safe. Signed-off-by: Xiao Yang Reviewed-by: Stefan Hajnoczi Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse.h | 1229

[PULL 41/52] target/arm: Convert PMULL.8 to gvec

2020-02-21 Thread Peter Maydell
From: Richard Henderson We still need two different helpers, since NEON and SVE2 get the inputs from different locations within the source vector. However, we can convert both to the same internal form for computation. The sve2 helper is not used yet, but adding it with this patch helps

[PULL 42/52] xilinx_spips: Correct the number of dummy cycles for the FAST_READ_4 cmd

2020-02-21 Thread Peter Maydell
From: Francisco Iglesias Correct the number of dummy cycles required by the FAST_READ_4 command (to be eight, one dummy byte). Fixes: ef06ca3946 ("xilinx_spips: Add support for RX discard and RX drain") Suggested-by: Cédric Le Goater Signed-off-by: Francisco Iglesias Reviewed-by: Edgar E.

[PULL 1/6] virtiofsd: Help message fix for 'seconds'

2020-02-21 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" second should be seconds. Reported-by: Christophe de Dinechin Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c index

Re: Race condition in overlayed qcow2?

2020-02-21 Thread dovgaluk
Vladimir Sementsov-Ogievskiy писал 2020-02-21 13:09: 21.02.2020 12:49, dovgaluk wrote: Vladimir Sementsov-Ogievskiy писал 2020-02-20 12:36: 1 or 2 are ok, and 4 or 8 lead to the failures. That is strange. I could think, that it was caused by the bugs in deterministic CPU execution, but the

Re: [PATCH] tcg: gdbstub: Fix single-step issue on arm target

2020-02-21 Thread Philippe Mathieu-Daudé
On 2/21/20 12:51 PM, Changbin Du wrote: On Thu, Feb 20, 2020 at 10:24:37PM +0100, Luc Michel wrote: I'm curious, I never experienced this behaviour from GDB. What GDB and QEMU versions are you using? On my side (GDB 9.1), even without 'vContSupported+' in the 'qSupported' answer, GDB sends a

[Bug 1863601] Re: unable to type "|" character in french keyboard.

2020-02-21 Thread Aditya prakash
Hi Daniel, Thanks for your response. I am using virt-manager to start with to connect with VNC. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1863601 Title: unable to type "|" character in french

[Bug 1863601] Re: unable to type "|" character in french keyboard.

2020-02-21 Thread Daniel Berrange
Can you provide the QEMU command line (/var/log/libvirt/qemu/$GUEST.log) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1863601 Title: unable to type "|" character in french keyboard. Status in

[PULL 01/52] aspeed/scu: Create separate write callbacks

2020-02-21 Thread Peter Maydell
From: Joel Stanley This splits the common write callback into separate ast2400 and ast2500 implementations. This makes it clearer when implementing differing behaviour. Signed-off-by: Joel Stanley Reviewed-by: Andrew Jeffery Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé

[PULL 05/52] z2: Make providing flash images non-mandatory

2020-02-21 Thread Peter Maydell
From: Guenter Roeck Up to now, the z2 machine only boots if a flash image is provided. This is not really necessary; the machine can boot from initrd or from SD without it. At the same time, having to provide dummy flash images is a nuisance and does not add any real value. Make it optional.

  1   2   3   4   >