This series uses python logging to enable output conditionally on
iotests.log(). We unify an initialization call (which also enables
debugging output for those tests with -d) and then make the switch
inside of iotests.
It will help alleviate the need to create logged/unlogged versions
of all the v
This doesn't fix everything in here, but it does help clean up the
pylint report considerably.
This should be 100% style changes only; the intent is to make pylint
more useful by working on establishing a baseline for iotests that we
can gate against in the future. This will be important if (when?
This allows others to get repeatable results with pylint. If you run
`pylint iotests.py`, you should see a 100% pass.
Signed-off-by: John Snow
---
tests/qemu-iotests/pylintrc | 22 ++
1 file changed, 22 insertions(+)
create mode 100644 tests/qemu-iotests/pylintrc
diff --git
It's bad hygiene: if we modify this list, it will be modified across all
invocations.
(Remaining bad usages are fixed in a subsequent patch which changes the
function signature anyway.)
Signed-off-by: John Snow
---
tests/qemu-iotests/iotests.py | 24
1 file changed, 12
The right way to solve this is to come up with a virtual environment
infrastructure that sets all the paths correctly, and/or to create
installable python modules that can be imported normally.
That's hard, so just silence this error for now.
Signed-off-by: John Snow
---
tests/qemu-iotests/iote
79 is the PEP8 recommendation. This recommendation works well for
reading patch diffs in TUI email clients.
Signed-off-by: John Snow
---
tests/qemu-iotests/iotests.py | 69 ++-
tests/qemu-iotests/pylintrc | 6 ++-
2 files changed, 48 insertions(+), 27 deletions
Discourage their use.
(Also, make pending patches not yet using the new entry points fail in a
very obvious way.)
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
tests/qemu-iotests/iotests.py | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tests/q
Since this one is nicely factored to use a single entry point,
use script_main to run the tests.
Signed-off-by: John Snow
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Max Reitz
---
tests/qemu-iotests/258 | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/tests/
Like script_main, but doesn't require a single point of entry.
Replace all existing initialization sections with this drop-in replacement.
This brings debug support to all existing script-style iotests.
Reviewed-by: Max Reitz
Signed-off-by: John Snow
---
tests/qemu-iotests/149| 3 +-
On 3/4/20 10:38 PM, John Snow wrote:
This doesn't fix everything in here, but it does help clean up the
pylint report considerably.
This should be 100% style changes only; the intent is to make pylint
more useful by working on establishing a baseline for iotests that we
can gate against in the f
On 3/4/20 10:38 PM, John Snow wrote:
Discourage their use.
I recommend you to repeat the subject, else it is harder to review
looking only at patch description.
(Also, make pending patches not yet using the new entry points fail in a
very obvious way.)
Reviewed-by: Max Reitz
Signed-off-b
We can turn logging on/off globally instead of per-function.
Remove use_log from run_job, and use python logging to turn on
diffable output when we run through a script entry point.
iotest 245 changes output order due to buffering reasons.
An extended note on python logging:
A NullHandler is a
On 3/4/20 10:38 PM, John Snow wrote:
79 is the PEP8 recommendation. This recommendation works well for
reading patch diffs in TUI email clients.
Signed-off-by: John Snow
---
tests/qemu-iotests/iotests.py | 69 ++-
tests/qemu-iotests/pylintrc | 6 ++-
2 fil
On 3/4/20 10:38 PM, John Snow wrote:
It's bad hygiene: if we modify this list, it will be modified across all
invocations.
(Remaining bad usages are fixed in a subsequent patch which changes the
function signature anyway.)
Signed-off-by: John Snow
---
tests/qemu-iotests/iotests.py | 24 +
This buffer is only used by the adlib audio device. Move it to
the .heap to release 32KiB of .bss (size reported on x86_64 host).
Signed-off-by: Philippe Mathieu-Daudé
---
hw/audio/fmopl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c
The USB descriptor sizes are specified as 16-bit for idVendor /
idProduct, and 8-bit for bInterfaceClass / bInterfaceSubClass /
bInterfaceProtocol. Doing so we reduce the usbredir_raw_serial_ids[]
and usbredir_ftdi_serial_ids[] arrays from 16KiB to 6KiB (size
reported on x86_64 host, building with
Signed-off-by: Philippe Mathieu-Daudé
---
hw/audio/fmopl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c
index 9f50a89b4a..173a7521f2 100644
--- a/hw/audio/fmopl.c
+++ b/hw/audio/fmopl.c
@@ -1066,7 +1066,7 @@ static void OPLResetChip(F
The intel-hda model uses an array of register indexed by the
register address. This array also contains a pair of aliased
registers at offset 0x2000. This creates a huge hole in the
array, which ends up eating 4.6MiB of .rodata (size reported
on x86_64 host, building with --extra-cflags=-Os).
By u
We only need these arrays when using the curses display.
Move them from the .bss to the .heap (sizes reported on
x86_64 host: screen[] is 64KiB, vga_to_curses 7KiB).
Signed-off-by: Philippe Mathieu-Daudé
---
ui/curses.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/
As we only use this array as input, make it const.
Signed-off-by: Philippe Mathieu-Daudé
---
ui/curses.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/curses.c b/ui/curses.c
index 3a1b71451c..3bafc10c1c 100644
--- a/ui/curses.c
+++ b/ui/curses.c
@@ -529,7 +529,7 @@ stati
This series reduce the footprint of the QEMU binary:
.bss: 106KiB (moved to .heap)
.rodata: 4.34MiB
(sizes on x86_64 building with -Os)
The elf-dissector tool [1] [2] helped to notice the big array.
[1] https://phabricator.kde.org/source/elf-dissector/
[2] https://www.volkerkrause.eu/2019/06/22/e
On Wed, 4 Mar 2020, Mark Cave-Ayland wrote:
On 04/03/2020 00:22, BALATON Zoltan wrote:
So on that basis the best explanation as to what is happening is the
comment in the link you provided here:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/powerpc/platforms/chrp/pci
On Wed, Mar 04, 2020 at 04:33:57PM +, Daniel P. Berrangé wrote:
> On Wed, Mar 04, 2020 at 08:25:34AM -0800, Elena Ufimtseva wrote:
> > On Wed, Mar 04, 2020 at 11:00:32AM +, Daniel P. Berrangé wrote:
> > > On Mon, Mar 02, 2020 at 02:39:37PM -0800, Elena Ufimtseva wrote:
> > > > On Mon, Mar 0
On 3/4/20 4:45 PM, Philippe Mathieu-Daudé wrote:
> I don't understand the rational for this change, but the result is
> correct anyway, so thanks for this nice cleanup!
Leftover from when 'no-else-return' was enabled.
It's mostly harmless.
> -Original Message-
> From: Paolo Bonzini On Behalf Of Paolo Bonzini
> Sent: Tuesday, March 3, 2020 9:53 AM
> To: Sunil Muthuswamy ; Richard Henderson
> ; Eduardo Habkost
> Cc: qemu-devel@nongnu.org; Stefan Weil
> Subject: Re: [EXTERNAL] Re: PATCH] WHPX: TSC get and set should be dep
On 04/03/20 23:44, Sunil Muthuswamy wrote:
>> You don't need the "git config --local commit.gpgsign true" command, but
>> you will then create a signed tag with
>>
>> git tag -s -f qemu-for-upstream
>> # let's say "mirror" is your github repo
>> git push mirror +tags/for-upstream
>>
On Sun, 16 Feb 2020 05:55:17 PST (-0800), bmeng...@gmail.com wrote:
At present the board serial number is hard-coded to 1, and passed
to OTP model during initialization. Firmware (FSBL, U-Boot) uses
the serial number to generate a unique MAC address for the on-chip
ethernet controller. When multi
At present the board serial number is hard-coded to 1, and passed
to OTP model during initialization. Firmware (FSBL, U-Boot) uses
the serial number to generate a unique MAC address for the on-chip
ethernet controller. When multiple QEMU 'sifive_u' instances are
created and connected to the same su
At present the board serial number is hard-coded to 1, and passed
to OTP model during initialization. Firmware (FSBL, U-Boot) uses
the serial number to generate a unique MAC address for the on-chip
ethernet controller. When multiple QEMU 'sifive_u' instances are
created and connected to the same su
Split the file into clear machine and SoC sections.
Signed-off-by: Alistair Francis
---
hw/riscv/sifive_u.c | 107 ++--
1 file changed, 54 insertions(+), 53 deletions(-)
diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c
index 156a003642..9a0145b5b4 1
From: Bin Meng
At present the board serial number is hard-coded to 1, and passed
to OTP model during initialization. Firmware (FSBL, U-Boot) uses
the serial number to generate a unique MAC address for the on-chip
ethernet controller. When multiple QEMU 'sifive_u' instances are
created and connect
On Wed, Mar 4, 2020 at 6:47 AM Bin Meng wrote:
>
> Hi Alistair,
>
> On Wed, Mar 4, 2020 at 9:37 AM Alistair Francis
> wrote:
> >
> > At present the board serial number is hard-coded to 1, and passed
> > to OTP model during initialization. Firmware (FSBL, U-Boot) uses
> > the serial number to gene
On 3/4/20 4:58 PM, Philippe Mathieu-Daudé wrote:
> Do we want to indent Python like C and align argument below opening
> parenthesis? Except when using sys.stderr.write() you seem to do it.
This isn't an argument to write, it's an argument to the format string,
so I will say "no."
For *where*
On Wed, Mar 4, 2020 at 3:00 PM Palmer Dabbelt wrote:
>
> On Sun, 16 Feb 2020 05:55:17 PST (-0800), bmeng...@gmail.com wrote:
> > At present the board serial number is hard-coded to 1, and passed
> > to OTP model during initialization. Firmware (FSBL, U-Boot) uses
> > the serial number to generate
Hi Gerd,
On 02/13/20 10:06, Gerd Hoffmann wrote:
> The only difference to hardware revision 4 is that the device doesn't
> switch to VGA mode in case someone happens to touch a VGA register,
> which should make things more robust in configurations with multiple
> vga devices.
>
> Swtiching back to
Patchew URL:
https://patchew.org/QEMU/cover.1583362888.git.alistair.fran...@wdc.com/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN
On Wed, Mar 4, 2020 at 6:10 AM Bin Meng wrote:
>
> On Wed, Mar 4, 2020 at 9:37 AM Alistair Francis
> wrote:
> >
> > Split the file into clear machine and SoC sections.
> >
>
> Yep, I found functions in this file are a little bit confusing as well ..
>
> > Signed-off-by: Alistair Francis
> > ---
The idea is that instead of increasing the arguments to job_run all the
time, create a more general-purpose job runner that can be subclassed to
do interesting things with.
pylint note: the 'callbacks' option guards against unused warning
arguments in functions designated as callbacks. It does not
Requires: 20200304213818.15341-1-js...@redhat.com
(This requires the iotests pylint & logging series.)
The basic idea is to make a generic job runtime manager and allow
callers to subclass the manager. Then, instead of adding callback
arguments to the function all the time, we have à la carte cus
It's easier to work with than a list of tuples, because we can check the
keys for membership.
Signed-off-by: John Snow
---
python/qemu/machine.py| 10 +-
tests/qemu-iotests/040| 12 ++--
tests/qemu-iotests/260| 5 +++--
tests/qemu-iotests/iotests.py | 16
Instead of having somewhat reproduced it for itself.
Signed-off-by: John Snow
---
tests/qemu-iotests/040 | 51 +-
1 file changed, 25 insertions(+), 26 deletions(-)
diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040
index 90b59081ff..e2ef3bb812 1
On 2/20/20 8:05 AM, Philippe Mathieu-Daudé wrote:
> The 'is_write' argument is either 0 or 1.
> Convert it to a boolean type.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/hw/ide/internal.h | 2 +-
> hw/dma/rc4030.c | 6 +++---
> hw/ide/ahci.c | 2 +-
> hw/id
On 2/20/20 8:05 AM, Philippe Mathieu-Daudé wrote:
> The IDE DMA restart callback has been removed in commit fe09c7c9f0.
>
> Fixes: fe09c7c9f0
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/hw/ide/internal.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/hw/ide/inter
> Yes, that's correct. However I'm quite confident from booting other
> non-Solaris OSs
> under qemu-system-sparc64 that PCI native mode is being used,
> particularly as it is
> possible to see the related PCI sabre IRQ routing configuration
> changes.
Considering that Solaris 10 is accessing CFR
Analogous to what commit 5dfa88f7 did for setrlimit, this commit
selectively ignores limits for memory-related resources in prlimit64
calls. This is to prevent too restrictive limits from causing QEMU
itself to malfunction.
Signed-off-by: Tobias Koch
---
linux-user/syscall.c | 16 ++-
This series improves the 'make help' output:
- re-indent current output
- list tools targets:
$ make help
[...]
Architecture specific targets:
x86_64-softmmu/all - Build for x86_64-softmmu
Tools targets:
qemu-ga- Build qemu-ga tool
The 'help' target is displayed unaligned. Add a print-help
function and use it. Now if someone want to change the
indentation, there is a single place to modify.
Signed-off-by: Philippe Mathieu-Daudé
---
Makefile | 44 +++-
1 file changed, 23 insertions(+)
List the name of the tool targets when calling 'make help':
$ make help
[...]
Tools targets:
qemu-ga- Build qemu-ga tool
qemu-keymap- Build qemu-keymap tool
elf2dmp- Build elf2dmp tool
ivshmem-client
Express the macreg[] arrays using typedefs.
No logical changes introduced here.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/net/e1000.c | 6 --
hw/net/e1000e_core.c | 6 --
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index 0b833d5
More memory footprint reduction, similar to:
https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg00984.html
The elf-dissector tool [1] [2] helped to notice the big array.
[1] https://phabricator.kde.org/source/elf-dissector/
[2] https://www.volkerkrause.eu/2019/06/22/elf-dissector-aarch64-su
Reduce a bit the memory footprint by making the helper_opts[]
array const.
Signed-off-by: Philippe Mathieu-Daudé
---
fsdev/virtfs-proxy-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
index aa1ab2590d..de061a8
Each array consumes 256KiB of .data. As we do not reassign entries,
we can move it to the .rodata section, and save a total of 1MiB of
.data (size reported on x86_64 host).
Signed-off-by: Philippe Mathieu-Daudé
---
hw/net/e1000.c | 4 ++--
hw/net/e1000e_core.c | 4 ++--
2 files changed, 4
On Wed, Mar 04, 2020 at 04:33:09PM +0100, Philippe Mathieu-Daudé wrote:
> We already have a ui pointer, use it (to simplify the next commit).
>
> Signed-off-by: Philippe Mathieu-Daudé
Applied to ppc-for-5.0.
> ---
> hw/scsi/spapr_vscsi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletio
On Thu, Mar 05, 2020 at 11:41:37AM +1100, David Gibson wrote:
> On Wed, Mar 04, 2020 at 04:33:10PM +0100, Philippe Mathieu-Daudé wrote:
> > Introduce the req_ui() helper which returns a pointer to
> > the viosrp_iu union held in the vscsi_req structure.
> > This simplifies the next patch.
> >
> >
On Wed, Mar 04, 2020 at 04:33:07PM +0100, Philippe Mathieu-Daudé wrote:
> This header use the srp_* structures declared in "hw/scsi/srp.h".
>
> Signed-off-by: Philippe Mathieu-Daudé
Applied to ppc-for-5.0.
> ---
> hw/scsi/viosrp.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/
On Wed, Mar 04, 2020 at 04:33:08PM +0100, Philippe Mathieu-Daudé wrote:
> Replace sizeof() flexible arrays union srp_iu/viosrp_iu by the
> SRP_MAX_IU_LEN definition, which is what this code actually meant
> to use.
>
> Signed-off-by: Philippe Mathieu-Daudé
Applied to ppc-for-5.0
> ---
> hw/scs
On Wed, Mar 04, 2020 at 04:33:10PM +0100, Philippe Mathieu-Daudé wrote:
> Introduce the req_ui() helper which returns a pointer to
> the viosrp_iu union held in the vscsi_req structure.
> This simplifies the next patch.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/scsi/spapr_vscsi.c | 40
On Wed, Mar 04, 2020 at 04:33:11PM +0100, Philippe Mathieu-Daudé wrote:
> The 'union srp_iu' is meant as a pointer to any SRP Information
> Unit type, it is not related to the size of a VIO DMA buffer.
>
> Use a plain buffer for the VIO DMA read/write calls.
> We can remove the reserved buffer fro
> From: Jean-Philippe Brucker
> Sent: Thursday, March 5, 2020 12:47 AM
>
[...]
> > >
> > > * We can't use DVM in nested mode unless the VMID is shared with the
> > > CPU. For that we'll need the host SMMU driver to hook into the KVM
> VMID
> > > allocator, just like we do for the ASID allocator. I
On 3/4/2020 5:23 PM, Markus Armbruster wrote:
> Pan Nengyuan writes:
>
>> port->bh forgot to delete on the error path, this patch add it to fix
>> memleaks. It's easy to reproduce as follow(add a same nr port):
>> {'execute': 'device_add', 'arguments': {'id': 'virtio_serial_pci0',
>> 'dr
Traditionally, virtio devices don't do DMA by the usual path on the
guest platform. In particular they usually bypass any virtual IOMMU
the guest has, using hypervisor magic to access untranslated guest
physical addresses.
There's now the optional iommu_platform flag which can tell virtio
devices
Upcoming Secure VM support for pSeries machines introduces some
complications for virtio, since the transfer buffers need to be
explicitly shared so that the hypervisor can access them.
While it's not strictly speaking dependent on it, the fact that virtio
devices bypass normal platform IOMMU tran
PAPR specifies a kind of odd, paravirtualized PCI bus, which looks to
the guess mostly like classic PCI, even if some of the individual
devices on the bus are PCI Express. One consequence of that is that
virtio-pci devices still default to being in transitional mode, though
legacy mode is now disa
Cc'ing people listed by "scripts/get_maintainer.pl -f target/i386/hax*".
Rui Prior writes:
> Dear qemu developers,
>
> I found a bug/limitation of qemu on windows (qemu-w64-setup-20200201.exe
> from https://qemu.weilnetz.de/w64/ ) that makes qemu terminate
> immediately with "VCPU shutdown reque
John Snow writes:
> On 3/4/20 3:01 AM, Markus Armbruster wrote:
>> John Snow writes:
>>
>>> On 2/27/20 9:45 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
>>>
>>> I wrote some pylint cleanup for iotests recently, too. Are you targeting
>>> a subset of pylint errors to clean
John Snow writes:
> On 3/4/20 2:22 AM, Markus Armbruster wrote:
>> John Snow writes:
>>
>>> Repeatable results. run `pylint iotests.py` and you should get a pass.
>>
>> Start your sentences with a capital letter, please.
>>
>
> The German complains about the capitalization, but not the senten
John Snow writes:
> On 3/4/20 10:59 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster
>> ---
>> scripts/qapi/commands.py | 2 +-
>> scripts/qapi/expr.py | 3 +--
>> scripts/qapi/gen.py| 9 ++---
>> scripts/qapi/introspect.py | 2 --
>> scripts/qapi/parser.
Hi Eric,
On 2020/3/4 22:26, Auger Eric wrote:
Hi Zenghui,
On 2/7/20 4:20 AM, Zenghui Yu wrote:
Hi Eric,
On 2020/1/28 18:34, Eric Auger wrote:
its_enable_defaults() is the top init function that allocates the
command queue and all the requested tables (device, collection,
lpi config and pendin
This patch fix memleaks when we call tests/qtest/cpu-plug-test on s390x. The
leak stack is as follow:
Direct leak of 48 byte(s) in 1 object(s) allocated from:
#0 0x7fb43c7cd970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970)
#1 0x7fb43be2149d in g_malloc0 (/lib64/libglib-2.0.so.0+0x
This series delay timer_new from init into realize to avoid memleaks when we
call 'device_list_properties'.
And do timer_free only in s390x_cpu_finalize because it's hotplugable. However,
mos6522_realize is never called
at all due to the incorrect creation of it. So we aslo fix the incorrect
cr
There are some memleaks when we call 'device_list_properties'. This patch move
timer_new from init into realize to fix it.
Reported-by: Euler Robot
Signed-off-by: Pan Nengyuan
---
Cc: Laurent Vivier
Cc: Mark Cave-Ayland
Cc: David Gibson
Cc: qemu-...@nongnu.org
---
v2->v1:
- no changes in thi
This patch fix a bug in mac_via where it failed to actually realize devices it
was using.
And move the init codes which inits the mos6522 objects and properties on them
from realize()
into init(). However, we keep qdev_set_parent_bus in realize(), otherwise it
will cause
device-introspect-test t
Patchew URL:
https://patchew.org/QEMU/20200305065422.12707-1-pannengy...@huawei.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v4 0/3] delay timer_new from init to realize to fix memleaks.
Message-id: 20200305065422.12707-
On 3/5/20 1:43 AM, David Gibson wrote:
On Wed, Mar 04, 2020 at 04:33:11PM +0100, Philippe Mathieu-Daudé wrote:
The 'union srp_iu' is meant as a pointer to any SRP Information
Unit type, it is not related to the size of a VIO DMA buffer.
Use a plain buffer for the VIO DMA read/write calls.
We ca
On Mon, Mar 02, 2020 at 03:27:42PM +, Peter Maydell wrote:
>
> Hi -- any progress on this front? (Maybe I missed an email; if
> so, sorry about that...)
>
> thanks
> -- PMM
>
Hi Peter,
Yes, I've made some progress on some of the points raised on the last
email exchanges:
1) Jobs on non-L
On 3/5/2020 2:54 PM, Pan Nengyuan wrote:
> This patch fix a bug in mac_via where it failed to actually realize devices
> it was using.
> And move the init codes which inits the mos6522 objects and properties on
> them from realize()
> into init(). However, we keep qdev_set_parent_bus in realiz
On 3/5/2020 2:54 PM, Pan Nengyuan wrote:
> This patch fix a bug in mac_via where it failed to actually realize devices
> it was using.
> And move the init codes which inits the mos6522 objects and properties on
> them from realize()
> into init(). However, we keep qdev_set_parent_bus in realiz
On Thu, Mar 05, 2020 at 02:56:20AM +, Tian, Kevin wrote:
> > From: Jean-Philippe Brucker
> > Sent: Thursday, March 5, 2020 12:47 AM
> >
> [...]
> > > >
> > > > * We can't use DVM in nested mode unless the VMID is shared with the
> > > > CPU. For that we'll need the host SMMU driver to hook int
On 2/24/20 2:13 PM, Gavin Shan wrote:
The depth of TxFIFO can be 1 or 16 depending on LCR[4]. The TxFIFO is
disabled when its depth is 1. It's nice to have TxFIFO enabled if
possible because more characters can be piled and transmitted at once,
which would have less overhead. Besides, we can be b
> From: Jean-Philippe Brucker
> Sent: Thursday, March 5, 2020 3:34 PM
>
> On Thu, Mar 05, 2020 at 02:56:20AM +, Tian, Kevin wrote:
> > > From: Jean-Philippe Brucker
> > > Sent: Thursday, March 5, 2020 12:47 AM
> > >
> > [...]
> > > > >
> > > > > * We can't use DVM in nested mode unless the V
201 - 280 of 280 matches
Mail list logo