Re: [PATCH v7 3/5] virtio-iommu: Call iommu notifier for attach/detach

2020-03-16 Thread Jean-Philippe Brucker
Hi Bharat, Could you Cc me on your next posting? Unfortunately I don't have much hardware for testing this at the moment, but I might be able to help a little on the review. On Mon, Mar 16, 2020 at 02:40:00PM +0530, Bharat Bhushan wrote: > > >>> First issue is: your guest can use 4K page and

Re: [PATCH] kvm: support to get/set dirty log initial-all-set capability

2020-03-16 Thread Cornelia Huck
On Wed, 4 Mar 2020 10:55:54 +0800 Jay Zhou wrote: > Since the new capability KVM_DIRTY_LOG_INITIALLY_SET of > KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2 has been introduced in the > kernel, tweak the userspace side to detect and enable this > capability. > > Signed-off-by: Jay Zhou > --- >

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-16 Thread Boris Derzhavets
No luck when testing [2]. Reports are attached ** Attachment added: "PPA packages installed" https://bugs.launchpad.net/qemu/+bug/1866870/+attachment/5337552/+files/report.install.ppa -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

Re: [PATCH 0/5] QEMU Gating CI

2020-03-16 Thread Cleber Rosa
- Original Message - > From: "Cleber Rosa" > To: "Peter Maydell" > Cc: "Alex Bennée" , "QEMU Developers" > , "Fam Zheng" , > "Eduardo Habkost" , "Beraldo Leal" , > "Philippe Mathieu-Daudé" > , "Thomas Huth" , "Wainer dos Santos > Moschetta" , "Erik > Skultety" , "Willian Rampazzo"

Re: [PATCH] net: Complete qapi-fication of netdev_add

2020-03-16 Thread Markus Armbruster
Markus Armbruster writes: [...] > We better check all other uses of option group "netdev". To the best of my grepping abilities: = Definition = * qemu_netdev_opts Option group definition, with empty .desc[]. = CLI = Keep in mind: we finish processing CLI netdev before we start monitors

[PATCH 2/2] accel/tcg: avoid integer overflow

2020-03-16 Thread Yifei Jiang
This fixes coverity issues 75235919, etc., 1524/* Handle CPU specific unaligned behaviour */ CID 75235919: (OVERFLOW_BEFORE_WIDEN) 1525. overflow_before_widen: Potentially overflowing expression "1 << a_bits" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic, and

[PATCH] Update copyright date for user-facing copyright strings

2020-03-16 Thread Peter Maydell
Update the copyright date to 2020 for the copyright strings which are user-facing and represent overall copyright info for all of QEMU. Reported-by: John Arbuckle Signed-off-by: Peter Maydell --- include/qemu-common.h | 2 +- docs/conf.py | 2 +- 2 files changed, 2 insertions(+), 2

Re: [PATCH] checkpatch: enforce process for expected files

2020-03-16 Thread Igor Mammedov
On Sun, 15 Mar 2020 07:35:46 -0400 "Michael S. Tsirkin" wrote: > If the process documented in tests/qtest/bios-tables-test.c > is followed, then same patch never touches both expected > files and code. Teach checkpatch to enforce this rule. > > Signed-off-by: Michael S. Tsirkin Tested-by:

[PATCH 09/11] target/mips: Always enable CONFIG_SEMIHOSTING

2020-03-16 Thread Philippe Mathieu-Daudé
On MIPS, the semihosting feature is always required on user-space. Signed-off-by: Philippe Mathieu-Daudé --- default-configs/mips-linux-user-common.mak | 4 default-configs/mips-linux-user.mak| 2 ++ default-configs/mips64-linux-user.mak | 2 ++

[PATCH 02/11] MAINTAINERS: Add an 'overall' entry for accelerators

2020-03-16 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- Cc: Richard Henderson Cc: Paolo Bonzini --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7898e338f6..08d9556ab2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -405,6 +405,15 @@ S: Supported F:

Re: [PATCH] MAINTAINERS: Mark the LatticeMico32 target as orphan

2020-03-16 Thread Paolo Bonzini
On 16/03/20 13:26, Philippe Mathieu-Daudé wrote: > Michael Walle expressed his desire to orphan the lm32 target [*]: > > I guess it is time to pull the plug. Mainly, because I have > no time for this anymore. I've always worked on this on my > spare time and life changed. And secondly, I

[PATCH v2 1/2] lockable: add lock guards

2020-03-16 Thread Stefan Hajnoczi
This patch introduces two lock guard macros that automatically unlock a lock object (QemuMutex and others): void f(void) { QEMU_LOCK_GUARD(); if (!may_fail()) { return; /* automatically unlocks mutex */ } ... } and: WITH_QEMU_LOCK_GUARD() { if

Re: [PATCH v2 0/2] thread: add lock guard macros

2020-03-16 Thread Paolo Bonzini
On 16/03/20 12:09, Stefan Hajnoczi wrote: > Lock guards automatically call qemu_(rec_)mutex_unlock() when returning from a > function or leaving leaving a lexical scope. This simplifies code and > eliminates leaks (especially in error code paths). > > This series adds lock guards for QemuMutex

[PULL 1/6] qapi/audio: add documentation for AudioFormat

2020-03-16 Thread Gerd Hoffmann
From: Volker Rümelin The review for patch ed2a4a7941 "audio: proper support for float samples in mixeng" suggested this would be a good idea. Acked-by: Markus Armbruster Signed-off-by: Volker Rümelin Tested-by: John Arbuckle Message-id: 20200308193321.20668-1-vr_q...@t-online.de

[PULL 4/6] audio: change mixing engine float range to [-1.f, 1.f]

2020-03-16 Thread Gerd Hoffmann
From: Volker Rümelin Currently the internal float range of the mixing engine is [-.5f, .5f]. PulseAudio, SDL2 and libasound use a [-1.f, 1.f] range. This means with float samples the audio playback volume is 6dB too low and audio recording signals will be clipped in most cases. To avoid another

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-16 Thread Boris Derzhavets
** Attachment added: "Check PPA [2} installed" https://bugs.launchpad.net/qemu/+bug/1866870/+attachment/5337555/+files/ppa2installed.txt -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1866870

Re: [PATCH 0/2] Fix Cooperlake CPU model

2020-03-16 Thread Zhang, Cathy
On 3/16/2020 6:24 PM, Paolo Bonzini wrote: On 16/03/20 11:19, Zhang, Cathy wrote: Yes, I see they are already in master, but not in v4.2 yet, so will they be in the next release v5.0? Yes, that's what master will become. Paolo That's great! Thanks for your response!

[PULL 3/6] audio: consistency changes

2020-03-16 Thread Gerd Hoffmann
From: Volker Rümelin Change the clip_natural_float_from_mono() function in audio/mixeng.c to be consistent with the clip_*_from_mono() functions in audio/mixeng_template.h. Signed-off-by: Volker Rümelin Message-id: 20200308193321.20668-3-vr_q...@t-online.de Signed-off-by: Gerd Hoffmann ---

Re: [PATCH 1/4] usb-serial: Move USB_TOKEN_IN into a helper function

2020-03-16 Thread Gerd Hoffmann
Hi, > +if (len > s->recv_used) > +len = s->recv_used; scripts/checkpatch.pl flags a codestyle error here. > -if (len > s->recv_used) > -len = s->recv_used; Which is strictly speaking not your fault as you are just moving around existing code. It's common

[Bug 1866870] Re: KVM Guest pauses after upgrade to Ubuntu 20.04

2020-03-16 Thread Boris Derzhavets
Log file for f31wks guest ** Attachment added: "Log file for f31wks guest" https://bugs.launchpad.net/qemu/+bug/1866870/+attachment/5337553/+files/fedora31wks.log ** Attachment removed: "PPA packages installed"

[PATCH 1/2] tcg: avoid integer overflow

2020-03-16 Thread Yifei Jiang
This fixes coverity issues 75234842, etc.,: 2221tcg_gen_andi_i64(t, t, dup_const(vece, 1)); CID 75234842: (OVERFLOW_BEFORE_WIDEN) . overflow_before_widen: Potentially overflowing expression "1 << nbit" with type "int" (32 bits, signed) is evaluated using 32-bit arithmetic, and

Re: [PATCH v8 0/9] Clock framework API

2020-03-16 Thread Edgar E. Iglesias
On Tue, Feb 25, 2020 at 02:14:13PM +0100, Damien Hedde wrote: > This series aims to add a way to model clock distribution in qemu. > The proposed objet and qdev API allows to model the clock tree of > a platform allowing us to inspect clock configuration and detect > problems such as disabled

[PATCH 04/11] MAINTAINERS: Add an entry for the HVF accelerator

2020-03-16 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- Cc: Reviewed-by: Nikita Leshenko Cc: Sergio Andres Gomez Del Real Cc: Roman Bolshakov Cc: Patrick Colp Cc: Cameron Esfahani Cc: Liran Alon Cc: Heiher --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS

Re: [PATCH] block/io: fix bdrv_co_do_copy_on_readv

2020-03-16 Thread Stefan Hajnoczi
On Thu, Mar 12, 2020 at 11:19:49AM +0300, Vladimir Sementsov-Ogievskiy wrote: > Prior to 1143ec5ebf4 it was OK to qemu_iovec_from_buf() from aligned-up > buffer to original qiov, as qemu_iovec_from_buf() will stop at qiov end > anyway. > > But after 1143ec5ebf4 we assume that

[PATCH 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it

2020-03-16 Thread Philippe Mathieu-Daudé
The semihosting feature is only meaningful when using TCG. So far only the ARM/MIPS/LM32 provide the semihosting feature. Do not enable it by default, and let the few targets requiring it to manually select it. Signed-off-by: Philippe Mathieu-Daudé --- hw/semihosting/Kconfig | 4 +++- 1 file

Re: [PATCH 0/5] QEMU Gating CI

2020-03-16 Thread Daniel P . Berrangé
On Thu, Mar 12, 2020 at 03:36:11PM -0400, Cleber Rosa wrote: > The idea about a public facing Gating CI for QEMU was lastly > summarized in an RFC[1]. Since then, it was decided that a > simpler version should be attempted first. > > Changes from the RFC patches[2] accompanying the RFC document:

[PATCH 10/11] target/arm: Always enable CONFIG_SEMIHOSTING

2020-03-16 Thread Philippe Mathieu-Daudé
On ARM, the semihosting feature is always required on user-space, and is also used by system emulation. Signed-off-by: Philippe Mathieu-Daudé --- default-configs/aarch64-linux-user-common.mak | 4 default-configs/aarch64-linux-user.mak| 2 ++

[PATCH] MAINTAINERS: Mark the LatticeMico32 target as orphan

2020-03-16 Thread Philippe Mathieu-Daudé
Michael Walle expressed his desire to orphan the lm32 target [*]: I guess it is time to pull the plug. Mainly, because I have no time for this anymore. I've always worked on this on my spare time and life changed. And secondly, I guess RISC-V is taking over ;) It has a far better

Re: [PATCH v4 0/6] reference implementation of RSS and hash report

2020-03-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200316100933.11499-1-yuri.benditov...@daynix.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH 0/5] QEMU Gating CI

2020-03-16 Thread Alex Bennée
Daniel P. Berrangé writes: > On Thu, Mar 12, 2020 at 03:36:11PM -0400, Cleber Rosa wrote: >> The idea about a public facing Gating CI for QEMU was lastly >> summarized in an RFC[1]. Since then, it was decided that a >> simpler version should be attempted first. >> >> Changes from the RFC

[PATCH v2 3/8] ppc/spapr: Add FWNMI System Reset state

2020-03-16 Thread Nicholas Piggin
The FWNMI option must deliver system reset interrupts to their registered address, and there are a few constraints on the handler addresses specified in PAPR. Add the system reset address state and checks. Signed-off-by: Nicholas Piggin --- hw/ppc/spapr.c | 2 ++ hw/ppc/spapr_rtas.c

[PATCH v2] hw/ide: Do ide_drive_get() within pci_ide_create_devs()

2020-03-16 Thread BALATON Zoltan
The pci_ide_create_devs() function takes a hd_table parameter but all callers just pass what ide_drive_get() returns so we can do it locally simplifying callers and removing hd_table parameter. Signed-off-by: BALATON Zoltan --- v2: Alternative version that applies without [PATCH 4/8] hw/ide:

Re: [PATCH 2/2] hw/rdma: Skip data-path mr_id translation

2020-03-16 Thread Marcel Apfelbaum
Hi Yuval, On 3/7/20 2:56 PM, Yuval Shaia wrote: With the change made in commit 68b89aee71 ("Utilize ibv_reg_mr_iova for memory registration") the MR emulation is no longer needed in order to translate the guest addresses into host addresses. With that, the next obvious step is to skip entirely

Re: [PATCH 1/8] hw/ide: Get rid of piix3_init functions

2020-03-16 Thread BALATON Zoltan
On Mon, 16 Mar 2020, Markus Armbruster wrote: BALATON Zoltan writes: This removes pci_piix3_ide_init() and pci_piix3_xen_ide_init() functions similar to clean up done to other ide devices. Got a commit hash for "done to other ide devices"? Not yet in master, patches to CMD646 from Mark are

[PULL 0/1] Vga 20200316 patches

2020-03-16 Thread Gerd Hoffmann
The following changes since commit 61c265f0660ee476985808c8aa7915617c44fd53: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20200313a' into staging (2020-03-13 10:33:04 +) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-20200316-pull

Re: [PATCH 1/4] usb-serial: Move USB_TOKEN_IN into a helper function

2020-03-16 Thread Jason Andryuk
On Mon, Mar 16, 2020 at 7:40 AM Gerd Hoffmann wrote: > > Hi, > > > +if (len > s->recv_used) > > +len = s->recv_used; > > scripts/checkpatch.pl flags a codestyle error here. > > > -if (len > s->recv_used) > > -len = s->recv_used; > > Which is strictly speaking not

Re: [PATCH 04/11] MAINTAINERS: Add an entry for the HVF accelerator

2020-03-16 Thread Roman Bolshakov
Hi Philippe, I can take the ownership if nobody wants it. At the moment I'm working on APIC for HVF to get kvm-unit-tests fixed. Next items on the list (in no particular order): * MMX emulation * SSE emulation * qxl display * gdb stub * virtio-gpu/virgil running on metal * VFIO-PCI based on

Re: [PATCH] travis.yml: Set G_MESSAGES_DEBUG do report GLib errors

2020-03-16 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Since commit f5852efa293 we can display GLib errors with the QEMU > error reporting API. Set it to the 'error' level, as this helps > understanding failures from QEMU calls to GLib on Travis-CI. > > Signed-off-by: Philippe Mathieu-Daudé Queued to

Re: [PATCH 1/2] tcg: avoid integer overflow

2020-03-16 Thread Peter Maydell
On Mon, 16 Mar 2020 at 13:15, Yifei Jiang wrote: > > This fixes coverity issues 75234842, etc.,: Where does this issue number come from, by the way? It's not from the online Coverity Scan we use which is the issue ID we usually cite for coverity stuff. > 2221tcg_gen_andi_i64(t, t,

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-16 Thread Igor Mammedov
On Fri, 13 Mar 2020 11:26:45 -0400 "Michael S. Tsirkin" wrote: > On Fri, Mar 13, 2020 at 10:36:56AM +0100, Igor Mammedov wrote: > > On Thu, 12 Mar 2020 13:09:51 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Mar 12, 2020 at 05:27:45PM +0100, Igor Mammedov wrote: > > > > On Wed, 11

Re: [PATCH v2 4/8] qapi/misc: Move query-uuid command with block code

2020-03-16 Thread Igor Mammedov
On Mon, 16 Mar 2020 01:03:44 +0100 Philippe Mathieu-Daudé wrote: here should be why PS: I don't see a reason to move it to block code at all if this command is moved then it should be machine code > Signed-off-by: Philippe Mathieu-Daudé > --- > qapi/block-core.json | 30

Re: [PATCH v2 5/8] qapi/misc: Restrict query-vm-generation-id command to machine code

2020-03-16 Thread Igor Mammedov
On Mon, 16 Mar 2020 01:03:45 +0100 Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Igor Mammedov > --- > qapi/machine.json | 20 > qapi/misc.json| 21 - > hw/acpi/vmgenid.c | 2 +- > stubs/vmgenid.c | 2 +- > 4

Re: [PATCH 2/2] accel/tcg: avoid integer overflow

2020-03-16 Thread Peter Maydell
On Mon, 16 Mar 2020 at 12:14, Yifei Jiang wrote: > > This fixes coverity issues 75235919, etc., > 1524/* Handle CPU specific unaligned behaviour */ > CID 75235919: (OVERFLOW_BEFORE_WIDEN) > 1525. overflow_before_widen: Potentially overflowing expression "1 << > a_bits" with type

Re: [PATCH 1/1] target/ppc: fix ELFv2 signal handler endianness

2020-03-16 Thread Vincent Fazio
Laurent, On Sun, Mar 15, 2020 at 1:10 PM Laurent Vivier wrote: > > Le 15/03/2020 à 16:52, Vincent Fazio a écrit : > > From: Vincent Fazio > > > > In ELFv2, function pointers are entry points and are in host endianness. > > "host endianness" is misleading here. "target endianness" is better. I

Re: [PATCH 1/4] tests/vm: write raw console log

2020-03-16 Thread Alex Bennée
Gerd Hoffmann writes: > Run "tail -f /var/tmp/*/qemu*console.raw" in another terminal > to watch the install console. > > Signed-off-by: Gerd Hoffmann I suspect this is what's breaking "make check-acceptance" so I've dropped the series from testing/next for now. 2020-03-11 12:12:30,546

Re: [PATCH v2 6/8] qapi/misc: Restrict ACPI commands to machine code

2020-03-16 Thread Igor Mammedov
On Mon, 16 Mar 2020 01:03:46 +0100 Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Igor Mammedov > --- > qapi/machine.json| 154 +++ > qapi/misc.json | 154 --- >

Re: [PATCH 0/8] Misc hw/ide legacy clean up

2020-03-16 Thread BALATON Zoltan
On Mon, 16 Mar 2020, BALATON Zoltan wrote: On Mon, 16 Mar 2020, Markus Armbruster wrote: BALATON Zoltan writes: These are some clean ups to remove more legacy init functions and lessen dependence on include/hw/ide.h with some simplifications in board code. There should be no functional

Re: [PATCH 0/2] avoid integer overflow

2020-03-16 Thread Peter Maydell
On Mon, 16 Mar 2020 at 12:25, Yifei Jiang wrote: > > the constant default type is "int", when the constant is shifted to the left, > it may exceed 32 bits, resulting in integer overflowing. So constant type need > change to "long" "long" would not in general be the right type to use in cases

[PATCH 08/11] target/Kconfig: Allow targets to use Kconfig

2020-03-16 Thread Philippe Mathieu-Daudé
Allow targets to select target-specific Kconfig values. Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 6 -- target/Kconfig | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) create mode 100644 target/Kconfig diff --git a/Makefile b/Makefile index 1cf9d76ce7..e402c33811

Re: [PATCH 0/5] QEMU Gating CI

2020-03-16 Thread Cleber Rosa
- Original Message - > From: "Daniel P. Berrangé" > To: "Cleber Rosa" > Cc: "Alex Bennée" , "Peter Maydell" > , qemu-devel@nongnu.org, "Fam > Zheng" , "Thomas Huth" , "Eduardo Habkost" > , "Erik Skultety" > , "Wainer Moschetta" , "Wainer dos > Santos Moschetta" > , "Willian

[PULL 1/1] stdvga+bochs-display: add dummy mmio handler

2020-03-16 Thread Gerd Hoffmann
The bochs-display mmio bar has some sub-regions with the actual hardware registers. What happens when the guest access something outside those regions depends on the archirecture. On x86 those reads succeed (and return 0xff I think). On risc-v qemu aborts. This patch adds handlers for the

[Bug 1813165] Re: KVM internal error. Suberror: 1 emulation failure

2020-03-16 Thread Jon Hood
I created a new bug request to track the Ubuntu 20.04 package (bug #1867545) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1813165 Title: KVM internal error. Suberror: 1 emulation failure Status

Re: [PATCH] MAINTAINERS: Mark the LatticeMico32 target as orphan

2020-03-16 Thread Philippe Mathieu-Daudé
On 3/16/20 2:32 PM, Michael Walle wrote: Hi, Am 2020-03-16 13:26, schrieb Philippe Mathieu-Daudé: Michael Walle expressed his desire to orphan the lm32 target [*]:   I guess it is time to pull the plug. Mainly, because I have   no time for this anymore. I've always worked on this on my  

Re: [PATCH 0/5] QEMU Gating CI

2020-03-16 Thread Cleber Rosa
- Original Message - > From: "Peter Maydell" > To: "Cleber Rosa" > Cc: "Alex Bennée" , "QEMU Developers" > , "Fam Zheng" , > "Eduardo Habkost" , "Beraldo Leal" , > "Philippe Mathieu-Daudé" > , "Thomas Huth" , "Wainer dos Santos > Moschetta" , "Erik > Skultety" , "Willian Rampazzo"

Re: [PATCH 6/8] hw/ide: Do ide_drive_get() within pci_ide_create_devs()

2020-03-16 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 3/16/20 7:23 AM, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 13/03/20 23:16, BALATON Zoltan wrote: > > +    pci_dev = pci_create_simple(pci_bus, -1, "cmd646-ide"); > +    pci_ide_create_devs(pci_dev); Additionally, I

[PATCH] MAINTAINERS: Add an entry for the HVF accelerator

2020-03-16 Thread Roman Bolshakov
Cc: Nikita Leshenko Cc: Sergio Andres Gomez Del Real Cc: Patrick Colp Cc: Cameron Esfahani Cc: Liran Alon Cc: Heiher Signed-off-by: Roman Bolshakov --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 32867bc636..e544f3012e 100644 ---

Re: [PATCH 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it

2020-03-16 Thread Peter Maydell
On Mon, 16 Mar 2020 at 13:45, Philippe Mathieu-Daudé wrote: > > The semihosting feature is only meaningful when using TCG. > > So far only the ARM/MIPS/LM32 provide the semihosting feature. Also m68k, nios2, xtensa. riscv eventually but not yet upstream. > > Do not enable it by default, and let

[PATCH v6 07/42] nvme: refactor nvme_addr_read

2020-03-16 Thread Klaus Jensen
From: Klaus Jensen Pull the controller memory buffer check to its own function. The check will be used on its own in later patches. Signed-off-by: Klaus Jensen Acked-by: Keith Busch --- hw/block/nvme.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git

[PATCH v2] hw/ide: Move MAX_IDE_DEVS define to hw/ide/internal.h

2020-03-16 Thread BALATON Zoltan
We can move this define now that less files use it to internal.h to further reduce dependency on hw/ide.h. Signed-off-by: BALATON Zoltan --- v2: Alternative version of patch 7 that applies without [PATCH 4/8] hw/ide: Move MAX_IDE_BUS define to one header include/hw/ide.h | 2 --

Re: [PATCH 0/8] Misc hw/ide legacy clean up

2020-03-16 Thread BALATON Zoltan
On Mon, 16 Mar 2020, Markus Armbruster wrote: BALATON Zoltan writes: These are some clean ups to remove more legacy init functions and lessen dependence on include/hw/ide.h with some simplifications in board code. There should be no functional change. PATCH 1 could quote precedence more

Re: [PATCH 1/2] hw/rdma: Cosmetic change - no need for two sge arrays

2020-03-16 Thread Marcel Apfelbaum
Hi Yuval, On 3/7/20 2:56 PM, Yuval Shaia wrote: The function build_host_sge_array uses two sge arrays, one for input and one for output. Since the size of the two arrays is the same, the function can write directly to the given source array (i.e. input/output argument). Signed-off-by: Yuval

Re: [PATCH v2 8/8] qapi/misc: Restrict device memory commands to machine code

2020-03-16 Thread Igor Mammedov
On Mon, 16 Mar 2020 01:03:48 +0100 Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Igor Mammedov > --- > qapi/machine.json | 131 +++ > qapi/misc.json | 132 >

Re: [PATCH 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it

2020-03-16 Thread Philippe Mathieu-Daudé
On 3/16/20 2:49 PM, Peter Maydell wrote: On Mon, 16 Mar 2020 at 13:45, Philippe Mathieu-Daudé wrote: The semihosting feature is only meaningful when using TCG. So far only the ARM/MIPS/LM32 provide the semihosting feature. Also m68k, nios2, xtensa. riscv eventually but not yet upstream.

[PATCH v6 13/42] nvme: add support for the asynchronous event request command

2020-03-16 Thread Klaus Jensen
From: Klaus Jensen Required for compliance with NVMe revision 1.2.1. See NVM Express 1.2.1, Section 5.2 ("Asynchronous Event Request command"). Mostly imported from Keith's qemu-nvme tree. Modified with a max number of queued events (controllable with the aer_max_queued device parameter). The

[PULL 12/38] linux-user: Support futex_time64

2020-03-16 Thread Laurent Vivier
From: Alistair Francis Add support for host and target futex_time64. If futex_time64 exists on the host we try that first before falling back to the standard futex syscall. Signed-off-by: Alistair Francis Reviewed-by: Laurent Vivier Message-Id:

[PULL 30/38] linux-user, mips64: add syscall table generation support

2020-03-16 Thread Laurent Vivier
Copy syscall_n32.tbl, syscall_n64.tbl and syscallhdr.sh from linux/arch/parisc/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Move the offsets (6000 for n32 and 5000 for n64) from the file to the Makefile.objs to be passed to syscallhdr.sh Signed-off-by: Laurent Vivier

Re: [PATCH v2 7/8] ppc/spapr: Implement FWNMI System Reset delivery

2020-03-16 Thread Mahesh J Salgaonkar
On 2020-03-17 00:26:12 Tue, Nicholas Piggin wrote: > PAPR requires that if "ibm,nmi-register" succeeds, then the hypervisor > delivers all system reset and machine check exceptions to the registered > addresses. > > System Resets are delivered with registers set to the architected state, > and

Re: [PATCH v3 06/34] tests/test-qmp-cmds: Check responses more thoroughly

2020-03-16 Thread Eric Blake
On 3/15/20 9:46 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- tests/test-qmp-cmds.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) @@ -163,9 +164,17 @@ static QObject *do_qmp_dispatch(QDict *req, bool allow_oob) static void

[PATCH v1 09/28] gdbstub: move mem_buf to GDBState and use GByteArray

2020-03-16 Thread Alex Bennée
This is in preparation for further re-factoring of the register API with the rest of the code. Theoretically the read register function could overwrite the MAX_PACKET_LENGTH buffer although currently all registers are well within the size range. Signed-off-by: Alex Bennée Reviewed-by: Richard

[PULL 27/38] linux-user, i386: add syscall table generation support

2020-03-16 Thread Laurent Vivier
Copy syscall_32.tbl and syscallhdr.sh from linux/arch/x86/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Signed-off-by: Laurent Vivier Reviewed-by: Taylor Simpson Message-Id: <20200310103403.3284090-15-laur...@vivier.eu> Signed-off-by: Laurent Vivier --- configure

[PATCH v2 0/4] usb-serial: xHCI and timeout fixes

2020-03-16 Thread Jason Andryuk
This patch series includes two fixes for usb-serial. The first is a data corruption issue with xHCI controllers. The FTDI data packets need to have a 2 byte header start every 64 bytes of packet data. For EHCI this is not a problem since USBPacket size is 64, so only 1 such chunk fits in a

[PATCH v1 12/28] target/m68k: use gdb_get_reg helpers

2020-03-16 Thread Alex Bennée
This is cleaner than poking memory directly and will make later clean-ups easier. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier --- v3 - fix mem_buf references - fix mem_buf + len cases --- target/m68k/helper.c | 29 +++-- 1

[PULL 24/38] linux-user, s390x: add syscall table generation support

2020-03-16 Thread Laurent Vivier
Copy syscall.tbl from linux/arch/s390x/kernel/syscalls v5.5 Copy syscallhdr.sh from m68k. Signed-off-by: Laurent Vivier Reviewed-by: Taylor Simpson Message-Id: <20200310103403.3284090-12-laur...@vivier.eu> Signed-off-by: Laurent Vivier --- configure | 3 +-

[PATCH v1 15/28] target/arm: prepare for multiple dynamic XMLs

2020-03-16 Thread Alex Bennée
We will want to generate similar dynamic XML for gdbstub support of SVE registers (the upstream doesn't use XML). To that end lightly rename a few things to make the distinction. Signed-off-by: Alex Bennée Acked-by: Richard Henderson --- target/arm/cpu.h | 20 +---

[PULL 18/38] linux-user, xtensa: add syscall table generation support

2020-03-16 Thread Laurent Vivier
Copy syscall.tbl and syscallhdr.sh from linux/arch/xtensa/kernel/syscalls v5.5 Update syscallhdr.sh to generate QEMU syscall_nr.h Signed-off-by: Laurent Vivier Reviewed-by: Taylor Simpson Message-Id: <20200310103403.3284090-6-laur...@vivier.eu> Signed-off-by: Laurent Vivier --- configure

Re: [PATCH 1/2] block: bdrv_set_backing_bs: fix use-after-free

2020-03-16 Thread John Snow
On 3/16/20 4:47 AM, Philippe Mathieu-Daudé wrote: > On 3/16/20 7:06 AM, Vladimir Sementsov-Ogievskiy wrote: >> There is a use-after-free possible: bdrv_unref_child() leaves >> bs->backing freed but not NULL. bdrv_attach_child may produce nested >> polling loop due to drain, than access of freed

RE: [PATCH v3 1/4] scripts: add a script to generate syscall_nr.h

2020-03-16 Thread Taylor Simpson
> -Original Message- > From: Laurent Vivier > Sent: Monday, March 16, 2020 3:56 AM > To: qemu-devel@nongnu.org > Cc: Laurent Vivier ; Richard Henderson > ; Riku Voipio ; Taylor > Simpson ; Alistair Francis > > Subject: [PATCH v3 1/4] scripts: add a script to generate syscall_nr.h > >

Re: [PATCH V2] vhost: correctly turn on VIRTIO_F_IOMMU_PLATFORM

2020-03-16 Thread Peter Xu
On Mon, Mar 16, 2020 at 01:19:54PM -0400, Michael S. Tsirkin wrote: > On Fri, Mar 13, 2020 at 12:31:22PM -0400, Peter Xu wrote: > > On Fri, Mar 13, 2020 at 11:29:59AM -0400, Michael S. Tsirkin wrote: > > > On Fri, Mar 13, 2020 at 01:44:46PM +0100, Halil Pasic wrote: > > > > [..] > > > > > > > > >

Re: [PATCH v3 15/34] qapi/introspect: Factor out _make_tree()

2020-03-16 Thread Marc-André Lureau
On Sun, Mar 15, 2020 at 4:14 PM Markus Armbruster wrote: > > The value of @qmp_schema_qlit is generated from an expression tree. > Tree nodes are created in several places. Factor out the common code > into _make_tree(). This isn't much of a win now. It will pay off > when we add feature flags

[PATCH v2] MAINTAINERS: Add an entry for the HVF accelerator

2020-03-16 Thread Roman Bolshakov
Cc: Nikita Leshenko Cc: Sergio Andres Gomez Del Real Cc: Patrick Colp Cc: Cameron Esfahani Cc: Liran Alon Cc: Heiher Signed-off-by: Roman Bolshakov --- Changes since v1: Status is changed to Maintained instead of Supported. MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+)

[PATCH v1 21/28] configure: allow user to specify what gdb to use

2020-03-16 Thread Alex Bennée
This is useful, especially when testing relatively new gdbstub features that might not be in distro packages yet. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- configure | 9 + 1 file changed, 9 insertions(+) diff --git a/configure b/configure index

Re: [PATCH v3 18/34] qapi/schema: Rename QAPISchemaObjectType{Variant, Variants}

2020-03-16 Thread Marc-André Lureau
On Sun, Mar 15, 2020 at 4:19 PM Markus Armbruster wrote: > > QAPISchemaObjectTypeVariants represents both object type and alternate > type variants. Rename to QAPISchemaVariants. > > Rename QAPISchemaObjectTypeVariant the same way. > > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André

Re: [PATCH v3 18/19] hw/arm: Do not build to 'virt' machine on Xen

2020-03-16 Thread Stefano Stabellini
On Mon, 16 Mar 2020, Philippe Mathieu-Daudé wrote: > Xen on ARM does not use QEMU machines [*]. Disable the 'virt' > machine there to avoid odd errors such: > > CC i386-softmmu/hw/cpu/a15mpcore.o > hw/cpu/a15mpcore.c:28:10: fatal error: kvm_arm.h: No such file or directory > > [*] >

Re: [PATCH v3 13/34] qapi: Consistently put @features parameter right after @ifcond

2020-03-16 Thread Eric Blake
On 3/15/20 9:46 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- scripts/qapi/commands.py | 6 +++--- scripts/qapi/doc.py| 10 +- scripts/qapi/introspect.py | 10 +- scripts/qapi/schema.py | 36

Re: [PATCH v3 19/34] qapi/schema: Call QAPIDoc.connect_member() in just one place

2020-03-16 Thread Marc-André Lureau
On Sun, Mar 15, 2020 at 4:00 PM Markus Armbruster wrote: > > The .connect_doc() of classes that have QAPISchemaMember connect them > to their documentation. Change them to delegate the actual work to > new QAPISchemaMember.connect_doc(). Matches the .connect_doc() that > already exist. > >

Re: [PATCH v3 22/34] qapi: Simplify how qmp_dispatch() deals with QCO_NO_SUCCESS_RESP

2020-03-16 Thread Marc-André Lureau
On Sun, Mar 15, 2020 at 3:51 PM Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > qapi/qmp-dispatch.c | 25 + > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/qapi/qmp-dispatch.c

Re: [PATCH v3 20/34] qapi: Add feature flags to struct members

2020-03-16 Thread Marc-André Lureau
On Sun, Mar 15, 2020 at 4:23 PM Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau > --- > docs/devel/qapi-code-gen.txt| 4 +++- > tests/qapi-schema/doc-good.texi | 2 ++ > qapi/introspect.json| 6 +- >

Re: [PATCH v2 2/8] ppc/spapr: Change FWNMI names

2020-03-16 Thread Cédric Le Goater
On 3/16/20 3:26 PM, Nicholas Piggin wrote: > The option is called "FWNMI", and it involves more than just machine > checks, also machine checks can be delivered without the FWNMI option, > so re-name various things to reflect that. Reviewed-by: Cédric Le Goater > Signed-off-by: Nicholas

Re: [PATCH 02/11] MAINTAINERS: Add an 'overall' entry for accelerators

2020-03-16 Thread Richard Henderson
On 3/16/20 5:00 AM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > Cc: Richard Henderson > Cc: Paolo Bonzini > --- > MAINTAINERS | 9 + > 1 file changed, 9 insertions(+) Reviewed-by: Richard Henderson r~

[PATCH v1 08/28] gdbstub: move str_buf to GDBState and use GString

2020-03-16 Thread Alex Bennée
Rather than having a static buffer replace str_buf with a GString which we know can grow on demand. Convert the internal functions to take a GString instead of a char * and length. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Damien Hedde Tested-by: Damien Hedde ---

Re: [PATCH v2 3/8] ppc/spapr: Add FWNMI System Reset state

2020-03-16 Thread Greg Kurz
On Tue, 17 Mar 2020 00:26:08 +1000 Nicholas Piggin wrote: > The FWNMI option must deliver system reset interrupts to their > registered address, and there are a few constraints on the handler > addresses specified in PAPR. Add the system reset address state and > checks. > > Signed-off-by:

[PATCH v1 27/28] gdbstub: do not split gdb_monitor_write payload

2020-03-16 Thread Alex Bennée
From: Damien Hedde Since we can now send packets of arbitrary length: simplify gdb_monitor_write() and send the whole payload in one packet. Suggested-by: Luc Michel Signed-off-by: Damien Hedde Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id:

[PATCH v1 11/28] target/arm: use gdb_get_reg helpers

2020-03-16 Thread Alex Bennée
This is cleaner than poking memory directly and will make later clean-ups easier. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- v2 - make sure we pass hi/lo correctly as quads are stored in LE order --- target/arm/helper.c | 18

Re: [PATCH v2 2/8] ppc/spapr: Change FWNMI names

2020-03-16 Thread Mahesh J Salgaonkar
On 2020-03-17 00:26:07 Tue, Nicholas Piggin wrote: > The option is called "FWNMI", and it involves more than just machine > checks, also machine checks can be delivered without the FWNMI option, > so re-name various things to reflect that. > > Signed-off-by: Nicholas Piggin > --- >

Re: [PATCH v4] python/qemu/qmp.py: QMP debug with VM label

2020-03-16 Thread John Snow
On 3/16/20 6:32 AM, Oksana Vohchana wrote: > QEMUMachine writes some messages to the default logger. > But it sometimes hard to read the output if we have requests to > more than one VM. > This patch adds a label to the logger in the debug mode. > > Signed-off-by: Oksana Vohchana > --- > v2:

[PATCH v1 22/28] tests/guest-debug: add a simple test runner

2020-03-16 Thread Alex Bennée
The test runners job is to start QEMU with guest debug enabled and then spawn a gdb process running a test script that exercises the functionality it wants to test. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- tests/guest-debug/run-test.py | 57

Re: [PATCH 1/2] migration: avoid suspicious strncpy() use

2020-03-16 Thread Juan Quintela
Stefan Hajnoczi wrote: > gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1) with sanitizers enabled > reports the following error: > > CC migration/global_state.o > In file included from /usr/include/string.h:495, >from /home/stefanha/qemu/include/qemu/osdep.h:101, >

Re: [PATCH v2 2/2] mmap-alloc: Include osdep.h before checking CONFIG_LINUX

2020-03-16 Thread Eduardo Habkost
On Mon, Mar 16, 2020 at 06:08:54PM +, Peter Maydell wrote: > On Mon, 16 Mar 2020 at 17:51, Eduardo Habkost wrote: > > Yes, but both MAP_SYNC and MAP_SHARED_VALIDATE aren't available > > if the host is not Linux. > > > > Defining MAP_SYNC to 0 on MIPS would restore the existing > > behavior,

[PATCH v2 1/4] usb-serial: Move USB_TOKEN_IN into a helper function

2020-03-16 Thread Jason Andryuk
We'll be adding a loop, so move the code into a helper function. breaks are replaced with returns. While making this change, add braces to single line if statements to comply with coding style and keep checkpatch happy. Signed-off-by: Jason Andryuk --- v2: Add braces to single line if

[PATCH v1 17/28] target/arm: default SVE length to 64 bytes for linux-user

2020-03-16 Thread Alex Bennée
The Linux kernel chooses the default of 64 bytes for SVE registers on the basis that it is the largest size on known hardware that won't grow the signal frame. We still honour the sve-max-vq property and userspace can expand the number of lanes by calling PR_SVE_SET_VL. This should not make any

<    1   2   3   4   5   6   7   >