Re: [PATCH v3 24/34] qapi: Replace qmp_dispatch()'s TODO comment by an explanation

2020-03-16 Thread Marc-André Lureau
Hi On Sun, Mar 15, 2020 at 3:48 PM Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster > --- > qapi/qmp-dispatch.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c > index 112d29a9ab..fb53687ce9 100644 > ---

[PATCH v1 07/28] gdbstub: stop passing GDBState * around and use global

2020-03-16 Thread Alex Bennée
We only have one GDBState which should be allocated at the time we process any commands. This will make further clean-up a bit easier. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Damien Hedde Reviewed-by: Philippe Mathieu-Daudé --- v3 - remove final *s paramters

Re: [PATCH v2 2/9] hw/core/qdev-properties: Use qemu_strtoul() in set_pci_host_devaddr()

2020-03-16 Thread Richard Henderson
On 3/15/20 5:11 PM, Philippe Mathieu-Daudé wrote: > Replace strtoul() by qemu_strtoul() so checkpatch.pl won't > complain if we move this code later. Increase the slot and > func local variables to unsigned long so that the range check > isn't truncated. Remove the 'e == p' test which is done in >

Re: [PATCH v3 05/34] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers

2020-03-16 Thread Eric Blake
On 3/15/20 9:46 AM, Markus Armbruster wrote: Checking the value of qmp_dispatch() is repetitive. Factor out helpers do_qmp_dispatch() and do_qmp_dispatch_error(). Without this, the next commit would make things even more repetitive. Signed-off-by: Markus Armbruster ---

Re: [PATCH V2] vhost: correctly turn on VIRTIO_F_IOMMU_PLATFORM

2020-03-16 Thread Peter Xu
On Mon, Mar 16, 2020 at 05:57:37PM +0100, Halil Pasic wrote: > On Fri, 13 Mar 2020 12:31:22 -0400 > Peter Xu wrote: > > > On Fri, Mar 13, 2020 at 11:29:59AM -0400, Michael S. Tsirkin wrote: > > > On Fri, Mar 13, 2020 at 01:44:46PM +0100, Halil Pasic wrote: > > > > [..] > > > > > > > > > > > >

Re: [PATCH v5 57/60] target/riscv: vector slide instructions

2020-03-16 Thread Richard Henderson
On 3/16/20 1:04 AM, LIU Zhiwei wrote: >> As a preference, I think you can do away with this helper. >> Simply use the slideup helper with argument 1, and then >> afterwards store the integer register into element 0.  You should be able to >> re-use code from vmv.s.x for that. > When I try it, I

[PATCH v3 05/25] hw/arm: Use memory_region_init_rom() with read-only regions

2020-03-16 Thread Philippe Mathieu-Daudé
This commit was produced with the Coccinelle script scripts/coccinelle/memory-region-housekeeping.cocci. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4210.c | 3 +-- hw/arm/mainstone.c | 3 +-- hw/arm/omap_sx1.c | 6 ++ hw/arm/palm.c | 3 +-- hw/arm/spitz.c | 3 +--

Re: [PATCH v3 23/34] qapi: Simplify how qmp_dispatch() gets the request ID

2020-03-16 Thread Marc-André Lureau
On Sun, Mar 15, 2020 at 3:51 PM Markus Armbruster wrote: > > We convert the request object to a QDict twice: first in > qmp_dispatch() to get the request ID, and then again in > qmp_dispatch_check_obj(), which converts to QDict, then checks and > returns it. We can't get the request ID from the

Re: [PATCH v3 11/34] qapi/schema: Clean up around QAPISchemaEntity.connect_doc()

2020-03-16 Thread Eric Blake
On 3/15/20 9:46 AM, Markus Armbruster wrote: QAPISchemaEntity calls doc.connect_feature() in .check(). Improper since commit ee1e6a1f6c8 split .connect_doc() off .check(). Move the call. Requires making the children call super().connect_doc() as they should. Signed-off-by: Markus Armbruster

Re: [PATCH v2 6/8] target/ppc: allow ppc_cpu_do_system_reset to take an alternate vector

2020-03-16 Thread Cédric Le Goater
On 3/16/20 3:26 PM, Nicholas Piggin wrote: > Provide for an alternate delivery location, -1 defaults to the > architected address. I don't know what is the best approach, to override the vector addr computed by powerpc_excp() or use a machine class handler with cpu->vhyp. > Signed-off-by:

Re: [PATCH v2 2/2] mmap-alloc: Include osdep.h before checking CONFIG_LINUX

2020-03-16 Thread Eduardo Habkost
On Sun, Mar 15, 2020 at 05:15:46PM -0400, Michael S. Tsirkin wrote: > On Sun, Mar 15, 2020 at 11:45:59AM -0400, Eduardo Habkost wrote: > > On Wed, Mar 11, 2020 at 07:23:42PM -0400, Eduardo Habkost wrote: > > > The CONFIG_LINUX check at the top of mmap-alloc.c never worked > > > because it was done

Re: [PATCH v2 7/8] ppc/spapr: Implement FWNMI System Reset delivery

2020-03-16 Thread Greg Kurz
On Mon, 16 Mar 2020 23:05:00 +0530 Mahesh J Salgaonkar wrote: > On 2020-03-17 00:26:12 Tue, Nicholas Piggin wrote: > > PAPR requires that if "ibm,nmi-register" succeeds, then the hypervisor > > delivers all system reset and machine check exceptions to the registered > > addresses. > > > >

Re: [PULL 0/1] Vga 20200316 patches

2020-03-16 Thread Peter Maydell
are available in the Git repository at: > > git://git.kraxel.org/qemu tags/vga-20200316-pull-request > > for you to fetch changes up to f872c76296b991fde4db5fb87a1cfbd8d4c22c88: > > stdvga+bochs-display: add dum

Re: [PATCH v9] fixup! Fix subcode/pbt

2020-03-16 Thread Cornelia Huck
On Mon, 16 Mar 2020 16:05:03 +0100 Janosch Frank wrote: > On 3/16/20 3:54 PM, Cornelia Huck wrote: > > On Mon, 16 Mar 2020 15:47:41 +0100 > > Janosch Frank wrote: > > > >> On 3/16/20 3:27 PM, Cornelia Huck wrote: > >>> On Fri, 13 Mar 2020 05:52:32 -0400 > >>> Janosch Frank wrote: > >>>

Re: [PATCH v2 5/8] ppc/spapr: Allow FWNMI on TCG

2020-03-16 Thread Cédric Le Goater
On 3/16/20 3:26 PM, Nicholas Piggin wrote: > There should no longer be a reason to prevent TCG providing FWNMI. > System Reset interrupts are generated to the guest with nmi monitor > command and H_SIGNAL_SYS_RESET. Machine Checks can not be injected > currently, but this could be implemented with

Re: [PATCH 2/2] block/qcow2: zero data_file child after free

2020-03-16 Thread John Snow
On 3/16/20 2:06 AM, Vladimir Sementsov-Ogievskiy wrote: > data_file being NULL doesn't seem to be a correct state, but it's > better than dead pointer and simpler to debug. > How important is it to have correct state in the middle of teardown? > Signed-off-by: Vladimir Sementsov-Ogievskiy >

Re: [PATCH v3 2/2] net: tulip: add .can_recieve routine

2020-03-16 Thread P J P
Hello Stefan, Jason, +-- On Fri, 6 Mar 2020, Stefan Hajnoczi wrote --+ | > +static int | > +tulip_can_receive(NetClientState *nc) | > +{ | > +TULIPState *s = qemu_get_nic_opaque(nc); | > + | > +if (s->rx_frame_len || tulip_rx_stopped(s)) { | > +return false; | > +} | > + | >

Re: [PATCH 11/11] hw/semihosting: Make the feature depend of TCG, and allow to disable it

2020-03-16 Thread Richard Henderson
On 3/16/20 5:00 AM, Philippe Mathieu-Daudé wrote: > The semihosting feature is only meaningful when using TCG. > > So far only the ARM/MIPS/LM32 provide the semihosting feature. > > Do not enable it by default, and let the few targets requiring > it to manually select it. > > Signed-off-by:

Re: [PATCH v3 12/34] qapi: Add feature flags to remaining definitions

2020-03-16 Thread Eric Blake
On 3/15/20 9:46 AM, Markus Armbruster wrote: In v4.1.0, we added feature flags just to struct types (commit 6a8c0b5102^..f3ed93d545), to satisfy an immediate need (commit c9d4070991 "file-posix: Add dynamic-auto-read-only QAPI feature"). In v4.2.0, we added them to commands (commit 23394b4c39

[PATCH v3 07/25] hw/m68k: Use memory_region_init_rom() with read-only regions

2020-03-16 Thread Philippe Mathieu-Daudé
This commit was produced with the Coccinelle script scripts/coccinelle/memory-region-housekeeping.cocci. Signed-off-by: Philippe Mathieu-Daudé --- hw/m68k/q800.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c index c5699f6f3e..81749e7ec6

[PATCH v3 04/25] scripts/cocci: Patch to replace memory_region_init_{ram, readonly -> rom}

2020-03-16 Thread Philippe Mathieu-Daudé
Add a semantic patch to replace memory_region_init_ram(readonly) by memory_region_init_rom(). Signed-off-by: Philippe Mathieu-Daudé --- .../memory-region-housekeeping.cocci | 18 ++ 1 file changed, 18 insertions(+) diff --git

Re: [PATCH 06/11] accel/Kconfig: Extract accel selectors into their own config

2020-03-16 Thread Richard Henderson
On 3/16/20 5:00 AM, Philippe Mathieu-Daudé wrote: > Move the accel selectors from the global Kconfig.host to their > own Kconfig file. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Makefile | 1 + > Kconfig.host | 7 --- > accel/Kconfig | 6 ++ > 3 files changed, 7

Re: [PATCH v9] fixup! Fix subcode/pbt

2020-03-16 Thread Cornelia Huck
On Mon, 16 Mar 2020 16:04:00 +0100 Christian Borntraeger wrote: > On 16.03.20 15:54, Cornelia Huck wrote: > > On Mon, 16 Mar 2020 15:47:41 +0100 > > Janosch Frank wrote: > > > >> On 3/16/20 3:27 PM, Cornelia Huck wrote: > >>> On Fri, 13 Mar 2020 05:52:32 -0400 > >>> Janosch Frank wrote: >

Re: [PATCH 08/11] target/Kconfig: Allow targets to use Kconfig

2020-03-16 Thread Richard Henderson
On 3/16/20 5:00 AM, Philippe Mathieu-Daudé wrote: > diff --git a/target/Kconfig b/target/Kconfig > new file mode 100644 > index 00..8b13789179 > --- /dev/null > +++ b/target/Kconfig > @@ -0,0 +1 @@ > + Does this want a # This file intentionally left blank. ? Otherwise, Reviewed-by:

[PATCH v3 10/25] hw/ppc: Use memory_region_init_rom() with read-only regions

2020-03-16 Thread Philippe Mathieu-Daudé
This commit was produced with the Coccinelle script scripts/coccinelle/memory-region-housekeeping.cocci. Acked-by: David Gibson Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/mac_newworld.c | 3 +-- hw/ppc/mac_oldworld.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PULL 07/61] WHPX: TSC get and set should be dependent on VM state

2020-03-16 Thread Paolo Bonzini
From: Sunil Muthuswamy Currently, TSC is set as part of the VM runtime state. Setting TSC at runtime is heavy and additionally can have side effects on the guest, which are not very resilient to variances in the TSC. This patch uses the VM state to determine whether to set TSC or not. Some minor

[PULL 09/61] MAINTAINERS: Add entry for Guest X86 HAXM CPUs

2020-03-16 Thread Paolo Bonzini
From: Colin Xu HAXM covers below files: include/sysemu/hax.h target/i386/hax-* V2: Add HAXM github page for wiki and issue tracking. Cc: Wenchao Wang Cc: Hang Yuan Reviewed-by: Hang Yuan Signed-off-by: Colin Xu Message-Id: <20200228012046.6629-1-colin...@intel.com> Signed-off-by: Paolo

[PULL 19/61] ich9: Simplify ich9_lpc_initfn

2020-03-16 Thread Paolo Bonzini
From: Felipe Franciosi Currently, ich9_lpc_initfn simply serves as a caller to ich9_lpc_add_properties. This simplifies the code a bit by eliminating ich9_lpc_add_properties altogether and executing its logic in the parent object initialiser function. Signed-off-by: Felipe Franciosi

[PULL 39/61] scripts/cocci: Rename memory-region-{init-ram -> housekeeping}

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé As we are going to add various semantic changes related to the memory region API, rename this script to be more generic. Add a 'usage' header, and an entry in MAINTAINERS to avoid checkpatch warning. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS

[PULL 32/61] Use -isystem for linux-headers dir

2020-03-16 Thread Paolo Bonzini
From: Eduardo Habkost glibc and Linux-provided headers are known to generate macro redefinition warnings when used together. For example: and duplicate some macro definitions. We normally never see those warnings because GCC suppresses warnings generated by system headers. We carry our own

[PULL 44/61] hw/net: Use memory_region_init_rom() with read-only regions

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé This commit was produced with the Coccinelle script scripts/coccinelle/memory-region-housekeeping.cocci. Signed-off-by: Philippe Mathieu-Daudé --- hw/net/dp8393x.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/net/dp8393x.c

[PULL 51/61] scripts/cocci: Patch to remove unnecessary memory_region_set_readonly()

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Add a semantic patch to remove memory_region_set_readonly() calls on ROM memory regions. Signed-off-by: Philippe Mathieu-Daudé --- scripts/coccinelle/memory-region-housekeeping.cocci | 15 +++ 1 file changed, 15 insertions(+) diff --git

[PULL 41/61] hw/arm: Use memory_region_init_rom() with read-only regions

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé This commit was produced with the Coccinelle script scripts/coccinelle/memory-region-housekeeping.cocci. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4210.c | 3 +-- hw/arm/mainstone.c | 3 +-- hw/arm/omap_sx1.c | 6 ++ hw/arm/palm.c | 3 +--

[PULL 60/61] hw/arm: Remove unnecessary memory_region_set_readonly() on ROM alias

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé This commit was produced with the Coccinelle script scripts/coccinelle/memory-region-housekeeping.cocci. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4210.c| 1 - hw/arm/stm32f205_soc.c | 1 - hw/arm/stm32f405_soc.c | 1 - 3 files changed, 3

Re: [PATCH v2 3/8] ppc/spapr: Add FWNMI System Reset state

2020-03-16 Thread David Gibson
On Tue, Mar 17, 2020 at 12:26:08AM +1000, Nicholas Piggin wrote: > The FWNMI option must deliver system reset interrupts to their > registered address, and there are a few constraints on the handler > addresses specified in PAPR. Add the system reset address state and > checks. > > Signed-off-by:

Re: [PATCH v3 00/19] Support disabling TCG on ARM (part 2)

2020-03-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200316160634.3386-1-phi...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v2 7/8] ppc/spapr: Implement FWNMI System Reset delivery

2020-03-16 Thread David Gibson
On Tue, Mar 17, 2020 at 12:26:12AM +1000, Nicholas Piggin wrote: > PAPR requires that if "ibm,nmi-register" succeeds, then the hypervisor > delivers all system reset and machine check exceptions to the registered > addresses. > > System Resets are delivered with registers set to the architected

Re: [PATCH v2 7/8] ppc/spapr: Implement FWNMI System Reset delivery

2020-03-16 Thread David Gibson
On Mon, Mar 16, 2020 at 06:52:54PM +0100, Greg Kurz wrote: > On Mon, 16 Mar 2020 23:05:00 +0530 > Mahesh J Salgaonkar wrote: > > > On 2020-03-17 00:26:12 Tue, Nicholas Piggin wrote: > > > PAPR requires that if "ibm,nmi-register" succeeds, then the hypervisor > > > delivers all system reset and

Re: [PATCH v2 4/8] ppc/spapr: Fix FWNMI machine check interrupt delivery

2020-03-16 Thread David Gibson
On Tue, Mar 17, 2020 at 09:19:57AM +1000, Nicholas Piggin wrote: > Cédric Le Goater's on March 17, 2020 3:59 am: > > On 3/16/20 3:26 PM, Nicholas Piggin wrote: > >> FWNMI machine check delivery misses a few things that will make it fail > >> with TCG at least (which we would like to allow in

[PULL 27/61] hw/usb/quirks: Use smaller types to reduce .rodata by 10KiB

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé The USB descriptor sizes are specified as 16-bit for idVendor / idProduct, and 8-bit for bInterfaceClass / bInterfaceSubClass / bInterfaceProtocol. Doing so we reduce the usbredir_raw_serial_ids[] and usbredir_ftdi_serial_ids[] arrays from 16KiB to 6KiB (size

[PULL 17/61] qom/object: enable setter for uint types

2020-03-16 Thread Paolo Bonzini
From: Felipe Franciosi Traditionally, the uint-specific property helpers only offer getters. When adding object (or class) uint types, one must therefore use the generic property helper if a setter is needed (and probably duplicate some code writing their own getters/setters). This enhances the

[PULL 42/61] hw/display: Use memory_region_init_rom() with read-only regions

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé This commit was produced with the Coccinelle script scripts/coccinelle/memory-region-housekeeping.cocci. Signed-off-by: Philippe Mathieu-Daudé --- hw/display/cg3.c | 5 ++--- hw/display/tcx.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git

Re: [PATCH] linux-user: Update TASK_UNMAPPED_BASE for aarch64

2020-03-16 Thread Lirong Yuan
Thanks Laurent for the prompt responses! Yes that is exactly where the value is taken from. For anyone interested in detailed information of the change, here is the previous discussion thread: http://patchwork.ozlabs.org/patch/1242370/ Regards, Lirong On Sat, Mar 14, 2020 at 10:34 AM Laurent

[PULL 50/61] scripts/cocci: Patch to detect potential use of memory_region_init_rom

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Add a semantic patch to detect potential replacement of memory_region_init_ram(readonly) by memory_region_init_rom(). Signed-off-by: Philippe Mathieu-Daudé --- scripts/coccinelle/memory-region-housekeeping.cocci | 19 +++ 1 file changed, 19

[PULL 40/61] scripts/cocci: Patch to replace memory_region_init_{ram, readonly -> rom}

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Add a semantic patch to replace memory_region_init_ram(readonly) by memory_region_init_rom(). Signed-off-by: Philippe Mathieu-Daudé --- scripts/coccinelle/memory-region-housekeeping.cocci | 18 ++ 1 file changed, 18 insertions(+) diff --git

[PULL 59/61] hw/ppc/ppc405: Use memory_region_init_rom() with read-only regions

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé The scripts/coccinelle/memory-region-housekeeping.cocci reported: * TODO [[view:./hw/ppc/ppc405_boards.c::face=ovl-face1::linb=195::colb=8::cole=30][potential use of memory_region_init_rom*() in ./hw/ppc/ppc405_boards.c::195]] * TODO

[PULL 03/61] misc: Replace zero-length arrays with flexible array member (automatic)

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Description copied from Linux kernel commit from Gustavo A. R. Silva (see [3]): --v-- description start --v-- The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare

[PULL 14/61] configure: Fix building with SASL on Windows

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé The Simple Authentication and Security Layer (SASL) library re-defines the struct iovec on Win32 [*]. QEMU also re-defines it in "qemu/osdep.h". The two definitions then clash on a MinGW build. We can avoid the SASL definition by defining STRUCT_IOVEC_DEFINED. Since

[PULL 12/61] build-sys: do not make qemu-ga link with pixman

2020-03-16 Thread Paolo Bonzini
From: Marc-André Lureau Since commit d52c454aadcdae74506f315ebf8b58bb79a05573 ("contrib: add vhost-user-gpu"), qemu-ga is linking with pixman. This is because the Make-based build-system use a global namespace for variables, and we rely on "main.o-libs" for different linking targets. Note:

[PULL 35/61] lockable: add lock guards

2020-03-16 Thread Paolo Bonzini
From: Stefan Hajnoczi This patch introduces two lock guard macros that automatically unlock a lock object (QemuMutex and others): void f(void) { QEMU_LOCK_GUARD(); if (!may_fail()) { return; /* automatically unlocks mutex */ } ... } and:

[PULL 49/61] hw/sparc: Use memory_region_init_rom() with read-only regions

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé This commit was produced with the Coccinelle script scripts/coccinelle/memory-region-housekeeping.cocci. Reviewed-by: KONRAD Frederic Signed-off-by: Philippe Mathieu-Daudé --- hw/sparc/leon3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PULL 29/61] ui/curses: Move arrays to .heap to save 74KiB of .bss

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé We only need these arrays when using the curses display. Move them from the .bss to the .heap (sizes reported on x86_64 host: screen[] is 64KiB, vga_to_curses 7KiB). Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- ui/curses.c | 8 ++--

[PULL 61/61] hw/arm: Let devices own the MemoryRegion they create

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Avoid orphan memory regions being added in the /unattached QOM container. This commit was produced with the Coccinelle script scripts/coccinelle/memory-region-housekeeping.cocci. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4210.c| 12 ++--

Re: [PATCH v2 4/8] ppc/spapr: Fix FWNMI machine check interrupt delivery

2020-03-16 Thread Nicholas Piggin
Cédric Le Goater's on March 17, 2020 3:59 am: > On 3/16/20 3:26 PM, Nicholas Piggin wrote: >> FWNMI machine check delivery misses a few things that will make it fail >> with TCG at least (which we would like to allow in future to improve >> testing). > > I don't understand which issues are

[PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

2020-03-16 Thread Alexey Kardashevskiy
The following changes since commit 33dead675695e596b7f32c72e6f6a20390e86d8a: pseries: Update SLOF firmware image (2020-03-13 17:50:44 +1100) are available in the Git repository at: g...@github.com:aik/qemu.git tags/qemu-slof-20200317 for you to fetch changes up to

Re: [PATCH v2] MAINTAINERS: Mark the LatticeMico32 target as orphan

2020-03-16 Thread Richard Henderson
On 3/16/20 7:28 AM, Philippe Mathieu-Daudé wrote: > Michael Walle expressed his desire to orphan the lm32 target [*]: > > I guess it is time to pull the plug. Mainly, because I have > no time for this anymore. I've always worked on this on my > spare time and life changed. And secondly, I

Re: [PULL 00/61] Misc patches for soft freeze

2020-03-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1584394048-44994-1-git-send-email-pbonz...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[PATCH v8 09/11] iotest 258: use script_main

2020-03-16 Thread John Snow
Since this one is nicely factored to use a single entry point, use script_main to run the tests. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Max Reitz --- tests/qemu-iotests/258 | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

[PATCH v8 01/11] iotests: do a light delinting

2020-03-16 Thread John Snow
This doesn't fix everything in here, but it does help clean up the pylint report considerably. This should be 100% style changes only; the intent is to make pylint more useful by working on establishing a baseline for iotests that we can gate against in the future. Signed-off-by: John Snow

[PATCH v8 03/11] iotests: ignore import warnings from pylint

2020-03-16 Thread John Snow
The right way to solve this is to come up with a virtual environment infrastructure that sets all the paths correctly, and/or to create installable python modules that can be imported normally. That's hard, so just silence this error for now. Signed-off-by: John Snow ---

[PATCH v8 04/11] iotests: replace mutable list default args

2020-03-16 Thread John Snow
It's bad hygiene: if we modify this list, it will be modified across all invocations. (Remaining bad usages are fixed in a subsequent patch which changes the function signature anyway.) Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé --- tests/qemu-iotests/iotests.py | 24

[PATCH v8 00/11] iotests: use python logging

2020-03-16 Thread John Snow
This series uses python logging to enable output conditionally on iotests.log(). We unify an initialization call (which also enables debugging output for those tests with -d) and then make the switch inside of iotests. It will help alleviate the need to create logged/unlogged versions of all the

[PATCH v8 02/11] iotests: don't use 'format' for drive_add

2020-03-16 Thread John Snow
It shadows (with a different type) the built-in format. Use something else. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Max Reitz --- tests/qemu-iotests/055| 3 ++- tests/qemu-iotests/iotests.py | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-)

[PATCH v8 11/11] iotests: use python logging for iotests.log()

2020-03-16 Thread John Snow
We can turn logging on/off globally instead of per-function. Remove use_log from run_job, and use python logging to turn on diffable output when we run through a script entry point. iotest 245 changes output order due to buffering reasons. An extended note on python logging: A NullHandler is

[PATCH v8 10/11] iotests: Mark verify functions as private

2020-03-16 Thread John Snow
Mark the verify functions as "private" with a leading underscore, to discourage their use. (Also, make pending patches not yet using the new entry points fail in a very obvious way.) Signed-off-by: John Snow Reviewed-by: Max Reitz --- tests/qemu-iotests/iotests.py | 20 ++-- 1

[PATCH v8 05/11] iotests: add pylintrc file

2020-03-16 Thread John Snow
This allows others to get repeatable results with pylint. If you run `pylint iotests.py`, you should see a 100% pass. Signed-off-by: John Snow --- tests/qemu-iotests/pylintrc | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 tests/qemu-iotests/pylintrc diff

[PATCH v8 06/11] iotests: drop Python 3.4 compatibility code

2020-03-16 Thread John Snow
We no longer need to accommodate 3.4, drop this code. (Also, the line is over 79 characters, so drop it.) Touch up the docstring a little bit while we're here. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff

[PATCH v8 08/11] iotests: add script_initialize

2020-03-16 Thread John Snow
Like script_main, but doesn't require a single point of entry. Replace all existing initialization sections with this drop-in replacement. This brings debug support to all existing script-style iotests. Signed-off-by: John Snow Reviewed-by: Max Reitz --- tests/qemu-iotests/149| 3 +-

[PATCH v8 07/11] iotests: limit line length to 79 chars

2020-03-16 Thread John Snow
79 is the PEP8 recommendation. This recommendation works well for reading patch diffs in TUI email clients. Signed-off-by: John Snow --- tests/qemu-iotests/iotests.py | 64 +++ tests/qemu-iotests/pylintrc | 6 +++- 2 files changed, 47 insertions(+), 23

Re: [PATCH v2 6/8] target/ppc: allow ppc_cpu_do_system_reset to take an alternate vector

2020-03-16 Thread David Gibson
On Tue, Mar 17, 2020 at 09:28:24AM +1000, Nicholas Piggin wrote: > Cédric Le Goater's on March 17, 2020 4:15 am: > > On 3/16/20 3:26 PM, Nicholas Piggin wrote: > >> Provide for an alternate delivery location, -1 defaults to the > >> architected address. > > > > I don't know what is the best

Re: [PULL 00/38] Linux user for 5.0 patches

2020-03-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200316161550.336150-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/38] Linux user for 5.0 patches Message-id: 20200316161550.336150-1-laur...@vivier.eu Type: series

Re: [PULL SUBSYSTEM qemu-pseries] pseries: Update SLOF firmware image

2020-03-16 Thread David Gibson
On Tue, Mar 17, 2020 at 10:33:06AM +1100, Alexey Kardashevskiy wrote: > The following changes since commit 33dead675695e596b7f32c72e6f6a20390e86d8a: > > pseries: Update SLOF firmware image (2020-03-13 17:50:44 +1100) > > are available in the Git repository at: > >

[PULL 18/61] ich9: fix getter type for sci_int property

2020-03-16 Thread Paolo Bonzini
From: Felipe Franciosi When QOM APIs were added to ich9 in 6f1426ab, the getter for sci_int was written using uint32_t. However, the object property is uint8_t. This fixes the getter for correctness. Signed-off-by: Felipe Franciosi Reviewed-by: Marc-André Lureau Signed-off-by: Paolo Bonzini

[PULL 25/61] hw/audio/fmopl: Move ENV_CURVE to .heap to save 32KiB of .bss

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé This buffer is only used by the adlib audio device. Move it to the .heap to release 32KiB of .bss (size reported on x86_64 host). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefano Garzarella Signed-off-by: Paolo Bonzini --- hw/audio/fmopl.c | 4 +++- 1

[PULL 23/61] Makefile: Align 'help' target output

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé The 'help' target is displayed unaligned. Add a print-help function and use it. Now if someone want to change the indentation, there is a single place to modify. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini --- Makefile | 44

[PULL 34/61] cpus: avoid pause_all_vcpus getting stuck due to race

2020-03-16 Thread Paolo Bonzini
From: Longpeng We found an issue when repeat reboot in guest during migration, it cause the migration thread never be waken up again. | | LOCK BQL | ...| main_loop_should_exit

[PULL 36/61] lockable: add QemuRecMutex support

2020-03-16 Thread Paolo Bonzini
From: Stefan Hajnoczi The polymorphic locking macros don't support QemuRecMutex yet. Add it so that lock guards can be used with QemuRecMutex. Convert TCG plugins functions that benefit from these macros. Manual qemu_rec_mutex_lock/unlock() callers are left unmodified in cases where clarity

Re: [PULL 00/38] Linux user for 5.0 patches

2020-03-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200316161550.336150-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/38] Linux user for 5.0 patches Message-id: 20200316161550.336150-1-laur...@vivier.eu Type: series

[PULL 46/61] hw/ppc: Use memory_region_init_rom() with read-only regions

2020-03-16 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé This commit was produced with the Coccinelle script scripts/coccinelle/memory-region-housekeeping.cocci. Acked-by: David Gibson Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/mac_newworld.c | 3 +-- hw/ppc/mac_oldworld.c | 3 +-- 2 files changed, 2

Re: [PATCH v2 5/8] ppc/spapr: Allow FWNMI on TCG

2020-03-16 Thread Nicholas Piggin
Greg Kurz's on March 17, 2020 4:01 am: > On Tue, 17 Mar 2020 00:26:10 +1000 > Nicholas Piggin wrote: > >> There should no longer be a reason to prevent TCG providing FWNMI. >> System Reset interrupts are generated to the guest with nmi monitor >> command and H_SIGNAL_SYS_RESET. Machine Checks

Re: [PULL 00/38] Linux user for 5.0 patches

2020-03-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200316161550.336150-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/38] Linux user for 5.0 patches Message-id: 20200316161550.336150-1-laur...@vivier.eu Type: series

[Bug 1866892] Re: guest OS catches a page fault bug when running dotnet

2020-03-16 Thread Robert Henry
A simpler case seems to produce the same error. See https://bugs.launchpad.net/qemu/+bug/1824344 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1866892 Title: guest OS catches a page fault bug

[Bug 1824344] Re: x86: retf or iret pagefault sets wrong error code

2020-03-16 Thread Robert Henry
This appears to be similar to https://bugs.launchpad.net/qemu/+bug/1866892 (and much simpler) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1824344 Title: x86: retf or iret pagefault sets wrong

[PULL 02/10] hbitmap: move hbitmap_iter_next_word to hbitmap.c

2020-03-16 Thread John Snow
From: Vladimir Sementsov-Ogievskiy The function is definitely internal (it's not used by third party and it has complicated interface). Move it to .c file. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow Message-id:

[PULL 00/10] Bitmaps patches

2020-03-16 Thread John Snow
The following changes since commit 6e8a73e911f066527e775e04b98f31ebd19db600: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2020-03-11 14:41:27 +) are available in the Git repository at: https://github.com/jnsnow/qemu.git tags/bitmaps-pull-request

[PULL 08/10] nbd/server: introduce NBDExtentArray

2020-03-16 Thread John Snow
From: Vladimir Sementsov-Ogievskiy Introduce NBDExtentArray class, to handle extents list creation in more controlled way and with fewer OUT parameters in functions. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Message-id: 20200205112041.6003-9-vsement...@virtuozzo.com

[PATCH v3 2/3] iotests: add JobRunner class

2020-03-16 Thread John Snow
The idea is that instead of increasing the arguments to job_run all the time, create a more general-purpose job runner that can be subclassed to do interesting things with. pylint note: the 'callbacks' option guards against unused warning arguments in functions designated as callbacks. It does

[PATCH v3 3/3] iotests: modify test 040 to use JobRunner

2020-03-16 Thread John Snow
Instead of having somewhat reproduced it for itself. Signed-off-by: John Snow --- tests/qemu-iotests/040 | 51 +- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040 index 90b59081ff..e2ef3bb812

Re: [PATCH 0/5] QEMU Gating CI

2020-03-16 Thread Cleber Rosa
- Original Message - > From: "Peter Maydell" > To: "Cleber Rosa" > Cc: "Fam Zheng" , "Thomas Huth" , "Beraldo > Leal" , "Erik > Skultety" , "Alex Bennée" , > "Wainer Moschetta" , > "QEMU Developers" , "Wainer dos Santos Moschetta" > , "Willian Rampazzo" > , "Philippe Mathieu-Daudé"

Re: [PATCH v3 30/34] qapi: Implement deprecated-output=hide for QMP event data

2020-03-16 Thread Markus Armbruster
Markus Armbruster writes: > This policy suppresses deprecated bits in output, and thus permits > "testing the future". Implement it for QMP event data: suppress > deprecated members. > > No QMP event data is deprecated right now. > > Signed-off-by: Markus Armbruster Needs a fixup: diff --git

Re: [PATCH v3 05/34] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers

2020-03-16 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Sun, Mar 15, 2020 at 3:48 PM Markus Armbruster wrote: >> >> Checking the value of qmp_dispatch() is repetitive. Factor out >> helpers do_qmp_dispatch() and do_qmp_dispatch_error(). Without this, >> the next commit would make things even more repetitive.

Re: [PATCH v4 6/6] virtio-net: add migration support for RSS and hash report

2020-03-16 Thread Yuri Benditovich
On Tue, Mar 17, 2020 at 1:05 AM Michael S. Tsirkin wrote: > On Mon, Mar 16, 2020 at 12:09:33PM +0200, Yuri Benditovich wrote: > > Save and restore RSS/hash report configuration. > > > > Signed-off-by: Yuri Benditovich > > --- > > hw/net/virtio-net.c | 26 ++ > > 1 file

[PATCH v2 4/8] ppc/spapr: Fix FWNMI machine check interrupt delivery

2020-03-16 Thread Nicholas Piggin
FWNMI machine check delivery misses a few things that will make it fail with TCG at least (which we would like to allow in future to improve testing). It's not nice to scatter interrupt delivery logic around the tree, so move it to excp_helper.c and share code where possible. Signed-off-by:

Re: [PATCH v9] fixup! Fix subcode/pbt

2020-03-16 Thread Cornelia Huck
On Mon, 16 Mar 2020 15:47:41 +0100 Janosch Frank wrote: > On 3/16/20 3:27 PM, Cornelia Huck wrote: > > On Fri, 13 Mar 2020 05:52:32 -0400 > > Janosch Frank wrote: > > > >> Signed-off-by: Janosch Frank > >> --- > >> hw/s390x/ipl.h | 11 +++ > >> target/s390x/diag.c | 2 +- > >>

[PATCH v2 5/8] ppc/spapr: Allow FWNMI on TCG

2020-03-16 Thread Nicholas Piggin
There should no longer be a reason to prevent TCG providing FWNMI. System Reset interrupts are generated to the guest with nmi monitor command and H_SIGNAL_SYS_RESET. Machine Checks can not be injected currently, but this could be implemented with the mce monitor cmd similarly to i386.

Re: [PATCH v9] fixup! Fix subcode/pbt

2020-03-16 Thread Janosch Frank
On 3/16/20 3:54 PM, Cornelia Huck wrote: > On Mon, 16 Mar 2020 15:47:41 +0100 > Janosch Frank wrote: > >> On 3/16/20 3:27 PM, Cornelia Huck wrote: >>> On Fri, 13 Mar 2020 05:52:32 -0400 >>> Janosch Frank wrote: >>> Signed-off-by: Janosch Frank --- hw/s390x/ipl.h | 11

Re: [PATCH v6 3/4] qcow2: add zstd cluster compression

2020-03-16 Thread Eric Blake
On 3/12/20 4:22 AM, Denis Plotnikov wrote: zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. +++

[PATCH v6 16/42] nvme: make sure ncqr and nsqr is valid

2020-03-16 Thread Klaus Jensen
From: Klaus Jensen 0x is not an allowed value for NCQR and NSQR in Set Features on Number of Queues. Signed-off-by: Klaus Jensen Acked-by: Keith Busch Reviewed-by: Maxim Levitsky --- hw/block/nvme.c | 8 1 file changed, 8 insertions(+) diff --git a/hw/block/nvme.c

[PATCH v6 20/42] nvme: provide the mandatory subnqn field

2020-03-16 Thread Klaus Jensen
From: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index b40d27cddc46..74061d08fd2e 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -1925,6 +1925,9 @@ static void

[PATCH v6 10/42] nvme: refactor device realization

2020-03-16 Thread Klaus Jensen
From: Klaus Jensen This patch splits up nvme_realize into multiple individual functions, each initializing a different subset of the device. Signed-off-by: Klaus Jensen Acked-by: Keith Busch --- hw/block/nvme.c | 178 ++-- hw/block/nvme.h | 23

<    1   2   3   4   5   6   7   >