Re: [RFC PATCH v1 20/26] kvm: vmi: intercept live migration

* Adalbert Lazăr (ala...@bitdefender.com) wrote: > On Tue, 28 Apr 2020 13:24:39 +0100, "Dr. David Alan Gilbert" > wrote: > > * Adalbert Lazăr (ala...@bitdefender.com) wrote: > > > On Mon, 27 Apr 2020 20:08:55 +0100, "Dr. David Alan Gilbert" > > > wrote: > > > > * Adalbert Lazăr

Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

Patchew URL: https://patchew.org/QEMU/20200428132629.796753-1-mre...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH 4/4] block: Use blk_make_empty() after commits

Am 28.04.2020 um 15:26 hat Max Reitz geschrieben: > bdrv_commit() already has a BlockBackend pointing to the BDS that we > want to empty, it just has the wrong permissions. > > qemu-img commit has no BlockBackend pointing to the old backing file > yet, but introducing one is simple. > > After

Re: [PATCH v3 13/18] target/arm: Update contiguous first-fault and no-fault loads

On 4/27/20 11:38 AM, Peter Maydell wrote: > I would suggest something like: > > + * From this point on, all memory operations are MemSingleNF. > + * > + * Per the MemSingleNF pseudocode, a no-fault load from Device memory > + * must not actually hit the bus -- it returns (UNKNOWN,

Re: backing chain & block status & filters

28.04.2020 14:28, Kevin Wolf wrote: Am 28.04.2020 um 13:08 hat Max Reitz geschrieben: On 28.04.20 10:55, Vladimir Sementsov-Ogievskiy wrote: Hi! I wanted to resend my "[PATCH 0/4] fix & merge block_status_above and is_allocated_above", and returned to all the inconsistencies about

RE: [PATCH 1/2] Fix undefined behaviour

> -Original Message- > From: Artur Puzio > Sent: 28 April 2020 10:41 > To: p...@xen.org; 'Grzegorz Uriasz' ; > qemu-devel@nongnu.org > Cc: marma...@invisiblethingslab.com; ja...@bartmin.ski; > j.nowa...@student.uw.edu.pl; 'Stefano > Stabellini' ; 'Anthony Perard' > ; xen- >

Re: [PATCH v3 1/3] block: Add blk_new_with_bs() helper

On 4/28/20 1:34 AM, Max Reitz wrote: block_crypto_co_create_generic(BlockDriverState *bs,     PreallocMode prealloc,     Error **errp)   { -    int ret; +    int ret = -EPERM; I’m not sure I’m a fan of this,

Re: [PATCH 4/4] block: Use blk_make_empty() after commits

On 4/28/20 8:26 AM, Max Reitz wrote: bdrv_commit() already has a BlockBackend pointing to the BDS that we want to empty, it just has the wrong permissions. qemu-img commit has no BlockBackend pointing to the old backing file yet, but introducing one is simple. After this commit,

Re: [PATCH 3/4] block: Add blk_make_empty()

On 4/28/20 8:26 AM, Max Reitz wrote: Two callers of BlockDriver.bdrv_make_empty() remain that should not call this method directly. Both do not have access to a BdrvChild, but they can use a BlockBackend, so we add this function that lets them use it. Signed-off-by: Max Reitz ---

[PATCH RFC v2] target/arm: Implement SVE2 TBL, TBX

Signed-off-by: Stephen Long --- target/arm/helper-sve.h| 10 ++ target/arm/internals.h | 12 +++ target/arm/sve.decode | 5 +++ target/arm/sve_helper.c| 71 ++ target/arm/translate-sve.c | 20 +++ 5 files changed, 112

Re: [PATCH 3/4] block: Add blk_make_empty()

Am 28.04.2020 um 15:26 hat Max Reitz geschrieben: > Two callers of BlockDriver.bdrv_make_empty() remain that should not call > this method directly. Both do not have access to a BdrvChild, but they > can use a BlockBackend, so we add this function that lets them use it. > > Signed-off-by: Max

[PATCH v2] target/arm: Use correct variable for setting 'max' cpu's MIDR_EL1

MIDR_EL1 a 64-bit system register with the top 32-bit being RES0. This fixes when compiling with -Werror=conversion: target/arm/cpu64.c: In function ‘aarch64_max_initfn’: target/arm/cpu64.c:628:21: error: conversion from ‘uint64_t’ {aka ‘long unsigned int’} to ‘uint32_t’ {aka ‘unsigned

Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

On 4/28/20 8:26 AM, Max Reitz wrote: Branch: https://github.com/XanClic/qemu.git fix-bdrv_make_empty-v1 Branch: https://git.xanclic.moe/XanClic/qemu.git fix-bdrv_make_empty-v1 Hi, Right now, there is no centralized bdrv_make_empty() function. Not only is it bad style to call BlockDriver

Re: [PATCH v2] target/arm: Use correct variable for setting 'max' cpu's MIDR_EL1

On Tue, 28 Apr 2020 at 16:50, Philippe Mathieu-Daudé wrote: Looks like you forgot to edit the commit message subject line. > MIDR_EL1 a 64-bit system register with the top 32-bit being RES0. > > This fixes when compiling with -Werror=conversion: > > target/arm/cpu64.c: In function

Re: [PATCH v10 00/14] iotests: use python logging

Am 28.04.2020 um 13:46 hat Max Reitz geschrieben: > On 31.03.20 02:00, John Snow wrote: > > This series uses python logging to enable output conditionally on > > iotests.log(). We unify an initialization call (which also enables > > debugging output for those tests with -d) and then make the

Re: [PATCH v20 4/4] iotests: 287: add qcow2 compression type test

On 4/28/20 7:55 AM, Max Reitz wrote: +# This tests qocw2-specific low-level functionality +_supported_fmt qcow2 +_supported_proto file +_supported_os Linux This test doesn’t work with compat=0.10 (because we can’t store a non-default compression type there) or data_file (because those don’t

Re: [RFC PATCH v1 20/26] kvm: vmi: intercept live migration

On Tue, 28 Apr 2020 13:24:39 +0100, "Dr. David Alan Gilbert" wrote: > * Adalbert Lazăr (ala...@bitdefender.com) wrote: > > On Mon, 27 Apr 2020 20:08:55 +0100, "Dr. David Alan Gilbert" > > wrote: > > > * Adalbert Lazăr (ala...@bitdefender.com) wrote: > > > > From: Marian Rotariu > > > > > > >

Re: [PATCH v2 02/14] qcrypto/luks: implement encryption key management

On Sun, Mar 08, 2020 at 05:18:51PM +0200, Maxim Levitsky wrote: > Next few patches will expose that functionality > to the user. > > Signed-off-by: Maxim Levitsky > --- > crypto/block-luks.c | 398 +++- > qapi/crypto.json| 61 ++- > 2 files

[PATCH v21 0/4] implement zstd cluster compression method

v21: 03: * remove the loop on compression [Max] * use designated initializers [Max] 04: * don't erase user's options [Max] * use _rm_test_img [Max] * add unsupported qcow2 options [Max] v20: 04: fix a number of flaws [Vladimir] * don't use

[PATCH v21 2/4] qcow2: rework the cluster compression routine

The patch enables processing the image compression type defined for the image and chooses an appropriate method for image clusters (de)compression. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz ---

[PATCH v21 4/4] iotests: 287: add qcow2 compression type test

The test checks fulfilling qcow2 requirements for the compression type feature and zstd compression type operability. Signed-off-by: Denis Plotnikov Reviewed-by: Vladimir Sementsov-Ogievskiy Tested-by: Vladimir Sementsov-Ogievskiy --- slirp | 2 +-

Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

On 4/28/20 8:49 AM, Eric Blake wrote: On 4/28/20 8:26 AM, Max Reitz wrote: Branch: https://github.com/XanClic/qemu.git fix-bdrv_make_empty-v1 Branch: https://git.xanclic.moe/XanClic/qemu.git fix-bdrv_make_empty-v1 Hi, Right now, there is no centralized bdrv_make_empty() function.  Not only is

Re: [PATCH v2] char-socket: initialize reconnect timer only when the timer doesn't start

Apply the above patch, then `make check-unit` or `tests/test-char -p /char/socket/client/reconnect-error/unix` Marc-André Lureau 于2020年4月28日周二 下午7:06写道： > > Hi > > On Tue, Apr 28, 2020 at 10:59 AM Li Feng wrote: > > > > Sorry for sending the weird same mail out. > > Ignore the second one. > > >

Re: [PATCH 1/4] block: Add bdrv_make_empty()

On 4/28/20 9:01 AM, Kevin Wolf wrote: Can we please fix this to take a flags parameter? I want to make it easier for callers to request BDRV_REQ_NO_FALLBACK for distinguishing between callers where the image must be made empty (read as all zeroes) regardless of time spent, vs. made empty

Re: [PATCH 1/4] block: Add bdrv_make_empty()

Am 28.04.2020 um 15:26 hat Max Reitz geschrieben: > Right now, all users of bdrv_make_empty() call the BlockDriver method > directly. That is not only bad style, it is also wrong, unless the > caller has a BdrvChild with a WRITE permission. > > Introduce bdrv_make_empty() that verifies that it

Re: [RFC PATCH v1 20/26] kvm: vmi: intercept live migration

On Tue, 28 Apr 2020 14:43:20 +0100, "Dr. David Alan Gilbert" wrote: > * Adalbert Lazăr (ala...@bitdefender.com) wrote: > > One use case is to do VM introspection all the time the guest is running. > > From the user perspective, the pause/suspend/shutdown/snapshot/migrate > > commands should work

Re: [PATCH v21 0/4] implement zstd cluster compression method

Patchew URL: https://patchew.org/QEMU/20200428133407.10657-1-dplotni...@virtuozzo.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v21 0/4] implement zstd cluster compression method Message-id:

Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

Patchew URL: https://patchew.org/QEMU/20200428132629.796753-1-mre...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH] virtiofsd: Show submounts

On Tue, Apr 28, 2020 at 03:51:43PM +0100, Stefan Hajnoczi wrote: > On Mon, Apr 27, 2020 at 06:59:02PM +0100, Dr. David Alan Gilbert wrote: > > * Max Reitz (mre...@redhat.com) wrote: > > > Currently, setup_mounts() bind-mounts the shared directory without > > > MS_REC. This makes all submounts

Re: [PATCH v21 0/4] implement zstd cluster compression method

Patchew URL: https://patchew.org/QEMU/20200428133407.10657-1-dplotni...@virtuozzo.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v21 0/4] implement zstd cluster compression method Message-id:

Re: [PATCH 4/5] ramfb: add sanity checks to ramfb_create_display_surface

On 04/27/20 13:11, Gerd Hoffmann wrote: >>> -size = (hwaddr)linesize * height; >>> -data = cpu_physical_memory_map(addr, , false); >>> -if (size != (hwaddr)linesize * height) { >>> -cpu_physical_memory_unmap(data, size, 0, 0); >>> +mapsize = size = stride * (height - 1) +

[PATCH 3/4] block: Add blk_make_empty()

Two callers of BlockDriver.bdrv_make_empty() remain that should not call this method directly. Both do not have access to a BdrvChild, but they can use a BlockBackend, so we add this function that lets them use it. Signed-off-by: Max Reitz --- include/sysemu/block-backend.h | 2 ++

[PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

Branch: https://github.com/XanClic/qemu.git fix-bdrv_make_empty-v1 Branch: https://git.xanclic.moe/XanClic/qemu.git fix-bdrv_make_empty-v1 Hi, Right now, there is no centralized bdrv_make_empty() function. Not only is it bad style to call BlockDriver methods directly, it is also wrong, unless

Re: [PATCH 1/4] block: Add bdrv_make_empty()

Am 28.04.2020 um 16:07 hat Eric Blake geschrieben: > On 4/28/20 9:01 AM, Kevin Wolf wrote: > > > > Can we please fix this to take a flags parameter? I want to make it > > > easier > > > for callers to request BDRV_REQ_NO_FALLBACK for distinguishing between > > > callers where the image must be

Re: [PATCH 3/4] block: Add blk_make_empty()

On 4/28/20 8:55 AM, Eric Blake wrote: +++ b/include/sysemu/block-backend.h @@ -266,4 +266,6 @@ int coroutine_fn blk_co_copy_range(BlockBackend *blk_in, int64_t off_in,   const BdrvChild *blk_root(BlockBackend *blk); +int blk_make_empty(BlockBackend *blk, Error **errp); + Again, a flag

Re: [PATCH] virtiofsd: Show submounts

On Mon, Apr 27, 2020 at 06:59:02PM +0100, Dr. David Alan Gilbert wrote: > * Max Reitz (mre...@redhat.com) wrote: > > Currently, setup_mounts() bind-mounts the shared directory without > > MS_REC. This makes all submounts disappear. > > > > Pass MS_REC so that the guest can see submounts again. >

Re: [PATCH v2] migration/xbzrle: add encoding rate

* Wei Wang (wei.w.w...@intel.com) wrote: > Users may need to check the xbzrle encoding rate to know if the guest > memory is xbzrle encoding-friendly, and dynamically turn off the > encoding if the encoding rate is low. > > Signed-off-by: Yi Sun > Signed-off-by: Wei Wang > --- >

Re: backing chain & block status & filters

28.04.2020 14:08, Max Reitz wrote: On 28.04.20 10:55, Vladimir Sementsov-Ogievskiy wrote: Hi! I wanted to resend my "[PATCH 0/4] fix & merge block_status_above and is_allocated_above", and returned to all the inconsistencies about block-status. I keep in mind Max's series about child-access

Re: [PATCH v2 04/14] block/amend: separate amend and create options for qemu-img

On Sun, Mar 08, 2020 at 05:18:53PM +0200, Maxim Levitsky wrote: > Some options are only useful for creation > (or hard to be amended, like cluster size for qcow2), while some other > options are only useful for amend, like upcoming keyslot management > options for luks > > Since currently only

Re: [PATCH 2/4] block: Use bdrv_make_empty() where possible

Am 28.04.2020 um 15:26 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf

Re: [PATCH 3/3] virtio-net: remove VIRTIO_NET_HDR_F_RSC_INFO compat handling

On 2020/4/28 下午6:55, Yuri Benditovich wrote: On Tue, Apr 28, 2020 at 12:18 PM Cornelia Huck > wrote: On Tue, 28 Apr 2020 16:58:44 +0800 Jason Wang mailto:jasow...@redhat.com>> wrote: > On 2020/4/28 下午4:34, Cornelia Huck wrote: > > On Tue, 28 Apr

Re: [PATCH v1] target/m68k: fix gdb for m68xxx

Le 4/27/20 à 9:53 AM, Laurent Vivier a écrit : Le 20/04/2020 à 16:01, frederic.kon...@adacore.com a écrit : From: KONRAD Frederic Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is it uses the "org.gnu.gdb.coldfire.core" feature name and gdb 8.3 then expects a

Re: About hardfloat in ppc

On Tue, Apr 28, 2020 at 4:36 PM Alex Bennée wrote: > > 罗勇刚(Yonggang Luo) writes: > > > I am confusing why only inexact are set then we can use hard-float. > > The inexact behaviour of the host hardware may be different from the > guest architecture we are trying to emulate and the host

Re: [Qemu-devel] Should memory hotplug work with vhost-user backends?

> > I've briefly looked through the libvhost-user code and the hot-add path > > looks safe enough to me (or at least no more broken than the regular > > vhost-user memory hot-add path). > > > > Can you elaborate a little more about why memory hot-add is unsafe with > > vhost-user device backends

Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

Patchew URL: https://patchew.org/QEMU/20200428132629.796753-1-mre...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v2 04/14] block/amend: separate amend and create options for qemu-img

On Tue, Apr 28, 2020 at 04:03:33PM +0100, Daniel P. Berrangé wrote: > On Sun, Mar 08, 2020 at 05:18:53PM +0200, Maxim Levitsky wrote: > > Some options are only useful for creation > > (or hard to be amended, like cluster size for qcow2), while some other > > options are only useful for amend, like

RE: [PATCH 1/2] Fix undefined behaviour

> -Original Message- > From: Paul Durrant > Sent: 28 April 2020 13:33 > To: 'Artur Puzio' ; 'Grzegorz Uriasz' > ; qemu-devel@nongnu.org > Cc: marma...@invisiblethingslab.com; ja...@bartmin.ski; > j.nowa...@student.uw.edu.pl; 'Stefano > Stabellini' ; 'Anthony Perard' > ; xen- >

Re: [PATCH v20 4/4] iotests: 287: add qcow2 compression type test

On 28.04.2020 16:01, Eric Blake wrote: On 4/28/20 7:55 AM, Max Reitz wrote: +# This tests qocw2-specific low-level functionality +_supported_fmt qcow2 +_supported_proto file +_supported_os Linux This test doesn’t work with compat=0.10 (because we can’t store a non-default compression type

[PATCH v21 3/4] qcow2: add zstd cluster compression

zstd significantly reduces cluster compression time. It provides better compression performance maintaining the same level of the compression ratio in comparison with zlib, which, at the moment, is the only compression method available. The performance test results: Test compresses and

[PATCH v21 1/4] qcow2: introduce compression type feature

The patch adds some preparation parts for incompatible compression type feature to qcow2 allowing the use different compression methods for image clusters (de)compressing. It is implied that the compression type is set on the image creation and can be changed only later by image conversion, thus

Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

Patchew URL: https://patchew.org/QEMU/20200428132629.796753-1-mre...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v1] target/m68k: fix gdb for m68xxx

Le 28/04/2020 à 15:19, KONRAD Frederic a écrit : > > > Le 4/27/20 à 9:53 AM, Laurent Vivier a écrit : >> Le 20/04/2020 à 16:01, frederic.kon...@adacore.com a écrit : >>> From: KONRAD Frederic ... >> I would prefer to have two macros with no class parameter, something >> like

Re: [PATCH 1/2] Fix undefined behaviour

On 28.04.2020 10:10, Paul Durrant wrote: >> -Original Message- >> From: Grzegorz Uriasz >> Sent: 28 April 2020 07:29 >> To: qemu-devel@nongnu.org >> Cc: Grzegorz Uriasz ; marma...@invisiblethingslab.com; >> ar...@puzio.waw.pl; >> ja...@bartmin.ski; j.nowa...@student.uw.edu.pl; Stefano

Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

On 4/28/20 8:43 AM, no-re...@patchew.org wrote: Patchew URL: https://patchew.org/QEMU/20200428132629.796753-1-mre...@redhat.com/ SIGNpc-bios/optionrom/pvh.bin /tmp/qemu-test/src/qemu-img.c: In function 'img_commit': /tmp/qemu-test/src/qemu-img.c:1071:9: error: implicit declaration of

Re: [PATCH 1/4] block: Add bdrv_make_empty()

On 4/28/20 9:16 AM, Kevin Wolf wrote: Yes. Although now I'm wondering if the two should remain separate or should just be a single driver callback where flags can include BDRV_REQ_ZERO_WRITE to distinguish whether exposing the backing file vs. reading as all zeroes is intended, or if that is

Re: [RFC PATCH v1 20/26] kvm: vmi: intercept live migration

* Adalbert Lazăr (ala...@bitdefender.com) wrote: > On Mon, 27 Apr 2020 20:08:55 +0100, "Dr. David Alan Gilbert" > wrote: > > * Adalbert Lazăr (ala...@bitdefender.com) wrote: > > > From: Marian Rotariu > > > > > > It is possible that the introspection tool has made some changes inside > > > the

[PATCH 4/4] block: Use blk_make_empty() after commits

bdrv_commit() already has a BlockBackend pointing to the BDS that we want to empty, it just has the wrong permissions. qemu-img commit has no BlockBackend pointing to the old backing file yet, but introducing one is simple. After this commit, bdrv_make_empty() is the only remaining caller of

[PATCH 2/4] block: Use bdrv_make_empty() where possible

Signed-off-by: Max Reitz --- block/replication.c | 6 ++ block/vvfat.c | 4 +--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/block/replication.c b/block/replication.c index da013c2041..cc6a40d577 100644 --- a/block/replication.c +++ b/block/replication.c @@ -331,9

[PATCH 1/4] block: Add bdrv_make_empty()

Right now, all users of bdrv_make_empty() call the BlockDriver method directly. That is not only bad style, it is also wrong, unless the caller has a BdrvChild with a WRITE permission. Introduce bdrv_make_empty() that verifies that it does. Signed-off-by: Max Reitz --- include/block/block.h |

Re: [PATCH 1/4] block: Add bdrv_make_empty()

Am 28.04.2020 um 15:53 hat Eric Blake geschrieben: > On 4/28/20 8:26 AM, Max Reitz wrote: > > Right now, all users of bdrv_make_empty() call the BlockDriver method > > directly. That is not only bad style, it is also wrong, unless the > > caller has a BdrvChild with a WRITE permission. > > > >

Re: [PATCH 2/4] block: Use bdrv_make_empty() where possible

On 4/28/20 8:26 AM, Max Reitz wrote: Signed-off-by: Max Reitz --- block/replication.c | 6 ++ block/vvfat.c | 4 +--- 2 files changed, 3 insertions(+), 7 deletions(-) Yes, definitely nicer :) May have some obvious fallout to add a 0 flag parameter, per my request on 1/4, but

Re: [PATCH 1/4] block: Add bdrv_make_empty()

On 4/28/20 8:26 AM, Max Reitz wrote: Right now, all users of bdrv_make_empty() call the BlockDriver method directly. That is not only bad style, it is also wrong, unless the caller has a BdrvChild with a WRITE permission. Introduce bdrv_make_empty() that verifies that it does. Signed-off-by:

Re: [PATCH v5 0/4] introduction of migration_version attribute for VFIO live migration

* Yan Zhao (yan.y.z...@intel.com) wrote: > On Mon, Apr 27, 2020 at 11:37:43PM +0800, Dr. David Alan Gilbert wrote: > > * Yan Zhao (yan.y.z...@intel.com) wrote: > > > On Sat, Apr 25, 2020 at 03:10:49AM +0800, Dr. David Alan Gilbert wrote: > > > > * Yan Zhao (yan.y.z...@intel.com) wrote: > > > > >

[PATCH] hw/arm/mps2-tz: Use TYPE_IOTKIT instead of hardcoded string

By using the TYPE_* definitions for devices, we can: - quickly find where devices are used with 'git-grep' - easily rename a device (one-line change). Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/mps2-tz.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 05/14] block/amend: refactor qcow2 amend options

On Sun, Mar 08, 2020 at 05:18:54PM +0200, Maxim Levitsky wrote: > Some qcow2 create options can't be used for amend. > Remove them from the qcow2 create options and add generic logic to detect > such options in qemu-img > > Signed-off-by: Maxim Levitsky > --- > block/qcow2.c | 108

Re: [PATCH v20 4/4] iotests: 287: add qcow2 compression type test

On 28.04.20 13:41, Denis Plotnikov wrote: > > > On 27.04.2020 16:29, Max Reitz wrote: >> On 21.04.20 10:11, Denis Plotnikov wrote: >>> The test checks fulfilling qcow2 requirements for the compression >>> type feature and zstd compression type operability. >>> >>> Signed-off-by: Denis Plotnikov

Re: [PATCH 3/3] virtio-net: remove VIRTIO_NET_HDR_F_RSC_INFO compat handling

On 2020/4/28 下午5:18, Cornelia Huck wrote: On Tue, 28 Apr 2020 16:58:44 +0800 Jason Wang wrote: On 2020/4/28 下午4:34, Cornelia Huck wrote: On Tue, 28 Apr 2020 16:19:15 +0800 Jason Wang wrote: On 2020/4/27 下午6:24, Cornelia Huck wrote: VIRTIO_NET_HDR_F_RSC_INFO is available in the

Re: [PATCH v3 0/3] qcow2: Allow resize of images with internal snapshots

On 24.04.20 21:09, Eric Blake wrote: > In v3: > - patch 1: fix error returns [patchew, Max], R-b dropped > - patch 2,3: unchanged, so add R-b > > Eric Blake (3): > block: Add blk_new_with_bs() helper > qcow2: Allow resize of images with internal snapshots > qcow2: Tweak comment about

Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

Patchew URL: https://patchew.org/QEMU/20200428132629.796753-1-mre...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH 0/4] block: Do not call BlockDriver.bdrv_make_empty() directly

Patchew URL: https://patchew.org/QEMU/20200428132629.796753-1-mre...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[PATCH v1 0/1] target/arm: Remove access_el3_aa32ns()

From: "Edgar E. Iglesias" Hi, Laurent reported hitting the assert in access_el3_aa32ns() when accessing 32-bit versions of some of the virtualization regs when EL3 is 64-bit. I think we got this wrong back then and it seems to me like we should remove direct usage of access_el3_aa32ns() and

Re: [PATCH 0/3] account for NVDIMM nodes during SRAT generation

On Mon, 2020-04-27 at 19:44 -0700, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200428012810.10877-1-vishal.l.ve...@intel.com/ [..] > > === OUTPUT BEGIN === > 1/3 Checking commit 08b7ee5e7ddf (diffs-allowed: add the SRAT AML to > diffs-allowed) > 2/3 Checking commit

Re: [PATCH v2] target/arm: Use correct variable for setting 'max' cpu's MIDR_EL1

On Tue, Apr 28, 2020 at 5:50 PM Philippe Mathieu-Daudé wrote: > > MIDR_EL1 a 64-bit system register with the top 32-bit being RES0. > > This fixes when compiling with -Werror=conversion: > > target/arm/cpu64.c: In function ‘aarch64_max_initfn’: > target/arm/cpu64.c:628:21: error: conversion

Re: [PATCH v2 08/14] block/qcow2: extend qemu-img amend interface with crypto options

On Sun, Mar 08, 2020 at 05:18:57PM +0200, Maxim Levitsky wrote: > Now that we have all the infrastructure in place, > wire it in the qcow2 driver and expose this to the user. > > Signed-off-by: Maxim Levitsky > --- > block/qcow2.c | 80 -- >

Re: [PATCH v3 1/4] hw/net/can: Introduce Xilinx ZynqMP CAN controller

On Wed, Apr 22, 2020 at 05:56:06PM -0700, Vikram Garhwal wrote: > XlnxCAN is developed based on SocketCAN, QEMU CAN bus implementation. > Bus connection and socketCAN connection for each CAN module can be set > through command lines. + Damien (there's a reset question for you inline) + Francisco

Re: [PATCH 11/17] hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory

On 4/28/20 6:34 PM, Markus Armbruster wrote: The "bcm2835-peripherals" device's .instance_init() method bcm2835_peripherals_init() attempts to make two memory regions QOM children of the device. This is futile, because memory_region_init() already did. The errors are ignored (a later commit

Re: [PATCH RESEND v6 00/36] Initial support for multi-process qemu

On Wed, Apr 22, 2020 at 09:13:35PM -0700, elena.ufimts...@oracle.com wrote: > We will post separate patchsets for the following improvements for > the experimental Qemu multi-process: > - Live migration; > - Asynchronous communication channel; > - Libvirt support; > > We welcome all your

Re: [PATCH 03/17] qom: Drop object_property_del_child()'s unused parameter @errp

On 4/28/20 11:34 AM, Markus Armbruster wrote: Signed-off-by: Markus Armbruster --- qom/object.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake diff --git a/qom/object.c b/qom/object.c index 0c9e2052fa..9c74749193 100644 --- a/qom/object.c +++

Re: [PATCH 02/17] qom: Clean up inconsistent use of gchar * vs. char *

On 4/28/20 11:34 AM, Markus Armbruster wrote: Uses of gchar * in qom/object.h: Nice audit. I don't know if we can blindly assume that 'gchar' is a (stupid) typedef to 'char', or if they can ever differ, but avoiding gchar where possible always makes sense to me. Signed-off-by: Markus

Re: [PATCH v1 10/11] hw/arm: versal-virt: Add support for SD

On Mon, Apr 27, 2020 at 11:25 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Add support for SD. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > hw/arm/xlnx-versal-virt.c | 46 +++ > 1 file changed, 46

Re: [PATCH v1 11/11] hw/arm: versal-virt: Add support for the RTC

On Mon, Apr 27, 2020 at 11:28 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Add support for the RTC. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > hw/arm/xlnx-versal-virt.c | 22 ++ > 1 file changed, 22 insertions(+)

[PATCH] s390x/kvm: help valgrind in several places

We need some little help in the code to reduce the valgrind noise. - some designated initializers for the cpu model features and subfunctions - mark memory as defined for sida memory reads Signed-off-by: Christian Borntraeger --- target/s390x/kvm.c | 15 +-- 1 file changed, 13

Re: [PATCH 17/17] qom: Drop @errp parameter of object_property_del()

On 4/28/20 11:34 AM, Markus Armbruster wrote: Same story as for object_property_add(): the only way object_property_del() can fail is when the property with this name does not exist. Since our property names are all hardcoded, failure is a programming error, and the appropriate way to handle it

Re: [PATCH v2 07/14] block/crypto: implement the encryption key management

On Sun, Mar 08, 2020 at 05:18:56PM +0200, Maxim Levitsky wrote: > This implements the encryption key management using the generic code in > qcrypto layer and exposes it to the user via qemu-img > > This code adds another 'write_func' because the initialization > write_func works directly on the

Re: [PATCH V2] Add a new PIIX option to control PCI hot unplugging of devices on non-root buses

On Tue, Apr 28, 2020 at 12:05:47PM -0400, Michael S. Tsirkin wrote: > On Tue, Apr 28, 2020 at 10:16:52AM +, Ani Sinha wrote: > > A new option "use_acpi_unplug" is introduced for PIIX which will > > selectively only disable hot unplugging of both hot plugged and > > cold plugged PCI devices on

Re: [PATCH v7 04/10] qcow2: Support BDRV_REQ_ZERO_WRITE for truncate

On 4/24/20 7:54 AM, Kevin Wolf wrote: If BDRV_REQ_ZERO_WRITE is set and we're extending the image, calling qcow2_cluster_zeroize() with flags=0 does the right thing: It doesn't undo any previous preallocation, but just adds the zero flag to all relevant L2 entries. If an external data file is in

[PATCH 06/17] qom: Drop object_property_set_description() parameter @errp

object_property_set_description() and object_class_property_set_description() fail only when property @name is not found. There are 85 calls of object_property_set_description() and object_class_property_set_description(). None of them can fail: * 84 immediately follow the creation of the

[PATCH 0/2] m68k fpu fixes

Here are two fixes for the m68k targets: - the first one implements a fix about infinity handling when converting it from extended format to double or single format. - the second fixes the length of the floating points registers for GDB. Changes: * target/m68k/cpu.c: created

[PATCH 2/2] target/m68k: fix gdb for m68xxx

Currently "cf-core.xml" is sent to GDB when using any m68k flavor. Thing is it uses the "org.gnu.gdb.coldfire.core" feature name and gdb 8.3 then expects a coldfire FPU instead of the default m68881 FPU. This is not OK because the m68881 floats registers are 96 bits wide so it crashes GDB with

[PATCH 1/2] softfloat: m68k: infinity is a valid encoding

The MC68881 say about infinities (3.2.4): "*For the extended precision format, the most significant bit of the mantissa (the integer bit) is a don't care." https://www.nxp.com/docs/en/reference-manual/MC68881UM.pdf The m68k extended format is implemented with the floatx80 and

Re: [PATCH v10 00/14] iotests: use python logging

On 4/28/20 8:21 AM, Kevin Wolf wrote: > Am 28.04.2020 um 13:46 hat Max Reitz geschrieben: >> On 31.03.20 02:00, John Snow wrote: >>> This series uses python logging to enable output conditionally on >>> iotests.log(). We unify an initialization call (which also enables >>> debugging output for

[PATCH RFC 2/3] target/arm: Implement SVE2 FCVTLT

Signed-off-by: Stephen Long --- target/arm/helper-sve.h| 5 + target/arm/sve.decode | 2 ++ target/arm/sve_helper.c| 23 +++ target/arm/translate-sve.c | 16 4 files changed, 46 insertions(+) diff --git a/target/arm/helper-sve.h

Re: [PATCH 07/17] tests/check-qom-proplist: Improve iterator coverage

On 4/28/20 11:34 AM, Markus Armbruster wrote: The tests' "qemu-dummy" device has only class properties. Turn one of them into an instance property. test_dummy_class_iterator() expects one fewer property than test_dummy_iterator(). Rewrite test_dummy_prop_iterator() to take expected properties

Re: [PATCH v3 2/4] xlnx-zynqmp: Connect Xilinx ZynqMP CAN controller

Hi Vikram, A couple of more comments: On the git summary: s/controller/controllers/ On [2020 Apr 22] Wed 17:56:07, Vikram Garhwal wrote: > Connect CAN0 and CAN1 to ZCU102 board. Perhaps also: s/to ZCU102 board/on the ZynqMP/ (even though zcu102 is the only board using it at the moment). Best

Re: [Virtio-fs] [PATCH] virtiofsd: Show submounts

On Tue, Apr 28, 2020 at 4:52 PM Stefan Hajnoczi wrote: > > On Mon, Apr 27, 2020 at 06:59:02PM +0100, Dr. David Alan Gilbert wrote: > > * Max Reitz (mre...@redhat.com) wrote: > > > Currently, setup_mounts() bind-mounts the shared directory without > > > MS_REC. This makes all submounts disappear.

Re: [PATCH for-5.1 5/7] target/mips: Add more CP0 register for save/restore

пон, 27. апр 2020. у 11:36 Huacai Chen је написао/ла: > > Add more CP0 register for save/restore, including: EBase, XContext, > PageGrain, PWBase, PWSize, PWField, PWCtl, Config*, KScratch1~KScratch6. > > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxun Yang > --- > target/mips/kvm.c |

Re: [PATCH v2 14/14] iotests: add tests for blockdev-amend

On Sun, Mar 08, 2020 at 05:19:03PM +0200, Maxim Levitsky wrote: > This commit adds two tests that cover the > new blockdev-amend functionality of luks and qcow2 driver > > Signed-off-by: Maxim Levitsky > --- > tests/qemu-iotests/302 | 278 + >

Re: [PATCH v2 3/3] configure: add libdaxctl support

On 4/15/20 4:35 AM, Jingqi Liu wrote: > Add a pair of configure options --{enable,disable}-libdaxctl to control > whether QEMU is compiled with libdaxctl [1]. Libdaxctl is a utility > library for managing the device dax subsystem. > > QEMU uses mmap(2) to maps vNVDIMM backends and aligns the

Re: [PATCH v2 2/3] docs/nvdimm: add description of alignment requirement of device dax

On 4/15/20 4:35 AM, Jingqi Liu wrote: > For device dax (e.g., /dev/dax0.0), the NUM of 'align=NUM' option > needs to match the alignment requirement of the device dax. > It must be larger than or equal to the 'align' of device dax. > > Signed-off-by: Jingqi Liu > --- > docs/nvdimm.txt | 9

Re: [PATCH v3 2/4] xlnx-zynqmp: Connect Xilinx ZynqMP CAN controller

On Wed, Apr 22, 2020 at 05:56:07PM -0700, Vikram Garhwal wrote: > Connect CAN0 and CAN1 to ZCU102 board. Comments inline. > > Signed-off-by: Vikram Garhwal > --- > hw/arm/xlnx-zynqmp.c | 26 ++ > include/hw/arm/xlnx-zynqmp.h | 3 +++ > 2 files changed, 29

  1   2   3   4   >