Re: [PATCH v3 3/3] target/arm: Use clear_vec_high more effectively

2020-05-05 Thread Philippe Mathieu-Daudé
On 5/4/20 9:23 PM, Richard Henderson wrote: Do not explicitly store zero to the NEON high part when we can pass !is_q to clear_vec_high. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- Patch easier to review with 'git-diff --function-context'. target/arm/translate-a64.c |

Re: [PATCH] aspeed: Support AST2600A1 silicon revision

2020-05-05 Thread Cédric Le Goater
On 5/4/20 11:37 AM, Joel Stanley wrote: > There are minimal differences from Qemu's point of view between the A0 > and A1 silicon revisions. > > As the A1 exercises different code paths in u-boot it is desirable to > emulate that instead. > > Signed-off-by: Joel Stanley Reviewed-by: Cédric Le

Re: [PATCH qemu] spapr: Add PVR setting capability

2020-05-05 Thread Alexey Kardashevskiy
On 05/05/2020 15:50, David Gibson wrote: > On Tue, May 05, 2020 at 10:56:17AM +1000, Alexey Kardashevskiy wrote: >> >> >> On 04/05/2020 21:30, Greg Kurz wrote: >>> On Fri, 17 Apr 2020 14:11:05 +1000 >>> Alexey Kardashevskiy wrote: >>> At the moment the VCPU init sequence includes setting

Re: [PATCH v18 QEMU 02/18] vfio: Add function to unmap VFIO region

2020-05-05 Thread Philippe Mathieu-Daudé
Hi Kirti, On 5/5/20 12:44 AM, Kirti Wankhede wrote: This function will be used for migration region. Migration region is mmaped when migration starts and will be unmapped when migration is complete. Signed-off-by: Kirti Wankhede Reviewed-by: Neo Jia Reviewed-by: Cornelia Huck ---

Re: [PATCH v5 4/7] qcow2: Deprecate use of qemu-img amend to change backing file

2020-05-05 Thread Kevin Wolf
Am 03.04.2020 um 19:58 hat Eric Blake geschrieben: > The use of 'qemu-img amend' to change qcow2 backing files is not > tested very well. In particular, our implementation has a bug where > if a new backing file is provided without a format, then the prior > format is blindly reused, even if this

[PATCH] iotests/055: Use cache.no-flush for vmdk target

2020-05-05 Thread Kevin Wolf
055 uses the backup block job to create a compressed backup of an $IMGFMT image with both qcow2 and vmdk targets. However, cluster allocation in vmdk is very slow because it flushes the image file after each L2 update. There is no reason why we need this level of safety in this test, so let's

[Bug 1876678] Re: Ubuntu 20.04 KVM / QEMU Failure with nested FreeBSD bhyve

2020-05-05 Thread John Hartley
** Summary changed: - Ubuntu 20.04 QEMU Failure with nested FreeBSD bhyve + Ubuntu 20.04 KVM / QEMU Failure with nested FreeBSD bhyve -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1876678 Title:

RE: [PULL 04/20] crypto: Redundant type conversion for AES_KEY pointer

2020-05-05 Thread Chenqun (kuhn)
>-Original Message- >From: Daniel P. Berrangé [mailto:berra...@redhat.com] >Sent: Monday, May 4, 2020 8:58 PM >To: Chenqun (kuhn) >Cc: qemu-devel@nongnu.org; Michael Tokarev ; qemu- >triv...@nongnu.org; Laurent Vivier ; Euler Robot > >Subject: Re: [PULL 04/20] crypto: Redundant type

[PATCH] tests/Makefile: Fix description of "make check"

2020-05-05 Thread Huacai Chen
The description of "make check" is out-of-date, so fix it by adding block and softfloat. Signed-off-by: Huacai Chen --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 03a74b6..5d32239 100644 ---

Re: [PATCH for-5.1 V3 0/7] mips: Add Loongson-3 machine support (with KVM)

2020-05-05 Thread chen huacai
Hi, Aleksandar, On Sun, May 3, 2020 at 6:50 PM Aleksandar Markovic wrote: > > нед, 3. мај 2020. у 12:21 Huacai Chen је написао/ла: > > > > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B > > R1/R2. Loongson-3A R1 is the oldest and its ISA is the smallest, while > >

Re: [PATCH v5 3/7] qcow: Tolerate backing_fmt=, but warn on backing_fmt=raw

2020-05-05 Thread Kevin Wolf
Am 03.04.2020 um 19:58 hat Eric Blake geschrieben: > qcow has no space in the metadata to store a backing format, and there > are existing qcow images backed both by raw or by other formats > (usually qcow) images, reliant on probing to tell the difference. > While we don't recommend the creation

Re: [PATCH] tests/Makefile: Fix description of "make check"

2020-05-05 Thread Claudio Fontana
On 5/5/20 9:29 AM, Huacai Chen wrote: > The description of "make check" is out-of-date, so fix it by adding > block and softfloat. > > Signed-off-by: Huacai Chen > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.include

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-05-05 Thread Ike Panhc
Thanks. I will test it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1805256 Title: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images Status in kunpeng920:

Re: [PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate()

2020-05-05 Thread Kevin Wolf
Am 04.05.2020 um 19:07 hat Alberto Garcia geschrieben: > On Mon 04 May 2020 06:01:19 PM CEST, Eric Blake wrote: > >> +_supported_fmt qcow2 > >> +_supported_proto file > > > > Do we have to limit it to qcow2 and file? Yes, it's testing a bugfix > > for qcow2, but are there other formats that it

[PATCH v2] crypto: Redundant type conversion for AES_KEY pointer

2020-05-05 Thread Chen Qun
We can delete the redundant type conversion if we set the the AES_KEY parameter with 'const' in qcrypto_cipher_aes_ecb_(en|de)crypt() function. Reported-by: Euler Robot Signed-off-by: Chen Qun --- v1->v2: Cc: "Daniel P. Berrangé" Modify the AES_KEY parameter with 'const' in

[PATCH] aspeed: sdmc: Implement AST2600 locking behaviour

2020-05-05 Thread Joel Stanley
The AST2600 handles this differently with the extra 'hardlock' state, so move the testing to the soc specific class' write callback. Signed-off-by: Joel Stanley --- hw/misc/aspeed_sdmc.c | 55 +++ 1 file changed, 45 insertions(+), 10 deletions(-) diff

Re: [PATCH v9 8/9] virtio-iommu: Implement probe request

2020-05-05 Thread Bharat Bhushan
On Fri, Apr 24, 2020 at 7:22 PM Auger Eric wrote: > > Hi Bharat, > On 4/23/20 6:09 PM, Jean-Philippe Brucker wrote: > > Hi Bharat, > > > > A few more things found while rebasing > > > > On Mon, Mar 23, 2020 at 02:16:16PM +0530, Bharat Bhushan wrote: > >> This patch implements the PROBE request.

Re: [PATCH] aspeed: sdmc: Implement AST2600 locking behaviour

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200505090136.341426-1-j...@jms.id.au/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

Re: [PATCH v2] crypto: Redundant type conversion for AES_KEY pointer

2020-05-05 Thread Daniel P . Berrangé
On Tue, May 05, 2020 at 04:59:40PM +0800, Chen Qun wrote: > We can delete the redundant type conversion if > we set the the AES_KEY parameter with 'const' in > qcrypto_cipher_aes_ecb_(en|de)crypt() function. > > Reported-by: Euler Robot > Signed-off-by: Chen Qun > --- > v1->v2: > Cc: "Daniel P.

Re: [PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate()

2020-05-05 Thread Alberto Garcia
On Tue 05 May 2020 10:54:12 AM CEST, Kevin Wolf wrote: > But I think there is a more important problem with the test: It seems > to pass even with old binaries that don't have the fix. Is this only > on my system or do you get the same? With old binaries when qcow2_cluster_zeroize() is called it

Re: [PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate()

2020-05-05 Thread Kevin Wolf
Am 05.05.2020 um 10:54 hat Kevin Wolf geschrieben: > Am 04.05.2020 um 19:07 hat Alberto Garcia geschrieben: > > On Mon 04 May 2020 06:01:19 PM CEST, Eric Blake wrote: > > >> +_supported_fmt qcow2 > > >> +_supported_proto file > > > > > > Do we have to limit it to qcow2 and file? Yes, it's testing

Re: [PATCH v2] Fix iotest 153

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504131959.9533-1-mlevi...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate()

2020-05-05 Thread Kevin Wolf
Am 05.05.2020 um 11:16 hat Alberto Garcia geschrieben: > On Tue 05 May 2020 10:54:12 AM CEST, Kevin Wolf wrote: > > But I think there is a more important problem with the test: It seems > > to pass even with old binaries that don't have the fix. Is this only > > on my system or do you get the

Re: [PATCH v2 0/1] target/arm: Remove access_el3_aa32ns()

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504142125.31180-1-edgar.igles...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200504142125.31180-1-edgar.igles...@gmail.com Subject: [PATCH v2 0/1] target/arm: Remove

Re: [EXT] Re: [PATCH v9 1/9] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-05-05 Thread Bharat Bhushan
Hi Eric, On Fri, Apr 24, 2020 at 7:47 PM Auger Eric wrote: > > Hi Bharat, > > On 4/2/20 11:01 AM, Bharat Bhushan wrote: > > Hi Eric/Alex, > > > >> -Original Message- > >> From: Alex Williamson > >> Sent: Thursday, March 26, 2020 11:23 PM > >> To: Auger Eric > >> Cc: Bharat Bhushan ;

Re: [EXT] Re: [PATCH v9 1/9] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-05-05 Thread Auger Eric
Hi Bharat, On 5/5/20 11:25 AM, Bharat Bhushan wrote: > Hi Eric, > > On Fri, Apr 24, 2020 at 7:47 PM Auger Eric wrote: >> >> Hi Bharat, >> >> On 4/2/20 11:01 AM, Bharat Bhushan wrote: >>> Hi Eric/Alex, >>> -Original Message- From: Alex Williamson Sent: Thursday, March 26,

Re: [PATCH] tests/Makefile: Fix description of "make check"

2020-05-05 Thread Philippe Mathieu-Daudé
On 5/5/20 9:29 AM, Huacai Chen wrote: The description of "make check" is out-of-date, so fix it by adding block and softfloat. Signed-off-by: Huacai Chen --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.include

Re: [PATCH v5 7/7] qemu-img: Deprecate use of -b without -F

2020-05-05 Thread Kevin Wolf
Am 03.04.2020 um 19:58 hat Eric Blake geschrieben: > Creating an image that requires format probing of the backing image is > inherently unsafe (we've had several CVEs over the years based on > probes leaking information to the guest on a subsequent boot, although > these days tools like libvirt

Re: [PATCH v5] audio/jack: add JACK client audiodev

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504132300.1ae883c1...@aeryn.lan.ktmba/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit

Re: [PATCH v2 0/1] target/arm: Remove access_el3_aa32ns()

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504142125.31180-1-edgar.igles...@gmail.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PATCH v2] qcow2: Avoid integer wraparound in qcow2_co_truncate()

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504142308.10446-1-be...@igalia.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200504142308.10446-1-be...@igalia.com Subject: [PATCH v2] qcow2: Avoid integer wraparound in

Re: [PATCH 5/6] block/nvme: Align block pages queue to host page size

2020-05-05 Thread Laurent Vivier
On 05/05/2020 10:00, Laurent Vivier wrote: > On 04/05/2020 11:46, Philippe Mathieu-Daudé wrote: >> In nvme_create_queue_pair() we create a page list using >> qemu_blockalign(), then map it with qemu_vfio_dma_map(): >> >> q->prp_list_pages = qemu_blockalign0(bs, s->page_size * NVME_QUEUE_SIZE);

Re: Infinite loop in bus_unparent(), qdev bug or qdev misuse?

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/87tv0vzrwj@dusky.pond.sub.org/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that has

Re: [PATCH v3] qcow2: Avoid integer wraparound in qcow2_co_truncate()

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504155217.10325-1-be...@igalia.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit that

Re: [PATCH v3 00/12] user-mode: Prune build dependencies (part 1)

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504152922.21365-1-phi...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PATCH v3 00/12] user-mode: Prune build dependencies (part 1)

2020-05-05 Thread Laurent Vivier
Le 04/05/2020 à 17:29, Philippe Mathieu-Daudé a écrit : > This is the first part of a series reducing user-mode > dependencies. By stripping out unused code, the build > and testing time is reduced (as is space used by objects). > > Part 1 (generic): > - reduce user-mode object list > - remove

Re: [PATCH 5/6] block/nvme: Align block pages queue to host page size

2020-05-05 Thread Laurent Vivier
On 04/05/2020 11:46, Philippe Mathieu-Daudé wrote: > In nvme_create_queue_pair() we create a page list using > qemu_blockalign(), then map it with qemu_vfio_dma_map(): > > q->prp_list_pages = qemu_blockalign0(bs, s->page_size * NVME_QUEUE_SIZE); > r = qemu_vfio_dma_map(s->vfio,

Re: [PATCH v2] Fix iotest 153

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504131959.9533-1-mlevi...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v2] Fix iotest 153

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504131959.9533-1-mlevi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200504131959.9533-1-mlevi...@redhat.com Subject: [PATCH v2] Fix iotest 153 Type: series === TEST

Re: [PULL 00/39] target-arm queue

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504123309.3808-1-peter.mayd...@linaro.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT

Re: [PULL 00/39] target-arm queue

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504123309.3808-1-peter.mayd...@linaro.org/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a

Re: Infinite loop in bus_unparent(), qdev bug or qdev misuse?

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/87tv0vzrwj@dusky.pond.sub.org/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v2] tests/qht-bench: Fix Clang 'int-conversion' warning

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504144125.22435-1-phi...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PULL v2 0/4] Block patches

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504151438.362702-1-stefa...@redhat.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH v3] tests/qht-bench: Fix Clang 'implicit-int-float-conversion' warning

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504144352.23021-1-phi...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PULL v2 0/4] Block patches

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504151438.362702-1-stefa...@redhat.com/ Hi, This series failed build test on FreeBSD host. Please find the details below. === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the git checkout with # HEAD pointing to a commit

Re: [PULL v2 0/4] Block patches

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504151438.362702-1-stefa...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [PULL v2 0/4] Block patches

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200504151438.362702-1-stefa...@redhat.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH v2 00/10] Cadence GEM Fixes

2020-05-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1588601168-27576-1-git-send-email-sai.pavan.bo...@xilinx.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 1588601168-27576-1-git-send-email-sai.pavan.bo...@xilinx.com Subject: [PATCH v2

Re: [PATCH v5 7/7] qemu-img: Deprecate use of -b without -F

2020-05-05 Thread Peter Krempa
On Tue, May 05, 2020 at 10:11:03 +0200, Kevin Wolf wrote: > Am 03.04.2020 um 19:58 hat Eric Blake geschrieben: > > Creating an image that requires format probing of the backing image is > > inherently unsafe (we've had several CVEs over the years based on > > probes leaking information to the

Re: [PATCH v5 00/18] nvme: refactoring and cleanups

2020-05-05 Thread Philippe Mathieu-Daudé
On 5/5/20 7:48 AM, Klaus Jensen wrote: From: Klaus Jensen Changes since v5 No functional changes, just updated Reviewed-by tags. Also, I screwed up the CC list when sending v4. Philippe and Keith, please add a Reviewed-by to * "nvme: factor out pmr setup" and * "do

Re: [PATCH v18 QEMU 05/18] vfio: Add migration region initialization and finalize function

2020-05-05 Thread Cornelia Huck
On Tue, 5 May 2020 04:14:40 +0530 Kirti Wankhede wrote: > - Migration functions are implemented for VFIO_DEVICE_TYPE_PCI device in this > patch series. I would drop this sentence; people looking at this patch in the future are unlikely to care. > - VFIO device supports migration or not is

Re: [PATCH 0/6] vmdk: Fix zero cluster handling

2020-05-05 Thread Kevin Wolf
Am 30.04.2020 um 15:30 hat Kevin Wolf geschrieben: > What I was really investigating is why 055 was so slow. I couldn't solve > that, but instead I found out that our VMDK code for zero clusters and > write_zeroes was completely broken. Apart from segfaults when zero > clusters were actually

Re: [EXT] Re: [PATCH v9 1/9] hw/vfio/common: Remove error print on mmio region translation by viommu

2020-05-05 Thread Bharat Bhushan
hi Eric, On Tue, May 5, 2020 at 3:00 PM Auger Eric wrote: > > Hi Bharat, > > On 5/5/20 11:25 AM, Bharat Bhushan wrote: > > Hi Eric, > > > > On Fri, Apr 24, 2020 at 7:47 PM Auger Eric wrote: > >> > >> Hi Bharat, > >> > >> On 4/2/20 11:01 AM, Bharat Bhushan wrote: > >>> Hi Eric/Alex, > >>> >

Re: [PATCH v4 00/18] target/arm: sve load/store improvements

2020-05-05 Thread Peter Maydell
On Mon, 4 May 2020 at 17:03, Richard Henderson wrote: > > On 5/4/20 2:43 AM, Peter Maydell wrote: > > I've reviewed patch 13, but I still don't understand why you've > > made the size-related changes in patch 4, so I've continued > > our conversation in the thread on the v3 version of that patch.

Re: [PATCH 5/6] block/nvme: Align block pages queue to host page size

2020-05-05 Thread Philippe Mathieu-Daudé
On 5/5/20 10:23 AM, Laurent Vivier wrote: On 05/05/2020 10:00, Laurent Vivier wrote: On 04/05/2020 11:46, Philippe Mathieu-Daudé wrote: In nvme_create_queue_pair() we create a page list using qemu_blockalign(), then map it with qemu_vfio_dma_map(): q->prp_list_pages = qemu_blockalign0(bs,

[RFC PATCH] hw/arm/musicpal: Map the UART devices unconditionally

2020-05-05 Thread Philippe Mathieu-Daudé
I can't find proper documentation or datasheet, but it is likely a MMIO mapped serial device mapped in the 0x8000..0x8000 range belongs to the SoC address space, thus is always mapped in the memory bus. Map the devices on the bus regardless a chardev is attached to it. Signed-off-by:

Re: [PATCH v2 3/4] backup: Make sure that source and target size match

2020-05-05 Thread Kevin Wolf
Am 30.04.2020 um 20:21 hat Vladimir Sementsov-Ogievskiy geschrieben: > 30.04.2020 17:27, Kevin Wolf wrote: > > Since the introduction of a backup filter node in commit 00e30f05d, the > > backup block job crashes when the target image is smaller than the > > source image because it will try to

Re: [PATCH] tests/Makefile: Fix description of "make check"

2020-05-05 Thread chen huacai
Hi, Philippe, On Tue, May 5, 2020 at 5:33 PM Philippe Mathieu-Daudé wrote: > > On 5/5/20 9:29 AM, Huacai Chen wrote: > > The description of "make check" is out-of-date, so fix it by adding > > block and softfloat. > > > > Signed-off-by: Huacai Chen > > --- > > tests/Makefile.include | 2 +- >

[PATCH] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h'

2020-05-05 Thread Philippe Mathieu-Daudé
Use the generic AUDIO_HOST_ENDIANNESS definition instead of a custom one. Signed-off-by: Philippe Mathieu-Daudé --- Who/what machine is using this device anyway? --- hw/audio/gus.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/audio/gus.c b/hw/audio/gus.c index

Re: [PATCH v2 0/4] backup: Make sure that source and target size match

2020-05-05 Thread Kevin Wolf
Am 30.04.2020 um 16:27 hat Kevin Wolf geschrieben: > v2: > - Fixed iotest 283 > - Corrected commit message for patch 3 [Vladimir] > - Fixed permissions for the source node, too > - Refactored the test case to avoid some duplication [Vladimir] Thanks for the review, applied to the block branch.

Re: [RFC PATCH] hw/arm/musicpal: Map the UART devices unconditionally

2020-05-05 Thread Jan Kiszka
On 05.05.20 11:59, Philippe Mathieu-Daudé wrote: I can't find proper documentation or datasheet, but it is likely a MMIO mapped serial device mapped in the 0x8000..0x8000 range belongs to the SoC address space, thus is always mapped in the memory bus. Map the devices on the bus

Re: [PATCH] hw/audio/gus: Use AUDIO_HOST_ENDIANNESS definition from 'audio/audio.h'

2020-05-05 Thread Paolo Bonzini
On 05/05/20 12:07, Philippe Mathieu-Daudé wrote: > Use the generic AUDIO_HOST_ENDIANNESS definition instead > of a custom one. > > Signed-off-by: Philippe Mathieu-Daudé > --- > Who/what machine is using this device anyway? PC, like all old ISA audio cards. Paolo

Re: [PATCH for-5.1 V3 0/7] mips: Add Loongson-3 machine support (with KVM)

2020-05-05 Thread Aleksandar Markovic
уторак, 05. мај 2020., chen huacai је написао/ла: > Hi, Aleksandar, > > On Sun, May 3, 2020 at 6:50 PM Aleksandar Markovic > wrote: > > > > нед, 3. мај 2020. у 12:21 Huacai Chen је > написао/ла: > > > > > > Loongson-3 CPU family include Loongson-3A R1/R2/R3/R4 and Loongson-3B > > > R1/R2.

Re: [PULL v2 0/4] Block patches

2020-05-05 Thread Peter Maydell
On Mon, 4 May 2020 at 16:15, Stefan Hajnoczi wrote: > > The following changes since commit 9af638cc1f665712522608c5d6b8c03d8fa67666: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20200504' into staging (2020-05-04 > 13:37:17 +0100) > > are available in the Git

Re: [PATCH v3 03/33] block: Add BdrvChildRole and BdrvChildRoleBits

2020-05-05 Thread Max Reitz
On 05.05.20 14:54, Kevin Wolf wrote: > Am 05.05.2020 um 13:59 hat Max Reitz geschrieben: >> On 05.05.20 13:19, Kevin Wolf wrote: >>> Am 18.02.2020 um 13:42 hat Max Reitz geschrieben: [...] +/* Useful combination of flags */ +BDRV_CHILD_IMAGE= BDRV_CHILD_DATA +

Re: [PATCH v4 03/13] acpi: rtc: use a single crs range

2020-05-05 Thread Igor Mammedov
On Tue, 5 May 2020 13:38:33 +0200 Gerd Hoffmann wrote: > Use a single io range for _CRS instead of two, > following what real hardware does. > > Signed-off-by: Gerd Hoffmann > --- > hw/rtc/mc146818rtc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

Re: [PATCH v4 13/13] floppy: make isa_fdc_get_drive_max_chs static

2020-05-05 Thread Igor Mammedov
On Tue, 5 May 2020 13:38:43 +0200 Gerd Hoffmann wrote: > acpi aml generator needs this, but it is in floppy code now > so we can make the function static. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov > --- > include/hw/block/fdc.h | 2 -- > hw/block/fdc.c | 4 ++-- >

Re: [PATCH v4 12/13] acpi: drop serial/parallel enable bits from dsdt

2020-05-05 Thread Igor Mammedov
On Tue, 5 May 2020 13:38:42 +0200 Gerd Hoffmann wrote: > The _STA methods for COM+LPT used to reference them, > but that isn't the case any more. > > Signed-off-by: Gerd Hoffmann > --- > hw/i386/acpi-build.c | 23 --- > 1 file changed, 23 deletions(-) > > diff --git

Re: [PATCH v4 05/13] acpi: move aml builder code for serial device

2020-05-05 Thread Philippe Mathieu-Daudé
On 5/5/20 1:38 PM, Gerd Hoffmann wrote: The code uses the isa_serial_io array to figure what the device uid is. Side effect is that acpi antries are not limited to port 1+2 any more, we'll also get entries for ports 3+4. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov ---

Re: [PATCH v2 01/13] acpi: make build_madt() more generic.

2020-05-05 Thread Igor Mammedov
On Tue, 5 May 2020 15:42:53 +0200 Gerd Hoffmann wrote: > Remove PCMachineState dependency from build_madt(). > Pass AcpiDeviceIf as separate argument instead of > depending on PCMachineState->acpi_dev. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor

Re: [PATCH v2 06/13] acpi: move acpi_align_size to acpi-common.h

2020-05-05 Thread Philippe Mathieu-Daudé
Hi Gerd, On 5/5/20 3:42 PM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- hw/i386/acpi-common.h | 19 +++ hw/i386/acpi-build.c | 18 -- 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/hw/i386/acpi-common.h b/hw/i386/acpi-common.h

RE: [PATCH v2 02/10] xen: Fix and improve handling of device_add usb-host errors

2020-05-05 Thread Paul Durrant
> -Original Message- > From: Markus Armbruster > Sent: 05 May 2020 11:19 > To: qemu-devel@nongnu.org > Cc: Stefano Stabellini ; Anthony Perard > ; Paul > Durrant ; Gerd Hoffmann ; > xen-de...@lists.xenproject.org > Subject: [PATCH v2 02/10] xen: Fix and improve handling of device_add >

Re: [PATCH] virtiofsd: Use clone() and not unshare(), support non-root

2020-05-05 Thread Stefan Hajnoczi
On Mon, May 04, 2020 at 04:07:22PM +0200, Marc-André Lureau wrote: > Hi > > On Fri, May 1, 2020 at 8:29 PM Colin Walters wrote: > > > > I'd like to make use of virtiofs as part of our tooling in > > https://github.com/coreos/coreos-assembler > > Most of the code runs as non-root today; qemu also

Re: [PATCH 12/17] qdev: Clean up qdev_connect_gpio_out_named()

2020-05-05 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 4/28/20 6:34 PM, Markus Armbruster wrote: >> Both qdev_connect_gpio_out_named() and device_set_realized() put >> objects without a parent into the "/machine/unattached/" orphanage. >> >> qdev_connect_gpio_out_named() needs a lengthy comment to explain how >>

[PATCH v2 16/18] qdev: Unrealize must not fail

2020-05-05 Thread Markus Armbruster
Devices may have component devices and buses. Device realization may fail. Realization is recursive: a device's realize() method realizes its components, and device_set_realized() realizes its buses (which should in turn realize the devices on that bus, except bus_set_realized() doesn't

Re: [PATCH] virtiofsd: Use clone() and not unshare(), support non-root

2020-05-05 Thread Daniel P . Berrangé
On Tue, May 05, 2020 at 04:23:59PM +0100, Stefan Hajnoczi wrote: > On Mon, May 04, 2020 at 04:07:22PM +0200, Marc-André Lureau wrote: > > Hi > > > > On Fri, May 1, 2020 at 8:29 PM Colin Walters wrote: > > > > > > I'd like to make use of virtiofs as part of our tooling in > > >

[PATCH v2 03/18] qom: Drop object_property_del_child()'s unused parameter @errp

2020-05-05 Thread Markus Armbruster
Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Reviewed-by: Paolo Bonzini --- qom/object.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qom/object.c b/qom/object.c index 07762cc331..3d65658059 100644 --- a/qom/object.c +++ b/qom/object.c @@ -614,7 +614,7 @@

Re: [PATCH v2 04/18] qom: Simplify object_property_get_enum()

2020-05-05 Thread Philippe Mathieu-Daudé
On 5/5/20 5:29 PM, Markus Armbruster wrote: Reuse object_property_get_str(). Switches from the string to the qobject visitor under the hood. Signed-off-by: Markus Armbruster --- qom/object.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/qom/object.c

Re: [PATCH v2 04/18] qom: Simplify object_property_get_enum()

2020-05-05 Thread Paolo Bonzini
On 05/05/20 17:29, Markus Armbruster wrote: > Reuse object_property_get_str(). Switches from the string to the > qobject visitor under the hood. > > Signed-off-by: Markus Armbruster > --- > qom/object.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git

[PATCH v5 27/31] qcow2: Add subcluster support to qcow2_co_pwrite_zeroes()

2020-05-05 Thread Alberto Garcia
This works now at the subcluster level and pwrite_zeroes_alignment is updated accordingly. qcow2_cluster_zeroize() is turned into qcow2_subcluster_zeroize() with the following changes: - The request can now be subcluster-aligned. - The cluster-aligned body of the request is still zeroized

[PATCH v5 28/31] qcow2: Add the 'extended_l2' option and the QCOW2_INCOMPAT_EXTL2 bit

2020-05-05 Thread Alberto Garcia
Now that the implementation of subclusters is complete we can finally add the necessary options to create and read images with this feature, which we call "extended L2 entries". Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- qapi/block-core.json | 7 +++ block/qcow2.h

[PATCH v5 14/31] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type()

2020-05-05 Thread Alberto Garcia
This patch adds QCow2SubclusterType, which is the subcluster-level version of QCow2ClusterType. All QCOW2_SUBCLUSTER_* values have the the same meaning as their QCOW2_CLUSTER_* equivalents (when they exist). See below for details and caveats. In images without extended L2 entries clusters are

[PATCH v5 25/31] qcow2: Clear the L2 bitmap when allocating a compressed cluster

2020-05-05 Thread Alberto Garcia
Compressed clusters always have the bitmap part of the extended L2 entry set to 0. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz --- block/qcow2-cluster.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c index 4544a40aa0..0a295076a3

Re: [PATCH v2 0/4] softfloat: fix floatx80 emulation bugs

2020-05-05 Thread Richard Henderson
On 5/4/20 4:36 PM, Joseph Myers wrote: > Joseph Myers (4): > softfloat: silence sNaN for conversions to/from floatx80 > softfloat: fix floatx80 pseudo-denormal addition / subtraction > softfloat: fix floatx80 pseudo-denormal comparisons > softfloat: fix floatx80 pseudo-denormal round to

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-05-05 Thread Rafael David Tinoco
Hello Ike, Please, let me know if you want me to go after the needed SRUs for this fix or if you will. I'll wait for the final feedback from tests with your PPA. Cheers! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH v1 5/9] hw/core: stream: Add an end-of-packet flag

2020-05-05 Thread Alistair Francis
On Thu, Apr 30, 2020 at 9:26 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Some stream clients stream an endless stream of data while > other clients stream data in packets. Stream interfaces > usually have a way to signal the end of a packet or the > last beat of a transfer. > >

Re: [PATCH v2 05/18] qom: Drop convenience method object_property_get_uint16List()

2020-05-05 Thread Paolo Bonzini
On 05/05/20 17:29, Markus Armbruster wrote: > qom/object.c provides object_property_get_TYPE() and > object_property_set_TYPE() for a number of common types. These are > all convenience wrappers around object_property_get_qobject() and > object_property_set_qobject(). > > Except for

[PATCH v5 01/31] qcow2: Make Qcow2AioTask store the full host offset

2020-05-05 Thread Alberto Garcia
The file_cluster_offset field of Qcow2AioTask stores a cluster-aligned host offset. In practice this is not very useful because all users(*) of this structure need the final host offset into the cluster, which they calculate using host_offset = file_cluster_offset + offset_into_cluster(s,

[PATCH v5 11/31] qcow2: Add offset_into_subcluster() and size_to_subclusters()

2020-05-05 Thread Alberto Garcia
Like offset_into_cluster() and size_to_clusters(), but for subclusters. Signed-off-by: Alberto Garcia --- block/qcow2.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/block/qcow2.h b/block/qcow2.h index e68febb15b..8b1ed1cbcf 100644 --- a/block/qcow2.h +++ b/block/qcow2.h @@

[PATCH v5 18/31] qcow2: Handle QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC

2020-05-05 Thread Alberto Garcia
When dealing with subcluster types there is a new value called QCOW2_SUBCLUSTER_UNALLOCATED_ALLOC that has no equivalent in QCow2ClusterType. This patch handles that value in all places where subcluster types are processed. Signed-off-by: Alberto Garcia Reviewed-by: Max Reitz Reviewed-by:

[PATCH v5 07/31] qcow2: Document the Extended L2 Entries feature

2020-05-05 Thread Alberto Garcia
Subcluster allocation in qcow2 is implemented by extending the existing L2 table entries and adding additional information to indicate the allocation status of each subcluster. This patch documents the changes to the qcow2 format and how they affect the calculation of the L2 cache size.

[PATCH v5 12/31] qcow2: Add l2_entry_size()

2020-05-05 Thread Alberto Garcia
qcow2 images with subclusters have 128-bit L2 entries. The first 64 bits contain the same information as traditional images and the last 64 bits form a bitmap with the status of each individual subcluster. Because of that we cannot assume that L2 entries are sizeof(uint64_t) anymore. This

[PATCH v5 20/31] qcow2: Add subcluster support to qcow2_get_host_offset()

2020-05-05 Thread Alberto Garcia
The logic of this function remains pretty much the same, except that it uses count_contiguous_subclusters(), which combines the logic of count_contiguous_clusters() / count_contiguous_clusters_unallocated() and checks individual subclusters. Signed-off-by: Alberto Garcia --- block/qcow2.h

[PATCH v5 16/31] qcow2: Add cluster type parameter to qcow2_get_host_offset()

2020-05-05 Thread Alberto Garcia
This function returns an integer that can be either an error code or a cluster type (a value from the QCow2ClusterType enum). We are going to start using subcluster types instead of cluster types in some functions so it's better to use the exact data types instead of integers for clarity and in

[PATCH v7] audio/jack: add JACK client audiodev

2020-05-05 Thread Geoffrey McRae
This commit adds a new audiodev backend to allow QEMU to use JACK as both an audio sink and source. Signed-off-by: Geoffrey McRae --- audio/Makefile.objs| 5 + audio/audio.c | 1 + audio/audio_template.h | 2 + audio/jackaudio.c | 677

Re: [PATCH v1 3/9] hw/net/xilinx_axienet: Remove unncessary cast

2020-05-05 Thread Alistair Francis
On Thu, Apr 30, 2020 at 9:28 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Remove unncessary cast, buf is already uint8_t *. > No functional change. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- > hw/net/xilinx_axienet.c | 2 +- > 1 file

Re: [PATCH v1 4/9] hw/dma/xilinx_axidma: Add DMA memory-region property

2020-05-05 Thread Alistair Francis
On Thu, Apr 30, 2020 at 9:29 AM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Add DMA memory-region property to externally control what > address-space this DMA operates on. > > Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Alistair > --- >

[PATCH v5 09/31] qcow2: Add subcluster-related fields to BDRVQcow2State

2020-05-05 Thread Alberto Garcia
This patch adds the following new fields to BDRVQcow2State: - subclusters_per_cluster: Number of subclusters in a cluster - subcluster_size: The size of each subcluster, in bytes - subcluster_bits: No. of bits so 1 << subcluster_bits = subcluster_size Images without subclusters are treated as if

[PATCH v5 29/31] qcow2: Assert that expand_zero_clusters_in_l1() does not support subclusters

2020-05-05 Thread Alberto Garcia
This function is only used by qcow2_expand_zero_clusters() to downgrade a qcow2 image to a previous version. It is however not possible to downgrade an image with extended L2 entries because older versions of qcow2 do not have this feature. Signed-off-by: Alberto Garcia ---

  1   2   3   4   >