Re: [PULL 0/7] bitmaps patches for 2020-05-18

On Mon, 18 May 2020 at 21:55, Eric Blake wrote: > > The following changes since commit a28c9c8c9fc42484efe1bf5a77affe842e54e38b: > > Merge remote-tracking branch > 'remotes/kraxel/tags/vga-20200518-pull-request' into staging (2020-05-18 > 16:37:09 +0100) > > are available in the Git

Re: [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices

On 5/19/20 1:42 PM, Philippe Mathieu-Daudé wrote: > On 5/19/20 7:45 AM, Markus Armbruster wrote: >> "Andrew Jeffery" writes: >> >>> On Mon, 18 May 2020, at 21:49, Cédric Le Goater wrote: On 5/18/20 7:03 AM, Markus Armbruster wrote: > These devices are optional, and controlled by

Re: [PATCH 17/24] pnv/psi: Correct the pnv-psi* devices not to be sysbus devices

On 5/18/20 7:04 AM, Markus Armbruster wrote: > pnv_chip_power8_instance_init() creates a "pnv-psi-POWER8" sysbus > device in a way that leaves it unplugged. > pnv_chip_power9_instance_init() and pnv_chip_power10_instance_init() > do the same for "pnv-psi-POWER9" and "pnv-psi-POWER10",

Re: [PATCH 16/24] ppc/pnv: Put "*-pnv-chip" and "pnv-xive" on the main system bus

On 5/18/20 7:04 AM, Markus Armbruster wrote: > pnv_init() creates "power10_v1.0-pnv-chip", "power8_v2.0-pnv-chip", > "power8e_v2.1-pnv-chip", "power8nvl_v1.0-pnv-chip", or > "power9_v2.0-pnv-chip" sysbus devices in a way that leaves them > unplugged. > > pnv_chip_power9_instance_init() creates a

Re: [PATCH 5/6] migration/qemu-file.c: Don't ratelimit a shutdown fd

On Mon, 18 May 2020 12:55:34 +0100 "Dr. David Alan Gilbert" wrote: > * Zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > > > This causes the migration thread to hang if we failover during > > > checkpoint. A > > > shutdown fd won't cause network traffic anyway. > > > > > > > I'm not

Re: [PATCH v2 3/8] s390/sclp: rework sclp boundary and length checks

On Mon, 18 May 2020 11:15:07 -0400 Collin Walling wrote: > On 5/18/20 4:50 AM, Janosch Frank wrote: > > On 5/16/20 12:20 AM, Collin Walling wrote: > >> Rework the SCLP boundary check to account for different SCLP commands > >> (eventually) allowing different boundary sizes. > >> > >> Move the

Re: [PATCH v3] docs/s390x: document vfio-ccw

On 18/05/2020 09.55, Cornelia Huck wrote: > Add a basic example for passing a dasd via vfio-ccw. > > Signed-off-by: Cornelia Huck > --- > > v2->v3: moved uuid generation (Thomas) > > --- > docs/system/s390x/vfio-ccw.rst | 77 ++ > docs/system/target-s390x.rst

[PATCH] io_uring: retry io_uring_submit() if it fails with errno=EINTR

As recently documented [1], io_uring_enter(2) syscall can return an error (errno=EINTR) if the operation was interrupted by a delivery of a signal before it could complete. This should happen when IORING_ENTER_GETEVENTS flag is used, for example during io_uring_submit_and_wait() or during

[PATCH v2] xen: fix build without pci passthrough

has_igd_gfx_passthru is only available when QEMU is built with CONFIG_XEN_PCI_PASSTHROUGH, and hence shouldn't be used in common code without checking if it's available. Fixes: 46472d82322d0 ('xen: convert "-machine igd-passthru" to an accelerator property') Signed-off-by: Roger Pau Monné ---

[PATCH 33/55] qom: Tidy up a few object_initialize_child() calls

The callers of object_initialize_child() commonly pass either , sizeof(child), or pchild, sizeof(*pchild). Tidy up the few that don't, mostly to keep the next commit simpler. Signed-off-by: Markus Armbruster --- hw/arm/aspeed.c | 2 +- hw/microblaze/xlnx-zynqmp-pmu.c | 3 +--

[PATCH 10/55] qdev: Convert uses of qdev_set_parent_bus() with Coccinelle

In addition to the qdev_create() patterns converted so far, we have a qdev_set_parent_bus() pattern. Mostly when we embed a device in a parent device rather than allocating it on the heap. This pattern also puts devices in the dangerous "no QOM parent, but plugged into bus" state I explained in

[PATCH 16/55] pci: pci_create(), pci_create_multifunction() are now unused, drop

Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Signed-off-by: Markus Armbruster --- include/hw/pci/pci.h | 3 --- hw/pci/pci.c | 16 2 files changed, 19 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 66f8ba519b..a4e9c33416 100644 ---

[PATCH 34/55] qom: Less verbose object_initialize_child()

All users of object_initialize_child() pass the obvious child size argument. Almost all pass _abort and no properties. Tiresome. Rename object_initialize_child() to object_initialize_child_with_props() to free the name. New convenience wrapper object_initialize_child() automates the size

[PATCH 43/55] sysbus: Convert to sysbus_realize() etc. with Coccinelle

Convert from qdev_realize(), qdev_realize_and_unref() with null @bus argument to sysbus_realize(), sysbus_realize_and_unref(). Coccinelle script: @@ expression dev, errp; @@ -qdev_realize(DEVICE(dev), NULL, errp); +sysbus_realize(SYS_BUS_DEVICE(dev), errp); @@

Re: [PATCH v2] target/arm: Allow user-mode code to write CPSR.E via MSR

On 5/18/20 7:28 AM, Peter Maydell wrote: > Using the MSR instruction to write to CPSR.E is deprecated, but it is > required to work from any mode including unprivileged code. We were > incorrectly forbidding usermode code from writing it because > CPSR_USER did not include the CPSR_E bit. > > We

Re: [PULL 0/7] bitmaps patches for 2020-05-18

On 5/19/20 7:42 AM, Peter Maydell wrote: On Mon, 18 May 2020 at 21:55, Eric Blake wrote: The following changes since commit a28c9c8c9fc42484efe1bf5a77affe842e54e38b: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20200518-pull-request' into staging (2020-05-18 16:37:09 +0100) are

Re: [PATCH v2] hw/display/edid: Add missing 'qdev-properties.h' header

On 5/18/20 10:45 AM, Philippe Mathieu-Daudé wrote: > When trying to consume the DEFINE_EDID_PROPERTIES() macro > by including "hw/display/edid.h", we get this build failure: > > include/hw/display/edid.h:24:5: error: implicit declaration of > function ‘DEFINE_PROP_UINT32’

Re: [PATCH 0/4] fuzz: misc changes for oss-fuzz compatability

ping? On 200511 2301, Alexander Bulekov wrote: > Hello, > With these patches, the fuzzer passes the oss-fuzz build checks. > There are also some miscelanous improvement to the fuzzer, in general: > * If building for oss-fuzz, check executable_dir/pc-bios for >the bios images > * Fix a typo

Re: [PATCH 10/10] softfloat: Return bool from all classification predicates

On 5/19/20 3:10 AM, Alex Bennée wrote: > > Richard Henderson writes: > >> This includes *_is_any_nan, *_is_neg, *_is_inf, etc. >> >> Signed-off-by: Richard Henderson > > Reviewed-by: Alex Bennée > > As an aside do you think we'll see any benefit from rolling up the > classifications with

Re: [RFC PATCH 0/3] block: Synchronous bdrv_*() from coroutine in different AioContext

On 5/19/20 10:48 AM, Vladimir Sementsov-Ogievskiy wrote: The other options is doing what you suggested. There is nothing in the qcow2 on-disk format that would prevent this, but we would have to extend the qcow2 driver to allow I/O to inactive L1 tables. This sounds like a non-trivial amount of

[PATCH] arm/aspeed: Rework NIC attachment

The AST2400 and AST2500 SoCs have two MACs but only the first MAC0 is active on the Aspeed machines using these SoCs. The AST2600 has four MACs. The AST2600 EVB machine activates MAC1, MAC2 and MAC3 and the Tacoma BMC machine activates MAC2. Introduce a bit-field property "macs-mask" under the

[PULL 07/10] softfloat: Inline float64 compare specializations

Replace the float64 compare specializations with inline functions that call the standard float64_compare{,_quiet} functions. Use bool as the return type. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/fpu/softfloat.h | 49 ++-- fpu/softfloat.c |

[PULL 09/10] softfloat: Inline floatx80 compare specializations

Replace the floatx80 compare specializations with inline functions that call the standard floatx80_compare{,_quiet} functions. Use bool as the return type. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/fpu/softfloat.h | 49 ++-- fpu/softfloat.c | 257

[PULL 10/10] softfloat: Return bool from all classification predicates

This includes *_is_any_nan, *_is_neg, *_is_inf, etc. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/fpu/softfloat.h| 66 +- fpu/softfloat-specialize.inc.c | 16 - 2 files changed, 41

Re: [PATCH v2 5/9] block/io: expand in_flight inc/dec section: simple cases

19.05.2020 17:33, Kevin Wolf wrote: Am 19.05.2020 um 16:01 hat Vladimir Sementsov-Ogievskiy geschrieben: 19.05.2020 14:25, Vladimir Sementsov-Ogievskiy wrote: 19.05.2020 14:16, Kevin Wolf wrote: Am 19.05.2020 um 13:06 hat Vladimir Sementsov-Ogievskiy geschrieben: 19.05.2020 13:52, Kevin Wolf

[PATCH v7 03/12] tests/vm: pass args through to BaseVM's __init__

Signed-off-by: Robert Foley --- tests/vm/basevm.py | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index a2d4054d72..fbefda0595 100644 --- a/tests/vm/basevm.py +++ b/tests/vm/basevm.py @@ -61,9 +61,9 @@ class

Re: [RFC PATCH 0/3] block: Synchronous bdrv_*() from coroutine in different AioContext

Am 19.05.2020 um 15:54 hat Denis Plotnikov geschrieben: > > > On 19.05.2020 15:32, Vladimir Sementsov-Ogievskiy wrote: > > 14.05.2020 17:26, Kevin Wolf wrote: > > > Am 14.05.2020 um 15:21 hat Thomas Lamprecht geschrieben: > > > > On 5/12/20 4:43 PM, Kevin Wolf wrote: > > > > > Stefan (Reiter),

[PATCH 04/55] qdev: Put qdev_new() to use with Coccinelle

Let's start simple and put qdev_new() to use. Coccinelle script: @ depends on !(file in "hw/core/qdev.c")@ expression type_name; @@ -DEVICE(object_new(type_name)) +qdev_new(type_name) Signed-off-by: Markus Armbruster --- hw/block/nand.c | 2 +- hw/misc/auxbus.c |

Re: [RFC] Various questions about TCG implementation, DRM patches dealing with pointers over guest-host barrier.

On 5/17/20 4:05 PM, Catherine A. Frederick wrote: > - I've been implementing an instruction scheduler(list scheduler, with > priority > given to most successors) for TCG and currently if I replace instructions in > s->ops(the TCG context) I get a crash later in tcg_reg_alloc_op, even if the >

[PATCH 11/55] qdev: Convert uses of qdev_set_parent_bus() manually

Same transformation as in the previous commit. Manual, because convincing Coccinelle to transform these cases is somewhere between not worthwhile and infeasible (at least for me). Signed-off-by: Markus Armbruster --- hw/pci-host/prep.c | 3 +-- hw/ppc/pnv.c | 6 ++ hw/s390x/sclp.c

[PATCH 32/55] auxbus: Eliminate aux_create_slave()

aux_create_slave() has become a trivial wrapper around qdev_new(). There's just one user. Eliminate. Signed-off-by: Markus Armbruster --- include/hw/misc/auxbus.h | 7 --- hw/display/xlnx_dp.c | 2 +- hw/misc/auxbus.c | 9 - 3 files changed, 1 insertion(+), 17

[PATCH 38/55] microbit: Tidy up sysbus_init_child_obj() @child argument

The callers of sysbus_init_child_obj() commonly pass either , sizeof(child), or pchild, sizeof(*pchild). Tidy up two that don't, mostly to keep future commits simpler. Signed-off-by: Markus Armbruster --- hw/arm/microbit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 23/55] ssi: Convert last use of ssi_create_slave_no_init() manually

Same transformation as in the previous commit. Manual, because convincing Coccinelle to transform this case is not worthwhile. Cc: Alistair Francis Signed-off-by: Markus Armbruster --- hw/ssi/ssi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ssi/ssi.c

[PATCH 28/55] usb: Eliminate usb_try_create_simple()

usb_try_create_simple() is qdev_try_new() and qdev_realize_and_unref() with more verbose error messages. Of its two users, one ignores errors, and the other asserts they are impossible. Make them use qdev_try_new() and qdev_realize_and_unref() directly, and eliminate usb_try_create_simple Cc:

[PATCH 15/55] pci: Convert uses of pci_create() etc. manually

Same transformation as in the previous commit. Manual, because convincing Coccinelle to transform these cases is not worthwhile. Cc: Michael S. Tsirkin Cc: Marcel Apfelbaum Signed-off-by: Markus Armbruster --- hw/sparc64/sun4u.c | 12 1 file changed, 8 insertions(+), 4

[PATCH 21/55] ssi: ssi_auto_connect_slaves() never does anything, drop

ssi_auto_connect_slaves(parent, cs_line, bus) iterates over @parent's QOM children @dev of type TYPE_SSI_SLAVE. It puts these on @bus, and sets cs_line[] to qdev_get_gpio_in_named(dev, SSI_GPIO_CS, 0). Suspicious: there is no protection against overrunning cs_line[]. Turns out it's safe because

[PATCH 35/55] macio: Convert use of qdev_set_parent_bus()

Convert qdev_set_parent_bus()/realize to qdev_realize(); recent commit "qdev: New qdev_new(), qdev_realize(), etc." explains why. Cc: Mark Cave-Ayland Cc: David Gibson Signed-off-by: Markus Armbruster --- hw/misc/macio/macio.c | 13 ++--- 1 file changed, 6 insertions(+), 7

[PATCH 22/55] ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle

Replace dev = ssi_create_slave_no_init(bus, type_name); ... qdev_init_nofail(dev); by dev = qdev_new(type_name); ... qdev_realize_and_unref(dev, bus, _fatal); Recent commit "qdev: New qdev_new(), qdev_realize(), etc." explains why. @@ type SSIBus;

[PATCH 53/55] qdev: Convert bus-less devices to qdev_realize() with Coccinelle

All remaining conversions to qdev_realize() are for bus-less devices. Coccinelle script: // only correct for bus-less @dev! @@ expression errp; expression dev; @@ -qdev_init_nofail(dev); +qdev_realize(dev, NULL, _fatal); @ depends on !(file in

Re: [PATCH RISU] arm.risu, thumb.risu: Add v8.2 DP and FHM insns

On 5/18/20 8:47 AM, Peter Maydell wrote: > Add coverage for the v8.2 DP and v8.2 FHM insns in the Neon extension > space. (We already had the v8.1 VQRDMLAH/VQRDLSH and the v8.3 > VCADD/VCMLA, so this brings the risu coverage into line with what > QEMU has implemented so far.) > > Signed-off-by:

Re: [RFC PATCH 0/3] block: Synchronous bdrv_*() from coroutine in different AioContext

19.05.2020 18:29, Kevin Wolf wrote: Am 19.05.2020 um 17:05 hat Denis Plotnikov geschrieben: On 19.05.2020 17:18, Kevin Wolf wrote: Am 19.05.2020 um 15:54 hat Denis Plotnikov geschrieben: On 19.05.2020 15:32, Vladimir Sementsov-Ogievskiy wrote: 14.05.2020 17:26, Kevin Wolf wrote: Am

[PULL 08/10] softfloat: Inline float128 compare specializations

Replace the float128 compare specializations with inline functions that call the standard float128_compare{,_quiet} functions. Use bool as the return type. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/fpu/softfloat.h | 49 +++-- fpu/softfloat.c | 238

[PULL 04/10] softfloat: Name rounding mode enum

Give the previously unnamed enum a typedef name. Use the packed attribute so that we do not affect the layout of the float_status struct. Use it in the prototypes of relevant functions. Adjust switch statements as necessary to avoid compiler warnings. Reviewed-by: Alex Bennée Reviewed-by:

[PULL 00/10] softfloat misc cleanups

The following changes since commit f2465433b43fb87766d79f42191607dac4aed5b4: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2020-05-19 13:42:58 +0100) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-fpu-20200519

Re: [PATCH Kernel v22 0/8] Add UAPIs to support migration for VFIO devices

Hi folks, My impression is that we're getting pretty close to a workable implementation here with v22 plus respins of patches 5, 6, and 8. We also have a matching QEMU series and a proposal for a new i40e consumer, as well as I assume GVT-g updates happening internally at Intel. I expect all of

Re: [RFC PATCH 0/3] block: Synchronous bdrv_*() from coroutine in different AioContext

On 19.05.2020 15:32, Vladimir Sementsov-Ogievskiy wrote: 14.05.2020 17:26, Kevin Wolf wrote: Am 14.05.2020 um 15:21 hat Thomas Lamprecht geschrieben: On 5/12/20 4:43 PM, Kevin Wolf wrote: Stefan (Reiter), after looking a bit closer at this, I think there is no bug in QEMU, but the bug is

Re: [PATCH] virtio-crypto: Convert DPRINTF to trace event

Hi, On 5/16/20 4:05 PM, teachk wrote: From: Hou Weiying Signed-off-by: Hou Weiying --- hw/virtio/trace-events| 12 hw/virtio/virtio-crypto.c | 26 ++ include/hw/virtio/virtio-crypto.h | 11 --- 3 files changed, 26

[PATCH 41/55] sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2

The callers of sysbus_init_child_obj() commonly pass either , sizeof(child), or pchild, sizeof(*pchild). Tidy up the few that use something else instead, mostly to keep future commits simpler. Coccinelle script: @@ expression parent, propname, type; expression child; type T;

[PATCH 36/55] macio: Eliminate macio_init_child_obj()

macio_init_child_obj() has become a trivial wrapper around object_initialize_child_with_props(). Eliminate it, since the general convenience wrapper object_initialize_child() is just as convenient already. Cc: Mark Cave-Ayland Cc: David Gibson Signed-off-by: Markus Armbruster ---

[PATCH 40/55] hw/arm/armsse: Pass correct child size to sysbus_init_child_obj()

armsse_init() initializes s->armv7m[i] for all i. It passes the size of the entire array instead of the array element to sysbus_init_child_obj(). Harmless, but fix it anyway. Signed-off-by: Markus Armbruster --- hw/arm/armsse.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PULL 05/10] softfloat: Name compare relation enum

Give the previously unnamed enum a typedef name. Use it in the prototypes of compare functions. Use it to hold the results of the compare functions. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/fpu/softfloat.h | 25

[PULL 03/10] softfloat: Change tininess_before_rounding to bool

Slightly tidies the usage within softfloat.c and the representation in float_status. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- include/fpu/softfloat-helpers.h | 8 ++--- include/fpu/softfloat-types.h | 8 ++--- fpu/softfloat.c | 54

[PATCH v7 02/12] tests/vm: pass --genisoimage to basevm script

From: Alex Bennée If we have an alternative to genisoimage we really need to tell the script about it as well so it can use it. It will still default to genisoimage in case it is run outside our build machinery. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by:

[PATCH v7 01/12] configure: add alternate binary for genisoimage

From: Alex Bennée Not all distros ship genisoimage which is a Debian fork from the original cdrtools. As the options are pretty much the same support it as a fallback binary. Signed-off-by: Alex Bennée Signed-off-by: Robert Foley --- configure | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v7 00/12] tests/vm: Add support for aarch64 VMs

This is version 7 of the patch series to add support for aarch64 VMs in the vm-build infrastructure. - Ubuntu 18.04 aarch64 VM - CentOS 8 aarch64 VM v6: https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg03134.html Changes in v7 - Made changes to the way we discover the efi image for

[PATCH v7 04/12] tests/vm: Add configuration to basevm.py

Added use of a configuration to tests/vm/basevm.py. The configuration provides parameters used to configure a VM. This allows for providing alternate configurations to the VM being created/launched. cpu, machine, memory, and NUMA configuration are all examples of configuration which we might want

[PATCH v7 10/12] tests/vm: Added a new script for centos.aarch64.

centos.aarch64 creates a CentOS 8 image. Also added a new kickstart script used to build the centos.aarch64 image. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include| 3 +- tests/vm/centos-8-aarch64.ks | 51 tests/vm/centos.aarch64 | 227

[PATCH v7 07/12] tests/vm: Add ability to select QEMU from current build.

Added a new special variable QEMU_LOCAL=1, which will indicate to take the QEMU binary from the current build. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov --- tests/vm/Makefile.include | 4 tests/vm/basevm.py| 25 ++--- 2 files changed, 26

[PATCH] io_uring: use io_uring_cq_ready() to check for ready cqes

In qemu_luring_poll_cb() we are not using the cqe peeked from the CQ ring. We are using io_uring_peek_cqe() only to see if there are cqes ready, so we can replace it with io_uring_cq_ready(). Signed-off-by: Stefano Garzarella --- block/io_uring.c | 9 +++-- 1 file changed, 3 insertions(+),

Re: [PATCH v2 5/9] block/io: expand in_flight inc/dec section: simple cases

19.05.2020 14:25, Vladimir Sementsov-Ogievskiy wrote: 19.05.2020 14:16, Kevin Wolf wrote: Am 19.05.2020 um 13:06 hat Vladimir Sementsov-Ogievskiy geschrieben: 19.05.2020 13:52, Kevin Wolf wrote: Am 06.05.2020 um 09:02 hat Vladimir Sementsov-Ogievskiy geschrieben: 27.04.2020 17:39, Vladimir

Re: [PATCH 5/6] migration/qemu-file.c: Don't ratelimit a shutdown fd

* Lukas Straub (lukasstra...@web.de) wrote: > On Mon, 18 May 2020 12:55:34 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: > > > > This causes the migration thread to hang if we failover during > > > > checkpoint. A > > > > shutdown fd won't

Re: Migration with ``drive-mirror`` + NBD will let quorum qcow2 image become larger

On Tue 19 May 2020 11:15:44 AM CEST, Kevin Wolf wrote: > But maybe it could return a limited set of flags at least so that the > mirror job can get the BDRV_BLOCK_ZERO information if the quorum > children agree on it. Yeah, maybe it is possible to implement a conservative version of that function

[PATCH 03/55] qdev: New qdev_new(), qdev_realize(), etc.

We commonly plug devices into their bus right when we create them, like this: dev = qdev_create(bus, type_name); Note that @dev is a weak reference. The reference from @bus to @dev is the only strong one. We realize at some later time, either with object_property_set_bool(OBJECT(dev),

[PATCH 52/55] qdev: Use qdev_realize() in qdev_device_add()

Signed-off-by: Markus Armbruster --- qdev-monitor.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index f3d907..249d9a2408 100644 --- a/qdev-monitor.c +++ b/qdev-monitor.c @@ -661,9 +661,7 @@ DeviceState *qdev_device_add(QemuOpts

[PATCH 37/55] sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls

OBJECT(child) expands to ((Object *)(child)). sysbus_init_child_obj() parameter @child is void *. Pass child instead of OBJECT(child). Signed-off-by: Markus Armbruster --- hw/arm/allwinner-a10.c | 4 ++-- hw/arm/aspeed_ast2600.c | 40 +---

Re: [PULL 0/8] Block patches

On Tue, 19 May 2020 at 09:01, Stefan Hajnoczi wrote: > > The following changes since commit 013a18edbbc59cdad019100c7d03c0494642b74c: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-2020051= > 4' into staging (2020-05-14 16:17:55 +0100) > > are available in the Git

Re: [PATCH Kernel v20 4/8] vfio iommu: Add ioctl definition for dirty pages tracking

On Tue, 19 May 2020 17:35:07 +0200 Cornelia Huck wrote: > On Fri, 15 May 2020 23:05:24 +0530 > Kirti Wankhede wrote: > > > On 5/15/2020 4:29 PM, Cornelia Huck wrote: > > > On Fri, 15 May 2020 02:07:43 +0530 > > > Kirti Wankhede wrote: > > > > > >> IOMMU container maintains a list of

[PATCH RISU 2/4] sve2.risu: Add patterns for integer multiply (unpredicated)

Signed-off-by: Stephen Long --- sve2.risu | 11 +++ 1 file changed, 11 insertions(+) diff --git a/sve2.risu b/sve2.risu index eb1d75a..ccdb19f 100755 --- a/sve2.risu +++ b/sve2.risu @@ -1,6 +1,17 @@ # Input file for risugen defining AArch64 SVE2 instructions .mode arm.aarch64 +#

[PATCH RISU 3/4] sve2.risu: Add patterns for integer (predicated) ops

Signed-off-by: Stephen Long --- sve2.risu | 55 +++ 1 file changed, 55 insertions(+) diff --git a/sve2.risu b/sve2.risu index ccdb19f..9e48e1e 100755 --- a/sve2.risu +++ b/sve2.risu @@ -12,6 +12,61 @@ PMULA64_V0100 size:2 1

[PULL v2 0/7] bitmaps patches for 2020-05-18

The following changes since commit f2465433b43fb87766d79f42191607dac4aed5b4: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2020-05-19 13:42:58 +0100) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git

[PULL v2 7/7] qemu-img: Add bitmap sub-command

Include actions for --add, --remove, --clear, --enable, --disable, and --merge (note that --clear is a bit of fluff, because the same can be accomplished by removing a bitmap and then adding a new one in its place, but it matches what QMP commands exist). Listing is omitted, because it does not

[PATCH v7 12/12] tests/vm: Add workaround to consume console

The ConsoleSocket object provides a socket interface which will consume all arriving characters on the socket, but will provide those chars via recv() as would a regular socket. This is a workaround we found was needed since there is a known issue where QEMU will hang waiting for console

[PATCH v7 11/12] tests/vm: change scripts to use self._config

This change converts existing scripts to using for example self.ROOT_PASS, to self._config['root_pass']. We made similar changes for GUEST_USER, and GUEST_PASS. This allows us also to remove the change in basevm.py, which adds __getattr__ for backwards compatibility. Signed-off-by: Robert Foley

[PATCH v7 08/12] tests/vm: allow wait_ssh() to specify command

This allows for waiting for completion of arbitrary commands. Signed-off-by: Robert Foley Reviewed-by: Peter Puhov Reviewed-by: Alex Bennée --- tests/vm/basevm.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/vm/basevm.py b/tests/vm/basevm.py index

Re: [PATCH v2 5/9] block/io: expand in_flight inc/dec section: simple cases

Am 19.05.2020 um 16:01 hat Vladimir Sementsov-Ogievskiy geschrieben: > 19.05.2020 14:25, Vladimir Sementsov-Ogievskiy wrote: > > 19.05.2020 14:16, Kevin Wolf wrote: > > > Am 19.05.2020 um 13:06 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > > 19.05.2020 13:52, Kevin Wolf wrote: > > > > > Am

[PATCH 02/55] qdev: Drop redundant bus realization

Realizing a device automatically realizes its buses, in device_set_realized(). Realizing them in realize methods is redundant, unless the methods themselves require them to be realized early. None do. Drop the redundant bus realiziations. Signed-off-by: Markus Armbruster ---

[PATCH 05/55] qdev: Convert to qbus_realize(), qbus_unrealize()

I'm going to convert device realization to qdev_realize() with the help of Coccinelle. Convert bus realization to qbus_realize() first, to get it out of Coccinelle's way. Readability improves. Signed-off-by: Markus Armbruster --- hw/core/qdev.c | 10 +++--- hw/pci/pci.c | 2 +- 2 files

[PATCH 01/55] qdev: Rename qbus_realize() to qbus_init()

qbus_realize() does not actually realize. Rename it to qbus_init(). Signed-off-by: Markus Armbruster --- hw/core/bus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/core/bus.c b/hw/core/bus.c index f42d64f34a..08c5eab24a 100644 --- a/hw/core/bus.c +++

[PATCH 19/55] isa: Convert uses of isa_create(), isa_try_create() manually

Same transformation as in the previous commit. Manual, because convincing Coccinelle to transform these cases is not worthwhile. Signed-off-by: Markus Armbruster --- include/hw/net/ne2000-isa.h | 5 +++-- hw/block/fdc.c | 4 ++-- hw/i386/pc.c| 4 ++-- hw/ppc/pnv.c

[PATCH 06/55] qdev: Convert to qdev_unrealize() with Coccinelle

For readability, and consistency with qbus_realize(). Coccinelle script: @ depends on !(file in "hw/core/qdev.c")@ typedef DeviceState; DeviceState *dev; symbol false, error_abort; @@ -object_property_set_bool(OBJECT(dev), false, "realized", _abort); +

[PATCH 39/55] sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1

The callers of sysbus_init_child_obj() commonly pass either , sizeof(child), or pchild, sizeof(*pchild). Tidy up the few that use sizeof(child_type) instead, mostly to keep future commits simpler. Coccinelle script: @@ expression parent, propname, type; type T; T child; @@

[PATCH 17/55] isa: New isa_new(), isa_realize_and_unref() etc.

I'm converting from qdev_create()/qdev_init_nofail() to qdev_new()/qdev_realize_and_unref(); recent commit "qdev: New qdev_new(), qdev_realize(), etc." explains why. ISA devices use qdev_create() through isa_create() and isa_try_create(). Provide isa_new(), isa_try_new(), and

[PATCH 12/55] pci: New pci_new(), pci_realize_and_unref() etc.

I'm converting from qdev_create()/qdev_init_nofail() to qdev_new()/qdev_realize_and_unref(); recent commit "qdev: New qdev_new(), qdev_realize(), etc." explains why. PCI devices use qdev_create() through pci_create() and pci_create_multifunction(). Provide pci_new(), pci_new_multifunction(), and

[PATCH 45/55] sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1

I'm converting from qdev_set_parent_bus()/realize to qdev_realize(); recent commit "qdev: Convert uses of qdev_set_parent_bus() with Coccinelle" explains why. sysbus_init_child_obj() is a wrapper around object_initialize_child_with_props() and qdev_set_parent_bus(). It passes no properties.

[PATCH 42/55] sysbus: New sysbus_realize(), sysbus_realize_and_unref()

Sysbus devices almost always plug into the main system bus. qdev_create() even has a convenience feature to make that easy: a null bus argument gets replaced by the main system bus. qdev_realize() and qdev_realize_and_unref() do the same. We can do better. Provide convenience wrappers around

Re: [PATCH v3] docs/s390x: document vfio-ccw

On Tue, 19 May 2020 15:19:21 +0200 Thomas Huth wrote: > On 18/05/2020 09.55, Cornelia Huck wrote: > > Add a basic example for passing a dasd via vfio-ccw. > > > > Signed-off-by: Cornelia Huck > > --- > > > > v2->v3: moved uuid generation (Thomas) > > > > --- > >

Re: [RFC PATCH 0/3] block: Synchronous bdrv_*() from coroutine in different AioContext

Am 19.05.2020 um 17:05 hat Denis Plotnikov geschrieben: > On 19.05.2020 17:18, Kevin Wolf wrote: > > Am 19.05.2020 um 15:54 hat Denis Plotnikov geschrieben: > > > > > > On 19.05.2020 15:32, Vladimir Sementsov-Ogievskiy wrote: > > > > 14.05.2020 17:26, Kevin Wolf wrote: > > > > > Am 14.05.2020 um

Re: [RISU v2 02/17] Unify master_fd and apprentice_fd to comm_fd

Richard Henderson writes: > Any one invocation cannot be both master and apprentice. > Let's use only one variable for the file descriptor. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [RISU v2 01/17] Use bool for tracing variables

Richard Henderson writes: > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée

Re: [PATCH v2] xen: fix build without pci passthrough

On Tue, May 19, 2020 at 04:31:01PM +0200, Roger Pau Monne wrote: > has_igd_gfx_passthru is only available when QEMU is built with > CONFIG_XEN_PCI_PASSTHROUGH, and hence shouldn't be used in common > code without checking if it's available. > > Fixes: 46472d82322d0 ('xen: convert "-machine

[PATCH RISU 4/4] sve2.risu: Add patterns for widening integer arithmetic

Signed-off-by: Stephen Long --- sve2.risu | 62 +++ 1 file changed, 62 insertions(+) diff --git a/sve2.risu b/sve2.risu index 9e48e1e..a4d5312 100755 --- a/sve2.risu +++ b/sve2.risu @@ -67,6 +67,68 @@ USQADD A64_V01000100 size:2 011

[PULL 02/10] softfloat: Replace flag with bool

We have had this on the to-do list for quite some time. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/fpu/softfloat-helpers.h | 14 +-- include/fpu/softfloat-macros.h | 24 ++-- include/fpu/softfloat-types.h | 14 +--

Re: [RISU v2 03/17] Hoist trace file opening

Richard Henderson writes: > We will want to share this code with --dump. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > risu.c | 37 + > 1 file changed, 17 insertions(+), 20 deletions(-) > > diff

[PULL 01/10] softfloat: Use post test for floatN_mul

The existing f{32,64}_addsub_post test, which checks for zero inputs, is identical to f{32,64}_mul_fast_test. Which means we can eliminate the fast_test/fast_op hooks in favor of reusing the same post hook. This means we have one fewer test along the fast path for multiply. Tested-by: Alex

Re: [PATCH v2 6/8] s390/sclp: add extended-length sccb support for kvm guest

On Mon, 18 May 2020 10:55:24 +0200 Janosch Frank wrote: > On 5/16/20 12:20 AM, Collin Walling wrote: > > As more features and facilities are added to the Read SCP Info (RSCPI) > > response, more space is required to store them. The space used to store > > these new features intrudes on the space

Re: [PATCH v3] block: make BlockConf.*_size properties 32-bit

Am 29.04.2020 um 11:18 hat Roman Kagan geschrieben: > Devices (virtio-blk, scsi, etc.) and the block layer are happy to use > 32-bit for logical_block_size, physical_block_size, and min_io_size. > However, the properties in BlockConf are defined as uint16_t limiting > the values to 32768. > >

[PATCH 09/55] qdev: Convert uses of qdev_create() manually

Same transformation as in the previous commit. Manual, because convincing Coccinelle to transform these cases is somewhere between not worthwhile and infeasible (at least for me). Signed-off-by: Markus Armbruster --- hw/arm/highbank.c | 6 +++--- hw/arm/sbsa-ref.c

[PATCH 20/55] isa: isa_create(), isa_try_create() are now unused, drop

Signed-off-by: Markus Armbruster --- include/hw/isa/isa.h | 2 -- hw/isa/isa-bus.c | 16 2 files changed, 18 deletions(-) diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h index 3b6215fafe..52b61eed88 100644 --- a/include/hw/isa/isa.h +++ b/include/hw/isa/isa.h @@

[PATCH 24/55] ssi: ssi_create_slave_no_init() is now unused, drop

Cc: Alistair Francis Signed-off-by: Markus Armbruster --- include/hw/ssi/ssi.h | 1 - hw/ssi/ssi.c | 5 - 2 files changed, 6 deletions(-) diff --git a/include/hw/ssi/ssi.h b/include/hw/ssi/ssi.h index 1725b13c32..93f2b8b0be 100644 --- a/include/hw/ssi/ssi.h +++

[PATCH 27/55] usb: usb_create() is now unused, drop

Cc: Gerd Hoffmann Signed-off-by: Markus Armbruster --- include/hw/usb.h | 1 - hw/usb/bus.c | 8 2 files changed, 9 deletions(-) diff --git a/include/hw/usb.h b/include/hw/usb.h index 86093d941a..817dcebbef 100644 --- a/include/hw/usb.h +++ b/include/hw/usb.h @@ -535,7 +535,6 @@

<    1   2   3   4   >