Re: [PATCH 5/6] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-06-11 Thread Cédric Le Goater
On 6/10/20 1:06 AM, Havard Skinnemoen wrote: > On Tue, Jun 9, 2020 at 12:24 AM Cédric Le Goater > wrote: > > On 5/21/20 9:21 PM, Havard Skinnemoen wrote: > > +void npcm7xx_write_secondary_boot(ARMCPU *cpu, const struct > arm_boot_info *info) > > +{ > > +   

[PATCH v3] fuzz: add oss-fuzz build-script

2020-06-11 Thread Alexander Bulekov
It is neater to keep this in the QEMU repo, since any change that requires an update to the oss-fuzz build configuration, can make the necessary changes in the same series. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Alexander Bulekov --- In v3 I tried to make this build outside the

Re: [PATCH for-5.1 V4 3/4] hw/mips: Add Loongson-3 machine support (with KVM)

2020-06-11 Thread Jiaxun Yang
在 2020/6/2 10:39, Huacai Chen 写道: Add Loongson-3 based machine support, it use i8259 as the interrupt controler and use GPEX as the pci controller. Currently it can only work with KVM, but we will add TCG support in future. We already have a full functional Linux kernel (based on Linux-5.4.x

RE: [RFC] hw: nios2: update interrupt_request when STATUS_PIE disabled

2020-06-11 Thread Wu, Wentong
HI Thomas, Thanks for the help, I updated the patch in the new thread https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg03103.html, hoping that follows QEMU's working style, Thanks again. BR, Wentong -Original Message- From: Thomas Huth Sent: Wednesday, June 10, 2020 9:29 PM

Re: [RFC PATCH 0/3] fuzz: add generic fuzzer

2020-06-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200611055651.13784-1-alx...@bu.edu/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200611055651.13784-1-alx...@bu.edu Subject: [RFC PATCH 0/3] fuzz: add generic fuzzer Type: series ===

[RFC PATCH 3/3] fuzz: Add callbacks for dma-access functions

2020-06-11 Thread Alexander Bulekov
Signed-off-by: Alexander Bulekov --- exec.c| 17 - include/exec/memory.h | 8 include/exec/memory_ldst_cached.inc.h | 9 + include/sysemu/dma.h | 5 - memory_ldst.inc.c |

[RFC PATCH 0/3] fuzz: add generic fuzzer

2020-06-11 Thread Alexander Bulekov
These patches add a generic fuzzer for virtual devices. This should allow us to fuzz devices that accept inputs over MMIO, PIO and DMA without any device-specific code. Example: QEMU_FUZZ_ARGS="-device virtio-net" \ FUZZ_REGION_WHITELIST="virtio pci-" \ ./i386-softmmu/qemu-fuzz-i386

[PATCH v8 09/10] acpi: drop build_piix4_pm()

2020-06-11 Thread Gerd Hoffmann
The _SB.PCI0.PX13.P13C opregion (holds isa device enable bits) is not used any more, remove it from DSDT. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedow --- hw/i386/acpi-build.c | 16 1 file changed, 16 deletions(-) diff --git a/hw/i386/acpi-build.c

[PATCH v8 06/10] acpi: factor out fw_cfg_add_acpi_dsdt()

2020-06-11 Thread Gerd Hoffmann
Add helper function to add fw_cfg device, also move code to hw/i386/fw_cfg.c. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov --- hw/i386/fw_cfg.h | 1 + hw/i386/acpi-build.c | 24 +--- hw/i386/fw_cfg.c | 28

[PATCH v8 00/10] acpi: i386 tweaks

2020-06-11 Thread Gerd Hoffmann
First batch of microvm patches, some generic acpi stuff. Split the acpi-build.c monster, specifically split the pc and q35 and pci bits into a separate file which we can skip building at some point in the future. v2 changes: leave acpi-build.c largely as-is, move useful bits to other places to

Re: [PATCH for-5.1 V4 3/4] hw/mips: Add Loongson-3 machine support (with KVM)

2020-06-11 Thread Huacai Chen
Hi, Jiaxun, On Thu, Jun 11, 2020 at 1:59 PM Jiaxun Yang wrote: > > > > 在 2020/6/2 10:39, Huacai Chen 写道: > > Add Loongson-3 based machine support, it use i8259 as the interrupt > > controler and use GPEX as the pci controller. Currently it can only > > work with KVM, but we will add TCG support

[PATCH v3 6/7] vga: build virtio-gpu only once

2020-06-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- hw/display/Makefile.objs | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/display/Makefile.objs b/hw/display/Makefile.objs index 76b3571e4902..d619594ad4d3

[PATCH v3 2/7] build: fix device module builds

2020-06-11 Thread Gerd Hoffmann
See comment. Feels quite hackish. Better ideas anyone? Signed-off-by: Gerd Hoffmann --- Makefile.target | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Makefile.target b/Makefile.target index 8ed1eba95b9c..c70325df5796 100644 --- a/Makefile.target +++ b/Makefile.target @@ -179,6

Re: [PATCH v8 02/10] acpi: move aml builder code for floppy device

2020-06-11 Thread Philippe Mathieu-Daudé
On 6/11/20 9:29 AM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé > --- > hw/block/fdc.c | 83 > hw/i386/acpi-build.c | 83 >

[PATCH v3 5/7] vga: build qxl as module

2020-06-11 Thread Gerd Hoffmann
First step in making spice support modular. Signed-off-by: Gerd Hoffmann --- hw/core/qdev.c | 2 ++ hw/Makefile.objs | 1 + hw/display/Makefile.objs | 5 - 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index

[PATCH v3 4/7] usb: build usb-redir as module

2020-06-11 Thread Gerd Hoffmann
Drops libusbredirparser.so dependency from core qemu. Signed-off-by: Gerd Hoffmann --- hw/core/qdev.c | 1 + hw/usb/Makefile.objs | 9 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index 0388efe2190b..676707e64191 100644 ---

[PATCH v3 7/7] vga: build virtio-gpu as module

2020-06-11 Thread Gerd Hoffmann
Drops libvirglrenderer.so dependency from core qemu. Signed-off-by: Gerd Hoffmann --- hw/core/qdev.c | 6 ++ hw/display/Makefile.objs | 23 +-- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/hw/core/qdev.c b/hw/core/qdev.c index

Re: [PATCH v8 10/10] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.

2020-06-11 Thread Michael S. Tsirkin
On Thu, Jun 11, 2020 at 10:31:01AM +0200, Philippe Mathieu-Daudé wrote: > On 6/11/20 10:27 AM, Philippe Mathieu-Daudé wrote: > > Hi Gerd, > > > > On 6/11/20 9:29 AM, Gerd Hoffmann wrote: > >> Seems to be unused. > >> > >> Signed-off-by: Gerd Hoffmann > >> Reviewed-by: Igor Mammedov > >> --- >

Re: [PATCH 1/1] MAINTAINERS: Adjust sh4 maintainership

2020-06-11 Thread Aleksandar Markovic
чет, 11. јун 2020. у 10:25 Thomas Huth је написао/ла: > > On 11/06/2020 00.17, Aleksandar Markovic wrote: > > This patch transfers sh4 sections to Yoshinori Sato, who is best > > positioned in the community to assume their maintainership. He is > > the maintainer of the related target rx. > > > >

Re: [PULL 4/6] target/mips: Add more CP0 register for save/restore

2020-06-11 Thread Aleksandar Markovic
чет, 11. јун 2020. у 11:50 Alex Bennée је написао/ла: > > > Aleksandar Markovic writes: > > > From: Huacai Chen > > > > Add more CP0 register for save/restore, including: EBase, XContext, > > PageGrain, PWBase, PWSize, PWField, PWCtl, Config*, KScratch1~KScratch6. > > > > Signed-off-by: Huacai

Re: [PATCH v8 1/4] Allow vu_message_read to be replaced

2020-06-11 Thread Stefan Hajnoczi
On Fri, Jun 05, 2020 at 07:35:35AM +0800, Coiby Xu wrote: > Allow vu_message_read to be replaced by one which will make use of the > QIOChannel functions. Thus reading vhost-user message won't stall the > guest. > > Signed-off-by: Coiby Xu > --- > contrib/libvhost-user/libvhost-user-glib.c | 2

Re: [PATCH] hw/m68k/mcf5206: Replace remaining hw_error()s by qemu_log_mask()

2020-06-11 Thread Laurent Vivier
Le 11/06/2020 à 07:58, Thomas Huth a écrit : > hw_error() dumps the CPU state and exits QEMU. This is ok during initial > code development (to see where the guest code is currently executing), > but it is certainly not the desired behavior that we want to present to > normal users, and it can also

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-06-11 Thread Andrew Cloke
** Changed in: kunpeng920/ubuntu-18.04 Status: In Progress => Fix Committed ** Changed in: kunpeng920/ubuntu-18.04-hwe Status: In Progress => Fix Committed ** Changed in: kunpeng920/ubuntu-19.10 Status: In Progress => Fix Committed ** Changed in: kunpeng920/ubuntu-20.04

Re: [PATCH 2/2] qcow2: improve savevm performance

2020-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 11:25, Denis V. Lunev wrote: On 6/11/20 11:04 AM, Vladimir Sementsov-Ogievskiy wrote: 10.06.2020 22:00, Denis V. Lunev wrote: This patch does 2 standard basic things: - it creates intermediate buffer for all writes from QEMU migration code    to QCOW2 image, - this buffer is sent

[PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Greg Kurz
We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as recommanded in the "qapi/error.h" header file. Since spapr_caps_apply() passes _fatal, all functions must also call the ERRP_AUTO_PROPAGATE() macro for error_append_hint() to be functional.

[PATCH v2 1/3] error: auto propagated local_err

2020-06-11 Thread Greg Kurz
From: Vladimir Sementsov-Ogievskiy Introduce a new ERRP_AUTO_PROPAGATE macro, to be used at start of functions with an errp OUT parameter. It has three goals: 1. Fix issue with error_fatal and error_prepend/error_append_hint: user can't see this additional information, because exit() happens

[PATCH v2 0/3] spapr: Improve error reporting in spapr_caps.c

2020-06-11 Thread Greg Kurz
Spapr capabilities are checked at machine init. If a capability cannot be used, an error message is printed and QEMU exits. In most places, the error message also contains an hint for the user. But we should use error_append_hint() for that, as explained in the "qapi/error.h" header. This is

[PATCH v2 3/3] spapr: Forbid nested KVM-HV in pre-power9 compat mode

2020-06-11 Thread Greg Kurz
Nested KVM-HV only works on POWER9. Signed-off-by: Greg Kurz --- hw/ppc/spapr_caps.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c index 2cb7ba8f005a..e86a7c350444 100644 --- a/hw/ppc/spapr_caps.c +++ b/hw/ppc/spapr_caps.c @@ -409,6

Re: [PATCH v8 01/10] qtest: allow DSDT acpi table changes

2020-06-11 Thread Michael S. Tsirkin
On Thu, Jun 11, 2020 at 09:29:10AM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann OK, thanks! What is still missing is resulting ASL differences in the expected files for reviewers. See ./tests/qtest/bios-tables-test.c step 7. I'm working on a tool that will show the changes more

[PATCH v2 0/1] Resolution of sh4 maintainership

2020-06-11 Thread Aleksandar Markovic
This series consists of a single patch that introduces a new maintainer for sh4 target. He may or may not adjust further the details of sh4 sections, with recent discussions in mind. The central idea of this series is that noone imposes his/hers particular vision on the new maintainer person,

[PATCH v2 1/1] MAINTAINERS: Adjust sh4 maintainership

2020-06-11 Thread Aleksandar Markovic
This patch transfers sh4 sections to Yoshinori Sato, who is best positioned in the community to assume sh4 maintainership. He is the maintainer of the related target rx as well, which means that some synergy between the two targets can be expected in future. Further adjustments, reorganizations,

Re: [PULL 4/6] target/mips: Add more CP0 register for save/restore

2020-06-11 Thread Alex Bennée
Aleksandar Markovic writes: > From: Huacai Chen > > Add more CP0 register for save/restore, including: EBase, XContext, > PageGrain, PWBase, PWSize, PWField, PWCtl, Config*, KScratch1~KScratch6. > > Signed-off-by: Huacai Chen > Co-developed-by: Jiaxun Yang > Reviewed-by: Aleksandar Markovic

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 13:39, Greg Kurz wrote: On Thu, 11 Jun 2020 13:21:51 +0300 Vladimir Sementsov-Ogievskiy wrote: 11.06.2020 13:13, Greg Kurz wrote: On Thu, 11 Jun 2020 11:50:57 +0200 Laurent Vivier wrote: On 11/06/2020 11:10, Greg Kurz wrote: We have a dedicated error API for hints. Use it

Re: [PATCH v3] fuzz: add oss-fuzz build-script

2020-06-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200611061355.31967-1-alx...@bu.edu/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200611061355.31967-1-alx...@bu.edu Subject: [PATCH v3] fuzz: add oss-fuzz build-script Type: series ===

Re: [PATCH v2 3/3] spapr: Forbid nested KVM-HV in pre-power9 compat mode

2020-06-11 Thread Laurent Vivier
On 11/06/2020 11:10, Greg Kurz wrote: > Nested KVM-HV only works on POWER9. > > Signed-off-by: Greg Kurz > --- > hw/ppc/spapr_caps.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c > index 2cb7ba8f005a..e86a7c350444 100644 > ---

Re: [PATCH v2 1/1] MAINTAINERS: Adjust sh4 maintainership

2020-06-11 Thread Aleksandar Markovic
чет, 11. јун 2020. у 11:52 Thomas Huth је написао/ла: > > On 11/06/2020 11.40, Aleksandar Markovic wrote: > > This patch transfers sh4 sections to Yoshinori Sato, who is > > best positioned in the community to assume sh4 maintainership. > > He is the maintainer of the related target rx as well,

[Bug 1883083] [NEW] QEMU: block/vvfat driver issues

2020-06-11 Thread P J P
Public bug reported: Nathan Huckleberry has reported following issues in the block/vvfat driver for the virtual VFAT file system image, used to share a host system directory with a guest VM. Please note: -> https://www.qemu.org/docs/master/system/images.html#virtual-fat-disk-images Virtual

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Greg Kurz
On Thu, 11 Jun 2020 13:21:51 +0300 Vladimir Sementsov-Ogievskiy wrote: > 11.06.2020 13:13, Greg Kurz wrote: > > On Thu, 11 Jun 2020 11:50:57 +0200 > > Laurent Vivier wrote: > > > >> On 11/06/2020 11:10, Greg Kurz wrote: > >>> We have a dedicated error API for hints. Use it instead of embedding

Re: [PULL 4/6] target/mips: Add more CP0 register for save/restore

2020-06-11 Thread Aleksandar Markovic
чет, 11. јун 2020. у 11:50 Alex Bennée је написао/ла: > > > Aleksandar Markovic writes: > > > From: Huacai Chen > > > > Add more CP0 register for save/restore, including: EBase, XContext, > > PageGrain, PWBase, PWSize, PWField, PWCtl, Config*, KScratch1~KScratch6. > > > > Signed-off-by: Huacai

Re: Clarification regarding new qemu-img convert --target-is-zero flag

2020-06-11 Thread David Edmondson
On Wednesday, 2020-06-10 at 11:21:27 -05, Eric Blake wrote: > On 6/10/20 10:57 AM, David Edmondson wrote: >> On Wednesday, 2020-06-10 at 10:48:52 -05, Eric Blake wrote: >> >>> On 6/10/20 10:42 AM, David Edmondson wrote: On Wednesday, 2020-06-10 at 18:29:33 +03, Sam Eiderman wrote:

[PATCH] block/aio_task: allow start/wait task from any coroutine

2020-06-11 Thread Vladimir Sementsov-Ogievskiy
Currently, aio task pool assumes that there is a main coroutine, which creates tasks and wait for them. Let's remove the restriction by using CoQueue. Code becomes clearer, interface more obvious. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi! Here is my counter-propasal for "[PATCH 1/2]

Re: [RFC v3 1/8] net: introduce qemu_get_peer

2020-06-11 Thread Laurent Vivier
On 29/05/2020 16:06, Cindy Lu wrote: > This is a small function that can get the peer from given NetClientState and > queue_index > > Signed-off-by: Cindy Lu > --- > include/net/net.h | 1 + > net/net.c | 6 ++ > 2 files changed, 7 insertions(+) > > diff --git a/include/net/net.h

Re: [PATCH v8 09/10] acpi: drop build_piix4_pm()

2020-06-11 Thread Philippe Mathieu-Daudé
On 6/11/20 9:29 AM, Gerd Hoffmann wrote: > The _SB.PCI0.PX13.P13C opregion (holds isa device enable bits) > is not used any more, remove it from DSDT. Maybe: "is not used any more (see previous commit), remove it from DSDT." (if Michael can do the change when applying if you agree).

Re: [PATCH v2 1/3] error: auto propagated local_err

2020-06-11 Thread Laurent Vivier
On 11/06/2020 11:09, Greg Kurz wrote: > From: Vladimir Sementsov-Ogievskiy > > Introduce a new ERRP_AUTO_PROPAGATE macro, to be used at start of > functions with an errp OUT parameter. > > It has three goals: > > 1. Fix issue with error_fatal and error_prepend/error_append_hint: user > can't

Re: [PATCH 5/6] hw/arm: Add NPCM730 and NPCM750 SoC models

2020-06-11 Thread Peter Maydell
On Thu, 11 Jun 2020 at 07:12, Cédric Le Goater wrote: > Some don't some do. This is a bit confusing. Probably the usual thing of people not noticing that they need to do something for big-endian hosts and nobody testing the minor platforms there. > Peter, should we fix the boards not doing the

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Laurent Vivier
On 11/06/2020 11:10, Greg Kurz wrote: > We have a dedicated error API for hints. Use it instead of embedding > the hint in the error message, as recommanded in the "qapi/error.h" > header file. > > Since spapr_caps_apply() passes _fatal, all functions must > also call the ERRP_AUTO_PROPAGATE()

Re: [PATCH v2 1/1] MAINTAINERS: Adjust sh4 maintainership

2020-06-11 Thread Thomas Huth
On 11/06/2020 11.40, Aleksandar Markovic wrote: > This patch transfers sh4 sections to Yoshinori Sato, who is > best positioned in the community to assume sh4 maintainership. > He is the maintainer of the related target rx as well, which > means that some synergy between the two targets can be

Re: [PATCH v3] fuzz: add oss-fuzz build-script

2020-06-11 Thread Darren Kenny
Hi Alex, On Thursday, 2020-06-11 at 02:13:55 -04, Alexander Bulekov wrote: > It is neater to keep this in the QEMU repo, since any change that > requires an update to the oss-fuzz build configuration, can make the > necessary changes in the same series. > > Suggested-by: Philippe Mathieu-Daudé >

[PATCH v8 07/10] acpi: simplify build_isa_devices_aml()

2020-06-11 Thread Gerd Hoffmann
x86 machines can have a single ISA bus only. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/acpi-build.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c

[PATCH v8 01/10] qtest: allow DSDT acpi table changes

2020-06-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8bf4..6a052c50447a 100644 ---

[PATCH v8 04/10] floppy: move cmos_get_fd_drive_type() from pc

2020-06-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Acked-by: John Snow --- include/hw/block/fdc.h | 1 + include/hw/i386/pc.h | 1 - hw/block/fdc.c | 26 +- hw/i386/pc.c | 25 - 4 files changed, 26

[PATCH v8 05/10] acpi: move aml builder code for i8042 (kbd+mouse) device

2020-06-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov --- hw/i386/acpi-build.c | 39 --- hw/input/pckbd.c | 31 +++ 2 files changed, 31 insertions(+), 39 deletions(-) diff --git

Re: [PATCH] iotests: Add copyright line in qcow2.py

2020-06-11 Thread Stefan Hajnoczi
On Tue, Jun 09, 2020 at 03:59:44PM -0500, Eric Blake wrote: > The file qcow2.py was originally contributed in 2012 by Kevin Wolf, > but was not given traditional boilerplate headers at the time. The > missing license was just rectified (commit 16306a7b39) using the > project-default GPLv2+, but

Re: Core dump happened when starting a VM on arm64 server

2020-06-11 Thread Andrew Jones
On Thu, Jun 11, 2020 at 04:46:45PM +0800, Haibo Xu wrote: > Hi, > > I met a qemu core dump issue when starting a VM with cpu feature > "pmu=on" on an arm server. > The commands to start the machine is: > > ./qemu-system-aarch64 \ >-cpu host,pmu=on -M virt,accel=kvm,gic-version=3

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 12:10, Greg Kurz wrote: We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as recommanded in the "qapi/error.h" header file. Since spapr_caps_apply() passes _fatal, all functions must also call the ERRP_AUTO_PROPAGATE() macro for

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Greg Kurz
On Thu, 11 Jun 2020 13:42:48 +0300 Vladimir Sementsov-Ogievskiy wrote: > 11.06.2020 13:21, Vladimir Sementsov-Ogievskiy wrote: > > 11.06.2020 13:13, Greg Kurz wrote: > >> On Thu, 11 Jun 2020 11:50:57 +0200 > >> Laurent Vivier wrote: > >> > >>> On 11/06/2020 11:10, Greg Kurz wrote: > We

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 13:21, Vladimir Sementsov-Ogievskiy wrote: 11.06.2020 13:13, Greg Kurz wrote: On Thu, 11 Jun 2020 11:50:57 +0200 Laurent Vivier wrote: On 11/06/2020 11:10, Greg Kurz wrote: We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as

Re: [PATCH v3 05/11] MAINTAINERS: Add an entry for common Renesas peripherals

2020-06-11 Thread Thomas Huth
On 11/06/2020 00.08, Philippe Mathieu-Daudé wrote: > Renesas peripherals are common to SH4/RX based MCUs. Their > datasheets share common sections. It makes sense to maintain > them altogether. The current names are misleading (see the > 'sh' prefix). This will be fixed later when RX peripherals >

[PATCH v8 02/10] acpi: move aml builder code for floppy device

2020-06-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- hw/block/fdc.c | 83 hw/i386/acpi-build.c | 83 stubs/cmos.c | 7 stubs/Makefile.objs | 1 + 4 files changed, 91

Re: [PATCH v8 10/10] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.

2020-06-11 Thread Philippe Mathieu-Daudé
On 6/11/20 10:27 AM, Philippe Mathieu-Daudé wrote: > Hi Gerd, > > On 6/11/20 9:29 AM, Gerd Hoffmann wrote: >> Seems to be unused. >> >> Signed-off-by: Gerd Hoffmann >> Reviewed-by: Igor Mammedov >> --- >> hw/i386/acpi-build.c | 11 --- >> 1 file changed, 11 deletions(-) >> >> diff

[Bug 1882851] Re: QEMU video freezes with "Guest disabled display" (virtio driver)

2020-06-11 Thread Gerd Hoffmann
Hmm, happens with xorg only. Wayland behaves as expected (any mouse/kbd event wakes up the screen). Which pretty much implies this is a guest bug. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[PATCH v3 0/1] Resolution of sh4 maintainership

2020-06-11 Thread Aleksandar Markovic
This series consists of a single patch that introduces a new maintainer for sh4 target. He may or may not adjust further the details of sh4 sections, with recent discussions in mind. The central idea of this series is that noone imposes his/hers particular vision on the new maintainer person,

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Greg Kurz
On Thu, 11 Jun 2020 11:50:57 +0200 Laurent Vivier wrote: > On 11/06/2020 11:10, Greg Kurz wrote: > > We have a dedicated error API for hints. Use it instead of embedding > > the hint in the error message, as recommanded in the "qapi/error.h" > > header file. > > > > Since spapr_caps_apply()

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 13:21, Vladimir Sementsov-Ogievskiy wrote: 11.06.2020 13:13, Greg Kurz wrote: On Thu, 11 Jun 2020 11:50:57 +0200 Laurent Vivier wrote: On 11/06/2020 11:10, Greg Kurz wrote: We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as

[PATCH v8 03/10] floppy: make isa_fdc_get_drive_max_chs static

2020-06-11 Thread Gerd Hoffmann
acpi aml generator needs this, but it is in floppy code now so we can make the function static. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Acked-by: John Snow --- include/hw/block/fdc.h | 2 -- hw/block/fdc.c | 4 ++-- 2 files changed,

[PATCH v8 08/10] acpi: drop serial/parallel enable bits from dsdt

2020-06-11 Thread Gerd Hoffmann
The _STA methods for COM+LPT used to reference them, but that isn't the case any more. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- hw/i386/acpi-build.c | 23 --- 1 file changed, 23 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index

Re: [PATCH 2/2] qcow2: improve savevm performance

2020-06-11 Thread Vladimir Sementsov-Ogievskiy
10.06.2020 22:00, Denis V. Lunev wrote: This patch does 2 standard basic things: - it creates intermediate buffer for all writes from QEMU migration code to QCOW2 image, - this buffer is sent to disk asynchronously, allowing several writes to run in parallel. In general, migration code is

Re: [PATCH 2/2] qcow2: improve savevm performance

2020-06-11 Thread Denis V. Lunev
On 6/11/20 11:04 AM, Vladimir Sementsov-Ogievskiy wrote: > 10.06.2020 22:00, Denis V. Lunev wrote: >> This patch does 2 standard basic things: >> - it creates intermediate buffer for all writes from QEMU migration code >>    to QCOW2 image, >> - this buffer is sent to disk asynchronously, allowing

Re: [PATCH v8 10/10] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.

2020-06-11 Thread Philippe Mathieu-Daudé
Hi Gerd, On 6/11/20 9:29 AM, Gerd Hoffmann wrote: > Seems to be unused. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 11 --- > 1 file changed, 11 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index

Re: [PATCH 1/1] MAINTAINERS: Adjust sh4 maintainership

2020-06-11 Thread Thomas Huth
On 11/06/2020 00.17, Aleksandar Markovic wrote: > This patch transfers sh4 sections to Yoshinori Sato, who is best > positioned in the community to assume their maintainership. He is > the maintainer of the related target rx. > > Further adjustments, reorganizations, and improvements of sh4 >

Re: [PATCH V2] virtio-pci: fix queue_enable write

2020-06-11 Thread Stefan Hajnoczi
On Wed, Jun 10, 2020 at 01:43:51PM +0800, Jason Wang wrote: > Spec said: The driver uses this to selectively prevent the device from > executing requests from this virtqueue. 1 - enabled; 0 - disabled. > > Though write 0 to queue_enable is forbidden by the spec, we should not > assume that the

Re: [PATCH for-5.1 V4 3/4] hw/mips: Add Loongson-3 machine support (with KVM)

2020-06-11 Thread Aleksandar Markovic
> >>> +int fd = 0, freq = 0; > >>> +char buf[1024], *buf_p; 1024 should have been defined via preprocessor constant > >>> + > >>> +fd = open("/proc/cpuinfo", O_RDONLY); > >>> +if (fd == -1) { > >>> +fprintf(stderr, "Failed to open /proc/cpuinfo!\n"); > >>> +return

Re: [PATCH v8 10/10] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.

2020-06-11 Thread Philippe Mathieu-Daudé
On 6/11/20 11:12 AM, Michael S. Tsirkin wrote: > On Thu, Jun 11, 2020 at 10:31:01AM +0200, Philippe Mathieu-Daudé wrote: >> On 6/11/20 10:27 AM, Philippe Mathieu-Daudé wrote: >>> Hi Gerd, >>> >>> On 6/11/20 9:29 AM, Gerd Hoffmann wrote: Seems to be unused. Signed-off-by: Gerd

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 13:13, Greg Kurz wrote: On Thu, 11 Jun 2020 11:50:57 +0200 Laurent Vivier wrote: On 11/06/2020 11:10, Greg Kurz wrote: We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as recommanded in the "qapi/error.h" header file. Since

[Bug 1882851] Re: QEMU video freezes with "Guest disabled display" (virtio driver)

2020-06-11 Thread Diego Viola
> Hmm, happens with xorg only. Nope, I can reproduce it with sway as well (which is another Wayland compositor). To reproduce it with sway, just do: swaymsg "output * dpms off" and then should you see "Guest disabled display", at that point I'm unable to get back image. I tried the sendkey

[Bug 1882851] Re: QEMU video freezes with "Guest disabled display" (virtio driver)

2020-06-11 Thread Diego Viola
I can't wake up the screen after hitting keys or moving the mouse after turning off the screen with sway. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1882851 Title: QEMU video freezes with

Re: [PATCH] hw/m68k/mcf5206: Replace remaining hw_error()s by qemu_log_mask()

2020-06-11 Thread Philippe Mathieu-Daudé
On 6/11/20 7:58 AM, Thomas Huth wrote: > hw_error() dumps the CPU state and exits QEMU. This is ok during initial > code development (to see where the guest code is currently executing), > but it is certainly not the desired behavior that we want to present to > normal users, and it can also cause

[PATCH v8 10/10] acpi: q35: drop _SB.PCI0.ISA.LPCD opregion.

2020-06-11 Thread Gerd Hoffmann
Seems to be unused. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- hw/i386/acpi-build.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 02cf4199c2e9..d93ea40c58b9 100644 --- a/hw/i386/acpi-build.c +++

Re: [PATCH v3 05/11] MAINTAINERS: Add an entry for common Renesas peripherals

2020-06-11 Thread Philippe Mathieu-Daudé
On 6/11/20 9:38 AM, Thomas Huth wrote: > On 11/06/2020 00.08, Philippe Mathieu-Daudé wrote: >> Renesas peripherals are common to SH4/RX based MCUs. Their >> datasheets share common sections. It makes sense to maintain >> them altogether. The current names are misleading (see the >> 'sh' prefix).

Re: [PATCH for-5.1 V4 3/4] hw/mips: Add Loongson-3 machine support (with KVM)

2020-06-11 Thread Jiaxun Yang
在 2020/6/11 15:49, Huacai Chen 写道: Hi, Jiaxun, On Thu, Jun 11, 2020 at 1:59 PM Jiaxun Yang wrote: 在 2020/6/2 10:39, Huacai Chen 写道: Add Loongson-3 based machine support, it use i8259 as the interrupt controler and use GPEX as the pci controller. Currently it can only work with KVM, but

[PATCH v3 3/7] ccid: build smartcard as module

2020-06-11 Thread Gerd Hoffmann
Drops libcacard.so dependency from core qemu. Signed-off-by: Gerd Hoffmann --- Makefile.objs| 1 + hw/core/qdev.c | 2 ++ hw/Makefile.objs | 1 + hw/usb/Makefile.objs | 4 +++- 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/Makefile.objs b/Makefile.objs index

[PATCH v3 1/7] qdev: add support for device module loading

2020-06-11 Thread Gerd Hoffmann
When compiling devices as modules we'll need some infrastrtucture to actually load those modules if needed. This patch adds it. Signed-off-by: Gerd Hoffmann --- include/hw/qdev-core.h | 3 +++ include/qemu/module.h | 1 + hw/core/qdev.c | 50

[PATCH v3 0/7] build some devices as modules.

2020-06-11 Thread Gerd Hoffmann
Specifically devices which depend on shared libraries, to reduce the runtime dependencies of core qemu. v2: - better commit messages. - add some more devices. - general tidy up. v3: - rebase, solve stubs conflict. - fix -vga $name - fix -device $name,help Gerd Hoffmann (7): qdev: add

Re: [PATCH 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Greg Kurz
On Wed, 10 Jun 2020 21:03:15 +0300 Vladimir Sementsov-Ogievskiy wrote: > 10.06.2020 20:17, Greg Kurz wrote: > > We have a dedicated error API for hints. Use it instead of embedding > > the hint in the error message, as recommanded in the "qapi/error.h" > > header file. > > > > Since

[PATCH v3 1/1] MAINTAINERS: Adjust sh4 maintainership

2020-06-11 Thread Aleksandar Markovic
This patch transfers sh4 sections to Yoshinori Sato, who is best positioned in the community to assume sh4 maintainership. He is the maintainer of the related target rx as well, which means that some synergy between the two targets can be expected in future. Further adjustments, reorganizations,

Re: [PULL 00/17] testing and misc fixes

2020-06-11 Thread Peter Maydell
On Tue, 9 Jun 2020 at 11:38, Alex Bennée wrote: > > The following changes since commit 49ee11555262a256afec592dfed7c5902d5eefd2: > > Merge remote-tracking branch > 'remotes/vivier2/tags/linux-user-for-5.1-pull-request' into staging > (2020-06-08 11:04:57 +0100) > > are available in the Git

Re: [PATCH v2 2/3] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Vladimir Sementsov-Ogievskiy
11.06.2020 13:44, Vladimir Sementsov-Ogievskiy wrote: 11.06.2020 13:39, Greg Kurz wrote: On Thu, 11 Jun 2020 13:21:51 +0300 Vladimir Sementsov-Ogievskiy wrote: 11.06.2020 13:13, Greg Kurz wrote: On Thu, 11 Jun 2020 11:50:57 +0200 Laurent Vivier wrote: On 11/06/2020 11:10, Greg Kurz

Re: [PATCH v3 1/1] MAINTAINERS: Adjust sh4 maintainership

2020-06-11 Thread Thomas Huth
On 11/06/2020 11.53, Aleksandar Markovic wrote: > This patch transfers sh4 sections to Yoshinori Sato, who is > best positioned in the community to assume sh4 maintainership. > He is the maintainer of the related target rx as well, which > means that some synergy between the two targets can be

[PATCH 2/2] hmp: Add 'openfd' command

2020-06-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Wire up the hmp 'openfd' to open a file and add it to the monitor's fd stash. Example usage: (qemu) openfd mig "my.mig" (qemu) migrate -d "fd:mig" Signed-off-by: Dr. David Alan Gilbert --- hmp-commands.hx| 16 +++- include/monitor/hmp.h |

[PATCH 0/2] monitor openfd commands

2020-06-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The monitors currently have a 'getfd' command that lets you pass an fd via the monitor socket. 'openfd' is a new command that opens a file and puts the fd in the same fd pool. The file is opened RW and created if it doesn't exist. It makes it easy to test

[RFC v6 20/25] intel_iommu: do not pass down pasid bind for PASID #0

2020-06-11 Thread Liu Yi L
RID_PASID field was introduced in VT-d 3.0 spec, it is used for DMA requests w/o PASID in scalable mode VT-d. It is also known as IOVA. And in VT-d 3.1 spec, there is definition on it: "Implementations not supporting RID_PASID capability (ECAP_REG.RPS is 0b), use a PASID value of 0 to perform

[RFC v6 03/25] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps

2020-06-11 Thread Liu Yi L
This patch modifies pci_setup_iommu() to set PCIIOMMUOps instead of setting PCIIOMMUFunc. PCIIOMMUFunc is used to get an address space for a PCI device in vendor specific way. The PCIIOMMUOps still offers this functionality. But using PCIIOMMUOps leaves space to add more iommu related vendor

[RFC v6 14/25] intel_iommu: process PASID cache invalidation

2020-06-11 Thread Liu Yi L
This patch adds PASID cache invalidation handling. When guest enabled PASID usages (e.g. SVA), guest software should issue a proper PASID cache invalidation when caching-mode is exposed. This patch only adds the draft handling of pasid cache invalidation. Detailed handling will be added in

[RFC v6 18/25] intel_iommu: bind/unbind guest page table to host

2020-06-11 Thread Liu Yi L
This patch captures the guest PASID table entry modifications and propagates the changes to host to setup dual stage DMA translation. The guest page table is configured as 1st level page table (GVA->GPA) whose translation result would further go through host VT-d 2nd level page table(GPA->HPA)

[RFC v6 15/25] intel_iommu: add PASID cache management infrastructure

2020-06-11 Thread Liu Yi L
This patch adds a PASID cache management infrastructure based on new added structure VTDPASIDAddressSpace, which is used to track the PASID usage and future PASID tagged DMA address translation support in vIOMMU. struct VTDPASIDAddressSpace { VTDBus *vtd_bus; uint8_t devfn;

[RFC v6 16/25] vfio: add bind stage-1 page table support

2020-06-11 Thread Liu Yi L
This patch adds bind_stage1_pgtbl() definition in HostIOMMUContextClass, also adds corresponding implementation in VFIO. This is to expose a way for vIOMMU to setup dual stage DMA translation for passthru devices on hardware. Cc: Kevin Tian Cc: Jacob Pan Cc: Peter Xu Cc: Eric Auger Cc: Yi Sun

[PATCH v3 3/4] spapr: Use error_append_hint() in spapr_caps.c

2020-06-11 Thread Greg Kurz
We have a dedicated error API for hints. Use it instead of embedding the hint in the error message, as recommanded in the "qapi/error.h" header file. Since spapr_caps_apply() passes _fatal, all functions must also call the ERRP_AUTO_PROPAGATE() macro for error_append_hint() to be functional.

[PATCH v3 1/4] spapr: Simplify some warning printing paths in spapr_caps.c

2020-06-11 Thread Greg Kurz
We obviously only want to print a warning in these cases, but this is done in a rather convoluted manner. Just use warn_report() instead. Signed-off-by: Greg Kurz --- hw/ppc/spapr_caps.c | 28 ++-- 1 file changed, 6 insertions(+), 22 deletions(-) diff --git

[PATCH v3 0/4] spapr: Improve error reporting in spapr_caps.c

2020-06-11 Thread Greg Kurz
Spapr capabilities are checked at machine init. If a capability cannot be used, an error message is printed and QEMU exits. In most places, the error message also contains an hint for the user. But we should use error_append_hint() for that, as explained in the "qapi/error.h" header. This is

Re: [PATCH v1 9/9] .travis.yml: allow failure for unreliable hosts

2020-06-11 Thread Thomas Huth
On 02/06/2020 17.46, Alex Bennée wrote: > They will still run but they won't get in the way of the result. What does this exactly mean? Will we still get a notification e-mail when something went wrong during the test? Thomas

  1   2   3   4   5   >