[PATCH 09/78] numa: properly check if numa is supported

From: Igor Mammedov Commit aa57020774b, by mistake used MachineClass::numa_mem_supported to check if NUMA is supported by machine and also as unrelated change set it to true for sbsa-ref board. Luckily change didn't break machines that support NUMA, as the field is set to true for them. But

Re: [RFC v5 4/4] cpus: extract out accel-specific code to each accel

Claudio Fontana writes: > each accelerator registers a new "CpusAccel" interface > implementation on initialization, providing functions for > starting a vcpu, kicking a vcpu, and sychronizing state. > > This way the code in cpus.c is now all general softmmu code, > nothing

Re: [PULL 00/23] target-arm queue

Patchew URL: https://patchew.org/QEMU/20200616095702.25848-1-peter.mayd...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PULL 00/23] target-arm queue Type: series Message-id:

Re: [PATCH v4 1/5] acpi: Convert build_tpm2() to build_append* API

On 6/16/20 8:33 AM, Igor Mammedov wrote: nevertheless looks like faithfull conversion, btw why you didn't drop Acpi20TPM2 structure definition? If we get rid of the table we should keep a reference to this document, table 7: "TCG ACPI Specification; Family 1.2 and 2.0; Level 00 Revision

[PATCH] hw/arm/virt: Add 5.0 HW compat props

Cc: Cornelia Huck Signed-off-by: Andrew Jones --- hw/arm/virt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index caceb1e4a05f..8b6e6aa7b138 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2375,6 +2375,7 @@ DEFINE_VIRT_MACHINE_AS_LATEST(5, 1) static

Re: [PATCH v2 4/5] acpi: Enable TPM IRQ

On 6/16/20 9:01 AM, Auger Eric wrote: Hi Stefan, On 6/15/20 7:11 PM, Stefan Berger wrote: On 6/15/20 11:13 AM, Marc-André Lureau wrote: diff --git a/include/hw/acpi/tpm.h b/include/hw/acpi/tpm.h index 1a2a57a21f..063a9eb42a 100644 --- a/include/hw/acpi/tpm.h +++ b/include/hw/acpi/tpm.h @@

Re: [PATCH v4 1/5] acpi: Convert build_tpm2() to build_append* API

Hi Igor, On 6/16/20 2:33 PM, Igor Mammedov wrote: > On Thu, 11 Jun 2020 15:59:13 +0200 > Eric Auger wrote: > >> In preparation of its move to the generic acpi code, >> let's convert build_tpm2() to use build_append API. This >> latter now is prefered in place of direct ACPI struct field >>

Re: [PATCH v8 07/14] block/crypto: implement the encryption key management

On Mon, 2020-06-08 at 14:14 +0200, Max Reitz wrote: > On 08.06.20 11:40, Maxim Levitsky wrote: > > This implements the encryption key management using the generic code in > > qcrypto layer and exposes it to the user via qemu-img > > > > This code adds another 'write_func' because the

Re: [RFC v5 3/4] cpu-timers, icount: new modules

Claudio Fontana writes: > refactoring of cpus.c continues with cpu timer state extraction. > > cpu-timers: responsible for the cpu timers state, and for access to > cpu clocks and ticks. > > icount: counts the TCG instructions executed. As such it is specific to > the TCG accelerator.

[PATCH v5 09/11] macio: Add dummy screamer register area

The only thing this returns is an idle status so the firmware continues, otherwise just ignores and logs access for debugging. This is a stop gap until proper implementation of this device lands. Signed-off-by: BALATON Zoltan --- hw/misc/macio/macio.c | 34 ++ 1

[PATCH v5 10/11] WIP macio/cuda: Attempt to add i2c support

This is a non-working RFC patch attempt to implement i2c bus in CUDA needed for firmware to access SPD data of installed RAM. The skeleton is there but actual operation fails because I don't know how this is supposed to work and the i2c bus state becomes invalid quickly. Also sending back results

[PATCH v5 06/11] mac_oldworld: Rename ppc_heathrow_reset to ppc_heathrow_cpu_reset

This function resets a CPU not the whole machine so reflect that in its name. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daudé --- hw/ppc/mac_oldworld.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c index

[PATCH v5 11/11] mac_oldworld: Add SPD data to cover RAM

OpenBIOS gets RAM size via fw_cfg but rhe original board firmware detects RAM using SPD data so generate and add SDP eeproms to cover as much RAM as possible to describe with SPD (this may be less than the actual ram_size due to SDRAM size constraints). Signed-off-by: BALATON Zoltan ---

[PATCH v5 05/11] grackle: Set revision in PCI config to match hardware

Signed-off-by: BALATON Zoltan --- hw/pci-host/grackle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/grackle.c b/hw/pci-host/grackle.c index 4b3af0c704..48d11f13ab 100644 --- a/hw/pci-host/grackle.c +++ b/hw/pci-host/grackle.c @@ -130,7 +130,7 @@ static void

[PATCH v5 03/11] mac_oldworld: Drop a variable, use get_system_memory() directly

Half of the occurances already use get_system_memory() directly instead of sysmem variable, convert the two other uses to get_system_memory() tii which seems to be more common and drop the variable. Signed-off-by: BALATON Zoltan --- hw/ppc/mac_oldworld.c | 5 ++--- 1 file changed, 2

[PATCH v5 07/11] mac_oldworld: Map macio to expected address at reset

Add a reset function that maps macio to the address expected by the firmware of the board at startup. Signed-off-by: BALATON Zoltan --- hw/ppc/mac.h | 12 hw/ppc/mac_oldworld.c | 15 ++- 2 files changed, 26 insertions(+), 1 deletion(-) diff --git

[PATCH v5 08/11] mac_oldworld: Add machine ID register

The G3 beige machine has a machine ID register that is accessed by the firmware to deternine the board config. Add basic emulation of it. Signed-off-by: BALATON Zoltan --- v4: Move MermoryRegion to MachineState, use constants hw/ppc/mac.h | 1 + hw/ppc/mac_oldworld.c | 24

[PATCH v5 04/11] mac_oldworld: Drop some variables

Values not used frequently enough may not worth putting in a local variable, especially with names almost as long as the original value because that does not improve readability, to the contrary it makes it harder to see what value is used. Drop a few such variables. Signed-off-by: BALATON Zoltan

[PATCH v5 01/11] mac_oldworld: Allow loading binary ROM image

The beige G3 Power Macintosh has a 4MB firmware ROM. Fix the size of the rom region and fall back to loading a binary image with -bios if loading ELF image failed. This allows testing emulation with a ROM image from real hardware as well as using an ELF OpenBIOS image. Signed-off-by: BALATON

[PATCH v5 00/11] Mac Old World ROM experiment

v5: Rebased on master, added some more clean ups, CUDA i2c is still to be sorted out, help with that is welcome. Regards, BALATON Zoltan BALATON Zoltan (11): mac_oldworld: Allow loading binary ROM image mac_newworld: Allow loading binary ROM image mac_oldworld: Drop a variable, use

[PATCH v5 02/11] mac_newworld: Allow loading binary ROM image

Fall back to load binary ROM image if loading ELF fails. This also moves PROM_BASE and PROM_SIZE defines to board as these are matching the ROM size and address on this board. Signed-off-by: BALATON Zoltan --- Notes: Unlike mac_oldworld where the openbios-ppc image loads at end of ROM

Re: [PULL 01/21] tests/docker: bump fedora to 32

Philippe Mathieu-Daudé writes: > On 6/16/20 2:53 PM, Alex Bennée wrote: >> We should be keeping this up to date as Fedora goes out of support >> quite quickly. >> >> Signed-off-by: Alex Bennée > > FWIW this one had: > Reviewed-by: Richard Henderson Thanks, I've issued a v2 of the tag:

[PULL v2 00/21] testing and plugin updates (tsan, pluginsm cross-builds)

The following changes since commit f5e34624f28f37ec3c8a93bdee348effee966a78: Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-jun-15-2020' into staging (2020-06-16 11:00:28 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git

Re: [PATCH V3] Rename use_acpi_pci_hotplug to more appropriate use_acpi_hotplug_bridge

> On Jun 16, 2020, at 7:09 PM, Igor Mammedov wrote: > > I've meant something like: > > Signed-off-by: Ani Sinha > --- > vX: - I might be blind and don't see changelog . Ah right. I was thinking you were referring to diff stat. I will add changeling next time. ani

Re: [PATCH V3] Rename use_acpi_pci_hotplug to more appropriate use_acpi_hotplug_bridge

On Tue, 16 Jun 2020 18:50:13 +0530 Ani Sinha wrote: > On Tue, Jun 16, 2020 at 6:47 PM Igor Mammedov wrote: > > > On Tue, 16 Jun 2020 12:31:39 + > > Ani Sinha wrote: > > > > > Currently, the option use_acpi_pci_hotplug is being used to control > > device > > > hotplug capability

Re: [PULL 00/23] target-arm queue

Merge remote-tracking branch > 'remotes/berrange/tags/qcrypto-next-pull-request' into staging (2020-06-15 > 16:36:34 +0100) > > are available in the Git repository at: > > https://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20200616 > > for you to fet

Re: [PATCH v4 1/7] MAINTAINERS: Cover 'hw/sh4/sh_intc.h' with the R2D machine

On 11/06/2020 13.43, Philippe Mathieu-Daudé wrote: > Commit 81527b94ad added hw/intc/sh_intc.c, complete by > adding its corresponding header. > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS >

Re: [PATCH] tests: disassemble-asm.sh: generate AML in readable format

On Thu, 11 Jun 2020 12:51:16 -0400 "Michael S. Tsirkin" wrote: subj: s/asm/asl/ > On systems where the IASL tool exists, we can convert > extected ACPI tables to ASL format, which is useful > for debugging and documentation purposes. > This script does this for all ACPI tables under

Re: [PATCH v8 05/14] block/amend: refactor qcow2 amend options

On 08.06.20 11:40, Maxim Levitsky wrote: > Some qcow2 create options can't be used for amend. > Remove them from the qcow2 create options and add generic logic to detect > such options in qemu-img > > Signed-off-by: Maxim Levitsky > Reviewed-by: Daniel P. Berrangé Last week (when I was about

Re: [PULL 01/21] tests/docker: bump fedora to 32

On 6/16/20 2:53 PM, Alex Bennée wrote: > We should be keeping this up to date as Fedora goes out of support > quite quickly. > > Signed-off-by: Alex Bennée FWIW this one had: Reviewed-by: Richard Henderson https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg06556.html > Message-Id:

Re: [PATCH V3] Rename use_acpi_pci_hotplug to more appropriate use_acpi_hotplug_bridge

On Tue, Jun 16, 2020 at 6:47 PM Igor Mammedov wrote: > On Tue, 16 Jun 2020 12:31:39 + > Ani Sinha wrote: > > > Currently, the option use_acpi_pci_hotplug is being used to control > device > > hotplug capability using ACPI for slots of cold plugged bridges. Hence, > we > > are renaming this

[PATCH 2/2] iotests: filter few more luks specific create options

From: Maxim Levitsky This allows more tests to be able to have same output on both qcow2 luks encrypted images and raw luks images Signed-off-by: Maxim Levitsky Signed-off-by: Max Reitz --- tests/qemu-iotests/087.out | 6 +++--- tests/qemu-iotests/134.out | 2 +-

Re: [RFC v5 2/4] cpu-throttle: new module, extracted from cpus.c

Claudio Fontana writes: > move the vcpu throttling functionality into its own module. > > This functionality is not specific to any accelerator, > and it is used currently by migration to slow down guests to try to > have migrations converge, and by the cocoa MacOS UI to throttle speed. > >

[PATCH 1/2] iotests: Make _filter_img_create more active

Right now, _filter_img_create just filters out everything that looks format-dependent, and applies some filename filters. That means that we have to add another filter line every time some format gets a new creation option. This can be avoided by instead discarding everything and just keeping

[PATCH 0/2] iotests: Make _filter_img_create more active

Hi, Applying Maxim’s series for LUKS encryption slot management through qemu-img amend / blockdev-amend has brought a – on the first glance – rather minor problem: It changes the order of qcow2’s creation options, which results in some reference output changes (patch 5:

Re: [PATCH V3] Rename use_acpi_pci_hotplug to more appropriate use_acpi_hotplug_bridge

On Tue, 16 Jun 2020 12:31:39 + Ani Sinha wrote: > Currently, the option use_acpi_pci_hotplug is being used to control device > hotplug capability using ACPI for slots of cold plugged bridges. Hence, we > are renaming this option to better reflect what it actually does. > > Signed-off-by:

QEMU | Pipeline #156667089 has failed for master | 53550e81

Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 53550e81 ( https://gitlab.com/qemu-project/qemu/-/commit/53550e81e2cafe7c03a39526b95cd21b5194d9b1 ) Commit Message: Merge

Re: [RFC v5 1/4] softmmu: move softmmu only files from root

Claudio Fontana writes: > move arch_init, balloon, cpus, ioport, memory, memory_mapping, qtest. > > They are all specific to CONFIG_SOFTMMU. > > Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée > --- > MAINTAINERS | 12 ++-- >

[PULL 17/21] Revert ".shippable: temporaily disable some cross builds"

This reverts commit 12d43b5ae916809aad9ccf8aa2a0a06260527340. Signed-off-by: Alex Bennée Message-Id: <20200612190237.30436-18-alex.ben...@linaro.org> diff --git a/.shippable.yml b/.shippable.yml index 10cf219bff4..2cce7b56890 100644 --- a/.shippable.yml +++ b/.shippable.yml @@ -5,8 +5,8 @@ env:

[PULL 18/21] cirrus.yml: serialise make check

We do this on our other platforms to make it easier to see what has broken. Signed-off-by: Alex Bennée Reviewed-by: Li-Wen Hsu Message-Id: <20200612190237.30436-19-alex.ben...@linaro.org> diff --git a/.cirrus.yml b/.cirrus.yml index ce7850a320e..69342ae031b 100644 --- a/.cirrus.yml +++

Re: [PATCH v2 4/5] acpi: Enable TPM IRQ

Hi Stefan, On 6/15/20 7:11 PM, Stefan Berger wrote: > On 6/15/20 11:13 AM, Marc-André Lureau wrote: >> >>> diff --git a/include/hw/acpi/tpm.h b/include/hw/acpi/tpm.h >>> index 1a2a57a21f..063a9eb42a 100644 >>> --- a/include/hw/acpi/tpm.h >>> +++ b/include/hw/acpi/tpm.h >>> @@ -24,7 +24,7 @@ >>>  

[PULL 13/21] include/qemu: Added tsan.h for annotations.

From: Robert Foley These annotations will allow us to give tsan additional hints. For example, we can inform tsan about reads/writes to ignore to silence certain classes of warnings. We can also annotate threads so that the proper thread naming shows up in tsan warning results. Signed-off-by:

[PULL 20/21] tests/tcg: ensure -cpu max also used for plugin run

The check-tcg plugins build was failing because some special case tests that needed -cpu max failed because the plugin variant hadn't carried across the QEMU_OPTS tweak. Guests which globally set QEMU_OPTS=-cpu FOO where unaffected. Signed-off-by: Alex Bennée Message-Id:

[PULL 15/21] docs: Added details on TSan to testing.rst

From: Robert Foley Adds TSan details to testing.rst. This includes background and reference details on TSan, and details on how to build and test with TSan both with and without docker. Signed-off-by: Robert Foley Reviewed-by: Emilio G. Cota Reviewed-by: Alex Bennée Signed-off-by: Alex

[PULL 09/21] tcg: call qemu_spin_destroy for tb->jmp_lock

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley Signed-off-by: Alex Bennée [RF: minor changes + remove tb_destroy_func] Message-Id: <20200609200738.445-7-robert.fo...@linaro.org> Message-Id: <20200612190237.30436-10-alex.ben...@linaro.org> diff --git

[PULL 16/21] tests: Disable select tests under TSan, which hit TSan issue.

From: Robert Foley Disable a few tests under CONFIG_TSAN, which run into a known TSan issue that results in a hang. https://github.com/google/sanitizers/issues/1116 The disabled tests under TSan include all the qtests as well as the test-char, test-qga, and test-qdev-global-props.

[PULL 19/21] tests/tcg: build plugin list from contents of src directory

If you jump back and forth between branches while developing plugins you end up debugging failures caused by plugins left in the build directory. Fix this by basing plugins on the source tree instead. Signed-off-by: Alex Bennée Message-Id: <20200615141922.18829-2-alex.ben...@linaro.org> diff

[PULL 08/21] qht: call qemu_spin_destroy for head buckets

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley Reviewed-by: Alex Bennée [AJB: add implied cota s-o-b c.f. github.com/cota/qemu/tree/tsan @ 1bd1209] Signed-off-by: Alex Bennée Message-Id: <20200609200738.445-6-robert.fo...@linaro.org> Message-Id:

[PULL 14/21] util: Added tsan annotate for thread name.

From: Robert Foley This allows us to see the name of the thread in tsan warning reports such as this: Thread T7 'CPU 1/TCG' (tid=24317, running) created by main thread at: Signed-off-by: Robert Foley Reviewed-by: Emilio G. Cota Signed-off-by: Alex Bennée Message-Id:

[PULL 07/21] cputlb: destroy CPUTLB with tlb_destroy

From: "Emilio G. Cota" I was after adding qemu_spin_destroy calls, but while at it I noticed that we are leaking some memory. Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id:

[PULL 11/21] thread: add tsan annotations to QemuSpin

From: "Emilio G. Cota" Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <20200609200738.445-9-robert.fo...@linaro.org> Message-Id: <20200612190237.30436-12-alex.ben...@linaro.org> diff --git a/include/qemu/thread.h

[PULL 02/21] Makefile: dtc: update, build the libfdt target

From: Claudio Fontana dtc submodule update, now call the libfdt target from the new dtc Makefile, which has been changed to not require bison, flex, etc. This removes warnings during the build. scripts/ symlink and tests directory creation are not necessary, and neither is calling the clean

[PULL 21/21] plugins: new lockstep plugin for debugging TCG changes

When we make changes to the TCG we sometimes cause regressions that are deep into the execution cycle of the guest. Debugging this often requires comparing large volumes of trace information to figure out where behaviour has diverged. The lockstep plugin utilises a shared socket so two QEMU's

[PULL 12/21] tests/docker: Added docker build support for TSan.

From: Robert Foley Added a new docker for ubuntu 20.04. This docker has support for Thread Sanitizer including one patch we need in one of the header files. https://github.com/llvm/llvm-project/commit/a72dc86cd This command will build with tsan enabled: make docker-test-tsan-ubuntu2004 V=1

[PULL 05/21] cpu: convert queued work to a QSIMPLEQ

From: "Emilio G. Cota" We convert queued work to a QSIMPLEQ, instead of open-coding it. While at it, make sure that all accesses to the list are performed while holding the list's lock. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé

[PULL 01/21] tests/docker: bump fedora to 32

We should be keeping this up to date as Fedora goes out of support quite quickly. Signed-off-by: Alex Bennée Message-Id: <20200612190237.30436-2-alex.ben...@linaro.org> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker index 92b6e11c8a8..798ddd2c3e0

[PULL 10/21] translate-all: call qemu_spin_destroy for PageDesc

From: "Emilio G. Cota" The radix tree is append-only, but we can fail to insert a PageDesc if the insertion races with another thread. Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id:

[PULL 00/21] testing and plugin updates (tsan, plugins, cross-builds)

The following changes since commit f5e34624f28f37ec3c8a93bdee348effee966a78: Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-jun-15-2020' into staging (2020-06-16 11:00:28 +0100) are available in the Git repository at: https://github.com/stsquad/qemu.git

[PULL 04/21] configure: add --enable-tsan flag + fiber annotations for coroutine-ucontext

From: Lingfeng Yang We tried running QEMU under tsan in 2016, but tsan's lack of support for longjmp-based fibers was a blocker: https://groups.google.com/forum/#!topic/thread-sanitizer/se0YuzfWazw Fortunately, thread sanitizer gained fiber support in early 2019:

[PULL 03/21] Makefile: remove old compatibility gunks

From: Claudio Fontana Signed-off-by: Claudio Fontana Reviewed-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20200518160319.18861-3-cfont...@suse.de> Message-Id:

[PULL 06/21] thread: add qemu_spin_destroy

From: "Emilio G. Cota" It will be used for TSAN annotations. Signed-off-by: Emilio G. Cota Signed-off-by: Robert Foley Reviewed-by: Alex Bennée Signed-off-by: Alex Bennée Message-Id: <20200609200738.445-4-robert.fo...@linaro.org> Message-Id: <20200612190237.30436-7-alex.ben...@linaro.org>

Re: [PATCH v2 3/5] tests: Temporarily ignore DSDT table differences

On 6/15/20 4:23 PM, Stefan Berger wrote: > Ignore DSDT table differences before enabling IRQ support for TPM. > > Signed-off-by: Stefan Berger > CC: Michael S. Tsirkin Reviewed-by: Eric Auger Thanks Eric > --- > tests/qtest/bios-tables-test-allowed-diff.h | 1 + > 1 file changed, 1

Re: [PATCH v2 2/5] tpm: Extend TPMIfClass with get_irqnum() function

Hi Stefan, On 6/15/20 5:44 PM, Stefan Berger wrote: > On 6/15/20 11:11 AM, Marc-André Lureau wrote: >> Hi >> >> On Mon, Jun 15, 2020 at 6:23 PM Stefan Berger >> wrote: >>> From: Stefan Berger >>> >>> Implement get_irqnum() as part of the TPMIfClass to be get the assigned >> ^^ to get >> >>> IRQ

Re: [PATCH v4 1/5] acpi: Convert build_tpm2() to build_append* API

On Thu, 11 Jun 2020 15:59:13 +0200 Eric Auger wrote: > In preparation of its move to the generic acpi code, > let's convert build_tpm2() to use build_append API. This > latter now is prefered in place of direct ACPI struct field > settings with manual endianness conversion. > > Signed-off-by:

Re: [PATCH V2] Rename use_acpi_pci_hotplug to more appropriate use_acpi_hotplug_bridge

> On Jun 16, 2020, at 5:29 PM, Igor Mammedov wrote: > >> Change-Id: I2a6ab47e80fa2bc9504ce88e063d710efaceb842 > what is this id, prehaps drop it? Sent V3 with this dropped. Ani

Re: [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons

On 6/16/20 2:29 PM, Peter Maydell wrote: > On Tue, 16 Jun 2020 at 11:40, Philippe Mathieu-Daudé wrote: >> On 6/16/20 12:27 PM, Peter Maydell wrote: >>> This change seems kind of pointless unless these GPIO lines are >>> actually wired up to something. >> >> Yes, I should have kept it out of this

Re: [PATCH v2 1/5] tpm_tis: Allow lowering of IRQ also when locality is not active

Hi Stefan, On 6/15/20 4:23 PM, Stefan Berger wrote: > From: Stefan Berger > > This patch fixes a bug that occurs when using interrupts. It > allows to lower the IRQ also when a locality is not active. > > Signed-off-by: Stefan Berger Reviewed-by: Eric Auger Thanks Eric > --- >

Re: [PULL 00/33] Net patches

On Tue, 16 Jun 2020 at 07:45, Jason Wang wrote: > > The following changes since commit 7d3660e79830a069f1848bb4fa1cdf8f666424fb: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2020-06-12 23:06:22 +0100) > > are available in the git repository at: > >

[PATCH V3] Rename use_acpi_pci_hotplug to more appropriate use_acpi_hotplug_bridge

Currently, the option use_acpi_pci_hotplug is being used to control device hotplug capability using ACPI for slots of cold plugged bridges. Hence, we are renaming this option to better reflect what it actually does. Signed-off-by: Ani Sinha --- hw/acpi/piix4.c | 21 +++-- 1 file

Re: [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons

On Tue, 16 Jun 2020 at 11:40, Philippe Mathieu-Daudé wrote: > On 6/16/20 12:27 PM, Peter Maydell wrote: > > This change seems kind of pointless unless these GPIO lines are > > actually wired up to something. > > Yes, I should have kept it out of this series, or documented > better the goal in the

Re: [PULL 00/84] QOM patches for 2020-06-15

On Mon, 15 Jun 2020 at 21:43, Markus Armbruster wrote: > > The following changes since commit 7d3660e79830a069f1848bb4fa1cdf8f666424fb: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2020-06-12 23:06:22 +0100) > > are available in the Git repository at: >

Re: [RFC v3 3/8] virtio-bus: introduce queue_enabled method

On Tue, Jun 16, 2020 at 3:50 PM Laurent Vivier wrote: > > On 29/05/2020 16:06, Cindy Lu wrote: > > From: Jason Wang > > > > This patch introduces queue_enabled() method which allows the > > transport to implement its own way to report whether or not a queue is > > enabled. > > > > Signed-off-by:

Re: [RFC v3 5/8] vhost: introduce vhost_set_vring_ready method

On Tue, Jun 16, 2020 at 4:04 PM Laurent Vivier wrote: > > On 29/05/2020 16:06, Cindy Lu wrote: > > From: Jason Wang > > > > Vhost-vdpa introduces VHOST_VDPA_SET_VRING_ENABLE which complies the > > semantic of queue_enable defined in virtio spec. This method can be > > used for preventing device

Re: [PATCH v4 1/5] acpi: Convert build_tpm2() to build_append* API

On Thu, 11 Jun 2020 10:25:38 -0400 Stefan Berger wrote: > On 6/11/20 9:59 AM, Eric Auger wrote: [...] > > -tpm2_ptr->log_area_minimum_length = > > -cpu_to_le32(TPM_LOG_AREA_MINIMUM_SIZE); > > +/* Platform Specific Parameters */ > > +g_array_append_vals(table_data,

Re: [PATCH v2 2/2] qemu-options.hx: Document hmat-lb and hmat-cache order

On Wed, 10 Jun 2020 15:17:35 +0200 Michal Privoznik wrote: > To simplify internal implementation the hmat-cache parsing code > expects hmat-lb to be already parsed. This means, that hmat-lb > arguments must come before hmat-cache. Document this restriction > so that management applications can

Re: [PATCH v2 1/2] qemu-options.hx: Mark all hmat-cache attributes required

On Wed, 10 Jun 2020 15:17:34 +0200 Michal Privoznik wrote: > The documentation to `-numa hmat-cache` says that @node-id, @size > and @level are the only required attributes. The rest > (@associativity, @policy and @line) is optional. Well, not quite > - if I try to start QEMU with only the three

Re: [PATCH V2] Rename use_acpi_pci_hotplug to more appropriate use_acpi_hotplug_bridge

On Wed, 10 Jun 2020 13:40:51 + Ani Sinha wrote: > Currently, the option use_acpi_pci_hotplug is being used to control device > hotplug capability using ACPI for slots of cold plugged bridges. Hence, we > are renaming this option to better reflect what it actually does. > > Change-Id:

Re: [PATCH v2 0/2] target/mips: Add two groups of loongson-ext instructions

在 2020/6/16 18:38, Aleksandar Markovic 写道: уторак, 16. јун 2020., Jiaxun Yang > је написао/ла: This is the sucessor of: "Basic TCG Loongson-3A1000 Support" Thanks! Hi, Jiaxun. Thanks for providing updated version of the series. I wonder,

Re: [PATCH v2] migration: Count new_dirty instead of real_dirty

Hi Dave, On 2020/6/16 17:58, Dr. David Alan Gilbert wrote: > * zhukeqian (zhukeqi...@huawei.com) wrote: >> Hi Dave, >> >> On 2020/6/16 17:35, Dr. David Alan Gilbert wrote: >>> * Keqian Zhu (zhukeqi...@huawei.com) wrote: real_dirty_pages becomes equal to total ram size after dirty log sync

Re: [PATCH v4 04/21] s390x/pv: Convert to ram_block_discard_disable()

On Wed, 10 Jun 2020 13:54:02 +0200 David Hildenbrand wrote: > Discarding RAM does not work as expected with protected VMs. Let's > switch to ram_block_discard_disable() for now, as we want to get rid > of qemu_balloon_inhibit(). Note that it will currently never fail, but > might fail in the

Re: [PATCH v4 02/21] vfio: Convert to ram_block_discard_disable()

On Wed, 10 Jun 2020 13:54:00 +0200 David Hildenbrand wrote: > VFIO is (except devices without a physical IOMMU or some mediated devices) > incompatible with discarding of RAM. The kernel will pin basically all VM > memory. Let's convert to ram_block_discard_disable(), which can now > fail, in

Re: [PATCH 1/2] hw/386: Fix uninitialized memory with -device and CPU hotplug

On Mon, 08 Jun 2020 15:18:50 -0500 Babu Moger wrote: > Noticed the following command failure while testing CPU hotplug. > > $ qemu-system-x86_64 -machine q35,accel=kvm -smp 1,maxcpus=2, > cores=1, threads=1,sockets=2 -cpu EPYC -device EPYC-x86_64- > cpu,core-id=0,socket-id=1,thread-id=0 >

Re: [PATCH v4 05/21] virtio-balloon: Rip out qemu_balloon_inhibit()

* David Hildenbrand (da...@redhat.com) wrote: > The only remaining special case is postcopy. It cannot handle > concurrent discards yet, which would result in requesting already sent > pages from the source. Special-case it in virtio-balloon instead. > > Introduce

[PATCH v2 0/2] Add strace support for printing arguments for ioctls

From: Filip Bozuta This series introduces the functionality in strace to print arguments for ioctls. This is gonna be a useful adittion as it indroduces a good debugging and diagnostic mechanism for user programs cross compiled for different architectures. The first patch in the series

[PATCH v2 1/2] linux-user: Add thunk argument types for SIOCGSTAMP and SIOCGSTAMPNS

From: Filip Bozuta Socket ioctls SIOCGSTAMP and SIOCGSTAMPNS, used for timestamping the socket connection, are defined in file "ioctls.h" differently from other ioctls. The reason for this difference is explained in the comments above their definition. These ioctls didn't have defined thunk

[PATCH v2 2/2] linux-user: Add strace support for printing arguments of ioctl()

From: Filip Bozuta This patch implements functionality for strace argument printing for ioctls. When running ioctls through qemu with "-strace", they get printed in format: "ioctl(fd_num,0x*,0x*) = ret_value" where the request code an the ioctl's third argument get printed in a

Re: [PULL v2 00/18] MIPS + misc queue for June 15th, 2020

On Mon, 15 Jun 2020 at 20:29, Aleksandar Markovic wrote: > > The following changes since commit 7d3660e79830a069f1848bb4fa1cdf8f666424fb: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2020-06-12 23:06:22 +0100) > > are available in the git repository at:

Re: [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons

On 6/16/20 12:27 PM, Peter Maydell wrote: > On Tue, 16 Jun 2020 at 07:32, Philippe Mathieu-Daudé wrote: >> >> The FPGA system control block has 2 push-buttons labelled PB0/PB1. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- > >> @@ -249,6 +258,8 @@ static void mps2_fpgaio_init(Object *obj)

[PATCH v4 6/6] linux-user: Add strace support for printing arguments of fallocate()

From: Filip Bozuta This patch implements strace argument printing functionality for following syscall: *fallocate - manipulate file space int fallocate(int fd, int mode, off_t offset, off_t len) man page: https://www.man7.org/linux/man-pages/man2/fallocate.2.html

[PATCH v4 5/6] linux-user: Add strace support for printing arguments of chown()/lchown()

From: Filip Bozuta This patch implements strace argument printing functionality for syscalls: *chown, lchown - change ownership of a file int chown(const char *pathname, uid_t owner, gid_t group) int lchown(const char *pathname, uid_t owner, gid_t group) man page:

[PATCH v4 4/6] linux-user: Add strace support for printing arguments of lseek()

From: Filip Bozuta This patch implements strace argument printing functionality for syscall: *lseek - reposition read/write file offset off_t lseek(int fd, off_t offset, int whence) man page: https://www.man7.org/linux/man-pages/man2/lseek.2.html Implementation notes:

[PATCH v4 1/6] linux-user: Extend strace support to enable argument printing after syscall execution

From: Filip Bozuta Structure "struct syscallname" in file "strace.c" is used for "-strace" to print arguments and return values of syscalls. The last field of this structure "result" represents the calling function that prints the return values. This field was extended in this

[PATCH v4 0/6] Add strace support for printing arguments of selected syscalls

From: Filip Bozuta This series covers strace support for printing arguments of following syscalls: *acct() *lgetxattr() *removexattr() *lchown() *fsync() *fgetxattr() *lremovexattr() *fallocate() *fdatasync() *listxattr()

[PATCH v4 2/6] linux-user: Add strace support for a group of syscalls

From: Filip Bozuta This patch implements strace argument printing functionality for following syscalls: *acct - switch process accounting on or off int acct(const char *filename) man page: https://www.man7.org/linux/man-pages/man2/acct.2.html *fsync, fdatasync -

[PATCH v4 3/6] linux-user: Add strace support for printing argument of syscalls used for extended attributes

From: Filip Bozuta This patch implements strace argument printing functionality for following syscalls: *getxattr, lgetxattr, fgetxattr - retrieve an extended attribute value ssize_t getxattr(const char *path, const char *name, void *value, size_t size) ssize_t

[PATCH v2 0/2] target/mips: Add two groups of loongson-ext instructions

уторак, 16. јун 2020., Jiaxun Yang је написао/ла: > This is the sucessor of: > "Basic TCG Loongson-3A1000 Support" > > Thanks! > > Hi, Jiaxun. Thanks for providing updated version of the series. I wonder, given so many "#if defined(TARGET_MIPS64)" lines in this series, what would be the 32-bit

Re: [PATCH 6/7] hw/arm/mps2: Map the FPGA I/O block

On 6/16/20 12:26 PM, Peter Maydell wrote: > On Tue, 16 Jun 2020 at 07:32, Philippe Mathieu-Daudé wrote: >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- > >> @@ -337,6 +339,11 @@ static void mps2_common_init(MachineState *machine) >> >> sysbus_create_simple("versatile_i2c",

Re: [PATCH 3/7] hw/arm/mps2: Add CMSDK APB watchdog as unimplemented device

On 6/16/20 12:17 PM, Peter Maydell wrote: > On Tue, 16 Jun 2020 at 07:32, Philippe Mathieu-Daudé wrote: >> >> Register the watchdog peripheral as unimplemented to better >> follow its accesses, for example booting Zephyr: > > We have a TYPE_CMSDK_APB_WATCHDOG device; so we could use > that, I

Re: [PATCH 00/22] ADB: fix autopoll issues and rework mac_via state machine

Tested-by: Finn Thain Thanks for all your work on this. I've just noticed a discrepancy between the traces from an ADB bus scan on Laurent's Apple Quadra and an ADB bus scan on your patched QEMU machine. Apple Q800: [C1f][s ][Rff-][Rff ][rff-] [C2f][s ][R61 ][R05 ][r00-] [C3f][s

Re: [PATCH 7/7] hw/misc/mps2-fpgaio: Implement push-buttons

On Tue, 16 Jun 2020 at 07:32, Philippe Mathieu-Daudé wrote: > > The FPGA system control block has 2 push-buttons labelled PB0/PB1. > > Signed-off-by: Philippe Mathieu-Daudé > --- > @@ -249,6 +258,8 @@ static void mps2_fpgaio_init(Object *obj) > memory_region_init_io(>iomem, obj,

<    1   2   3   4   5   6   >