[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-06-18 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:4.2-3ubuntu6.2 --- qemu (1:4.2-3ubuntu6.2) focal; urgency=medium * d/p/ubuntu/lp-1805256*: Fixes for QEMU on aarch64 ARM hosts - async: use explicit memory barriers (LP: #1805256) - aio-wait: delegate polling of main AioContext if

Re: [PATCH 2/5] block/aio_task: allow start/wait task from any coroutine

2020-06-18 Thread Vladimir Sementsov-Ogievskiy
16.06.2020 19:20, Denis V. Lunev wrote: From: Vladimir Sementsov-Ogievskiy Currently, aio task pool assumes that there is a main coroutine, which creates tasks and wait for them. Let's remove the restriction by using CoQueue. Code becomes clearer, interface more obvious. Signed-off-by:

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-06-18 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:2.11+dfsg-1ubuntu7.27 --- qemu (1:2.11+dfsg-1ubuntu7.27) bionic; urgency=medium * d/p/ubuntu/lp-1805256*: Fixes for QEMU on aarch64 ARM hosts - aio: rename aio_context_in_iothread() to in_aio_context_home_thread() - aio: Do

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-06-18 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu - 1:4.0+dfsg-0ubuntu9.7 --- qemu (1:4.0+dfsg-0ubuntu9.7) eoan; urgency=medium * d/p/ubuntu/lp-1805256*: Fixes for QEMU on aarch64 ARM hosts - async: use explicit memory barriers (LP: #1805256) - aio-wait: delegate polling of main

Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-18 Thread Philippe Mathieu-Daudé
On 6/17/20 10:23 PM, Peter Maydell wrote: > On Mon, 15 Jun 2020 at 22:23, Allan Peramaki wrote: >> >> Fix audio on software that accesses DRAM above 64k via register peek/poke >> and some cases when more than 16 voices are used. >> >> Fixes: 135f5ae1974c ("audio: GUSsample is int16_t") >>

Re: [PATCH v7 04/42] target/arm: Add support for MTE to HCR_EL2 and SCR_EL3

2020-06-18 Thread Peter Maydell
On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/helper.c | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v7 06/42] target/arm: Add DISAS_UPDATE_NOCHAIN

2020-06-18 Thread Peter Maydell
On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Add an option that writes back the PC, like DISAS_UPDATE_EXIT, > but does not exit back to the main loop. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v7 08/42] target/arm: Add MTE bits to tb_flags

2020-06-18 Thread Peter Maydell
On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Cache the composite ATA setting. > > Cache when MTE is fully enabled, i.e. access to tags are enabled > and tag checks affect the PE. Do this for both the normal context > and the UNPRIV context. > > Signed-off-by: Richard Henderson

Re: [PATCH v2 0/2] target/mips: Add two groups of loongson-ext instructions

2020-06-18 Thread Aleksandar Markovic
среда, 17. јун 2020., Jiaxun Yang је написао/ла: > > > 在 2020/6/16 22:41, Aleksandar Markovic 写道: > >> >> >> уторак, 16. јун 2020., Jiaxun Yang > jiaxun.y...@flygoat.com>> је написао/ла: >> >> >> >> 在 2020/6/16 18:38, Aleksandar Markovic 写道: >> >> >> >> уторак, 16. јун 2020., Jiaxun

[PATCH v9 08/10] accel/Kconfig: Add the TCG selector

2020-06-18 Thread Philippe Mathieu-Daudé
Expose the CONFIG_TCG selector to let minikconf.py uses it. When building with --disable-tcg build, this helps to deselect devices that are TCG-dependent. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 1 + accel/Kconfig | 3

Re: [PATCH] docs: vhost-user: add Virtio status protocol feature

2020-06-18 Thread Jason Wang
On 2020/6/18 下午7:29, Maxime Coquelin wrote: This patch specifies the VHOST_USER_SET_STATUS and VHOST_USER_GET_STATUS requests, which are sent by the master to update and query the Virtio status in the backend. Signed-off-by: Maxime Coquelin --- Changes since v1: = - Only

Re: [PATCH v2 0/2] target/mips: Add two groups of loongson-ext instructions

2020-06-18 Thread Jiaxun Yang
在 2020/6/18 20:00, Aleksandar Markovic 写道: среда, 17. јун 2020., Jiaxun Yang > је написао/ла: 在 2020/6/16 22:41, Aleksandar Markovic 写道: уторак, 16. јун 2020., Jiaxun Yang mailto:jiaxun.y...@flygoat.com>

Re: [PATCH v2] arm/virt: Add memory hot remove support

2020-06-18 Thread Auger Eric
Hi Shameer, On 6/17/20 6:40 PM, Shameerali Kolothum Thodi wrote: > Hi Eric, > >> -Original Message- >> From: Auger Eric [mailto:eric.au...@redhat.com] >> Sent: 17 June 2020 14:54 >> To: Shameerali Kolothum Thodi ; >> qemu-devel@nongnu.org; qemu-...@nongnu.org >> Cc: imamm...@redhat.com;

Re: [PATCH] target/arm/kvm: Check supported feature per accelerator (not per vCPU)

2020-06-18 Thread Philippe Mathieu-Daudé
On 6/18/20 11:22 AM, Andrew Jones wrote: > On Wed, Jun 17, 2020 at 03:08:00PM +0200, Philippe Mathieu-Daudé wrote: >> Since commit d70c996df23f, when enabling the PMU we get: >> >> $ qemu-system-aarch64 -cpu host,pmu=on -M virt,accel=kvm,gic-version=3 >> Segmentation fault (core dumped) >> >>

Re: [PATCH 5/5] block/io: improve savevm performance

2020-06-18 Thread Vladimir Sementsov-Ogievskiy
16.06.2020 19:20, Denis V. Lunev wrote: This patch does 2 standard basic things: - it creates intermediate buffer for all writes from QEMU migration code to block driver, - this buffer is sent to disk asynchronously, allowing several writes to run in parallel. Thus bdrv_vmstate_write() is

Re: [PATCH v7 05/42] target/arm: Rename DISAS_UPDATE to DISAS_UPDATE_EXIT

2020-06-18 Thread Peter Maydell
On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Emphasize that the is_jmp option exits to the main loop. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PULL 0/4] Microvm 20200617 patches

2020-06-18 Thread Peter Maydell
On Wed, 17 Jun 2020 at 13:33, Gerd Hoffmann wrote: > > The following changes since commit 5c24bce3056ff209a1ecc50ff4b7e65b85ad8e74: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-and-plugin-160620-2' into staging > (2020-06-16 14:57:15 +0100) > > are available in the

[PATCH] docs: vhost-user: add Virtio status protocol feature

2020-06-18 Thread Maxime Coquelin
This patch specifies the VHOST_USER_SET_STATUS and VHOST_USER_GET_STATUS requests, which are sent by the master to update and query the Virtio status in the backend. Signed-off-by: Maxime Coquelin --- Changes since v1: = - Only keep the spec part in this patch, the

QEMU | Pipeline #157572877 has failed for master | bac8d222

2020-06-18 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: bac8d222 ( https://gitlab.com/qemu-project/qemu/-/commit/bac8d222a19f4a30d0a17980bd932f23a6af77bb ) Commit Message: configure: Add

Re: [PATCH 4/5] GitLab Gating CI: introduce pipeline-status contrib script

2020-06-18 Thread Daniel P . Berrangé
On Thu, Mar 12, 2020 at 03:36:15PM -0400, Cleber Rosa wrote: > This script is intended to be used right after a push to a branch. > > By default, it will look for the pipeline associated with the commit > that is the HEAD of the *local* staging branch. It can be used as a > one time check, or

[PATCH v9 09/10] Makefile: Allow target-specific optional Kconfig

2020-06-18 Thread Philippe Mathieu-Daudé
Allow use of target-specific Kconfig file. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 00e8553745..c131c4e99d 100644 --- a/Makefile

[PATCH v9 01/10] MAINTAINERS: Fix KVM path expansion glob

2020-06-18 Thread Philippe Mathieu-Daudé
The KVM files has been moved from target-ARCH to the target/ARCH/ folder in commit fcf5ef2a. Fix the pathname expansion. Fixes: fcf5ef2a ("Move target-* CPU file into a target/ folder") Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Alex Bennée Signed-off-by: Philippe

[PATCH v9 06/10] Makefile: Write MINIKCONF variables as one entry per line

2020-06-18 Thread Philippe Mathieu-Daudé
Having one entry per line helps reviews/refactors. As we are going to modify the MINIKCONF variables, split them now to ease further review. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 9 ++--- 1 file changed, 6

Re: [PATCH 0/7] misc: Reduce QEMUTimer pressure by using lower precision when possible

2020-06-18 Thread Paolo Bonzini
On 18/06/20 14:26, Philippe Mathieu-Daudé wrote: >> This is in principle a very good idea; however, util/qemu-timer.c does >> not use the scale to coalesce low-precision timers with nearby >> high-precision ones. > IOW this doesn't reduce the pressure, but simply makes the code easier? Easier, or

Re: [PATCH v3] arm/virt: Add memory hot remove support

2020-06-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200618122129.7704-1-shameerali.kolothum.th...@huawei.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

[PULL V2 00/33] Net patches

2020-06-18 Thread Jason Wang
The following changes since commit 3f429a3400822141651486193d6af625eeab05a5: Merge remote-tracking branch 'remotes/kraxel/tags/microvm-20200617-pull-request' into staging (2020-06-18 11:23:15 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git

Re: [PATCH] hw/arm/virt: Add 5.0 HW compat props

2020-06-18 Thread Peter Maydell
On Tue, 16 Jun 2020 at 15:08, Andrew Jones wrote: > > Cc: Cornelia Huck > Signed-off-by: Andrew Jones > --- > hw/arm/virt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index caceb1e4a05f..8b6e6aa7b138 100644 > --- a/hw/arm/virt.c > +++

Re: [PATCH v9 1/5] Allow vu_message_read to be replaced

2020-06-18 Thread Kevin Wolf
Am 14.06.2020 um 20:39 hat Coiby Xu geschrieben: > Allow vu_message_read to be replaced by one which will make use of the > QIOChannel functions. Thus reading vhost-user message won't stall the > guest. > > Signed-off-by: Coiby Xu _vu_queue_notify() still has a direct call of vu_message_read()

Re: [PATCH v2] hw/audio/gus: Fix registers 32-bit access

2020-06-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200618103623.6031-1-phi...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export

[PATCH v9 07/10] accel/Kconfig: Extract accel selectors into their own config

2020-06-18 Thread Philippe Mathieu-Daudé
Move the accel selectors from the global Kconfig.host to their own Kconfig file. Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- Makefile | 1 + Kconfig.host | 7 --- accel/Kconfig | 6 ++ 3 files changed, 7 insertions(+), 7

QEMU | Pipeline #157595486 has failed for master | 3f429a34

2020-06-18 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 3f429a34 ( https://gitlab.com/qemu-project/qemu/-/commit/3f429a3400822141651486193d6af625eeab05a5 ) Commit Message: Merge

Re: [PATCH v7 11/42] target/arm: Implement the GMI instruction

2020-06-18 Thread Peter Maydell
On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v6: Inline the operation. > --- > target/arm/translate-a64.c | 15 +++ > 1 file changed, 15 insertions(+) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] target/arm/kvm: Check supported feature per accelerator (not per vCPU)

2020-06-18 Thread Andrew Jones
On Wed, Jun 17, 2020 at 03:08:00PM +0200, Philippe Mathieu-Daudé wrote: > Since commit d70c996df23f, when enabling the PMU we get: > > $ qemu-system-aarch64 -cpu host,pmu=on -M virt,accel=kvm,gic-version=3 > Segmentation fault (core dumped) > > Thread 1 "qemu-system-aar" received signal

Re: [PATCH 0/7] python: create installable package

2020-06-18 Thread Kevin Wolf
Am 17.06.2020 um 22:27 hat John Snow geschrieben: > > In the Avocado project, we have a `make develop` rule that does that > > for the main setup.py file, and for all plugins we carry on the same > > tree, which is similar in some regards to the "not at the project root > > directory" situation

Re: [PATCH] crypto/linux_keyring: fix 'secret_keyring' configure test

2020-06-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200618092636.71832-1-david.edmond...@oracle.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH 1/1] configure: prefer python's sphinx module

2020-06-18 Thread Peter Maydell
On Tue, 16 Jun 2020 at 20:09, John Snow wrote: > Using an explicit entry path script for sphinx can lead to confusing > results: If the python binary belongs to a virtual environment, our > configure script may still select a sphinx script that belongs to the > system distribution packages. > >

Re: [PATCH 1/1] docs/s390x: fix vfio-ap device_del description

2020-06-18 Thread Cornelia Huck
On Wed, 17 Jun 2020 19:17:54 +0200 Thomas Huth wrote: > On 17/06/2020 18.06, Christian Borntraeger wrote: > > device_del requires an id and not a sysfsfile. > > > > Signed-off-by: Christian Borntraeger > > --- > > docs/system/s390x/vfio-ap.rst | 8 > > 1 file changed, 4

[PATCH v2] hw/audio/gus: Fix registers 32-bit access

2020-06-18 Thread Philippe Mathieu-Daudé
From: Allan Peramaki Fix audio on software that accesses DRAM above 64k via register peek/poke and some cases when more than 16 voices are used. Cc: qemu-sta...@nongnu.org Fixes: 135f5ae1974c ("audio: GUSsample is int16_t") Signed-off-by: Allan Peramaki Tested-by: Volker Rümelin Reviewed-by:

Re: [PATCH] block: Raise an error when backing file parameter is an empty string

2020-06-18 Thread Alberto Garcia
On Wed 17 Jun 2020 08:27:25 PM CEST, Connor Kuehl wrote: > Providing an empty string for the backing file parameter like so: > > qemu-img create -f qcow2 -b '' /tmp/foo > > allows the flow of control to reach and subsequently fail an assert > statement because passing an empty string to > >

Re: Understanding initialization order for spice in qemu

2020-06-18 Thread Alex Bennée
Christophe de Dinechin writes: > Hi Gerd, > > > When I build qemu on master with moduels enabled, and run with spice, I > occasionally see: > > qemu-system-x86_64: util/module.c:136: module_load_file: Assertion > `QTAILQ_EMPTY(_init_list)' failed. > > Interestingly, I seem to have seen that

Re: [PATCH v7 07/42] target/arm: Add MTE system registers

2020-06-18 Thread Peter Maydell
On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > This is TFSRE0_EL1, TFSR_EL1, TFSR_EL2, TFSR_EL3, > RGSR_EL1, GCR_EL1, GMID_EL1, and PSTATE.TCO. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [Bug 1883560] [NEW] mips linux-user builds occasionly crash randomly only to be fixed by a full clean re-build

2020-06-18 Thread Cornelia Huck
On Mon, 15 Jun 2020 15:18:48 - Alex Bennée <1883...@bugs.launchpad.net> wrote: > Public bug reported: > > >From time to time I find check-tcg crashes with a one of the MIPS > binaries. The last time it crashed was running the test: > > ./mips64el-linux-user/qemu-mips64el

Re: [PATCH for-5.1] qcow2: Don't open images with a backing file and the data-file-raw bit

2020-06-18 Thread Alberto Garcia
On Wed 03 Jun 2020 03:53:03 PM CEST, Max Reitz wrote: > Sorry for the long delay. :/ And sorry for my long delay as well. > The patch itself looks good, but I’m not sure whether it is extensive > enough. Let me just jump straight to the problem: > > $ ./qemu-img create -f qcow2 \ > -o

Re: qemu-pr-helper -v suppresses errors, isn't that weird?

2020-06-18 Thread Paolo Bonzini
On 18/06/20 07:32, Markus Armbruster wrote: > prh_co_entry() reports reports errors reading requests / writing > responses only when @verbose (command line -v); relevant code appended > for you convenience. > > Sure these are *errors*? The program recovers and continues, and this > is deemed

Re: [PATCH 0/7] misc: Reduce QEMUTimer pressure by using lower precision when possible

2020-06-18 Thread Philippe Mathieu-Daudé
On 6/18/20 2:23 PM, Paolo Bonzini wrote: > On 16/06/20 09:51, Philippe Mathieu-Daudé wrote: >> This series contains few patches resulting from the notes I >> took while reviewing Mark ADB series last Sunday, in particular: >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg712078.html >> >>

[PATCH v3] arm/virt: Add memory hot remove support

2020-06-18 Thread Shameer Kolothum
This adds support for memory(pc-dimm) hot remove on arm/virt that uses acpi ged device. NVDIMM hot removal is not yet supported. Signed-off-by: Shameer Kolothum --- V2 --> v3 -Addressed Eric's review comment and added check for NVDIMM. RFC v1 --> v2 -Rebased on top of latest Qemu master.

[PATCH] crypto/linux_keyring: fix 'secret_keyring' configure test

2020-06-18 Thread David Edmondson
The configure test for 'secret_keyring' incorrectly checked the 'have_keyring' variable. Fixes: 54e7aac0562452e4fcab65ca5001d030eef2de15 Signed-off-by: David Edmondson --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index

Re: [PATCH 3/5] block/aio_task: drop aio_task_pool_wait_one() helper

2020-06-18 Thread Vladimir Sementsov-Ogievskiy
16.06.2020 19:20, Denis V. Lunev wrote: It is not used outside the module. Actually there are 2 kind of waiters: - for a slot and - for all tasks to finish This patch limits external API to listed types. Signed-off-by: Denis V. Lunev Suggested-by: Vladimir Sementsov-Ogievskiy Reviewed-by:

Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-18 Thread Peter Maydell
On Thu, 18 Jun 2020 at 11:22, Philippe Mathieu-Daudé wrote: > > On 6/17/20 10:23 PM, Peter Maydell wrote: > > On Mon, 15 Jun 2020 at 22:23, Allan Peramaki wrote: > >> > >> Fix audio on software that accesses DRAM above 64k via register peek/poke > >> and some cases when more than 16 voices are

Re: [PATCH v4 0/6] Vs clang-10 and gcc-9 warnings

2020-06-18 Thread Peter Maydell
On Wed, 17 Jun 2020 at 21:14, Richard Henderson wrote: > > Three of these patches are for cleaning up warnings vs clang-10. > > All of the patches from v3 are reviewed. The final patch is new, > fixing a problem in "make check" (which I was clearly lax in not > seeing before). I've applied

Re: [PATCH 2/2] scripts/tracetool: Add plainlog backend

2020-06-18 Thread BALATON Zoltan
On Thu, 18 Jun 2020, Daniel P. Berrangé wrote: On Thu, Jun 18, 2020 at 08:31:24AM +0100, Stefan Hajnoczi wrote: On Wed, Jun 17, 2020 at 03:36:29PM +0200, BALATON Zoltan wrote: Add a backend that is the same as the log backend but omits the process id and timestamp so logs are easier to read

Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-18 Thread Philippe Mathieu-Daudé
On 6/18/20 12:23 PM, Peter Maydell wrote: > On Thu, 18 Jun 2020 at 11:22, Philippe Mathieu-Daudé > wrote: >> >> On 6/17/20 10:23 PM, Peter Maydell wrote: >>> On Mon, 15 Jun 2020 at 22:23, Allan Peramaki wrote: Fix audio on software that accesses DRAM above 64k via register peek/poke

[Bug 1805256] Re: qemu-img hangs on rcu_call_ready_event logic in Aarch64 when converting images

2020-06-18 Thread Andrew Cloke
** Changed in: kunpeng920/ubuntu-20.04 Status: Fix Committed => Fix Released ** Changed in: kunpeng920/ubuntu-19.10 Status: Fix Committed => Fix Released ** Changed in: kunpeng920/ubuntu-18.04-hwe Status: Fix Committed => Fix Released ** Changed in: kunpeng920/ubuntu-18.04

Re: [PATCH v7 03/42] target/arm: Add support for MTE to SCTLR_ELx

2020-06-18 Thread Peter Maydell
On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > This does not attempt to rectify all of the res0 bits, but does > clear the mte bits when not enabled. Since there is no high-part > mapping of SCTLR, aa32 mode cannot write to these bits. > > Signed-off-by: Richard Henderson > --- >

Re: [PATCH v7 01/42] target/arm: Add isar tests for mte

2020-06-18 Thread Peter Maydell
On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v7 02/42] target/arm: Improve masking of SCR RES0 bits

2020-06-18 Thread Peter Maydell
On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Protect reads of aa64 id registers with ARM_CP_STATE_AA64. > Use this as a simpler test than arm_el_is_aa64, since EL3 > cannot change mode. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] target/arm/kvm: Check supported feature per accelerator (not per vCPU)

2020-06-18 Thread Paolo Bonzini
On 18/06/20 10:57, Andrew Jones wrote: >> If it's a test that the feature is enabled (e.g. via -cpu) then I agree. >> For something that ends up as a KVM_CHECK_EXTENSION or KVM_ENABLE_CAP on >> the KVM fd, however, I think passing an AccelState is better. > I can live with that justification as

Understanding initialization order for spice in qemu

2020-06-18 Thread Christophe de Dinechin
Hi Gerd, When I build qemu on master with moduels enabled, and run with spice, I occasionally see: qemu-system-x86_64: util/module.c:136: module_load_file: Assertion `QTAILQ_EMPTY(_init_list)' failed. Interestingly, I seem to have seen that only on master, but not on my own branch. Have

Re: [PATCH v7 09/42] target/arm: Implement the IRG instruction

2020-06-18 Thread Peter Maydell
On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Update to 00eac5. > Merge choose_random_nonexcluded_tag into helper_irg since > that pseudo function no longer exists separately. > v6: Remove obsolete logical/physical tag distinction;

Re: [PATCH v1] memory: assert MemoryRegionOps callbacks are defined

2020-06-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200618121218.215808-1-ppan...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash

[PATCH v9 05/10] Makefile: Remove dangerous EOL trailing backslash

2020-06-18 Thread Philippe Mathieu-Daudé
One might get caught trying to understand unexpected Makefile behavior. Trailing backslash can help to split very long lines, but are rather dangerous when nothing follow. Preserve other developers debugging time by removing this one. Reviewed-by: Thomas Huth Reviewed-by: Alistair Francis

[PATCH v9 04/10] configure: Generate rule to calculate the base architecture of a target

2020-06-18 Thread Philippe Mathieu-Daudé
From: Alex Bennée As we encode the base architecture in configure.sh, we can emit the base-arch() function into config-host.mak. Signed-off-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- configure | 19 +++ 1 file changed, 19 insertions(+) diff --git a/configure

[PATCH v9 10/10] accel/tcg: Add stub for probe_access()

2020-06-18 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The TCG helpers were added in b92e5a22ec3 in softmmu_template.h. probe_write() was added in there in 3b4afc9e75a to be moved out to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored as probe_access() in c25c283df0f. Since it is a TCG specific helper, add a

Re: [PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-06-18 Thread David Hildenbrand
On 13.06.20 22:07, Alexander Duyck wrote: > On Tue, May 26, 2020 at 9:14 PM Alexander Duyck > wrote: >> >> From: Alexander Duyck >> >> In an upcoming patch a feature named Free Page Reporting is about to be >> added. In order to avoid any confusion we should drop the use of the word >> 'report'

Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-18 Thread Peter Maydell
On Wed, 17 Jun 2020 at 23:26, Allan Peramaki wrote: > > On 17/06/2020 23:23, Peter Maydell wrote: > > > > This patch is quite difficult to read because it mixes some > > whitespace only changes with some actual changes of > > behaviour. > > Sorry about that. I had to put some whitespace in the

Re: [PATCH RESEND v2 2/2] nvme: allow cmb and pmr to be enabled on same device

2020-06-18 Thread Klaus Jensen
On Jun 16 22:18, Andrzej Jakowski wrote: > So far it was not possible to have CMB and PMR emulated on the same > device, because BAR2 was used exclusively either of PMR or CMB. This > patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors. > > Signed-off-by: Andrzej Jakowski >

[Bug 1805256] Update Released

2020-06-18 Thread Łukasz Zemczak
The verification of the Stable Release Update for qemu has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a

Re: [PATCH] target/arm/kvm: Check supported feature per accelerator (not per vCPU)

2020-06-18 Thread Paolo Bonzini
On 18/06/20 12:17, Philippe Mathieu-Daudé wrote: >>> cpu->kvm_init_features[0] |= 1 << KVM_ARM_VCPU_SVE; >>> } >>> >>> -- >>> 2.21.3 >>> >>> >> At all callsites we pass current_accel() to the kvm_arm__supported() >> functions. Is there any reason not to drop their input parameter

Re: [PATCH 5/5] block/io: improve savevm performance

2020-06-18 Thread Denis V. Lunev
On 6/18/20 1:56 PM, Vladimir Sementsov-Ogievskiy wrote: > 16.06.2020 19:20, Denis V. Lunev wrote: >> This patch does 2 standard basic things: >> - it creates intermediate buffer for all writes from QEMU migration code >>    to block driver, >> - this buffer is sent to disk asynchronously, allowing

Re: [PATCH] docs: vhost-user: add Virtio status protocol feature

2020-06-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200618112908.130528-1-maxime.coque...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PULL 14/15] qcow2_format.py: dump bitmaps header extension

2020-06-18 Thread Max Reitz
On 09.06.20 22:52, Eric Blake wrote: > From: Vladimir Sementsov-Ogievskiy > > Add class for bitmap extension and dump its fields. Further work is to > dump bitmap directory. > > Test new functionality inside 291 iotest. Unfortunately, it also breaks 291 with an external data file, which worked

Re: [PATCH v1] memory: assert MemoryRegionOps callbacks are defined

2020-06-18 Thread Alex Bennée
P J P writes: > From: Prasad J Pandit > > When registering a MemoryRegionOps object, assert that its > read/write callback methods are defined. This avoids potential > guest crash via a NULL pointer dereference. > > Suggested-by: Peter Maydell > Signed-off-by: Prasad J Pandit > --- >

Re: [PATCH v7 10/42] target/arm: Implement the ADDG, SUBG instructions

2020-06-18 Thread Peter Maydell
On Wed, 3 Jun 2020 at 02:13, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > v2: Shift offset in translate; use extract32. > v6: Implement inline for !ATA. > diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c > index 2481561925..a18d71ad98 100644 > ---

Re: [PATCH 4/5] block, migration: add bdrv_flush_vmstate helper

2020-06-18 Thread Vladimir Sementsov-Ogievskiy
16.06.2020 19:20, Denis V. Lunev wrote: Right now bdrv_fclose() is just calling bdrv_flush(). The problem is that migration code is working inefficently from black layer terms and are frequently called for very small pieces of not properly aligned data. Block layer is capable to work this way,

Re: [PATCH 4/5] block, migration: add bdrv_flush_vmstate helper

2020-06-18 Thread Vladimir Sementsov-Ogievskiy
17.06.2020 00:29, Denis V. Lunev wrote:   if (ret < 0) {   return ret;   } ...attempting it here, at which point it looks like the only reason you need ret2 is to preserve ret long enough... no, I would like to be sure that intermediate state is always cleared at the end. In

Re: [PATCH V5] util/oslib-posix : qemu_init_exec_dir implementation for Mac

2020-06-18 Thread Peter Maydell
On Tue, 16 Jun 2020 at 19:40, David CARLIER wrote: > > From 3025a0ce3fdf7d3559fc35a52c659f635f5c750c Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Tue, 26 May 2020 21:35:27 +0100 > Subject: [PATCH] util/oslib-posix : qemu_init_exec_dir implementation for Mac > > Using dyld API to get

Re: [PATCH v4 18/21] virtio-mem: Migration sanity checks

2020-06-18 Thread David Hildenbrand
On 17.06.20 19:59, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> We want to make sure that certain properties don't change during >> migration, especially to catch user errors in a nice way. Let's migrate >> a temporary structure and validate that the properties

[PATCH v1] memory: assert MemoryRegionOps callbacks are defined

2020-06-18 Thread P J P
From: Prasad J Pandit When registering a MemoryRegionOps object, assert that its read/write callback methods are defined. This avoids potential guest crash via a NULL pointer dereference. Suggested-by: Peter Maydell Signed-off-by: Prasad J Pandit --- memory.c | 5 + 1 file changed, 5

Re: [PATCH 0/7] misc: Reduce QEMUTimer pressure by using lower precision when possible

2020-06-18 Thread Paolo Bonzini
On 16/06/20 09:51, Philippe Mathieu-Daudé wrote: > This series contains few patches resulting from the notes I > took while reviewing Mark ADB series last Sunday, in particular: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg712078.html > > I have another patch for hw/input/hid.c but I

[PATCH v9 02/10] MAINTAINERS: Add an 'overall' entry for accelerators

2020-06-18 Thread Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5184cf46b3..426439a2c3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -416,6 +416,17 @@

[PATCH v9 00/10] accel: Allow targets to use Kconfig

2020-06-18 Thread Philippe Mathieu-Daudé
Missing review: - 03/10 MAINTAINERS: Cover the HAX accelerator stub - 04/10 configure: Generate rule to calculate base arch of target This series include generic patches I took of the KVM/ARM specific series which will follow. - Update accelerators in MAINTAINERS - Add accel/Kconfig - Allow

[PATCH v9 03/10] MAINTAINERS: Cover the HAX accelerator stub

2020-06-18 Thread Philippe Mathieu-Daudé
Cover accel/stubs/hax-stub.c in the HAXM section. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 426439a2c3..cebb0d385a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -476,6 +476,7 @@ M: Colin Xu L:

[PULL V2 01/33] virtio-net: implement RSS configuration command

2020-06-18 Thread Jason Wang
From: Yuri Benditovich Optionally report RSS feature. Handle RSS configuration command and keep RSS parameters in virtio-net device context. Signed-off-by: Yuri Benditovich Signed-off-by: Jason Wang --- hw/net/trace-events| 3 + hw/net/virtio-net.c| 167

[PULL V2 11/33] net: cadence_gem: Fix debug statements

2020-06-18 Thread Jason Wang
From: Sai Pavan Boddu Enabling debug breaks the build, Fix them and make debug statements always compilable. Fix few statements to use sized integer casting. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_gem.c | 27

[PULL V2 04/33] virtio-net: reference implementation of hash report

2020-06-18 Thread Jason Wang
From: Yuri Benditovich Suggest VIRTIO_NET_F_HASH_REPORT if specified in device parameters. If the VIRTIO_NET_F_HASH_REPORT is set, the device extends configuration space. If the feature is negotiated, the packet layout is extended to accomodate the hash information. In this case deliver packet's

[PULL V2 12/33] net: cadence_gem: Fix the queue address update during wrap around

2020-06-18 Thread Jason Wang
From: Sai Pavan Boddu During wrap around and reset, queues are pointing to initial base address of queue 0, irrespective of what queue we are dealing with. Fix it by assigning proper base address every time. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason

[PULL V2 31/33] hw/net/e1000e: Do not abort() on invalid PSRCTL register value

2020-06-18 Thread Jason Wang
From: Philippe Mathieu-Daudé libFuzzer found using 'qemu-system-i386 -M q35': qemu: hardware error: e1000e: PSRCTL.BSIZE0 cannot be zero CPU #0: EAX= EBX= ECX= EDX=0663 ESI= EDI= EBP= ESP= EIP=fff0 EFL=0002 [---] CPL=0 II=0

Re: [PATCH v4 6/6] linux-user: Add strace support for printing arguments of fallocate()

2020-06-18 Thread Laurent Vivier
Le 16/06/2020 à 12:39, Filip Bozuta a écrit : > From: Filip Bozuta > > This patch implements strace argument printing functionality for following > syscall: > > *fallocate - manipulate file space > > int fallocate(int fd, int mode, off_t offset, off_t len) > man page:

Re: [PATCH rc1 00/15] hw: Renesas patches (SH4 and RX)

2020-06-18 Thread Yoshinori Sato
On Thu, 18 Jun 2020 04:15:04 +0900, Philippe Mathieu-Daudé wrote: > > Hi Richard, Yoshinori, > > This is a merger of the latest SH4 patches (add a common entry for > Renesas hardware in MAINTAINERS, an acceptance test from Thomas), > and Yoshinori's v32 [*] of the RX machine. > Call this

Re: [PATCH v25 QEMU 3/3] virtio-balloon: Replace free page hinting references to 'report' with 'hint'

2020-06-18 Thread Alexander Duyck
On Thu, Jun 18, 2020 at 5:54 AM David Hildenbrand wrote: > > On 13.06.20 22:07, Alexander Duyck wrote: > > On Tue, May 26, 2020 at 9:14 PM Alexander Duyck > > wrote: > >> > >> From: Alexander Duyck > >> > >> In an upcoming patch a feature named Free Page Reporting is about to be > >> added. In

[PULL 2/7] vfio-ccw: Refactor cleanup of regions

2020-06-18 Thread Cornelia Huck
From: Eric Farman While we're at it, add a g_free() for the async_cmd_region that is the last thing currently created. g_free() knows how to handle NULL pointers, so this makes it easier to remember what cleanups need to be performed when new regions are added. Signed-off-by: Eric Farman

[PULL V2 13/33] net: cadence_gem: Fix irq update w.r.t queue

2020-06-18 Thread Jason Wang
From: Sai Pavan Boddu Set irq's specific to a queue, present implementation is setting q1 irq based on q0 status. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_gem.c | 25 +++-- 1 file changed, 3 insertions(+),

[PULL V2 18/33] net: cadence_gem: Add support for jumbo frames

2020-06-18 Thread Jason Wang
From: Sai Pavan Boddu Add a property "jumbo-max-len", which sets default value of jumbo frames up to 16,383 bytes. Add Frame length checks for standard and jumbo frames. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_gem.c

[PULL V2 17/33] net: cadence_gem: Fix up code style

2020-06-18 Thread Jason Wang
From: Sai Pavan Boddu Fix the code style for register definitions. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_gem.c | 204 ++- 1 file changed, 103 insertions(+), 101 deletions(-)

[PULL V2 09/33] hw/net/tulip: Fix 'Descriptor Error' definition

2020-06-18 Thread Jason Wang
From: Philippe Mathieu-Daudé Bit #14 is "DE" for 'Descriptor Error': When set, indicates a frame truncation caused by a frame that does not fit within the current descriptor buffers, and that the 21143 does not own the next descriptor. [Table 4-1. RDES0 Bit Fields Description]

[PULL V2 26/33] net/colo-compare.c: Fix deadlock in compare_chr_send

2020-06-18 Thread Jason Wang
From: Lukas Straub The chr_out chardev is connected to a filter-redirector running in the main loop. qemu_chr_fe_write_all might block here in compare_chr_send if the (socket-)buffer is full. If another filter-redirector in the main loop want's to send data to chr_pri_in it might also block if

Re: [PULL 14/15] qcow2_format.py: dump bitmaps header extension

2020-06-18 Thread Vladimir Sementsov-Ogievskiy
18.06.2020 16:13, Max Reitz wrote: On 09.06.20 22:52, Eric Blake wrote: From: Vladimir Sementsov-Ogievskiy Add class for bitmap extension and dump its fields. Further work is to dump bitmap directory. Test new functionality inside 291 iotest. Unfortunately, it also breaks 291 with an

[PULL V2 16/33] net: cadence_gem: Move tx/rx packet buffert to CadenceGEMState

2020-06-18 Thread Jason Wang
From: Sai Pavan Boddu Moving this buffers to CadenceGEMState, as their size will be increased more when JUMBO frames support is added. Signed-off-by: Sai Pavan Boddu Reviewed-by: Edgar E. Iglesias Signed-off-by: Jason Wang --- hw/net/cadence_gem.c | 38

Re: [PATCH v3] docs: vhost-user: add Virtio status protocol feature

2020-06-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200618134501.145747-1-maxime.coque...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

Re: [PATCH v2 2/2] linux-user: Add strace support for printing arguments of ioctl()

2020-06-18 Thread Laurent Vivier
Le 16/06/2020 à 12:51, Filip Bozuta a écrit : > From: Filip Bozuta > > This patch implements functionality for strace argument printing for ioctls. > When running ioctls through qemu with "-strace", they get printed in format: > > "ioctl(fd_num,0x*,0x*) = ret_value" > > where the request

  1   2   3   4   >