[RFC v2 0/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-06-26 Thread Eugenio Pérez
I am able to hit this assertion when a Red Hat 7 guest virtio_net device raises an "Invalidation" of all the TLB entries. This happens in the guest's startup if 'intel_iommu=on' argument is passed to the guest kernel and right IOMMU/ATS devices are declared in qemu's command line. Command line:

[PULL 0/4] ppc-for-5.1 queue 20200626

2020-06-26 Thread David Gibson
The following changes since commit 63d211993b73ca9ac2bc618afeb61a698e9f5198: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2020-06-25 16:52:42 +0100) are available in the Git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-5.1-20200626 for you

[PULL 2/4] spapr: Fix typos in comments and macro indentation

2020-06-26 Thread David Gibson
From: Gustavo Romero This commit fixes typos in spapr_vio_reg_to_irq() comments and a macro indentation. Signed-off-by: Gustavo Romero Message-Id: <1590710681-12873-1-git-send-email-grom...@linux.ibm.com> Acked-by: Cédric Le Goater Signed-off-by: David Gibson --- hw/ppc/spapr_vio.c

[PULL 4/4] target/ppc: Remove TIDR from POWER10 processor

2020-06-26 Thread David Gibson
From: Cédric Le Goater It is not part of Power ISA Version 3.1. Signed-off-by: Cédric Le Goater Message-Id: <20200623154534.266065-1-...@kaod.org> Signed-off-by: David Gibson --- target/ppc/translate_init.inc.c | 5 - 1 file changed, 5 deletions(-) diff --git

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-26 Thread David Hildenbrand
Does this have any implications when probing with the 'none' machine? >>> >>> I'm not sure. In your case, I guess the cpu bit would still show up >>> as before, so it would tell you base feature availability, but not >>> whether you can use the new configuration option. >>> >>> Since the HTL

[PATCH v5 19/21] virtio-mem: Add trace events

2020-06-26 Thread David Hildenbrand
Let's add some trace events that might come in handy later. Cc: "Michael S. Tsirkin" Cc: "Dr. David Alan Gilbert" Signed-off-by: David Hildenbrand --- hw/virtio/trace-events | 10 ++ hw/virtio/virtio-mem.c | 10 +- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git

[PATCH v5 17/21] virtio-pci: Send qapi events when the virtio-mem size changes

2020-06-26 Thread David Hildenbrand
Let's register the notifier and trigger the qapi event with the right device id. MEMORY_DEVICE_SIZE_CHANGE is similar to BALLOON_CHANGE, however on a memory device level. Don't unregister the notifier (we neither have finalize() nor unrealize() for VirtIOPCIProxy, so it's not that simple to do

[PATCH v5 14/21] numa: Handle virtio-mem in NUMA stats

2020-06-26 Thread David Hildenbrand
Account the memory to the configured nid. Reviewed-by: Pankaj Gupta Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: "Michael S. Tsirkin" Signed-off-by: David Hildenbrand --- hw/core/numa.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/core/numa.c b/hw/core/numa.c index

Re: [PATCH v5 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-06-26 Thread Auger Eric
Hi Markus, On 6/25/20 9:05 AM, Markus Armbruster wrote: > Eric Auger writes: > >> This patch implements the PROBE request. At the moment, >> only THE RESV_MEM property is handled. The first goal is >> to report iommu wide reserved regions such as the MSI regions >> set by the machine code. On

Re: [PATCH v5 5/5] hw/arm/virt: Let the virtio-iommu bypass MSIs

2020-06-26 Thread Auger Eric
Hi Peter, On 6/25/20 12:01 PM, Peter Maydell wrote: > On Wed, 24 Jun 2020 at 14:27, Eric Auger wrote: >> >> At the moment the virtio-iommu translates MSI transactions. >> This behavior is inherited from ARM SMMU. The virt machine >> code knows where the guest MSI doorbells are so we can easily

Re: [PATCH v5 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-06-26 Thread Auger Eric
Hi Peter, On 6/25/20 12:12 PM, Peter Maydell wrote: > On Thu, 25 Jun 2020 at 08:06, Markus Armbruster wrote: >> $ qemu-system-x86_64 -nodefaults -S -display none -device >> virtio-iommu-pci,len-reserved-regions=1,reserved-regions[0]=0xfee0:0xfeef:99 >> qemu-system-x86_64:

Re: [PULL 0/4] target/xtensa fixes

2020-06-26 Thread Peter Maydell
On Thu, 25 Jun 2020 at 09:11, Max Filippov wrote: > > Hi Peter, > > please pull the following batch of fixes for the target/xtensa. > > The following changes since commit 648db19685b7030aa558a4ddbd3a8e53d8c9a062: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-misc-2020-04-29' >

Re: [PATCH] hw/arm: Add 'virtm' hardware

2020-06-26 Thread Peter Maydell
On Fri, 26 Jun 2020 at 00:07, Keith Packard wrote: > > 'virtm' is a hardware target that is designed to be used for compiler > and library testing on Cortex-M processors. It supports all cortex-m > processors and includes sufficient memory to run even large test > cases. > > Signed-off-by: Keith

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-26 Thread Janosch Frank
On 6/26/20 8:53 AM, David Hildenbrand wrote: > Does this have any implications when probing with the 'none' machine? I'm not sure. In your case, I guess the cpu bit would still show up as before, so it would tell you base feature availability, but not whether you can use

Re: [PATCH v5 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-06-26 Thread Auger Eric
Hi Markus On 6/26/20 10:53 AM, Markus Armbruster wrote: > Auger Eric writes: > >> Hi Markus, >> On 6/25/20 9:05 AM, Markus Armbruster wrote: >>> Eric Auger writes: >>> This patch implements the PROBE request. At the moment, only THE RESV_MEM property is handled. The first goal is

Re: [Bug 1885247] [NEW] Build error in Intel 32-bit hosts

2020-06-26 Thread Thomas Huth
On 26/06/2020 11.13, Philippe Mathieu-Daudé wrote: On 6/26/20 9:37 AM, Aleksandar Markovic wrote: пет, 26. јун 2020. у 09:11 Aleksandar Markovic <1885...@bugs.launchpad.net> је написао/ла: Public bug reported: The code base is on master, checked out on Thursday June25th 2020, 0250c595c9d.

Re: [PATCH 00/17] block/nvme: Various cleanups required to use multiple queues

2020-06-26 Thread Philippe Mathieu-Daudé
On 6/25/20 9:27 PM, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200625184838.28172-1-phi...@redhat.com/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you have Docker

[PATCH v1] virtio-balloon: always indicate S_DONE when migration fails

2020-06-26 Thread David Hildenbrand
If something goes wrong during precopy, before stopping the VM, we will never send a S_DONE indication to the VM, resulting in the hinted pages not getting released to be used by the guest OS (e.g., Linux). Easy to reproduce: 1. Start migration (e.g., HMP "migrate -d 'exec:gzip -c >

Re: [PATCH v4 8/8] s390: guest support for diagnose 0x318

2020-06-26 Thread Cornelia Huck
On Wed, 24 Jun 2020 16:23:12 -0400 Collin Walling wrote: > DIAGNOSE 0x318 (diag318) is an s390 instruction that allows the storage > of diagnostic information that is collected by the firmware in the case > of hardware/firmware service events. > > QEMU handles the instruction by storing the

[PATCH 3/5] haiku build fix

2020-06-26 Thread David CARLIER
>From 56890fa5728d11c72232348b3f3273e2df31c197 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jun 2020 10:40:58 + Subject: [PATCH 3/5] Checking mlockall symbol presence Signed-off-by: David Carlier --- configure | 15 +++ os-posix.c | 4 2 files changed, 19

[RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-06-26 Thread Eugenio Pérez
Bug reference: https://bugs.launchpad.net/qemu/+bug/1885175 It is possible to hit this assertion on rhel7 guests if iommu is properly enabled. Signed-off-by: Eugenio Pérez --- memory.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/memory.c b/memory.c index 2f15a4b250..7f789710d2 100644

RE: [PATCH v6 5/5] hw/riscv: virt: Allow creating multiple NUMA sockets

2020-06-26 Thread Anup Patel
> -Original Message- > From: Alistair Francis > Sent: 26 June 2020 00:20 > To: Anup Patel > Cc: Anup Patel ; Peter Maydell > ; Palmer Dabbelt ; > Alistair Francis ; Sagar Karandikar > ; Atish Patra ; open > list:RISC-V ; qemu-devel@nongnu.org > Developers > Subject: Re: [PATCH v6 5/5]

[Bug 1885247] [NEW] Build error in Intel 32-bit hosts

2020-06-26 Thread Aleksandar Markovic
Public bug reported: The code base is on master, checked out on Thursday June25th 2020, 0250c595c9d. The build procedure: $ mkdir build-gcc $ cd build-gcc $ ../configure $ make The build error message is: CC x86_64-softmmu/hw/hyperv/hyperv.o CC

[PATCH v5 01/21] pc: Support coldplugging of virtio-pmem-pci devices on all buses

2020-06-26 Thread David Hildenbrand
E.g., with "pc-q35-4.2", trying to coldplug a virtio-pmem-pci devices results in "virtio-pmem-pci not supported on this bus" Reasons is, that the bus does not support hotplug and, therefore, does not have a hotplug handler. Let's allow coldplugging virtio-pmem devices on such buses. The

[PATCH v5 02/21] exec: Introduce ram_block_discard_(disable|require)()

2020-06-26 Thread David Hildenbrand
We want to replace qemu_balloon_inhibit() by something more generic. Especially, we want to make sure that technologies that really rely on RAM block discards to work reliably to run mutual exclusive with technologies that effectively break it. E.g., vfio will usually pin all guest memory,

[PATCH v5 11/21] virtio-pci: Proxy for virtio-mem

2020-06-26 Thread David Hildenbrand
Let's add a proxy for virtio-mem, make it a memory device, and pass-through the properties. Reviewed-by: Pankaj Gupta Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: "Dr. David Alan Gilbert" Cc: Igor Mammedov Signed-off-by: David Hildenbrand --- hw/virtio/Makefile.objs| 1 +

[PATCH v5 12/21] MAINTAINERS: Add myself as virtio-mem maintainer

2020-06-26 Thread David Hildenbrand
Let's make sure patches/bug reports find the right person. Reviewed-by: Dr. David Alan Gilbert Cc: "Michael S. Tsirkin" Cc: Peter Maydell Cc: Markus Armbruster Signed-off-by: David Hildenbrand --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS

[PATCH v5 07/21] target/i386: sev: Use ram_block_discard_disable()

2020-06-26 Thread David Hildenbrand
AMD SEV will pin all guest memory, mark discarding of RAM broken. At the time this is called, we cannot have anyone active that relies on discards to work properly - let's still implement error handling. Reviewed-by: Dr. David Alan Gilbert Cc: "Michael S. Tsirkin" Cc: Paolo Bonzini Cc: Richard

[PATCH v5 04/21] accel/kvm: Convert to ram_block_discard_disable()

2020-06-26 Thread David Hildenbrand
Discarding memory does not work as expected. At the time this is called, we cannot have anyone active that relies on discards to work properly. Reviewed-by: Dr. David Alan Gilbert Cc: Paolo Bonzini Signed-off-by: David Hildenbrand --- accel/kvm/kvm-all.c | 4 ++-- 1 file changed, 2

[PATCH v5 05/21] s390x/pv: Convert to ram_block_discard_disable()

2020-06-26 Thread David Hildenbrand
Discarding RAM does not work as expected with protected VMs. Let's switch to ram_block_discard_disable() for now, as we want to get rid of qemu_balloon_inhibit(). Note that it will currently never fail, but might fail in the future with new technologies (e.g., virtio-mem). Acked-by: Cornelia Huck

Re: [Bug 1885247] [NEW] Build error in Intel 32-bit hosts

2020-06-26 Thread Aleksandar Markovic
пет, 26. јун 2020. у 09:11 Aleksandar Markovic <1885...@bugs.launchpad.net> је написао/ла: > > Public bug reported: > > The code base is on master, checked out on Thursday June25th 2020, > 0250c595c9d. The build procedure: > > $ mkdir build-gcc > $ cd build-gcc > $ ../configure > $ make > > The

Re: [PATCH] hw/virtio/virtio-iommu-pci.c: Fix typo in error message

2020-06-26 Thread Auger Eric
Hi Peter, On 6/25/20 12:08 PM, Peter Maydell wrote: > Fix a typo in an error message in virtio_iommu_pci_realize(): > "Check you machine" should be "Check your machine". > > Reported-by: Markus Armbruster > Signed-off-by: Peter Maydell Reviewed-by: Eric Auger Thanks Eric > --- >

Re: [RFC v5 12/12] pc-bios: s390x: Cleanup jump to ipl code

2020-06-26 Thread Janosch Frank
On 6/25/20 2:58 PM, Thomas Huth wrote: > On 24/06/2020 09.52, Janosch Frank wrote: >> jump_to_IPL_code takes a 64 bit address, masks it with the short psw >> address mask and later branches to it using a full 64 bit register. >> >> * As the masking is not necessary, let's remove it >> * Without

Re: [Bug 1885247] [NEW] Build error in Intel 32-bit hosts

2020-06-26 Thread Philippe Mathieu-Daudé
On 6/26/20 9:37 AM, Aleksandar Markovic wrote: > пет, 26. јун 2020. у 09:11 Aleksandar Markovic > <1885...@bugs.launchpad.net> је написао/ла: >> >> Public bug reported: >> >> The code base is on master, checked out on Thursday June25th 2020, >> 0250c595c9d. The build procedure: >> >> $ mkdir

Re: [PATCH v6 2/2] target/arm: kvm: Handle misconfigured dabt injection

2020-06-26 Thread Andrew Jones
On Thu, Jun 25, 2020 at 11:03:36PM +0100, Beata Michalska wrote: > Injecting external data abort through KVM might trigger > an issue on kernels that do not get updated to include the KVM fix. > For those and aarch32 guests, the injected abort gets misconfigured > to be an implementation defined

[PULL 00/22] qemu-macppc queue 20200626

2020-06-26 Thread Mark Cave-Ayland
The following changes since commit 5acc270a355120ce967ca1f1eeca0abbdb9303c8: Merge remote-tracking branch 'remotes/xtensa/tags/20200625-xtensa' into staging (2020-06-25 21:20:45 +0100) are available in the Git repository at: git://github.com/mcayland/qemu.git tags/qemu-macppc-20200626

[PULL 06/22] adb: introduce realize/unrealize and VMStateDescription for ADB bus

2020-06-26 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Tested-by: Finn Thain Acked-by: Laurent Vivier Message-Id: <20200623204936.24064-7-mark.cave-ayl...@ilande.co.uk> --- hw/input/adb.c | 32 1 file changed, 32 insertions(+) diff --git a/hw/input/adb.c b/hw/input/adb.c index

[PULL 09/22] pmu: convert to use ADBBusState internal autopoll variables

2020-06-26 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Tested-by: Finn Thain Acked-by: Laurent Vivier Message-Id: <20200623204936.24064-10-mark.cave-ayl...@ilande.co.uk> --- hw/misc/macio/pmu.c | 39 ++--- include/hw/misc/macio/pmu.h | 3 --- 2 files changed, 15

[PULL 02/22] adb: fix adb-mouse read length and revert disable-reg3-direct-writes workaround

2020-06-26 Thread Mark Cave-Ayland
Commit 84051eb400 "adb: add property to disable direct reg 3 writes" introduced a workaround for spurious writes to ADB register 3 when MacOS 9 enables autopoll on the mouse device. Further analysis shows that the problem is that only a partial request is sent, and since the len parameter is

[PULL 01/22] adb: coding style update to fix checkpatch errors

2020-06-26 Thread Mark Cave-Ayland
This will help ensure that style guidelines are being maintained during subsequent changes. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Tested-by: Finn Thain Acked-by: Laurent Vivier Message-Id: <20200623204936.24064-2-mark.cave-ayl...@ilande.co.uk> --- hw/input/adb.c

[PULL 03/22] cuda: convert ADB autopoll timer from ns to ms

2020-06-26 Thread Mark Cave-Ayland
This is in preparation for consolidating all of the ADB autopoll management in one place. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Tested-by: Finn Thain Acked-by: Laurent Vivier Message-Id: <20200623204936.24064-4-mark.cave-ayl...@ilande.co.uk> ---

[PULL 08/22] cuda: convert to use ADBBusState internal autopoll variables

2020-06-26 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Tested-by: Finn Thain Acked-by: Laurent Vivier Message-Id: <20200623204936.24064-9-mark.cave-ayl...@ilande.co.uk> --- hw/misc/macio/cuda.c | 56 +++- include/hw/misc/macio/cuda.h | 4 --- 2 files changed, 23

[PULL 04/22] pmu: fix duplicate autopoll mask variable

2020-06-26 Thread Mark Cave-Ayland
It seems that during the initial work to introduce the via-pmu ADB support a duplicate autopoll mask variable was accidentally left in place. Remove the duplicate autopoll_mask variable and switch everything over to use adb_poll_mask instead. Signed-off-by: Mark Cave-Ayland Tested-by: Finn

[PULL 16/22] cuda: add adb_autopoll_block() and adb_autopoll_unblock() functions

2020-06-26 Thread Mark Cave-Ayland
Ensure that the CUDA buffer is protected from autopoll requests overwriting its contents whilst existing CUDA requests are in progress. Signed-off-by: Mark Cave-Ayland Tested-by: Finn Thain Acked-by: Laurent Vivier Message-Id: <20200623204936.24064-17-mark.cave-ayl...@ilande.co.uk> ---

[PULL 20/22] adb: only call autopoll callbacks when autopoll is not blocked

2020-06-26 Thread Mark Cave-Ayland
Handle this at the ADB bus level so that individual implementations do not need to handle this themselves. Finally add an assert() into adb_request() to prevent developers from accidentally making an explicit ADB request without blocking autopoll. Signed-off-by: Mark Cave-Ayland Tested-by:

Re: [PATCH v2 3/3] usb/hcd-xhci: Split pci wrapper for xhci base model

2020-06-26 Thread Markus Armbruster
Sai Pavan Boddu writes: > Hi Markus, > >> -Original Message- >> From: Markus Armbruster >> Sent: Thursday, June 25, 2020 1:42 PM >> To: Sai Pavan Boddu >> Cc: Gerd Hoffmann ; Peter Maydell >> ; Thomas Huth ; Eduardo >> Habkost ; qemu-devel@nongnu.org; Alistair Francis >> ; 'Marc-André

Re: [PATCH 03/46] qdev: Smooth error checking of qdev_realize() & friends

2020-06-26 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > 24.06.2020 19:43, Markus Armbruster wrote: >> Convert >> >> foo(..., ); >> if (err) { >> ... >> } >> >> to >> >> if (!foo(..., )) { >> ... >> } >> >> for qdev_realize(), qdev_realize_and_unref(), qbus_realize() and

[PATCH v5 08/21] migration/rdma: Use ram_block_discard_disable()

2020-06-26 Thread David Hildenbrand
RDMA will pin all guest memory (as documented in docs/rdma.txt). We want to disable RAM block discards - however, to keep it simple use ram_block_discard_is_required() instead of inhibiting. Note: It is not sufficient to limit disabling to pin_all. Even when only conditionally pinning 1 MB

[PATCH v5 16/21] virtio-mem: Allow notifiers for size changes

2020-06-26 Thread David Hildenbrand
We want to send qapi events in case the size of a virtio-mem device changes. This allows upper layers to always know how much memory is actually currently consumed via a virtio-mem device. Unfortuantely, we have to report the id of our proxy device. Let's provide an easy way for our proxy device

[PATCH v5 13/21] hmp: Handle virtio-mem when printing memory device info

2020-06-26 Thread David Hildenbrand
Print the memory device info just like for other memory devices. Reviewed-by: Dr. David Alan Gilbert Cc: "Dr. David Alan Gilbert" Cc: "Michael S. Tsirkin" Signed-off-by: David Hildenbrand --- monitor/hmp-cmds.c | 16 1 file changed, 16 insertions(+) diff --git

[PATCH v5 20/21] virtio-mem: Exclude unplugged memory during migration

2020-06-26 Thread David Hildenbrand
The content of unplugged memory is undefined and should not be migrated, ever. Exclude all unplugged memory during precopy using the precopy notifier infrastructure introduced for free page hinting in virtio-balloon. Unplugged memory is marked as "not dirty", meaning it won't be considered for

[PATCH v5 21/21] numa: Auto-enable NUMA when any memory devices are possible

2020-06-26 Thread David Hildenbrand
Let's auto-enable it also when maxmem is specified but no slots are defined. This will result in us properly creating ACPI srat tables, indicating the maximum possible PFN to the guest OS. Based on this, e.g., Linux will enable the swiotlb properly. This avoids having to manually force the

Re: [PATCH v5 11/12] pc-bios: s390x: Fix bootmap.c passing PSWs as addresses

2020-06-26 Thread Janosch Frank
On 6/25/20 2:46 PM, Thomas Huth wrote: > On 24/06/2020 09.52, Janosch Frank wrote: >> The component entries written by zipl contain short PSWs, not >> addresses. Let's mask them and only pass the address part to >> jump_to_IPL_code(uint64_t address) because it expects an address as >> visible by

Re: [PATCH 0/2] block: propagate discard alignment from format drivers to the guest

2020-06-26 Thread Denis V. Lunev
On 6/11/20 8:16 PM, Denis V. Lunev wrote: > Nowaday SCSI drivers in guests are able to align UNMAP requests before > sending to the device. Right now QEMU provides an ability to set > this via "discard_granularity" property of the block device which could > be used by management layer. > > Though,

Re: [PATCH v6 1/2] target/arm: kvm: Handle DABT with no valid ISS

2020-06-26 Thread Andrew Jones
On Thu, Jun 25, 2020 at 11:03:35PM +0100, Beata Michalska wrote: > On ARMv7 & ARMv8 some load/store instructions might trigger a data abort > exception with no valid ISS info to be decoded. The lack of decode info > makes it at least tricky to emulate those instruction which is one of the > (many)

[Bug 1885247] Re: Build error in Intel 32-bit hosts

2020-06-26 Thread Peter Maydell
I suspect an extra uintptr_t cast will fix this: p = (void *)(uintptr_t)(((uintptr_t)iter->map & TARGET_PAGE_MASK) | off_in_page); Which looks kind of ugly but then the code is taking a host void* (iter->map), casting it to integer to do arithmetic on and then wanting to get it back to a void*

[PULL 11/22] adb: introduce new ADBDeviceHasData method to ADBDeviceClass

2020-06-26 Thread Mark Cave-Ayland
This is required later to allow devices to assert a service request (SRQ) signal to indicate that it has data to send, without having to consume it. Signed-off-by: Mark Cave-Ayland Tested-by: Finn Thain Acked-by: Laurent Vivier Message-Id:

[PULL 05/22] pmu: honour autopoll_rate_ms when rearming the ADB autopoll timer

2020-06-26 Thread Mark Cave-Ayland
Don't use a fixed value but instead use the default value from the ADB bus state. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Tested-by: Finn Thain Acked-by: Laurent Vivier Message-Id: <20200623204936.24064-6-mark.cave-ayl...@ilande.co.uk> --- hw/misc/macio/pmu.c | 4

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-26 Thread Janosch Frank
On 6/26/20 11:32 AM, Daniel P. Berrangé wrote: > On Fri, Jun 26, 2020 at 11:01:58AM +0200, Janosch Frank wrote: >> On 6/26/20 8:53 AM, David Hildenbrand wrote: >>> Does this have any implications when probing with the 'none' machine? >> >> I'm not sure. In your case, I guess the cpu

[ PATCH 2/5] haiku build fix

2020-06-26 Thread David CARLIER
>From 19a41d406eda976001827d248398d7fb172d140b Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jun 2020 10:38:17 + Subject: [PATCH 2/5] Enable *pty API. Signed-off-by: David Carlier --- configure | 9 + util/qemu-openpty.c | 2 +- 2 files changed, 10

[PATCH 5/5] haiku build fix

2020-06-26 Thread David CARLIER
>From 68d4d4312eccd212b4d2484e09425816ebd2346a Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jun 2020 11:01:54 + Subject: [PATCH 5/5] Last chunk of build fix Signed-off-by: David Carlier --- include/qemu/bswap.h | 2 ++ util/Makefile.objs | 2 +- util/compatfd.c | 2 ++

Re: [PATCH v5 0/5] VIRTIO-IOMMU probe request support and MSI bypass on ARM

2020-06-26 Thread Jean-Philippe Brucker
On Wed, Jun 24, 2020 at 09:47:59AM -0400, Michael S. Tsirkin wrote: > On Wed, Jun 24, 2020 at 03:26:20PM +0200, Eric Auger wrote: > > By default the virtio-iommu translates MSI transactions. This > > behavior is inherited from ARM SMMU. However the virt machine > > code knows where the MSI

Re: [PATCH v3] build: Haiku build fix

2020-06-26 Thread Peter Maydell
On Thu, 25 Jun 2020 at 22:31, David CARLIER wrote: > > From 78706a28c6aa8b5e522b5781588b38961d79d6f6 Mon Sep 17 00:00:00 2001 > From: David Carlier > Date: Thu, 25 Jun 2020 19:32:42 + > Subject: [PATCH] build: haiku system build fix > > Most of missing features resides in the bsd library. >

Re: [PATCH v5 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-06-26 Thread Markus Armbruster
Auger Eric writes: > Hi Markus, > On 6/25/20 9:05 AM, Markus Armbruster wrote: >> Eric Auger writes: >> >>> This patch implements the PROBE request. At the moment, >>> only THE RESV_MEM property is handled. The first goal is >>> to report iommu wide reserved regions such as the MSI regions >>>

[PULL 18/22] mac_via: move VIA1 portB write logic into mos6522_q800_via1_write()

2020-06-26 Thread Mark Cave-Ayland
Currently the logic is split between the mos6522 portB_write() callback and the memory region used to capture the VIA1 MMIO accesses. Move everything into the latter mos6522_q800_via1_write() function to keep all the logic in one place to make it easier to follow. Signed-off-by: Mark Cave-Ayland

[PULL 21/22] adb: use adb_device prefix for ADB device trace events

2020-06-26 Thread Mark Cave-Ayland
This is to allow us to distinguish between ADB device events and ADB bus events separately. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Tested-by: Finn Thain Acked-by: Laurent Vivier Message-Id: <20200623204936.24064-22-mark.cave-ayl...@ilande.co.uk> ---

[PULL 17/22] pmu: add adb_autopoll_block() and adb_autopoll_unblock() functions

2020-06-26 Thread Mark Cave-Ayland
Ensure that the PMU buffer is protected from autopoll requests overwriting its contents whilst existing PMU requests are in progress. Signed-off-by: Mark Cave-Ayland Tested-by: Finn Thain Acked-by: Laurent Vivier Message-Id: <20200623204936.24064-18-mark.cave-ayl...@ilande.co.uk> ---

[PULL 22/22] adb: add ADB bus trace events

2020-06-26 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Tested-by: Finn Thain Acked-by: Laurent Vivier Message-Id: <20200623204936.24064-23-mark.cave-ayl...@ilande.co.uk> --- hw/input/adb.c| 21 - hw/input/trace-events | 7 +++ 2 files changed, 27

[PULL 14/22] adb: use adb_request() only for explicit requests

2020-06-26 Thread Mark Cave-Ayland
Currently adb_request() is called both for explicit ADB requests and internal autopoll requests via adb_poll(). Move the current functionality into do_adb_request() to be used internally and add a simple adb_request() wrapper for explicit requests. Signed-off-by: Mark Cave-Ayland Tested-by:

[PULL 15/22] adb: add autopoll_blocked variable to block autopoll

2020-06-26 Thread Mark Cave-Ayland
Whilst autopoll is enabled it is necessary to prevent the ADB buffer contents from being overwritten until the host has read back the response in its entirety. Add adb_autopoll_block() and adb_autopoll_unblock() functions in preparation for ensuring that the ADB buffer contents are protected for

Re: [PATCH v4 6/8] s390/sclp: add extended-length sccb support for kvm guest

2020-06-26 Thread Cornelia Huck
On Wed, 24 Jun 2020 16:23:10 -0400 Collin Walling wrote: > As more features and facilities are added to the Read SCP Info (RSCPI) > response, more space is required to store them. The space used to store > these new features intrudes on the space originally used to store CPU > entries. This

Re: [PATCH v1 1/2] semihosting: defer connect_chardevs a little more to use serialx

2020-06-26 Thread Fred Konrad
Le 6/16/20 à 4:52 PM, Alex Bennée a écrit : kon...@adacore.com writes: From: KONRAD Frederic With that we can just use chardev=serial0. I don't quite follow what this means. ./aarch64-softmmu/qemu-system-aarch64 -cpu max -monitor none -chardev=serial0 -M virt -display none

[PULL 1/4] spapr: Simplify some warning printing paths in spapr_caps.c

2020-06-26 Thread David Gibson
From: Greg Kurz We obviously only want to print a warning in these cases, but this is done in a rather convoluted manner. Just use warn_report() instead. Signed-off-by: Greg Kurz Message-Id: <159188281098.70166.18387926536399257573.st...@bahia.lan> Reviewed-by: Vladimir Sementsov-Ogievskiy

[PULL 3/4] ppc/pnv: Silence missing BMC warning with qtest

2020-06-26 Thread David Gibson
From: Greg Kurz The device introspect test in qtest emits some warnings with the the pnv machine types during the "nodefaults" phase: TEST check-qtest-ppc64: tests/qtest/device-introspect-test qemu-system-ppc64: warning: machine has no BMC device. Use '-device ipmi-bmc-sim,id=bmc0 -device

Re: [PATCH v2 00/22] ADB: fix autopoll issues and rework mac_via state machine

2020-06-26 Thread Laurent Vivier
Le 23/06/2020 à 22:49, Mark Cave-Ayland a écrit : > This patchset is something I have been chipping away at for a while since > spending some time over the Christmas holidays trying to boot the MacOS > toolbox ROM on the new q800 machine. > > Initially I discovered that there were some problems

[PATCH v5 10/21] virtio-mem: Paravirtualized memory hot(un)plug

2020-06-26 Thread David Hildenbrand
This is the very basic/initial version of virtio-mem. An introduction to virtio-mem can be found in the Linux kernel driver [1]. While it can be used in the current state for hotplug of a smaller amount of memory, it will heavily benefit from resizeable memory regions in the future. Each

[PATCH v5 09/21] migration/colo: Use ram_block_discard_disable()

2020-06-26 Thread David Hildenbrand
COLO will copy all memory in a RAM block, disable discarding of RAM. Reviewed-by: Dr. David Alan Gilbert Tested-by: Lukas Straub Cc: "Michael S. Tsirkin" Cc: Hailiang Zhang Cc: Juan Quintela Cc: "Dr. David Alan Gilbert" Signed-off-by: David Hildenbrand --- include/migration/colo.h | 2 +-

[PATCH v5 03/21] vfio: Convert to ram_block_discard_disable()

2020-06-26 Thread David Hildenbrand
VFIO is (except devices without a physical IOMMU or some mediated devices) incompatible with discarding of RAM. The kernel will pin basically all VM memory. Let's convert to ram_block_discard_disable(), which can now fail, in contrast to qemu_balloon_inhibit(). Leave "x-balloon-allowed" named as

[PATCH v5 06/21] virtio-balloon: Rip out qemu_balloon_inhibit()

2020-06-26 Thread David Hildenbrand
The only remaining special case is postcopy. It cannot handle concurrent discards yet, which would result in requesting already sent pages from the source. Special-case it in virtio-balloon instead. Introduce migration_in_incoming_postcopy(), to find out if incoming postcopy is active.

[PATCH v5 00/21] virtio-mem: Paravirtualized memory hot(un)plug

2020-06-26 Thread David Hildenbrand
This is the very basic, initial version of virtio-mem. More info on virtio-mem in general can be found in the Linux kernel driver v2 posting [1] and in patch #10. The Linux driver is now upstream. This series now contains a resend of [3]: "[PATCH v1] pc: Support coldplugging of

[PATCH v5 15/21] pc: Support for virtio-mem-pci

2020-06-26 Thread David Hildenbrand
Let's wire it up similar to virtio-pmem. Also disallow unplug, so it's harder for users to shoot themselves into the foot. Reviewed-by: Pankaj Gupta Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Cc: Eric Blake Cc: Markus

[PATCH v5 18/21] virtio-mem: Migration sanity checks

2020-06-26 Thread David Hildenbrand
We want to make sure that certain properties don't change during migration, especially to catch user errors in a nice way. Let's migrate a temporary structure and validate that the properties didn't change. Reviewed-by: Dr. David Alan Gilbert Cc: "Michael S. Tsirkin" Cc: "Dr. David Alan

Re: [PATCH v2 00/22] ADB: fix autopoll issues and rework mac_via state machine

2020-06-26 Thread Mark Cave-Ayland
On 26/06/2020 08:14, Laurent Vivier wrote: > Le 23/06/2020 à 22:49, Mark Cave-Ayland a écrit : >> This patchset is something I have been chipping away at for a while since >> spending some time over the Christmas holidays trying to boot the MacOS >> toolbox ROM on the new q800 machine. >> >>

[PULL 10/22] mac_via: convert to use ADBBusState internal autopoll variables

2020-06-26 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland Tested-by: Finn Thain Acked-by: Laurent Vivier Message-Id: <20200623204936.24064-11-mark.cave-ayl...@ilande.co.uk> --- hw/misc/mac_via.c | 22 ++ include/hw/misc/mac_via.h | 1 - 2 files changed, 10 insertions(+), 13 deletions(-)

[PULL 13/22] adb: add status field for holding information about the last ADB request

2020-06-26 Thread Mark Cave-Ayland
Currently only 2 bits are defined: one to indicate if the request timed out (no reply) and another to indicate whether the request was the result of an autopoll operation. Signed-off-by: Mark Cave-Ayland Tested-by: Finn Thain Acked-by: Laurent Vivier Message-Id:

[PULL 07/22] adb: create autopoll variables directly within ADBBusState

2020-06-26 Thread Mark Cave-Ayland
Rather than each ADB implementation requiring its own functions to manage autopoll state, timers, and autopoll masks prepare to move this information directly into ADBBusState. Add external functions within adb.h to allow each ADB implementation to manage the new autopoll variables.

[PULL 12/22] adb: keep track of devices with pending data

2020-06-26 Thread Mark Cave-Ayland
Add a new pending variable to ADBBusState which is a bitmask indicating which ADB devices have data to send. Update the bitmask every time that an ADB request is executed. Signed-off-by: Mark Cave-Ayland Tested-by: Finn Thain Acked-by: Laurent Vivier Message-Id:

[PULL 19/22] mac_via: rework ADB state machine to be compatible with both MacOS and Linux

2020-06-26 Thread Mark Cave-Ayland
The existing ADB state machine is designed to work with Linux which has a different interpretation of the state machine detailed in "Guide to the Macintosh Family Hardware". In particular the current Linux implementation includes an extra change to IDLE state when switching the VIA between send

Re: [PATCH v3 0/9] Generalize memory encryption models

2020-06-26 Thread Daniel P . Berrangé
On Fri, Jun 26, 2020 at 11:01:58AM +0200, Janosch Frank wrote: > On 6/26/20 8:53 AM, David Hildenbrand wrote: > > Does this have any implications when probing with the 'none' machine? > > I'm not sure. In your case, I guess the cpu bit would still show up > as before, so it

Re: [Bug 1885247] [NEW] Build error in Intel 32-bit hosts

2020-06-26 Thread Philippe Mathieu-Daudé
On 6/26/20 11:20 AM, Thomas Huth wrote: > On 26/06/2020 11.13, Philippe Mathieu-Daudé wrote: >> On 6/26/20 9:37 AM, Aleksandar Markovic wrote: >>> пет, 26. јун 2020. у 09:11 Aleksandar Markovic >>> <1885...@bugs.launchpad.net> је написао/ла: Public bug reported: The code base

Re: [PATCH v4 4/8] hw/misc/pca9552: Add a 'description' property for debugging purpose

2020-06-26 Thread Philippe Mathieu-Daudé
On 6/26/20 7:49 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> On 6/25/20 10:12 AM, Philippe Mathieu-Daudé wrote: >>> On 6/25/20 8:37 AM, Markus Armbruster wrote: Cédric Le Goater writes: > On 6/22/20 10:31 AM, Philippe Mathieu-Daudé wrote: >> On 6/22/20

QEMU | Pipeline #160380996 has failed for master | 5acc270a

2020-06-26 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 5acc270a ( https://gitlab.com/qemu-project/qemu/-/commit/5acc270a355120ce967ca1f1eeca0abbdb9303c8 ) Commit Message: Merge

[PATCH 4/5] haiku build fix

2020-06-26 Thread David CARLIER
>From 775173ded5657de4d4b467f2f68e747f6a9c0750 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jun 2020 10:44:36 + Subject: [PATCH 4/5] Platform specific changes qemu_exec_dir implementation Signed-off-by: David Carlier --- include/qemu/osdep.h | 4 util/oslib-posix.c |

[PATCH 1/5] haiku build fix

2020-06-26 Thread David CARLIER
>From 4d0933384d2bfcd0fc8c4c06eed2d07f3f1b7f8b Mon Sep 17 00:00:00 2001 From: David Carlier Date: Fri, 26 Jun 2020 10:35:40 + Subject: [PATCH 1/5] Haiku build fix enabling BSD symbols. Signed-off-by: David Carlier --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

RE: [PATCH v2 3/3] usb/hcd-xhci: Split pci wrapper for xhci base model

2020-06-26 Thread Sai Pavan Boddu
HI Markus, > -Original Message- > From: Markus Armbruster > Sent: Friday, June 26, 2020 11:42 AM > To: Sai Pavan Boddu > Cc: Peter Maydell ; Thomas Huth > ; Eduardo Habkost ; qemu- > de...@nongnu.org; Alistair Francis ; Gerd > Hoffmann ; Paolo Bonzini ; > Ying Fang ; 'Marc-André Lureau'

Re: [PATCH v3 1/3] riscv: Unify Qemu's reset vector code path

2020-06-26 Thread Bin Meng
On Fri, Jun 26, 2020 at 8:33 AM Atish Patra wrote: > > Currently, all riscv machines except sifive_u have identical reset vector > code implementations with memory addresses being different for all machines. > They can be easily combined into a single function in common code. > > Move it to

Re: [PULL 00/12] Block patches

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 02:31:14PM +0100, Peter Maydell wrote: > On Wed, 24 Jun 2020 at 11:02, Stefan Hajnoczi wrote: > > > > The following changes since commit 171199f56f5f9bdf1e5d670d09ef1351d8f01bae: > > > > Merge remote-tracking branch > >

Re: [PATCH 3/3] virtiofsd: Allow addition or removal of capabilities

2020-06-26 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 05:29:29PM +0100, Dr. David Alan Gilbert (git) wrote: > +/* > + * The modcaps option is a colon separated list of caps, > + * each preceded by either + or -. > + */ > +while (lo->modcaps) { > +capng_act_t action; > +int cap; > + > +

[PATCH v6 0/5] VIRTIO-IOMMU probe request support and MSI bypass on ARM

2020-06-26 Thread Eric Auger
By default the virtio-iommu translates MSI transactions. This behavior is inherited from ARM SMMU. However the virt machine code knows where the MSI doorbells are, so we can easily declare those regions as VIRTIO_IOMMU_RESV_MEM_T_MSI. With that setting the guest iommu subsystem will not need to

Re: [PATCH v3 8/9] spapr: PEF: block migration

2020-06-26 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > We haven't yet implemented the fairly involved handshaking that will be > needed to migrate PEF protected guests. For now, just use a migration > blocker so we get a meaningful error if someone attempts this (this is the > same approach used

  1   2   3   4   5   6   >