RE: [PATCH 1/2] hw/386: Fix uninitialized memory with -device and CPU hotplug

2020-06-29 Thread Babu Moger
> -Original Message- > From: Moger, Babu > Sent: Thursday, June 25, 2020 5:55 PM > To: Igor Mammedov > Cc: ehabk...@redhat.com; m...@redhat.com; qemu-devel@nongnu.org; > pbonz...@redhat.com; r...@twiddle.net > Subject: Re: [PATCH 1/2] hw/386: Fix uninitialized memory with -device and

[PATCH] hw/block/nvme: make lba data size configurable

2020-06-29 Thread Klaus Jensen
From: Klaus Jensen Allos the LBA data size (lbads) to be set between 9 and 12. Signed-off-by: Klaus Jensen Acked-by: Keith Busch Reviewed-by: Maxim Levitsky Reviewed-by: Philippe Mathieu-Daudé --- Based-on: <20200629214051.1282060-1-...@irrelevant.dk> ("[PATCH v2 0/4] hw/block/nvme: support

Re: [PATCH 04/10] spice: Move all the spice-related code in spice-app.so

2020-06-29 Thread Gerd Hoffmann
Hi, > common-obj-y = audio.o audio_legacy.o noaudio.o wavaudio.o mixeng.o > -common-obj-$(CONFIG_SPICE) += spiceaudio.o > +spice-app.mo-objs += ../audio/spiceaudio.o Hmm. audio/audio.c will try to load audio-${backend}.so when you run qemu -audiodev ${backend}, so I suspect this is not going

Re: [PATCH v2 03/18] hw/block/nvme: Clean up unused AER definitions

2020-06-29 Thread Alistair Francis
On Wed, Jun 17, 2020 at 2:48 PM Dmitry Fomichev wrote: > > Removed unused struct NvmeAerResult and SMART-related async event > codes. All other event codes are now categorized by their type. > This avoids having to define the same values in a single enum, > NvmeAsyncEventRequest, that is now

Re: [PATCH v2 05/18] hw/block/nvme: Introduce the Namespace Types definitions

2020-06-29 Thread Alistair Francis
On Wed, Jun 17, 2020 at 2:47 PM Dmitry Fomichev wrote: > > From: Niklas Cassel > > Define the structures and constants required to implement > Namespace Types support. > > Signed-off-by: Niklas Cassel > Signed-off-by: Dmitry Fomichev > --- > hw/block/nvme.h | 3 ++ >

[Bug 1869858] Re: qemu can't start Windows10arm64 19H1(with kvm)

2020-06-29 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1869858 Title: qemu can't

Re: [PATCH 05/10] build: Avoid build failure when building drivers as modules

2020-06-29 Thread Gerd Hoffmann
Hi, > > +# > > +# common-obj-m has some crap here, probably as side effect from > > +# filling obj-y. Clear it. Fixes suspicious dependency errors when > > +# building devices as modules. > > +# > > +common-obj-m := > > This comment doesn't fill me with confidence - makes it feel like

Re: [PATCH v3 2/3] RISC-V: Copy the fdt in dram instead of ROM

2020-06-29 Thread Bin Meng
On Tue, Jun 30, 2020 at 2:50 AM Atish Patra wrote: > > On Sat, Jun 27, 2020 at 2:55 AM Bin Meng wrote: > > > > On Sat, Jun 27, 2020 at 12:37 PM Atish Patra wrote: > > > > > > On Fri, Jun 26, 2020 at 7:54 PM Bin Meng wrote: > > > > > > > > Hi Atish, > > > > > > > > On Sat, Jun 27, 2020 at 12:58

Re: [PATCH v2 01/18] hw/block/nvme: Move NvmeRequest has_sg field to a bit flag

2020-06-29 Thread Alistair Francis
On Wed, Jun 17, 2020 at 2:43 PM Dmitry Fomichev wrote: > > In addition to the existing has_sg flag, a few more Boolean > NvmeRequest flags are going to be introduced in subsequent patches. > Convert "has_sg" variable to "flags" and define NvmeRequestFlags > enum for individual flag values. > >

Re: [PATCH v2 02/18] hw/block/nvme: Define 64 bit cqe.result

2020-06-29 Thread Alistair Francis
On Wed, Jun 17, 2020 at 2:44 PM Dmitry Fomichev wrote: > > From: Ajay Joshi > > A new write command, Zone Append, is added as a part of Zoned > Namespace Command Set. Upon successful completion of this command, > the controller returns the start LBA of the performed write operation > in

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-06-29 Thread BALATON Zoltan
On Mon, 29 Jun 2020, Markus Armbruster wrote: BALATON Zoltan writes: On Sat, 27 Jun 2020, Markus Armbruster wrote: Quick reply without having thought through the issues at all: I'm not Does that mean you'll reply later with more detail or this is all you had to say about this? (Just to know

[PATCH] hw/block/nvme: add support for dulbe

2020-06-29 Thread Klaus Jensen
From: Klaus Jensen This adds support for reporting the Deallocated or Unwritten Logical Block error (DULBE). This requires tracking the allocated/deallocated status of all logical blocks. Introduce a bitmap that does this. The bitmap is persisted on the new 'state' drive that is associated with

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-29 Thread Yonggang Luo
Wonderful work, May I reproduce the work on my local machine? On Mon, Jun 29, 2020 at 6:26 PM Ahmed Karaman wrote: > Hi, > > The second report of the TCG Continuous Benchmarking series builds > upon the QEMU performance metrics calculated in the previous report. > This report presents a method

[PATC 7/9] Skipping drm build, unsupported

2020-06-29 Thread David CARLIER
>From 157a0374093371719de42e99364352d64190f52a Mon Sep 17 00:00:00 2001 From: David Carlier Date: Mon, 29 Jun 2020 22:20:06 + Subject: [PATCH 7/9] Skipping drm build, unsupported. Signed-off-by: David Carlier --- util/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 1/9] Enabling BSD symbols

2020-06-29 Thread David CARLIER
>From 5c6022f21289eb6e78e93d584c766db82165dced Mon Sep 17 00:00:00 2001 From: David Carlier Date: Mon, 29 Jun 2020 22:13:35 + Subject: [PATCH 1/9] Enabling BSD symbols. Signed-off-by: David Carlier --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 3/9] Checking mlockall symbol presence

2020-06-29 Thread David CARLIER
>From ac450c4abe03e0e461fede18727500e616d9f7e2 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Mon, 29 Jun 2020 22:15:21 + Subject: [PATCH 3/9] Checking mlockall symbol presence. Signed-off-by: David Carlier --- configure | 15 +++ os-posix.c | 4 2 files changed, 19

PATCH [0/9]: haiku build fix

2020-06-29 Thread David CARLIER
>From fcdb25804af98329b52a04e7a4e5191135aac4f6 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Mon, 29 Jun 2020 22:36:32 + Subject: [PATCH 0/9] *** SUBJECT HERE *** *** BLURB HERE *** David Carlier (9): Enabling BSD symbols. Enabling *pty api Checking mlockall symbol presence.

Re: [PATCH] hw/ppc/ppc4xx: Only accept (combination of) pow2 DDR sizes

2020-06-29 Thread BALATON Zoltan
On Mon, 29 Jun 2020, Philippe Mathieu-Daudé wrote: Use popcount instruction to count the number of bits set in the RAM size. Allow at most 1 bit for each bank. This avoid using invalid hardware configurations. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/ppc4xx_devs.c | 9 + 1 file

Re: [PATCH v2 04/18] hw/block/nvme: Add Commands Supported and Effects log

2020-06-29 Thread Alistair Francis
On Wed, Jun 17, 2020 at 3:05 PM Dmitry Fomichev wrote: > > This log page becomes necessary to implement to allow checking for > Zone Append command support in Zoned Namespace Command Set. > > This commit adds the code to report this log page for NVM Command > Set only. The parts that are specific

[PATCH 1/3] hw/block/nvme: add NVMe 1.4 specific fields

2020-06-29 Thread Klaus Jensen
From: Klaus Jensen Add new fields from NVM Express v1.4. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 3 +- include/block/nvme.h | 195 +-- 2 files changed, 172 insertions(+), 26 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c

[PATCH 0/3] hw/block/nvme: bump to v1.4

2020-06-29 Thread Klaus Jensen
From: Klaus Jensen This bumps the supported version to v1.4 and adds the CSE log page. Based-on: <20200630042304.1305269-1-...@irrelevant.dk> ("[PATCH] hw/block/nvme: add support for dulbe") Gollu Appalanaidu (1): hw/block/nvme: add commands supported and effects log page Klaus Jensen (2):

[PATCH 2/3] hw/block/nvme: add commands supported and effects log page

2020-06-29 Thread Klaus Jensen
From: Gollu Appalanaidu This is to support for the Commands Supported and Effects log page. See NVM Express Spec 1.3d, sec. 5.14.1.5 ("Commands Supported and Effects") Signed-off-by: Gollu Appalanaidu Co-authored-by: Klaus Jensen --- hw/block/nvme.c | 20 +++-

Re: [PATCH v2 05/18] hw/block/nvme: Introduce the Namespace Types definitions

2020-06-29 Thread Klaus Jensen
On Jun 18 06:34, Dmitry Fomichev wrote: > From: Niklas Cassel > > Define the structures and constants required to implement > Namespace Types support. > > Signed-off-by: Niklas Cassel > Signed-off-by: Dmitry Fomichev > --- > hw/block/nvme.h | 3 ++ > include/block/nvme.h | 75

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier

2020-06-29 Thread Jason Wang
On 2020/6/29 下午9:34, Peter Xu wrote: On Mon, Jun 29, 2020 at 01:51:47PM +0800, Jason Wang wrote: On 2020/6/28 下午10:47, Peter Xu wrote: On Sun, Jun 28, 2020 at 03:03:41PM +0800, Jason Wang wrote: On 2020/6/27 上午5:29, Peter Xu wrote: Hi, Eugenio, (CCing Eric, Yan and Michael too) On Fri,

Re: [PATCH v2 01/18] hw/block/nvme: Move NvmeRequest has_sg field to a bit flag

2020-06-29 Thread Klaus Jensen
On Jun 18 06:33, Dmitry Fomichev wrote: > In addition to the existing has_sg flag, a few more Boolean > NvmeRequest flags are going to be introduced in subsequent patches. > Convert "has_sg" variable to "flags" and define NvmeRequestFlags > enum for individual flag values. > > Signed-off-by:

Re: [PATCH v2 03/18] hw/block/nvme: Clean up unused AER definitions

2020-06-29 Thread Klaus Jensen
On Jun 18 06:34, Dmitry Fomichev wrote: > Removed unused struct NvmeAerResult and SMART-related async event > codes. All other event codes are now categorized by their type. > This avoids having to define the same values in a single enum, > NvmeAsyncEventRequest, that is now removed. > > Later

Re: Building in Solaris 11.4

2020-06-29 Thread Thomas Huth
On 29/06/2020 22.25, Michele Denber wrote: On 06-29-2020 8:12 AM, Thomas Huth wrote: ... It's not the same bug as last year, but a new one: Seems like newer versions of Solaris now have this functions in their libraries! Yes - I just checked. Solaris 10 does not have openpty, but Solaris 11.4

[PATCH 8/9] Skipping sys/syscall.h inclusion as only used in qemu_signalfd anyway

2020-06-29 Thread David CARLIER
>From b821b7e9bbf1f327058ee858a92c7a7ee6740e63 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Mon, 29 Jun 2020 22:20:39 + Subject: [PATCH 8/9] Skipping sys/syscall.h inclusion as only used in qemu_signalfd anyway. Signed-off-by: David Carlier --- util/compatfd.c | 2 ++ 1 file

Re: [PATCH v2 02/18] hw/block/nvme: Define 64 bit cqe.result

2020-06-29 Thread Klaus Jensen
On Jun 18 06:33, Dmitry Fomichev wrote: > From: Ajay Joshi > > A new write command, Zone Append, is added as a part of Zoned > Namespace Command Set. Upon successful completion of this command, > the controller returns the start LBA of the performed write operation > in cqe.result field.

[PATCH 3/3] hw/block/nvme: add trace event for requests with non-zero status code

2020-06-29 Thread Klaus Jensen
From: Klaus Jensen If a command results in a non-zero status code, trace it. Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 5 + hw/block/trace-events | 1 + 2 files changed, 6 insertions(+) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 9f1a1ba03b8a..25d79bcd0bc9 100644

[PATCH 5/9] Define SIGIO constant with SIGPOLL equivalence

2020-06-29 Thread David CARLIER
>From 93c001e7da19c76a73a687dc6584bc31385a2693 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Mon, 29 Jun 2020 22:18:32 + Subject: [PATCH 5/9] Define SIGIO constant with SIGPOLL equivalence, Signed-off-by: David Carlier --- include/qemu/osdep.h | 4 1 file changed, 4 insertions(+)

[PATCH 6/9] Including endian.h for bswap operations

2020-06-29 Thread David CARLIER
>From 2f65cab41a8f4508532b3893815f222bf2293463 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Mon, 29 Jun 2020 22:19:34 + Subject: [PATCH 6/9] Including endian.h for bswap operations. Signed-off-by: David Carlier --- include/qemu/bswap.h | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH 9/9] Implementing qemu_init_exec_dir.

2020-06-29 Thread David CARLIER
>From fcdb25804af98329b52a04e7a4e5191135aac4f6 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Mon, 29 Jun 2020 22:36:03 + Subject: [PATCH 9/9] Implementing qemu_init_exec_dir. Signed-off-by: David Carlier --- util/oslib-posix.c | 19 +++ 1 file changed, 19 insertions(+)

[PATCH 2/9] Enabling *pty api

2020-06-29 Thread David CARLIER
>From 8b205a027dacad08ce9187474d9490667904a4e2 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Mon, 29 Jun 2020 22:14:53 + Subject: [PATCH 2/9] Enabling *pty api Signed-off-by: David Carlier --- configure | 9 + util/qemu-openpty.c | 2 +- 2 files changed, 10

[PATCH 4/9] Checking sys/signal.h presence.

2020-06-29 Thread David CARLIER
>From 9d43c8cd1611d0347db9066b1df1dc34431b2028 Mon Sep 17 00:00:00 2001 From: David Carlier Date: Mon, 29 Jun 2020 22:17:53 + Subject: [PATCH 4/9] Checking sys/signal.h presence. Signed-off-by: David Carlier --- configure | 8 hw/xen/xen-legacy-backend.c | 1 -

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-29 Thread Lukáš Doktor
Dne 29. 06. 20 v 12:25 Ahmed Karaman napsal(a): > Hi, > > The second report of the TCG Continuous Benchmarking series builds > upon the QEMU performance metrics calculated in the previous report. > This report presents a method to dissect the number of instructions > executed by a QEMU invocation

Re: [PATCH v2 04/18] hw/block/nvme: Add Commands Supported and Effects log

2020-06-29 Thread Klaus Jensen
On Jun 18 06:34, Dmitry Fomichev wrote: > This log page becomes necessary to implement to allow checking for > Zone Append command support in Zoned Namespace Command Set. > > This commit adds the code to report this log page for NVM Command > Set only. The parts that are specific to zoned

QEMU | Pipeline #161336114 has failed for master | fc1bff95

2020-06-29 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: fc1bff95 ( https://gitlab.com/qemu-project/qemu/-/commit/fc1bff958998910ec8d25db86cd2f53ff125f7ab ) Commit Message:

Re: [PATCH 09/10] spice: Put spice functions in a separate load module

2020-06-29 Thread Gerd Hoffmann
Hi, > > If so the more normal approach would be to have a struct defining > > a set of callbacks, that can be registered. Or if there's a natural > > fit with QOM, then a QOM interface that can then have a QOM object > > impl registered as a singleton. > > That was my second attempt (after the

Re: [PATCH 08/10] build: Add SPICE_CFLAGS and SPICE_LIBS to relevant files

2020-06-29 Thread Gerd Hoffmann
Hi, > obj-$(CONFIG_PC) += pc.o pc_sysfw.o > +pc.o-cflags += $(SPICE_CFLAGS) Hmm, looks strange. Why does pc.c need spice? > +qmp-cmds.o-cflags += $(SPICE_CFLAGS) > +hmp-cmds.o-cflags += $(SPICE_CFLAGS) spice monitor commands need this I guess? > +misc.o-cflags += $(SPICE_CFLAGS) Why

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-29 Thread Ahmed Karaman
On Mon, Jun 29, 2020 at 6:03 PM Alex Bennée wrote: > > > Ahmed Karaman writes: > > > Hi, > > > > The second report of the TCG Continuous Benchmarking series builds > > upon the QEMU performance metrics calculated in the previous report. > > This report presents a method to dissect the number of

Re: [PATCH 0/2] hw/block/nvme: handle transient dma errors

2020-06-29 Thread Klaus Jensen
On Jun 29 14:07, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200629202053.1223342-1-...@irrelevant.dk/ > > > > Hi, > > This series failed the docker-quick@centos7 build test. Please find the > testing commands and > their output below. If you have Docker

[PATCH v2 2/4] hw/block/nvme: support multiple namespaces

2020-06-29 Thread Klaus Jensen
From: Klaus Jensen This adds support for multiple namespaces by introducing a new 'nvme-ns' device model. The nvme device creates a bus named from the device name ('id'). The nvme-ns devices then connect to this and registers themselves with the nvme device. This changes how an nvme device is

Re: [PATCH] hw/misc/pca9552: Add missing TypeInfo::class_size field

2020-06-29 Thread Peter Maydell
On Mon, 29 Jun 2020 at 08:47, Philippe Mathieu-Daudé wrote: > > When adding the generic PCA955xClass in commit 736132e455, we > forgot to set the class_size field. Fill it now to avoid: Thanks; I've applied this to master since it fixes a memory corruption that affects all arm targets and I'm

Re: [PATCH 0/2] hw/block/nvme: handle transient dma errors

2020-06-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200629202053.1223342-1-...@irrelevant.dk/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

Re: [PATCH 4/5] hw/i2c: Rename i2c_create_slave() as i2c_slave_create_simple()

2020-06-29 Thread Corey Minyard
On Mon, Jun 29, 2020 at 07:38:20PM +0200, Philippe Mathieu-Daudé wrote: > We use "create_simple" names for functions that allocate, initialize, > configure and realize device objects: pci_create_simple(), > isa_create_simple(), usb_create_simple(). For consistency, rename > i2c_create_slave() as

Re: [PATCH 3/5] hw/i2c: Rename i2c_realize_and_unref() as i2c_slave_realize_and_unref()

2020-06-29 Thread Corey Minyard
On Mon, Jun 29, 2020 at 07:38:19PM +0200, Philippe Mathieu-Daudé wrote: > The other i2c functions are called i2c_slave_FOO(). Rename as > i2c_slave_realize_and_unref() to be consistent. Reviewed-by: Corey Minyard > > Suggested-by: Markus Armbruster > Signed-off-by: Philippe Mathieu-Daudé >

Re: [PATCH 2/5] hw/i2c: Rename i2c_try_create_slave() as i2c_slave_new()

2020-06-29 Thread Corey Minyard
On Mon, Jun 29, 2020 at 07:38:18PM +0200, Philippe Mathieu-Daudé wrote: > We use "new" names for functions that allocate and initialize > device objects: pci_new(), isa_new(), usb_new(). > Let's call this one i2c_slave_new(). Since we have to update > all the callers, also let it return a I2CSlave

Re: [PATCH 0/5] hw/i2c: Rename method names for consistency and add documentation

2020-06-29 Thread Corey Minyard
On Mon, Jun 29, 2020 at 07:38:16PM +0200, Philippe Mathieu-Daudé wrote: > In commit d88c42ff2c we added 2 methods: i2c_try_create_slave() > and i2c_realize_and_unref(). > Markus noted their name could be improved for consistency [1], > and Peter reported the lack of documentation [2]. Fix that

Re: [PATCH 5/5] hw/i2c: Document the I2C qdev helpers

2020-06-29 Thread Corey Minyard
On Mon, Jun 29, 2020 at 07:38:21PM +0200, Philippe Mathieu-Daudé wrote: > In commit d88c42ff2c we added new prototype but neglected to > add their documentation. Fix that. Reviewed-by: Corey Minyard > > Reported-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH v2 2/4] smbus: Fix spd_data_generate() error API violation

2020-06-29 Thread BALATON Zoltan
On Mon, 29 Jun 2020, Philippe Mathieu-Daudé wrote: On 6/27/20 9:17 AM, Markus Armbruster wrote: BALATON Zoltan writes: On Wed, 22 Apr 2020, BALATON Zoltan wrote: On Wed, 22 Apr 2020, Philippe Mathieu-Daudé wrote: On 4/22/20 4:27 PM, BALATON Zoltan wrote: On Wed, 22 Apr 2020, Markus

Re: [PATCH 2/5] hw/i2c: Rename i2c_try_create_slave() as i2c_slave_new()

2020-06-29 Thread BALATON Zoltan
On Mon, 29 Jun 2020, Philippe Mathieu-Daudé wrote: We use "new" names for functions that allocate and initialize device objects: pci_new(), isa_new(), usb_new(). Let's call this one i2c_slave_new(). Since we have to update all the callers, also let it return a I2CSlave object. All the callers

[PATCH v2 0/4] hw/block/nvme: support multiple namespaces

2020-06-29 Thread Klaus Jensen
From: Klaus Jensen v2: bummer, v1 didn't apply cleanly to master (it applied to Kevin's block tree); rebased to make patchew happy This adds a new 'nvme-ns' device that attaches to the nvme device through a bus. This decouples the nvme controller and nvme namespaces such that multiple

[PATCH v2 4/4] hw/block/nvme: change controller pci id

2020-06-29 Thread Klaus Jensen
From: Klaus Jensen There are two reasons for changing this: 1. The nvme device currently uses an internal Intel device id. 2. Since commits "nvme: fix write zeroes offset and count" and "nvme: support multiple namespaces" the controller device no longer has the quirks that the

[PATCH v2 1/4] hw/block/nvme: refactor identify active namespace id list

2020-06-29 Thread Klaus Jensen
From: Klaus Jensen Prepare to support inactive namespaces. Signed-off-by: Klaus Jensen Reviewed-by: Maxim Levitsky --- hw/block/nvme.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 4bcd114f76b1..eaee420219fd 100644 ---

[PATCH v2 3/4] pci: allocate pci id for nvme

2020-06-29 Thread Klaus Jensen
From: Klaus Jensen The emulated nvme device (hw/block/nvme.c) is currently using an internal Intel device id. Prepare to change that by allocating a device id under the 1b36 (Red Hat, Inc.) vendor id. Signed-off-by: Klaus Jensen Acked-by: Keith Busch Acked-by: Gerd Hoffmann Reviewed-by:

[PATCH 1/3] target/nios2: add DISAS_NORETURN case for nothing more to generate

2020-06-29 Thread Wentong Wu
Add DISAS_NORETURN case for nothing more to generate because at runtime execution will never return from some helper call. And at the same time replace DISAS_UPDATE in t_gen_helper_raise_exception and gen_exception with the newly added DISAS_NORETURN. Signed-off-by: Wentong Wu ---

[PATCH 2/3] target/nios2: in line the semantics of DISAS_UPDATE with other targets

2020-06-29 Thread Wentong Wu
In line the semantics of DISAS_UPDATE on nios2 target with other targets which is to explicitly write the PC back into the cpu state before doing a tcg_gen_exit_tb(). Signed-off-by: Wentong Wu --- target/nios2/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 09/46] error: Avoid error_propagate() after migrate_add_blocker()

2020-06-29 Thread Vladimir Sementsov-Ogievskiy
24.06.2020 19:43, Markus Armbruster wrote: When migrate_add_blocker(blocker, ) is followed by error_propagate(errp, err), we can often just as well do migrate_add_blocker(..., errp). Do that with this Coccinelle script: @@ expression blocker, err, errp; expression ret; @@

Re: [PATCH 11/17] hw/misc/max111x: Create header file for documentation, TYPE_ macros

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/28/20 4:24 PM, Peter Maydell wrote: > Create a header file for the hw/misc/max111x device, in the > usual modern style for QOM devices: > * definition of the TYPE_ constants and macros > * definition of the device's state struct so that it can >be embedded in other structs if desired >

Re: [PATCH 06/17] hw/misc/max111x: provide QOM properties for setting initial values

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/28/20 4:24 PM, Peter Maydell wrote: > Add some QOM properties to the max111x ADC device to allow the > initial values to be configured. Currently this is done by > board code calling max111x_set_input() after it creates the > device, which doesn't work on system reset. > > This requires us

Re: [PATCH 07/17] hw/misc/max111x: Don't use vmstate_register()

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/28/20 4:24 PM, Peter Maydell wrote: > The max111x is a proper qdev device; we can use dc->vmsd rather than > directly calling vmstate_register(). > > It's possible that this is a migration compat break, but the only > boards that use this device are the spitz-family ('akita', 'borzoi', >

Re: [PATCH v3 16/30] .gitignore: un-ignore .gitlab-ci.d

2020-06-29 Thread Thomas Huth
On 26/06/2020 20.13, Alex Bennée wrote: The sooner we deprecate in-tree builds the sooner this mess of regexes can be thrown away. Signed-off-by: Alex Bennée --- v2 - just use explicit !/.gitlab-ci.d --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore

Re: [PATCH 11/46] qemu-option: Make uses of find_desc_by_name() more similar

2020-06-29 Thread Vladimir Sementsov-Ogievskiy
29.06.2020 12:36, Vladimir Sementsov-Ogievskiy wrote: 24.06.2020 19:43, Markus Armbruster wrote: This is to make the next commit easier to review. Signed-off-by: Markus Armbruster ---   util/qemu-option.c | 32 ++--   1 file changed, 18 insertions(+), 14

Re: [PATCH 04/10] spice: Move all the spice-related code in spice-app.so

2020-06-29 Thread Daniel P . Berrangé
On Mon, Jun 29, 2020 at 11:22:40AM +0200, Christophe de Dinechin wrote: > > On 2020-06-26 at 19:20 CEST, Daniel P. Berrangé wrote... > > On Fri, Jun 26, 2020 at 06:43:01PM +0200, Christophe de Dinechin wrote: > >> If we want to build spice as a separately loadable module, we need to > >> put all

Re: [PULL 3/6] MAINTAINERS: Add Loongson-3 maintainer and reviewer

2020-06-29 Thread Aleksandar Markovic
понедељак, 29. јун 2020., Philippe Mathieu-Daudé је написао/ла: > On 6/27/20 9:51 PM, Aleksandar Markovic wrote: > > From: Huacai Chen > > > > Add myself as the maintainer for Loongson-3 virtual platforms, and > > also add Jiaxun Yang as the reviewer. > > > > Signed-off-by: Huacai Chen > >

Re: [PATCH v3 19/30] gitlab: build all container images during CI

2020-06-29 Thread Thomas Huth
On 26/06/2020 20.13, Alex Bennée wrote: From: Daniel P. Berrangé We have a number of container images in tests/docker/dockerfiles that are intended to provide well defined environments for doing test builds. We want our CI system to use these containers too. This introduces builds of all of

Re: [PATCH v2 6/9] spapr_pci: add spapr msi read method

2020-06-29 Thread Li Qiang
David Gibson 于2020年6月25日周四 上午10:09写道: > > On Thu, Jun 25, 2020 at 12:25:20AM +0530, P J P wrote: > > From: Prasad J Pandit > > > > Add spapr msi mmio read method to avoid NULL pointer dereference > > issue. > > > > Reported-by: Lei Sun > > Signed-off-by: Prasad J Pandit > Reviewed-by: Li

Re: [PATCH v3 29/30] gitlab: limit re-builds of the containers

2020-06-29 Thread Daniel P . Berrangé
On Fri, Jun 26, 2020 at 07:13:56PM +0100, Alex Bennée wrote: > Most of the time we are just rebuilding the same things. We can skip > this although currently there is no mechanism for picking up new > distro releases. > > Rather than try to be too fine grained allow any change to trigger all >

Re: [PATCH v3 16/30] .gitignore: un-ignore .gitlab-ci.d

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/26/20 8:13 PM, Alex Bennée wrote: > The sooner we deprecate in-tree builds the sooner this mess of regexes > can be thrown away. :S Reviewed-by: Philippe Mathieu-Daudé > > Signed-off-by: Alex Bennée > > --- > v2 > - just use explicit !/.gitlab-ci.d > --- > .gitignore | 1 + > 1 file

Re: [PATCH v3 25/30] tests/docker: add a linux-user testing focused image

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/26/20 8:13 PM, Alex Bennée wrote: > We happily use all the cross images for both cross-building QEMU as > well as building the linux-user tests. However calling docker from > within docker seems not to work. As we can build in Debian anyway why > not include an image that has all the

Re: [PATCH 03/46] qdev: Smooth error checking of qdev_realize() & friends

2020-06-29 Thread Greg Kurz
On Wed, 24 Jun 2020 18:43:01 +0200 Markus Armbruster wrote: > Convert > > foo(..., ); > if (err) { > ... > } > > to > > if (!foo(..., )) { > ... > } > > for qdev_realize(), qdev_realize_and_unref(), qbus_realize() and their > wrappers

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-29 Thread Aleksandar Markovic
понедељак, 29. јун 2020., Ahmed Karaman је написао/ла: > Hi, > > The second report of the TCG Continuous Benchmarking series builds > upon the QEMU performance metrics calculated in the previous report. > This report presents a method to dissect the number of instructions > executed by a QEMU

Re: [PATCH v1 08/10] vhost: implement vhost_dev_start method

2020-06-29 Thread Cindy Lu
On Thu, Jun 25, 2020 at 10:35 PM Laurent Vivier wrote: > > On 22/06/2020 17:37, Cindy Lu wrote: > > use the vhost_dev_start callback to send the status to backend > > I agree with Jason, squash this patch with the previous one. > will fix this > > Signed-off-by: Cindy Lu > > --- > >

[PATCH] hw/misc/pca9552: Add missing TypeInfo::class_size field

2020-06-29 Thread Philippe Mathieu-Daudé
When adding the generic PCA955xClass in commit 736132e455, we forgot to set the class_size field. Fill it now to avoid: (gdb) run -machine mcimx6ul-evk -m 128M -display none -serial stdio -kernel ./OS.elf Starting program: ../../qemu/qemu/arm-softmmu/qemu-system-arm -machine mcimx6ul-evk -m

Re: [PATCH 02/17] hw/arm/spitz: Create SpitzMachineClass abstract base class

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/28/20 4:24 PM, Peter Maydell wrote: > For the four Spitz-family machines (akita, borzoi, spitz, terrier) > create a proper abstract class SpitzMachineClass which encapsulates > the common behaviour, rather than having them all derive directly > from TYPE_MACHINE: > * instead of each machine

Re: [PATCH 09/17] hw/arm/spitz: Use max111x properties to set initial values

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/28/20 4:24 PM, Peter Maydell wrote: > Use the new max111x qdev properties to set the initial input > values rather than calling max111x_set_input(); this means that > on system reset the inputs will correctly return to their initial > values. > > Signed-off-by: Peter Maydell > --- >

[PATCH 3/3] cpu-timers, icount: new modules

2020-06-29 Thread Claudio Fontana
refactoring of cpus.c continues with cpu timer state extraction. cpu-timers: responsible for the cpu timers state, and for access to cpu clocks and ticks. icount: counts the TCG instructions executed. As such it is specific to the TCG accelerator. Therefore, it is built only under CONFIG_TCG.

[PATCH 0/3] QEMU cpus.c refactoring part1

2020-06-29 Thread Claudio Fontana
Motivation and higher level steps: https://lists.gnu.org/archive/html/qemu-devel/2020-05/msg04628.html Previous series: [RFC RESEND v7 0/4] QEMU cpus.c refactoring This series is already reviewed, and is a split of the first three patches from the previous series (RFC). The forth and last of

[PATCH 1/3] softmmu: move softmmu only files from root

2020-06-29 Thread Claudio Fontana
move arch_init, balloon, cpus, ioport, memory, memory_mapping, qtest. They are all specific to CONFIG_SOFTMMU. Signed-off-by: Claudio Fontana Reviewed-by: Alex Bennée Reviewed-by: Laurent Vivier Reviewed-by: Thomas Huth --- MAINTAINERS | 12 ++--

Re: [PATCH 06/10] trivial: Remove extra trailing whitespace

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/26/20 6:43 PM, Christophe de Dinechin wrote: > Signed-off-by: Christophe de Dinechin > --- > hw/display/qxl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/display/qxl.c b/hw/display/qxl.c > index d5627119ec..28caf878cd 100644 > --- a/hw/display/qxl.c > +++

Re: [PATCH v2 3/3] scsi-disk: Add support for the GET LBA STATUS 16 command

2020-06-29 Thread Stefan Hajnoczi
On Thu, Jun 25, 2020 at 01:31:56PM +, Lin Ma wrote: > On 2020-06-25 21:25, Lin Ma wrote: > >> +/* > >> + * 8 + 16 is the length in bytes of response header and > >> + * one LBA status descriptor > >> + */ > >> +memset(outbuf, 0, 8 + 16); > >> +outbuf[3] = 20; > >> +

Re: [PATCH v3 28/30] gitlab: split build-disabled into two phases

2020-06-29 Thread Thomas Huth
On 26/06/2020 20.13, Alex Bennée wrote: As we run check-qtest in "SLOW" mode this can timeout so split into two jobs. Signed-off-by: Alex Bennée --- .gitlab-ci.yml | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index

[PATCH v7 2/5] virtio-iommu: Implement RESV_MEM probe request

2020-06-29 Thread Eric Auger
This patch implements the PROBE request. At the moment, only THE RESV_MEM property is handled. The first goal is to report iommu wide reserved regions such as the MSI regions set by the machine code. On x86 this will be the IOAPIC MSI region, [0xFEE0 - 0xFEEF], on ARM this may be the ITS

[PATCH v7 5/5] hw/arm/virt: Let the virtio-iommu bypass MSIs

2020-06-29 Thread Eric Auger
At the moment the virtio-iommu translates MSI transactions. This behavior is inherited from ARM SMMU. The virt machine code knows where the guest MSI doorbells are so we can easily declare those regions as VIRTIO_IOMMU_RESV_MEM_T_MSI. With that setting the guest will not map MSIs through the IOMMU

[PATCH v7 4/5] virtio-iommu-pci: Add array of Interval properties

2020-06-29 Thread Eric Auger
The machine may need to pass reserved regions to the virtio-iommu-pci device (such as the MSI window on x86 or the MSI doorbells on ARM). So let's add an array of Interval properties. Note: if some reserved regions are already set by the machine code - which should be the case in general -, the

[PATCH v7 0/5] VIRTIO-IOMMU probe request support and MSI bypass on ARM

2020-06-29 Thread Eric Auger
By default the virtio-iommu translates MSI transactions. This behavior is inherited from ARM SMMU. However the virt machine code knows where the MSI doorbells are, so we can easily declare those regions as VIRTIO_IOMMU_RESV_MEM_T_MSI. With that setting the guest iommu subsystem will not need to

[PATCH v7 1/5] qdev: Introduce DEFINE_PROP_RESERVED_REGION

2020-06-29 Thread Eric Auger
Introduce a new property defining a reserved region: ::. This will be used to encode reserved IOVA regions. For instance, in virtio-iommu use case, reserved IOVA regions will be passed by the machine code to the virtio-iommu-pci device (an array of those). The type of the reserved region will

[Bug 1883268] Re: random errors on aarch64 when executing __aarch64_cas8_acq_rel

2020-06-29 Thread Christophe Lyon
Hi Richard, Thanks for taking a look and confirming that you managed to reproduce the problem. I forgot to mention that I'm using x86_64 hosts, not i686. I hope there are not two unrelated issues... -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [PATCH 3/4] nbd: make client_close synchronous

2020-06-29 Thread Vladimir Sementsov-Ogievskiy
25.06.2020 17:25, Vladimir Sementsov-Ogievskiy wrote: client_close doesn't guarantee that client is closed: nbd_trip() keeps reference to it. Let's wait for nbd_trip to finish. Without this fix, the following crash is possible: - export bitmap through unternal Qemu NBD server - connect a

Re: [PATCH v2 00/16] Crazy shit around -global (pardon my french)

2020-06-29 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Cc: David for insurance against me spewing nonsense about migration. > > John Snow writes: > > > On 6/25/20 12:45 AM, Markus Armbruster wrote: > >> John Snow writes: > >> > >>> On 6/22/20 5:42 AM, Markus Armbruster wrote: > There are three

Re: [PATCH 01/17] hw/arm/spitz: Detabify

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/28/20 4:24 PM, Peter Maydell wrote: > The spitz board has been around a long time, and still has a fair number > of hard-coded tab characters in it. We're about to do some work on > this source file, so start out by expanding out the tabs. > > This commit is a pure whitespace only change. >

Re: [PATCH 08/17] ssi: Add ssi_realize_and_unref()

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/28/20 4:24 PM, Peter Maydell wrote: > Add an ssi_realize_and_unref(), for the benefit of callers > who want to be able to create an SSI device, set QOM properties > on it, and then do the realize-and-unref afterwards. > > The API works on the same principle as the recently added >

Re: [PATCH 16/17] hw/arm/spitz: Provide usual QOM macros for corgi-ssp and spitz-lcdtg

2020-06-29 Thread Philippe Mathieu-Daudé
On 6/28/20 4:24 PM, Peter Maydell wrote: > The QOM types "spitz-lcdtg" and "corgi-ssp" are missing the > usual QOM TYPE and casting macros; provide and use them. > > In particular, we can safely use the QOM cast macros instead of > FROM_SSI_SLAVE() because in both cases the 'ssidev' field of >

Re: [PATCH 08/10] build: Add SPICE_CFLAGS and SPICE_LIBS to relevant files

2020-06-29 Thread Christophe de Dinechin
On 2020-06-26 at 19:26 CEST, Daniel P. Berrangé wrote... > On Fri, Jun 26, 2020 at 06:43:05PM +0200, Christophe de Dinechin wrote: >> Instead of adding the spice build flags to the top-level build >> options, add them where they are necessary. This is a step to move the >> burden of linking with

Re: [PATCH 11/46] qemu-option: Make uses of find_desc_by_name() more similar

2020-06-29 Thread Vladimir Sementsov-Ogievskiy
24.06.2020 19:43, Markus Armbruster wrote: This is to make the next commit easier to review. Signed-off-by: Markus Armbruster Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 12/46] qemu-option: Factor out helper find_default_by_name()

2020-06-29 Thread Vladimir Sementsov-Ogievskiy
24.06.2020 19:43, Markus Armbruster wrote: Signed-off-by: Markus Armbruster Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH QEMU v25 03/17] vfio: Add save and load functions for VFIO PCI devices

2020-06-29 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Fri, 26 Jun 2020 13:16:13 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Alex Williamson (alex.william...@redhat.com) wrote: > > > On Wed, 24 Jun 2020 19:59:39 +0530 > > > Kirti Wankhede wrote: > > > > > > > On 6/23/2020 1:58 AM,

Re: [PULL 07/15] hw/timer: RX62N 8-Bit timer (TMR)

2020-06-29 Thread Philippe Mathieu-Daudé
Hi Yoshinori, On 6/25/20 11:25 AM, Peter Maydell wrote: > On Sun, 21 Jun 2020 at 13:54, Philippe Mathieu-Daudé wrote: >> >> From: Yoshinori Sato >> >> renesas_tmr: 8bit timer modules. > > Hi; the recent Coverity run reports a potential bug in this > code: (CID 1429976) > > >> +static

Re: [PATCH v3 23/30] tests/docker: add packages needed for check-acceptance

2020-06-29 Thread Philippe Mathieu-Daudé
Hi Alex, On 6/26/20 8:13 PM, Alex Bennée wrote: > We need additional python packages to run check-acceptance. Add them > to the docker images we will be using later. I'm not sure everybody is interested by that. Maybe we could add an extra 'acceptance-testing' Docker layer on top and use these

  1   2   3   4   5   >