If you can sort out the issue with masking in patches 1 and 2 then I'd be
> happy to
> take patches 1-5. Obviously there is still some discussion around the i2c
> part, so I
> can wait a few more days to see what the outcome is there: the patches
> generally seem
> okay, the one change I would like
On 01.07.20 18:16, Vladimir Sementsov-Ogievskiy wrote:
> 29.06.2020 18:00, Max Reitz wrote:
>> On 29.06.20 16:18, Vladimir Sementsov-Ogievskiy wrote:
>>> 29.06.2020 16:48, Max Reitz wrote:
Hi,
In an iotest, I’m trying to quit qemu immediately after a migration has
failed. Unfor
On 06/26/20 20:13, Alex Bennée wrote:
> From: Thomas Huth
>
> The edk2.yml and opensbi.yml files have recently been moved/renamed,
> but the change has not been reflected in the rules in the YML files
> yet.
>
> Fixes: 922febe2af ("Move edk2 and opensbi YAML files to .gitlab-ci.d folder")
> Sign
On 01/07/2020 23.17, Aurelien Jarno wrote:
Aleksandar,
On 2020-07-01 20:51, Aleksandar Markovic wrote:
On Wed, Jul 1, 2020 at 7:39 PM Aurelien Jarno wrote:
Aleksandar,
On 2020-06-30 23:54, Aleksandar Markovic wrote:
As, in a very clear way, evidenced from the previous versions of this
seri
Aleksandar Markovic writes:
> On Wed, Jul 1, 2020 at 4:03 PM Alex Bennée wrote:
>>
>> For some reason these tests fail all the time on GitLab. I can
>> re-create the hang around 3% of the time locally but it doesn't seem
>> to be MTTCG related. For now skipIf on GITLAB_CI.
>>
>> Signed-off-by:
Pavel Dovgalyuk writes:
> Is it true, that semihosting can be used to access (read and write) host
> files from the guest?
They can - but in these test cases we are only using semihosting for
console output and signalling an exit code at the end of the test. I
don't think that gets in the way
On 02.07.2020 10:49, Alex Bennée wrote:
Pavel Dovgalyuk writes:
Is it true, that semihosting can be used to access (read and write) host
files from the guest?
They can - but in these test cases we are only using semihosting for
console output and signalling an exit code at the end of the te
[Please excuse me for top-posting, I want to preserve somewhat old context]
So, is this CVE-2020-13791 issue fixed by the fix for CVE-2020-13754,
by this commit:
https://git.qemu.org/?p=qemu.git;a=commit;h=5d971f9e672507210e77d020d89e0e89165c8fc9
?
Thanks,
/mjt
04.06.2020 15:00, Michael S. T
Alexander Graf writes:
> On 01.07.20 22:47, Peter Maydell wrote:
>> On Wed, 1 Jul 2020 at 21:08, Alexander Graf wrote:
>>> We currently treat unknown SMC calls as UNDEF. This behavior is different
>>> from KVM, which treats them as NOP.
>>>
>>> Unfortunately, the UNDEF exception breaks running
On 7/1/20 10:35 PM, Peter Maydell wrote:
> On Wed, 1 Jul 2020 at 19:21, Philippe Mathieu-Daudé wrote:
>>
>> We can run I/O access with the 'i' or 'o' HMP commands in the
>> monitor. These commands are expected to run on a vCPU. The
>> monitor is not a vCPU thread. To avoid crashing, initialize
>>
On Thu, 2 Jul 2020, Howard Spoelstra wrote:
The boing is beautiful when g3beige/screamer with increased buffer size
boots the G3 rom ;-)
Try it without my RFC I2C patches (checkout the one before i2c which is
"mac_oldworld: Change PCI address of macio to match real hardware" then
build that).
On 7/1/20 9:39 PM, Laurent Vivier wrote:
> qemu_set_nonblock() checks that the file descriptor can be used and, if
> not, crashes QEMU. An assert() is used for that. The use of assert() is
> used to detect programming error and the coredump will allow to debug
> the problem.
>
> But in the case of
Aurelien Jarno writes:
> Signed-off-by: Aurelien Jarno
Reviewed-by: Alex Bennée
Queued to fpu/next, thanks.
> ---
> MAINTAINERS | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index dec252f38b..0535e043f0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
>
On 01.07.20 16:34, Vladimir Sementsov-Ogievskiy wrote:
> 30.06.2020 11:45, Max Reitz wrote:
>> This migration parameter allows mapping block node names and bitmap
>> names to aliases for the purpose of block dirty bitmap migration.
>>
>> This way, management tools can use different node and bitmap
On 01.07.20 16:38, Eric Blake wrote:
> On 6/30/20 3:45 AM, Max Reitz wrote:
>> The created structure is not really a proper QAPI object, so we cannot
>> and will not free its members. Strings therein should therefore not be
>> duplicated, or we will leak them.
>
> This seems fragile to me; having
On 02/07/2020 10:00, Philippe Mathieu-Daudé wrote:
> On 7/1/20 9:39 PM, Laurent Vivier wrote:
>> qemu_set_nonblock() checks that the file descriptor can be used and, if
>> not, crashes QEMU. An assert() is used for that. The use of assert() is
>> used to detect programming error and the coredump wi
On 7/2/20 10:17 AM, Laurent Vivier wrote:
> On 02/07/2020 10:00, Philippe Mathieu-Daudé wrote:
>> On 7/1/20 9:39 PM, Laurent Vivier wrote:
>>> qemu_set_nonblock() checks that the file descriptor can be used and, if
>>> not, crashes QEMU. An assert() is used for that. The use of assert() is
>>> used
On 6/23/20 7:59 PM, Cleber Rosa wrote:
> On Mon, Jun 22, 2020 at 10:21:03AM -0400, Cleber Rosa wrote:
>>
>> The script should indeed work with the workflow you described. I'll just
>> run a few tests, to make sure that are no caveats, and I'll let you and
>> Peter know about it.
>>
>
> FIY, I've
Merged in commit 1db889c71f37d5bad411b2ef83a69739d9d598f9.
** Changed in: qemu
Status: Confirmed => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1874073
Title:
openrisc_sim.c
On 02/07/20 06:51, Markus Armbruster wrote:
> Igor, Paolo, you showed me the error in v2. Could you have a look at
> this revision?
>
> Markus Armbruster writes:
>
>> The Error ** argument must be NULL, &error_abort, &error_fatal, or a
>> pointer to a variable containing NULL. Passing an argum
On 02.07.20 09:54, Alex Bennée wrote:
Alexander Graf writes:
On 01.07.20 22:47, Peter Maydell wrote:
On Wed, 1 Jul 2020 at 21:08, Alexander Graf wrote:
We currently treat unknown SMC calls as UNDEF. This behavior is different
from KVM, which treats them as NOP.
Unfortunately, the UNDEF e
On 02/07/20 08:18, Pavel Dovgalyuk wrote:
> Is it true, that semihosting can be used to access (read and write) host
> files from the guest?
> In such a case it can't be used with RR for the following reasons:
> 1. We don't preserve modified files, therefore the execution result may
> change in the
02.07.2020 11:09, Max Reitz wrote:
On 01.07.20 16:34, Vladimir Sementsov-Ogievskiy wrote:
30.06.2020 11:45, Max Reitz wrote:
This migration parameter allows mapping block node names and bitmap
names to aliases for the purpose of block dirty bitmap migration.
This way, management tools can use
On 02/07/20 07:09, Aurelien Jarno wrote:
> On 2020-07-01 20:55, Aurelien Jarno wrote:
>> NACK
> This NACK was because I find inacceptable to claim that you got not
> answer from Paul or from myself after very few time.
>
> Now about the content of the patch, QEMU used to be a fun ride, but it
> ha
01.07.2020 11:02, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
24.06.2020 19:43, Markus Armbruster wrote:
Convert uses like
opts = qemu_opts_create(..., &err);
if (err) {
...
}
to
opts = qemu_opts_create(..., &err);
if (!opts) {
On Thu, Jul 02, 2020 at 07:13:08AM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > Create a "qemu_open_err" method which does the same as "qemu_open",
> > but with a "Error **errp" for error reporting. There should be no
> > behavioural difference for existing callers at this s
On 02/07/20 09:54, Michael Tokarev wrote:
> [Please excuse me for top-posting, I want to preserve somewhat old context]
>
> So, is this CVE-2020-13791 issue fixed by the fix for CVE-2020-13754,
> by this commit:
>
> https://git.qemu.org/?p=qemu.git;a=commit;h=5d971f9e672507210e77d020d89e0e89165c
On Fri, Jun 26, 2020 at 06:44:19AM -0400, Paolo Bonzini wrote:
> In 32-bit mode, the higher 16 bits of the destination
> register are undefined. In practice CR0[31:0] is stored,
> just like in 64-bit mode, so just remove the "if" that
> currently differentiates the behavior.
>
> Signed-off-by: Pa
On 01/07/20 19:54, Philippe Mathieu-Daudé wrote:
> This code was introduced with SMP support in commit 6a00d60127,
> later commit 296af7c952 moved CPU parts to cpus.c but forgot this
> code. Move now and simplify ifdef'ry.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> cpus.c | 18 +++
On 02.07.20 11:19, Vladimir Sementsov-Ogievskiy wrote:
> 02.07.2020 11:09, Max Reitz wrote:
>> On 01.07.20 16:34, Vladimir Sementsov-Ogievskiy wrote:
>>> 30.06.2020 11:45, Max Reitz wrote:
This migration parameter allows mapping block node names and bitmap
names to aliases for the purpose
On 02/07/20 07:49, Daniele Buono wrote:
> This patch adds a flag to enable/disable control flow integrity checks
> on indirect function calls. This feature is only provided by LLVM/Clang
> v3.9 or higher, and only allows indirect function calls to functions
> with compatible signatures.
>
> We als
On 06/29/20 16:09, Andrew Jones wrote:
> The flash device is exclusively for the host-controlled firmware, so
> we should not expose it to the OS. Exposing it risks the OS messing
> with it, which could break firmware runtime services and surprise the
> OS when all its changes disappear after reboo
On 02/07/20 11:37, Roman Bolshakov wrote:
> On Fri, Jun 26, 2020 at 06:44:19AM -0400, Paolo Bonzini wrote:
>> In 32-bit mode, the higher 16 bits of the destination
>> register are undefined. In practice CR0[31:0] is stored,
>> just like in 64-bit mode, so just remove the "if" that
>> currently dif
On 06/29/20 16:09, Andrew Jones wrote:
> Differences between disassembled ASL files for DSDT:
>
> @@ -5,13 +5,13 @@
> *
> * Disassembling to symbolic ASL+ operators
> *
> - * Disassembly of a, Mon Jun 29 09:50:01 2020
> + * Disassembly of b, Mon Jun 29 09:50:03 2020
> *
> * Original Tabl
On 01/07/20 22:35, Peter Maydell wrote:
> For the monitor, that
> would be the current "default cpu" as set by the "cpu"
> command (cf monitor_set_cpu()). The bug here will be that
> somewhere along the line we are probably missing plumbing
> sufficient to pass down "which CPU do we want".
Yeah, t
On Thu, Jul 02, 2020 at 01:49:48AM -0400, Daniele Buono wrote:
> This patch adds a flag to enable/disable control flow integrity checks
> on indirect function calls. This feature is only provided by LLVM/Clang
> v3.9 or higher, and only allows indirect function calls to functions
> with compatible
On Mon, Jun 29, 2020 at 04:09:37PM +0200, Andrew Jones wrote:
> The flash device is exclusively for the host-controlled firmware, so
> we should not expose it to the OS. Exposing it risks the OS messing
> with it, which could break firmware runtime services and surprise the
> OS when all its change
On 01.07.20 18:26, Alberto Garcia wrote:
> On Wed 01 Jul 2020 02:52:14 PM CEST, Max Reitz wrote:
>>> if (l2_entry & QCOW_OFLAG_COMPRESSED) {
>>> return QCOW2_CLUSTER_COMPRESSED;
>>> -} else if (l2_entry & QCOW_OFLAG_ZERO) {
>>> +} else if ((l2_entry & QCOW_OFLAG_ZERO) && !has_
On Tue, Jun 30, 2020 at 11:39:32AM +0200, Cornelia Huck wrote:
> On Tue, 30 Jun 2020 10:04:51 +0100
> Stefan Hajnoczi wrote:
>
> > On Mon, Jun 29, 2020 at 02:07:16PM +0100, Daniel P. Berrangé wrote:
> > > On Mon, Jun 29, 2020 at 01:53:05PM +0100, Stefan Hajnoczi wrote:
> > > > On Thu, Jun 25,
On 7/1/20 6:05 PM, Daniel P. Berrangé wrote:
> Currently we suggest that a filesystem may not support O_DIRECT after
> seeing an EINVAL. Other things can cause EINVAL though, so it is better
> to do an explicit check, and then report a definitive error message.
>
> Signed-off-by: Daniel P. Berrang
On Jul 1 14:48, Andrzej Jakowski wrote:
> So far it was not possible to have CMB and PMR emulated on the same
> device, because BAR2 was used exclusively either of PMR or CMB. This
> patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors.
>
Linux craps out when I test this (1MB C
On Thu, 2 Jul 2020 at 10:53, Michael S. Tsirkin wrote:
>
> On Mon, Jun 29, 2020 at 04:09:37PM +0200, Andrew Jones wrote:
> > The flash device is exclusively for the host-controlled firmware, so
> > we should not expose it to the OS. Exposing it risks the OS messing
> > with it, which could break f
On Wed, Jul 01, 2020 at 06:19:17PM +0200, Cornelia Huck wrote:
> On Tue, 30 Jun 2020 09:04:38 -0400
> "Michael S. Tsirkin" wrote:
>
> > On Tue, Jun 30, 2020 at 02:25:04PM +0200, Cornelia Huck wrote:
>
> > > What bothers me most is that you need to explicitly request a device to
> > > be modern-o
On 02/07/20 11:38, Paolo Bonzini wrote:
> On 01/07/20 19:54, Philippe Mathieu-Daudé wrote:
>> This code was introduced with SMP support in commit 6a00d60127,
>> later commit 296af7c952 moved CPU parts to cpus.c but forgot this
>> code. Move now and simplify ifdef'ry.
>>
>> Signed-off-by: Philippe M
On Wed, Jul 01, 2020 at 03:58:19PM +0200, Cornelia Huck wrote:
> On Tue, 30 Jun 2020 09:02:31 -0400
> "Michael S. Tsirkin" wrote:
>
> > On Tue, Jun 30, 2020 at 01:30:43PM +0200, Cornelia Huck wrote:
> > > On Tue, 30 Jun 2020 06:45:42 -0400
> > > "Michael S. Tsirkin" wrote:
> > >
> > > > On Tu
Philippe Mathieu-Daudé writes:
> This code was introduced with SMP support in commit 6a00d60127,
> later commit 296af7c952 moved CPU parts to cpus.c but forgot this
> code. Move now and simplify ifdef'ry.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
--
Alex Bennée
On Jul 2 12:13, Klaus Jensen wrote:
> On Jul 1 14:48, Andrzej Jakowski wrote:
> > So far it was not possible to have CMB and PMR emulated on the same
> > device, because BAR2 was used exclusively either of PMR or CMB. This
> > patch places CMB at BAR4 offset so it not conflicts with MSI-X vectors
On 7/2/20 12:21 PM, Paolo Bonzini wrote:
> On 02/07/20 11:38, Paolo Bonzini wrote:
>> On 01/07/20 19:54, Philippe Mathieu-Daudé wrote:
>>> This code was introduced with SMP support in commit 6a00d60127,
>>> later commit 296af7c952 moved CPU parts to cpus.c but forgot this
>>> code. Move now and sim
Paolo Bonzini writes:
> On 02/07/20 11:38, Paolo Bonzini wrote:
>> On 01/07/20 19:54, Philippe Mathieu-Daudé wrote:
>>> This code was introduced with SMP support in commit 6a00d60127,
>>> later commit 296af7c952 moved CPU parts to cpus.c but forgot this
>>> code. Move now and simplify ifdef'ry.
From: Philippe Mathieu-Daudé
This code was introduced with SMP support in commit 6a00d60127,
later commit 267f685b8b moved CPU list management to common code
but forgot this code. Move now and simplify ifdef'ry.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Philippe Ma
02.07.2020 12:41, Max Reitz wrote:
On 02.07.20 11:19, Vladimir Sementsov-Ogievskiy wrote:
02.07.2020 11:09, Max Reitz wrote:
On 01.07.20 16:34, Vladimir Sementsov-Ogievskiy wrote:
30.06.2020 11:45, Max Reitz wrote:
This migration parameter allows mapping block node names and bitmap
names to a
On 7/2/20 12:38 PM, Philippe Mathieu-Daudé wrote:
> From: Philippe Mathieu-Daudé
>
> This code was introduced with SMP support in commit 6a00d60127,
> later commit 267f685b8b moved CPU list management to common code
> but forgot this code. Move now and simplify ifdef'ry.
>
> Reviewed-by: Richard
This code was introduced with SMP support in commit 6a00d60127,
later commit 267f685b8b moved CPU list management to common code
but forgot this code. Move now and simplify ifdef'ry.
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Signed-off-by: Philippe Mathieu-Daudé
---
cpus-common.c
Function "print_fdset()" in "strace.c" is used to print the file descriptor
values in "print__newselect()" which prints arguments of syscall _newselect().
Until changes from this patch, this function was printing "," even after the
last value of the fd_set argument. This was changed in this patch b
On Thu, 2 Jul 2020 06:16:06 -0400
"Michael S. Tsirkin" wrote:
> On Wed, Jul 01, 2020 at 06:19:17PM +0200, Cornelia Huck wrote:
> > On Tue, 30 Jun 2020 09:04:38 -0400
> > "Michael S. Tsirkin" wrote:
> >
> > > On Tue, Jun 30, 2020 at 02:25:04PM +0200, Cornelia Huck wrote:
> >
> > > > What
Paolo Bonzini writes:
> On 01/07/20 22:35, Peter Maydell wrote:
>> For the monitor, that
>> would be the current "default cpu" as set by the "cpu"
>> command (cf monitor_set_cpu()). The bug here will be that
>> somewhere along the line we are probably missing plumbing
>> sufficient to pass down
02.07.2020 12:41, Max Reitz wrote:
I don’t know if doing it differently would actually be beneficial for
anyone, but OTOH naively it seems like a more invasive code change.
I don't see real benefits, we can go either way, so, not worth rewriting
the patch.
===
I feel like a stupid reviewer:)
** Changed in: qemu
Assignee: Philippe Mathieu-Daudé (philmd) => (unassigned)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1833661
Title:
Linux kernel oops on Malta board while accessing pfla
Hi all,
I want to build QEMU 4.2.0 with the plugin module on Windows 7
with Mingw, but the building process faild.
The step I follow is listed below:
1. create "dsp_build" diretory under source file folder
2. change directory to dsp_build , and run ../configure
--target-list=dsp-sof
On 06/23/20 19:27, Philippe Mathieu-Daudé wrote:
> On the host OS, various aspects of TLS operation are configurable.
> In particular it is possible for the sysadmin to control the TLS
> cipher/protocol algorithms that applications are permitted to use.
>
> * Any given crypto library has a built-i
On 06/23/20 19:27, Philippe Mathieu-Daudé wrote:
> Since our format is consumable by the fw_cfg device,
> we can implement the FW_CFG_DATA_GENERATOR interface.
>
> Example of use to dump the cipher suites (if tracing enabled):
>
> $ qemu-system-x86_64 -S \
> -object tls-cipher-suites,id=mys
On 07/01/20 12:31, Daniel P. Berrangé wrote:
> On Tue, Jun 23, 2020 at 07:27:21PM +0200, Philippe Mathieu-Daudé wrote:
>> Hi,
>>
>> This series has 3 parts:
>>
>> - First we add the tls-cipher-suites object
>>
>> - We add the ability to QOM objects to produce data
>> consumable by the fw_cfg devi
On Thu, Jul 02, 2020 at 01:00:02PM +0200, Laszlo Ersek wrote:
> On 07/01/20 12:31, Daniel P. Berrangé wrote:
> > On Tue, Jun 23, 2020 at 07:27:21PM +0200, Philippe Mathieu-Daudé wrote:
> >> Hi,
> >>
> >> This series has 3 parts:
> >>
> >> - First we add the tls-cipher-suites object
> >>
> >> - We a
On 7/2/20 1:01 PM, Daniel P. Berrangé wrote:
> On Thu, Jul 02, 2020 at 01:00:02PM +0200, Laszlo Ersek wrote:
>> On 07/01/20 12:31, Daniel P. Berrangé wrote:
>>> On Tue, Jun 23, 2020 at 07:27:21PM +0200, Philippe Mathieu-Daudé wrote:
Hi,
This series has 3 parts:
- First we a
Merged as commit aabab96797a7d61989c25a7ca2b094591bbc74f9.
** Changed in: qemu
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1878628
Title:
linux-user/m
Merged in commit 9c61fcc89a70256c19047d251aa44f666f06089c.
** Changed in: qemu
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1878627
Title:
audio/mixeng
From: lichun
Errors are already freed by error_report_err, so we only need to call
error_free when that function is not called.
Cc: qemu-sta...@nongnu.org
Signed-off-by: lichun
Message-Id: <20200621213017.17978-1-lic...@ruijie.com.cn>
Reviewed-by: Markus Armbruster
[Commit message improved, cc
test_file_monitor_events() leaks an Error object when
qemu_file_monitor_add_watch() fails, which seems unlikely. Plug it.
Cc: Daniel P. Berrangé
Signed-off-by: Markus Armbruster
Message-Id: <20200630090351.1247703-11-arm...@redhat.com>
Reviewed-by: Daniel P. Berrangé
---
tests/test-util-filem
All callers pass &error_abort. Drop the parameter.
Cc: Paolo Bonzini
Cc: "Daniel P. Berrangé"
Cc: Eduardo Habkost
Signed-off-by: Markus Armbruster
Message-Id: <20200630090351.1247703-14-arm...@redhat.com>
---
include/hw/qdev-core.h | 2 +-
hw/core/bus.c | 4 ++--
hw/scsi/s
Receiving the error in a local variable only to assert there is none
is less clear than passing &error_abort. Clean up.
Signed-off-by: Markus Armbruster
Reviewed-by: Thomas Huth
Message-Id: <20200630090351.1247703-5-arm...@redhat.com>
---
tests/check-qobject.c | 5 +-
tests/chec
qbus_set_hotplug_handler() is a simple wrapper around
object_property_set_link().
object_property_set_link() fails when the property doesn't exist, is
not settable, or its .check() method fails. These are all programming
errors here, so passing &error_abort to qbus_set_hotplug_handler() is
approp
From: Peter Maydell
Fix a typo in an error message in virtio_iommu_pci_realize():
"Check you machine" should be "Check your machine".
Reported-by: Markus Armbruster
Signed-off-by: Peter Maydell
Message-Id: <20200625100811.12690-1-peter.mayd...@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé
R
Replace
g_assert(err != NULL);
error_free(err);
err = NULL;
and variations thereof by
error_free_or_abort(&err);
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
Message-Id: <20200630090351.1247703-6-arm...@redhat.com>
---
tests/check-block-qdict.c | 24 ++--
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
x86_cpu_new() is wron
Replace
sysbus_realize(SYS_BUS_DEVICE(&s->spi[i]), &local_err);
error_propagate(&err, local_err);
if (err) {
error_propagate(errp, err);
return;
}
by
sysbus_realize(SYS_BUS_DEVICE(&s->spi[i]), &err);
if (err) {
e
vnc_display_print_local_addr() leaks the Error object when
qio_channel_socket_get_local_address() fails. Seems unlikely. Called
when we create a VNC display with vnc_display_open(). Plug the leak
by passing NULL to ignore the error.
Cc: Daniel P. Berrange
Cc: Gerd Hoffmann
Signed-off-by: Mark
qemu_rdma_registration_stop() uses the ERROR() macro to create, report
to stderr, and store an Error object. The stored Error object is
never used, and its memory is leaked.
Even where ERROR() doesn't leak, it is ill-advised. The whole point
of passing an Error to the caller is letting the calle
error_report_err() frees its first argument. Freeing it again is
wrong. Don't.
Fixes: 47287c27d0c367a89f7b2851e23a7f8b2d499dd6
Cc: Gerd Hoffmann
Cc: Daniel P. Berrangé
Cc: qemu-sta...@nongnu.org
Signed-off-by: Markus Armbruster
Message-Id: <20200630090351.1247703-7-arm...@redhat.com>
Reviewed
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
sifive_u_soc_realize(
The following changes since commit fc1bff958998910ec8d25db86cd2f53ff125f7ab:
hw/misc/pca9552: Add missing TypeInfo::class_size field (2020-06-29 21:16:10
+0100)
are available in the Git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-error-2020-07-02
for you to fetch changes up t
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
stm32f205_soc_realize
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
riscv_harts_realize()
milkymist_memcard_realize() leaks an Error object when realization of
its "sd-card" device fails. Quite harmless, since we only ever
realize this once, in milkymist_init() via milkymist_memcard_create().
Plug the leak.
Fixes: 3d0369ba499866cc6a839f71212d97876500762d
Cc: Philippe Mathieu-Daudé
C
Receiving the error in a local variable only to free it is less clear
(and also less efficient) than passing NULL. Clean up.
Cc: Daniel P. Berrange
Cc: Jerome Forissier
CC: Greg Kurz
Signed-off-by: Markus Armbruster
Reviewed-by: Greg Kurz
Message-Id: <20200630090351.1247703-4-arm...@redhat.c
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
aspeed_soc_ast2600_re
transfer_memory_block() leaks an Error object when reading file
/sys/devices/system/memory/memory/state fails with errno other
than ENOENT, and @sys2memblk is false, i.e. when the state file exists
but cannot be read (seems quite unlikely), and this is
guest-set-memory-blocks, not guest-get-memory-
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
amdvi_realize() is wr
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
mips_cps_realize() is
Commit 150ab54aa6 "net/virtio: fix re-plugging of primary device"
fixed failover_replug_primary() to return false on failure. Commit
5a0948d36c "net/virtio: Fix failover error handling crash bugs" broke
it again for hotplug_handler_plug() failure. Unbreak it.
Commit 5a0948d36c4cbc1c5534afac6fee9
On Wed, Jul 01, 2020 at 01:48:36PM +0100, Anthony PERARD wrote:
> On Wed, Jul 01, 2020 at 08:01:55AM -0400, Michael S. Tsirkin wrote:
> > On Wed, Jul 01, 2020 at 12:05:49PM +0100, Anthony PERARD wrote:
> > > The ACPI spec state that "Accesses to PM1 control registers are
> > > accessed through byte
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
armsse_realize() is w
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
virtio_gpu_pci_base_r
On Thu, Jul 02, 2020 at 11:16:03AM +0100, Peter Maydell wrote:
> On Thu, 2 Jul 2020 at 10:53, Michael S. Tsirkin wrote:
> >
> > On Mon, Jun 29, 2020 at 04:09:37PM +0200, Andrew Jones wrote:
> > > The flash device is exclusively for the host-controlled firmware, so
> > > we should not expose it to
Cc: Jens Freimann
Cc: Michael S. Tsirkin
Cc: Marcel Apfelbaum
Signed-off-by: Markus Armbruster
Reviewed-by: Jens Freimann
Reviewed-by: Michael S. Tsirkin
Message-Id: <20200630090351.1247703-3-arm...@redhat.com>
---
hw/pci/pci.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/pci/pci
spapr_machine_init() leaks an Error object when
kvmppc_check_papr_resize_hpt() fails and spapr->resize_hpt is
SPAPR_RESIZE_HPT_DISABLED, i.e. when the host doesn't support hash
page table resizing, and the user didn't ask for it. As harmless as
memory leaks can possibly be. Plug it.
Fixes: 30f4b
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL. Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.
bcm2835_peripherals_r
On Tue, 16 Jun 2020 06:50:33 +0200
Halil Pasic wrote:
> The story short: compiler can generate code that does two
> distinct fetches of *ind_addr for old and _old. If that happens we can
> not figure out if we had the desired xchg or not.
>
> Halil Pasic (2):
> virtio-ccw: fix virtio_set_ind_a
object_property_set_link() fails when the property doesn't exist, is
not settable, or its .check() method fails. These are all programming
errors here, so passing it &error_abort is appropriate.
Cc: Peter Maydell
Cc: "Cédric Le Goater"
Cc: Andrew Jeffery
Cc: Joel Stanley
Cc: qemu-...@nongnu.o
Patchew URL:
https://patchew.org/QEMU/20200702102749.22178-1-filip.boz...@syrmia.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] linux-user: Fix "print_fdset()" in "strace.c" to not print ",
" after last value
Type: serie
From: Riku Voipio
I haven't been active for a while. Pass the maintainer hat
forward to Laurent, who has done a stellar job filling in.
Signed-off-by: Riku Voipio
---
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git MAINTAINERS MAINTAINERS
index dec252f38b..29a23
1 - 100 of 559 matches
Mail list logo
