[PATCH V2 04/10] scripts/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the scripts folder. Signed-off-by: zhaolichang Reviewed-by: Peter Maydell --- scripts/checkpatch.pl | 2 +-

[PATCH V2 01/10] qemu/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennée --- Changelog | 2 +- accel/tcg/user-exec.c

[PATCH V2 00/10] fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors, this series fixed this spelling errors. v1 -> v2: address Peter Maydell's comments address Alex Bennée's comments add reviewed-by for patch 1,2,3,4,5,6,9,10

[PATCH V2 02/10] migration/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the migration folder. Signed-off-by: zhaolichang Reviewed-by: Peter Maydell --- migration/colo-failover.c | 2 +-

[PATCH V2 10/10] contrib/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the contrib folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennée --- contrib/gitdm/filetypes.txt | 6

[PATCH V2 03/10] docs/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the docs folder. Signed-off-by: zhaolichang Reviewed-by: Peter Maydell --- docs/COLO-FT.txt | 6 +++---

[PATCH V2 05/10] util/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the util folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennée --- util/osdep.c | 2 +- util/qemu-progress.c

[PATCH V2 07/10] block/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the block folder. Signed-off-by: zhaolichang --- block/block-copy.c | 2 +- block/linux-aio.c | 2 +- block/mirror.c | 2 +-

[PATCH V2 06/10] linux-user/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the linux-user folder. Signed-off-by: zhaolichang Reviewed-by: Alex Bennée --- linux-user/aarch64/signal.c | 2

[PATCH V2 09/10] qapi/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the qapi folder. Signed-off-by: zhaolichang Reviewed-by: Markus Armbruster --- qapi/block-core.json | 4 ++-- qapi/crypto.json

[PATCH V2 08/10] disas/: fix some comment spelling errors

2020-08-26 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu, so I used the spellcheck tool to check the spelling errors and finally found some spelling errors in the disas folder. Signed-off-by: zhaolichang --- disas/hppa.c | 2 +- disas/m68k.c | 8 disas/ppc.c | 2 +- 3 files

[PULL v2 00/34] Block patches

2020-08-26 Thread Max Reitz
The following changes since commit 30aa19446d82358a30eac3b556b4d6641e00b7c1: Merge remote-tracking branch 'remotes/cschoenebeck/tags/pull-9p-20200812' into staging (2020-08-24 16:39:53 +0100) are available in the Git repository at: https://github.com/XanClic/qemu.git

[Bug 1893003] [NEW] qemu-user doesn't translate host/target data for iovec I/O

2020-08-26 Thread Mike Gelfand
Public bug reported: When using iovec I/O functions (like `readv`), no data translation happens. I'm hitting this issue with libevent upon constructing a bufferevent over an inotify descriptor, and then building for either ppc64 or s390x (both big-endian) on x86_64 (little-endian) and running

Re: [PATCH] meson: don't require CONFIG_VTE for the GTK UI

2020-08-26 Thread Paolo Bonzini
Queued, thanks. Paolo On Wed, Aug 26, 2020 at 12:23 AM Mark Cave-Ayland wrote: > > Prevously CONFIG_VTE was not required to build QEMU with GTK UI support as not > all platforms have VTE available (in particular Windows). > > Remove this requirement from the meson build system to enable QEMU to

Re: [PATCH v3 50/74] migration: Rename class type checking macros

2020-08-26 Thread Juan Quintela
Eduardo Habkost wrote: > Rename the macros to make them consistent with the MIGRATION_OBJ > macro name. > > This will make future conversion to OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost > --- > Changes series v2 -> v3: new patch added to series v3 > > --- > Cc: Juan Quintela >

Re: [PATCH v3 62/74] [automated] Use TYPE_INFO macro

2020-08-26 Thread Juan Quintela
Eduardo Habkost wrote: > Generated using: > $ ./scripts/codeconverter/converter.py -i --passes=2 \ > --pattern=TypeRegisterCall,TypeInitMacro $(git grep -l TypeInfo -- > '*.[ch]') > > One notable difference is that files declaring multiple types > will now have multiple separate

Re: [PATCH v3 65/74] [automated] Move QOM typedefs and add missing includes (pass 2)

2020-08-26 Thread Juan Quintela
Eduardo Habkost wrote: > Some typedefs and macros are defined after the type check macros. > This makes it difficult to automatically replace their > definitions with OBJECT_DECLARE_TYPE. > > Patch generated using: > > $ ./scripts/codeconverter/converter.py -i \ >

Re: [PATCH] meson: skip SDL2 detection if --disable-system

2020-08-26 Thread Marc-André Lureau
On Wed, Aug 26, 2020 at 11:03 AM Paolo Bonzini wrote: > SDL is only used for system emulation; avoid spurious warnings for > static --disable-system emulation by skipping the detection of > the library if there are no system emulation targets. > > Reported-by: Peter Maydell > Signed-off-by:

Re: [PATCH v3 67/74] [automated] Use DECLARE_*CHECKER* macros (pass 2)

2020-08-26 Thread Juan Quintela
Eduardo Habkost wrote: > $ ./scripts/codeconverter/converter.py -i \ >--pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]') > > Signed-off-by: Eduardo Habkost > --- > Changes series v2 -> v3: this is a new patch added in series v3 > > The script was re-run after rebase and after additional

Re: [PATCH v3 64/74] [automated] Move QOM typedefs and add missing includes

2020-08-26 Thread Juan Quintela
[dropped people from CC] Eduardo Habkost wrote: > Some typedefs and macros are defined after the type check macros. > This makes it difficult to automatically replace their > definitions with OBJECT_DECLARE_TYPE. > > Patch generated using: > > $ ./scripts/codeconverter/converter.py -i \ >

Re: [PATCH v3 66/74] [automated] Use DECLARE_*CHECKER* macros

2020-08-26 Thread Juan Quintela
Eduardo Habkost wrote: > $ ./scripts/codeconverter/converter.py -i \ >--pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]') > > Reviewed-by: Daniel P. Berrangé > Signed-off-by: Eduardo Habkost > --- > Changes v2 -> v3: > * Removed hunks due to rebase conflicts: > hw/arm/integratorcp.c

Re: [PATCH] os-posix: Restore firmware location ../share/qemu

2020-08-26 Thread Paolo Bonzini
Hi, I will post next week a patch to make all searches relative to the executable path. I will CC you so you can test it. Thanks! Paolo Il mer 26 ago 2020, 10:01 ha scritto: > Prior to commit 6dd2dacedd83d12328afa8559bffb2b9ec5c89ed (v5.0.0), the > binary relative path ../share/qemu was

Re: [PATCH 3/4] meson: Mingw64 gcc doesn't recognize system include_type for sdl2

2020-08-26 Thread Daniel P . Berrangé
On Wed, Aug 26, 2020 at 08:48:22AM +0200, Paolo Bonzini wrote: > On Tue, Aug 25, 2020 at 11:38 PM Mark Cave-Ayland > wrote: > > Marc-André had a query about why this is marked as a system include, > > however I can > > confirm that it fixes the missing "SDL.h" issue during build. > > It was

Re: [PATCH for-4.2 v2 3/3] block/file-posix: Let post-EOF fallocate serialize

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
22.08.2020 20:04, Vladimir Sementsov-Ogievskiy wrote: 22.08.2020 20:03, Vladimir Sementsov-Ogievskiy wrote: 01.11.2019 18:25, Max Reitz wrote: The XFS kernel driver has a bug that may cause data corruption for qcow2 images as of qemu commit c8bb23cbdbe32f.  We can work around it by treating

Re: [PATCH 2/4] meson: fixes relpath may fail on win32.

2020-08-26 Thread Paolo Bonzini
On Tue, Aug 25, 2020 at 11:31 PM Mark Cave-Ayland wrote: > On 25/08/2020 17:53, luoyongg...@gmail.com wrote: > > > From: Yonggang Luo > > > > On win32, os.path.relpath would raise exception when do the following > > relpath: > > C:/msys64/mingw64/x.exe relative to E:/path/qemu-build would fail.

Re: [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja

2020-08-26 Thread Paolo Bonzini
On Tue, Aug 25, 2020 at 11:26 PM Mark Cave-Ayland wrote: > I've tested this and it changes build.ninja so instead of Windows paths > beginning C$$ > they now begin C$ instead e.g.: > > build qemu-version.h: CUSTOM_COMMAND | > C$:/msys64/home/Mark/qemu/scripts/qemu-version.sh PHONY The patch

Re: [PATCH 3/4] meson: Mingw64 gcc doesn't recognize system include_type for sdl2

2020-08-26 Thread Paolo Bonzini
On Tue, Aug 25, 2020 at 11:38 PM Mark Cave-Ayland wrote: > Marc-André had a query about why this is marked as a system include, however > I can > confirm that it fixes the missing "SDL.h" issue during build. It was marked as a system include in an attempt to work around the SDL 2.0.8 bug that

Re: [PATCH v5 07/10] block: introduce preallocate filter

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
25.08.2020 18:11, Max Reitz wrote: On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: It's intended to be inserted between format and protocol nodes to preallocate additional space (expanding protocol file) on writes crossing EOF. It improves performance for file-systems with slow

[PATCH] meson: skip SDL2 detection if --disable-system

2020-08-26 Thread Paolo Bonzini
SDL is only used for system emulation; avoid spurious warnings for static --disable-system emulation by skipping the detection of the library if there are no system emulation targets. Reported-by: Peter Maydell Signed-off-by: Paolo Bonzini --- meson.build | 27 --- 1

[PATCH] configure: add --ninja option

2020-08-26 Thread Paolo Bonzini
On Windows it is not possible to invoke a Python script as $NINJA. If ninja is present use it directly, while if it is not we can keep using ninjatool. Reported-by: Mark Cave-Ayland Signed-off-by: Paolo Bonzini --- configure | 16 +++- 1 file changed, 15 insertions(+), 1

[PATCH] meson: move pixman detection to meson

2020-08-26 Thread Paolo Bonzini
When pixman is not installed (or too old), but virglrenderer is available and "configure" has been run with "--disable-system", the build currently aborts when trying to compile vhost-user-gpu (since it requires pixman). Let's skip the build of vhost-user-gpu when pixman is not installed or too

Re: [PATCH v5 07/10] block: introduce preallocate filter

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
24.08.2020 20:52, Vladimir Sementsov-Ogievskiy wrote: 21.08.2020 17:11, Vladimir Sementsov-Ogievskiy wrote: It's intended to be inserted between format and protocol nodes to preallocate additional space (expanding protocol file) on writes crossing EOF. It improves performance for file-systems

Re: [PATCH v3 48/74] s390-virtio-ccw: Rename S390_MACHINE_CLASS macro

2020-08-26 Thread Cornelia Huck
On Tue, 25 Aug 2020 15:20:44 -0400 Eduardo Habkost wrote: > Rename it to be consistent with S390_CCW_MACHINE and > TYPE_S390_CCW_MACHINE. > > This will make future conversion to OBJECT_DECLARE* easier. > > Signed-off-by: Eduardo Habkost > --- > Changes series v2 -> v3: new patch added to

Re: [PATCH 1/4] meson: Fixes the ninjatool issue that E$$: are generated in Makefile.ninja SIMPLE_PATH_RE should match the full path token. Or the $ and : contained in path would not matched if the pa

2020-08-26 Thread Markus Armbruster
Please do not put all of your commit message in the subject line. https://wiki.qemu.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message https://chris.beams.io/posts/git-commit/

[PATCH v7 7/8] sparc/sun4m: Use start-powered-off CPUState property

2020-08-26 Thread Thiago Jung Bauermann
Instead of setting CPUState::halted to 1 in secondary_cpu_reset(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Now secondary_cpu_reset() becomes equivalent to main_cpu_reset() so rename the function to sun4m_cpu_reset(). Also remove

[PATCH v7 5/8] mips/cps: Use start-powered-off CPUState property

2020-08-26 Thread Thiago Jung Bauermann
Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Also change creation of CPU object from cpu_create() to object_new() and qdev_realize_and_unref() because cpu_create() realizes the

Re: [External] Re: [PATCH 2/2] coroutine: take exactly one batch from global pool at a time

2020-08-26 Thread 王洪浩
The purpose of this patch is to improve performance without increasing memory consumption. My test case: QEMU command line arguments -drive file=/dev/nvme2n1p1,format=raw,if=none,id=local0,cache=none,aio=native \ -device virtio-blk,id=blk0,drive=local0,iothread=iothread0,num-queues=4 \ -drive

Re: device compatibility interface for live migration with assigned devices

2020-08-26 Thread Yan Zhao
On Tue, Aug 25, 2020 at 04:39:25PM +0200, Cornelia Huck wrote: <...> > > do you think the bin_attribute I proposed yesterday good? > > Then we can have a single compatible with a variable in the mdev_type and > > aggregator. > > > >mdev_type=i915-GVTg_V5_{val1:int:2,4,8} > >

Re: [PATCH] disas/libvixl: Fix fall-through annotation for GCC >= 7

2020-08-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200824130114.41368-1-th...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200824130114.41368-1-th...@redhat.com Subject: [PATCH] disas/libvixl: Fix fall-through

Re: [PATCH 00/12] fix some error memleaks

2020-08-26 Thread Pan Nengyuan
ping! On 2020/8/15 0:02, Pan Nengyuan wrote: > This series fix some Error/GError memleaks. > > Pan Nengyuan (12): > qga/channel-posix: Plug memory leak in ga_channel_write_all() > hw/vfio/ap: Plug memleak in vfio_ap_get_group() > elf2dmp/qemu_elf: Plug memleak in QEMU_Elf_init >

[PATCH v7 8/8] target/s390x: Use start-powered-off CPUState property

2020-08-26 Thread Thiago Jung Bauermann
Instead of setting CPUState::halted to 1 in s390_cpu_initfn(), use the start-powered-off property which makes cpu_common_reset() initialize it to 1 in common code. Note that this changes behavior by setting cs->halted to 1 on reset, which didn't happen before. Acked-by: Cornelia Huck

Re: [PATCH v5 06/10] block: introduce BDRV_REQ_NO_WAIT flag

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
25.08.2020 16:10, Max Reitz wrote: On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: Add flag to make serialising request no wait: if there are conflicting requests, just return error immediately. It's will be used in upcoming preallocate filter. Signed-off-by: Vladimir

Re: [PATCH v2 6/7] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM

2020-08-26 Thread Igor Mammedov
On Tue, 25 Aug 2020 19:25:48 +0200 Laszlo Ersek wrote: > On 08/18/20 14:22, Igor Mammedov wrote: > > In case firmware has negotiated CPU hotplug SMI feature, generate > > AML to describe SMI IO port region and send SMI to firmware > > on each CPU hotplug SCI in case new CPUs were hotplugged. > >

Re: [PATCH v5 02/12] migration/dirtyrate: add DirtyRateStatus to denote calculation status

2020-08-26 Thread David Edmondson
Minor wordsmithing... On Monday, 2020-08-24 at 17:14:30 +08, Chuan Zheng wrote: > add DirtyRateStatus to denote calculating status. > > Signed-off-by: Chuan Zheng > --- > migration/dirtyrate.c | 22 ++ > qapi/migration.json | 17 + > 2 files changed, 39

Re: [PATCH v2 6/7] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM

2020-08-26 Thread Laszlo Ersek
Hi Igor, On 08/25/20 19:25, Laszlo Ersek wrote: > So I would suggest fetching the CNEW array element back into "uid" > first, then using "uid" for both the NOTIFY call, and the (currently > missing) restoration of CSEL. Then we can write 1 to CINS. > > Expressed as a patch on top of yours: > >>

Re: [PULL 00/18] riscv-to-apply queue

2020-08-26 Thread Peter Maydell
On Wed, 26 Aug 2020 at 04:21, Bin Meng wrote: > On Wed, Aug 26, 2020 at 6:41 AM Alistair Francis wrote: > > Richard and Philippe review patches and some of the RISC-V patches get > > reviewed by the RISC-V community. The main problem (which is a common > > problem in open source) is that large

Re: [PULL 00/18] riscv-to-apply queue

2020-08-26 Thread Peter Maydell
On Tue, 25 Aug 2020 at 20:01, Alistair Francis wrote: > > The following changes since commit 7774e403f2ac58b3e87bfe8d2f77676501ba893e: > > Merge remote-tracking branch > 'remotes/kraxel/tags/fixes-20200825-pull-request' into staging (2020-08-25 > 10:54:51 +0100) > > are available in the Git

Re: [PATCH v5 03/12] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info

2020-08-26 Thread David Edmondson
On Monday, 2020-08-24 at 17:14:31 +08, Chuan Zheng wrote: > Add RamlockDirtyInfo to store sampled page info of each ramblock. > > Signed-off-by: Chuan Zheng > --- > migration/dirtyrate.h | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/migration/dirtyrate.h

Re: [PATCH] hw/timer/armv7m_systick: assert that board code set system_clock_scale

2020-08-26 Thread Philippe Mathieu-Daudé
Le mar. 25 août 2020 18:09, Peter Maydell a écrit : > It is the responsibility of board code for an armv7m system to set > system_clock_scale appropriately for the CPU speed of the core. > If it forgets to do this, then QEMU will hang if the guest tries > to use the systick timer in the "tick at

Re: [PATCH v5 03/12] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info

2020-08-26 Thread Zheng Chuan
On 2020/8/26 17:29, David Edmondson wrote: > On Monday, 2020-08-24 at 17:14:31 +08, Chuan Zheng wrote: > >> Add RamlockDirtyInfo to store sampled page info of each ramblock. >> >> Signed-off-by: Chuan Zheng >> --- >> migration/dirtyrate.h | 18 ++ >> 1 file changed, 18

Re: [PATCH v2 1/1] core/register: Specify instance_size in the TypeInfo

2020-08-26 Thread Philippe Mathieu-Daudé
Le mar. 25 août 2020 19:42, Alistair Francis a écrit : > Reported-by: Eduardo Habkost > Signed-off-by: Alistair Francis > --- > hw/core/register.c | 31 +-- > 1 file changed, 13 insertions(+), 18 deletions(-) > > diff --git a/hw/core/register.c b/hw/core/register.c

Re: [PATCH v2 2/5] meson: use meson datadir instead of qemu_datadir

2020-08-26 Thread Paolo Bonzini
You'd need to check first if it works correctly if confsuffix "looks like" an absolute path ('/qemu'). So + looks correct to me. (Sorry for top posting). Paolo Il mer 26 ago 2020, 10:53 Marc-André Lureau ha scritto: > Hi > > On Wed, Aug 26, 2020 at 12:30 PM Daniel P. Berrangé > wrote: > >>

Re: [PATCH-for-5.2 0/4] hw/char/serial: Use the Clock API to feed the UART reference clock

2020-08-26 Thread Philippe Mathieu-Daudé
Hi Peter, Le lun. 24 août 2020 17:20, Peter Maydell a écrit : > On Sat, 22 Aug 2020 at 21:00, Philippe Mathieu-Daudé > wrote: > > > > On 8/6/20 3:03 PM, Philippe Mathieu-Daudé wrote: > > > This series improve tracing of multiple UART device in the same > > > chipset, and allow to use the Clock

Re: [PATCH v2 0/3] hw/misc/unimp: Improve how offset/value are displayed

2020-08-26 Thread Philippe Mathieu-Daudé
Hi Peter, Le lun. 24 août 2020 17:01, Peter Maydell a écrit : > On Sat, 22 Aug 2020 at 21:02, Philippe Mathieu-Daudé > wrote: > > > > On 8/12/20 9:02 PM, Philippe Mathieu-Daudé wrote: > > > This series aims to ease looking at the '-d unimp' output reported > > > by the UnimplementedDevice. > >

Re: [PATCH v2 0/3] hw/misc/unimp: Improve how offset/value are displayed

2020-08-26 Thread Philippe Mathieu-Daudé
Le mer. 26 août 2020 11:54, Philippe Mathieu-Daudé a écrit : > Hi Peter, > > Le lun. 24 août 2020 17:01, Peter Maydell a > écrit : > >> On Sat, 22 Aug 2020 at 21:02, Philippe Mathieu-Daudé >> wrote: >> > >> > On 8/12/20 9:02 PM, Philippe Mathieu-Daudé wrote: >> > > This series aims to ease

Re: [PATCH v5 06/12] migration/dirtyrate: Record hash results for each sampled page

2020-08-26 Thread David Edmondson
On Monday, 2020-08-24 at 17:14:34 +08, Chuan Zheng wrote: > Record hash results for each sampled page, crc32 is taken to calculate > hash results for each sampled 4K-page. > > Signed-off-by: Chuan Zheng > Signed-off-by: YanYing Zhuang > --- > migration/dirtyrate.c | 136 >

Re: [PATCH v5 07/10] block: introduce preallocate filter

2020-08-26 Thread Max Reitz
On 26.08.20 11:15, Vladimir Sementsov-Ogievskiy wrote: > 26.08.2020 11:52, Max Reitz wrote: >> On 26.08.20 08:49, Vladimir Sementsov-Ogievskiy wrote: >>> 25.08.2020 18:11, Max Reitz wrote: On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: > It's intended to be inserted between format

Re: [PATCH v5 1/8] hw/i386: Remove node_id, nr_nodes and nodes_per_pkg from topology

2020-08-26 Thread Igor Mammedov
On Fri, 21 Aug 2020 17:12:25 -0500 Babu Moger wrote: > Remove node_id, nr_nodes and nodes_per_pkg from topology. Use > die_id, nr_dies and dies_per_pkg which is already available. > Removes the confusion over two variables. > > With node_id removed in topology the uninitialized memory issue >

Re: [PATCH v5 03/12] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info

2020-08-26 Thread Zheng Chuan
On 2020/8/26 17:40, Zheng Chuan wrote: > > > On 2020/8/26 17:29, David Edmondson wrote: >> On Monday, 2020-08-24 at 17:14:31 +08, Chuan Zheng wrote: >> >>> Add RamlockDirtyInfo to store sampled page info of each ramblock. >>> >>> Signed-off-by: Chuan Zheng >>> --- >>> migration/dirtyrate.h

Re: [PULL 00/18] riscv-to-apply queue

2020-08-26 Thread Bin Meng
Hi Peter, On Wed, Aug 26, 2020 at 5:25 PM Peter Maydell wrote: > > On Wed, 26 Aug 2020 at 04:21, Bin Meng wrote: > > On Wed, Aug 26, 2020 at 6:41 AM Alistair Francis > > wrote: > > > Richard and Philippe review patches and some of the RISC-V patches get > > > reviewed by the RISC-V community.

Re: [PATCH v5 08/12] migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE

2020-08-26 Thread David Edmondson
On Monday, 2020-08-24 at 17:14:36 +08, Chuan Zheng wrote: > In order to sample real RAM, skip ramblock with size below MIN_RAMBLOCK_SIZE > which is set as 128M. > > Signed-off-by: Chuan Zheng > --- > migration/dirtyrate.c | 24 > migration/dirtyrate.h | 10 ++ >

Re: [PATCH v5 07/12] migration/dirtyrate: Compare page hash results for recorded sampled page

2020-08-26 Thread David Edmondson
On Monday, 2020-08-24 at 17:14:35 +08, Chuan Zheng wrote: > Compare page hash results for recorded sampled page. > > Signed-off-by: Chuan Zheng > Signed-off-by: YanYing Zhuang > --- > migration/dirtyrate.c | 64 > +++ > 1 file changed, 64

oslib-posix:Fix handle fd leak in qemu_write_pidfile()

2020-08-26 Thread AlexChen
From: alexchen The fd will leak when (a.st_ino == b.st_ino) is true, fix it. Signed-off-by: AlexChen --- util/oslib-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index ad8001a4ad..74cf5e9c73 100644 --- a/util/oslib-posix.c +++

Re: [PATCH v2 07/10] vfio/platform: Remove dead assignment in vfio_intp_interrupt()

2020-08-26 Thread Li Qiang
Chenqun (kuhn) 于2020年8月26日周三 上午9:47写道: > > > > > Clang static code analyzer show warning: > > > hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read > > > ret = event_notifier_test_and_clear(intp->interrupt); > > > ^

elf2dmp: Fix memory leak on main() error paths

2020-08-26 Thread AlexChen
From: AlexChen The 'kdgb' is allocating memory in get_kdbg(), but it is not freed in both fill_header() and fill_context() failed branches, fix it. Signed-off-by: AlexChen --- contrib/elf2dmp/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/elf2dmp/main.c

Re: [PATCH v5 09/12] migration/dirtyrate: Implement get_sample_page_period() and block_sample_page_period()

2020-08-26 Thread David Edmondson
On Monday, 2020-08-24 at 17:14:37 +08, Chuan Zheng wrote: > Implement get_sample_page_period() and set_sample_page_period() to > sleep specific time between sample actions. > > Signed-off-by: Chuan Zheng > --- > migration/dirtyrate.c | 24 > migration/dirtyrate.h | 2

Re: [PATCH v3 43/74] nubus: Rename class type checking macros

2020-08-26 Thread Laurent Vivier
Le 25/08/2020 à 21:20, Eduardo Habkost a écrit : > Rename the existing class type checking macros to be consistent > with the type name and instance type checking macro. Use a > NUBUS_MACFB prefix instead of MACFB_NUBUS. > > This will make future conversion to OBJECT_DECLARE* easier. > >

Re: [PATCH v3 49/74] swim: Rename struct SWIM to Swim

2020-08-26 Thread Laurent Vivier
Le 25/08/2020 à 21:20, Eduardo Habkost a écrit : > Currently we have a SWIM typedef and a SWIM type checking macro, > but OBJECT_DECLARE* would transform the SWIM macro into a > function, and the function name would conflict with the SWIM > typedef name. > > Rename the struct and typedef to

Re: oslib-posix:Fix handle fd leak in qemu_write_pidfile()

2020-08-26 Thread Daniel P . Berrangé
On Wed, Aug 26, 2020 at 06:14:48PM +0800, AlexChen wrote: > From: alexchen > > The fd will leak when (a.st_ino == b.st_ino) is true, fix it. That is *INTENTIONAL*. We're holding a lock on the file and the lock exists only while the FD is open. When QEMU exists, the FD is closed and the lock

Re: [PATCH v3 00/74] qom: Automated conversion of type checking boilerplate

2020-08-26 Thread Roman Bolshakov
On Tue, Aug 25, 2020 at 03:19:56PM -0400, Eduardo Habkost wrote: > git tree for this series: > https://github.com/ehabkost/qemu-hacks/tree/work/qom-macros-autoconvert > Hi Eduardo, another assert fires during QEMU start: $ lldb -- $QEMU -cpu nahelem -M q35,accel=hvf -cdrom test.iso (lldb)

Re: [PATCH v5 10/12] migration/dirtyrate: Implement calculate_dirtyrate() function

2020-08-26 Thread David Edmondson
On Monday, 2020-08-24 at 17:14:38 +08, Chuan Zheng wrote: > Implement calculate_dirtyrate() function. > > Signed-off-by: Chuan Zheng > Signed-off-by: YanYing Zhuang > --- > migration/dirtyrate.c | 45 +++-- > 1 file changed, 43 insertions(+), 2

Re: [PATCH v2 05/10] hw/virtio/vhost-user:Remove dead assignment in scrub_shadow_regions()

2020-08-26 Thread Li Qiang
Chen Qun 于2020年8月25日周二 下午7:28写道: > > Clang static code analyzer show warning: > hw/virtio/vhost-user.c:606:9: warning: Value stored to 'mr' is never read > mr = vhost_user_get_mr_data(reg->userspace_addr, , ); > ^~ > >

Re: [PATCH v5 11/12] migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function

2020-08-26 Thread David Edmondson
On Monday, 2020-08-24 at 17:14:39 +08, Chuan Zheng wrote: > Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function which could be > called > > Signed-off-by: Chuan Zheng > --- > migration/dirtyrate.c | 45 + > qapi/migration.json | 44

Re: [PATCH v2 1/5] meson: pass confsuffix option

2020-08-26 Thread Daniel P . Berrangé
On Tue, Aug 25, 2020 at 09:58:23PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The following patches will make use of it to fix installation paths. > > Signed-off-by: Marc-André Lureau > --- > configure | 1 + > meson_options.txt | 1 + > 2 files changed, 2

Re: [PATCH v2 2/5] meson: use meson datadir instead of qemu_datadir

2020-08-26 Thread Daniel P . Berrangé
On Tue, Aug 25, 2020 at 09:58:24PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > When cross-compiling, by default qemu_datadir is 'c:\Program > Files\QEMU', which is not recognized as being an absolute path, and > meson will end up adding the prefix again. > >

Re: [PATCH v2 3/5] meson: add docdir option and pass pre-prefix qemu_docdir

2020-08-26 Thread Daniel P . Berrangé
On Tue, Aug 25, 2020 at 09:58:25PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > When cross-compiling, by default qemu_docdir is 'c:\Program Files\QEMU\' > which is not recognized as being an absolute path, and meson will end up > adding the prefix again. > > Add an

Re: [PATCH v2 4/5] meson: use meson mandir instead of qemu_mandir

2020-08-26 Thread Daniel P . Berrangé
On Tue, Aug 25, 2020 at 09:58:26PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > When cross-compiling, by default qemu_mandir is 'c:\Program > Files\QEMU', which is not recognized as being an absolute path, and > meson will end up adding the prefix again. > > Use the

Re: [PATCH v5 06/10] block: introduce BDRV_REQ_NO_WAIT flag

2020-08-26 Thread Max Reitz
On 26.08.20 08:26, Vladimir Sementsov-Ogievskiy wrote: > 25.08.2020 16:10, Max Reitz wrote: >> On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: >>> Add flag to make serialising request no wait: if there are conflicting >>> requests, just return error immediately. It's will be used in

Re: [PATCH v2 3/5] meson: add docdir option and pass pre-prefix qemu_docdir

2020-08-26 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2020 at 12:32 PM Daniel P. Berrangé wrote: > On Tue, Aug 25, 2020 at 09:58:25PM +0400, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau > > > > When cross-compiling, by default qemu_docdir is 'c:\Program Files\QEMU\' > > which is not recognized as being an

Re: [PATCH v2 5/5] meson: add NSIS building

2020-08-26 Thread Daniel P . Berrangé
On Tue, Aug 25, 2020 at 09:58:27PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > Makefile| 56 --- > meson.build | 25 > scripts/nsis.py | 78

Re: linux-user static build broken

2020-08-26 Thread Daniel P . Berrangé
On Tue, Aug 25, 2020 at 10:36:13PM +0200, Laurent Vivier wrote: > Hi, > > since we have switched to meson, the statically linked binaries of qemu > linux-user are broken: > > cd $OBJ > $SRC/configure --static --target-list=m68k-linux-user > make > ./qemu-m68k > Segmentation fault (core dumped) >

[Bug 1893010] [NEW] qemu linux-user doesn't support OFD fcntl locks

2020-08-26 Thread Mike Gelfand
Public bug reported: "Open file description locks (non-POSIX)", as they are described in fcntl(2) man page, aren't supported by qemu-user and attempting to use those results in EINVAL. I'm on Gentoo with latest QEMU version currently available (5.0.0-r2), and trying to emulate ppc64 and s390x on

Re: linux-user static build broken

2020-08-26 Thread Laurent Vivier
Le 26/08/2020 à 10:44, Daniel P. Berrangé a écrit : > On Tue, Aug 25, 2020 at 10:36:13PM +0200, Laurent Vivier wrote: >> Hi, >> >> since we have switched to meson, the statically linked binaries of qemu >> linux-user are broken: >> >> cd $OBJ >> $SRC/configure --static

Re: [PATCH v5 07/10] block: introduce preallocate filter

2020-08-26 Thread Max Reitz
On 26.08.20 08:49, Vladimir Sementsov-Ogievskiy wrote: > 25.08.2020 18:11, Max Reitz wrote: >> On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: >>> It's intended to be inserted between format and protocol nodes to >>> preallocate additional space (expanding protocol file) on writes >>>

Re: [PATCH v2 2/5] meson: use meson datadir instead of qemu_datadir

2020-08-26 Thread Marc-André Lureau
Hi On Wed, Aug 26, 2020 at 12:30 PM Daniel P. Berrangé wrote: > On Tue, Aug 25, 2020 at 09:58:24PM +0400, marcandre.lur...@redhat.com > wrote: > > From: Marc-André Lureau > > > > When cross-compiling, by default qemu_datadir is 'c:\Program > > Files\QEMU', which is not recognized as being an

[Bug 1893003] Re: qemu linux-user doesn't translate host/target data for iovec I/O

2020-08-26 Thread Mike Gelfand
** Summary changed: - qemu-user doesn't translate host/target data for iovec I/O + qemu linux-user doesn't translate host/target data for iovec I/O ** Tags added: linux-user ** Tags added: ppc s390x -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Bug 1893010] Re: qemu linux-user doesn't support OFD fcntl locks

2020-08-26 Thread Mike Gelfand
** Summary changed: - qemu-user doesn't support OFD fcntl locks + qemu linux-user doesn't support OFD fcntl locks ** Tags added: linux-user -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1893010

Re: [PATCH v5 06/10] block: introduce BDRV_REQ_NO_WAIT flag

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
26.08.2020 11:36, Max Reitz wrote: On 26.08.20 08:26, Vladimir Sementsov-Ogievskiy wrote: 25.08.2020 16:10, Max Reitz wrote: On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: Add flag to make serialising request no wait: if there are conflicting requests, just return error immediately.

Re: device compatibility interface for live migration with assigned devices

2020-08-26 Thread Yan Zhao
On Thu, Aug 20, 2020 at 02:24:26PM +0100, Sean Mooney wrote: > On Thu, 2020-08-20 at 14:27 +0800, Yan Zhao wrote: > > On Thu, Aug 20, 2020 at 06:16:28AM +0100, Sean Mooney wrote: > > > On Thu, 2020-08-20 at 12:01 +0800, Yan Zhao wrote: > > > > On Thu, Aug 20, 2020 at 02:29:07AM +0100, Sean Mooney

Re: linux-user static build broken

2020-08-26 Thread Paolo Bonzini
$ORIGIN is a special literal used by ld.so. It's probably fixed by the same patch that was posted for msys. Paolo Il mer 26 ago 2020, 10:51 Laurent Vivier ha scritto: > Le 26/08/2020 à 10:44, Daniel P. Berrangé a écrit : > > On Tue, Aug 25, 2020 at 10:36:13PM +0200, Laurent Vivier wrote: > >>

Re: [PATCH v5 07/10] block: introduce preallocate filter

2020-08-26 Thread Vladimir Sementsov-Ogievskiy
26.08.2020 11:52, Max Reitz wrote: On 26.08.20 08:49, Vladimir Sementsov-Ogievskiy wrote: 25.08.2020 18:11, Max Reitz wrote: On 21.08.20 16:11, Vladimir Sementsov-Ogievskiy wrote: It's intended to be inserted between format and protocol nodes to preallocate additional space (expanding

[Bug 1892604] Re: qemu-system-arm: ../hw/usb/hcd-dwc2.c:666: dwc2_glbreg_read: Assertion `addr <= GINTSTS2' failed.

2020-08-26 Thread Peter Maydell
It is still a bug in QEMU -- we shouldn't allow guest behaviour to make QEMU assert(). If there's unimplemented functionality in the USB controller model that can be logged with qemu_log_mask(LOG_UNIMP, ...) -- You received this bug notification because you are a member of qemu- devel-ml, which

QEMU | Pipeline #182124352 has failed for master | 78dca230

2020-08-26 Thread GitLab via
Your pipeline has failed. Project: QEMU ( https://gitlab.com/qemu-project/qemu ) Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master ) Commit: 78dca230 ( https://gitlab.com/qemu-project/qemu/-/commit/78dca230c97ed0d6e16ae0c96d5407644d991994 ) Commit Message: Merge

[PATCH v6 04/20] acpi: ged: add control regs

2020-08-26 Thread Gerd Hoffmann
Add control regs (sleep, reset) for hw-reduced acpi. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- include/hw/acpi/generic_event_device.h | 12 +++ hw/acpi/generic_event_device.c | 44 ++ 2 files changed, 56 insertions(+) diff --git

Re: [PATCH v5 03/12] migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info

2020-08-26 Thread David Edmondson
On Wednesday, 2020-08-26 at 11:33:30 +01, Dr. David Alan Gilbert wrote: > * David Edmondson (d...@dme.org) wrote: >> On Monday, 2020-08-24 at 17:14:31 +08, Chuan Zheng wrote: >> >> > Add RamlockDirtyInfo to store sampled page info of each ramblock. >> > >> > Signed-off-by: Chuan Zheng >> > ---

[PATCH v6 15/20] x86: move cpu hotplug from pc to x86

2020-08-26 Thread Gerd Hoffmann
The cpu hotplug code handles the initialization of coldplugged cpus too, so it is needed even in case cpu hotplug is not supported. Move the code from pc to x86, so microvm can use it. Move both plug and unplug to keep everything in one place, even though microvm needs plug only. Signed-off-by:

[PATCH v6 17/20] tests/acpi: allow microvm test data updates.

2020-08-26 Thread Gerd Hoffmann
Also add empty test data files. Signed-off-by: Gerd Hoffmann --- tests/qtest/bios-tables-test-allowed-diff.h | 3 +++ tests/data/acpi/microvm/APIC| 0 tests/data/acpi/microvm/DSDT| 0 tests/data/acpi/microvm/FACP| 0 4 files changed, 3

[PATCH v6 16/20] microvm: wire up hotplug

2020-08-26 Thread Gerd Hoffmann
The cpu hotplug code handles the initialization of coldplugged cpus too, so it is needed even in case cpu hotplug is not supported. Wire cpu hotplug up for microvm. Without this we get a broken MADT table. Signed-off-by: Gerd Hoffmann Reviewed-by: Igor Mammedov --- hw/i386/microvm.c | 42

Re: [PATCH v4 3/6] util: add Error object for qemu_open_internal error reporting

2020-08-26 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Aug 25, 2020 at 05:14:21PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > Instead of relying on the limited information from errno, we can now >> > also provide detailed error messages. >> >> The more detailed error messages are

Re: linux-user static build broken

2020-08-26 Thread Laurent Vivier
Le 26/08/2020 à 11:08, Paolo Bonzini a écrit : > $ORIGIN is a special literal used by ld.so. It's probably fixed by the > same patch that was posted for msys. If I remove the "-Wl,-rpath,RIGIN/" from the command line to build qemu-m68k, it works again. What the patch name or series? Thanks,

  1   2   3   4   5   >