> Remove all the hardcoded values and replace with generalized
> fields.
>
> Signed-off-by: Babu Moger
> ---
> target/i386/cpu.c | 31 ---
> 1 file changed, 16 insertions(+), 15 deletions(-)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index ba4667b33c..b
CCing qemu-s390x.
On 01.09.20 17:00, Marc Hartmayer wrote:
> This patch series is about enabling virtio-fs on s390x. For that we need
> + some shim code (first patch), and we need
> + libvhost-user to deal with virtio endiannes for non-legacy virtio
>devices as mandated by the spec.
>
> Ho
On Tue, 1 Sep 2020 20:39:27 +0530
Ani Sinha wrote:
> Ability to turn hotplug off on the pci root bus for i440fx was added in
> commit:
> 3d7e78aaf0 ("Introduce a new flag for i440fx to disable PCI hotplug on
> the root bus")
>
> This change adds a unit test in order to test this feature.
Can someone please review this?
On Aug 29, 2020, 13:42 +0530, Ani Sinha , wrote:
> When ACPI hotplug for the root bus is disabled, the bsel property for that
> bus is not set. Please see the following commit:
>
> 3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the
> root
Eugenio Pérez wrote:
> Previous name didn't reflect the iommu operation.
>
> Signed-off-by: Eugenio Pérez
Reviewed-by: Juan Quintela
On 2020/8/21 下午7:08, Stefan Hajnoczi wrote:
The first vDPA ioctls have been added to the vhost-user protocol and I
wonder if it's time to fully change the vhost-user protocol's focus to
providing a full VIRTIO device model like vDPA does.
Initially vhost-user was just used for vhost-net. As a
Hi,
> > Also a single IRQ only.
> >
> > I'm wondering which is correct? Probably one IRQ? Do we need support for
> > multiple IRQs in xhci-sysbus in the first place?
> [Sai Pavan Boddu] It should be only one, as others seems to be define for
> device and OTG modes.
Documenting the registers
On Tue, Sep 01, 2020 at 03:04:59AM -0400, Paolo Bonzini wrote:
> We do not need to ask cmake for the dependencies, so just use the
> pkg-config mechanism. Keep "auto" for SDL so that it tries using
> sdl-config too.
>
> The documentation is adjusted to use SDL2_image as the example,
> rather than
Hello Vikram,
thanks much for the patches review.
On Tuesday 01 of September 2020 22:01:26 Vikram Garhwal wrote:
> Hi Jan,
> A couple of comments on this patch.
>
> On Tue, Jul 14, 2020 at 02:20:14PM +0200, p...@cmp.felk.cvut.cz wrote:
> > From: Jan Charvat
> > @@ -185,13 +204,34 @@ static void
Eugenio Pérez wrote:
> This way we can tell between regulars IOMMURLBEntries (entry of IOMMU
> hardware) and notifications.
>
> In the notifications, we set explicitly if it is a MAPs or an UNMAP,
> instead of trusting in entry permissions to differenciate them.
>
> Signed-off-by: Eugenio Pérez
Eugenio Pérez wrote:
> Adapt intel and vhost to use this new notification type
>
> Signed-off-by: Eugenio Pérez
Reviewed-by: Juan Quintela
Daniel P. Berrangé writes:
> On Tue, Sep 01, 2020 at 04:38:46PM +0200, Markus Armbruster wrote:
>> One more question...
>>
>> Lukas Straub writes:
>>
>> > The yank feature allows to recover from hanging qemu by "yanking"
>> > at various parts. Other qemu systems can register themselves and
>>
Eugenio Pérez wrote:
> Signed-off-by: Eugenio Pérez
Reviewed-by: Juan Quintela
check-block has its own test harness, unlike every other test. If
we capture its output, as is in general nicer to do without V=1,
there will be no sign of progress. So for lack of a better option
just move the invocation of the test back to Makefile rules.
As a side effect, this will also fix "
On Tue, Sep 1, 2020 at 11:14 PM Peter Xu wrote:
>
> On Tue, Sep 01, 2020 at 04:26:03PM +0200, Eugenio Pérez wrote:
> > I am able to hit this assertion when a Red Hat 7 guest virtio_net device
> > raises an "Invalidation" of all the TLB entries. This happens in the
> > guest's startup if 'intel_iom
Fix an error handling issue reported by Coverity:
/qemu/tests/qtest/ahci-test.c: 1452 in prepare_iso()
1444 int fd = mkstemp(cdrom_path);
>>> CID 1432375: Error handling issues (NEGATIVE_RETURNS)
>>> "fd" is passed to a parameter that cannot be negative.
1452 re
This variable is used once in an assertion. Remove single
declaration and access directly in the assert().
See in "qemu/osdep.h":
* [...] disable assertion is not
* supported upstream so the risk is all yours. Meanwhile, please
* submit patches to remove any s
This variable is used once in an assertion. Remove single
declaration and access directly in the assert().
See in "qemu/osdep.h":
* [...] disable assertion is not
* supported upstream so the risk is all yours. Meanwhile, please
* submit patches to remove any s
Fix a Coverity warning in qtest,
do not declare local variable only used for assertions
(use them directly).
Philippe Mathieu-Daudé (5):
tests/qtest/ipmi-kcs: Fix assert side-effect
hw/pci-bridge: Do not declare local variable only used for assertion
hw/ppc/spapr: Do not declare local variab
Fix assert side-effect reported by Coverity:
/qemu/tests/qtest/ipmi-kcs-test.c: 84 in kcs_wait_obf()
83 while (IPMI_KCS_CMDREG_GET_OBF() == 0) {
>>> CID 1432368: Incorrect expression (ASSERT_SIDE_EFFECT)
>>> Argument "--count" of g_assert() has a side effect. The contain
This variable is used once in an assertion. Remove single
declaration and access directly in the assert().
See in "qemu/osdep.h":
* [...] disable assertion is not
* supported upstream so the risk is all yours. Meanwhile, please
* submit patches to remove any s
This variable is used once in an assertion. Remove single
declaration and access directly in the assert().
See in "qemu/osdep.h":
* [...] disable assertion is not
* supported upstream so the risk is all yours. Meanwhile, please
* submit patches to remove any s
The functions using these arrays expect a "const unsigned char *"
argument, it is safe to declare these as 'static const'.
Signed-off-by: Philippe Mathieu-Daudé
---
tests/qtest/tpm-tests.c | 4 ++--
tests/qtest/tpm-util.c | 10 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff
> > +#include
> > +int rc = ioctl(hostfd, USBDEVFS_GET_SPEED, NULL);
>
> This (further) breaks a bunch of the Travis jobs - I assume because libusb
> doesn't
> always have this symbol:
>
> ../hw/usb/host-libusb.c:954:32: error: ‘USBDEVFS_GET_SPEED’ undeclared
> (first use in this fu
On 9/2/20 8:53 AM, Cédric Le Goater wrote:
> On 9/1/20 12:40 PM, Philippe Mathieu-Daudé wrote:
>> Replace the magic '4' by ARRAY_SIZE(s->irq) which is more explicit.
>
> We could also define the 'irq' array with PCI_NUM_PINS instead of 4.
Good idea, thanks!
>
>> Signed-off-by: Philippe Mathieu-
Fixes build failures with old kernels (USBDEVFS_GET_SPEED missing),
on the assumtion that distros with old kernels also have old libusb.
Reported-by: Alex Bennée
Signed-off-by: Gerd Hoffmann
---
hw/usb/host-libusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/host
GDB remote protocol supports reverse debugging of the targets.
It includes 'reverse step' and 'reverse continue' operations.
The first one finds the previous step of the execution,
and the second one is intended to stop at the last breakpoint that
would happen when the program is executed normally.
On Tue, Sep 1, 2020 at 10:55 PM Peter Xu wrote:
>
> On Tue, Sep 01, 2020 at 04:26:05PM +0200, Eugenio Pérez wrote:
> > This way we can tell between regulars IOMMURLBEntries (entry of IOMMU
> > hardware) and notifications.
>
> s/regulars IOMMURLBEntries/regular IOMMUTLBEntry/
>
> >
> > In the notif
From: Pavel Dovgalyuk
This patch adds an accessor function for the name of the record/replay
log file. Adding an accessor instead of making variable global,
prevents accidental modification of this variable by other modules.
Signed-off-by: Pavel Dovgalyuk
Reviewed-by: Alex Bennée
---
include/
Interrupt poll is not a real interrupt event. It is needed only for
thread safety. This interrupt is used for i386 and converted
to hardware interrupt by cpu_handle_interrupt function.
Therefore it is not needed to be recorded, because hardware
interrupt will be recorded after converting.
Signed-o
From: Pavel Dovgalyuk
This patch introduces the icount field for saving within the snapshot.
It is required for navigation between the snapshots in record/replay mode.
Signed-off-by: Pavel Dovgalyuk
Acked-by: Kevin Wolf
---
block/qcow2-snapshot.c |7 +++
block/qcow2.h |3
From: Pavel Dovgalyuk
Saving icount as a parameters of the snapshot allows navigation between
them in the execution replay scenario.
This information can be used for finding a specific snapshot for proceeding
the recorded execution to the specific moment of the time.
E.g., 'reverse step' action (
From: Pavel Dovgalyuk
This patch updates iotests that verify qemu monitor output.
New output format for snapshot listing include ICOUNT column.
Signed-off-by: Pavel Dovgalyuk
---
tests/qemu-iotests/267.out | 48 ++--
1 file changed, 24 insertions(+), 2
From: Pavel Dovgalyuk
This patch introduces 'info replay' monitor command and
corresponding qmp request.
These commands request the current record/replay mode, replay log file
name, and the instruction count (number of recorded/replayed
instructions). The instruction count can be used with the
r
From: Pavel Dovgalyuk
This patch introduces replay_break, replay_delete_break
qmp and hmp commands.
These commands allow stopping at the specified instruction.
It may be useful for debugging when there are some known
events that should be investigated.
replay_break command has one argument - numb
From: Pavel Dovgalyuk
This patch adds replay.json file. It will be
used for adding record/replay-related data structures and commands.
Signed-off-by: Pavel Dovgalyuk
Reviewed-by: Markus Armbruster
Reviewed-by: Alex Bennée
---
MAINTAINERS |1 +
include/sysemu/replay.h |1 +
From: Pavel Dovgalyuk
This patch adds support of the reverse continue operation for gdbstub.
Reverse continue finds the last breakpoint that would happen in normal
execution from the beginning to the current moment.
Implementation of the reverse continue replays the execution twice:
to find the b
From: Pavel Dovgalyuk
This patch adds hmp/qmp commands replay_seek/replay-seek that proceed
the execution to the specified instruction count.
The command automatically loads nearest snapshot and replays the execution
to find the desired instruction count.
Signed-off-by: Pavel Dovgalyuk
Acked-by
From: Pavel Dovgalyuk
Non-empty record/replay queue prevents saving and loading the VM state,
because it includes pending bottom halves and block coroutines.
But when the new VM state is loaded, we don't have to preserve the consistency
of the current state anymore. Therefore this patch just flus
From: Pavel Dovgalyuk
This patch updates the documentation and describes usage of the reverse
debugging in QEMU+GDB.
Signed-off-by: Pavel Dovgalyuk
---
docs/replay.txt | 33 +
1 file changed, 33 insertions(+)
diff --git a/docs/replay.txt b/docs/replay.txt
ind
On Wed, Sep 02, 2020 at 04:00:46AM -0400, Paolo Bonzini wrote:
> check-block has its own test harness, unlike every other test. If
> we capture its output, as is in general nicer to do without V=1,
> there will be no sign of progress. So for lack of a better option
> just move the invocation of t
On 9/2/20 10:14 AM, Gerd Hoffmann wrote:
> Fixes build failures with old kernels (USBDEVFS_GET_SPEED missing),
> on the assumtion that distros with old kernels also have old libusb.
>
> Reported-by: Alex Bennée
> Signed-off-by: Gerd Hoffmann
> ---
> hw/usb/host-libusb.c | 2 +-
> 1 file changed
From: Pavel Dovgalyuk
Reverse debugging test uses gdb remote client of avocado framework.
This client was fixed since the currently used version 76.
Therefore this patch bumps the version to 81 and fixes command
line version compatibility issue.
Signed-off-by: Pavel Dovgalyuk
---
tests/Makefil
On Dienstag, 1. September 2020 14:45:55 CEST David Cohen wrote:
> Hi,
>
> I'm trying to use qemu on OSX Catalina using HVF hypervisor, but it's
> currently panic'ing upon booting Linux guest.
>
> These are the args I'm using:
> build % ./qemu-system-x86_64 -cdrom
> ~/Downloads/archlinux-2020.08.0
On Wed, Sep 02, 2020 at 07:23:13AM +0200, kra...@redhat.com wrote:
> Hi,
>
> > 1. CentOS7 with Python 2.7.5
>
> > Root cause is my argparse and python version. But change the invoking order
> > can adapt both new and old argparse.
>
> python2 is EOL and not supported any more.
> please "y
On 9/1/20 8:20 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> util/oslib-posix.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index a68fccb52d..8e23b8fac0 100644
> --- a/util/oslib-posix.c
> +++ b/util/o
From: Pavel Dovgalyuk
GDB remote protocol supports two reverse debugging commands:
reverse step and reverse continue.
This patch adds support of the first one to the gdbstub.
Reverse step is intended to step one instruction in the backwards
direction. This is not possible in regular execution.
Bu
From: Pavel Dovgalyuk
This is a test for GDB reverse debugging commands: reverse step and reverse
continue.
Every test in this suite consists of two phases: record and replay.
Recording saves the execution of some instructions and makes an initial
VM snapshot to allow reverse execution.
Replay s
On 9/1/20 8:20 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> include/net/net.h | 4 ++--
> net/tap.c | 28 +---
> 2 files changed, 23 insertions(+), 9 deletions(-)
>
> diff --git a/include/net/net.h b/include/net/net.h
> index e7ef42d62b..897b2d
On 9/1/20 8:20 AM, Paolo Bonzini wrote:
> As an additional advantage, the logic is now unified between
> POSIX and Win32 systems.
>
> Signed-off-by: Paolo Bonzini
> ---
> include/qemu-common.h | 1 -
> include/sysemu/sysemu.h | 2 +-
> os-posix.c | 20
> os-
On 9/1/20 8:20 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> softmmu/vl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/softmmu/vl.c b/softmmu/vl.c
> index 81e325fa44..b79de9cd66 100644
> --- a/softmmu/vl.c
> +++ b/softmmu/vl.c
> @@ -2676,8 +2676,9
On 9/1/20 8:20 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> ui/gtk.c | 10 --
> ui/sdl2.c | 9 +++--
> 2 files changed, 15 insertions(+), 4 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 02/09/20 10:28, Philippe Mathieu-Daudé wrote:
>>
>> -void qemu_add_data_dir(const char *path)
>> +void qemu_add_data_dir(char *path)
> But we have 'const char *data_dir[16];', why remove the const?
In order to free duplicates: before this patch the directory can be
statically- or stack-alloca
On Friday, August 28, 2020, Ahmed Karaman
wrote:
> A nightly performance testing system to monitor any change in QEMU
> performance across seventeen different targets.
>
>
Reviewed-by: Aleksandar Markovic
> The system includes eight different benchmarks to provide a variety
> of testing workl
On 02/09/20 10:19, Daniel P. Berrangé wrote:
> On Wed, Sep 02, 2020 at 04:00:46AM -0400, Paolo Bonzini wrote:
>> check-block has its own test harness, unlike every other test. If
>> we capture its output, as is in general nicer to do without V=1,
>> there will be no sign of progress. So for lack
On Friday, August 28, 2020, Ahmed Karaman
wrote:
> Add a new 'tests/performance' directory under the 'Performance Tools
> and Tests' subsection.
>
>
Reviewed-by: Aleksandar Markovic
> Signed-off-by: Ahmed Karaman
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/M
On Wednesday, 2020-09-02 at 10:09:09 +02, Philippe Mathieu-Daudé wrote:
> The functions using these arrays expect a "const unsigned char *"
> argument, it is safe to declare these as 'static const'.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Darren Kenny
> ---
> tests/qtest/tpm-tes
Applying both, thanks!
On Wed, Sep 2, 2020 at 9:54 AM Juan Quintela wrote:
>
> Eugenio Pérez wrote:
> > This way we can tell between regulars IOMMURLBEntries (entry of IOMMU
> > hardware) and notifications.
> >
> > In the notifications, we set explicitly if it is a MAPs or an UNMAP,
> > instead
On 02/09/20 10:24, Philippe Mathieu-Daudé wrote:
>> -helper = bridge->has_helper ? bridge->helper : DEFAULT_BRIDGE_HELPER;
>> +if (!bridge->has_helper) {
>> +helper = default_helper = get_relocated_path(DEFAULT_BRIDGE_HELPER);
>> +} else {
>> +helper = bridge->helper;
>>
On 9/2/20 10:35 AM, Paolo Bonzini wrote:
> On 02/09/20 10:28, Philippe Mathieu-Daudé wrote:
>>>
>>> -void qemu_add_data_dir(const char *path)
>>> +void qemu_add_data_dir(char *path)
>> But we have 'const char *data_dir[16];', why remove the const?
>
> In order to free duplicates: before this pat
On 9/1/20 6:59 PM, Thomas Huth wrote:
> On 31/08/2020 17.09, Janosch Frank wrote:
>> If a blob provides a reset PSW then we should use it instead of
>> branching to the PSW address and using our own mask.
>>
>> Signed-off-by: Janosch Frank
>> ---
>> pc-bios/s390-ccw/bootmap.c | 3 ++-
>> pc-bio
On Friday, August 28, 2020, Ahmed Karaman
wrote:
> - Apply pylint and flake8 formatting rules to the script.
> - Move syntax and usage exmaple to main() docstring.
> - Update get_jit_line() to only detect the main jit call.
> - Use mypy for specifying parameters and return types in functions.
>
>
On Wed, 2 Sep 2020 10:07:57 +0200
Philippe Mathieu-Daudé wrote:
> Fix assert side-effect reported by Coverity:
>
> /qemu/tests/qtest/ipmi-kcs-test.c: 84 in kcs_wait_obf()
> 83 while (IPMI_KCS_CMDREG_GET_OBF() == 0) {
> >>> CID 1432368: Incorrect expression (ASSERT_SIDE_EFFEC
Am 01.09.2020 um 16:34 hat Max Reitz geschrieben:
> This includes some permission limiting (for example, we only need to
> take the RESIZE permission for active commits where the base is smaller
> than the top).
>
> base_overlay is introduced so we can query bdrv_is_allocated_above() on
> it - we
On Wed, 2 Sep 2020 10:07:58 +0200
Philippe Mathieu-Daudé wrote:
> This variable is used once in an assertion. Remove single
> declaration and access directly in the assert().
>
> See in "qemu/osdep.h":
>
> * [...] disable assertion is not
> * supported upstre
On Wed, 2 Sep 2020 10:07:59 +0200
Philippe Mathieu-Daudé wrote:
> This variable is used once in an assertion. Remove single
> declaration and access directly in the assert().
>
> See in "qemu/osdep.h":
>
> * [...] disable assertion is not
> * supported upstre
On Wed, 2 Sep 2020 10:08:00 +0200
Philippe Mathieu-Daudé wrote:
> This variable is used once in an assertion. Remove single
> declaration and access directly in the assert().
>
> See in "qemu/osdep.h":
>
> * [...] disable assertion is not
> * supported upstre
Hi Eugenio,
On 9/1/20 4:26 PM, Eugenio Pérez wrote:
> Previous name didn't reflect the iommu operation.
>
> Signed-off-by: Eugenio Pérez
Reviewed-by: Eric Auger
Thanks
Eric
> ---
> hw/arm/smmu-common.c | 2 +-
> hw/arm/smmuv3.c | 2 +-
> hw/i386/intel_iommu.c | 4 ++--
> include/exec
Le 01/09/2020 à 12:19, Philippe Mathieu-Daudé a écrit :
> TCO_DEBUG() and DEBUG definitions are not used, remove them.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/acpi/tco.c | 11 ---
> 1 file changed, 11 deletions(-)
>
> diff --git a/hw/acpi/tco.c b/hw/acpi/tco.c
> index fb905
Am 01.09.2020 um 16:34 hat Max Reitz geschrieben:
> We have to perform an active commit whenever the top node has a parent
> that has taken the WRITE permission on it.
>
> This means that block-commit's @backing-file parameter is longer allowed
s/longer/no longer/
> for such nodes, and that user
On Wed, 2 Sep 2020 10:08:01 +0200
Philippe Mathieu-Daudé wrote:
> This variable is used once in an assertion. Remove single
> declaration and access directly in the assert().
>
> See in "qemu/osdep.h":
>
> * [...] disable assertion is not
> * supported upstre
> apic_id contains all the information required to build
> CPUID_8000_001E. core_id and node_id is already part of
> apic_id generated by x86_topo_ids_from_apicid.
>
> Also remove the restriction on number bits on core_id and
> node_id.
>
> Remove all the hardcoded values and replace with generaliz
Le 01/09/2020 à 12:42, Philippe Mathieu-Daudé a écrit :
> Replace fprintf() by qemu_log_mask(LOG_GUEST_ERROR).
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/gpio/omap_gpio.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/gpio/omap_gpio.c b/hw/gpio/omap_
Le 01/09/2020 à 12:42, Philippe Mathieu-Daudé a écrit :
> Replace disabled printf() by qemu_log_mask(UNIMP).
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/gpio/max7310.c | 11 +--
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/hw/gpio/max7310.c b/hw/gpio/max73
Daniel P. Berrangé writes:
> On Tue, Sep 01, 2020 at 04:20:47PM +0200, Markus Armbruster wrote:
>> Daniel P. Berrangé writes:
>>
>> > savevm, loadvm and delvm are some of the few HMP commands that have never
>> > been converted to use QMP. The primary reason for this lack of conversion
>> > is
The SFDP table is 0x80 bytes long. The mandatory table for basic
features is available at byte 0x30 and an extra Macronix specific
table is available at 0x60.
4B opcodes are not supported.
Signed-off-by: Cédric Le Goater
---
hw/block/m25p80_sfdp.h | 3 +++
hw/block/m25p80.c | 3 ++-
hw/b
Hello,
JEDEC STANDARD JESD216 for Serial Flash Discovery Parameters (SFDP)
provides a mean to describe the features of a serial flash device
using a set of internal parameter tables. Support in Linux has been
added some time ago and the spi-nor driver is using it more often
to detect the flash set
JEDEC STANDARD JESD216 for Serial Flash Discovery Parameters (SFDP)
provides a mean to describe the features of a serial flash device
using a set of internal parameter tables.
This is the initial framework for the RDSFDP command giving access to
a private SFDP area under the flash. This area now n
The SFDP table size is 0x200 bytes long. The mandatory table for basic
features is available at byte 0x30 plus some more Macronix specific
tables.
Signed-off-by: Cédric Le Goater
---
hw/block/m25p80_sfdp.h | 2 +-
hw/block/m25p80.c | 3 +-
hw/block/m25p80_sfdp.c | 68 +
The SFDP table size is 0x100 bytes long. Only the mandatory table for
basic features is available at byte 0x80.
Signed-off-by: Cédric Le Goater
---
hw/block/m25p80_sfdp.h | 2 ++
hw/block/m25p80.c | 3 ++-
hw/block/m25p80_sfdp.c | 40
3 files chang
The SFDP table size is 0x100 bytes long. The mandatory table for basic
features is available at byte 0x80 and two extra Winbond specifics
table are available at 0xC0 and 0xF0.
Signed-off-by: Cédric Le Goater
---
hw/block/m25p80_sfdp.h | 1 +
hw/block/m25p80.c | 3 ++-
hw/block/m25p80_sfdp
The mx25l25635e and mx25l25635f chips have the same JEDEC id but the
mx25l25635f has more capabilities reported in the SFDP table. Support
for 4B opcodes is of interest because it is exploited by the Linux
kernel.
The SFDP table size is 0x200 bytes long. The mandatory table for basic
features is a
Modify the snooping routine to handle RDSFDP, 1 dummy and 3 bytes
address space.
Signed-off-by: Cédric Le Goater
---
include/hw/ssi/aspeed_smc.h | 1 +
hw/ssi/aspeed_smc.c | 21 ++---
2 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/include/hw/ssi/aspeed_s
A mx25l25635f chip model is generally found on these machines. It's
newer and uses 4B opcodes which is better to exercise the support in
the Linux kernel.
Signed-off-by: Cédric Le Goater
---
hw/arm/aspeed.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/arm/aspeed.c
On 02/09/2020 10.05, Philippe Mathieu-Daudé wrote:
> Fix an error handling issue reported by Coverity:
>
> /qemu/tests/qtest/ahci-test.c: 1452 in prepare_iso()
> 1444 int fd = mkstemp(cdrom_path);
> >>> CID 1432375: Error handling issues (NEGATIVE_RETURNS)
> >>> "fd" is p
The same values were collected on 4 differents OpenPower systems,
palmettos, romulus and tacoma.
The SFDP table size is defined as being 0x100 bytes but it could be
bigger. Only the mandatory table for basic features is available at
byte 0x30.
Signed-off-by: Cédric Le Goater
---
hw/block/m25p80
On Tue, Sep 01, 2020 at 03:54:29PM +0100, Peter Maydell wrote:
> On Tue, 1 Sep 2020 at 15:16, Gerd Hoffmann wrote:
> >
> > Hi,
> >
> > > Generating ar with a custom command
> > > cp: '../../pc-bios/keymaps/ar' and 'pc-bios/keymaps/ar' are the same file
> >
> > Hmm, strange. No failures in gitla
On 02/09/2020 10.09, Philippe Mathieu-Daudé wrote:
> The functions using these arrays expect a "const unsigned char *"
> argument, it is safe to declare these as 'static const'.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> tests/qtest/tpm-tests.c | 4 ++--
> tests/qtest/tpm-util.c | 10 ++
On 02/09/2020 10.46, Janosch Frank wrote:
> On 9/1/20 6:59 PM, Thomas Huth wrote:
>> On 31/08/2020 17.09, Janosch Frank wrote:
>>> If a blob provides a reset PSW then we should use it instead of
>>> branching to the PSW address and using our own mask.
>>>
>>> Signed-off-by: Janosch Frank
>>> ---
>
On 9/2/20 11:11 AM, Greg Kurz wrote:
> On Wed, 2 Sep 2020 10:08:01 +0200
> Philippe Mathieu-Daudé wrote:
>
>> This variable is used once in an assertion. Remove single
>> declaration and access directly in the assert().
>>
>> See in "qemu/osdep.h":
>>
>> * [...]
On 02/09/2020 10.07, Philippe Mathieu-Daudé wrote:
> Fix assert side-effect reported by Coverity:
>
> /qemu/tests/qtest/ipmi-kcs-test.c: 84 in kcs_wait_obf()
> 83 while (IPMI_KCS_CMDREG_GET_OBF() == 0) {
> >>> CID 1432368: Incorrect expression (ASSERT_SIDE_EFFECT)
> >>> A
Hi Alex,
Apologies for not taking so long to get to this.
On Wednesday, 2020-08-19 at 02:10:57 -04, Alexander Bulekov wrote:
> This is a generic fuzzer designed to fuzz a virtual device's
> MemoryRegions, as long as they exist within the Memory or Port IO (if it
> exists) AddressSpaces. The fuz
Hi Paolo,
there seems to be some parallelism or race condition somewhere?
with master, commit 8d90bfc5c31ad60f6049dd39be636b06bc00b652
I am doing:
mkdir build-nontcg
cd build-nontcg
../configure --disable-tcg --enable-kvm --enable-hax
make -j120
make -j120 check
I am getting:
Compiling C obj
On 02/09/2020 10.17, Daniel P. Berrangé wrote:
> On Wed, Sep 02, 2020 at 07:23:13AM +0200, kra...@redhat.com wrote:
>> Hi,
>>
>>> 1. CentOS7 with Python 2.7.5
>>
>>> Root cause is my argparse and python version. But change the invoking order
>>> can adapt both new and old argparse.
>>
>> pyt
Patchew URL:
https://patchew.org/QEMU/20200901151823.29785-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20200901151823.29785-1-peter.mayd...@linaro.org
Subject: [PULL 00/47] target-arm que
Hi Eugenio,
On 9/1/20 4:26 PM, Eugenio Pérez wrote:
> This way we can tell between regulars IOMMURLBEntries (entry of IOMMU
> hardware) and notifications.>
> In the notifications, we set explicitly if it is a MAPs or an UNMAP,
> instead of trusting in entry permissions to differenciate them.
diffe
On 02.09.20 10:53, Kevin Wolf wrote:
> Am 01.09.2020 um 16:34 hat Max Reitz geschrieben:
>> This includes some permission limiting (for example, we only need to
>> take the RESIZE permission for active commits where the base is smaller
>> than the top).
>>
>> base_overlay is introduced so we can qu
On 29.08.20 01:21, Nir Soffer wrote:
> Fix some issues introduced when iotests.FilePaths was added and merge it back
> into FilePath keeping the option to create multiple file names.
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
signature.asc
Des
On 02/09/2020 10.37, Paolo Bonzini wrote:
> On 02/09/20 10:19, Daniel P. Berrangé wrote:
>> On Wed, Sep 02, 2020 at 04:00:46AM -0400, Paolo Bonzini wrote:
>>> check-block has its own test harness, unlike every other test. If
>>> we capture its output, as is in general nicer to do without V=1,
>>>
Am 01.09.2020 um 16:33 hat Max Reitz geschrieben:
> v6: https://lists.nongnu.org/archive/html/qemu-devel/2019-08/msg01715.html
> v7: https://lists.nongnu.org/archive/html/qemu-block/2020-06/msg01357.html
>
> Branch: https://github.com/XanClic/qemu.git child-access-functions-v8
> Branch: https://gi
1 - 100 of 545 matches
Mail list logo
