Re: [PATCH v2] tests: Trying fixes test-replication.c on msys2.

On Fri, Sep 4, 2020 at 9:07 PM Thomas Huth wrote: > On 04/09/2020 00.06, Yonggang Luo wrote: > > Signed-off-by: Yonggang Luo > > --- > > tests/test-replication.c | 17 + > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > diff --git a/tests/test-replication.c

Re: [RFC PATCH 00/12] hw: Forbid DMA write accesses to MMIO regions

Philippe Mathieu-Daudé 于2020年9月3日周四 下午7:09写道： > > Hi, > > I'm not suppose to work on this but I couldn't sleep so kept > wondering about this problem the whole night and eventually > woke up to write this quickly, so comments are scarce, sorry. > > The first part is obvious anyway, simply pass

Re: [PATCH 1/2] hw/net/e1000e: Remove overwritten read handler for STATUS register

Philippe Mathieu-Daudé 于2020年9月4日周五 下午9:14写道： > > The STATUS register readop handler is initialized first with > the generic e1000e_mac_readreg() handler: > > 2861 #define e1000e_getreg(x)[x] = e1000e_mac_readreg > 2862 typedef uint32_t (*readops)(E1000ECore *, int); > 2863 static const

Re: [PATCH 2/2] hw/net/e1000e: Remove duplicated write handler for FLSWDATA register

Philippe Mathieu-Daudé 于2020年9月4日周五 下午9:14写道： > > The FLSWDATA register writeop handler is initialized twice: > > 3067 #define e1000e_putreg(x)[x] = e1000e_mac_writereg > 3068 typedef void (*writeops)(E1000ECore *, int, uint32_t); > 3069 static const writeops e1000e_macreg_writeops[] =

Re: [PATCH] configure: the error info not consistence with option.

On Fri, Sep 4, 2020 at 3:54 PM Paolo Bonzini wrote: > On 04/09/20 05:54, 罗勇刚(Yonggang Luo) wrote: > > > > test "$vhost_net_user" = "" && vhost_net_user=$vhost_user > > if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no"; > > then > > - error_exit

Re: [PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup

Pan Nengyuan 于2020年9月4日周五 下午3:23写道： > > s->connection_track_table forgot to destroy in colo_rewriter_cleanup. Fix it. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang > --- > net/filter-rewriter.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH 3/3] pci: Let pci_dma_write() propagate MemTxResult

Philippe Mathieu-Daudé 于2020年9月5日周六 上午12:26写道： > > pci_dma_rw() returns a MemTxResult type. > Do not discard it, return it to the caller. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang > --- > include/hw/pci/pci.h | 16 ++-- > 1 file changed, 14 insertions(+), 2

Re: [PATCH 2/3] pci: Let pci_dma_read() propagate MemTxResult

Philippe Mathieu-Daudé 于2020年9月5日周六 上午12:27写道： > > pci_dma_rw() returns a MemTxResult type. > Do not discard it, return it to the caller. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Li Qiang > --- > include/hw/pci/pci.h | 16 ++-- > 1 file changed, 14 insertions(+), 2

Re: hw/clock: What clock rate for virt machines?

On Fri, 04 Sep 2020 10:52:06 PDT (-0700), alistai...@gmail.com wrote: On Wed, Sep 2, 2020 at 12:48 PM Philippe Mathieu-Daudé wrote: On 9/2/20 8:18 PM, Peter Maydell wrote: > On Wed, 2 Sep 2020 at 18:03, Philippe Mathieu-Daudé wrote: >> >> On 9/2/20 6:49 PM, Peter Maydell wrote: >>> On Wed, 2

Re: [PATCH 1/3] pci: Let pci_dma_rw() propagate MemTxResult

Philippe Mathieu-Daudé 于2020年9月5日周六 上午12:26写道： > > dma_memory_rw() returns a MemTxResult type. > Do not discard it, return it to the caller. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/pci/pci.h | 18 -- > 1 file changed, 16 insertions(+), 2 deletions(-) > >

Re: [PATCH] configure: the error info not consistence with option.

On 04/09/20 05:54, 罗勇刚(Yonggang Luo) wrote: > >  test "$vhost_net_user" = "" && vhost_net_user=$vhost_user >  if test "$vhost_net_user" = "yes" && test "$vhost_user" = "no"; > then > -  error_exit "--enable-vhost-net-user requires --enable-vhost-user" > + 

Re: make -i check resut for msys2

On 04/09/2020 00.53, 罗勇刚(Yonggang Luo) wrote: > > > On Thu, Sep 3, 2020 at 10:33 PM Thomas Huth > wrote: > > On 03/09/2020 11.18, 罗勇刚(Yonggang Luo) wrote: > [...] > >   TEST    check-unit: tests/test-replication.exe > > ** > >

Re: [PATCH v4 1/3] spapr: move h_home_node_associativity to spapr_numa.c

On Thu, Sep 03, 2020 at 10:04:37PM -0300, Daniel Henrique Barboza wrote: > The implementation of this hypercall will be modified to use > spapr->numa_assoc_arrays input. Moving it to spapr_numa.c makes > make more sense. > > Signed-off-by: Daniel Henrique Barboza Applied to ppc-for-5.2 (though

[PATCH] target/i386/cpu: add return value verification and ignore Error objects

'err' is unnecessary in x86_cpu_class_check_missing_features(), we can change x86_cpu_expand_features() to return true on success, false on failure, then pass NULL here to remove it. Signed-off-by: Pan Nengyuan Suggested-by: Markus Armbruster --- target/i386/cpu.c | 15 +++ 1 file

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

On Thu, Sep 03, 2020 at 08:18:17PM -0400, Cleber Rosa wrote: > On Thu, Jul 09, 2020 at 01:28:27PM +0200, Andrea Bolognani wrote: > > On Thu, 2020-07-09 at 11:30 +0100, Daniel P. Berrangé wrote: > > > On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote: > > > > +- name: Installation of

Re: [PATCH] iotests: Remove 030 from the auto group

Am 04.09.2020 um 07:57 hat Thomas Huth geschrieben: > Test 030 is still occasionally failing in the CI ... so for the > time being, let's disable it in the "auto" group. We can add it > back once it got more stable. > > Signed-off-by: Thomas Huth I would rather just disable this one test

i440fx/acpi: don't hot-unplug cold plugged bridges when their hotplug switch is off

I have seen that when hotplug for pci bridge devices are turned off and devices are attached behind the bridge, I still see Windows trying to hot remove the pci bridge and failing. Today looking at the AML disassembly, I realized that we are addding slot enumeration and EJ0 methods even for the

[PULL 0/4] Ui 20200904 patches

The following changes since commit 67a7bfe560a1bba59efab085cb3430f45176d382: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-09= -03' into staging (2020-09-03 16:58:25 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/ui-20200904-pull

[PULL 1/4] ui/gtk-gl-area: Plug memleak in gd_gl_area_create_context()

From: Pan Nengyuan Receiving error in local variable err, and forgot to free it. This patch check the return value of 'gdk_window_create_gl_context' and 'gdk_gl_context_realize', then free err to fix it. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Message-Id:

[PATCH] target-i386: seperate MCIP & MCE_MASK error reason

Previously we can only get a simple string "Triple fault" in qemu log. Add detailed message for the two reasons to describe why qemu has to reset the guest. Signed-off-by: zhenwei pi --- target/i386/helper.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff

Re: [PATCH] meson: fix qxl module build

Hi, > if config_all_devices.has_key('CONFIG_QXL') >qxl_ss = ss.source_set() > - qxl_ss.add(when: 'CONFIG_QXL', if_true: files('qxl.c', 'qxl-logger.c', > 'qxl-render.c')) > + qxl_ss.add(files('qxl.c', 'qxl-logger.c', 'qxl-render.c')) >hw_display_modules += {'qxl': qxl_ss} > endif >

[PULL 2/4] vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string

From: Pan Nengyuan 'addr' is forgot to free in vnc_socket_ip_addr_string error path. Fix that. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Li Qiang Message-Id: <20200831134315.1221-11-pannengy...@huawei.com> Signed-off-by: Gerd Hoffmann --- ui/vnc-auth-sasl.c | 1 + 1

[PULL 3/4] ui: Add more mouse buttons to SPICE

From: Frediano Ziglio Add support for SIDE and EXTRA buttons. The constants for buttons in both SPICE and QEMU are defined as LEFT MIDDLE RIGHT UP DOWN SIDE EXTRA (same order). "button_mask" contains for each bit the state of a button. Qemu currently uses bits 0, 1, 2

[PULL 4/4] ui/gtk: Update refresh interval after widget is realized

From: Philippe Mathieu-Daudé Nikola reported on Windows when gd_vc_gfx_init() is called, the window is not yet realized, so we run gd_refresh_rate_millihz(NULL) which returns 0 milli-Hertz. When a Widget is realized, it fires a 'realized' event. We already have the gd_draw_event() handler

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

On 04/09/20 09:24, Markus Armbruster wrote: >> Ah, via the tools variable in configure. Nice maze. I've queued the patch. > Please don't. > > These programs are examples to help people understand how the ivhsmem > device works. They might even be useful for debugging. They are *not* > to be

Re: [PATCH v2] tests: Trying fixes test-replication.c on msys2.

On 04/09/20 00:06, Yonggang Luo wrote: > Signed-off-by: Yonggang Luo > --- > tests/test-replication.c | 17 + > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/tests/test-replication.c b/tests/test-replication.c > index 9ab3666a90..d0e06f8d77 100644 > ---

Re: [PATCH v5 06/20] tests/qapi/doc-good.json: Prepare for qapi-doc Sphinx extension

Peter Maydell writes: > doc-good.json tests doc comment parser corner cases. We're about to > largely replace it by a Sphinx extension, which will have different > corner cases. Tweak the test so it passes both with the old parser > and the Sphinx extension, by making it match the more

Re: [PATCH v4 2/3] spapr_numa: create a vcpu associativity helper

On Thu, Sep 03, 2020 at 10:04:38PM -0300, Daniel Henrique Barboza wrote: > The work to be done in h_home_node_associativity() intersects > with what is already done in spapr_numa_fixup_cpu_dt(). This > patch creates a new helper, spapr_numa_get_vcpu_assoc(), to > be used for both

[PATCH] net/filter-rewriter: destroy g_hash_table in colo_rewriter_cleanup

s->connection_track_table forgot to destroy in colo_rewriter_cleanup. Fix it. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan --- net/filter-rewriter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/filter-rewriter.c b/net/filter-rewriter.c index 1aaad101b6..9ff366d44f 100644

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

Paolo Bonzini writes: > On 03/09/20 17:49, Daniel P. Berrangé wrote: >> On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote: >>> On 03/09/20 17:35, Bruce Rogers wrote: Turn on the meson install flag for these executables Signed-off-by: Bruce Rogers ---

Re: [PATCH v6 1/8] monitor: simplify functions for getting a dup'd fdset entry

Daniel P. Berrangé writes: > Currently code has to call monitor_fdset_get_fd, then dup > the return fd, and then add the duplicate FD back into the > fdset. This dance is overly verbose for the caller and > introduces extra failure modes which can be avoided by > folding all the logic into

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

On Thu, Sep 03, 2020 at 08:11:39PM -0400, Cleber Rosa wrote: > On Thu, Jul 09, 2020 at 11:30:29AM +0100, Daniel P. Berrangé wrote: > > On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote: > > > This is a mapping of Peter's "remake-merge-builds" and > > > "pull-buildtest" scripts, gone

[PATCH v1] i440fx/acpi: don't hot-unplug cold plugged bridges when their hotplug switch is off

Cold plugged bridges should not be hot unpluggable, even when their hotplug property (acpi-pci-hotplug-with-bridge-support) is turned off. However, with the current implementaton, windows would try to hot-unplug a pci bridge when it's hotplug switch is off. This is regardless of whether there

Re: [PATCH 2/8] i8254: Rename PIT to ISA_PIT

On Thu, Sep 03, 2020 at 02:01:22PM -0400, Eduardo Habkost wrote: > Rename type checking function to be consistent with the type name > constant (TYPE_ISA_PIT) and type name string ("isa-pit"). > > Suggested-by: "Daniel P. Berrangé" > Signed-off-by: Eduardo Habkost > --- > Cc: "Michael S.

Re: [PATCH 3/8] i8259: Rename TYPE_I8259 to TYPE_ISA_I8259

On Thu, Sep 03, 2020 at 02:01:23PM -0400, Eduardo Habkost wrote: > This will make the type name constant consistent with QOM > type name string ("isa-i8259"). > > Suggested-by: Philippe Mathieu-Daudé > Suggested-by: "Daniel P. Berrangé" > Signed-off-by: Eduardo Habkost > --- > Changes v1 ->v2:

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

Paolo Bonzini writes: > On 04/09/20 09:24, Markus Armbruster wrote: >>> Ah, via the tools variable in configure. Nice maze. I've queued the patch. >> Please don't. >> >> These programs are examples to help people understand how the ivhsmem >> device works. They might even be useful for

Re: [PATCH v2 0/3] qcow2: Fix removal of list members from BDRVQcow2State.cluster_allocs

On 03.09.20 18:37, Alberto Garcia wrote: > Hi, > > here are the changes from v1: > > - Split changes into three different patches. > - Rewrite the documentation of qcow2_alloc_cluster_offset() [Max] > - Use peek_file_be in the test case to read the offset of the refcount > table [Max]. > -

Re: [PATCH v2 3/3] qcow2: Rewrite the documentation of qcow2_alloc_cluster_offset()

On Fri 04 Sep 2020 11:28:18 AM CEST, Max Reitz wrote: >> + * If any clusters or subclusters were allocated then @m contains a >> + * list with the information of all the affected regions. Note that >> + * this can happen regardless of whether this function succeeds or >> + * not. The caller is

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

On 7/9/20 4:46 AM, Cleber Rosa wrote: > This is a mapping of Peter's "remake-merge-builds" and > "pull-buildtest" scripts, gone through some updates, adding some build > option and removing others. > > The jobs currently cover the machines that the QEMU project owns, and that > are setup and

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

Hi, > > IOW, a RHEL-8 aarch64 host, running docker for ubuntu18.04, fedora30 > > etc. > > I've come across so many caveats and corner cases that having the > lowest common denominator proved to be the smart and sane thing to do. > For instance, building on the example you gave, running a RHEL

Re: [PATCH v4 3/3] spapr_numa: use spapr_numa_get_vcpu_assoc() in home_node hcall

On Thu, 3 Sep 2020 22:04:39 -0300 Daniel Henrique Barboza wrote: > The current implementation of h_home_node_associativity hard codes > the values of associativity domains of the vcpus. Let's make > it consider the values already initialized in spapr->numa_assoc_array, > via the

[PULL 01/46] qemu-iotests: move check-block back to Makefiles

check-block has its own test harness, unlike every other test. If we capture its output, as is in general nicer to do without V=1, there will be no sign of progress. So for lack of a better option just move the invocation of the test back to Makefile rules. As a side effect, this will also fix

[PULL 29/46] Makefile: remove dead variables and includes

Makefile.objs, the .d files and various CONFIG_* symbols are not used anymore by the Make side of the build; they are only processed by Meson. We can delete them. Signed-off-by: Paolo Bonzini --- Makefile | 20 Makefile.objs | 34

[PULL 13/46] meson: build qapi tests library

From: Marc-André Lureau - builds QAPI builtins types/visitor to fix a linking issue with unresolved symbols in the static library. - work around a meson limitation on generated file output directories. Signed-off-by: Marc-André Lureau Message-Id:

[PULL 21/46] meson: convert atomic*-bench

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20200828110734.1638685-11-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 5 - tests/meson.build | 10 ++ 2 files changed, 10 insertions(+), 5 deletions(-) diff

[PULL 18/46] meson: move keyutils dependency check

From: Marc-André Lureau Since there is not minimum version specified, and it's a test-only dependency, it's fair to depend on a version that ships with a .pc I suppose. Signed-off-by: Marc-André Lureau Message-Id: <20200828110734.1638685-8-marcandre.lur...@redhat.com> Signed-off-by: Paolo

Re: [PATCH 7/8] esp-pci: Rename PCI_ESP to AM53C974

On Thu, Sep 03, 2020 at 02:01:27PM -0400, Eduardo Habkost wrote: > Rename the type checking function to be consistent with the type > name constant (TYPE_AM53C974) and type name string ("am53c974"). > > Suggested-by: Philippe Mathieu-Daudé > Suggested-by: "Daniel P. Berrangé" > Signed-off-by:

Re: make -i check resut for msys2

Am 04.09.2020 um 08:03 hat Thomas Huth geschrieben: > On 04/09/2020 00.53, 罗勇刚(Yonggang Luo) wrote: > > > > > > On Thu, Sep 3, 2020 at 10:33 PM Thomas Huth > > wrote: > > > > On 03/09/2020 11.18, 罗勇刚(Yonggang Luo) wrote: > > [...] > > >   TEST    

Re: [PATCH 8/8] tusb6010: Rename TUSB to TUSB6010

On Thu, Sep 03, 2020 at 02:01:28PM -0400, Eduardo Habkost wrote: > Make type checking function name consistent with the TYPE_TUSB6010 > constant and QOM type name ("tusb6010"). > > Suggested-by: Philippe Mathieu-Daudé > Suggested-by: "Daniel P. Berrangé" > Signed-off-by: Eduardo Habkost > ---

Re: [PATCH v8 06/14] roms: Add virtual Boot ROM for NPCM7xx SoCs

On 8/25/20 2:17 AM, Havard Skinnemoen via wrote: > This is a minimalistic boot ROM written specifically for use with QEMU. > It supports loading the second-stage loader from SPI flash into RAM, SMP > boot, and not much else. > > Signed-off-by: Havard Skinnemoen > --- > Makefile

[PATCH v4 3/7] tests/qtest/vhost-user-test: prepare the tests for adding new dev class

For now only vhost-user-net device is supported by the test. Other vhost-user devices are not tested. As a first step make source code refactoring so new devices can reuse the same test routines. To make this provide a new vhost_user_ops structure with the methods to initialize device, its command

[PATCH v4 4/7] tests/qtest/libqos/virtio-blk: add support for vhost-user-blk

Add support for the vhost-user-blk-pci device. This node can be used by the vhost-user-blk tests. Tests for the vhost-user-blk device are added in the following patches. Signed-off-by: Dima Stepanov --- tests/qtest/libqos/virtio-blk.c | 14 ++ 1 file changed, 14 insertions(+) diff

[PATCH v4 0/7] vhost-user-blk: fix the migration issue and enhance qtests

v3 -> v4: - vhost: recheck dev state in the vhost_migration_log routine Reviewed-by: Raphael Norwitz - vhost: check queue state in the vhost_dev_set_log routine Use "continue" instead of "break" to handle non-initialized virtqueue case. v2 -> v3: - update commit message for the

[PATCH v4 1/7] vhost: recheck dev state in the vhost_migration_log routine

vhost-user devices can get a disconnect in the middle of the VHOST-USER handshake on the migration start. If disconnect event happened right before sending next VHOST-USER command, then the vhost_dev_set_log() call in the vhost_migration_log() function will return error. This error will lead to

[PATCH v4 2/7] vhost: check queue state in the vhost_dev_set_log routine

If the vhost-user-blk daemon provides only one virtqueue, but device was added with several queues, then QEMU will send more VHOST-USER command than expected by daemon side. The vhost_virtqueue_start() routine handles such case by checking the return value from the virtio_queue_get_desc_addr()

Re: [PATCH] iotests: Remove 030 from the auto group

Am 04.09.2020 um 12:14 hat Thomas Huth geschrieben: > On 04/09/2020 10.25, Kevin Wolf wrote: > > Am 04.09.2020 um 07:57 hat Thomas Huth geschrieben: > >> Test 030 is still occasionally failing in the CI ... so for the > >> time being, let's disable it in the "auto" group. We can add it > >> back

Re: [PATCH v3 6/7] configure,Makefile: Install colo resource-agent

On 8/4/20 12:47 PM, Lukas Straub wrote: > Optionally install the resouce-agent so it gets picked up by > pacemaker. This patch now needs to be rebased. > > Signed-off-by: Lukas Straub > --- > Makefile | 5 + > configure | 10 ++ > 2 files changed, 15 insertions(+) > > diff

[PULL 0/2] Vga 20200904 patches

The following changes since commit 67a7bfe560a1bba59efab085cb3430f45176d382: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-09-03' into staging (2020-09-03 16:58:25 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/vga-20200904-pull

[PULL 1/2] virtio-gpu: fix unmap the already mapped items

From: Li Zhijian we go here either (!(*iov)[i].iov_base) or (len != l), so we need to consider to unmap the 'i'th item as well when the 'i'th item is not nil CC: Li Qiang Signed-off-by: Li Zhijian Message-id: 20200827035855.24354-1-lizhij...@cn.fujitsu.com Signed-off-by: Gerd Hoffmann ---

[PULL 2/2] cirrus: handle wraparound in cirrus_invalidate_region

Code simply asserts that there is no wraparound instead of handling it properly. The assert() can be triggered by the guest (must be privilidged inside the guest though). Fix it. Buglink: https://bugs.launchpad.net/qemu/+bug/1880189 Cc: Li Qiang Reported-by: Philippe Mathieu-Daudé

[PULL 03/46] tests: handling signal on win32 properly

From: Yonggang Luo SIGABRT should use signal(SIGABRT, sigabrt_handler) to handle on win32 The error: E:/CI-Cor-Ready/xemu/qemu.org/tests/test-replication.c:559:33: error: invalid use of undefined type 'struct sigaction' 559 | sigact = (struct sigaction) { |

[PULL 00/46] Next round of Meson bugfixes and cleanups

The following changes since commit 67a7bfe560a1bba59efab085cb3430f45176d382: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-09-03' into staging (2020-09-03 16:58:25 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git

[PULL 04/46] mtest2make: split environment from test command

Pass the environment and test command in separate macro arguments, so that we will be able to insert a test driver in the next patch. Signed-off-by: Paolo Bonzini --- scripts/mtest2make.py | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[PULL 24/46] tests/migration/stress: remove unused exit_success

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20200828110734.1638685-15-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/migration/stress.c | 13 - 1 file changed, 13 deletions(-) diff --git a/tests/migration/stress.c

[PULL 11/46] ninjatool: use constant names for stamp files

Numbering files according to rules causes confusion, because CUSTOM_COMMAND3.stamp from a previous build might represent completely different targets after Makefile.ninja is regenerated. As a result, the new targets are not rebuilt and compilation fails. Use the targets to build a SHA1 hash; the

[PULL 17/46] meson: convert the unit tests

From: Thomas Huth Signed-off-by: Marc-André Lureau Message-Id: <20200828110734.1638685-7-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini Signed-off-by: Thomas Huth --- tests/Makefile.include | 254 + tests/meson.build | 175

[PULL 20/46] meson: convert vhost-user-bridge

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20200828110734.1638685-10-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 2 -- tests/meson.build | 9 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git

[PULL 19/46] meson: remove old socket_scm_helper rule

From: Marc-André Lureau It was covered already in commit d3ca592b3c10 ("meson: convert check-block") Signed-off-by: Marc-André Lureau Message-Id: <20200828110734.1638685-9-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 1 - 1 file changed, 1

[PULL 34/46] configure: move -ldl test to meson

Signed-off-by: Paolo Bonzini --- accel/tcg/meson.build | 2 +- configure | 1 - meson.build | 4 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/accel/tcg/meson.build b/accel/tcg/meson.build index 2a335b50f2..96a76ed23d 100644 --- a/accel/tcg/meson.build

[PULL 10/46] configure: include cross sdl2-config in meson cross file

Signed-off-by: Paolo Bonzini --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure b/configure index 644e2c923d..e65662a3b3 100755 --- a/configure +++ b/configure @@ -8156,6 +8156,9 @@ echo "ar = $(meson_quote $ar)" >> $cross echo "nm = $(meson_quote $nm)" >> $cross

Re: [PATCH] iotests: Remove 030 from the auto group

On 04.09.20 07:57, Thomas Huth wrote: > Test 030 is still occasionally failing in the CI ... so for the > time being, let's disable it in the "auto" group. We can add it > back once it got more stable. > > Signed-off-by: Thomas Huth > --- > I just saw the problem here: >

Re: [PATCH 1/8] i8254: Rename TYPE_I8254 to TYPE_ISA_PIT

On Thu, Sep 03, 2020 at 02:01:21PM -0400, Eduardo Habkost wrote: > This will make the type name constant consistent with the name of > the QOM type ("isa-pit"). > > Suggested-by: "Daniel P. Berrangé" > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * v1 subject was: "i8254: Rename

Re: [PATCH v5 08/20] scripts/qapi/parser.py: improve doc comment indent handling

Peter Maydell writes: > Make the handling of indentation in doc comments more sophisticated, > so that when we see a section like: > > Notes: some text >some more text > indented line 3 > > we save it for the doc-comment processing code as: > > some text > some more text >

Re: [PATCH] meson: fix qxl module build

On 04/09/20 10:12, Gerd Hoffmann wrote: > Hi, > >> if config_all_devices.has_key('CONFIG_QXL') >>qxl_ss = ss.source_set() >> - qxl_ss.add(when: 'CONFIG_QXL', if_true: files('qxl.c', 'qxl-logger.c', >> 'qxl-render.c')) >> + qxl_ss.add(files('qxl.c', 'qxl-logger.c', 'qxl-render.c')) >>

Re: [PATCH v8 02/14] hw/misc: Add NPCM7xx Clock Controller device model

On 8/25/20 2:16 AM, Havard Skinnemoen via wrote: > Enough functionality to boot the Linux kernel has been implemented. This > includes: > > - Correct power-on reset values so the various clock rates can be > accurately calculated. > - Clock enables stick around when written. > > In

[PATCH v4 7/7] tests/qtest/vhost-user-test: enable the reconnect tests

For now a QTEST_VHOST_USER_FIXME environment variable is used to separate reconnect tests for the vhost-user-net device. Looks like the reconnect functionality is pretty stable, so this separation is deprecated. Remove it and enable these tests for the default run. Signed-off-by: Dima Stepanov

[PATCH v4 5/7] tests/qtest/vhost-user-test: add support for the vhost-user-blk device

Add vhost_user_ops structure for the vhost-user-blk device class. Add the test_reconnect and test_migrate tests for this device. Signed-off-by: Dima Stepanov --- tests/qtest/vhost-user-test.c | 139 +- 1 file changed, 137 insertions(+), 2 deletions(-)

Re: [PATCH 15/77] xen/9pfs: yield when there isn't enough room on the ring

Additional candidate: 353b5a91cc 9p: null terminate fs driver options list Best regards, Christian Schoenebeck

[PULL 16/46] meson: convert qht-bench

From: Marc-André Lureau This is required by test-qht-par unit test. Signed-off-by: Marc-André Lureau Message-Id: <20200828110734.1638685-5-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 1 - tests/meson.build | 4 2 files changed, 4

[PULL 23/46] meson: convert the speed tests

Use meson benchmark() for them, adjust mtest2make.py for that. A new target "make bench" can be used to run all benchmarks. Signed-off-by: Marc-André Lureau Message-Id: <20200828110734.1638685-14-marcandre.lur...@redhat.com> [Rewrite mtest2make part. - Paolo] Signed-off-by: Paolo Bonzini ---

[PULL 15/46] meson: declare keyutils dependency

From: Marc-André Lureau Rename the variable to be more explicit. A further clean-up patch will move the actual to dependency check to meson entirely. Signed-off-by: Marc-André Lureau Message-Id: <20200828110734.1638685-4-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- configure

[PULL 14/46] meson: declare tasn1 dependency

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Message-Id: <20200828110734.1638685-3-marcandre.lur...@redhat.com> Signed-off-by: Paolo Bonzini --- meson.build | 5 + 1 file changed, 5 insertions(+) diff --git a/meson.build b/meson.build index f7b57315ef..b2d1a909b6 100644 ---

Re: [PATCH] iotests: Remove 030 from the auto group

On 04.09.20 10:31, Max Reitz wrote: > On 04.09.20 07:57, Thomas Huth wrote: >> Test 030 is still occasionally failing in the CI ... so for the >> time being, let's disable it in the "auto" group. We can add it >> back once it got more stable. >> >> Signed-off-by: Thomas Huth >> --- >> I just saw

Re: [PATCH v2 2/2] GitLab Gating CI: initial set of jobs, documentation and scripts

On Thu, 2020-09-03 at 17:12 -0400, Cleber Rosa wrote: > On Thu, Jul 09, 2020 at 10:55:07AM +0200, Erik Skultety wrote: > > On Wed, Jul 08, 2020 at 10:46:57PM -0400, Cleber Rosa wrote: > > > +.. note:: there are currently limitations to gitlab-runner itself when > > > + setting up a

Re: [PATCH 00/77] Patch Round-up for stable 5.0.1, freeze on 2020-09-10

On 9/3/20 10:58 PM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v5.0.1: > > https://github.com/mdroth/qemu/commits/stable-5.0-staging > > Patch freeze is 2020-09-10, and the release is planned for 2020-09-15: > >

Re: [PATCH v2 3/3] qcow2: Rewrite the documentation of qcow2_alloc_cluster_offset()

On 03.09.20 18:37, Alberto Garcia wrote: > The current text corresponds to an earlier, simpler version of this > function and it does not explain how it works now. > > Signed-off-by: Alberto Garcia > --- > block/qcow2-cluster.c | 24 ++-- > 1 file changed, 14 insertions(+),

Re: [PATCH v2 3/3] qcow2: Rewrite the documentation of qcow2_alloc_cluster_offset()

On 04.09.20 11:36, Alberto Garcia wrote: > On Fri 04 Sep 2020 11:28:18 AM CEST, Max Reitz wrote: >>> + * If any clusters or subclusters were allocated then @m contains a >>> + * list with the information of all the affected regions. Note that >>> + * this can happen regardless of whether this

Re: [PATCH v4 2/3] spapr_numa: create a vcpu associativity helper

On Thu, 3 Sep 2020 22:04:38 -0300 Daniel Henrique Barboza wrote: > The work to be done in h_home_node_associativity() intersects > with what is already done in spapr_numa_fixup_cpu_dt(). This > patch creates a new helper, spapr_numa_get_vcpu_assoc(), to > be used for both

Re: [PATCH v4 2/3] spapr_numa: create a vcpu associativity helper

On 9/4/20 7:02 AM, Greg Kurz wrote: On Thu, 3 Sep 2020 22:04:38 -0300 Daniel Henrique Barboza wrote: The work to be done in h_home_node_associativity() intersects with what is already done in spapr_numa_fixup_cpu_dt(). This patch creates a new helper, spapr_numa_get_vcpu_assoc(), to be

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

On Fri, Sep 04, 2020 at 11:37:58AM +0200, Philippe Mathieu-Daudé wrote: > On 9/4/20 9:24 AM, Markus Armbruster wrote: > > Paolo Bonzini writes: > > > >> On 03/09/20 17:49, Daniel P. Berrangé wrote: > >>> On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote: > On 03/09/20 17:35,

Re: [PATCH v3 0/7] colo: Introduce resource agent and test suite/CI

Hi Wainer, As Cleber is busy with Gating CI, can you review tests/acceptance/colo.py please? On 8/27/20 10:40 AM, Lukas Straub wrote: > On Tue, 18 Aug 2020 14:27:01 +0200 > Lukas Straub wrote: > >> On Tue, 4 Aug 2020 12:46:29 +0200 >> Lukas Straub wrote: >> >>> Hello Everyone, >>> So here is

[PULL 05/46] mtest2make: split working directory from test command

Pass the working directory and test command in separate macro arguments, so that we will be able to insert a test driver in the next patch. Signed-off-by: Paolo Bonzini --- scripts/mtest2make.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PULL 08/46] meson: remove b_lundef option

Meson automatically adds "-undefined dynamic_lookup" to shared_module build targets; b_lundef is only needed for executables. Therefore, we can remove this option. Signed-off-by: Paolo Bonzini --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build

[PULL 06/46] mtest2make: hide output of successful tests

The softfloat tests are quite noisy; before the Meson conversion they buffered the output in a file and emitted the output only if the test failed. Tweak mtest2make.py so that the courtesy is extended to all non-TAP tests. Signed-off-by: Paolo Bonzini --- scripts/mtest2make.py | 2 +-

[PULL 02/46] tests/Makefile: test-image-locking needs CONFIG_POSIX

From: Thomas Huth test-image-locking.c uses the qemu_lock_fd_test() function which is only available on Posix-like systems. Signed-off-by: Thomas Huth Message-Id: <20200803065803.20836-1-th...@redhat.com> Reviewed-by: John Snow Signed-off-by: Paolo Bonzini --- tests/Makefile.include | 2 ++

[PULL 09/46] configure: do not include absolute paths in -I and -L paths

On msys2, paths such as -L/e/path/to/qemu are not recognized by the linker. Fortunately we do not need absolute paths at all in a non-recursive build system. Tested-by: Mark Cave-Ayland Signed-off-by: Paolo Bonzini --- configure | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[PULL 07/46] mtest2make: unify tests that appear in multiple suites

Whenever a test appears in multiple suites, the rules generated by mtest2make are currently running it twice. Instead, after this patch we generate a phony target for each test and we have a generic "run-tests" target depend on all the tests that were chosen on the command line. Tests that

[PULL 12/46] meson: fix libqos linking

Add genh to the sources to avoid race conditions between QAPI file generation and libqos compilation. Make the name_suffix .fa for consistency with other link_whole static libraries and to work around a Meson issue where lots of linker flags are placed between -Wl,--start-group and

Re: [PATCH 6/8] esp-pci: Rename TYPE_AM53C974_DEVICE to TYPE_AM53C974

On Thu, Sep 03, 2020 at 02:01:26PM -0400, Eduardo Habkost wrote: > This will make the type name constant consistent with the QOM > type name string ("am53c974"). > > Suggested-by: Philippe Mathieu-Daudé > Suggested-by: "Daniel P. Berrangé" > Signed-off-by: Eduardo Habkost > --- > Changes v1 ->

Re: [PATCH 5/8] i8259: Rename KVM_PIC to KVM_I8259

On Thu, Sep 03, 2020 at 02:01:25PM -0400, Eduardo Habkost wrote: > Rename the type checking function to be consistent with the type > name constant (TYPE_KVM_I8259) and type name string > ("kvm-i8259"). > > Suggested-by: Philippe Mathieu-Daudé > Suggested-by: "Daniel P. Berrangé" >

  1   2   3   4   >