[PATCH] block/qcow2-cluster: Add missing "fallthrough" annotation

2020-09-08 Thread Thomas Huth
When compiling with -Werror=implicit-fallthrough, the compiler currently complains: ../../devel/qemu/block/qcow2-cluster.c: In function ‘cluster_needs_new_alloc’: ../../devel/qemu/block/qcow2-cluster.c:1320:12: error: this statement may fall through [-Werror=implicit-fallthrough=] if (l2

Re: [PULL 00/64] Block layer patches

2020-09-08 Thread Kevin Wolf
Am 07.09.2020 um 22:22 hat Peter Maydell geschrieben: > On Mon, 7 Sep 2020 at 12:09, Kevin Wolf wrote: > > > > The following changes since commit 7c37270b3fbe3d034ba80e488761461676e21eb4: > > > > Merge remote-tracking branch > > 'remotes/kraxel/tags/ui-20200904-pull-request' into staging (2020-

Re: [PULL 3/5] softmmu/cpus: Only set parallel_cpus for SMP

2020-09-08 Thread Claudio Fontana
On 9/7/20 6:49 PM, Philippe Mathieu-Daudé wrote: > On 9/7/20 6:30 PM, Claudio Fontana wrote: >> On 9/7/20 12:20 PM, Philippe Mathieu-Daudé wrote: >>> On 9/7/20 12:05 PM, Claudio Fontana wrote: Hi Richard, currently rebasing on top of this one, just a question, why is the patch n

[Bug 1852196] Re: update edk2 submodule & binaries to edk2-stable202005

2020-09-08 Thread Laszlo Ersek (Red Hat)
** Changed in: qemu Assignee: Philippe Mathieu-Daudé (philmd) => Laszlo Ersek (Red Hat) (lersek) ** Summary changed: - update edk2 submodule & binaries to edk2-stable202005 + update edk2 submodule & binaries to edk2-stable202008 -- You received this bug notification because you are a memb

[PATCH 01/10] Makefile: remove obsolete edk2 exception from "clean" rule

2020-09-08 Thread Laszlo Ersek
The file "BaseTools/Source/Python/UPT/Dll/sqlite3.dll" was removed in edk2 commit 26e2b295ec7a ("BaseTools:Remove unused BaseTools\Source\Python\UPT\Dll", 2019-05-08), part of edk2-stable201905, so skipping it in the outermost in-tree "clean" rule is unnecessary. Remove the obsolete pathname refer

[PATCH 10/10] tests: acpi: update "virt/SSDT.memhp" for edk2-stable202008

2020-09-08 Thread Laszlo Ersek
The NVDIMM_ACPI_MEM_ADDR dword in "virt/SSDT.memhp" needs an update due to the firmware now allocating NVDIMM_DSM_MEM_FILE at a lower address. > } > } > > -Name (MEMA, 0x43DD) > +Name (MEMA, 0x43D1) > } > Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Philippe Mat

[PATCH 07/10] roms/Makefile.edk2: enable new ARM/AARCH64 flags up to edk2-stable202008

2020-09-08 Thread Laszlo Ersek
Edk2 commit ffe048a0807b ("ArmVirtPkg: handle NETWORK_TLS_ENABLE in ArmVirtQemu*", 2019-06-28), part of edk2-stable201908, allows us to include the UEFI HTTPS Boot feature in the ArmVirtQemu fw platform (ARM and AARCH64). Edk2 commit range 4c0f6e349d32..0980779a9ddc, part of edk2-stable202005, add

[PATCH 02/10] roms/efirom, tests/uefi-test-tools: update edk2's own submodules first

2020-09-08 Thread Laszlo Ersek
In edk2 commit 06033f5abad3 ("BaseTools: Make brotli a submodule", 2020-04-16), part of edk2-stable202005, the Brotli compressor / decompressor source code that edk2 had flattened into BaseTools was replaced with a git submodule. This means we have to initialize edk2's own submodules before buildi

[PATCH 03/10] roms/Makefile.edk2: prepare for replacing TPM2*_ENABLE macros

2020-09-08 Thread Laszlo Ersek
Ekd2 commit 07952a962a40 ("OvmfPkg: rename TPM2 config prefix to TPM", 2020-03-04), part of edk2-stable202005, renamed OVMF's TPM2*_ENABLE build flags to TPM*_ENABLE. Going forward, the TPM*_ENABLE flags would activate both TPM1.2 and TPM2.0 support. In order to build OVMF at edk2-stable202008 wit

[PATCH 08/10] pc-bios: refresh edk2 build artifacts for edk2-stable202008

2020-09-08 Thread Laszlo Ersek
Rebuild the pc-bios/edk2-*.fd.bz2 binaries, based on the edk2-stable202008 release. Cc: Philippe Mathieu-Daudé Ref: https://bugs.launchpad.net/qemu/+bug/1852196 Signed-off-by: Laszlo Ersek --- pc-bios/edk2-aarch64-code.fd.bz2 | Bin 1178070 -> 1507722 bytes pc-bios/edk2-arm-code.fd.bz2

[PATCH 00/10] edk2: adopt the edk2-stable202008 release

2020-09-08 Thread Laszlo Ersek
Ref:https://bugs.launchpad.net/qemu/+bug/1852196 Repo: https://github.com/lersek/qemu.git Branch: edk2stable202008_lp_1852196 This series consumes the following upstream edk2 releases: https://github.com/tianocore/edk2/releases/tag/edk2-stable201908 https://github.com/tianocore/edk2/rel

[PATCH 04/10] tests: acpi: tolerate "virt/SSDT.memhp" mismatch temporarily

2020-09-08 Thread Laszlo Ersek
... to let "check-qtest-aarch64" pass until we refresh the AML after advancing the edk2 submodule to tag edk2-stable202008. Cc: "Michael S. Tsirkin" Cc: Igor Mammedov Cc: Philippe Mathieu-Daudé Ref: https://bugs.launchpad.net/qemu/+bug/1852196 Signed-off-by: Laszlo Ersek --- tests/qtest/bios-

[PATCH 06/10] roms/Makefile.edk2: complete replacing TPM2*_ENABLE macros

2020-09-08 Thread Laszlo Ersek
At tag "edk2-stable202008", the TPM2_ENABLE and TPM2_CONFIG_ENABLE macros are useless (for IA32 and X64). Their roles have been absorbed by TPM_ENABLE and TPM_CONFIG_ENABLE, respectively. Remove the old build flags. Cc: Philippe Mathieu-Daudé Ref: https://bugs.launchpad.net/qemu/+bug/1852196 Sign

[PATCH 09/10] pc-bios: update the README file with edk2-stable202008 information

2020-09-08 Thread Laszlo Ersek
Refresh the "pc-bios/README" file with edk2 and OpenSSL release info, matching the edk2-stable202008 firmware images added in the previous patch. Cc: Philippe Mathieu-Daudé Ref: https://bugs.launchpad.net/qemu/+bug/1852196 Signed-off-by: Laszlo Ersek --- pc-bios/README | 4 ++-- 1 file changed,

Re: [PATCH v5 09/10] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM

2020-09-08 Thread Igor Mammedov
On Mon, 7 Sep 2020 17:17:52 +0200 Laszlo Ersek wrote: > Hi Igor, > > On 09/07/20 13:23, Igor Mammedov wrote: > > In case firmware has negotiated CPU hotplug SMI feature, generate > > AML to describe SMI IO port region and send SMI to firmware > > on each CPU hotplug SCI in case new CPUs were hot

[PATCH] meson.build: tweak sdl-image error message

2020-09-08 Thread Sergei Trofimovich
Before the change missing SDL was reported as: ../meson.build:253:4: ERROR: Expected 1 arguments, got 2. After the error as: ../meson.build:258:4: ERROR: Problem encountered: sdl-image required, but SDL was not found CC: Paolo Bonzini CC: "Marc-André Lureau" CC: "Philippe Mathieu-Dau

[Bug 1852196] Re: update edk2 submodule & binaries to edk2-stable202008

2020-09-08 Thread Laszlo Ersek (Red Hat)
Posted * [qemu-devel] [PATCH 00/10] edk2: adopt the edk2-stable202008 release 20200908072939.30178-1-lersek@redhat.com">http://mid.mail-archive.com/20200908072939.30178-1-lersek@redhat.com -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to Q

Re: [PATCH v3 09/15] replay: implement replay-seek command

2020-09-08 Thread Pavel Dovgalyuk
On 07.09.2020 19:25, Alex Bennée wrote: Pavel Dovgalyuk writes: On 07.09.2020 17:59, Alex Bennée wrote: Pavel Dovgalyuk writes: On 07.09.2020 15:58, Alex Bennée wrote: Pavel Dovgalyuk writes: From: Pavel Dovgalyuk This patch adds hmp/qmp commands replay_seek/replay-seek that proce

Re: [PATCH] meson.build: tweak sdl-image error message

2020-09-08 Thread Philippe Mathieu-Daudé
On 9/8/20 9:40 AM, Sergei Trofimovich wrote: > Before the change missing SDL was reported as: > > ../meson.build:253:4: ERROR: Expected 1 arguments, got 2. > > After the error as: > > ../meson.build:258:4: ERROR: Problem encountered: sdl-image required, but > SDL was not found > > CC:

Re: [RFC PATCH v4 8/8] hw/arm/tosa: Make TYPE_TOSA_MISC_GPIO a plain QDev

2020-09-08 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > TYPE_TOSA_MISC_GPIO doesn't need to be a SysBus device, > make it a plain QDev. > > Signed-off-by: Philippe Mathieu-Daudé > --- > RFC because having to pass MachineState and call > object_property_add_child() simply makes things more > complex... but it seems to

Re: [PULL 3/5] softmmu/cpus: Only set parallel_cpus for SMP

2020-09-08 Thread Philippe Mathieu-Daudé
+Laurent On 9/8/20 9:09 AM, Claudio Fontana wrote: > On 9/7/20 6:49 PM, Philippe Mathieu-Daudé wrote: >> On 9/7/20 6:30 PM, Claudio Fontana wrote: >>> On 9/7/20 12:20 PM, Philippe Mathieu-Daudé wrote: On 9/7/20 12:05 PM, Claudio Fontana wrote: > Hi Richard, > > currently rebasing

[Bug 1852196] Re: update edk2 submodule & binaries to edk2-stable202008

2020-09-08 Thread Laszlo Ersek (Red Hat)
** Description changed: - edk2-stable202005 has been tagged: + Consume the following upstream edk2 releases: -   https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release- - Planning + https://github.com/tianocore/edk2/releases/tag/edk2-stable201908 + https://github.com/tianocore/edk

Re: [PATCH 06/10] roms/Makefile.edk2: complete replacing TPM2*_ENABLE macros

2020-09-08 Thread Philippe Mathieu-Daudé
On 9/8/20 9:29 AM, Laszlo Ersek wrote: > At tag "edk2-stable202008", the TPM2_ENABLE and TPM2_CONFIG_ENABLE macros > are useless (for IA32 and X64). Their roles have been absorbed by > TPM_ENABLE and TPM_CONFIG_ENABLE, respectively. Remove the old build > flags. > > Cc: Philippe Mathieu-Daudé > R

Re: [PATCH 03/10] roms/Makefile.edk2: prepare for replacing TPM2*_ENABLE macros

2020-09-08 Thread Philippe Mathieu-Daudé
On 9/8/20 9:29 AM, Laszlo Ersek wrote: > Ekd2 commit 07952a962a40 ("OvmfPkg: rename TPM2 config prefix to TPM", > 2020-03-04), part of edk2-stable202005, renamed OVMF's TPM2*_ENABLE build > flags to TPM*_ENABLE. Going forward, the TPM*_ENABLE flags would activate > both TPM1.2 and TPM2.0 support. >

Re: [PATCH] 9pfs: disable msize warning for synth driver

2020-09-08 Thread Greg Kurz
On Mon, 7 Sep 2020 14:27:19 +0200 Greg Kurz wrote: > On Mon, 07 Sep 2020 13:55:52 +0200 > Christian Schoenebeck wrote: > > > On Montag, 7. September 2020 11:57:58 CEST Greg Kurz wrote: > > > On Sun, 6 Sep 2020 18:50:32 +0200 > > > > > > Christian Schoenebeck wrote: > > > > Previous patch intr

Re: [PATCH 07/10] roms/Makefile.edk2: enable new ARM/AARCH64 flags up to edk2-stable202008

2020-09-08 Thread Philippe Mathieu-Daudé
On 9/8/20 9:29 AM, Laszlo Ersek wrote: > Edk2 commit ffe048a0807b ("ArmVirtPkg: handle NETWORK_TLS_ENABLE in > ArmVirtQemu*", 2019-06-28), part of edk2-stable201908, allows us to > include the UEFI HTTPS Boot feature in the ArmVirtQemu fw platform (ARM > and AARCH64). > > Edk2 commit range 4c0f6e3

[PATCH v2 01/12] update Linux headers with new vSPE macros

2020-09-08 Thread Haibo Xu
Signed-off-by: Haibo Xu --- linux-headers/asm-arm64/kvm.h | 4 linux-headers/linux/kvm.h | 1 + 2 files changed, 5 insertions(+) diff --git a/linux-headers/asm-arm64/kvm.h b/linux-headers/asm-arm64/kvm.h index 9e34f0f875..802319ee02 100644 --- a/linux-headers/asm-arm64/kvm.h +++ b/linux

[PATCH v2 05/12] target/arm/kvm: spe: Unify device attr operation helper

2020-09-08 Thread Haibo Xu
From: Andrew Jones Rename kvm_arm_pmu_set_attr() to kvm_arm_set_device_attr(), So both the vPMU and vSPE device can share the same API. Signed-off-by: Andrew Jones --- target/arm/kvm64.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/target/arm/kvm64.c b/target

[PATCH v2 07/12] hw/arm/virt: Move post cpu realize check into its own function

2020-09-08 Thread Haibo Xu
From: Andrew Jones We'll add more to this new function in coming patches so we also state the gic must be created and call it below create_gic(). No functional change intended. Signed-off-by: Andrew Jones --- hw/arm/virt.c | 38 ++ 1 file changed, 22 insert

[PATCH v2 09/12] hw/arm/virt: spe: Add SPE fdt binding for virt machine

2020-09-08 Thread Haibo Xu
Add a virtual SPE device for virt machine while using PPI 5 for SPE overflow interrupt number which has already selected in kvmtool. Signed-off-by: Haibo Xu --- hw/arm/virt-acpi-build.c| 3 +++ hw/arm/virt.c | 43 - include/hw/acpi/acpi-defs

[PATCH v2 00/12] target/arm: Add vSPE support to KVM guest

2020-09-08 Thread Haibo Xu
v2: - Rebased on Andrew's patches[3] - Added compat codes to enable vSPE only for the 5.2 and later machine types [Andrew] - Changed to use the ID register bit to identify the spe feature [Andrew/Richard] - Added the missing field in AcpiMadtGenericCpuInterface definition [Auge

[PATCH v2 10/12] target/arm/cpu: spe: Enable spe to work with host cpu

2020-09-08 Thread Haibo Xu
Turn on the spe cpu property by default if host cpu support it, i.e. we can now do '-cpu max|host' to add the vSPE, and '-cpu max|host,spe=off' to remove it. Signed-off-by: Haibo Xu --- target/arm/cpu.c | 3 +++ target/arm/cpu.h | 2 ++ target/arm/cpu64.c | 7 ++- target/arm/kvm64.c |

[PATCH v2 03/12] target/arm/cpu: spe: Add an option to turn on/off vSPE support

2020-09-08 Thread Haibo Xu
Adds a spe=[on/off] option to enable/disable vSPE support in guest vCPU. Signed-off-by: Haibo Xu --- target/arm/cpu.c | 6 ++ target/arm/cpu.h | 13 target/arm/cpu64.c | 52 ++ 3 files changed, 71 insertions(+) diff --git a/targe

[PATCH v2 12/12] target/arm: spe: Add corresponding doc and test.

2020-09-08 Thread Haibo Xu
Signed-off-by: Haibo Xu --- docs/system/arm/cpu-features.rst | 20 target/arm/monitor.c | 2 +- tests/qtest/arm-cpu-features.c | 9 + 3 files changed, 30 insertions(+), 1 deletion(-) diff --git a/docs/system/arm/cpu-features.rst b/docs/system/arm/cpu-

[PATCH v2 02/12] target/arm/kvm: spe: Add helper to detect SPE when using KVM

2020-09-08 Thread Haibo Xu
Reviewed-by: Richard Henderson Signed-off-by: Haibo Xu --- target/arm/kvm.c | 5 + target/arm/kvm_arm.h | 13 + 2 files changed, 18 insertions(+) diff --git a/target/arm/kvm.c b/target/arm/kvm.c index 8bb7318378..58f991e890 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm

[PATCH v2 08/12] hw/arm/virt: Move kvm pmu setup to virt_cpu_post_init

2020-09-08 Thread Haibo Xu
From: Andrew Jones Move the KVM PMU setup part of fdt_add_pmu_nodes() to virt_cpu_post_init(), which is a more appropriate location. Now fdt_add_pmu_nodes() is also named more appropriately, because it no longer does anything but fdt node creation. No functional change intended. Signed-off-by:

[PATCH v2 04/12] target/arm: spe: Only enable SPE from 5.2 compat machines.

2020-09-08 Thread Haibo Xu
Signed-off-by: Haibo Xu --- hw/arm/virt.c | 7 +++ include/hw/arm/virt.h | 1 + 2 files changed, 8 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index acf9bfbece..3f6d26c531 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1830,6 +1830,10 @@ static void machvirt_init(Mac

[PATCH v2 11/12] target/arm/kvm: spe: Enable userspace irqchip support.

2020-09-08 Thread Haibo Xu
Since the current kernel patches haven't enabled the userspace irqchip support, this patch is not verified yet! Signed-off-by: Haibo Xu --- linux-headers/linux/kvm.h | 1 + target/arm/kvm.c | 5 + 2 files changed, 6 insertions(+) diff --git a/linux-headers/linux/kvm.h b/linux-heade

Re: [PATCH 01/10] Makefile: remove obsolete edk2 exception from "clean" rule

2020-09-08 Thread Philippe Mathieu-Daudé
On 9/8/20 9:29 AM, Laszlo Ersek wrote: > The file "BaseTools/Source/Python/UPT/Dll/sqlite3.dll" was removed in edk2 > commit 26e2b295ec7a ("BaseTools:Remove unused > BaseTools\Source\Python\UPT\Dll", 2019-05-08), part of edk2-stable201905, > so skipping it in the outermost in-tree "clean" rule is u

[PATCH v2 06/12] target/arm/kvm: spe: Add device init and set_irq operations

2020-09-08 Thread Haibo Xu
Signed-off-by: Haibo Xu --- target/arm/kvm64.c | 33 + target/arm/kvm_arm.h | 5 + 2 files changed, 38 insertions(+) diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index 8ffd31ffdf..5a2032fc9e 100644 --- a/target/arm/kvm64.c +++ b/target/arm/kvm64.c @

Re: [PATCH 05/10] roms/edk2: update submodule from edk2-stable201905 to edk2-stable202008

2020-09-08 Thread Philippe Mathieu-Daudé
Hi Laszlo, On 9/8/20 9:29 AM, Laszlo Ersek wrote: > Update the edk2 submodule from release edk2-stable201905 to > edk2-stable202008. The release notes can be read at [...] > > Cc: Philippe Mathieu-Daudé > Ref: https://bugs.launchpad.net/qemu/+bug/1852196 > Signed-off-by: Laszlo Ersek > --- > r

Re: [PATCH] meson.build: tweak sdl-image error message

2020-09-08 Thread Paolo Bonzini
Cc: qemu-triv...@nongnu.org Il mar 8 set 2020, 09:50 Sergei Trofimovich ha scritto: > Before the change missing SDL was reported as: > > ../meson.build:253:4: ERROR: Expected 1 arguments, got 2. > > After the error as: > > ../meson.build:258:4: ERROR: Problem encountered: sdl-image requi

Re: [PATCH 10/10] tests: acpi: update "virt/SSDT.memhp" for edk2-stable202008

2020-09-08 Thread Philippe Mathieu-Daudé
On 9/8/20 9:29 AM, Laszlo Ersek wrote: > The NVDIMM_ACPI_MEM_ADDR dword in "virt/SSDT.memhp" needs an update due to > the firmware now allocating NVDIMM_DSM_MEM_FILE at a lower address. > >> } >> } >> >> -Name (MEMA, 0x43DD) >> +Name (MEMA, 0x43D1) >> } >> What abou

[Bug 1894804] [NEW] Second DEVICE_DELETED event missing during virtio-blk disk device detach

2020-09-08 Thread Lee Yarwood
Public bug reported: We are in the process of moving OpenStack CI across to use 20.04 Focal as the underlying OS and encountering the following issue in any test attempting to detach disk devices from running QEMU instances. We can see a single DEVICE_DELETED event raised to libvirtd for the /mac

Re: [PATCH 00/29] block/export: Add infrastructure and QAPI for block exports

2020-09-08 Thread Markus Armbruster
Doesn't apply for me. Got something I could pull?

Re: [PATCH] MAINTAINERS: add Stefan Hajnoczi as block/nvme.c maintainer

2020-09-08 Thread Fam Zheng
On 2020-09-07 12:16, Stefan Hajnoczi wrote: > Development of the userspace NVMe block driver picked up again recently. > After talking with Fam I am stepping up as block/nvme.c maintainer. > Patches will be merged through my 'block' tree. > > Cc: Kevin Wolf > Cc: Klaus Jensen > Cc: Fam Zheng >

Re: [PATCH] vhost-user: add separate memslot counter for vhost-user

2020-09-08 Thread Michael S. Tsirkin
+ Cc: Igor Mammedov + Cc: Marc-André Lureau who worked on this in the past. On Tue, Sep 08, 2020 at 02:11:41PM +0800, Jiajun Chen wrote: > Used_memslots is equal to dev->mem->nregions now, it is true for > vhost kernel, but not for vhost user, which uses the memory regions > that h

Re: [PATCH] block/qcow2-cluster: Add missing "fallthrough" annotation

2020-09-08 Thread Philippe Mathieu-Daudé
Hi Thomas, On 9/8/20 9:00 AM, Thomas Huth wrote: > When compiling with -Werror=implicit-fallthrough, the compiler currently > complains: Do you know what is missing to add this in configure::warn_flags? > > ../../devel/qemu/block/qcow2-cluster.c: In function ‘cluster_needs_new_alloc’: > ../../d

[Bug 1894804] Re: Second DEVICE_DELETED event missing during virtio-blk disk device detach

2020-09-08 Thread Kashyap Chamarthy
Just to expand a little more on the "second DEVICE_DELETED" event: Apparently this is an "oddity" of VirtIO devices where we see _two_ DEVICE_DELETED events upon hot-unplugging a device. So, ideally, we should see the following two events, but we're only seeing the first one: (1) "event": "DEVIC

Re: [PATCH v4 1/5] block: add bitmap-populate job

2020-09-08 Thread Markus Armbruster
Eric Blake writes: > From: John Snow > > This job copies the allocation map into a bitmap. It's a job because > there's no guarantee that allocation interrogation will be quick (or > won't hang), so it cannot be retrofitted into block-dirty-bitmap-merge. > > It was designed with different possib

Re: [PATCH v2] virtio-mem: detach the element from the virtqueue when error occurs

2020-09-08 Thread David Hildenbrand
On 07.09.20 03:36, Li Qiang wrote: > Ping! > Michael usually picks up patches and I only ack them. I guess he's busy, because I acked already ~3 weeks ago https://lkml.kernel.org/r/254210bc-9e7e-407d-3151-104944930...@redhat.com -- Thanks, David / dhildenb

Re: [PATCH 04/10] tests: acpi: tolerate "virt/SSDT.memhp" mismatch temporarily

2020-09-08 Thread Igor Mammedov
On Tue, 8 Sep 2020 09:29:33 +0200 Laszlo Ersek wrote: > ... to let "check-qtest-aarch64" pass until we refresh the AML after > advancing the edk2 submodule to tag edk2-stable202008. > > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: Philippe Mathieu-Daudé > Ref: https://bugs.launchpad.ne

Re: [PATCH v1] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine

2020-09-08 Thread David Hildenbrand
On 20.08.20 11:48, David Hildenbrand wrote: > Unfortunately, a typo sneeked in: we want to set > auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp. > > Cc: qemu-sta...@nongnu.org # v5.1 > Fixes: 195784a0cfad (numa: Auto-enable NUMA when any memory devices are > possible) > Re

Re: [PATCH 10/10] tests: acpi: update "virt/SSDT.memhp" for edk2-stable202008

2020-09-08 Thread Igor Mammedov
On Tue, 8 Sep 2020 09:29:39 +0200 Laszlo Ersek wrote: > The NVDIMM_ACPI_MEM_ADDR dword in "virt/SSDT.memhp" needs an update due to > the firmware now allocating NVDIMM_DSM_MEM_FILE at a lower address. > > > } > > } > > > > -Name (MEMA, 0x43DD) > > +Name (MEMA, 0x43D100

Re: [PULL 00/64] Block layer patches

2020-09-08 Thread Max Reitz
On 08.09.20 09:01, Kevin Wolf wrote: > Am 07.09.2020 um 22:22 hat Peter Maydell geschrieben: >> On Mon, 7 Sep 2020 at 12:09, Kevin Wolf wrote: >>> >>> The following changes since commit 7c37270b3fbe3d034ba80e488761461676e21eb4: >>> >>> Merge remote-tracking branch >>> 'remotes/kraxel/tags/ui-20

Re: [PATCH] 9pfs: disable msize warning for synth driver

2020-09-08 Thread Christian Schoenebeck
On Dienstag, 8. September 2020 10:10:36 CEST Greg Kurz wrote: > > > BTW, have you ever tried dealing with patchwork client's 'state' feature > > > for already transmited patches on the list (new, rejected, etc.)? > > > > Nope, never used patchwork's state at all and I've no idea on how it > > work

Re: [PATCH v3 09/15] replay: implement replay-seek command

2020-09-08 Thread Alex Bennée
Pavel Dovgalyuk writes: > On 07.09.2020 19:25, Alex Bennée wrote: >> >> Pavel Dovgalyuk writes: >> >>> On 07.09.2020 17:59, Alex Bennée wrote: Pavel Dovgalyuk writes: > On 07.09.2020 15:58, Alex Bennée wrote: >> >> Pavel Dovgalyuk writes: >> >>> From: Pav

Re: [PATCH v2] scripts/git.orderfile: Display meson files along with buildsys ones

2020-09-08 Thread Stefano Garzarella
On Mon, Sep 07, 2020 at 06:12:22PM +0200, Philippe Mathieu-Daudé wrote: > Since commit a56650518f5 ("configure: integrate Meson in the build > system") we replaced many Makefile by Meson files. Adapt the > git.orderfile script to display the new file at the same position. > > Signed-off-by: Phili

Re: [PATCH 1/5] migration: Rework migrate_send_rp_req_pages() function

2020-09-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > We duplicated the logic of maintaining the last_rb variable at both callers of > this function. Pass *rb pointer into the function so that we can avoid > duplicating the logic. Also, when we have the rb pointer, it's also easier to > remove the original 2nd

Re: [PATCH 3/5] migration: Pass incoming state into qemu_ufd_copy_ioctl()

2020-09-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > It'll be used in follow up patches to access more fields out of it. Meanwhile > fetch the userfaultfd inside the function. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > migration/postcopy-ram.c | 8 +--- > 1 file changed,

[PATCH 1/4] docs: lift block-core.json rST header into parents

2020-09-08 Thread Stefan Hajnoczi
block-core.json is included from several places. It has no way of knowing what header level (h1, h2, ...) is appropriate. Sphinx reports errors when it encounters an h2 header where it expects an h1 header. This issue prevents the next patch from generating documentation for qemu-storage-daemon QMP

Re: [PATCH] block/qcow2-cluster: Add missing "fallthrough" annotation

2020-09-08 Thread Thomas Huth
On 08/09/2020 10.43, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 9/8/20 9:00 AM, Thomas Huth wrote: >> When compiling with -Werror=implicit-fallthrough, the compiler currently >> complains: > > Do you know what is missing to add this in configure::warn_flags? Quite a bit, I think. I'm fixi

[PATCH 4/4] MAINTAINERS: add Kevin Wolf as storage daemon maintainer

2020-09-08 Thread Stefan Hajnoczi
The MAINTAINERS file was not updated when the storage daemon was merged. Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b233da2a73..3e8bfde1e3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2099,6 +2099,

[PATCH 0/4] docs: add qemu-storage-daemon documentation

2020-09-08 Thread Stefan Hajnoczi
Add documentation for the qemu-storage-daemon program and its QMP commands. The man page looks like this: QEMU-STORAGE-DAEMON(1) QEMUQEMU-STORAGE-DAEMON(1) NAME qemu-storage-daemon - QEMU storage daemon SYNOPSIS qemu-storage-daemon [options] DESCRIPTION

[PATCH 2/4] docs: generate qemu-storage-daemon-qmp-ref(7) man page

2020-09-08 Thread Stefan Hajnoczi
Although qemu-storage-daemon QMP commands are identical to QEMU QMP commands they are a subset. Generate a manual page of just the commands supported by qemu-storage-daemon so that users know exactly what is available in qemu-storage-daemon. Signed-off-by: Stefan Hajnoczi --- docs/interop/qemu-s

[PATCH 3/4] docs: add qemu-storage-daemon(1) man page

2020-09-08 Thread Stefan Hajnoczi
Document the qemu-storage-daemon tool. Most of the command-line options are identical to their QEMU counterparts. Perhaps Sphinx hxtool integration could be extended to extract documentation for individual command-line options so they can be shared. For now the qemu-storage-daemon simply refers to

Re: [PULL 13/14] virtio-ccw: fix virtio_set_ind_atomic

2020-09-08 Thread Halil Pasic
On Fri, 3 Jul 2020 12:06:49 +0200 Cornelia Huck wrote: > From: Halil Pasic > > The atomic_cmpxchg() loop is broken because we occasionally end up with > old and _old having different values (a legit compiler can generate code > that accessed *ind_addr again to pick up a value for _old instead

Re: [PATCH] 9pfs: disable msize warning for synth driver

2020-09-08 Thread Greg Kurz
On Tue, 08 Sep 2020 11:01:15 +0200 Christian Schoenebeck wrote: > On Dienstag, 8. September 2020 10:10:36 CEST Greg Kurz wrote: > > > > BTW, have you ever tried dealing with patchwork client's 'state' feature > > > > for already transmited patches on the list (new, rejected, etc.)? > > > > > > N

Re: [PATCH v5 09/10] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM

2020-09-08 Thread Laszlo Ersek
On 09/08/20 09:39, Igor Mammedov wrote: > On Mon, 7 Sep 2020 17:17:52 +0200 > Laszlo Ersek wrote: >>1 Method (CSCN, 0, Serialized) >>2 { >>3 Acquire (\_SB.PCI0.PRES.CPLK, 0x) >>4 Name (CNEW, Package (0xFF){}) >>5

Re: [PULL 14/14] s390x/pci: fix set_ind_atomic

2020-09-08 Thread Halil Pasic
On Fri, 3 Jul 2020 12:06:50 +0200 Cornelia Huck wrote: > From: Halil Pasic > > The atomic_cmpxchg() loop is broken because we occasionally end up with > old and _old having different values (a legit compiler can generate code > that accessed *ind_addr again to pick up a value for _old instead

[PATCH] kconfig: fix comment referring to old Makefiles

2020-09-08 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- Kconfig.host | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Kconfig.host b/Kconfig.host index a6d871c399..4af19bf70e 100644 --- a/Kconfig.host +++ b/Kconfig.host @@ -1,6 +1,6 @@ # These are "proxy" symbols used to pass config-host.mak val

[PULL v5 00/46] Next round of Meson bugfixes and cleanups

2020-09-08 Thread Paolo Bonzini
The following changes since commit e11bd71f89649da3cff439c030d2ccac0cc914e3: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-09-07' into staging (2020-09-07 16:51:00 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstrea

[Bug 1894804] Re: Second DEVICE_DELETED event missing during virtio-blk disk device detach

2020-09-08 Thread Kashyap Chamarthy
Attaching the QMP requests and responses filtered out from the giant libvirtd.log. This file was generated using: $> grep -Ei '(QEMU_MONITOR_SEND_MSG|QEMU_MONITOR_RECV_)' libvirtd.log |& tee QMP_requests_and_replies_from_libvirtd.log (And then I `gzip`ed it; compressed - 3.1MB; uncom

Re: [PATCH] 9pfs: disable msize warning for synth driver

2020-09-08 Thread Christian Schoenebeck
On Dienstag, 8. September 2020 11:01:15 CEST Christian Schoenebeck wrote: > The command to change a patch state is, e.g.: > > pwclient update -s Queued 11759645 > > When I do that I get this error: > > The update action requires authentication, but no username or password > is

Re: [PULL 0/3] Sirius/ipxe 20200908 patches

2020-09-08 Thread Laszlo Ersek
ilable in the Git repository at: > > git://git.kraxel.org/qemu tags/sirius/ipxe-20200908-pull-request > > for you to fetch changes up to 3e570a9ae9b966362596fd649f2cbcff0b2199c9: > > ipxe: update binaries (2020-09-08 08:08:30 +0200) > > ---

Re: [PATCH 2/5] migration: Introduce migrate_send_rp_message_req_pages()

2020-09-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > This is another layer wrapper for sending a page request to the source VM, Ah, it's not obvious why this is needed until 4/5 :-) Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Peter Xu > --- > migration/migration.c | 10 -- > migration/mi

Re: [PATCH v2] scripts/git.orderfile: Display meson files along with buildsys ones

2020-09-08 Thread Laszlo Ersek
On 09/07/20 18:12, Philippe Mathieu-Daudé wrote: > Since commit a56650518f5 ("configure: integrate Meson in the build > system") we replaced many Makefile by Meson files. Adapt the > git.orderfile script to display the new file at the same position. > > Signed-off-by: Philippe Mathieu-Daudé > ---

Re: [PATCH v1] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine

2020-09-08 Thread Michael S. Tsirkin
On Tue, Sep 08, 2020 at 10:56:53AM +0200, David Hildenbrand wrote: > On 20.08.20 11:48, David Hildenbrand wrote: > > Unfortunately, a typo sneeked in: we want to set > > auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp. > > > > Cc: qemu-sta...@nongnu.org # v5.1 > > Fixes: 195

Re: [PATCH] 9pfs: disable msize warning for synth driver

2020-09-08 Thread Christian Schoenebeck
On Dienstag, 8. September 2020 11:34:28 CEST Greg Kurz wrote: > On Tue, 08 Sep 2020 11:01:15 +0200 > > Christian Schoenebeck wrote: > > On Dienstag, 8. September 2020 10:10:36 CEST Greg Kurz wrote: > > > > > BTW, have you ever tried dealing with patchwork client's 'state' > > > > > feature > > >

Re: [RFC PATCH v4 8/8] hw/arm/tosa: Make TYPE_TOSA_MISC_GPIO a plain QDev

2020-09-08 Thread Peter Maydell
On Tue, 8 Sep 2020 at 08:54, Markus Armbruster wrote: > > Philippe Mathieu-Daudé writes: > > > TYPE_TOSA_MISC_GPIO doesn't need to be a SysBus device, > > make it a plain QDev. > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > RFC because having to pass MachineState and call > > object_p

RE: [PATCH v4 1/7] usb/hcd-xhci: Make dma read/writes hooks pci free

2020-09-08 Thread Sai Pavan Boddu
Hi Philippe, > -Original Message- > From: Philippe Mathieu-Daudé > Sent: Tuesday, September 1, 2020 10:05 PM > To: Sai Pavan Boddu ; Peter Maydell > ; Markus Armbruster ; > 'Marc-André Lureau' ; Paolo Bonzini > ; Gerd Hoffmann ; Edgar > Iglesias ; Francisco Eduardo Iglesias > > Cc: qemu-

Re: [PATCH] kconfig: fix comment referring to old Makefiles

2020-09-08 Thread Philippe Mathieu-Daudé
On 9/8/20 11:42 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > Kconfig.host | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Kconfig.host b/Kconfig.host > index a6d871c399..4af19bf70e 100644 > --- a/Kconfig.host > +++ b/Kconfig.host > @@ -1,6 +1,6 @@

[Bug 1894818] [NEW] COLO's guest VNC client hang after failover

2020-09-08 Thread Derek Su
Public bug reported: Hello, After setting up COLO's primary and secondary VMs, I installed the vncserver and xrdp (apt install tightvncserver xrdp) inside the VM. I access the VM from another PC via VNC/RDP client, and everything is OK. Then, kill the primary VM and issue the failover commands.

[Bug 1894804] Re: Second DEVICE_DELETED event missing during virtio-blk disk device detach

2020-09-08 Thread Daniel Berrange
Note that there are many VMs running, so it is important to isolate logs for just one of them, by matching on mon=0x. For example considering this $ grep 0x7f021c0b9c70 libvirtd.log | grep -E 'QEMU_MONITOR_(RECV_REPLY|RECV_EVENT|SEND_MSG)' We can see the "device_del" request: 2020-09-

[Bug 1894818] Re: COLO's guest VNC client hang after failover

2020-09-08 Thread Derek Su
** Description changed: Hello, After setting up COLO's primary and secondary VMs, I installed the vncserver and xrdp (apt install tightvncserver xrdp) inside the VM. I access the VM from another PC via VNC/RDP client, and everything is OK. Then, kill the primary VM and issue the f

Re: [PATCH v4 1/7] usb/hcd-xhci: Make dma read/writes hooks pci free

2020-09-08 Thread Philippe Mathieu-Daudé
>> On 8/28/20 9:19 PM, Sai Pavan Boddu wrote: >>> This patch starts making the hcd-xhci.c pci free, as part of this >>> restructuring dma read/writes are handled without passing pci object. >>> >>> Signed-off-by: Sai Pavan Boddu >>> --- >>> hw/usb/hcd-xhci.c | 24 +++- hw/usb/

Re: [PATCH v4 1/7] usb/hcd-xhci: Make dma read/writes hooks pci free

2020-09-08 Thread Philippe Mathieu-Daudé
On 9/8/20 12:30 PM, Philippe Mathieu-Daudé wrote: >>> On 8/28/20 9:19 PM, Sai Pavan Boddu wrote: This patch starts making the hcd-xhci.c pci free, as part of this restructuring dma read/writes are handled without passing pci object. Signed-off-by: Sai Pavan Boddu ---

[Bug 1894818] Re: COLO's guest VNC client hang after failover

2020-09-08 Thread Derek Su
** Description changed: Hello, After setting up COLO's primary and secondary VMs, I installed the vncserver and xrdp (apt install tightvncserver xrdp) inside the VM. I access the VM from another PC via VNC/RDP client, and everything is OK. Then, kill the primary VM and issue the f

Re: [PATCH v2 02/12] target/arm/kvm: spe: Add helper to detect SPE when using KVM

2020-09-08 Thread Andrew Jones
On Tue, Sep 08, 2020 at 08:13:20AM +, Haibo Xu wrote: > Reviewed-by: Richard Henderson > Signed-off-by: Haibo Xu > --- > target/arm/kvm.c | 5 + > target/arm/kvm_arm.h | 13 + > 2 files changed, 18 insertions(+) > > diff --git a/target/arm/kvm.c b/target/arm/kvm.c > ind

test-logging.c are failling because when removing those logging files, the longging file handlers are not closed

2020-09-08 Thread Yonggang Luo
I found qemu_log_close use call_rcu with qemu_logfile_free to closing log files. What I need to do to wait those logging files closed? I tried to using synchronize_rcu but have no effection void qemu_log_close(void) { QemuLogFile *logfile; qemu_mutex_lock(&qemu_logfile_mutex); log

Re: [PATCH v2 03/12] target/arm/cpu: spe: Add an option to turn on/off vSPE support

2020-09-08 Thread Andrew Jones
On Tue, Sep 08, 2020 at 08:13:21AM +, Haibo Xu wrote: > Adds a spe=[on/off] option to enable/disable vSPE support in > guest vCPU. > > Signed-off-by: Haibo Xu > --- > target/arm/cpu.c | 6 ++ > target/arm/cpu.h | 13 > target/arm/cpu64.c | 52 +++

Re: [PATCH v2 04/12] target/arm: spe: Only enable SPE from 5.2 compat machines.

2020-09-08 Thread Andrew Jones
On Tue, Sep 08, 2020 at 08:13:22AM +, Haibo Xu wrote: > Signed-off-by: Haibo Xu > --- > hw/arm/virt.c | 7 +++ > include/hw/arm/virt.h | 1 + > 2 files changed, 8 insertions(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index acf9bfbece..3f6d26c531 100644 > --- a/hw/arm/vir

[PATCH] tests/socket-helpers: Only fail socket protocol check if it is really necessary

2020-09-08 Thread Thomas Huth
The tests/test-char test is currently always failing on my system since socket_can_bind_connect("::1", PF_INET6) fails with EINVAL and thus socket_check_protocol_support() is returning -1 for an error. But IPv4 is working fine. The logic in socket_check_protocol_support() seems to be wrong here, if

Fwd: test-logging.c are failling because when removing those logging files, the longging file handlers are not closed

2020-09-08 Thread Yonggang Luo
This is the errors: ./tests/test-logging.exe # random seed: R02S3184056dae59ebe73ccdba81f5807d40 1..4 # Start of logging tests ok 1 /logging/parse_range ok 2 /logging/parse_path ok 3 /logging/logfile_write_path ok 4 /logging/logfile_lock_path # End of logging tests ** ERROR:../tests/test-logging.

Re: [PATCH v3 09/15] replay: implement replay-seek command

2020-09-08 Thread Pavel Dovgalyuk
On 07.09.2020 19:25, Alex Bennée wrote: Pavel Dovgalyuk writes: On 07.09.2020 17:59, Alex Bennée wrote: Pavel Dovgalyuk writes: On 07.09.2020 15:58, Alex Bennée wrote: Pavel Dovgalyuk writes: From: Pavel Dovgalyuk This patch adds hmp/qmp commands replay_seek/replay-seek that proce

Re: [PATCH v2 05/12] target/arm/kvm: spe: Unify device attr operation helper

2020-09-08 Thread Andrew Jones
On Tue, Sep 08, 2020 at 08:13:23AM +, Haibo Xu wrote: > From: Andrew Jones > > Rename kvm_arm_pmu_set_attr() to kvm_arm_set_device_attr(), > So both the vPMU and vSPE device can share the same API. > > Signed-off-by: Andrew Jones Looks like a faithful port of what I posted as a hunk of ano

Re: [PATCH v3 09/15] replay: implement replay-seek command

2020-09-08 Thread Pavel Dovgalyuk
On 08.09.2020 12:13, Alex Bennée wrote: Pavel Dovgalyuk writes: On 07.09.2020 19:25, Alex Bennée wrote: Pavel Dovgalyuk writes: On 07.09.2020 17:59, Alex Bennée wrote: Pavel Dovgalyuk writes: On 07.09.2020 15:58, Alex Bennée wrote: Pavel Dovgalyuk writes: From: Pavel Dovgalyuk

Re: [PATCH v2 06/12] target/arm/kvm: spe: Add device init and set_irq operations

2020-09-08 Thread Andrew Jones
On Tue, Sep 08, 2020 at 08:13:24AM +, Haibo Xu wrote: > Signed-off-by: Haibo Xu > --- > target/arm/kvm64.c | 33 + > target/arm/kvm_arm.h | 5 + > 2 files changed, 38 insertions(+) > Reviewed-by: Andrew Jones

Re: [PATCH 4/5] migration: Maintain postcopy faulted addresses

2020-09-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Maintain a list of faulted addresses on the destination host for which we're > waiting on. This is implemented using a GTree rather than a real list to make > sure even there're plenty of vCPUs/threads that are faulting, the lookup will > still be fast with

Re: [PATCH v5 09/10] x68: acpi: trigger SMI before sending hotplug Notify event to OSPM

2020-09-08 Thread Laszlo Ersek
On 09/08/20 11:35, Laszlo Ersek wrote: > On 09/08/20 09:39, Igor Mammedov wrote: >> On Mon, 7 Sep 2020 17:17:52 +0200 >> Laszlo Ersek wrote: > >>>1 Method (CSCN, 0, Serialized) >>>2 { >>>3 Acquire (\_SB.PCI0.PRES.CPLK, 0x) >>>4

  1   2   3   4   5   6   >