Re: [PATCH v3 02/16] fuzz: Add general virtual-device fuzzer

2020-09-21 Thread Alexander Bulekov
On 200921 0743, Philippe Mathieu-Daudé wrote: > Hi Alexander, > > On 9/21/20 4:24 AM, Alexander Bulekov wrote: > > This is a generic fuzzer designed to fuzz a virtual device's > > MemoryRegions, as long as they exist within the Memory or Port IO (if it > > exists) AddressSpaces. The fuzzer's

[PATCH v4 0/2] Skip copy-on-write when allocating a zero cluster

2020-09-21 Thread Alberto Garcia
I had to rebase the series due to conflicting changes on master. There are no other differences. Berto v4: - Fix rebase conflicts after cb8503159a v3: https://lists.gnu.org/archive/html/qemu-block/2020-09/msg00912.html - Add a new patch to improve the reporting of BDRV_BLOCK_ZERO [Vladimir] -

[PATCH v4 1/2] qcow2: Report BDRV_BLOCK_ZERO more accurately in bdrv_co_block_status()

2020-09-21 Thread Alberto Garcia
If a BlockDriverState supports backing files but has none then any unallocated area reads back as zeroes. bdrv_co_block_status() is only reporting this is if want_zero is true, but this is an inexpensive test and there is no reason not to do it in all cases. Suggested-by: Vladimir

Re: [PATCH 1/2] libvhost-user: return early on virtqueue errors

2020-09-21 Thread Philippe Mathieu-Daudé
On 9/21/20 1:34 PM, Stefan Hajnoczi wrote: > vu_panic() is not guaranteed to exit the program. Return early when > errors are encountered. > > Note that libvhost-user does not have an "unmap" operation for mapped > descriptors. Therefore it is correct to return without explicit cleanup. > >

Re: [PATCH 2/2] libvhost-user: return on error in vu_log_queue_fill()

2020-09-21 Thread Philippe Mathieu-Daudé
On 9/21/20 1:34 PM, Stefan Hajnoczi wrote: > vu_panic() is not guaranteed to exit the program. Return early when > errors are encountered. > > Signed-off-by: Stefan Hajnoczi > --- > contrib/libvhost-user/libvhost-user.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PULL v3 00/15] virtio,pc,acpi: fixes, tests

2020-09-21 Thread Li Qiang
Michael S. Tsirkin 于2020年9月21日周一 下午8:31写道: > > On Mon, Sep 21, 2020 at 07:44:42PM +0800, Li Qiang wrote: > > Michael S. Tsirkin 于2020年9月21日周一 下午7:30写道: > > > > > > The following changes since commit > > > 053a4177817db307ec854356e95b5b350800a216: > > > > > > Merge remote-tracking branch > >

[PATCH REPOST] hw: virtio-pmem: detach the element fromt the virtqueue when error occurs

2020-09-21 Thread Li Qiang
If error occurs while processing the virtio request we should call 'virtqueue_detach_element' to detach the element from the virtqueue before free the elem. Fixes: 5f503cd9f3 ("virtio-pmem: add virtio device") Reviewed-by: Pankaj Gupta Signed-off-by: Li Qiang --- hw/virtio/virtio-pmem.c | 1 +

Re: [PATCH v3 0/5] Qemu SEV-ES guest support

2020-09-21 Thread Tom Lendacky
On 9/21/20 6:48 AM, Dr. David Alan Gilbert wrote: > * Tom Lendacky (thomas.lenda...@amd.com) wrote: >> On 9/18/20 5:00 AM, Dr. David Alan Gilbert wrote: >>> * Tom Lendacky (thomas.lenda...@amd.com) wrote: On 9/17/20 12:28 PM, Dr. David Alan Gilbert wrote: > * Tom Lendacky

Re: [RFC PATCH 3/6] hw/sd/sdcard: Do not use legal address '0' for INVALID_ADDRESS

2020-09-21 Thread Philippe Mathieu-Daudé
On 9/21/20 2:24 PM, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: >> Philippe Mathieu-Daudé writes: >> >>> +Paolo & Kevin. >>> >>> On 9/21/20 10:40 AM, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: > As it is legal to WRITE/ERASE the

Re: [RFC] Move to C11 Atomics

2020-09-21 Thread Paolo Bonzini
On 21/09/20 15:44, Stefan Hajnoczi wrote: > On Mon, Sep 21, 2020 at 01:15:30PM +0200, Paolo Bonzini wrote: >> On 21/09/20 12:41, Stefan Hajnoczi wrote: >>> The upshot is that all atomic variables in QEMU need to use C11 Atomic >>> atomic_* types. This is a big change! >> >> The main issue with

Re: [PATCH v3 1/5] sev/i386: Add initial support for SEV-ES

2020-09-21 Thread Tom Lendacky
On 9/21/20 1:45 AM, Dov Murik wrote: > On 16/09/2020 0:29, Tom Lendacky wrote: >> From: Tom Lendacky >> >> Provide initial support for SEV-ES. This includes creating a function to >> indicate the guest is an SEV-ES guest (which will return false until all >> support is in place), performing the

Re: [PULL v3 00/15] virtio,pc,acpi: fixes, tests

2020-09-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200921112913.555392-1-...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20200921112913.555392-1-...@redhat.com Subject: [PULL v3 00/15] virtio,pc,acpi: fixes, tests

Re: tools/virtiofs: Multi threading seems to hurt performance

2020-09-21 Thread Daniel P . Berrangé
On Mon, Sep 21, 2020 at 09:35:16AM -0400, Vivek Goyal wrote: > On Mon, Sep 21, 2020 at 09:50:19AM +0100, Dr. David Alan Gilbert wrote: > > * Vivek Goyal (vgo...@redhat.com) wrote: > > > Hi All, > > > > > > virtiofsd default thread pool size is 64. To me it feels that in most of > > > the cases

Re: Limiting per vCPU Usage

2020-09-21 Thread Daniel P . Berrangé
On Mon, Sep 21, 2020 at 03:47:56PM +0200, Peter Lieven wrote: > Am 21.09.20 um 10:29 schrieb Daniel P. Berrangé: > > On Sun, Sep 20, 2020 at 10:24:41PM +0200, Peter Lieven wrote: > > > Hi Qemu folks, > > > > > > > > > is there a BCP to limit just the maximum usage of a virtual (KVM) cpu? > > >

Re: Issue 25514 in oss-fuzz: qemu: Coverage build failure

2020-09-21 Thread Paolo Bonzini
On 21/09/20 15:38, Alexander Bulekov wrote: > Hi Paolo, > These are the builds with clang coverage enabled. > The normal fuzzing builds are succeeding now (log from this morning: > https://oss-fuzz-build-logs.storage.googleapis.com/log-a426424c-cae4-407a-ae7b-205a9ae59286.txt > ) > > I already

Re: Should we apply for GitLab's open source program?

2020-09-21 Thread Daniel P . Berrangé
On Fri, Sep 04, 2020 at 05:08:36PM +0100, Daniel P. Berrangé wrote: > On Fri, Sep 04, 2020 at 04:35:34PM +0100, Alex Bennée wrote: > > > > Hi, > > > > Given our growing reliance on GitLab and the recent announcement about > > free tier minutes: > > > >

[Bug 1896263] Re: The bios-tables-test test causes QEMU to crash (Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed) on AMD processors

2020-09-21 Thread Laurent Vivier
I've reproduced the problem with HEAD of master, qemu-4.2.0 and qemu-4.0.0. I think the problem comes from the the kernel. Host CPU: Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz Host kernel: 5.8.4-200.fc32.x86_64 -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [PATCH v2 17/20] backup: move to block-copy

2020-09-21 Thread Vladimir Sementsov-Ogievskiy
23.07.2020 12:47, Max Reitz wrote: On 01.06.20 20:11, Vladimir Sementsov-Ogievskiy wrote: This brings async request handling and block-status driven chunk sizes to backup out of the box, which improves backup performance. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

Re: Limiting per vCPU Usage

2020-09-21 Thread Peter Lieven
Am 21.09.20 um 10:29 schrieb Daniel P. Berrangé: On Sun, Sep 20, 2020 at 10:24:41PM +0200, Peter Lieven wrote: Hi Qemu folks, is there a BCP to limit just the maximum usage of a virtual (KVM) cpu? I know that there are many approaches, but as far as I know they all limit the complete qemu

Re: [SeaBIOS] Regression with latest SeaBIOS booting multi-disk root LVs?

2020-09-21 Thread Paul Menzel
Dear Stefan, Am 21.09.20 um 15:10 schrieb Stefan Reiter: since SeaBIOS 1.14.0 (QEMU 5.1) VMs with LVM root disks spanning more than one PV fail to boot, if only the first is set as bootable. I believe this is due to the changes in SeaBIOS only initializing drives marked as 'bootable' by

Re: [RFC] Move to C11 Atomics

2020-09-21 Thread Stefan Hajnoczi
On Mon, Sep 21, 2020 at 01:15:30PM +0200, Paolo Bonzini wrote: > On 21/09/20 12:41, Stefan Hajnoczi wrote: > > The upshot is that all atomic variables in QEMU need to use C11 Atomic > > atomic_* types. This is a big change! > > The main issue with this is that C11 atomic types do too much magic,

Re: Issue 25514 in oss-fuzz: qemu: Coverage build failure

2020-09-21 Thread Alexander Bulekov
On 200921 1410, Paolo Bonzini wrote: > On 21/09/20 12:10, ClusterFuzz-External via monorail wrote: > > > > Comment #2 on issue 25514 by ClusterFuzz-External: qemu: Coverage build > > failure > > https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25514#c2 > > > > Friendly reminder that the the

Re: tools/virtiofs: Multi threading seems to hurt performance

2020-09-21 Thread Vivek Goyal
On Mon, Sep 21, 2020 at 09:39:23AM +0100, Stefan Hajnoczi wrote: > On Fri, Sep 18, 2020 at 05:34:36PM -0400, Vivek Goyal wrote: > > And here are the comparision results. To me it seems that by default > > we should switch to 1 thread (Till we can figure out how to make > > multi thread performance

Re: tools/virtiofs: Multi threading seems to hurt performance

2020-09-21 Thread Vivek Goyal
On Mon, Sep 21, 2020 at 09:50:19AM +0100, Dr. David Alan Gilbert wrote: > * Vivek Goyal (vgo...@redhat.com) wrote: > > Hi All, > > > > virtiofsd default thread pool size is 64. To me it feels that in most of > > the cases thread pool size 1 performs better than thread pool size 64. > > > > I ran

Re: [External] Re: ping: [PATCH 0/3] add MEMORY_FAILURE event

2020-09-21 Thread zhenwei pi
On 9/21/20 8:09 PM, Paolo Bonzini wrote: On 21/09/20 04:22, zhenwei pi wrote: Hi, A patchset about handling 'MCE' might have been ignored, can anyone tell me whether the purpose is reasonable? https://patchwork.kernel.org/cover/11773795/ Yes, it's very useful. Just one thing,

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-21 Thread Paolo Bonzini
On 21/09/20 12:54, Alex Bennée wrote: > Something is breaking when switching to a branch with this on from > current master: > > Linking target qemu-hppa > /usr/bin/ld: libcommon.fa.p/disas_alpha.c.o: in function `print_insn_alpha': >

Re: [External] Re: [PATCH 2/3] iqapi/run-state.json: introduce memory failure event

2020-09-21 Thread zhenwei pi
On 9/21/20 8:48 PM, Peter Maydell wrote: On Mon, 14 Sep 2020 at 14:53, zhenwei pi wrote: Introduce 4 memory failure events for a guest. Then uplayer could know when/why/what happened to a guest during hitting a hardware memory failure. Signed-off-by: zhenwei pi --- +## +#

Regression with latest SeaBIOS booting multi-disk root LVs?

2020-09-21 Thread Stefan Reiter
Hi list, since SeaBIOS 1.14.0 (QEMU 5.1) VMs with LVM root disks spanning more than one PV fail to boot, if only the first is set as bootable. I believe this is due to the changes in SeaBIOS only initializing drives marked as 'bootable' by QEMU. One fix is to mark all disks containing root

[Bug 1895471] Re: compilation error with clang in util/async.c

2020-09-21 Thread Stefan Hajnoczi
Mailing list discussion about how to fix this: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg07392.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1895471 Title: compilation error

Re: [PATCH v2] s390x/tcg: Implement MONITOR CALL

2020-09-21 Thread Cornelia Huck
On Fri, 18 Sep 2020 10:51:22 +0200 David Hildenbrand wrote: > Recent upstream Linux uses the MONITOR CALL instruction for things like > BUG_ON() and WARN_ON(). We currently inject an operation exception when > we hit a MONITOR CALL instruction - which is wrong, as the instruction > is not glued

[PATCH v2 2/2] vhost-vdpa: add trace-events

2020-09-21 Thread Laurent Vivier
Add trace functionis in vhost-vdpa.c. All traces from this file can be enabled with '-trace vhost_vdpa*'. Acked-by: Stefan Hajnoczi Signed-off-by: Laurent Vivier --- hw/virtio/trace-events | 29 ++ hw/virtio/vhost-vdpa.c | 86 +++--- 2 files

[PATCH v2 0/2] vhost-vdpa: add trace functions in vhost-vdpa.c

2020-09-21 Thread Laurent Vivier
Add trace events functions in vdpa functions. Modify qemu_hexdump() to be able to dump the vdpa config in trace logs in hexadecimal form. v2: fix problems reported by checkpatch (TAB, missing 0x and 80+ line) added Stefan Acked-by Laurent Vivier (2): util/hexdump: introduce

[PATCH v2 1/2] util/hexdump: introduce qemu_hexdump_line()

2020-09-21 Thread Laurent Vivier
Dumping one line of hexadecimal/ASCII from a buffer is often needed. Move this part from qemu_hexdump() and use it Acked-by: Stefan Hajnoczi Signed-off-by: Laurent Vivier --- include/qemu-common.h | 8 +++ util/hexdump.c| 54 +++ 2 files

Re: [PATCH 2/2] qdev: Let BusRealize() return a boolean value to indicate error

2020-09-21 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 9/21/20 10:19 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Commit 9940b2cfbc0 introduced qdev_realize() and qbus_realize() >>> with the ability to return a boolean value if an error occured, >>> thus the caller does not need to check

Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces

2020-09-21 Thread Richard W.M. Jones
On Mon, Sep 21, 2020 at 02:54:15PM +0200, Peter Krempa wrote: > On Mon, Sep 21, 2020 at 13:45:14 +0100, Richard W.M. Jones wrote: > > Some general comments on using the patch: > > > > * For libguestfs I chose to add > > > > -compat deprecated-input=reject,deprecated-output=hide > > > > This

Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces

2020-09-21 Thread Peter Maydell
On Mon, 14 Sep 2020 at 09:55, Markus Armbruster wrote: > > New option -compat lets you configure what to do when deprecated > interfaces get used. This is intended for testing users of the > management interfaces. It is experimental. > > -compat deprecated-input= configures what to do when >

Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces

2020-09-21 Thread Peter Krempa
On Mon, Sep 21, 2020 at 13:45:14 +0100, Richard W.M. Jones wrote: > Some general comments on using the patch: > > * For libguestfs I chose to add > > -compat deprecated-input=reject,deprecated-output=hide > > This is only enabled in developer builds of libguestfs when we > are running

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-21 Thread Yonggang Luo
On Mon, Sep 21, 2020 at 7:06 PM Alex Bennée wrote: > > > Alex Bennée writes: > > > Richard Henderson writes: > > > >> There are better ways to do this, e.g. meson cmake subproject, > >> but that requires cmake 3.7 and some of our CI environments > >> only provide cmake 3.5. > >> > >> Nor can we

Re: [PATCH 2/3] iqapi/run-state.json: introduce memory failure event

2020-09-21 Thread Peter Maydell
On Mon, 14 Sep 2020 at 14:53, zhenwei pi wrote: > > Introduce 4 memory failure events for a guest. Then uplayer could > know when/why/what happened to a guest during hitting a hardware > memory failure. > > Signed-off-by: zhenwei pi > --- > +## > +# @MemoryFailureAction: > +# > +# Host memory

Re: [PATCH v5 0/8] Configurable policy for handling deprecated interfaces

2020-09-21 Thread Richard W.M. Jones
Some general comments on using the patch: * For libguestfs I chose to add -compat deprecated-input=reject,deprecated-output=hide This is only enabled in developer builds of libguestfs when we are running qemu directly (not via libvirt). The patch for this is attached. * What's the

Re: [PATCH 0/2] vhost-vdpa: add trace functions in vhost-vdpa.c

2020-09-21 Thread Laurent Vivier
On 21/09/2020 14:32, Michael S. Tsirkin wrote: > On Mon, Sep 21, 2020 at 09:41:36AM +0100, Stefan Hajnoczi wrote: >> On Sun, Sep 20, 2020 at 06:24:32PM +0200, Laurent Vivier wrote: >>> Add trace events functions in vdpa functions. >>> >>> Modify qemu_hexdump() to be able to dump the vdpa config

Re: [PATCH 2/2] microvm: add pcie support

2020-09-21 Thread Michael S. Tsirkin
On Mon, Sep 21, 2020 at 01:33:47PM +0200, Gerd Hoffmann wrote: > On Fri, Sep 18, 2020 at 08:36:14AM -0400, Michael S. Tsirkin wrote: > > On Fri, Sep 18, 2020 at 02:19:11PM +0200, Gerd Hoffmann wrote: > > > Uses the existing gpex device which is also used as pcie host bridge on > > > arm/aarch64.

Re: [PULL v3 00/15] virtio,pc,acpi: fixes, tests

2020-09-21 Thread Michael S. Tsirkin
On Mon, Sep 21, 2020 at 07:44:42PM +0800, Li Qiang wrote: > Michael S. Tsirkin 于2020年9月21日周一 下午7:30写道: > > > > The following changes since commit 053a4177817db307ec854356e95b5b350800a216: > > > > Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-20200918' > > into staging

Re: [PATCH] migration: Truncate state file in xen-save-devices-state

2020-09-21 Thread Dov Murik
On 21/09/2020 14:17, Dr. David Alan Gilbert wrote: * Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: When running the xen-save-devices-state QMP command, if the filename already exists it will be truncated before dumping the devices' state into it. Signed-off-by: Dov Murik --- OK, that

Re: [PATCH 0/2] vhost-vdpa: add trace functions in vhost-vdpa.c

2020-09-21 Thread Michael S. Tsirkin
On Mon, Sep 21, 2020 at 09:41:36AM +0100, Stefan Hajnoczi wrote: > On Sun, Sep 20, 2020 at 06:24:32PM +0200, Laurent Vivier wrote: > > Add trace events functions in vdpa functions. > > > > Modify qemu_hexdump() to be able to dump the vdpa config > > in trace logs in hexadecimal form. > > > >

Re: [PATCH v5 00/10] x86: fix cpu hotplug with secure boot

2020-09-21 Thread Michael S. Tsirkin
On Mon, Sep 21, 2020 at 01:46:01PM +0200, Igor Mammedov wrote: > On Mon, 7 Sep 2020 07:23:38 -0400 > Igor Mammedov wrote: > > > v5: > > - fix hotplug on Windows when there is more than 256 possible CPUs > > (Windows isn't able to handle VarPackage over 255 elements > > so process

[PATCH v5 3/4] vhost-user-vsock-pci: force virtio version 1

2020-09-21 Thread Stefano Garzarella
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety check that requires to set 'disable-legacy=on' on vhost-user-vsock-pci device: $ ./qemu-system-x86_64 ... \ -chardev socket,id=char0,reconnect=0,path=/tmp/vhost4.socket \ -device

[PATCH v5 4/4] vhost-vsock-ccw: force virtio version 1

2020-09-21 Thread Stefano Garzarella
virtio-vsock was introduced after the release of VIRTIO 1.0 specifications, so it should be 'modern-only'. This patch forces virtio version 1 as done for vhost-vsock-pci. To avoid migration issues, we force virtio version 1 only when legacy check is enabled in the new machine types (>= 5.1).

Re: [PATCH 0/2] vhost-vdpa: add trace functions in vhost-vdpa.c

2020-09-21 Thread Laurent Vivier
On 20/09/2020 20:03, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/20200920162434.868041-1-lviv...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id:

[PATCH v5 1/4] virtio: skip legacy support check on machine types less than 5.1

2020-09-21 Thread Stefano Garzarella
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a check that returns an error if legacy support is on, but the device does not support legacy. Unfortunately some devices were wrongly declared legacy capable even if they were not (e.g vhost-vsock). To avoid

[PATCH v5 2/4] vhost-vsock-pci: force virtio version 1

2020-09-21 Thread Stefano Garzarella
Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety check that requires to set 'disable-legacy=on' on vhost-vsock-pci device: $ ./qemu-system-x86_64 ... -device vhost-vsock-pci,guest-cid=5 qemu-system-x86_64: -device

[PATCH v5 0/4] vhost-vsock: force virtio version 1

2020-09-21 Thread Stefano Garzarella
v5: - Patch 2: added a phrase about transitional device in the commit message [Cornelia] - All patches reviewed by Cornelia v4: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg07353.html v3: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg06549.html v2:

Re: [PULL 0/2] Python queue, 2020-09-18

2020-09-21 Thread Peter Maydell
On Fri, 18 Sep 2020 at 19:04, Eduardo Habkost wrote: > > Leftovers from pre-5.1.0 days. > > The following changes since commit 053a4177817db307ec854356e95b5b350800a216: > > Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-20200918' > into staging (2020-09-18 16:34:26 +0100) > >

Re: [RFC PATCH 3/6] hw/sd/sdcard: Do not use legal address '0' for INVALID_ADDRESS

2020-09-21 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Philippe Mathieu-Daudé writes: > > > +Paolo & Kevin. > > > > On 9/21/20 10:40 AM, Markus Armbruster wrote: > >> Philippe Mathieu-Daudé writes: > >> > >>> As it is legal to WRITE/ERASE the address/block 0, > >>> change the value of this

Re: [RFC PATCH 3/6] hw/sd/sdcard: Do not use legal address '0' for INVALID_ADDRESS

2020-09-21 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > +Paolo & Kevin. > > On 9/21/20 10:40 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> As it is legal to WRITE/ERASE the address/block 0, >>> change the value of this definition to an illegal >>> address: UINT32_MAX. >>> >>> Signed-off-by:

Re: ping: [PATCH 0/3] add MEMORY_FAILURE event

2020-09-21 Thread Paolo Bonzini
On 21/09/20 04:22, zhenwei pi wrote: > Hi, > > A patchset about handling 'MCE' might have been ignored, can anyone tell > me whether the purpose is reasonable? > > https://patchwork.kernel.org/cover/11773795/ Yes, it's very useful. Just one thing, "guest-mce" can be reported for both AR and AO

Re: Issue 25514 in oss-fuzz: qemu: Coverage build failure

2020-09-21 Thread Paolo Bonzini
On 21/09/20 12:10, ClusterFuzz-External via monorail wrote: > > Comment #2 on issue 25514 by ClusterFuzz-External: qemu: Coverage build > failure > https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=25514#c2 > > Friendly reminder that the the build is still failing. > Please try to fix this

Re: [PATCH v5 1/8] qemu-options: New -compat to set policy for deprecated interfaces

2020-09-21 Thread Richard W.M. Jones
On Mon, Sep 14, 2020 at 10:08:50AM -0500, Eric Blake wrote: > On 9/14/20 3:47 AM, Markus Armbruster wrote: > >Policy is separate for input and output. > > > >Input policy can be "accept" (accept silently), or "reject" (reject > >the request with an error). > > > >Output policy can be "accept"

[PATCH 2/2] microvm: add usb support

2020-09-21 Thread Gerd Hoffmann
Wire up "usb=on" machine option. When enabled add a sysbus xhci controller with 8 ports. Declare it in the ACPI DSDT table so the guest OS finds it. Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 5 - hw/i386/acpi-microvm.c| 20 hw/i386/microvm.c

[PATCH 1/2] microvm: add irq table

2020-09-21 Thread Gerd Hoffmann
Add a comment with a table listing the IRQs, both legacy pc and microvm side-by-side. Signed-off-by: Gerd Hoffmann --- include/hw/i386/microvm.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/include/hw/i386/microvm.h b/include/hw/i386/microvm.h index

[Bug 1894804] Re: Second DEVICE_DELETED event missing during virtio-blk disk device detach

2020-09-21 Thread Christian Ehrhardt 
Hi, interesting bug report - thanks lee, Kashyap and Sean - as well as Danil for taking a look already. If this would always fail no unplugs would work ever which I knew can't be right as I test that. So we need to find what is different... @Openstack people - is that reliably triggering at

[PATCH 1/2] libvhost-user: return early on virtqueue errors

2020-09-21 Thread Stefan Hajnoczi
vu_panic() is not guaranteed to exit the program. Return early when errors are encountered. Note that libvhost-user does not have an "unmap" operation for mapped descriptors. Therefore it is correct to return without explicit cleanup. Signed-off-by: Stefan Hajnoczi ---

[PATCH 0/2] libvhost-user: return after vu_panic()

2020-09-21 Thread Stefan Hajnoczi
vu_panic() is not guaranteed to exit the program. Return errors instead. Most of the code already does this but I spotted some cases that weren't handled yet. Stefan Hajnoczi (2): libvhost-user: return early on virtqueue errors libvhost-user: return on error in vu_log_queue_fill()

[PATCH 0/2] microvm: add usb support

2020-09-21 Thread Gerd Hoffmann
This depends on the xhci sysfs patch series by Sai Pavan Boddu Gerd Hoffmann (2): microvm: add irq table microvm: add usb support include/hw/i386/microvm.h | 25 + hw/i386/acpi-microvm.c| 20 hw/i386/microvm.c | 12 3

Re: [PATCH v3 0/5] Qemu SEV-ES guest support

2020-09-21 Thread Dr. David Alan Gilbert
* Tom Lendacky (thomas.lenda...@amd.com) wrote: > On 9/18/20 5:00 AM, Dr. David Alan Gilbert wrote: > > * Tom Lendacky (thomas.lenda...@amd.com) wrote: > > > On 9/17/20 12:28 PM, Dr. David Alan Gilbert wrote: > > > > * Tom Lendacky (thomas.lenda...@amd.com) wrote: > > > > > From: Tom Lendacky > >

[PULL v3 13/15] cphp: remove deprecated cpu-add command(s)

2020-09-21 Thread Michael S. Tsirkin
From: Igor Mammedov These were deprecated since 4.0, remove both HMP and QMP variants. Users should use device_add command instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammedov Reviewed-by:

Re: [PULL v3 00/15] virtio,pc,acpi: fixes, tests

2020-09-21 Thread Li Qiang
Michael S. Tsirkin 于2020年9月21日周一 下午7:30写道: > > The following changes since commit 053a4177817db307ec854356e95b5b350800a216: > > Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-20200918' > into staging (2020-09-18 16:34:26 +0100) > > are available in the Git repository at: > >

Re: [PATCH 2/2] microvm: add pcie support

2020-09-21 Thread Gerd Hoffmann
On Fri, Sep 18, 2020 at 08:36:14AM -0400, Michael S. Tsirkin wrote: > On Fri, Sep 18, 2020 at 02:19:11PM +0200, Gerd Hoffmann wrote: > > Uses the existing gpex device which is also used as pcie host bridge on > > arm/aarch64. For now only a 32bit mmio window and no ioport support. > > > > It is

Re: [PATCH v5 00/10] x86: fix cpu hotplug with secure boot

2020-09-21 Thread Igor Mammedov
On Mon, 7 Sep 2020 07:23:38 -0400 Igor Mammedov wrote: > v5: > - fix hotplug on Windows when there is more than 256 possible CPUs > (Windows isn't able to handle VarPackage over 255 elements > so process CPUs in batches) > - fix off-by-one in package length (Laszlo) > - fix not

[PULL v3 12/15] tests/qtest/vhost-user-test: enable the reconnect tests

2020-09-21 Thread Michael S. Tsirkin
From: Dima Stepanov For now a QTEST_VHOST_USER_FIXME environment variable is used to separate reconnect tests for the vhost-user-net device. Looks like the reconnect functionality is pretty stable, so this separation is deprecated. Remove it and enable these tests for the default run.

Re: [Bug 1896263] [NEW] The bios-tables-test test causes QEMU to crash (Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed) on AMD processors

2020-09-21 Thread Stefan Hajnoczi
On Fri, Sep 18, 2020 at 6:18 PM Apteryx <1896...@bugs.launchpad.net> wrote: > Host CPU: AMD Ryzen 3900X I also hit this test failure. Host CPU: Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz Host kernel: Linux 5.8.6-201.fc32.x86_64 qemu-system-x86_64: error: failed to set MSR 0x4b564d02 to 0x0

[PULL v3 09/15] tests/qtest/libqos/virtio-blk: add support for vhost-user-blk

2020-09-21 Thread Michael S. Tsirkin
From: Dima Stepanov Add support for the vhost-user-blk-pci device. This node can be used by the vhost-user-blk tests. Tests for the vhost-user-blk device are added in the following patches. Signed-off-by: Dima Stepanov Message-Id:

[PATCH 2/2] libvhost-user: return on error in vu_log_queue_fill()

2020-09-21 Thread Stefan Hajnoczi
vu_panic() is not guaranteed to exit the program. Return early when errors are encountered. Signed-off-by: Stefan Hajnoczi --- contrib/libvhost-user/libvhost-user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c

[PULL v3 10/15] tests/qtest/vhost-user-test: add support for the vhost-user-blk device

2020-09-21 Thread Michael S. Tsirkin
From: Dima Stepanov Add vhost_user_ops structure for the vhost-user-blk device class. Add the test_reconnect and test_migrate tests for this device. Signed-off-by: Dima Stepanov Reviewed-by: Raphael Norwitz Message-Id: Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[PULL v3 08/15] tests/qtest/vhost-user-test: prepare the tests for adding new dev class

2020-09-21 Thread Michael S. Tsirkin
From: Dima Stepanov For now only vhost-user-net device is supported by the test. Other vhost-user devices are not tested. As a first step make source code refactoring so new devices can reuse the same test routines. To make this provide a new vhost_user_ops structure with the methods to

[PULL v3 04/15] virtio-mem: detach the element from the virtqueue when error occurs

2020-09-21 Thread Michael S. Tsirkin
From: Li Qiang If error occurs while processing the virtio request we should call 'virtqueue_detach_element' to detach the element from the virtqueue before free the elem. Signed-off-by: Li Qiang Message-Id: <20200816142245.17556-1-liq...@163.com> Fixes: 910b25766b ("virtio-mem:

[PULL v3 07/15] vhost: check queue state in the vhost_dev_set_log routine

2020-09-21 Thread Michael S. Tsirkin
From: Dima Stepanov If the vhost-user-blk daemon provides only one virtqueue, but device was added with several queues, then QEMU will send more VHOST-USER command than expected by daemon side. The vhost_virtqueue_start() routine handles such case by checking the return value from the

[PULL v3 11/15] tests/qtest/vhost-user-test: add migrate_reconnect test

2020-09-21 Thread Michael S. Tsirkin
From: Dima Stepanov Add new migrate_reconnect test for the vhost-user-blk device. Perform a disconnect after sending response for the VHOST_USER_SET_LOG_BASE command. Signed-off-by: Dima Stepanov Reviewed-by: Raphael Norwitz Message-Id:

[PULL v3 06/15] vhost: recheck dev state in the vhost_migration_log routine

2020-09-21 Thread Michael S. Tsirkin
From: Dima Stepanov vhost-user devices can get a disconnect in the middle of the VHOST-USER handshake on the migration start. If disconnect event happened right before sending next VHOST-USER command, then the vhost_dev_set_log() call in the vhost_migration_log() function will return error. This

[PULL v3 15/15] virtio-iommu-pci: force virtio version 1

2020-09-21 Thread Michael S. Tsirkin
From: Eric Auger Commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on") added a safety check that requires to set 'disable-legacy=on' on virtio-iommu-pci: qemu-system-aarch64: -device virtio-iommu-pci: device is modern-only, use disable-legacy=on virtio-iommu was

[PULL v3 02/15] vhost: switch to use IOTLB v2 format

2020-09-21 Thread Michael S. Tsirkin
From: Jason Wang This patch tries to switch to use new kernel IOTLB format V2. Previous version may have inconsistent ABI between 32bit and 64bit machines because of the hole after type field. Refer kernel commit ("429711aec282 vhost: switch to use new message format") for more information. To

[PULL v3 03/15] vhost-vdpa: batch updating IOTLB mappings

2020-09-21 Thread Michael S. Tsirkin
From: Jason Wang To speed up the memory mapping updating between vhost-vDPA and vDPA device driver, this patch passes the IOTLB batching flags via IOTLB API. Two new flags was introduced, VHOST_IOTLB_BATCH_BEGIN is a hint that a bathced IOTLB updating may be initiated from the userspace.

[PULL v3 05/15] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine

2020-09-21 Thread Michael S. Tsirkin
From: David Hildenbrand Unfortunately, a typo sneeked in: we want to set auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp. Cc: qemu-sta...@nongnu.org # v5.1 Fixes: 195784a0cfad (numa: Auto-enable NUMA when any memory devices are possible) Reported-by: Dr. David Alan

[PULL v3 14/15] virtio-iommu: Check gtrees are non null before destroying them

2020-09-21 Thread Michael S. Tsirkin
From: Eric Auger If realize fails, domains and endpoints trees may be NULL. On unrealize(), this produces assertions: "GLib: g_tree_destroy: assertion 'tree != NULL' failed" Check that the trees are non NULL before destroying them. Cc: qemu-sta...@nongnu.org Signed-off-by: Eric Auger

[PULL v3 00/15] virtio,pc,acpi: fixes, tests

2020-09-21 Thread Michael S. Tsirkin
The following changes since commit 053a4177817db307ec854356e95b5b350800a216: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-20200918' into staging (2020-09-18 16:34:26 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git

[PULL v3 01/15] linux headers: sync to 5.9-rc4

2020-09-21 Thread Michael S. Tsirkin
From: Jason Wang Update against Linux 5.9-rc4. Cc: Cornelia Huck Cc: Paolo Bonzini Signed-off-by: Jason Wang Message-Id: <20200907104903.31551-2-jasow...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/standard-headers/drm/drm_fourcc.h | 140

Re: [PATCH] migration: Truncate state file in xen-save-devices-state

2020-09-21 Thread Dr. David Alan Gilbert
* Dov Murik (dovmu...@linux.vnet.ibm.com) wrote: > When running the xen-save-devices-state QMP command, if the filename > already exists it will be truncated before dumping the devices' state > into it. > > Signed-off-by: Dov Murik > --- OK, that looks fine to me, so: Reviewed-by: Dr. David

Re: [RFC] Move to C11 Atomics

2020-09-21 Thread Paolo Bonzini
On 21/09/20 12:41, Stefan Hajnoczi wrote: > The upshot is that all atomic variables in QEMU need to use C11 Atomic > atomic_* types. This is a big change! The main issue with this is that C11 atomic types do too much magic, including defaulting to seq-cst operations for loads and stores. As

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

2020-09-21 Thread Fam Zheng
On 2020-09-19 10:22, Zhenyu Ye wrote: > On 2020/9/18 22:06, Fam Zheng wrote: > > > > I can see how blocking in a slow io_submit can cause trouble for main > > thread. I think one way to fix it (until it's made truly async in new > > kernels) is moving the io_submit call to thread pool, and

[PULL 1/1] hw/input/tsc2xxx: Reduce MouseTransformInfo structure exposure

2020-09-21 Thread Gerd Hoffmann
From: Philippe Mathieu-Daudé Commit a5d7eb6534a ("Add TSC2301 touchscreen & keypad controller") added the MouseTransformInfo declaration in "ui/console.h", however it is only used in "hw/input/tsc2xxx.h". Reduce the structure exposure by moving it to the single include where it is used. This

[PULL 0/1] Input 20200921 patches

2020-09-21 Thread Gerd Hoffmann
The following changes since commit 053a4177817db307ec854356e95b5b350800a216: Merge remote-tracking branch 'remotes/philmd-gitlab/tags/fw_cfg-20200918' i= nto staging (2020-09-18 16:34:26 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/input-20200921-pull

Re: [PATCH] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition

2020-09-21 Thread Alberto Garcia
On Mon 21 Sep 2020 01:01:45 PM CEST, Philippe Mathieu-Daudé wrote: > Use self-explicit NANOSECONDS_PER_SECOND definition instead > of magic value. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alberto Garcia Berto

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-21 Thread Alex Bennée
Alex Bennée writes: > Richard Henderson writes: > >> There are better ways to do this, e.g. meson cmake subproject, >> but that requires cmake 3.7 and some of our CI environments >> only provide cmake 3.5. >> >> Nor can we add a meson.build file to capstone/, because the git >> submodule

[PATCH] block/sheepdog: Replace magic val by NANOSECONDS_PER_SECOND definition

2020-09-21 Thread Philippe Mathieu-Daudé
Use self-explicit NANOSECONDS_PER_SECOND definition instead of magic value. Signed-off-by: Philippe Mathieu-Daudé --- block/sheepdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index cbbebc1aaf2..cbc655a1a05 100644 ---

Re: [PATCH v3 01/10] capstone: Convert Makefile bits to meson bits

2020-09-21 Thread Alex Bennée
Richard Henderson writes: > There are better ways to do this, e.g. meson cmake subproject, > but that requires cmake 3.7 and some of our CI environments > only provide cmake 3.5. > > Nor can we add a meson.build file to capstone/, because the git > submodule would then always report "untracked

[RFC] Move to C11 Atomics

2020-09-21 Thread Stefan Hajnoczi
This patch is incomplete but I am looking for feedback on the approach before fully implementing it (which will involve lots of changes). QEMU's atomic.h provides atomic operations and is intended to work with or without . Some of the atomic.h APIs are from C11 Atomics while others are

RE: [PATCH v7 3/7] usb/hcd-xhci: Split pci wrapper for xhci base model

2020-09-21 Thread Sai Pavan Boddu
Hi Gerd, Thanks, I will update this in V8. Regards, Sai Pavan > -Original Message- > From: Gerd Hoffmann > Sent: Thursday, September 17, 2020 5:14 PM > To: Sai Pavan Boddu > Cc: Peter Maydell ; Markus Armbruster > ; 'Marc-André Lureau' > ; Paolo Bonzini ; > Edgar Iglesias ; Francisco

Re: [RFC PATCH 3/6] hw/sd/sdcard: Do not use legal address '0' for INVALID_ADDRESS

2020-09-21 Thread Philippe Mathieu-Daudé
+Paolo & Kevin. On 9/21/20 10:40 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> As it is legal to WRITE/ERASE the address/block 0, >> change the value of this definition to an illegal >> address: UINT32_MAX. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> Cc: Dr.

RE: eMMC support

2020-09-21 Thread Sai Pavan Boddu
Hi Joel, > -Original Message- > From: Joel Stanley > Sent: Thursday, September 17, 2020 6:25 AM > To: Sai Pavan Boddu ; Cédric Le Goater > > Cc: Philippe Mathieu-Daudé ; Edgar Iglesias > ; qemu-devel@nongnu.org > Subject: Re: eMMC support > > On Wed, 16 Sep 2020 at 18:35, Sai Pavan

RE: eMMC support

2020-09-21 Thread Sai Pavan Boddu
Hi Cedric, > -Original Message- > From: Cédric Le Goater > Sent: Thursday, September 17, 2020 11:55 AM > To: Joel Stanley ; Sai Pavan Boddu > Cc: Philippe Mathieu-Daudé ; Edgar Iglesias > ; qemu-devel@nongnu.org > Subject: Re: eMMC support > > On 9/17/20 2:55 AM, Joel Stanley wrote: >

<    1   2   3   4   >