Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-30 Thread Michael S. Tsirkin
On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote: > On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin wrote: > > > > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote: > > > On Tue, Sep 29, 2020 at 4:45 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Sep 29, 2020 at

Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-09-30 Thread Mark Cave-Ayland
On 24/09/2020 16:00, Laurent Vivier wrote: > Le 24/09/2020 à 16:53, Philippe Mathieu-Daudé a écrit : >> On 9/16/20 4:50 AM, David Gibson wrote: >>> On Mon, Sep 14, 2020 at 12:24:25PM +0200, Philippe Mathieu-Daudé wrote: As the 'io_base' argument of m48t59_init() is unused (set to 0),

[PULL 2/2] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-30 Thread Michael S. Tsirkin
From: Ani Sinha This change adds a new DSDT golden master table blob to test disabling hotplug on both pci root bus and pci bridges. Also reverts the change in file bios-tables-test-allowed-diff.h to make sure its now empty so that future modifications to acpi tables can be caught. The

Re: [RFC PATCH v5 2/2] hw/riscv: sifive_u: Add backend drive support

2020-09-30 Thread Green Wan
On Wed, Sep 30, 2020 at 1:08 AM Alistair Francis wrote: > > On Mon, Sep 28, 2020 at 2:18 AM Green Wan wrote: > > > > Hi Alistair, > > > > Thanks for the review. See the reply inline below. > > > > > > On Sat, Sep 26, 2020 at 5:52 AM Alistair Francis > > wrote: > > > > > > On Tue, Sep 1, 2020

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-30 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Tue, Sep 29, 2020 at 3:01 PM Paolo Bonzini wrote: [...] >> Marc-André, we are totally in agreement about that! The problem is that >> you have already decided what the solution looks like, and that's what >> I'm not sure about because your solution also

Re: [PATCH 01/16] hw/core/cpu: Let CPU object have a clock source

2020-09-30 Thread Igor Mammedov
On Mon, 28 Sep 2020 19:15:24 +0200 Philippe Mathieu-Daudé wrote: > Let CPUState have a clock source (named 'clk') and CPUClass > have a clock_update() callback. The clock can be optionally > set Using qdev_connect_clock_in() from the Clock API. > If the clock changes, the optional clock_update()

Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-30 Thread Michael S. Tsirkin
On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote: > > > On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin wrote: > > On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote: > > > On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin > wrote: > > > > > > > > On

Re: [PATCH v4 04/12] target/arm: Restrict ARMv4 cpus to TCG accel

2020-09-30 Thread Philippe Mathieu-Daudé
On 9/30/20 12:43 AM, Philippe Mathieu-Daudé wrote: > KVM requires a cpu based on (at least) the ARMv7 architecture. > > Only enable the following ARMv4 CPUs when TCG is available: > > - StrongARM (SA1100/1110) > - OMAP1510 (TI925T) > > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH v5 05/14] hw/block/nvme: Add support for Namespace Types

2020-09-30 Thread Klaus Jensen
On Sep 28 11:35, Dmitry Fomichev wrote: > From: Niklas Cassel > > Namespace Types introduce a new command set, "I/O Command Sets", > that allows the host to retrieve the command sets associated with > a namespace. Introduce support for the command set and enable > detection for the NVM Command

Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-09-30 Thread Mark Cave-Ayland
On 14/09/2020 11:24, Philippe Mathieu-Daudé wrote: > As the 'io_base' argument of m48t59_init() is unused (set to 0), > remove it to simplify. > To create a device on the ISA bus, m48t59_init_isa() is the > preferred function to use. > > Signed-off-by: Philippe Mathieu-Daudé > --- >

[PULL 1/2] tests/acpi: unit test exercising global pci hotplug off for i440fx

2020-09-30 Thread Michael S. Tsirkin
From: Ani Sinha This change adds a unit test to exercise the case when hotplug is disabled both for pci root bus and the pci bridges by passing the following two switches to qemu: -global PIIX4_PM.acpi-root-pci-hotplug=off -global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off

[PULL 0/2] acpi: unit test

2020-09-30 Thread Michael S. Tsirkin
The following changes since commit f142e4ede72853aaa7d306bc79b099caed45769b: tests/acpi: drop unnecessary files (2020-09-29 07:10:37 -0400) are available in the Git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to

Re: [PATCH 16/16] tests/acceptance: Test the MIPSsim machine

2020-09-30 Thread Daniel P . Berrangé
On Tue, Sep 29, 2020 at 10:38:30AM +0100, Alex Bennée wrote: > > Philippe Mathieu-Daudé writes: > > > +Alex/Daniel > > > > On 9/28/20 10:33 PM, Willian Rampazzo wrote: > >> On Mon, Sep 28, 2020 at 2:31 PM Philippe Mathieu-Daudé > >> wrote: > >>> > >>> Add a test for the mipssim machine, based

Some comments on using qemu-storage-daemon

2020-09-30 Thread Richard W.M. Jones
I understand that QSD is at an early stage of development and I'm sure you have plans to fix these things. Nevertheless here are my comments after trying to add an interop test with libnbd. (1) Documentation! (Or complete lack of it ...) I had to ask Kevin how to construct the command line

Re: [PATCH v4 01/12] accel/tcg: Add stub for cpu_loop_exit()

2020-09-30 Thread Thomas Huth
On 30/09/2020 00.43, Philippe Mathieu-Daudé wrote: > Since the support of SYS_READC in commit 8de702cb67 the > semihosting code is strongly depedent of the TCG accelerator > via a call to cpu_loop_exit(). > > Ideally we would only build semihosting support when TCG > is available, but

Re: [PATCH 00/16] hw/mips: Set CPU frequency

2020-09-30 Thread Igor Mammedov
On Mon, 28 Sep 2020 19:15:23 +0200 Philippe Mathieu-Daudé wrote: > All the MIPS cores emulated by QEMU provides the Coproc#0 > 'Count' register which can be used as a free running timer. > > Since it's introduction in 2005 this timer uses a fixed > frequency of 100 MHz (for a CPU freq of 200

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-30 Thread Marc-André Lureau
Hi On Wed, Sep 30, 2020 at 11:34 AM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > On Tue, Sep 29, 2020 at 3:01 PM Paolo Bonzini > wrote: > [...] > >> Marc-André, we are totally in agreement about that! The problem is that > >> you have already decided what the

Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-30 Thread Ani Sinha
On Wed, Sep 30, 2020 at 1:34 PM Michael S. Tsirkin wrote: > > On Wed, Sep 30, 2020 at 01:17:53PM +0530, Ani Sinha wrote: > > > > > > On Wed, Sep 30, 2020 at 1:14 PM Michael S. Tsirkin wrote: > > > > On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote: > > > > > > > > > > > > >

[Bug 1849644] Re: QEMU VNC websocket proxy requires non-standard 'binary' subprotocol

2020-09-30 Thread Christian Ehrhardt 
Trying to connect using novnc latest/stable:1.2.0 2020-07-31 (6) 18MB - as-is failing to connect Keeping VNC up and refreshing qemu. Updating to the new qemu from focal proposed (by now resolved the archive publishing issues we had before this morning). Get:67

Re: [PATCH v3 3/5] hw/arm/virt: Move kvm pmu setup to virt_cpu_post_init

2020-09-30 Thread Auger Eric
Hi Drew, On 9/16/20 11:26 AM, Andrew Jones wrote: > Move the KVM PMU setup part of fdt_add_pmu_nodes() to > virt_cpu_post_init(), which is a more appropriate location. Now > fdt_add_pmu_nodes() is also named more appropriately, because it > no longer does anything but fdt node creation. > > No

Re: [PATCH v4 04/46] qapi: modify docstrings to be sphinx-compatible

2020-09-30 Thread Markus Armbruster
John Snow writes: > I did not say "sphinx beautiful", just "sphinx compatible". They will > not throw errors when parsed and interpreted as ReST. "Bang on the keyboard until Sphinx doesn't throw errors anymore" might be good enough for a certain kind of mathematician, but a constructive

Re: [PATCH v5 09/14] hw/block/nvme: Support Zoned Namespace Command Set

2020-09-30 Thread Klaus Jensen
On Sep 28 11:35, Dmitry Fomichev wrote: > The emulation code has been changed to advertise NVM Command Set when > "zoned" device property is not set (default) and Zoned Namespace > Command Set otherwise. > > Handlers for three new NVMe commands introduced in Zoned Namespace > Command Set

Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-30 Thread Ani Sinha
On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin wrote: > On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote: > > > On Tue, Sep 29, 2020 at 5:05 PM Michael S. Tsirkin > wrote: > > > > > > > > On Tue, Sep 29, 2020 at 04:58:03PM +0530, Ani Sinha wrote: > > > > > On Tue, Sep 29, 2020 at

Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-30 Thread Ani Sinha
On Wed, Sep 30, 2020 at 1:14 PM Michael S. Tsirkin wrote: > On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote: > > > > > > > > > On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin > wrote: > > > > > > On Tue, Sep 29, 2020 at 06:03:00PM +0530, Ani Sinha wrote: > > > > > > > On

Re: [PATCH v4 00/12] Support disabling TCG on ARM (part 2)

2020-09-30 Thread Igor Mammedov
On Wed, 30 Sep 2020 00:43:43 +0200 Philippe Mathieu-Daudé wrote: > Cover from Samuel Ortiz from (part 1) [1]: > > This patchset allows for building and running ARM targets with TCG > disabled. [...] > > The rationale behind this work comes from the NEMU project where we're > trying to

Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-30 Thread Michael S. Tsirkin
On Wed, Sep 30, 2020 at 01:17:53PM +0530, Ani Sinha wrote: > > > On Wed, Sep 30, 2020 at 1:14 PM Michael S. Tsirkin wrote: > > On Wed, Sep 30, 2020 at 01:09:09PM +0530, Ani Sinha wrote: > > > > > > > > > On Wed, Sep 30, 2020 at 1:06 PM Michael S. Tsirkin > wrote: > >

Re: [PATCH v4 9/9] memory: assert MemoryRegionOps callbacks are defined

2020-09-30 Thread P J P
+-- On Wed, 16 Sep 2020, Philippe Mathieu-Daudé wrote --+ | On 8/11/20 1:41 PM, P J P wrote: | > When registering a MemoryRegionOps object, assert that its | > read/write callback methods are defined. This avoids potential | > guest crash via a NULL pointer dereference. | > | > Suggested-by:

Re: [PATCH] pci: check bus pointer before dereference

2020-09-30 Thread Igor Mammedov
On Wed, 30 Sep 2020 10:32:42 +0530 (IST) P J P wrote: > [+Paolo, +Fam Zheng - for scsi] > > +-- On Mon, 28 Sep 2020, P J P wrote --+ > | +-- On Wed, 16 Sep 2020, Peter Maydell wrote --+ > | | On Wed, 16 Sep 2020 at 07:28, P J P wrote: > | | > -> >

Re: Outline for VHOST_USER_PROTOCOL_F_VDPA

2020-09-30 Thread Michael S. Tsirkin
On Tue, Sep 29, 2020 at 07:38:24PM +0100, Stefan Hajnoczi wrote: > On Tue, Sep 29, 2020 at 06:04:34AM -0400, Michael S. Tsirkin wrote: > > On Tue, Sep 29, 2020 at 09:57:51AM +0100, Stefan Hajnoczi wrote: > > > On Tue, Sep 29, 2020 at 02:09:55AM -0400, Michael S. Tsirkin wrote: > > > > On Mon, Sep

Re: [PATCH v5 03/14] hw/block/nvme: Introduce the Namespace Types definitions

2020-09-30 Thread Klaus Jensen
On Sep 28 11:35, Dmitry Fomichev wrote: > From: Niklas Cassel > > Define the structures and constants required to implement > Namespace Types support. > > Signed-off-by: Niklas Cassel > Signed-off-by: Dmitry Fomichev > --- > hw/block/nvme-ns.h | 2 ++ > hw/block/nvme.c | 2 +- >

Re: [PATCH v3 4/5] DO NOT MERGE: HACK: Add steal time KVM cap to kvm.h

2020-09-30 Thread Auger Eric
Hi Drew, On 9/16/20 11:26 AM, Andrew Jones wrote: > --- > linux-headers/linux/kvm.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h > index a28c3667370b..924672cca1f1 100644 > --- a/linux-headers/linux/kvm.h > +++

Re: Some comments on using qemu-storage-daemon

2020-09-30 Thread Daniel P . Berrangé
On Wed, Sep 30, 2020 at 09:40:59AM +0100, Richard W.M. Jones wrote: > I understand that QSD is at an early stage of development and I'm sure > you have plans to fix these things. Nevertheless here are my comments > after trying to add an interop test with libnbd. > > (1) Documentation! (Or

Re: Some comments on using qemu-storage-daemon

2020-09-30 Thread Richard W.M. Jones
On Wed, Sep 30, 2020 at 09:49:00AM +0100, Daniel P. Berrangé wrote: > On Wed, Sep 30, 2020 at 09:40:59AM +0100, Richard W.M. Jones wrote: > > I understand that QSD is at an early stage of development and I'm sure > > you have plans to fix these things. Nevertheless here are my comments > > after

Re: [PATCH] PoC: Rust binding for QAPI (qemu-ga only, for now)

2020-09-30 Thread Marc-André Lureau
Hi On Tue, Sep 29, 2020 at 10:23 PM Paolo Bonzini wrote: > On 29/09/20 19:55, Marc-André Lureau wrote: > > My understanding of what you propose is: > > - ForeignConvert::with_foreign > > - FromForeign::from_foreign (with implied into_native) > > And: > > - ForeignConvert::as_foreign (with the

Re: [PATCH v10 13/13] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug

2020-09-30 Thread Ani Sinha
On Wed, Sep 30, 2020 at 1:37 PM Ani Sinha wrote: > On Wed, Sep 30, 2020 at 1:34 PM Michael S. Tsirkin wrote: > > > > > > On Wed, Sep 30, 2020 at 01:17:53PM +0530, Ani Sinha wrote: > > > > > > > > > > > > On Wed, Sep 30, 2020 at 1:14 PM Michael S. Tsirkin > wrote: > > > > > > > > On Wed,

[RFC PATCH v2 0/8] block-backend: Introduce I/O hang

2020-09-30 Thread Jiahui Cen
A VM in the cloud environment may use a virutal disk as the backend storage, and there are usually filesystems on the virtual block device. When backend storage is temporarily down, any I/O issued to the virtual block device will cause an error. For example, an error occurred in ext4 filesystem

[RFC PATCH v2 6/8] virtio-blk: pause I/O hang when resetting

2020-09-30 Thread Jiahui Cen
When resetting virtio-blk, we have to drain all AIOs but do not care about the results. So it is necessary to disable I/O hang before resetting virtio-blk, and enable it after resetting. Signed-off-by: Jiahui Cen Signed-off-by: Ying Fang --- hw/block/virtio-blk.c | 8 1 file changed,

[RFC PATCH v2 1/8] block-backend: introduce I/O rehandle info

2020-09-30 Thread Jiahui Cen
The I/O hang feature is realized based on a rehandle mechanism. Each block backend will have a list to store hanging block AIOs, and a timer to regularly resend these aios. In order to issue the AIOs again, each block AIOs also need to store its coroutine entry. Signed-off-by: Jiahui Cen

[PATCH RFC 00/14] fix some comment spelling errors

2020-09-30 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/. I used spellcheck to check the spelling errors and found some errors in the folder. The checkpatch.pl file in the Linux kernel can check spelling errors in patches. I'm trying to add this function to the checkpatch.pl

[RFC PATCH v2 7/8] qemu-option: add I/O hang timeout option

2020-09-30 Thread Jiahui Cen
I/O hang timeout should be different under different situations. So it is better to provide an option for user to determine I/O hang timeout for each block device. Signed-off-by: Jiahui Cen Signed-off-by: Ying Fang --- blockdev.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

[PATCH RFC 08/14] m68k/: fix some comment spelling errors

2020-09-30 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/m68k. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang --- target/m68k/translate.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[PATCH RFC 06/14] mips/: fix some comment spelling errors

2020-09-30 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/mips. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang --- target/mips/internal.h | 2 +- target/mips/translate.c | 10 +-

[PULL 01/17] util/vfio-helpers: Pass page protections to qemu_vfio_pci_map_bar()

2020-09-30 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Pages are currently mapped READ/WRITE. To be able to use different protections, add a new argument to qemu_vfio_pci_map_bar(). Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi Message-Id: <20200922083821.578519-2-phi...@redhat.com> ---

[PATCH v3 3/3] target-i386: post memory failure event to uplayer

2020-09-30 Thread zhenwei pi
Post memory failure event to uplayer to handle hardware memory corrupted event. Rather than simple QEMU log, QEMU could report more effective message to uplayer. For example, guest crashes by MCE, selecting another host server is a better choice. Signed-off-by: zhenwei pi ---

Re: [PATCH] pci: check bus pointer before dereference

2020-09-30 Thread P J P
+-- On Wed, 30 Sep 2020, Igor Mammedov wrote --+ | 'dest' is offset into MemoryRegion, so far I don't see how it could break | into QEMU stack. Do you have a simple reproducer? Please see: -> https://ruhr-uni-bochum.sciebo.de/s/NNWP2GfwzYKeKwE?path=%2Flsi_nullptr1 Thank you. -- Prasad J

[PULL 13/17] block/io: refactor save/load vmstate

2020-09-30 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Like for read/write in a previous commit, drop extra indirection layer, generate directly bdrv_readv_vmstate() and bdrv_writev_vmstate(). Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake Reviewed-by: Stefan

Re: [PATCH v4 00/12] Support disabling TCG on ARM (part 2)

2020-09-30 Thread Philippe Mathieu-Daudé
On 9/30/20 9:58 AM, Igor Mammedov wrote: > On Wed, 30 Sep 2020 00:43:43 +0200 > Philippe Mathieu-Daudé wrote: > >> Cover from Samuel Ortiz from (part 1) [1]: >> >> This patchset allows for building and running ARM targets with TCG >> disabled. [...] >> >> The rationale behind this work

Re: [PATCH RFC 00/14] fix some comment spelling errors

2020-09-30 Thread Philippe Mathieu-Daudé
On 9/30/20 11:53 AM, zhaolichang wrote: > I found that there are many spelling errors in the comments of qemu/target/. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > The checkpatch.pl file in the Linux kernel can check spelling errors in > patches. >

Re: [PATCH] hw/arm: Restrict APEI tables generation to the 'virt' machine

2020-09-30 Thread Philippe Mathieu-Daudé
On 9/30/20 7:08 AM, Dongjiu Geng wrote: > On 2020/9/29 20:56, Philippe Mathieu-Daudé wrote: >> As only the Virt machine uses the RAS Virtualization feature (see >> commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option"), >> restrict the APEI tables generation code to the virt machine. >

Re: [PATCH v1 03/15] meson: move libmpathpersist test

2020-09-30 Thread Alex Bennée
Paolo Bonzini writes: > On 25/09/20 17:40, Alex Bennée wrote: >> From: Paolo Bonzini >> >> This is the first compiler/linker test that has been moved to Meson. >> Add more section headings to keep things clearer. >> >> [thuth: Add check for mpathpersist.found() before showing >>

Re: [PATCH RFC 02/14] ppc/: fix some comment spelling errors

2020-09-30 Thread David Edmondson
On Wednesday, 2020-09-30 at 17:53:09 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/ppc. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson

Re: [PATCH RFC 03/14] riscv/: fix some comment spelling errors

2020-09-30 Thread David Edmondson
On Wednesday, 2020-09-30 at 17:53:10 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/riscv. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David

Re: [PATCH RFC 12/14] arm/: fix some comment spelling errors

2020-09-30 Thread David Edmondson
On Wednesday, 2020-09-30 at 17:53:19 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/arm. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson

Re: [PATCH RFC 14/14] target/: fix some comment spelling errors

2020-09-30 Thread David Edmondson
On Wednesday, 2020-09-30 at 17:53:21 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of qemu/target. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson > ---

[PATCH v4 5/6] meson: add spice dependency to core spice source files.

2020-09-30 Thread Gerd Hoffmann
Right now it happens to work by pure luck because the spice chardevs add the spice dependency to the softmmu source set. That'll change though once we start building spice chardevs as module, so lets fix it properly. Signed-off-by: Gerd Hoffmann --- ui/meson.build | 2 +- 1 file changed, 1

Re: About 'qemu-security' mailing list

2020-09-30 Thread P J P
+-- On Fri, 18 Sep 2020, P J P wrote --+ | +-- On Wed, 16 Sep 2020, Stefan Hajnoczi wrote --+ | | Do downstream maintainers want to know about potential security bug reports | | that have not been triaged yet? | | | | Maybe there should there be a pre-announce list for bugs that have been | |

Re: [PATCH v2 3/4] block: move block exports to libblockdev

2020-09-30 Thread Stefan Hajnoczi
On Tue, Sep 29, 2020 at 12:36:10PM -0500, Eric Blake wrote: > On 9/29/20 7:55 AM, Stefan Hajnoczi wrote: > > Block exports are used by softmmu, qemu-storage-daemon, and qemu-nbd. > > They are not used by other programs and are not otherwise needed in > > libblock. > > > > Undo the recent move of

Re: [PATCH v2 0/2] NVMe passthrough: Take into account host IOVA reserved regions

2020-09-30 Thread Stefan Hajnoczi
On Tue, Sep 29, 2020 at 10:55:48AM +0200, Eric Auger wrote: > The current IOVA allocator allocates within the [0x1, 1ULL << 39] > window, without paying attention to the host IOVA reserved regions. > This prevents NVMe passthtrough from working on ARM as the fixed > IOVAs rapidly grow up to

Re: [PATCH v7 06/13] qmp: Call monitor_set_cur() only in qmp_dispatch()

2020-09-30 Thread Markus Armbruster
Kevin Wolf writes: > Am 28.09.2020 um 13:42 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 14.09.2020 um 17:10 hat Markus Armbruster geschrieben: >> >> Kevin Wolf writes: >> >> >> >> > The correct way to set the current monitor for a coroutine handler will >> >> > be

Re: [PATCH v2 11/13] block/export: convert vhost-user-blk server to block export API

2020-09-30 Thread Stefan Hajnoczi
On Wed, Sep 30, 2020 at 07:28:58AM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > Use the new QAPI block exports API instead of defining our own QOM > > objects. > > > > This is a large change because the lifecycle of VuBlockDev needs to > > follow BlockExportDriver. QOM

[RFC PATCH v2 2/8] block-backend: rehandle block aios when EIO

2020-09-30 Thread Jiahui Cen
When a backend device temporarily does not response, like a network disk down due to some network faults, any IO to the coresponding virtual block device in VM would return I/O error. If the hypervisor returns the error to VM, the filesystem on this block device may not work as usual. And in many

[RFC PATCH v2 8/8] qapi: add I/O hang and I/O hang timeout qapi event

2020-09-30 Thread Jiahui Cen
Sometimes hypervisor management tools like libvirt may need to monitor I/O hang events. Let's report I/O hang and I/O hang timeout event via qapi. Signed-off-by: Jiahui Cen Signed-off-by: Ying Fang --- block/block-backend.c | 3 +++ qapi/block-core.json | 26 ++ 2

Re: [PATCH 16/16] tests/acceptance: Test the MIPSsim machine

2020-09-30 Thread Alex Bennée
Daniel P. Berrangé writes: > On Tue, Sep 29, 2020 at 10:38:30AM +0100, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé writes: >> >> > +Alex/Daniel >> > >> > On 9/28/20 10:33 PM, Willian Rampazzo wrote: >> >> On Mon, Sep 28, 2020 at 2:31 PM Philippe Mathieu-Daudé >> >> wrote: >> >>> >>

[PATCH RFC 04/14] rx/: fix some comment spelling errors

2020-09-30 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/rx. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang --- target/rx/op_helper.c | 2 +- target/rx/translate.c | 2 +- 2 files changed, 2 insertions(+), 2

[PATCH RFC 03/14] riscv/: fix some comment spelling errors

2020-09-30 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/riscv. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang --- target/riscv/cpu.c | 2 +- target/riscv/cpu_bits.h | 2 +- target/riscv/csr.c

[PATCH v3 2/3] qapi/run-state.json: introduce memory failure event

2020-09-30 Thread zhenwei pi
Introduce memory failure events for hyperviso/guest . Then uplayer could know when/why/what happened during hitting a hardware memory failure. Suggested by Peter Maydell, rename events name to make them architecture-neutral; and suggested by Paolo, add more info to distinguish a mce is AR/AO,

Re: [PATCH 00/16] hw/mips: Set CPU frequency

2020-09-30 Thread Philippe Mathieu-Daudé
On 9/30/20 9:40 AM, Igor Mammedov wrote: > On Mon, 28 Sep 2020 19:15:23 +0200 > Philippe Mathieu-Daudé wrote: > >> All the MIPS cores emulated by QEMU provides the Coproc#0 >> 'Count' register which can be used as a free running timer. >> >> Since it's introduction in 2005 this timer uses a

[PULL 04/17] block/nvme: Drop NVMeRegs structure, directly use NvmeBar

2020-09-30 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé NVMeRegs only contains NvmeBar. Simplify the code by using NvmeBar directly. This triggers a checkpatch.pl error: ERROR: Use of volatile is usually wrong, please add a comment #30: FILE: block/nvme.c:691: +volatile NvmeBar *regs; This is a false positive

[PULL 15/17] docs: add 'io_uring' option to 'aio' param in qemu-options.hx

2020-09-30 Thread Stefan Hajnoczi
From: Stefano Garzarella When we added io_uring AIO engine, we forgot to update qemu-options.hx, so qemu(1) man page and qemu help were outdated. Signed-off-by: Stefano Garzarella Signed-off-by: Stefan Hajnoczi Reviewed-by: Julia Suvorova Reviewed-by: Pankaj Gupta Message-Id:

[PULL 05/17] block/nvme: Use register definitions from 'block/nvme.h'

2020-09-30 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Use the NVMe register definitions from "block/nvme.h" which ease a bit reviewing the code while matching the datasheet. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi Message-Id: <20200922083821.578519-6-phi...@redhat.com> --- block/nvme.c |

[PULL 17/17] util/vfio-helpers: Rework the IOVA allocator to avoid IOVA reserved regions

2020-09-30 Thread Stefan Hajnoczi
From: Eric Auger Introduce the qemu_vfio_find_fixed/temp_iova helpers which respectively allocate IOVAs from the bottom/top parts of the usable IOVA range, without picking within host IOVA reserved windows. The allocation remains basic: if the size is too big for the remaining of the current

Re: [PATCH RFC 14/14] target/: fix some comment spelling errors

2020-09-30 Thread Philippe Mathieu-Daudé
On 9/30/20 11:53 AM, zhaolichang wrote: > I found that there are many spelling errors in the comments of qemu/target. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: Philippe Mathieu-Daudé > --- >

[PULL 12/17] block: drop bdrv_prwv

2020-09-30 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Now that we are not maintaining boilerplate code for coroutine wrappers, there is no more sense in keeping the extra indirection layer of bdrv_prwv(). Let's drop it and instead generate pure bdrv_preadv() and bdrv_pwritev(). Currently, bdrv_pwritev() and

[PULL 11/17] block: generate coroutine-wrapper code

2020-09-30 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Use code generation implemented in previous commit to generated coroutine wrappers in block.c and block/io.c Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Stefan Hajnoczi Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Message-Id:

[PULL 16/17] util/vfio-helpers: Collect IOVA reserved regions

2020-09-30 Thread Stefan Hajnoczi
From: Eric Auger The IOVA allocator currently ignores host reserved regions. As a result some chosen IOVAs may collide with some of them, resulting in VFIO MAP_DMA errors later on. This happens on ARM where the MSI reserved window quickly is encountered: [0x800, 0x810]. since 5.4 kernel,

Re: [PATCH RFC 04/14] rx/: fix some comment spelling errors

2020-09-30 Thread Philippe Mathieu-Daudé
On 9/30/20 11:53 AM, zhaolichang wrote: > I found that there are many spelling errors in the comments of qemu/target/rx. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: Philippe Mathieu-Daudé > --- >

Re: [PATCH RFC 09/14] sh4/: fix some comment spelling errors

2020-09-30 Thread Philippe Mathieu-Daudé
On 9/30/20 11:53 AM, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/sh4. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang > --- > target/sh4/cpu.h | 2 +- >

Re: [PATCH RFC 08/14] m68k/: fix some comment spelling errors

2020-09-30 Thread Laurent Vivier
Le 30/09/2020 à 11:53, zhaolichang a écrit : > I found that there are many spelling errors in the comments of > qemu/target/m68k. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang > --- > target/m68k/translate.c | 16

Re: [PATCH RFC 10/14] i386/: fix some comment spelling errors

2020-09-30 Thread David Edmondson
On Wednesday, 2020-09-30 at 17:53:17 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of > qemu/target/i386. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson

Re: [PATCH RFC 04/14] rx/: fix some comment spelling errors

2020-09-30 Thread David Edmondson
On Wednesday, 2020-09-30 at 17:53:11 +08, zhaolichang wrote: > I found that there are many spelling errors in the comments of qemu/target/rx. > I used spellcheck to check the spelling errors and found some errors in the > folder. > > Signed-off-by: zhaolichang Reviewed-by: David Edmondson >

Re: [PATCH v4 30/46] qapi/gen.py: Fix edge-case of _is_user_module

2020-09-30 Thread Eduardo Habkost
On Wed, Sep 30, 2020 at 12:31:34AM -0400, John Snow wrote: > The edge case is that if the name is '', this expression returns a > string instead of a bool, which violates our declared type. > > Signed-off-by: John Snow > Reviewed-by: Cleber Rosa Reviewed-by: Eduardo Habkost -- Eduardo

Re: [PATCH] hw/arm: Restrict APEI tables generation to the 'virt' machine

2020-09-30 Thread Dongjiu Geng
On 2020/9/30 18:35, Philippe Mathieu-Daudé wrote: > On 9/30/20 7:08 AM, Dongjiu Geng wrote: >> On 2020/9/29 20:56, Philippe Mathieu-Daudé wrote: >>> As only the Virt machine uses the RAS Virtualization feature (see >>> commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option"), >>>

Re: [PATCH v7 06/13] qmp: Call monitor_set_cur() only in qmp_dispatch()

2020-09-30 Thread Kevin Wolf
Am 30.09.2020 um 11:26 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 28.09.2020 um 13:42 hat Markus Armbruster geschrieben: > >> Kevin Wolf writes: > >> > >> > Am 14.09.2020 um 17:10 hat Markus Armbruster geschrieben: > >> >> Kevin Wolf writes: > >> >> > >> >> > The

[RFC PATCH v2 4/8] block-backend: add I/O rehandle pause/unpause

2020-09-30 Thread Jiahui Cen
Sometimes there is no need to rehandle AIOs although I/O hang is enabled. For example, when deleting a block backend, we have to wait AIO completed by calling blk_drain(), but not care about the results. So a pause interface of I/O hang is helpful to bypass the rehandle mechanism. Signed-off-by:

[RFC PATCH v2 3/8] block-backend: add I/O hang timeout

2020-09-30 Thread Jiahui Cen
Not all errors would be fixed, so it is better to add a rehandle timeout for I/O hang. Signed-off-by: Jiahui Cen Signed-off-by: Ying Fang --- block/block-backend.c | 99 +- include/sysemu/block-backend.h | 2 + 2 files changed, 100 insertions(+), 1

[PATCH RFC 12/14] arm/: fix some comment spelling errors

2020-09-30 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/arm. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang --- target/arm/cpu.h | 2 +- target/arm/helper.c| 4 ++-- target/arm/m_helper.c

[PATCH RFC 05/14] tricore/: fix some comment spelling errors

2020-09-30 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/tricore. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang --- target/s390x/ioinst.c | 2 +- target/tricore/csfr.def| 2 +-

[PATCH RFC 07/14] s390x/: fix some comment spelling errors

2020-09-30 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/s390x. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang --- target/s390x/cpu_models.h | 4 ++-- target/s390x/excp_helper.c | 2 +-

[PATCH RFC 14/14] target/: fix some comment spelling errors

2020-09-30 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang --- target/openrisc/cpu.h| 2 +- target/sparc/asi.h | 2 +- target/unicore32/translate.c

[PATCH v3 1/3] target-i386: seperate MCIP & MCE_MASK error reason

2020-09-30 Thread zhenwei pi
Previously we can only get a simple string "Triple fault" in qemu log. Add detailed message for the two reasons to describe why qemu has to reset the guest. Signed-off-by: zhenwei pi --- target/i386/helper.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff

[PATCH RFC 13/14] alpha/: fix some comment spelling errors

2020-09-30 Thread zhaolichang
I found that there are many spelling errors in the comments of qemu/target/alpha. I used spellcheck to check the spelling errors and found some errors in the folder. Signed-off-by: zhaolichang --- target/alpha/cpu.h | 4 ++-- target/alpha/translate.c | 2 +- 2 files changed, 3

[PATCH v3 0/3] add MEMORY_FAILURE event

2020-09-30 Thread zhenwei pi
v2->v3: Use g_strdup_printf instead of snprintf. Declear memory failure event as 3 parts: 'recipient', 'action', 'flags'. Wrapper function emit_guest_memory_failure_hypervisor_memory_failure. v1->v2: Suggested by Peter Maydell, rename events to make them architecture-neutral: 'PC-RAM' ->

Re: [PATCH] hw/arm/aspeed: Map the UART5 device unconditionally

2020-09-30 Thread Cédric Le Goater
On 9/30/20 7:29 AM, Andrew Jeffery wrote: > > > On Fri, 18 Sep 2020, at 02:33, Cédric Le Goater wrote: >> On 9/17/20 6:57 PM, Philippe Mathieu-Daudé wrote: >>> On 9/16/20 7:51 AM, Cédric Le Goater wrote: On 9/15/20 7:23 PM, Philippe Mathieu-Daudé wrote: > ping? It's reviewed :

[PULL 10/17] scripts: add block-coroutine-wrapper.py

2020-09-30 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy We have a very frequent pattern of creating a coroutine from a function with several arguments: - create a structure to pack parameters - create _entry function to call original function taking parameters from struct - do different magic to handle

[PULL 03/17] block/nvme: Reduce I/O registers scope

2020-09-30 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé We only access the I/O register in nvme_init(). Remove the reference in BDRVNVMeState and reduce its scope. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi Message-Id: <20200922083821.578519-4-phi...@redhat.com> --- block/nvme.c | 29

[PULL 02/17] block/nvme: Map doorbells pages write-only

2020-09-30 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Per the datasheet sections 3.1.13/3.1.14: "The host should not read the doorbell registers." As we don't need read access, map the doorbells with write-only permission. We keep a reference to this mapped address in the BDRVNVMeState structure. Signed-off-by:

[PULL 06/17] block/nvme: Replace magic value by SCALE_MS definition

2020-09-30 Thread Stefan Hajnoczi
From: Philippe Mathieu-Daudé Use self-explicit SCALE_MS definition instead of magic value (missed in similar commit e4f310fe7f5). Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Stefan Hajnoczi Message-Id: <20200922083821.578519-7-phi...@redhat.com> --- block/nvme.c | 2 +- 1 file

Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()

2020-09-30 Thread Philippe Mathieu-Daudé
On 9/30/20 10:35 AM, Mark Cave-Ayland wrote: > On 14/09/2020 11:24, Philippe Mathieu-Daudé wrote: > >> As the 'io_base' argument of m48t59_init() is unused (set to 0), >> remove it to simplify. >> To create a device on the ISA bus, m48t59_init_isa() is the >> preferred function to use. >> >>

Re: [PULL 00/29] QAPI patches patches for 2020-09-29

2020-09-30 Thread Peter Maydell
On Tue, 29 Sep 2020 at 21:19, Markus Armbruster wrote: > > The following changes since commit b150cb8f67bf491a49a1cb1c7da151eeacbdbcc9: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2020-09-29 13:18:54 +0100) > > are available in the Git repository at: > >

use of 'apt' in scripting in our dockerfiles provokes warnings

2020-09-30 Thread Peter Maydell
While processing a recent pullreq which updated the dockerfile dependencies and thus provoked a rebuild, I noticed that we use the 'apt' command in ways that provoke a warning: #7 0.789 WARNING: apt does not have a stable CLI interface. Use with caution in scripts. The apt(8) manpage says:

  1   2   3   4   >