[PATCH v2 3/5] memory: Add IOMMU_NOTIFIER_DEVIOTLB_UNMAP IOMMUTLBNotificationType

2020-10-19 Thread Eugenio Pérez
This allows us to differentiate between regular IOMMU map/unmap events and DEVIOTLB unmap. Doing so, notifiers that only need device IOTLB invalidations will not receive regular IOMMU unmappings. Adapt intel and vhost to use it. Signed-off-by: Eugenio Pérez Reviewed-by: Peter Xu Reviewed-by: Ju

[PATCH v2 5/5] memory: Skip bad range assertion if notifier is DEVIOTLB_UNMAP type

2020-10-19 Thread Eugenio Pérez
Device IOTLB invalidations can unmap arbitrary ranges, eiter outside of the memory region or even [0, ~0ULL] for all the space. The assertion could be hit by a guest, and rhel7 guest effectively hit it. Signed-off-by: Eugenio Pérez Reviewed-by: Peter Xu Reviewed-by: Juan Quintela --- softmmu/m

[PATCH v2 0/5] memory: Skip assertion in memory_region_unregister_iommu_notifier

2020-10-19 Thread Eugenio Pérez
I am able to hit this assertion when a Red Hat 7 guest virtio_net device raises an "Invalidation" of all the TLB entries. This happens in the guest's startup if 'intel_iommu=on' argument is passed to the guest kernel and right IOMMU/ATS devices are declared in qemu's command line. Command line: /h

[PATCH v2 4/5] intel_iommu: Skip page walking on device iotlb invalidations

2020-10-19 Thread Eugenio Pérez
Although they didn't reach the notifier because of the filtering in memory_region_notify_iommu_one, the vt-d was still splitting huge memory invalidations in chunks. Skipping it. This improves performance in case of netperf with vhost-net: * TCP_STREAM: From 1923.6Mbit/s to 2175.13Mbit/s (13%) * T

Re: [PULL 00/44] mips-next patches for 2020-10-17

2020-10-19 Thread Peter Maydell
On Sat, 17 Oct 2020 at 15:05, Philippe Mathieu-Daudé wrote: > > The following changes since commit 7daf8f8d011cdd5d3e86930ed2bde969425c790c: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging= > (2020-10-16 17:39:01 +0100) > > are available in the Git repository at:

Re: [PATCH v2 5/8] qemu/bswap: Use compiler __builtin_bswap() on Haiku

2020-10-19 Thread Philippe Mathieu-Daudé
On 9/28/20 4:18 PM, Philippe Mathieu-Daudé wrote: On 9/28/20 4:13 PM, Daniel P. Berrangé wrote: On Mon, Sep 28, 2020 at 03:09:01PM +0100, David CARLIER wrote: Unfortunately it breaks the build. Can you provide details of the errors seen and toolchain versions. I notice we don't have any CI s

[Bug 1891748] Re: qemu-arm-static 5.1 can't run gcc

2020-10-19 Thread Mehmet Aydoğdu
** Also affects: charms Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1891748 Title: qemu-arm-static 5.1 can't run gcc Status in QEMU: Fix Committed S

[RFC PATCH v3 0/1] tests/vm: Add Haiku VM

2020-10-19 Thread Philippe Mathieu-Daudé
Intent to not get Alexander's patch lost. Since v2: - No change, posted as single patch Since v1: - Addressed Thomas Huth review comments Alexander von Gluck IV (1): tests/vm: Add Haiku test based on their vagrant images tests/keys/vagrant| 27 + tests/keys/vagrant.pub|

[RFC PATCH v3 1/1] tests/vm: Add Haiku test based on their vagrant images

2020-10-19 Thread Philippe Mathieu-Daudé
From: Alexander von Gluck IV Signed-off-by: Alexander von Gluck IV [PMD: Avoid to recreate the image each time] Signed-off-by: Philippe Mathieu-Daudé --- tests/keys/vagrant| 27 + tests/keys/vagrant.pub| 1 + tests/vm/Makefile.include | 3 +- tests/vm/basevm.py

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-19 Thread BALATON Zoltan via
On Mon, 19 Oct 2020, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 10/12/20 1:50 PM, BALATON Zoltan via wrote: On Mon, 12 Oct 2020, David Gibson wrote: On Mon, Oct 12, 2020 at 08:21:41AM +0200, Philippe Mathieu-Daudé wrote: On 10/12/20 12:34 AM, David Gibson wrote: On Su

Re: [PATCH] qemu-img: add support for rate limit in qemu-img commit

2020-10-19 Thread Alberto Garcia
On Sun 18 Oct 2020 08:33:59 AM CEST, Zhengui li wrote: Hello, > diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx > index b89c019..ed55b76 100644 > --- a/qemu-img-cmds.hx > +++ b/qemu-img-cmds.hx > @@ -34,9 +34,9 @@ SRST > ERST > > DEF("commit", img_commit, > -"commit [--object objectdef]

Re: [PATCH] configure: Test that gio libs from pkg-config work

2020-10-19 Thread Peter Maydell
On Mon, 28 Sep 2020 at 17:42, Paolo Bonzini wrote: > > On 28/09/20 18:04, Peter Maydell wrote: > > I wanted a statically-linked system emulation binary (which, yes, > > I know is not really something we support :-)). I got one with > > suitably liberal use of --disable-foo configure options, and >

Re: [PATCH v2 2/9] configure: cross-compiling without cross_prefix

2020-10-19 Thread BALATON Zoltan via
On Mon, 19 Oct 2020, Thomas Huth wrote: On 19/10/2020 10.07, Thomas Huth wrote: On 19/10/2020 03.39, Joelle van Dyne wrote: From: osy The iOS toolchain does not use the host prefix naming convention. We add a new option `--enable-cross-compile` that forces cross-compile even without a cross_p

[PATCH] hw/misc/bcm2835_cprman: Make cprman_internals an included source file

2020-10-19 Thread Philippe Mathieu-Daudé
bcm2835_cprman_internals.h is only include by bcm2835_cprman.c and contains various static array definitions. Make it an included source file (using the .c.inc extension). Signed-off-by: Philippe Mathieu-Daudé --- I'm sending this on top of: [PATCH v3 00/15] raspi: add the bcm2835 cprman clock ma

Re: [PATCH] configure: Test that gio libs from pkg-config work

2020-10-19 Thread Philippe Mathieu-Daudé
On 9/28/20 6:04 PM, Peter Maydell wrote: On some hosts (eg Ubuntu Bionic) pkg-config returns a set of libraries for gio-2.0 which don't actually work when compiling statically. (Specifically, the returned library string includes -lmount, but not -lblkid which -lmount depends upon, so linking fail

Re: [PULL v2 00/13] qemu-macppc queue 20201019

2020-10-19 Thread Peter Maydell
; > are available in the Git repository at: > > git://github.com/mcayland/qemu.git tags/qemu-macppc-20201019 > > for you to fetch changes up to bb997e5c967b3b6f19f1461811df6317ed37c5ff: > > mac_oldworld: Change PCI address of macio to

[PATCH] hw/block/nvme: fix prp mapping status codes

2020-10-19 Thread Klaus Jensen
From: Gollu Appalanaidu Differentiate between missing PRPs and misaligned PRPs, return the relevant status code and streamline the trace event naming. See NVMe Express v1.3d, Section 4.3 ("Physical Region Page Entry and List"). Signed-off-by: Gollu Appalanaidu Signed-off-by: Klaus Jensen ---

[PATCH 1/1] 9pfs: suppress performance warnings on qtest runs

2020-10-19 Thread Christian Schoenebeck
Don't trigger any performance warning if we're just running test cases, because tests intentionally run for edge cases. So far performance warnings were suppressed for the 'synth' fs driver backend only. This patch suppresses them for all 9p fs driver backends. Signed-off-by: Christian Schoenebec

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Dave Martin
On Mon, Oct 19, 2020 at 11:25:25AM +0200, Andrew Jones wrote: > On Thu, Oct 15, 2020 at 03:57:02PM +0100, Peter Maydell wrote: > > On Thu, 15 Oct 2020 at 15:41, Andrew Jones wrote: > > > The reporter states neither the source nor destination hardware supports > > > SVE. My guess is that what's hap

[PATCH] do not use colons in test names

2020-10-19 Thread Paolo Bonzini
Starting with meson 0.56, colons are used to separate the subproject name from the test name. Use dash or slash depending on what looks nicer. Signed-off-by: Paolo Bonzini --- tests/fp/meson.build| 4 ++-- tests/qtest/meson.build | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) dif

[PATCH] meson: use b_staticpic=false for meson >=0.56.0

2020-10-19 Thread Paolo Bonzini
Meson 0.56.0 correctly builds non-PIC static libraries with -fPIE if b_pie=true. We do not have to pass b_staticpic=true if PIE is requested if Meson is new-enough, which improves performance. Signed-off-by: Paolo Bonzini --- configure | 6 +- meson.build | 4 ++-- 2 files changed, 7 inse

Re: [PATCH v7 08/11] hw/block/nvme: Add injection of Offline/Read-Only zones

2020-10-19 Thread Klaus Jensen
On Oct 19 11:17, Dmitry Fomichev wrote: > ZNS specification defines two zone conditions for the zones that no > longer can function properly, possibly because of flash wear or other > internal fault. It is useful to be able to "inject" a small number of > such zones for testing purposes. > > This

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Peter Maydell
On Mon, 19 Oct 2020 at 12:32, Dave Martin wrote: > I'm not quite sure about Peter's assessment here. > > I agree with the inconsistency identified here: we always enumerate all > unallocated ID regs, but we enumerate ID_AA64ZFR0_EL1 conditionally. > This doesn't feel right: on a non-SVE guest, ID_

Re: [PATCH v2 6/9] tcg: implement mirror mapped JIT for iOS

2020-10-19 Thread BALATON Zoltan via
On Sun, 18 Oct 2020, Joelle van Dyne wrote: From: osy On iOS, we cannot allocate RWX pages without special entitlements. As a workaround, we can allocate a RX region and then mirror map it to a separate RX region. Then we can write to one region and execute from the other one. We also define `

Re: [PATCH] qemu-img: add support for rate limit in qemu-img convert

2020-10-19 Thread Alberto Garcia
On Sun 18 Oct 2020 08:34:39 AM CEST, Zhengui li wrote: > @@ -2729,6 +2757,10 @@ out: > qemu_opts_del(opts); > qemu_opts_free(create_opts); > qemu_opts_del(sn_opts); > +if (s.target && rate_limit && > +blk_get_public(s.target)->throttle_group_member.throttle_state) { > +

Re: [PATCH 1/1] 9pfs: suppress performance warnings on qtest runs

2020-10-19 Thread Greg Kurz
On Mon, 19 Oct 2020 13:10:18 +0200 Christian Schoenebeck wrote: > Don't trigger any performance warning if we're just running test cases, > because tests intentionally run for edge cases. > > So far performance warnings were suppressed for the 'synth' fs driver > backend only. This patch suppres

Re: [PATCH v3 01/13] block: return status from bdrv_append and friends

2020-10-19 Thread Kevin Wolf
Am 16.10.2020 um 19:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > The recommended use of qemu error api assumes returning status together > with setting errp and avoid void functions with errp parameter. Let's > improve bdrv_append and some friends to reduce error-propagation > overhead in fur

Re: [PATCH] do not use colons in test names

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/19/20 1:41 PM, Paolo Bonzini wrote: Starting with meson 0.56, colons are used to separate the subproject name from the test name. Use dash or slash depending on what looks nicer. Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daudé --- tests/fp/meson.build| 4 ++--

Re: [PATCH v2 3/8] migration: Add spaces around operator

2020-10-19 Thread Markus Armbruster
Bihong Yu writes: > Yes, I used to think "const VMStateDescription *[]" was right, but when I > search > similar expressions, most of all are "xxx * []". Such as: > fsdev/qemu-fsdev.c:54:.opts = (const char * []) > hw/intc/s390_flic_kvm.c:567:.subsections = (const VMStateDescription

io: Don't use '#' flag of printf format

2020-10-19 Thread AlexChen
Signed-off-by: AlexChen --- io/channel-websock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/io/channel-websock.c b/io/channel-websock.c index 47a0e941d9..e94a1fcf99 100644 --- a/io/channel-websock.c +++ b/io/channel-websock.c @@ -746,7 +746,7 @@ static int qio_channel_we

Re: [PATCH 1/1] 9pfs: suppress performance warnings on qtest runs

2020-10-19 Thread Christian Schoenebeck
On Montag, 19. Oktober 2020 13:48:22 CEST Greg Kurz wrote: > On Mon, 19 Oct 2020 13:10:18 +0200 > > Christian Schoenebeck wrote: > > Don't trigger any performance warning if we're just running test cases, > > because tests intentionally run for edge cases. > > > > So far performance warnings wer

Re: [PATCH v3 02/13] block: use return status of bdrv_append()

2020-10-19 Thread Kevin Wolf
Am 16.10.2020 um 19:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > Now bdrv_append returns status and we can drop all the local_err things > around it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Greg Kurz > Reviewed-by: Alberto Garcia > --- > block.c

Re: io: Don't use '#' flag of printf format

2020-10-19 Thread Daniel P . Berrangé
On Mon, Oct 19, 2020 at 08:12:02PM +0800, AlexChen wrote: > Signed-off-by: AlexChen > --- > io/channel-websock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/io/channel-websock.c b/io/channel-websock.c > index 47a0e941d9..e94a1fcf99 100644 > --- a/io/channel-websock.c

Re: [PATCH] target/i386: Support up to 32768 CPUs without IRQ remapping

2020-10-19 Thread David Woodhouse
On Thu, 2020-10-08 at 09:53 +0200, Paolo Bonzini wrote: > Indeed the nice thing about irqchip=split is that the handling of device > interrupts is entirely confined within QEMU, no matter if they're IOAPIC > or MSI. And because we had to implement interrupt remapping, the IOAPIC > is effectively u

Re: [PATCH v2 0/5] qapi: Restrict machine (and migration) specific commands

2020-10-19 Thread Eduardo Habkost
On Mon, Oct 19, 2020 at 09:55:20AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Mon, Oct 12, 2020 at 02:15:31PM +0200, Philippe Mathieu-Daudé wrote: > >> Reduce the machine code pulled into qemu-storage-daemon. > >> > >> The series is fully Acked, but Markus wants it review

[PULL 1/3] usb: hcd-dwc2: change assert()s to qemu_log_mask(LOG_GUEST_ERROR...)

2020-10-19 Thread Gerd Hoffmann
From: Paul Zimmerman Change several assert()s to qemu_log_mask(LOG_GUEST_ERROR...), to prevent the guest from causing Qemu to assert. Also fix up several existing qemu_log_mask()s to include the function name in the message. Suggested-by: Peter Maydell Signed-off-by: Paul Zimmerman Message-id:

[PULL 0/3] Usb 20201019 patches

2020-10-19 Thread Gerd Hoffmann
The following changes since commit e12ce85b2c79d83a340953291912875c30b3af06: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2020-10-16 22:46:28 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/usb-20201019-pu

[PULL 3/3] hw/usb/hcd-dwc2: fix divide-by-zero in dwc2_handle_packet()

2020-10-19 Thread Gerd Hoffmann
From: Mauro Matteo Cascella Check the value of mps to avoid potential divide-by-zero later in the function. Since HCCHAR_MPS is guest controllable, this prevents a malicious/buggy guest from crashing the QEMU process on the host. Signed-off-by: Mauro Matteo Cascella Reviewed-by: Paul Zimmerman

[PULL 2/3] usb/hcd-ehci: Fix error handling on missing device for iTD

2020-10-19 Thread Gerd Hoffmann
From: Anthony PERARD The EHCI Host Controller emulation attempt to locate the device associated with a periodic isochronous transfer description (iTD) and when this fail the host controller is reset. But according the EHCI spec 1.0 section 5.15.2.4 Host System Error, the host controller is suppo

Re: [PATCH 8/30] powerpc tcg: Fix Lesser GPL version number

2020-10-19 Thread Thomas Huth
On 19/10/2020 08.11, Chetan Pant wrote: > There is no "version 2" of the "Lesser" General Public License. > It is either "GPL version 2.0" or "Lesser GPL version 2.1". > This patch replaces all occurrences of "Lesser GPL version 2" with > "Lesser GPL version 2.1" in comment section. > > Signed-off

Re: [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set

2020-10-19 Thread Klaus Jensen
On Oct 19 11:17, Dmitry Fomichev wrote: > diff --git a/hw/block/nvme-ns.h b/hw/block/nvme-ns.h > index d6b2808b97..170cbb8cdc 100644 > --- a/hw/block/nvme-ns.h > +++ b/hw/block/nvme-ns.h > @@ -34,6 +45,18 @@ typedef struct NvmeNamespace { > const uint32_t *iocs; > uint8_t csi; > >

Re: [PATCH 1/1] 9pfs: suppress performance warnings on qtest runs

2020-10-19 Thread Greg Kurz
On Mon, 19 Oct 2020 14:12:46 +0200 Christian Schoenebeck wrote: > On Montag, 19. Oktober 2020 13:48:22 CEST Greg Kurz wrote: > > On Mon, 19 Oct 2020 13:10:18 +0200 > > > > Christian Schoenebeck wrote: > > > Don't trigger any performance warning if we're just running test cases, > > > because te

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

2020-10-19 Thread Zhenyu Ye
Hi Stefan, On 2020/10/13 18:00, Stefan Hajnoczi wrote: > > Sorry, I lost track of this on-going email thread. > > Thanks for the backtrace. It shows the io_submit call is done while the > AioContext lock is held. The monitor thread is waiting for the > IOThread's AioContext lock. vcpus threads c

Re: io: Don't use '#' flag of printf format

2020-10-19 Thread Philippe Mathieu-Daudé
On 10/19/20 2:12 PM, AlexChen wrote: Signed-off-by: AlexChen --- io/channel-websock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/io/channel-websock.c b/io/channel-websock.c index 47a0e941d9..e94a1fcf99 100644 --- a/io/channel-websock.c +++ b/io/channel-websock.c @@ -7

[PULL v3 0/6] 9p queue (previous 2020-10-17)

2020-10-19 Thread Christian Schoenebeck
The following changes since commit ba2a9a9e6318bfd93a2306dec40137e198205b86: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-macppc-20201019' into staging (2020-10-19 11:46:03 +0100) are available in the Git repository at: https://github.com/cschoenebeck/qemu.git ta

[PULL v3 2/6] tests/9pfs: change qtest name prefix to synth

2020-10-19 Thread Christian Schoenebeck
All existing 9pfs test cases are using the 'synth' fs driver so far, which means they are not accessing real files, but a purely simulated (in RAM only) file system. Let's make this clear by changing the prefix of the individual qtest case names from 'fs/' to 'synth/'. That way they'll be easily d

[PULL v3 1/6] 9pfs: suppress performance warnings on qtest runs

2020-10-19 Thread Christian Schoenebeck
Don't trigger any performance warning if we're just running test cases, because tests intentionally run for edge cases. So far performance warnings were suppressed for the 'synth' fs driver backend only. This patch suppresses them for all 9p fs driver backends. Signed-off-by: Christian Schoenebec

[PULL v3 6/6] tests/9pfs: add local Tmkdir test

2020-10-19 Thread Christian Schoenebeck
This test case uses the 9pfs 'local' driver to create a directory and then checks if the expected directory was actually created (as real directory) on host side. This patch introduces a custom split() implementation, because the test code requires non empty array elements as result. For that reas

[Bug 1900352] Re: no sound in spice when VNC enabled

2020-10-19 Thread Gerd Hoffmann
What is in the libvirt logs (/var/log/libvirt/qemu/${guest}.log) ? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1900352 Title: no sound in spice when VNC enabled Status in QEMU: New Bug descri

[PULL v3 3/6] tests/9pfs: introduce local tests

2020-10-19 Thread Christian Schoenebeck
This patch introduces 9pfs test cases using the 9pfs 'local' filesystem driver which reads/writes/creates/deletes real files and directories. In this initial version, there is only one local test which actually only checks if the 9pfs 'local' device was created successfully. Before the 9pfs 'loca

Re: [PATCH v4 0/3] unbreak non-tcg builds

2020-10-19 Thread Paolo Bonzini
On 19/10/20 12:11, Claudio Fontana wrote: > Hi all, > > anything more for me to do here? I think nothing, I picked up patch 1 due to conflicts but I was waiting for comments from Richard. I have now picked them up. Paolo > On 10/13/20 9:21 PM, Claudio Fontana wrote: >> This series now unbreaks

[PULL v3 4/6] tests/9pfs: wipe local 9pfs test directory

2020-10-19 Thread Christian Schoenebeck
Before running the first 9pfs test case, make sure the test directory for running the 9pfs 'local' tests on is entirely empty. For that reason simply delete the test directory (if any) before (re)creating it on test suite startup. Note: The preferable precise behaviour would be the test directory

Re: [PATCH v3 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

2020-10-19 Thread Kevin Wolf
Am 16.10.2020 um 19:10 hat Vladimir Sementsov-Ogievskiy geschrieben: > qcow2_do_open correctly sets errp on each failure path. So, we can > simplify code in qcow2_co_invalidate_cache() and drop explicit error > propagation. qcow2_update_options_prepare() can return -EINVAL without setting errp:

[PULL v3 5/6] tests/9pfs: add virtio_9p_test_path()

2020-10-19 Thread Christian Schoenebeck
This new public function virtio_9p_test_path() allows 9pfs 'local' tests to translate a path from guest scope to host scope. For instance by passing an empty string it would return the root path on host of the exported 9pfs tree. Signed-off-by: Christian Schoenebeck Message-Id: Signed-off-by: C

[Bug 1900352] Re: no sound in spice when VNC enabled

2020-10-19 Thread Daniel Berrange
If VNC is enabled, then libvirt sets QEMU_AUDIO_DRV=none unless /etc/libvirt/qemu.conf is set to allow output to host audio. Clearly this doesn't do the right thing when SPICE is present at the same time as VNC, but that's libvirt's fault rather than QEMU. -- You received this bug notification b

Re: [PATCH v1 0/2] Add timeout mechanism to qmp actions

2020-10-19 Thread Paolo Bonzini
On 19/10/20 14:40, Zhenyu Ye wrote: > The kernel backtrace for io_submit in GUEST is: > > guest# ./offcputime -K -p `pgrep -nx fio` > b'finish_task_switch' > b'__schedule' > b'schedule' > b'io_schedule' > b'blk_mq_get_tag' > b'blk_m

Re: [PATCH] configure: Test that gio libs from pkg-config work

2020-10-19 Thread Paolo Bonzini
On 19/10/20 13:16, Peter Maydell wrote: > On Mon, 28 Sep 2020 at 17:42, Paolo Bonzini wrote: >> >> On 28/09/20 18:04, Peter Maydell wrote: >>> I wanted a statically-linked system emulation binary (which, yes, >>> I know is not really something we support :-)). I got one with >>> suitably liberal u

[PATCH] vhost-user-gpu: incorrect print type

2020-10-19 Thread Zhengui li
fix incorrect print type. --- contrib/vhost-user-gpu/vhost-user-gpu.c | 34 - 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/contrib/vhost-user-gpu/vhost-user-gpu.c b/contrib/vhost-user-gpu/vhost-user-gpu.c index a019d0a..ee2bf59 100644 --- a/contr

[PATCH] vhost-user: fix incorrect print type

2020-10-19 Thread Zhengui li
fix incorrect print type. --- hw/virtio/vhost-user.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 9c5b4f7..db563bd 100644 --- a/hw/virtio/vhost-user.c +++ b/hw/virtio/vhost-user.c @@ -308,7 +308,7 @@ static int

[PATCH] vhost-user-scsi: fix incorrect print type

2020-10-19 Thread Zhengui li
fix incorrect print type. --- contrib/vhost-user-scsi/vhost-user-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c b/contrib/vhost-user-scsi/vhost-user-scsi.c index 3c91238..1527ffd 100644 --- a/contrib/vhost-user-scsi/vhost-user-

[PATCH] virtio-iommu: fix incorrect print type

2020-10-19 Thread Zhengui li
fix incorrect print type. --- hw/virtio/virtio-iommu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index 21ec63b..bd6ce44 100644 --- a/hw/virtio/virtio-iommu.c +++ b/hw/virtio/virtio-iommu.c @@ -632,7 +632,7 @@ stati

[PATCH] virtio-gpu: fix incorrect print type

2020-10-19 Thread Zhengui li
fix incorrect print type. --- hw/display/virtio-gpu.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index 90be4e3..d785d88 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @

[PATCH] vfio: fix incorrect print type

2020-10-19 Thread Zhengui li
fix incorrect print type. --- hw/vfio/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 13471ae..acc3356 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -203,7 +203,7 @@ void vfio_region_write(void *opaque, hwaddr add

Re: [PATCH] vhost-user-gpu: incorrect print type

2020-10-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1603114196-22776-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1603114196-22776-1-git-send-email-lizhen...@huawei.com Subject: [PATCH] vhost

Re: [PATCH] vhost-user: fix incorrect print type

2020-10-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1603114272-25004-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1603114272-25004-1-git-send-email-lizhen...@huawei.com Subject: [PATCH] vhost

Re: [PATCH] vhost-user-scsi: fix incorrect print type

2020-10-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1603114225-22628-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1603114225-22628-1-git-send-email-lizhen...@huawei.com Subject: [PATCH] vhost

Re: [PULL 0/3] Usb 20201019 patches

2020-10-19 Thread Peter Maydell
available in the Git repository at: > > git://git.kraxel.org/qemu tags/usb-20201019-pull-request > > for you to fetch changes up to bea2a9e3e00b275dc40cfa09c760c715b8753e03: > > hw/usb/hcd-dwc2: fix divide-by-zero in d

Re: [PATCH] virtio-gpu: fix incorrect print type

2020-10-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1603114292-10332-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1603114292-10332-1-git-send-email-lizhen...@huawei.com Subject: [PATCH] virti

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Andrew Jones
On Mon, Oct 19, 2020 at 12:43:33PM +0100, Peter Maydell wrote: > On Mon, 19 Oct 2020 at 12:32, Dave Martin wrote: > > I'm not quite sure about Peter's assessment here. > > > > I agree with the inconsistency identified here: we always enumerate all > > unallocated ID regs, but we enumerate ID_AA64Z

Re: [PATCH] virtio-iommu: fix incorrect print type

2020-10-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1603114311-7392-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1603114311-7392-1-git-send-email-lizhen...@huawei.com Subject: [PATCH] virtio-

Re: [PATCH] vfio: fix incorrect print type

2020-10-19 Thread no-reply
Patchew URL: https://patchew.org/QEMU/1603114337-28056-1-git-send-email-lizhen...@huawei.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1603114337-28056-1-git-send-email-lizhen...@huawei.com Subject: [PATCH] vfio:

Re: [PATCH] vfio: fix incorrect print type

2020-10-19 Thread Alex Williamson
On Mon, 19 Oct 2020 13:32:17 + Zhengui li wrote: > fix incorrect print type. Why is it incorrect, describe your change. Patches must include a Signed-off-by to adhere to the developer's certificate of origin. Thanks, Alex > --- > hw/vfio/common.c | 4 ++-- > 1 file changed, 2 insertions(

Re: [PATCH] target/i386: Support up to 32768 CPUs without IRQ remapping

2020-10-19 Thread Paolo Bonzini
On 19/10/20 14:21, David Woodhouse wrote: > On Thu, 2020-10-08 at 09:53 +0200, Paolo Bonzini wrote: >> I think you're not >> handling that correctly for CPUs >255, so after all we _do_ need some >> kernel support. > > I think that works out OK. > > In QEMU's ioapic_update_kvm_routes() it calls io

Re: [PATCH 8/30] powerpc tcg: Fix Lesser GPL version number

2020-10-19 Thread Chetan
Hello, On Mon, Oct 19, 2020 at 4:13 PM Daniel P. Berrangé wrote: >This subject line says 8/30, but I've never received patches >9->30, and I don't see them in the mailing list archive >either... I'm working on the rest of the patches and will be pushing them before the end of this week. Please

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-19 Thread Markus Armbruster
BALATON Zoltan via writes: > On Mon, 19 Oct 2020, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >>> On 10/12/20 1:50 PM, BALATON Zoltan via wrote: On Mon, 12 Oct 2020, David Gibson wrote: > On Mon, Oct 12, 2020 at 08:21:41AM +0200, Philippe > Mathieu-Daudé wrote:

[Bug 1414466] Re: -net user, hostfwd=... is not working(qemu-system-aarch64)

2020-10-19 Thread srinivasan magudeeswaran
Is this issue resolved.? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1414466 Title: -net user,hostfwd=... is not working(qemu-system-aarch64) Status in QEMU: Confirmed Bug description: QEMU

Re: Kernel patch cases qemu live migration failed.

2020-10-19 Thread Peter Maydell
On Mon, 19 Oct 2020 at 14:40, Andrew Jones wrote: > > On Mon, Oct 19, 2020 at 12:43:33PM +0100, Peter Maydell wrote: > > Well, ID regs are special in the architecture -- they always exist > > and must RAZ/WI, even if they're not actually given any fields yet. > > This is different from other "unus

[PATCH] vhost-user-gpu: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- contrib/vhost-user-gpu/vhost-user-gpu.c | 34 - 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/contrib/vhost-user-

[PATCH] vhost-user-scsi: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- contrib/vhost-user-scsi/vhost-user-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/vhost-user-scsi/vhost-user-scsi.c b/contrib/

[PATCH] virtio-gpu: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- hw/display/virtio-gpu.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/display

[PATCH] vhost-user: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- hw/virtio/vhost-user.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index 9c5b4f7

[PATCH] vfio: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- hw/vfio/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 13471ae..acc3356 100644 --- a/hw

[PATCH] virtio-iommu: fix incorrect print type

2020-10-19 Thread Zhengui li
The type of input variable is unsigned int while the printer type is int. So fix incorrect print type. Signed-off-by: Zhengui li --- hw/virtio/virtio-iommu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c index 21ec63

Re: [PATCH v3 0/3] target/arm: Implement an IMPDEF pauth algorithm

2020-10-19 Thread Mark Rutland
Hi Richard, Thanks again for this, and sorry for the radiosilence -- I broke my arm the weekend this was sent, and once I had recovered enough to use a computer again this had slipped off my TODO list. I've just given this a go, applied atop of this morning's HEAD commit (ba2a9a9e6318bfd93a2306de

Re: [PATCH] microbit_i2c: Fix coredump when dump-vmstate

2020-10-19 Thread Peng Liang
On 10/19/2020 6:35 PM, Philippe Mathieu-Daudé wrote: > On 10/19/20 11:34 AM, Peng Liang wrote: >> VMStateDescription.fields should be end with VMSTATE_END_OF_LIST(). >> However, microbit_i2c_vmstate doesn't follow it.  Let's change it. > > It might be easy to add a Coccinelle script to avoid futur

[Bug 1900155] Re: MIPS Malta fails booting due to IDE error

2020-10-19 Thread John Snow
Yup. Mark Cave-Ayland pointed this out to me. I have a patch ready for it: diff --git a/hw/ide/core.c b/hw/ide/core.c index 693b352d5e..98cea7ad45 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2254,10 +2254,8 @@ static void ide_perform_srst(IDEState *s) /* Cancel PIO callback, reset reg

[PATCH 1/2] travis: Check if docs can be built with multiple Sphinx versions

2020-10-19 Thread Eduardo Habkost
Add new jobs to .travis.yml to test if docs can be built with multiple Sphinx versions: 1.6.1, latest 1.x, 2.0.0, and latest 2.x. Signed-off-by: Eduardo Habkost --- .travis.yml | 37 + 1 file changed, 37 insertions(+) diff --git a/.travis.yml b/.travis.yml in

Re: [PULL 00/34] QAPI patches patches for 2020-10-10

2020-10-19 Thread John Snow
On 10/18/20 3:29 AM, Philippe Mathieu-Daudé wrote: On 10/10/20 11:54 AM, Markus Armbruster wrote: The following changes since commit 4a7c0bd9dcb08798c6f82e55b5a3423f7ee669f1:    Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.2-20201009' into staging (2020-10-09 15:48:04 +0100)

[PATCH 0/2] gitlab: minor fixes for checkpatch CI job

2020-10-19 Thread Daniel P . Berrangé
This fixes a bogus error when pushing a branch whose content has no delta against upstream git master. Daniel P. Berrangé (2): gitlab: skip checkpatch.pl checks if no commit delta on branch scripts: fix error from checkpatch.pl when no commits are found .gitlab-ci.d/check-patch.py | 8 ++

[PATCH 2/2] travis: Remove docs from "tools and docs" job

2020-10-19 Thread Eduardo Habkost
We have other jobs that will test documentation builds, so we don't need to build docs in that job. Signed-off-by: Eduardo Habkost --- .travis.yml | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index f5208301d6..626b61b077 100644 --- a/.travi

[PATCH 1/2] gitlab: skip checkpatch.pl checks if no commit delta on branch

2020-10-19 Thread Daniel P . Berrangé
If the current branch is synced to the current upstream git master, there are no commits that need checking. This causes checkpatch.pl to print an error that it found no commits. We need to avoid calling checkpatch.pl in this case. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/check-patch.p

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-19 Thread Mark Cave-Ayland
On 19/10/2020 15:00, Markus Armbruster wrote: BALATON Zoltan via writes: On Mon, 19 Oct 2020, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 10/12/20 1:50 PM, BALATON Zoltan via wrote: On Mon, 12 Oct 2020, David Gibson wrote: On Mon, Oct 12, 2020 at 08:21:41AM +0200, Philippe

[PATCH 2/2] scripts: fix error from checkpatch.pl when no commits are found

2020-10-19 Thread Daniel P . Berrangé
The error message was supposed to mention the input revision list start point, not the branch flag. Signed-off-by: Daniel P. Berrangé --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 6ed34970f9..88c8

Re: [PATCH 1/2] travis: Check if docs can be built with multiple Sphinx versions

2020-10-19 Thread Daniel P . Berrangé
On Mon, Oct 19, 2020 at 10:31:08AM -0400, Eduardo Habkost wrote: > Add new jobs to .travis.yml to test if docs can be built with > multiple Sphinx versions: 1.6.1, latest 1.x, 2.0.0, and latest > 2.x. > > Signed-off-by: Eduardo Habkost > --- > .travis.yml | 37 +++

Re: [PATCH 1/30] cryptodev: Fix Lesser GPL version number

2020-10-19 Thread Thomas Huth
On 14/10/2020 15.37, Chetan Pant wrote: > There is no "version 2" of the "Lesser" General Public License. > It is either "GPL version 2.0" or "Lesser GPL version 2.1". > This patch replaces all occurrences of "Lesser GPL version 2" with > "Lesser GPL version 2.1" in comment section. > > Signed-off

Re: [PATCH] hw/arm/nseries: Fix loading kernel image on n8x0 machines

2020-10-19 Thread Richard Henderson
On 10/19/20 2:51 AM, Philippe Mathieu-Daudé wrote: > Commit 7998beb9c2e removed the ram_size initialization in the > arm_boot_info structure, however it is used by arm_load_kernel(). > > Initialize the field to fix: > > $ qemu-system-arm -M n800 -append 'console=ttyS1' \ > -kernel meego-arm

[PATCH] x86/kvm: Reserve KVM_FEATURE_MSI_EXT_DEST_ID

2020-10-19 Thread David Woodhouse
From: David Woodhouse No functional change; just reserve the feature bit for now so that VMMs can start to implement it. This will allow the host to indicate that MSI emulation supports 15-bit destination IDs, allowing up to 32768 CPUs without interrupt remapping. cf. https://patchwork.kernel.o

Re: [PATCH v5] sev: add sev-inject-launch-secret

2020-10-19 Thread Eduardo Habkost
On Thu, Oct 15, 2020 at 10:37:13AM -0400, to...@linux.ibm.com wrote: > From: Tobin Feldman-Fitzthum > > AMD SEV allows a guest owner to inject a secret blob > into the memory of a virtual machine. The secret is > encrypted with the SEV Transport Encryption Key and > integrity is guaranteed with t

Re: [PULL v3 0/6] 9p queue (previous 2020-10-17)

2020-10-19 Thread Peter Maydell
On Mon, 19 Oct 2020 at 13:55, Christian Schoenebeck wrote: > > The following changes since commit ba2a9a9e6318bfd93a2306dec40137e198205b86: > > Merge remote-tracking branch 'remotes/mcayland/tags/qemu-macppc-20201019' > into staging (2020-10-19 11:46:03 +0100) >

Re: [PATCH] drivers/virt: vmgenid: add vm generation id driver

2020-10-19 Thread Michael S. Tsirkin
On Sun, Oct 18, 2020 at 09:14:00AM -0700, Andy Lutomirski wrote: > On Sun, Oct 18, 2020 at 8:59 AM Michael S. Tsirkin wrote: > > > > On Sun, Oct 18, 2020 at 08:54:36AM -0700, Andy Lutomirski wrote: > > > On Sun, Oct 18, 2020 at 8:52 AM Michael S. Tsirkin > > > wrote: > > > > > > > > On Sat, Oct

<    1   2   3   4   5   >