On 10/30/20 1:40 AM, Chen Qun wrote:
> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
> target/ppc/mmu_helper.c: In function ‘dump_mmu’:
> target/ppc/mmu_helper.c:1351:12: warning: this statement may fall through
> [-Wimplicit-fallthrough=]
> 1351 | if
On Oct 27 18:57, Klaus Jensen wrote:
> From: Klaus Jensen
>
> This adds support for the Deallocated or Unwritten Logical Block error
> recovery feature as well as the Dataset Management command.
>
> v7:
> - Handle negative return value from bdrv_block_status.
> - bdrv_get_info may not be
On Fri, Oct 30, 2020 at 11:29 AM Marc-André Lureau <
marcandre.lur...@gmail.com> wrote:
>
>
> On Fri, Oct 30, 2020 at 2:07 AM Eduardo Habkost
> wrote:
>
>> Make the code more generic and not specific to TYPE_DEVICE.
>>
>> Signed-off-by: Eduardo Habkost
>>
>
> Nice cleanup!, but fails to build
On Fri, Oct 30, 2020 at 2:07 AM Eduardo Habkost wrote:
> sparc_set_nwindows() is one of the very few property setters that
> don't check dev->realized, and there's no reason for it to be
> special. Check dev->realized like the other setters.
>
> Signed-off-by: Eduardo Habkost
>
Reviewed-by:
On Fri, Oct 30, 2020 at 2:09 AM Eduardo Habkost wrote:
> Make the code more generic and not specific to TYPE_DEVICE.
>
> Signed-off-by: Eduardo Habkost
>
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
> From: Stefan Hajnoczi
> Sent: Friday, October 30, 2020 3:51 PM
>
> Hi,
> The "Scalable Work Submission in Device Virtualization" talk at KVM
> Forum 2020 was interesting and I have some beginner questions about
> ENQCMD:
> https://static.sched.com/hosted_files/kvmforum2020/22/Scalable_Work_Su
Coverity wants the return value of mkdir() to be checked, so let's
pretend to do that. We're actually just making a dummy check and
ignore the result, because we actually only care if the required
directory exists and we have an existence check for that in place
already.
Reported-by: Greg Kurz
On Mon, Sep 21, 2020 at 06:10:26PM -0400, Eduardo Habkost wrote:
> Class properties make QOM introspection simpler and easier, as
> they don't require an object to be instantiated.
>
> Signed-off-by: Eduardo Habkost
Reviewed-by: Michael S. Tsirkin
> ---
> Cc: "Michael S. Tsirkin"
> Cc:
On Thu, Oct 29, 2020 at 06:17:37PM +0100, Max Reitz wrote:
> RFC: https://www.redhat.com/archives/virtio-fs/2020-May/msg00024.html
> v1: https://lists.nongnu.org/archive/html/qemu-devel/2020-09/msg03598.html
>
> Branch: https://github.com/XanClic/qemu.git virtiofs-submounts-v3
> Branch:
On Fri, Oct 30, 2020 at 12:02:18PM +0800, Antti Antinoja wrote:
> Hi All,
>
> I couldn't find any mention about live migration incompatibility between 5.0
> and 5.1 in the release notes but at least on our AMD based platform live
> migration from 5.0 to 5.1 is not possible.
>
> The upgraded
Eric Blake writes:
> On 10/29/20 8:38 AM, Markus Armbruster wrote:
>> The abstract sockets test spawns a thread to listen and a accept, and
>
> s/and a/and/
Yes.
>> a second one to connect, with a sleep(1) in between to "ensure" the
>> former is listening when the latter tries to connect.
On Fri, Oct 30, 2020 at 2:06 AM Eduardo Habkost wrote:
> This setter is one of the very few property setters that don't
> check dev->realized, and there's no reason to make size
> properties different from the rest. Add the missing check.
>
> Fixes: e8cd45c78f53 ("qdev: Add SIZE type to qdev
Sigh, I should have caught some of these in the last review, sorry.
For the series,
Reviewed-by: Darren Kenny
Thanks,
Darren.
On Thursday, 2020-10-29 at 13:28:57 -04, Alexander Bulekov wrote:
> These patches fix some silly issues I found after the generic-fuzzer
> started running on
On Fri, Oct 30, 2020 at 2:16 AM Eduardo Habkost wrote:
> Make the code more generic and not specific to TYPE_DEVICE.
>
> Signed-off-by: Eduardo Habkost
>
What about dropping _qdev from the function name too?
Also, I am not sure it's a well designed function.. I would rather have 3
different
On Mon, Sep 28, 2020 at 09:17:31PM +0800, Jiajun Chen wrote:
> Used_memslots is equal to dev->mem->nregions now, it is true for
> vhost kernel, but not for vhost user, which uses the memory regions
> that have file descriptor. In fact, not all of the memory regions
> have file descriptor.
> It is
Eric Blake writes:
> On 10/29/20 8:38 AM, Markus Armbruster wrote:
>> Commit 776b97d360 "qemu-sockets: add abstract UNIX domain socket
>> support" neglected to update socket_sockaddr_to_address_unix(). The
>> function returns a non-abstract socket address for abstract
>> sockets (wrong) with a
On Thu, Oct 29, 2020 at 02:38:28PM +0100, Markus Armbruster wrote:
> The test covers only two out of nine combinations. Test all nine.
> Four turn out to be broken. Marked /* BUG */.
>
> Signed-off-by: Markus Armbruster
> ---
> tests/test-util-sockets.c | 86
On 2020/10/30 下午2:21, Stefan Hajnoczi wrote:
On Fri, Oct 30, 2020 at 3:04 AM Alex Williamson
wrote:
It's great to revisit ideas, but proclaiming a uAPI is bad solely
because the data transfer is opaque, without defining why that's bad,
evaluating the feasibility and implementation of
Paolo Bonzini writes:
> On 29/10/20 18:39, Paolo Bonzini wrote:
>>> When @tight was set to false as it should be, absent @tight defaults
>>> to false. Wrong, it should default to true. This is what breaks QMP.
>> When @has_tight...
>
> Ah, I see what you meant here. Suggested reword:
>
>
Hi,
The "Scalable Work Submission in Device Virtualization" talk at KVM
Forum 2020 was interesting and I have some beginner questions about
ENQCMD:
https://static.sched.com/hosted_files/kvmforum2020/22/Scalable_Work_Submission_In_Device_Virtualization.pdf
Security
If the ENQCMD
On Fri, Oct 30, 2020 at 2:14 AM Eduardo Habkost wrote:
> Make the code more generic and not specific to TYPE_DEVICE.
>
> Signed-off-by: Eduardo Habkost
>
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
This patch adds some gen_io_start() calls to allow execution
of s390x targets in icount mode with -smp 1.
It enables deterministic timers and record/replay features.
Signed-off-by: Pavel Dovgalyuk
---
0 files changed
diff --git a/target/s390x/translate.c b/target/s390x/translate.c
index
On Mon, Oct 26, 2020 at 02:21:26PM +0800, Cindy Lu wrote:
> Sometime vdpa get an all 0 mac address from the hardware, this will cause the
> traffic down
> So we add the check for this part.
> if we get an 0 mac address we will use the default mac address instead
>
> Signed-off-by: Cindy Lu
>
Eric Blake writes:
> On 10/29/20 8:38 AM, Markus Armbruster wrote:
>> The abstract socket namespace is a non-portable Linux extension. An
>> attempt to use it elsewhere should fail with ENOENT (the abstract
>> address looks like a "" pathname, which does not resolve). We report
>> this failure
Hi
On Fri, Oct 30, 2020 at 2:19 AM Eduardo Habkost wrote:
> qdev_class_add_property() and qdev_property_add_static() will
> have code that's specific for device types.
>
> object_class_property_add_static(),
> object_class_add_static_props(), and object_property_add_static()
> will be generic
On 10/30/20 1:40 AM, Chen Qun wrote:
> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
> target/sparc/win_helper.c: In function ‘get_gregset’:
> target/sparc/win_helper.c:304:9: warning: this statement may fall through
> [-Wimplicit-fallthrough=]
> 304 |
Eric Blake writes:
> On 10/29/20 8:38 AM, Markus Armbruster wrote:
>> QMP chardev-add defaults absent member @tight to false instead of
>> true. HMP chardev-add and CLI -chardev correctly default to true.
>>
>> The previous commit demonstrated that socket_listen() and
>> socket_connect() are
Hi Dmitry,
On 10/30/20 3:32 AM, Dmitry Fomichev wrote:
> The emulation code has been changed to advertise NVM Command Set when
> "zoned" device property is not set (default) and Zoned Namespace
> Command Set otherwise.
>
> Define values and structures that are needed to support Zoned
> Namespace
On Fri, Oct 30, 2020 at 2:05 AM Eduardo Habkost wrote:
> An empty props array is unnecessary, we can just not call
> device_class_set_props().
>
> Signed-off-by: Eduardo Habkost
>
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
On Fri, Oct 30, 2020 at 2:05 AM Eduardo Habkost wrote:
> Move everything related to Property and PropertyInfo to
> qdev-properties.[ch] to make it easier to refactor that code.
>
> Signed-off-by: Eduardo Habkost
>
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
On Fri, Oct 30, 2020 at 2:07 AM Eduardo Habkost wrote:
> There's no reason to keep the property list separate from the CPU
> class code. Move the variable to hw/core/cpu.c and make it
> static.
>
> Signed-off-by: Eduardo Habkost
>
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
Paolo Bonzini writes:
> On 29/10/20 14:38, Markus Armbruster wrote:
>> +/* Linux abstract socket */
>> +addr->u.q_unix.path = g_strndup(su->sun_path + 1,
>> +sizeof(su->sun_path) - 1);
>> +addr->u.q_unix.has_abstract = true;
>> +
On Mon, Oct 26, 2020 at 02:21:26PM +0800, Cindy Lu wrote:
> Sometime vdpa get an all 0 mac address from the hardware, this will cause the
> traffic down
> So we add the check for this part.
> if we get an 0 mac address we will use the default mac address instead
>
> Signed-off-by: Cindy Lu
I
On Mon, Sep 21, 2020 at 06:10:43PM -0400, Eduardo Habkost wrote:
> Class properties make QOM introspection simpler and easier, as
> they don't require an object to be instantiated.
>
> Signed-off-by: Eduardo Habkost
Reviewed-by: Michael S. Tsirkin
> ---
> Cc: "Michael S. Tsirkin"
> Cc:
On Thu, Oct 29, 2020 at 12:01:27PM -0400, John Snow wrote:
> In experimenting with my mirror on gitlab though, I was unable to find a way
> to configure it to send issue tracker notifications to the email list. A
> move to gitlab would likely mean, then:
>
> 1. The cessation of (automatic) issue
Looking at the way the code is formatted here (there is an empty
line after break statements, but none where the break is missing),
the fallthrough is very likely intended here. So add a fallthrough
comment to make the it compilable with -Werror=implicit-fallthrough.
Signed-off-by: Thomas Huth
On 2020/10/30 上午11:04, Alex Williamson wrote:
On Fri, 30 Oct 2020 09:11:23 +0800
Jason Wang wrote:
On 2020/10/29 下午11:46, Alex Williamson wrote:
On Thu, 29 Oct 2020 23:09:33 +0800
Jason Wang wrote:
On 2020/10/29 下午10:31, Alex Williamson wrote:
On Thu, 29 Oct 2020 21:02:05 +0800
Jason
On Fri, Oct 30, 2020 at 2:13 AM Eduardo Habkost wrote:
> Support Property.set_default and PropertyInfo.description even if
> PropertyInfo.create is set.
>
> Signed-off-by: Eduardo Habkost
> ---
> Cc: Paolo Bonzini
> Cc: "Daniel P. Berrangé"
> Cc: Eduardo Habkost
> Cc: qemu-devel@nongnu.org
>
On Fri, Oct 30, 2020 at 2:05 AM Eduardo Habkost wrote:
> All other qdev property error messages use "."
> instead of ".". Change set_size32() for consistency,
> and to make the code not specific to TYPE_DEVICE.
>
> Signed-off-by: Eduardo Habkost
>
Reviewed-by: Marc-André Lureau
--
On Fri, Oct 30, 2020 at 8:58 AM Xinhao Zhang wrote:
>
> Fix code style. Space required before the open parenthesis '('.
>
> Signed-off-by: Xinhao Zhang
> Signed-off-by: Kai Deng
> Reported-by: Euler Robot
> ---
> target/riscv/csr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
On Thu, Oct 29, 2020 at 02:38:25PM +0100, Markus Armbruster wrote:
> The thread functions build the SocketAddress from global variable
> @abstract_sock_name and the tight flag passed as pointer
> argument (either NULL or (gpointer)1). There is no need for such
> hackery; simply pass the
On 10/29/20 8:57 PM, Richard Henderson wrote:
> On 10/28/20 12:22 PM, Philippe Mathieu-Daudé wrote:
>> +g_autofree void *dtb;
>>
>> dtb = load_device_tree(dtb_filename, _size);
>
> With g_autofree, we must initialize the variable on declaration. Often this
> is
> with
> A migration compatibility interface has not been determined for vfio.
> We currently rely on the vendor drivers to provide their own internal
> validation and harmlessly reject migration from an incompatible device.
> It would be great if we could make progress on this, but it's a
> difficult
On Fri, Oct 30, 2020 at 2:11 AM Eduardo Habkost wrote:
> We'll add extra code to the qdev property getters and setters, so
> add wrapper functions where additional actions can be performed.
>
> The new functions have a "static_prop_" prefix instead of "qdev_"
> because the code will eventually
On Fri, Oct 30, 2020 at 2:10 AM Eduardo Habkost wrote:
> Every single qdev property setter function manually checks
> dev->realized. We can just check dev->realized inside
> qdev_property_set() instead.
>
> The check is being added as a separate function
> (qdev_prop_allow_set()) because it
On Fri, Oct 30, 2020 at 4:55 PM Michael S. Tsirkin wrote:
>
> On Mon, Oct 26, 2020 at 02:21:26PM +0800, Cindy Lu wrote:
> > Sometime vdpa get an all 0 mac address from the hardware, this will cause
> > the traffic down
> > So we add the check for this part.
> > if we get an 0 mac address we will
Eric Blake writes:
> On 10/29/20 8:38 AM, Markus Armbruster wrote:
>> Commit 776b97d360 "qemu-sockets: add abstract UNIX domain socket
>> support" neglected to update qemu_chr_socket_address(). It shows
>> shows neither @abstract nor @tight. Fix that.
>>
>> Signed-off-by: Markus Armbruster
On Thu, Oct 29, 2020 at 04:25:41PM +0800, Bin Meng wrote:
> From: Bin Meng
>
> At present the virtio device config space access is handled by the
> virtio_config_readX() and virtio_config_writeX() APIs. They perform
> a sanity check on the result of address plus size against the config
> space
Le 30/10/2020 à 01:40, Chen Qun a écrit :
> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
> linux-user/mips/cpu_loop.c: In function ‘cpu_loop’:
> linux-user/mips/cpu_loop.c:104:24: warning: this statement may fall through
> [-Wimplicit-fallthrough=]
> 104 |
On Fri, Oct 30, 2020 at 3:04 AM Alex Williamson
wrote:
> It's great to revisit ideas, but proclaiming a uAPI is bad solely
> because the data transfer is opaque, without defining why that's bad,
> evaluating the feasibility and implementation of defining a well
> specified data format rather than
BlockDeviceMapEntry has never been used. It was added in commit
facd6e2 "so that it is published through the introspection mechanism."
What exactly introspecting types that aren't used for anything could
accomplish isn't clear. What "introspection mechanism" to use is also
nebulous. To the best
On 10/30/20 1:40 AM, Chen Qun wrote:
> When using -Wimplicit-fallthrough in our CFLAGS, the compiler showed warning:
> ../accel/tcg/user-exec.c: In function ‘handle_cpu_signal’:
> ../accel/tcg/user-exec.c:169:13: warning: this statement may fall through
> [-Wimplicit-fallthrough=]
> 169 |
On Fri, Oct 30, 2020 at 2:07 AM Eduardo Habkost wrote:
> Make the code more generic and not specific to TYPE_DEVICE.
>
> Signed-off-by: Eduardo Habkost
>
Nice cleanup!, but fails to build atm
../hw/block/xen-block.c:403:9: error: ‘dev’ undeclared (first use in this
function); did you mean
On Fri, Oct 30, 2020 at 2:09 AM Eduardo Habkost wrote:
> Make the code more generic and not specific to TYPE_DEVICE.
>
> Signed-off-by: Eduardo Habkost
>
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
On Fri, Oct 30, 2020 at 2:11 AM Eduardo Habkost wrote:
> Make the code more generic and not specific to TYPE_DEVICE.
>
> Signed-off-by: Eduardo Habkost
>
Reviewed-by: Marc-André Lureau
--
Marc-André Lureau
Fixes two bugs with the 9pfs 'local' tests as discussed with latest 9P PR
(2020-10-23). See the discussion of that PR for details.
Christian Schoenebeck (2):
tests/9pfs: fix test dir for parallel tests
tests/9pfs: fix coverity error in create_local_test_dir()
tests/qtest/libqos/virtio-9p.c
Use mkdtemp() to generate a unique directory for the 9p 'local' tests.
This fixes occasional 9p test failures when running 'make check -jN' if
QEMU was compiled for multiple target architectures, because the individual
architecture's test suites would run in parallel and interfere with each
On Wed, Sep 30, 2020 at 10:32:42AM +0530, P J P wrote:
>
> [+Paolo, +Fam Zheng - for scsi]
>
> +-- On Mon, 28 Sep 2020, P J P wrote --+
> | +-- On Wed, 16 Sep 2020, Peter Maydell wrote --+
> | | On Wed, 16 Sep 2020 at 07:28, P J P wrote:
> | | > ->
>
On 29.10.20 21:46, Eduardo Habkost wrote:
> On Thu, Oct 29, 2020 at 06:17:44PM +0100, Max Reitz wrote:
>> This test invokes several shell scripts to create a random directory
>> tree full of submounts, and then check in the VM whether every submount
>> has its own ID and the structure looks as
On Thu, Oct 29, 2020 at 01:47:02PM -0500, Eric Blake wrote:
> On 10/29/20 11:07 AM, Kevin Wolf wrote:
>
> >>>
> >>> QEMU's interface is differently messy.
> >>>
> >>> Our equivalent to struct sockaddr_un is QAPI type UnixSocketAddress:
> >>>
> >>> { 'struct': 'UnixSocketAddress',
> >>>
On Thu, Oct 29, 2020 at 04:27:44PM -0400, John Snow wrote:
> On 10/29/20 3:55 PM, Thomas Huth wrote:
> > On 29/10/2020 18.12, John Snow wrote:
> > > On 10/29/20 12:49 PM, Alistair Francis wrote:
> > > > On Thu, Oct 29, 2020 at 9:41 AM Cornelia Huck wrote:
> > > > >
> > > > > On Thu, 29 Oct 2020
On Thu, 29 Oct 2020 at 20:38, Eduardo Habkost wrote:
>
> Fix bounds check for idx at freq_to_str(), to actually ensure idx
> never goes beyond the last element of the suffixes array.
>
> Reported-by: Coverity (CID 1435957: OVERRUN)
> Suggested-by: Peter Maydell
Personally I preferred the other
On Fri, Oct 30, 2020 at 2:18 AM Eduardo Habkost wrote:
> We're just doing pointer math with the device pointer, we can
> simply use obj instead.
>
> Signed-off-by: Eduardo Habkost
>
Reviewed-by: Marc-André Lureau
---
> Cc: Paolo Bonzini
> Cc: "Daniel P. Berrangé"
> Cc: Eduardo Habkost
>
Lukas Straub writes:
> On Thu, 29 Oct 2020 17:36:14 +0100
> Markus Armbruster wrote:
>
>> Nothing major, looks almost ready to me.
>>
>> Lukas Straub writes:
>>
>> > The yank feature allows to recover from hanging qemu by "yanking"
>> > at various parts. Other qemu systems can register
On Thu, Oct 29, 2020 at 10:32:53AM +0100, Philippe Mathieu-Daudé wrote:
> Rename Submission Queue flags with 'Sq' to differentiate
> submission queue flags from command queue flags, and introduce
> Completion Queue flag definitions.
>
> Reviewed-by: Eric Auger
> Tested-by: Eric Auger
>
The following changes since commit 802427bcdae1ad2eceea8a8877ecad835e3f8fde:
Merge remote-tracking branch
'remotes/pmaydell/tags/pull-target-arm-20201027-1' into staging (2020-10-29
11:40:04 +)
are available in the Git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git
From: Ben Widawsky
Prevent _CRS resources being quietly chopped off and instead throw an
assertion. _CRS is used by host bridges to declare regions of io and/or
memory that they consume. On some (all?) platforms the host bridge
doesn't have PCI header space and so they need some way to convey
From: Si-Wei Liu
Vendor driver may not support or implement config
interrupt delivery for link status notifications.
In this event, vendor driver is expected to NACK
the feature, but guest will keep link always up.
Signed-off-by: Si-Wei Liu
Message-Id:
From: Philippe Mathieu-Daudé
Fix uninitialized value issues reported by Coverity:
Field 'msg.reserved' is uninitialized when calling write().
Fixes: a5bd05800f8 ("vhost-vdpa: batch updating IOTLB mappings")
Reported-by: Coverity (CID 1432864: UNINIT)
Signed-off-by: Philippe Mathieu-Daudé
From: Ben Widawsky
Prevent future developers working on root complexes, root ports, or
bridges that also wish to implement a BAR for those, from shooting
themselves in the foot. PCI type 1 headers only support 2 base address
registers. It is incorrect and difficult to figure out what is wrong
From: Jason Wang
After Linux kernel commit 61363c1474b1 ("iommu/vt-d: Enable ATS only
if the device uses page aligned address."), ATS will be only enabled
if device advertises a page aligned request.
Unfortunately, vhost-net is the only user and we don't advertise the
aligned request capability
From: Peter Xu
Dave magically found this. Fix them with "0x%x".
Reported-by: Dr. David Alan Gilbert
Signed-off-by: Peter Xu
Message-Id: <20201019173922.100270-1-pet...@redhat.com>
Reviewed-by: Dr. David Alan Gilbert
Reviewed-by: Philippe Mathieu-Daudé
Acked-by: Jason Wang
Reviewed-by:
On Thu, 29 Oct 2020 at 20:25, wrote:
>
> From: Rémi Denis-Courmont
>
> HCR should be applied when NS is set, not when it is cleared.
>
> Signed-off-by: Rémi Denis-Courmont
> ---
> target/arm/helper.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Applied to target-arm.next,
On Fri, 30 Oct 2020 at 10:23, AlexChen wrote:
>
> In exynos4210_fimd_update(), the pointer s is dereferenced before
> being check if it is valid, which may lead to NULL pointer dereference.
> So move the assignment to global_width after checking that the s is valid
>
> Reported-by: Euler Robot
>
On Thu, 29 Oct 2020 at 20:25, wrote:
>
> From: Rémi Denis-Courmont
>
> Secure mode is not exempted from checking SCR_EL3.TLOR, and in the
> future HCR_EL2.TLOR when S-EL2 is enabled.
>
> Signed-off-by: Rémi Denis-Courmont
Applied to target-arm.next, thanks.
-- PMM
On Fri, 30 Oct 2020 at 10:23, AlexChen wrote:
>
> In omap_lcd_interrupts(), the pointer omap_lcd is dereferenced before
> being check if it is valid, which may lead to NULL pointer dereference.
> So move the assignment to surface after checking that the omap_lcd is valid.
>
> Reported-by: Euler
On Tue, 27 Oct 2020 at 14:43, John Snow wrote:
>
> The following changes since commit a95e0396c805735c491a049b01de6f5a713fb91b:
>
> Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream'
> into staging (2020-10-26 15:49:11 +)
>
> are available in the Git repository at:
>
>
From: Greg Kurz
fs_readdir_split() isn't a top level test function and thus shouldn't
take the "void *obj, void *data, QGuestAllocator *t_alloc" arguments.
Turn it into a helper to be used by test functions.
Signed-off-by: Greg Kurz
Message-Id:
From: Greg Kurz
fs_create_dir() is a top level test function. It should set alloc.
Signed-off-by: Greg Kurz
Message-Id: <160321016764.266767.3763279057643874020.st...@bahia.lan>
Signed-off-by: Christian Schoenebeck
---
tests/qtest/virtio-9p-test.c | 1 +
1 file changed, 1 insertion(+)
diff
This test case uses a Tunlinkat 9p request with flag AT_REMOVEDIR
(see 'man 2 unlink') to remove a directory from host's test directory.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
<3c7c65b476ba44bea6afd0b378b5287e1c671a32.1603285620.git.qemu_...@crudebyte.com>
Ping for code review, please ?
thanks
-- PMM
On Thu, 22 Oct 2020 at 17:44, Peter Maydell wrote:
>
> In arm_v7m_mmu_idx_for_secstate() we get the 'priv' level to pass to
> armv7m_mmu_idx_for_secstate_and_priv() by calling arm_current_el().
> This is incorrect when the security state being
This test case uses a Tlcreate 9p request to create a regular file inside
host's test directory.
Signed-off-by: Christian Schoenebeck
Reviewed-by: Greg Kurz
Message-Id:
<269cae0c00af941a3a4ae78f1e319f93462a7eb4.1603285620.git.qemu_...@crudebyte.com>
Signed-off-by: Christian Schoenebeck
---
Use the BIT_ULL() macro to ensure we use 64-bit arithmetic.
This fixes the following Coverity issue (OVERFLOW_BEFORE_WIDEN):
CID 1432363 (#1 of 1): Unintentional integer overflow:
overflow_before_widen:
Potentially overflowing expression 1 << scale with type int
(32 bits, signed) is
Split out walking a directory path to a separate new utility function
do_walk() and use that function in do_mkdir().
The code difference saved this way is not much, but we'll use that new
do_walk() function in the upcoming patches, so it will avoid quite
some code duplication after all.
Since commit 6f5fd837889, vu_init() can fail if malloc() returns NULL.
This fixes the following Coverity warning:
CID 1435958 (#1 of 1): Unchecked return value (CHECKED_RETURN)
Fixes: 6f5fd837889 ("libvhost-user: support many virtqueues")
Signed-off-by: Philippe Mathieu-Daudé
---
On 10/30/20 9:51 AM, Daniel P. Berrangé wrote:
On Fri, Oct 30, 2020 at 09:47:04AM -0400, John Snow wrote:
On 10/30/20 9:38 AM, Peter Maydell wrote:
On Fri, 30 Oct 2020 at 13:32, John Snow wrote:
Is there a script that's public that you use for tagging the QEMU
release? I see make-release in
Hi Pavel,
On Tue, Oct 6, 2020 at 9:41 AM Paolo Bonzini wrote:
>
> From: Pavel Dovgalyuk
>
> This patch adds support of the reverse continue operation for gdbstub.
> Reverse continue finds the last breakpoint that would happen in normal
> execution from the beginning to the current moment.
>
On 29/10/2020 21.14, Alex Bennée wrote:
> Show the targets but keep them separate from the main list.
>
> Signed-off-by: Alex Bennée
> ---
> configure | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 55e07c82dd..6c2e9ff37c 100755
> ---
Make qio_channel_tls_shutdown thread-safe by using atomics when
accessing tioc->shutdown.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Reviewed-by: Daniel P. Berrangé
---
io/channel-tls.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/io/channel-tls.c
Register a yank function to shutdown the socket on yank.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
---
chardev/char-socket.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/chardev/char-socket.c b/chardev/char-socket.c
index
Register yank functions on sockets to shut them down.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Acked-by: Dr. David Alan Gilbert
---
migration/channel.c | 13 +
migration/migration.c | 25 +
migration/multifd.c | 10
On Fri, Oct 30, 2020 at 2:12 AM Eduardo Habkost wrote:
> Note that this doesn't replace the check callback at
> object*_property_add_link() (yet), because currently the link
> property check callback needs to get the property value as
> argument (despite this not being necessary in most cases).
On Fri, Oct 30, 2020 at 2:15 AM Eduardo Habkost wrote:
> This removes the last remaining DeviceState-specific line of code
> inside qdev property registration code, and will allow us to make
> static properties a core QOM feature.
>
> Signed-off-by: Eduardo Habkost
>
Reviewed-by: Marc-André
On Fri, Oct 30, 2020 at 2:17 AM Eduardo Habkost wrote:
> The array property registration code is hard to follow. Move the
> two steps into separate functions that have clear
> responsibilities.
>
> Signed-off-by: Eduardo Habkost
> ---
> Cc: Paolo Bonzini
> Cc: "Daniel P. Berrangé"
> Cc:
On Fri, 30 Oct 2020 at 09:23, Daniel P. Berrangé wrote:
> My convincing strategy is "do nothing" :-)
I am, er, not convinced :-)
> Most importantly we need to be able to make the existing "QEMU" component
> in launch read-only to prevent people filing new bugs there, ideally with
> a change in
MIPSR6 (not only MIPS32R6) processors support unaligned access in
hardware, so set MO_UNALN in their default_tcg_memop_mask. Btw, new
Loongson-3 (such as Loongson-3A4000) also support unaligned access,
since both old and new Loongson-3 use the same binaries, we can simply
set MO_UNALN for all
John Snow writes:
> On 10/29/20 3:55 PM, Thomas Huth wrote:
>> On 29/10/2020 18.12, John Snow wrote:
>>> On 10/29/20 12:49 PM, Alistair Francis wrote:
On Thu, Oct 29, 2020 at 9:41 AM Cornelia Huck wrote:
>
> On Thu, 29 Oct 2020 12:01:27 -0400
> John Snow wrote:
>
>>
On Mon, Oct 19, 2020 at 12:43:29PM +0200, Eugenio Pérez wrote:
> This way we can tell between regular IOMMUTLBEntry (entry of IOMMU
> hardware) and notifications.
>
> In the notifications, we set explicitly if it is a MAPs or an UNMAP,
> instead of trusting in entry permissions to differentiate
On Fri, 2020-10-30 at 05:01 -0400, Michael S. Tsirkin wrote:
> On Wed, Sep 30, 2020 at 10:32:42AM +0530, P J P wrote:
> >
> > [+Paolo, +Fam Zheng - for scsi]
> >
> > +-- On Mon, 28 Sep 2020, P J P wrote --+
> > > +-- On Wed, 16 Sep 2020, Peter Maydell wrote --+
> > > > On Wed, 16 Sep 2020 at
On Fri, 30 Oct 2020 at 10:10, Daniel P. Berrangé wrote:
> This
> makes it more appealing to leave existing bugs in the LP tracker until
> they are resolved, auto-closed, or there is a compelling reason to move
> to gitlab.
The compelling reason is that there is no way that I want to
have to
1 - 100 of 321 matches
Mail list logo
