LGTM, tested and working on iOS.
-j
On Thu, Nov 5, 2020 at 7:29 PM Richard Henderson
wrote:
>
> This is my take on Joelle's patch set:
> https://lists.nongnu.org/archive/html/qemu-devel/2020-10/msg07837.html
>
> Changes for v3:
> * Even more patches -- all tcg backends converted.
> * Fixups
On Thu, Nov 5, 2020 at 7:29 PM Richard Henderson
wrote:
>
> Cribbed from code posted by Joelle van Dyne ,
> and rearranged to a cleaner structure. Completely untested.
>
> Signed-off-by: Richard Henderson
Reviewed-by: Joelle van Dyne
On Sun, Nov 8, 2020 at 1:10 AM Philippe Mathieu-Daudé wrote:
>
> GCC 9.3.0 thinks that 'method' can be left uninitialized. This code
> is already in the "if (bsel || pcihp_bridge_en)" block statement,
> but it isn't smart enough to figure it out.
>
> Restrict the code to be used only in the "if
On 06/11/2020 15.18, Philippe Mathieu-Daudé wrote:
> On 11/6/20 7:33 AM, Markus Armbruster wrote:
>> Thomas Huth writes:
>>
>>> On 05/11/2020 06.14, AlexChen wrote:
On 2020/11/4 18:44, Thomas Huth wrote:
> On 04/11/2020 11.23, AlexChen wrote:
>> We should use printf format specifier
Hi, Philippe,
On Sat, Nov 7, 2020 at 8:11 PM Philippe Mathieu-Daudé wrote:
>
> Hi Huacai,
>
> On 11/6/20 5:21 AM, Huacai Chen wrote:
> > From: Jiaxun Yang
> >
> > Our current code assumed the target page size is always 4k
> > when handling PageMask and VPN2, however, variable page size
> > was
Hi,
Seeing this same thing! And I'm on Ubuntu 20.10, so pretty current :-).
vt82c686b-usb-uhci doesn't seem to be accessible any more, but trying
qemu-xhci => no joy, still have to reset the VM after each startup, to
get the keyboard and mouse working.
Is this expected?
Thanks!
--
You
A future libslirp update will use libresolv on Darwin systems, so we add the
flags in QEMU build now.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Joelle van Dyne
---
meson.build | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meson.build b/meson.build
index e62324d5ac..664d9f93a5 100644
Some hosts (iOS) have a sandboxed filesystem and do not provide low-level
APIs for interfacing with host block devices.
Signed-off-by: Joelle van Dyne
---
configure| 4
meson.build | 1 +
qapi/block-core.json | 4 +++-
block/file-posix.c | 8 +++-
4 files
The iOS toolchain does not use the host prefix naming convention. So we need
to enable cross-compile options while allowing the PREFIX to be blank.
Signed-off-by: Joelle van Dyne
---
configure | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure
will succeed with CONFIG_PREADV even when targeting a lower OS version. We
therefore need to check at run time if we can actually use these APIs.
Signed-off-by: Joelle van Dyne
---
block/file-posix.c | 12
1
This introduces support for building for iOS hosts. When the correct Xcode
toolchain is used, iOS host will be detected automatically.
* block: disable features not supported by iOS sandbox
* slirp: disable SMB features for iOS
* osdep: disable system() calls for iOS
Signed-off-by: Joelle van
This change registers a bottom handler to close the JACK client
connection when a server shutdown signal is received. Without this
libjack2 attempts to "clean up" old clients and causes a use after free
segfault.
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 50
When entitlements are available (macOS or jailbroken iOS), a hardware
feature called APRR exists on newer Apple Silicon that can cheaply mark JIT
pages as either RX or RW. Reverse engineered functions from
libsystem_pthread.dylib are implemented to handle this.
The following rules apply for JIT
Based-on: 20201106032921.600200-1-richard.hender...@linaro.org
([PATCH v3 00/41] Mirror map JIT memory for TCG)
These set of changes brings QEMU TCG to iOS devices and future Apple Silicon
devices. They were originally developed last year and have been working in the
UTM app. Recently, we ported
v10:
* fixed typo in commit message
* qjack_shutdown_lock is now static
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 50 +++
1 file changed, 37 insertions(+), 13 deletions(-)
--
2.20.1
On 05/11/2020 09.19, Markus Armbruster wrote:
> Thomas Huth writes:
>
>> On 04/11/2020 11.23, AlexChen wrote:
>>> We should use printf format specifier "%u" instead of "%d" for
>>> argument of type "unsigned int".
>>>
>>> Reported-by: Euler Robot
>>> Signed-off-by: Alex Chen
>>> ---
>>>
iOS does not support ucontext natively for aarch64 and the sigaltstack is
also unsupported (even worse, it fails silently, see:
https://openradar.appspot.com/13002712 )
As a workaround we include a library implementation of ucontext and add it
as a build option.
Signed-off-by: Joelle van Dyne
On Samstag, 7. November 2020 10:58:10 CET Christian Schoenebeck wrote:
> On Samstag, 7. November 2020 01:04:58 CET Geoffrey McRae wrote:
> > This change registers a bottom handler to close the JACK client
> > connection when a server shutdown signal is recieved. Without this
One last minor thing,
When using a Cortex-A15, the Virt machine does not use any
MPCore peripherals. Remove the dependency.
Fixes: 7951c7b7c05 ("hw/arm: Express dependencies of the virt machine with
Kconfig")
Reported-by: Miroslav Rezanina
Signed-off-by: Philippe Mathieu-Daudé
---
RFC because there might be some
On Samstag, 7. November 2020 01:04:58 CET Geoffrey McRae wrote:
> This change registers a bottom handler to close the JACK client
> connection when a server shutdown signal is recieved. Without this
> libjack2 attempts to "clean up" old clients and causes a use after free
> segfault.
>
>
Hi,
On 9/29/20 9:22 AM, Michael S. Tsirkin wrote:
> From: Ani Sinha
>
> When acpi hotplug is turned off for both root pci bus as well as for pci
> bridges, we should not generate the related ACPI code for DSDT table or
> initialize related hw ports or reserve hw resources. This change makes
>
Since commit 755fba11fbc and 8ddab8dd3d8 we can not build
USB_XHCI_NEC without USB_XHCI_PCI. Correct the Kconfig
dependency.
Fixes: 755fba11fbc ("usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c")
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/Kconfig | 4 +---
1 file changed, 1
On 11/7/20 11:10 AM, Philippe Mathieu-Daudé wrote:
> Hi,
>
> On 9/29/20 9:22 AM, Michael S. Tsirkin wrote:
>> From: Ani Sinha
>>
>> When acpi hotplug is turned off for both root pci bus as well as for pci
>> bridges, we should not generate the related ACPI code for DSDT table or
>> initialize
On Thu, Nov 05, 2020 at 05:50:27PM -0800, John G Johnson wrote:
> The idea behind the version IDs is to identify incompatible protocol
> changes as major versions, and compatible changes as minor versions. What
> would be the purpose of the third version type?
Well, like any patch
Ping for 5.2 as this is a bugfix.
On 10/13/20 12:22 PM, Philippe Mathieu-Daudé wrote:
> set_pci_host_devaddr() is hard to follow, thus bug-prone.
> We indeed introduced a bug in commit bccb20c49df, as the
> same line might be used to parse a bus (up to 0xff) or a
> slot (up to 0x1f). Instead of
Hi Geoffrey,
Cc'ing the QOM maintainers.
On 11/7/20 12:45 AM, Geoffrey McRae wrote:
> The commit bccb20c49df1bd683248a366021973901c11982f introduced an error
> in the checking logic that validates the bus addresses for PCI device
> addresses preventing usage of devices via vfio-pci that sit at a
'method' can be left uninitialized. Restrict some code to be used
only in the "if (bsel || pcihp_bridge_en)" block statement.
This fixes (gcc 9.3.0 on Ubuntu):
../hw/i386/acpi-build.c: In function 'build_append_pci_bus_devices':
../hw/i386/acpi-build.c:496:9: error: 'method' may be used
The TYPE_XHCI model is abstract and can not be used as it.
It is meant to be overloaded by children classes. Restore
it as abstract type.
Fixes: 8ddab8dd3d8 ("usb/hcd-xhci: Split pci wrapper for xhci base model")
Reported-by: Miroslav Rezanina
Signed-off-by: Philippe Mathieu-Daudé
---
Signed-off-by: Philippe Mathieu-Daudé
---
Cc: Eduardo Habkost
Cc: qemu-triv...@nongnu.org
hw/usb/hcd-xhci-pci.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/usb/hcd-xhci-pci.h b/hw/usb/hcd-xhci-pci.h
index aa2e890627c..cf9a180caa4 100644
--- a/hw/usb/hcd-xhci-pci.h
Commit 348b8d1a76 "macio: don't reference serial_hd() directly within the
device"
removed the setting of user_creatable to false on the basis that the restriction
was due to the use of serial_hd() in macio_instance_init().
Unfortunately this isn't the full story since the PIC object property
On 11/7/20 12:28 PM, Mark Cave-Ayland wrote:
> Commit 348b8d1a76 "macio: don't reference serial_hd() directly within the
> device"
> removed the setting of user_creatable to false on the basis that the
> restriction
> was due to the use of serial_hd() in macio_instance_init().
>
> Unfortunately
Hi Huacai,
On 11/6/20 5:21 AM, Huacai Chen wrote:
> From: Jiaxun Yang
>
> Our current code assumed the target page size is always 4k
> when handling PageMask and VPN2, however, variable page size
> was just added to mips target and that's no longer true.
>
> Fixes: ee3863b9d414 ("target/mips:
On Sat, Nov 7, 2020 at 3:40 PM Philippe Mathieu-Daudé wrote:
>
> Hi,
>
> On 9/29/20 9:22 AM, Michael S. Tsirkin wrote:
> > From: Ani Sinha
> >
> > When acpi hotplug is turned off for both root pci bus as well as for pci
> > bridges, we should not generate the related ACPI code for DSDT table or
On Fri, Nov 06, 2020 at 09:03:40PM +, Stefan Hajnoczi wrote:
> libvhost-user is needed when CONFIG_LINUX is set. The CONFIG_VHOST_USER
> check in meson.build is incorrect.
>
> In fact, no explicit check is needed since this dependency is not built
> by default. If something declares a
On Fri, 6 Nov 2020 at 09:28, Gerd Hoffmann wrote:
>
> Hi,
>
> If you have an long commit message put it into the body not the subject
> please.
>
> On Sat, Nov 07, 2020 at 01:03:39AM +0800, lichun wrote:
> > Signed-off-by: lichun
> > ---
> > ui/console.c | 5 +++--
> > 1 file changed, 3
Follow the code base style by using the _COMMON suffix to
abstract QOM types.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/hcd-xhci-pci.h | 4 ++--
hw/usb/hcd-xhci-nec.c | 2 +-
hw/usb/hcd-xhci-pci.c | 16
3 files changed, 11 insertions(+), 11 deletions(-)
diff --git
Fix few regressions introduced while introducing xhci-sysbus.
Cleaned a bit code style while here, patches included for 6.0.
Philippe Mathieu-Daudé (5):
hw/usb/hcd-xhci: Make xhci base model abstract
hw/usb/Kconfig: Fix USB_XHCI_NEC (depends on USB_XHCI_PCI)
hw/usb/hcd-xhci: Rename
Follow the code base style by using the _COMMON suffix to
abstract QOM types.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/hcd-xhci.h| 4 +++-
include/hw/usb/xhci.h| 1 -
hw/usb/hcd-xhci-pci.c| 2 +-
hw/usb/hcd-xhci-sysbus.c | 2 +-
hw/usb/hcd-xhci.c| 10
On 11/7/20 1:22 PM, Ani Sinha wrote:
> On Sat, Nov 7, 2020 at 3:40 PM Philippe Mathieu-Daudé
> wrote:
>>
>> Hi,
>>
>> On 9/29/20 9:22 AM, Michael S. Tsirkin wrote:
>>> From: Ani Sinha
>>>
>>> When acpi hotplug is turned off for both root pci bus as well as for pci
>>> bridges, we should not
On Sat, Nov 07, 2020 at 03:18:24PM +0100, Philippe Mathieu-Daudé wrote:
> On 11/7/20 1:22 PM, Ani Sinha wrote:
> > On Sat, Nov 7, 2020 at 3:40 PM Philippe Mathieu-Daudé
> > wrote:
> >>
> >> Hi,
> >>
> >> On 9/29/20 9:22 AM, Michael S. Tsirkin wrote:
> >>> From: Ani Sinha
> >>>
> >>> When acpi
Le 07/11/2020 à 00:51, Peter Maydell a écrit :
> The q800 board code connects both of the IRQ outputs of the ESCC
> to the same pic[3] qemu_irq. Connecting two qemu_irqs outputs directly
> to the same input is not valid as it produces subtly wrong behaviour
> (for instance if both the IRQ lines
On Sat, Nov 07, 2020 at 11:29:40AM +0100, Philippe Mathieu-Daudé wrote:
> 'method' can be left uninitialized. Restrict some code to be used
> only in the "if (bsel || pcihp_bridge_en)" block statement.
>
> This fixes (gcc 9.3.0 on Ubuntu):
>
> ../hw/i386/acpi-build.c: In function
Le 07/11/2020 à 00:51, Peter Maydell a écrit :
> The handling of the GLUE (General Logic Unit) device is
> currently open-coded. Make this into a proper QOM device.
>
> This minor piece of modernisation gets rid of the free
> floating qemu_irq array 'pic', which Coverity points out
> is
Hi, I am confuse with the LPC/GSI code.
In pc_q35_init() we connect the LPC outputs to
GSI input:
116 static void pc_q35_init(MachineState *machine)
117 {
...
240 /* irq lines */
241 gsi_state = pc_gsi_create(>gsi, pcmc->pci_enabled);
242
243 ich9_lpc = ICH9_LPC_DEVICE(lpc);
244
Cc'ing SPARC maintainers ...
On 11/7/20 12:51 AM, Peter Maydell wrote:
> The q800 board code connects both of the IRQ outputs of the ESCC
> to the same pic[3] qemu_irq. Connecting two qemu_irqs outputs directly
> to the same input is not valid as it produces subtly wrong behaviour
> (for instance
This fixes the following warning (gcc 9.3.0 on Ubuntu):
../hw/i386/acpi-build.c: In function 'build_append_pci_bus_devices':
../hw/i386/acpi-build.c:496:9: error: 'method' may be used uninitialized
in this function [-Werror=maybe-uninitialized]
496 | aml_append(parent_scope,
> On 11/7/20 12:51 AM, Peter Maydell wrote:
>> The q800 board code connects both of the IRQ outputs of the ESCC
>> to the same pic[3] qemu_irq. Connecting two qemu_irqs outputs directly
>> to the same input is not valid as it produces subtly wrong behaviour
>> (for instance if both the IRQ lines
This fixes the following warning (gcc 9.3.0 on Ubuntu):
../hw/i386/acpi-build.c: In function 'build_append_pci_bus_devices':
../hw/i386/acpi-build.c:496:9: error: 'method' may be used uninitialized
in this function [-Werror=maybe-uninitialized]
496 | aml_append(parent_scope,
omap2420_mpu_init() introduced in commit 827df9f3c5f ("Add basic
OMAP2 chip support") takes care of creating the 3 UARTs.
Then commit 58a26b477e9 ("Emulate a serial bluetooth HCI with H4+
extensions and attach to n8x0's UART") added n8x0_uart_setup()
which create the UART and connects it to an
This series is inspired by Peter's following patch:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg758178.html
I started to audit the IRQ uses and fixed the easy problems.
Unresolved ones:
- stellaris_init() connects different TYPE_STELLARIS_GPTM
to the same ADC input (seems some weird
The system configuration controller (SYSCFG) doesn't have
any output IRQ (and the INTC input #71 belongs to the UART6).
Remove the invalid code.
Fixes: db635521a02 ("stm32f205: Add the stm32f205 SoC")
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/misc/stm32f2xx_syscfg.h | 2 --
We don't need to fill the full pic[] array if we only use
few of the interrupt lines. Directly call qdev_get_gpio_in()
when necessary.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/musicpal.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git
GCC 9.3.0 thinks that 'method' can be left uninitialized. This code
is already in the "if (bsel || pcihp_bridge_en)" block statement,
but it isn't smart enough to figure it out.
Restrict the code to be used only in the "if (bsel || pcihp_bridge_en)"
block statement to fix (on Ubuntu):
On Sat, Nov 07, 2020 at 08:38:51PM +0530, Ani Sinha wrote:
> This fixes the following warning (gcc 9.3.0 on Ubuntu):
>
> ../hw/i386/acpi-build.c: In function 'build_append_pci_bus_devices':
> ../hw/i386/acpi-build.c:496:9: error: 'method' may be used uninitialized
> in this function
On Sat, Nov 7, 2020 at 9:56 PM Michael S. Tsirkin wrote:
>
> On Sat, Nov 07, 2020 at 08:38:51PM +0530, Ani Sinha wrote:
> > This fixes the following warning (gcc 9.3.0 on Ubuntu):
> >
> > ../hw/i386/acpi-build.c: In function 'build_append_pci_bus_devices':
> > ../hw/i386/acpi-build.c:496:9:
Hi,
I am looking to contribute code to QEMU, a software I have enjoyed
using for my own projects. I want to contribute to developing a
specific component in the project. I was looking for possible project
ideas and came across this page:
https://wiki.qemu.org/Google_Summer_of_Code_2020 . Is it ok
We can use one MPC per SRAM bank, but we currently only wire the
IRQ from the first expansion MPC to the IRQ splitter. Fix that.
Fixes: bb75e16d5e6 ("hw/arm/iotkit: Wire up MPC interrupt lines")
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/armsse.c | 3 ++-
1 file changed, 2 insertions(+),
The MusicPal board code connects both of the IRQ outputs of the UART
to the same INTC qemu_irq. Connecting two qemu_irqs outputs directly
to the same input is not valid as it produces subtly wrong behaviour
(for instance if both the IRQ lines are high, and then one goes
low, the INTC input will
Richard Henderson writes:
> This value is constant across all thread-local copies of TCGContext,
> so we might as well move it out of thread-local storage.
>
> Use the correct function pointer type, and name the variable
> tcg_qemu_tb_exec, which means that we are able to remove the
> macro
Richard Henderson writes:
> On 11/6/20 12:31 PM, Alex Bennée wrote:
>>> +/* Flush the dcache at RW, and the icache at RX, as necessary. */
>>> +static inline void flush_idcache_range(uintptr_t rx, uintptr_t rw, size_t
>>> len)
>>> {
>>> -__builtin___clear_cache((char *)start, (char
60 matches
Mail list logo
