client_migrate_info reports spice_server_migrate_connect() failure as
"An undefined error has occurred". Improve to "Could not set up
display for migration".
QERR_UNDEFINED_ERROR is now unused. Drop.
Cc: Gerd Hoffmann
Signed-off-by: Markus Armbruster
---
include/qapi/qmp/qerror.h | 3 ---
Obviously not for 5.2. Please review anyway.
Markus Armbruster (10):
qerror: Drop unused QERR_ macros
qerror: Eliminate QERR_ macros used in just one place
block: Improve some block-commit, block-stream error messages
ui: Improve some set_passwd, expire_password error messages
ui:
On 13/11/20 09:26, Markus Armbruster wrote:
qom-list-properties reports
Parameter 'typename' expects device
when @typename exists, but isn't a TYPE_DEVICE. Improve this to
Parameter 'typename' expects a non-abstract device type
device-list-properties reports
Parameter
* Markus Armbruster (arm...@redhat.com) wrote:
> Clean up includes so that osdep.h is included first and headers
> which it implies are not included manually.
>
> This commit was created with scripts/clean-includes, with the changes
> to the following files manually reverted:
>
>
On 13/11/2020 07.12, Markus Armbruster wrote:
> Clean up includes so that osdep.h is included first and headers
> which it implies are not included manually.
>
> This commit was created with scripts/clean-includes, with the changes
> to the following files manually reverted:
>
>
On Thu 12-11-20 17:38:36, Maxim Levitsky wrote:
> On Thu, 2020-11-12 at 12:19 +0100, Jan Kara wrote:
> > [added some relevant people and lists to CC]
> >
> > On Wed 11-11-20 17:44:05, Maxim Levitsky wrote:
> > > On Wed, 2020-11-11 at 17:39 +0200, Maxim Levitsky wrote:
> > > > clone of
iotest 277 fails on Fedora 33 (Python 3.9) because a deprecation warning
changes the output:
nbd-fault-injector.py:230: DeprecationWarning: This method will be
removed in future versions. Use 'parser.read_file()' instead.
In fact, readfp() has already been deprecated in Python 3.2 and
On 13/11/2020 11.15, Paolo Bonzini wrote:
> Use the machine properties instead.
>
> Cc: Laurent Vivier
> Signed-off-by: Paolo Bonzini
> ---
> hw/m68k/mcf5206.c | 4 +++-
> hw/m68k/mcf5208.c | 3 ++-
> target/m68k/m68k-semi.c | 5 +++--
> 3 files changed, 8 insertions(+), 4
mon_get_cpu() is indirectly called monitor_parse_arguments() where
the current monitor isn't set yet. Instead of using monitor_cur(),
explicitly pass the Monitor pointer to the function.
Signed-off-by: Kevin Wolf
---
include/monitor/hmp-target.h | 2 +-
monitor/monitor-internal.h | 2 +-
All of these callbacks use mon_get_cpu_env(). Pass the Monitor
pointer to them it in preparation for adding a monitor argument to
mon_get_cpu_env().
Signed-off-by: Kevin Wolf
---
include/monitor/hmp-target.h | 3 ++-
monitor/misc.c | 2 +-
target/i386/monitor.c| 3 ++-
When I restricted the section where the current monitor is set to only
the command handler, I missed that monitor_parse_arguments() can use it
indirectly, too, when evaluating register variables. These cases get
NULL now and crash (easy to reproduce with "x $pc").
This series passes the right
* Markus Armbruster (arm...@redhat.com) wrote:
> Commit 741d4086c8 "migration: Use proper types in json" (v2.12.0)
> switched MigrationParameters to narrower integer types, and removed
> the simplified qmp_migrate_set_parameters()'s argument checking
> accordingly.
>
> Good idea, except
On 11.11.20 17:53, Alberto Garcia wrote:
This simply calls bdrv_co_pwrite_zeroes() in all children
Signed-off-by: Alberto Garcia
---
block/quorum.c | 18 --
tests/qemu-iotests/312 | 7 +++
tests/qemu-iotests/312.out | 4
3 files changed, 27
From: Philippe Mathieu-Daudé
Commit ec87f206d70 ("cirrus: replace debug printf with trace points")
forgot to remove this code once replaced. Do it now.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
Message-id: 20201103112558.2554390-2-phi...@redhat.com
From: Philippe Mathieu-Daudé
The '%u' conversion specifier is for decimal notation.
When prefixing a format with '0x', we want the hexadecimal
specifier ('%x').
Inspired-by: Dov Murik
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Dr. David Alan Gilbert
Message-id:
The following changes since commit cb5d19e8294486551c422759260883ed290226d9:
Merge remote-tracking branch 'remotes/mcayland/tags/qemu-macppc-20201112' i=
nto staging (2020-11-12 11:33:26 +)
are available in the Git repository at:
git://git.kraxel.org/qemu tags/fixes-20201113-pull
From: Geoffrey McRae
This change registers a bottom handler to close the JACK client
connection when a server shutdown signal is received. Without this
libjack2 attempts to "clean up" old clients and causes a use after free
segfault.
Signed-off-by: Geoffrey McRae
Reviewed-by: Christian
Am 13.11.2020 um 13:13 hat Dr. David Alan Gilbert geschrieben:
> * Kevin Wolf (kw...@redhat.com) wrote:
> > When I restricted the section where the current monitor is set to only
> > the command handler, I missed that monitor_parse_arguments() can use it
> > indirectly, too, when evaluating
* Kevin Wolf (kw...@redhat.com) wrote:
> When I restricted the section where the current monitor is set to only
> the command handler, I missed that monitor_parse_arguments() can use it
> indirectly, too, when evaluating register variables. These cases get
> NULL now and crash (easy to reproduce
On Thu, 12 Nov 2020 at 18:41, Dr. David Alan Gilbert (git)
wrote:
>
> From: "Dr. David Alan Gilbert"
>
> The following changes since commit cb5d19e8294486551c422759260883ed290226d9:
>
> Merge remote-tracking branch 'remotes/mcayland/tags/qemu-macppc-20201112'
> into staging (2020-11-12
* Markus Armbruster (arm...@redhat.com) wrote:
> migrate-set-parameters passes the size to xbzrle_cache_resize().
> xbzrle_cache_resize() checks it fits into size_t before it passes it
> on to cache_init(). cache_init() checks it is a power of two no
> smaller than @page_size.
>
> cache_init()
* Markus Armbruster (arm...@redhat.com) wrote:
> cache_init() attempts to handle allocation failure.. The two error
> messages are garbage, as untested error messages commonly are:
>
> Parameter 'cache size' expects Failed to allocate cache
> Parameter 'cache size' expects Failed to
>Am 13.11.2020 um 12:13 hat lichun geschrieben:
>> monitor_parse_arguments() also need to known the current monitoar:
>> (gdb) bt
>> #0 0x55ac6a6d in mon_get_cpu_sync (mon=0x0,
>>synchronize=synchronize@entry=true) at ../monitor/misc.c:270
>> #1 0x55ac6b4a in mon_get_cpu ()
On 13/11/20 11:44, Thomas Huth wrote:
On 13/11/2020 11.15, Paolo Bonzini wrote:
Use the machine properties instead.
Cc: Laurent Vivier
Signed-off-by: Paolo Bonzini
Thanks -- of course this was just an unintentional send, but I'll note
your Reviewed-by nevertheless.
Paolo
Reviewed-by:
On Thu, 12 Nov 2020 16:43:09 -0500
Eduardo Habkost wrote:
> Make the code more generic and not specific to TYPE_DEVICE.
>
> Reviewed-by: Marc-André Lureau
> Signed-off-by: Eduardo Habkost
> ---
> Cc: Paolo Bonzini
> Cc: "Daniel P. Berrangé"
> Cc: Eduardo Habkost
> Cc: Cornelia Huck
> Cc:
On Thu, 12 Nov 2020 at 23:07, Alex Williamson
wrote:
>
> The following changes since commit cb5d19e8294486551c422759260883ed290226d9:
>
> Merge remote-tracking branch 'remotes/mcayland/tags/qemu-macppc-20201112'
> into staging (2020-11-12 11:33:26 +)
>
> are available in the Git repository
On 11.11.20 17:53, Alberto Garcia wrote:
The quorum driver does not implement bdrv_co_block_status() and
because of that it always reports to contain data even if all its
children are known to be empty.
One consequence of this is that if we for example create a quorum with
a size of 10GB and we
mon_get_cpu_env() is indirectly called monitor_parse_arguments() where
the current monitor isn't set yet. Instead of using monitor_cur_env(),
explicitly pass the Monitor pointer to the function.
Without this fix, an HMP command like "x $pc" crashes like this:
#0 0x55caa01f in
On 12/11/20 18:59, Kevin Wolf wrote:
The final missing piece to achieve compatibility between
qemu_chr_parse_cli_str()/qemu_chr_new_cli() and the legacy command line
is support for the 'mux' option. Implement it.
Signed-off-by: Kevin Wolf
---
qapi/char.json | 4 +++-
chardev/char.c | 41
* Markus Armbruster (arm...@redhat.com) wrote:
> Not sure about 5.2. The bugs aren't recent regressions.
Lets leave it till 5.3
> Markus Armbruster (6):
> migration: Fix and clean up around @tls-authz
> migration: Fix migrate-set-parameters argument validation
> migration: Clean up signed
* Kevin Wolf (kw...@redhat.com) wrote:
> When I restricted the section where the current monitor is set to only
> the command handler, I missed that monitor_parse_arguments() can use it
> indirectly, too, when evaluating register variables. These cases get
> NULL now and crash (easy to reproduce
> -Original Message-
> From: Peter Maydell [mailto:peter.mayd...@linaro.org]
> Sent: Friday, November 13, 2020 6:13 PM
> To: ganqixin
> Cc: QEMU Developers ; QEMU Trivial
> ; Thomas Huth ; Laurent
> Vivier ; Philippe Mathieu-Daudé ;
> Markus Armbruster ; Michael S. Tsirkin
> ; Chenqun
On Thu, 12 Nov 2020 16:43:06 -0500
Eduardo Habkost wrote:
> Make the code more generic and not specific to TYPE_DEVICE.
>
> Reviewed-by: Marc-André Lureau
> Signed-off-by: Eduardo Habkost
> ---
> Changes v1 -> v2:
> - Fix build error with CONFIG_XEN
> I took the liberty of keeping the
* Markus Armbruster (arm...@redhat.com) wrote:
> migrate_params_check() has a number of error messages of the form
>
> Parameter 'NAME' expects is invalid, it should be ...
>
> Fix them to something like
>
> Parameter 'NAME' expects a ...
>
> Signed-off-by: Markus Armbruster
* Markus Armbruster (arm...@redhat.com) wrote:
> Commit d2f1d29b95 "migration: add support for a "tls-authz" migration
> parameter" added MigrationParameters member @tls-authz. Whereas the
> other members aren't really optional (see commit 1bda8b3c695), this
> one is genuinely optional:
From: Philippe Mathieu-Daudé
Since commit 755fba11fbc and 8ddab8dd3d8 we can not build
USB_XHCI_NEC without USB_XHCI_PCI. Correct the Kconfig
dependency.
Fixes: 755fba11fbc ("usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c")
Reviewed-by: Sai Pavan Boddu
Reviewed-by: Richard Henderson
Storing properties directly in XHCIPciState.xhci doesn't work,
the object_initialize_child() call in xhci_instance_init() will
overwrite them.
This changes the defaults for some properties, which in turn breaks
live migration and possibly other things as well.
So add XHCINecState, store
On Fri, 13 Nov 2020 at 04:40, Richard Henderson
wrote:
>
> The following changes since commit cb5d19e8294486551c422759260883ed290226d9:
>
> Merge remote-tracking branch 'remotes/mcayland/tags/qemu-macppc-20201112'
> into staging (2020-11-12 11:33:26 +)
>
> are available in the Git
From: lichun
In graphic_hw_update(), first select an existing console,
a specific-console or active_console(if not specified),
then updating the console.
Signed-off-by: lichun
Message-id: 1604682219-114389-1-git-send-email-lic...@ruijie.com.cn
Signed-off-by: Gerd Hoffmann
---
ui/console.c |
* Kevin Wolf (kw...@redhat.com) wrote:
> Am 13.11.2020 um 13:13 hat Dr. David Alan Gilbert geschrieben:
> > * Kevin Wolf (kw...@redhat.com) wrote:
> > > When I restricted the section where the current monitor is set to only
> > > the command handler, I missed that monitor_parse_arguments() can use
block-commit defaults @base-node to the deepest backing image. When
there is none, it fails with "Base 'NULL' not found". Improve to
"There is no backing image".
block-commit and block-stream reject a @base argument that doesn't
resolve with "Base 'BASE' not found". Commit 6b33f3ae8b
QERR_INVALID_BLOCK_FORMAT is dead since commit e6641719fe "block:
Always pass NULL as drv for bdrv_open()", 2015-09-14.
QERR_INVALID_PASSWORD is dead since commit c01c214b69 "block: remove
all encryption handling APIs", 2017-07-11.
Bury them.
Signed-off-by: Markus Armbruster
---
Change to "expects a THING" where that's an obvious improvement
Signed-off-by: Markus Armbruster
---
block/quorum.c | 2 +-
blockdev.c | 2 +-
chardev/char.c | 2 +-
hw/core/qdev-properties-system.c | 2 +-
softmmu/qdev-monitor.c
On 13/11/20 07:12, Markus Armbruster wrote:
Clean up includes so that osdep.h is included first and headers
which it implies are not included manually.
This commit was created with scripts/clean-includes, with the changes
to the following files manually reverted:
contrib/plugins/,
Am 13.11.2020 um 12:13 hat lichun geschrieben:
> monitor_parse_arguments() also need to known the current monitoar:
> (gdb) bt
> #0 0x55ac6a6d in mon_get_cpu_sync (mon=0x0,
> synchronize=synchronize@entry=true) at ../monitor/misc.c:270
> #1 0x55ac6b4a in mon_get_cpu () at
Hi Mateja,
(Cc'ing Fredrik)
On 2/27/19 3:00 PM, Aleksandar Markovic wrote:
> From: Mateja Marjanovic
>
> Set up MMI code to be compiled only for TARGET_MIPS64. This is
> needed so that GPRs are 64 bit, and combined with MMI registers,
> they will form full 128 bit registers.
>
>
On Mon, Nov 09, 2020 at 01:24:20PM +0100, Thomas Huth wrote:
> On 09/11/2020 12.25, Dima Stepanov wrote:
> > The virtio-blk fuzz target sets up and fuzzes the available virtio-blk
> > queues. The implementation is based on two files:
> > - tests/qtest/fuzz/virtio_scsi_fuzz.c
> > -
On Fri, 13 Nov 2020 at 09:59, Changbin Du wrote:
>
> This adds hmp 'info tlb' command support for the arm platform.
> The limitation is that this only implements a page walker for
> ARMv8-A AArch64 Long Descriptor format, 32bit addressing is
> not supported yet.
"info tlb" needs its own entirely
bios_name was a legacy variable used by machine code, but it is
no more.
Signed-off-by: Paolo Bonzini
Reviewed-by: Alex Bennée
Message-Id: <20201026143028.3034018-16-pbonz...@redhat.com>
Signed-off-by: Paolo Bonzini
---
include/sysemu/sysemu.h | 1 -
softmmu/vl.c| 2 --
2 files
On 13/11/20 11:23, Bin Meng wrote:
It would be nicer if the commit message explained how
the guest can notice the difference.
The commit message says "Per the SDM" :) The actual failure case
involves a special code sequence that is exposed in VxWorks guest
testing. Linux does not expose this
set_passwd and expire_password reject invalid "protocol" with "Invalid
parameter 'protocol'". Misleading; the parameter is valid, its value
isn't. Improve to "Parameter 'protocol' expects 'vnc' or 'spice'".
expire_password fails with "Could not set password". Misleading;
improve to "Could not
Change
Parameter 'protocol' expects spice
to
Parameter 'protocol' expects 'spice'
for consistency with similar error messages elsewhere.
Cc: Gerd Hoffmann
Signed-off-by: Markus Armbruster
---
monitor/misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Signed-off-by: Markus Armbruster
---
include/qapi/qmp/qerror.h | 9 -
monitor/misc.c| 8
net/net.c | 2 +-
3 files changed, 5 insertions(+), 14 deletions(-)
diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h
index
> +Version Data Format
> +^^^
> +
> +The version data is an optional JSON byte array with the following format:
> +
> ++--+--+---+
> +| Name | Type | Description
>
On Fri, Nov 13, 2020 at 07:23:57AM +0100, Markus Armbruster wrote:
> The Error ** argument must be NULL, _abort, _fatal, or a
> pointer to a variable containing NULL. Passing an argument of the
> latter kind twice without clearing it in between is wrong: if the
> first call sets an error, it no
On Fri, Nov 13, 2020 at 07:23:58AM +0100, Markus Armbruster wrote:
> When qauthz_list_file_load() rejects JSON values other than JSON
> object with a rather confusing error message:
>
> $ echo 1 | qemu-system-x86_64 -nodefaults -S -display none -object
>
On Fri, 13 Nov 2020 07:12:16 +0100
Markus Armbruster wrote:
> Clean up includes so that osdep.h is included first and headers
> which it implies are not included manually.
>
> This commit was created with scripts/clean-includes, with the changes
> to the following files manually reverted:
>
>
From: Bin Meng
Per the SDM, when returning to outer privilege level, for segment
registers (ES, FS, GS, and DS) if the check fails, the segment
selector becomes null, but QEMU clears the base/limit/flags as well
as nullifying the segment selector, which should be a spec violation.
Real hardware
On Fri, 13 Nov 2020 at 10:17, Paolo Bonzini wrote:
>
> Pull defaults to digic4_board_init so that a MachineState is available.
>
> Cc: Peter Maydell
> Signed-off-by: Paolo Bonzini
> ---
> hw/arm/digic_boards.c | 19 +++
> 1 file changed, 7 insertions(+), 12 deletions(-)
Pull defaults to digic4_board_init so that a MachineState is available.
Cc: Peter Maydell
Signed-off-by: Paolo Bonzini
---
hw/arm/digic_boards.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c
index
qom-list-properties reports
Parameter 'typename' expects device
when @typename exists, but isn't a TYPE_DEVICE. Improve this to
Parameter 'typename' expects a non-abstract device type
device-list-properties reports
Parameter 'typename' expects object
when @typename exists, but
check_suspend_mode()'s error message
Parameter 'mode' expects GuestSuspendMode
makes no sense to users: GuestSuspendMode is a C enum. Fortunately,
it is unreachable. Replace it by abort().
Cc: Michael Roth
Signed-off-by: Markus Armbruster
---
qga/commands-win32.c | 3 +--
1 file
Am 12.11.2020 um 19:34 hat Eric Blake geschrieben:
> On 11/12/20 11:28 AM, Kevin Wolf wrote:
> > Introduce alias definitions for object types (structs and unions). This
> > allows using the same QAPI type and visitor for many syntax variations
> > that exist in the external representation, like
Patchew URL:
https://patchew.org/QEMU/20201113095854.67668-1-changbin...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20201113095854.67668-1-changbin...@gmail.com
Type: series
Subject: [PATCH] arm/monitor: Add support
On Fri, 13 Nov 2020 at 03:32, Gan Qixin wrote:
>
> The category of the ads7846 device is not set, put it into the 'input'
> category.
>
> Signed-off-by: Gan Qixin
> ---
> Cc: Peter Maydell
> ---
> hw/display/ads7846.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
Use the machine properties instead.
Cc: qemu-...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/arm/aspeed.c | 8
hw/display/pxa2xx_lcd.c | 5 +++--
target/arm/arm-semi.c | 3 ++-
3 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
Use the loader parameters instead.
Signed-off-by: Paolo Bonzini
---
hw/i386/fw_cfg.c | 2 +-
hw/i386/vmport.c | 3 ++-
hw/i386/xen/xen-hvm.c | 2 +-
hw/intc/apic_common.c | 3 ++-
hw/smbios/smbios.c| 8
5 files changed, 10 insertions(+), 8 deletions(-)
diff --git
Use the machine properties instead.
Signed-off-by: Paolo Bonzini
---
hw/cris/axis_dev88.c | 1 +
hw/cris/boot.c | 2 +-
hw/cris/boot.h | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/cris/axis_dev88.c b/hw/cris/axis_dev88.c
index dab7423c73..b0cb6d84af 100644
On 13/11/20 10:56, Bin Meng wrote:
From: Bin Meng
Per the SDM, when returning to outer privilege level, for segment
registers (ES, FS, GS, and DS) if the check fails, the segment
selector becomes null, but QEMU clears the base/limit/flags as well
as nullifying the segment selector, which
Hi Paolo,
On Fri, Nov 13, 2020 at 6:18 PM Paolo Bonzini wrote:
>
> On 13/11/20 10:56, Bin Meng wrote:
> > From: Bin Meng
> >
> > Per the SDM, when returning to outer privilege level, for segment
> > registers (ES, FS, GS, and DS) if the check fails, the segment
> > selector becomes null, but
The e1000e_write_packet_to_guest() function iterates over a set of
receive descriptors by advancing rx descriptor head register (RDH) from
its initial value to rx descriptor tail register (RDT). The check in
e1000e_ring_empty() is responsible for detecting whether RDH has reached
RDT, terminating
* Markus Armbruster (arm...@redhat.com) wrote:
> 73af8dd8d7 "migration: Make xbzrle_cache_size a migration
> parameter" (v2.11.0) made the new parameter unsigned (QAPI type
> 'size', uint64_t in C). It neglected to update existing code, which
> continues to use int64_t.
>
>
Kevin Wolf writes:
> Am 12.11.2020 um 09:22 hat Markus Armbruster geschrieben:
>> Kevin Wolf writes:
>>
>> > The aliases "tty" and "parport" are only valid on the command line, QMP
>> > commands like chardev-add don't know them. query-chardev-backends should
>> > describe QMP and therefore not
Change
Parameter 'mode' expects halt|powerdown|reboot
to
Parameter 'mode' expects 'halt', 'powerdown', or 'reboot'
for consistency with similar error messages elsewhere.
Cc: Michael Roth
Signed-off-by: Markus Armbruster
---
qga/commands-win32.c | 2 +-
1 file changed, 1
Am 23.09.2020 um 22:37 hat Eric Blake geschrieben:
> Missed during merge resolution of commit bc5ee6da71.
>
> Signed-off-by: Eric Blake
> ---
> docs/tools/qemu-img.rst | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst
> index
This adds hmp 'info tlb' command support for the arm platform.
The limitation is that this only implements a page walker for
ARMv8-A AArch64 Long Descriptor format, 32bit addressing is
not supported yet.
Signed-off-by: Changbin Du
---
hmp-commands-info.hx | 3 +-
target/arm/helper.c|
Use the machine properties instead.
Cc: Richard Henderson
Signed-off-by: Paolo Bonzini
---
hw/hppa/machine.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
index 5e745d5ea9..7e41cb2462 100644
--- a/hw/hppa/machine.c
+++
Use the machine properties instead.
Cc: Laurent Vivier
Signed-off-by: Paolo Bonzini
---
hw/m68k/mcf5206.c | 4 +++-
hw/m68k/mcf5208.c | 3 ++-
target/m68k/m68k-semi.c | 5 +++--
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/hw/m68k/mcf5206.c b/hw/m68k/mcf5206.c
On 13/11/20 11:22, Peter Maydell wrote:
Pull defaults to digic4_board_init so that a MachineState is available.
Cc: Peter Maydell
Signed-off-by: Paolo Bonzini
---
hw/arm/digic_boards.c | 19 +++
1 file changed, 7 insertions(+), 12 deletions(-)
Reviewed-by: Peter Maydell
Did
On Fri, 13 Nov 2020 at 10:37, Paolo Bonzini wrote:
>
> On 13/11/20 11:22, Peter Maydell wrote:
> >> Pull defaults to digic4_board_init so that a MachineState is available.
> >>
> >> Cc: Peter Maydell
> >> Signed-off-by: Paolo Bonzini
> >> ---
> >> hw/arm/digic_boards.c | 19 +++
On Fri, Nov 13, 2020 at 05:44:04PM +, Alex Bennée wrote:
> We don't need running commentary for the CI logs and by keeping it
> short we might just see the problem on the first page. While we are at
> it flush the previous line so order is maintained between script and
> sub process.
>
>
On 11/9/20 6:10 AM, remi.denis.courm...@huawei.com wrote:
> From: Rémi Denis-Courmont
>
> In the secure stage 2 translation regime, the VSTCR.SW and VTCR.NSW
> bits can invert the secure flag for pagetable walks. This patchset
> allows S1_ptw_translate() to change the non-secure bit.
>
>
On 11/9/20 6:10 AM, remi.denis.courm...@huawei.com wrote:
> From: Rémi Denis-Courmont
>
> Signed-off-by: Rémi Denis-Courmont
> ---
> target/arm/cpu.h| 2 ++
> target/arm/helper.c | 24
> 2 files changed, 26 insertions(+)
Reviewed-by: Richard Henderson
r~
We don't need running commentary for the CI logs and by keeping it
short we might just see the problem on the first page. While we are at
it flush the previous line so order is maintained between script and
sub process.
Signed-off-by: Alex Bennée
---
.gitlab-ci.d/check-patch.py | 4 ++--
1 file
On 12/11/20 16:04, Hannes Reinecke wrote:
On 11/12/20 10:52 AM, Paolo Bonzini wrote:
Well, ironically I'm currently debugging a customer escalation which
touches exactly this area. It revolves more around the SG_IO handling;
Technically this patch is for *non* passthrough, but yeah it's a
On 13.11.20 19:00, Vladimir Sementsov-Ogievskiy wrote:
13.11.2020 19:24, Max Reitz wrote:
On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote:
Benchmark for new preallocate filter.
Example usage:
./bench_prealloc.py ../../build/qemu-img \
ssd-ext4:/path/to/mount/point \
On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
Here is a filter, which does preallocation on write.
v7:
01: add Alberto's r-b
07: don't remove sentence from the comment
08: - drop extra "s->file_end = end;" line
- improve check/set perm handlers
09: add Max's r-b
10: add
On 13.11.20 17:52, Alberto Garcia wrote:
Following Max's suggestion, this version sets supported_zero_flags.
Berto
v4:
- Set supported_zero_flags in quorum [Max]
- Update test to verify the data written before doing 'write -z' [Max]
v3:
On 13.11.20 17:52, Alberto Garcia wrote:
This simply calls bdrv_co_pwrite_zeroes() in all children.
bs->supported_zero_flags is also set to the flags that are supported
by all children.
Signed-off-by: Alberto Garcia
---
block/quorum.c | 36 ++--
On 11/9/20 6:10 AM, remi.denis.courm...@huawei.com wrote:
> From: Rémi Denis-Courmont
>
> This checks if EL2 is enabled (meaning EL2 registers take effects) in
> the current security context.
>
> Signed-off-by: Rémi Denis-Courmont
> ---
> target/arm/cpu.h | 16
> 1 file
Thank you very much for your answer. I have already watched two
tutorials, but it does not work. Do you have a tutorial for me? Thank
you
Regard
Le vendredi 13 novembre 2020 à 16:55:40 UTC+1, Peter Maydell
<1904...@bugs.launchpad.net> a écrit :
QEMU is working fine, but your guest
13.11.2020 19:24, Max Reitz wrote:
On 21.10.20 16:58, Vladimir Sementsov-Ogievskiy wrote:
Benchmark for new preallocate filter.
Example usage:
./bench_prealloc.py ../../build/qemu-img \
ssd-ext4:/path/to/mount/point \
ssd-xfs:/path2 hdd-ext4:/path3 hdd-xfs:/path4
The
On 11/9/20 6:10 AM, remi.denis.courm...@huawei.com wrote:
> From: Rémi Denis-Courmont
>
> The VTTBR write callback so far assumes that the underlying VM lies in
> non-secure state. This handles the secure state scenario.
>
> Signed-off-by: Rémi Denis-Courmont
> ---
> target/arm/helper.c | 13
The recently-added 'guest-get-disk' command returns a list of
GuestDiskInfo entries, which in turn have a 'dependents' field which
lists devices these entries are dependent upon. Thus, 'dependencies'
is a better name for this field. Address this by renaming the field
accordingly.
Additionally,
* Eric Blake (ebl...@redhat.com) wrote:
> These cases require a bit more thought to review; in each case, the
> code was appending to a list, but not with a FOOList **tail variable.
>
> Signed-off-by: Eric Blake
> ---
> block/gluster.c| 13 +---
> block/qapi.c | 14
Test what happens when a rewrite-corrupted quorum node performs such a
rewrite, while there is no parent that has taken the WRITE permission.
Signed-off-by: Max Reitz
---
tests/qemu-iotests/081 | 54 ++
tests/qemu-iotests/081.out | 27 +++
Otherwise, this breaks whenever the test directory contains the image
format (e.g. "/tmp/test-raw-file" is filtered to "/tmp/test-IMGFMT-file"
instead of "TEST_DIR").
Signed-off-by: Max Reitz
---
tests/qemu-iotests/081 | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
Hi,
While reviewing Berto’s block-status/write-zeroes series for quorum, I
wondered how quorum’s permission code handles rewrite-corrupted. It
turns out it doesn’t, and so qemu with a read-only rewrite-corrupted
quorum node simply crashes once there is a mismatch that leads to a
rewrite.
It
Using rewrite-corrupted means quorum may issue writes to its children
just from receiving read requests from its parents. Thus, it must take
the WRITE permission when rewrite-corrupted is used.
Signed-off-by: Max Reitz
---
block/quorum.c | 5 +
1 file changed, 5 insertions(+)
diff --git
On 11/9/20 6:10 AM, remi.denis.courm...@huawei.com wrote:
> From: Rémi Denis-Courmont
>
> In this context, the HCR value is the effective value, and thus is
> zero in secure mode. The tests for HCR.{F,I}MO are sufficient.
>
> Signed-off-by: Rémi Denis-Courmont
> ---
> target/arm/cpu.c| 8
1 - 100 of 207 matches
Mail list logo
