On Tue, Nov 17, 2020 at 2:48 AM Eduardo Habkost wrote:
> Useful function where we need to check for the qlit type before
> converting it to an actual QObject.
>
> Signed-off-by: Eduardo Habkost
>
Reviewed-by: Marc-André Lureau
---
> include/qapi/qmp/qlit.h | 5 +
> 1 file changed, 5
On Tue, Nov 17, 2020 at 2:48 AM Eduardo Habkost wrote:
> Use QNumValue to represent QNums, so we can also support uint64_t
> and double QNum values. Add new QLIT_QNUM_(INT|UINT|DOUBLE)
> macros for each case.
>
> The QLIT_QNUM() macro is being kept for compatibility with
> existing code, but
On Mon, Nov 16, 2020 at 02:19:11PM +, Peter Maydell wrote:
> On Sun, 15 Nov 2020 at 22:27, Michael S. Tsirkin wrote:
> >
> > The following changes since commit c6f28ed5075df79fef39c500362a3f4089256c9c:
> >
> > Update version for v5.2.0-rc1 release (2020-11-10 22:29:57 +)
> >
> > are
From: Stefan Hajnoczi
The vhost-user protocol uses the Linux eventfd feature and is typically
connected to Linux kvm.ko ioeventfd and irqfd file descriptors. The
protocol specification in docs/interop/vhost-user.rst does not describe
how platforms without eventfd support work.
The QEMU
Paolo Bonzini writes:
> They are going to be deprecated, avoid warnings on stdout while the
> tests run.
>
> Signed-off-by: Paolo Bonzini
> ---
> python/qemu/machine.py | 2 +-
> tests/qtest/pflash-cfi02-test.c | 4 ++--
> tests/qtest/test-filter-redirector.c | 8
>
On 16/11/2020 22.42, Matthew Rosato wrote:
> Hot-unplugging a vfio-pci device on s390x causes a QEMU crash:
>
> qemu-system-s390x: ../softmmu/memory.c:2772:
> do_address_space_destroy: Assertion `QTAILQ_EMPTY(>listeners)' failed.
>
> In s390, the IOMMU address space is freed during device
Eric Blake writes:
> Instead of modifying the value member of a list element passed as a
> parameter, and open-coding the manipulation of that list, it's nicer
> to just return a freshly allocated value to be prepended to a list
> using QAPI_LIST_PREPEND.
>
> Signed-off-by: Eric Blake
> ---
>
Hi Peter,
the following changes since commit b17d3b7b77f043f0e76f0e6ce6def3c1b1d5ee8b:
Merge remote-tracking branch 'remotes/mdroth/tags/qga-pull-2020-11-16-tag'
into staging (2020-11-16 20:15:57 +)
are available in the Git repository at:
https://gitlab.com/huth/qemu.git
*** This bug is a duplicate of bug 1022023 ***
https://bugs.launchpad.net/bugs/1022023
** This bug is no longer a duplicate of bug 1054558
1366x768 resolution missing
** This bug has been marked a duplicate of bug 1022023
vga/std lacks few wide screen modes.
--
You received this bug
The Haiku VM that we are going to add is using _BSD_SOURCE instead
of BSD_SOURCE (without initial underscore)... according to David
Carlier, the BSD_SOURCE without underscore was likely a typo, so
let's simply add the underscore there now.
This fixes the build failure with the bswapXX() macros not
Since USB emulation has been added in QEMU 5.1, I'm marking this feature
request as done now. If there are still issues, please open a new ticket
instead.
** Changed in: qemu
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of qemu-
From: Alexander von Gluck IV
Signed-off-by: Alexander von Gluck IV
[PMD: Avoid recreating the image each time]
Signed-off-by: Philippe Mathieu-Daudé
[thuth: Add ninja package, /usr/bin/env hack and --disable-slirp]
Message-Id: <20201114165137.15379-5-th...@redhat.com>
Buglink:
On Tue, Nov 17, 2020 at 2:43 AM Eduardo Habkost wrote:
> Provide a separate QNumValue type that can be used for QNum value
> literals without the referencing counting and memory allocation
> features provided by QObject.
>
> Signed-off-by: Eduardo Habkost
> ---
> Changes v1 -> v2:
> * Fix "make
From: AlexChen
When socket() fails, it returns -1, 0 is the normal return value and should not
return error.
Reported-by: Euler Robot
Signed-off-by: AlexChen
Message-Id: <5f9a5b48.9030...@huawei.com>
Reviewed-by: Raphael Norwitz
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S.
From: Stefan Hajnoczi
I interpreted CONFIG_VHOST_USER as controlling only QEMU's vhost-user
device frontends. However, virtiofsd and contrib/ vhost-user device
backends are also controlled by CONFIG_VHOST_USER. Make the
vhost-user-blk server depend on CONFIG_VHOST_USER for consistency.
Now the
From: AlexChen
We should use printf format specifier "%u" instead of "%d" for
argument of type "unsigned int".
Reported-by: Euler Robot
Signed-off-by: Alex Chen
Message-Id: <5fa28106.6000...@huawei.com>
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
From: Stefan Hajnoczi
QEMU currently truncates the mmap_offset field when sending
VHOST_USER_ADD_MEM_REG and VHOST_USER_REM_MEM_REG messages. The struct
layout looks like this:
typedef struct VhostUserMemoryRegion {
uint64_t guest_phys_addr;
uint64_t memory_size;
uint64_t
On 16/11/20 21:13, Jessica Clarke wrote:
These are meant to correspond to the error code reported for #PF, so fix
the definition for Instruction Fetch faults and add one for Reserved Bit
faults (checking for that is currently a TODO in x86_mmu.c).
Signed-off-by: Jessica Clarke
---
*** This bug is a duplicate of bug 1022023 ***
https://bugs.launchpad.net/bugs/1022023
I noticed that we have multiple tickets for more resolutions opened.
Let's consolidate all in https://bugs.launchpad.net/qemu/+bug/1022023
and close this one here as duplicate.
** This bug has been marked
From: Brad Smith
update NetBSD to 9.1
Signed-off-by: Brad Smith
Reviewed-by: Gerd Hoffmann
Tested-by: Gerd Hoffmann
Message-Id: <20201114040150.gd13...@humpty.home.comstyle.com>
Signed-off-by: Thomas Huth
---
tests/vm/netbsd | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
Hi Paolo,
On Fri, Nov 13, 2020 at 6:39 PM Paolo Bonzini wrote:
>
> On 13/11/20 11:23, Bin Meng wrote:
> >> It would be nicer if the commit message explained how
> >> the guest can notice the difference.
> >
> > The commit message says "Per the SDM" :) The actual failure case
> > involves a
Was the MIPS64R2-generic good enough for you?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1877706
Title:
[Feature request] qemu does not
On Tue, Nov 17, 2020 at 2:43 AM Eduardo Habkost wrote:
> Render existing doc comments at docs/devel/qobject.html.
>
> Signed-off-by: Eduardo Habkost
>
Reviewed-by: Marc-André Lureau
---
> docs/devel/index.rst | 1 +
> docs/devel/qobject.rst | 11 +
>
On Tue, Nov 17, 2020 at 2:42 AM Eduardo Habkost wrote:
> Extract the QNum value comparison logic to a function that takes
> QNumValue* as argument.
>
> Signed-off-by: Eduardo Habkost
> ---
> include/qapi/qmp/qnum.h | 1 +
> qobject/qnum.c | 29 +++--
> 2 files
On Tue, Nov 17, 2020 at 2:44 AM Eduardo Habkost wrote:
> The function will be used outside qom/object.c, to simplify the
> field property code that sets the property default value.
>
> Signed-off-by: Eduardo Habkost
>
Reviewed-by: Marc-André Lureau
---
> include/qom/object.h | 11
There are more requests in other bug tickets:
- 1366x768 (from https://bugs.launchpad.net/qemu/+bug/1054558)
- 1080 wide x 1920 high (from
https://bugs.launchpad.net/qemu/+bug/1665789)
... so these should be considered, too, I think.
--
You received this bug notification because you are a
*** This bug is a duplicate of bug 1022023 ***
https://bugs.launchpad.net/bugs/1022023
I noticed that we have multiple tickets for more resolutions opened.
Let's consolidate all in https://bugs.launchpad.net/qemu/+bug/1022023
and close this one here as duplicate.
** This bug has been marked
On Tue, Nov 17, 2020 at 2:45 AM Eduardo Habkost wrote:
> Using QLitObject lets us get rid of most of the
> .set_default_value functions, and just use
> object_property_set_default() directly.
>
> Signed-off-by: Eduardo Habkost
>
Reviewed-by: Marc-André Lureau
---
> Changes v1 -> v2:
> *
On Wed, Nov 11, 2020 at 12:43:21PM +, Stefan Hajnoczi wrote:
> The vhost-user-blk server test was already in Michael Tsirkin's recent vhost
> pull request, but was dropped because it exposed vhost-user regressions
> (b7c1bd9d7848 and the Based-on tag below). Now that the vhost-user regressions
From: Stefan Hajnoczi
The --enable/disable-vhost-user-blk-server options were implemented in
./configure. There has been confusion about them and part of the problem
is that the shell syntax used for setting the default value is not easy
to read. Move the option over to meson where the
From: Philippe Mathieu-Daudé
GCC 9.3.0 thinks that 'method' can be left uninitialized. This code
is already in the "if (bsel || pcihp_bridge_en)" block statement,
but it isn't smart enough to figure it out.
Restrict the code to be used only in the "if (bsel || pcihp_bridge_en)"
block statement
The following changes since commit c6f28ed5075df79fef39c500362a3f4089256c9c:
Update version for v5.2.0-rc1 release (2020-11-10 22:29:57 +)
are available in the Git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
for you to fetch changes up to
Ok, then let's mark this ticket as WONTFIX since nobody will be working
on it in the near future.
** Changed in: qemu
Status: New => Won't Fix
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
From: AlexChen
The size of env->mmu.regs is 3, but the range of 'rn' is [0, 5].
To avoid data access out of bounds, only if 'rn' is less than 3, we
can print env->mmu.regs[rn]. In other cases, we can print
env->mmu.regs[MMU_R_TLBX].
Reported-by: Euler Robot
Signed-off-by: Alex Chen
Compilation of pc-bios/optionrom fails on Haiku with:
BUILD pvh.img
ld: pvh_main.o: in function `pvh_load_kernel':
pc-bios/optionrom/pvh_main.c:73: undefined reference to `GLOBAL_OFFSET_TABLE_'
Makefile:57: recipe for target 'pvh.img' failed
make[1]: *** [pvh.img] Error 1
Let's simply
From: Philippe Mathieu-Daudé
Last use of qemu_bswap_len() has been removed in commit
e5fd1eb05ec ("apb: add busA qdev property to PBM PCI bridge").
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20200928131934.739451-2-phi...@redhat.com>
Signed-off-by:
On Tue, Nov 17, 2020 at 2:43 AM Eduardo Habkost wrote:
> qnum_get_double() won't change the object, the argument can be
> const.
>
> Signed-off-by: Eduardo Habkost
>
No idea why I didn't make it const in the first place.
Reviewed-by: Marc-André Lureau
---
> include/qapi/qmp/qnum.h | 2 +-
>
On 16/11/20 21:03, Jessica Clarke wrote:
Buglink: https://bugs.launchpad.net/qemu/+bug/1894836
Signed-off-by: Jessica Clarke
---
target/i386/hvf/x86_cpuid.c | 4
1 file changed, 4 insertions(+)
diff --git a/target/i386/hvf/x86_cpuid.c b/target/i386/hvf/x86_cpuid.c
index
From: Gan Qixin
The category of the ssd0323 device is not set, put it into the 'display'
category.
Signed-off-by: Gan Qixin
Reviewed-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20201112125824.763182-2-ganqi...@huawei.com>
Signed-off-by: Thomas Huth
---
From: Rebecca Cran
Update containers.yml to use the $CI_REGISTRY variable as other files
such as edk2.yml do.
Signed-off-by: Rebecca Cran
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20201113172519.31056-1-rebe...@nuviainc.com>
Signed-off-by: Thomas Huth
---
.gitlab-ci.d/containers.yml
From: Gan Qixin
The category of the ads7846 device is not set, put it into the 'input'
category.
Signed-off-by: Gan Qixin
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Peter Maydell
Message-Id: <20201112125824.763182-3-ganqi...@huawei.com>
Signed-off-by: Thomas Huth
---
Eduardo Habkost writes:
> On Mon, Nov 16, 2020 at 10:20:04AM -0600, Eric Blake wrote:
>> On 11/16/20 7:10 AM, Roman Bolshakov wrote:
>> > There's a problem for management applications to determine if certain
>> > accelerators available. Generic QMP command should help with that.
>> >
>> >
On 11/17/20 8:38 AM, Paolo Bonzini wrote:
On 17/11/20 07:55, Hannes Reinecke wrote:
On 11/16/20 11:00 PM, Paolo Bonzini wrote:
On 16/11/20 20:05, Hannes Reinecke wrote:
+ if (sreq->host_status == SCSI_HOST_OK) {
+ SCSISense sense;
+
+ sreq->status =
On Mon, 16 Nov 2020 16:42:35 -0500
Matthew Rosato wrote:
> Hot-unplugging a vfio-pci device on s390x causes a QEMU crash:
>
> qemu-system-s390x: ../softmmu/memory.c:2772:
> do_address_space_destroy: Assertion `QTAILQ_EMPTY(>listeners)' failed.
>
> In s390, the IOMMU address space is freed
Eric Blake writes:
> Instead of taking a list parameter and returning a new head at a
> distance, just return the new item for the caller to insert into a
> list via QAPI_LIST_PREPEND.
>
> Signed-off-by: Eric Blake
> ---
> migration/migration.c | 22 +-
> 1 file changed, 9
On Mon, Nov 16, 2020 at 02:38:12PM +, Stefan Hajnoczi wrote:
> On Wed, Nov 11, 2020 at 03:41:59PM +, Dr. David Alan Gilbert wrote:
> > * Stefan Hajnoczi (stefa...@redhat.com) wrote:
> > > On Wed, Nov 11, 2020 at 12:56:26PM +, Dr. David Alan Gilbert wrote:
> > > > * Stefan Hajnoczi
On Solaris and Haiku, the _IO() macros are defined in .
Add a proper check for this header to our build system, and make sure
to include the header in tpm_ioctl.h to fix a build failure on Solaris
and Haiku.
Message-Id: <20201115152317.42752-1-th...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé
From: Gan Qixin
The category of the max111x device is not set, put it into the 'misc'
category.
Signed-off-by: Gan Qixin
Reviewed-by: Thomas Huth
Message-Id: <20201112125824.763182-5-ganqi...@huawei.com>
Signed-off-by: Thomas Huth
---
hw/misc/max111x.c | 1 +
1 file changed, 1 insertion(+)
From: Gan Qixin
The category of the nand device is not set, put it into the 'storage'
category.
Signed-off-by: Gan Qixin
Reviewed-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20201112125824.763182-4-ganqi...@huawei.com>
Signed-off-by: Thomas Huth
---
hw/block/nand.c | 1
On 17/11/20 11:08, Bin Meng wrote:
I see. Is there any chance you could write a testcase for
kvm-unit-tests? Or just explain how to write such a test, and then I
can write it myself; it's not clear to me how the guest can observe the
base and limit of a non-present segment.
I am not familiar
If your file is "ELF 32-bit MSB executable, MIPS, N32 MIPS64 rel2 version 1",
then you have to use the mipsn32-linux-user variant of QEMU (binary
'qemu-mipsn32').
** Changed in: qemu
Status: Incomplete => Invalid
** Tags added: mips
--
You received this bug notification because you are
Fixed by commits 4ac4e7281a2..1a9925e3390.
** Changed in: qemu
Status: New => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1900155
Title:
MIPS Malta fails booting due to IDE
On 11/17/20 12:43 PM, Cornelia Huck wrote:
> On Sun, 01 Nov 2020 14:02:46 -0700
> Alex Williamson wrote:
>
>> From: Pierre Morel
>>
>> We use a S390PCIGroup structure to hold the information related to a
>> zPCI Function group.
>>
>> This allows us to be ready to support multiple groups and to
This patch adds trace events for virtio-pmem functionality.
Adding trace events for virtio pmem request, reponse and host
side fsync functionality.
Signed-off-by: Pankaj Gupta
---
hw/virtio/trace-events | 5 +
hw/virtio/virtio-pmem.c | 4
2 files changed, 9 insertions(+)
diff --git
iotest 277 fails on Fedora 33 (Python 3.9) because a deprecation warning
changes the output:
nbd-fault-injector.py:230: DeprecationWarning: This method will be
removed in future versions. Use 'parser.read_file()' instead.
In fact, readfp() has already been deprecated in Python 3.2 and
Commit 02c4bdf1 tried to make signal=on the default for stdio chardevs
except for '-serial mon:stdio', but it forgot about QMP and accidentally
switched the QMP default from true (except for -nographic) to false
(always). The documentation was kept unchanged and still describes the
opposite of the
From: Maxim Levitsky
On Linux, fallocate(fd, FALLOC_FL_PUNCH_HOLE) when it is used on a block device,
without O_DIRECT can return -EBUSY if it races with another write to the same
page.
Since this is rare and discard is not a critical operation, ignore this error
Signed-off-by: Maxim Levitsky
The following changes since commit bce36c6c5436c0c2679b42c6de54de5393dfcf59:
Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' into
staging (2020-11-16 22:29:51 +)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you
On Tue, 17 Nov 2020 13:01:15 +0100
Philippe Mathieu-Daudé wrote:
> Fix an endianness issue reported by Cornelia:
>
> > s390x tcg guest on x86, virtio-pci devices are not detected. The
> > relevant feature bits are visible to the guest. Same breakage with
> > different guest kernels.
> > KVM
On 11/17/20 2:00 PM, Peter Maydell wrote:
On Tue, 17 Nov 2020 at 12:03, Philippe Mathieu-Daudé wrote:
Fix an endianness issue reported by Cornelia:
s390x tcg guest on x86, virtio-pci devices are not detected. The
relevant feature bits are visible to the guest. Same breakage with
The TMP105 datasheet (https://www.ti.com/lit/gpn/tmp105) says that the
power-up reset values for the T_low and T_high registers are 80 degrees C
and 75 degrees C, which are 0x500 and 0x4B0 hex according to table 5. These
values are then shifted right by four bits to give the register reset
From: Philippe Mathieu-Daudé
Fix Coverity CID 1435957: Memory - illegal accesses (OVERRUN):
>>> Overrunning array "suffixes" of 7 8-byte elements at element
index 7 (byte offset 63) using index "idx" (which evaluates to 7).
Note, the biggest input value freq_to_str() can accept is
On 11/17/20 8:31 AM, Cornelia Huck wrote:
On Tue, 17 Nov 2020 14:23:57 +0100
Pierre Morel wrote:
On 11/17/20 2:00 PM, Peter Maydell wrote:
On Tue, 17 Nov 2020 at 12:03, Philippe Mathieu-Daudé wrote:
Fix an endianness issue reported by Cornelia:
s390x tcg guest on x86, virtio-pci
On Mon, 16 Nov 2020 10:06:26 -0800
Ben Widawsky wrote:
> On 20-11-16 17:21:07, Jonathan Cameron wrote:
> > On Tue, 10 Nov 2020 21:46:59 -0800
> > Ben Widawsky wrote:
> >
> > > Introduce emulation of Compute Express Link 2.0, which was released
> > > today at
On Mon, 16 Nov 2020 13:11:16 -0800
Ben Widawsky wrote:
> On 20-11-16 13:07:56, Jonathan Cameron wrote:
> > On Tue, 10 Nov 2020 21:47:03 -0800
> > Ben Widawsky wrote:
> >
> > > A CXL device is a type of CXL component. Conceptually, a CXL device
> > > would be a leaf node in a CXL topology.
Le 17/11/2020 à 12:19, Laurent Vivier a écrit :
> Fix "-d unimp" trace results:
>
> Unknown QEMU_IFLA_BRPORT type 35
> Unknown QEMU_IFLA_BRPORT type 36
>
> Also process IFLA_EXT_MASK to fix:
>
> Unknown target QEMU_IFLA type: 29
>
> Signed-off-by: Laurent Vivier
> ---
>
On 11/17/20 9:13 AM, Cornelia Huck wrote:
On Tue, 17 Nov 2020 09:02:37 -0500
Matthew Rosato wrote:
On 11/17/20 8:31 AM, Cornelia Huck wrote:
On Tue, 17 Nov 2020 14:23:57 +0100
Pierre Morel wrote:
On 11/17/20 2:00 PM, Peter Maydell wrote:
On Tue, 17 Nov 2020 at 12:03, Philippe
On 11/9/2020 6:45 PM, Salil Mehta wrote:
Hi Fangying,
A trivial thing. This patch looks bit of a noise in this patch-set. Better
to send it as a separate patch-set and get it accepted.
Hmm, this patch looks like a code reactor for the somewhat confusing
*smp_cpus* which will tidy the code.
hi yuanjungong,
You can send a patch to qemu-devel mailing
list(https://wiki.qemu.org/MailingLists) to fix this memleak according to
https://wiki.qemu.org/Contribute/SubmitAPatch.
Thanks.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to
ping???
On 11/9/20 3:16 PM, Philippe Mathieu-Daudé wrote:
> Cc'ing PCI developers (rc2 is scheduled for tomorrow).
>
> On 11/7/20 9:59 AM, Philippe Mathieu-Daudé wrote:
>> Ping for 5.2 as this is a bugfix.
>>
>> On 10/13/20 12:22 PM, Philippe Mathieu-Daudé wrote:
>>> set_pci_host_devaddr() is
Alex Chen writes:
> On 2020/11/17 0:50, Thomas Huth wrote:
>> On 28/10/2020 14.45, AlexChen wrote:
>>> Either accept() fails or exits normally, we need to close the fd.
>>>
>>> Reported-by: Euler Robot
>>> Signed-off-by: AlexChen
>>> ---
>>> contrib/plugins/lockstep.c | 2 ++
>>> 1 file
Update the F: line after the Meson refactor.
Fixes: 1bb4cb1c338..73362fc0b0c ("default-configs: ...")
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index
On Thu, Nov 12, 2020 at 07:13:37PM -0600, Eric Blake wrote:
> Anywhere we create a list of just one item or by prepending items
> (typically because order doesn't matter), we can use the now-public
> macro. But places where we must keep the list in order by appending
> remain open-coded until
On Fri, Nov 13, 2020 at 07:12:16AM +0100, Markus Armbruster wrote:
> Clean up includes so that osdep.h is included first and headers
> which it implies are not included manually.
>
> This commit was created with scripts/clean-includes, with the changes
> to the following files manually reverted:
On Tue, 17 Nov 2020 12:55:22 +0100
Philippe Mathieu-Daudé wrote:
> On 11/17/20 12:43 PM, Cornelia Huck wrote:
> > On Sun, 01 Nov 2020 14:02:46 -0700
> > Alex Williamson wrote:
> >
> >> From: Pierre Morel
> >>
> >> We use a S390PCIGroup structure to hold the information related to a
> >>
From: Max Reitz
Test what happens when a rewrite-corrupted quorum node performs such a
rewrite, while there is no parent that has taken the WRITE permission.
Signed-off-by: Max Reitz
Message-Id: <20201113211718.261671-4-mre...@redhat.com>
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/081
From: Max Reitz
Using rewrite-corrupted means quorum may issue writes to its children
just from receiving read requests from its parents. Thus, it must take
the WRITE permission when rewrite-corrupted is used.
Signed-off-by: Max Reitz
Message-Id: <20201113211718.261671-2-mre...@redhat.com>
From: Paolo Bonzini
Even though only the pointer value is only printed, it is untidy
and Coverity complains.
Cc: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
Message-Id: <20201113154102.1460459-1-pbonz...@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Kevin Wolf
---
ping?
On 11/2/20 3:42 PM, Philippe Mathieu-Daudé wrote:
> We disabled the virtio_check_params tests in commit 2d6a6e238a2
> ("tests/acceptance/virtio_check_params: Disable the test"),
> because these tests were making multiarch CI fail (virtio is
> multiarch).
>
> We took the big hammer, as we
On Thu, Nov 12, 2020 at 05:19:01PM -0600, Mike Christie wrote:
> diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c
> index f22fce5..8795fd3 100644
> --- a/drivers/vhost/scsi.c
> +++ b/drivers/vhost/scsi.c
> @@ -1468,8 +1468,8 @@ static void vhost_scsi_flush(struct vhost_scsi *vs)
> /*
From: Andrew Jones
The removal of the selection of A15MPCORE from ARM_VIRT also
removed what A15MPCORE selects, ARM_GIC. We still need ARM_GIC.
Fixes: bec3c97e0cf9 ("hw/arm/virt: Remove dependency on Cortex-A15 MPCore
peripherals")
Reported-by: Miroslav Rezanina
Signed-off-by: Andrew Jones
In the mtspr helper we attempt to check for "is the timer disabled"
with "if (env->ttmr & TIMER_NONE)". This is wrong because TIMER_NONE
is zero and the condition is always false (Coverity complains about
the dead code.)
The correct check would be to test whether the TTMR_M field in the
register
://git.linaro.org/people/pmaydell/qemu-arm.git
tags/pull-target-arm-20201117
for you to fetch changes up to ab135622cf478585bdfcb68b85e4a817d74a0c42:
tmp105: Correct handling of temperature limit checks (2020-11-17 12:56:33
+)
target-arm
Paolo Bonzini writes:
> On 17/11/20 10:20, Markus Armbruster wrote:
>>> -chardev = ('socket,id=console,path=%s,server,nowait' %
>>> +chardev = ('socket,id=console,path=%s,server=yes,wait=no' %
>>
>> Let's stick to the canonical 'on' and 'off'.
>
> That was on purpose
On Mon, 16 Nov 2020 14:01:40 -0800
Ben Widawsky wrote:
> On 20-11-16 16:44:09, Jonathan Cameron wrote:
> > On Tue, 10 Nov 2020 21:47:10 -0800
> > Ben Widawsky wrote:
> >
> > > This works like adding a typical pxb device, except the name is
> > > 'pxb-cxl' instead of 'pxb-pcie'. An example
Fix "-d unimp" trace results:
Unknown QEMU_IFLA_BRPORT type 35
Unknown QEMU_IFLA_BRPORT type 36
Also process IFLA_EXT_MASK to fix:
Unknown target QEMU_IFLA type: 29
Signed-off-by: Laurent Vivier
---
linux-user/fd-trans.c | 11 +++
1 file changed, 11 insertions(+)
diff --git
The QEMU project is currently considering to move its bug tracking to another
system. For this we need to know which bugs are still valid and which could be
closed already. Thus we are setting older bugs to "Incomplete" now.
If you still think this bug report here is valid, then please switch
From: Max Reitz
Otherwise, this breaks whenever the test directory contains the image
format (e.g. "/tmp/test-raw-file" is filtered to "/tmp/test-IMGFMT-file"
instead of "TEST_DIR").
Signed-off-by: Max Reitz
Message-Id: <20201113211718.261671-3-mre...@redhat.com>
Signed-off-by: Kevin Wolf
---
On 17/11/20 12:46, Daniel P. Berrangé wrote:
On Tue, Nov 17, 2020 at 12:38:50PM +0100, Paolo Bonzini wrote:
cURL 7.16.0 was released in October 2006. Just remove code that is
in all likelihood not being used anywhere.
Rather than assuming that, we should be picking our minimum version
and
On Tue, Nov 17, 2020 at 01:40:56PM +0100, Paolo Bonzini wrote:
> On 17/11/20 12:46, Daniel P. Berrangé wrote:
> > On Tue, Nov 17, 2020 at 12:38:50PM +0100, Paolo Bonzini wrote:
> > > cURL 7.16.0 was released in October 2006. Just remove code that is
> > > in all likelihood not being used
On Thu, Nov 12, 2020 at 05:19:03PM -0600, Mike Christie wrote:
> We use like 3 coding styles in this struct. Switch to just tabs.
>
> Signed-off-by: Mike Christie
> Reviewed-by: Chaitanya Kulkarni
> ---
> drivers/vhost/vhost.h | 12 ++--
> 1 file changed, 6 insertions(+), 6
On Tue, 17 Nov 2020 14:12:00 +0100
Philippe Mathieu-Daudé wrote:
> On 11/17/20 2:00 PM, Peter Maydell wrote:
> > On Tue, 17 Nov 2020 at 12:03, Philippe Mathieu-Daudé
> > wrote:
> >>
> >> Fix an endianness issue reported by Cornelia:
> >>
> >>> s390x tcg guest on x86, virtio-pci devices are
> -Original Message-
> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
> Sent: Monday, November 16, 2020 10:05 PM
> To: ganqixin ; qemu-devel@nongnu.org;
> qemu-triv...@nongnu.org; Marc-André Lureau
> ; th...@redhat.com
> Cc: Chenqun (kuhn) ; Zhanghailiang
> ; Gerd Hoffmann ;
>
In commit 5edab03d4040 we added tracepoints to the ps2 keyboard
and mouse emulation. However we didn't remove all the debug-by-printf
support. In fact there is only one printf() remaining, and it is
redundant with the trace_ps2_write_mouse() event next to it.
Remove the printf() and the now-unused
From: Alex Chen
We should use printf format specifier "%u" instead of "%d" for
argument of type "unsigned int".
Reported-by: Euler Robot
Signed-off-by: Alex Chen
Message-id: 2020073651.72804-1-alex.c...@huawei.com
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
From: Alistair Francis
This patch fixes CID 1432800 by removing an unnecessary check.
Signed-off-by: Alistair Francis
Reviewed-by: Peter Maydell
Signed-off-by: Peter Maydell
---
hw/core/register.c | 4
1 file changed, 4 deletions(-)
diff --git a/hw/core/register.c b/hw/core/register.c
On Tue, 17 Nov 2020 09:02:37 -0500
Matthew Rosato wrote:
> On 11/17/20 8:31 AM, Cornelia Huck wrote:
> > On Tue, 17 Nov 2020 14:23:57 +0100
> > Pierre Morel wrote:
> >
> >> On 11/17/20 2:00 PM, Peter Maydell wrote:
> >>> On Tue, 17 Nov 2020 at 12:03, Philippe Mathieu-Daudé
> >>> wrote:
On 17/11/20 09:50, Hannes Reinecke wrote:
Since we're right in the middle of the freeze, let me send a RFC patch
for Linux to clean up DID_* a little bit.
What's your intention there? I do have (of course) a larger patchset for
revisiting the SCSI status codes, so I could resubmit those
** Tags added: linux-user mips
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1858461
Title:
Please refactor linux-user/mips/cpu_loop.c
Status in QEMU:
New
Bug description:
Hello. I am
cURL 7.16.0 was released in October 2006. Just remove code that is
in all likelihood not being used anywhere.
Signed-off-by: Paolo Bonzini
---
block/curl.c | 28
1 file changed, 28 deletions(-)
diff --git a/block/curl.c b/block/curl.c
index 4f907c47be..b77bfe12e7
1 - 100 of 300 matches
Mail list logo
