Re: [qemu PATCH] docs: fix missing backslash in certtool shell example

2020-11-27 Thread Peter Maydell
On Fri, 27 Nov 2020 at 10:34, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > --- > docs/system/tls.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/system/tls.rst b/docs/system/tls.rst > index dc2b94257f..b0973afe1b 100644 > ---

Re: [PATCH 4/8] arm: Synchronize CPU on PSCI on

2020-11-27 Thread Alexander Graf
On 27.11.20 05:41, Paolo Bonzini wrote: On 27/11/20 00:32, Alexander Graf wrote: On 26.11.20 23:26, Peter Maydell wrote: On Thu, 26 Nov 2020 at 22:16, Alexander Graf wrote: cpu_synchronize_state() sets the CPU registers into "dirty" state which means that env now holds the current copy.

Re: [PATCH 28/36] vl: allow -incoming defer with -preconfig

2020-11-27 Thread Igor Mammedov
On Mon, 23 Nov 2020 09:14:27 -0500 Paolo Bonzini wrote: > Now that there is no RUN_STATE_PRECONFIG anymore that can conflict with > RUN_STATE_INMIGRATE, we can allow -incoming defer with -preconfig. > > Signed-off-by: Paolo Bonzini Reviewed-by: Igor Mammedov > --- > softmmu/vl.c | 5 ++---

Re: [PATCH for-6.0 6/6] qapi: Deprecate 'query-kvm'

2020-11-27 Thread Daniel P . Berrangé
Copying libvir-list for the deprecation warning. On Mon, Nov 16, 2020 at 04:10:11PM +0300, Roman Bolshakov wrote: > 'query-accel' QMP command should be used instead. > > Signed-off-by: Roman Bolshakov > --- > qapi/machine.json | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-)

Re: [PATCH 26/36] remove preconfig state

2020-11-27 Thread Igor Mammedov
On Fri, 27 Nov 2020 06:19:51 +0100 Paolo Bonzini wrote: > On 26/11/20 19:55, Igor Mammedov wrote: > > On Mon, 23 Nov 2020 09:14:25 -0500 > > Paolo Bonzini wrote: > > > >> The preconfig state is only used if -incoming is not specified, which > >> makes the RunState state machine more tricky

Re: [PATCH for-6.0 2/6] qapi: Rename KvmInfo to AccelInfo

2020-11-27 Thread Dr. David Alan Gilbert
* Roman Bolshakov (r.bolsha...@yadro.com) wrote: > There's nothing specific to KVM in the structure. A more generic name > would be more appropriate. > > Signed-off-by: Roman Bolshakov For HMP: Acked-by: Dr. David Alan Gilbert Markus/Eric: Is it OK from QMP to change the type like that?

Re: [PATCH for-6.0 5/6] hmp: Add 'info accel' command

2020-11-27 Thread Dr. David Alan Gilbert
* Roman Bolshakov (r.bolsha...@yadro.com) wrote: > The command is made after 'info kvm' and aims to replace it as more > generic one. > > If used without parameters, the command can used to get current > accelerator. Otherwise, it may be used to determine if an accelerator is > available. Here's

[qemu PATCH] docs: fix missing backslash in certtool shell example

2020-11-27 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- docs/system/tls.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/system/tls.rst b/docs/system/tls.rst index dc2b94257f..b0973afe1b 100644 --- a/docs/system/tls.rst +++ b/docs/system/tls.rst @@ -64,7 +64,7 @@ interactive prompts

Re: ImageInfo oddities regarding compression

2020-11-27 Thread Kevin Wolf
Am 27.11.2020 um 11:14 hat Daniel P. Berrangé geschrieben: > On Fri, Nov 27, 2020 at 11:06:36AM +0100, Markus Armbruster wrote: > > ImageInfo has an optional member @compressed: > > > > ## > > # @ImageInfo: > > [...] > > # @compressed: true if the image is compressed (Since 1.7)

Re: [PATCH 13/36] vl: move semihosting command line fallback to qemu_init_board

2020-11-27 Thread Igor Mammedov
On Fri, 27 Nov 2020 06:03:43 +0100 Paolo Bonzini wrote: > On 26/11/20 18:10, Igor Mammedov wrote: > > On Mon, 23 Nov 2020 09:14:12 -0500 > > Paolo Bonzini wrote: > > > >> Move more sane parts of the huge qemu_init function out of it. > >> > >> Signed-off-by: Paolo Bonzini > >> --- > >>

Re: ImageInfo oddities regarding compression

2020-11-27 Thread Daniel P . Berrangé
On Fri, Nov 27, 2020 at 11:06:36AM +0100, Markus Armbruster wrote: > ImageInfo has an optional member @compressed: > > ## > # @ImageInfo: > [...] > # @compressed: true if the image is compressed (Since 1.7) > > Doc bug: neglects to specify the default. I guess it's false. > >

ImageInfo oddities regarding compression

2020-11-27 Thread Markus Armbruster
ImageInfo has an optional member @compressed: ## # @ImageInfo: [...] # @compressed: true if the image is compressed (Since 1.7) Doc bug: neglects to specify the default. I guess it's false. The only user appears to be vmdk_get_extent_info(). Goes back to v1.7.0's commits

Re: [PATCH v4 0/6] UFFD write-tracking migration/snapshots

2020-11-27 Thread Andrey Gruzdev
On 27.11.2020 12:49, Peter Krempa wrote: On Fri, Nov 27, 2020 at 11:21:39 +0300, Andrey Gruzdev wrote: On 26.11.2020 18:47, Peter Krempa wrote: On Thu, Nov 26, 2020 at 18:17:28 +0300, Andrey Gruzdev via wrote: This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas he's

Re: [PATCH v4 0/6] UFFD write-tracking migration/snapshots

2020-11-27 Thread Peter Krempa
On Fri, Nov 27, 2020 at 11:21:39 +0300, Andrey Gruzdev wrote: > On 26.11.2020 18:47, Peter Krempa wrote: > > On Thu, Nov 26, 2020 at 18:17:28 +0300, Andrey Gruzdev via wrote: > > > This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas > > > he's > > > implemented in his series

Re: [PATCH 1/6] migration: Add multi-thread compress method

2020-11-27 Thread Markus Armbruster
Kevin, Max, suggest to skip right to Qcow2CompressionType. Zeyu Jin writes: > A multi-thread compress method parameter is added to hold the method we > are going to use. By default the 'zlib' method is used to maintain the > compatibility as before. > > Signed-off-by: Zeyu Jin > Signed-off-by:

Re: [PATCH v2] qga/commands-posix: Send CCW address on s390x with the fsinfo data

2020-11-27 Thread Cornelia Huck
On Fri, 27 Nov 2020 09:23:53 +0100 Thomas Huth wrote: > We need the CCW address on the libvirt side to correctly identify > the disk, so add this information to the GuestDiskAddress on s390x. > > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1755075 > Signed-off-by: Thomas Huth > --- >

[PATCH v2 0/6] migration: Multi-thread compression method support

2020-11-27 Thread Zeyu Jin
Currently we have both multi-thread compression and multifd to optimize live migration in Qemu. Mulit-thread compression deals with the situation where network bandwith is limited but cpu resource adequate. Multifd instead aims to take full advantage of network bandwith. Moreover it supports both

[PATCH v2 5/6] migration: Add compress_level sanity check

2020-11-27 Thread Zeyu Jin
Zlib compression has level from 1 to 9. However Zstd compression has level from 1 to 22 (level >= 20 not recommanded). Let's do sanity check here to make sure a vaild compress_level is given by user. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- migration/migration.c | 32

[PATCH v2 4/6] migration: Add zstd support in multi-thread compression

2020-11-27 Thread Zeyu Jin
This patch enables zstd option in multi-thread compression. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- hw/core/qdev-properties-system.c | 2 +- migration/ram.c | 128 ++- qapi/migration.json | 2 +- 3 files changed, 129

[PATCH v2 3/6] migration: Add multi-thread compress ops

2020-11-27 Thread Zeyu Jin
Add the MigrationCompressOps and MigrationDecompressOps structures to make the compression method configurable for multi-thread compression migration. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang parameters.decompress_threads; } +CompressMethod migrate_compress_method(void) +{ +

[PATCH v2 6/6] doc: Update multi-thread compression doc

2020-11-27 Thread Zeyu Jin
Modify the doc to fit the previous changes. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- docs/multi-thread-compression.txt | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/docs/multi-thread-compression.txt

[PATCH v2 1/6] migration: Add multi-thread compress method

2020-11-27 Thread Zeyu Jin
A multi-thread compress method parameter is added to hold the method we are going to use. By default the 'zlib' method is used to maintain the compatibility as before. Signed-off-by: Zeyu Jin Signed-off-by: Ying Fang --- hw/core/qdev-properties-system.c | 11 +++

[PATCH v2 2/6] migration: Refactoring multi-thread compress migration

2020-11-27 Thread Zeyu Jin
Code refactor for the compression procedure which includes: 1. Move qemu_compress_data and qemu_put_compression_data from qemu-file.c to ram.c, for the reason that most part of the code logical has nothing to do with qemu-file. Besides, the decompression code is located at ram.c only. 2.

[PATCH v2 0/6]

2020-11-27 Thread Zeyu Jin
Currently we have both multi-thread compression and multifd to optimize live migration in Qemu. Mulit-thread compression deals with the situation where network bandwith is limited but cpu resource adequate. Multifd instead aims to take full advantage of network bandwith. Moreover it supports both

Re: [PATCH 1/2] keyval: accept escaped commas in implied option

2020-11-27 Thread Paolo Bonzini
[huge snip] On 27/11/20 09:38, Markus Armbruster wrote: The suboptimal error message is due to the way I coded the parser, not due to the grammar. Small digression: a different grammar influences how the parser is written. You coded the parser like this because you thought of implied

Re: [PATCH 0/1] net: Fix handling of id in netdev_add and netdev_del

2020-11-27 Thread Markus Armbruster
Jason Wang writes: > On 2020/11/25 下午6:02, Markus Armbruster wrote: >> This is a regression fix, but the regression is already in 5.0. I >> think it's too late for 5.2. If I'm right, then the issue should be >> documented in the release notes (I can do that). > > > Please do that and I've

Re: [PATCH] virtfs-proxy-helper: Fix a resource leak in main()

2020-11-27 Thread Greg Kurz
On Thu, 26 Nov 2020 19:44:24 +0100 Christian Schoenebeck wrote: [...] > > The only justification that'd deserve to be in the changelog of > > such a patch is something like "because this is good practice > > to rollback in case code moves to another function than main()". > > Well, the actual

Re: [PATCH v2 2/6] accel: accel_available() function

2020-11-27 Thread Claudio Fontana
On 11/26/20 10:48 PM, Eduardo Habkost wrote: > On Thu, Nov 26, 2020 at 10:06:03PM +0100, Claudio Fontana wrote: >> On 11/26/20 3:25 PM, Paolo Bonzini wrote: >>> On 26/11/20 15:13, Claudio Fontana wrote: One option I see is simply to document the behavior where accel_available() is

Re: [RFC v6 10/11] accel: introduce AccelCPUClass extending CPUClass

2020-11-27 Thread Claudio Fontana
On 11/27/20 7:21 AM, Paolo Bonzini wrote: > On 26/11/20 23:32, Claudio Fontana wrote: >> +if (acc) { >> +object_class_foreach(accel_init_cpu_int_aux, cpu_type, false, acc); >> +} > > Any reason to do it for cpu_type only, rather than for all subclasses of > CPU_RESOLVING_TYPE?

Re: [PATCH 1/2] keyval: accept escaped commas in implied option

2020-11-27 Thread Markus Armbruster
Paolo Bonzini writes: > This is used with the weirdly-named device "SUNFD,two", so accepting it "SUNW,fdtwo" > is also a preparatory step towards keyval-ifying -device and the > device_add monitor command. Not quite. Device "SUNW,fdtwo" has user_creatable = false (it's a sysbus device), and

[PATCH v2] qga/commands-posix: Send CCW address on s390x with the fsinfo data

2020-11-27 Thread Thomas Huth
We need the CCW address on the libvirt side to correctly identify the disk, so add this information to the GuestDiskAddress on s390x. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1755075 Signed-off-by: Thomas Huth --- v2: Add missing comment about "subchno" (thanks to Cornelia for

Re: [PATCH v4 0/6] UFFD write-tracking migration/snapshots

2020-11-27 Thread Andrey Gruzdev
On 26.11.2020 18:47, Peter Krempa wrote: On Thu, Nov 26, 2020 at 18:17:28 +0300, Andrey Gruzdev via wrote: This patch series is a kind of 'rethinking' of Denis Plotnikov's ideas he's implemented in his series '[PATCH v0 0/4] migration: add background snapshot'. Currently the only way to make

<    1   2   3