Re: [PATCH 0/9] target/mips: Simplify MSA TCG logic

2020-12-02 Thread Jiaxun Yang
在 2020/12/3 上午2:44, Philippe Mathieu-Daudé 写道: I converted MSA opcodes to decodetree. To keep the series small I split it in 2, this is the non-decodetree specific patches (so non-decodetree experts can review it ;) ). First we stop using env->insn_flags to check for MSAi presence, then we

Re: [PATCH v3 07/10] arm: Add Hypervisor.framework build target

2020-12-02 Thread Roman Bolshakov
On Wed, Dec 02, 2020 at 08:04:05PM +0100, Alexander Graf wrote: > Now that we have all logic in place that we need to handle > Hypervisor.framework > on Apple Silicon systems, let's add CONFIG_HVF for aarch64 as well so that we > can build it. > > Signed-off-by: Alexander Graf > > --- > > v1

Re: [PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Alexander Graf
On 02.12.20 23:46, Frank Yang wrote: On Wed, Dec 2, 2020 at 2:28 PM Alexander Graf > wrote: On 02.12.20 23:19, Frank Yang wrote: From downstream: https://android-review.googlesource.com/c/platform/external/qemu/+/1515002

Re: [PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Peter Collingbourne
On Wed, Dec 2, 2020 at 3:26 PM Frank Yang wrote: > > > > On Wed, Dec 2, 2020 at 2:57 PM Alexander Graf wrote: >> >> >> On 02.12.20 23:46, Frank Yang wrote: >> >> >> >> On Wed, Dec 2, 2020 at 2:28 PM Alexander Graf wrote: >>> >>> >>> On 02.12.20 23:19, Frank Yang wrote: >>> >>> >>> From

Re: [PATCH v3 04/10] arm: Set PSCI to 0.2 for HVF

2020-12-02 Thread Roman Bolshakov
On Wed, Dec 02, 2020 at 08:04:02PM +0100, Alexander Graf wrote: > In Hypervisor.framework, we just pass PSCI calls straight on to the QEMU > emulation > of it. That means, if TCG is compatible with PSCI 0.2, so are we. Let's > transpose > that fact in code too. > > Signed-off-by: Alexander Graf

Re: [PATCH for-6.0] hw/ppc: Do not re-read the clock on pre_save if doing savevm

2020-12-02 Thread David Gibson
On Wed, Dec 02, 2020 at 06:28:26PM +0100, Greg Kurz wrote: > A guest with enough RAM, eg. 128G, is likely to detect savevm downtime > and to complain about stalled CPUs. This happens because we re-read > the timebase just before migrating it and we thus don't account for > all the time between VM

Re: [PATCH v3 6/6] linux-user: Add support for MIPS Loongson 2F/3E

2020-12-02 Thread chen huacai
Hi, Philippe, On Wed, Dec 2, 2020 at 5:16 PM Philippe Mathieu-Daudé wrote: > > On 12/2/20 2:01 AM, chen huacai wrote: > > Hi, Philippe, > > > > On Wed, Dec 2, 2020 at 3:31 AM Philippe Mathieu-Daudé > > wrote: > >> > >> Userland ELF binaries using Longsoon SIMD instructions have the > >>

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread P J P
Hello Dan, Stefano, +-- On Wed, 2 Dec 2020, Stefano Stabellini wrote --+ | On Wed, 2 Dec 2020, Daniel P. Berrangé wrote: | > > + any third parties, including Xen Security Project, without your prior | > > + permission. | > | > Why this explicit note about the Xen project ? What if we decide

Re: [PATCH] xive: Add more trace events

2020-12-02 Thread David Gibson
On Fri, Nov 27, 2020 at 02:36:54PM +0100, Cédric Le Goater wrote: > These are useful to understand IRQ requests from the OS. > > Signed-off-by: Cédric Le Goater > --- > > David, Feel free to merge with the previous. Done, thanks. > > hw/intc/spapr_xive.c | 6 ++ >

Re: [PATCH v10 0/9] pci_expander_brdige:acpi: Support pxb-pcie for ARM

2020-12-02 Thread Jiahui Cen
Hi Michael, On 2020/12/2 17:53, Michael S. Tsirkin wrote: > On Thu, Nov 19, 2020 at 09:48:32AM +0800, Jiahui Cen wrote: >> Changes with v9 >> v9->v10: >> Refactor patch2 to drop useless macros and variables. >> Split patch2 into two patches. > > I tagged this for after the release. To help make

[Bug 1906156] Re: Host OS Reboot Required, for Guest kext to Load (Fully)

2020-12-02 Thread Russell Morris
Sorry for the delay on updating this - but pulling my hair out (and I'm short enough of that already ... LOL). I can't get Ubuntu to let me run the custom qemu executable. Really is looking like apparmor. Fighting with that, but struggling to have it let me run it :-(. Thanks. -- You received

Re: [PATCH] scsi: allow user to set werror as report

2020-12-02 Thread Zihao Chang
Ping? This is a fix patch which has been reviewed, whose tree should it go via? Thanks Zihao On 2020/11/3 22:03, Zihao Chang wrote: > > > On 2020/11/3 18:52, Fam Zheng wrote: >> On Tue, 2020-11-03 at 14:12 +0800, Zihao Chang wrote: >>> 'enospc' is the default for -drive, but qemu allows user

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread Stefano Stabellini
On Wed, 2 Dec 2020, Daniel P. Berrangé wrote: > On Mon, Nov 30, 2020 at 07:19:07PM +0530, P J P wrote: > > From: Prasad J Pandit > > > > We are about to introduce a qemu-security mailing list to report > > and triage QEMU security issues. > > > > Update the QEMU security process web page with

Re: [PATCH 0/9] target/mips: Simplify MSA TCG logic

2020-12-02 Thread Jiaxun Yang
在 2020/12/3 上午2:44, Philippe Mathieu-Daudé 写道: I converted MSA opcodes to decodetree. To keep the series small I split it in 2, this is the non-decodetree specific patches (so non-decodetree experts can review it ;) ). First we stop using env->insn_flags to check for MSAi presence, then we

Re: [PATCH v2] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD

2020-12-02 Thread AL Yu-Chen Cho
On Mon, 2020-11-30 at 10:14 +0100, Philippe Mathieu-Daudé wrote: > On 11/30/20 5:26 AM, Cho, Yu-Chen wrote: > > v2: > > Drop some package from dockerfile to make docker image more light. > > > > v1: > > Add build-system-opensuse jobs and opensuse-leap.docker dockerfile. > > Use openSUSE Leap 15.2

[Bug 1906516] Re: [RISCV] sfence.vma need to end the translation block

2020-12-02 Thread jinyan
** Description changed: QEMU emulator version 5.0.0 sfence.vma will flush the tlb, so after this instruction, the translation block should be end. The following code will only work in single step mode: ``` relocate: - li a0, OFFSET +  li a0, OFFSET - la t0, 1f -

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread P J P
+-- On Wed, 2 Dec 2020, Philippe Mathieu-Daudé wrote --+ | Maybe: | | 0) **Acknowledge reception** |- A non-automated response email is sent to acknowledge the | reception of the request. | This is the starting date for the maximum **60 days** required | to

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread P J P
Hello Dan, +-- On Wed, 2 Dec 2020, Daniel P. Berrangé wrote --+ | > +- If issue is found to be less severe, an upstream public bug (or an | > + issue) will be created immediately. | | No need to repeat "or an issue". I think it would read more clearly as | |- If the severity of

Re: [PATCH v3 06/10] hvf: Add Apple Silicon support

2020-12-02 Thread Roman Bolshakov
On Wed, Dec 02, 2020 at 08:04:04PM +0100, Alexander Graf wrote: > With Apple Silicon available to the masses, it's a good time to add support > for driving its virtualization extensions from QEMU. > > This patch adds all necessary architecture specific code to get basic VMs > working. It's still

Re: [PATCH v3 03/10] hvf: Introduce hvf vcpu struct

2020-12-02 Thread Roman Bolshakov
On Wed, Dec 02, 2020 at 08:04:01PM +0100, Alexander Graf wrote: > We will need more than a single field for hvf going forward. To keep > the global vcpu struct uncluttered, let's allocate a special hvf vcpu > struct, similar to how hax does it. > Reviewed-by: Roman Bolshakov Tested-by: Roman

[PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Frank Yang
>From downstream: https://android-review.googlesource.com/c/platform/external/qemu/+/1515002 Based on v3 of Alexander Graf's patches https://patchew.org/QEMU/20201202190408.2041-1-ag...@csgraf.de We need to adjust CNTVOFF_EL2 so that time doesnt warp. Even though we can set separate

Re: [PATCH v3 02/10] hvf: Move common code out

2020-12-02 Thread Roman Bolshakov
On Wed, Dec 02, 2020 at 08:04:00PM +0100, Alexander Graf wrote: > Until now, Hypervisor.framework has only been available on x86_64 systems. > With Apple Silicon shipping now, it extends its reach to aarch64. To > prepare for support for multiple architectures, let's move common code out > into

Re: [PATCH v3 05/10] hvf: arm: Mark CPU as dirty on reset

2020-12-02 Thread Roman Bolshakov
On Wed, Dec 02, 2020 at 08:04:03PM +0100, Alexander Graf wrote: > When clearing internal state of a CPU, we should also make sure that HVF > knows about it and can push the new values down to vcpu state. > I'm sorry if I'm asking something dumb. But isn't cpu_synchronize_all_post_reset() is

Re: [PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Frank Yang
We've gotten the Android Emulator snapshots working again on M1 and noticed a time warp issue where the stopwatch app would, on a snapshot load, resume including the time the emulator wasn't running. This seems to fix it. Now we have snapshots mostly working (though file backed ram is a bit

Re: [PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Alexander Graf
On 02.12.20 23:19, Frank Yang wrote: From downstream: https://android-review.googlesource.com/c/platform/external/qemu/+/1515002 Based on v3 of Alexander Graf's patches

Re: [PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Frank Yang
On Wed, Dec 2, 2020 at 2:28 PM Alexander Graf wrote: > > On 02.12.20 23:19, Frank Yang wrote: > > > From downstream: > https://android-review.googlesource.com/c/platform/external/qemu/+/1515002 > > Based on v3 of Alexander Graf's patches > >

Re: [PATCH] hw/block: m25p80: Fix fast read for SST flashes

2020-12-02 Thread Bin Meng
Hi Alistair, On Thu, Dec 3, 2020 at 3:52 AM Alistair Francis wrote: > > On Sun, Nov 29, 2020 at 6:55 PM Bin Meng wrote: > > > > From: Bin Meng > > > > SST flashes require a dummy byte after the address bits. > > > > Signed-off-by: Bin Meng > > I couldn't find a datasheet that says this... But

Re: [PATCH] hw/block: m25p80: Fix fast read for SST flashes

2020-12-02 Thread Alistair Francis
On Wed, Dec 2, 2020 at 3:09 PM Bin Meng wrote: > > Hi Alistair, > > On Thu, Dec 3, 2020 at 3:52 AM Alistair Francis wrote: > > > > On Sun, Nov 29, 2020 at 6:55 PM Bin Meng wrote: > > > > > > From: Bin Meng > > > > > > SST flashes require a dummy byte after the address bits. > > > > > >

Re: [PATCH v1 4/9] vfio: Support for RamDiscardMgr in the !vIOMMU case

2020-12-02 Thread Alex Williamson
On Thu, 19 Nov 2020 16:39:13 +0100 David Hildenbrand wrote: > Implement support for RamDiscardMgr, to prepare for virtio-mem > support. Instead of mapping the whole memory section, we only map > "populated" parts and update the mapping when notified about > discarding/population of memory via

Re: [PATCH v1 1/9] memory: Introduce RamDiscardMgr for RAM memory regions

2020-12-02 Thread Alex Williamson
On Thu, 19 Nov 2020 16:39:10 +0100 David Hildenbrand wrote: > We have some special RAM memory regions (managed by virtio-mem), whereby > the guest agreed to only use selected memory ranges. "unused" parts are > discarded so they won't consume memory - to logically unplug these memory > ranges.

Re: [PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Frank Yang
On Wed, Dec 2, 2020 at 2:57 PM Alexander Graf wrote: > > On 02.12.20 23:46, Frank Yang wrote: > > > > On Wed, Dec 2, 2020 at 2:28 PM Alexander Graf wrote: > >> >> On 02.12.20 23:19, Frank Yang wrote: >> >> >> From downstream: >>

Re: [PATCH v3 01/10] hvf: Add hypervisor entitlement to output binaries

2020-12-02 Thread Roman Bolshakov
On Wed, Dec 02, 2020 at 08:03:59PM +0100, Alexander Graf wrote: > In macOS 11, QEMU only gets access to Hypervisor.framework if it has the > respective entitlement. Add an entitlement template and automatically self > sign and apply the entitlement in the build. > > Signed-off-by: Alexander Graf

Re: [PATCH v1 1/1] hvf: arm: Properly sync guest time on migration

2020-12-02 Thread Peter Collingbourne
On Wed, Dec 2, 2020 at 2:57 PM Alexander Graf wrote: > > > On 02.12.20 23:46, Frank Yang wrote: > > > > On Wed, Dec 2, 2020 at 2:28 PM Alexander Graf wrote: >> >> >> On 02.12.20 23:19, Frank Yang wrote: >> >> >> From downstream: >>

Re: [PATCH for-6.0 v2 1/3] spapr: Improve naming of some vCPU id related items

2020-12-02 Thread David Gibson
On Mon, Nov 30, 2020 at 05:52:56PM +0100, Greg Kurz wrote: > The machine tells the IC backend the number of vCPU ids it will be > exposed to, in order to: > - fill the "ibm,interrupt-server-ranges" property in the DT (XICS) > - size the VP block used by the in-kernel chip (XICS-on-XIVE, XIVE) > >

Re: [PATCH] tests/acceptance: fix timeout for vm.wait

2020-12-02 Thread Pavel Dovgalyuk
On 02.12.2020 18:22, John Snow wrote: On 12/2/20 1:31 AM, Pavel Dovgalyuk wrote: This patch adds timeout parameter to vm.wait() calls, because the default value is just 30 seconds, and tests may last for more time. This doesn't sound right -- the timeout isn't meant to be for the entire

[PATCH v2 3/4] block/throttle-groups: Use lock guard macros

2020-12-02 Thread Gan Qixin
Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/throttle-groups. Signed-off-by: Gan Qixin --- Cc: Kevin Wolf Cc: Paolo Bonzini Cc: Markus Armbruster --- block/throttle-groups.c | 48 - 1 file

[PATCH v2 1/4] block/accounting: Use lock guard macros

2020-12-02 Thread Gan Qixin
Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/accounting. Signed-off-by: Gan Qixin Reviewed-by: Paolo Bonzini --- Cc: Kevin Wolf Cc: Markus Armbruster --- block/accounting.c | 32 +++- 1 file changed,

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread P J P
+-- On Wed, 2 Dec 2020, Daniel P. Berrangé wrote --+ | > +- If issue is found to be less severe, an upstream public bug (or an | > + issue) will be created immediately. | | No need to repeat "or an issue". I think it would read more clearly as | |- If the severity of the issue is

RE: [PATCH v2 01/12] pc-dimm: put it into the 'storage' category

2020-12-02 Thread ganqixin
> -Original Message- > From: Pankaj Gupta [mailto:pankaj.gupta.li...@gmail.com] > Sent: Monday, November 30, 2020 6:19 PM > To: ganqixin > Cc: Qemu Developers ; qemu-triv...@nongnu.org; > Chenqun (kuhn) ; th...@redhat.com; > Zhanghailiang ; Michael S . Tsirkin > > Subject: Re: [PATCH v2

[PATCH v2 2/4] block/curl: Use lock guard macros

2020-12-02 Thread Gan Qixin
Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/curl. Signed-off-by: Gan Qixin Reviewed-by: Paolo Bonzini --- Cc: Kevin Wolf Cc: Markus Armbruster --- block/curl.c | 28 ++-- 1 file changed, 14 insertions(+),

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Gerd Hoffmann
Hi, > It would be much nicer to do the wrapper the other way round, i.e. > setting properties before the device is realized would update a > configuration struct and realize would then call .create() with that > struct. To me, this sounds much harder, though also a more useful state. Well, in

RE: [PATCH 4/4] block/iscsi.c: Use lock guard macros

2020-12-02 Thread ganqixin
> -Original Message- > From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: Wednesday, December 2, 2020 7:12 PM > To: ganqixin > Cc: qemu-devel@nongnu.org; qemu-triv...@nongnu.org; > pbonz...@redhat.com; mre...@redhat.com; stefa...@redhat.com; > dnbrd...@gmail.com; Zhanghailiang ; > Chenqun

[Bug 1906608] [NEW] [Feature request]For some ehci controller, qemu should implement using portsc[26-27] to detect the speed of device.

2020-12-02 Thread ruimeiyan
Public bug reported: for some ehci controller ,for example ehci controller on fsl_imx6,it using portsc[26-27] to decide a full speed device or high speed device was connected, hub-ehci.c should set the portsc[26-27] to return the right speed. line:1001 in hub-ehci.c if (dev &&

[PATCH v2 0/4] Use lock guard macros in block

2020-12-02 Thread Gan Qixin
v1->v2: -Patch1: Add Paolo Bonzini reviewed tag and delete the .c suffix in the commit message. -Patch2: Add Paolo Bonzini reviewed tag and delete the .c suffix in the commit message. -Patch3: Delete the .c suffix in the commit. Changes suggested by Kevin Wolf: Fix wrong

[PATCH v2 4/4] block/iscsi: Use lock guard macros

2020-12-02 Thread Gan Qixin
Replace manual lock()/unlock() calls with lock guard macros (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/iscsi. Signed-off-by: Gan Qixin --- Cc: Kevin Wolf Cc: Paolo Bonzini Cc: Markus Armbruster --- block/iscsi.c | 50 -- 1 file changed, 24

Re: [RFC PATCH v2 4/5] virtio-net: Added eBPF RSS to virtio-net.

2020-12-02 Thread Jason Wang
On 2020/12/2 下午3:16, Yuri Benditovich wrote: On Wed, Dec 2, 2020 at 6:06 AM Jason Wang > wrote: On 2020/12/1 下午3:40, Yuri Benditovich wrote: > > > On Tue, Nov 24, 2020 at 10:49 AM Jason Wang mailto:jasow...@redhat.com> >

[PULL 013/113] pci: Let pci_dma_read() propagate MemTxResult

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé pci_dma_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201023151923.3243652-10-phi...@redhat.com> Signed-off-by: Paolo Bonzini

[PULL 000/113] First batch of misc (i386, kernel-doc, memory, vl.c) changes for QEMU 6.0

2020-12-02 Thread Paolo Bonzini
The following changes since commit 944fdc5e27a5b5adbb765891e8e70e88ba9a00ec: Merge remote-tracking branch 'remotes/elmarco/tags/libslirp-pull-request' into staging (2020-11-27 17:09:55 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for

[PULL 016/113] hw/ssi: Update coding style to make checkpatch.pl happy

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé To make the next commit easier to review, clean this code first. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201012124955.3409127-3-f4...@amsat.org> Signed-off-by: Paolo Bonzini --- include/hw/ssi/ssi.h | 16 +--- 1 file changed, 9

[PULL 056/113] vl: extract qemu_init_subsystems

2020-12-02 Thread Paolo Bonzini
Group a bunch of subsystem initializations that can be done right after command line parsing. Remove initializations that can be done simply as global variable initializers. Reviewed-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 94

[PULL 027/113] mips: remove bios_name

2020-12-02 Thread Paolo Bonzini
Cc: Philippe Mathieu-Daudé Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Message-Id: <20201026143028.3034018-9-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/mips/fuloong2e.c | 6 +++--- hw/mips/jazz.c | 6 +++--- hw/mips/malta.c | 6 +++--- hw/mips/mipssim.c | 6

[PULL 029/113] ppc: remove bios_name

2020-12-02 Thread Paolo Bonzini
Cc: David Gibson Signed-off-by: Paolo Bonzini Acked-by: David Gibson Reviewed-by: Alex Bennée Message-Id: <20201026143028.3034018-11-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/ppc/e500.c | 4 ++-- hw/ppc/mac_newworld.c | 4 +--- hw/ppc/mac_oldworld.c | 4 +---

[PULL 032/113] sh4: remove bios_name

2020-12-02 Thread Paolo Bonzini
Cc: Yoshinori Sato Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201026143028.3034018-14-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/sh4/shix.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PULL 071/113] vl: initialize displays before preconfig loop

2020-12-02 Thread Paolo Bonzini
Displays should be available before the monitor starts, so that it is possible to use the graphical console to interact with the monitor itself. This patch is quite ugly, but all this is temporary. The double call to qemu_init_displays will go away as soon we can unify machine initialization

[PULL 064/113] vl: extract default devices to separate functions

2020-12-02 Thread Paolo Bonzini
Reviewed-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 216 +++ 1 file changed, 114 insertions(+), 102 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index cb4b870f09..1a80a9a68d 100644 --- a/softmmu/vl.c +++

[PULL 063/113] vl: load plugins as late as possible

2020-12-02 Thread Paolo Bonzini
There is no need to load plugins in the middle of default device processing, move -plugin handling just before preconfig is entered. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 12 ++-- 1 file changed, 6 insertions(+),

[PULL 089/113] Replace HTTP links with HTTPS ones: documentation

2020-12-02 Thread Paolo Bonzini
From: "Alexander A. Klimov" Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^#

[PULL 104/113] scripts: kernel-doc: allow passing desired Sphinx C domain dialect

2020-12-02 Thread Paolo Bonzini
From: Mauro Carvalho Chehab When kernel-doc is called via kerneldoc.py, there's no need to auto-detect the Sphinx version, as the Sphinx module already knows it. So, add an optional parameter to allow changing the Sphinx dialect. As kernel-doc can also be manually called, keep the

[PULL 075/113] hmp: introduce cmd_available

2020-12-02 Thread Paolo Bonzini
Combine the RUN_STATE_PRECONFIG and cmd_can_preconfig checks into a single function, to avoid repeating the same expression (or its negation after applying DeMorgan's rule) over and over again. Reviewed-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- monitor/hmp.c | 18 ++ 1

[PULL 092/113] scripts/kernel-doc: optionally treat warnings as errors

2020-12-02 Thread Paolo Bonzini
From: Pierre-Louis Bossart The kbuild bot recently added the W=1 option, which triggered documentation cleanups to squelch hundreds of kernel-doc warnings. To make sure new kernel contributions don't add regressions to kernel-doc descriptors, this patch suggests an option to treat warnings as

[PATCH 07/15] chardev: do not use machine_init_done

2020-12-02 Thread Paolo Bonzini
machine_init_done is not the right flag to check when preconfig is taken into account; for example "./qemu-system-x86_64 -serial mon:stdio -preconfig" does not print the QEMU monitor header until after exit_preconfig. Add back a custom bool for mux character devices. This partially undoes commit

[PATCH 16/28] qemu-config: parse configuration files to a QDict

2020-12-02 Thread Paolo Bonzini
Change the parser to put the values into a QDict and pass them to a callback. qemu_config_parse's QemuOpts creation is itself turned into a callback function. Signed-off-by: Paolo Bonzini --- include/qemu/config-file.h | 6 ++- softmmu/vl.c | 4 +- util/qemu-config.c |

[PATCH 25/28] vl: rename local variable in configure_accelerators

2020-12-02 Thread Paolo Bonzini
Silly patch extracted from the next one, which is already big enough. Because there are already local variables named "accel", we will name the global vl.c variable for "-M accel" accelerators instead. Rename it already in configure_accelerators to be ready. Signed-off-by: Paolo Bonzini ---

Re: [PATCH v2 32/32] scripts: kernel-doc: remove unnecesssary change wrt Linux

2020-12-02 Thread Paolo Bonzini
On 02/12/20 10:03, Philippe Mathieu-Daudé wrote: On 12/1/20 11:35 AM, Paolo Bonzini wrote: A comment in kernel-doc mentions QEMU's qatomic_set macro, but since this code originated in Linux we should just revert it and stay as close to the kernel's copy of the script as possible. The change

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Kevin Wolf
Am 02.12.2020 um 10:30 hat Paolo Bonzini geschrieben: > On 01/12/20 23:08, Eduardo Habkost wrote: > > > Properties are only a useful concept if they have a use. If > > > -object/object_add/object-add can do the same job without properties, > > > properties are not needed anymore. > > > > Do you

[PULL 5/6] intel_iommu: Skip page walking on device iotlb invalidations

2020-12-02 Thread Michael S. Tsirkin
From: Eugenio Pérez Although they didn't reach the notifier because of the filtering in memory_region_notify_iommu_one, the vt-d was still splitting huge memory invalidations in chunks. Skipping it. This improves performance in case of netperf with vhost-net: * TCP_STREAM: From 1923.6Mbit/s to

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Michael S. Tsirkin
On Wed, Dec 02, 2020 at 10:55:15AM +, Daniel P. Berrangé wrote: > On Wed, Dec 02, 2020 at 11:51:05AM +0100, Juan Quintela wrote: > > "Michael S. Tsirkin" wrote: > > > On Wed, Dec 02, 2020 at 05:31:53AM -0500, Michael S. Tsirkin wrote: > > >> On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P.

[PATCH] accel/tcg: Remove deprecated '-tb-size' option

2020-12-02 Thread Philippe Mathieu-Daudé
The '-tb-size' option (replaced by '-accel tcg,tb-size') is deprecated since 5.0 (commit fe174132478). Remove it. Signed-off-by: Philippe Mathieu-Daudé --- docs/system/deprecated.rst | 12 +--- accel/tcg/translate-all.c | 2 +- softmmu/vl.c | 8 qemu-options.hx

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Michael S. Tsirkin
On Wed, Dec 02, 2020 at 11:26:39AM +, Daniel P. Berrangé wrote: > On Wed, Dec 02, 2020 at 06:19:29AM -0500, Michael S. Tsirkin wrote: > > On Wed, Dec 02, 2020 at 10:55:15AM +, Daniel P. Berrangé wrote: > > > On Wed, Dec 02, 2020 at 11:51:05AM +0100, Juan Quintela wrote: > > > > "Michael S.

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Juan Quintela
"Michael S. Tsirkin" wrote: > On Wed, Dec 02, 2020 at 05:31:53AM -0500, Michael S. Tsirkin wrote: >> On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P. Berrangé wrote: >> > On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael S. Tsirkin wrote: >> > > On Wed, Nov 18, 2020 at 09:37:22AM +0100,

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Daniel P . Berrangé
On Wed, Dec 02, 2020 at 06:19:29AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2020 at 10:55:15AM +, Daniel P. Berrangé wrote: > > On Wed, Dec 02, 2020 at 11:51:05AM +0100, Juan Quintela wrote: > > > "Michael S. Tsirkin" wrote: > > > > On Wed, Dec 02, 2020 at 05:31:53AM -0500, Michael

[PULL 009/113] dma: Let dma_memory_rw() propagate MemTxResult

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé address_space_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PULL 008/113] dma: Let dma_memory_set() propagate MemTxResult

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé address_space_write() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Richard Henderson Reviewed-by: Li Qiang Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Message-Id:

[PULL 023/113] hppa: remove bios_name

2020-12-02 Thread Paolo Bonzini
Cc: Richard Henderson Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201026143028.3034018-5-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/hppa/machine.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PULL 012/113] pci: Let pci_dma_rw() propagate MemTxResult

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé dma_memory_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201023151923.3243652-9-phi...@redhat.com> Signed-off-by: Paolo

[PULL 018/113] hw/core/stream: Rename StreamSlave as StreamSink

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé In order to use inclusive terminology, rename 'slave stream' as 'sink stream'. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Paolo Bonzini Reviewed-by: Edgar E. Iglesias Message-Id: <20200910070131.435543-3-phi...@redhat.com> Signed-off-by: Paolo Bonzini ---

[PULL 038/113] hppa: do not use ram_size global

2020-12-02 Thread Paolo Bonzini
Use the machine properties instead. Cc: Richard Henderson Signed-off-by: Paolo Bonzini --- hw/hppa/machine.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index 5e745d5ea9..7e41cb2462 100644 --- a/hw/hppa/machine.c +++

[PULL 021/113] alpha: remove bios_name

2020-12-02 Thread Paolo Bonzini
Cc: Richard Henderson Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201026143028.3034018-2-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/alpha/dp264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PULL 031/113] s390: remove bios_name

2020-12-02 Thread Paolo Bonzini
Cc: Thomas Huth Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée Reviewed-by: Thomas Huth Message-Id: <20201026143028.3034018-13-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- hw/s390x/ipl.c | 8 ++-- hw/s390x/s390-virtio-ccw.c | 3 ++- 2 files changed, 4

[PULL 062/113] vl: create "-net nic -net user" default earlier

2020-12-02 Thread Paolo Bonzini
Create it together with other default backends, even though the processing is done later. Reviewed-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index

[PULL 055/113] vl: move various initialization routines out of qemu_init

2020-12-02 Thread Paolo Bonzini
Some very simple initialization routines can be nested in existing subsystem-level functions, do that to simplify qemu_init. Reviewed-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- hw/core/machine.c | 3 +++ include/hw/qdev-core.h | 8 migration/migration.c | 4

[PULL 051/113] treewide: do not use short-form boolean options

2020-12-02 Thread Paolo Bonzini
They are going to be deprecated, avoid warnings on stdout while the tests run. Signed-off-by: Paolo Bonzini --- docs/specs/tpm.rst | 2 +- python/qemu/machine.py | 2 +- qemu-options.hx | 32 ++--

[PULL 061/113] qemu-option: restrict qemu_opts_set to merge-lists QemuOpts

2020-12-02 Thread Paolo Bonzini
qemu_opts_set is used to create default network backends and to parse sugar options -kernel, -initrd, -append, -bios and -dtb. These are very different uses: I would *expect* a function named qemu_opts_set to set an option in a merge-lists QemuOptsList, such as -kernel, and possibly to set an

[PULL 074/113] vl: start VM via qmp_cont

2020-12-02 Thread Paolo Bonzini
Complement the previous patch by starting the VM with a QMP command. The plan is that the user will be able to do the same, invoking two commands "finish-machine-init" and "cont" instead of "x-exit-preconfig". Reviewed-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 3 ++- 1

[PULL 079/113] vl: remove serial_max_hds

2020-12-02 Thread Paolo Bonzini
serial_hd(i) is NULL if and only if i >= serial_max_hds(). Test serial_hd(i) instead of bounding the loop at serial_max_hds(), thus removing one more function that vl.c is expected to export. Reviewed-by: Igor Mammedov Signed-off-by: Paolo Bonzini --- hw/ppc/spapr.c | 6 ++

[PULL 090/113] scripts/kernel-doc: parse __ETHTOOL_DECLARE_LINK_MODE_MASK

2020-12-02 Thread Paolo Bonzini
From: Mauro Carvalho Chehab The __ETHTOOL_DECLARE_LINK_MODE_MASK macro is a variant of DECLARE_BITMAP(), used by phylink.h. As we have already a parser for DECLARE_BITMAP(), let's add one for this macro, in order to avoid such warnings: ./include/linux/phylink.h:54: warning: Function

[PULL 101/113] scripts: kernel-doc: reimplement -nofunction argument

2020-12-02 Thread Paolo Bonzini
From: Mauro Carvalho Chehab Right now, the build system doesn't use -nofunction, as it is pretty much useless, because it doesn't consider the other output modes (extern, internal), working only with all. Also, it is limited to exclude functions. Re-implement it in order to allow excluding any

[PULL 112/113] Revert "docs: temporarily disable the kernel-doc extension"

2020-12-02 Thread Paolo Bonzini
This reverts commit fd68a72875cf318f4310726f842139119c5f45d5. We're done with the update of kernel-doc and we can restore kernel-doc's functionality. Signed-off-by: Paolo Bonzini Signed-off-by: Paolo Bonzini --- docs/sphinx/kerneldoc.py | 3 --- 1 file changed, 3 deletions(-) diff --git

[PULL 107/113] Revert "kernel-doc: Handle function typedefs without asterisks"

2020-12-02 Thread Paolo Bonzini
This reverts commit 3cd3c5193cde5242e243c25759f85802e267994f. We will replace the commit with the fix from Linux. Signed-off-by: Paolo Bonzini Message-Id: <20201117165312.118257-26-pbonz...@redhat.com> Signed-off-by: Paolo Bonzini --- scripts/kernel-doc | 2 +- 1 file changed, 1 insertion(+),

[PATCH 01/15] remove preconfig state

2020-12-02 Thread Paolo Bonzini
The preconfig state is only used if -incoming is not specified, which makes the RunState state machine more tricky than it need be. However there is already an equivalent condition which works even with -incoming, namely qdev_hotplug. Use it instead of a separate runstate. Signed-off-by: Paolo

[PATCH 15/15] monitor: allow quitting while in preconfig state

2020-12-02 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hmp-commands.hx | 1 + qapi/control.json | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index ff2d7aa8f3..d192afa652 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -45,6 +45,7 @@ ERST

[PATCH 07/28] keyval: simplify keyval_parse_one

2020-12-02 Thread Paolo Bonzini
Now that the key is NULL terminated, we can remove some of the contortions that were done to operate on possibly '='-terminated strings in keyval_parse_one. Signed-off-by: Paolo Bonzini --- util/keyval.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff

[PATCH 14/28] qemu-config: add error propagation to qemu_config_parse

2020-12-02 Thread Paolo Bonzini
This enables some simplification of vl.c via error_fatal. Signed-off-by: Paolo Bonzini --- block/blkdebug.c | 3 +-- include/qemu/config-file.h | 4 ++-- softmmu/vl.c | 30 -- util/qemu-config.c | 20 ++-- 4 files

[PATCH 26/28] vl: switch -M parsing to keyval

2020-12-02 Thread Paolo Bonzini
Switch from QemuOpts to keyval. This enables non-scalar machine properties. Signed-off-by: Paolo Bonzini --- softmmu/vl.c | 296 +++ 1 file changed, 132 insertions(+), 164 deletions(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Michael S. Tsirkin
On Wed, Nov 18, 2020 at 09:37:22AM +0100, Juan Quintela wrote: > If we have a paused guest, it can't unplug the network VF device, so > we wait there forever. Just change the code to give one error on that > case. > > Signed-off-by: Juan Quintela It's certainly possible but it's management

[PATCH 23/28] storage-daemon: do not register the "object" group with QemuOpts

2020-12-02 Thread Paolo Bonzini
Since qsd uses keyval instead of -object, do not bother registering qemu_object_opts. It used to be necessary for object-del; that requirement is not there anymore since emulators have switched to keyval. Signed-off-by: Paolo Bonzini --- storage-daemon/qemu-storage-daemon.c | 10 -- 1

[PULL 005/113] docs/devel/loads-stores: Add regexp for DMA functions

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Edgar E. Iglesias Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201023151923.3243652-3-phi...@redhat.com> Signed-off-by: Paolo Bonzini --- docs/devel/loads-stores.rst | 2 ++ 1 file changed, 2 insertions(+)

[PULL 001/113] target/i386: fix operand order for PDEP and PEXT

2020-12-02 Thread Paolo Bonzini
For PDEP and PEXT, the mask is provided in the memory (mod+r/m) operand, and therefore is loaded in s->T0 by gen_ldst_modrm. The source is provided in the second source operand (VEX.) and therefore is loaded in s->T1. Fix the order in which they are passed to the helpers. Reported-by: Lenard

[PULL 014/113] pci: Let pci_dma_write() propagate MemTxResult

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé pci_dma_rw() returns a MemTxResult type. Do not discard it, return it to the caller. Reviewed-by: Li Qiang Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20201023151923.3243652-11-phi...@redhat.com> Signed-off-by: Paolo Bonzini

[PULL 036/113] arm: do not use ram_size global

2020-12-02 Thread Paolo Bonzini
Use the machine properties instead. Cc: qemu-...@nongnu.org Signed-off-by: Paolo Bonzini --- hw/arm/aspeed.c | 8 hw/display/pxa2xx_lcd.c | 5 +++-- target/arm/arm-semi.c | 3 ++- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c

  1   2   3   4   5   >