Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
hw/core/machine.c | 24
include/sysemu/sysemu.h | 1 +
softmmu/vl.c| 24
3 files changed, 25 insertions(+), 24 deletions(-)
diff --git a/hw/core/machine.c
Once smp_parse is done, the validation operates on the MachineState.
There is no reason for that code to be in vl.c.
Reviewed-by: Igor Mammedov
Tested-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
hw/core/machine.c | 23 +++
include/hw/boards.h | 1 +
softmmu/vl.c
From: Mauro Carvalho Chehab
The PHY kernel-doc markup has gained support for documenting
a typedef enum.
However, right now the parser was not prepared for it.
So, add support for parsing it.
Fixes: 4069a572d423 ("net: phy: Document core PHY structures")
Signed-off-by: Mauro Carvalho Chehab
Move post-preconfig initialization to the x-exit-preconfig. If preconfig
is not requested, just exit preconfig mode immediately with the QMP
command.
As a result, the preconfig loop will run with accel_setup_post
and os_setup_post restrictions (xen_restrict, chroot, etc.)
already done.
> -Original Message-
> From: Eduardo Habkost
> Sent: Wednesday, December 2, 2020 5:12 AM
> To: Kang, Luwei
> Cc: pbonz...@redhat.com; r...@twiddle.net; qemu-devel@nongnu.org
> Subject: Re: [PATCH 1/2] i386/cpu: Add the Intel PT capabilities checking
> before
> extend the CPUID level
>
Compute the DIRTY_MEMORY_CODE bit in memory_region_get_dirty_log_mask
instead of memory_region_init_*. This makes it possible to allocate
memory backend objects at any time.
Signed-off-by: Paolo Bonzini
---
softmmu/memory.c | 12 ++--
softmmu/vl.c | 6 +-
2 files changed, 7
Switch from QemuOpts to keyval. This enables compound options
for accelerators.
Signed-off-by: Paolo Bonzini
---
accel/accel.c | 6 ++
include/sysemu/accel.h | 1 +
softmmu/vl.c | 134 ++---
3 files changed, 67 insertions(+), 74
This is used with the weirdly-named device "SUNFD,fdtwo":
$ qemu-system-sparc -device SUNW,,fdtwo,help
SUNW,fdtwo options:
drive=- Node name or ID of a block device to use as a
backend
fallback= - FDC drive type, 144/288/120/none/auto (default:
"144")
...
Therefore,
The qtest server right now can only be created using the -qtest
and -qtest-log options. Allow an alternative way to create it
using "-object qtest,chardev=...,log=...".
Signed-off-by: Paolo Bonzini
---
softmmu/qtest.c | 144
softmmu/vl.c|
Machines and accelerators are not user-creatable but they share
similar parsing machinery. Export functions that will be used
with -machine and -accel in softmmu/vl.c.
Signed-off-by: Paolo Bonzini
---
include/qom/object.h| 21 +
qom/object_interfaces.c | 51
On 01/12/20 23:08, Eduardo Habkost wrote:
Properties are only a useful concept if they have a use. If
-object/object_add/object-add can do the same job without properties,
properties are not needed anymore.
Do you mean "not needed for -object anymore"? Properties are
still used by internal C
Signed-off-by: Paolo Bonzini
---
util/qemu-option.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/util/qemu-option.c b/util/qemu-option.c
index 40564a12eb..afba08d92e 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -1052,7 +1052,8 @@ bool
On Fri, Nov 20, 2020 at 06:51:07PM +, John Levon wrote:
>
> If we find a queue with an inconsistent guest index value, explicitly mark the
> device as needing a reset - and broken - via virtio_error().
>
> There's at least one driver implementation - the virtio-win NetKVM driver -
> that
>
On Thu, Nov 12, 2020 at 05:19:00PM -0600, Mike Christie wrote:
> diff --git a/linux-headers/linux/vhost.h b/linux-headers/linux/vhost.h
> index 7523218..98dd919 100644
> --- a/linux-headers/linux/vhost.h
> +++ b/linux-headers/linux/vhost.h
> @@ -70,6 +70,7 @@
> #define VHOST_VRING_BIG_ENDIAN 1
>
On Thu, Nov 19, 2020 at 09:48:32AM +0800, Jiahui Cen wrote:
> Changes with v9
> v9->v10:
> Refactor patch2 to drop useless macros and variables.
> Split patch2 into two patches.
I tagged this for after the release. To help make sure this is
not lost pls ping me after the release.
Thanks!
>
From: Eugenio Pérez
Previous name didn't reflect the iommu operation.
Signed-off-by: Eugenio Pérez
Reviewed-by: Peter Xu
Reviewed-by: David Gibson
Reviewed-by: Juan Quintela
Reviewed-by: Eric Auger
Acked-by: Jason Wang
Message-Id: <20201116165506.31315-2-epere...@redhat.com>
Reviewed-by:
On 02/12/2020 12.27, Philippe Mathieu-Daudé wrote:
> The '-tb-size' option (replaced by '-accel tcg,tb-size') is
> deprecated since 5.0 (commit fe174132478). Remove it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> docs/system/deprecated.rst | 12 +---
> accel/tcg/translate-all.c |
> --- a/tests/docker/dockerfiles/centos8.docker
> +++ b/tests/docker/dockerfiles/centos8.docker
> @@ -1,4 +1,4 @@
> -FROM centos:8.1.1911
> +FROM registry.centos.org/centos:8
At least for centos-8 I've noticed the docker.io containters are
multiarch whereas registry.centos.org has x86_64 only.
I
The check has the same effect here, it only matters that it is performed
once all devices, both builtin and user-specified, have been created.
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Use the equivalent argument to the function instead.
Signed-off-by: Paolo Bonzini
---
hw/nios2/boot.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/nios2/boot.c b/hw/nios2/boot.c
index 1df3b66c29..3cb864914b 100644
--- a/hw/nios2/boot.c
+++ b/hw/nios2/boot.c
@@
Move more of them into MachineState, in preparation for moving initialization
of the machine out of vl.c.
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
include/hw/boards.h | 1 +
softmmu/vl.c| 12 ++--
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git
"Late" backends are created after the machine.
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 64 ++--
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index
From: André Almeida
Subroutine dump_struct uses type attributes to check if the struct
syntax is valid. Then, it removes all attributes before using it for
output. `cacheline_aligned_in_smp` is an attribute that is
not included in both steps. Add it, since it is used by kernel structs.
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 81 +---
1 file changed, 45 insertions(+), 36 deletions(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index 5af52454ee..acf09b2040 100644
--- a/softmmu/vl.c
+++ b/softmmu/vl.c
@@ -2704,6 +2704,49 @@
This reverts commit 152d1967f650f67b7ece3a5dda77d48069d72647.
We will replace the commit with the fix from Linux.
Signed-off-by: Paolo Bonzini
Message-Id: <20201117165312.118257-16-pbonz...@redhat.com>
Signed-off-by: Paolo Bonzini
---
docs/sphinx/kerneldoc.py | 1 -
scripts/kernel-doc |
Make qemu_start_incoming_migration local to migration/migration.c.
By using the runstate instead of a separate flag, vl need not do
anything to setup deferred incoming migration.
qmp_migrate_incoming also does not need the deferred_incoming flag
anymore, because "-incoming PROTOCOL" will clear
Preserve bisectability while we update scripts/kernel-doc from Linux.
Without this patch, building with Sphinx 3 would break while we
revert our own Sphinx 3 support and replace it with Linux's.
Suggested-by: Peter Maydell
Signed-off-by: Paolo Bonzini
---
docs/sphinx/kerneldoc.py | 3 +++
1
We want to make it independent of QemuOpts.
Signed-off-by: Paolo Bonzini
Signed-off-by: Paolo Bonzini
---
include/qemu/config-file.h | 1 -
softmmu/vl.c | 33 +
util/qemu-config.c | 33 -
3 files changed,
A comment in kernel-doc mentions QEMU's qatomic_set macro, but since
this code originated in Linux we should just revert it and stay as close
to the kernel's copy of the script as possible.
The change was introduced (more or less unintentionally) in QEMU commit
commit d73415a31547, which did a
From: Mauro Carvalho Chehab
This should solve bad error reports like this one:
./include/linux/iio/iio.h:0: WARNING: Unknown target name: "devm".
Signed-off-by: Mauro Carvalho Chehab
Link:
From: Mauro Carvalho Chehab
The include/linux/genalloc.h file defined this typedef:
typedef unsigned long (*genpool_algo_t)(unsigned long *map,unsigned
long size,unsigned long start,unsigned int nr,void *data, struct gen_pool
*pool, unsigned long start_addr);
Because it has a type
From: Mauro Carvalho Chehab
Sphinx C domain code after 3.2.1 will start complaning if :c:struct
would be used for an union type:
.../Documentation/gpu/drm-kms-helpers:352: ../drivers/video/hdmi.c:851:
WARNING: C 'identifier' cross-reference uses wrong tag: reference name is
'union
From: Mauro Carvalho Chehab
The typedef regex for function prototypes are very complex.
Split them into 3 separate regex and then join them using
qr.
Signed-off-by: Mauro Carvalho Chehab
Link:
Now that there is no RUN_STATE_PRECONFIG anymore that can conflict with
RUN_STATE_INMIGRATE, we can allow -incoming defer with -preconfig.
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
This is needed for SPAPR which has different defaults than everyone else.
Right now it looks at the -machine QemuOpts, but those will go away.
Signed-off-by: Paolo Bonzini
---
hw/core/machine.c | 1 +
include/hw/mem/nvdimm.h | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff
> -Original Message-
> From: Qemu-devel
> [mailto:qemu-devel-bounces+kuhn.chenqun=huawei@nongnu.org] On
> Behalf Of Luká? Doktor
> Sent: Thursday, November 26, 2020 4:10 PM
> To: QEMU Developers
> Cc: Charles Shih ; Aleksandar Markovic
> ; Stefan Hajnoczi
>
> Subject: Proposal for a
Like -set and -readconfig, it would not really be too hard to
extend -writeconfig to parsing mechanisms other than QemuOpts.
However, the uses of -writeconfig are substantially more
limited, as it is generally easier to write the configuration
by hand in the first place. In addition, -writeconfig
On Wed, Nov 25, 2020 at 02:56:59PM +, Jonathan Cameron wrote:
> Cool. I'll run a few more comprehensive tests then send out the
> trivial patch to enable the kernel option + v2 of the qemu support.
IIUC there will be another version of this patch, right?
--
MST
Enable creation of object with non-scalar properties.
Signed-off-by: Paolo Bonzini
---
qemu-nbd.c | 42 +-
1 file changed, 13 insertions(+), 29 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index a7075c5419..b4bd21a21e 100644
--- a/qemu-nbd.c
+++
Am 01.12.2020 um 22:23 hat Paolo Bonzini geschrieben:
> On 01/12/20 20:35, Kevin Wolf wrote:
> > Am 01.12.2020 um 18:16 hat Paolo Bonzini geschrieben:
> > I don't think this is actually a new things. We already have types and
> > commands declared with things like 'if': 'defined(TARGET_S390X)'.
>
On 12/2/20 12:15 AM, Richard Henderson wrote:
> On 12/1/20 1:28 PM, Philippe Mathieu-Daudé wrote:
>> ISA features are usually denoted in read-only bits from
>> CPU registers. Add the GET_FEATURE_REG_EQU() macro which
>> checks if a CPU register has bits set to a specific value.
>>
>> Use the macro
Could you help by rebasing this on master? Shouldn't be hard ...
Thanks!
On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael S. Tsirkin wrote:
> On Wed, Nov 18, 2020 at 09:37:22AM +0100, Juan Quintela wrote:
> > If we have a paused guest, it can't unplug the network VF device, so
> > we wait there forever. Just change the code to give one error on that
> > case.
> >
>
On Wed, Dec 02, 2020 at 11:51:05AM +0100, Juan Quintela wrote:
> "Michael S. Tsirkin" wrote:
> > On Wed, Dec 02, 2020 at 05:31:53AM -0500, Michael S. Tsirkin wrote:
> >> On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P. Berrangé wrote:
> >> > On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael
* Shenming Lu (lushenm...@huawei.com) wrote:
> Hi,
>
> After reading everyone's opinions, we have a rough idea for this issue.
>
> One key point is whether it is necessary to setup the config space before
> the device can accept further migration data. I think it is decided by
> the vendor
Patch 5 gave me pause but we do need patch 6 as
it's a guest triggerable assert, and it seemed
cleaner to just take the whole patchset than cherry-pick.
The following changes since commit d73c46e4a84e47ffc61b8bf7c378b1383e7316b5:
Update version for v5.2.0-rc4 release (2020-12-01 16:21:01
From: Eugenio Pérez
Device IOTLB invalidations can unmap arbitrary ranges, eiter outside of
the memory region or even [0, ~0ULL] for all the space. The assertion
could be hit by a guest, and rhel7 guest effectively hit it.
Signed-off-by: Eugenio Pérez
Reviewed-by: Peter Xu
Reviewed-by: Juan
Claudio Fontana writes:
> Hi Alex and all,
>
> when trying to use check-tcg (master), I am getting often these errors:
>
> $ ../configure --disable-system --disable-tools
>
> $ make -j12 check-tcg
>
> ERRO[] cannot find mappings for user claudio: No subgid ranges found for
> group
On Wed, Dec 02, 2020 at 06:37:46AM -0500, Michael S. Tsirkin wrote:
> On Wed, Dec 02, 2020 at 11:26:39AM +, Daniel P. Berrangé wrote:
> > On Wed, Dec 02, 2020 at 06:19:29AM -0500, Michael S. Tsirkin wrote:
> > > On Wed, Dec 02, 2020 at 10:55:15AM +, Daniel P. Berrangé wrote:
> > > > On
On a Wednesday in 2020, Philippe Mathieu-Daudé wrote:
The '-tb-size' option (replaced by '-accel tcg,tb-size') is
deprecated since 5.0 (commit fe174132478). Remove it.
Signed-off-by: Philippe Mathieu-Daudé
---
docs/system/deprecated.rst | 12 +---
accel/tcg/translate-all.c | 2 +-
On 01/12/2020 18.18, Daniel P. Berrangé wrote:
> The travis container that we have no longer matches what travis
> currently uses. As all x86 jobs are being moved to GitLab CI too,
> there is no compelling reason to update the travis container. It
> is simpler to just remove it.
>
>
This works as intended, see Markus' reply here:
https://lists.gnu.org/archive/html/qemu-devel/2020-12/msg00337.html
** Changed in: qemu
Status: New => Invalid
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
From: Bin Meng
Per the SDM, when returning to outer privilege level, for segment
registers (ES, FS, GS, and DS) if the check fails, the segment
selector becomes null, but QEMU clears the base/limit/flags as well
as nullifying the segment selector, which should be a spec violation.
Real hardware
From: Philippe Mathieu-Daudé
In order to use inclusive terminology, rename SSI 'slave' as
'peripheral', following the specification resolution:
https://www.oshwa.org/a-resolution-to-redefine-spi-signal-names/
Patch created mechanically using:
$ sed -i s/SSISlave/SSIPeripheral/ $(git grep -l
From: Philippe Mathieu-Daudé
In order to use inclusive terminology, rename max_slaves
as max_peripherals.
Patch generated using:
$ sed -i s/slave/peripheral/ \
hw/ssi/aspeed_smc.c include/hw/ssi/aspeed_smc.h
One line in aspeed_smc_read() has been manually tweaked
to pass checkpatch.
bios_name was a legacy variable used by machine code, but it is
no more.
Signed-off-by: Paolo Bonzini
Reviewed-by: Alex Bennée
Message-Id: <20201026143028.3034018-16-pbonz...@redhat.com>
Signed-off-by: Paolo Bonzini
---
include/sysemu/sysemu.h | 1 -
softmmu/vl.c| 2 --
2 files
Just like -incoming. Later we will add support for "-incoming defer
-preconfig", because there are cases (Xen, block layer) that want
to look at RUNSTATE_INMIGRATE. -loadvm will remain mutually exclusive
with preconfig; the plan is to just do loadvm in the monitor, since
the user is already
Use the loader parameters instead.
Signed-off-by: Paolo Bonzini
---
hw/i386/fw_cfg.c | 2 +-
hw/i386/vmport.c | 3 ++-
hw/i386/xen/xen-hvm.c | 2 +-
hw/intc/apic_common.c | 3 ++-
hw/smbios/smbios.c| 8
5 files changed, 10 insertions(+), 8 deletions(-)
diff --git
Use the machine properties for the leftovers too.
Signed-off-by: Paolo Bonzini
---
hw/core/generic-loader.c | 3 ++-
hw/core/numa.c | 10 +-
hw/virtio/virtio-balloon.c | 3 ++-
include/exec/cpu-common.h | 2 --
monitor/qmp-cmds.c | 3 ++-
softmmu/vl.c
From: Mauro Carvalho Chehab
The pattern @foo->bar() is valid, as it can be used by a
function pointer inside a struct passed as a parameter.
Right now, it causes a warning:
./drivers/firewire/core-transaction.c:606: WARNING: Inline strong
start-string without end-string.
In this
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
hw/core/machine.c | 2 ++
include/exec/cpu-common.h | 3 ++
include/exec/exec-all.h | 3 --
softmmu/globals.c | 74 +++
softmmu/meson.build | 1 +
softmmu/vl.c
This reverts commit 19ab6044be0c55d529e875e3ee16fdd5c3b54d33.
We will replace the commit with the fix from Linux.
Signed-off-by: Paolo Bonzini
Message-Id: <20201117165312.118257-27-pbonz...@redhat.com>
Signed-off-by: Paolo Bonzini
---
scripts/kernel-doc | 4 ++--
1 file changed, 2
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
include/sysemu/sysemu.h | 3 +
softmmu/meson.build | 1 +
softmmu/runstate.c | 800
softmmu/vl.c| 752 +
4 files changed, 805
qdev_machine_creation_done is only setting a flag now. Extend it to
move more code out of vl.c. Leave only consistency checks and gdbserver
processing in qemu_machine_creation_done.
gdbserver_start can be moved after qdev_machine_creation_done because
it only does listen on the socket and
This is needed when we add help support for object_add.
Signed-off-by: Paolo Bonzini
---
qom/object_interfaces.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/qom/object_interfaces.c b/qom/object_interfaces.c
index ed896fe764..34edc3d1d8 100644
---
HMP is using QemuOpts to parse free-form commands device_add,
netdev_add and object_add. However, none of these need QemuOpts
for validation (these three QemuOptsLists are all of the catch-all
kind), and keyval is already able to parse into QDict. So use
keyval directly, avoiding the detour from
Zihao Chang writes:
> Fix the example of add qmp hello-world example.
> Without ":", make will report error:
> ../qapi/misc.json:573:2: line should end with ':'
>
> Signed-off-by: Zihao Chang
> ---
> docs/devel/writing-qmp-commands.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
On 12/2/20 2:14 AM, Huacai Chen wrote:
> Hi, Phillippe,
>
> On Tue, Nov 24, 2020 at 6:25 AM Philippe Mathieu-Daudé
> wrote:
>>
>> On 11/6/20 5:21 AM, Huacai Chen wrote:
>>> Preparing to add Loongson-3 machine support, add Loongson-3's LEFI (a
>>> UEFI-like interface for BIOS-Kernel boot
On Wed, Dec 02, 2020 at 11:16:04AM +0100, Juan Quintela wrote:
> "Michael S. Tsirkin" wrote:
> > On Wed, Nov 18, 2020 at 09:37:21AM +0100, Juan Quintela wrote:
> >> Hi
> >>
> >> This is a big rework of the network failover setup. General idea is:
> >> * We don't cache the name of the
On Tue, Dec 01, 2020 at 05:43:38PM +, Stefan Hajnoczi wrote:
On Tue, Dec 01, 2020 at 02:45:18PM +0100, Stefano Garzarella wrote:
On Tue, Dec 01, 2020 at 12:59:43PM +, Stefan Hajnoczi wrote:
> On Fri, Nov 20, 2020 at 07:31:08AM -0500, Michael S. Tsirkin wrote:
> > On Fri, Nov 20, 2020 at
On Wed, Dec 02, 2020 at 12:54:14PM +0100, Gerd Hoffmann wrote:
> > --- a/tests/docker/dockerfiles/centos8.docker
> > +++ b/tests/docker/dockerfiles/centos8.docker
> > @@ -1,4 +1,4 @@
> > -FROM centos:8.1.1911
> > +FROM registry.centos.org/centos:8
>
> At least for centos-8 I've noticed the
15.11.2020 14:36, Lukas Straub wrote:
Register a yank function which shuts down the socket and sets
s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an
error occured.
Signed-off-by: Lukas Straub
Acked-by: Stefan Hajnoczi
Hi! Could I ask, what's the reason for qatomic_load_acquire
From: Philippe Mathieu-Daudé
dma_memory_rw_relaxed() returns a MemTxResult type.
Do not discard it, return it to the caller.
Reviewed-by: Richard Henderson
Reviewed-by: Li Qiang
Reviewed-by: Edgar E. Iglesias
Signed-off-by: Philippe Mathieu-Daudé
Message-Id:
From: Philippe Mathieu-Daudé
In order to use inclusive terminology, rename 'slave stream'
as 'sink stream'.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Paolo Bonzini
Reviewed-by: Edgar E. Iglesias
Message-Id: <20200910070131.435543-4-phi...@redhat.com>
Signed-off-by: Paolo Bonzini
---
Use the machine properties instead.
Cc: Mark Cave-Ayland
Signed-off-by: Paolo Bonzini
---
hw/sparc64/sparc64.c | 3 ++-
hw/sparc64/sun4u.c | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/hw/sparc64/sparc64.c b/hw/sparc64/sparc64.c
index 100b2fab17..e3f9219a10 100644
Use the machine properties instead.
Cc: qemu-...@nongnu.org
Signed-off-by: Paolo Bonzini
---
hw/ppc/prep.c | 2 +-
hw/ppc/spapr_vio.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
index c6b9d1ddcb..7e72f6e4a9 100644
---
Move CHECKPOINT_INIT right before the machine initialization is
completed. Everything before is essentially an extension of
command line parsing.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
hw/core/machine.c | 5 +
softmmu/vl.c | 5
The final part of qemu_init, starting with the completion of
board init, is already relatively clean. Split it out of
qemu_init so that qemu_init keeps only the messy parts.
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 249
Reviewed-by: Igor Mammedov
Signed-off-by: Paolo Bonzini
---
softmmu/vl.c | 113 +++
1 file changed, 60 insertions(+), 53 deletions(-)
diff --git a/softmmu/vl.c b/softmmu/vl.c
index d9fe9f63c0..5af52454ee 100644
--- a/softmmu/vl.c
+++
From: Mauro Carvalho Chehab
Sphinx is very pedantic with respect to blank lines. Sometimes,
in order to make it to properly handle something, we need to
add a blank line. However, currently, any blank line inside a
kernel-doc comment like:
/*
* @foo: bar
*
*
From: Jonathan Neuschäfer
Currently, when kernel-doc encounters a macro with a named variable
argument[1], such as this:
#define hlist_for_each_entry_rcu(pos, head, member, cond...)
... it expects the variable argument to be documented as `cond...`,
rather than `cond`. This is semantically
Machine options can be retrieved as properties of the machine object.
Encourage that by removing the "easy" accessor to machine options.
Signed-off-by: Paolo Bonzini
---
accel/kvm/kvm-all.c | 11 ---
hw/arm/boot.c | 2 +-
hw/microblaze/boot.c| 9 -
From: Mauro Carvalho Chehab
There are a few namespace clashes by using c:macro everywhere:
basically, when using it, we can't have something like:
.. c:struct:: pwm_capture
.. c:macro:: pwm_capture
So, we need to use, instead:
.. c:function:: int pwm_capture (struct
From: Mauro Carvalho Chehab
There are some function pointer prototypes inside the net
includes, like this one:
int (*pcs_config)(struct phylink_config *config, unsigned int mode,
phy_interface_t interface, const unsigned long
*advertising);
There's nothing
From: Mauro Carvalho Chehab
While kernel-doc needs to parse parameters in order to
identify its name, it shouldn't be touching the type,
as parsing it is very difficult, and errors happen.
One current error is when parsing this parameter:
const u32 (*tab)[256]
Found at ./lib/crc32.c,
On 12/1/20 11:35 AM, Paolo Bonzini wrote:
> A comment in kernel-doc mentions QEMU's qatomic_set macro, but since
> this code originated in Linux we should just revert it and stay as close
> to the kernel's copy of the script as possible.
>
> The change was introduced (more or less
Add generic machinery to support parsing command line options with
keyval in -set and -readconfig, choosing between QDict and
QemuOpts as the underlying data structure.
The keyval_merge function is slightly heavyweight as a way to
do qemu_set_option for QDict-based options, but it will be put
to
Options such as "server" or "nowait", that are commonly found in -chardev,
are sugar for "server=on" and "wait=off". This is quite surprising and
also does not have any notion of typing attached. It is even possible to
do "-device e1000,noid" and get a device with "id=off".
Deprecate it and
Am 09.11.2020 um 16:43 hat Gan Qixin geschrieben:
> Replace manual lock()/unlock() calls with lock guard macros
> (QEMU_LOCK_GUARD/WITH_QEMU_LOCK_GUARD) in block/iscsi.c.
>
> Signed-off-by: Gan Qixin
> ---
> block/iscsi.c | 28 +---
> 1 file changed, 13 insertions(+), 15
From: David Woodhouse
The IOAPIC has an 'Extended Destination ID' field in its RTE, which maps
to bits 11-4 of the MSI address. Since those address bits fall within a
given 4KiB page they were historically non-trivial to use on real hardware.
The Intel IOMMU uses the lowest bit to indicate a
Most property release functions in qom/object.c only free the opaque
value. Combine all of them into a single function.
Signed-off-by: Paolo Bonzini
---
qom/object.c | 36 +++-
1 file changed, 7 insertions(+), 29 deletions(-)
diff --git a/qom/object.c
From: Philippe Mathieu-Daudé
In order to use inclusive terminology, rename 'slave stream'
as 'sink stream'.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Paolo Bonzini
Reviewed-by: Edgar E. Iglesias
Message-Id: <20200910070131.435543-5-phi...@redhat.com>
Signed-off-by: Paolo Bonzini
---
Use the loader parameters instead.
Cc: Philippe Mathieu-Daudé
Signed-off-by: Paolo Bonzini
---
hw/moxie/moxiesim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/moxie/moxiesim.c b/hw/moxie/moxiesim.c
index d07d504c0d..f7b57fcae1 100644
--- a/hw/moxie/moxiesim.c
+++
Cc: Michael Walle
Signed-off-by: Paolo Bonzini
Reviewed-by: Alex Bennée
Message-Id: <20201026143028.3034018-7-pbonz...@redhat.com>
Signed-off-by: Paolo Bonzini
---
hw/lm32/milkymist.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/lm32/milkymist.c
The ROM loader state is global and not part of the MCU, and the
BIOS is in machine->firmware. So just like the kernel case,
load it in the board.
Due to the ordering between CPU reset and ROM reset, the ROM
has to be registered before the CPU is realized, otherwise
the reset vector is loaded
Use the equivalent argument to the function instead.
Signed-off-by: Paolo Bonzini
---
hw/microblaze/boot.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/microblaze/boot.c b/hw/microblaze/boot.c
index 8ad3c27f2c..e1f56f83f9 100644
--- a/hw/microblaze/boot.c
+++
Use the machine properties instead.
Cc: Laurent Vivier
Reviewed-by: Thomas Huth
Signed-off-by: Paolo Bonzini
---
hw/m68k/mcf5206.c | 4 +++-
hw/m68k/mcf5208.c | 3 ++-
target/m68k/m68k-semi.c | 5 +++--
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git
Use the machine properties or loader parameters instead.
Cc: Philippe Mathieu-Daudé
Signed-off-by: Paolo Bonzini
---
hw/mips/fuloong2e.c | 4 ++--
hw/mips/malta.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c
index
From: André Almeida
The current regular expression for strip attributes of structs (and
for nested ones as well) also removes all whitespaces that may
surround the attribute. After that, the code will split structs and
iterate for each symbol separated by comma at the end of struct
definition
From: Mauro Carvalho Chehab
Address several issues related to pointing to the wrong line
number:
1) ensure that line numbers will always be initialized
When section is the default (Description), the line number
is not initializing, producing this:
$ ./scripts/kernel-doc
101 - 200 of 406 matches
Mail list logo
