[PULL 070/113] vl: separate qemu_resolve_machine_memdev

2020-12-02 Thread Paolo Bonzini
This is a bit nasty: the machine is storing a string and later resolving it. We probably want to remove the memdev property and instead make this a memory-set command. "-M memdev" can be handled a legacy option that is special cased by machine_set_property. Reviewed-by: Igor Mammedov

[PULL 037/113] cris: do not use ram_size global

2020-12-02 Thread Paolo Bonzini
Use the machine properties instead. Signed-off-by: Paolo Bonzini --- hw/cris/axis_dev88.c | 1 + hw/cris/boot.c | 2 +- hw/cris/boot.h | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/cris/axis_dev88.c b/hw/cris/axis_dev88.c index dab7423c73..b0cb6d84af 100644

[PULL 060/113] vl: extract various command line desugaring snippets to a new function

2020-12-02 Thread Paolo Bonzini
Keep the machine initialization sequence free of miscellaneous command line parsing actions. The only difference is that preallocation will always be done with one thread if -smp is not provided; previously it was using mc->default_cpus, which is almost always 1 anyway. Reviewed-by: Igor

[PULL 050/113] hw/char/serial: Clean up unnecessary code

2020-12-02 Thread Paolo Bonzini
From: Philippe Mathieu-Daudé Since commit 5ec3a23e6c8 ("serial: convert PIO to new memory api read/write") we don't need to worry about accesses bigger than 8-bit. Use the extract()/deposit() functions to access the correct part of the 16-bit 'divider' register. Reported-by: Jonathan D.

[PULL 102/113] scripts: kernel-doc: fix typedef identification

2020-12-02 Thread Paolo Bonzini
From: Mauro Carvalho Chehab Some typedef expressions are output as normal functions. As we need to be clearer about the type with Sphinx 3.x, detect such cases. While here, fix a wrongly-indented block. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Paolo Bonzini Message-Id:

[PULL 100/113] scripts: kernel-doc: fix troubles with line counts

2020-12-02 Thread Paolo Bonzini
From: Mauro Carvalho Chehab There's currently a bug with the way kernel-doc script counts line numbers that can be seen with: $ ./scripts/kernel-doc -rst -enable-lineno include/linux/math64.h >all && ./scripts/kernel-doc -rst -internal -enable-lineno include/linux/math64.h >int &&

[PATCH 03/28] qemu-option: clean up id vs. list->merge_lists

2020-12-02 Thread Paolo Bonzini
Looking at all merge-lists QemuOptsList, here is how they access their QemuOpts: reopen_opts in qemu-io-cmds.c ("qemu-img reopen -o") qemu_opts_find(_opts, NULL) empty_opts in qemu-io.c ("qemu-io open -o") qemu_opts_find(_opts, NULL) qemu_rtc_opts ("-rtc")

[PATCH 08/28] tests: convert check-qom-proplist to keyval

2020-12-02 Thread Paolo Bonzini
The command-line creation test is using QemuOpts. Switch it to keyval, since all the -object command line options will follow qemu-storage-daemon and do the same. Signed-off-by: Paolo Bonzini --- tests/check-qom-proplist.c | 58 +- 1 file changed, 38

Re: [PATCH v3 6/6] linux-user: Add support for MIPS Loongson 2F/3E

2020-12-02 Thread Philippe Mathieu-Daudé
On 12/2/20 2:01 AM, chen huacai wrote: > Hi, Philippe, > > On Wed, Dec 2, 2020 at 3:31 AM Philippe Mathieu-Daudé wrote: >> >> Userland ELF binaries using Longsoon SIMD instructions have the >> HWCAP_LOONGSON_MMI bit set [1]. >> Binaries compiled for Longsoon 3E [2] have the HWCAP_LOONGSON_EXT >>

Re: [PATCH 0/4] Use lock guard macros in block

2020-12-02 Thread Paolo Bonzini
On 02/12/20 10:22, Markus Armbruster wrote: Did this fall through the cracks? Gan Qixin writes: Hi all, I saw some tasks to replace manual lock()/unlock() calls with lock guard macros in BiteSizedTasks. I am very interested in this and modified some of the files under block. Could

Re: [PATCH v2 00/27] Virtio net failover fixes

2020-12-02 Thread Michael S. Tsirkin
On Wed, Nov 18, 2020 at 09:37:21AM +0100, Juan Quintela wrote: > Hi I tagged this for after the release. To help make sure this is not lost pls ping me after the release. Thanks! > This is a big rework of the network failover setup. General idea is: > * We don't cache the name of the

Re: [PATCH v2 01/27] migration: Network Failover can't work with a paused guest

2020-12-02 Thread Michael S. Tsirkin
On Wed, Dec 02, 2020 at 05:31:53AM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2020 at 10:27:18AM +, Daniel P. Berrangé wrote: > > On Wed, Dec 02, 2020 at 05:13:18AM -0500, Michael S. Tsirkin wrote: > > > On Wed, Nov 18, 2020 at 09:37:22AM +0100, Juan Quintela wrote: > > > > If we have

[PULL 4/6] memory: Add IOMMU_NOTIFIER_DEVIOTLB_UNMAP IOMMUTLBNotificationType

2020-12-02 Thread Michael S. Tsirkin
From: Eugenio Pérez This allows us to differentiate between regular IOMMU map/unmap events and DEVIOTLB unmap. Doing so, notifiers that only need device IOTLB invalidations will not receive regular IOMMU unmappings. Adapt intel and vhost to use it. Signed-off-by: Eugenio Pérez Reviewed-by:

Re: [PATCH 12/15] plugin: propagate errors

2020-12-02 Thread Alex Bennée
Paolo Bonzini writes: > qemu_finish_machine_init currently can only exit QEMU if it fails. > Prepare for giving it proper error propagation, and possibly for > adding a plugin_add monitor command that calls an accelerator > method. > > While at it, make all errors from plugin_load look the

Re: [PATCH v2] hw/arm/virt enable support for virtio-mem

2020-12-02 Thread Jonathan Cameron
On Wed, 2 Dec 2020 05:02:57 -0500 "Michael S. Tsirkin" wrote: > On Wed, Nov 25, 2020 at 02:56:59PM +, Jonathan Cameron wrote: > > Cool. I'll run a few more comprehensive tests then send out the > > trivial patch to enable the kernel option + v2 of the qemu support. > > IIUC there will be

[PULL 3/6] memory: Add IOMMUTLBEvent

2020-12-02 Thread Michael S. Tsirkin
From: Eugenio Pérez This way we can tell between regular IOMMUTLBEntry (entry of IOMMU hardware) and notifications. In the notifications, we set explicitly if it is a MAPs or an UNMAP, instead of trusting in entry permissions to differentiate them. Signed-off-by: Eugenio Pérez Reviewed-by:

Re: [PULL 000/113] First batch of misc (i386, kernel-doc, memory, vl.c) changes for QEMU 6.0

2020-12-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201202080849.4125477-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201202080849.4125477-1-pbonz...@redhat.com Subject: [PULL 000/113] First batch of

Re: [PATCH 18/23] tests/docker: auto-generate centos7 with lcitool

2020-12-02 Thread Gerd Hoffmann
Hi, > +RUN echo 'skip_missing_names_on_install=0' >> /etc/yum.conf && \ > +yum install -y epel-release && \ > +yum install -y centos-release-xen-48 && \ > +yum update -y && \ > +yum install -y \ > +SDL2-devel \ More a comment for lcitool I guess: rpmbuild generates

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Paolo Bonzini
On 02/12/20 11:38, Kevin Wolf wrote: Am 02.12.2020 um 10:30 hat Paolo Bonzini geschrieben: On 01/12/20 23:08, Eduardo Habkost wrote: Properties are only a useful concept if they have a use. If -object/object_add/object-add can do the same job without properties, properties are not needed

Re: check-tcg errors (build-user, build-user-plugins) again

2020-12-02 Thread Alex Bennée
Claudio Fontana writes: > On 12/2/20 12:16 PM, Alex Bennée wrote: >> >> Claudio Fontana writes: >> >>> Hi Alex and all, >>> >>> when trying to use check-tcg (master), I am getting often these errors: >>> >>> $ ../configure --disable-system --disable-tools >>> >>> $ make -j12 check-tcg >>>

Re: [PATCH 06/15] arc: TCG instruction definitions

2020-12-02 Thread Cupertino Miranda
Hi Richard, Thank you so much for your reviews. I will start working on improving the code straight away to try to minimize waiting times. However lets just address the elephant in the room. Indeed we have the TCG definitions being generated. However we are very serious about wanting to upstream

Re: [PATCH v2 1/8] libvhost-user: replace qemu/bswap.h with glibc endian.h

2020-12-02 Thread Stefan Hajnoczi
On Wed, Nov 25, 2020 at 02:06:33PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Reviewed-by: Dr. David Alan Gilbert > Reviewed-by: Stefan Hajnoczi > --- > contrib/libvhost-user/libvhost-user.c | 77 ++- > 1

Re: [PATCH v2 5/8] libvhost-user: make it a meson subproject

2020-12-02 Thread Stefan Hajnoczi
On Wed, Nov 25, 2020 at 02:06:37PM +0400, marcandre.lur...@redhat.com wrote: > diff --git a/meson.build b/meson.build > index 5062407c70..1b14998691 100644 > --- a/meson.build > +++ b/meson.build > @@ -1476,7 +1476,12 @@ trace_events_subdirs += [ >'util', > ] > >

Re: check-tcg errors (build-user, build-user-plugins) again

2020-12-02 Thread Philippe Mathieu-Daudé
On 12/2/20 12:25 PM, Claudio Fontana wrote: > On 12/2/20 12:16 PM, Alex Bennée wrote: >> Claudio Fontana writes: >>> Is there some pre-configuration on the host necessary to be able to >>> run check-tcg? >> >> There shouldn't be but those errors remind me of some of the tweaks I >> had to make to

Re: [PATCH v2 8/8] .gitlab-ci: add build-libvhost-user

2020-12-02 Thread Philippe Mathieu-Daudé
On 11/25/20 11:06 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > .gitlab-ci.yml | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index d0173e82b1..e517506c35 100644 > ---

Re: [PATCH 24/29] migration, vl: start migration via qmp_migrate_incoming

2020-12-02 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 20/11/20 16:34, Igor Mammedov wrote: > > > qapi_event_send_migration(MIGRATION_STATUS_SETUP); > > > -if (!strcmp(uri, "defer")) { > > > -deferred_incoming_migration(errp); > > > -} else if (strstart(uri, "tcp:", ) || > > > -

Re: [PATCH v2 3/8] libvhost-user: remove qemu/compiler.h usage

2020-12-02 Thread Stefan Hajnoczi
On Wed, Nov 25, 2020 at 02:06:35PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > contrib/libvhost-user/libvhost-user.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc

Re: [PATCH] hw/pci-host/pam: Replace magic number by PAM_REGIONS_COUNT definition

2020-12-02 Thread Julia Suvorova
On Wed, Dec 2, 2020 at 2:24 PM Philippe Mathieu-Daudé wrote: > > While this change helps triskaidekaphobic developers, it > is a good practice to avoid magic values and using constant > definitions instead. > > Introduce the PAM_REGIONS_COUNT and use it. No logical change. > > Signed-off-by:

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Kevin Wolf
Am 02.12.2020 um 14:54 hat Eduardo Habkost geschrieben: > On Wed, Dec 02, 2020 at 02:26:44PM +0100, Paolo Bonzini wrote: > > On 02/12/20 13:51, Eduardo Habkost wrote: > > > > > I'm liking the direction this is taking. However, I would still > > > > > like to have a clearer and feasible plan that

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread Daniel P . Berrangé
On Mon, Nov 30, 2020 at 07:19:07PM +0530, P J P wrote: > From: Prasad J Pandit > > We are about to introduce a qemu-security mailing list to report > and triage QEMU security issues. > > Update the QEMU security process web page with new mailing list > and triage details. > > Signed-off-by:

Re: [PATCH v11 2/7] block/nbd.c: Add yank feature

2020-12-02 Thread Lukas Straub
On Wed, 2 Dec 2020 15:18:48 +0300 Vladimir Sementsov-Ogievskiy wrote: > 15.11.2020 14:36, Lukas Straub wrote: > > Register a yank function which shuts down the socket and sets > > s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an > > error occured. > > > > Signed-off-by: Lukas

virtiofsd-rs: A rust virtiofs daemon

2020-12-02 Thread Dr. David Alan Gilbert
Hi, Sergio has been working on virtiofsd-rs, a virtiofs daemon written in rust, and which can be found at: https://gitlab.com/virtio-fs/virtiofsd-rs It started life originally as part of the crosvm project, got ported to vhost-user as part of the Cloud Hypervisor project, and has now been

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Paolo Bonzini
On 02/12/20 11:27, Kevin Wolf wrote: Declaring read-only QOM properties is trivial. Trivial sounds like it's something the computer should be doing. Possibly, but not necessarily. There's always a cost to automatic code generation. If things are _too_ trivial and easy to get right, the

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Paolo Bonzini
On 02/12/20 13:51, Eduardo Habkost wrote: I'm liking the direction this is taking. However, I would still like to have a clearer and feasible plan that would work for -device, -machine, and -cpu. -cpu is not a problem since it's generally created with a static configuration (now done with

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread Philippe Mathieu-Daudé
Hi Prasad, On 11/30/20 2:49 PM, P J P wrote: > From: Prasad J Pandit > ... > +## How we respond: > + > +* Process of handling security issues can be divided in two halves. > + Maybe: 0) **Acknowledge reception** - A non-automated response email is sent to acknowledge the

Re: [PATCH v2 8/8] .gitlab-ci: add build-libvhost-user

2020-12-02 Thread Stefan Hajnoczi
On Wed, Nov 25, 2020 at 02:06:40PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > .gitlab-ci.yml | 11 +++ > 1 file changed, 11 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

RE: [raw] Guest stuck during live live-migration

2020-12-02 Thread Quentin Grolleau
Do you think that, applying this patch ( replacing by "#if 0" there : https://github.com/qemu/qemu/blob/master/block/file-posix.c#L2601 ), could affect for any reason the customer data ? As we are on full NVME and 10G networks it should fix our vm which completely freeze. Quentin

Re: [PATCH 0/4] vhost-user: avoid g_return_val_if() in get/set_config()

2020-12-02 Thread Stefan Hajnoczi
On Wed, Nov 18, 2020 at 07:21:15PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Nov 18, 2020 at 1:17 PM Stefan Hajnoczi wrote: > > > Markus Armbruster pointed out that g_return_val_if() is meant for > > programming > > errors. It must not be used for input validation since it can be

[PATCH v2 1/4] contrib/vhost-user-blk: avoid g_return_val_if() input validation

2020-12-02 Thread Stefan Hajnoczi
Do not validate input with g_return_val_if(). This API is intended for checking programming errors and is compiled out with -DG_DISABLE_CHECKS. Use an explicit if statement for input validation so it cannot accidentally be compiled out. Suggested-by: Markus Armbruster Signed-off-by: Stefan

[PATCH v2 2/4] contrib/vhost-user-gpu: avoid g_return_val_if() input validation

2020-12-02 Thread Stefan Hajnoczi
Do not validate input with g_return_val_if(). This API is intended for checking programming errors and is compiled out with -DG_DISABLE_CHECKS. Use an explicit if statement for input validation so it cannot accidentally be compiled out. Suggested-by: Markus Armbruster Signed-off-by: Stefan

[PATCH v2 0/4] vhost-user: avoid g_return_val_if() in get/set_config()

2020-12-02 Thread Stefan Hajnoczi
v2: * Print errors [Marc-André] Markus Armbruster pointed out that g_return_val_if() is meant for programming errors. It must not be used for input validation since it can be compiled out. Use explicit if statements instead. This patch series converts vhost-user device backends that use

[RFC PATCH] configure: add --without-default-features

2020-12-02 Thread Alex Bennée
By default QEMU enables a lot of features if it can probe and find the support libraries. It also enables a bunch of features by default. This patch adds the ability to build --without-default-features which can be paired with a --without-default-devices for a barely functional build. The main

Re: [PATCH] ide:atapi: check io_buffer_index in ide_atapi_cmd_reply_end

2020-12-02 Thread P J P
Hi, [doing a combined reply] +-- On Tue, 1 Dec 2020, Philippe Mathieu-Daudé wrote --+ | Is it possible to release the reproducer to the community, so we can work on | a fix and test it? * No, we can not release/share reproducers on a public list. * We can request reporters to do so by

Re: [PATCH v2 4/8] libvhost-user: drop qemu/osdep.h dependency

2020-12-02 Thread Stefan Hajnoczi
On Wed, Nov 25, 2020 at 02:06:36PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > contrib/libvhost-user/libvhost-user-glib.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [PATCH v2 2/8] libvhost-user: replace qemu/memfd.h usage

2020-12-02 Thread Stefan Hajnoczi
On Wed, Nov 25, 2020 at 02:06:34PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Undo the damage from commit 5f9ff1eff3 ("libvhost-user: Support tracking > inflight I/O in shared memory") which introduced glib dependency through > osdep.h inclusion. > > libvhost-user.c

Re: [PATCH v6] hw/i386/pc: add max combined fw size as machine configuration option

2020-12-02 Thread McMillan, Erich
Sure, no problem. From: Michael S. Tsirkin Sent: Wednesday, December 2, 2020 3:56 AM To: McMillan, Erich Cc: qemu-devel@nongnu.org ; ler...@redhat.com ; dgilb...@redhat.com ; marcel.apfelb...@gmail.com ; imamm...@redhat.com ; kra...@redhat.com Subject: Re:

Re: [PATCH v1 1/1] security-process: update process information

2020-12-02 Thread P J P
Hello Konrad, all +-- On Tue, 1 Dec 2020, Konrad Rzeszutek Wilk wrote --+ | On Mon, Nov 30, 2020 at 07:19:07PM +0530, P J P wrote: | > We are about to introduce a qemu-security mailing list to report | > and triage QEMU security issues. | > Update the QEMU security process web page with new

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Eduardo Habkost
On Wed, Dec 02, 2020 at 10:30:11AM +0100, Paolo Bonzini wrote: > On 01/12/20 23:08, Eduardo Habkost wrote: > > > Properties are only a useful concept if they have a use. If > > > -object/object_add/object-add can do the same job without properties, > > > properties are not needed anymore. > > >

Re: [PATCH 24/29] migration, vl: start migration via qmp_migrate_incoming

2020-12-02 Thread Daniel P . Berrangé
On Wed, Dec 02, 2020 at 01:10:37PM +, Dr. David Alan Gilbert wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: > > On 20/11/20 16:34, Igor Mammedov wrote: > > > > qapi_event_send_migration(MIGRATION_STATUS_SETUP); > > > > -if (!strcmp(uri, "defer")) { > > > > -

Re: [PATCH 24/29] migration, vl: start migration via qmp_migrate_incoming

2020-12-02 Thread Paolo Bonzini
On 02/12/20 14:15, Daniel P. Berrangé wrote: Can someone remind me why we need to have an -incoming arg at all ? With snapshots, we can just start QEMU normally, using -S if desired, and then invoke "loadvm" to restore from a snapshot at any time. What is different thet means we can't just run

Re: [PATCH] linux-user/elfload: Fix handling of pure BSS segments

2020-12-02 Thread Alex Bennée
Stephen Long writes: > Alex Bennee writes: > >>> Apologies for the unclear commit msg. I was also seeing a SIGSEGV in >>> zero_bss() with the binaries I was generating. I was using LLD to generate >>> the binaries. The binaries all had LOAD segments with a file size of >>> 0. >> >> How hairy

Re: [RFC PATCH v2 0/5] eBPF RSS support for virtio-net

2020-12-02 Thread Jason Wang
On 2020/11/19 下午7:13, Andrew Melnychenko wrote: This set of patches introduces the usage of eBPF for packet steering and RSS hash calculation: * RSS(Receive Side Scaling) is used to distribute network packets to guest virtqueues by calculating packet hash * Additionally adding support for the

[Bug 1906516] [NEW] [RISCV] sfence.vma need to end the translation block

2020-12-02 Thread jinyan
Public bug reported: QEMU emulator version 5.0.0 sfence.vma will flush the tlb, so after this instruction, the translation block should be end. The following code will only work in single step mode: ``` relocate: li a0, OFFSET la t0, 1f add t0, t0, a0 csrw

Re: [PATCH v2 6/8] libvhost-user: check memfd API

2020-12-02 Thread Stefan Hajnoczi
On Wed, Nov 25, 2020 at 02:06:38PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Do not compile potentially panicking code, instead check memfd API is > present during configure time. > > Signed-off-by: Marc-André Lureau > --- >

Re: [PATCH v2 7/8] libvhost-user: add a simple link test without glib

2020-12-02 Thread Stefan Hajnoczi
On Wed, Nov 25, 2020 at 02:06:39PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > subprojects/libvhost-user/link-test.c | 45 +++ > subprojects/libvhost-user/meson.build | 4 +++ > 2 files changed, 49

[PATCH] hw/block: m25p80: Implement AAI-WP command support for SST flashes

2020-12-02 Thread Bin Meng
From: Xuzhou Cheng Auto Address Increment (AAI) Word-Program is a special command of SST flashes. AAI-WP allows multiple bytes of data to be programmed without re-issuing the next sequential address location. Signed-off-by: Xuzhou Cheng Signed-off-by: Bin Meng --- hw/block/m25p80.c | 17

Re: [PATCH 24/29] migration, vl: start migration via qmp_migrate_incoming

2020-12-02 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 02/12/20 14:10, Dr. David Alan Gilbert wrote: > > I'm more worried about how this stops a repeated 'migrate incoming' > > or a 'migrate_incoming' that's issued following a qemu that's been > > started with -incoming tcp:... but which a socket

Re: [raw] Guest stuck during live live-migration

2020-12-02 Thread Kevin Wolf
Am 02.12.2020 um 16:09 hat Quentin Grolleau geschrieben: > Do you think that, applying this patch ( replacing by "#if 0" there : > https://github.com/qemu/qemu/blob/master/block/file-posix.c#L2601 ), > could affect for any reason the customer data ? > > As we are on full NVME and 10G networks it

[PATCH] hw/pci-host/pam: Replace magic number by PAM_REGIONS_COUNT definition

2020-12-02 Thread Philippe Mathieu-Daudé
While this change helps triskaidekaphobic developers, it is a good practice to avoid magic values and using constant definitions instead. Introduce the PAM_REGIONS_COUNT and use it. No logical change. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci-host/i440fx.h | 2 +-

Re: [PATCH] ide:atapi: check io_buffer_index in ide_atapi_cmd_reply_end

2020-12-02 Thread Paolo Bonzini
On 02/12/20 14:17, P J P wrote: Hi, [doing a combined reply] +-- On Tue, 1 Dec 2020, Philippe Mathieu-Daudé wrote --+ | Is it possible to release the reproducer to the community, so we can work on | a fix and test it? * No, we can not release/share reproducers on a public list. We do

[PATCH] i386/cpu: Fix Icelake Server model number

2020-12-02 Thread Tim Wiederhake
See arch/x86/include/asm/intel-family.h in the Kernel: #define INTEL_FAM6_ICELAKE_X 0x6A Signed-off-by: Tim Wiederhake --- target/i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 5a8c96072e..67e3f92f98 100644

Re: [PATCH] tests/acceptance: fix timeout for vm.wait

2020-12-02 Thread John Snow
On 12/2/20 1:31 AM, Pavel Dovgalyuk wrote: This patch adds timeout parameter to vm.wait() calls, because the default value is just 30 seconds, and tests may last for more time. This doesn't sound right -- the timeout isn't meant to be for the entire duration of the test, the timeout is

[PATCH v2 4/4] block/export: avoid g_return_val_if() input validation

2020-12-02 Thread Stefan Hajnoczi
Do not validate input with g_return_val_if(). This API is intended for checking programming errors and is compiled out with -DG_DISABLE_CHECKS. Use an explicit if statement for input validation so it cannot accidentally be compiled out. Suggested-by: Markus Armbruster Signed-off-by: Stefan

Re: [PATCH 24/29] migration, vl: start migration via qmp_migrate_incoming

2020-12-02 Thread Paolo Bonzini
On 02/12/20 14:10, Dr. David Alan Gilbert wrote: I'm more worried about how this stops a repeated 'migrate incoming' or a 'migrate_incoming' that's issued following a qemu that's been started with -incoming tcp:... but which a socket hasn't yet connected to. Good question, fortunately it is

Re: [PATCH] ide:atapi: check io_buffer_index in ide_atapi_cmd_reply_end

2020-12-02 Thread Philippe Mathieu-Daudé
On 12/2/20 2:17 PM, P J P wrote: > +-- On Tue, 1 Dec 2020, Philippe Mathieu-Daudé wrote --+ > | Is it possible to release the reproducer to the community, so we can work > on > | a fix and test it? > > * No, we can not release/share reproducers on a public list. > > * We can request

Re: [PATCH 00/18] qapi/qom: QAPIfy object-add

2020-12-02 Thread Eduardo Habkost
On Wed, Dec 02, 2020 at 02:26:44PM +0100, Paolo Bonzini wrote: > On 02/12/20 13:51, Eduardo Habkost wrote: > > > > I'm liking the direction this is taking. However, I would still > > > > like to have a clearer and feasible plan that would work for > > > > -device, -machine, and -cpu. > > > > > >

Re: virtiofsd-rs: A rust virtiofs daemon

2020-12-02 Thread Stefan Hajnoczi
On Wed, Dec 02, 2020 at 12:34:10PM +, Dr. David Alan Gilbert wrote: > Sergio has been working on virtiofsd-rs, a virtiofs daemon > written in rust, and which can be found at: > > https://gitlab.com/virtio-fs/virtiofsd-rs > > It started life originally as part of the crosvm project, got >

Re: check-tcg errors (build-user, build-user-plugins) again

2020-12-02 Thread Claudio Fontana
On 12/2/20 1:52 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> On 12/2/20 12:16 PM, Alex Bennée wrote: >>> >>> Claudio Fontana writes: >>> Hi Alex and all, when trying to use check-tcg (master), I am getting often these errors: $ ../configure --disable-system

Re: [RFC PATCH v2 0/5] eBPF RSS support for virtio-net

2020-12-02 Thread Toke Høiland-Jørgensen
Jason Wang writes: > On 2020/11/19 下午7:13, Andrew Melnychenko wrote: >> This set of patches introduces the usage of eBPF for packet steering >> and RSS hash calculation: >> * RSS(Receive Side Scaling) is used to distribute network packets to >> guest virtqueues by calculating packet hash >> *

[PATCH v2 1/2] hw/ssi: imx_spi: Use a macro for number of chip selects supported

2020-12-02 Thread Bin Meng
From: Bin Meng Avoid using a magic number (4) everywhere for the number of chip selects supported. Signed-off-by: Bin Meng Reviewed-by: Alistair Francis --- (no changes since v1) hw/ssi/imx_spi.c | 4 ++-- include/hw/ssi/imx_spi.h | 5 - 2 files changed, 6 insertions(+), 3

[PATCH v2 2/2] hw/ssi: imx_spi: Disable chip selects in imx_spi_reset()

2020-12-02 Thread Bin Meng
From: Xuzhou Cheng When a write to ECSPI_CONREG register to disable the SPI controller, imx_spi_reset() is called to reset the controller, during which CS lines should have been disabled, otherwise the state machine of any devices (e.g.: SPI flashes) connected to the SPI master is stuck to its

[PATCH v2 3/4] contrib/vhost-user-input: avoid g_return_val_if() input validation

2020-12-02 Thread Stefan Hajnoczi
Do not validate input with g_return_val_if(). This API is intended for checking programming errors and is compiled out with -DG_DISABLE_CHECKS. Use an explicit if statement for input validation so it cannot accidentally be compiled out. Suggested-by: Markus Armbruster Signed-off-by: Stefan

[PATCH 4/9] target/mips: Simplify MSA TCG logic

2020-12-02 Thread Philippe Mathieu-Daudé
Only decode MSA opcodes if MSA is present (implemented). Now than check_msa_access() will only be called if MSA is present, the only way to have MIPS_HFLAG_MSA unset is if MSA is disabled (bit CP0C5_MSAEn cleared, see previous commit). Therefore we can remove the 'reserved instruction' exception.

[PATCH 5/9] target/mips: Remove now unused ASE_MSA definition

2020-12-02 Thread Philippe Mathieu-Daudé
We don't use ASE_MSA anymore (replaced by ase_msa_available() checking MSAP bit from CP0_Config3). Remove it. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/mips-defs.h | 1 - target/mips/translate_init.c.inc | 8 2 files changed, 4 insertions(+), 5 deletions(-) diff

[PATCH v3 00/10] hvf: Implement Apple Silicon Support

2020-12-02 Thread Alexander Graf
Now that Apple Silicon is widely available, people are obviously excited to try and run virtualized workloads on them, such as Linux and Windows. This patch set implements a fully functional version to get the ball going on that. With this applied, I can successfully run both Linux and Windows as

[PATCH v3 09/10] hvf: arm: Add support for GICv3

2020-12-02 Thread Alexander Graf
We currently only support GICv2 emulation. To also support GICv3, we will need to pass a few system registers into their respective handler functions. This patch adds handling for all of the required system registers, so that we can run with more than 8 vCPUs. Signed-off-by: Alexander Graf ---

[PATCH v3 05/10] hvf: arm: Mark CPU as dirty on reset

2020-12-02 Thread Alexander Graf
When clearing internal state of a CPU, we should also make sure that HVF knows about it and can push the new values down to vcpu state. Make sure that with HVF enabled, we tell it that it should synchronize CPU state on next entry after a reset. This fixes PSCI handling, because now newly pushed

[PATCH v3 04/10] arm: Set PSCI to 0.2 for HVF

2020-12-02 Thread Alexander Graf
In Hypervisor.framework, we just pass PSCI calls straight on to the QEMU emulation of it. That means, if TCG is compatible with PSCI 0.2, so are we. Let's transpose that fact in code too. Signed-off-by: Alexander Graf --- target/arm/cpu.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [RFC PATCH] configure: add --without-default-features

2020-12-02 Thread Alex Bennée
Alex Bennée writes: > By default QEMU enables a lot of features if it can probe and find the > support libraries. It also enables a bunch of features by default. > This patch adds the ability to build --without-default-features which > can be paired with a --without-default-devices for a

[PATCH v3 10/10] hvf: arm: Implement -cpu host

2020-12-02 Thread Alexander Graf
Now that we have working system register sync, we push more target CPU properties into the virtual machine. That might be useful in some situations, but is not the typical case that users want. So let's add a -cpu host option that allows them to explicitly pass all CPU capabilities of their host

Re: [PATCH v2 1/1] Fix to show vfio migration stat in migration status

2020-12-02 Thread Alex Williamson
On Wed, 2 Dec 2020 00:43:14 +0530 Kirti Wankhede wrote: > Header file where CONFIG_VFIO is defined is not included in migration.c > file. > > Moved populate_vfio_info() to hw/vfio/common.c file. Added its stub in > stubs/vfio.c file. Updated header files and meson file accordingly. > > Fixes:

Re: [PATCH] hw/block: m25p80: Fix fast read for SST flashes

2020-12-02 Thread Alistair Francis
On Sun, Nov 29, 2020 at 6:55 PM Bin Meng wrote: > > From: Bin Meng > > SST flashes require a dummy byte after the address bits. > > Signed-off-by: Bin Meng I couldn't find a datasheet that says this... But the actual code change looks fine, so: Acked-by: Alistair Francis Alistair > --- > >

[PATCH 6/9] target/mips: Alias MSA vector registers on FPU scalar registers

2020-12-02 Thread Philippe Mathieu-Daudé
Commits 863f264d10f ("add msa_reset(), global msa register") and cb269f273fd ("fix multiple TCG registers covering same data") removed the FPU scalar registers and replaced them by aliases to the MSA vector registers. While this might be the case for CPU implementing MSA, this makes QEMU code

Re: [PATCH] docs: set CONFDIR when running sphinx

2020-12-02 Thread Eduardo Habkost
On Wed, Dec 02, 2020 at 10:05:50AM +0100, Paolo Bonzini wrote: > On 01/12/20 19:37, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > The default configuration path /etc/qemu can be overriden with configure > > options, and the generated documentation used to reflect it. > >

Re: [PATCH v3 3/3] arm/hvf: Add a WFI handler

2020-12-02 Thread Peter Collingbourne
On Wed, Dec 2, 2020 at 10:49 AM Alexander Graf wrote: > > > On 02.12.20 05:44, Peter Collingbourne wrote: > > Sleep on WFI until the VTIMER is due but allow ourselves to be woken > > up on IPI. > > > > Signed-off-by: Peter Collingbourne > > --- > > v3: > > - move the simplified locking to a

Re: [PATCH v3 3/3] arm/hvf: Add a WFI handler

2020-12-02 Thread Alexander Graf
On 02.12.20 05:44, Peter Collingbourne wrote: Sleep on WFI until the VTIMER is due but allow ourselves to be woken up on IPI. Signed-off-by: Peter Collingbourne --- v3: - move the simplified locking to a separate patch - spin on sleep <2ms v2: - simplify locking further - wait indefinitely

[PATCH v3 07/10] arm: Add Hypervisor.framework build target

2020-12-02 Thread Alexander Graf
Now that we have all logic in place that we need to handle Hypervisor.framework on Apple Silicon systems, let's add CONFIG_HVF for aarch64 as well so that we can build it. Signed-off-by: Alexander Graf --- v1 -> v2: - Fix build on 32bit arm --- meson.build| 11 ++-

Re: [PATCH v3 00/10] hvf: Implement Apple Silicon Support

2020-12-02 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201202190408.2041-1-ag...@csgraf.de/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201202190408.2041-1-ag...@csgraf.de Subject: [PATCH v3 00/10] hvf: Implement Apple Silicon

[PATCH v13 09/10] stream: skip filters when writing backing file name to QCOW2 header

2020-12-02 Thread Andrey Shinkevich via
Avoid writing a filter JSON file name and a filter format name to QCOW2 image when the backing file is being changed after the block stream job. It can occur due to a concurrent commit job on the same backing chain. A user is still able to assign the 'backing-file' parameter for a block-stream job

[PATCH 8/9] target/mips: Remove CPUMIPSState* argument from gen_msa*() methods

2020-12-02 Thread Philippe Mathieu-Daudé
The gen_msa*() methods don't use the "CPUMIPSState *env" argument. Remove it to simplify. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 57 - 1 file changed, 28 insertions(+), 29 deletions(-) diff --git a/target/mips/translate.c

[PATCH 7/9] target/mips: Extract msa_translate_init() from mips_tcg_init()

2020-12-02 Thread Philippe Mathieu-Daudé
Extract the logic initialization of the MSA registers from the generic initialization. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/translate.c | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/target/mips/translate.c

[PATCH v3 03/10] hvf: Introduce hvf vcpu struct

2020-12-02 Thread Alexander Graf
We will need more than a single field for hvf going forward. To keep the global vcpu struct uncluttered, let's allocate a special hvf vcpu struct, similar to how hax does it. Signed-off-by: Alexander Graf --- accel/hvf/hvf-cpus.c| 8 +- include/hw/core/cpu.h | 3 +-

[PATCH v3 02/10] hvf: Move common code out

2020-12-02 Thread Alexander Graf
Until now, Hypervisor.framework has only been available on x86_64 systems. With Apple Silicon shipping now, it extends its reach to aarch64. To prepare for support for multiple architectures, let's move common code out into its own accel directory. Signed-off-by: Alexander Graf --- MAINTAINERS

[PATCH v3 06/10] hvf: Add Apple Silicon support

2020-12-02 Thread Alexander Graf
With Apple Silicon available to the masses, it's a good time to add support for driving its virtualization extensions from QEMU. This patch adds all necessary architecture specific code to get basic VMs working. It's still pretty raw, but definitely functional. Known limitations: - Vtimer

[PATCH-for-5.2? 1/1] Acceptance tests: bump Fedora to 32

2020-12-02 Thread Cleber Rosa
Currently in use Fedora 31 has been moved out of the standard download locations that are supported by the functionality provided by avocado.utils.vmimage. So right now, the boot_linux.py tests will get canceled by not being able to find those specific images. Ideally, this would be bumped to

[PATCH-for-5.2? 0/1] Acceptance tests: bump Fedora to 32

2020-12-02 Thread Cleber Rosa
I believe this may be a candidate for "right now" because the code changes here simply sync with external infrastructure changes, that is, the retirement of Fedora 31 from the official repository locations). The following jobs contain a validation of this bump: -

[PATCH 1/9] target/mips: Introduce ase_msa_available() helper

2020-12-02 Thread Philippe Mathieu-Daudé
Instead of accessing CP0_Config3 directly and checking the 'MSA Present' bit, introduce an explicit helper, making the code easier to read. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/internal.h | 6 ++ target/mips/kvm.c | 12 ++-- target/mips/translate.c | 8

[PATCH 2/9] target/mips: Simplify msa_reset()

2020-12-02 Thread Philippe Mathieu-Daudé
Call msa_reset() inconditionally, but only reset the MSA registers if MSA is implemented. Signed-off-by: Philippe Mathieu-Daudé --- Maybe not very useful. --- target/mips/translate.c | 5 + target/mips/translate_init.c.inc | 4 2 files changed, 5 insertions(+), 4 deletions(-)

[PATCH 0/9] target/mips: Simplify MSA TCG logic

2020-12-02 Thread Philippe Mathieu-Daudé
I converted MSA opcodes to decodetree. To keep the series small I split it in 2, this is the non-decodetree specific patches (so non-decodetree experts can review it ;) ). First we stop using env->insn_flags to check for MSAi presence, then we restrict TCG functions to DisasContext*. Based-on:

[DISCUSSION] How to set properties of non-pluggable devices?

2020-12-02 Thread Doug Evans
Hi. Suppose I want to set a property of a non-pluggable device that cannot be set after the device has been realized (e.g., I can't use qmp to set the property after QEMU has started). Being non-pluggable means I can't use "-device foo,bar=baz" on the command line. [But I can use "-device

<    1   2   3   4   5   >