Daniel P. Berrangé 于2020年12月8日周二 下午9:45写道：
>
> On Tue, Dec 08, 2020 at 08:59:37PM +0800, Li Feng wrote:
> > This patch addresses this issue:
> > When accessing a volume on an NFS filesystem without supporting the file
> > lock,
> > tools, like qemu-img, will complain "Failed to lock byte 100".
>
在 2020/12/8 上午8:37, Philippe Mathieu-Daudé 写道:
Introduce the 'mod-msa32' decodetree config for the 32-bit MSA ASE.
We decode the branch instructions, and all instructions based
on the MSA opcode.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Jiaxun Yang
Double checked opcode
Kevin Wolf 于2020年12月8日周二 下午10:38写道：
>
> Am 08.12.2020 um 13:59 hat Li Feng geschrieben:
> > This patch addresses this issue:
> > When accessing a volume on an NFS filesystem without supporting the file
> > lock,
> > tools, like qemu-img, will complain "Failed to lock byte 100".
> >
> > In the
On Wed, Nov 4, 2020 at 21:29 Eduardo Habkost wrote:
> On Sat, Oct 31, 2020 at 09:51:38PM +0530, Ani Sinha wrote:
> > On Thu, Oct 15, 2020 at 10:22 PM Eduardo Habkost
> wrote:
> > >
> > > On Mon, Sep 21, 2020 at 03:03:25PM +0530, Ani Sinha wrote:
> > > > Object property insertion code iterates
This patch addresses this issue:
When accessing a volume on an NFS filesystem without supporting the file lock,
tools, like qemu-img, will complain "Failed to lock byte 100".
In the original code, the qemu_has_ofd_lock will test the lock on the
"/dev/null" pseudo-file. Actually, the file.locking
在 2020/12/8 上午8:36, Philippe Mathieu-Daudé 写道:
Finally, we use decodetree with the MIPS target.
Starting easy with the MSA ASE. 2700+ lines extracted
from helper.h and translate.c, now built as an new
object: mod-msa_translate.o.
While the diff stat is positive by 86 lines, we actually
Hi all,
I want to implement a new USB HID device in QEMU. I found that there exists
`hw/usb/dev-hid.c` on the source tree, but I did not find any further
documentation.
Would you please guide me how I should proceed?
Regards,
Ali
On 12/9/20 7:07 AM, zhouyang wrote:
> I found some style problems while check the code using checkpatch.pl.
> This commit fixs the issue below:
> ERROR: open brace '{' following struct go on the same line
>
> Signed-off-by: zhouyang
> ---
> fsdev/9p-marshal.h | 12
>
Hi Keith:
Thanks for the patch, I've verified with newlib semihosting support
which is contributed by Craig Blackmore from embecosm,
and I would like to add semihosting to user mode, do you mind add this
patch into this patch series?
On Thu, Nov 26, 2020 at 5:41 AM Keith Packard via wrote:
>
>
On 08.12.20 02:54, David Gibson wrote:
> On Fri, Dec 04, 2020 at 03:43:10PM +0100, Halil Pasic wrote:
>> On Fri, 4 Dec 2020 09:29:59 +0100
>> Christian Borntraeger wrote:
>>
>>> On 04.12.20 09:17, Cornelia Huck wrote:
On Fri, 4 Dec 2020 09:10:36 +0100
Christian Borntraeger wrote:
On Fri, Nov 20, 2020 at 07:50:48PM +0100, Eugenio Pérez wrote:
> Signed-off-by: Eugenio Pérez
> ---
> hw/virtio/vhost-sw-lm-ring.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/hw/virtio/vhost-sw-lm-ring.c b/hw/virtio/vhost-sw-lm-ring.c
> index
On Tue, 2020-12-08 at 07:55 +0100, Thomas Huth wrote:
> On 24/11/2020 10.45, Cho, Yu-Chen wrote:
> > v2:
> > Drop some package from dockerfile to make docker image more light.
> >
> > v1:
> > Add build-system-opensuse jobs and opensuse-leap.docker dockerfile.
> > Use openSUSE Leap 15.2 container
cpu-exec tries to execute TB without caching when current
icount budget is over. But sometimes refilled budget is big
enough to try executing cached blocks.
This patch checks that instruction budget is big enough
for next block execution instead of just running cpu_exec_nocache.
It halves the
On Fri, Nov 20, 2020 at 07:50:54PM +0100, Eugenio Pérez wrote:
> Specify VirtQueueElement * as return type makes no harm at this moment.
The reason for the void * return type is that C implicitly converts void
pointers to pointers of any type. The function takes a size_t sz
argument so it can
On Fri, Nov 20, 2020 at 07:50:56PM +0100, Eugenio Pérez wrote:
> @@ -83,6 +89,18 @@ void vhost_vring_set_notification_rcu(VhostShadowVirtqueue
> *vq, bool enable)
> smp_mb();
> }
>
> +bool vhost_vring_poll_rcu(VhostShadowVirtqueue *vq)
A name like "more_used" is clearer than "poll".
On Tue, 8 Dec 2020 15:30:04 +1100
David Gibson wrote:
> On Mon, Dec 07, 2020 at 02:37:04PM +0100, Greg Kurz wrote:
> > It is currently impossible to hot-unplug a memory device between
> > machine reset and CAS.
> >
> > (qemu) device_del dimm1
> > Error: Memory hot unplug not supported for this
On Tue, 8 Dec 2020 12:54:03 +1100
David Gibson wrote:
> > > >>> + * Virtio devices can't count on directly accessing guest
> > > >>> + * memory, so they need iommu_platform=on to use normal DMA
> > > >>> + * mechanisms. That requires also disabling legacy virtio
> > >
That is indeed the source and patches, but I wanted to follow their git
repo for easier maintenance. Surely they must have one.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1905979
Title:
Check
Hi
On Tue, Dec 8, 2020 at 10:57 AM Gerd Hoffmann wrote:
> On Fri, Dec 04, 2020 at 03:57:23PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Thu, Dec 3, 2020 at 3:12 PM Gerd Hoffmann wrote:
> >
> > > The vnc server should send desktop resize notifications unconditionally
> > > on a new
On Mon, Dec 07, 2020 at 12:38:49PM -0500, Eduardo Habkost wrote:
> On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote:
> > There's no generic way to query current accel and its properties via QOM
> > because there's no link between an accel and current machine.
> >
> > The change
Public bug reported:
I am using some third party GDB client, and I have noticed that every time "?"
command is send from the client, QEMU gdbstub removes all break points. This
behaviour is not expected since "?" command should only return stop reason.
Here is documentation from official gdb:
On Mon, 7 Dec 2020 at 22:48, Steven Price wrote:
>
> On 04/12/2020 08:25, Haibo Xu wrote:
> > On Fri, 20 Nov 2020 at 17:51, Steven Price wrote:
> >>
> >> On 19/11/2020 19:11, Marc Zyngier wrote:
> >>> On 2020-11-19 18:42, Andrew Jones wrote:
> On Thu, Nov 19, 2020 at 03:45:40PM +, Peter
Interesting. Thanks for the link.
The file system we are using is the Quobyte file system (2.24.1)
(https://www.quobyte.com/), which works via FUSE.
We've had problems with OFD locks with this file system in the past, so my
first thought, seeing the error in comment #1, was that those would be
The kernel version is Linux hostname 4.15.0-124-generic #127-Ubuntu SMP
Fri Nov 6 10:54:43 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1905979
Title:
On Mon, 7 Dec 2020 18:22:55 +0100
Paolo Bonzini wrote:
> Il lun 7 dic 2020, 17:57 Igor Mammedov ha scritto:
>
> > On Mon, 7 Dec 2020 17:43:16 +0100
> > Paolo Bonzini wrote:
> >
> > > On 07/12/20 17:24, Igor Mammedov wrote:
> > > >> +void qtest_server_init(const char *qtest_chrdev, const
On Fri, Nov 20, 2020 at 07:50:58PM +0100, Eugenio Pérez wrote:
> @@ -1028,6 +1061,7 @@ static int vhost_sw_live_migration_start(struct
> vhost_dev *dev)
>
> for (idx = 0; idx < dev->nvqs; ++idx) {
> struct vhost_virtqueue *vq = >vqs[idx];
> +unsigned num =
Since NVDIMM support was introduced on pseries machine,
it ignored machine's nvdimm=on|off option and effectively
was always enabled on machines that support NVDIMM.
Later on commit
(28f5a716212 ppc/spapr_nvdimm: do not enable support with 'nvdimm=off')
makes QEMU error out in case user
Le 08/12/2020 à 01:17, Matteo Croce a écrit :
> From: Matteo Croce
>
> Add a '-c' option which does a chroot() just before starting the
> emulation. This is useful when the static QEMU user binary can't
> be copied into the target root filesystem, e.g. if it's readonly.
Did you try to use the
On Fri, Nov 20, 2020 at 07:50:38PM +0100, Eugenio Pérez wrote:
> This series enable vDPA software assisted live migration for vhost-net
> devices. This is a new method of vhost devices migration: Instead of
> relay on vDPA device's dirty logging capability, SW assisted LM
> intercepts dataplane,
On Mon, 7 Dec 2020 23:32:55 -0300
Daniel Henrique Barboza wrote:
> On 12/7/20 1:07 PM, Igor Mammedov wrote:
> > On Wed, 2 Dec 2020 03:18:49 -0500
> > Paolo Bonzini wrote:
> >
> >> Machine options can be retrieved as properties of the machine object.
> >> Encourage that by removing the
On Mon, Dec 07, 2020 at 06:50:07PM +0100, Peter Krempa wrote:
> On Mon, Dec 07, 2020 at 12:38:49 -0500, Eduardo Habkost wrote:
> > On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote:
> > > There's no generic way to query current accel and its properties via QOM
> > > because there's
From: Klaus Jensen
Add support for TP 4065a ("Simple Copy Command"), v2020.05.04
("Ratified").
The implementation uses a bounce buffer to first read in the source
logical blocks, then issue a write of that bounce buffer. The default
maximum number of source logical blocks is 128, translating to
From: Klaus Jensen
Commit 37712e00b1f0 ("hw/block/nvme: factor out pmr setup") changed the
control flow such that the CAP register is erronously cleared after
nvme_init_pmr() has configured it. Since the entire NvmeCtrl structure
is zero-filled initially, there is no need for the explicit
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1905979
Title:
Check if F_OFD_SETLK is supported may give wrong result
Status in QEMU:
On 2020-12-08 09:51, Haibo Xu wrote:
On Mon, 7 Dec 2020 at 22:48, Steven Price wrote:
[...]
Sounds like you are making good progress - thanks for the update. Have
you thought about how the PROT_MTE mappings might work if QEMU itself
were to use MTE? My worry is that we end up with MTE in
On Tue, Dec 08, 2020 at 11:13:07 +0300, Roman Bolshakov wrote:
> On Mon, Dec 07, 2020 at 06:50:07PM +0100, Peter Krempa wrote:
> > On Mon, Dec 07, 2020 at 12:38:49 -0500, Eduardo Habkost wrote:
> > > On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote:
> > > > There's no generic way to
From: Klaus Jensen
Add support for TP 4065 ("Simple Copy Command").
Changes for v3
* rebased on nvme-next
* changed the default msrc value to a more reasonable 127 from 255 to
better align with the default mcl value of 128.
Changes for v2
* prefer style that aligns with existing
From: Klaus Jensen
Add new data structures and types for the Simple Copy command.
Signed-off-by: Klaus Jensen
Cc: Stefan Hajnoczi
Cc: Fam Zheng
Reviewed-by: Minwoo Im
Acked-by: Stefan Hajnoczi
---
include/block/nvme.h | 45 ++--
1 file changed, 43
On Fri, Nov 20, 2020 at 07:51:02PM +0100, Eugenio Pérez wrote:
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index eebfac4455..cb44b9997f 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -1109,6 +1109,10 @@ static int vhost_sw_live_migration_start(struct
> vhost_dev *dev)
On Tue, 8 Dec 2020 at 00:44, Dr. David Alan Gilbert wrote:
>
> * Steven Price (steven.pr...@arm.com) wrote:
> > On 07/12/2020 15:27, Peter Maydell wrote:
> > > On Mon, 7 Dec 2020 at 14:48, Steven Price wrote:
> > > > Sounds like you are making good progress - thanks for the update. Have
> > > >
Look in the same directory as that .deb link above - the the files
ending in orig.tar.gz (upstream source) and files ending in
debian.tar.xz (downstream modifications)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
On Nov 27 07:21, Minwoo Im wrote:
> Hello,
>
> On Fri, Nov 27, 2020 at 3:56 AM Klaus Jensen wrote:
> >
> > From: Gollu Appalanaidu
> >
> > Add the Compare command.
> >
> > This implementation uses a bounce buffer to read in the data from
> > storage and then compare with the host supplied
On Fri, Nov 20, 2020 at 07:50:51PM +0100, Eugenio Pérez wrote:
> -static inline bool vhost_vring_should_kick(VhostShadowVirtqueue *vq)
> +static bool vhost_vring_should_kick_rcu(VhostShadowVirtqueue *vq)
"vhost_vring_" is a confusing name. This is not related to
vhost_virtqueue or the
On 08/12/20 03:16, Daniel Henrique Barboza wrote:
2) find a way to make object_property_get_str() to return kvm_type =
NULL if the 'kvm_type' option is absent and keep spapr code
untouched. I don't have the knowledge to assess how hard this would
be.
3) I can change the pseries logic to add
On Tue, 8 Dec 2020 at 18:01, Marc Zyngier wrote:
>
> On 2020-12-08 09:51, Haibo Xu wrote:
> > On Mon, 7 Dec 2020 at 22:48, Steven Price wrote:
> >>
>
> [...]
>
> >> Sounds like you are making good progress - thanks for the update. Have
> >> you thought about how the PROT_MTE mappings might work
Move the check whenever a cursor exists into the vnc_cursor_define()
function so callers don't have to do it.
Suggested-by: Marc-André Lureau
Signed-off-by: Gerd Hoffmann
---
ui/vnc.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index
The AArch64 view of CLIDR_EL1 extends the ICB field to include also bit
32, as well as adding a Ttype field when FEAT_MTE is implemented.
Extend the clidr field to be able to hold this context.
Signed-off-by: Leif Lindholm
---
target/arm/cpu.h | 2 +-
1 file changed, 1 insertion(+), 1
SBSS -> SSBS
Signed-off-by: Leif Lindholm
---
target/arm/cpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index e5514c8286..6962ef05d6 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -1851,7 +1851,7 @@ FIELD(ID_AA64PFR0, RAS,
Add entries present in ARM DDI 0487F.c (August 2020).
Signed-off-by: Leif Lindholm
---
target/arm/cpu.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index 5e9e8061f7..2a12a5ce92 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@
Hotplug a virtio-net-ccw device, and then hotunplug it again.
Signed-off-by: Cornelia Huck
---
v2->v3:
- do the dmesg cleanout and waiting for messages properly [Thomas]
Wainer: I dropped your r-b, as there had been too many changes for
me to be comfortable with retaining it
---
On Tue, Dec 8, 2020 at 4:02 PM Gerd Hoffmann wrote:
> Unused and duplicate (there is dpy_get_ui_info).
>
> Signed-off-by: Gerd Hoffmann
>
:)
Reviewed-by: Marc-André Lureau
---
> include/ui/console.h | 1 -
> ui/console.c | 6 --
> 2 files changed, 7 deletions(-)
>
> diff --git
On Tue, 8 Dec 2020 13:57:28 +1100
David Gibson wrote:
> On Fri, Dec 04, 2020 at 02:12:29PM +0100, Cornelia Huck wrote:
> > On Fri, 4 Dec 2020 13:07:27 +
> > "Dr. David Alan Gilbert" wrote:
> >
> > > * Cornelia Huck (coh...@redhat.com) wrote:
> > > > On Fri, 4 Dec 2020 09:06:50 +0100
>
This patch addresses this issue:
When accessing a volume on an NFS filesystem without supporting the file lock,
tools, like qemu-img, will complain "Failed to lock byte 100".
In the original code, the qemu_has_ofd_lock will test the lock on the
"/dev/null" pseudo-file. Actually, the file.locking
On 12/8/20 1:23 PM, Leif Lindholm wrote:
> SBSS -> SSBS
For Speculative Store Bypassing State.
>
> Signed-off-by: Leif Lindholm
> ---
> target/arm/cpu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé
On Thu, Oct 22, 2020 at 05:29:16PM +0100, Fam Zheng wrote:
> On Tue, 2020-10-20 at 09:34 +0800, Zhenyu Ye wrote:
> > On 2020/10/19 21:25, Paolo Bonzini wrote:
> > > On 19/10/20 14:40, Zhenyu Ye wrote:
> > > > The kernel backtrace for io_submit in GUEST is:
> > > >
> > > > guest#
On 12/8/20 12:59 PM, Daniel P. Berrangé wrote:
> It is interesting to know if the PS2 keyboard is in translated mode, and
> which of the three scancode sets are in use.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> hw/input/ps2.c| 2 +-
> hw/input/trace-events | 2 +-
> 2 files changed,
On Tue, Dec 08, 2020 at 08:59:37PM +0800, Li Feng wrote:
> This patch addresses this issue:
> When accessing a volume on an NFS filesystem without supporting the file lock,
> tools, like qemu-img, will complain "Failed to lock byte 100".
>
> In the original code, the qemu_has_ofd_lock will test
spapr_kvm_type() is considering 'vm_type=NULL' as a valid input, where
the function returns 0. This is relying on the current QEMU machine
options handling logic, where the absence of the 'kvm-type' option
will be reflected as 'vm_type=NULL' in this function.
This is not robust, and will break if
Rémi Denis-Courmont writes:
> Hi,
>
> Le tiistaina 1. joulukuuta 2020, 20.23.46 EET Peter Maydell a écrit :
>> > The base tests fail without the patchset seem to assume an US American
>> > locale, which is frankly infuriatingly culturally insensitive.
>>
>> I run them with en_GB.UTF-8,
On 05/12/2020 15:09, Philippe Mathieu-Daudé wrote:
> Per the "NCR89C105 Chip Specification" referenced in the header:
>
>Chip-level Address Map
>
>--
>| 1D0 -> | Counter/Timers
On 12/7/20 4:35 PM, Willian Rampazzo wrote:
We could use something more pythonic for this file. Instead of 3
string concatenations, my suggestion is to go with string formatting,
like:
s = "%s, logfile=%s, drain_thread=%s>" % (s, self._logfile, self._drain_thread)
As str is immutable in
On Tue, 8 Dec 2020, Alexey Kardashevskiy wrote:
On 07/12/2020 22:48, BALATON Zoltan wrote:
diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
index 2e89e36cfbdc..048bf49592aa 100644
--- a/include/hw/ppc/spapr.h
+++ b/include/hw/ppc/spapr.h
@@ -175,6 +175,13 @@ struct SpaprMachineState
On Mon, 7 Dec 2020 19:40:36 +0100
Thomas Huth wrote:
> On 07/12/2020 17.34, Thomas Huth wrote:
> > On 07/12/2020 17.30, Cornelia Huck wrote:
> >> On Mon, 7 Dec 2020 15:28:47 +0100
> >> Thomas Huth wrote:
> >>
> >>> On 04/12/2020 13.14, Cornelia Huck wrote:
> Hotplug a virtio-net-ccw
On Wed, Dec 2, 2020 at 12:23 AM Jagannathan Raman
wrote:
> SyncSysMemMsg message format is defined. It is used to send
> file descriptors of the RAM regions to remote device.
> RAM on the remote device is configured with a set of file descriptors.
> Old RAM regions are deleted and new regions,
It is interesting to know if the PS2 keyboard is in translated mode, and
which of the three scancode sets are in use.
Signed-off-by: Daniel P. Berrangé
---
hw/input/ps2.c| 2 +-
hw/input/trace-events | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/input/ps2.c
On Tue, Dec 08, 2020 at 12:57:28PM +0100, Gerd Hoffmann wrote:
> The rfb standard keeps envolving. While the official spec is kind of
> frozen since a decade or so the community maintains an updated version
> of the spec at:
> https://github.com/rfbproto/rfbproto/
>
> This series adds
On 12/7/20 10:50 PM, Peter Maydell wrote:
> On Mon, 7 Dec 2020 at 21:26, Eduardo Habkost wrote:
>> My understanding is that there's no reason for ARM KVM to use
>> another approach, and that CPUClass.do_interrupt is not really
>> TCG-specific.
>>
>> Do we have any case where the
On 12/8/20 2:51 PM, Claudio Fontana wrote:
> On 12/8/20 2:27 PM, Philippe Mathieu-Daudé wrote:
>> On 12/7/20 10:50 PM, Peter Maydell wrote:
>>> On Mon, 7 Dec 2020 at 21:26, Eduardo Habkost wrote:
My understanding is that there's no reason for ARM KVM to use
another approach, and that
Use the bdrv_co_delete_file interface to delete the underlying
file if qcow2 initialization fails (e.g due to bad encryption secret)
This makes the qcow2 driver behave the same way as the luks driver behaves.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1845353
V3: addressed review
On 12/8/20 2:55 PM, Claudio Fontana wrote:
> On 12/8/20 2:51 PM, Claudio Fontana wrote:
>> On 12/8/20 2:27 PM, Philippe Mathieu-Daudé wrote:
>>> On 12/7/20 10:50 PM, Peter Maydell wrote:
On Mon, 7 Dec 2020 at 21:26, Eduardo Habkost wrote:
> My understanding is that there's no reason for
The range of 'cid' is [1, NVME_QUEUE_SIZE-1], so when 'cid' is equal to
NVME_QUEUE_SIZE, it should be continued, otherwise it will lead to array
index out of bounds when accessing 'q->reqs[cid-1]'
Reported-by: Euler Robot
Signed-off-by: Alex Chen
---
block/nvme.c | 2 +-
1 file changed, 1
I found some style problems while check the code using checkpatch.pl.
This commit fixs the issue below:
ERROR: that open brace { should be on the previous line
Signed-off-by: zhouyang (T)
---
contrib/plugins/howvec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
I found some style problems while check the code using checkpatch.pl.
This commit fixs the issue below:
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: zhouyang (T)
---
contrib/plugins/howvec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/plugins/howvec.c
Use active_console in that case like we do in many other places.
Signed-off-by: Gerd Hoffmann
---
ui/console.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/ui/console.c b/ui/console.c
index f995639e45f6..30e70be555db 100644
--- a/ui/console.c
+++
vnc stopped using the copyrect pseudo encoding in 2017, in commit
50628d3479e4 ("cirrus/vnc: zap bitblit support from console code.")
So we can drop the now unused copyrect feature bit.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Marc-André Lureau
---
ui/vnc.h | 2 --
ui/vnc.c | 3 ---
2 files
The vnc server should send desktop resize notifications unconditionally
on a new client connect, for feature negotiation reasons. Add a bool
flag to vnc_desktop_resize() to force sending the message even in case
there is no size change.
Signed-off-by: Gerd Hoffmann
---
ui/vnc.c | 9 +
On Tue, Dec 8, 2020 at 3:59 PM Gerd Hoffmann wrote:
> Use active_console in that case like we do in many other places.
>
> Signed-off-by: Gerd Hoffmann
>
Reviewed-by: Marc-André Lureau
---
> ui/console.c | 12 ++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git
On Tue, 8 Dec 2020 11:28:29 +0100
Halil Pasic wrote:
> On Tue, 8 Dec 2020 12:54:03 +1100
> David Gibson wrote:
>
> > > > >>> + * Virtio devices can't count on directly accessing guest
> > > > >>> + * memory, so they need iommu_platform=on to use normal DMA
> > > > >>> +
On 04.12.20 09:36, Janosch Frank wrote:
> There's no VSIE support for a protected guest, so let's better not
> advertise it and its support facilities.
>
> Signed-off-by: Janosch Frank
Looks sane. Assuming that all features that depend on SIE are named
S390_FEAT_SIE_*
this should take care
03.12.2020 20:23, Kevin Wolf wrote:
The only thing that happens after the 'out:' label is blk_unref(blk).
However, blk = NULL in all of the error cases, so instead of jumping to
'out:', we can just return directly.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Kevin Wolf
---
blockdev.c | 7
On Tue, Dec 08, 2020 at 05:51:34AM +0100, Laszlo Ersek wrote:
> Hi Vivek,
>
> On 12/07/20 19:30, Vivek Goyal wrote:
> > Laszlo is writing a virtiofs client for OVMF and noticed that if he
> > sends fuse FLUSH command for directory object, virtiofsd crashes.
> > virtiofsd does not expect a FLUSH
On Dec 08 12:17, Alex Bennée wrote:
> Aaron Lindsay writes:
>
> > I'm trying to migrate to using the new plugin interface. I see the
> > following in include/qemu/qemu-plugin.h:
> >
> >> enum qemu_plugin_cb_flags {
> >> QEMU_PLUGIN_CB_NO_REGS, /* callback does not access the CPU's regs */
>
A bug on KDE bug tracker:
https://bugs.kde.org/show_bug.cgi?id=430157
** Bug watch added: KDE Bug Tracking System #430157
https://bugs.kde.org/show_bug.cgi?id=430157
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
I found some style problems while check the code using checkpatch.pl.
This commit fixs the misuse of '#' flag of printf format
Signed-off-by: zhouyang (T)
---
contrib/plugins/hotblocks.c | 2 +-
contrib/plugins/hotpages.c | 2 +-
contrib/plugins/howvec.c| 2 +-
contrib/plugins/lockstep.c
The kernel KVM_CLEAR_DIRTY_LOG interface has align requirement on both the
start and the size of the given range of pages. We have been careful to
handle the unaligned cases when performing CLEAR on one slot. But it seems
that we forget to take the unaligned *size* case into account when
preparing
Use an enum for the vnc feature bits. That way they are enumerated
automatically and we don't have to do that manually when adding or
removing features.
Signed-off-by: Gerd Hoffmann
Reviewed-by: Marc-André Lureau
---
ui/vnc.h | 26 ++
1 file changed, 14 insertions(+),
Signed-off-by: Leif Lindholm
---
target/arm/cpu.h | 24
1 file changed, 24 insertions(+)
diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index b54d1dc092..5e9e8061f7 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -1713,6 +1713,30 @@ FIELD(V7M_FPCCR, ASPEN, 31,
First, fix a typo in ID_AA64PFR1 (SBSS -> SSBS).
Second, turn clidr in the ARMCPU struct 64-bit, to support all fields defined
by the ARM ARM.
Third, add field definitions for CLIDR (excepting the Ttype fields, since
I was unsure of prefererred naming - Ttype7-Ttype1?).
Fourth add all ID_AA64
When the qio_channel_socket_connect_sync() fails
we should goto 'out_socket' label to free the 'sioc' instead of
goto 'out' label.
In addition, there's a lot of redundant code in the successful branch
and the error branch, optimize it.
Reported-by: Euler Robot
Signed-off-by: Alex Chen
On Thu, Aug 27, 2020 at 03:29:11PM +0100, Stefan Hajnoczi wrote:
> This patch series improves format string compiler error messages. Instead of
> showing the generated file, show the trace-events file where the format string
> is defined.
>
> Stefan Hajnoczi (4):
> tracetool: add output
On 08.12.20 14:29, Christian Borntraeger wrote:
>
>
> On 04.12.20 09:36, Janosch Frank wrote:
>> There's no VSIE support for a protected guest, so let's better not
>> advertise it and its support facilities.
>>
>> Signed-off-by: Janosch Frank
>
> Looks sane. Assuming that all features that
On Wed, Dec 2, 2020 at 12:23 AM Jagannathan Raman
wrote:
> SyncSysMemMsg message format is defined. It is used to send
> file descriptors of the RAM regions to remote device.
> RAM on the remote device is configured with a set of file descriptors.
> Old RAM regions are deleted and new regions,
Add #defines for two new pseudo encodings:
* cursor with alpha channel.
* extended desktop resize.
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#pseudo-encodings
Signed-off-by: Gerd Hoffmann
Reviewed-by: Marc-André Lureau
---
ui/vnc.h | 2 ++
1 file changed, 2 insertions(+)
Patchew URL:
https://patchew.org/QEMU/20201208115934.3163238-1-berra...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201208115934.3163238-1-berra...@redhat.com
Subject: [PATCH] hw/input: expand trace
Hi
On Wed, Dec 2, 2020 at 12:23 AM Jagannathan Raman
wrote:
> From: Elena Ufimtseva
>
> Signed-off-by: Elena Ufimtseva
> Signed-off-by: Jagannathan Raman
> Signed-off-by: John G Johnson
> Reviewed-by: Stefan Hajnoczi
> ---
> include/hw/remote/mpqemu-link.h | 4
>
03.12.2020 16:58, Alex Chen wrote:
When the qio_channel_socket_connect_sync() fails
we should goto 'out_socket' label to free the 'sioc' instead of
goto 'out' label.
In addition, there's a lot of redundant code in the successful branch
and the error branch, optimize it.
Reported-by: Euler Robot
Hi
On Wed, Dec 2, 2020 at 12:23 AM Jagannathan Raman
wrote:
> Add memory-listener object which is used to keep the view of the RAM
> in sync between QEMU and remote process.
> A MemoryListener is registered for system-memory AddressSpace. The
> listener sends SYNC_SYSMEM message to the remote
When the underlying block device doesn't support the
bdrv_co_delete_file interface, an 'Error' object was leaked.
Signed-off-by: Maxim Levitsky
---
block/crypto.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/crypto.c b/block/crypto.c
index aef5a5721a..b3a5275132 100644
---
On Tue, Dec 08, 2020 at 12:57:34PM +0100, Gerd Hoffmann wrote:
> There is a new vnc extension for cursors with an alpha channel. Use
> it if supported by the vnc client, prefer it over the "rich cursor"
> extension which supports only a bitmask for transparency.
>
> This is a visible improvement
On Tue, Dec 08, 2020 at 12:57:29PM +0100, Gerd Hoffmann wrote:
> Unused and duplicate (there is dpy_get_ui_info).
>
> Signed-off-by: Gerd Hoffmann
> ---
> include/ui/console.h | 1 -
> ui/console.c | 6 --
> 2 files changed, 7 deletions(-)
Reviewed-by: Daniel P. Berrangé
1 - 100 of 453 matches
Mail list logo
