Re: [PATCH 06/12] vt82c686: Simplify vt82c686b_realize()

On 1/6/21 10:13 PM, BALATON Zoltan wrote: > Remove unneeded variables and setting value to 0 on zero initialised > data and replace check for error with error_fatal. Rationalise loop > that sets PCI config header fields read only. > > Signed-off-by: BALATON Zoltan > --- > hw/isa/vt82c686.c | 20

Re: [PATCH v2 03/24] target/mips/cpu: Introduce isa_rel6_available() helper

On 12/16/20 4:14 AM, Jiaxun Yang wrote: > 在 2020/12/16 上午10:50, Jiaxun Yang 写道: >> TBH I do think it doesn't sounds like a good idea to make 32-bit >> and 64-bit different. In fact ISA_MIPS32R6 is always set for targets >> with ISA_MIPS64R6. >> >> We're treating MIPS64R6 as a superset of MIPS32R6,

Re: [PATCH 3/3] sam460ex: Use type cast macro instead of simple cast

On Wed, 6 Jan 2021 16:24:01 +0100 BALATON Zoltan via wrote: > Use the PCI_BUS type cast macro to convert result of > qdev_get_child_bus(). Also remove the check for NULL afterwards which > should not be needed because sysbus_create_simple() uses error_abort It seems to me that

Re: [PATCH 5/5] i386: provide simple 'hyperv=on' option to x86 machine types

Igor Mammedov wrote: > my preferred approach is still -cpu hyperv=on, since it doesn't > depend on order CLI is currently parsed (which is fragile thing), > but rather on what user asked us to do with CPU. I think I'm OK with this solution for the time being. When non-CPU devices arrive and if

Re: [PATCH 02/12] vt82c686: Reorganise code

On 1/6/21 10:13 PM, BALATON Zoltan wrote: > Move lines around so that object definitions become consecutive and > not scattered around. This brings functions belonging to an object > together so it's clearer what is defined and what parts belong to > which object. > > Signed-off-by: BALATON

Re: [PATCH 05/12] vt82c686: Make vt82c686b-pm an abstract base class and add vt8231-pm based on it

Hi Zoltan, On 1/6/21 10:13 PM, BALATON Zoltan wrote: > The vt82c686b-pm model can be shared between VT82C686B and VT8231. The > only difference between the two is the device id in what we emulate so > make an abstract via-pm model by renaming appropriately and add types > for vt82c686b-pm and

Re: [PATCH] virtio-mmio: fix guest kernel crash with SHM regions

Hi, any comment? Thanks, Laurent Le 20/12/2020 à 17:35, Laurent Vivier a écrit : > In the kernel, virtio_gpu_init() uses virtio_get_shm_region() > since > commit 6076a9711dc5 ("drm/virtio: implement blob resources: probe for host > visible region") > but vm_get_shm_region() unconditionally

Re: [PULL v2 00/53] Misc patches for 2020-12-21

Paolo Bonzini writes: > I have already sent the v3, so you may want to wait a day or two. The good > thing of conversion patches is that if they break something you can just > drop them. :) I re-span with v4 which just has a few extra regression fixes on top of the ones in your v3. > > Paolo

[Bug 1910505] [NEW] atomic failure linking with --enable-sanitizers on 32-bit Linux hosts

Public bug reported: As of commit 50536341b47, using --enable-sanitizers on 32-bit Linux host: - displays various warnings - fails linking Using Ubuntu 18.04 (release 20201211.1) and Clang10 on i386: [139/675] Compiling C object softmmu.fa.p/softmmu_icount.c.o In file included from

Re: [Bug 1910505] [NEW] atomic failure linking with --enable-sanitizers on 32-bit Linux hosts

Cc'ing atomic team and qemu-block@ for "qemu/stats64.h". On 1/7/21 9:40 AM, Philippe Mathieu-Daudé wrote: > Public bug reported: > > As of commit 50536341b47, using --enable-sanitizers on 32-bit Linux host: > - displays various warnings > - fails linking > > Using Ubuntu 18.04 (release

[v2 PATCH] RISC-V: Place DTB at 3GB boundary instead of 4GB

Currently, we place the DTB at 2MB from 4GB or end of DRAM which ever is lesser. However, Linux kernel can address only 1GB of memory for RV32. Thus, it can not map anything beyond 3GB (assuming 2GB is the starting address). As a result, it can not process DT and panic if opensbi dynamic firmware

Re: [PATCH v3 0/5] SCSI: fix transfer limits for SCSI passthrough

On Thu, 2020-12-17 at 18:56 +0200, Maxim Levitsky wrote: > This patch series attempts to provide a solution to the problem of the > transfer > limits of the raw file driver (host_device/file-posix), some of which I > already tried to fix in the past. > > I included 2 patches from Tom Yan which

[PATCH v4 5/5] whpx: move whpx_lapic_state from header to c file

This struct only used in whpx-apic.c, there is no need expose it in whpx.h. Signed-off-by: Yonggang Luo --- include/sysemu/whpx.h| 7 --- target/i386/whpx/whpx-apic.c | 7 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/include/sysemu/whpx.h

Re: [PATCH v2 0/2] Quality of life patches for qemu coroutine debugging

On Thu, 2020-12-17 at 17:54 +0200, Maxim Levitsky wrote: > These are two patches that improve a bit the qemu gdb scripts in regard to > coroutines. > > First patch fixes a bug in 'qemu coroutine' in regard to usage on non topmost > stack frame. > > Second patch implements 'qemu bt' as Stefan

Re: [PATCH] virtio-mmio: fix guest kernel crash with SHM regions

Hi, > > According to the comments in the kernel, a non existent shared region > > has a length of (u64)-1. virtio spec says the same. > > + case VIRTIO_MMIO_SHM_LEN_LOW: > > + case VIRTIO_MMIO_SHM_LEN_HIGH: > > +/* > > + * VIRTIO_MMIO_SHM_SEL is unimplemented > > +

Re: [PATCH v4 5/5] whpx: move whpx_lapic_state from header to c file

On 07/01/21 11:28, Marc-André Lureau wrote: Hi On Thu, Jan 7, 2021 at 2:26 PM Yonggang Luo > wrote: This struct only used in whpx-apic.c, there is no need expose it in whpx.h. Signed-off-by: Yonggang Luo mailto:luoyongg...@gmail.com>> Similar patch

Re: [PATCH v4 3/5] maintainers: Add me as Windows Hosted Continuous Integration maintainer

On 1/7/21 11:19 AM, Yonggang Luo wrote: > Signed-off-by: Yonggang Luo > --- > MAINTAINERS | 6 ++ > 1 file changed, 6 insertions(+) Again: Reviewed-by: Philippe Mathieu-Daudé

[Bug 1908266] Re: spice unnecessary forces nographic

Try "qemu -display spice-app", then go to menu -> view -> displays in virt-viewer. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1908266 Title: spice unnecessary forces nographic Status in QEMU:

Re: [PATCH] meson: fix ncurses detection on macOS

On 28/12/20 16:16, Chris Hofstaedtler wrote: Without this, meson fails with "curses package not usable" when using ncurses 6.2. Apparently the wide functions (addwstr, etc) are hidden behind the extra define, and meson does not define it at that detection stage. Signed-off-by: Chris

Re: [PULL v4 0/4] more testing fixes (all green now)

On Wed, 6 Jan 2021 at 20:26, Alex Bennée wrote: > > The following changes since commit aadac5b3d9fdce28030495f80fc76a4336e97328: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2021-01-06 15:55:29 +) > > are available in the Git repository at: >

[PATCH v4 2/5] cirrus/msys2: Cache msys2 mingw in a better way.

Signed-off-by: Yonggang Luo --- .cirrus.yml | 117 ++-- 1 file changed, 68 insertions(+), 49 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index 68b8a8fa9c..bc40a0550d 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -64,23 +64,61 @@

[PATCH v4 3/5] maintainers: Add me as Windows Hosted Continuous Integration maintainer

Signed-off-by: Yonggang Luo --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4be087b88e..4d9df874a1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3198,6 +3198,12 @@ S: Maintained F: .cirrus.yml W: https://cirrus-ci.com/github/qemu/qemu

[PATCH v4 0/5] Misc meson fixes along test-vmstate fixes

V1-V2 Fixes whpx: Fixes include of whp-dispatch.h in whpx.h by the suggestion of Philippe Mathieu-Daudé Add new patch whpx: move whpx_lapic_state from header to c file The test-vmstate can be passed under win32 too so enable it on win32, This is based on Bonzini's upstream tag along Yonggang

Re: [PATCH v4 5/5] whpx: move whpx_lapic_state from header to c file

Hi On Thu, Jan 7, 2021 at 2:26 PM Yonggang Luo wrote: > This struct only used in whpx-apic.c, there is no need > expose it in whpx.h. > > Signed-off-by: Yonggang Luo > Similar patch pending:

Re: [PATCH 05/12] vt82c686: Make vt82c686b-pm an abstract base class and add vt8231-pm based on it

On Thu, 7 Jan 2021, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 1/6/21 10:13 PM, BALATON Zoltan wrote: The vt82c686b-pm model can be shared between VT82C686B and VT8231. The only difference between the two is the device id in what we emulate so make an abstract via-pm model by renaming

Re: [PATCH 05/12] vt82c686: Make vt82c686b-pm an abstract base class and add vt8231-pm based on it

On Thu, 7 Jan 2021 11:38:21 +0100 (CET) BALATON Zoltan wrote: > On Thu, 7 Jan 2021, Philippe Mathieu-Daudé wrote: > > Hi Zoltan, > > > > On 1/6/21 10:13 PM, BALATON Zoltan wrote: > >> The vt82c686b-pm model can be shared between VT82C686B and VT8231. The > >> only difference between the two is

Re: [PATCH 3/3] sam460ex: Use type cast macro instead of simple cast

On Thu, 7 Jan 2021 10:45:26 +0100 BALATON Zoltan wrote: > On Thu, 7 Jan 2021, Greg Kurz wrote: > > On Wed, 6 Jan 2021 16:24:01 +0100 > > BALATON Zoltan via wrote: > > > >> Use the PCI_BUS type cast macro to convert result of > >> qdev_get_child_bus(). Also remove the check for NULL afterwards

Re: [PATCH 2/2] whpx: move internal definitions to whpx-internal.h

On 12/19/20 10:06 AM, Paolo Bonzini wrote: > Only leave the external interface in sysemu/whpx.h. whpx_apic_in_platform > is moved to a .c file because it needs whpx_state. > > Reported-by: Marc-André Lureau > Signed-off-by: Paolo Bonzini > --- > include/sysemu/whpx.h| 22

Re: [PATCH v4 1/5] cirrus/msys2: Exit powershell with $LastExitCode

On 1/7/21 11:19 AM, Yonggang Luo wrote: > Currently if we don't exit with $LastExitCode manually, > the cirrus would not report the build/testing failure. > > Signed-off-by: Yonggang Luo Please keep tag from reviewers when sending new versions. Reviewed-by: Philippe Mathieu-Daudé > --- >

[PATCH v4 3/8] acpi: Add addr offset in build_crs

AML needs Address Translation offset to describe how a bridge translates addresses accross the bridge when using an address descriptor, and especially on ARM, the translation offset of pio resource is usually non zero. Therefore, it's necessary to pass offset for pio, mmio32, mmio64 and bus

[PATCH v4 4/8] acpi/gpex: Inform os to keep firmware resource map

There may be some differences in pci resource assignment between guest os and firmware. Eg. A Bridge with Bus [d2] -+-[:d2]---01.0-[d3]01.0 where [d2:01.00] is a pcie-pci-bridge with BAR0 (mem, 64-bit, non-pref) [size=256] [d3:01.00] is a PCI Device with BAR0 (mem,

[PATCH v4 7/8] acpi: Enable pxb unit-test for ARM virt machine

No matter whether the pxb is enabled or not, the CONFIG_PXB macro in test would keep undefined. And since pxb is now enabled for ARM Virt machine by default, let's enable pxb unit-test by removing the CONFIG_PXB. Signed-off-by: Jiahui Cen --- tests/qtest/bios-tables-test.c | 4 1 file

Re: [PATCH v1 0/1] intc/arm_gic: Fix gic_irq_signaling_enabled() for vCPUs

On Mon, 14 Dec 2020 at 22:21, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Hi, > > Found this while debugging an issue with lockups during boot of > Linux on Xen. > > In the particular setup, I'm running without EL3 firmware so group0 > interrupts are disabled on the physical

Re: [PATCH 02/12] vt82c686: Reorganise code

On Thu, 7 Jan 2021, Philippe Mathieu-Daudé wrote: On 1/6/21 10:13 PM, BALATON Zoltan wrote: Move lines around so that object definitions become consecutive and not scattered around. This brings functions belonging to an object together so it's clearer what is defined and what parts belong to

Re: [Bug 1873769] Re: SB16 audio playback freezes emulation in Windows 95 guest

On Wed, 2021-01-06 at 15:50 +, Vladislav K. Valtchev wrote: > P.S.: sorry for the terribly broken lines. I didn't expect launchpad to > add additional line breaks that way :-( > FYI, since I am into retro gaming with kvm on win98, I ended up using -device AC97 with old realtek_3_41 win95 (I

Re: [Bug 1910505] [NEW] atomic failure linking with --enable-sanitizers on 32-bit Linux hosts

On 07/01/21 10:10, Philippe Mathieu-Daudé wrote: libblock.fa(block_io.c.o): In function `stat64_max': include/qemu/stats64.h:58: undefined reference to `__atomic_load_8' include/qemu/stats64.h:60: undefined reference to `__atomic_compare_exchange_8' libblock.fa(block_qapi.c.o): In function

Re: [PATCH 0/3] RFC: few random hacks to improve eventfd fallback path

On Thu, 2020-12-17 at 17:00 +0200, Maxim Levitsky wrote: > These few patches are the result of a random hacking I did to make the qemu > cope with eventfd allocation failure, when using an iothread, > as it happened in bz #1897550. > > I am not 100% sure which patches in this series are worth to

Re: [PATCH v6 0/3] qcow2: don't leave partially initialized file on image creation

On Thu, 2020-12-17 at 19:09 +0200, Maxim Levitsky wrote: > Use the bdrv_co_delete_file interface to delete the underlying > file if qcow2 initialization fails (e.g due to bad encryption secret) > > This makes the qcow2 driver behave the same way as the luks driver behaves. > > Buglink:

Re: [PATCH v4 0/5] Misc meson fixes along test-vmstate fixes

Patchew URL: https://patchew.org/QEMU/20210107101919.80-1-luoyongg...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210107101919.80-1-luoyongg...@gmail.com Subject: [PATCH v4 0/5] Misc meson fixes along

Re: [PATCH v4 0/5] Misc meson fixes along test-vmstate fixes

On 07/01/21 11:19, Yonggang Luo wrote: V1-V2 Fixes whpx: Fixes include of whp-dispatch.h in whpx.h by the suggestion of Philippe Mathieu-Daudé Add new patch whpx: move whpx_lapic_state from header to c file The test-vmstate can be passed under win32 too so enable it on win32, This is based

Re: [PATCH v2] meson: fix Cocoa option in summary

On 30/12/20 23:16, Chris Hofstaedtler wrote: Cocoa support was always shown as "no", even it if was enabled. Fixes: b4e312e953b ("configure: move cocoa option to Meson") Cc: Paolo Bonzini Cc: Peter Maydell Cc: Philippe Mathieu-Daudé Signed-off-by: Chris Hofstaedtler --- meson.build | 2 +-

Re: [PATCH v2] meson: fix Cocoa option in summary

On 30/12/20 23:16, Chris Hofstaedtler wrote: Cocoa support was always shown as "no", even it if was enabled. Fixes: b4e312e953b ("configure: move cocoa option to Meson") Cc: Paolo Bonzini Cc: Peter Maydell Cc: Philippe Mathieu-Daudé Signed-off-by: Chris Hofstaedtler --- meson.build | 2 +-

[PATCH v4 6/8] Kconfig: Compile PXB for ARM_VIRT

PXB is now supported on ARM, so let's compile for arm_virt machine. Signed-off-by: Jiahui Cen --- hw/pci-bridge/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-bridge/Kconfig b/hw/pci-bridge/Kconfig index a51ec716f5..f8df4315ba 100644 ---

[PATCH v4 2/8] acpi: Fix unmatched expected DSDT.pxb file

Commit fe1127da11 ("unit-test: Add the binary file and clear diff.h") does not use the up-to-date expected file for pxb for ARM virt. Fix the expected DSDT.pxb file. Full diff of changed file disassembly: diff -ru /tmp/old/tests/data/acpi/virt/DSDT.pxb.dsl

[PATCH v4 0/8] acpi: Some fixes for pxb support for ARM virt machine

This patch series adds some fixes for ARM virt machine pxb support. 1. Pass addr offset for IO, MMIO and bus number when builing crs, because the addr_trans is needed to describe an addr resource. [1] 2. Inform guest os not to ignore the resource map generated by firmware as the x86 default way.

[PATCH v4 1/8] acpi: Allow DSDT acpi table changes

Signed-off-by: Jiahui Cen --- tests/qtest/bios-tables-test-allowed-diff.h | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..42418e58e7 100644 ---

[PATCH v4 5/8] acpi/gpex: Exclude pxb's resources from PCI0

Exclude the resources of extra root bridges from PCI0's _CRS. Otherwise, the resource windows would overlap in guest, and the IO resource window would fail to be registered. Signed-off-by: Jiahui Cen --- hw/pci-host/gpex-acpi.c | 64 +--- 1 file changed, 43 insertions(+), 21

Re: [PATCH] tests/docker: Remove Debian 9 remnant lines

Philippe Mathieu-Daudé writes: > Debian 9 base container has been removed in commits > e3755276d1f and c9d78b06c06. Remove the last remnants. > > Fixes: e3755276d1f ("tests/docker: Remove old Debian 9 containers") > Signed-off-by: Philippe Mathieu-Daudé Queued to testing/next, thanks. > ---

Re: [PATCH 4/4] block: introduce BDRV_MAX_LENGTH

On Fri, Dec 04, 2020 at 01:27:13AM +0300, Vladimir Sementsov-Ogievskiy wrote: > Finally to be safe with calculations, to not calculate different > maximums for different nodes (depending on cluster size and > request_alignment), let's simply set QEMU_ALIGN_DOWN(INT64_MAX, 2^30) > as absolute

Re: [PATCH v4 5/5] whpx: move whpx_lapic_state from header to c file

On Thu, Jan 7, 2021 at 2:55 AM Paolo Bonzini wrote: > > On 07/01/21 11:28, Marc-André Lureau wrote: > > Hi > > > > On Thu, Jan 7, 2021 at 2:26 PM Yonggang Luo > > wrote: > > > > This struct only used in whpx-apic.c, there is no need > > expose it in whpx.h.

Re: [PATCH v4 4/5] whpx: Fixes include of whp-dispatch.h in whpx.h

On 1/7/21 11:19 AM, Yonggang Luo wrote: > Signed-off-by: Yonggang Luo > --- > include/sysemu/whpx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] tests/docker: Remove Debian 9 remnant lines

On 07/01/2021 08.29, Philippe Mathieu-Daudé wrote: Debian 9 base container has been removed in commits e3755276d1f and c9d78b06c06. Remove the last remnants. Fixes: e3755276d1f ("tests/docker: Remove old Debian 9 containers") Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH 3/3] sam460ex: Use type cast macro instead of simple cast

On Thu, 7 Jan 2021, Greg Kurz wrote: On Wed, 6 Jan 2021 16:24:01 +0100 BALATON Zoltan via wrote: Use the PCI_BUS type cast macro to convert result of qdev_get_child_bus(). Also remove the check for NULL afterwards which should not be needed because sysbus_create_simple() uses error_abort It

[PATCH v4 4/5] whpx: Fixes include of whp-dispatch.h in whpx.h

Signed-off-by: Yonggang Luo --- include/sysemu/whpx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sysemu/whpx.h b/include/sysemu/whpx.h index 9346fd92e9..4f38784d7e 100644 --- a/include/sysemu/whpx.h +++ b/include/sysemu/whpx.h @@ -15,7 +15,7 @@ #ifdef

[PATCH v4 1/5] cirrus/msys2: Exit powershell with $LastExitCode

Currently if we don't exit with $LastExitCode manually, the cirrus would not report the build/testing failure. Signed-off-by: Yonggang Luo --- .cirrus.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.cirrus.yml b/.cirrus.yml index 3907e036da..68b8a8fa9c 100644 --- a/.cirrus.yml +++

Re: [PATCH v4 4/5] whpx: Fixes include of whp-dispatch.h in whpx.h

Hi On Thu, Jan 7, 2021 at 2:23 PM Yonggang Luo wrote: > Signed-off-by: Yonggang Luo > --- > include/sysemu/whpx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/sysemu/whpx.h b/include/sysemu/whpx.h > index 9346fd92e9..4f38784d7e 100644 > ---

Re: [PATCH 4/4] block: introduce BDRV_MAX_LENGTH

On Thu, Jan 07, 2021 at 09:58:17AM +, Richard W.M. Jones wrote: > On Fri, Dec 04, 2020 at 01:27:13AM +0300, Vladimir Sementsov-Ogievskiy wrote: > > Finally to be safe with calculations, to not calculate different > > maximums for different nodes (depending on cluster size and > >

Re: [PATCH v4 0/5] Misc meson fixes along test-vmstate fixes

On 07/01/21 11:19, Yonggang Luo wrote: V1-V2 Fixes whpx: Fixes include of whp-dispatch.h in whpx.h by the suggestion of Philippe Mathieu-Daudé Add new patch whpx: move whpx_lapic_state from header to c file The test-vmstate can be passed under win32 too so enable it on win32, This is based

Re: [PATCH] meson: Propagate gnutls dependency

On 05/01/21 15:37, Roman Bolshakov wrote: Does it work if you do: crypto_ss.add(authz, qom) libcrypto = static_library('crypto', crypto_ss.sources() + genh, dependencies: crypto_ss.dependencies(), ...) crypto =

[PATCH v4 8/8] acpi: Update _DSM method in expected files

A new _DSM #5 method is added. Update expected DSDT files accordingly, and re-enable their testing. Full diff of changed files disassembly: diff -ru /tmp/old/tests/data/acpi/microvm/DSDT.pcie.dsl /tmp/new/tests/data/acpi/microvm/DSDT.pcie.dsl --- /tmp/old/tests/data/acpi/microvm/DSDT.pcie.dsl

Re: [PATCH] hw/arm/virt: Remove virt machine state 'smp_cpus'

On Wed, 16 Dec 2020 at 06:44, Andrew Jones wrote: > > On Tue, Dec 15, 2020 at 06:20:48PM +, David Edmondson wrote: > > On Tuesday, 2020-12-15 at 18:48:15 +01, Andrew Jones wrote: > > > > > virt machine's 'smp_cpus' and machine->smp.cpus must always have the > > > same value. And, anywhere we

Re: [PATCH 4/4] block: introduce BDRV_MAX_LENGTH

On Thu, Jan 07, 2021 at 10:56:12AM +, Richard W.M. Jones wrote: > On Thu, Jan 07, 2021 at 09:58:17AM +, Richard W.M. Jones wrote: > > On Fri, Dec 04, 2020 at 01:27:13AM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > Finally to be safe with calculations, to not calculate different >

Re: [PATCH v3 2/5] file-posix: add sg_get_max_segments that actually works with sg

On 17.12.20 17:56, Maxim Levitsky wrote: From: Tom Yan sg devices have different major/minor than their corresponding block devices. Using sysfs to get max segments never really worked for them. Fortunately the sg driver provides an ioctl to get sg_tablesize, which is apparently equivalent to

Re: [PATCH v2 03/24] target/mips/cpu: Introduce isa_rel6_available() helper

On 1/7/21 10:04 AM, Philippe Mathieu-Daudé wrote: > On 12/16/20 4:14 AM, Jiaxun Yang wrote: >> 在 2020/12/16 上午10:50, Jiaxun Yang 写道: >>> TBH I do think it doesn't sounds like a good idea to make 32-bit >>> and 64-bit different. In fact ISA_MIPS32R6 is always set for targets >>> with ISA_MIPS64R6.

[PATCH v4 00/11] virtio-mem: vfio support

A virtio-mem device manages a memory region in guest physical address space, represented as a single (currently large) memory region in QEMU, mapped into system memory address space. Before the guest is allowed to use memory blocks, it must coordinate with the hypervisor (plug blocks). After a

[PATCH v4 10/11] virtio-mem: Require only coordinated discards

We implement the RamDiscardMgr interface and only require coordinated discarding of RAM to work. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Pankaj Gupta Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc:

[PATCH v4 09/11] softmmu/physmem: Extend ram_block_discard_(require|disable) by two discard types

We want to separate the two cases whereby we discard ram - uncoordinated: e.g., virito-balloon - coordinated: e.g., virtio-mem coordinated via the RamDiscardMgr Reviewed-by: Pankaj Gupta Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor

[PATCH v4 11/11] vfio: Disable only uncoordinated discards

We support coordinated discarding of RAM using the RamDiscardMgr. Let's unlock support for coordinated discards, keeping uncoordinated discards (e.g., via virtio-balloon) disabled. This unlocks virtio-mem + vfio. Note that vfio used via "nvme://" by the block layer has to be implemented/unlocked

[RFC PATCH v2 0/8] Automatically convert configure options to meson build options

This is v2 of a concept that was first posted last September. In the meanwhile more options have been added to Meson, so the effect of the change can hopefully be evaluated more accurately. At least, the amount of lines removed in the configure script is larger than the size of the script

[PATCH 8/8] configure: automatically parse command line for meson -D options

Right now meson_options.txt lists almost 60 options. Each option needs code in configure to parse it and pass the option down to Meson as a -D command-line argument; in addition the default must be duplicated between configure and meson_options.txt. This series tries to remove the code

[PATCH] vnc: add qmp to support change authz

This patch add a new qmp 'change-vnc-authz' to support change the tls/sasl authz of vm. If index='', unset tlsauthzid/sasl.authzid { "execute":"change-vnc-authz", "arguments":{ "index":"object-authz-id", "type":"tls/sasl" } } Signed-off-by: Zihao Chang ---

Re: [PATCH v3 04/10] vfio: Query and store the maximum number of DMA mappings

On 17.12.20 20:47, Alex Williamson wrote: > On Thu, 17 Dec 2020 20:04:28 +0100 > David Hildenbrand wrote: > >> On 17.12.20 18:55, Alex Williamson wrote: >>> On Wed, 16 Dec 2020 15:11:54 +0100 >>> David Hildenbrand wrote: >>> Let's query the maximum number of DMA mappings by querying the

Re: [PATCH v3 3/5] block: add max_ioctl_transfer to BlockLimits

On 17.12.20 17:56, Maxim Levitsky wrote: Maximum transfer size when accessing a kernel block device is only relevant when using SCSI passthrough (SG_IO ioctl) since only in this case the requests are passed directly to underlying hardware with no pre-processing. So by “with no pre-processing”

[PATCH v4 06/11] vfio: Sanity check maximum number of DMA mappings with RamDiscardMgr

Although RamDiscardMgr can handle running into the maximum number of DMA mappings by propagating errors when creating a DMA mapping, we want to sanity check and warn the user early that there is a theoretical setup issue and that virtio-mem might not be able to provide as much memory towards a VM

[PATCH v4 08/11] softmmu/physmem: Don't use atomic operations in ram_block_discard_(disable|require)

We have users in migration context that don't hold the BQL (when finishing migration). To prepare for further changes, use a dedicated mutex instead of atomic operations. Keep using qatomic_read ("READ_ONCE") for the functions that only extract the current state (e.g., used by virtio-balloon),

Re: [PATCH v3 5/5] block/scsi: correctly emulate the VPD block limits page

On 17.12.20 17:56, Maxim Levitsky wrote: When the device doesn't support the VPD block limits page, we emulate it even for SCSI passthrough. As a part of the emulation we need to add it to the 'Supported VPD Pages' The code that does this adds it to the page, but it doesn't increase the length

[PATCH 5/8] configure: move GTK+ detection to Meson

This also allows removing CONFIG_NEED_X11, all the ingredients can be computed easily in meson.build. Signed-off-by: Paolo Bonzini --- configure | 55 ++- meson.build | 29 ++--- meson_options.txt | 2 ++

[PATCH 2/8] cocoa: do not enable coreaudio automatically

Remove the automagic connection between --enable-cocoa and enabling coreaudio in audio_drv_list. It can be overridden anyway just by placing --enable-cocoa before --audio-drv-list. Signed-off-by: Paolo Bonzini --- configure | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [PATCH] cirrus: don't run full qtest on macOS

On 06/01/2021 13:36, Daniel P. Berrangé wrote: The Cirrus CI macOS build hosts have exhibited a serious performance degradation in recent months. For example the "qom-test" qtest takes over an hour for only the qemu-system-aarch64 binary. This is as much 20-40 times slower than other

Re: [PATCH V1] gdbstub: suspended state support

Steve Sistare writes: > Modify the gdb server so a continue command appears to resume execution > when in RUN_STATE_SUSPENDED. Do not print the next gdb prompt, but do not > actually resume instruction fetch. While in this "fake" running mode, a > ctrl-C returns the user to the gdb prompt.

[Bug 1910540] [NEW] where the trace file "trace-*"

Public bug reported: I compile qemu-system-aarch64 with --enable-trace-backends=simple option, then start qemu with -trace nvme* , qemu start successful but I cann't find the trace file "trace-*" at qemu started directory. ** Affects: qemu Importance: Undecided Status: New --

Re: [PATCH v3 4/5] block: use blk_get_max_ioctl_transfer for SCSI passthrough

On 17.12.20 17:56, Maxim Levitsky wrote: Switch file-posix to expose only the max_ioctl_transfer limit. Let the iscsi driver work as it did before since it is bound by the transfer limit in both regular read/write and in SCSI passthrough case. Switch the scsi-disk and scsi-block drivers to

[PATCH v4 01/11] memory: Introduce RamDiscardMgr for RAM memory regions

We have some special RAM memory regions (managed by virtio-mem), whereby the guest agreed to only use selected memory ranges. "unused" parts are discarded so they won't consume memory - to logically unplug these memory ranges. Before the VM is allowed to use such logically unplugged memory again,

[PATCH v4 02/11] virtio-mem: Factor out traversing unplugged ranges

Let's factor out the core logic, to be reused soon. Reviewed-by: Pankaj Gupta Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Alex Williamson Cc: Dr. David Alan Gilbert Cc: Igor Mammedov Cc: Pankaj Gupta Cc: Peter Xu Cc: Auger Eric Cc: Wei Yang Cc: teawater Cc: Marek Kedzierski

[PATCH v4 04/11] vfio: Support for RamDiscardMgr in the !vIOMMU case

Implement support for RamDiscardMgr, to prepare for virtio-mem support. Instead of mapping the whole memory section, we only map "populated" parts and update the mapping when notified about discarding/population of memory via the RamDiscardListener. Similarly, when syncing the dirty bitmaps, sync

Re: [PULL 50/55] virtfs: convert to meson

On Mon, 2020-12-21 at 15:44 +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- >  configure | 29 - >  meson.build   | 24 ++-- >  meson_options.txt | 11 +++ >  3 files changed, 33 insertions(+), 31 deletions(-) > >

[PATCH 1/8] build-system: clean up TCG/TCI configury

Make CONFIG_TCG_INTERPRETER a Meson option, and enable TCI (though with a warning) if the host CPU is unsupported, making it more similar to other --enable-* options. Remove TCG-specific include paths from !CONFIG_TCG builds. Signed-off-by: Paolo Bonzini --- configure | 11 +++

[PATCH 7/8] configure: quote command line arguments in config.status

Make config.status generation a bit more robust. (The quote_sh function will also be reused to parse configure's command line arguments in an external script driven by Meson build option introspection). Signed-off-by: Paolo Bonzini --- configure | 6 +- 1 file changed, 5 insertions(+), 1

[PATCH 4/8] configure: move X11 detection to Meson

For now move the logic verbatim. GTK+ actually has a hard requirement on X11 if gtk+x11 is present, but we will sort that out later. Signed-off-by: Paolo Bonzini --- configure | 14 ++ meson.build| 9 + ui/meson.build | 4 ++-- 3 files changed, 9 insertions(+),

Re: [PATCH v3 1/5] file-posix: split hdev_refresh_limits from raw_refresh_limits

On 17.12.20 17:56, Maxim Levitsky wrote: From: Tom Yan We can and should get max transfer length and max segments for all host devices / cdroms (on Linux). Also use MIN_NON_ZERO instead when we clamp max transfer length against max segments. Signed-off-by: Tom Yan Signed-off-by: Maxim

Re: [PATCH 1/2] file-posix: allow -EBUSY errors during write zeros on raw block devices

On Mon, 2020-11-16 at 15:48 +0100, Kevin Wolf wrote: > Am 11.11.2020 um 16:39 hat Maxim Levitsky geschrieben: > > On Linux, fallocate(fd, FALLOC_FL_PUNCH_HOLE) when it is used on a block > > device, > > without O_DIRECT can return -EBUSY if it races with another write to the > > same page. > >

[PATCH v4 05/11] vfio: Query and store the maximum number of possible DMA mappings

Let's query the maximum number of possible DMA mappings by querying the available mappings when creating the container (before any mappings are created). We'll use this informaton soon to perform some sanity checks and warn the user. Cc: Paolo Bonzini Cc: "Michael S. Tsirkin" Cc: Alex

[PATCH v4 07/11] vfio: Support for RamDiscardMgr in the vIOMMU case

vIOMMU support works already with RamDiscardMgr as long as guests only map populated memory. Both, populated and discarded memory is mapped into _space_memory, where vfio_get_xlat_addr() will find that memory, to create the vfio mapping. Sane guests will never map discarded memory (e.g.,

[PATCH v4 03/11] virtio-mem: Implement RamDiscardMgr interface

Let's properly notify when (un)plugging blocks, after discarding memory and before allowing the guest to consume memory. Handle errors from notifiers gracefully (e.g., no remaining VFIO mappings) when plugging, rolling back the change and telling the guest that the VM is busy. One special case to

[PATCH 3/8] gtk: remove CONFIG_GTK_GL

CONFIG_GTK_GL is defined if OpenGL is present and GTK+ is 3.16 or newer. Since GTK+ 3.22 is the minimum supported version, just use CONFIG_OPENGL instead. Cc: Gerd Hoffmann Signed-off-by: Paolo Bonzini --- configure | 7 --- meson.build| 1 - ui/gtk.c | 16

[PATCH 6/8] configure: move Cocoa incompatibility checks to Meson

The cocoa UI code currently assumes it is always the active UI and does not interact well with other UI frontend code. Move the relevant checks to Meson now that all other frontends have become Meson options. This way, SDL/GTK+/Cocoa can be parsed entirely by

Re: [PATCH v3 1/3] update-linux-headers: Include const.h

On Thu, Jan 07, 2021 at 12:50:34PM -0500, Eric Farman wrote: > > > On 1/7/21 12:05 PM, Peter Maydell wrote: > > On Thu, 7 Jan 2021 at 16:52, Eric Farman wrote: > > > On 1/6/21 2:03 PM, Peter Xu wrote: > > > > Could I ask why the const.h is installed into > > > > include/standard-headers/linux

What's the correct way to implement rfi and related instruction.

This is the first patch,: It's store MSR bits differntly for different rfi instructions: [Qemu-devel] [PATCH] target-ppc: fix RFI by clearing some bits of MSR https://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02999.html Comes from target-ppc: fix RFI by clearing some bits of MSR SHA-1:

Re: [PATCH 05/12] vt82c686: Make vt82c686b-pm an abstract base class and add vt8231-pm based on it

On Thu, 7 Jan 2021, Igor Mammedov wrote: On Thu, 7 Jan 2021 11:38:21 +0100 (CET) BALATON Zoltan wrote: On Thu, 7 Jan 2021, Philippe Mathieu-Daudé wrote: Hi Zoltan, On 1/6/21 10:13 PM, BALATON Zoltan wrote: The vt82c686b-pm model can be shared between VT82C686B and VT8231. The only

Re: [PATCH v2 02/24] target/arm: Add ALIGN_MEM to TBFLAG_ANY

On 1/7/21 5:42 AM, Peter Maydell wrote: >> +/* Memory operations require alignment: SCTLR_ELx.A or CCR.UNALIGN_TRP */ >> +FIELD(TBFLAG_ANY, ALIGN_MEM, 19, 1) > > This is trying to use the same bit as TBFLAG_A64 MTE0_ACTIVE... > We might have to finally start in on using bits in cs_base. Oops.

  1   2   3   4   5   >