[PATCH v6 09/23] tcg/optimize: Improve find_better_copy

2021-01-11 Thread Richard Henderson
Prefer TEMP_CONST over anything else. Signed-off-by: Richard Henderson --- tcg/optimize.c | 27 --- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 16b0aa7229..e42f9c89a8 100644 --- a/tcg/optimize.c +++

[PATCH v6 07/23] tcg: Expand TempOptInfo to 64-bits

2021-01-11 Thread Richard Henderson
This propagates the extended value of TCGTemp.val that we did before. In addition, it will be required for vector constants. Signed-off-by: Richard Henderson --- tcg/optimize.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git

[PATCH v6 04/23] tcg: Add temp_readonly

2021-01-11 Thread Richard Henderson
In most, but not all, places that we check for TEMP_FIXED, we are really testing that we do not modify the temporary. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 5 + tcg/tcg.c | 21 ++--- 2

[PATCH v6 06/23] tcg: Rename struct tcg_temp_info to TempOptInfo

2021-01-11 Thread Richard Henderson
Fix this name vs our coding style. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/optimize.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index

[PATCH v6 03/23] tcg: Consolidate 3 bits into enum TCGTempKind

2021-01-11 Thread Richard Henderson
The temp_fixed, temp_global, temp_local bits are all related. Combine them into a single enumeration. Reviewed-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- include/tcg/tcg.h | 20 +--- tcg/optimize.c| 8 +-- tcg/tcg.c | 126

[PATCH v6 01/23] tcg: Use tcg_out_dupi_vec from temp_load

2021-01-11 Thread Richard Henderson
Having dupi pass though movi is confusing and arguably wrong. Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- Cc: Wataru Ashihara Cc: Philippe Mathieu-Daudé --- tcg/tcg.c| 6 +++- tcg/aarch64/tcg-target.c.inc | 7 tcg/i386/tcg-target.c.inc| 63

[PATCH v6 10/23] tcg/optimize: Adjust TempOptInfo allocation

2021-01-11 Thread Richard Henderson
Do not allocate a large block for indexing. Instead, allocate for each temporary as they are seen. In general, this will use less memory, if we consider that most TBs do not touch every target register. This also allows us to allocate TempOptInfo for new temps created during optimization.

[PATCH v6 00/23] tcg: Better handling of constants

2021-01-11 Thread Richard Henderson
Changes for v6: Minor rebase conflict fixed. Changes for v5: Moved the clearing of the hash table from the end of compilation to the beginning of compilation. We skip the former when we long jump out of the translator loop, e.g. touching a code page that is unmapped. Patches without review:

[PATCH v6 02/23] tcg: Increase tcg_out_dupi_vec immediate to int64_t

2021-01-11 Thread Richard Henderson
While we don't store more than tcg_target_long in TCGTemp, we shouldn't be limited to that for code generation. We will be able to use this for INDEX_op_dup2_vec with 2 constants. Also pass along the minimal vece that may be said to apply to the constant. This allows some simplification in the

[PATCH] hw/ppc/ppc400_bamboo: Set dcr-base correctly when creating UIC

2021-01-11 Thread Peter Maydell
In commit 0270d74ef8862350 we switched from ppcuic_init() to directly creating the UIC device, but I missed that the Bamboo's UIC has a non-standard DCR base register value (0xc0 rather than the default of 0x30). This made Linux panic early in the boot process. Specify the correct dcr-base

[PATCH v2 0/2] Fixing several GCC 11 warnings

2021-01-11 Thread Miroslav Rezanina
Compiling qemu using GCC 11 we got several new warnings. To allow build with --enable-werror, we need to solve issues generating these warnings. Signed-of-by: Miroslav Rezanina v2: - Patch 2 rewrite to use strpadcpy - removed Patch 3 (different version sent by Philippe Mathieu-Daudé)

Re: [PATCH 4/8] hw/ppc/ppc440_bamboo: Drop use of ppcuic_init()

2021-01-11 Thread Peter Maydell
On Mon, 11 Jan 2021 at 01:00, Nathan Chancellor wrote: > > On Sat, Dec 12, 2020 at 12:15:33AM +, Peter Maydell wrote: > > Switch the bamboo board to directly creating and configuring the UIC, > > rather than doing it via the old ppcuic_init() helper function. > Hopefully reporting this here

[PATCH v2 1/2] Fix net.c warning on GCC 11

2021-01-11 Thread Miroslav Rezanina
When building qemu with GCC 11, compiling eth.c file produce following warning: warning: array subscript 'struct ip6_ext_hdr_routing[0]' is partly outside array bounds of 'struct ip6_ext_hdr[1]' [-Warray-bounds] This caused by retyping from ip6_ext_hdr to ip6_ext_hdr_routing that has more

Re: [PATCH] hvf: guard xgetbv call.

2021-01-11 Thread Richard Henderson
On 1/10/21 6:31 PM, Roman Bolshakov wrote: >> Also, if we're going to put this some place common, forcing the caller to do >> the cpuid that feeds this, then we should probably make all of the startup >> cpuid stuff common as well. >> > > I proposed the version because all callers of xgetbv

[PATCH v2 2/2] s390x: Use strpadcpy for copying vm name

2021-01-11 Thread Miroslav Rezanina
When using strncpy with lenght equal to size of target array, GCC 11 produce following warning: warning: '__builtin_strncpy' specified bound 256 equals destination size [-Wstringop-truncation] To prevent this warning, use strpadcpy function that will enusure that provide functionality

Re: [PATCH v3 06/25] block/block-copy: add list of all call-states

2021-01-11 Thread Max Reitz
On 26.10.20 18:17, Vladimir Sementsov-Ogievskiy wrote: It simplifies debugging. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/block-copy.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-11 Thread Cornelia Huck
On Tue, 5 Jan 2021 12:41:25 -0800 Ram Pai wrote: > On Tue, Jan 05, 2021 at 11:56:14AM +0100, Halil Pasic wrote: > > On Mon, 4 Jan 2021 10:40:26 -0800 > > Ram Pai wrote: > > > The main difference between my proposal and the other proposal is... > > > > > > In my proposal the guest makes the

Re: [PATCH v3 05/25] block/block-copy: add max_chunk and max_workers parameters

2021-01-11 Thread Max Reitz
On 26.10.20 18:17, Vladimir Sementsov-Ogievskiy wrote: They will be used for backup. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block-copy.h | 6 ++ block/block-copy.c | 11 +-- 2 files changed, 15 insertions(+), 2 deletions(-) Reviewed-by: Max

Re: [PATCH 4/5] hw/ppc/ppc4xx_pci: Replace pointless warning by assert()

2021-01-11 Thread Nathan Chancellor
On Mon, Jan 11, 2021 at 11:04:25AM +0100, Philippe Mathieu-Daudé wrote: > +Peter > > On 1/11/21 2:11 AM, Nathan Chancellor wrote: > > On Tue, Sep 01, 2020 at 12:40:42PM +0200, Philippe Mathieu-Daudé wrote: > >> We call pci_register_root_bus() to register 4 IRQs with the > >>

[PATCH v3 4/5] tests/tcg/s390x: Fix EXRL tests

2021-01-11 Thread David Hildenbrand
The current EXRL tests crash on real machines: we must not use r0 as a base register for trt/trtr, otherwise the content gets ignored. Also, we must not use r0 for exrl, otherwise it gets ignored. Let's use the "a" constraint so we get a general purpose register != r0. For op2, we can simply

[PATCH v3 5/5] s390x/tcg: Ignore register content if b1/b2 is zero when handling EXECUTE

2021-01-11 Thread David Hildenbrand
In our EXECUTE fast path, we have to ignore the content of r0, if specified by b1 or b2. Fixes: d376f123c7de ("target/s390x: Re-implement a few EXECUTE target insns directly") Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Tested-by: Nick Desaulniers Tested-by: Guenter Roeck

[PATCH v3 3/5] s390x/tcg: Don't ignore content in r0 when not specified via "b" or "x"

2021-01-11 Thread David Hildenbrand
Using get_address() with register identifiers comming from an "r" field is wrong: if the "r" field designates "r0", we don't read the content and instead assume 0 - which should only be applied when the register was specified via "b" or "x". PoP 5-11 "Operand-Address Generation": "A zero in any

[PATCH v3 1/5] s390x/tcg: Fix ALGSI

2021-01-11 Thread David Hildenbrand
Looks like something went wrong whiel touching that line. Instead of "r1" we need a new temporary. Also, we have to pass MO_TEQ, to indicate that we are working with 64-bit values. Let's revert these changes. Fixes: ff26d287bddc ("target/s390x: Improve cc computation for ADD LOGICAL")

[PATCH v3 2/5] s390x/tcg: Fix RISBHG

2021-01-11 Thread David Hildenbrand
RISBHG is broken and currently hinders clang-11 builds of upstream kernels from booting: the kernel crashes early, while decompressing the image. [...] Kernel fault: interruption code 0005 ilc:2 Kernel random base: PSW : 20018000 00017a1e R:0

[PATCH v3 0/5] s390x/tcg: fix booting Linux kernels compiled with clang-11 and clang-12

2021-01-11 Thread David Hildenbrand
This series fixes booting current upstream Linux kernel compiled by clang-11 and clang-12 under TCG. Latest version of the patches available at: g...@github.com:davidhildenbrand/qemu.git clang v2 -> v3: - Add 'tests/tcg/s390x: Fix EXRL tests' -- "make check-tcg" with v2 revealed two buggy tests

Re: [PATCH] vhost-user-fs: add the "bootindex" property

2021-01-11 Thread Laszlo Ersek
On 01/11/21 17:22, Cornelia Huck wrote: > On Mon, 4 Jan 2021 14:24:01 +0100 > Laszlo Ersek wrote: > >> virtio-fs qualifies as a bootable device minimally under OVMF, but >> currently the necessary "bootindex" property is missing (fw_cfg kernel >> boot notwithstanding). >> >> Add the property.

Re: [PATCH v3 04/25] block/block-copy: implement block_copy_async

2021-01-11 Thread Max Reitz
On 26.10.20 18:17, Vladimir Sementsov-Ogievskiy wrote: We'll need async block-copy invocation to use in backup directly. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block-copy.h | 26 block/block-copy.c | 81 -- 2

Re: Ask for suggestions for CVE-2019-12928

2021-01-11 Thread Daniel P . Berrangé
On Mon, Jan 11, 2021 at 11:43:53PM +0800, 江芳杰 wrote: > Hi: > Sorry to bother you~ > I have read the discussions about CVE--2019-12928 ( > https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg01153.html). > But, for the scenario of PC users, which is no requirement of network access >

Re: [PATCH] vhost-user-fs: add the "bootindex" property

2021-01-11 Thread Cornelia Huck
On Mon, 4 Jan 2021 14:24:01 +0100 Laszlo Ersek wrote: > virtio-fs qualifies as a bootable device minimally under OVMF, but > currently the necessary "bootindex" property is missing (fw_cfg kernel > boot notwithstanding). > > Add the property. For completeness, add it to the CCW device as well;

Re: [PATCH] vhost-user-fs: add the "bootindex" property

2021-01-11 Thread Laszlo Ersek
On 01/11/21 11:07, Christian Borntraeger wrote: > > > On 11.01.21 11:05, Laszlo Ersek wrote: >> On 01/11/21 10:46, Christian Borntraeger wrote: >>> >>> >>> On 04.01.21 14:24, Laszlo Ersek wrote: virtio-fs qualifies as a bootable device minimally under OVMF, but currently the necessary

Re: [RFC v6 10/11] accel: introduce AccelCPUClass extending CPUClass

2021-01-11 Thread Claudio Fontana
On 12/19/20 12:00 AM, Claudio Fontana wrote: > On 12/18/20 11:30 PM, Claudio Fontana wrote: >> On 12/18/20 10:55 PM, Claudio Fontana wrote: >>> On 12/18/20 7:04 PM, Claudio Fontana wrote: On 12/18/20 7:01 PM, Paolo Bonzini wrote: > On 18/12/20 18:51, Claudio Fontana wrote: >> But with

Re: [PATCH 1/2] sysemu/runstate: Let runstate_is_running() return bool

2021-01-11 Thread David Hildenbrand
On 11.01.21 16:20, Philippe Mathieu-Daudé wrote: > runstate_check() returns a boolean. runstate_is_running() > returns what runstate_check() returns, also a boolean. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/runstate.h | 2 +- > softmmu/runstate.c| 2 +- > 2 files

Re: [PATCH v5 14/14] block/qcow2: refactor qcow2_update_options_prepare error paths

2021-01-11 Thread Alberto Garcia
On Sat 09 Jan 2021 01:58:11 PM CET, Vladimir Sementsov-Ogievskiy wrote: > Keep setting ret close to setting errp and don't merge different error > paths into one. This way it's more obvious that we don't return > error without setting errp. > > Signed-off-by: Vladimir Sementsov-Ogievskiy I get

Re: [PATCH v3 02/25] qapi: backup: add perf.use-copy-range parameter

2021-01-11 Thread Max Reitz
On 26.10.20 18:17, Vladimir Sementsov-Ogievskiy wrote: Experiments show, that copy_range is not always making things faster. So, to make experimentation simpler, let's add a parameter. Some more perf parameters will be added soon, so here is a new struct. For now, add new backup qmp parameter

Re: [PATCH v3 2/3] Update linux headers to 5.11-rc2

2021-01-11 Thread Cornelia Huck
On Mon, 11 Jan 2021 10:18:28 -0500 "Michael S. Tsirkin" wrote: > On Mon, Jan 11, 2021 at 10:11:23AM -0500, Eric Farman wrote: > > > > > > On 1/11/21 10:00 AM, Michael S. Tsirkin wrote: > > > On Mon, Jan 11, 2021 at 02:43:22PM +0100, Cornelia Huck wrote: > > > > On Mon, 11 Jan 2021 08:00:45

Re: [PATCH] configure: Add flags for MinGW32 standalone build

2021-01-11 Thread Joshua Watt
On Mon, Jan 11, 2021 at 1:44 AM Paolo Bonzini wrote: > > On 11/01/21 08:29, Stefan Weil wrote: > > Am 11.01.21 um 08:04 schrieb Thomas Huth: > > > >> On 08/01/2021 19.30, Joshua Watt wrote: > >>> > >>> On 1/8/21 1:25 AM, Thomas Huth wrote: > On 07/01/2021 22.38, Joshua Watt wrote: > >

Re: [PATCH] vnc: fix unfinalized tlscreds for VncDisplay

2021-01-11 Thread Daniel P . Berrangé
On Mon, Jan 11, 2021 at 09:19:11PM +0800, Zihao Chang wrote: > In vnc_display_open(), if tls-creds is enabled, do object_ref(object > ref 1->2) for tls-creds. While in vnc_display_close(), object_unparent > sets object ref to 1(2->1) and unparent the object for root. > Problem: > 1. the object

Re: [PATCH] cirrus.yml: Replace the hard-coded python-sphinx version with the generic one

2021-01-11 Thread Philippe Mathieu-Daudé
On 1/11/21 11:34 AM, Thomas Huth wrote: > The mingw-w64-x86_64-python-sphinx-2.3.1 package has been removed from > the server, so the windows_msys2_task is currently failing. Replace the > old version with the current generic one to fix the issue (the current > version seems to work fine now,

Re: [PATCH] vnc: fix unfinalized tlscreds for VncDisplay

2021-01-11 Thread Philippe Mathieu-Daudé
+Daniel On 1/11/21 2:19 PM, Zihao Chang wrote: > In vnc_display_open(), if tls-creds is enabled, do object_ref(object > ref 1->2) for tls-creds. While in vnc_display_close(), object_unparent > sets object ref to 1(2->1) and unparent the object for root. > Problem: > 1. the object can not be

Re: [RFC PATCH 4/5] tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements

2021-01-11 Thread Miroslav Rezanina
- Original Message - > From: "Philippe Mathieu-Daudé" > To: qemu-devel@nongnu.org > Cc: "Huacai Chen" , "Aurelien Jarno" > , "Aleksandar Rikalo" > , "Thomas Huth" , "Stefan > Weil" , > qemu-ri...@nongnu.org, qemu-...@nongnu.org, "Jiaxun Yang" > , qemu-s3...@nongnu.org, > "Philippe

Re: [PATCH v1 17/20] riscv: Add semihosting support for user mode

2021-01-11 Thread Philippe Mathieu-Daudé
On 1/8/21 11:42 PM, Alex Bennée wrote: > From: Kito Cheng > > This could made testing more easier and ARM/AArch64 has supported on > their linux user mode too, so I think it should be reasonable. > > Verified GCC testsuite with newlib/semihosting. > > Signed-off-by: Kito Cheng > Reviewed-by:

Re: [PATCH v1 12/20] semihosting: Move ARM semihosting code to shared directories

2021-01-11 Thread Philippe Mathieu-Daudé
On 1/8/21 11:42 PM, Alex Bennée wrote: > From: Keith Packard > > This commit renames two files which provide ARM semihosting support so > that they can be shared by other architectures: > > 1. target/arm/arm-semi.c -> hw/semihosting/common-semi.c > 2. linux-user/arm/semihost.c ->

Re: [PATCH v1 13/20] semihosting: Change common-semi API to be architecture-independent

2021-01-11 Thread Philippe Mathieu-Daudé
On 1/8/21 11:42 PM, Alex Bennée wrote: > From: Keith Packard > > The public API is now defined in > hw/semihosting/common-semi.h. do_common_semihosting takes CPUState * > instead of CPUARMState *. All internal functions have been renamed > common_semi_ instead of arm_semi_ or arm_. Aside from

Re: [PATCH v1 12/20] semihosting: Move ARM semihosting code to shared directories

2021-01-11 Thread Philippe Mathieu-Daudé
On 1/11/21 4:30 PM, Philippe Mathieu-Daudé wrote: > On 1/8/21 11:42 PM, Alex Bennée wrote: >> From: Keith Packard >> >> This commit renames two files which provide ARM semihosting support so >> that they can be shared by other architectures: >> >> 1. target/arm/arm-semi.c ->

Re: [PATCH v1 12/20] semihosting: Move ARM semihosting code to shared directories

2021-01-11 Thread Philippe Mathieu-Daudé
On 1/8/21 11:42 PM, Alex Bennée wrote: > From: Keith Packard > > This commit renames two files which provide ARM semihosting support so > that they can be shared by other architectures: > > 1. target/arm/arm-semi.c -> hw/semihosting/common-semi.c > 2. linux-user/arm/semihost.c ->

Re: [PATCH v1 02/20] test/guest-debug: echo QEMU command as well

2021-01-11 Thread Philippe Mathieu-Daudé
On 1/8/21 11:42 PM, Alex Bennée wrote: > This helps with debugging. > > Signed-off-by: Alex Bennée > Message-Id: <20201214153012.12723-2-alex.ben...@linaro.org> > Message-Id: <20201218112707.28348-2-alex.ben...@linaro.org> > Signed-off-by: Alex Bennée > --- > tests/guest-debug/run-test.py | 1

[PATCH 2/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument

2021-01-11 Thread Philippe Mathieu-Daudé
The 'running' argument from VMChangeStateHandler does not require other value than 0 / 1. Make it a plain boolean. Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/runstate.h | 10 -- target/arm/kvm_arm.h| 2 +- target/ppc/cpu-qom.h| 2 +- accel/xen/xen-all.c

[PATCH 0/2] sysemu: Let VMChangeStateHandler take boolean 'running' argument

2021-01-11 Thread Philippe Mathieu-Daudé
Trivial prototype change to clarify the use of the 'running' argument of VMChangeStateHandler. Green CI: https://gitlab.com/philmd/qemu/-/pipelines/239497352 Philippe Mathieu-Daudé (2): sysemu/runstate: Let runstate_is_running() return bool sysemu: Let VMChangeStateHandler take boolean

[PATCH 1/2] sysemu/runstate: Let runstate_is_running() return bool

2021-01-11 Thread Philippe Mathieu-Daudé
runstate_check() returns a boolean. runstate_is_running() returns what runstate_check() returns, also a boolean. Signed-off-by: Philippe Mathieu-Daudé --- include/sysemu/runstate.h | 2 +- softmmu/runstate.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v3 2/3] Update linux headers to 5.11-rc2

2021-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2021 at 10:11:23AM -0500, Eric Farman wrote: > > > On 1/11/21 10:00 AM, Michael S. Tsirkin wrote: > > On Mon, Jan 11, 2021 at 02:43:22PM +0100, Cornelia Huck wrote: > > > On Mon, 11 Jan 2021 08:00:45 -0500 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Mon, Jan 11, 2021 at

Re: [PATCH v3 2/3] Update linux headers to 5.11-rc2

2021-01-11 Thread Eric Farman
On 1/11/21 10:00 AM, Michael S. Tsirkin wrote: On Mon, Jan 11, 2021 at 02:43:22PM +0100, Cornelia Huck wrote: On Mon, 11 Jan 2021 08:00:45 -0500 "Michael S. Tsirkin" wrote: On Mon, Jan 11, 2021 at 01:54:04PM +0100, Cornelia Huck wrote: On Mon, 4 Jan 2021 21:20:56 +0100 Eric Farman

[RFC PATCH 5/5] tcg: Restrict tcg_out_vec_op() to arrays of TCG_MAX_OP_ARGS elements

2021-01-11 Thread Philippe Mathieu-Daudé
tcg_reg_alloc_op() allocates arrays of TCG_MAX_OP_ARGS elements. Signed-off-by: Philippe Mathieu-Daudé --- tcg/tcg.c| 14 -- tcg/aarch64/tcg-target.c.inc | 3 ++- tcg/i386/tcg-target.c.inc| 3 ++- tcg/ppc/tcg-target.c.inc | 3 ++- 4 files changed, 14

[RFC PATCH 4/5] tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements

2021-01-11 Thread Philippe Mathieu-Daudé
tcg_reg_alloc_op() allocates arrays of TCG_MAX_OP_ARGS elements. The Aarch64 target already does this since commit 8d8db193f25 ("tcg-aarch64: Hoist common argument loads in tcg_out_op"), SPARC since commit b357f902bff ("tcg-sparc: Hoist common argument loads in tcg_out_op"). RISCV missed it upon

[PATCH 1/5] tcg/arm: Hoist common argument loads in tcg_out_op()

2021-01-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tcg/arm/tcg-target.c.inc | 173 +++ 1 file changed, 86 insertions(+), 87 deletions(-) diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc index 0fd11264544..94cc12a0fc6 100644 ---

[PATCH 3/5] tcg/s390: Hoist common argument loads in tcg_out_op()

2021-01-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tcg/s390/tcg-target.c.inc | 252 ++ 1 file changed, 122 insertions(+), 130 deletions(-) diff --git a/tcg/s390/tcg-target.c.inc b/tcg/s390/tcg-target.c.inc index d7ef0790556..74b2314c78a 100644 ---

[PATCH 0/5] tcg: Restrict tcg_out_op() to arrays of TCG_MAX_OP_ARGS elements

2021-01-11 Thread Philippe Mathieu-Daudé
Attempt to fix the warning reported by Miroslav using GCC 10: https://www.mail-archive.com/qemu-devel@nongnu.org/msg771520.html Philippe Mathieu-Daudé (5): tcg/arm: Hoist common argument loads in tcg_out_op() tcg/ppc: Hoist common argument loads in tcg_out_op() tcg/s390: Hoist common

[PATCH 2/5] tcg/ppc: Hoist common argument loads in tcg_out_op()

2021-01-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tcg/ppc/tcg-target.c.inc | 294 ++- 1 file changed, 138 insertions(+), 156 deletions(-) diff --git a/tcg/ppc/tcg-target.c.inc b/tcg/ppc/tcg-target.c.inc index 19a4a12f155..d37b519d693 100644 ---

Re: [PATCH v3] acpi: Permit OEM ID and OEM table ID fields to be changed

2021-01-11 Thread Marian Posteuca
Igor Mammedov writes: > overall looks good. > Please add a test case for it, see > tests/qtest/bios-tables-test.c for description how to do it > an/or at > "[PATCH v3 08/12] tests/acpi: allow updates for expected data files" > and follow up patches on the list. When you say add a test case, do

Re: [PATCH v3 2/3] Update linux headers to 5.11-rc2

2021-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2021 at 02:43:22PM +0100, Cornelia Huck wrote: > On Mon, 11 Jan 2021 08:00:45 -0500 > "Michael S. Tsirkin" wrote: > > > On Mon, Jan 11, 2021 at 01:54:04PM +0100, Cornelia Huck wrote: > > > On Mon, 4 Jan 2021 21:20:56 +0100 > > > Eric Farman wrote: > > > > > > >

About creating machines on the command line

2021-01-11 Thread Luc Michel
Hi, We would like to work on improving QEMU to be able to create custom machines from the command line. The goal here is to get feedback from the community and shape the future developments. The use case mainly comes from people working with tools to customize their designs, such as SiFive

Re: [PATCH 0/6] Update git repo URLs to GitLab

2021-01-11 Thread Wainer dos Santos Moschetta
Hi, On 1/11/21 8:50 AM, Stefan Hajnoczi wrote: Several places in qemu.git reference qemu.org git repo URLs. Let's switch to GitLab repo URLs in order to enable GitLab as a gating CI and in order to reduce qemu.org bandwidth consumption. Paolo has already set up GitLab mirror repos. sgabios was

Re: [PATCH v1 10/20] target/arm: use official org.gnu.gdb.aarch64.sve layout for registers

2021-01-11 Thread Luis Machado
Hi, On 1/11/21 11:36 AM, Alex Bennée wrote: Luis Machado writes: For the record, the layout looks OK to me. So a Reviewed-by? Yes. Just a reminder that GDB will soon support bfloat16 types. A patch may be pushed this month. Will we be able to probe for the support - or will an

Re: check-tcg HOWTO?

2021-01-11 Thread Claudio Fontana
Ciao Alex, thanks for your answer, On 1/11/21 2:35 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> Hi Alex, >> >> happy new year, >> >> I am trying to get check-tcg to run reliably, >> as I am doing some substantial refactoring of tcg cpu operations, so I need >> to verify that TCG

Re: [PULL v2 00/15] Testing, CI and bsd-user patches

2021-01-11 Thread Philippe Mathieu-Daudé
On 1/11/21 3:06 PM, Thomas Huth wrote: > The following changes since commit 7b09f127738ae3d0e71716cea086fc8f847a5686: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210108' into staging (2021-01-08 > 15:37:04 +) > > are available in the Git repository at: >

Re: [PATCH v1 10/20] target/arm: use official org.gnu.gdb.aarch64.sve layout for registers

2021-01-11 Thread Alex Bennée
Luis Machado writes: > For the record, the layout looks OK to me. So a Reviewed-by? > Just a reminder that GDB will soon support bfloat16 types. A patch may > be pushed this month. Will we be able to probe for the support - or will an older GDB silently accept and drop any bfloat16 fields?

Re: [PATCH v14 1/7] Introduce yank feature

2021-01-11 Thread Marc-André Lureau
On Mon, Jan 11, 2021 at 5:34 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > On Mon, Dec 28, 2020 at 7:08 PM Lukas Straub > wrote: > > > >> The yank feature allows to recover from hanging qemu by "yanking" > >> at various parts. Other qemu systems can register

[PULL v2 00/15] Testing, CI and bsd-user patches

2021-01-11 Thread Thomas Huth
The following changes since commit 7b09f127738ae3d0e71716cea086fc8f847a5686: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210108' into staging (2021-01-08 15:37:04 +) are available in the Git repository at: https://gitlab.com/huth/qemu.git

[PULL 01/15] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD

2021-01-11 Thread Thomas Huth
From: "Cho, Yu-Chen" Add build-system-opensuse jobs and opensuse-leap.docker dockerfile. Use openSUSE Leap 15.2 container image in the gitlab-CI. Signed-off-by: Cho, Yu-Chen Tested-by: Wainer dos Santos Moschetta Reviewed-by: Wainer dos Santos Moschetta Message-Id:

Re: check-tcg HOWTO?

2021-01-11 Thread Alex Bennée
Claudio Fontana writes: > Hi Alex, > > happy new year, > > I am trying to get check-tcg to run reliably, > as I am doing some substantial refactoring of tcg cpu operations, so I need > to verify that TCG is fine. > > This is an overall getting started question, is there a how-to on how > to

Re: [PULL 00/15] Testing, CI and bsd-user patches

2021-01-11 Thread Peter Maydell
On Mon, 11 Jan 2021 at 13:43, Thomas Huth wrote: > > Hi, > > the following changes since commit 7b09f127738ae3d0e71716cea086fc8f847a5686: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210108' into staging (2021-01-08 > 15:37:04 +) > > are available in the

Re: [PULL 00/15] Testing, CI and bsd-user patches

2021-01-11 Thread Thomas Huth
On 11/01/2021 14.46, Peter Maydell wrote: On Mon, 11 Jan 2021 at 13:43, Thomas Huth wrote: Hi, the following changes since commit 7b09f127738ae3d0e71716cea086fc8f847a5686: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210108' into staging (2021-01-08 15:37:04

[PULL 13/15] bsd-user: Update strace.list for FreeBSD's latest syscalls

2021-01-11 Thread Thomas Huth
From: Warner Losh Update strace.list to include all of FreeBSD's syscalls up through svn r331280. Signed-off-by: Stacey Son Signed-off-by: Sean Bruno Signed-off-by: Alexander Kabaev Signed-off-by: Jung-uk Kim Author: Michal Meloun Signed-off-by: Mikaël Urankar [imp moved this change to

[PULL 09/15] fuzz: add minimization options

2021-01-11 Thread Thomas Huth
From: Qiuhao Li -M1: remove IO commands iteratively -M2: try setting bits in operand of write/out to zero Signed-off-by: Qiuhao Li Reviewed-by: Alexander Bulekov Tested-by: Alexander Bulekov Message-Id: Signed-off-by: Thomas Huth --- scripts/oss-fuzz/minimize_qtest_trace.py | 30

Re: [PATCH 18/20] keyval: Use GString to accumulate value strings

2021-01-11 Thread Paolo Bonzini
On 11/01/21 14:05, Markus Armbruster wrote: I had to choose between creating a conflict and holding back my series while we figure out what to do with your patch. The dilemma is my own doing; your patch is waiting just for me. I picked the conflict. I can look into rebasing your patch on top

[PULL 07/15] fuzz: remove IO commands iteratively

2021-01-11 Thread Thomas Huth
From: Qiuhao Li Now we use a one-time scan and remove strategy in the minimizer, which is not suitable for timing dependent instructions. For example, instruction A will indicate an address where the config chunk locates, and instruction B will make the configuration active. If we have the

[PULL 08/15] fuzz: set bits in operand of write/out to zero

2021-01-11 Thread Thomas Huth
From: Qiuhao Li Simplifying the crash cases by opportunistically setting bits in operands of out/write to zero may help to debug, since usually bit one means turn on or trigger a function while zero is the default turn-off setting. Tested bug https://bugs.launchpad.net/qemu/+bug/1908062

[PULL 15/15] fuzz: map all BARs and enable PCI devices

2021-01-11 Thread Thomas Huth
From: Alexander Bulekov Prior to this patch, the fuzzer found inputs to map PCI device BARs and enable the device. While it is nice that the fuzzer can do this, it added significant overhead, since the fuzzer needs to map all the BARs (regenerating the memory topology), at the start of each

[PULL 12/15] bsd-user: move strace OS/arch dependent code to host/arch dirs

2021-01-11 Thread Thomas Huth
From: Stacey Son This change moves host OS and arch dependent code for the sysarch system call related to the -strace functionality into the appropriate host OS and target arch directories. Signed-off-by: Stacey Son Signed-off-by: Sean Bruno [ imp integrated minor build fixes from sbruno ]

[PULL 14/15] tests/acceptance: Fix race conditions in s390x tests & skip fedora on gitlab-CI

2021-01-11 Thread Thomas Huth
There was a race condition in the first test where there was already the "crw" output in the dmesg, but the "0.0.4711" entry has not been created in the /sys fs yet. Fix it by waiting until it is there. The second test has even more problems on gitlab-CI. Even after adding some more

[PULL 04/15] fuzz: accelerate non-crash detection

2021-01-11 Thread Thomas Huth
From: Qiuhao Li We spend much time waiting for the timeout program during the minimization process until it passes a time limit. This patch hacks the CLOSED (indicates the redirection file closed) notification in QTest's output if it doesn't crash. Test with quadrupled trace input at:

[PULL 02/15] qtest/libqtest: fix heap-buffer-overflow in qtest_cb_for_every_machine()

2021-01-11 Thread Thomas Huth
From: Gan Qixin When the length of mname is less than 5, memcpy("xenfv", mname, 5) will cause heap buffer overflow. Therefore, use strncmp to avoid this problem. The asan showed stack: ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6020f2f4 at pc 0x7f65d8cc2225 bp

[PULL 11/15] bsd-user: regenerate FreeBSD's system call numbers

2021-01-11 Thread Thomas Huth
From: Warner Losh Recreate the FreeBSD system call numbers from current sys/syscall.h. Since this isn't guaranteed to be on all systems, continue the practice of generating it with some variation on: sed -e s/SYS_/TARGET_NR_/ < $FREEBSD_SRC/sys/syscall.h > syscall_nr.h until a more

[PULL 10/15] fuzz: heuristic split write based on past IOs

2021-01-11 Thread Thomas Huth
From: Qiuhao Li If previous write commands write the same length of data with the same step, we view it as a hint. Signed-off-by: Qiuhao Li Reviewed-by: Alexander Bulekov Tested-by: Alexander Bulekov Message-Id: Signed-off-by: Thomas Huth --- scripts/oss-fuzz/minimize_qtest_trace.py | 56

[PULL 03/15] util/oslib-win32: Fix _aligned_malloc() arguments order

2021-01-11 Thread Thomas Huth
From: Philippe Mathieu-Daudé Commit dfbd0b873a8 inadvertently swapped the arguments of _aligned_malloc(), correct it to fix [*]: G_TEST_SRCDIR=C:/Users/ContainerAdministrator/AppData/Local/Temp/cirrus-ci-build/tests

[PULL 00/15] Testing, CI and bsd-user patches

2021-01-11 Thread Thomas Huth
Hi, the following changes since commit 7b09f127738ae3d0e71716cea086fc8f847a5686: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210108' into staging (2021-01-08 15:37:04 +) are available in the Git repository at: https://gitlab.com/huth/qemu.git

[PULL 06/15] fuzz: split write operand using binary approach

2021-01-11 Thread Thomas Huth
From: Qiuhao Li Currently, we split the write commands' data from the middle. If it does not work, try to move the pivot left by one byte and retry until there is no space. But, this method has two flaws: 1. It may fail to trim all unnecessary bytes on the right side. For example, there is an

[PULL 05/15] fuzz: double the IOs to remove for every loop

2021-01-11 Thread Thomas Huth
From: Qiuhao Li Instead of removing IO instructions one by one, we can try deleting multiple instructions at once. According to the locality of reference, we double the number of instructions to remove for the next round and recover it to one once we fail. This patch is usually significant for

[PULL 01/15] gitlab-ci.yml: Add openSUSE Leap 15.2 for gitlab CI/CD

2021-01-11 Thread Thomas Huth
From: "Cho, Yu-Chen via" Add build-system-opensuse jobs and opensuse-leap.docker dockerfile. Use openSUSE Leap 15.2 container image in the gitlab-CI. Signed-off-by: Cho, Yu-Chen Tested-by: Wainer dos Santos Moschetta Reviewed-by: Wainer dos Santos Moschetta Message-Id:

Re: [PATCH v3 2/3] Update linux headers to 5.11-rc2

2021-01-11 Thread Cornelia Huck
On Mon, 11 Jan 2021 08:00:45 -0500 "Michael S. Tsirkin" wrote: > On Mon, Jan 11, 2021 at 01:54:04PM +0100, Cornelia Huck wrote: > > On Mon, 4 Jan 2021 21:20:56 +0100 > > Eric Farman wrote: > > > > > Signed-off-by: Eric Farman > > > --- > > > .../infiniband/hw/vmw_pvrdma/pvrdma_ring.h|

Re: [PATCH v14 1/7] Introduce yank feature

2021-01-11 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Mon, Dec 28, 2020 at 7:08 PM Lukas Straub wrote: > >> The yank feature allows to recover from hanging qemu by "yanking" >> at various parts. Other qemu systems can register themselves and >> multiple yank functions. Then all yank functions for selected >>

Re: qemu bsd-user plans

2021-01-11 Thread Daniel P . Berrangé
On Fri, Jan 08, 2021 at 12:41:30PM -0700, Warner Losh wrote: > The FreeBSD project has rewritten bsd-user. We've been working on this for > quite some time (the earliest commits date from 2013). Maybe a dozen people > have worked on this over time, and there's 3 or 4 active developers focused > on

Re: [PATCH v1 10/20] target/arm: use official org.gnu.gdb.aarch64.sve layout for registers

2021-01-11 Thread Luis Machado
For the record, the layout looks OK to me. Just a reminder that GDB will soon support bfloat16 types. A patch may be pushed this month. On 1/8/21 7:42 PM, Alex Bennée wrote: While GDB can work with any XML description given to it there is special handling for SVE registers on the GDB side

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Christian Borntraeger
On 11.01.21 14:17, Miroslav Rezanina wrote: > > > - Original Message - >> From: "Christian Borntraeger" >> To: "Thomas Huth" , "Miroslav Rezanina" >> >> Cc: "qemu-s390x" , "Philippe Mathieu-Daudé" >> , qemu-devel@nongnu.org >> Sent: Monday, January 11, 2021 2:02:32 PM >> Subject:

[PATCH] vnc: fix unfinalized tlscreds for VncDisplay

2021-01-11 Thread Zihao Chang
In vnc_display_open(), if tls-creds is enabled, do object_ref(object ref 1->2) for tls-creds. While in vnc_display_close(), object_unparent sets object ref to 1(2->1) and unparent the object for root. Problem: 1. the object can not be found from the objects_root, while the object is not

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Miroslav Rezanina
- Original Message - > From: "Christian Borntraeger" > To: "Thomas Huth" , "Miroslav Rezanina" > > Cc: "qemu-s390x" , "Philippe Mathieu-Daudé" > , qemu-devel@nongnu.org > Sent: Monday, January 11, 2021 2:02:32 PM > Subject: Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy

Re: [PATCH] 9pfs/proxy: Check return value of proxy_marshal()

2021-01-11 Thread Christian Schoenebeck via
On Montag, 11. Januar 2021 10:49:56 CET Greg Kurz wrote: > This should always successfully write exactly two 32-bit integers. > Make it clear with an assert(), like v9fs_receive_status() and > v9fs_receive_response() already do when unmarshalling the same > header. > > Fixes: Coverity CID 1438968

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Christian Borntraeger
On 11.01.21 13:54, Thomas Huth wrote: > On 11/01/2021 13.42, Miroslav Rezanina wrote: >> >> >> - Original Message - >>> From: "Thomas Huth" >>> To: "Philippe Mathieu-Daudé" , mreza...@redhat.com, >>> qemu-devel@nongnu.org, "qemu-s390x" >>> >>> Sent: Monday, January 11, 2021 1:24:57

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Christian Borntraeger
On 11.01.21 14:02, Christian Borntraeger wrote: > > > On 11.01.21 13:54, Thomas Huth wrote: >> On 11/01/2021 13.42, Miroslav Rezanina wrote: >>> >>> >>> - Original Message - From: "Thomas Huth" To: "Philippe Mathieu-Daudé" , mreza...@redhat.com, qemu-devel@nongnu.org,

Re: [PATCH 18/20] keyval: Use GString to accumulate value strings

2021-01-11 Thread Markus Armbruster
Paolo Bonzini writes: > On 11/12/20 18:11, Markus Armbruster wrote: >> QString supports modifying its string, but it's quite limited: you can >> only append. The remaining callers use it for building an initial >> string, never for modifying it later. >> Change keyval_parse_one() to do build

Re: [PATCH v3 2/3] Update linux headers to 5.11-rc2

2021-01-11 Thread Michael S. Tsirkin
On Mon, Jan 11, 2021 at 01:54:04PM +0100, Cornelia Huck wrote: > On Mon, 4 Jan 2021 21:20:56 +0100 > Eric Farman wrote: > > > Signed-off-by: Eric Farman > > --- > > .../infiniband/hw/vmw_pvrdma/pvrdma_ring.h| 14 +- > > .../infiniband/hw/vmw_pvrdma/pvrdma_verbs.h | 2 +- > >

<    1   2   3   4   >