Re: [PATCH 2/3] qmp: remove deprecated "change" command

2021-01-20 Thread Eric Blake
On 1/20/21 8:42 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > docs/system/deprecated.rst | 5 > docs/system/removed-features.rst | 5 > monitor/qmp-cmds.c | 51 > qapi/misc.json | 49

Re: [PATCH v3 05/17] qapi: pass QAPISchemaModule to visit_module instead of str

2021-01-20 Thread John Snow
On 1/20/21 7:07 AM, Markus Armbruster wrote: John Snow writes: Modify visit_module to pass the module itself instead of just its name. This allows for future patches to centralize some module-interrogation behavior within the QAPISchemaModule class itself, cutting down on duplication between

Re: qemu broke booting of old RedHat floppies

2021-01-20 Thread Thomas Huth
On 20/01/2021 16.11, Michael Tokarev wrote: As someone noticed on IRC, old (2.x) RedHat floppies does not boot in current qemu.  When qemu is booted from floppy image at  https://archive.org/details/RedHatLinuxBootDisk521998 (download the "ISO image" link there, it really is an 1.44 floppy),

Re: [PATCH] runstate: cleanup reboot and panic actions

2021-01-20 Thread Eric Blake
On 1/20/21 8:37 AM, Paolo Bonzini wrote: > The possible choices for panic, reset and watchdog actions are inconsistent. > > "-action panic=poweroff" should be renamed to "-action panic=shutdown" > on the command line. This is because "-action panic=poweroff" and > "-action watchdog=poweroff"

Re: [PATCH v4 00/23] backup performance: block_status + async

2021-01-20 Thread Daniel P . Berrangé
On Wed, Jan 20, 2021 at 04:53:26PM +0100, Max Reitz wrote: > On 20.01.21 15:44, Max Reitz wrote: > > On 20.01.21 15:34, Max Reitz wrote: > > [...] > > > >  From a glance, it looks to me like two coroutines are created > > > simultaneously in two threads, and so one thread sets up a special > > >

Re: [RFC PATCH 1/2] scsi/utils: Add INVALID_PARAM_VALUE sense code definition

2021-01-20 Thread Philippe Mathieu-Daudé
On 1/20/21 5:01 PM, Gerd Hoffmann wrote: > Hi, > >>> +/* Illegal request, Invalid value in parameter list */ >>> +extern const struct SCSISense sense_code_INVALID_PARAM_VALUE; > >> Pre-existing: the term 'illegal' is suspect in computer science (the >> code isn't breaking any laws); > >

Re: [PULL 3/5] linux-user: add missing IPv6 get/setsockopt option

2021-01-20 Thread Philippe Mathieu-Daudé
On 1/20/21 5:00 PM, Laurent Vivier wrote: > Le 20/01/2021 à 13:16, Philippe Mathieu-Daudé a écrit : >> On 1/19/21 6:54 PM, Laurent Vivier wrote: >>> From: Shu-Chun Weng >>> >>> IPV6_ADDR_PREFERENCES (RFC5014: Source address selection) was not supported. >>> >>> Signed-off-by: Shu-Chun Weng >>>

Re: [PATCH v2 1/3] scsi/utils: Rename 'illegal request' -> 'invalid request'

2021-01-20 Thread Gerd Hoffmann
On Wed, Jan 20, 2021 at 04:35:20PM +0100, Philippe Mathieu-Daudé wrote: > While these requests are invalid, they are not breaking any laws :) > Rename 'illegal request' as 'invalid request'. Given the scsi spec calls this "illegal request" I think it makes sense to *not* change this and stay

Revisiting VERSION for Python subpackage

2021-01-20 Thread John Snow
Hi Peter: In the past, you expressed hesitation over adding another VERSION file to ./python/, preferring we single-source it somehow. For now, I believe I will be pursuing a version of 0.6.0.0a1 to indicate the subpackage is in a beta state, but otherwise tied/related to the QEMU 6.0

Re: [PULL 3/5] linux-user: add missing IPv6 get/setsockopt option

2021-01-20 Thread Philippe Mathieu-Daudé
On 1/20/21 5:22 PM, Laurent Vivier wrote: > Le 20/01/2021 à 17:12, Philippe Mathieu-Daudé a écrit : >> On 1/20/21 5:00 PM, Laurent Vivier wrote: >>> Le 20/01/2021 à 13:16, Philippe Mathieu-Daudé a écrit : On 1/19/21 6:54 PM, Laurent Vivier wrote: > From: Shu-Chun Weng > >

Re: [PATCH] meson: Declare have_virtfs_proxy_helper in main meson.build

2021-01-20 Thread Paolo Bonzini
On 20/01/21 16:15, Philippe Mathieu-Daudé wrote: have_virtfs_proxy_helper is used from docs/meson.build, and can be not declared when including it before fsdev/meson.build. This fixes: ../docs/meson.build:54:2: ERROR: Unknown variable "have_virtfs_proxy_helper". Signed-off-by: Philippe

[PULL 2/7] fuzz: refine the ide/ahci fuzzer configs

2021-01-20 Thread Alexander Bulekov
Disks work differently depending on the x86 machine type (SATA vs PATA). Additionally, we should fuzz the atapi code paths, which might contain vulnerabilities such as CVE-2020-29443. This patch adds hard-disk and cdrom generic-fuzzer configs for both the pc (PATA) and q35 (SATA) machine types.

[PULL 5/7] fuzz: add virtio-9p configurations for fuzzing

2021-01-20 Thread Alexander Bulekov
virtio-9p devices are often used to expose a virtual-filesystem to the guest. There have been some bugs reported in this device, such as CVE-2018-19364, and CVE-2021-20181. We should fuzz this device This patch adds two virtio-9p configurations: * One with the widely used -fsdev local driver.

Re: [PATCH v9 06/11] block: rename and alter bdrv_all_find_snapshot semantics

2021-01-20 Thread Eric Blake
On 1/20/21 4:44 AM, Daniel P. Berrangé wrote: > Currently bdrv_all_find_snapshot() will return 0 if it finds > a snapshot, -1 if an error occurs, or if it fails to find a > snapshot. New callers to be added want to distinguish between > the error scenario and failing to find a snapshot. > >

[PATCH 3/3] configure: Emit warning when accelerator requested but not needed

2021-01-20 Thread Philippe Mathieu-Daudé
In some configurations it might be pointless to check and compile accelerator code. Do not deselect the accelerator, but emit a warning. Signed-off-by: Philippe Mathieu-Daudé --- configure | 21 + 1 file changed, 21 insertions(+) diff --git a/configure b/configure index

[PULL 13/14] MAINTAINERS: Remove Ben Warren

2021-01-20 Thread Thomas Huth
From: John Snow Ben's email bounces and he no longer works for Skyport Systems. I was unable to reach Ben, so mark this section as Orphaned for now. Signed-off-by: John Snow Message-Id: <20201030153416.429791-2-js...@redhat.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 3 +-- 1 file

[PATCH 1/3] configure: Do not build TCG if not necessary

2021-01-20 Thread Philippe Mathieu-Daudé
We don't want to check/build TCG when no system/user emulation is requested. This is useful in particular when building only: - tools - documentation Signed-off-by: Philippe Mathieu-Daudé --- configure | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/configure

Re: [PATCH 3/3] vnc: support "-vnc help"

2021-01-20 Thread Eric Blake
On 1/20/21 8:42 AM, Paolo Bonzini wrote: > Use qemu_opts_parse_noisily now that HMP does not call > vnc_parse anymore. > > Signed-off-by: Paolo Bonzini > --- > include/ui/console.h | 2 +- > softmmu/vl.c | 6 +++--- > ui/vnc-stubs.c | 7 +++ > ui/vnc.c | 8

[PATCH v4] linux-user: add missing IPv6 get/setsockopt option

2021-01-20 Thread Philippe Mathieu-Daudé
From: Shu-Chun Weng IPV6_ADDR_PREFERENCES (RFC5014: Source address selection) was not supported. Signed-off-by: Shu-Chun Weng Reviewed-by: Laurent Vivier Message-Id: <20201218193213.3566856-4-...@google.com> [PMD: Add missing include for IPV6_ADDR_PREFERENCES] Signed-off-by: Philippe

Re: [PATCH v9 09/11] migration: introduce a delete_snapshot wrapper

2021-01-20 Thread Eric Blake
On 1/20/21 4:44 AM, Daniel P. Berrangé wrote: > Make snapshot deletion consistent with the snapshot save > and load commands by using a wrapper around the blockdev > layer. The main difference is that we get upfront validation > of the passed in device list (if any). > > Signed-off-by: Daniel P.

[PULL 4/7] docs/fuzz: add some information about OSS-Fuzz

2021-01-20 Thread Alexander Bulekov
Signed-off-by: Alexander Bulekov Reviewed-by: Darren Kenny --- docs/devel/fuzzing.rst | 26 ++ 1 file changed, 26 insertions(+) diff --git a/docs/devel/fuzzing.rst b/docs/devel/fuzzing.rst index 5f5200c843..b9bb07988b 100644 --- a/docs/devel/fuzzing.rst +++

[PULL 1/7] docs/fuzz: fix pre-meson path

2021-01-20 Thread Alexander Bulekov
Signed-off-by: Alexander Bulekov Reviewed-by: Thomas Huth --- docs/devel/fuzzing.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/devel/fuzzing.rst b/docs/devel/fuzzing.rst index 6096242d99..5f5200c843 100644 --- a/docs/devel/fuzzing.rst +++

[PULL 4/7] fuzz: log the arguments used to initialize QEMU

2021-01-20 Thread Alexander Bulekov
This is useful for building reproducers. Instead checking the code or the QEMU_FUZZ_ARGS, the arguments are at the top of the crash log. Signed-off-by: Alexander Bulekov Reviewed-by: Thomas Huth --- tests/qtest/fuzz/fuzz.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff

[PULL 6/7] fuzz: ignore address_space_map is_write flag

2021-01-20 Thread Alexander Bulekov
We passed an is_write flag to the fuzz_dma_read_cb function to differentiate between the mapped DMA regions that need to be populated with fuzzed data, and those that don't. We simply passed through the address_space_map is_write parameter. The goal was to cut down on unnecessarily populating

[PULL 5/7] fuzz: enable dynamic args for generic-fuzz configs

2021-01-20 Thread Alexander Bulekov
For some device configurations, it is useful to configure some resources, and adjust QEMU arguments at runtime, prior to fuzzing. This patch adds an "argfunc" to generic the generic_fuzz_config. When specified, it is responsible for configuring the resources and returning a string containing the

[PULL 05/14] elf2dmp: Rename PAGE_SIZE to ELF2DMP_PAGE_SIZE

2021-01-20 Thread Thomas Huth
From: Jiaxun Yang As per POSIX specification of limits.h [1], OS libc may define PAGE_SIZE in limits.h. To prevent collosion of definition, we rename PAGE_SIZE here. [1]: https://pubs.opengroup.org/onlinepubs/7908799/xsh/limits.h.html Signed-off-by: Jiaxun Yang Reviewed-by: Thomas Huth

[PULL 02/14] configure: Add sys/timex.h to probe clock_adjtime

2021-01-20 Thread Thomas Huth
From: Jiaxun Yang It is not a part of standard time.h. Glibc put it under time.h however musl treat it as a sys timex extension. Signed-off-by: Jiaxun Yang Reviewed-by: Thomas Huth Message-Id: <20210118063808.12471-2-jiaxun.y...@flygoat.com> Signed-off-by: Thomas Huth --- configure | 1 + 1

[PULL 12/14] tests: Fix memory leak in tpm-util.c

2021-01-20 Thread Thomas Huth
From: Stefan Berger This patch fixes the following memory leak detected by asan: Indirect leak of 560320 byte(s) in 136 object(s) allocated from: #0 0x556b3b3f9b57 in calloc (/home/stefanb/tmp/qemu-tip/build/tests/qtest/tpm-crb-swtpm-test+0x23fb57) #1 0x152b0e96b9b0 in g_malloc0

Re: [PATCH 1/3] hmp: remove "change vnc TARGET" command

2021-01-20 Thread Eric Blake
On 1/20/21 8:42 AM, Paolo Bonzini wrote: > The HMP command \"change vnc TARGET\" is messy: > > - it takes an ugly shortcut to determine if the option has an "id", > with incorrect results if "id=" is not preceded by an unescaped > comma. > > - it deletes the existing QemuOpts and does not try to

Re: qemu broke booting of old RedHat floppies

2021-01-20 Thread Alexander Bulekov
On 210120 1811, Michael Tokarev wrote: > As someone noticed on IRC, old (2.x) RedHat floppies does not boot > in current qemu. When qemu is booted from floppy image at > https://archive.org/details/RedHatLinuxBootDisk521998 > (download the "ISO image" link there, it really is an 1.44 floppy), >

[PULL 3/7] fuzz: enable dynamic args for generic-fuzz configs

2021-01-20 Thread Alexander Bulekov
For some device configurations, it is useful to configure some resources, and adjust QEMU arguments at runtime, prior to fuzzing. This patch adds an "argfunc" to generic the generic_fuzz_config. When specified, it is responsible for configuring the resources and returning a string containing the

[PULL 0/7] 2021-01-20 fuzzing patches

2021-01-20 Thread Alexander Bulekov
Hi Peter, The following changes since commit 48202c712412c803ddb56365c7bca322aa4e7506: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210119-1' into staging (2021-01-19 15:47:23 +) are available in the Git repository at: https://gitlab.com/a1xndr/qemu.git

[PULL 6/7] docs/fuzz: add some information about OSS-Fuzz

2021-01-20 Thread Alexander Bulekov
Signed-off-by: Alexander Bulekov Reviewed-by: Darren Kenny --- docs/devel/fuzzing.rst | 26 ++ 1 file changed, 26 insertions(+) diff --git a/docs/devel/fuzzing.rst b/docs/devel/fuzzing.rst index 5f5200c843..b9bb07988b 100644 --- a/docs/devel/fuzzing.rst +++

[PULL 0/7] 2021-01-20 fuzzing patches

2021-01-20 Thread Alexander Bulekov
Hi Peter, The following changes since commit 48202c712412c803ddb56365c7bca322aa4e7506: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210119-1' into staging (2021-01-19 15:47:23 +) are available in the Git repository at: https://gitlab.com/a1xndr/qemu.git

Re: [PATCH v9 02/11] migration: Make save_snapshot() return bool, not 0/-1

2021-01-20 Thread Eric Blake
On 1/20/21 4:44 AM, Daniel P. Berrangé wrote: > From: Philippe Mathieu-Daudé > > Just for consistency, following the example documented since > commit e3fe3988d7 ("error: Document Error API usage rules"), > return a boolean value indicating an error is set or not. > > Acked-by: Pavel Dovgalyuk

Re: [PATCH] target/arm: Implement ID_PFR2

2021-01-20 Thread Richard Henderson
On 1/19/21 5:52 PM, Richard Henderson wrote: > This was defined at some point before ARMv8.4, and will > shortly be used by new processor descriptions. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > > I've pulled this out of a largely defunct 2019 branch. This will

[Bug 1893040] Re: External modules retreval using Go1.15 on s390x appears to have checksum and ECDSA verification issues

2021-01-20 Thread David Hildenbrand
I remember we had these "ECDSA verification failure" issues in older QEMU versions, but these were fixed. I just tired building the go file under Fedora 32 running under latest upstream qemu-system-s390x, and using latest go binaries from https://golang.org/dl/: [root@atomic-00 hello]# uname -a

[PULL 00/14] gitlab-CI, qtests and misc patches

2021-01-20 Thread Thomas Huth
Hi Peter, the following changes since commit 48202c712412c803ddb56365c7bca322aa4e7506: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210119-1' into staging (2021-01-19 15:47:23 +) are available in the Git repository at: https://gitlab.com/huth/qemu.git

Re: [PATCH v2] fuzz: refine the ide/ahci fuzzer configs

2021-01-20 Thread Thomas Huth
On 20/01/2021 16.22, Alexander Bulekov wrote: Disks work differently depending on the x86 machine type (SATA vs PATA). Additionally, we should fuzz the atapi code paths, which might contain vulnerabilities such as CVE-2020-29443. This patch adds hard-disk and cdrom generic-fuzzer configs for

Re: [RFC PATCH 1/2] scsi/utils: Add INVALID_PARAM_VALUE sense code definition

2021-01-20 Thread Gerd Hoffmann
Hi, > > +/* Illegal request, Invalid value in parameter list */ > > +extern const struct SCSISense sense_code_INVALID_PARAM_VALUE; > Pre-existing: the term 'illegal' is suspect in computer science (the > code isn't breaking any laws); Indeed. It's named that way in the scsi specs though, and

Re: [PATCH v3 05/17] qapi: pass QAPISchemaModule to visit_module instead of str

2021-01-20 Thread Eric Blake
On 1/20/21 6:07 AM, Markus Armbruster wrote: > John Snow writes: > >> Modify visit_module to pass the module itself instead of just its >> name. This allows for future patches to centralize some >> module-interrogation behavior within the QAPISchemaModule class itself, >> cutting down on

Re: [PULL 3/5] linux-user: add missing IPv6 get/setsockopt option

2021-01-20 Thread Laurent Vivier
Le 20/01/2021 à 17:12, Philippe Mathieu-Daudé a écrit : > On 1/20/21 5:00 PM, Laurent Vivier wrote: >> Le 20/01/2021 à 13:16, Philippe Mathieu-Daudé a écrit : >>> On 1/19/21 6:54 PM, Laurent Vivier wrote: From: Shu-Chun Weng IPV6_ADDR_PREFERENCES (RFC5014: Source address selection)

Re: [PATCH v2 3/3] console: make QMP/HMP screendump run in coroutine

2021-01-20 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > On Wed, Jan 20, 2021 at 06:29:41PM +0400, Marc-André Lureau wrote: > > Hi Gerd > > > > On Wed, Jan 20, 2021 at 6:18 PM Gerd Hoffmann wrote: > > > > > > On Tue, Oct 27, 2020 at 05:36:02PM +0400, marcandre.lur...@redhat.com > > > wrote: > > > > From:

[PATCH 0/2] meson: Further cleanup of summary

2021-01-20 Thread Paolo Bonzini
Inspired by Philippe's "meson: Clarify summary" and based on it. Paolo Bonzini (2): meson: Summarize configurable features together meson: split the summary in multiple sections meson.build | 90 ++--- 1 file changed, 51 insertions(+), 39

[PULL 3/7] docs/fuzz: fix pre-meson path

2021-01-20 Thread Alexander Bulekov
Signed-off-by: Alexander Bulekov Reviewed-by: Thomas Huth --- docs/devel/fuzzing.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/devel/fuzzing.rst b/docs/devel/fuzzing.rst index 6096242d99..5f5200c843 100644 --- a/docs/devel/fuzzing.rst +++

[PULL 06/14] tests: Rename PAGE_SIZE definitions

2021-01-20 Thread Thomas Huth
From: Jiaxun Yang As per POSIX specification of limits.h [1], OS libc may define PAGE_SIZE in limits.h. Self defined PAGE_SIZE is frequently used in tests, to prevent collosion of definition, we give PAGE_SIZE definitons reasonable prefixs. [1]:

[PULL 14/14] MAINTAINERS: Make status spellings consistent

2021-01-20 Thread Thomas Huth
From: John Snow Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20201030153416.429791-3-js...@redhat.com> Signed-off-by: Thomas Huth --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH 2/3] configure: Do not build/check for capstone when emulation is disabled

2021-01-20 Thread Philippe Mathieu-Daudé
The capstone library is only used by system and user mode emulation. When it is not required, do not check for it. Signed-off-by: Philippe Mathieu-Daudé --- configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 012c527e3cd..a5159157a49 100755 ---

[PATCH v2 2/3] scsi/utils: Add INVALID_PARAM_VALUE sense code definition

2021-01-20 Thread Philippe Mathieu-Daudé
Reviewed-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé --- include/scsi/utils.h | 2 ++ scsi/utils.c | 5 + 2 files changed, 7 insertions(+) diff --git a/include/scsi/utils.h b/include/scsi/utils.h index 725769be3cb..504cde1cc9b 100644 --- a/include/scsi/utils.h +++

Re: [PATCH v3 10/17] qapi/gen: Combine ._add_[user|system]_module

2021-01-20 Thread John Snow
On 1/20/21 9:20 AM, Markus Armbruster wrote: John Snow writes: From: Markus Armbruster QAPISchemaModularCVisitor attempts to encapsulate the way it splits the module name space between user modules (name can't start with './') and system modules (name is None or starts with './') by Is

Re: [PATCH v2] fuzz: refine the ide/ahci fuzzer configs

2021-01-20 Thread Darren Kenny
On Wednesday, 2021-01-20 at 10:22:11 -05, Alexander Bulekov wrote: > Disks work differently depending on the x86 machine type (SATA vs PATA). > Additionally, we should fuzz the atapi code paths, which might contain > vulnerabilities such as CVE-2020-29443. This patch adds hard-disk and > cdrom

[PULL 3/7] docs/fuzz: fix pre-meson path

2021-01-20 Thread Alexander Bulekov
Signed-off-by: Alexander Bulekov Reviewed-by: Thomas Huth --- docs/devel/fuzzing.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/devel/fuzzing.rst b/docs/devel/fuzzing.rst index 6096242d99..5f5200c843 100644 --- a/docs/devel/fuzzing.rst +++

Re: [PATCH 0/3] configure: Do not build TCG or link with capstone if not necessary

2021-01-20 Thread Paolo Bonzini
On 20/01/21 18:02, Philippe Mathieu-Daudé wrote: For patch 1, which files are not compiled with the patch that were compiled without? softfloat. Really? I see this: specific_ss.add(when: 'CONFIG_TCG', if_true: files( 'fpu/softfloat.c', ...)) Maybe -subdir('fp') +if 'CONFIG_TCG' in

[PULL 1/7] fuzz: ignore address_space_map is_write flag

2021-01-20 Thread Alexander Bulekov
We passed an is_write flag to the fuzz_dma_read_cb function to differentiate between the mapped DMA regions that need to be populated with fuzzed data, and those that don't. We simply passed through the address_space_map is_write parameter. The goal was to cut down on unnecessarily populating

Re: [PATCH v9 02/11] migration: Make save_snapshot() return bool, not 0/-1

2021-01-20 Thread Eric Blake
On 1/20/21 12:46 PM, Eric Blake wrote: > On 1/20/21 4:44 AM, Daniel P. Berrangé wrote: >> From: Philippe Mathieu-Daudé >> >> Just for consistency, following the example documented since >> commit e3fe3988d7 ("error: Document Error API usage rules"), >> return a boolean value indicating an error

[PULL 11/14] qtest/npcm7xx_pwm-test: Fix memleak in pwm_qom_get

2021-01-20 Thread Thomas Huth
From: Gan Qixin The pwm_qom_get function didn't free "response", which caused an indirect memory leak. So use qobject_unref() to fix it. ASAN shows memory leak stack: Indirect leak of 7416 byte(s) in 18000 object(s) allocated from: #0 0x7f96e2f79d4e in __interceptor_calloc

[PULL 07/14] accel/kvm: avoid using predefined PAGE_SIZE

2021-01-20 Thread Thomas Huth
From: Jiaxun Yang As per POSIX specification of limits.h [1], OS libc may define PAGE_SIZE in limits.h. PAGE_SIZE is used in included kernel uapi headers. To prevent collosion of definition, we discard PAGE_SIZE from defined by libc and take QEMU's variable. [1]:

Re: [PATCH 2/3] qmp: remove deprecated "change" command

2021-01-20 Thread Philippe Mathieu-Daudé
On 1/20/21 3:42 PM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > docs/system/deprecated.rst | 5 > docs/system/removed-features.rst | 5 > monitor/qmp-cmds.c | 51 > qapi/misc.json | 49

[PATCH 0/3] configure: Do not build TCG or link with capstone if not necessary

2021-01-20 Thread Philippe Mathieu-Daudé
We do not need TCG and capstone all the times. In some configuration we can leave them out. Last patch emit a warning when a user explicitly select an accelerator that the build with not use. Philippe Mathieu-Daudé (3): configure: Do not build TCG if not necessary configure: Do not

[PATCH v2 0/3] hw/usb/dev-uas: Fix Clang 11 -Wgnu-variable-sized-type-not-at-end error

2021-01-20 Thread Philippe Mathieu-Daudé
Another attempt to fix the following Clang 11 warning: usb/dev-uas.c:157:31: error: field 'status' with variable sized type 'uas_i= u' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-vari= able-sized-type-not-at-end] uas_iustatus;

Re: [PATCH v2 1/3] scsi/utils: Rename 'illegal request' -> 'invalid request'

2021-01-20 Thread Eric Blake
On 1/20/21 9:35 AM, Philippe Mathieu-Daudé wrote: > While these requests are invalid, they are not breaking any laws :) > Rename 'illegal request' as 'invalid request'. > > Suggested-by: Eric Blake > Signed-off-by: Philippe Mathieu-Daudé > --- > include/scsi/utils.h | 20 ++-- >

Re: [PATCH v4 00/23] backup performance: block_status + async

2021-01-20 Thread Max Reitz
On 20.01.21 15:44, Max Reitz wrote: On 20.01.21 15:34, Max Reitz wrote: [...]  From a glance, it looks to me like two coroutines are created simultaneously in two threads, and so one thread sets up a special SIGUSR2 action, then another reverts SIGUSR2 to the default, and then the first

Re: eMMC support

2021-01-20 Thread Edgar Iglesias
On 20 Jan 2021 09:55, Cédric Le Goater wrote: > > On 9/17/20 8:25 AM, Cédric Le Goater wrote: > > On 9/17/20 2:55 AM, Joel Stanley wrote: > >> On Wed, 16 Sep 2020 at 18:35, Sai Pavan Boddu wrote: > >>> > >>> Hi Philippe, > >>> > >>> > >>> > >>> We are looking to add eMMC support, I searched the

Re: [PATCH 3/3] configure: Emit warning when accelerator requested but not needed

2021-01-20 Thread Thomas Huth
On 20/01/2021 16.19, Philippe Mathieu-Daudé wrote: In some configurations it might be pointless to check and compile accelerator code. Do not deselect the accelerator, but emit a warning. Signed-off-by: Philippe Mathieu-Daudé --- configure | 21 + 1 file changed, 21

Re: [PATCH v4 00/23] backup performance: block_status + async

2021-01-20 Thread Max Reitz
On 20.01.21 17:04, Daniel P. Berrangé wrote: On Wed, Jan 20, 2021 at 04:53:26PM +0100, Max Reitz wrote: On 20.01.21 15:44, Max Reitz wrote: On 20.01.21 15:34, Max Reitz wrote: [...]  From a glance, it looks to me like two coroutines are created simultaneously in two threads, and so one

Re: [PATCH 3/3] configure: Emit warning when accelerator requested but not needed

2021-01-20 Thread Philippe Mathieu-Daudé
On 1/20/21 5:33 PM, Thomas Huth wrote: > On 20/01/2021 16.19, Philippe Mathieu-Daudé wrote: >> In some configurations it might be pointless to check and >> compile accelerator code. Do not deselect the accelerator, >> but emit a warning. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>  

Re: [PATCH v9 08/11] migration: wire up support for snapshot device selection

2021-01-20 Thread Eric Blake
On 1/20/21 4:44 AM, Daniel P. Berrangé wrote: > Modify load_snapshot/save_snapshot to accept the device list and vmstate > node name parameters previously added to the block layer. > > Signed-off-by: Daniel P. Berrangé > --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer

[PULL 7/7] fuzz: refine the ide/ahci fuzzer configs

2021-01-20 Thread Alexander Bulekov
Disks work differently depending on the x86 machine type (SATA vs PATA). Additionally, we should fuzz the atapi code paths, which might contain vulnerabilities such as CVE-2020-29443. This patch adds hard-disk and cdrom generic-fuzzer configs for both the pc (PATA) and q35 (SATA) machine types.

[PULL 7/7] fuzz: add virtio-9p configurations for fuzzing

2021-01-20 Thread Alexander Bulekov
virtio-9p devices are often used to expose a virtual-filesystem to the guest. There have been some bugs reported in this device, such as CVE-2018-19364, and CVE-2021-20181. We should fuzz this device This patch adds two virtio-9p configurations: * One with the widely used -fsdev local driver.

[PATCH v2 1/3] scsi/utils: Rename 'illegal request' -> 'invalid request'

2021-01-20 Thread Philippe Mathieu-Daudé
While these requests are invalid, they are not breaking any laws :) Rename 'illegal request' as 'invalid request'. Suggested-by: Eric Blake Signed-off-by: Philippe Mathieu-Daudé --- include/scsi/utils.h | 20 ++-- scsi/utils.c | 20 ++-- 2 files changed,

Re: [PATCH v4 00/23] backup performance: block_status + async

2021-01-20 Thread Max Reitz
On 20.01.21 16:53, Max Reitz wrote: On 20.01.21 15:44, Max Reitz wrote: On 20.01.21 15:34, Max Reitz wrote: [...]  From a glance, it looks to me like two coroutines are created simultaneously in two threads, and so one thread sets up a special SIGUSR2 action, then another reverts SIGUSR2

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-20 Thread Matthew Rosato
On 1/20/21 9:45 AM, Pierre Morel wrote: On 1/20/21 3:03 PM, Matthew Rosato wrote: On 1/20/21 4:12 AM, Pierre Morel wrote: On 1/19/21 9:44 PM, Matthew Rosato wrote: Today, ISM devices are completely disallowed for vfio-pci passthrough as QEMU rejects the device due to an (inappropriate)

Re: [PULL 3/5] linux-user: add missing IPv6 get/setsockopt option

2021-01-20 Thread Laurent Vivier
Le 20/01/2021 à 13:16, Philippe Mathieu-Daudé a écrit : > On 1/19/21 6:54 PM, Laurent Vivier wrote: >> From: Shu-Chun Weng >> >> IPV6_ADDR_PREFERENCES (RFC5014: Source address selection) was not supported. >> >> Signed-off-by: Shu-Chun Weng >> Reviewed-by: Laurent Vivier >> Message-Id:

Re: [PATCH v2 3/3] console: make QMP/HMP screendump run in coroutine

2021-01-20 Thread Gerd Hoffmann
On Wed, Jan 20, 2021 at 06:29:41PM +0400, Marc-André Lureau wrote: > Hi Gerd > > On Wed, Jan 20, 2021 at 6:18 PM Gerd Hoffmann wrote: > > > > On Tue, Oct 27, 2020 at 05:36:02PM +0400, marcandre.lur...@redhat.com wrote: > > > From: Marc-André Lureau > > > > > > Thanks to the monitors' coroutine

Re: [PATCH v3 05/17] qapi: pass QAPISchemaModule to visit_module instead of str

2021-01-20 Thread John Snow
On 1/20/21 11:02 AM, Eric Blake wrote: On 1/20/21 6:07 AM, Markus Armbruster wrote: John Snow writes: Modify visit_module to pass the module itself instead of just its name. This allows for future patches to centralize some module-interrogation behavior within the QAPISchemaModule class

Re: [PATCH v2 1/3] scsi/utils: Rename 'illegal request' -> 'invalid request'

2021-01-20 Thread Eric Blake
On 1/20/21 10:15 AM, Gerd Hoffmann wrote: > On Wed, Jan 20, 2021 at 04:35:20PM +0100, Philippe Mathieu-Daudé wrote: >> While these requests are invalid, they are not breaking any laws :) >> Rename 'illegal request' as 'invalid request'. > > Given the scsi spec calls this "illegal request" I think

Re: [PATCH 0/3] configure: Do not build TCG or link with capstone if not necessary

2021-01-20 Thread Paolo Bonzini
On 20/01/21 16:19, Philippe Mathieu-Daudé wrote: We do not need TCG and capstone all the times. In some configuration we can leave them out. Last patch emit a warning when a user explicitly select an accelerator that the build with not use. Philippe Mathieu-Daudé (3): configure: Do not

Re: Thread safety of coroutine-sigaltstack

2021-01-20 Thread Eric Blake
On 1/20/21 10:26 AM, Max Reitz wrote: > Hi, > > I’ve run into trouble with Vladimir’s async backup series on MacOS, > namely that iotest 256 fails with qemu exiting because of a SIGUSR2. > > Turns out this is because MacOS (-xcode) uses coroutine-sigaltstack, > when I use this on Linux, I get

Re: [PULL 3/5] linux-user: add missing IPv6 get/setsockopt option

2021-01-20 Thread Laurent Vivier
Le 20/01/2021 à 17:56, Philippe Mathieu-Daudé a écrit : > On 1/20/21 5:22 PM, Laurent Vivier wrote: >> Le 20/01/2021 à 17:12, Philippe Mathieu-Daudé a écrit : >>> On 1/20/21 5:00 PM, Laurent Vivier wrote: Le 20/01/2021 à 13:16, Philippe Mathieu-Daudé a écrit : > On 1/19/21 6:54 PM,

Re: Thread safety of coroutine-sigaltstack

2021-01-20 Thread Laszlo Ersek
On 01/20/21 17:26, Max Reitz wrote: > Hi, > > I’ve run into trouble with Vladimir’s async backup series on MacOS, > namely that iotest 256 fails with qemu exiting because of a SIGUSR2. > > Turns out this is because MacOS (-xcode) uses coroutine-sigaltstack, > when I use this on Linux, I get the

[PATCH 2/2] meson: split the summary in multiple sections

2021-01-20 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- meson.build | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/meson.build b/meson.build index 75ce835d48..3d2ac1a399 100644 --- a/meson.build +++ b/meson.build @@ -2238,9 +2238,8 @@ endif # Configuration summary #

[PATCH 1/2] meson: Summarize configurable features together

2021-01-20 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- meson.build | 74 +++-- 1 file changed, 38 insertions(+), 36 deletions(-) diff --git a/meson.build b/meson.build index 1d27f1b8bb..75ce835d48 100644 --- a/meson.build +++ b/meson.build @@ -2338,11 +2338,6 @@ if

[PULL 4/7] fuzz: log the arguments used to initialize QEMU

2021-01-20 Thread Alexander Bulekov
This is useful for building reproducers. Instead checking the code or the QEMU_FUZZ_ARGS, the arguments are at the top of the crash log. Signed-off-by: Alexander Bulekov Reviewed-by: Thomas Huth --- tests/qtest/fuzz/fuzz.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff

Re: [PULL 0/7] 2021-01-20 fuzzing patches

2021-01-20 Thread Alexander Bulekov
Nack On 210120 1235, Alexander Bulekov wrote: > Hi Peter, > > The following changes since commit 48202c712412c803ddb56365c7bca322aa4e7506: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20210119-1' into staging (2021-01-19 > 15:47:23 +) > > are available in

Re: [PATCH v9 11/11] migration: introduce snapshot-{save, load, delete} QMP commands

2021-01-20 Thread Eric Blake
On 1/20/21 4:44 AM, Daniel P. Berrangé wrote: > savevm, loadvm and delvm are some of the few HMP commands that have never > been converted to use QMP. The reasons for the lack of conversion are > that they blocked execution of the event thread, and the semantics > around choice of disks were

[PULL 04/14] hw/block/nand: Rename PAGE_SIZE to NAND_PAGE_SIZE

2021-01-20 Thread Thomas Huth
From: Jiaxun Yang As per POSIX specification of limits.h [1], OS libc may define PAGE_SIZE in limits.h. To prevent collosion of definition, we rename PAGE_SIZE here. [1]: https://pubs.opengroup.org/onlinepubs/7908799/xsh/limits.h.html Signed-off-by: Jiaxun Yang Reviewed-by: Thomas Huth

[PULL 10/14] gitlab-ci: Add alpine to pipeline

2021-01-20 Thread Thomas Huth
From: Jiaxun Yang [thuth: Enable "make check" tests, too, after tests/check-block.sh got fixed] Signed-off-by: Jiaxun Yang Message-Id: <20210118063808.12471-10-jiaxun.y...@flygoat.com> Signed-off-by: Thomas Huth --- .gitlab-ci.d/containers.yml | 5 + .gitlab-ci.yml | 33

[PULL 08/14] tests/docker: Add dockerfile for Alpine Linux

2021-01-20 Thread Thomas Huth
From: Jiaxun Yang Alpine Linux[1] is a security-oriented, lightweight Linux distribution based on musl libc and busybox. It it popular among Docker guests and embedded applications. Adding it to test against different libc. [1]: https://alpinelinux.org/ Signed-off-by: Jiaxun Yang

Re: qemu broke booting of old RedHat floppies

2021-01-20 Thread Michael Tokarev
20.01.2021 18:11, Michael Tokarev wrote: .. Now, I don't even know where to put that "type=144/288/auto" thing, I tried this:  -drive file=RedHatLinuxBootDisk521998.disk1of1.img,if=floppy,format=raw,type=144 but it says that format=raw does not support "type=144" option. So I found this:

[PATCH v2] fuzz: refine the ide/ahci fuzzer configs

2021-01-20 Thread Alexander Bulekov
Disks work differently depending on the x86 machine type (SATA vs PATA). Additionally, we should fuzz the atapi code paths, which might contain vulnerabilities such as CVE-2020-29443. This patch adds hard-disk and cdrom generic-fuzzer configs for both the pc (PATA) and q35 (SATA) machine types.

Re: [PATCH 0/9] meson: Clarify summary

2021-01-20 Thread Paolo Bonzini
On 19/01/21 19:49, Philippe Mathieu-Daudé wrote: Reorder stuffs in summary to quicker understand bug reports. Remove information from deselected features when not necessary. Philippe Mathieu-Daudé (9): meson: Summarize generic information first meson: Summarize compilation information

Re: [PATCH 0/3] configure: Do not build TCG or link with capstone if not necessary

2021-01-20 Thread Philippe Mathieu-Daudé
On 1/20/21 5:46 PM, Paolo Bonzini wrote: > On 20/01/21 16:19, Philippe Mathieu-Daudé wrote: >> We do not need TCG and capstone all the times. In some >> configuration we can leave them out. >> >> Last patch emit a warning when a user explicitly select an >> accelerator that the build with not use.

[PULL 2/7] fuzz: refine the ide/ahci fuzzer configs

2021-01-20 Thread Alexander Bulekov
Disks work differently depending on the x86 machine type (SATA vs PATA). Additionally, we should fuzz the atapi code paths, which might contain vulnerabilities such as CVE-2020-29443. This patch adds hard-disk and cdrom generic-fuzzer configs for both the pc (PATA) and q35 (SATA) machine types.

[PULL 2/7] fuzz: log the arguments used to initialize QEMU

2021-01-20 Thread Alexander Bulekov
This is useful for building reproducers. Instead checking the code or the QEMU_FUZZ_ARGS, the arguments are at the top of the crash log. Signed-off-by: Alexander Bulekov Reviewed-by: Thomas Huth --- tests/qtest/fuzz/fuzz.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff

[PULL 1/7] fuzz: ignore address_space_map is_write flag

2021-01-20 Thread Alexander Bulekov
We passed an is_write flag to the fuzz_dma_read_cb function to differentiate between the mapped DMA regions that need to be populated with fuzzed data, and those that don't. We simply passed through the address_space_map is_write parameter. The goal was to cut down on unnecessarily populating

[PULL 7/7] fuzz: add virtio-9p configurations for fuzzing

2021-01-20 Thread Alexander Bulekov
virtio-9p devices are often used to expose a virtual-filesystem to the guest. There have been some bugs reported in this device, such as CVE-2018-19364, and CVE-2021-20181. We should fuzz this device This patch adds two virtio-9p configurations: * One with the widely used -fsdev local driver.

Re: [PATCH] qmp-shell: Suppress banner and prompt when stdin is not a TTY

2021-01-20 Thread Dov Murik
On 20/01/2021 17:46, John Snow wrote: On 1/20/21 4:45 AM, Daniel P. Berrangé wrote: On Wed, Jan 20, 2021 at 10:25:25AM +0200, Dov Murik wrote: Hi John, On 19/01/2021 22:02, John Snow wrote: On 1/17/21 2:27 AM, Dov Murik wrote: Detect whether qmp-shell's standard input is not a TTY; in

Re: [PATCH] runstate: cleanup reboot and panic actions

2021-01-20 Thread Alejandro Jimenez
On 1/20/2021 9:37 AM, Paolo Bonzini wrote: The possible choices for panic, reset and watchdog actions are inconsistent. "-action panic=poweroff" should be renamed to "-action panic=shutdown" on the command line. This is because "-action panic=poweroff" and "-action watchdog=poweroff" have

Re: [PATCH v3 18/19] i386: provide simple 'hv-default=on' option

2021-01-20 Thread Igor Mammedov
On Wed, 20 Jan 2021 15:38:33 +0100 Vitaly Kuznetsov wrote: > Igor Mammedov writes: > > > On Fri, 15 Jan 2021 10:20:23 +0100 > > Vitaly Kuznetsov wrote: > > > >> Igor Mammedov writes: > >> > >> > On Thu, 7 Jan 2021 16:14:49 +0100 > >> > Vitaly Kuznetsov wrote: > >> > > >> >>

[PULL 09/14] tests/check-block.sh: Refuse to run the iotests with BusyBox' sed

2021-01-20 Thread Thomas Huth
BusyBox' sed reports itself as "This is not GNU sed version 4.0" when being run with the --version parameter. However, the iotests really need GNU sed, they do not work with the BusyBox version. So let's make sure that we really have GNU sed and refuse to run the tests with BusyBox' sed.

  1   2   3   4   >