Re: [PATCH 10/25] hmp: special case help options for object_add

2021-01-25 Thread Markus Armbruster
Paolo Bonzini writes: > On 25/01/21 13:48, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> Fix "object_add help" and "object_add TYPE,help". >>> >>> Signed-off-by: Paolo Bonzini >> Standard question when I read "Fix $interface" in a commit message: >> how >> exactly is it broken? > >

Re: [PATCH 11/25] remove -writeconfig

2021-01-25 Thread Daniel P . Berrangé
On Mon, Jan 25, 2021 at 03:01:01PM +0100, Paolo Bonzini wrote: > On 25/01/21 13:53, Markus Armbruster wrote: > > I love the "and how give me a config file for all that" idea, but I > > agree our -writeconfig is flawed. I hope we can bring it back in more > > useful shape. > > > > No deprecation

Re: How to check when "raw" format driver uses a "regular" file?

2021-01-25 Thread Peter Maydell
On Mon, 25 Jan 2021 at 16:03, Philippe Mathieu-Daudé wrote: > The problem is when emulating devices such NOR Flash (parallel mapping > or SD cards) we expect the block driver being a plain file (either "raw" > format or another) but a "regular" file. When an user passes something > else like a

Re: [PATCH v2] configure: Only build s390-ccw BIOS when system emulation is built

2021-01-25 Thread Thomas Huth
On 25/01/2021 16.37, Philippe Mathieu-Daudé wrote: It is pointless to build the s390-ccw BIOS when only user-mode emulation is built. Only build it when s390 system mode emulation is selected. Signed-off-by: Philippe Mathieu-Daudé --- v2: Restrict to s390x-softmmu (thuth) We could move the

Re: [PATCH v20 08/20] io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all helpers

2021-01-25 Thread Daniel P . Berrangé
On Tue, Jan 19, 2021 at 03:28:25PM -0500, Jagannathan Raman wrote: > From: Elena Ufimtseva > > Adds qio_channel_readv_full_all_eof() and qio_channel_readv_full_all() > to read both data and FDs. Refactors existing code to use these helpers. > > Signed-off-by: Elena Ufimtseva > Signed-off-by:

Re: [PATCH v9 02/11] migration: Make save_snapshot() return bool, not 0/-1

2021-01-25 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > From: Philippe Mathieu-Daudé > > Just for consistency, following the example documented since > commit e3fe3988d7 ("error: Document Error API usage rules"), > return a boolean value indicating an error is set or not. > > Acked-by: Pavel

Re: [PATCH] virtio: Add corresponding memory_listener_unregister to unrealize

2021-01-25 Thread Peter Xu
On Mon, Jan 25, 2021 at 05:55:35PM +0100, Eugenio Perez Martin wrote: > On Mon, Jan 25, 2021 at 4:15 AM Jason Wang wrote: > > > > > > On 2021/1/23 上午4:08, Eugenio Pérez wrote: > > > Cannot destroy address spaces of IOMMU-aware virtio devices without it, > > > since they can contain memory

Re: [PATCH] hw/mips: loongson3: Drop 'struct MemmapEntry'

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/22/21 1:24 PM, Bin Meng wrote: > From: Bin Meng > > There is already a MemMapEntry type defined in hwaddr.h. Let's drop > the loongson3 defined `struct MemmapEntry` and use the existing one. > > Signed-off-by: Bin Meng > --- > > hw/mips/loongson3_bootp.h | 7 +-- >

Re: [PATCH 1/4] hw/riscv: Drop 'struct MemmapEntry'

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/22/21 1:29 PM, Bin Meng wrote: > From: Bin Meng > > There is already a MemMapEntry type defined in hwaddr.h. Let's drop > the RISC-V defined `struct MemmapEntry` and use the existing one. > > Signed-off-by: Bin Meng > --- > > hw/riscv/microchip_pfsoc.c | 9 +++-- >

[PATCH 3/6] vhost-user: Return error code from slave_read()

2021-01-25 Thread Vivek Goyal
Right now slave_read() is called through main event loop and does not return error. In next few patches I want to call slave_read() from vhost device shutdown path as well and want to know if an error happened so that caller can give up and return error accordingly. Hence, create helper function

Re: [PATCH 0/3] hw/block/nvme: misc fixes

2021-01-25 Thread Klaus Jensen
On Jan 25 10:02, Keith Busch wrote: > On Mon, Jan 25, 2021 at 09:22:24AM +0100, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Misc fixes from Gollu. > > Looks good. > > Reviewed-by: Keith Busch Thanks, applied! signature.asc Description: PGP signature

[RESEND PULL 4/7] fuzz: log the arguments used to initialize QEMU

2021-01-25 Thread Alexander Bulekov
This is useful for building reproducers. Instead checking the code or the QEMU_FUZZ_ARGS, the arguments are at the top of the crash log. Signed-off-by: Alexander Bulekov Reviewed-by: Thomas Huth Message-Id: <20210117201014.271610-3-alx...@bu.edu> --- tests/qtest/fuzz/fuzz.c | 11 ++- 1

[RESEND PULL 2/7] fuzz: refine the ide/ahci fuzzer configs

2021-01-25 Thread Alexander Bulekov
Disks work differently depending on the x86 machine type (SATA vs PATA). Additionally, we should fuzz the atapi code paths, which might contain vulnerabilities such as CVE-2020-29443. This patch adds hard-disk and cdrom generic-fuzzer configs for both the pc (PATA) and q35 (SATA) machine types.

[RESEND PULL 6/7] docs/fuzz: add some information about OSS-Fuzz

2021-01-25 Thread Alexander Bulekov
Signed-off-by: Alexander Bulekov Reviewed-by: Darren Kenny Message-Id: <20210117230924.449676-3-alx...@bu.edu> --- docs/devel/fuzzing.rst | 26 ++ 1 file changed, 26 insertions(+) diff --git a/docs/devel/fuzzing.rst b/docs/devel/fuzzing.rst index 5f5200c843..b9bb07988b

[PATCH v9 3/6] iotests: add testenv.py

2021-01-25 Thread Vladimir Sementsov-Ogievskiy
Add TestEnv class, which will handle test environment in a new python iotests running framework. Don't add compat=1.1 for qcow2 IMGOPTS, as v3 is default anyway. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/testenv.py | 279 ++ 1 file

[PATCH v9 5/6] iotests: rewrite check into python

2021-01-25 Thread Vladimir Sementsov-Ogievskiy
Just use classes introduced in previous three commits. Behavior difference is described in these three commits. Drop group file, as it becomes unused. Drop common.env: now check is in python, and for tests we use same python interpreter that runs the check itself. Use build environment PYTHON in

Re: [PATCH v5 2/6] sev/i386: Require in-kernel irqchip support for SEV-ES guests

2021-01-25 Thread Dr. David Alan Gilbert
* Tom Lendacky (thomas.lenda...@amd.com) wrote: > From: Tom Lendacky > > In prep for AP booting, require the use of in-kernel irqchip support. This > lessens the Qemu support burden required to boot APs. > > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Signed-off-by: Tom

Re: [PATCH 0/3] hw/block/nvme: misc fixes

2021-01-25 Thread Keith Busch
On Mon, Jan 25, 2021 at 09:22:24AM +0100, Klaus Jensen wrote: > From: Klaus Jensen > > Misc fixes from Gollu. Looks good. Reviewed-by: Keith Busch

[PATCH 5/6] libvhost-user: Add support to start/stop/flush slave channel

2021-01-25 Thread Vivek Goyal
This patch adds support to start/stop/flush slave channel functionality. Signed-off-by: Vivek Goyal --- subprojects/libvhost-user/libvhost-user.c | 103 -- subprojects/libvhost-user/libvhost-user.h | 8 +- 2 files changed, 105 insertions(+), 6 deletions(-) diff --git

Re: [Qemu-devel][PATCH] x86/cpu: Use max host physical address if -cpu max option is applied

2021-01-25 Thread Nathan Chancellor
On Mon, Jan 25, 2021 at 11:42:43AM +0100, Paolo Bonzini wrote: > On 25/01/21 08:10, Nathan Chancellor wrote: > > > > This patch as commit 5a140b255d ("x86/cpu: Use max host physical address > > > > if -cpu max option is applied") prevents me from using '-cpu host' while > > > > booting an

Re: [PATCH v5 1/6] sev/i386: Add initial support for SEV-ES

2021-01-25 Thread Dr. David Alan Gilbert
* Tom Lendacky (thomas.lenda...@amd.com) wrote: > From: Tom Lendacky > > Provide initial support for SEV-ES. This includes creating a function to > indicate the guest is an SEV-ES guest (which will return false until all > support is in place), performing the proper SEV initialization and >

[RESEND PULL 1/7] fuzz: ignore address_space_map is_write flag

2021-01-25 Thread Alexander Bulekov
We passed an is_write flag to the fuzz_dma_read_cb function to differentiate between the mapped DMA regions that need to be populated with fuzzed data, and those that don't. We simply passed through the address_space_map is_write parameter. The goal was to cut down on unnecessarily populating

[PATCH v9 6/6] iotests: rename and move 169 and 199 tests

2021-01-25 Thread Vladimir Sementsov-Ogievskiy
Rename bitmaps migration tests and move them to tests subdirectory to demonstrate new human-friendly test naming. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/{199 => tests/migrate-bitmaps-postcopy-test} | 0 .../{199.out => tests/migrate-bitmaps-postcopy-test.out}

[PATCH v9 1/6] iotests: 146: drop extra whitespaces from .out file

2021-01-25 Thread Vladimir Sementsov-Ogievskiy
check script will be stricter soon about whitespaces, so fix 146.out now. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/146.out | 780 ++--- 1 file changed, 390 insertions(+), 390 deletions(-) diff --git a/tests/qemu-iotests/146.out

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-25 Thread Stefan Weil
Am 25.01.21 um 18:05 schrieb Philippe Mathieu-Daudé: On 1/25/21 5:47 PM, Daniel P. Berrangé wrote: On Mon, Jan 25, 2021 at 03:45:30PM +0100, Philippe Mathieu-Daudé wrote: Some new users get confused with 'TCG' and 'TCI', and enable TCI support expecting to enable TCG. Emit a warning when

Re: [PATCH] virtio: Add corresponding memory_listener_unregister to unrealize

2021-01-25 Thread Eugenio Perez Martin
On Mon, Jan 25, 2021 at 6:18 PM Peter Xu wrote: > > On Mon, Jan 25, 2021 at 05:55:35PM +0100, Eugenio Perez Martin wrote: > > On Mon, Jan 25, 2021 at 4:15 AM Jason Wang wrote: > > > > > > > > > On 2021/1/23 上午4:08, Eugenio Pérez wrote: > > > > Cannot destroy address spaces of IOMMU-aware virtio

Re: [PATCH 0/2] trace: make the 'log' backend timestamp configurable

2021-01-25 Thread Philippe Mathieu-Daudé
Hi Stefan, On 1/25/21 12:35 PM, Stefan Hajnoczi wrote: > Zoltan reminded me that the 'log' backend prints tids/timestamps and this can > be unwanted in some cases. It's easier to look at trace output without them > and > in some cases parsing is also more convenient with them. > > Extend -msg

Re: configure does not detect librados or librbd since the switch to meson

2021-01-25 Thread Paolo Bonzini
On 25/01/21 15:31, Peter Lieven wrote: on Dedian / Ubuntu configure does no longer detect librbd / librados since the switch to meson. I need to add dirs: ['/usr/lib'] to the cc.find_library for librados and librbd. But I am not familiar with meson and can't say if thats the appropriate fix.

Re: [PATCH] net/slirp.c: Fix spelling error in error message

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/22/21 1:42 AM, dje--- via wrote: > DNS should be DHCP > > Signed-off-by: Doug Evans > --- > net/slirp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH 0/3] Drop deprecated floppy config & bogus -drive if=T

2021-01-25 Thread Markus Armbruster
Markus Armbruster (3): fdc: Drop deprecated floppy configuration fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common() blockdev: Drop deprecated bogus -drive interface type docs/system/deprecated.rst | 33 -- docs/system/removed-features.rst | 33 ++

Re: [PATCH v2] configure: Only build s390-ccw BIOS when system emulation is built

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/25/21 5:29 PM, Thomas Huth wrote: > On 25/01/2021 16.37, Philippe Mathieu-Daudé wrote: >> It is pointless to build the s390-ccw BIOS when only user-mode >> emulation is built. Only build it when s390 system mode emulation >> is selected. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >>

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-25 Thread Daniel P . Berrangé
On Mon, Jan 25, 2021 at 03:45:30PM +0100, Philippe Mathieu-Daudé wrote: > Some new users get confused with 'TCG' and 'TCI', and enable TCI > support expecting to enable TCG. > > Emit a warning when native TCG backend is available on the > host architecture, mentioning this is a suboptimal

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/25/21 5:47 PM, Daniel P. Berrangé wrote: > On Mon, Jan 25, 2021 at 03:45:30PM +0100, Philippe Mathieu-Daudé wrote: >> Some new users get confused with 'TCG' and 'TCI', and enable TCI >> support expecting to enable TCG. >> >> Emit a warning when native TCG backend is available on the >> host

[PATCH 6/6] virtiofsd: Opt in for slave start/stop/shutdown functionality

2021-01-25 Thread Vivek Goyal
This is an opt-in feature not enabled by default. Enable it in protocol features by setting VHOST_USER_PROTOCOL_F_SLAVE_CH_START_STOP. Signed-off-by: Vivek Goyal --- tools/virtiofsd/fuse_virtio.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/virtiofsd/fuse_virtio.c

[PATCH 2/6] libvhost-user: Use slave_mutex in all slave messages

2021-01-25 Thread Vivek Goyal
dev->slave_mutex needs to be taken when sending messages on slave_fd. Currently _vu_queue_notify() does not do that. Introduce a helper vu_message_slave_send_receive() which sends as well as receive response. Use this helper in all the paths which send message on slave_fd channel. Signed-off-by:

[PATCH 4/6] qemu, vhost-user: Extend protocol to start/stop/flush slave channel

2021-01-25 Thread Vivek Goyal
Currently we don't have a mechanism to flush slave channel while shutting down vhost-user device and that can result a deadlock. Consider following scenario. 1. Slave gets a request from guest on virtqueue (say index 1, vq1), to map a portion of file in qemu address space. 2. Thread serving

Re: [PATCH V6 4/6] hw/block/nvme: support for multi-controller in subsystem

2021-01-25 Thread Klaus Jensen
On Jan 24 11:54, Minwoo Im wrote: > We have nvme-subsys and nvme devices mapped together. To support > multi-controller scheme to this setup, controller identifier(id) has to > be managed. Earlier, cntlid(controller id) used to be always 0 because > we didn't have any subsystem scheme that

Re: [PATCH V6 4/6] hw/block/nvme: support for multi-controller in subsystem

2021-01-25 Thread Keith Busch
On Mon, Jan 25, 2021 at 07:03:32PM +0100, Klaus Jensen wrote: > On Jan 24 11:54, Minwoo Im wrote: > > We have nvme-subsys and nvme devices mapped together. To support > > multi-controller scheme to this setup, controller identifier(id) has to > > be managed. Earlier, cntlid(controller id) used

Re: [RESEND PULL 0/4] Net patches

2021-01-25 Thread Peter Maydell
On Mon, 25 Jan 2021 at 12:23, Jason Wang wrote: > > The following changes since commit e81eb5e6d108008445821e4f891fb9563016c71b: > > Merge remote-tracking branch 'remotes/bonzini-gitlab/tags/for-upstream' > into staging (2021-01-23 22:34:21 +) > > are available in the git repository at: >

Re: [PATCH v2] target/mips: fetch code with translator_ld

2021-01-25 Thread Richard Henderson
On 1/25/21 12:58 AM, Philippe Mathieu-Daudé wrote: > Similarly to commits ae82adc8e29..7f93879e444, use the > translator_ld*() API introduced in commit 409c1a0bf0f > to fetch the code on the MIPS target. > > Reviewed-by: Jiaxun Yang > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Restrict

[Bug 1912065] Re: Segfaults in tcg/optimize.c:212 after commit 7c79721606be11b5bc556449e5bcbc331ef6867d

2021-01-25 Thread Richard Henderson
** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1912065 Title: Segfaults in tcg/optimize.c:212 after commit

[RESEND PULL 5/7] fuzz: enable dynamic args for generic-fuzz configs

2021-01-25 Thread Alexander Bulekov
For some device configurations, it is useful to configure some resources, and adjust QEMU arguments at runtime, prior to fuzzing. This patch adds an "argfunc" to generic the generic_fuzz_config. When specified, it is responsible for configuring the resources and returning a string containing the

[PATCH v9 0/6] Rework iotests/check

2021-01-25 Thread Vladimir Sementsov-Ogievskiy
v9: 01: new, one more whitespace-fixing patch testenv: allow case when we don't have system-arch emulator, but have several for another architectures change direct os.access(..., os.X_OK) calls to new helper function which also check that path is a file testrunner: s/fail/not run/ for

[PATCH v9 4/6] iotests: add testrunner.py

2021-01-25 Thread Vladimir Sementsov-Ogievskiy
Add TestRunner class, which will run tests in a new python iotests running framework. There are some differences with current ./check behavior, most significant are: - Consider all tests self-executable, just run them, don't run python by hand. - Elapsed time is cached in json file - Elapsed

[RESEND PULL 7/7] fuzz: add virtio-9p configurations for fuzzing

2021-01-25 Thread Alexander Bulekov
virtio-9p devices are often used to expose a virtual-filesystem to the guest. There have been some bugs reported in this device, such as CVE-2018-19364, and CVE-2021-20181. We should fuzz this device This patch adds two virtio-9p configurations: * One with the widely used -fsdev local driver.

Re: [PULL 0/7] 2021-01-20 fuzzing patches

2021-01-25 Thread Alexander Bulekov
On 210122 1506, Peter Maydell wrote: > On Wed, 20 Jan 2021 at 17:45, Alexander Bulekov wrote: > > > > Hi Peter, > > > > The following changes since commit 48202c712412c803ddb56365c7bca322aa4e7506: > > > > Merge remote-tracking branch > > 'remotes/pmaydell/tags/pull-target-arm-20210119-1' into

[RESEND PULL 0/7] 2021-01-25 Fuzzing Patches

2021-01-25 Thread Alexander Bulekov
Hi Paolo, The following changes since commit 3dcfd4e3f285cd69d7cf581d3a688e421d28e07e: Merge remote-tracking branch 'remotes/gkurz-gitlab/tags/9p-next-pull-request' into staging (2021-01-25 13:48:38 +) are available in the Git repository at: https://gitlab.com/a1xndr/qemu.git

Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/11/21 11:28 AM, BALATON Zoltan wrote: > On Mon, 11 Jan 2021, Jiaxun Yang wrote: >> On Mon, Jan 11, 2021, at 3:25 AM, BALATON Zoltan wrote: >>> On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote: +PCI experts On 1/10/21 1:43 AM, BALATON Zoltan wrote: > On Sun, 10 Jan 2021,

[PATCH 1/6] virtiofsd: Drop ->vu_dispatch_rwlock while waiting for thread to exit

2021-01-25 Thread Vivek Goyal
When we are shutting down virtqueues, virtio_loop() receives a message VHOST_USER_GET_VRING_BASE from master. We acquire ->vu_dispatch_rwlock and get into the process of shutting down virtqueue. In one of the final steps, we are waiting for fv_queue_thread() to exit/finish and wait with

[RFC PATCH 0/6] vhost-user: Shutdown/Flush slave channel properly

2021-01-25 Thread Vivek Goyal
Hi, We are working on DAX support in virtiofs and have some patches out of the tree hosted here. https://gitlab.com/virtio-fs/qemu/-/commits/virtio-fs-dev These patches have not been proposed for merge yet, becasue David Gilbert noticed that we can run into a deadlock during an emergency reboot

[RESEND PULL 3/7] docs/fuzz: fix pre-meson path

2021-01-25 Thread Alexander Bulekov
Signed-off-by: Alexander Bulekov Reviewed-by: Thomas Huth Message-Id: <20210117201014.271610-2-alx...@bu.edu> --- docs/devel/fuzzing.rst | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/devel/fuzzing.rst b/docs/devel/fuzzing.rst index 6096242d99..5f5200c843 100644

[PATCH v9 2/6] iotests: add findtests.py

2021-01-25 Thread Vladimir Sementsov-Ogievskiy
Add python script with new logic of searching for tests: Current ./check behavior: - tests are named [0-9][0-9][0-9] - tests must be registered in group file (even if test doesn't belong to any group, like 142) Behavior of findtests.py: - group file is dropped - tests are all files in

Re: [PATCH v2 05/12] meson: Restrict block subsystem processing

2021-01-25 Thread Paolo Bonzini
Another possibility is to place the if in block/meson.build, using subdir_done() to stop the processing of the directory. Paolo Il lun 25 gen 2021, 13:15 Kevin Wolf ha scritto: > Am 22.01.2021 um 21:44 hat Philippe Mathieu-Daudé geschrieben: > > Avoid generating module_block.h and block-gen.c

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-25 Thread Richard Henderson
On 1/25/21 8:58 AM, Stefan Weil wrote: > I have no evidence that TCI is less reliable than TCG, so I would not write > that. It can't pass make check-tcg. r~

[PATCH v4 0/4] meson: Try to clarify TCG / TCI options for new users

2021-01-25 Thread Philippe Mathieu-Daudé
Since v3: - Rebased - Include fix for 23a77b2d18b ("build-system: clean up TCG/TCI configury") - Use get_option() (Claudio) - Use warning message suggested by Daniel - Drop 'Reword --enable-tcg-interpreter as --disable-native-tcg' (Paolo) Some new users get confused between 'TCG' and 'TCI' and

Re: [PATCH] hw/scsi/megasas: check for NULL frame in megasas_command_cancelled()

2021-01-25 Thread Philippe Mathieu-Daudé
You forgot to Cc the subsystem maintainers... ./scripts/get_maintainer.pl -f hw/scsi/megasas.c Hannes Reinecke (supporter:megasas) Paolo Bonzini (supporter:SCSI) Fam Zheng (reviewer:SCSI) On 1/25/21 3:22 PM, Mauro Matteo Cascella wrote: > Hello, > > Any updates on this little patch? Please

Re: [PATCH 0/8] s390x/pci: Fixing s390 vfio-pci ISM support

2021-01-25 Thread Matthew Rosato
On 1/22/21 11:46 AM, Cornelia Huck wrote: On Thu, 21 Jan 2021 13:06:24 -0500 Matthew Rosato wrote: On 1/21/21 12:50 PM, Cornelia Huck wrote: On Thu, 21 Jan 2021 15:54:22 +0100 Niklas Schnelle wrote: On 1/21/21 3:46 PM, Pierre Morel wrote: On 1/21/21 2:37 PM, Niklas Schnelle wrote:

Re: [PATCH] replay: fix replay of the interrupts

2021-01-25 Thread Claudio Fontana
On 1/25/21 3:26 PM, Alex Bennée wrote: > > Claudio Fontana writes: > >> On 1/25/21 1:43 PM, Claudio Fontana wrote: >>> On 1/25/21 1:12 PM, Alex Bennée wrote: Paolo Bonzini writes: > In general I agree, but != means that rr disabled returns true. In general > it seems to

Re: [PATCH v2 2/2] net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/25/21 6:07 AM, Jason Wang wrote: > > On 2021/1/15 下午11:11, Philippe Mathieu-Daudé wrote: >> QEMU fuzzer reported a buffer overflow in _eth_get_rss_ex_dst_addr() >> reproducible as: > > > Want to apply but it doesn't apply on master: > > Applying: net/eth: Fix stack-buffer-overflow in

Re: How to check when "raw" format driver uses a "regular" file?

2021-01-25 Thread Kevin Wolf
Am 25.01.2021 um 17:01 hat Philippe Mathieu-Daudé geschrieben: > On 1/25/21 4:43 PM, Kevin Wolf wrote: > > Am 25.01.2021 um 16:05 hat Philippe Mathieu-Daudé geschrieben: > >> Is it possible to restrict a block driver to a particular set of > >> options? In my case I'd like to restrict the raw

Re: [PATCH v7 12/35] Hexagon (target/hexagon) instruction attributes

2021-01-25 Thread Philippe Mathieu-Daudé
On 1/22/21 11:01 PM, Taylor Simpson wrote: >> -Original Message- >> From: Philippe Mathieu-Daudé On >> Behalf Of Philippe Mathieu-Daudé >> Sent: Friday, January 22, 2021 11:54 AM >> To: Taylor Simpson ; qemu-devel@nongnu.org >> Cc: richard.hender...@linaro.org; alex.ben...@linaro.org; >>

Re: [PATCH] trace: add meson custom_target() depend_files for tracetool

2021-01-25 Thread Stefan Hajnoczi
On Mon, Jan 25, 2021 at 11:09:58AM +, Stefan Hajnoczi wrote: > Re-generate tracetool output when the tracetool source code changes. Use > the same approach as qapi_gen_depends and introduce a tracetool_depends > files list so meson is aware of the dependencies. > > Signed-off-by: Stefan

Re: [PATCH v20 01/20] multi-process: add the concept description to docs/devel/qemu-multiprocess

2021-01-25 Thread Cédric Le Goater
Hello, Thanks for this patchset. I have a slightly "off topic" question but I don't want to distract the maintainers from merging any of this. Feel free to ignore. I understand that this framework is targetting KVM and mostly PCI devices but I was wondering if it could be of any use for full

[PATCH v3] configure: Only build s390-ccw BIOS when system emulation is built

2021-01-25 Thread Philippe Mathieu-Daudé
It is pointless to build the s390-ccw BIOS when only user-mode emulation is built. Only build it when s390 system mode emulation is selected. Signed-off-by: Philippe Mathieu-Daudé --- v3: Restrict to s390x host (thuth) v2: Restrict to s390x-softmmu target (thuth) --- configure | 8 +++- 1

Re: configure does not detect librados or librbd since the switch to meson

2021-01-25 Thread Peter Lieven
Am 25.01.21 um 16:24 schrieb Paolo Bonzini: > On 25/01/21 15:31, Peter Lieven wrote: >> on Dedian / Ubuntu configure does no longer detect librbd / librados >> since the switch to meson. >> >> I need to add dirs: ['/usr/lib'] to the cc.find_library for librados >> and librbd. But I am not familiar

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-25 Thread Stefan Weil
Am 25.01.21 um 20:02 schrieb Richard Henderson: On 1/25/21 8:58 AM, Stefan Weil wrote: I have no evidence that TCI is less reliable than TCG, so I would not write that. It can't pass make check-tcg. Where does it fail? Maybe an expected timeout problem which can be solved by increasing

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-25 Thread Laszlo Ersek
On 01/25/21 22:13, Laszlo Ersek wrote: > On 01/23/21 23:13, Paolo Bonzini wrote: >> On 22/01/21 22:26, Laszlo Ersek wrote: >>> That seems bogus, per POSIX, given that all signals except SIGUSR2 are >>> included in the mask passed to sigsuspend(). >> >> What happens if you get a SIGSTOP at exactly

Re: Thread safety of coroutine-sigaltstack

2021-01-25 Thread Laszlo Ersek
On 01/23/21 14:35, Peter Maydell wrote: > On Sat, 23 Jan 2021 at 00:06, Laszlo Ersek wrote: >> On 01/22/21 11:14, Peter Maydell wrote: >>> I think (but have not checked) that that means we will build and >>> link the object file into the user-mode binaries if you happen >>> to build them in the

Re: [PATCH v7 00/35] Hexagon patch series

2021-01-25 Thread Philippe Mathieu-Daudé
Hi Taylor, On 1/20/21 4:28 AM, Taylor Simpson wrote: > This series adds support for the Hexagon processor with Linux user support > > See patch 02/33 Hexagon README for detailed information. > > This series assumes int128_or() is implemented. >

Re: [PATCH V6 1/6] hw/block/nvme: introduce nvme-subsys device

2021-01-25 Thread Klaus Jensen
On Jan 24 11:54, Minwoo Im wrote: > To support multi-path in QEMU NVMe device model, We need to have NVMe > subsystem hierarchy to map controllers and namespaces to a NVMe > subsystem. > > This patch introduced a simple nvme-subsys device model. The subsystem > will be prepared with subsystem

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-25 Thread Laszlo Ersek
On 01/25/21 11:57, Max Reitz wrote: > On 23.01.21 01:41, Laszlo Ersek wrote: >> On 01/22/21 22:26, Laszlo Ersek wrote: >> >>> I'm drifting towards an overhaul of coroutine-sigaltstack, based on my >>> personal understanding of POSIX, but given that I can absolutely not >>> *test*

Re: [PATCH v8 2/5] iotests: add testenv.py

2021-01-25 Thread Kevin Wolf
Am 23.01.2021 um 22:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add TestEnv class, which will handle test environment in a new python > iotests running framework. > > Don't add compat=1.1 for qcow2 IMGOPTS, as v3 is default anyway. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- >

Re: [PATCH 0/2] hw/block/nvme: zoned fixes

2021-01-25 Thread Dmitry Fomichev
On Mon, 2021-01-25 at 08:25 +0100, Klaus Jensen wrote: > On Jan 19 14:54, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Patch [1/2] fixes the zone append bug reported by Niklas. [2/2] > > refactors the zone write check function to return status codes in a > > different order if there are

Re: configure does not detect librados or librbd since the switch to meson

2021-01-25 Thread Paolo Bonzini
On 25/01/21 20:47, Peter Lieven wrote: Can you include the meson-logs/meson-log.txt output? Sure:https://pastebin.com/u3XtbDvQ Does this work for you? diff --git a/meson.build b/meson.build index 690d48a6fd..a662772c4a 100644 --- a/meson.build +++ b/meson.build @@ -14,6 +14,9 @@ config_host

Re: configure does not detect librados or librbd since the switch to meson

2021-01-25 Thread Peter Lieven
Am 25.01.21 um 22:57 schrieb Paolo Bonzini: > On 25/01/21 20:47, Peter Lieven wrote: >>> Can you include the meson-logs/meson-log.txt output? >> >> Sure:https://pastebin.com/u3XtbDvQ > > Does this work for you? > > diff --git a/meson.build b/meson.build > index 690d48a6fd..a662772c4a 100644 > ---

Re: [PATCH v3] sphinx: adopt kernel readthedoc theme

2021-01-25 Thread Marc-André Lureau
Hi On Mon, Jan 25, 2021 at 8:47 PM John Snow wrote: > > On 1/24/21 1:19 PM, Marc-André Lureau wrote: > > Hi > > > > On Fri, Jan 22, 2021 at 12:59 AM John Snow wrote: > >> > >> On 1/20/21 5:25 AM, marcandre.lur...@redhat.com wrote: > >>> From: Marc-André Lureau > >>> > >>> The default

Re: [PATCH 0/2] trace: make the 'log' backend timestamp configurable

2021-01-25 Thread BALATON Zoltan
On Mon, 25 Jan 2021, Stefan Hajnoczi wrote: Zoltan reminded me that the 'log' backend prints tids/timestamps and this can be unwanted in some cases. It's easier to look at trace output without them and in some cases parsing is also more convenient with them. Extend -msg timestamp=on|off to

Re: [PATCH V6 0/6] hw/block/nvme: support multi-path for ctrl/ns

2021-01-25 Thread Klaus Jensen
On Jan 24 11:54, Minwoo Im wrote: > Hello, > > This is sixth patch series for the support of NVMe subsystem scheme with > multi-controller and namespace sharing in a subsystem. > > This version has a fix in nvme_init_ctrl() when 'cntlid' is set to the > Identify Controller data structure by

Re: [PATCH] coroutine-sigaltstack: Keep SIGUSR2 handler up

2021-01-25 Thread Laszlo Ersek
On 01/23/21 23:13, Paolo Bonzini wrote: > On 22/01/21 22:26, Laszlo Ersek wrote: >> That seems bogus, per POSIX, given that all signals except SIGUSR2 are >> included in the mask passed to sigsuspend(). > > What happens if you get a SIGSTOP at exactly the wrong time?  (Yeah I > know how

[PATCH] target/arm: Correctly initialize MDCR_EL2.HPMN

2021-01-25 Thread muellerd--- via
When working with performance monitoring counters, we look at MDCR_EL2.HPMN as part of the check whether a counter is enabled. This check fails, because MDCR_EL2.HPMN is reset to 0, meaning that no counters are "enabled" for < EL2. That's in violation of the Arm specification, which states that >

Re: [PATCH] arm: rename xlnx-zcu102.canbusN properties

2021-01-25 Thread Vikram Garhwal
On Fri, Jan 22, 2021 at 01:21:53PM +, Peter Maydell wrote: Patch looks good to me. Reviewed-by: Vikram Garhwal > Just noticed this wasn't cc'd to the Xilinx folks. Would one > of you like to review it? > > thanks > -- PMM > > On Mon, 18 Jan 2021 at 16:25, Paolo Bonzini wrote: > > > > The

[PATCH v2] virtio: Add corresponding memory_listener_unregister to unrealize

2021-01-25 Thread Eugenio Pérez
Address space is destroyed without proper removal of its listeners with current code. They are expected to be removed in virtio_device_instance_finalize [1], but qemu calls it through object_deinit, after address_space_destroy call through device_set_realized [2]. Move it to

Re: [PATCH V6 6/6] hw/block/nvme: support for shared namespace in subsystem

2021-01-25 Thread Klaus Jensen
On Jan 24 11:54, Minwoo Im wrote: > nvme-ns device is registered to a nvme controller device during the > initialization in nvme_register_namespace() in case that 'bus' property > is given which means it's mapped to a single controller. > > This patch introduced a new property 'subsys' just like

Re: [PATCH v5 4/6] sev/i386: Don't allow a system reset under an SEV-ES guest

2021-01-25 Thread Dr. David Alan Gilbert
* Tom Lendacky (thomas.lenda...@amd.com) wrote: > From: Tom Lendacky > > An SEV-ES guest does not allow register state to be altered once it has > been measured. When an SEV-ES guest issues a reboot command, Qemu will > reset the vCPU state and resume the guest. This will cause failures under >

[PATCH] hw/block/nvme: add broadcast nsid support flush command

2021-01-25 Thread Klaus Jensen
From: Gollu Appalanaidu Add support for using the broadcast nsid to issue a flush on all namespaces through a single command. Signed-off-by: Gollu Appalanaidu Reviewed-by: Klaus Jensen --- include/block/nvme.h | 8 +++ hw/block/nvme.c | 123 +++---

RE: [PATCH v7 15/35] Hexagon (target/hexagon/arch.[ch]) utility functions

2021-01-25 Thread Taylor Simpson
> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Monday, January 25, 2021 10:30 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: a...@rev.ng; alex.ben...@linaro.org; richard.hender...@linaro.org; > laur...@vivier.eu; Brian Cain >

Re: [PATCH] coroutine-sigaltstack: Add SIGUSR2 mutex

2021-01-25 Thread Laszlo Ersek
On 01/25/21 13:03, Max Reitz wrote: > Disposition (action) for any given signal is global for the process. > When two threads run coroutine-sigaltstack's qemu_coroutine_new() > concurrently, they may interfere with each other: One of them may revert > the SIGUSR2 handler to SIG_DFL, between the

[PATCH] hw/misc: Fix arith overflow in NPCM7XX PWM module

2021-01-25 Thread wuhaotsh--- via
There's a potential arith overflow in npcm7xx_pwm_calculate_duty. This patch fixes it. Thanks Peter for finding this out. Signed-off-by: Hao Wu --- hw/misc/npcm7xx_pwm.c | 4 ++-- tests/qtest/npcm7xx_pwm-test.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [RFC v4 01/16] target/riscv: reformat @sh format encoding for B-extension

2021-01-25 Thread Alistair Francis
On Tue, Jan 12, 2021 at 11:18 PM wrote: > > From: Kito Cheng > > Signed-off-by: Kito Cheng > Signed-off-by: Frank Chang > Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Alistair > --- > target/riscv/insn32.decode | 10 +- > 1 file changed, 5 insertions(+), 5

Re: [PATCH v6 68/72] target/riscv: gdb: modify gdb csr xml file to align with csr register map

2021-01-25 Thread Alistair Francis
On Tue, Jan 12, 2021 at 2:50 AM wrote: > > From: Hsiangkai Wang > > Signed-off-by: Hsiangkai Wang > Acked-by: Richard Henderson > Signed-off-by: Frank Chang This patch won't apply any more, we have removed the hardcoded GDB register list. Alistair > --- > gdb-xml/riscv-32bit-csr.xml | 11

Re: [PATCH v2 0/2] vnc: unbreak older gtk-vnc

2021-01-25 Thread Laszlo Ersek
On 01/25/21 11:40, Gerd Hoffmann wrote: > > > Gerd Hoffmann (2): > Revert "vnc: move initialization to framebuffer_update_request" > vnc: send extended desktop resize on update requests > > ui/vnc.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > I didn't test

[PATCH] hw/block/nvme: fix wrong parameter name 'cross_read'

2021-01-25 Thread Minwoo Im
The actual parameter name is 'cross_read' rather than 'cross_zone_read'. Signed-off-by: Minwoo Im --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 21aec90637fa..bf9134f73d81 100644 --- a/hw/block/nvme.c +++

Re: [PATCH v7 05/11] osdep: build with non-working system() function

2021-01-25 Thread Paolo Bonzini
On 26/01/21 01:12, Joelle van Dyne wrote: Here's how meson does cc.has_function https://github.com/mesonbuild/meson/blob/master/mesonbuild/compilers/mixins/clike.py#L761 Since the compiler error comes from the header file with __attribute__((availability(ios,unavailable))) The meson check

[PATCH v9 10/11] darwin: detect CoreAudio for build

2021-01-25 Thread Joelle van Dyne
On iOS there is no CoreAudio, so we should not assume Darwin always has it. Signed-off-by: Joelle van Dyne --- configure | 35 +-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/configure b/configure index fddd11fed9..89836f8692 100755 ---

[PATCH v9 06/11] darwin: remove redundant dependency declaration

2021-01-25 Thread Joelle van Dyne
Meson will find CoreFoundation, IOKit, and Cocoa as needed. Reviewed-by: Peter Maydell Signed-off-by: Joelle van Dyne --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index d72ab22da5..1b2fc502ea 100755 --- a/configure +++ b/configure @@ -781,7 +781,6 @@

[PATCH v9 05/11] osdep: build with non-working system() function

2021-01-25 Thread Joelle van Dyne
Build without error on hosts without a working system(). If system() is called, return -1 with ENOSYS. Signed-off-by: Joelle van Dyne --- meson.build | 1 + include/qemu/osdep.h | 12 2 files changed, 13 insertions(+) diff --git a/meson.build b/meson.build index

[PATCH v9 04/11] slirp: feature detection for smbd

2021-01-25 Thread Joelle van Dyne
Replace Windows specific macro with a more generic feature detection macro. Allows slirp smb feature to be disabled manually as well. Signed-off-by: Joelle van Dyne --- configure | 22 +- meson.build | 2 +- net/slirp.c | 16 3 files changed, 30

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-25 Thread Richard Henderson
On 1/25/21 11:02 AM, Stefan Weil wrote: > Am 25.01.21 um 20:02 schrieb Richard Henderson: > >> On 1/25/21 8:58 AM, Stefan Weil wrote: >>> I have no evidence that TCI is less reliable than TCG, so I would not write >>> that. >> It can't pass make check-tcg. > > > Where does it fail? Maybe an

Re: Thread safety of coroutine-sigaltstack

2021-01-25 Thread Paolo Bonzini
On 25/01/21 23:15, Laszlo Ersek wrote: - How does this case differ from the registration of types? type_init() is a constructor function, and it generally ends up adding some structures with function pointers (I reckon) via type_table_add(). The main executable doesn't call into the device code

Re: [PATCH v2 6/7] goldfish_rtc: re-arm the alarm after migration

2021-01-25 Thread Alistair Francis
On Sat, Jan 23, 2021 at 7:06 AM Laurent Vivier wrote: > > Is there someone to merge this? Do you mean just this patch or the whole series? Alistair > > Thanks, > Laurent > > Le 20/12/2020 à 12:26, Laurent Vivier a écrit : > > After a migration the clock offset is updated, but we also > > need

  1   2   3   4   >