Re: [PATCH 0/3] Fix zone write validation

2021-01-26 Thread Klaus Jensen
On Jan 26 09:21, Klaus Jensen wrote: > On Jan 26 14:02, Dmitry Fomichev wrote: > > These patches solve a few problems that exist in zoned Write > > ans Zone Append validation code. > > > > Dmitry Fomichev (3): > > hw/block/nvme: Check for zone boundary during append > > hw/block/nvme: Check

Re: Thread safety of coroutine-sigaltstack

2021-01-26 Thread Laszlo Ersek
On 01/25/21 23:45, Paolo Bonzini wrote: > On 25/01/21 23:15, Laszlo Ersek wrote: >> >> - How does this case differ from the registration of types? type_init() >> is a constructor function, and it generally ends up adding some >> structures with function pointers (I reckon) via type_table_add().

Re: [PATCH] hw/sd: ssi-sd: Fix SEND_IF_COND (CMD8) response

2021-01-26 Thread Philippe Mathieu-Daudé
On 1/26/21 5:43 AM, Bin Meng wrote: > From: Bin Meng > > The SEND_IF_COND command (CMD8) response is of format R7, but > current code returns R1 for CMD8. Fix it. > > Fixes: 775616c3ae8c ("Partial SD card SPI mode support") > Signed-off-by: Bin Meng > > --- > When testing with VxWorks driver,

Re: [PATCH 0/3] Fix zone write validation

2021-01-26 Thread Klaus Jensen
On Jan 26 14:02, Dmitry Fomichev wrote: > These patches solve a few problems that exist in zoned Write > ans Zone Append validation code. > > Dmitry Fomichev (3): > hw/block/nvme: Check for zone boundary during append > hw/block/nvme: Check zone state before checking boundaries >

Re: [PATCH v8 2/5] iotests: add testenv.py

2021-01-26 Thread Vladimir Sementsov-Ogievskiy
26.01.2021 01:05, Kevin Wolf wrote: Am 23.01.2021 um 22:04 hat Vladimir Sementsov-Ogievskiy geschrieben: Add TestEnv class, which will handle test environment in a new python iotests running framework. Don't add compat=1.1 for qcow2 IMGOPTS, as v3 is default anyway. Signed-off-by: Vladimir

Re: [PATCH] hw/scsi/megasas: check for NULL frame in megasas_command_cancelled()

2021-01-26 Thread Mauro Matteo Cascella
On Mon, Jan 25, 2021 at 3:52 PM Philippe Mathieu-Daudé wrote: > > You forgot to Cc the subsystem maintainers... > > ./scripts/get_maintainer.pl -f hw/scsi/megasas.c > Hannes Reinecke (supporter:megasas) > Paolo Bonzini (supporter:SCSI) > Fam Zheng (reviewer:SCSI) I used to only check the

Re: [PATCH v1] gitlab-ci.yml: Speed up CI by using "meson test --no-rebuild"

2021-01-26 Thread Paolo Bonzini
On 26/01/21 08:03, Thomas Huth wrote: +  artifacts: +    when: always +    paths: +  - build/meson-logs/ +    reports: +  junit: build/meson-logs/testlog.junit.xml Ok, I've tried that but it also worked not quite as expected:

Re: [PATCH] gitlab-ci.yml: Avoid recompiling the sources in the test jobs

2021-01-26 Thread Thomas Huth
On 26/01/2021 08.36, Philippe Mathieu-Daudé wrote: On 1/26/21 7:57 AM, Thomas Huth wrote: Currently, our check-system-* jobs are recompiling the whole sources again. This happens due to the fact that the jobs are checking out the whole source tree and required submodules again, and only try to

Re: [PATCH] hw/block/nvme: fix wrong parameter name 'cross_read'

2021-01-26 Thread Klaus Jensen
On Jan 26 09:19, Minwoo Im wrote: > The actual parameter name is 'cross_read' rather than 'cross_zone_read'. > > Signed-off-by: Minwoo Im > --- > hw/block/nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/block/nvme.c b/hw/block/nvme.c > index

Re: [PATCH v7 05/11] osdep: build with non-working system() function

2021-01-26 Thread Peter Maydell
On Tue, 26 Jan 2021 at 00:12, Joelle van Dyne wrote: > cc.compiles should work though. Is there a reason why it's not used > instead of all the compile_prog checks in ./configure ? As Paolo says, that's because our transition to Meson is pretty recent. We put in the minimum necessary to move all

Re: [PATCH v4 5/5] qapi: More complex uses of QAPI_LIST_APPEND

2021-01-26 Thread Markus Armbruster
Eric Blake writes: > These cases require a bit more thought to review; in each case, the > code was appending to a list, but not with a FOOList **tail variable. > > Signed-off-by: Eric Blake > Reviewed-by: Vladimir Sementsov-Ogievskiy > > --- > fix qmp_guest_network_get_interfaces [Vladimir]

Re: [PATCH] gitlab-ci.yml: Avoid recompiling the sources in the test jobs

2021-01-26 Thread Philippe Mathieu-Daudé
On 1/26/21 10:08 AM, Thomas Huth wrote: > On 26/01/2021 08.36, Philippe Mathieu-Daudé wrote: >> On 1/26/21 7:57 AM, Thomas Huth wrote: >>> Currently, our check-system-* jobs are recompiling the whole sources >>> again. This happens due to the fact that the jobs are checking out >>> the whole

Re: [PATCH v8 2/5] iotests: add testenv.py

2021-01-26 Thread Kevin Wolf
Am 26.01.2021 um 09:28 hat Vladimir Sementsov-Ogievskiy geschrieben: > 26.01.2021 01:05, Kevin Wolf wrote: > > Am 23.01.2021 um 22:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > Add TestEnv class, which will handle test environment in a new python > > > iotests running framework. > > > >

[Bug 1796520] Re: autogen crashes on qemu-sh4-user after 61dedf2af7

2021-01-26 Thread John Paul Adrian Glaubitz
** Changed in: qemu Status: Expired => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1796520 Title: autogen crashes on qemu-sh4-user after 61dedf2af7 Status in QEMU:

Re: [PATCH v8 2/5] iotests: add testenv.py

2021-01-26 Thread Vladimir Sementsov-Ogievskiy
26.01.2021 12:45, Kevin Wolf wrote: Am 26.01.2021 um 09:28 hat Vladimir Sementsov-Ogievskiy geschrieben: 26.01.2021 01:05, Kevin Wolf wrote: Am 23.01.2021 um 22:04 hat Vladimir Sementsov-Ogievskiy geschrieben: Add TestEnv class, which will handle test environment in a new python iotests

Re: [PATCH] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-26 Thread Stefan Hajnoczi
On Fri, Jan 22, 2021 at 10:40:54AM -0500, Vivek Goyal wrote: > On Thu, Jan 21, 2021 at 02:44:29PM +, Stefan Hajnoczi wrote: > > A well-behaved FUSE client does not attempt to open special files with > > FUSE_OPEN because they are handled on the client side (e.g. device nodes > > are handled by

Re: [PATCH v9 3/6] iotests: add testenv.py

2021-01-26 Thread Vladimir Sementsov-Ogievskiy
25.01.2021 21:50, Vladimir Sementsov-Ogievskiy wrote: Add TestEnv class, which will handle test environment in a new python iotests running framework. Don't add compat=1.1 for qcow2 IMGOPTS, as v3 is default anyway. Signed-off-by: Vladimir Sementsov-Ogievskiy squash-in to fix mypy

Re: [PATCH v8 2/5] iotests: add testenv.py

2021-01-26 Thread Kevin Wolf
Am 26.01.2021 um 11:08 hat Vladimir Sementsov-Ogievskiy geschrieben: > 26.01.2021 12:45, Kevin Wolf wrote: > > Am 26.01.2021 um 09:28 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 26.01.2021 01:05, Kevin Wolf wrote: > > > > Am 23.01.2021 um 22:04 hat Vladimir Sementsov-Ogievskiy geschrieben:

Re: [PATCH v3] s390x/cpu_model: disallow unpack for --only-migratable

2021-01-26 Thread Cornelia Huck
On Mon, 25 Jan 2021 14:53:32 +0100 Christian Borntraeger wrote: > Secure execution (aka protected virtualization) guests cannot be > migrated at the moment. If the unpack facility is provided in the cpu > model, a guest may choose to transition to secure mode, making the > guest unmigratable at

[PATCH V2 4/7] block/rbd: add bdrv_attach_aio_context

2021-01-26 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/rbd.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index f68ebcf240..7abd0252c9 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -91,6 +91,7 @@ typedef struct BDRVRBDState { char *namespace;

[PATCH V2 5/7] block/rbd: migrate from aio to coroutines

2021-01-26 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/rbd.c | 253 ++-- 1 file changed, 86 insertions(+), 167 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 7abd0252c9..d11a3c6dd1 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -66,22 +66,6 @@ typedef

[PATCH V2 3/7] block/rbd: update s->image_size in qemu_rbd_getlength

2021-01-26 Thread Peter Lieven
in case the image size changed we should adjust our internally stored size as well. Signed-off-by: Peter Lieven --- block/rbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/rbd.c b/block/rbd.c index 1028596c68..f68ebcf240 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -964,6 +964,7

Re: [PATCH v3 1/2] net/eth: Simplify _eth_get_rss_ex_dst_addr()

2021-01-26 Thread Stefano Garzarella
On Tue, Jan 26, 2021 at 12:18:46PM +0100, Philippe Mathieu-Daudé wrote: The length field is already contained in the ip6_ext_hdr structure. Check it direcly in eth_parse_ipv6_hdr() before calling _eth_get_rss_ex_dst_addr(), which gets a bit simplified. Reviewed-by: Miroslav Rezanina

[PULL 06/53] qapi: copy-on-read filter: add 'bottom' option

2021-01-26 Thread Max Reitz
From: Andrey Shinkevich Add an option to limit copy-on-read operations to specified sub-chain of backing-chain, to make copy-on-read filter useful for block-stream job. Suggested-by: Max Reitz Suggested-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Andrey Shinkevich Signed-off-by: Vladimir

[PULL 22/53] iotests/129: Limit mirror job's buffer size

2021-01-26 Thread Max Reitz
Issuing 'stop' on the VM drains all nodes. If the mirror job has many large requests in flight, this may lead to significant I/O that looks a bit like 'stop' would make the job try to complete (which is what 129 should verify not to happen). We can limit the I/O in flight by limiting the buffer

[PULL 25/53] coroutine-sigaltstack: Add SIGUSR2 mutex

2021-01-26 Thread Max Reitz
Disposition (action) for any given signal is global for the process. When two threads run coroutine-sigaltstack's qemu_coroutine_new() concurrently, they may interfere with each other: One of them may revert the SIGUSR2 handler to SIG_DFL, between the other thread (a) setting up

[PATCH] meson: honor --enable-rbd if cc.links test fails

2021-01-26 Thread Paolo Bonzini
If the link test failed, compilation proceeded with RBD disabled, even if --enable-rbd was used on the configure command line. Fix that. Signed-off-by: Paolo Bonzini --- meson.build | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/meson.build

[PATCH] meson: accept either shared or static libraries if --disable-static

2021-01-26 Thread Paolo Bonzini
Meson's "static" argument to cc.find_library is a tri-state. By default Meson *prefers* a shared library, which basically means using -l to look for it; instead, "static: false" *requires* a shared library. Of course, "static: true" requires a static library, which is all good for

Re: [PATCH] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-26 Thread Miklos Szeredi
On Tue, Jan 26, 2021 at 11:18 AM Stefan Hajnoczi wrote: > > On Mon, Jan 25, 2021 at 05:12:23PM +0100, Miklos Szeredi wrote: > > On Thu, Jan 21, 2021 at 3:44 PM Stefan Hajnoczi wrote: > > > > > This patch adds the missing checks to virtiofsd. This is a short-term > > > solution because it does

[PATCH V2 7/7] block/rbd: drop qemu_rbd_refresh_limits

2021-01-26 Thread Peter Lieven
librbd supports 1 byte alignment for all aio operations. Currently, there is no API call to query limits from the ceph backend. So drop the bdrv_refresh_limits completely until there is such an API call. Signed-off-by: Peter Lieven --- block/rbd.c | 9 - 1 file changed, 9 deletions(-)

Re: [PATCH 2/2] gitlab-ci: Test Fedora capstone package

2021-01-26 Thread Daniel P . Berrangé
On Tue, Jan 26, 2021 at 12:36:49PM +0100, Philippe Mathieu-Daudé wrote: > Test building the 4 targets using the capstone disassembler > with the capstone package provided on Fedora. > > Signed-off-by: Philippe Mathieu-Daudé > --- > .gitlab-ci.yml | 7 +++ > 1 file changed, 7 insertions(+) >

Re: [PATCH] gitlab-ci.yml: Avoid some submodules to speed up the CI a little bit

2021-01-26 Thread Philippe Mathieu-Daudé
Hi Thomas, On 1/21/21 6:44 PM, Thomas Huth wrote: > Since the meson build system rework, the configure script prefers the > git submodules over the system libraries. So we are testing compilation > with capstone, fdt and libslirp as a submodule all over the place, > burning CPU cycles by

Re: [PATCH] meson: Restrict Cocoa framework check to macOS

2021-01-26 Thread Philippe Mathieu-Daudé
On 1/26/21 2:28 PM, Peter Maydell wrote: > On Tue, 26 Jan 2021 at 13:26, Philippe Mathieu-Daudé > wrote: >> >> Do not check for Cocoa framework if the OS is not macOS. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> meson.build | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [PATCH] meson: Restrict Cocoa framework check to macOS

2021-01-26 Thread Paolo Bonzini
On 26/01/21 14:47, Philippe Mathieu-Daudé wrote: -cocoa = dependency('appleframeworks', modules: 'Cocoa', required: get_option('cocoa')) +cocoa = not_found +if targetos == 'darwin' + cocoa = dependency('appleframeworks', modules: 'Cocoa', required: get_option('cocoa')) +endif if

[PULL 14/53] block: apply COR-filter to block-stream jobs

2021-01-26 Thread Max Reitz
From: Andrey Shinkevich This patch completes the series with the COR-filter applied to block-stream operations. Adding the filter makes it possible in future implement discarding copied regions in backing files during the block-stream job, to reduce the disk overuse (we need control on

[PULL 07/53] iotests: add #310 to test bottom node in COR driver

2021-01-26 Thread Max Reitz
From: Andrey Shinkevich The test case #310 is similar to #216 by Max Reitz. The difference is that the test #310 involves a bottom node to the COR filter driver. Signed-off-by: Andrey Shinkevich Signed-off-by: Vladimir Sementsov-Ogievskiy [vsementsov: detach backing to test reads from top,

[PULL 10/53] stream: rework backing-file changing

2021-01-26 Thread Max Reitz
From: Andrey Shinkevich Stream in stream_prepare calls bdrv_change_backing_file() to change backing-file in the metadata of bs. It may use either backing-file parameter given by user or just take filename of base on job start. Backing file format is determined by base on job finish. There are

[PULL 26/53] qapi: backup: add perf.use-copy-range parameter

2021-01-26 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy Experiments show, that copy_range is not always making things faster. So, to make experimentation simpler, let's add a parameter. Some more perf parameters will be added soon, so here is a new struct. For now, add new backup qmp parameter with x- prefix for

[PULL 30/53] block/block-copy: add list of all call-states

2021-01-26 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy It simplifies debugging. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-Id: <20210116214705.822267-6-vsement...@virtuozzo.com> Signed-off-by: Max Reitz --- block/block-copy.c | 11 ++- 1 file changed, 10 insertions(+), 1

[PULL 39/53] iotests: 219: prepare for backup over block-copy

2021-01-26 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy The further change of moving backup to be a one block-copy call will make copying chunk-size and cluster-size two separate things. So, even with 64k cluster sized qcow2 image, default chunk would be 1M. Test 219 depends on specified chunk-size. Update it for

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-26 Thread Daniel P . Berrangé
On Mon, Jan 25, 2021 at 09:02:38AM -1000, Richard Henderson wrote: > On 1/25/21 8:58 AM, Stefan Weil wrote: > > I have no evidence that TCI is less reliable than TCG, so I would not write > > that. > > It can't pass make check-tcg. It also doesn't have anyhere near the same level of automated

Re: [DRAFT RFC] ioeventfd/ioregionfd support in vfio-user

2021-01-26 Thread Stefan Hajnoczi
On Thu, Jan 21, 2021 at 04:09:09PM +, John Levon wrote: > > Hi, please take a look. For context, this addition is against the current > https://github.com/nutanix/libvfio-user/blob/master/docs/vfio-user.rst > specification. > > kvm@ readers: Stefan suggested this may be of interest from a

Re: [PATCH] iotests/118: Drop 'change' test

2021-01-26 Thread Kevin Wolf
Am 26.01.2021 um 11:48 hat Max Reitz geschrieben: > Commit 0afec75734331 removed the 'change' QMP command, so we can no > longer test it in 118. > > Fixes: 0afec75734331a0b52fa3aa4235220eda8c7846f >('qmp: remove deprecated "change" command') > Signed-off-by: Max Reitz Thanks, applied to

[PATCH v3 1/2] net/eth: Simplify _eth_get_rss_ex_dst_addr()

2021-01-26 Thread Philippe Mathieu-Daudé
The length field is already contained in the ip6_ext_hdr structure. Check it direcly in eth_parse_ipv6_hdr() before calling _eth_get_rss_ex_dst_addr(), which gets a bit simplified. Reviewed-by: Miroslav Rezanina Signed-off-by: Philippe Mathieu-Daudé --- net/eth.c | 14 +++--- 1 file

Re: [PATCH] iotests/118: Drop 'change' test

2021-01-26 Thread Paolo Bonzini
On 26/01/21 11:48, Max Reitz wrote: Commit 0afec75734331 removed the 'change' QMP command, so we can no longer test it in 118. Fixes: 0afec75734331a0b52fa3aa4235220eda8c7846f ('qmp: remove deprecated "change" command') Signed-off-by: Max Reitz --- tests/qemu-iotests/118 | 17

Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available

2021-01-26 Thread Stefan Weil
Am 25.01.21 um 23:35 schrieb Richard Henderson: On 1/25/21 11:02 AM, Stefan Weil wrote: Am 25.01.21 um 20:02 schrieb Richard Henderson: On 1/25/21 8:58 AM, Stefan Weil wrote: I have no evidence that TCI is less reliable than TCG, so I would not write that. It can't pass make check-tcg.

[PATCH V2 2/7] block/rbd: store object_size in BDRVRBDState

2021-01-26 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/rbd.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index a191c74619..1028596c68 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -90,6 +90,7 @@ typedef struct BDRVRBDState { char *snap;

[PATCH 2/2] vhost_user_gpu: Drop dead check for g_malloc() failure

2021-01-26 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/display/vhost-user-gpu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost-user-gpu.c index 51f1747c4a..db042c7c5e 100644 --- a/hw/display/vhost-user-gpu.c +++ b/hw/display/vhost-user-gpu.c @@ -332,7 +332,6

Re: [PATCH] coroutine-sigaltstack: Add SIGUSR2 mutex

2021-01-26 Thread Vladimir Sementsov-Ogievskiy
25.01.2021 15:03, Max Reitz wrote: Disposition (action) for any given signal is global for the process. When two threads run coroutine-sigaltstack's qemu_coroutine_new() concurrently, they may interfere with each other: One of them may revert the SIGUSR2 handler to SIG_DFL, between the other

[PULL 18/53] iotests/129: Remove test images in tearDown()

2021-01-26 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: Willian Rampazzo Message-Id: <20210118105720.14824-5-mre...@redhat.com> --- tests/qemu-iotests/129 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu-iotests/129

[PULL 37/53] iotests/129: Limit backup's max-chunk/max-workers

2021-01-26 Thread Max Reitz
Right now, this does not change anything, because backup ignores max-chunk and max-workers. However, as soon as backup is switched over to block-copy for the background copying process, we will need it to keep 129 passing. Signed-off-by: Max Reitz Message-Id:

Re: [PATCH] meson: honor --enable-rbd if cc.links test fails

2021-01-26 Thread Peter Lieven
Am 26.01.21 um 11:27 schrieb Paolo Bonzini: > If the link test failed, compilation proceeded with RBD disabled, > even if --enable-rbd was used on the configure command line. > Fix that. > > Signed-off-by: Paolo Bonzini > --- > meson.build | 24 +++- > 1 file changed, 15

Re: [PATCH v1 1/3] target/microblaze: Add use-non-secure property

2021-01-26 Thread Edgar E. Iglesias
On Thu, Jan 21, 2021 at 04:18:53PM -0800, Joe Komlodi wrote: > This property is used to control the security of the following interfaces > on MicroBlaze: > M_AXI_DP - data interface > M_AXI_IP - instruction interface > M_AXI_DC - dcache interface > M_AXI_IC - icache interface > > It works by

[Bug 1879531] Re: Stack-overflow in _eth_get_rss_ex_dst_addr

2021-01-26 Thread Philippe Mathieu-Daudé
Proposed fix: https://www.mail-archive.com/qemu-devel@nongnu.org/msg773408.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1879531 Title: Stack-overflow in _eth_get_rss_ex_dst_addr Status in

[PATCH 0/2] gitlab-ci: Test Fedora capstone package

2021-01-26 Thread Philippe Mathieu-Daudé
Add a job for a supported feature: capstone. Philippe Mathieu-Daudé (2): docker: Install libcastone on Fedora gitlab-ci: Test Fedora capstone package .gitlab-ci.yml | 7 +++ tests/docker/dockerfiles/fedora.docker | 1 + 2 files changed, 8 insertions(+) --

[PATCH 1/2] docker: Install libcastone on Fedora

2021-01-26 Thread Philippe Mathieu-Daudé
As other packages might install the system capstone library, we want to test it too in our CI. By default QEMU clones libcapstone from git, but a developer can force to use the system packaged library using: $ ./configure --enable-capstone=system Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH] meson: Restrict Cocoa framework check to macOS

2021-01-26 Thread Peter Maydell
On Tue, 26 Jan 2021 at 13:26, Philippe Mathieu-Daudé wrote: > > Do not check for Cocoa framework if the OS is not macOS. > > Signed-off-by: Philippe Mathieu-Daudé > --- > meson.build | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meson.build b/meson.build > index

Re: [PATCH 0/2] trace: make the 'log' backend timestamp configurable

2021-01-26 Thread Stefan Hajnoczi
On Mon, Jan 25, 2021 at 08:50:23PM +0100, BALATON Zoltan wrote: > On Mon, 25 Jan 2021, Stefan Hajnoczi wrote: > > Zoltan reminded me that the 'log' backend prints tids/timestamps and this > > can > > be unwanted in some cases. It's easier to look at trace output without them > > and > > in some

Re: [PATCH] iotests/178: Pass value to invalid option

2021-01-26 Thread Kevin Wolf
Am 26.01.2021 um 13:38 hat Max Reitz geschrieben: > ccd3b3b8112 has deprecated short-hand boolean options (i.e., options > with values). All options without values are interpreted as boolean > options, so this includes the invalid option "snapshot.foo" used in > iotest 178. > > So after

Re: [PATCH 2/2] vhost_user_gpu: Drop dead check for g_malloc() failure

2021-01-26 Thread Michael S. Tsirkin
On Tue, Jan 26, 2021 at 01:42:40PM +0100, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster Reviewed-by: Michael S. Tsirkin > --- > hw/display/vhost-user-gpu.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost-user-gpu.c > index

[PULL 16/53] iotests/297: Rewrite in Python and extend reach

2021-01-26 Thread Max Reitz
Instead of checking iotests.py only, check all Python files in the qemu-iotests/ directory. Of course, most of them do not pass, so there is an extensive skip list for now. (The only files that do pass are 209, 254, 283, and iotests.py.) (Alternatively, we could have the opposite, i.e. an

[PULL 17/53] iotests: Move try_remove to iotests.py

2021-01-26 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Willian Rampazzo Message-Id: <20210118105720.14824-4-mre...@redhat.com> --- tests/qemu-iotests/124| 8 +--- tests/qemu-iotests/iotests.py | 11 +++ 2 files changed, 8

[PULL 23/53] iotests/129: Clean up pylint and mypy complaints

2021-01-26 Thread Max Reitz
And consequentially drop it from 297's skip list. Signed-off-by: Max Reitz Reviewed-by: Willian Rampazzo Reviewed-by: Vladimir Sementsov-Ogievskiy Message-Id: <20210118105720.14824-10-mre...@redhat.com> --- tests/qemu-iotests/129 | 4 ++-- tests/qemu-iotests/297 | 2 +- 2 files changed, 3

Re: [PATCH 3/4] tests/qtest: Only run fuzz-megasas-test if megasas device is available

2021-01-26 Thread Philippe Mathieu-Daudé
On 1/15/21 11:39 PM, Alexander Bulekov wrote: > On 210115 1609, Philippe Mathieu-Daudé wrote: >> This test fails when QEMU is built without the megasas device, >> restrict it to its availability. > > Should we just make a separate directory for fuzzer tests and have a > separate source file for

[PATCH v3 0/2] net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

2021-01-26 Thread Philippe Mathieu-Daudé
I had a look at the patch from Miroslav trying to silence a compiler warning which in fact is a nasty bug. Here is a fix. https://www.mail-archive.com/qemu-devel@nongnu.org/msg772735.html v3: Added Thomas qtest Acked-by Philippe Mathieu-Daudé (2): net/eth: Simplify _eth_get_rss_ex_dst_addr()

Re: [PATCH] iotests/118: Drop 'change' test

2021-01-26 Thread Max Reitz
On 26.01.21 12:18, Kevin Wolf wrote: Am 26.01.2021 um 11:48 hat Max Reitz geschrieben: Commit 0afec75734331 removed the 'change' QMP command, so we can no longer test it in 118. Fixes: 0afec75734331a0b52fa3aa4235220eda8c7846f ('qmp: remove deprecated "change" command') Signed-off-by:

Re: [PATCH v2 2/2] sev: update sev-inject-launch-secret to make gpa optional

2021-01-26 Thread Dr. David Alan Gilbert
* James Bottomley (j...@linux.ibm.com) wrote: > If the gpa isn't specified, it's value is extracted from the OVMF > properties table located below the reset vector (and if this doesn't > exist, an error is returned). OVMF has defined the GUID for the SEV > secret area as

[PATCH] iotests/178: Pass value to invalid option

2021-01-26 Thread Max Reitz
ccd3b3b8112 has deprecated short-hand boolean options (i.e., options with values). All options without values are interpreted as boolean options, so this includes the invalid option "snapshot.foo" used in iotest 178. So after ccd3b3b8112, 178 fails with: +qemu-img: warning: short-form boolean

[Bug 1879531] Re: Stack-overflow in _eth_get_rss_ex_dst_addr

2021-01-26 Thread Peter Maydell
** Tags added: fuzzer -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1879531 Title: Stack-overflow in _eth_get_rss_ex_dst_addr Status in QEMU: New Bug description: Hello, While fuzzing, I

Re: [PULL v1 0/1] Merge tpm 2021/01/25 v1

2021-01-26 Thread Peter Maydell
On Tue, 26 Jan 2021 at 02:08, Stefan Berger wrote: > > Peter, > > this PR removes an unused tracepoint from tpm_spapr. > >Stefan > > The following changes since commit 31ee895047bdcf7387e3570cbd2a473c6f744b08: > > Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into

[PULL 00/53] Block patches

2021-01-26 Thread Max Reitz
The following changes since commit 31ee895047bdcf7387e3570cbd2a473c6f744b08: Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging (2021-01-25 15:56:13 +) are available in the Git repository at: https://github.com/XanClic/qemu.git tags/pull-block-2021-01-26

[PULL 03/53] block: add API function to insert a node

2021-01-26 Thread Max Reitz
From: Andrey Shinkevich Provide API for insertion a node to backing chain. Suggested-by: Max Reitz Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Message-Id: <20201216061703.70908-3-vsement...@virtuozzo.com> Signed-off-by: Max Reitz ---

[PULL 24/53] iotests/300: Clean up pylint and mypy complaints

2021-01-26 Thread Max Reitz
And consequentially drop it from 297's skip list. Signed-off-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Willian Rampazzo Message-Id: <20210118105720.14824-11-mre...@redhat.com> --- tests/qemu-iotests/297 | 2 +- tests/qemu-iotests/300 | 18 +++--- 2

[PULL 21/53] iotests/129: Actually test a commit job

2021-01-26 Thread Max Reitz
Before this patch, test_block_commit() performs an active commit, which under the hood is a mirror job. If we want to test various different block jobs, we should perhaps run an actual commit job instead. Doing so requires adding an overlay above the source node before the commit is done (and

Re: [PATCH] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-26 Thread Stefan Hajnoczi
On Mon, Jan 25, 2021 at 05:12:23PM +0100, Miklos Szeredi wrote: > On Thu, Jan 21, 2021 at 3:44 PM Stefan Hajnoczi wrote: > > > This patch adds the missing checks to virtiofsd. This is a short-term > > solution because it does not prevent a compromised virtiofsd process > > from opening device

Re: [PATCH v2] target/mips: fetch code with translator_ld

2021-01-26 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Similarly to commits ae82adc8e29..7f93879e444, use the > translator_ld*() API introduced in commit 409c1a0bf0f > to fetch the code on the MIPS target. > > Reviewed-by: Jiaxun Yang > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée -- Alex

Re: [PATCH v1 3/3] target/microblaze: Add security attributes on memory transactions

2021-01-26 Thread Edgar E. Iglesias
On Thu, Jan 21, 2021 at 04:18:55PM -0800, Joe Komlodi wrote: > Using the cfg.use_non_secure bitfield and the MMU access type, we can > determine > if the access should be secure or not. Reviewed-by: Edgar E. Iglesias Tested-by: Edgar E. Iglesias > > Signed-off-by: Joe Komlodi > --- >

[PATCH v2 0/2] tests/qtest: Only run fuzz-tests when tested devices are available

2021-01-26 Thread Philippe Mathieu-Daudé
Some tests/qtest/fuzz-test fail when the device tested is not available in the build. Fix this by only running the test when devices are available. FWIW Alexander Bulekov suggested an improvement, putting each test in a directory named by the device tested. This series does not cover that.

[PATCH v2 1/2] tests/qtest: Only run fuzz-megasas-test if megasas device is available

2021-01-26 Thread Philippe Mathieu-Daudé
This test fails when QEMU is built without the megasas device, restrict it to its availability. Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/fuzz-megasas-test.c | 49 + tests/qtest/fuzz-test.c | 25 - MAINTAINERS

Re: [PATCH v2 0/2] tests/qtest: Only run fuzz-tests when tested devices are available

2021-01-26 Thread Philippe Mathieu-Daudé
On 1/26/21 12:16 PM, Philippe Mathieu-Daudé wrote: > Some tests/qtest/fuzz-test fail when the device tested is > not available in the build. Fix this by only running the > test when devices are available. Forgot, since v1: - Do not make the testing generic, keep it restricted to x86 (thuth) >

[PATCH V2 0/7] block/rbd: migrate to coroutines and add write zeroes support

2021-01-26 Thread Peter Lieven
this series migrates the qemu rbd driver from the old aio emulation to native coroutines and adds write zeroes support which is important for block operations. To achive this we first bump the librbd requirement to the already outdated luminous release of ceph to get rid of some wrappers and

Re: [PATCH v5 3/6] sev/i386: Allow AP booting under SEV-ES

2021-01-26 Thread Dr. David Alan Gilbert
* Tom Lendacky (thomas.lenda...@amd.com) wrote: > From: Tom Lendacky > > When SEV-ES is enabled, it is not possible modify the guests register > state after it has been initially created, encrypted and measured. > > Normally, an INIT-SIPI-SIPI request is used to boot the AP. However, the >

Re: [PATCH 0/2] gitlab-ci: Test Fedora capstone package

2021-01-26 Thread Philippe Mathieu-Daudé
On 1/26/21 1:05 PM, Thomas Huth wrote: > On 26/01/2021 12.36, Philippe Mathieu-Daudé wrote: >> Add a job for a supported feature: capstone. >> >> Philippe Mathieu-Daudé (2): >>    docker: Install libcastone on Fedora >>    gitlab-ci: Test Fedora capstone package >> >>   .gitlab-ci.yml  

Re: [PATCH] iotests/118: Drop 'change' test

2021-01-26 Thread Kevin Wolf
Am 26.01.2021 um 12:30 hat Paolo Bonzini geschrieben: > On 26/01/21 11:48, Max Reitz wrote: > > Commit 0afec75734331 removed the 'change' QMP command, so we can no > > longer test it in 118. > > > > Fixes: 0afec75734331a0b52fa3aa4235220eda8c7846f > > ('qmp: remove deprecated "change"

Re: [PATCH v9 0/6] Rework iotests/check

2021-01-26 Thread Kevin Wolf
Am 25.01.2021 um 19:50 hat Vladimir Sementsov-Ogievskiy geschrieben: > v9: > 01: new, one more whitespace-fixing patch > testenv: allow case when we don't have system-arch emulator, but have several > for another architectures > change direct os.access(..., os.X_OK) calls to new helper

Re: [PATCH 2/2] vhost_user_gpu: Drop dead check for g_malloc() failure

2021-01-26 Thread Marc-André Lureau
On Tue, Jan 26, 2021 at 4:47 PM Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau thanks > --- > hw/display/vhost-user-gpu.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost-user-gpu.c > index

Re: [PATCH 1/2] backends/dbus-vmstate: Fix short read error handling

2021-01-26 Thread Marc-André Lureau
On Tue, Jan 26, 2021 at 4:43 PM Markus Armbruster wrote: > > When dbus_vmstate_post_load() fails, it complains to stderr. Except > on short read, where it checks with g_return_val_if_fail(). This > fails silently if G_DISABLE_CHECKS is undefined (it should be), or > else pads the short read

Re: [PATCH] meson: accept either shared or static libraries if --disable-static

2021-01-26 Thread Philippe Mathieu-Daudé
On 1/26/21 11:27 AM, Paolo Bonzini wrote: > Meson's "static" argument to cc.find_library is a tri-state. By default > Meson *prefers* a shared library, which basically means using -l to > look for it; instead, "static: false" *requires* a shared library. Of > course, "static: true" requires a

Re: [PATCH v9 0/6] Rework iotests/check

2021-01-26 Thread Vladimir Sementsov-Ogievskiy
26.01.2021 15:53, Kevin Wolf wrote: Am 25.01.2021 um 19:50 hat Vladimir Sementsov-Ogievskiy geschrieben: v9: 01: new, one more whitespace-fixing patch testenv: allow case when we don't have system-arch emulator, but have several for another architectures change direct os.access(...,

Re: [PATCH] coroutine-sigaltstack: Add SIGUSR2 mutex

2021-01-26 Thread Max Reitz
On 26.01.21 13:44, Vladimir Sementsov-Ogievskiy wrote: 25.01.2021 15:03, Max Reitz wrote: Disposition (action) for any given signal is global for the process. When two threads run coroutine-sigaltstack's qemu_coroutine_new() concurrently, they may interfere with each other: One of them may

[PULL 05/53] qapi: add filter-node-name to block-stream

2021-01-26 Thread Max Reitz
From: Andrey Shinkevich Provide the possibility to pass the 'filter-node-name' parameter to the block-stream job as it is done for the commit block job. Signed-off-by: Andrey Shinkevich Reviewed-by: Vladimir Sementsov-Ogievskiy [vsementsov: comment indentation, s/Since: 5.2/Since: 6.0/]

[PULL 09/53] copy-on-read: skip non-guest reads if no copy needed

2021-01-26 Thread Max Reitz
From: Andrey Shinkevich If the flag BDRV_REQ_PREFETCH was set, skip idling read/write operations in COR-driver. It can be taken into account for the COR-algorithms optimization. That check is being made during the block stream job by the moment. Add the BDRV_REQ_PREFETCH flag to the

[PULL 38/53] iotests: 185: prepare for backup over block-copy

2021-01-26 Thread Max Reitz
From: Vladimir Sementsov-Ogievskiy The further change of moving backup to be a one block-copy call will make copying chunk-size and cluster-size two separate things. So, even with 64k cluster sized qcow2 image, default chunk would be 1M. 185 test however assumes, that with speed limited to 64K,

Re: [PATCH v2] virtiofsd: prevent opening of special files (CVE-2020-35517)

2021-01-26 Thread Daniel P . Berrangé
On Tue, Jan 26, 2021 at 10:35:02AM +, Stefan Hajnoczi wrote: > A well-behaved FUSE client does not attempt to open special files with > FUSE_OPEN because they are handled on the client side (e.g. device nodes > are handled by client-side device drivers). > > The check to prevent virtiofsd

Re: [PATCH] iotests/118: Drop 'change' test

2021-01-26 Thread Philippe Mathieu-Daudé
On 1/26/21 11:48 AM, Max Reitz wrote: > Commit 0afec75734331 removed the 'change' QMP command, so we can no > longer test it in 118. > > Fixes: 0afec75734331a0b52fa3aa4235220eda8c7846f >('qmp: remove deprecated "change" command') > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/118

Re: [PATCH 2/4] tests/qtest: Make fuzz-test generic to all targets

2021-01-26 Thread Philippe Mathieu-Daudé
On 1/15/21 11:21 PM, Thomas Huth wrote: > On 15/01/2021 16.09, Philippe Mathieu-Daudé wrote: >> Tests in fuzz-test's main() already check for the supported >> architecture before adding tests, therefore this test is not >> specific to the X86 target. Move it to the generic set. > > As long as it

Re: [RFC 4/5] pci: acpi: add _DSM method to PCI devices

2021-01-26 Thread Michael S. Tsirkin
On Tue, Dec 22, 2020 at 06:39:33PM -0500, Igor Mammedov wrote: > Implement _DSM according to: > PCI Firmware Specification 3.1 > 4.6.7. DSM for Naming a PCI or PCI Express Device Under > Operating Systems > and wire it up to cold and hot-plugged PCI devices. > Feature depends

[PATCH v2 2/2] tests/qtest: Only run fuzz-virtio-scsi when virtio-scsi is available

2021-01-26 Thread Philippe Mathieu-Daudé
This test fails when QEMU is built without the virtio-scsi device, restrict it to its availability. Reviewed-by: Michael S. Tsirkin Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/fuzz-test.c | 51 tests/qtest/fuzz-virtio-scsi-test.c | 75

[PATCH v3 2/2] net/eth: Fix stack-buffer-overflow in _eth_get_rss_ex_dst_addr()

2021-01-26 Thread Philippe Mathieu-Daudé
QEMU fuzzer reported a buffer overflow in _eth_get_rss_ex_dst_addr() reproducible as: $ cat << EOF | ./qemu-system-i386 -M pc-q35-5.0 \ -accel qtest -monitor none \ -serial none -nographic -qtest stdio outl 0xcf8 0x80001010 outl 0xcfc 0xe102 outl 0xcf8 0x80001004 outw 0xcfc

[PATCH V2 1/7] block/rbd: bump librbd requirement to luminous release

2021-01-26 Thread Peter Lieven
even luminous (version 12.2) is unmaintained for over 3 years now. Bump the requirement to get rid of the ifdef'ry in the code. Signed-off-by: Peter Lieven --- block/rbd.c | 120 meson.build | 13 -- 2 files changed, 17 insertions(+),

  1   2   3   4   >