Re: [PATCH v14 15/22] cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass

2021-02-02 Thread Claudio Fontana
On 2/2/21 11:01 AM, Claudio Fontana wrote: > On 1/29/21 1:31 AM, Richard Henderson wrote: >> On 1/27/21 11:28 PM, Claudio Fontana wrote: >>> +/* >>> + * NB: this should be covered by CONFIG_TCG, but it is unsafe to do it >>> here, >>> + * as this header is included by both ss_specific

[Bug 1912224] Re: qemu may freeze during drive-mirroring on fragmented FS

2021-02-02 Thread Alexandre arents
I think the issue come from SEEK_HOLE call. SEEK_HOLE is fine until we find a hole close to the offset, It becomes a very expensive call when the HOLE is at the end of file of a big file (or smaller fragmented file because there is a lot of FS extent the driver should check.) When we run a

Re: [PATCH v4 00/16] qapi: static typing conversion, pt1.5

2021-02-02 Thread Markus Armbruster
John Snow writes: > Hi, this patchset enables strict optional checking in mypy for > everything we have typed so far. > > In general, this patchset seeks to clarify Optional[T] vs T and lift the > no-strict-optional restriction in mypy. > > Ironing out these issues allows us to be even stricter

Re: [Bug 1911351] Re: x86-64 MTTCG Does not update page table entries atomically

2021-02-02 Thread Peter Maydell
On Tue, 2 Feb 2021 at 05:07, Venkatesh Srinivas <1911...@bugs.launchpad.net> wrote: > BTW, the RISC-V MMU code _does_ get this right and the model could be > followed by the x86 version - - something like > https://github.com/vsrinivas/qemu/commit/1efa7dc689c4572d8fe0880ddbe44ec22f8f4348, > (but

Re: [RFC PATCH 4/4] hw/intc: make gicv3_idreg() distinguish between gicv3/gicv4

2021-02-02 Thread Peter Maydell
On Sun, 24 Jan 2021 at 02:53, Leif Lindholm wrote: > > Make gicv3_idreg() able to return either gicv3 or gicv4 data. > Add a parameter to specify gic version. > > Signed-off-by: Leif Lindholm > --- > hw/intc/arm_gicv3_dist.c | 2 +- > hw/intc/arm_gicv3_redist.c | 2 +- >

Re: [PATCH v2 1/2] pci: reject too large ROMs

2021-02-02 Thread Laszlo Ersek
On 01/29/21 20:28, Paolo Bonzini wrote: > get_image_size() returns an int64_t, which pci_add_option_rom() assigns > to an "int" without any range checking. A 32-bit BAR could be up to > 2 GiB in size, so reject anything above it. In order to accomodate > a rounded-up size of 2 GiB, change

Re: vnc clipboard support

2021-02-02 Thread Gerd Hoffmann
Hi, > > How do you rate-limit intelligently to avoid overflowing the guest keyboard > > buffers? > > Like I said earlier in this thread, this is a big problem with > keyboard injection. It's a solved problem though, the qemu vnc server has throttling implemented already. There even is an

Re: [PATCH 1/1] target/arm: Add raw_writefn to SCR_EL3 register

2021-02-02 Thread Peter Maydell
On Thu, 28 Jan 2021 at 14:31, Mike Nawrocki wrote: > > Fixes an issue in migration where the reset value of SCR and the value > produced by scr_write via the writefn for SCR_EL3 mismatch. > > Signed-off-by: Mike Nawrocki > --- > target/arm/helper.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [QEMU-SECURITY] [PATCH] hw/intc/arm_gic: Fix interrupt ID in GICD_SGIR register

2021-02-02 Thread Philippe Mathieu-Daudé
On 2/2/21 7:21 AM, P J P wrote: > On Sunday, 31 January, 2021, 08:48:26 pm IST, Philippe Mathieu-Daudé > wrote:  >> Forwarding to qemu-security@ to see if this issue is worth a CVE. >> >> | On 1/31/21 11:34 AM, Philippe Mathieu-Daudé wrote: >> | > Per the ARM Generic Interrupt Controller

Re: [PATCH RFC 2/4] target/i386: define CPU models to model x86-64 ABI levels

2021-02-02 Thread David Edmondson
On Monday, 2021-02-01 at 15:36:04 GMT, Daniel P. Berrangé wrote: > To paraphrase: > > > https://developers.redhat.com/blog/2021/01/05/building-red-hat-enterprise-linux-9-for-the-x86-64-v2-microarchitecture-level/ > > In 2020, AMD, Intel, Red Hat, and SUSE worked together to define > three

Re: [RFC 09/10] vhost: Route guest->host notification through shadow virtqueue

2021-02-02 Thread Eugenio Perez Martin
On Mon, Feb 1, 2021 at 7:29 AM Jason Wang wrote: > > > On 2021/1/30 上午4:54, Eugenio Pérez wrote: > > Shadow virtqueue notifications forwarding is disabled when vhost_dev > > stops. > > > > Signed-off-by: Eugenio Pérez > > --- > > hw/virtio/vhost-shadow-virtqueue.h | 5 ++ > >

Re: [PATCH] qemu-img: add seek and -n option to dd command

2021-02-02 Thread David Edmondson
On Thursday, 2021-01-28 at 15:07:04 +01, Peter Lieven wrote: > Signed-off-by: Peter Lieven > > diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst > index b615aa8419..7d4564c2b8 100644 > --- a/docs/tools/qemu-img.rst > +++ b/docs/tools/qemu-img.rst > @@ -209,6 +209,10 @@ Parameters to

Re: [PATCH] hw/char/exynos4210_uart: Fix buffer size reporting with FIFO disabled

2021-02-02 Thread Peter Maydell
On Thu, 28 Jan 2021 at 03:36, Iris Johnson wrote: > > Currently the Exynos 4210 UART code always reports available FIFO space > when the backend checks for buffer space. When the FIFO is disabled this > is behavior causes the backend chardev code to replace the data before the > guest can read

Re: vnc clipboard support

2021-02-02 Thread Gerd Hoffmann
> > My preferred solution is to have QEMU leverage the existing SPICE > > guest agent if at all possible, because that's already widely > > available in existing guest OS. > > I think spice is not as widely available as VNC (or even Synergy) so the > idea to strip one of those down to just a

Re: [PATCH RFC 1/4] docs: add a table showing x86-64 ABI compatibility levels

2021-02-02 Thread Florian Weimer
* Peter Maydell: > Apart from the QEMU/KVM specific CPU models, why is this something > we should be documenting rather than, say, the people specifying > what the ABI compatiblity levels are ? The psABI only cares about userspace, and the specification there deliberately excludes CPU features

Re: [PATCH v2 2/2] pci: add romsize property

2021-02-02 Thread David Edmondson
On Friday, 2021-01-29 at 20:28:38 +01, Paolo Bonzini wrote: > This property can be useful for distros to set up known-good ROM sizes for > migration purposes. The VM will fail to start if the ROM is too large, > and migration compatibility will not be broken if the ROM is too small. > > Note

Re: [RFC PATCH 2/4] hw/intc: add helper function to determine gicv3 redistributor size

2021-02-02 Thread Peter Maydell
On Sun, 24 Jan 2021 at 02:53, Leif Lindholm wrote: > > GICv3 sets aside 128K for each redistributor block, whereas GICv4 sets > aside 256K. To enable use of the gicv3 model for gicv4, abstract this > away as the helper function gicv3_redist_size() and replace the current > hardcoded locations

Re: [RFC PATCH 0/4] hw/intc: enable GICv4 memory layout for GICv3 driver

2021-02-02 Thread Peter Maydell
On Sun, 24 Jan 2021 at 02:53, Leif Lindholm wrote: > > GICv4 sets aside 256K per redistributor configuration block, whereas GICv3 > only uses 128K. However, some codebases (like TF-A, EDK2) will happily use > the GICv3 functionality only. > > This set aims at enabling these codebases to run,

Re: [PATCH] Fix SPDX-License-Identifier typos

2021-02-02 Thread Philippe Mathieu-Daudé
On 2/1/21 9:01 PM, Ryan Finnie wrote: > Several SPDX headers contain "SPDX-License-Identifer" (note the > missing "i" before "er"); fix these typos. > > Signed-off-by: Ryan Finnie > Cc: qemu-triv...@nongnu.org > --- > hw/misc/aspeed_xdma.c | 2 +- > hw/misc/sbsa_ec.c | 2 +-

Re: [PATCH v3] tcg: Fix execution on Apple Silicon

2021-02-02 Thread Roman Bolshakov
On Fri, Jan 29, 2021 at 07:27:57PM -1000, Richard Henderson wrote: > On 1/29/21 10:50 AM, Roman Bolshakov wrote: > > > > I thought you already added MAP_JIT in 6f70ddee19e. It's getting enabled > > on my M1 laptop. Was it intended or not? > > > > /* Applicable to both iOS and macOS (Apple

Re: [PATCH v4 05/16] qapi: centralize is_[user|system|builtin]_module methods

2021-02-02 Thread Markus Armbruster
John Snow writes: > Define what a module is and define what kind of a module it is once and > for all, in one place. > > Signed-off-by: John Snow > --- > scripts/qapi/gen.py| 25 +++-- > scripts/qapi/schema.py | 31 +-- > 2 files changed, 40

Re: [PATCH v4 07/16] qapi: use explicitly internal module names

2021-02-02 Thread Markus Armbruster
John Snow writes: > Use ./emit and ./init explicitly instead of "emit" and "init" and adding > the prefix based on the specific method called, which later allows us to > coalesce the two different methods into one. "Bandwurmsatz" (literally "tapeworm sentence"). Perhaps something like:

Re: [PATCH RFC 1/1] hw: Replace anti-social QOM type names

2021-02-02 Thread Markus Armbruster
Mark Cave-Ayland writes: > On 29/01/2021 08:15, Markus Armbruster wrote: > >> Several QOM type names contain ',': >> ARM,bitband-memory >> etraxfs,pic >> etraxfs,serial >> etraxfs,timer >> fsl,imx25 >> fsl,imx31 >> fsl,imx6 >> fsl,imx6ul >> fsl,imx7

Re: Makefile has local changes that will be overwritten

2021-02-02 Thread Greg Kurz
On Mon, 1 Feb 2021 10:30:25 -0500 Programmingkid wrote: > > > > On Feb 1, 2021, at 9:52 AM, Peter Maydell wrote: > > > > On Mon, 1 Feb 2021 at 14:49, Dan Streetman wrote: > >> > >> On Mon, Feb 1, 2021 at 9:23 AM Programmingkid > >> wrote: > >>> > >>> When trying to build QEMU I see this

Re: [RFC 05/10] vhost: Add vhost_dev_from_virtio

2021-02-02 Thread Eugenio Perez Martin
On Tue, Feb 2, 2021 at 4:31 AM Jason Wang wrote: > > > On 2021/2/1 下午4:28, Eugenio Perez Martin wrote: > > On Mon, Feb 1, 2021 at 7:13 AM Jason Wang wrote: > >> > >> On 2021/1/30 上午4:54, Eugenio Pérez wrote: > >>> Signed-off-by: Eugenio Pérez > >>> --- > >>>include/hw/virtio/vhost.h | 1 +

Re: [PATCH] target/i386: Add bus lock debug exception support

2021-02-02 Thread Paolo Bonzini
On 02/02/21 10:02, Chenyi Qiang wrote: Bus lock debug exception is a feature that can notify the kernel by generate an #DB trap after the instruction acquires a bus lock when CPL>0. This allows the kernel to enforce user application throttling or mitigations. This feature is enumerated via

Re: vnc clipboard support

2021-02-02 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 12:10:15PM +0100, Gerd Hoffmann wrote: > Hi, > > > > How do you rate-limit intelligently to avoid overflowing the guest > > > keyboard buffers? > > > > Like I said earlier in this thread, this is a big problem with > > keyboard injection. > > It's a solved problem

Re: [PATCH RFC 0/1] QOM type names and QAPI

2021-02-02 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Jan 29, 2021 at 02:25:56PM +0100, Paolo Bonzini wrote: >> On 29/01/21 13:17, Daniel P. Berrangé wrote: >> > > On this one, my vote would be "no". "Versioned machine names >> > > include the QEMU version number" is pretty well entrenched, >> > > and requiring

Re: [PATCH RFC 1/4] docs: add a table showing x86-64 ABI compatibility levels

2021-02-02 Thread David Edmondson
On Monday, 2021-02-01 at 15:36:03 GMT, Daniel P. Berrangé wrote: > It is useful to know which CPUs satisfy each x86-64 ABI > compatibility level, when dealing with guest OS that require > something newer than the baseline ABI. > > These ABI levels are defined in: > >

Re: [PULL 0/2] block: Fix iotests to respect configured Python binary

2021-02-02 Thread Peter Maydell
On Fri, 29 Jan 2021 at 16:13, Peter Maydell wrote: > This is definitely better so I'm going to apply it, but it seems > to reveal a pile of iotest failures on FreeBSD: > Failures: 030 040 041 127 256 It seems to consistently be these five. What do they have in common ? thanks -- PMM

Re: [PATCH v14 15/22] cpu: tcg_ops: move to tcg-cpu-ops.h, keep a pointer in CPUClass

2021-02-02 Thread Claudio Fontana
On 1/29/21 1:31 AM, Richard Henderson wrote: > On 1/27/21 11:28 PM, Claudio Fontana wrote: >> +/* >> + * NB: this should be covered by CONFIG_TCG, but it is unsafe to do it >> here, >> + * as this header is included by both ss_specific and ss_common code, >> + * leading to

[PATCH] configure: Escape non-numbers in version_ge()

2021-02-02 Thread Philippe Mathieu-Daudé
On Red Hat based distributions, the configure script emits various warnings: # ./configure Using './build' as the directory for build output ./configure: line 212: test: 2-15: integer expression expected ./configure: line 213: test: 2-15: integer expression expected ./configure: line

Re: [PATCH v2 2/2] pci: add romsize property

2021-02-02 Thread Laszlo Ersek
On 02/02/21 11:05, David Edmondson wrote: > On Friday, 2021-01-29 at 20:28:38 +01, Paolo Bonzini wrote: > >> This property can be useful for distros to set up known-good ROM sizes for >> migration purposes. The VM will fail to start if the ROM is too large, >> and migration compatibility will

Re: [PULL 00/11] Tracing patches

2021-02-02 Thread Peter Maydell
On Mon, 1 Feb 2021 at 15:48, Stefan Hajnoczi wrote: > > The following changes since commit 74208cd252c5da9d867270a178799abd802b9338: > > Merge remote-tracking branch > 'remotes/berrange-gitlab/tags/misc-fixes-pull-request' into staging > (2021-01-29 19:51:25 +) > > are available in the

[PATCH] target/i386: Add bus lock debug exception support

2021-02-02 Thread Chenyi Qiang
Bus lock debug exception is a feature that can notify the kernel by generate an #DB trap after the instruction acquires a bus lock when CPL>0. This allows the kernel to enforce user application throttling or mitigations. This feature is enumerated via CPUID.(EAX=7,ECX=0).ECX[bit 24].

Re: [RFC PATCH 1/4] hw/intc: don't bail out gicv3 model init for revision 4

2021-02-02 Thread Peter Maydell
On Sun, 24 Jan 2021 at 02:53, Leif Lindholm wrote: > > As a first step towards GICv4 compatibility, add support for gic revision 4 > to GICv3 driver (i.e. don't bail out if revision 4 is encountered). > > Signed-off-by: Leif Lindholm > --- > hw/intc/arm_gicv3_common.c | 2 +- > 1 file changed,

Re: [RFC PATCH 3/4] hw/intc: set GICD_TYPER.DVIS for GICv4

2021-02-02 Thread Peter Maydell
On Sun, 24 Jan 2021 at 02:53, Leif Lindholm wrote: > > The VLPI frames are what make the redistributor size change, so ensure > we state in GICD_TYPER that we have them. > > Signed-off-by: Leif Lindholm > --- > hw/intc/arm_gicv3_dist.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git

[Bug 1912777] Re: KVM_EXIT_MMIO has increased in Qemu4.0.0 when compared to Qemu 2.11.0

2021-02-02 Thread ANIMESH KUMAR SINHA
Could someone update on this? ** Changed in: qemu Status: Incomplete => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1912777 Title: KVM_EXIT_MMIO has increased in Qemu4.0.0 when

Re: [PATCH] hw/char/exynos4210_uart: Fix missing call to report ready for input

2021-02-02 Thread Peter Maydell
On Sat, 30 Jan 2021 at 18:42, Iris Johnson wrote: > > When the frontend device has no space for a read the fd is removed > from polling to allow time for the guest to read and clear the buffer. > Without the call to qemu_chr_fe_accept_input(), the poll will not be > broken out of when the guest

Re: [PATCH v2] hw/arm/smmuv3: Fix addr_mask for range-based invalidation

2021-02-02 Thread Peter Maydell
On Sat, 30 Jan 2021 at 04:32, Zenghui Yu wrote: > > When handling guest range-based IOTLB invalidation, we should decode the TG > field into the corresponding translation granule size so that we can pass > the correct invalidation range to backend. Set @granule to (tg * 2 + 10) to > properly

Re: vnc clipboard support

2021-02-02 Thread Gerd Hoffmann
On Tue, Feb 02, 2021 at 11:17:09AM +, Daniel P. Berrangé wrote: > On Tue, Feb 02, 2021 at 12:10:15PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > How do you rate-limit intelligently to avoid overflowing the guest > > > > keyboard buffers? > > > > > > Like I said earlier in this thread,

Re: [PATCH RFC 1/4] docs: add a table showing x86-64 ABI compatibility levels

2021-02-02 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 09:41:15AM +, David Edmondson wrote: > On Monday, 2021-02-01 at 15:36:03 GMT, Daniel P. Berrangé wrote: > > > It is useful to know which CPUs satisfy each x86-64 ABI > > compatibility level, when dealing with guest OS that require > > something newer than the baseline

Re: [PULL 0/6] Block layer patches

2021-02-02 Thread Peter Maydell
On Mon, 1 Feb 2021 at 19:07, Kevin Wolf wrote: > > The following changes since commit 74208cd252c5da9d867270a178799abd802b9338: > > Merge remote-tracking branch > 'remotes/berrange-gitlab/tags/misc-fixes-pull-request' into staging > (2021-01-29 19:51:25 +) > > are available in the Git

Re: [PATCH 0/1] Allow to build virtiofsd without the entire tools

2021-02-02 Thread Wainer dos Santos Moschetta
Hi, On 2/1/21 8:04 PM, Paolo Bonzini wrote: Il lun 1 feb 2021, 22:15 Wainer dos Santos Moschetta mailto:waine...@redhat.com>> ha scritto: Not too long ago (QEMU 5.0) it was possible to configure with --disable-tools and still have virtiofsd built. With the recent port of the

Re: Makefile has local changes that will be overwritten

2021-02-02 Thread Warner Losh
On Tue, Feb 2, 2021, 2:27 AM Greg Kurz wrote: > On Mon, 1 Feb 2021 10:30:25 -0500 > Programmingkid wrote: > > > > > > > > On Feb 1, 2021, at 9:52 AM, Peter Maydell > wrote: > > > > > > On Mon, 1 Feb 2021 at 14:49, Dan Streetman > wrote: > > >> > > >> On Mon, Feb 1, 2021 at 9:23 AM

Re: [RFC PATCH 2/2] hw/arm/raspi: Restrict BCM2835 / BCM2836 SoC to TCG

2021-02-02 Thread Peter Maydell
On Tue, 2 Feb 2021 at 13:29, Philippe Mathieu-Daudé wrote: > > On 2/2/21 1:28 PM, Peter Maydell wrote: > > At the moment we can reasonably > > say "only the 'virt' board and one of the Xilinx boards are > > security-critical". > > What about the SBSA-ref? It doesn't work with KVM, and enforces

[PATCH v1 10/15] gdbstub: Fix handle_query_xfer_auxv

2021-02-02 Thread Alex Bennée
From: Richard Henderson The main problem was that we were treating a guest address as a host address with a mere cast. Use the correct interface for accessing guest memory. Do not allow offset == auxv_len, which would result in an empty packet. Fixes: 51c623b0de1 ("gdbstub: add support to

[PATCH v1 08/15] configure: bump the minimum gdb version for check-tcg to 9.1

2021-02-02 Thread Alex Bennée
For SVE, currently the bulk of the GDB TCG tests, we need at least GDB 9.1 to support the "ieee_half" data type we report. This only affects when GDB tests are run; users can still use lower versions of gdb as long as they aren't talking to an SVE enabled model. The work around is to either get a

[Bug 1914236] Re: QEMU: scsi: use-after-free in mptsas_process_scsi_io_request() of mptsas1068 emulator

2021-02-02 Thread P J P
** Information type changed from Private Security to Public Security -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1914236 Title: QEMU: scsi: use-after-free in mptsas_process_scsi_io_request() of

Re: [PATCH v1 07/15] configure: make version_ge more tolerant of shady version input

2021-02-02 Thread Eric Blake
On 2/2/21 7:39 AM, Alex Bennée wrote: > When checking GDB versions we have to tolerate all sorts of random > distro extensions to the version string. While we already attempt to > do some of that before we call version_ge is makes sense to try and > regularise the first input by stripping

Re: macOS (Big Sur, Apple Silicon) 'make check' fails in test-crypto-tlscredsx509

2021-02-02 Thread qemu_oss--- via
On Dienstag, 2. Februar 2021 06:19:42 CET Roman Bolshakov wrote: > 'make check' of libtasn1 doesn't succeed on x86_64 either. > > After a session of debugging I believe there's an issue with Clang 12. > Here's a test program (it reproduces unexpected ASN1_VALUE_NOT_VALID > from _asn1_time_der()

[PATCH 02/20] vhost-user-gpu: handle vhost-user-gpu features in a callback

2021-02-02 Thread marcandre . lureau
From: Marc-André Lureau Fixes a deadlock where the backend calls QEMU, while QEMU also calls the backend simultaneously, both ends waiting for each other. Signed-off-by: Marc-André Lureau --- contrib/vhost-user-gpu/vugpu.h | 2 +- contrib/vhost-user-gpu/vhost-user-gpu.c | 37

[PATCH 08/20] ui: annotate DCLOps callback requirements

2021-02-02 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- include/ui/console.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index ce6c72e37c..bea2b6329a 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@

[PATCH 12/20] ui: add a DCLOps callback to check dmabuf support

2021-02-02 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- include/ui/console.h | 2 ++ ui/console.c | 13 + 2 files changed, 15 insertions(+) diff --git a/include/ui/console.h b/include/ui/console.h index 0595aa9953..875885d9c7 100644 --- a/include/ui/console.h +++

[PATCH 11/20] ui: add an optional get_flags callback to GraphicHwOps

2021-02-02 Thread marcandre . lureau
From: Marc-André Lureau Those flags can be used to express different requirements for the display or other needs. Signed-off-by: Marc-André Lureau --- include/ui/console.h | 9 + hw/display/virtio-gpu-base.c | 16 hw/display/virtio-vga.c | 9 +

[PATCH 19/20] chardev: check if the chardev is registered for yanking

2021-02-02 Thread marcandre . lureau
From: Marc-André Lureau Not all chardevs are created via qmp_chardev_open_socket(), and those should not call the yank function registration, as this will eventually assert() not being registered. Signed-off-by: Marc-André Lureau --- chardev/char-socket.c | 53

Re: [PATCH] docs/interop/qmp-spec: Document the request queue limit

2021-02-02 Thread Markus Armbruster
Queued.

Re: [PATCH v4 12/23] linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE

2021-02-02 Thread Peter Maydell
On Thu, 28 Jan 2021 at 22:42, Richard Henderson wrote: > > This is the prctl bit that controls whether syscalls accept tagged > addresses. See Documentation/arm64/tagged-address-abi.rst in the > linux kernel. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v4 0/2] System Generation ID driver and VMGENID backend

2021-02-02 Thread Michael S. Tsirkin
On Thu, Jan 28, 2021 at 01:58:12PM +0100, Alexander Graf wrote: > Hey Michael! > > On 27.01.21 13:47, Michael S. Tsirkin wrote: > > > > On Thu, Jan 21, 2021 at 10:28:16AM +, Catangiu, Adrian Costin wrote: > > > On 12/01/2021, 14:49, "Michael S. Tsirkin" wrote: > > > > > > On Tue, Jan

Re: [PATCH v4 17/23] target/arm: Split out syndrome.h from internals.h

2021-02-02 Thread Peter Maydell
On Thu, 28 Jan 2021 at 22:42, Richard Henderson wrote: > > Move everything related to syndromes to a new file, > which can be shared with linux-user. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell (another dropped tag from v3) thanks -- PMM

Re: [PATCH v5 1/2] drivers/misc: sysgenid: add system generation id driver

2021-02-02 Thread Greg KH
On Mon, Feb 01, 2021 at 07:24:53PM +0200, Adrian Catangiu wrote: > +static long sysgenid_ioctl(struct file *file, > +unsigned int cmd, unsigned > long arg) Very odd indentation style, checkpatch.pl didn't catch this?

Re: [PULL 10/11] trace: document how to specify multiple --trace patterns

2021-02-02 Thread Markus Armbruster
BALATON Zoltan writes: > On Mon, 1 Feb 2021, Paolo Bonzini wrote: >> On 01/02/21 17:54, Kevin Wolf wrote: How does this option parsing work? Would then multiple patterns separated by comma as in -trace pattern1,pattern2 also work? >>> This would be interpreted as an implied

[PATCH v7 05/14] block: drop extra error propagation for bdrv_set_backing_hd

2021-02-02 Thread Vladimir Sementsov-Ogievskiy
bdrv_set_backing_hd now returns status, let's use it. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia --- block.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index 48b0de36ff..d679ed8036 100644 ---

[PATCH v7 01/14] block: return status from bdrv_append and friends

2021-02-02 Thread Vladimir Sementsov-Ogievskiy
The recommended use of qemu error api assumes returning status together with setting errp and avoid void functions with errp parameter. Let's improve bdrv_append and some friends to reduce error-propagation overhead in further patches. Choose int return status, because bdrv_replace_node_common()

[PATCH v7 00/14] block: deal with errp: part I

2021-02-02 Thread Vladimir Sementsov-Ogievskiy
v7: 08: rebase onto QAPI_LIST_APPEND used, drop r-b Vladimir Sementsov-Ogievskiy (14): block: return status from bdrv_append and friends block: use return status of bdrv_append() block: check return value of bdrv_open_child and drop error propagation blockdev: fix

[PATCH v7 04/14] blockdev: fix drive_backup_prepare() missed error

2021-02-02 Thread Vladimir Sementsov-Ogievskiy
We leak local_err and don't report failure to the caller. It's definitely wrong, let's fix. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia --- blockdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/blockdev.c

[PATCH v7 12/14] block/qcow2: simplify qcow2_co_invalidate_cache()

2021-02-02 Thread Vladimir Sementsov-Ogievskiy
qcow2_do_open correctly sets errp on each failure path. So, we can simplify code in qcow2_co_invalidate_cache() and drop explicit error propagation. Add ERRP_GUARD() as mandated by the documentation in include/qapi/error.h so that error_prepend() is actually called even if errp is _fatal.

[PATCH v7 13/14] block/qed: bdrv_qed_do_open: deal with errp

2021-02-02 Thread Vladimir Sementsov-Ogievskiy
Set errp always on failure. Generic bdrv_open_driver supports driver functions which can return negative value and forget to set errp. That's a strange thing.. Let's improve bdrv_qed_do_open to not behave this way. This allows to simplify code in bdrv_qed_co_invalidate_cache(). Signed-off-by:

[PATCH v7 07/14] blockjob: return status from block_job_set_speed()

2021-02-02 Thread Vladimir Sementsov-Ogievskiy
Better to return status together with setting errp. It allows to avoid error propagation in the caller. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia --- include/block/blockjob.h | 2 +- blockjob.c | 18 -- 2

[PATCH v7 10/14] block/qcow2-bitmap: return status from qcow2_store_persistent_dirty_bitmaps

2021-02-02 Thread Vladimir Sementsov-Ogievskiy
It's better to return status together with setting errp. It makes possible to avoid error propagation. While being here, put ERRP_GUARD() to fix error_prepend(errp, ...) usage inside qcow2_store_persistent_dirty_bitmaps() (see the comment above ERRP_GUARD() definition in include/qapi/error.h)

Re: [PULL 10/11] trace: document how to specify multiple --trace patterns

2021-02-02 Thread Paolo Bonzini
On 02/02/21 13:41, Markus Armbruster wrote: Since trace_opt_parse() deletes, this always creates an empty one. const char *file = qemu_opt_get(opts, "file"); This is always null. #ifdef CONFIG_TRACE_SIMPLE st_set_trace_file(file); if (init_trace_on_startup) {

Re: vnc clipboard support

2021-02-02 Thread Gerd Hoffmann
Hi, > The VNC protocol is way too crude. It is limited to transferring > plain text, and provides no way to specify or negotiate a character > set. The RFB spec says apps should use latin-1. In reality few, if any, > impls do charset conversion so most Linux impls will be sending UTF8 > while

Re: [RFC PATCH v3 07/31] hw/cxl/device: Add cheap EVENTS implementation (8.2.9.1)

2021-02-02 Thread Jonathan Cameron
On Mon, 1 Feb 2021 16:59:24 -0800 Ben Widawsky wrote: > Using the previously implemented stubbed helpers, it is now possible to > easily add the missing, required commands to the implementation. > > Signed-off-by: Ben Widawsky comment inline. Otherwise LGTM. > --- > hw/cxl/cxl-mailbox-utils.c

[PATCH] iotests: Revert emulator selection to old behaviour

2021-02-02 Thread Kevin Wolf
If the qemu-system-{arch} binary for the host architecture can't be found, the old 'check' implementation selected the alphabetically first system emulator binary that it could find. The new Python implementation just uses the first result of glob.iglob(), which has an undefined order. This is a

[PATCH 10/20] vhost-user-gpu: add a configuration flag for dmabuf usage

2021-02-02 Thread marcandre . lureau
From: Marc-André Lureau Let's inform VirtioGPUBase that vhost-user-gpu require DMABUF messages. Signed-off-by: Marc-André Lureau --- include/hw/virtio/virtio-gpu.h | 3 +++ hw/display/vhost-user-gpu.c| 2 ++ 2 files changed, 5 insertions(+) diff --git a/include/hw/virtio/virtio-gpu.h

[PATCH 09/20] ui: remove console_has_gl_dmabuf()

2021-02-02 Thread marcandre . lureau
From: Marc-André Lureau This check is currently limited. It only is used by vhost-user-gpu (not by vfio-display), and will print an error repeatedly during run-time. We are going to dissociate the GL context from the DisplayChangeListener, and listeners may come and go. The following patches

Re: [PATCH v4 01/23] tcg: Introduce target-specific page data for user-only

2021-02-02 Thread Peter Maydell
On Thu, 28 Jan 2021 at 22:41, Richard Henderson wrote: > > This data can be allocated by page_alloc_target_data() and > released by page_set_flags(start, end, prot | PAGE_RESET). > > This data will be used to hold tag memory for AArch64 MTE. > > Signed-off-by: Richard Henderson > --- > v3: Add

[PATCH 18/20] display/ui: add a callback to indicate GL state is flushed

2021-02-02 Thread marcandre . lureau
From: Marc-André Lureau Displaying rendered resources requires blocking qemu GPU to avoid extra framebuffer copies. For an external display, via Spice currently, there is a callback to block/unblock the rendering in the same thread. But with the vhost-user-gpu backend, the qemu process doesn't

Re: [PATCH v4 05/23] exec: Improve types for guest_addr_valid

2021-02-02 Thread Peter Maydell
On Thu, 28 Jan 2021 at 22:41, Richard Henderson wrote: > > Return bool not int; pass abi_ulong not 'unsigned long'. > All callers use abi_ulong already, so the change in type > has no effect. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v4 20/23] linux-user/aarch64: Signal SEGV_MTEAERR for async tag check error

2021-02-02 Thread Peter Maydell
On Thu, 28 Jan 2021 at 22:42, Richard Henderson wrote: > > The real kernel collects _TIF_MTE_ASYNC_FAULT into the current thread's > state on any kernel entry (interrupt, exception etc), and then delivers > the signal in advance of resuming the thread. > > This means that while the signal won't

Re: [PATCH] iotests: Revert emulator selection to old behaviour

2021-02-02 Thread Philippe Mathieu-Daudé
Forgot to Cc Wainer & Willian in case they are interested in providing a better long term fix. On 2/2/21 3:46 PM, Philippe Mathieu-Daudé wrote: > On 2/2/21 3:28 PM, Kevin Wolf wrote: >> If the qemu-system-{arch} binary for the host architecture can't be >> found, the old 'check' implementation

Re: [PATCH v9 00/10] hw/ssi: imx_spi: Fix various bugs in the imx_spi model

2021-02-02 Thread Peter Maydell
On Fri, 29 Jan 2021 at 13:23, Bin Meng wrote: > > From: Bin Meng > > Starting from v8, the series is based on the following 2 versions: > > - v5 series sent from Bin > http://patchwork.ozlabs.org/project/qemu-devel/list/?series=223919 > - v7 series sent from Philippe >

Re: [RFC PATCH 0/2] hw/arm/raspi: Restrict BCM2835 / BCM2836 SoC to TCG

2021-02-02 Thread Peter Maydell
On Sun, 31 Jan 2021 at 15:14, Philippe Mathieu-Daudé wrote: > > Peter mentioned [*] KVM only support ARMv8 targets. Restrict the > non-ARMv8 machines to TCG. > > While this is still not enough to boot a raspi3 image using KVM: > > $ qemu-system-aarch64 -M raspi3b -enable-kvm ... >

Re: [PATCH] migration: Provide a test for migratability

2021-02-02 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 1/21/21 12:51 PM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Provide a simple way to see if there's currently a migration blocker in > > operation: > > > > $ ./x86_64-softmmu/qemu-system-x86_64 -nographic -M

Re: [PATCH RFC 2/4] target/i386: define CPU models to model x86-64 ABI levels

2021-02-02 Thread Daniel P . Berrangé
On Tue, Feb 02, 2021 at 12:50:53PM +, David Edmondson wrote: > On Tuesday, 2021-02-02 at 12:32:39 GMT, Daniel P. Berrangé wrote: > > > On Tue, Feb 02, 2021 at 09:46:55AM +, David Edmondson wrote: > >> On Monday, 2021-02-01 at 15:36:04 GMT, Daniel P. Berrangé wrote: > >> > >> > To

[PATCH v7 08/14] block/qcow2: qcow2_get_specific_info(): drop error propagation

2021-02-02 Thread Vladimir Sementsov-Ogievskiy
Don't use error propagation in qcow2_get_specific_info(). For this refactor qcow2_get_bitmap_info_list, its current interface is rather weird. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.h| 4 ++-- block/qcow2-bitmap.c | 26 +- block/qcow2.c

[PATCH v7 11/14] block/qcow2: read_cache_sizes: return status value

2021-02-02 Thread Vladimir Sementsov-Ogievskiy
It's better to return status together with setting errp. It allows to reduce error propagation. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Greg Kurz Reviewed-by: Alberto Garcia --- block/qcow2.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff

Re: [PATCH v21 08/20] io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all helpers

2021-02-02 Thread Daniel P . Berrangé
On Fri, Jan 29, 2021 at 11:46:09AM -0500, Jagannathan Raman wrote: > From: Elena Ufimtseva > > Adds qio_channel_readv_full_all_eof() and qio_channel_readv_full_all() > to read both data and FDs. Refactors existing code to use these helpers. > > Signed-off-by: Elena Ufimtseva > Signed-off-by:

[PATCH v1 06/15] tests/docker: add a docker-exec-copy-test

2021-02-02 Thread Alex Bennée
This provides test machinery for checking the QEMU copying logic works properly. It takes considerably less time to run than starting a debootstrap only for it to fail later. I considered adding a remove command to docker.py but figured that might be gold plating given the relative size of the

[PATCH v1 11/15] tests/tcg: Replace /bin/true by true (required on macOS)

2021-02-02 Thread Alex Bennée
From: Stefan Weil /bin/true is missing on macOS, but simply "true" is available as a shell builtin. Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell Signed-off-by: Alex Bennée Message-Id: <20210128135627.2067003-1...@weilnetz.de> --- tests/tcg/Makefile.qemu | 4 ++-- 1 file changed, 2

Re: [RFC PATCH 2/2] hw/arm/raspi: Restrict BCM2835 / BCM2836 SoC to TCG

2021-02-02 Thread Philippe Mathieu-Daudé
On 2/2/21 2:47 PM, Peter Maydell wrote: > On Tue, 2 Feb 2021 at 13:29, Philippe Mathieu-Daudé wrote: >> >> On 2/2/21 1:28 PM, Peter Maydell wrote: >>> At the moment we can reasonably >>> say "only the 'virt' board and one of the Xilinx boards are >>> security-critical". >> >> What about the

[PATCH 04/20] vhost-user-gpu: handle display-info in a callback

2021-02-02 Thread marcandre . lureau
From: Marc-André Lureau Fixes a deadlock where the backend calls QEMU, while QEMU also calls the backend simultaneously, both ends waiting for each other. Signed-off-by: Marc-André Lureau --- contrib/vhost-user-gpu/vhost-user-gpu.c | 32 - 1 file changed, 26

Re: [RFC PATCH v3 21/31] hw/cxl/device: Add a memory device (8.2.8.5)

2021-02-02 Thread Eric Blake
On 2/1/21 6:59 PM, Ben Widawsky wrote: > A CXL memory device (AKA Type 3) is a CXL component that contains some > combination of volatile and persistent memory. It also implements the > previously defined mailbox interface as well as the memory device > firmware interface. > > Although the memory

Re: [PATCH v1 11/15] tests/tcg: Replace /bin/true by true (required on macOS)

2021-02-02 Thread Philippe Mathieu-Daudé
On Tue, Feb 2, 2021 at 3:23 PM Philippe Mathieu-Daudé wrote: > On 2/2/21 2:39 PM, Alex Bennée wrote: > > From: Stefan Weil > > > > /bin/true is missing on macOS, but simply "true" is available as a shell > > builtin. > > > > Signed-off-by: Stefan Weil > > Reviewed ... : >

[PATCH 17/20] virtio-gpu: avoid re-entering cmdq processing

2021-02-02 Thread marcandre . lureau
From: Marc-André Lureau The next patch will notify the GL context got flush, which will resume the queue processing. However, if this happens within the caller context, it will end up with a stack overflow flush/update loop. Signed-off-by: Marc-André Lureau --- include/hw/virtio/virtio-gpu.h

Re: [PATCH v4 1/2] drivers/misc: sysgenid: add system generation id driver

2021-02-02 Thread Michael S. Tsirkin
On Wed, Jan 27, 2021 at 11:15:05PM +0100, Pavel Machek wrote: > Hi! > > > - Solution > > > > The System Generation ID is a simple concept meant to alleviate the > > issue by providing a monotonically increasing u32 counter that changes > > each time the VM or container is restored from a

[PATCH 16/20] ui: add egl dmabuf import to gtkglarea

2021-02-02 Thread marcandre . lureau
From: Marc-André Lureau GtkGLArea is used on wayland, where EGL is usually available. Signed-off-by: Marc-André Lureau --- include/ui/gtk.h | 2 ++ ui/gtk-gl-area.c | 18 ++ ui/gtk.c | 22 ++ 3 files changed, 42 insertions(+) diff --git

Re: [PATCH v4 03/23] exec: Use uintptr_t for guest_base

2021-02-02 Thread Peter Maydell
On Thu, 28 Jan 2021 at 22:41, Richard Henderson wrote: > > This is more descriptive than 'unsigned long'. > No functional change, since these match on all linux+bsd hosts. > > Signed-off-by: Richard Henderson v3->v4 change: also make the places where we print it use %p and (void*)guest_base

Re: [PATCH] iotests: Revert emulator selection to old behaviour

2021-02-02 Thread Philippe Mathieu-Daudé
On 2/2/21 3:28 PM, Kevin Wolf wrote: > If the qemu-system-{arch} binary for the host architecture can't be > found, the old 'check' implementation selected the alphabetically first > system emulator binary that it could find. The new Python implementation > just uses the first result of

Re: [PATCH v3 0/5] Fix some style problems in contrib

2021-02-02 Thread Alex Bennée
zhouyang (T) writes: > kindly ping, > the link of this patch set > is:http://patchwork.ozlabs.org/project/qemu-devel/cover/20210118031004.1662363-1-zhouyang...@huawei.com/ Queued to plugins/next, thanks. (I might as well pick-up the ivshmem-server change while I'm at it as it's trivial). >

  1   2   3   4   5   >