[PATCH v7 4/6] target/i386: Add user-space MSR access interface for CET

2021-02-25 Thread Yang Weijiang
CET states are divided into user-mode and supervisor-mode states, MSR_KVM_GUEST_SSP holds current SHSTK pointer in use, MSR_IA32_U_CET and MSR_IA32_PL3_SSP are for user-mode states, others are for supervisor-mode states. Expose access according to current CET supported bits in CPUID and XSS.

[PATCH v7 5/6] target/i386: Add CET state support for guest migration

2021-02-25 Thread Yang Weijiang
Save the MSRs being used on source machine and restore them on destination machine. Signed-off-by: Yang Weijiang --- target/i386/machine.c | 161 ++ 1 file changed, 161 insertions(+) diff --git a/target/i386/machine.c b/target/i386/machine.c index

[PATCH v7 2/6] target/i386: Enable XSS feature enumeration for CPUID

2021-02-25 Thread Yang Weijiang
Currently, CPUID.(EAX=0DH,ECX=01H) doesn't enumerate features in XSS properly, add the support here. XCR0 bits indicate user-mode XSAVE components, and XSS bits indicate supervisor-mode XSAVE components. Signed-off-by: Yang Weijiang --- target/i386/cpu.c | 48

[PATCH v7 6/6] target/i386: Advise CET bits in CPU/MSR feature words

2021-02-25 Thread Yang Weijiang
CET SHSTK and IBT feature are enumerated via CPUID.(EAX=07H,ECX=0H):ECX[bit 7] and EDX[bit 20]. CET state load/restore at vmentry/vmexit are enabled via VMX_ENTRY_CTLS[bit 20] and VMX_EXIT_CTLS[bit 28]. Signed-off-by: Yang Weijiang --- target/i386/cpu.c | 8 1 file changed, 4

[PATCH v7 1/6] target/i386: Change XSAVE related feature-word names

2021-02-25 Thread Yang Weijiang
Rename XSAVE related feature-words for introducing XSAVES related feature-words. Signed-off-by: Yang Weijiang --- target/i386/cpu.c | 24 target/i386/cpu.h | 4 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c

[PATCH v7 0/6] Enable CET support for guest

2021-02-25 Thread Yang Weijiang
Control-flow Enforcement Technology (CET) provides protection against Return/Jump-Oriented Programming (ROP/JOP). It includes two features: Shadow Stack(SHSTK) and Indirect Branch Tracking(IBT). This patch series is to enable CET related CPUID report, XSAVES/XRSTORS support and MSR access etc. for

[PATCH v7 3/6] target/i386: Enable CET components support for XSAVES

2021-02-25 Thread Yang Weijiang
CET Shadow Stack(SHSTK) and Indirect Branch Tracking(IBT) are enumerated via CPUID.(EAX=07H,ECX=0H):ECX[bit 7] and EDX[bit 20] respectively. Two CET bits (bit 11 and 12) are defined in MSR_IA32_XSS for XSAVES. They correspond to CET states in user and supervisor mode respectively. Signed-off-by:

Re: [PATCH 1/2] Acceptance Tests: restore downloading of VM images

2021-02-25 Thread Philippe Mathieu-Daudé
On 2/26/21 12:21 AM, Cleber Rosa wrote: > The "get-vm-images" target defined in tests/Makefile.include is a > prerequisite for "check-acceptance", so that those files get > downloaded before the Avocado job even starts. > > It looks like on c401c058a1c a TARGETS variable was introduced with a >

[PATCH 1/2] Acceptance Tests: restore downloading of VM images

2021-02-25 Thread Cleber Rosa
The "get-vm-images" target defined in tests/Makefile.include is a prerequisite for "check-acceptance", so that those files get downloaded before the Avocado job even starts. It looks like on c401c058a1c a TARGETS variable was introduced with a different content than it was previously coming from

[PATCH 2/2] Acceptance Tests: restore filtering of tests by target arch

2021-02-25 Thread Cleber Rosa
Previously, tests were being filtered by the matching target architectures to be built. The benefit, compared to the current situation, is a more concise test job that won't show tests canceled because a matching QEMU binary was not found (those tests won't even be attempted). Signed-off-by:

[PATCH 0/2] Acceptance Tests: restore the use of target related information

2021-02-25 Thread Cleber Rosa
This addresses two issues, restoring them to their previous behavior: The first one, reported by Thomas Huth, a test timeout (and thus a job failed) on CI. The test was interrupted because of a download timeout. The download timeout happened due to the fact that "make get-vm-images" is

Re: [PATCH] multiprocess: move feature to meson_options.txt

2021-02-25 Thread Philippe Mathieu-Daudé
On 2/25/21 6:50 PM, Jag Raman wrote: > > >> On Feb 25, 2021, at 11:35 AM, Stefan Hajnoczi wrote: >> >> On Thu, Feb 25, 2021 at 01:15:53PM +0100, Paolo Bonzini wrote: >>> On 25/02/21 11:38, Philippe Mathieu-Daudé wrote: On 2/24/21 1:23 PM, Paolo Bonzini wrote: > Signed-off-by: Paolo

Re: [PATCH v2 0/2] tests: Add functional test for out-of-process device emulation

2021-02-25 Thread Philippe Mathieu-Daudé
On 2/25/21 9:59 PM, Willian Rampazzo wrote: > This series is a respin to the "multi-process: Acceptance test for multiproce= > ss > QEMU" patch sent in December which, runs an Avocado functional test to check = > if a > remote lsi53c895a device gets identified by the guest: >

[RFC PATCH 2/3] hw/block/pflash: Move code around

2021-02-25 Thread Philippe Mathieu-Daudé
First do the block checks, so we know if it is read-only or not. Then create the MemoryRegion. This will allow optimization in the next commit. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/pflash_cfi01.c | 24 hw/block/pflash_cfi02.c | 18 +- 2

[RFC PATCH 3/3] hw/block/pflash: use memory_region_init_rom_device_from_file()

2021-02-25 Thread Philippe Mathieu-Daudé
If the block drive is read-only we will model a "protected" flash device. We can thus use memory_region_init_rom_device_from_file() which mmap the backing file when creating the MemoryRegion. If the same backing file is used by multiple QEMU instances, this reduces the memory footprint (this is

[RFC PATCH 1/3] exec/memory: Introduce memory_region_init_rom_device_from_file()

2021-02-25 Thread Philippe Mathieu-Daudé
Introduce memory_region_init_rom_device_from_file() which mmap the backing file of ROM devices. This allows to reduce QEMU memory footprint as the same file can be shared between multiple instances of QEMU. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/memory.h | 85

[RFC PATCH 0/3] hw/block/pflash: Mmap read-only backend files with MAP_SHARED

2021-02-25 Thread Philippe Mathieu-Daudé
Hi, This series aims to reduce the memory footprint of flash devices when the backing file is read-only. When a backing file is read-only, the model considers the flash is in "protected" mode. No write are allowed, but the MMIO state machine is still usable. This series introduces a new memory

Re: [PATCH v2 03/31] qapi/qom: Add ObjectOptions for iothread

2021-02-25 Thread Eric Blake
On 2/24/21 7:52 AM, Kevin Wolf wrote: > Add an ObjectOptions union that will eventually describe the options of > all user creatable object types. As unions can't exist without any > branches, also add the first object type. > > This adds a QAPI schema for the properties of the iothread object. >

Re: [PATCH v2 02/31] qapi/qom: Drop deprecated 'props' from object-add

2021-02-25 Thread Eric Blake
On 2/24/21 7:52 AM, Kevin Wolf wrote: > The option has been deprecated in QEMU 5.0, remove it. > > Signed-off-by: Kevin Wolf > --- > qapi/qom.json| 6 +- > docs/system/deprecated.rst | 5 - > docs/system/removed-features.rst | 5 + > qom/qom-qmp-cmds.c

Re: [PATCH v2 01/31] tests: Drop 'props' from object-add calls

2021-02-25 Thread Eric Blake
On 2/24/21 7:52 AM, Kevin Wolf wrote: > The 'props' option has been deprecated in 5.0 in favour of a flattened > object-add command. Time to change our test cases to drop the deprecated > option. > > Signed-off-by: Kevin Wolf > --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software

Re: [PATCH v2 07/10] target/hexagon: import lexer for idef-parser

2021-02-25 Thread Richard Henderson
On 2/25/21 7:18 AM, Alessandro Di Federico wrote: > From: Paolo Montesel > > Signed-off-by: Alessandro Di Federico > Signed-off-by: Paolo Montesel > --- > target/hexagon/idef-parser/idef-parser.h | 245 +++ > target/hexagon/idef-parser/idef-parser.lex| 647 ++ >

Re: [PATCH v3 07/16] qapi/expr.py: Add casts in a few select cases

2021-02-25 Thread John Snow
On 2/25/21 7:07 AM, Markus Armbruster wrote: Unfortunately, the "check" in check_exprs falls off almost immediately. What do you mean by "falls off"? mypy loses the constraint in its static analysis. i.e. all of the work we do in expr.py is almost entirely opaque to mypy.

Re: [PATCH v3 10/16] qapi/expr.py: Remove single-letter variable

2021-02-25 Thread John Snow
On 2/25/21 9:03 AM, Markus Armbruster wrote: Why? Is it to appease a style checker? I disagree with a blanket ban of single-letter variable names. If @f is deemed too terrible to live, then I'd prefer @feat over @feature, because it's more visually distant to @features. Yeah, pylint. We've

Re: [PATCH] hw/elf_ops: Fix a typo

2021-02-25 Thread Stefano Garzarella
On Thu, Feb 25, 2021 at 07:13:44PM +0100, Philippe Mathieu-Daudé wrote: g_mapped_file_new_from_fd()'s parameter is named 'writable'. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/elf_ops.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/elf_ops.h

Re: [PATCH v2 06/10] target/hexagon: prepare input for the idef-parser

2021-02-25 Thread Richard Henderson
On 2/25/21 7:18 AM, Alessandro Di Federico wrote: > From: Alessandro Di Federico > > Introduce infrastructure necessary to produce a file suitable for being > parsed by the idef-parser. > > Signed-off-by: Alessandro Di Federico > --- > target/hexagon/gen_idef_parser_funcs.py | 114

Re: [PATCH v3 09/16] qapi/expr.py: Consolidate check_if_str calls in check_if

2021-02-25 Thread John Snow
On 2/25/21 9:23 AM, Markus Armbruster wrote: John Snow writes: This is a small rewrite to address some minor style nits. Don't compare against the empty list to check for the empty condition, and move the normalization forward to unify the check on the now-normalized structure. With the

[PATCH 1/1] qemu_timer.c: add timer_deadline_ms() helper

2021-02-25 Thread Daniel Henrique Barboza
The pSeries machine is using QEMUTimer internals to return the timeout in seconds for a timer object, in hw/ppc/spapr.c, function spapr_drc_unplug_timeout_remaining_sec(). Create a helper in qemu-timer.c to retrieve the deadline for a QEMUTimer object, in ms, to avoid exposing timer internals to

Re: [PATCH] qemu_fw_cfg: Make fw_cfg_rev_attr a proper kobj_attribute

2021-02-25 Thread Kees Cook
On Thu, 11 Feb 2021 12:42:58 -0700, Nathan Chancellor wrote: > fw_cfg_showrev() is called by an indirect call in kobj_attr_show(), > which violates clang's CFI checking because fw_cfg_showrev()'s second > parameter is 'struct attribute', whereas the ->show() member of 'struct > kobj_structure'

[PATCH v2 1/2] avocado_qemu: add exec_command function

2021-02-25 Thread Willian Rampazzo
Sometimes a test needs to send a command to a console without waiting for a pattern as a result, or the command issued do not produce any kind of output, like, for example, a `mount` command. This introduces the `exec_command` function to the avocado_qemu, allowing the test to send a command to

[PATCH v2 2/2] tests: Add functional test for out-of-process device emulation

2021-02-25 Thread Willian Rampazzo
From: Jagannathan Raman Runs the Avocado acceptance test to check if a remote lsi53c895a device gets identified by the guest. Signed-off-by: Elena Ufimtseva Signed-off-by: John G Johnson Signed-off-by: Jagannathan Raman Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Marc-André Lureau

[PATCH v2 0/2] tests: Add functional test for out-of-process device emulation

2021-02-25 Thread Willian Rampazzo
This series is a respin to the "multi-process: Acceptance test for multiproce= ss QEMU" patch sent in December which, runs an Avocado functional test to check = if a remote lsi53c895a device gets identified by the guest: https://www.mail-archive.com/qemu-devel@nongnu.org/msg769188.html First, we

Re: [PATCH v2 1/1] hw/s390x: modularize virtio-gpu-ccw

2021-02-25 Thread Halil Pasic
On Wed, 24 Feb 2021 17:46:34 +0100 Halil Pasic wrote: > On Wed, 24 Feb 2021 12:36:17 +0100 > Gerd Hoffmann wrote: [..] > > > > > -static TypeImpl *type_register_internal(const TypeInfo *info) > > > +static TypeImpl *type_register_internal(const TypeInfo *info, bool > > > mayfail) > > > { >

[PATCH 4/4] linux user: added tests for proc myself

2021-02-25 Thread aladjev . andrew
From: Andrew Aladjev --- tests/tcg/multiarch/linux-test.c | 85 1 file changed, 85 insertions(+) diff --git a/tests/tcg/multiarch/linux-test.c b/tests/tcg/multiarch/linux-test.c index 96bbad5..4918d45 100644 --- a/tests/tcg/multiarch/linux-test.c +++

[PATCH 3/4] linux user: refactored is proc myself, added support for fd/

2021-02-25 Thread aladjev . andrew
From: Andrew Aladjev --- linux-user/syscall.c | 12 ++-- linux-user/syscall_proc.c | 113 +++--- linux-user/syscall_proc.h | 5 +- 3 files changed, 101 insertions(+), 29 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index

[PATCH 2/4] linux user: moved is proc functions to separate file

2021-02-25 Thread aladjev . andrew
From: Andrew Aladjev --- linux-user/meson.build| 1 + linux-user/syscall.c | 33 + linux-user/syscall_proc.c | 32 linux-user/syscall_proc.h | 7 +++ 4 files changed, 41 insertions(+), 32 deletions(-) create mode

[PATCH 1/4] linux user: make execfd global (like exec path) and keep it open

2021-02-25 Thread aladjev . andrew
From: Andrew Aladjev User opens /proc/self/exe symlink, than kernel should create /proc/self/fd/ symlink. We should be able to detect both exe and fd/ symlinks to provide common behaviour. The easiest solution is to make execfd global and keep it open. This solution looks acceptable because

Re: [PATCH v3 08/16] qapi/expr.py: add type hint annotations

2021-02-25 Thread John Snow
On 2/25/21 8:56 AM, Markus Armbruster wrote: John Snow writes: Annotations do not change runtime behavior. This commit *only* adds annotations. Signed-off-by: John Snow Reviewed-by: Eduardo Habkost Reviewed-by: Cleber Rosa --- scripts/qapi/expr.py | 71

Re: [PATCH v2 05/10] target/hexagon: expose next PC in DisasContext

2021-02-25 Thread Richard Henderson
On 2/25/21 7:18 AM, Alessandro Di Federico wrote: > From: Paolo Montesel > > Signed-off-by: Alessandro Di Federico > Signed-off-by: Paolo Montesel > --- > target/hexagon/translate.c | 4 +++- > target/hexagon/translate.h | 1 + > 2 files changed, 4 insertions(+), 1 deletion(-) > +

Re: [PATCH v2 01/10] target/hexagon: update MAINTAINERS for idef-parser

2021-02-25 Thread Richard Henderson
On 2/25/21 7:18 AM, Alessandro Di Federico wrote: > From: Alessandro Di Federico > > Signed-off-by: Alessandro Di Federico > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 03/10] target/hexagon: make helper functions non-static

2021-02-25 Thread Richard Henderson
On 2/25/21 7:18 AM, Alessandro Di Federico wrote: > From: Paolo Montesel > > Make certain helper functions non-static, making them available outside > genptr.c. These functions are required by code generated by the > idef-parser. > > Signed-off-by: Alessandro Di Federico > Signed-off-by: Paolo

Re: [PATCH v2 04/10] target/hexagon: introduce new helper functions

2021-02-25 Thread Richard Henderson
On 2/25/21 7:18 AM, Alessandro Di Federico wrote: > From: Niccolò Izzo > > These helpers will be employed by the idef-parser generated code. > > Signed-off-by: Alessandro Di Federico > Signed-off-by: Niccolò Izzo > --- > target/hexagon/genptr.c | 227 +++-

Re: [PATCH v3 03/16] qapi/expr.py: constrain incoming expression types

2021-02-25 Thread John Snow
On 2/25/21 6:56 AM, Markus Armbruster wrote: John Snow writes: On 2/24/21 5:01 AM, Markus Armbruster wrote: John Snow writes: mypy does not know the types of values stored in Dicts that masquerade as objects. Help the type checker out by constraining the type. Signed-off-by: John Snow

Re: [PATCH v2 02/10] target/hexagon: import README for idef-parser

2021-02-25 Thread Richard Henderson
On 2/25/21 7:18 AM, Alessandro Di Federico wrote: > +Now let's have a quick look at the generated code, line by line. > + > +:: > + > + tcg_gen_movi_i32(RdV, 0); > + > +This code starts by initializing ``RdV``, since reading from that register > +without initialization will cause a segmentation

Re: [RFC v1 27/38] target/arm: move sve_zcr_len_for_el to common_cpu

2021-02-25 Thread Claudio Fontana
On 2/25/21 6:28 PM, Claudio Fontana wrote: > On 2/22/21 7:06 AM, Richard Henderson wrote: >> On 2/21/21 1:24 AM, Claudio Fontana wrote: >>> From: Claudio Fontana >>> >>> it is needed for KVM too. >>> >>> Signed-off-by: Claudio Fontana >>> --- >>> target/arm/cpu-common.c | 33

Re: [PATCH v4 0/6] Pegasos2 emulation

2021-02-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1614282456.git.bala...@eik.bme.hu/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: cover.1614282456.git.bala...@eik.bme.hu Subject: [PATCH v4 0/6] Pegasos2 emulation === TEST

[PATCH v4 6/6] hw/ppc: Add emulation of Genesi/bPlan Pegasos II

2021-02-25 Thread BALATON Zoltan
Add new machine called pegasos2 emulating the Genesi/bPlan Pegasos II, a PowerPC board based on the Marvell MV64361 system controller and the VIA VT8231 integrated south bridge/superio chips. It can run Linux, AmigaOS and a wide range of MorphOS versions. Currently a firmware ROM image is needed

Re: [PATCH v3 02/16] qapi/expr.py: Check for dict instead of OrderedDict

2021-02-25 Thread John Snow
On 2/25/21 5:40 AM, Markus Armbruster wrote: John Snow writes: On 2/24/21 4:30 AM, Markus Armbruster wrote: John Snow writes: OrderedDict is a subtype of dict, so we can check for a more general form. These functions do not themselves depend on it being any particular type. True. The

[PATCH v4 3/6] vt82c686: Add VT8231_SUPERIO based on VIA_SUPERIO

2021-02-25 Thread BALATON Zoltan
The VT8231 south bridge is very similar to VT82C686B but there are some differences in register addresses and functionality, e.g. the VT8231 only has one serial port. This commit adds VT8231_SUPERIO subclass based on the abstract VIA_SUPERIO class to emulate the superio part of VT8231.

[PATCH v4 2/6] vt82c686: QOM-ify superio related functionality

2021-02-25 Thread BALATON Zoltan
Collect superio functionality and its controlling config registers handling in an abstract VIA_SUPERIO class that is a subclass of ISA_SUPERIO and put vt82c686b specific parts in a subclass of this abstract class. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 240

[PATCH v4 5/6] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller

2021-02-25 Thread BALATON Zoltan
The Marvell Discovery II aka. MV64361 is a PowerPC system controller chip that is used on the pegasos2 PPC board. This adds emulation of it that models the device enough to boot guests on this board. The mv643xx.h header with register definitions is taken from Linux 4.15.10 only fixing end of line

[PATCH v4 4/6] vt82c686: Add emulation of VT8231 south bridge

2021-02-25 Thread BALATON Zoltan
Add emulation of VT8231 south bridge ISA part based on the similar VT82C686B but implemented in a separate subclass that holds the differences while reusing parts that can be shared. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 154 ++

[PATCH v4 1/6] vt82c686: Implement control of serial port io ranges via config regs

2021-02-25 Thread BALATON Zoltan
In VIA super south bridge the io ranges of superio components (parallel and serial ports and FDC) can be controlled by superio config registers to set their base address and enable/disable them. This is not easy to implement in QEMU because ISA emulation is only designed to set io base address

[PATCH v4 0/6] Pegasos2 emulation

2021-02-25 Thread BALATON Zoltan
Hello, This is adding a new PPC board called pegasos2. More info on it can be found at: https://osdn.net/projects/qmiga/wiki/SubprojectPegasos2 Currently it needs a firmware ROM image that I cannot include due to original copyright holder (bPlan) did not release it under a free licence but I

Re: [PATCH 7/7] ui/gtk: add clipboard support

2021-02-25 Thread Marc-André Lureau
On Fri, Feb 19, 2021 at 5:29 PM Gerd Hoffmann wrote: > This patch adds clipboard support to the qemu gtk ui. > > Signed-off-by: Gerd Hoffmann > --- > include/ui/gtk.h | 9 > ui/gtk-clipboard.c | 124 + > ui/gtk.c | 1 + >

Re: [PATCH v2 1/2] tests/acceptance: replace unstable apt.armbian.com URLs for orangepi-pc, cubieboard

2021-02-25 Thread Niek Linnenbank
Hi Philippe, Thomas, Daniel, Thank you all. Then I'll just prepare a new version of the patch that uses currently working archive.armbian.com links. Kind regards, Niek On Thu, Feb 25, 2021 at 10:46 AM Daniel P. Berrangé wrote: > On Wed, Feb 24, 2021 at 09:02:51PM +0100, Niek Linnenbank wrote:

Re: QEMU CI failed due to canceled download

2021-02-25 Thread Cleber Rosa
On Thu, Feb 25, 2021 at 05:51:08AM +0100, Thomas Huth wrote: > > Hi, > > I just faced this failure in the CI: > > https://gitlab.com/thuth/qemu/-/jobs/1053467007#L73 > > I thought we'd handle CANCEL as "skipped"? Why did this > cause the CI to fail? > Hi Thomas, Like Wainer pointed out,

Re: [PATCH v2 00/42] esp: consolidate PDMA transfer buffers and other fixes

2021-02-25 Thread Mark Cave-Ayland
On 25/02/2021 10:50, Philippe Mathieu-Daudé wrote: Thanks Phil - I understand that a set of 42 patches for a 25 year old disk controller is never going to be the top of most people's review list, and some parts are almost impossible to review unless you have a good understanding of the

Re: [PATCH v5 1/1] virtio-net: Add check for mac address while peer is vdpa

2021-02-25 Thread Michael S. Tsirkin
On Fri, Feb 26, 2021 at 12:55:06AM +0800, Cindy Lu wrote: > While peer is vdpa, sometime qemu get an all zero mac address from the > hardware, > This is not a legal value. Add the check for this.if we get an zero mac > address. > qemu will use the default mac address or the mac address from qemu

Re: [PATCH 5/7] ui/vnc: clipboard support

2021-02-25 Thread Marc-André Lureau
On Fri, Feb 19, 2021 at 5:25 PM Gerd Hoffmann wrote: > This patch adds support for cut+paste to the qemu vnc server, which > allows the vnc client exchange clipbaord data with qemu and other peers > clipboard like the qemu vdagent implementation. > > Signed-off-by: Gerd Hoffmann > --- >

Re: [PULL 00/17] pc,virtio,pci: fixes, tests

2021-02-25 Thread Peter Maydell
On Tue, 23 Feb 2021 at 16:03, Michael S. Tsirkin wrote: > > The following changes since commit 7ef8134565dccf9186d5eabd7dbb4ecae6dead87: > > Merge remote-tracking branch > 'remotes/edgar/tags/edgar/cris-next-2021-02-22.for-upstream' into staging > (2021-02-22 14:20:32 +) > > are available

Re: [PATCH] nbd: server: Report holes for raw images

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
19.02.2021 19:58, Eric Blake wrote: On 2/19/21 10:42 AM, Eric Blake wrote: To me, data=false looks compatible with NBD_STATE_HOLE. From user point of view, getting same results from qemu-nbd and qemu-img is more important than being more correct about allocation status. More to the point,

Re: [PATCH 4/7] ui/vdagent: add clipboard support

2021-02-25 Thread Marc-André Lureau
On Fri, Feb 19, 2021 at 5:19 PM Gerd Hoffmann wrote: > This patch adds support for clipboard messages to the qemu vdagent > implementation, which allows the guest exchange clipboard data with > qemu. Clipboard support can be enabled/disabled using the new > 'clipboard' parameter for the vdagent

RE: [PATCH] target/hexagon/gen_tcg_funcs: Fix a typo

2021-02-25 Thread Taylor Simpson
> -Original Message- > From: Philippe Mathieu-Daudé On > Behalf Of Philippe Mathieu-Daudé > Sent: Thursday, February 25, 2021 12:15 PM > To: qemu-devel@nongnu.org > Cc: qemu-triv...@nongnu.org; Taylor Simpson ; > Philippe Mathieu-Daudé > Subject: [PATCH] target/hexagon/gen_tcg_funcs:

Re: [PATCH 2/7] ui/vdagent: core infrastructure

2021-02-25 Thread Marc-André Lureau
Hi On Fri, Feb 19, 2021 at 5:17 PM Gerd Hoffmann wrote: > The vdagent protocol allows the guest agent (spice-vdagent) and the > spice client exchange messages to implement features which require > guest cooperation, for example clipboard support. > > This is a qemu implementation of the spice

[PATCH] exec/memory: Use struct Object typedef

2021-02-25 Thread Philippe Mathieu-Daudé
We forward-declare Object typedef in "qemu/typedefs.h" since commit ca27b5eb7cd ("qom/object: Move Object typedef to 'qemu/typedefs.h'"). Use it everywhere to make the code simpler. Signed-off-by: Philippe Mathieu-Daudé --- include/exec/memory.h | 32

[PATCH] target/hexagon/gen_tcg_funcs: Fix a typo

2021-02-25 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- target/hexagon/gen_tcg_funcs.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/target/hexagon/gen_tcg_funcs.py b/target/hexagon/gen_tcg_funcs.py index fe4d8e57303..db9f663a778 100755 ---

Re: [PATCH] nbd: server: Report holes for raw images

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
19.02.2021 19:07, Nir Soffer wrote: When querying image extents for raw image, qemu-nbd reports holes as zero: $ qemu-nbd -t -r -f raw empty-6g.raw $ qemu-img map --output json nbd://localhost [{ "start": 0, "length": 6442450944, "depth": 0, "zero": true, "data": true, "offset": 0}] $

[PATCH] hw/elf_ops: Fix a typo

2021-02-25 Thread Philippe Mathieu-Daudé
g_mapped_file_new_from_fd()'s parameter is named 'writable'. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/elf_ops.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/elf_ops.h b/include/hw/elf_ops.h index 8e8436831d2..304f266bf3b 100644 ---

Re: link to User documentation of https://wiki.qemu.org/Features/Tracing is broken currently

2021-02-25 Thread Stefan Hajnoczi
On Wed, Feb 24, 2021 at 05:51:16PM +, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > On Fri, Feb 19, 2021 at 07:31:21PM +0100, Claudio Fontana wrote: > >> the link to User documentation of https://wiki.qemu.org/Features/Tracing > >> is broken currently: > >> > >> it points to: > >>

Re: [PATCH 00/14] deprecations: remove many old deprecations

2021-02-25 Thread Jim Fehlig
Adding xen-devel and Ian to cc. On 2/24/21 6:11 AM, Daniel P. Berrangé wrote: The following features have been deprecated for well over the 2 release cycle we promise This reminded me of a bug report we received late last year when updating to 5.2.0. 'virsh setvcpus' suddenly stopped working

Re: [PATCH] multiprocess: move feature to meson_options.txt

2021-02-25 Thread Jag Raman
> On Feb 25, 2021, at 11:35 AM, Stefan Hajnoczi wrote: > > On Thu, Feb 25, 2021 at 01:15:53PM +0100, Paolo Bonzini wrote: >> On 25/02/21 11:38, Philippe Mathieu-Daudé wrote: >>> On 2/24/21 1:23 PM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- configure | 12

[Bug 1916344] Re: User mode networking not working properly on QEMU on Mac OS X host

2021-02-25 Thread Adam Chappell
Different problem here I think John. If you run the following you should the user mode networking that involves Slirp and has the problem. ``` qemu-system-i386 -m 700 -hda -net user -net nic ``` It's worth noting however that the problem most regularly manifest itself when a remote server

block/throttle and burst bucket

2021-02-25 Thread Peter Lieven
Hi, I was wondering if there is a way to check from outside (qmp etc.) if a throttled block device has exceeded the iops_max_length seconds of time bursting up to iops_max and is now hard limited to the iops limit that is supplied? Would it be also a good idea to exetend the accounting to

Re: [RFC v1 27/38] target/arm: move sve_zcr_len_for_el to common_cpu

2021-02-25 Thread Claudio Fontana
On 2/22/21 7:06 AM, Richard Henderson wrote: > On 2/21/21 1:24 AM, Claudio Fontana wrote: >> From: Claudio Fontana >> >> it is needed for KVM too. >> >> Signed-off-by: Claudio Fontana >> --- >> target/arm/cpu-common.c | 33 + >> target/arm/tcg/helper.c | 33

Re: [PATCH v5 0/9] block: Add retry for werror=/rerror= mechanism

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
23.02.2021 16:41, Eric Blake wrote: On 2/23/21 3:40 AM, Stefan Hajnoczi wrote: On Fri, Feb 05, 2021 at 06:13:06PM +0800, Jiahui Cen wrote: This patch series propose to extend the werror=/rerror= mechanism to add a 'retry' feature. It can automatically retry failed I/O requests on error without

Re: [PATCH] virtio-iommu: Default to bypass during boot

2021-02-25 Thread Jean-Philippe Brucker
On Sun, Feb 21, 2021 at 06:45:18AM -0500, Michael S. Tsirkin wrote: > On Thu, Feb 18, 2021 at 11:59:30AM +0100, Jean-Philippe Brucker wrote: > > Currently the virtio-iommu device must be programmed before it allows > > DMA from any PCI device. This can make the VM entirely unusable when a > >

Re: [RFC PATCH v2 3/4] block: Support multiple reopening with x-blockdev-reopen

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
24.02.2021 15:33, Kevin Wolf wrote: Am 09.02.2021 um 09:03 hat Vladimir Sementsov-Ogievskiy geschrieben: 08.02.2021 21:44, Alberto Garcia wrote: Signed-off-by: Alberto Garcia --- qapi/block-core.json | 2 +- include/block/block.h | 1 + block.c| 16

[PATCH v5 1/1] virtio-net: Add check for mac address while peer is vdpa

2021-02-25 Thread Cindy Lu
While peer is vdpa, sometime qemu get an all zero mac address from the hardware, This is not a legal value. Add the check for this.if we get an zero mac address. qemu will use the default mac address or the mac address from qemu cmdline Signed-off-by: Cindy Lu --- hw/net/virtio-net.c | 10

[PATCH v5 0/1] virtio-net: Add check for mac address while peer is vdpa

2021-02-25 Thread Cindy Lu
Add check for mac address while peer is vdpa Change from v4->v5 1. Add comment for this work around 2. while copy the netconfig, only overwrite the mac address Cindy Lu (1): virtio-net: Add check for mac address while peer is vdpa hw/net/virtio-net.c | 10 ++ 1 file changed, 10

Re: 9pfs developers docs

2021-02-25 Thread Greg Kurz
On Thu, 25 Feb 2021 17:31:22 +0100 Christian Schoenebeck wrote: > On Montag, 1. Februar 2021 14:37:02 CET qemu_oss--- via wrote: > > On Montag, 1. Februar 2021 13:26:49 CET Greg Kurz wrote: > > > > > I agree that a bunch of other things should be documented, but that's > > > > > definitely a

Re: [PATCH] virtio-net: Add check for mac address while peer is vdpa

2021-02-25 Thread Cindy Lu
sure, Thanks michael, I will address, these comment and send a new version On Wed, Feb 24, 2021 at 3:59 PM Michael S. Tsirkin wrote: > > > [PATCH] virtio-net: Add check for mac address while peer is vdpa > please do keep numbering patch versions. > > > On Wed, Feb 24, 2021 at 03:33:33PM +0800,

Re: [PATCH] multiprocess: move feature to meson_options.txt

2021-02-25 Thread Stefan Hajnoczi
On Thu, Feb 25, 2021 at 01:15:53PM +0100, Paolo Bonzini wrote: > On 25/02/21 11:38, Philippe Mathieu-Daudé wrote: > > On 2/24/21 1:23 PM, Paolo Bonzini wrote: > > > Signed-off-by: Paolo Bonzini > > > --- > > > configure | 12 > > > meson.build | 9 +++-- > > >

Re: [PATCH v2 1/7] intel_iommu: Fix mask may be uninitialized in vtd_context_device_invalidate

2021-02-25 Thread Auger Eric
Hi Philippe, On 2/25/21 11:08 AM, Philippe Mathieu-Daudé wrote: > On 2/25/21 10:14 AM, Eric Auger wrote: >> With -Werror=maybe-uninitialized configuration we get >> ../hw/i386/intel_iommu.c: In function ‘vtd_context_device_invalidate’: >> ../hw/i386/intel_iommu.c:1888:10: error: ‘mask’ may be

Re: 9pfs developers docs

2021-02-25 Thread Christian Schoenebeck
On Montag, 1. Februar 2021 14:37:02 CET qemu_oss--- via wrote: > On Montag, 1. Februar 2021 13:26:49 CET Greg Kurz wrote: > > > > I agree that a bunch of other things should be documented, but that's > > > > definitely a great start. Thanks for doing this ! > > > > > > > > Just one remark on the

Re: [PATCH 1/6] net: introduce qemu_receive_packet()

2021-02-25 Thread Alexander Bulekov
On 210225 1128, Alexander Bulekov wrote: > On 210225 1931, P J P wrote: > > +-- On Wed, 24 Feb 2021, Philippe Mathieu-Daudé wrote --+ > > | On 2/24/21 2:17 PM, Jason Wang wrote: > > | > On 2021/2/24 6:11 下午, Philippe Mathieu-Daudé wrote: > > | >> IIUC the guest could trigger an infinite loop and

Re: [PATCH 1/6] net: introduce qemu_receive_packet()

2021-02-25 Thread Alexander Bulekov
On 210225 1931, P J P wrote: > +-- On Wed, 24 Feb 2021, Philippe Mathieu-Daudé wrote --+ > | On 2/24/21 2:17 PM, Jason Wang wrote: > | > On 2021/2/24 6:11 下午, Philippe Mathieu-Daudé wrote: > | >> IIUC the guest could trigger an infinite loop and brick the emulated > | >> device model. Likely

Re: [PATCH 2/5] block: Fix BDRV_BLOCK_RAW status to honor alignment

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
25.02.2021 19:03, Eric Blake wrote: On 2/25/21 8:55 AM, Vladimir Sementsov-Ogievskiy wrote: 18.02.2021 23:15, Eric Blake wrote: Previous patches mentioned how the blkdebug filter driver demonstrates a bug present in our NBD server (for example, commit b0245d64); the bug is also present with

Re: [PATCH 1/5] iotests: Update 241 to expose backing layer fragmentation

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
25.02.2021 18:52, Eric Blake wrote: On 2/25/21 8:57 AM, Vladimir Sementsov-Ogievskiy wrote: 25.02.2021 16:50, Vladimir Sementsov-Ogievskiy wrote: 18.02.2021 23:15, Eric Blake wrote: Previous commits (such as 6e280648, 75d34eb9) have mentioned that our NBD server still sends unaligned

Re: [PATCH 2/5] block: Fix BDRV_BLOCK_RAW status to honor alignment

2021-02-25 Thread Eric Blake
On 2/25/21 8:55 AM, Vladimir Sementsov-Ogievskiy wrote: > 18.02.2021 23:15, Eric Blake wrote: >> Previous patches mentioned how the blkdebug filter driver demonstrates >> a bug present in our NBD server (for example, commit b0245d64); the >> bug is also present with the raw format driver when

Re: [PATCH v2 00/10] target/hexagon: introduce idef-parser

2021-02-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210225151856.3284701-1-ale.q...@rev.ng/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210225151856.3284701-1-ale.q...@rev.ng Subject: [PATCH v2 00/10] target/hexagon:

Re: [PATCH v2 3/7] virtio-iommu: Handle non power of 2 range invalidations

2021-02-25 Thread Peter Xu
On Thu, Feb 25, 2021 at 10:14:31AM +0100, Eric Auger wrote: > Unmap notifiers work with an address mask assuming an > invalidation range of a power of 2. Nothing mandates this > in the VIRTIO-IOMMU spec. > > So in case the range is not a power of 2, split it into > several invalidations. > >

Re: [PATCH v2 2/7] dma: Introduce dma_aligned_pow2_mask()

2021-02-25 Thread Peter Xu
On Thu, Feb 25, 2021 at 10:14:30AM +0100, Eric Auger wrote: > @@ -296,4 +296,7 @@ uint64_t dma_buf_write(uint8_t *ptr, int32_t len, > QEMUSGList *sg); > void dma_acct_start(BlockBackend *blk, BlockAcctCookie *cookie, > QEMUSGList *sg, enum BlockAcctType type); > >

Re: [PATCH 13/14] block: remove 'dirty-bitmaps' field from 'BlockInfo' struct

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
24.02.2021 16:11, Daniel P. Berrangé wrote: The same data is available in the 'BlockDeviceInfo' struct. Signed-off-by: Daniel P. Berrangé Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH 1/5] iotests: Update 241 to expose backing layer fragmentation

2021-02-25 Thread Eric Blake
On 2/25/21 8:57 AM, Vladimir Sementsov-Ogievskiy wrote: > 25.02.2021 16:50, Vladimir Sementsov-Ogievskiy wrote: >> 18.02.2021 23:15, Eric Blake wrote: >>> Previous commits (such as 6e280648, 75d34eb9) have mentioned that our >>> NBD server still sends unaligned fragments when an active layer with

Re: [PATCH 12/14] block: remove dirty bitmaps 'status' field

2021-02-25 Thread Vladimir Sementsov-Ogievskiy
24.02.2021 16:11, Daniel P. Berrangé wrote: The same information is available via the 'recording' and 'busy' fields. Signed-off-by: Daniel P. Berrangé Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH] tcg/i386: rdpmc: use the the condtions

2021-02-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210225054756.35962-1-linuxma...@163.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210225054756.35962-1-linuxma...@163.com Subject: [PATCH] tcg/i386: rdpmc: use the the

Re: [PATCH 1/5] iotests: Update 241 to expose backing layer fragmentation

2021-02-25 Thread Eric Blake
On 2/25/21 7:50 AM, Vladimir Sementsov-Ogievskiy wrote: > 18.02.2021 23:15, Eric Blake wrote: >> Previous commits (such as 6e280648, 75d34eb9) have mentioned that our >> NBD server still sends unaligned fragments when an active layer with >> large advertised minimum block size is backed by another

Re: [RFC PATCH 0/5] Experimenting with tb-lookup tweaks

2021-02-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210224165811.11567-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210224165811.11567-1-alex.ben...@linaro.org Subject: [RFC PATCH 0/5] Experimenting

Re: QEMU Clock record and replay

2021-02-25 Thread Philippe Mathieu-Daudé
Cc'ing Pavel/Alex. On 2/25/21 4:09 PM, Arnabjyoti Kalita wrote: > Hello all, > > I am trying to understand how the clock values are recorded and replayed > in QEMU (when it runs in TCG mode). I have been specifically following > the document that has been provided here - >

Re: [PATCH v2 1/7] intel_iommu: Fix mask may be uninitialized in vtd_context_device_invalidate

2021-02-25 Thread Peter Xu
On Thu, Feb 25, 2021 at 10:14:29AM +0100, Eric Auger wrote: > With -Werror=maybe-uninitialized configuration we get > ../hw/i386/intel_iommu.c: In function ‘vtd_context_device_invalidate’: > ../hw/i386/intel_iommu.c:1888:10: error: ‘mask’ may be used > uninitialized in this function

<    1   2   3   4   >