Re: [PATCH v1 1/2] hw/misc: versal: Add a model of the XRAM controller

2021-03-08 Thread Peter Maydell
On Tue, 2 Mar 2021 at 11:09, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > Add a model of the Xilinx Versal Accelerator RAM (XRAM). > This is mainly a stub to make firmware happy. The size of > the RAMs can be probed. The interrupt mask logic is > modelled but none of the interrups

Re: [PATCH v4] virtio-blk: Respect discard granularity

2021-03-08 Thread Stefan Hajnoczi
On Thu, Feb 25, 2021 at 09:12:39AM +0900, Akihiko Odaki wrote: > Report the configured granularity for discard operation to the > guest. If this is not set use the block size. > > Since until now we have ignored the configured discard granularity > and always reported the block size, let's add >

[PATCH v3 06/30] qapi/qom: Add ObjectOptions for memory-backend-*

2021-03-08 Thread Kevin Wolf
This adds a QAPI schema for the properties of the memory-backend-* objects. HostMemPolicy has to be moved to an include file that can be used by the storage daemon, too, because ObjectOptions must be the same in all binaries if we don't want to compile the whole code multiple times.

[PATCH v3 11/30] qapi/qom: Add ObjectOptions for can-*

2021-03-08 Thread Kevin Wolf
This adds a QAPI schema for the properties of the can-* objects. can-bus doesn't have any properties, so it only needs to be added to the ObjectType enum without adding a new branch to ObjectOptions. Signed-off-by: Kevin Wolf Acked-by: Peter Krempa Reviewed-by: Eric Blake --- qapi/qom.json |

[PATCH v3 25/30] qom: Add user_creatable_add_from_str()

2021-03-08 Thread Kevin Wolf
This is a version of user_creatable_process_cmdline() with an Error parameter that never calls exit() and is therefore usable in HMP. Signed-off-by: Kevin Wolf Acked-by: Peter Krempa Reviewed-by: Eric Blake --- include/qom/object_interfaces.h | 16 qom/object_interfaces.c

[PATCH v3 22/30] qom: Factor out user_creatable_process_cmdline()

2021-03-08 Thread Kevin Wolf
The implementation for --object can be shared between qemu-storage-daemon and other binaries, so move it into a function in qom/object_interfaces.c that is accessible from everywhere. This also requires moving the implementation of qmp_object_add() into a new user_creatable_add_qapi(), because

Re: [PATCH v2] MAINTAINERS: Merge the Gitlab-CI section into the generic CI section

2021-03-08 Thread Thomas Huth
On 08/03/2021 17.35, Philippe Mathieu-Daudé wrote: On 3/8/21 4:46 PM, Thomas Huth wrote: The status of the gitlab-CI files is currently somewhat confusing, and it is often not quite clear whether a patch should go via my tree or via the testing tree of Alex. That situation has grown

[PATCH v3 15/30] qapi/qom: Add ObjectOptions for confidential-guest-support

2021-03-08 Thread Kevin Wolf
This adds a QAPI schema for the properties of the objects implementing the confidential-guest-support interface. pef-guest and s390x-pv-guest don't have any properties, so they only need to be added to the ObjectType enum without adding a new branch to ObjectOptions. Signed-off-by: Kevin Wolf

[PATCH v3 30/30] qom: Drop QemuOpts based interfaces

2021-03-08 Thread Kevin Wolf
user_creatable_add_opts() has only a single user left, which is a test case. Rewrite the test to use user_creatable_add_type() instead (which is the remaining function that doesn't require a QAPI schema) and drop the QemuOpts related functions. Signed-off-by: Kevin Wolf Acked-by: Peter Krempa

Re: [RFC] adding a generic QAPI event for failed device hotunplug

2021-03-08 Thread Markus Armbruster
Daniel Henrique Barboza writes: > On 3/6/21 3:57 AM, Markus Armbruster wrote: >> Cc: ACPI maintainers for additional expertise. >> >> Daniel Henrique Barboza writes: >> >>> Hi, >>> >>> Recent changes in pseries code (not yet pushed, available at David's >>> ppc-for-6.0) are using the QAPI

Re: [PATCH v1 3/3] semihosting/arg-compat: fix up handling of SYS_HEAPINFO

2021-03-08 Thread Keith Packard via
Alistair Francis writes: > I have started on the effort, but I have not finished yet. Adding > riscv_cpu_is_32bit() was the first step there and I have some more > patches locally but I don't have anything working yet. That's awesome. I think waiting until we see what APIs you're developing for

[PULL 03/54] clock: Add clock_ns_to_ticks() function

2021-03-08 Thread Peter Maydell
Add a clock_ns_to_ticks() function which does the opposite of clock_ticks_to_ns(): given a duration in nanoseconds, it returns the number of clock ticks that would happen in that time. This is useful for devices that have a free running counter register whose value can be calculated when it is

Re: [PATCH v2] MAINTAINERS: Merge the Gitlab-CI section into the generic CI section

2021-03-08 Thread Wainer dos Santos Moschetta
On 3/8/21 12:46 PM, Thomas Huth wrote: The status of the gitlab-CI files is currently somewhat confusing, and it is often not quite clear whether a patch should go via my tree or via the testing tree of Alex. That situation has grown historically... Initially, I was the only one using the

[PULL 12/54] hw/timer/sse-timer: Model the SSE Subsystem System Timer

2021-03-08 Thread Peter Maydell
The SSE-300 includes some timers which are a different kind to those in the SSE-200. Model them. These timers are documented in the SSE-123 Example Subsystem Technical Reference Manual: https://developer.arm.com/documentation/101370/latest/ Signed-off-by: Peter Maydell Tested-by: Philippe

[PULL 00/54] target-arm queue

2021-03-08 Thread Peter Maydell
) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20210308-1 for you to fetch changes up to da2140183ac3a04b1ccb861aeac1f2c048c71b66: hw/timer/renesas_tmr: Fix use of uninitialized data in read_tcnt() (2021-03-08 17:20:04 +

[PULL 17/54] hw/misc/iotkit-sysctl: Handle SSE-300 changes to PDCM_PD_*_SENSE registers

2021-03-08 Thread Peter Maydell
The sysctl PDCM_PD_*_SENSE registers control various power domains in the system and allow the guest to configure which conditions keep a power domain awake and what power state to use when the domain is in a low power state. QEMU doesn't model power domains, so for us these registers are dummy

[PULL 38/54] hw/misc/mps2-fpgaio: Support AN547 DBGCTRL register

2021-03-08 Thread Peter Maydell
For the AN547 image, the FPGAIO block has an extra DBGCTRL register, which is used to control the SPNIDEN, SPIDEN, NPIDEN and DBGEN inputs to the CPU. These signals control when the CPU permits use of the external debug interface. Our CPU models don't implement the external debug interface, so

[PULL 32/54] hw/arm/armsse: Add support for SSE variants with a system counter

2021-03-08 Thread Peter Maydell
The SSE-300 has a system counter device; add support for SSE variants having this device. As with the existing devices like the cache control block, CPUID block, etc, we don't try to make the MMIO addresses configurable. We can do that if and when we need to model a future SSE variant which has

[PULL 29/54] hw/arm/armsse: Move PPUs into data-driven framework

2021-03-08 Thread Peter Maydell
Move the PPUs into the data-driven device placement framework. We don't implement them, so they are just TYPE_UNIMPLEMENTED stubs. Because the SSE-200 and the IotKit diverge here (the IoTKit does not have the PPUs) we need to separate out the ARMSSEDeviceInfo for the two variants, and only add

Re: [PATCH v2 2/7] dma: Introduce dma_aligned_pow2_mask()

2021-03-08 Thread Peter Maydell
On Thu, 25 Feb 2021 at 09:15, Eric Auger wrote: > > Currently get_naturally_aligned_size() is used by the intel iommu > to compute the maximum invalidation range based on @size which is > a power of 2 while being aligned with the @start address and less > than the maximum range defined by @gaw. >

Re: [RFC PATCH v2] meson: Only generate trace files for selected targets

2021-03-08 Thread Stefan Hajnoczi
On Wed, Feb 24, 2021 at 10:35:15PM +0100, Philippe Mathieu-Daudé wrote: > We don't need to generate trace files for targets we > are not building. Restrict the the ones selected. > > Signed-off-by: Philippe Mathieu-Daudé > --- > meson.build | 16 > 1 file changed, 8

[PATCH v3 10/30] qapi/qom: Add ObjectOptions for tls-*, deprecate 'loaded'

2021-03-08 Thread Kevin Wolf
This adds a QAPI schema for the properties of the tls-* objects. The 'loaded' property doesn't seem to make sense as an external interface: It is automatically set to true in ucc->complete, and explicitly setting it to true earlier just means that additional options will be silently ignored. In

[PATCH v3 01/30] qapi/qom: Drop deprecated 'props' from object-add

2021-03-08 Thread Kevin Wolf
The option has been deprecated in QEMU 5.0, remove it. Signed-off-by: Kevin Wolf Acked-by: Peter Krempa Reviewed-by: Eric Blake --- qapi/qom.json| 6 +- docs/system/deprecated.rst | 5 - docs/system/removed-features.rst | 5 + qom/qom-qmp-cmds.c

[PATCH v3 09/30] qapi/qom: Add ObjectOptions for secret*, deprecate 'loaded'

2021-03-08 Thread Kevin Wolf
This adds a QAPI schema for the properties of the secret* objects. The 'loaded' property doesn't seem to make sense as an external interface: It is automatically set to true in ucc->complete, and explicitly setting it to true earlier just means that additional options will be silently ignored.

[PATCH v3 05/30] qapi/qom: Add ObjectOptions for dbus-vmstate

2021-03-08 Thread Kevin Wolf
This adds a QAPI schema for the properties of the dbus-vmstate object. A list represented as a comma separated string is clearly not very QAPI-like, but for now just describe the existing interface. Signed-off-by: Kevin Wolf Acked-by: Peter Krempa Reviewed-by: Eric Blake --- qapi/qom.json |

[PATCH v3 14/30] qapi/qom: Add ObjectOptions for pr-manager-helper

2021-03-08 Thread Kevin Wolf
This adds a QAPI schema for the properties of the pr-manager-helper object. Signed-off-by: Kevin Wolf Acked-by: Peter Krempa Reviewed-by: Eric Blake --- qapi/qom.json | 14 ++ 1 file changed, 14 insertions(+) diff --git a/qapi/qom.json b/qapi/qom.json index 6fe775bd83..6afac9169f

[PATCH v3 12/30] qapi/qom: Add ObjectOptions for colo-compare

2021-03-08 Thread Kevin Wolf
This adds a QAPI schema for the properties of the colo-compare object. Signed-off-by: Kevin Wolf Acked-by: Peter Krempa Reviewed-by: Eric Blake --- qapi/qom.json | 49 + 1 file changed, 49 insertions(+) diff --git a/qapi/qom.json

[PATCH v3 13/30] qapi/qom: Add ObjectOptions for filter-*

2021-03-08 Thread Kevin Wolf
This adds a QAPI schema for the properties of the filter-* objects. Some parts of the interface (in particular NetfilterProperties.position) are very unusual for QAPI, but for now just describe the existing interface. net.json can't be included in qom.json because the storage daemon doesn't have

[PATCH v3 16/30] qapi/qom: Add ObjectOptions for input-*

2021-03-08 Thread Kevin Wolf
This adds a QAPI schema for the properties of the input-* objects. ui.json cannot be included in qom.json because the storage daemon can't use it, so move GrabToggleKeys to common.json. Signed-off-by: Kevin Wolf Acked-by: Peter Krempa Reviewed-by: Eric Blake --- qapi/common.json | 12

[PATCH v3 27/30] hmp: QAPIfy object_add

2021-03-08 Thread Kevin Wolf
This switches the HMP command object_add from a QemuOpts-based parser to user_creatable_add_from_str() which uses a keyval parser and enforces the QAPI schema. Apart from being a cleanup, this makes non-scalar properties and help accessible. In order for help to be printed to the monitor instead

[PATCH v3 26/30] qemu-img: Use user_creatable_process_cmdline() for --object

2021-03-08 Thread Kevin Wolf
This switches qemu-img from a QemuOpts-based parser for --object to user_creatable_process_cmdline() which uses a keyval parser and enforces the QAPI schema. Apart from being a cleanup, this makes non-scalar properties accessible. Signed-off-by: Kevin Wolf Acked-by: Peter Krempa ---

Re: [PATCH 07/24] DAX: virtio-fs: Add vhost-user slave commands for mapping

2021-03-08 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Tue, Feb 09, 2021 at 07:02:07PM +, Dr. David Alan Gilbert (git) wrote: > > diff --git a/docs/interop/vhost-user.rst b/docs/interop/vhost-user.rst > > index d6085f7045..1deedd3407 100644 > > --- a/docs/interop/vhost-user.rst > > +++

Re: [PATCH] xen-block: Fix removal of backend instance via xenstore

2021-03-08 Thread Anthony PERARD via
On Mon, Mar 08, 2021 at 03:38:49PM +0100, Paolo Bonzini wrote: > On 08/03/21 15:32, Anthony PERARD wrote: > > From: Anthony PERARD > > > > Whenever a Xen block device is detach via xenstore, the image > > associated with it remained open by the backend QEMU and an error is > > logged: > >

[PULL 11/54] hw/timer/sse-counter: Model the SSE Subsystem System Counter

2021-03-08 Thread Peter Maydell
The SSE-300 includes a counter module; implement a model of it. This counter is documented in the SSE-123 Example Subsystem Technical Reference Manual: https://developer.arm.com/documentation/101370/latest/ Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard

[PULL 28/54] hw/arm/armsse: Move sysctl register block into data-driven framework

2021-03-08 Thread Peter Maydell
Move the sysctl register block into the data-driven device placement framework. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20210219144617.4782-29-peter.mayd...@linaro.org --- hw/arm/armsse.c | 44

[PULL 31/54] hw/arm/armsse: Indirect irq_is_common[] through ARMSSEInfo

2021-03-08 Thread Peter Maydell
The SSE-300 has a slightly different set of shared-per-CPU interrupts, allow the irq_is_common[] array to be different per SSE variant. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id:

[PULL 39/54] hw/misc/mps2-scc: Implement changes for AN547

2021-03-08 Thread Peter Maydell
Implement the minor changes required to the SCC block for AN547 images: * CFG2 and CFG5 exist (like AN524) * CFG3 is reserved (like AN524) * CFG0 bit 1 is CPU_WAIT; we don't implement it, but note this in the TODO comment Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé

[PULL 35/54] hw/arm/armsse: Add SSE-300 support

2021-03-08 Thread Peter Maydell
Now we have sufficiently parameterised the code, we can add SSE-300 support by adding a new entry to the armsse_variants[] array. Note that the main watchdog (unlike the s32k watchdog) in the SSE-300 is a different device from the CMSDK watchdog; we don't have a model of it so we leave it as a

[PULL 37/54] hw/misc/mps2-fpgaio: Fold counters subsection into main vmstate

2021-03-08 Thread Peter Maydell
We've already broken migration compatibility for all the MPS boards, so we might as well take advantage of this to simplify the vmstate for the FPGAIO device by folding the counters subsection into the main vmstate description. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé

Re: [PATCH v2] FreeBSD: Upgrade to 12.2 release

2021-03-08 Thread Thomas Huth
On 08/03/2021 16.26, Warner Losh wrote: On Mon, Mar 8, 2021 at 6:30 AM Thomas Huth > wrote: On 07/03/2021 16.56, Warner Losh wrote: > FreeBSD 12.1 has reached end of life. Use 12.2 instead so that FreeBSD's > project's packages will work.  Update which

[PATCH v2] MAINTAINERS: Merge the Gitlab-CI section into the generic CI section

2021-03-08 Thread Thomas Huth
The status of the gitlab-CI files is currently somewhat confusing, and it is often not quite clear whether a patch should go via my tree or via the testing tree of Alex. That situation has grown historically... Initially, I was the only one using the gitlab-CI, just for my private repository

Re: [PATCH] inet_parse: Clarify IPv6 comment and error message

2021-03-08 Thread Eric Blake
On 3/8/21 5:30 AM, Daniel P. Berrangé wrote: > On Sun, Mar 07, 2021 at 05:31:24PM -0800, Doug Evans wrote: >> Not sure how this "Author email address is mangled" happened. >> >> $ git format-patch -o patches/error-parsing-ipv6 -1 >> $ git send-email --to='qemu-devel@nongnu.org,Samuel Thibault < >>

Re: [PATCH] Document qemu-img options data_file and data_file_raw

2021-03-08 Thread Connor Kuehl
On 3/1/21 11:28 AM, Connor Kuehl wrote: The contents of this patch were initially developed and posted by Han Han[1], however, it appears the original patch was not applied. Since then, the relevant documentation has been moved and adapted to a new format. I've taken most of the original

[PATCH v3 04/30] qapi/qom: Add ObjectOptions for cryptodev-*

2021-03-08 Thread Kevin Wolf
This adds a QAPI schema for the properties of the cryptodev-* objects. These interfaces have some questionable aspects (cryptodev-backend is really an abstract base class without function, and the queues option only makes sense for cryptodev-vhost-user), but as the goal is to represent the

Re: [PATCH v1 1/1] vfio: Make migration support non experimental by default.

2021-03-08 Thread Cornelia Huck
On Mon, 8 Mar 2021 21:39:49 +0530 Tarun Gupta wrote: > VFIO migration support in QEMU is experimental as of now, which was done to > provide soak time and resolve concerns regarding bit-stream. > But, with the patches discussed in >

Re: [PATCH v3] target/arm: Restrict v7A TCG cpus to TCG accel

2021-03-08 Thread Peter Maydell
On Sat, 6 Mar 2021 at 15:18, Philippe Mathieu-Daudé wrote: > > KVM requires the target cpu to be at least ARMv8 architecture > (support on ARMv7 has been dropped in commit 82bf7ae84ce: > "target/arm: Remove KVM support for 32-bit Arm hosts"). > > A KVM-only build won't be able to run TCG cpus,

[PATCH v3 23/30] qemu-io: Use user_creatable_process_cmdline() for --object

2021-03-08 Thread Kevin Wolf
This switches qemu-io from a QemuOpts-based parser for --object to user_creatable_process_cmdline() which uses a keyval parser and enforces the QAPI schema. Apart from being a cleanup, this makes non-scalar properties accessible. Signed-off-by: Kevin Wolf Acked-by: Peter Krempa Reviewed-by:

[PULL v2 00/30] Block layer patches

2021-03-08 Thread Kevin Wolf
The following changes since commit 138d2931979cb7ee4a54a434a54088231f6980ff: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20210308' into staging (2021-03-08 11:57:36 +) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream

[PULL 04/54] hw/timer/npcm7xx_timer: Use new clock_ns_to_ticks()

2021-03-08 Thread Peter Maydell
Use the new clock_ns_to_ticks() function in npcm7xx_timer where appropriate. Signed-off-by: Peter Maydell Reviewed-by: Luc Michel Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Hao Wu Tested-by: Philippe Mathieu-Daudé Message-id: 20210219144617.4782-5-peter.mayd...@linaro.org ---

[PULL 14/54] hw/misc/iotkit-sysctl: Handle CPU_WAIT, NMI_ENABLE for SSE-300

2021-03-08 Thread Peter Maydell
In the SSE-300 the CPU_WAIT and NMI_ENABLE registers have moved offsets, so they are now where the SSE-200's WICCTRL and EWCTRL were. The SSE-300 does not have WICCTLR or EWCTRL at all, and the old offsets are reserved: OffsetSSE-200 SSE-300 --- 0x118

Re: [PATCH v8] drivers/misc: sysgenid: add system generation id driver

2021-03-08 Thread Greg KH
On Mon, Mar 08, 2021 at 05:03:58PM +0100, Alexander Graf wrote: > > > On 08.03.21 15:36, Greg KH wrote: > > > > On Mon, Mar 08, 2021 at 04:18:03PM +0200, Adrian Catangiu wrote: > > > +static struct miscdevice sysgenid_misc = { > > > + .minor = MISC_DYNAMIC_MINOR, > > > + .name =

[PULL 06/54] hw/misc/iotkit-sysctl: Remove is_sse200 flag

2021-03-08 Thread Peter Maydell
Remove the is_sse200 flag in favour of just directly testing the new sse_version field. Since some of these registers exist in the SSE-300 but some do not or have different behaviour, we expand out the if() statements in the read and write functions into switch()es, so we have an easy place to

[PULL 19/54] hw/arm/Kconfig: Move ARMSSE_CPUID and ARMSSE_MHU stanzas to hw/misc

2021-03-08 Thread Peter Maydell
The ARMSSE_CPUID and ARMSSE_MHU Kconfig stanzas are for the devices implemented by hw/misc/cpuid.c and hw/misc/armsse-mhu.c. Move them to hw/misc/Kconfig where they belong. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard

[PULL 50/54] hw/arm: xlnx-zynqmp: Connect a Xilinx CSU DMA module for QSPI

2021-03-08 Thread Peter Maydell
From: Xuzhou Cheng Add a Xilinx CSU DMA module to ZynqMP SoC, and connent the stream link of GQSPI to CSU DMA. Signed-off-by: Xuzhou Cheng Signed-off-by: Bin Meng Reviewed-by: Edgar E. Iglesias Message-id: 20210303135254.3970-4-bmeng...@gmail.com Signed-off-by: Peter Maydell ---

[PULL 20/54] hw/misc/sse-cpu-pwrctrl: Implement SSE-300 CPU_PWRCTRL register block

2021-03-08 Thread Peter Maydell
The SSE-300 has a new register block CPU_PWRCTRL. There is one instance of this per CPU in the system (so just one for the SSE-300), and as well as the usual CIDR/PIDR ID registers it has just one register, CPUPWRCFG. This register allows the guest to configure behaviour of the system in

[PULL 23/54] hw/arm/armsse: Add framework for data-driven device placement

2021-03-08 Thread Peter Maydell
The SSE-300 is mostly the same as the SSE-200, but it has moved some of the devices in the memory map and uses different device types in some cases. To accommodate this, add a framework where the placement and wiring of some devices can be specified in a data table. This commit adds the

[PULL 24/54] hw/arm/armsse: Move dual-timer device into data-driven framework

2021-03-08 Thread Peter Maydell
Move the CMSDK dualtimer device handling into the data-driven device placement framework. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20210219144617.4782-25-peter.mayd...@linaro.org --- hw/arm/armsse.c | 35

[PULL 15/54] hw/misc/iotkit-sysctl: Handle INITSVTOR* for SSE-300

2021-03-08 Thread Peter Maydell
The SSE-300 has only one CPU and so no INITSVTOR1. It does have INITSVTOR0, but unlike the SSE-200 this register now has a LOCK bit which can be set to 1 to prevent any further writes to the register. Implement these differences. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé

[PULL 30/54] hw/arm/armsse: Add missing SSE-200 SYS_PPU

2021-03-08 Thread Peter Maydell
We forgot to implement a TYPE_UNIMPLEMENTED_DEVICE stub for the SYS_PPU in the SSE-200, which is at 0x50022000. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20210219144617.4782-31-peter.mayd...@linaro.org --- include/hw/arm/armsse.h

[PULL 25/54] hw/arm/armsse: Move watchdogs into data-driven framework

2021-03-08 Thread Peter Maydell
Move the CMSDK watchdog device handling into the data-driven device placement framework. This is slightly more complicated because these devices might wire their IRQs up to the NMI line, and because one of them uses the slow 32KHz clock rather than the main clock. Signed-off-by: Peter Maydell

Re: [PATCH RFC 1/4] hw/block/nvme: convert dsm to aiocb

2021-03-08 Thread Klaus Jensen
On Mar 8 16:37, Stefan Hajnoczi wrote: > On Tue, Mar 02, 2021 at 12:10:37PM +0100, Klaus Jensen wrote: > > +static void nvme_dsm_cancel(BlockAIOCB *aiocb) > > +{ > > +NvmeDSMAIOCB *iocb = container_of(aiocb, NvmeDSMAIOCB, common); > > + > > +/* break loop */ > > +iocb->curr.len = 0; >

[PULL 46/54] tests/qtest/sse-timer-test: Test counter scaling changes

2021-03-08 Thread Peter Maydell
Test that when we change the scaling of the system counter that the system timer responds appropriately. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé --- tests/qtest/sse-timer-test.c | 32 1 file changed,

[PATCH] block: remove format defaults from QemuOpts in bdrv_create_file()

2021-03-08 Thread Stefano Garzarella
QemuOpts is usually created merging the QemuOptsList of format and protocol. So, when the format calls bdr_create_file(), the 'opts' parameter contains a QemuOptsList with a combination of format and protocol default values. The format properly removes its options before calling

Re: [Virtio-fs] [PATCH] virtiofsd: Add qemu version and copyright info

2021-03-08 Thread Stefan Hajnoczi
On Wed, Mar 03, 2021 at 02:53:39PM -0500, Vivek Goyal wrote: > Option "-V" currently displays the fuse protocol version virtiofsd is > using. For example, I see this. > > $ ./virtiofsd -V > "using FUSE kernel interface version 7.33" > > People also want to know software version of virtiofsd so

Re: [PATCH v3 2/5] scripts/tracetool: Replace the word 'whitelist'

2021-03-08 Thread Stefan Hajnoczi
On Wed, Mar 03, 2021 at 07:46:41PM +0100, Philippe Mathieu-Daudé wrote: > Follow the inclusive terminology from the "Conscious Language in your > Open Source Projects" guidelines [*] and replace the words "whitelist" > appropriately. > > [*]

[PATCH v1 1/1] vfio: Make migration support non experimental by default.

2021-03-08 Thread Tarun Gupta
VFIO migration support in QEMU is experimental as of now, which was done to provide soak time and resolve concerns regarding bit-stream. But, with the patches discussed in https://www.mail-archive.com/qemu-devel@nongnu.org/msg784931.html , we have corrected ordering of saving PCI config space and

Re: [PATCH v2 4/7] hw/arm/smmu-common: Fix smmu_iotlb_inv_iova when asid is not set

2021-03-08 Thread Peter Maydell
On Thu, 25 Feb 2021 at 09:15, Eric Auger wrote: > > If the asid is not set, do not attempt to locate the key directly > as all inserted keys have a valid asid. > > Use g_hash_table_foreach_remove instead. > > Signed-off-by: Eric Auger > --- > hw/arm/smmu-common.c | 2 +- > 1 file changed, 1

Re: [PATCH v2] FreeBSD: Upgrade to 12.2 release

2021-03-08 Thread Stefan Weil
Am 08.03.21 um 16:46 schrieb Roman Bolshakov: > gnutls failures on macOS and FreeBSD (with clang as main compiler) won’t > happen only if libtasn1 from master is used. Otherwise libtasn1 has to be > compiled with -O1/-O0. Of course it is also possible to patch older versions of libtasn1 to

[PATCH v3 20/30] qemu-storage-daemon: Implement --object with qmp_object_add()

2021-03-08 Thread Kevin Wolf
This QAPIfies --object and ensures that QMP and the command line option behave the same. Signed-off-by: Kevin Wolf Acked-by: Peter Krempa Reviewed-by: Eric Blake --- storage-daemon/qemu-storage-daemon.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git

[PATCH v3 24/30] qemu-nbd: Use user_creatable_process_cmdline() for --object

2021-03-08 Thread Kevin Wolf
This switches qemu-nbd from a QemuOpts-based parser for --object to user_creatable_process_cmdline() which uses a keyval parser and enforces the QAPI schema. Apart from being a cleanup, this makes non-scalar properties accessible. Signed-off-by: Kevin Wolf Acked-by: Peter Krempa Reviewed-by:

[PULL 07/54] hw/misc/iotkit-secctl.c: Implement SSE-300 PID register values

2021-03-08 Thread Peter Maydell
The versions of the Secure Access Configuration Register Block and Non-secure Access Configuration Register Block in the SSE-300 are the same as those in the SSE-200, but the CIDR/PIDR ID register values are different. Plumb through the sse-version property and use it to select the correct ID

[PULL 10/54] hw/misc/iotkit-sysinfo.c: Implement SYS_CONFIG1 and IIDR

2021-03-08 Thread Peter Maydell
For SSE-300, the SYSINFO register block has two new registers: * SYS_CONFIG1 indicates the config for a potential CPU2 and CPU3; since the SSE-300 can only be configured with a single CPU it is always zero * IIDR is the subsystem implementation identity register; its value is set by

[PULL 01/54] clock: Add ClockEvent parameter to callbacks

2021-03-08 Thread Peter Maydell
The Clock framework allows users to specify a callback which is called after the clock's period has been updated. Some users need to also have a callback which is called before the clock period is updated. As the first step in adding support for notifying Clock users on pre-update events, add an

[PULL 08/54] hw/misc/iotkit-sysinfo.c: Implement SSE-300 PID register values

2021-03-08 Thread Peter Maydell
The version of the SYSINFO Register Block in the SSE-300 has different CIDR/PIDR register values to the SSE-200; pass in the sse-version property and use it to select the correct ID register values. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson

[PULL 18/54] hw/misc/iotkit-sysctl: Implement SSE-200 and SSE-300 PID register values

2021-03-08 Thread Peter Maydell
The SSE-200 and SSE-300 have different PID register values from the IoTKit for the sysctl register block. We incorrectly implemented the SSE-200 with the same PID values as IoTKit. Fix the SSE-200 bug and report these register values for SSE-300. Signed-off-by: Peter Maydell Tested-by:

[PULL 53/54] hw/timer/renesas_tmr: Prefix constants for CSS values with CSS_

2021-03-08 Thread Peter Maydell
The #defines INTERNAL and CASCADING represent different possible values for the TCCR.CSS register field; prefix them with CSS_ to make this more obvious, before we add more defines to represent the other possible values of the field in the next commit. Signed-off-by: Peter Maydell Reviewed-by:

[PULL 16/54] hw/misc/iotkit-sysctl: Implement dummy version of SSE-300 PWRCTRL register

2021-03-08 Thread Peter Maydell
The SSE-300 has a new PWRCTRL register at offset 0x1fc (previously reserved). This register controls accessibility of some registers in the Power Policy Units (PPUs). Since QEMU doesn't implement the PPUs, we don't need to implement any real behaviour for this register, so we just handle the

[PULL 22/54] hw/arm/armsse: Add a define for number of IRQs used by the SSE itself

2021-03-08 Thread Peter Maydell
The SSE uses 32 interrupts for its own devices, and then passes through its expansion IRQ inputs to the CPU's interrupts 33 and upward. Add a define for the number of IRQs the SSE uses for itself, instead of hardcoding 32. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé

[PULL 47/54] target/arm: Restrict v7A TCG cpus to TCG accel

2021-03-08 Thread Peter Maydell
From: Philippe Mathieu-Daudé KVM requires the target cpu to be at least ARMv8 architecture (support on ARMv7 has been dropped in commit 82bf7ae84ce: "target/arm: Remove KVM support for 32-bit Arm hosts"). A KVM-only build won't be able to run TCG cpus, move the v7A CPU definitions to cpu_tcg.c.

[PULL 42/54] hw/arm/mps2-tz: Add new mps3-an547 board

2021-03-08 Thread Peter Maydell
Add support for the mps3-an547 board; this is an SSE-300 based FPGA image that runs on the MPS3. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20210219144617.4782-43-peter.mayd...@linaro.org --- hw/arm/mps2-tz.c | 146

[PULL 48/54] hw/dma: Implement a Xilinx CSU DMA model

2021-03-08 Thread Peter Maydell
From: Xuzhou Cheng ZynqMP QSPI supports SPI transfer using DMA mode, but currently this is unimplemented. When QSPI is programmed to use DMA mode, QEMU will crash. This is observed when testing VxWorks 7. This adds a Xilinx CSU DMA model and the implementation is based on

Re: [PATCH v2] block/file-posix: Optimize for macOS

2021-03-08 Thread Akihiko Odaki
2021年3月9日(火) 0:17 Stefan Hajnoczi : > > The live migration compatibility issue is still present. Migrating to > another host might not work if the block limits are different. > > Here is an idea for solving it: > > Modify include/hw/block/block.h:DEFINE_BLOCK_PROPERTIES_BASE() to > support a new

Re: [PATCH v2 5/7] hw/arm/smmuv3: Enforce invalidation on a power of two range

2021-03-08 Thread Peter Maydell
On Thu, 25 Feb 2021 at 09:15, Eric Auger wrote: > > As of today, the driver can invalide a number of pages that is "invalidate" > not a power of 2. However IOTLB unmap notifications and internal > IOTLB invalidations work with masks leading to erroneous > invalidations. > > In case the range is

Re: [PATCH 00/14] deprecations: remove many old deprecations

2021-03-08 Thread Stefan Hajnoczi
On Wed, Feb 24, 2021 at 04:21:13PM +0100, Philippe Mathieu-Daudé wrote: > On 2/24/21 3:38 PM, Peter Maydell wrote: > > On Wed, 24 Feb 2021 at 13:21, Daniel P. Berrangé > > wrote: > >> > >> The following features have been deprecated for well over the 2 > >> release cycle we promise > >> > >>

[PATCH v3 00/30] qapi/qom: QAPIfy --object and object-add

2021-03-08 Thread Kevin Wolf
This series adds a QAPI type for the properties of all user creatable QOM types and finally makes the --object command line option (in all binaries) and the object-add monitor commands (in QMP and HMP) use the new ObjectOptions union. This change improves things in more than just one way: 1.

[PATCH v3 07/30] qapi/qom: Add ObjectOptions for rng-*, deprecate 'opened'

2021-03-08 Thread Kevin Wolf
This adds a QAPI schema for the properties of the rng-* objects. The 'opened' property doesn't seem to make sense as an external interface: It is automatically set to true in ucc->complete, and explicitly setting it to true earlier just means that trying to set additional options will result in

[PATCH v3 17/30] qapi/qom: Add ObjectOptions for x-remote-object

2021-03-08 Thread Kevin Wolf
This adds a QAPI schema for the properties of the x-remote-object object. Signed-off-by: Kevin Wolf Acked-by: Peter Krempa Reviewed-by: Eric Blake --- qapi/qom.json | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/qapi/qom.json b/qapi/qom.json index

[PATCH v3 02/30] qapi/qom: Add ObjectOptions for iothread

2021-03-08 Thread Kevin Wolf
Add an ObjectOptions union that will eventually describe the options of all user creatable object types. As unions can't exist without any branches, also add the first object type. This adds a QAPI schema for the properties of the iothread object. Signed-off-by: Kevin Wolf Acked-by: Peter

[PATCH v3 18/30] qapi/qom: QAPIfy object-add

2021-03-08 Thread Kevin Wolf
This converts object-add from 'gen': false to the ObjectOptions QAPI type. As an immediate benefit, clients can now use QAPI schema introspection for user creatable QOM objects. It is also the first step towards making the QAPI schema the only external interface for the creation of user creatable

[PATCH v3 08/30] qapi/qom: Add ObjectOptions for throttle-group

2021-03-08 Thread Kevin Wolf
This adds a QAPI schema for the properties of the throttle-group object. The only purpose of the x-* properties is to make the nested options in 'limits' available for a command line parser that doesn't support structs. Any parser that will use the QAPI schema will supports structs, though, so

[PATCH v3 21/30] qom: Remove user_creatable_add_dict()

2021-03-08 Thread Kevin Wolf
This function is now unused and can be removed. Signed-off-by: Kevin Wolf Acked-by: Peter Krempa Reviewed-by: Eric Blake --- include/qom/object_interfaces.h | 18 -- qom/object_interfaces.c | 32 2 files changed, 50 deletions(-) diff

[PATCH v3 28/30] qom: Add user_creatable_parse_str()

2021-03-08 Thread Kevin Wolf
The system emulator has a more complicated way of handling command line options in that it reorders options before it processes them. This means that parsing object options and creating the object happen at two different points. Split the parsing part into a separate function that can be reused by

[PATCH v3 29/30] vl: QAPIfy -object

2021-03-08 Thread Kevin Wolf
This switches the system emulator from a QemuOpts-based parser for -object to user_creatable_parse_str() which uses a keyval parser and enforces the QAPI schema. Apart from being a cleanup, this makes non-scalar properties accessible. This adopts a similar model as -blockdev uses: When parsing

[Bug 1916655] Re: Compilation fails due to zstd qcow2 compression

2021-03-08 Thread John Snow
Meson theoretically checks for that: meson.build: zstd = dependency('libzstd', version: '>=1.4.0', I suppose meson found the dependency, but the compile flags got the wrong header. Is there something we need to fix in the build system? -- You received this bug notification because you are a

Re: [PULL 00/31] Block layer patches

2021-03-08 Thread Stefan Hajnoczi
On Mon, Mar 08, 2021 at 12:08:29PM +0100, Kevin Wolf wrote: > Am 06.03.2021 um 12:22 hat Peter Maydell geschrieben: > > On Fri, 5 Mar 2021 at 16:55, Kevin Wolf wrote: > > > > > > The following changes since commit > > > 9a7beaad3dbba982f7a461d676b55a5c3851d312: > > > > > > Merge

[Bug 1916655] Re: Compilation fails due to zstd qcow2 compression

2021-03-08 Thread Dantali0n
> Is there something we need to fix in the build system? Maybe, I do not know how this dependency is validated. If the directories used to validate dependencies differs from the directories (or order) used at compile / link time than this can cause errors like these. However, what could also

[PULL 09/54] hw/arm/armsse.c: Use correct SYS_CONFIG0 register value for SSE-300

2021-03-08 Thread Peter Maydell
In the SSE-300, the format of the SYS_CONFIG0 register has changed again; pass through the correct value to the SYSINFO register block device. We drop the old SysConfigFormat enum, which was implemented in the hope that different flavours of SSE would share the same format; since they all seem to

[PULL 26/54] hw/arm/armsse: Move s32ktimer into data-driven framework

2021-03-08 Thread Peter Maydell
Move the CMSDK timer that uses the S32K slow clock into the data-driven device placement framework. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20210219144617.4782-27-peter.mayd...@linaro.org --- include/hw/arm/armsse.h | 3 +--

[PULL 52/54] hw/ssi: xilinx_spips: Remove DMA related dead codes from zynqmp_spips

2021-03-08 Thread Peter Maydell
From: Xuzhou Cheng Now that the Xilinx CSU DMA model is implemented, the existing DMA related dead codes in the ZynqMP QSPI are useless and should be removed. The maximum register number is also updated to only include the QSPI registers. Signed-off-by: Xuzhou Cheng Signed-off-by: Bin Meng

[PULL 36/54] hw/arm/mps2-tz: Make UART overflow IRQ board-specific

2021-03-08 Thread Peter Maydell
The AN547 puts the combined UART overflow IRQ at 48, not 47 like the other images. Make this setting board-specific. Signed-off-by: Peter Maydell Tested-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id:

<    1   2   3   4   5   >