Re: [PATCH v2 0/5] qemu-iotests: quality of life improvements

2021-03-24 Thread Emanuele Giuseppe Esposito
On 23/03/2021 19:19, Paolo Bonzini wrote: This series adds a few usability improvements to qemu-iotests, in particular: - arguments can be passed to Python unittests scripts, for example to run only a subset of the test cases (patches 1-2) - it is possible to do "./check --

[PATCH] qapi: introduce 'query-cpu-model-cpuid' action

2021-03-24 Thread Valeriy Vdovin
Introducing new qapi method 'query-cpu-model-cpuid'. This method can be used to get virtualized cpu model info generated by QEMU during VM initialization in the form of cpuid representation. Diving into more details about virtual cpu generation: QEMU first parses '-cpu' command line option. From

Re: [PATCH v5 00/10] KVM: Dirty ring support (QEMU part)

2021-03-24 Thread Peter Xu
On Wed, Mar 24, 2021 at 10:56:22AM +0800, Keqian Zhu wrote: > Hi Peter, > > On 2021/3/23 22:34, Peter Xu wrote: > > Keqian, > > > > On Tue, Mar 23, 2021 at 02:40:43PM +0800, Keqian Zhu wrote: > The second question is that you observed longer migration time > (55s->73s) when guest >

Re: [PATCH v4 2/6] block: Allow changing bs->file on reopen

2021-03-24 Thread Vladimir Sementsov-Ogievskiy
24.03.2021 15:25, Alberto Garcia wrote: On Thu 18 Mar 2021 03:25:07 PM CET, Vladimir Sementsov-Ogievskiy wrote: static int bdrv_reopen_prepare(BDRVReopenState *reopen_state, BlockReopenQueue *queue, - Transaction

Re: [PULL for 6.0 00/22] various fixes (kernel-doc, semihosting, testing)

2021-03-24 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210324143021.8560-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210324143021.8560-1-alex.ben...@linaro.org Subject: [PULL for 6.0 00/22] various

Re: [PATCH] hw/display/xlnx_dp: Free FIFOs adding xlnx_dp_finalize()

2021-03-24 Thread Alistair Francis
On Tue, Mar 23, 2021 at 3:15 PM Philippe Mathieu-Daudé wrote: > > When building with --enable-sanitizers we get: > > Direct leak of 16 byte(s) in 1 object(s) allocated from: > #0 0x5618479ec7cf in malloc (qemu-system-aarch64+0x233b7cf) > #1 0x7f675745f958 in g_malloc

Re: [PATCH] target/riscv: Align the data type of reset vector address

2021-03-24 Thread Alistair Francis
On Tue, Mar 23, 2021 at 5:15 AM Dylan Jhong wrote: > > Although the AE350 has not been upstream (preparing for v2), > the reset vector of the AE350 is known to be at the 2G position, > so this patch is corrected in advance. > > Signed-off-by: Dylan Jhong > Signed-off-by: Ruinland ChuanTzu Tsai

[PULL 2/2] migrate-bitmaps-postcopy-test: check that we can't remove in-flight bitmaps

2021-03-24 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Check that we can't remove bitmaps being migrated on destination vm. The new check proves that previous commit helps. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Stefan Hajnoczi Message-Id: <20210322094906.5079-3-vsement...@virtuozzo.com> ---

[Bug 1921092] Re: qemu-system-arm multi core debug not working

2021-03-24 Thread Martin Schönstedt
there was no bug, it was my fault. How do I delete this ** Changed in: qemu Status: New => Invalid ** Summary changed: - qemu-system-arm multi core debug not working + how do i delete this bug? ** Description changed: - Working with Zephyr RTOS, running a multi core sample on

[Bug 1920784] Re: qemu-system-ppc64le fails with kvm acceleration

2021-03-24 Thread Frank Heimes
The fix was sent to the kernel teams mailing list: https://lists.ubuntu.com/archives/kernel-team/2021-March/thread.html#118449 ** Changed in: linux (Ubuntu) Status: Confirmed => In Progress ** Changed in: ubuntu-power-systems Status: Confirmed => In Progress -- You received this

[PULL 0/2] Block patches

2021-03-24 Thread Stefan Hajnoczi
The following changes since commit 67c1115edd98f388ca89dd38322ea3fadf034523: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20210323-pull-request' into staging (2021-03-23 23:47:30 +) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git

[PULL 1/2] migration/block-dirty-bitmap: make incoming disabled bitmaps busy

2021-03-24 Thread Stefan Hajnoczi
From: Vladimir Sementsov-Ogievskiy Incoming enabled bitmaps are busy, because we do bdrv_dirty_bitmap_create_successor() for them. But disabled bitmaps being migrated are not marked busy, and user can remove them during the incoming migration. Then we may crash in cancel_incoming_locked() when

Re: [PATCH V4] file-posix: allow -EBUSY error during ioctl(fd, BLKZEROOUT, range) on block

2021-03-24 Thread Max Reitz
On 22.03.21 10:25, ChangLimin wrote: For Linux 5.10/5.11, qemu write zeros to a multipath device using ioctl(fd, BLKZEROOUT, range) with cache none or directsync return -EBUSY permanently. So as far as I can track back the discussion, Kevin asked on v1 why we’d set has_write_zeroes to false,

Re: [PATCH v2 7/7] ui/gtk: add clipboard support

2021-03-24 Thread Gerd Hoffmann
On Wed, Mar 24, 2021 at 05:26:24PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Mar 24, 2021 at 4:57 PM Gerd Hoffmann wrote: > > > Hi, > > > > > I fail to see how that works, imagine the other end is the same code > > (qemu > > > in the guest), it will take clipboard ownership and it is

[Bug 1920934] Re: Heap-use-after-free in io_writex / cputlb.c results in Linux kernel crashes

2021-03-24 Thread Marco Elver
The config is from 5.12-rc4, and the earliest kernel version that should reproduce this is 5.12-rc1. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1920934 Title: Heap-use-after-free in io_writex /

[PULL 15/22] gitlab: extend timeouts for CFI builds

2021-03-24 Thread Alex Bennée
These builds are running very close to the default build limit and as they are already pared down the only other option is to extend the timeout a little to give some breathing room. Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Willian Rampazzo Reviewed-by: Philippe

[PULL 22/22] gitlab: default to not building the documentation

2021-03-24 Thread Alex Bennée
In d0f26e68a0 ("gitlab: force enable docs build in Fedora, Ubuntu, Debian") we made sure we can build the documents on more than one system. However we don't want to build documents all the time as it's a waste of cycles (and energy). So lets reduce the total amount of documentation we build while

[PULL 16/22] qdev: define list of archs with virtio-pci or virtio-ccw

2021-03-24 Thread Alex Bennée
From: Laurent Vivier This is used to define virtio-*-pci and virtio-*-ccw aliases rather than substracting the CCW architecture from all the others. Signed-off-by: Laurent Vivier Signed-off-by: Alex Bennée Reviewed-by: Cornelia Huck Message-Id: <20210319202335.2397060-2-laur...@vivier.eu>

[PULL 21/22] iotests: iothreads need ioeventfd

2021-03-24 Thread Alex Bennée
From: Laurent Vivier And ioeventfd are only available with virtio-scsi-pci or virtio-scsi-ccw, use the alias but add a rule to require virtio-scsi-pci or virtio-scsi-ccw for the tests that use iothreads. Signed-off-by: Laurent Vivier Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth

[PULL 17/22] m68k: add the virtio devices aliases

2021-03-24 Thread Alex Bennée
From: Laurent Vivier Similarly to 5f629d943cb0 ("s390x: fix s390 virtio aliases"), define the virtio aliases. This allows to start machines with virtio devices without knowledge of the implementation type. For instance, we can use "-device virtio-scsi" on m68k, s390x or PC, and the device will

[PULL 18/22] blockdev: with -drive if=virtio, use generic virtio-blk

2021-03-24 Thread Alex Bennée
From: Laurent Vivier Rather than checking if the machine is an s390x to use virtio-blk-ccw instead of virtio-blk-pci, use the alias virtio-blk that is set to the expected target. This also enables the use of virtio-blk-device for targets without PCI or CCW. Signed-off-by: Laurent Vivier

[PULL 19/22] iotests: Revert "iotests: use -ccw on s390x for 040, 139, and 182"

2021-03-24 Thread Alex Bennée
From: Laurent Vivier Commit f1d5516ab583 introduces a test in some iotests to check if the machine is a s390-ccw-virtio and to select virtio-*-ccw rather than virtio-*-pci. We don't need that because QEMU already provides aliases to use the correct virtio interface according to the machine

Re: [PATCH 1/1] linux-user/s390x: Apply h2g to address of sigreturn stub

2021-03-24 Thread Richard Henderson
On 3/24/21 8:14 AM, Andreas Krebbel wrote: The part I actually needed to fix was in setup_rt_frame and there the fix is correct I think since here we do use 'frame' which is the host address. While doing that change I also stumbled upon the other location in setup_frame. There it is using

Re: [RFC v11 30/55] target/arm: wrap call to aarch64_sve_change_el in tcg_enabled()

2021-03-24 Thread Claudio Fontana
On 3/24/21 12:48 PM, Alex Bennée wrote: > > Alex Bennée writes: > >> Claudio Fontana writes: >> >>> On 3/23/21 11:50 PM, Alex Bennée wrote: > >> Moving up the build chain to the revert I now get: >> >> ./qemu-system-aarch64 -M virt,gic=host -cpu host -accel kvm -m 2048 >> -net none

[PULL 20/22] iotests: test m68k with the virt machine

2021-03-24 Thread Alex Bennée
From: Laurent Vivier This allows to cover the virtio tests with a 32bit big-endian virtio-mmio machine. Signed-off-by: Laurent Vivier Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Cornelia Huck Message-Id: <20210319202335.2397060-6-laur...@vivier.eu>

[PULL 14/22] utils: Work around mingw strto*l bug with 0x

2021-03-24 Thread Alex Bennée
From: Eric Blake Mingw recognizes that "0x" has value 0 without setting errno, but fails to advance endptr to the trailing garbage 'x'. This in turn showed up in our recent testsuite additions for qemu_strtosz (commit 1657ba44b4 utils: Enhance testsuite for do_strtosz()); adjust our remaining

[PULL 08/22] linux-user/riscv: initialise the TaskState heap/stack info

2021-03-24 Thread Alex Bennée
Arguably the target_cpu_copy_regs function for each architecture is misnamed as a number of the architectures also take the opportunity to fill out the TaskState structure. This could arguably be factored out into common code but that would require a wider audit of the architectures. For now just

[Bug 1920934] Re: Heap-use-after-free in io_writex / cputlb.c results in Linux kernel crashes

2021-03-24 Thread Richard Henderson
I have been unable to reproduce this problem with qemu master (67c1115edd98), and linux 5.10 w/ your config. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1920934 Title: Heap-use-after-free in

[PULL 09/22] tests/tcg: add HeapInfo checking to semihosting test

2021-03-24 Thread Alex Bennée
Query the SYS_HEAPINFO semicall and do some basic verification of the information via libc calls. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Message-Id: <20210323165308.15244-10-alex.ben...@linaro.org> diff --git

[PULL 11/22] configure: Don't use the __atomic_*_16 functions for testing 128-bit support

2021-03-24 Thread Alex Bennée
From: Thomas Huth The test for 128-bit atomics is causing trouble with FreeBSD 12.2 and --enable-werror: cc -Werror -fPIE -DPIE -std=gnu99 -Wall -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wundef -Wwrite-strings

[PULL 10/22] gitlab-ci.yml: Merge the trace-backend testing into other jobs

2021-03-24 Thread Alex Bennée
From: Thomas Huth Our gitlab-ci got quite slow in the past weeks, due to the immense amount of jobs that we have, so we should try to reduce the number of jobs. There is no real good reason for having separate jobs just to test the trace backends, we can do this just fine in other jobs, too.

[PULL 13/22] utils: Tighter tests for qemu_strtosz

2021-03-24 Thread Alex Bennée
From: Eric Blake Our tests were not validating the return value in all cases, nor was it guaranteeing our documented claim that 'res' is unchanged on error. For that matter, it wasn't as thorough as the existing tests for qemu_strtoi() and friends for proving that endptr and res are sanely set.

[PULL 05/22] semihosting: move semihosting tests to multiarch

2021-03-24 Thread Alex Bennée
It may be arm-compat-semihosting but more than one architecture uses it so lets move the tests into the multiarch area. We gate it on the feature and split the semicall.h header between the arches. Also clean-up a bit of the Makefile messing about to one common set of runners. Signed-off-by:

[PULL 12/22] cirrus.yml: Update the FreeBSD task to version 12.2

2021-03-24 Thread Alex Bennée
From: Thomas Huth FreeBSD version 12.1 is out of service now, and the task in the Cirrus-CI is failing. Update to 12.2 to get it working again. Unfortunately, there is a bug in libtasn1 that triggers with the new version of Clang that is used there (see this thread for details:

[PULL 07/22] semihosting/arm-compat-semi: don't use SET_ARG to report SYS_HEAPINFO

2021-03-24 Thread Alex Bennée
As per the spec: the PARAMETER REGISTER contains the address of a pointer to a four-field data block. So we need to follow arg0 and place the results of SYS_HEAPINFO there. Fixes: 3c37cfe0b1 ("semihosting: Change internal common-semi interfaces to use CPUState *") Signed-off-by: Alex

[PULL 06/22] semihosting/arm-compat-semi: unify GET/SET_ARG helpers

2021-03-24 Thread Alex Bennée
>>>From the semihosting point of view what we want to know is the current mode of the processor. Unify this into a single helper and allow us to use the same GET/SET_ARG helpers for the rest of the code. Having the helper will also be useful later. Note: we aren't currently testing riscv32 due to

[PULL 01/22] scripts/kernel-doc: strip QEMU_ from function definitions

2021-03-24 Thread Alex Bennée
Some packaged versions of Sphinx (fedora33/alpine so far) have issues with the annotated C code that kernel-doc spits out. Without knowing about things like QEMU_PLUGIN_EXPORT it chokes trying to understand the code. Evidently this is a problem for the kernel as well as the long stream of regex

[PULL 04/22] tools/virtiofsd: include --socket-group in help

2021-03-24 Thread Alex Bennée
I confused myself wandering if this had been merged by looking at the help output. It seems fuse_opt doesn't automagically add to help output so lets do it now. Signed-off-by: Alex Bennée Reviewed-by: Connor Kuehl Reviewed-by: Stefan Hajnoczi Updates: f6698f2b03 ("tools/virtiofsd: add support

[PULL 03/22] docs/devel: expand style section of memory management

2021-03-24 Thread Alex Bennée
This aims to provide a bit more guidance for those who take on one of our "clean up memory allocation" bite-sized tasks. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20210323165308.15244-4-alex.ben...@linaro.org> diff --git a/docs/devel/style.rst

[PULL 02/22] docs/devel: include the plugin API information from the headers

2021-03-24 Thread Alex Bennée
We have kerneldoc tags for the headers so we might as well extract them into our developer documentation whilst we are at it. Signed-off-by: Alex Bennée Reviewed-by: Aaron Lindsay Message-Id: <20210323165308.15244-3-alex.ben...@linaro.org> diff --git a/docs/devel/tcg-plugins.rst

[PULL for 6.0 00/22] various fixes (kernel-doc, semihosting, testing)

2021-03-24 Thread Alex Bennée
The following changes since commit 01874b15d36e3f9a3506c47941a92ccf8d8bed98: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20210323' into staging (2021-03-24 11:22:08 +) are available in the Git repository at: https://github.com/stsquad/qemu.git

[PATCH] hw/isa/piix4: Migrate Reset Control Register

2021-03-24 Thread Philippe Mathieu-Daudé
Fixes: 5790b757cfb ("piix4: Add the Reset Control Register") Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/piix4.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c index a50d97834c7..6eeff4525f8 100644 --- a/hw/isa/piix4.c +++

Re: [PATCH 2/6] block/vdi: Don't assume that blocks are larger than VdiHeader

2021-03-24 Thread Max Reitz
On 17.03.21 19:00, Paolo Bonzini wrote: From: David Edmondson Given that the block size is read from the header of the VDI file, a wide variety of sizes might be seen. Rather than re-using a block sized memory region when writing the VDI header, allocate an appropriately sized buffer.

Re: [PATCH v5 0/6] coroutine rwlock downgrade fix, minor VDI changes

2021-03-24 Thread Max Reitz
On 17.03.21 19:00, Paolo Bonzini wrote: This is a resubmit of David Edmondson's series at https://patchew.org/QEMU/20210309144015.557477-1-david.edmond...@oracle.com/. After closer analysis on IRC, the CoRwlock's attempt to ensure fairness turned out to be flawed. Therefore, this series

Re: [PATCH 1/6] block/vdi: When writing new bmap entry fails, don't leak the buffer

2021-03-24 Thread Max Reitz
On 17.03.21 19:00, Paolo Bonzini wrote: From: David Edmondson If a new bitmap entry is allocated, requiring the entire block to be written, avoiding leaking the buffer allocated for the block should the write fail. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Edmondson

Re: [PATCH for 6.0 v2 00/22] fixes for rc1 pre-PR (kernel-doc, semihosting, testing)

2021-03-24 Thread Alex Bennée
Peter Maydell writes: > On Tue, 23 Mar 2021 at 17:59, Alex Bennée wrote: >> I've added a testing patch to extend the CFI times, Laurent's series >> to fix the iotest regressions currently keeping the CI from going >> green and an optimisation to the --enable-docs build to try and start >>

Re: [PATCH 1/1] linux-user/s390x: Apply h2g to address of sigreturn stub

2021-03-24 Thread Andreas Krebbel
On 3/24/21 2:06 PM, Laurent Vivier wrote: > Le 24/03/2021 à 12:26, Andreas Krebbel a écrit : >> On 3/24/21 11:28 AM, Laurent Vivier wrote: >>> Le 24/03/2021 à 10:17, David Hildenbrand a écrit : On 24.03.21 09:51, Andreas Krebbel wrote: > The sigreturn SVC is put onto the stack by the

Re: [PATCH v2 09/22] tests/tcg: add HeapInfo checking to semihosting test

2021-03-24 Thread Richard Henderson
On 3/23/21 10:52 AM, Alex Bennée wrote: Query the SYS_HEAPINFO semicall and do some basic verification of the information via libc calls. Signed-off-by: Alex Bennée Message-Id:<20210320133706.21475-10-alex.ben...@linaro.org> --- v2 - expand test as suggested by Richard ---

Re: [PATCH v2] meson: Propagate gnutls dependency to migration

2021-03-24 Thread Paolo Bonzini
On 20/03/21 18:12, Jessica Clarke wrote: Commit 3eacf70bb5a83e4775ad8003cbca63a40f70c8c2 neglected to fix this for softmmu configs, which pull in migration's use of gnutls. This fixes the following compilation failure on Arm-based Macs: In file included from migration/multifd.c:23: In

Re: [PATCH v3] i386/cpu_dump: support AVX512 ZMM regs dump

2021-03-24 Thread Richard Henderson
On 3/24/21 2:00 AM, Robert Hoo wrote: +if ((env->xcr0 & XFEATURE_AVX512) == XFEATURE_AVX512) { +/* XSAVE enabled AVX512 */ +nb = (env->hflags & HF_CS64_MASK) ? 32 : 8; +for (i = 0; i < nb; i++) { +qemu_fprintf(f, "ZMM%02d=0x%016lx

Re: [PATCH 1/2] hw/riscv: sifive_u: Allow passing custom DTB

2021-03-24 Thread Bin Meng
Hi Anup, On Thu, Oct 22, 2020 at 1:34 PM Anup Patel wrote: > > Extend sifive_u machine to allow passing custom DTB using "-dtb" > command-line parameter. This will help users pass modified DTB > or Linux SiFive DTB to sifive_u machine. > > Signed-off-by: Anup Patel > --- > hw/riscv/sifive_u.c

Re: [PATCH for 6.0 v2 00/22] fixes for rc1 pre-PR (kernel-doc, semihosting, testing)

2021-03-24 Thread Peter Maydell
On Tue, 23 Mar 2021 at 17:59, Alex Bennée wrote: > I've added a testing patch to extend the CFI times, Laurent's series > to fix the iotest regressions currently keeping the CI from going > green and an optimisation to the --enable-docs build to try and start > bringing the total CI time down a

Re: [PATCH 2/8] virtiofds: Changed allocations of iovec to GLib's functions

2021-03-24 Thread Mahmoud Mandour
On Wed, Mar 24, 2021 at 2:57 PM Stefan Hajnoczi wrote: > Please use Reply-All on mailing list emails so that the mailing like and > all other CC email addresses are included in the discussion. > That's my bad, hopefully this won't happen again in the future. Mahmoud

Re: [PATCH v2 7/7] ui/gtk: add clipboard support

2021-03-24 Thread Marc-André Lureau
Hi On Wed, Mar 24, 2021 at 4:57 PM Gerd Hoffmann wrote: > Hi, > > > I fail to see how that works, imagine the other end is the same code > (qemu > > in the guest), it will take clipboard ownership and it is in a endless > > loop, isn't it? > > Notifications on guest-triggered clipboard

Re: [PULL 0/5] tcg patch queue for 6.0

2021-03-24 Thread Peter Maydell
On Wed, 24 Mar 2021 at 01:43, Richard Henderson wrote: > > The following changes since commit 266469947161aa10b1d36843580d369d5aa38589: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2021-03-23' > into staging (2021-03-23 22:28:58 +) > > are available in the Git repository

[PATCH RFC v2 0/6] Introduce IOMMU Option For PCI Root Bus

2021-03-24 Thread Wang Xingang
From: Xingang Wang These patches add support for configure iommu on/off for pci root bus, including primary bus and pxb root bus. At present, All root bus will go through iommu when iommu is configured, which is not flexible. So this add option to enable/disable iommu for primary bus and pxb

[PATCH RFC v2 5/6] hw/i386/acpi-build: Add explicit scope in DMAR table

2021-03-24 Thread Wang Xingang
From: Xingang Wang In DMAR table, the drhd is set to cover all pci devices when intel_iommu is on. This patch add explicit scope data, including only the pci devices that go through iommu. Signed-off-by: Xingang Wang Signed-off-by: Jiahui Cen --- hw/i386/acpi-build.c | 68

[PATCH RFC v2 1/6] hw/pci/pci_host: Add iommu property for pci host

2021-03-24 Thread Wang Xingang
From: Xingang Wang The pci host iommu property is useful to check whether the iommu is enabled on the pci root bus. Signed-off-by: Xingang Wang Signed-off-by: Jiahui Cen --- hw/pci/pci.c | 18 +- hw/pci/pci_host.c | 2 ++ include/hw/pci/pci.h | 1 +

[PATCH RFC v2 6/6] hw/i386/acpi-build: Add iommu filter in IVRS table

2021-03-24 Thread Wang Xingang
From: Xingang Wang When building amd IVRS table, only devices attached to root bus with IOMMU flag should be scanned. Signed-off-by: Xingang Wang Signed-off-by: Jiahui Cen --- hw/i386/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/acpi-build.c

[PATCH RFC v2 2/6] hw/pci: Add iommu option for pci root bus

2021-03-24 Thread Wang Xingang
From: Xingang Wang This add iommu option for pci root bus, including primary bus and pxb root bus. The option is valid only if there is a virtual iommu device. Signed-off-by: Xingang Wang Signed-off-by: Jiahui Cen --- hw/arm/virt.c | 25 +

[PATCH RFC v2 3/6] hw/pci: Add pci_root_bus_max_bus

2021-03-24 Thread Wang Xingang
From: Xingang Wang This helps to find max bus number of a root bus. Signed-off-by: Xingang Wang Signed-off-by: Jiahui Cen --- hw/pci/pci.c | 34 ++ include/hw/pci/pci.h | 1 + 2 files changed, 35 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c

[PATCH RFC v2 4/6] hw/arm/virt-acpi-build: Add explicit idmap info in IORT table

2021-03-24 Thread Wang Xingang
From: Xingang Wang The idmap of smmuv3 and root complex covers the whole RID space for now, this patch add explicit idmap info according to root bus number range. This add smmuv3 idmap for certain bus which has enabled the iommu property. Signed-off-by: Xingang Wang Signed-off-by: Jiahui Cen

Re: [PATCH 1/1] linux-user/s390x: Apply h2g to address of sigreturn stub

2021-03-24 Thread Laurent Vivier
Le 24/03/2021 à 12:26, Andreas Krebbel a écrit : > On 3/24/21 11:28 AM, Laurent Vivier wrote: >> Le 24/03/2021 à 10:17, David Hildenbrand a écrit : >>> On 24.03.21 09:51, Andreas Krebbel wrote: The sigreturn SVC is put onto the stack by the emulation code.  Hence the address of it should

Re: [PATCH 8/8] virtiofsd/fuse_virtio.c: Changed allocations of locals to GLib

2021-03-24 Thread Stefan Hajnoczi
On Wed, Mar 24, 2021 at 7:12 AM Mahmoud Mandour wrote: > > On Tue, Mar 23, 2021 at 4:15 PM Stefan Hajnoczi wrote: >> >> On Fri, Mar 19, 2021 at 03:25:27PM +0200, Mahmoud Mandour wrote: >> > @@ -588,7 +587,7 @@ out: >> > } >> > >> > pthread_mutex_destroy(>ch.lock); >> > -

Re: [PATCH v2 7/7] ui/gtk: add clipboard support

2021-03-24 Thread Gerd Hoffmann
Hi, > I fail to see how that works, imagine the other end is the same code (qemu > in the guest), it will take clipboard ownership and it is in a endless > loop, isn't it? Notifications on guest-triggered clipboard updates will not be sent back to the guest, exactly to avoid that kind of loop.

Re: [PATCH 2/8] virtiofds: Changed allocations of iovec to GLib's functions

2021-03-24 Thread Stefan Hajnoczi
On Tue, Mar 23, 2021 at 01:57:05PM +, Stefan Hajnoczi wrote: > On Fri, Mar 19, 2021 at 03:25:21PM +0200, Mahmoud Mandour wrote: > > @@ -629,9 +628,6 @@ int fuse_reply_ioctl_retry(fuse_req_t req, const struct > > iovec *in_iov, > > > > res = send_reply_iov(req, 0, iov, count); > > out:

[PATCH 1/1] linux-user/s390x: Apply h2g to address of sigreturn stub

2021-03-24 Thread Andreas Krebbel
The sigreturn SVC is put onto the stack by the emulation code. Hence the address of it should not be subject to guest_base transformation when fetching it. The fix applies h2g to the address when writing it into the return address register to nullify the transformation applied to it later.

Re: [PATCH v3 2/3] spapr: nvdimm: Implement H_SCM_FLUSH hcall

2021-03-24 Thread Aneesh Kumar K.V
On 3/24/21 8:37 AM, David Gibson wrote: On Tue, Mar 23, 2021 at 09:47:38AM -0400, Shivaprasad G Bhat wrote: The patch adds support for the SCM flush hcall for the nvdimm devices. To be available for exploitation by guest through the next patch. The hcall expects the semantics such that the

Issue Report: When VM has multiple vCPU and receive SIGBUS for SRAR, qemu will inject broadcast MCE to VM, VM may exceed 1S MCE sync time, and Panic.

2021-03-24 Thread Aili Yao
Hi: When i do memory SRAR test for VM, I meet the following issue: My VM has 16 vCPU, I will inject one UE error to memory which is accessed by VM, Then host MCE is raised and SIGBUS is send to VM, and qemu take control. Qemu will check the broadcast attribute by following

Re: [PATCH 1/1] linux-user/s390x: Apply h2g to address of sigreturn stub

2021-03-24 Thread Andreas Krebbel
On 3/24/21 11:28 AM, Laurent Vivier wrote: > Le 24/03/2021 à 10:17, David Hildenbrand a écrit : >> On 24.03.21 09:51, Andreas Krebbel wrote: >>> The sigreturn SVC is put onto the stack by the emulation code.  Hence >>> the address of it should not be subject to guest_base transformation >>> when

Re: [PATCH v3 3/3] spapr: nvdimm: Enable sync-dax device property for nvdimm

2021-03-24 Thread Aneesh Kumar K.V
On 3/24/21 8:39 AM, David Gibson wrote: On Tue, Mar 23, 2021 at 09:47:55AM -0400, Shivaprasad G Bhat wrote: The patch adds the 'sync-dax' property to the nvdimm device. When the sync-dax is 'off', the device tree property "hcall-flush-required" is added to the nvdimm node which makes the guest

Re: [PATCH v2] x86/mce: fix wrong no-return-ip logic in do_machine_check()

2021-03-24 Thread Aili Yao
On Wed, 24 Feb 2021 10:39:21 +0800 Aili Yao wrote: > On Tue, 23 Feb 2021 16:12:43 + > "Luck, Tony" wrote: > > > > What I think is qemu has not an easy to get the MCE signature from host > > > or currently no methods for this > > > So qemu treat all AR will be No RIPV, Do more is better

Re: [PATCH v2] x86/mce: fix wrong no-return-ip logic in do_machine_check()

2021-03-24 Thread Aili Yao
On Wed, 24 Mar 2021 10:59:50 +0800 Aili Yao wrote: > On Wed, 24 Feb 2021 10:39:21 +0800 > Aili Yao wrote: > > > On Tue, 23 Feb 2021 16:12:43 + > > "Luck, Tony" wrote: > > > > > > What I think is qemu has not an easy to get the MCE signature from host > > > > or currently no methods

[Bug 1920934] Re: Heap-use-after-free in io_writex / cputlb.c results in Linux kernel crashes

2021-03-24 Thread Richard Henderson
This suggests that the rcu_read in iotlb_to_section is not playing well with one of the g_renew calls in softmmu/physmem.c. Not sure which, since the sanitizer dump above doesn't trace back beyond glib itself. -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [PATCH v4 2/6] block: Allow changing bs->file on reopen

2021-03-24 Thread Alberto Garcia
On Thu 18 Mar 2021 03:25:07 PM CET, Vladimir Sementsov-Ogievskiy wrote: >> static int bdrv_reopen_prepare(BDRVReopenState *reopen_state, >> BlockReopenQueue *queue, >> - Transaction *set_backings_tran, Error >> **errp); >> +

Re: [PATCH 0/2] yank: Always link full yank code

2021-03-24 Thread Lukas Straub
On Wed, 24 Mar 2021 11:36:13 + Daniel P. Berrangé wrote: > On Wed, Mar 24, 2021 at 12:22:42PM +0100, Lukas Straub wrote: > > On Tue, 23 Mar 2021 19:09:15 + > > Daniel P. Berrangé wrote: > > > > > On Tue, Mar 23, 2021 at 06:52:19PM +0100, Lukas Straub wrote: > > > > Hello Everyone,

Re: [RFC v11 30/55] target/arm: wrap call to aarch64_sve_change_el in tcg_enabled()

2021-03-24 Thread Alex Bennée
Alex Bennée writes: > Claudio Fontana writes: > >> On 3/23/21 11:50 PM, Alex Bennée wrote: > Moving up the build chain to the revert I now get: > > ./qemu-system-aarch64 -M virt,gic=host -cpu host -accel kvm -m 2048 > -net none -nographic -kernel >

Re: [RFC v11 30/55] target/arm: wrap call to aarch64_sve_change_el in tcg_enabled()

2021-03-24 Thread Alex Bennée
Claudio Fontana writes: > On 3/23/21 11:50 PM, Alex Bennée wrote: >> >> Claudio Fontana writes: >> >>> After this patch it is possible to build only kvm: >>> >>> ./configure --disable-tcg --enable-kvm > > > It's possible to build, but tests will fail until all the test-related > patches are

Re: qdev: Regarding lazy ISA bridge creation

2021-03-24 Thread Cédric Le Goater
On 3/24/21 12:13 PM, Philippe Mathieu-Daudé wrote: > Hi Cédric, > > I'm trying to understand the comment you added in commit > 3495b6b6101 ("ppc/pnv: add a ISA bus"): > > /* let isa_bus_new() create its own bridge on SysBus otherwise > * devices specified on the command line won't find the

Re: [PATCH 0/2] yank: Always link full yank code

2021-03-24 Thread Daniel P . Berrangé
On Wed, Mar 24, 2021 at 12:22:42PM +0100, Lukas Straub wrote: > On Tue, 23 Mar 2021 19:09:15 + > Daniel P. Berrangé wrote: > > > On Tue, Mar 23, 2021 at 06:52:19PM +0100, Lukas Straub wrote: > > > Hello Everyone, > > > These patches remove yank's dependency on qiochannel and always link it

Re: [PATCH 0/2] yank: Always link full yank code

2021-03-24 Thread Lukas Straub
On Tue, 23 Mar 2021 19:09:15 + Daniel P. Berrangé wrote: > On Tue, Mar 23, 2021 at 06:52:19PM +0100, Lukas Straub wrote: > > Hello Everyone, > > These patches remove yank's dependency on qiochannel and always link it in. > > Please Review. > > It would be useful if the cover letter or

Re: [PATCH v10 7/7] hw/ppc: Add emulation of Genesi/bPlan Pegasos II

2021-03-24 Thread BALATON Zoltan
On Wed, 24 Mar 2021, David Gibson wrote: On Tue, Mar 23, 2021 at 02:01:27PM +0100, BALATON Zoltan wrote: On Tue, 23 Mar 2021, David Gibson wrote: On Wed, Mar 17, 2021 at 02:17:51AM +0100, BALATON Zoltan wrote: Add new machine called pegasos2 emulating the Genesi/bPlan Pegasos II, a PowerPC

Re: [PULL 0/5] Ui 20210323 patches

2021-03-24 Thread Peter Maydell
On Tue, 23 Mar 2021 at 15:39, Gerd Hoffmann wrote: > > The following changes since commit c95bd5ff1660883d15ad6e0005e4c8571604f51a: > > Merge remote-tracking branch 'remotes/philmd/tags/mips-fixes-20210322' into= > staging (2021-03-22 14:26:13 +) > > are available in the Git repository at:

qdev: Regarding lazy ISA bridge creation

2021-03-24 Thread Philippe Mathieu-Daudé
Hi Cédric, I'm trying to understand the comment you added in commit 3495b6b6101 ("ppc/pnv: add a ISA bus"): /* let isa_bus_new() create its own bridge on SysBus otherwise * devices specified on the command line won't find the bus and * will fail to create. */ isa_bus = isa_bus_new(NULL,

Re: [PATCH v10 6/7] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller

2021-03-24 Thread BALATON Zoltan
On Wed, 24 Mar 2021, David Gibson wrote: On Tue, Mar 23, 2021 at 02:31:07PM +0100, BALATON Zoltan wrote: On Tue, 23 Mar 2021, David Gibson wrote: On Wed, Mar 17, 2021 at 02:17:51AM +0100, BALATON Zoltan wrote: [snip] +static void setup_mem_windows(MV64361State *s, uint32_t val) +{ +

Re: [PATCH 0/5] virtio: Implement generic vhost-user-i2c backend

2021-03-24 Thread Viresh Kumar
On 24-03-21, 00:42, no-re...@patchew.org wrote: > Patchew URL: > https://patchew.org/QEMU/cover.1616570702.git.viresh.ku...@linaro.org/ > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renamelimit 0 > git config --local diff.renames

[PATCH] gitignore: Update with some filetypes

2021-03-24 Thread Viresh Kumar
Update .gitignore to ignore .swp and .patch files. Signed-off-by: Viresh Kumar --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 75a4be07240f..eb2553026c5e 100644 --- a/.gitignore +++ b/.gitignore @@ -13,3 +13,5 @@ GTAGS *~ *.ast_raw

Re: [PATCH V4 5/7] net/colo-compare: Move data structure and define to .h file.

2021-03-24 Thread Dr. David Alan Gilbert
* Zhang Chen (chen.zh...@intel.com) wrote: > Make other modules can reuse COLO code. > > Signed-off-by: Zhang Chen > --- > net/colo-compare.c | 106 - > net/colo-compare.h | 106 + > 2 files changed, 106

[Bug 1921092] Re: qemu-system-arm multi core debug not working

2021-03-24 Thread Martin Schönstedt
** Description changed: Working with Zephyr RTOS, running a multi core sample on mps2_an521 works fine. Both cpus start. Trying to debug with options -s -S the second core fails to boot. Posted with explanation also at: https://github.com/zephyrproject-rtos/zephyr/issues/33635 + + only

Re: [PATCH V4 4/7] hmp-commands: Add new HMP command for COLO passthrough

2021-03-24 Thread Dr. David Alan Gilbert
* Zhang Chen (chen.zh...@intel.com) wrote: > Add hmp_colo_passthrough_add and hmp_colo_passthrough_del make user > can maintain COLO network passthrough list in human monitor. > > Signed-off-by: Zhang Chen > --- > hmp-commands.hx | 26 ++ > include/monitor/hmp.h |

Re: [PATCH v2 05/10] Acceptance Tests: add port redirection for ssh by default

2021-03-24 Thread Auger Eric
Hi Cleber, On 3/23/21 11:15 PM, Cleber Rosa wrote: > For users of the LinuxTest class, let's set up the VM with the port > redirection for SSH, instead of requiring each test to set the same > arguments. > > Signed-off-by: Cleber Rosa > --- > tests/acceptance/avocado_qemu/__init__.py | 4 +++- >

[Bug 1921092] [NEW] qemu-system-arm multi core debug not working

2021-03-24 Thread Martin Schönstedt
Public bug reported: Working with Zephyr RTOS, running a multi core sample on mps2_an521 works fine. Both cpus start. Trying to debug with options -s -S the second core fails to boot. Posted with explanation also at: https://github.com/zephyrproject-rtos/zephyr/issues/33635 ** Affects: qemu

Re: Crashes with qemu-system-ppc64

2021-03-24 Thread Thomas Huth
On 24/03/2021 11.10, Thomas Huth wrote: On 24/03/2021 00.35, Philippe Mathieu-Daudé wrote: [...] Hmmm does this assert() matches your comment? -- >8 -- diff --git a/hw/core/qdev.c b/hw/core/qdev.c index cefc5eaa0a9..41cbee77d14 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -1130,6

Re: [PATCH v2 2/7] ui/vdagent: core infrastructure

2021-03-24 Thread Marc-André Lureau
On Wed, Mar 24, 2021 at 1:47 PM Gerd Hoffmann wrote: > On Mon, Mar 22, 2021 at 11:27:17AM +0100, Gerd Hoffmann wrote: > > Hi, > > > > > > +if (vd->msgsize != msg->size + sizeof(*msg)) { > > > > +/* FIXME: handle parse messages splitted into multiple > chunks */ > > > > +

Re: [PATCH 1/1] linux-user/s390x: Apply h2g to address of sigreturn stub

2021-03-24 Thread Laurent Vivier
Le 24/03/2021 à 10:17, David Hildenbrand a écrit : > On 24.03.21 09:51, Andreas Krebbel wrote: >> The sigreturn SVC is put onto the stack by the emulation code.  Hence >> the address of it should not be subject to guest_base transformation >> when fetching it. >> >> The fix applies h2g to the

Re: [PATCH v2 7/7] ui/gtk: add clipboard support

2021-03-24 Thread Marc-André Lureau
Hi On Wed, Mar 24, 2021 at 2:16 PM Gerd Hoffmann wrote: > Hi, > > > > +if (gd->cbowner[s]) { > > > +/* ignore notifications about our own grabs */ > > > +return; > > > +} > > > + > > > + > > > +switch (event->owner_change.reason) { > > > +case

Re: [PATCH v2 7/7] ui/gtk: add clipboard support

2021-03-24 Thread Gerd Hoffmann
Hi, > > +if (gd->cbowner[s]) { > > +/* ignore notifications about our own grabs */ > > +return; > > +} > > + > > + > > +switch (event->owner_change.reason) { > > +case GDK_SETTING_ACTION_NEW: > > +info = qemu_clipboard_info_new(>cbpeer, s); > > +

[Bug 1910723] Re: NULL pointer dereference issues in am53c974 SCSI host bus adapter

2021-03-24 Thread Mauro Matteo Cascella
I can confirm this is fixed now, thank you Mark. Patchset v2: https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg06550.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1910723 Title: NULL

Re: Crashes with qemu-system-ppc64

2021-03-24 Thread Thomas Huth
On 24/03/2021 00.35, Philippe Mathieu-Daudé wrote: [...] Hmmm does this assert() matches your comment? -- >8 -- diff --git a/hw/core/qdev.c b/hw/core/qdev.c index cefc5eaa0a9..41cbee77d14 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -1130,6 +1130,8 @@ Object *qdev_get_machine(void) {

[Bug 1909247] Re: QEMU: use after free vulnerability in esp_do_dma() in hw/scsi/esp.c

2021-03-24 Thread Mauro Matteo Cascella
Hello, Thank you all for your comments. Both patches (PJP/comment#8 - Mark/comment#9) seem to properly fix the UAF reported by Alexander in comment #6. However, I'm still able to reproduce the heap-bof from the above hw-esp-oob-issues.zip: ./x86_64-softmmu/qemu-system-x86_64 -m 512 \ -drive

<    1   2   3   4   >