Re: [PATCH 2/3] ci: do not use #processors+1 jobs, #processors is enough

2021-05-18 Thread Philippe Mathieu-Daudé
On 5/18/21 10:41 AM, Paolo Bonzini wrote: > I could not reconstruct the origin of the $(($(nproc) + 1)) idiom, I guess it is the historical way make would aggressively use the most compute power it could? Then later this bad habit impact was reduced by the -l option to keep make under some system

[PULL v2 12/29] hw/tricore: Add testdevice for tests in tests/tcg/

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann this device is used to verify the correctness of regression tests by allowing guests to write their exit status to this device. This is then used by qemu to exit using the written status. Reviewed-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex

Re: [PATCH 04/21] qdev: allow setting drive property for realized device

2021-05-18 Thread Max Reitz
On 17.05.21 20:09, Vladimir Sementsov-Ogievskiy wrote: 17.05.2021 18:48, Max Reitz wrote: On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: We need an ability to insert filters above top block node, attached to block device. It can't be achieved with blockdev-reopen command. So, we want

[PULL v2 29/29] configure: use cc, not host_cc to set cross_cc for build arch

2021-05-18 Thread Alex Bennée
Otherwise you run into hilarity like trying when cross compiling a 32 bit ARM build on a 64 bit system trying to use host_cc to build 32 bit test cases. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20210512102051.12134-32-alex.ben...@linaro.org> diff --git

Re: [PATCH v2 05/50] target/i386: Split out check_iopl

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:12, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) Reviewed-by: Paolo Bonzini

[PULL v2 17/29] tests/tcg/tricore: Add clz test

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann [AJB: dropped duplicate Makefile] Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-9-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-19-alex.ben...@linaro.org> diff --git

Re: [PATCH v2 08/50] target/i386: Assert IOPL is 0 for user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: On real hardware, the linux kernel has the iopl(2) syscall which can set IOPL to 3, to allow e.g. the xserver to briefly disable interrupts while programming the graphics card. However, QEMU cannot and does not implement this syscall, so the IOPL is

Re: [PATCH v2 07/50] target/i386: Assert CPL is 3 for user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:12, Richard Henderson wrote: A user-mode executable always runs in ring 3. Signed-off-by: Richard Henderson Reviewed-by: Paolo Bonzini

Re: [PATCH v2 23/50] target/i386: Reduce DisasContext.vex_[lv] to uint8_t

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Currently, vex_l is either {0,1}; if in the future we implement AVX-512, the max value will be 2. In vex_v we store a register number. This is 0-15 for SSE, and 0-31 for AVX-512. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson

Re: [PATCH v2 16/50] target/i386: Tidy REX_B, REX_X definition

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Change the storage from int to uint8_t since the value is in {0,8}. For x86_64 add 0 in the macros to (1) promote the type back to int, and (2) make the macro an rvalue. Signed-off-by: Richard Henderson Might be easier in the end to put all rex

Re: [PATCH v2 28/50] target/i386: Reorder DisasContext members

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Sort all of the single-byte members to the same area of the structure, eliminating 8 bytes of padding. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 27 ++- 1 file changed, 14 insertions(+), 13

[PATCH] target/ppc: Fix load endianness for lxvwsx/lxvdsx

2021-05-18 Thread Giuseppe Musacchio
TARGET_WORDS_BIGENDIAN may not match the machine endianness if that's a runtime-configurable parameter. Fixes: bcb0b7b1a1c05707304f80ca6f523d557816f85c Resolves: https://gitlab.com/qemu-project/qemu/-/issues/212 Signed-off-by: Giuseppe Musacchio --- target/ppc/translate/vsx-impl.c.inc | 12

Re: [PATCH v5 22/23] target/ppc: Move addpcis to decodetree

2021-05-18 Thread Richard Henderson
On 5/17/21 3:50 PM, matheus.fe...@eldorado.org.br wrote: +tcg_gen_movi_tl(cpu_gpr[a->rt], ctx->base.pc_next + (a->d<<16)); Missing spaces around <<. r~

Re: [PATCH v2 45/50] target/i386: Exit tb after wrmsr

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: At minimum, wrmsr can change efer, which affects HF_LMA. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index

Re: [PATCH v2 34/50] target/i386: Mark some helpers as noreturn

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Any helper that always raises an exception or interrupt, or simply exits to the main loop, can be so marked. Signed-off-by: Richard Henderson --- target/i386/helper.h | 18 +- target/i386/tcg/bpt_helper.c | 2 +-

Re: [PATCH 0/4] Misc. audio patches

2021-05-18 Thread Gerd Hoffmann
On Mon, May 17, 2021 at 09:45:04PM +0200, Volker Rümelin wrote: > A small collection of patches for the audio subsystem. > > It took me one evening to get a working audio system with JACK. > I never associated the in-(NULL) and out-(NULL) devices in the > patch bay with qemu. Added all to audio

Re: [PATCH v2 48/50] target/i386: Create helper_check_io

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Drop helper_check_io[bwl] and expose their common subroutine to tcg directly. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/i386/helper.h | 4 +--- target/i386/tcg/seg_helper.c | 21 +++--

Re: [PATCH v2 00/50] target/i386 translate cleanups

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:12, Richard Henderson wrote: Supercedes: 20210228232321.322053-1-richard.hender...@linaro.org ("i386 cleanup part 3") Claudio's prerequite patch set ("i386 cleanup part 2"), is now merged. Version 2 here fixes some minor rebase conflicts that crept in. Only 4 of the 50 patches

Re: [PATCH v1 03/11] target/arm: Implement scalar float32 to bfloat16 conversion

2021-05-18 Thread Peter Maydell
On Sat, 17 Apr 2021 at 00:59, Richard Henderson wrote: > > This is the 64-bit BFCVT and the 32-bit VCVT{B,T}.BF16.F32. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

[PATCH v5 0/3] spapr: nvdimm: Introduce spapr-nvdimm device

2021-05-18 Thread Shivaprasad G Bhat
If the device backend is not persistent memory for the nvdimm, there is need for explicit IO flushes to ensure persistence. On SPAPR, the issue is addressed by adding a new hcall to request for an explicit flush from the guest when the backend is not pmem. So, the approach here is to convey when

Re: [PATCH v1 06/11] target/arm: Implement bfloat16 dot product (vector)

2021-05-18 Thread Peter Maydell
On Sat, 17 Apr 2021 at 01:02, Richard Henderson wrote: > > This is BFDOT for both AArch64 AdvSIMD and SVE, > and VDOT.BF16 for AArch32 NEON. > > Signed-off-by: Richard Henderson > @@ -12326,6 +12336,16 @@ static void > disas_simd_three_reg_same_extra(DisasContext *s, uint32_t insn) >

[PATCH] fw_cfg: Set the max fw_cfg mem read size to 8 bytes

2021-05-18 Thread Xiaojuan Yang
From: yangxiaojuan fw_cfg_data_read() func supports access widths from 1 to 8 bytes while the ops set the wrong read size. Most arch use 8 bytes to send ram_size to bios. Signed-off-by: yangxiaojuan --- hw/nvram/fw_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] qemu-config: load modules when instantiating option groups

2021-05-18 Thread Paolo Bonzini
Right now the SPICE module is special cased to be loaded when processing of the -spice command line option. However, the spice option group can also be brought in via -readconfig, in which case the module is not loaded. Add a generic hook to load modules that provide a QemuOpts group, and use it

Re: [PATCH 0/5] block: file-posix queue

2021-05-18 Thread Kevin Wolf
Am 18.05.2021 um 10:38 hat Paolo Bonzini geschrieben: > Hi Max/Kevin, > > this is a combination of two series that both affect host block device > support in block/file-posix.c. I suspect both of them evaded your radar, > so I'm grouping them together and sending them out again. Is this based

[PATCH 2/3] ci: do not use #processors+1 jobs, #processors is enough

2021-05-18 Thread Paolo Bonzini
I could not reconstruct the origin of the $(($(nproc) + 1)) idiom, but I suspect it was there only to have a sensible result when nproc or getconf do not exist. This can be achieved also with an "||". Signed-off-by: Paolo Bonzini --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] remove qemu-options* from root directory

2021-05-18 Thread Markus Armbruster
Paolo Bonzini writes: > These headers are also included from softmmu/vl.c, so they should be > in include/. Removing qemu-options-wrapper.h, since elsewhere > we include "template" headers directly and #define the parameters in > the including file, and move qemu-options.h to include/. > >

[PULL v2 08/29] tests/tcg: don't iterate through other arch compilers

2021-05-18 Thread Alex Bennée
There should only be one compiler per architecture. Those cases where the same compiler can deal with a different architecture should be explicitly set for both cross_cc and docker configurations. Otherwise you get strangeness like: --cross-cc-aarch64=/bin/false causing the logic to attempt to

[PULL v2 01/29] tests/docker: fix copying of executable in "update"

2021-05-18 Thread Alex Bennée
We have the same symlink chasing problem when doing an "update" operation. Fix that. Based-on: 5e33f7fead ("tests/docker: better handle symlinked libs") Signed-off-by: Alex Bennée Reviewed-by: Willian Rampazzo Message-Id: <20210512102051.12134-3-alex.ben...@linaro.org> diff --git

[PULL v2 13/29] tests/tcg/tricore: Add build infrastructure

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann this includes the Makefile and linker script to build all the tests. Reviewed-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-5-kbast...@mail.uni-paderborn.de> Message-Id:

Re: [PATCH v2 01/50] target/i386: Split out gen_exception_gpf

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:12, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 68 - 1 file changed, 37 insertions(+), 31 deletions(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index

[PULL v2 06/29] tests/tcg: Use Hexagon Docker image

2021-05-18 Thread Alex Bennée
From: Alessandro Di Federico [PMD: Split from 'Add Hexagon Docker image' patch] Signed-off-by: Alessandro Di Federico Signed-off-by: Philippe Mathieu-Daudé [AJB: add container_hosts] Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

Re: [PATCH v2 09/50] target/i386: Assert !VM86 for x86_64 user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: For i386-linux-user, we can enter vm86 mode via the vm86(2) syscall. That syscall explicitly returns to 32-bit mode, and the syscall does not exist for a 64-bit x86_64 executable. Since we're adding an accessor macro, pull the value directly out of

Re: [PATCH v2 25/50] target/i386: Leave TF in DisasContext.flags

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: It's just as easy to clear the flag with AND than assignment. In two cases the test for the bit can be folded together with the test for HF_INHIBIT_IRQ_MASK. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 14 ++ 1

Re: [PATCH v2 18/50] target/i386: Move rex_w into DisasContext

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Treat this flag exactly like we treat the other rex bits. The -1 initialization is unused; the two tests are > 0 and == 1, so the value can be reduced to a bool. Signed-off-by: Richard Henderson Reviewed-by: Paolo Bonzini

Re: [PATCH] target/ppc: Fix load endianness for lxvwsx/lxvdsx

2021-05-18 Thread Greg Kurz
On Tue, 18 May 2021 11:23:52 +0200 Giuseppe Musacchio wrote: > TARGET_WORDS_BIGENDIAN may not match the machine endianness if that's a > runtime-configurable parameter. > > Fixes: bcb0b7b1a1c05707304f80ca6f523d557816f85c and Fixes: afae37d98ae991c0792c867dbd9f32f988044318 for lxvwsx.

Re: [RFC PATCH v3 6/9] hw/arm/virt-acpi-build: Use possible cpus in generation of MADT

2021-05-18 Thread wangyanan (Y)
Hi Drew, On 2021/5/18 16:15, Andrew Jones wrote: On Tue, May 18, 2021 at 12:27:59AM +0800, wangyanan (Y) wrote: Hi Drew, On 2021/5/17 15:42, Andrew Jones wrote: On Sun, May 16, 2021 at 06:28:57PM +0800, Yanan Wang wrote: When building ACPI tables regarding CPUs we should always build them

Re: [PATCH 11/21] block/copy-before-write: use file child instead of backing

2021-05-18 Thread Max Reitz
On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: We are going to publish copy-before-write filter, and there no public backing-child-based filter in Qemu. No reason to create a precedent, so let's refactor copy-before-write filter instead. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

Re: [PATCH v1 11/11] target/arm: Enable BFloat16 extensions

2021-05-18 Thread Peter Maydell
On Sat, 17 Apr 2021 at 01:05, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > target/arm/cpu64.c | 3 +++ > target/arm/cpu_tcg.c | 1 + > 2 files changed, 4 insertions(+) > > diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c > index 379f90fab8..db4f48edcf 100644 > ---

Re: [PATCH v1 08/11] target/arm: Implement bfloat16 matrix multiply accumulate

2021-05-18 Thread Peter Maydell
On Sat, 17 Apr 2021 at 01:00, Richard Henderson wrote: > > This is BFMMLA for both AArch64 AdvSIMD and SVE, > and VMMLA.BF16 for AArch32 NEON. > > Signed-off-by: Richard Henderson > +void HELPER(gvec_bfmmla)(void *vd, void *vn, void *vm, void *va, uint32_t > desc) > +{ > +intptr_t s,

Re: [PATCH 2/3] ci: do not use #processors+1 jobs, #processors is enough

2021-05-18 Thread Paolo Bonzini
On 18/05/21 14:43, Daniel P. Berrangé wrote: I'd be surprised if you can measure any statistically reliable difference at all wrt public CI. I've tried measuring CI performance for small changes and found it impossible in short time frames, as the deviation between runs is way too large. GitLab

Re: [PATCH v2 03/50] target/i386: Unify code paths for IRET

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:12, Richard Henderson wrote: In vm86 mode, we use the same helper as real-mode, but with an extra check for IOPL. All non-exceptional paths set EFLAGS. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 16 ++-- 1 file changed, 6 insertions(+), 10

[PULL v2 24/29] tests/tcg/tricore: Add muls test

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-16-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-26-alex.ben...@linaro.org> diff --git

Re: [PATCH v2 06/50] target/i386: Assert PE is set for user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:12, Richard Henderson wrote: A user-mode executable is never in real-mode. Since we're adding an accessor macro, pull the value directly out of flags for sysemu. Signed-off-by: Richard Henderson Reviewed-by: Paolo Bonzini

Re: [PATCH v2 20/50] target/i386: Reduce DisasContext.flags to uint32_t

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: The value comes from tb->flags, which is uint32_t. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index

Re: [PATCH v2 12/50] target/i386: Assert CODE64 for x86_64 user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: For x86_64 user-only, there is no way to leave 64-bit mode. Without x86_64, there is no way to enter 64-bit mode. There is an existing macro to aid with that; simply place it in the right place in the ifdef chain. Since we're adding an accessor

Re: [PATCH v2 04/21] qapi/parser: factor parsing routine into method

2021-05-18 Thread Markus Armbruster
John Snow writes: > For the sake of keeping __init__ smaller (and treating it more like a > gallery of what state variables we can expect to see), put the actual > parsing action into a parse method. It remains invoked from the init > method to reduce churn. I'm kind of *shrug* about this.

Re: [PATCH v2 46/50] target/i386: Tidy gen_check_io

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Get cur_eip from DisasContext. Do not require the caller to use svm_is_rep; get prefix from DisasContext. Use the proper symbolic constants for SVM_IOIO_*. While we're touching all call sites, return bool in preparation for gen_check_io raising #GP.

Re: [PATCH] hw/input/hid: Add support for keys of jp106 keyboard.

2021-05-18 Thread Gerd Hoffmann
On Thu, May 13, 2021 at 09:53:34AM +0200, Laurent Vivier wrote: > Le 13/05/2021 à 08:11, Katsuhiro Ueno a écrit : > > Ping. > > cc Gerd Added to usb queue. thanks, Gerd

[Bug 1924603] Re: Incorrect feature negotiation for vhost-vdpa netdevice

2021-05-18 Thread Thomas Huth
Not sure who should be the assignee here ... maybe it's best if you write a mail to the people who have been involved in the original code (see https://gitlab.com/qemu-project/qemu/-/commit/108a64818e69be0a97c ) and ask them who could have a look at this issue. -- You received this bug

Re: [PATCH v1 01/11] target/arm: Add isar_feature_{aa32, aa64, aa64_sve}_bf16

2021-05-18 Thread Peter Maydell
On Sat, 17 Apr 2021 at 00:59, Richard Henderson wrote: > > Note that the SVE BFLOAT16 support does not require SVE2, > it is an independent extension. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH] remove qemu-options* from root directory

2021-05-18 Thread Markus Armbruster
Paolo Bonzini writes: > On 18/05/21 10:54, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> These headers are also included from softmmu/vl.c, so they should be >>> in include/. Removing qemu-options-wrapper.h, since elsewhere >>> we include "template" headers directly and #define the

Re: [PATCH] target/ppc: Fix load endianness for lxvwsx/lxvdsx

2021-05-18 Thread Richard Henderson
On 5/18/21 4:23 AM, Giuseppe Musacchio wrote: TARGET_WORDS_BIGENDIAN may not match the machine endianness if that's a runtime-configurable parameter. Fixes: bcb0b7b1a1c05707304f80ca6f523d557816f85c Resolves: https://gitlab.com/qemu-project/qemu/-/issues/212 Signed-off-by: Giuseppe Musacchio

Re: [PATCH v1 05/11] fpu: Add float_round_to_odd_inf

2021-05-18 Thread Peter Maydell
On Sat, 17 Apr 2021 at 01:02, Richard Henderson wrote: > > For Arm BFDOT and BFMMLA, we need a version of round-to-odd > that overflows to infinity, instead of the max normal number. > > Signed-off-by: Richard Henderson > --- > include/fpu/softfloat-types.h | 4 +++- > fpu/softfloat.c

Re: [PATCH v3 0/3] hw/elf_ops: clear uninitialized segment space

2021-05-18 Thread Laurent Vivier
Le 29/04/2021 à 16:13, Laurent Vivier a écrit : > When the mem_size of the segment is bigger than the file_size, > and if this space doesn't overlap another segment, it needs > to be cleared. > > When the file is loaded in RAM, it is cleared by the loader (PATCH 2), > when the file is loaded in a

Re: [PATCH 3/7] virtiofsd: Use iov_discard_front() to skip bytes

2021-05-18 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > There are places where we need to skip few bytes from front of the iovec > array. We have our own custom code for that. Looks like iov_discard_front() > can do same thing. So use that helper instead. > > Signed-off-by: Vivek Goyal Oh nice; I hadn't

Re: [PATCH 6/7] virtiofsd: Check EOF before short read

2021-05-18 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > In virtio_send_data_iov() we are checking first for short read and then > EOF condition. Change the order. Basically check for error and EOF first > and last remaining piece is short ready which will lead to retry > automatically at the end of while loop.

[PATCH 4/5] block: check for sys/disk.h

2021-05-18 Thread Paolo Bonzini
From: Joelle van Dyne Some BSD platforms do not have this header. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Joelle van Dyne Message-Id: <20210315180341.31638-...@getutm.app> Signed-off-by: Paolo Bonzini --- block.c | 2 +- meson.build | 1 + 2 files

[PULL v2 05/29] docker: Add Hexagon image

2021-05-18 Thread Alex Bennée
From: Alessandro Di Federico This image is a little special because it takes a long time to build. As such most users don't want to be doing that and just pull random binaries from the ether as intended by the container gods. This involves someone with credentials and a beefy machine running:

[PULL v2 09/29] tests/docker: Added libbpf library to the docker files.

2021-05-18 Thread Alex Bennée
From: Andrew Melnychenko The series of patches for eBPF RSS adds libbpf dependency for qemu. https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg08887.html With this patch, libbpf added: Alpine - added libbpf-dev Centos 8 - added libbpf-devel Fedora - added libbpf-devel

[PULL v2 03/29] tests/docker: allow "update" to add the current user

2021-05-18 Thread Alex Bennée
The current user functionality is used for cross compiling to avoid complications with permissions when building test programs. However for images that come from the registry we still need the ability to add the user after the fact. Reviewed-by: Willian Rampazzo Signed-off-by: Alex Bennée

[PULL v2 04/29] tests/docker: add "fetch" sub-command

2021-05-18 Thread Alex Bennée
This simply wraps up fetching a build from the registry and tagging it as the local build. Reviewed-by: Willian Rampazzo Signed-off-by: Alex Bennée Message-Id: <20210512102051.12134-6-alex.ben...@linaro.org> diff --git a/tests/docker/docker.py b/tests/docker/docker.py index

[PULL v2 19/29] tests/tcg/tricore: Add fadd test

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-11-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-21-alex.ben...@linaro.org> diff --git

[PULL v2 18/29] tests/tcg/tricore: Add dvstep test

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann Tested-by: Alex Bennée Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id: <20210305170045.869437-10-kbast...@mail.uni-paderborn.de> Message-Id: <20210512102051.12134-20-alex.ben...@linaro.org> diff --git a/tests/tcg/tricore/macros.h

[PULL v2 25/29] tests/docker: gcc-10 based images for ppc64{, le} tests

2021-05-18 Thread Alex Bennée
From: Matheus Ferst A newer compiler is needed to build tests for Power10 instructions. As done for arm64 on c729a99d2701, a new '-test-cross' image is created for ppc64 and ppc64le. As done on 936fda4d771f, a test for compiler support is added to verify that the toolchain in use has

[PATCH v2 3/5] blockjob: let ratelimit handle a speed of 0

2021-05-18 Thread Emanuele Giuseppe Esposito
From: Paolo Bonzini Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Paolo Bonzini Signed-off-by: Emanuele Giuseppe Esposito --- blockjob.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/blockjob.c b/blockjob.c index dc1d9e0e46..22e5bb9b1f 100644

Re: [PATCH v2 04/50] target/i386: Split out check_vm86_iopl

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:12, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) Reviewed-by: Paolo Bonzini

Re: [PATCH v2 29/50] target/i386: Add stub generator for helper_set_dr

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: This removes an ifdef from the middle of disas_insn, and ensures that the branch is not reachable. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-)

Re: [PATCH v2 33/50] target/i386: Eliminate SVM helpers for user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Use STUB_HELPER to ensure that such calls are always eliminated. Signed-off-by: Richard Henderson --- target/i386/helper.h | 3 +-- target/i386/tcg/translate.c | 9 target/i386/tcg/user/svm_stubs.c | 38

[PATCH v2 2/7] block-copy: improve documentation of BlockCopyTask and BlockCopyState types and functions

2021-05-18 Thread Emanuele Giuseppe Esposito
As done in BlockCopyCallState, categorize BlockCopyTask and BlockCopyState in IN, State and OUT fields. This is just to understand which field has to be protected with a lock. BlockCopyTask .zeroes is a special case, because it is only initialized and then read by the coroutine in

Re: [PATCH v2 05/21] qapi/parser: Assert lexer value is a string

2021-05-18 Thread Markus Armbruster
John Snow writes: > The type checker can't narrow the type of the token value to string, > because it's only loosely correlated with the return token. > > We know that a token of '#' should always have a "str" value. > Add an assertion. > > Signed-off-by: John Snow > --- >

Re: [PATCH v2 37/50] target/i386: Remove pc_start argument to gen_svm_check_intercept

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: When exiting helper_svm_check_intercept via exception, cpu_vmexit calls cpu_restore_state, which will recover eip and cc_op via unwind. Therefore we do not need to store eip or cc_op before the call. Signed-off-by: Richard Henderson ---

Re: [PATCH v5 23/23] target/ppc: Move cmp/cmpi/cmpl/cmpli to decodetree

2021-05-18 Thread Richard Henderson
On 5/17/21 3:50 PM, matheus.fe...@eldorado.org.br wrote: +if(a->l && (ctx->insns_flags & PPC_64B)) { Space after IF. If I look back to the 6xx manual, I see NOTE: If L = 1, the instruction form is invalid. The fact that we're allowing L=1 for ppc32 is an existing bug, afaics. We

Re: [PATCH v2 49/50] target/i386: Move helper_check_io to sysemu

2021-05-18 Thread Paolo Bonzini
On 14/05/21 19:45, Richard Henderson wrote: On 5/14/21 10:13 AM, Richard Henderson wrote: --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -193,6 +193,7 @@ typedef struct DisasContext {   { qemu_build_not_reached(); }   #ifdef CONFIG_USER_ONLY +STUB_HELPER(check_io,

Re: [PATCH v4 00/13] virtio-gpu: Add support for Blob resources feature (v4)

2021-05-18 Thread Gerd Hoffmann
On Tue, May 11, 2021 at 03:47:06PM -0700, Vivek Kasireddy wrote: > Enabling this feature would eliminate data copies from the resource > object in the Guest to the shadow resource in Qemu. This patch series > however adds support only for Blobs of type > VIRTIO_GPU_BLOB_MEM_GUEST with property

[PATCH v2 3/7] block-copy: move progress_set_remaining in block_copy_task_end

2021-05-18 Thread Emanuele Giuseppe Esposito
Moving this function in task_end ensures to update the progress anyways, even if there is an error. It also helps in next patch, allowing task_end to have only one critical section. Signed-off-by: Emanuele Giuseppe Esposito --- block/block-copy.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH v2 4/5] progressmeter: protect with a mutex

2021-05-18 Thread Emanuele Giuseppe Esposito
On 18/05/2021 12:00, Vladimir Sementsov-Ogievskiy wrote: 18.05.2021 12:40, Emanuele Giuseppe Esposito wrote: Progressmeter is protected by the AioContext mutex, which is taken by the block jobs and their caller (like blockdev). We would like to remove the dependency of block layer code on

[PULL v2 00/13] Block layer patches

2021-05-18 Thread Kevin Wolf
The following changes since commit 367196caa07ac31443bc360145cc10fbef4fdf92: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.1-pull-request' into staging (2021-05-17 16:44:47 +0100) are available in the Git repository at: git://repo.or.cz/qemu/kevin.git

Re: [PATCH 10/21] block/copy-before-write: relax permission requirements when no parents

2021-05-18 Thread Vladimir Sementsov-Ogievskiy
18.05.2021 14:10, Max Reitz wrote: On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: We are going to publish copy-before-write filter. So, user should be able to create it with blockdev-add first, specifying both filtered and target children. And then do blockdev-reopen, to actually insert

[PATCH v2] hw/display/qxl: Set pci rom address aligned with page size

2021-05-18 Thread Bibo Mao
From: maobibo On some MIPS system, page size is 16K, and qxl vga device can be used for VM in kvm mode. Qxl pci rom size is set 8K fixed, smaller than 16K page size on host system, it fails to be added into memslots in kvm mode where memory_size and GPA are required to align with page size.

Re: [PATCH 7/7] virtiofsd: Set req->reply_sent right after sending reply

2021-05-18 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > There is no reason to set it in label "err". We should be able to set > it right after sending reply. It is easier to read. > > Signed-off-by: Vivek Goyal Reviewed-by: Dr. David Alan Gilbert > --- > tools/virtiofsd/fuse_virtio.c | 5 + > 1 file

Re: Fwd: Adding devices via QMP's device_add don't have their bootindex setting respected

2021-05-18 Thread Paolo Bonzini
On 18/05/21 14:22, Thomas Parrott wrote: Due to QEMU moving towards a QMP configuration mechanism and away from config file support, the LXD team are currently in the process of migrating to using QMP to add devices to VMs (so that we can support the use of QEMU 6.0). If the only issue you

Re: [PULL 00/20] emulated nvme updates

2021-05-18 Thread Peter Maydell
On Mon, 17 May 2021 at 10:17, Klaus Jensen wrote: > > From: Klaus Jensen > > Hi Peter, > > The following changes since commit 6005ee07c380cbde44292f5f6c96e7daa70f4f7d: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2021-05-16 17:22:46 +0100) > > are available

Re: [PATCH] qemu-config: load modules when instantiating option groups

2021-05-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210518131542.2941207-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210518131542.2941207-1-pbonz...@redhat.com Subject: [PATCH] qemu-config: load

[PATCH 3/3] ci: add -j to all "make" jobs

2021-05-18 Thread Paolo Bonzini
Run the tests in parallel, as that can greatly speed up the jobs. "meson test" is able to report failures to the terminal in a way that is readable enough even when tests are run in parallel. Signed-off-by: Paolo Bonzini --- .cirrus.yml| 18 +- .gitlab-ci.yml | 8

Re: [PATCH] fdc: check drive block device before usage (CVE-2021-20196)

2021-05-18 Thread P J P
Hello John, +-- On Mon, 17 May 2021, John Snow wrote --+ | > /* Selected drive */ | > -fdctrl->cur_drv = value & FD_DOR_SELMASK; | > +if (fdctrl->drives[value & FD_DOR_SELMASK].blk) { | > +fdctrl->cur_drv = value & FD_DOR_SELMASK; | > +} | | I don't think this is

[PULL v2 07/29] gitlab: add build-user-hexagon test

2021-05-18 Thread Alex Bennée
We special case this as the container with the cross compiler for the tests takes so long to build it is manually uploaded into the registry. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Willian Rampazzo Tested-by:

[PULL v2 10/29] tests/tcg: Add docker_as and docker_ld cmds

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann At least for the TriCore target no easily available c compiler exists. Thus we need to rely on "as" and "ld". This allows us to run them through the docker image. We don't test the generation capabilities of docker images as they are assumed to work. Reviewed-by:

[PULL v2 11/29] tests/tcg: Run timeout cmds using --foreground

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann when trying to run successful short tests from the Makefile timeout would not terminate. Rather it would wait until the time runs out. Excerpt from the manpage: --foreground when not running timeout directly from a shell prompt, allow COMMAND to read from the

[PULL v2 14/29] configure: Emit HOST_CC to config-host.mak

2021-05-18 Thread Alex Bennée
From: Bastian Koppelmann this is needed by the tricore-tcg-tests as tricore-gcc is not easily available. Thus we rely on the HOST_CC to do the preprocessing of the tricore assembly files. Signed-off-by: Bastian Koppelmann Signed-off-by: Alex Bennée Message-Id:

Re: [PATCH 04/21] qdev: allow setting drive property for realized device

2021-05-18 Thread Vladimir Sementsov-Ogievskiy
18.05.2021 12:09, Max Reitz wrote: On 17.05.21 20:09, Vladimir Sementsov-Ogievskiy wrote: 17.05.2021 18:48, Max Reitz wrote: On 17.05.21 08:44, Vladimir Sementsov-Ogievskiy wrote: We need an ability to insert filters above top block node, attached to block device. It can't be achieved with

[PATCH v2 4/5] progressmeter: protect with a mutex

2021-05-18 Thread Emanuele Giuseppe Esposito
Progressmeter is protected by the AioContext mutex, which is taken by the block jobs and their caller (like blockdev). We would like to remove the dependency of block layer code on the AioContext mutex, since most drivers and the core I/O code are already not relying on it. Create a new C file

Re: [PATCH v2 21/50] target/i386: Reduce DisasContext.override to int8_t

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: The range of values is -1 (none) to 5 (R_GS). Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index

Re: [PULL v2 00/29] testing and plugin updates

2021-05-18 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210518090720.21915-1-alex.ben...@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210518090720.21915-1-alex.ben...@linaro.org Subject: [PULL v2 00/29] testing and

Re: [PATCH v5 19/23] target/ppc: Implement setbc/setbcr/stnbc/setnbcr instructions

2021-05-18 Thread Richard Henderson
On 5/17/21 3:50 PM, matheus.fe...@eldorado.org.br wrote: +if(neg) { Missing space. r~

Re: [PATCH v2 31/50] target/i386: Assert !GUEST for user-only

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: For user-only, we do not need to check for VMM intercept. Signed-off-by: Richard Henderson Reviewed-by: Paolo Bonzini target/i386/tcg/translate.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 41/50] target/i386: Move invlpg, hlt, monitor, mwait to sysemu

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: These instructions are all privileged. Signed-off-by: Richard Henderson --- target/i386/helper.h | 8 ++-- target/i386/tcg/helper-tcg.h | 1 + target/i386/tcg/misc_helper.c| 55 +---

Re: [PATCH v4 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed

2021-05-18 Thread 'Gerd Hoffmann '
On Tue, May 11, 2021 at 03:55:37PM -0300, gust...@noronha.eti.br wrote: > From: Gustavo Noronha Silva > > Applications such as Gnome may use Alt-Tab and Super-Tab for different > purposes, some use Ctrl-arrows so we want to allow qemu to handle > everything when it captures the mouse/keyboard. >

Re: [PATCH v2 47/50] target/i386: Pass in port to gen_check_io

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: Pass in a pre-truncated TCGv_i32 value. We were doing the truncation of EDX in multiple places, now only once per insn. While all callers use s->tmp2_i32, for cleanliness of the subroutine, use a parameter anyway. Signed-off-by: Richard Henderson

Re: [PATCH v2 50/50] target/i386: Remove user-only i/o stubs

2021-05-18 Thread Paolo Bonzini
On 14/05/21 17:13, Richard Henderson wrote: With the previous patch for check_io, we now have enough for the compiler to dead-code eliminate all of the i/o helpers. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson Reviewed-by: Paolo Bonzini --- target/i386/helper.h

[PATCH v2 0/7] block-copy: protect block-copy internal structures

2021-05-18 Thread Emanuele Giuseppe Esposito
This serie of patches aims to reduce the usage of the global AioContexlock in block-copy, by introducing smaller granularity locks thus on making the block layer thread safe. This serie depends on Paolo's coroutine_sleep API and my previous serie that brings thread safety to the smaller API used

  1   2   3   4   5   6   >