Since "linux-user: fix use of SIGRTMIN" (6bc024e7), qemu removed
use of __SIGRTMAX except for in this QEMU_BUILD_BUG_ON assert.
Presumably, this check is to ensure that the loop in signal_table_init
from SIGRTMIN to SIGRTMAX falls within the bounds of
host_to_target_signal_table (_NSIG).
However,
Due to some real user scenarios don't need to monitor all traffic.
And qemu net-filter also need function to more detailed flow control.
This series give user ability to passthrough kinds of COLO network stream.
For example, windows guest user want to enable windows remote desktop
to touch
Since the real user scenario does not need COLO to monitor all traffic.
Add colo-passthrough-add and colo-passthrough-del to maintain
a COLO network passthrough list. Add IPFlowSpec struct for all QMP commands.
Except protocol field is necessary, other fields are optional.
Signed-off-by: Zhang
Add passthrough list for each CompareState.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 28
net/colo-compare.h | 12
2 files changed, 40 insertions(+)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 8175612c5f..2250efd40d 100644
---
_sigev_un._tid is an internal glibc field and is not available on
musl libc. The sigevent(7) man page and Linux UAPI headers both use
sigev_notify_thread_id as a public way to access this field.
musl libc supports this field since 1.2.2[0], and glibc plans to
add support as well[1][2].
If
On 5/17/21 3:51 AM, Philippe Mathieu-Daudé wrote:
The current cpu.c contains sysemu-specific methods.
To avoid building them in user-mode builds, split the
current cpu.c as cpu-common.c / cpu-sysemu.c.
Start by moving cpu_get_crash_info().
Signed-off-by: Philippe Mathieu-Daudé
---
On 5/17/21 3:51 AM, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
hw/core/cpu.c | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Richard Henderson
r~
On 5/17/21 3:51 AM, Philippe Mathieu-Daudé wrote:
In commit cbc183d2d9f ("cpu: move cc->transaction_failed to tcg_ops")
we restricted the do_transaction_failed() handler to the sysemu part
of TCGCPUOps, but forgot to restrict the target specific declarations.
Signed-off-by: Philippe
Add hmp_colo_passthrough_add and hmp_colo_passthrough_del make user
can maintain COLO network passthrough list in human monitor
Signed-off-by: Zhang Chen
---
hmp-commands.hx | 26 ++
include/monitor/hmp.h | 2 ++
monitor/hmp-cmds.c| 82
On 5/17/21 3:51 AM, Philippe Mathieu-Daudé wrote:
See rationale in previous commit. Targets should use the vmsd field
of DeviceClass, not CPUClass. As migration is not important on the
AVR target, break the migration compatibility and set the DeviceClass
vmsd field. To feel safer, increment the
Rename structure with COLO index and move it to .h file,
It make other modules can reuse COLO code.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 132 -
net/colo-compare.h | 86 +
2 files changed, 109 insertions(+),
Add support for H_SCM_PERFORMANCE_STATS described at [1] for
spapr nvdimms. This enables guest to fetch performance stats[2] like
expected life of an nvdimm ('MemLife ') etc and display them to the
user. Linux kernel support for fetching these performance stats and
exposing them to the user-space
Use connection protocol,src port,dst port,src ip,dst ip as the key
to bypass certain network traffic in COLO compare.
Signed-off-by: Zhang Chen
---
net/net.c | 162 +-
1 file changed, 160 insertions(+), 2 deletions(-)
diff --git a/net/net.c
No need to carry the flag all the time in many scenarios.
Signed-off-by: Zhang Chen
---
include/qemu/sockets.h | 1 +
util/qemu-sockets.c| 14 ++
2 files changed, 15 insertions(+)
diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h
index 7d1f813576..d5abc227eb 100644
On Thu, May 13, 2021 at 08:26:35AM +0200, Julia Suvorova wrote:
> The patch set consists of two parts:
> patches 1-4: introduce new feature
> 'acpi-pci-hotplug-with-bridge-support' on Q35
> patches 5-7: make the feature default along with changes in ACPI tables
>
> This way
On 5/24/21 5:27 AM, Peter Maydell wrote:
Here's a draft schedule for the 6.1 cycle:
2021-07-13 Soft feature freeze. Only bug fixes after this point.
2021-07-20 Hard feature freeze. Tag rc0
2021-07-27 Tag rc1
2021-08-03 Tag rc2
2021-08-10 Tag rc3
2021-08-17 Release; or tag rc4 if needed
On Tue, May 25, 2021 at 7:59 AM Takashi Yamamoto wrote:
>
> On Mon, May 24, 2021 at 7:59 PM Alex Bennée wrote:
> >
> >
> > YAMAMOTO Takashi writes:
> >
> > > Otherwise, it can be easily fooled by the user app using chdir().
> > >
> > > Signed-off-by: YAMAMOTO Takashi
> > > ---
> > >
On Fri, 12 Feb 2021 07:02:26 PST (-0800), zhiwei_...@c-sky.com wrote:
Signed-off-by: LIU Zhiwei
---
target/riscv/helper.h | 6
target/riscv/insn32.decode | 6
target/riscv/insn_trans/trans_rvp.c.inc | 7
target/riscv/packed_helper.c|
On 5/24/21 9:00 AM, Palmer Dabbelt wrote:
On Mon, 15 Mar 2021 14:22:58 PDT (-0700), alistai...@gmail.com wrote:
On Fri, Feb 12, 2021 at 10:14 AM LIU Zhiwei
wrote:
Signed-off-by: LIU Zhiwei
Acked-by: Alistair Francis
I saw some reviews on the other ones, but since others (like this)
On 5/25/21 5:20 AM, Richard Henderson wrote:
> On 5/24/21 7:58 PM, Swetha Joshi wrote:
>> Signed-off-by: Swetha Joshi
>> ---
>> target/arm/kvm64.c | 12
>> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> You're still missing the commit message.
>
>>
>> diff --git
I've been unable to replicate the crash with any of the instructions
here. Certainly all the statically compiled unit tests work and I've
just done a build of QEMU in an emulated Debian Buster (Armel) docker
image.
--
You received this bug notification because you are a member of qemu-
devel-ml,
24.05.2021 20:33, Programmingkid wrote:
On May 24, 2021, at 12:56 PM, Vladimir Sementsov-Ogievskiy
wrote:
24.05.2021 19:06, Programmingkid wrote:
On May 24, 2021, at 11:55 AM, Vladimir Sementsov-Ogievskiy
wrote:
24.05.2021 18:41, Programmingkid wrote:
On May 24, 2021, at 6:12 AM,
ping
On 11.05.2021 12:11, Pavel Dovgalyuk wrote:
This patch enables reverse debugging with watchpoints.
Reverse continue scans the execution to find the breakpoints
and watchpoints that should fire. It uses helper function
replay_breakpoint() for that. But this function needs to access
icount,
ping
On 11.05.2021 11:40, Pavel Dovgalyuk wrote:
This patch fixes calculation of number of the instructions
that fit the current page. It prevents creation of the translation
blocks that cross the page boundaries. It is required for deterministic
exception generation in icount mode.
On Freitag, 21. Mai 2021 13:59:47 CEST Greg Kurz wrote:
> On Sun, 16 May 2021 19:06:44 +0200
>
> Christian Schoenebeck wrote:
> > Hi Greg,
> >
> > while reviewing the 9p code base for further optimizations, I stumbled
> > over
> > the 'rename_lock' introduced by 02cb7f3a2 and wondered about
On 25/05/2021 9:59, Dov Murik wrote:
> From: James Bottomley
>
> If the VM is using memory encryption and also specifies a kernel/initrd
> or appended command line, calculate the hashes and add them to the
> encrypted data. For this to work, OVMF must support an encrypted area
> to place the
These patches add a few parameters to blkdebug to allow modification of
the block device block sizes, both logical and physical. It also adds a
test that uses the parameter to verify correct UNMAP behavior in devices
with 4k blocks.
v2: fixes style issues
Kit Westneat (3):
block/blkdebug: add
Allow users to specify the block size of the qdev for testing purposes.
Signed-off-by: Kit Westneat
---
block/blkdebug.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index 2c0b9b0ee8..d5f589920c 100644
---
Coverity points out that in tpm_test_swtpm_migration_test() we
assume that src_tpm_addr and dst_tpm_addr are non-NULL (we
pass them to tpm_util_migration_start_qemu() which will
unconditionally dereference them) but then later explicitly
check them for NULL. Remove the pointless checks.
Fixes:
On 5/24/21 10:42 PM, Cleber Rosa wrote:
On Wed, May 12, 2021 at 07:12:23PM -0400, John Snow wrote:
When creating a source distribution via 'python3 setup.py sdist', the
VERSION and PACKAGE.rst files aren't bundled by default. Create a
MANIFEST.in file that instructs the build tools to include
Ping for review? :)
On 5/17/21 1:11 PM, Philippe Mathieu-Daudé wrote:
> Hi,
>
> This series restricts various system emulation specific headers
> by moving them under sysemu/ and adding #error if included from
> user emulation.
> We could avoid the sysemu/ rename if too much churn, but enforcing
Created a file with stubs needed to compile disabling TCG. *_ppc_opcodes
were created to make cpu_init.c have a few less ifdefs, since they are
not needed. softmmu_resize_hpt_* have to be created because the compiler
can't automatically know they aren't used, but they should never be
reached.
updated build file to not compile some sources that are unnecessary if
TCG is disabled on the system.
Signed-off-by: Bruno Larsen (billionai)
---
target/ppc/meson.build | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/target/ppc/meson.build b/target/ppc/meson.build
On 5/25/21 1:24 PM, Alex Bennée wrote:
> The gprof/gcov passed on retry. I'll continue to look at it but didn't want
> to hold up the PR because of it. - Alex
>
> The following changes since commit 0dab1d36f55c3ed649bb8e4c74b9269ef3a63049:
>
> Merge remote-tracking branch
>
Add test for issue #345
Signed-off-by: Kit Westneat
---
tests/qtest/virtio-scsi-test.c | 50 ++
1 file changed, 50 insertions(+)
diff --git a/tests/qtest/virtio-scsi-test.c b/tests/qtest/virtio-scsi-test.c
index 1b7ecc1c8f..e569bda7d0 100644
---
Based-on: <20210525112431.22005-1-alex.ben...@linaro.org>
https://github.com/stsquad/qemu.git tags/pull-testing-and-misc-updates-250521=
-1
Philippe Mathieu-Daud=C3=A9 (2):
!fixup gitlab: add special rule for the hexagon container
gitlab-ci: Convert check-dco/check-patch jobs to the 'rules'
On 5/9/21 8:16 AM, Philippe Mathieu-Daudé wrote:
From: Richard Henderson
Signed-off-by: Richard Henderson
Message-Id:<20210508201640.1045808-1-richard.hender...@linaro.org>
[PMD: Split from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
---
accel/tcg/cputlb.c | 15 ---
1
We have a backlog of Coverity issues in tests (because we only
started running the scan on test code when we switched to meson
and started building the test code in "make" rather than only
in "make check"). This series fixes some of the easier ones.
There's nothing exciting here, it's all little
On 5/9/21 8:16 AM, Philippe Mathieu-Daudé wrote:
From: Richard Henderson
Signed-off-by: Richard Henderson
Message-Id: <20210508201640.1045808-1-richard.hender...@linaro.org>
[PMD: Split from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
---
include/exec/exec-all.h | 12
The e1000e_send_verify() test calls qemu_recv() but doesn't
check that the call succeeded, which annoys Coverity. Add
an explicit test check for the length of the data.
(This is a test check, not a "we assume this syscall always
succeeds", so we use g_assert_cmpint() rather than g_assert().)
On 5/9/21 8:16 AM, Philippe Mathieu-Daudé wrote:
From: Richard Henderson
Signed-off-by: Richard Henderson
Message-Id: <20210508201640.1045808-1-richard.hender...@linaro.org>
[PMD: Split from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
---
accel/tcg/cputlb.c | 13 ++---
1
On 5/9/21 8:16 AM, Philippe Mathieu-Daudé wrote:
From: Richard Henderson
Now than ... /* we use range? FILL ME... */ ... we can remove the
encode_pbm_to_runon() and flush_all_helper() calls.
Signed-off-by: Richard Henderson
Message-Id:<20210508201640.1045808-1-richard.hender...@linaro.org>
On 5/25/21 3:44 PM, Peter Maydell wrote:
> Coverity notices that the checks against mkstemp() failing in
> create_qcow2_with_mbr() are wrong: mkstemp returns -1 on failure but
> the check is just "g_assert(fd)". Fix to use "g_assert(fd >= 0)",
> matching the correct check in create_test_img().
>
On 5/25/21 3:44 PM, Peter Maydell wrote:
> Coverity points out that we calculate a 64-bit value using 32-bit
> arithmetic; add the cast to force the multiply to be done as 64-bits.
> (The overflow will never happen with the current test data.)
>
> Fixes: Coverity CID 1432320
> Signed-off-by:
From: James Bottomley
If the VM is using memory encryption and also specifies a kernel/initrd
or appended command line, calculate the hashes and add them to the
encrypted data. For this to work, OVMF must support an encrypted area
to place the data which is advertised via a special GUID in the
ping? (patch reviewed).
On 5/13/21 6:20 PM, Philippe Mathieu-Daudé wrote:
> On Fedora 32, using clang (version 10.0.1-3.fc32) we get:
>
> tests/qtest/fuzz/fuzz.c:237:5: error: implicit declaration of function
> 'qemu_init' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>
ping?
On 5/15/21 3:45 PM, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (2):
> tests/acceptance: Ignore binary data sent on serial console
> tests/acceptance: Add tests for the Pegasos2 machine
>
> tests/acceptance/avocado_qemu/__init__.py | 7 +-
>
From: Alex Bennée
Since c8e6793903 ("containers.yml: build with docker.py tooling") we
don't need to manually pull stuff from the upstream repository. Just
set the -r field to explicitly use that rather than the current
registry.
Signed-off-by: Alex Bennée
Message-Id:
Extract the build/test jobs run by default on the mainstream
CI into a new file (buildtest.yml).
Reviewed-by: Willian Rampazzo
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci.d/buildtest.yml | 736 +
.gitlab-ci.yml | 736
25.05.2021 13:18, Emanuele Giuseppe Esposito wrote:
On 21/05/2021 19:10, Vladimir Sementsov-Ogievskiy wrote:
18.05.2021 13:07, Emanuele Giuseppe Esposito wrote:
With tasks and calls lock protecting all State fields,
.method is the last BlockCopyState field left unprotected.
Set it as atomic.
Philippe Mathieu-Daudé writes:
> Sometimes pull requests are merged during the week-end, triggering
> a CI pipeline. Currently if such pipeline fails, the Avocado reports
> are available for 2 days. For the reviewers working on the project
> during office hours, the reports are already
We are compiling with -fno-common since commit 4c288acbd6 ("configure:
Always build with -fno-common"), so --warn-common (which had been added
in commit 49237acdb725e in 2008 already) should not be necessary anymore
nowadays.
Signed-off-by: Thomas Huth
---
Marked as RFC since I'm not 100% sure
Philippe Mathieu-Daudé writes:
> From: Alex Bennée
>
> Since c8e6793903 ("containers.yml: build with docker.py tooling") we
> don't need to manually pull stuff from the upstream repository. Just
> set the -r field to explicitly use that rather than the current
> registry.
>
> Signed-off-by:
These patches add a few parameters to blkdebug to allow modification of
the block device block sizes, both logical and physical. It also adds a
test that uses the parameter to verify correct UNMAP behavior in devices
with 4k blocks.
Kit Westneat (3):
block/blkdebug: add blocksize parameter
Allow users to specify the block size of the qdev for testing purposes.
Signed-off-by: Kit Westneat
---
block/blkdebug.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index 2c0b9b0ee8..c7500746a8 100644
---
Allow users to specify the logical and physical block sizes of the
qdev for testing purposes.
Signed-off-by: Kit Westneat
---
block/blkdebug.c | 36 +++-
1 file changed, 31 insertions(+), 5 deletions(-)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index
Make the build-user-hexagon -> hexagon-cross-container optional
to avoid on mainstream CI [*]:
'build-user-hexagon' job needs 'hexagon-cross-container' job
but it was not added to the pipeline
[*] https://gitlab.com/qemu-project/qemu/-/pipelines/309137207
Signed-off-by: Philippe
Per GitLab documentation [*]:
"rules replaces only/except and they can’t be used together
in the same job."
Since the 'rules' syntax is more powerful and we are already using
it, convert the check-dco/check-patch jobs so no job use the 'only/
except' syntax.
[*]
Coverity notes that we don't check for dup2() failing. Add some
assertions so that if it does ever happen we get some indication.
(This is similar to how we handle other "don't expect this syscall to
fail" checks in this test code.)
Fixes: Coverity CID 1432346
Signed-off-by: Peter Maydell
---
Coverity complains that we don't check for failures from dup()
and mkstemp(); add asserts that these syscalls succeeded.
Fixes: Coverity CID 1432516, 1432574
Signed-off-by: Peter Maydell
---
tests/unit/test-vmstate.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
On 5/25/21 3:44 PM, Peter Maydell wrote:
> Coverity complains that we don't check for failures from dup()
> and mkstemp(); add asserts that these syscalls succeeded.
>
> Fixes: Coverity CID 1432516, 1432574
> Signed-off-by: Peter Maydell
> ---
> tests/unit/test-vmstate.c | 2 ++
> 1 file
From: Mahmoud Mandour
Added a table-like output which contains the total number of calls
for each used syscall along with the number of errors that occurred.
Per-call tracing is still available through supplying the argument
``print`` to the plugin.
Signed-off-by: Mahmoud Mandour
This is not a 32 bit number, it can (and most likely will) be quite a
big one.
Signed-off-by: Alex Bennée
Reviewed-by: Pavel Dovgalyuk
Reviewed-by: Philippe Mathieu-Daudé
Message-Id: <20210520174303.12310-7-alex.ben...@linaro.org>
diff --git a/hmp-commands.hx b/hmp-commands.hx
index
From: Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé
Signed-off-by: Alex Bennée
Reviewed-by: Richard Henderson
Message-Id: <20210505170055.1415360-3-phi...@redhat.com>
Message-Id: <20210520174303.12310-5-alex.ben...@linaro.org>
diff --git a/gdbstub.c b/gdbstub.c
index
In theory we don't need an actual record/replay to enact reverse
debugging on a purely deterministic system (i.e one with no external
inputs running under icount). Tidy away the logic into a little
function.
Signed-off-by: Alex Bennée
Reviewed-by: Richard Henderson
Reviewed-by: Philippe
On 5/25/21 1:10 PM, Alex Bennée wrote:
> Philippe Mathieu-Daudé writes:
>> From: Alex Bennée
>>
>> Since c8e6793903 ("containers.yml: build with docker.py tooling") we
>> don't need to manually pull stuff from the upstream repository. Just
>> set the -r field to explicitly use that rather than
excp_helper.c, mmu-hash64.c and mmu_helper.c have some function
declarations that are TCG-only, and couldn't be easily moved to a
TCG only file, so ifdefs were added around them.
We also needed ifdefs around some header files because helper-proto.h
includes trace/generated-helpers.h, which is
The write calback decision when registering the MAS SPR has been turned
into a ternary operation, rather than an if-then-else block.
This was done because when building without TCG, even though the
compiler will optimize away the pointers to spr_write_generic*, it
doesn't optimize away the
This patch series finishes the the changes required to support disabling
TCG for ppc targets.
With the current version of the patch, the project compiles and runs ok,
but we need some more testing to ensure that no regressions happened,
especially with relation to gdb.
Based-on:
> On May 25, 2021, at 2:05 AM, Vladimir Sementsov-Ogievskiy
> wrote:
>
> 24.05.2021 20:33, Programmingkid wrote:
>>> On May 24, 2021, at 12:56 PM, Vladimir Sementsov-Ogievskiy
>>> wrote:
>>>
>>> 24.05.2021 19:06, Programmingkid wrote:
> On May 24, 2021, at 11:55 AM, Vladimir
Add test for issue #345
Signed-off-by: Kit Westneat
---
tests/qtest/virtio-scsi-test.c | 48 ++
1 file changed, 48 insertions(+)
diff --git a/tests/qtest/virtio-scsi-test.c b/tests/qtest/virtio-scsi-test.c
index 1b7ecc1c8f..6557e4f422 100644
---
Patchew URL:
https://patchew.org/QEMU/20210525124753.528516-1-kit.westn...@gmail.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210525124753.528516-1-kit.westn...@gmail.com
Subject: [PATCH 0/3] testing block
On 5/9/21 8:16 AM, Philippe Mathieu-Daudé wrote:
From: Richard Henderson
Signed-off-by: Richard Henderson
Message-Id: <20210508201640.1045808-1-richard.hender...@linaro.org>
[PMD: Split from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
---
include/exec/exec-all.h | 13 +
Coverity points out that we calculate a 64-bit value using 32-bit
arithmetic; add the cast to force the multiply to be done as 64-bits.
(The overflow will never happen with the current test data.)
Fixes: Coverity CID 1432320
Signed-off-by: Peter Maydell
---
tests/qtest/pflash-cfi02-test.c | 2
On 5/17/21 12:51 PM, Philippe Mathieu-Daudé wrote:
> Missing review: 2-5 (new) and 13
Ping for review? :)
> This series is inspired on Claudio TCG work.
>
> Instead of separate TCG from other accelerators, here we
> separate sysemu operations (system VS user).
>
> Since v6:
> - Rebased (3
The -msoft-float switch is not available in older versions of Clang.
Since we rely on the compiler to not generate floating point instructions
unexpectedly, we block those old compilers now via a test in the configure
script. Note that for some weird reasons, the Clang compiler only complains
On 5/25/21 11:40 AM, Philippe Mathieu-Daudé wrote:
> On 5/20/21 7:42 PM, Alex Bennée wrote:
>> The hexagon container is always manually built but of course not
>> everyone will be building it themselves and pushing to their
>> registries. We still need to create a "local" registry copy for the
>>
Philippe Mathieu-Daudé writes:
> Due to a design problem and misunderstanding between the Avocado
> framework and QEMU, Avocado is fetching many asset artifacts it
> shouldn't be fetching, exhausting the jobs CI timeout.
>
> Since Avocado artifacts are cached, this is not an issue with old
>
On Tue, 25 May 2021 at 02:07, Richard Henderson
wrote:
>
> Changes for v7:
> * Incorporate patch review, some of which broke out new patches.
> * Recover 4 patches which somehow got dropped during the v6 rebase.
> This should have been caught by risu testing, but I must have
> thought
On 5/25/21 1:53 PM, Bruno Larsen (billionai) wrote:
> excp_helper.c, mmu-hash64.c and mmu_helper.c have some function
> declarations that are TCG-only, and couldn't be easily moved to a
> TCG only file, so ifdefs were added around them.
>
> We also needed ifdefs around some header files because
Allow users to specify the logical and physical block sizes of the
qdev for testing purposes.
Signed-off-by: Kit Westneat
---
block/blkdebug.c | 39 +--
1 file changed, 33 insertions(+), 6 deletions(-)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index
On 5/9/21 8:16 AM, Philippe Mathieu-Daudé wrote:
From: Richard Henderson
Signed-off-by: Richard Henderson
Message-Id:<20210508201640.1045808-1-richard.hender...@linaro.org>
[PMD: Split from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
---
accel/tcg/cputlb.c | 24
On 5/9/21 8:16 AM, Philippe Mathieu-Daudé wrote:
From: Richard Henderson
Signed-off-by: Richard Henderson
Message-Id: <20210508201640.1045808-1-richard.hender...@linaro.org>
[PMD: Split from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
---
include/exec/exec-all.h | 19
Coverity notices that the checks against mkstemp() failing in
create_qcow2_with_mbr() are wrong: mkstemp returns -1 on failure but
the check is just "g_assert(fd)". Fix to use "g_assert(fd >= 0)",
matching the correct check in create_test_img().
Fixes: Coverity CID 1432274
Signed-off-by: Peter
On 5/9/21 8:16 AM, Philippe Mathieu-Daudé wrote:
From: Richard Henderson
Signed-off-by: Richard Henderson
Message-Id:<20210508201640.1045808-1-richard.hender...@linaro.org>
[PMD: Split from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé
---
accel/tcg/cputlb.c | 12 ++--
1 file
On 5/25/21 3:44 PM, Peter Maydell wrote:
> Coverity points out that in tpm_test_swtpm_migration_test() we
> assume that src_tpm_addr and dst_tpm_addr are non-NULL (we
> pass them to tpm_util_migration_start_qemu() which will
> unconditionally dereference them) but then later explicitly
> check
The _POSIX_C_SOURCE and _XOPEN_SOURCE macros are used by the
application to indicate to libc which declarations it should expose.
Since qemu does not define them anywhere, it does not make sense
to check their value.
Instead, since the intent is to determine whether the host struct
stat supports
On Tue, 25 May 2021 22:30:14 PDT (-0700), Palmer Dabbelt wrote:
On Fri, 12 Feb 2021 07:02:26 PST (-0800), zhiwei_...@c-sky.com wrote:
Signed-off-by: LIU Zhiwei
---
target/riscv/helper.h | 6
target/riscv/insn32.decode | 6
Ok, confirmed, with that new reproducer it also detects the error here
when I compile QEMU with Clang and ASAN enabled.
** Changed in: qemu
Status: Incomplete => Confirmed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Ok, thanks for checking! So let's close this ticket now.
** Changed in: qemu
Status: Incomplete => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1878067
Title:
Assertion
ping? (patch reviewed)
On 5/16/21 10:50 PM, Philippe Mathieu-Daudé wrote:
> Headers should be included from the 'include/' directory,
> not from the root directory.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/i386/acpi-common.h | 6 +++---
> include/monitor/monitor.h | 2 +-
>
25.05.2021 11:50, Max Reitz wrote:
On 19.05.21 08:11, Vladimir Sementsov-Ogievskiy wrote:
18.05.2021 19:39, Max Reitz wrote:
[...]
On 17.05.21 14:07, Vladimir Sementsov-Ogievskiy wrote:
[...]
Not also, that there is another benefit of such thing: we'll implement this
callback in qcow2
On 20/05/2021 17:19, Vladimir Sementsov-Ogievskiy wrote:
18.05.2021 13:07, Emanuele Giuseppe Esposito wrote:
Because the list of tasks is only modified by coroutine
functions, add a CoMutex in order to protect them.
Use the same mutex to protect also BlockCopyState in_flight_bytes
field to
We first set have_virtfs_proxy_helper depending on have_virtfs,
then update have_virtfs... While this might work, it is not clear
when looking at the code logic. Move the have_virtfs_proxy_helper
assignation *after* updating have_virtfs to make it obvious.
Signed-off-by: Philippe Mathieu-Daudé
Philippe Mathieu-Daudé writes:
> Extract the build/test jobs run by default on the mainstream
> CI into a new file (buildtest.yml).
>
> Reviewed-by: Willian Rampazzo
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Alex Bennée
--
Alex Bennée
The hexagon container is always manually built but of course not
everyone will be building it themselves and pushing to their
registries. We still need to create a "local" registry copy for the
actual gitlab tests to run. We don't build it in this case, just pull
it across from the upstream
Instead of jumping through hoops let glib deal with both tracking the
number of elements and auto freeing the memory once we are done. This
allows is to drop the usage of ALLOCA(3) which the man-page mentions
its "use is discouraged".
Signed-off-by: Alex Bennée
Message-Id:
ping? (patch reviewed)
On 5/13/21 7:12 PM, Philippe Mathieu-Daudé wrote:
> Inspired-by: Volker Rümelin
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/input/ps2.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/input/ps2.c b/hw/input/ps2.c
> index
Various patches to make mainstream CI green again:
- rebased "gitlab-ci: Ease forks pipeline workflow" on testing-next
- split gprof-gcov job
- run avocado tests manually (except on mainstream)
- fix firmware jobs to only run when files changed
- discard avocado results on success, keep them
Document how forks can use different set of jobs and add
a big warning so no new configuration is added to this
file.
Suggested-by: Daniel Berrangé
Signed-off-by: Philippe Mathieu-Daudé
---
.gitlab-ci.yml | 14 ++
1 file changed, 14 insertions(+)
diff --git a/.gitlab-ci.yml
1 - 100 of 453 matches
Mail list logo
