[PATCH v2 2/2] arm/aspeed: Add DPS310 to Witherspoon and Rainier

2021-06-16 Thread Joel Stanley
Witherspoon uses the DPS310 as a temperature sensor. Rainier uses it as a temperature and humidity sensor. Signed-off-by: Joel Stanley --- hw/arm/aspeed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 0eafc791540d..619ad869dd71

RE: [PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp

2021-06-16 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Tuesday, June 15, 2021 7:12 PM > To: qemu-devel@nongnu.org > Cc: laur...@vivier.eu; alex.ben...@linaro.org; Taylor Simpson > > Subject: [PATCH 07/21] linux-user/hexagon: Implement setup_sigtramp > > Continue to initialize the

Re: [PATCH 0/5] dp8393x: fixes for MacOS toolbox ROM

2021-06-16 Thread Mark Cave-Ayland
On 16/06/2021 04:09, Finn Thain wrote: On Mon, 14 Jun 2021, Mark Cave-Ayland wrote: On 14/06/2021 06:36, Philippe Mathieu-Daudé wrote: Cc'ing Finn & Laurent. On 6/13/21 6:37 PM, Mark Cave-Ayland wrote: Here is the next set of patches from my attempts to boot MacOS under QEMU's Q800

[PATCH v4 0/2] QOMify Sifive UART Model

2021-06-16 Thread Lukas Jünger
Hello, I have updated the commit message as requested by Bin. Best regards, Lukas Lukas Jünger (2): hw/char: Consistent function names for sifive_uart hw/char: QOMify sifive_uart include/hw/char/sifive_uart.h | 11 ++- hw/char/sifive_uart.c | 152

Re: [PATCH v5 06/16] qemu-iotests: delay QMP socket timers

2021-06-16 Thread Emanuele Giuseppe Esposito
On 15/06/2021 09:57, Vladimir Sementsov-Ogievskiy wrote: 14.06.2021 13:36, Emanuele Giuseppe Esposito wrote: On 04/06/2021 11:17, Emanuele Giuseppe Esposito wrote: Attaching gdbserver implies that the qmp socket should wait indefinitely for an answer from QEMU. For Timeout class, create

[PATCH v2 1/2] hw/misc: Add Infineon DPS310 sensor model

2021-06-16 Thread Joel Stanley
This contains some hardcoded register values that were obtained from the hardware after reading the temperature. It does enough to test the Linux kernel driver. The FIFO mode, IRQs and operation modes other than the default as used by Linux are not modelled. Signed-off-by: Joel Stanley --- v2:

[PATCH v2 0/2] hw/misc: DPS310 temp and pressure sensor model

2021-06-16 Thread Joel Stanley
v2 addresses the review from Cédric. I chose to drop the qom get/setters as the logic was quite involved, and requires more work to get right. This is a model for the Infineon DPS310 temperature and barometric pressure sensor. Joel Stanley (2): hw/misc: Add Infineon DPS310 sensor model

Re: [PATCH 0/5] dp8393x: fixes for MacOS toolbox ROM

2021-06-16 Thread Finn Thain
On Mon, 14 Jun 2021, Mark Cave-Ayland wrote: > On 14/06/2021 06:36, Philippe Mathieu-Daudé wrote: > > > Cc'ing Finn & Laurent. > > > > On 6/13/21 6:37 PM, Mark Cave-Ayland wrote: > > > Here is the next set of patches from my attempts to boot MacOS under > > > QEMU's Q800 machine related to the

Re: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-16 Thread Markus Armbruster
"Zhang, Chen" writes: >> -Original Message- >> From: Markus Armbruster >> Sent: Tuesday, June 15, 2021 10:43 PM >> To: Zhang, Chen >> Cc: Jason Wang ; qemu-dev > de...@nongnu.org>; Eric Blake ; Dr. David Alan >> Gilbert ; Daniel P.Berrangé ; >> Gerd Hoffmann ; Li Zhijian ; >> Lukas

[PATCH v4 2/2] hw/char: QOMify sifive_uart

2021-06-16 Thread Lukas Jünger
This QOMifies the SiFive UART model. Migration and reset have been implemented. Signed-off-by: Lukas Jünger --- include/hw/char/sifive_uart.h | 11 ++-- hw/char/sifive_uart.c | 114 +++--- 2 files changed, 109 insertions(+), 16 deletions(-) diff --git

[PATCH v4 1/2] hw/char: Consistent function names for sifive_uart

2021-06-16 Thread Lukas Jünger
This cleanes up function names in the SiFive UART model. Signed-off-by: Lukas Jünger --- hw/char/sifive_uart.c | 46 ++- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index

Re: [PATCH v4 1/2] hw/char: Consistent function names for sifive_uart

2021-06-16 Thread Alistair Francis
On Wed, Jun 16, 2021 at 4:44 PM Lukas Jünger wrote: > > This cleanes up function names in the SiFive UART model. > > Signed-off-by: Lukas Jünger Please keep all previous tags when re-sending patches (unless you make substantial changes) Reviewed-by: Alistair Francis Alistair > --- >

Re: [PATCH 02/11] keyval: introduce keyval_merge

2021-06-16 Thread Markus Armbruster
Paolo Bonzini writes: > This patch introduces a function that merges two keyval-produced > (or keyval-like) QDicts. It can be used to emulate the behavior of > .merge_lists = true QemuOpts groups, merging -readconfig sections and > command-line options in a single QDict, and also to implement

Re: [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast

2021-06-16 Thread Hyman Huang
在 2021/6/3 22:19, huang...@chinatelecom.cn 写道: From: Hyman Huang(黄勇) thread_id in CpuInfoFast is deprecated, parse thread-id instead after execute qmp query-cpus-fast. fix this so that test can go smoothly. Signed-off-by: Hyman Huang(黄勇) --- tests/migration/guestperf/engine.py | 2 +-

Re: [PATCH 2/2] tests/migration: fix "downtime_limit" type when "migrate-set-parameters"

2021-06-16 Thread Hyman Huang
在 2021/6/3 22:20, huang...@chinatelecom.cn 写道: From: Hyman Huang(黄勇) migrate-set-parameters parse "downtime_limit" as integer type when execute "migrate-set-parameters" before migration, and, the unit dowtime_limit is milliseconds, fix this two so that test can go smoothly. Signed-off-by:

Re: [PATCH qemu v21] spapr: Implement Open Firmware client interface

2021-06-16 Thread Alexey Kardashevskiy
On 6/15/21 20:29, BALATON Zoltan wrote: On Tue, 15 Jun 2021, Alexey Kardashevskiy wrote: The PAPR platform describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor.

RE: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-16 Thread Zhang, Chen
> -Original Message- > From: Markus Armbruster > Sent: Wednesday, June 16, 2021 2:04 PM > To: Zhang, Chen > Cc: Lukas Straub ; Daniel P.Berrangé > ; Li Zhijian ; Jason Wang > ; qemu-dev ; Dr. David > Alan Gilbert ; Gerd Hoffmann ; > Zhang Chen ; Eric Blake > Subject: Re: [PATCH V8

[PATCH] qapi: Fix crash on missing enum member name

2021-06-16 Thread Markus Armbruster
New test case enum-dict-no-name.json crashes: $ python3 scripts/qapi-gen.py tests/qapi-schema/enum-dict-no-name.json Traceback (most recent call last): [...] File "/work/armbru/qemu/scripts/qapi/expr.py", line 458, in check_enum member_name = member['name'] KeyError:

Re: [PATCH qemu v21] spapr: Implement Open Firmware client interface

2021-06-16 Thread Alexey Kardashevskiy
On 6/16/21 07:09, BALATON Zoltan wrote: On Tue, 15 Jun 2021, Alexey Kardashevskiy wrote: The PAPR platform describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require collaboration between the firmware and the hypervisor.

Re: [RFC PATCH v2 2/2] target/ppc: make gdb able to translate priviledged addresses

2021-06-16 Thread David Gibson
On Tue, Jun 15, 2021 at 08:32:32AM -0300, Bruno Piazera Larsen wrote: > On 14/06/2021 19:37, Richard Henderson wrote: > > On 6/14/21 12:16 PM, Bruno Larsen (billionai) wrote: > > > This patch changes ppc_cpu_get_phys_page_debug so that it is now > > > able to translate both, priviledged and real

Re: [PATCH v2 1/2] target/ppc: fix address translation bug for radix mmus

2021-06-16 Thread David Gibson
On Tue, Jun 15, 2021 at 09:25:06AM -0300, Bruno Piazera Larsen wrote: > > On 15/06/2021 00:20, Richard Henderson wrote: > > On 6/14/21 6:41 PM, David Gibson wrote: > > > I think move these to mmu-book3s-v3.h, since they're correct for both > > > the radix and hash sides of the modern book3s mmu.

Re: [PATCH v8 3/9] i386: hardcode supported eVMCS version to '1'

2021-06-16 Thread Vitaly Kuznetsov
Eduardo Habkost writes: > On Tue, Jun 08, 2021 at 02:08:11PM +0200, Vitaly Kuznetsov wrote: >> Currently, the only eVMCS version, supported by KVM (and described in TLFS) >> is '1'. When Enlightened VMCS feature is enabled, QEMU takes the supported >> eVMCS version range (from

[PATCH 2/3] hw/char: renesas_sci Add SCI and SCIF support.

2021-06-16 Thread Yoshinori Sato
This peripheral using SH7750. Signed-off-by: Yoshinori Sato --- include/hw/char/renesas_sci.h | 43 ++- hw/char/renesas_sci.c | 489 ++ 2 files changed, 531 insertions(+), 1 deletion(-) diff --git a/include/hw/char/renesas_sci.h

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-16 Thread Gerd Hoffmann
> > Hmm, what would be the use case? Right now qemu has the all-or-nothing > > approach for modules, i.e. if modules are enabled everything we can > > build as module will be built as module, and I havn't seen any drawbacks > > so far. So, why would one compile parts of qemu as module and other

[Bug 1892962] Re: Segfault in usb_bus_from_device

2021-06-16 Thread Thomas Huth
Ok, let's assume it's fixed - so I'm closing this now. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1892962 Title: Segfault in

Re: [PATCH v3 4/4] s390x/css: Add passthrough IRB

2021-06-16 Thread Cornelia Huck
On Wed, Jun 16 2021, Eric Farman wrote: > Wire in the subchannel callback for building the IRB > ESW and ECW space for passthrough devices, and copy > the hardware's ESW into the IRB we are building. > > If the hardware presented concurrent sense, then copy > that sense data into the IRB's ECW

Re: [PATCH] hw/audio/sb16: Avoid assertion by restricting I/O sampling rate range

2021-06-16 Thread Philippe Mathieu-Daudé
On 6/16/21 11:16 AM, Gerd Hoffmann wrote: > Hi, > >> Should I send this patch with tag V2? > > Yes, please. I don't understand why. Shouldn't it be enough if Qiang Liu replies with "Tested-by: Qiang Liu " ?

Re: [PATCH V3 5/6] block/rbd: add write zeroes support

2021-06-16 Thread Ilya Dryomov
On Wed, May 19, 2021 at 4:28 PM Peter Lieven wrote: > > Signed-off-by: Peter Lieven > --- > block/rbd.c | 37 - > 1 file changed, 36 insertions(+), 1 deletion(-) > > diff --git a/block/rbd.c b/block/rbd.c > index 0d8612a988..ee13f08a74 100644 > ---

Re: [PATCH v2] hw/audio/sb16: Avoid assertion by restricting I/O sampling rate range

2021-06-16 Thread Philippe Mathieu-Daudé
On 6/16/21 1:58 PM, Qiang Liu wrote: > Thx. I learned a lot about contributing to QEMU from this discussion! I think this was a misunderstanding with Gerd, the maintainer. Maintainers use some tools to ease their patch-by-email workflow. As a tester/reviewer you simply reply to a patch with a

Re: [PATCH v3 1/4] s390x/css: Introduce an ESW struct

2021-06-16 Thread Eric Farman
On Wed, 2021-06-16 at 11:46 +0200, Cornelia Huck wrote: > On Wed, Jun 16 2021, Eric Farman wrote: > > > The Interrupt Response Block is comprised of several other > > structures concatenated together, but only the 12-byte > > Subchannel-Status Word (SCSW) is defined as a proper struct. > >

Re: [PATCH v2 0/8] configure: Change to -std=gnu11

2021-06-16 Thread Paolo Bonzini
On 15/06/21 01:31, Richard Henderson wrote: Now that we assume gcc 7.5 as a minimum, we have the option of changing to a newer C standard. The two major new features that I think apply are _Generic and _Static_assert. While Paolo created a remarkably functional replacement for _Generic using

[PULL 00/25] target-arm queue

2021-06-16 Thread Peter Maydell
rge remote-tracking branch 'remotes/berrange-gitlab/tags/misc-fixes-pull-request' into staging (2021-06-14 15:59:13 +0100) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20210616 for you to fetch

Re: [PATCH 2/2] docs/system/arm: Add quanta-gbs-bmc reference

2021-06-16 Thread Cédric Le Goater
On 6/15/21 9:28 PM, Patrick Venture wrote: > Add line item reference to quanta-gbs-bmc machine. > > Signed-off-by: Patrick Venture Reviewed-by: Cédric Le Goater Thanks, C. > --- > docs/system/arm/nuvoton.rst | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

[PATCH 3/3] hw/sh4: sh7750 using renesas_sci.

2021-06-16 Thread Yoshinori Sato
Signed-off-by: Yoshinori Sato --- include/hw/sh4/sh.h | 8 hw/sh4/sh7750.c | 41 + hw/sh4/Kconfig | 2 +- 3 files changed, 42 insertions(+), 9 deletions(-) diff --git a/include/hw/sh4/sh.h b/include/hw/sh4/sh.h index

Re: [PATCH v3 1/4] s390x/css: Introduce an ESW struct

2021-06-16 Thread Cornelia Huck
On Wed, Jun 16 2021, Eric Farman wrote: > The Interrupt Response Block is comprised of several other > structures concatenated together, but only the 12-byte > Subchannel-Status Word (SCSW) is defined as a proper struct. > Everything else is a simple array of 32-bit words. > > Let's define a

Re: [PATCH v6 cxl2.0-v6-doe 5/6] cxl/cdat: CXL CDAT Data Object Exchange implementation

2021-06-16 Thread Jonathan Cameron
On Thu, 10 Jun 2021 09:16:33 -0400 Chris Browy wrote: > From: hchkuo > > The Data Object Exchange implementation of CXL Coherent Device Attribute > Table (CDAT). This implementation is referring to "Coherent Device > Attribute Table Specification, Rev. 1.02, Oct. 2020" and "Compute > Express

Re: [PATCH qemu v21] spapr: Implement Open Firmware client interface

2021-06-16 Thread BALATON Zoltan
On Wed, 16 Jun 2021, Alexey Kardashevskiy wrote: On 6/15/21 20:29, BALATON Zoltan wrote: On Tue, 15 Jun 2021, Alexey Kardashevskiy wrote: The PAPR platform describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require

Re: [PATCH 02/11] keyval: introduce keyval_merge

2021-06-16 Thread Paolo Bonzini
On 16/06/21 10:38, Markus Armbruster wrote: ... and both values are the same other QType (QTYPE_QNULL, QTYPE_QNUM, QTYPE_QSTRING, QTYPE_QBOOL): overwrite. Why is overwrite restricted to same QType? Is there no need for overwriting say a string with a number? Hmm, I guess it's okay, because

[Bug 1923583] Re: colo: pvm flush failed after svm killed

2021-06-16 Thread meeho yuen
https://git.qemu.org/?p=qemu.git;a=commit;h=5529b02da2dcd1ef6bc6cd42d4fbfb537fe2276f ** Changed in: qemu Status: Incomplete => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH 0/4] modules: add support for target-specific modules.

2021-06-16 Thread Claudio Fontana
On 6/16/21 11:28 AM, Gerd Hoffmann wrote: >>> Hmm, what would be the use case? Right now qemu has the all-or-nothing >>> approach for modules, i.e. if modules are enabled everything we can >>> build as module will be built as module, and I havn't seen any drawbacks >>> so far. So, why would one

[PATCH v2 3/4] target/i386: Added consistency checks for CR0

2021-06-16 Thread Lara Lazier
The combination of unset CD and set NW bit in CR0 is illegal. CR0[63:32] are also reserved and need to be zero. (AMD64 Architecture Programmer's Manual, V2, 15.5) Signed-off-by: Lara Lazier --- target/i386/cpu.h | 2 ++ target/i386/svm.h | 2 ++

[PATCH v2 2/4] target/i386: Added consistency checks for VMRUN intercept and ASID

2021-06-16 Thread Lara Lazier
Zero VMRUN intercept and ASID should cause an immediate VMEXIT during the consistency checks performed by VMRUN. (AMD64 Architecture Programmer's Manual, V2, 15.5) Signed-off-by: Lara Lazier --- target/i386/tcg/sysemu/svm_helper.c | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [PULL v1 0/5] Merge tpm 2021/06/15 v1

2021-06-16 Thread Peter Maydell
On Tue, 15 Jun 2021 at 16:22, Stefan Berger wrote: > > Hello! > > The patches in this PR eliminate all TPM related code if CONFIG_TPM is > not set, thus reducing code size. > > Regards, >Stefan > > The following changes since commit 1ea06abceec61b6f3ab33dadb0510b6e09fb61e2: > > Merge

Re: [PATCH v2] migration/rdma: Use huge page register VM memory

2021-06-16 Thread LIZHAOXIN1 [李照鑫]
> When using libvirt for RDMA live migration, if the VM memory is too large, > it will take a lot of time to deregister the VM at the source side, resulting > in a long downtime (VM 64G, deregister vm time is about 400ms). > > Although the VM's memory uses 2M huge pages, the MLNX driver still

Re: [PATCH v3 3/7] block: add max_hw_transfer to BlockLimits

2021-06-16 Thread Paolo Bonzini
On 15/06/21 18:18, Max Reitz wrote:   } +/* Returns the maximum hardware transfer length, in bytes; guaranteed nonzero */ +uint64_t blk_get_max_hw_transfer(BlockBackend *blk) +{ +    BlockDriverState *bs = blk_bs(blk); +    uint64_t max = INT_MAX; + +    if (bs) { +    max =

Re: [PATCH 1/2] docs/system/arm: Add quanta-q7l1-bmc reference

2021-06-16 Thread Cédric Le Goater
On 6/15/21 9:28 PM, Patrick Venture wrote: > Adds a line-item reference to the supported quanta-q71l-bmc aspeed > entry. > > Signed-off-by: Patrick Venture Reviewed-by: Cédric Le Goater Thanks, C. > --- > docs/system/arm/aspeed.rst | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v2 1/2] hw/misc: Add Infineon DPS310 sensor model

2021-06-16 Thread Cédric Le Goater
On 6/16/21 9:33 AM, Joel Stanley wrote: > This contains some hardcoded register values that were obtained from the > hardware after reading the temperature. > > It does enough to test the Linux kernel driver. The FIFO mode, IRQs and > operation modes other than the default as used by Linux are

[PATCH 1/3] hw/char: renesas_sci: Refactor for merge all SCI variant..

2021-06-16 Thread Yoshinori Sato
In order to handle unified all of the SCI, SCIa and SCIF in one part, to separate the transmission and reception portion and a register portion. RenesasSCIBase - common registers operation and event handling. RenesasSCIA - SCIa specific reigisters / functions. Signed-off-by: Yoshinori Sato ---

[PATCH v5 2/2] hw/char: QOMify sifive_uart

2021-06-16 Thread Lukas Jünger
This QOMifies the SiFive UART model. Migration and reset have been implemented. Signed-off-by: Lukas Jünger Reviewed-by: Bin Meng --- include/hw/char/sifive_uart.h | 11 ++-- hw/char/sifive_uart.c | 114 +++--- 2 files changed, 109 insertions(+), 16

Re: [PATCH qemu v21] spapr: Implement Open Firmware client interface

2021-06-16 Thread BALATON Zoltan
On Wed, 16 Jun 2021, Alexey Kardashevskiy wrote: On 6/16/21 07:09, BALATON Zoltan wrote: On Tue, 15 Jun 2021, Alexey Kardashevskiy wrote: The PAPR platform describes an OS environment that's presented by a combination of a hypervisor and firmware. The features it specifies require

[qemu-web PATCH 2/4] css: Improve the hover effect of the buttons

2021-06-16 Thread Thomas Huth
The hover effect of buttons was hardly visible since the color did not change much. Use a brighter color to make it clear that the button can be pressed. Resolves: https://gitlab.com/qemu-project/qemu-web/-/issues/1 Signed-off-by: Thomas Huth --- assets/css/style.css | 2 +- 1 file changed, 1

[qemu-web PATCH 1/4] Show only the latest three releases on the website

2021-06-16 Thread Thomas Huth
The QEMU project is only maintaining the very latest releases, so this could be the current RC version, followed by the current stable release and maybe also still the previous stable release (in case there are severe bugs). But it does not make sense to show a fourth release that we very likely

[qemu-web PATCH 0/4] Improve the download information on the website

2021-06-16 Thread Thomas Huth
Make it more clear that QEMU only supports the latest versions, improve the color of a button, and put the emphasis on the source code tarballs. Thomas Huth (4): Show only the latest three releases on the website css: Improve the hover effect of the buttons State that there is no official

Re: tb_flush() calls causing long Windows XP boot times

2021-06-16 Thread Programmingkid
> On Jun 15, 2021, at 9:58 PM, Richard Henderson > wrote: > > On 6/15/21 6:58 AM, Programmingkid wrote: >>> Ahh I misread - so those are the addresses of the routines and not where >>> it's sticking the breakpoint? >>> >>> I notice from a bit of googling that there is a boot debugger. I

[PATCH v2 1/4] target/i386: Refactored intercept checks into cpu_svm_has_intercept

2021-06-16 Thread Lara Lazier
Added cpu_svm_has_intercept to reduce duplication when checking the corresponding intercept bit outside of cpu_svm_check_intercept_param Signed-off-by: Lara Lazier --- target/i386/cpu.h | 3 + target/i386/tcg/sysemu/svm_helper.c | 105 +++- 2 files

[PATCH v2 0/4] target/i386: Start fixing kvm-unit-tests for svm

2021-06-16 Thread Lara Lazier
Following the APM2 I added some checks to resolve the following tests in kvm-unit-tests for svm: * vmrun_intercept_check * asid_zero * sel_cr0_bug * CR0 CD=0,NW=1: a0010011 * CR0 63:32: 180010011 * CR0 63:32: 1080010011 * CR0 63:32: 10080010011 * CR0 63:32: 100080010011 * CR0

Re: [PATCH v2 1/2] tests: migration-test: Still run the rest even if uffd missing

2021-06-16 Thread Juan Quintela
Peter Xu wrote: > Currently we'll skip the whole migration-test if uffd missing. > > It's a bit harsh - we can still run the rest besides postcopy! Enable them > when we still can. > > It'll happen more frequently now after kernel UFFD_USER_MODE_ONLY introduced > in > commit 37cd0575b8510159,

Re: [Virtio-fs] [PATCH v2 7/9] virtiofsd: Add inodes_by_handle hash table

2021-06-16 Thread Max Reitz
On 11.06.21 22:04, Vivek Goyal wrote: On Wed, Jun 09, 2021 at 05:55:49PM +0200, Max Reitz wrote: Currently, lo_inode.fhandle is always NULL and so always keep an O_PATH FD in lo_inode.fd. Therefore, when the respective inode is unlinked, its inode ID will remain in use until we drop our

Re: [PATCH 01/21] linux-user: Add infrastructure for a signal trampoline page

2021-06-16 Thread Max Filippov
On Tue, Jun 15, 2021 at 6:20 PM Richard Henderson wrote: > > Allocate a page to hold the signal trampoline(s). > Invoke a guest-specific hook to fill in the contents > of the page before marking it read-execute again. > > Signed-off-by: Richard Henderson > --- > linux-user/qemu.h| 7

Re: [PATCH 20/21] linux-user/xtensa: Implement setup_sigtramp

2021-06-16 Thread Max Filippov
On Tue, Jun 15, 2021 at 6:12 PM Richard Henderson wrote: > > Create and record the rt signal trampoline. > Use it when the guest does not use SA_RESTORER. > > Cc: Max Filippov > Signed-off-by: Richard Henderson > --- > linux-user/xtensa/target_signal.h | 2 ++ > linux-user/xtensa/signal.c

Re: [PATCH v3 3/7] block: add max_hw_transfer to BlockLimits

2021-06-16 Thread Max Reitz
On 16.06.21 15:18, Paolo Bonzini wrote: On 15/06/21 18:18, Max Reitz wrote:   } +/* Returns the maximum hardware transfer length, in bytes; guaranteed nonzero */ +uint64_t blk_get_max_hw_transfer(BlockBackend *blk) +{ +    BlockDriverState *bs = blk_bs(blk); +    uint64_t max = INT_MAX; + +   

Re: [PATCH v2 03/18] modules: add qemu-modinfo utility

2021-06-16 Thread Gerd Hoffmann
On Tue, Jun 15, 2021 at 03:35:44PM +0200, Paolo Bonzini wrote: > On 15/06/21 15:07, Gerd Hoffmann wrote: > > > Hmm, looks like I actually need both. Seems there is no easy way to get > > > the cflags out of a source_set to construct a cpp command line. Pulling > > > this out of

Re: [PATCH v4 2/2] hw/char: QOMify sifive_uart

2021-06-16 Thread Bin Meng
On Wed, Jun 16, 2021 at 2:44 PM Lukas Jünger wrote: > > This QOMifies the SiFive UART model. Migration and reset have been > implemented. > > Signed-off-by: Lukas Jünger > --- > include/hw/char/sifive_uart.h | 11 ++-- > hw/char/sifive_uart.c | 114 +++--- >

Re: [PATCH v4 1/2] hw/char: Consistent function names for sifive_uart

2021-06-16 Thread Bin Meng
On Wed, Jun 16, 2021 at 2:43 PM Lukas Jünger wrote: > > This cleanes up function names in the SiFive UART model. typo: cleans > > Signed-off-by: Lukas Jünger > --- > hw/char/sifive_uart.c | 46 ++- > 1 file changed, 24 insertions(+), 22 deletions(-) >

Re: [PATCH v2 1/2] hw/misc: Add Infineon DPS310 sensor model

2021-06-16 Thread Joel Stanley
On Wed, 16 Jun 2021 at 09:09, Cédric Le Goater wrote: > On 6/16/21 9:33 AM, Joel Stanley wrote: > > +typedef struct DPS310State { > > +/*< private >*/ > > +I2CSlave i2c; > > + > > +/*< public >*/ > > +uint8_t regs[NUM_REGISTERS]; > > + > > +int16_t pressure, temperature; > > >

Re: [PATCH] docs: describe the security considerations with virtiofsd xattr mapping

2021-06-16 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > Different guest xattr prefixes have distinct access control rules applied > by the guest. When remapping a guest xattr care must be taken that the > remapping does not allow the a guest user to bypass guest kernel access > control rules. > > For

Re: [PATCH 08/21] linux-user/hppa: Document non-use of setup_sigtramp

2021-06-16 Thread Philippe Mathieu-Daudé
+Helge On 6/16/21 3:11 AM, Richard Henderson wrote: > We cannot use a raw sigtramp page for hppa, > but must wait for full vdso support. > > Signed-off-by: Richard Henderson > --- > linux-user/hppa/target_signal.h | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git

Re: [PATCH v6 cxl2.0-v6-doe 6/6] test/cdat: CXL CDAT test data

2021-06-16 Thread Jonathan Cameron
On Thu, 10 Jun 2021 09:16:44 -0400 Chris Browy wrote: > From: hchkuo > > Pre-built CDAT table for testing, contains one CDAT header and six > CDAT entries: DSMAS, DSLBIS, DSMSCIS, DSIS, DSEMTS, and SSLBIS > respectively. > > Signed-off-by: hchkuo > Signed-off-by: Chris Browy I can't apply

Re: [RFC PATCH v2 2/2] target/ppc: make gdb able to translate priviledged addresses

2021-06-16 Thread Bruno Piazera Larsen
On 15/06/2021 18:37, Fabiano Rosas wrote: Richard Henderson writes: On 6/15/21 4:32 AM, Bruno Piazera Larsen wrote: On 14/06/2021 19:37, Richard Henderson wrote: On 6/14/21 12:16 PM, Bruno Larsen (billionai) wrote: This patch changes ppc_cpu_get_phys_page_debug so that it is now able to

Re: [PATCH] qapi: Fix crash on missing enum member name

2021-06-16 Thread Eric Blake
On Wed, Jun 16, 2021 at 09:21:21AM +0200, Markus Armbruster wrote: > New test case enum-dict-no-name.json crashes: > > $ python3 scripts/qapi-gen.py tests/qapi-schema/enum-dict-no-name.json > Traceback (most recent call last): > [...] > File

Re: [PATCH V3 1/6] block/rbd: bump librbd requirement to luminous release

2021-06-16 Thread Ilya Dryomov
On Wed, May 19, 2021 at 4:26 PM Peter Lieven wrote: > > even luminous (version 12.2) is unmaintained for over 3 years now. > Bump the requirement to get rid of the ifdef'ry in the code. > Qemu 6.1 dropped the support for RHEL-7 which was the last supported > OS that required an older librbd. > >

Re: [PATCH v3 26/26] virtiofsd: Ask qemu to drop CAP_FSETID if client asked for it

2021-06-16 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Thu, Jun 10, 2021 at 04:29:42PM +0100, Dr. David Alan Gilbert wrote: > > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > > > > > > > > Instead I was thinking about

Re: [PATCH v2 0/9] virtiofsd: Allow using file handles instead of O_PATH FDs

2021-06-16 Thread Max Reitz
On 11.06.21 21:19, Vivek Goyal wrote: On Wed, Jun 09, 2021 at 05:55:42PM +0200, Max Reitz wrote: Hi, v1 cover letter for an overview: https://listman.redhat.com/archives/virtio-fs/2021-June/msg00033.html Hi Max, What's the impact of these patches on performance? Just trying to get some idea

Re: [PATCH v2 2/2] arm/aspeed: Add DPS310 to Witherspoon and Rainier

2021-06-16 Thread Cédric Le Goater
On 6/16/21 9:33 AM, Joel Stanley wrote: > Witherspoon uses the DPS310 as a temperature sensor. Rainier uses it as > a temperature and humidity sensor. > > Signed-off-by: Joel Stanley Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/arm/aspeed.c | 4 ++-- > 1 file changed, 2

Re: [PATCH 0/3] renesas_sci update

2021-06-16 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210616091244.33049-1-ys...@users.sourceforge.jp/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210616091244.33049-1-ys...@users.sourceforge.jp Subject: [PATCH 0/3]

Re: [Virtio-fs] [PATCH] docs: describe the security considerations with virtiofsd xattr mapping

2021-06-16 Thread Dr. David Alan Gilbert
* Vivek Goyal (vgo...@redhat.com) wrote: > On Tue, Jun 15, 2021 at 04:46:45PM +0100, Daniel P. Berrangé wrote: > > On Fri, Jun 11, 2021 at 11:42:22AM -0400, Vivek Goyal wrote: > > > On Fri, Jun 11, 2021 at 01:04:27PM +0100, Daniel P. Berrangé wrote: > > > > Different guest xattr prefixes have

[PATCH] hw/rdma: Fix possible mremap overflow in the pvrdma device (CVE-2021-3582)

2021-06-16 Thread Marcel Apfelbaum
From: Marcel Apfelbaum Ensure mremap boundaries not trusting the guest kernel to pass the correct buffer length. Fixes: CVE-2021-3582 Reported-by: VictorV (Kunlun Lab) Tested-by: VictorV (Kunlun Lab) Signed-off-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_cmd.c | 6 ++ 1 file changed, 6

[qemu-web PATCH 3/4] State that there is no official support for older releases

2021-06-16 Thread Thomas Huth
Looking at some new tickets in the bug tracker, some people still seem to expect support for older releases. Let's make it a little bit more clear that the QEMU project only focuses on the very latest version. Signed-off-by: Thomas Huth --- support.md | 3 ++- 1 file changed, 2 insertions(+), 1

Re: tb_flush() calls causing long Windows XP boot times

2021-06-16 Thread Peter Maydell
On Wed, 16 Jun 2021 at 13:53, Alex Bennée wrote: > > Mark Cave-Ayland writes: > > diff --git a/exec.c b/exec.c > > index 67e520d18e..7f4074f95e 100644 > > --- a/exec.c > > +++ b/exec.c > > @@ -1019,14 +1019,13 @@ void tb_invalidate_phys_addr(AddressSpace *as, > > hwaddr addr, MemTxAttrs attrs) >

Re: tb_flush() calls causing long Windows XP boot times

2021-06-16 Thread Alex Bennée
Mark Cave-Ayland writes: > On 16/06/2021 02:58, Richard Henderson wrote: > >> On 6/15/21 6:58 AM, Programmingkid wrote: Ahh I misread - so those are the addresses of the routines and not where it's sticking the breakpoint? I notice from a bit of googling that there is a boot

Re: [PATCH v2] linux-user/trace-events: fix minor typo in format string

2021-06-16 Thread Laurent Vivier
Le 14/06/2021 à 16:42, Alex Bennée a écrit : > Signed-off-by: Alex Bennée > > --- > v2 > - fix typo in summary :-O > --- > linux-user/trace-events | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/linux-user/trace-events b/linux-user/trace-events > index

Re: [PATCH 04/21] linux-user/arm: Implement setup_sigtramp

2021-06-16 Thread Alex Bennée
Alex Bennée writes: > Richard Henderson writes: > >> ARM is more complicated than the others, in that we also >> have trampolines for using SA_RESTORER with FDPIC, and >> we need to create trampolines for both ARM and Thumb modes. >> >> Cc: qemu-...@nongnu.org >> Signed-off-by: Richard

Re: tb_flush() calls causing long Windows XP boot times

2021-06-16 Thread Mark Cave-Ayland
On 16/06/2021 02:58, Richard Henderson wrote: On 6/15/21 6:58 AM, Programmingkid wrote: Ahh I misread - so those are the addresses of the routines and not where it's sticking the breakpoint? I notice from a bit of googling that there is a boot debugger. I wonder if /nodebug in boot.ini stops

[PATCH 0/3] renesas_sci update

2021-06-16 Thread Yoshinori Sato
Renesas SH/RX have various SCI in serial interface. The design of sh_serial is old, so I integrate these SCIs with renesas_sci. Yoshinori Sato (3): hw/char: renesas_sci: Refactor for merge all SCI variant.. hw/char: renesas_sci Add SCI and SCIF support. hw/sh4: sh7750 using renesas_sci.

[PATCH v5 1/2] hw/char: Consistent function names for sifive_uart

2021-06-16 Thread Lukas Jünger
This cleans up function names in the SiFive UART model. Signed-off-by: Lukas Jünger Reviewed-by: Alistair Francis Reviewed-by: Bin Meng --- hw/char/sifive_uart.c | 46 ++- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git

Re: [PATCH] hw/audio/sb16: Avoid assertion by restricting I/O sampling rate range

2021-06-16 Thread Gerd Hoffmann
Hi, > Should I send this patch with tag V2? Yes, please. thanks, Gerd

[PATCH v5 0/2] QOMify Sifive UART Model

2021-06-16 Thread Lukas Jünger
Hello, I cleaned up the commit message as requested by Bin. Best regards, Lukas Lukas Jünger (2): hw/char: Consistent function names for sifive_uart hw/char: QOMify sifive_uart include/hw/char/sifive_uart.h | 11 ++- hw/char/sifive_uart.c | 152 +++---

[Bug 1911216] Re: abort issue locates in hw/usb/hcd-ohci.c:1297:ohci_frame_boundary

2021-06-16 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1911216 Title: abort issue locates in hw/usb/hcd-ohci.c:1297:ohci_frame_boundary Status in

Re: [PATCH v5 2/9] qapi: replace List[str] by QAPISchemaIfCond

2021-06-16 Thread Marc-André Lureau
Hi On Mon, Jun 14, 2021 at 4:20 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Wrap the 'if' condition in a higher-level object. Not only does this > > I can see "wrap in an object". I'm afraid don't get what makes it > "higher-level".

[PATCH v2] hw/audio/sb16: Avoid assertion by restricting I/O sampling rate range

2021-06-16 Thread Philippe Mathieu-Daudé
While the SB16 seems to work up to 48000 Hz, the "Sound Blaster Series Hardware Programming Guide" limit the sampling range from 4000 Hz to 44100 Hz (Section 3-9, 3-10: Digitized Sound I/O Programming, tables 3-2 and 3-3). Later, section 6-15 (DSP Commands) is more specific regarding the 41h /

Re: [PATCH v5 3/9] qapi: make gen_if/gen_endif take a simple string

2021-06-16 Thread Marc-André Lureau
Hi On Mon, Jun 14, 2021 at 4:48 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Instead of building prepocessor conditions from a list of string, use > > the result generated from QAPISchemaIfCond.cgen(). > > I understand why you're doing

[qemu-web PATCH 4/4] Present the source code on the first tab of the download page

2021-06-16 Thread Thomas Huth
The QEMU project provides the source code of QEMU, and not any binaries. So most people will come here for downloading the latest version of the source code and not for getting instructions on how to install the pre-packaged QEMU of their favourite distribution. Thus let's put the information

Re: [PATCH v2 2/2] tests: migration-test: Add dirty ring test

2021-06-16 Thread Juan Quintela
Peter Xu wrote: > Add dirty ring test if kernel supports it. Add the dirty ring parameter on > source should be mostly enough, but let's change the dest too to make them > match always. > > Reviewed-by: Dr. David Alan Gilbert > Signed-off-by: Peter Xu Reviewed-by: Juan Quintela Why we check

[PATCH v3] target/ppc: fix address translation bug for radix mmus

2021-06-16 Thread Bruno Larsen (billionai)
Based-on: <20210518201146.794854-1-richard.hender...@linaro.org> This commit attempts to fix the first bug mentioned by Richard Henderson in https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg06247.html To sumarize the bug here, when radix-style mmus are translating an address, they

Re: [PATCH v2 0/4] target/i386: Start fixing kvm-unit-tests for svm

2021-06-16 Thread Paolo Bonzini
On 16/06/21 14:39, Lara Lazier wrote: Following the APM2 I added some checks to resolve the following tests in kvm-unit-tests for svm: * vmrun_intercept_check * asid_zero * sel_cr0_bug * CR0 CD=0,NW=1: a0010011 * CR0 63:32: 180010011 * CR0 63:32: 1080010011 * CR0 63:32:

Re: [PATCH v2 2/2] tests: migration-test: Add dirty ring test

2021-06-16 Thread Peter Xu
On Wed, Jun 16, 2021 at 02:55:55PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > Add dirty ring test if kernel supports it. Add the dirty ring parameter on > > source should be mostly enough, but let's change the dest too to make them > > match always. > > > > Reviewed-by: Dr. David Alan

Re: [PATCH 04/21] linux-user/arm: Implement setup_sigtramp

2021-06-16 Thread Alex Bennée
Richard Henderson writes: > ARM is more complicated than the others, in that we also > have trampolines for using SA_RESTORER with FDPIC, and > we need to create trampolines for both ARM and Thumb modes. > > Cc: qemu-...@nongnu.org > Signed-off-by: Richard Henderson > --- >

Re: [PATCH v5 06/16] qemu-iotests: delay QMP socket timers

2021-06-16 Thread Vladimir Sementsov-Ogievskiy
16.06.2021 10:09, Emanuele Giuseppe Esposito wrote: On 15/06/2021 09:57, Vladimir Sementsov-Ogievskiy wrote: 14.06.2021 13:36, Emanuele Giuseppe Esposito wrote: On 04/06/2021 11:17, Emanuele Giuseppe Esposito wrote: Attaching gdbserver implies that the qmp socket should wait indefinitely

Re: [PATCH v3 0/2] hw/nvme: namespace parameter for EUI-64

2021-06-16 Thread Klaus Jensen
On Jun 14 22:18, Heinrich Schuchardt wrote: The EUI-64 field is the only identifier for NVMe namespaces in UEFI device paths. Add a new namespace property "eui64", that provides the user the option to specify the EUI-64. v3: use 52-54-00-00-00-00-00-00 as starting values for generating

Re: [RFC PATCH 4/5] ppc/pegasos2: Use Virtual Open Firmware as firmware replacement

2021-06-16 Thread BALATON Zoltan
On Wed, 16 Jun 2021, Alexey Kardashevskiy wrote: On 6/15/21 19:44, BALATON Zoltan wrote: On Tue, 15 Jun 2021, Alexey Kardashevskiy wrote: On 6/7/21 01:46, BALATON Zoltan wrote: The pegasos2 board comes with an Open Firmware compliant ROM based on SmartFirmware but it has some changes that are

  1   2   3   4   >