[Bug 1907497] Re: [OSS-Fuzz] Issue 28435 qemu:qemu-fuzz-i386-target-generic-fuzz-intel-hda: Stack-overflow in ldl_le_dma

2021-06-21 Thread Gianluca Gabruelli
I think this [0] commit actually fixes this bug, can someone please confirm it? [0] https://github.com/qemu/qemu/commit/1bf8b88f144bee747e386c88d45d772e066bbb36 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [PATCH v9] qapi: introduce 'query-kvm-cpuid' action

2021-06-21 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Jun 18, 2021 at 07:52:47AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > On Thu, Jun 17, 2021 at 05:53:11PM +0200, Claudio Fontana wrote: >> >> On 6/17/21 5:39 PM, Valeriy Vdovin wrote: >> >> > On Thu, Jun 17, 2021 at 04:14:17PM +0200,

Re: [PATCH 26/26] target/xtensa: Use translator_use_goto_tb

2021-06-21 Thread Max Filippov
On Sun, Jun 20, 2021 at 6:34 PM Richard Henderson wrote: > > Cc: Max Filippov > Signed-off-by: Richard Henderson > --- > target/xtensa/translate.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) Reviewed-by: Max Filippov -- Thanks. -- Max

Re: [PATCH 01/26] accel/tcg: Introduce translator_use_goto_tb

2021-06-21 Thread Max Filippov
On Sun, Jun 20, 2021 at 6:36 PM Richard Henderson wrote: > > Add a generic version of the common use_goto_tb test. > > Signed-off-by: Richard Henderson > --- > include/exec/translator.h | 10 ++ > accel/tcg/translator.c| 11 +++ > 2 files changed, 21 insertions(+)

Re: [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast

2021-06-21 Thread Hyman Huang
cc original author Daniel P. Berrangé :) may be this two fixes can be squashed into a single patch. 在 2021/6/16 14:26, Hyman Huang 写道: 在 2021/6/3 22:19, huang...@chinatelecom.cn 写道: From: Hyman Huang(黄勇) thread_id in CpuInfoFast is deprecated, parse thread-id instead after execute qmp

Re: [PATCH 09/15] hw/net/e1000e: Fix impl.min_access_size

2021-06-21 Thread Jason Wang
在 2021/6/20 上午1:26, Richard Henderson 写道: There are certainly architectural 2 byte writes, as evidenced by the e1000e_set_16bit function. I also saw a 1 byte write, though that may have been the fuzzer. Cc: Jason Wang Cc: Dmitry Fleytman Signed-off-by: Richard Henderson ---

Re: [PATCH v2] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option

2021-06-21 Thread Gerd Hoffmann
Hi, > " Your new option argument seems to count monitors from 1, while GTK counts > them from zero. Why the difference?" > sweeaun: It is due to gtk_window_fullscreen_on_monitor monitor index is > started from zero. I am not using zero as starting index of new option > argument to make

[PULL 04/37] s390x/tcg: Simplify vop64_3() handling

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand Let's simplify, reworking our handler generation, passing the whole "m5" register content and not providing specialized handlers for "se", and reading/writing proper float64 values using new helpers. Suggested-by: Richard Henderson Reviewed-by: Richard Henderson

[PULL 06/37] s390x/tcg: Simplify vfc64() handling

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand Pass the m5 field via simd_data() and don't provide specialized handlers for single-element variants. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-6-da...@redhat.com> Signed-off-by: Cornelia Huck ---

[PULL 16/37] s390x/tcg: Implement 32/128 bit for VECTOR FP COMPARE *

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand In addition to 32/128bit variants, we also have to support the "Signal-on-QNaN (SQ)" bit. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-16-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h

[PULL 25/37] linux-user: elf: s390x: Prepare for Vector enhancements facility

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand Let's check for S390_FEAT_VECTOR_ENH and set HWCAP_S390_VXRS_EXT accordingly. Add all missing HWCAP defined in upstream Linux. Cc: Laurent Vivier Acked-by: Laurent Vivier Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-25-da...@redhat.com>

[PULL 37/37] s390x/css: Add passthrough IRB

2021-06-21 Thread Cornelia Huck
From: Eric Farman Wire in the subchannel callback for building the IRB ESW and ECW space for passthrough devices, and copy the hardware's ESW into the IRB we are building. If the hardware presented concurrent sense, then copy that sense data into the IRB's ECW space. Signed-off-by: Eric Farman

[PULL 29/37] target/s390x: Expose load_psw and get_psw_mask to cpu.h

2021-06-21 Thread Cornelia Huck
From: Richard Henderson Rename to s390_cpu_set_psw and s390_cpu_get_psw_mask at the same time. Adjust so that they compile for user-only. Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée Reviewed-by: David Hildenbrand Tested-by: jonathan.albrecht Tested-by: Message-Id:

[PULL 33/37] linux-user/s390x: Save and restore psw.mask properly

2021-06-21 Thread Cornelia Huck
From: Richard Henderson At present, we're referencing env->psw.mask directly, which fails to ensure that env->cc_op is incorporated or updated. Use s390_cpu_{set_psw,get_psw_mask} to fix this. Mirror the kernel's cleaning of the psw.mask in save_sigregs and restore_sigregs. Ignore PSW_MASK_RI

Re: [PATCH v4 4/8] hw/intc: GICv3 ITS Command processing

2021-06-21 Thread Eric Auger
On 6/16/21 11:02 PM, shashi.mall...@linaro.org wrote: > Hi Eric, > > Please find my responses inline (below):- > > On Sun, 2021-06-13 at 17:55 +0200, Eric Auger wrote: >> Hi Shashi, >> >> On 6/2/21 8:00 PM, Shashi Mallela wrote: >>> Added ITS command queue handling for MAPTI,MAPI

Re: [PATCH 05/26] target/arm: Use translator_use_goto_tb

2021-06-21 Thread Peter Maydell
On Mon, 21 Jun 2021 at 02:42, Richard Henderson wrote: > > Put a wrapper in translate.h, which also checks for ss_active. > The ss_active test was incorrectly missing from the a32 version. True, but we almost never call gen_goto_tb() when ss_active (which makes sense because we generate code to

[PATCH v6 06/16] qemu-iotests: delay QMP socket timers

2021-06-21 Thread Emanuele Giuseppe Esposito
Attaching gdbserver implies that the qmp socket should wait indefinitely for an answer from QEMU. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[PATCH v6 12/16] qemu-iotests: allow valgrind to read/delete the generated log file

2021-06-21 Thread Emanuele Giuseppe Esposito
When using -valgrind on the script tests, it generates a log file in $TEST_DIR that is either read (if valgrind finds problems) or otherwise deleted. Provide the same exact behavior when using -valgrind on the python tests. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir

[PATCH v6 16/16] docs/devel/testing: add -p option to the debug section of QEMU iotests

2021-06-21 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 4 1 file changed, 4 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index fa85592a38..28a0b37b84 100644 --- a/docs/devel/testing.rst +++

[PATCH v6 03/16] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine

2021-06-21 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Reviewed-by: Max Reitz --- python/qemu/machine/qtest.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py

Re: [PATCH] block/rbd: Add support for rbd image encryption

2021-06-21 Thread Daniel P . Berrangé
On Mon, Jun 21, 2021 at 12:59:37PM +0200, Ilya Dryomov wrote: > On Mon, Jun 21, 2021 at 10:32 AM Daniel P. Berrangé > wrote: > > > > On Sat, Jun 19, 2021 at 09:44:32PM +0200, Ilya Dryomov wrote: > > > On Thu, Jun 17, 2021 at 6:05 PM Or Ozeri wrote: > > > > > > > > Starting from ceph Pacific,

[PULL 2/9] linux-user: Disable static assert involving __SIGRTMAX if it is missing

2021-06-21 Thread Laurent Vivier
From: Michael Forney This check is to ensure that the loop in signal_table_init() from SIGRTMIN to SIGRTMAX falls within the bounds of host_to_target_signal_table (_NSIG). However, it is not critical, since _NSIG is already defined to be the one larger than the largest signal supported by the

[PULL 0/9] Linux user for 6.1 patches

2021-06-21 Thread Laurent Vivier
-user-for-6.1-pull-request for you to fetch changes up to 96ff758c6e9cd5a01443ee15afbd0df4f00c37a8: linux-user: Use public sigev_notify_thread_id member if available (2021-06-20 16:41:47 +0200) Linux-user pull request 20210621

[PULL 6/9] tests/tcg/linux-test: Check that sigaction can query SIGKILL/SIGSTOP

2021-06-21 Thread Laurent Vivier
From: Ilya Leoshkevich Verify that querying is allowed, but making changes isn't. Signed-off-by: Ilya Leoshkevich Reviewed-by: Laurent Vivier Message-Id: <20210601145600.3131040-3-...@linux.ibm.com> Signed-off-by: Laurent Vivier --- tests/tcg/multiarch/linux-test.c | 9 + 1 file

[PATCH v17 5/6] KVM: arm64: ioctl to fetch/store tags in a guest

2021-06-21 Thread Steven Price
The VMM may not wish to have it's own mapping of guest memory mapped with PROT_MTE because this causes problems if the VMM has tag checking enabled (the guest controls the tags in physical RAM and it's unlikely the tags are correct for the VMM). Instead add a new ioctl which allows the VMM to

[PULL 6/7] fuzz: Display hexadecimal value with '0x' prefix

2021-06-21 Thread Thomas Huth
From: Philippe Mathieu-Daudé Use memory_region_size() to get the MemoryRegion size, and display it with the '0x' prefix. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Alexander Bulekov Reviewed-by: Laurent Vivier Reviewed-by: Thomas Huth Message-Id:

Re: [PATCH v3 0/2] target/s390x: Fix SIGILL psw.addr reporting

2021-06-21 Thread Ilya Leoshkevich
On Mon, 2021-06-21 at 09:12 -0400, jonathan.albrecht wrote: > On 2021-06-21 8:00 am, Ilya Leoshkevich wrote: > > On Thu, 2021-06-10 at 11:49 +0200, David Hildenbrand wrote: > > > On 02.06.21 02:22, Ilya Leoshkevich wrote: > > > > qemu-s390x puts a wrong value into SIGILL's siginfo_t's > > > >

Re: [PATCH 02/28] tcg/i386: Support bswap flags

2021-06-21 Thread Peter Maydell
On Mon, 14 Jun 2021 at 09:46, Richard Henderson wrote: > > Retain the current rorw bswap16 expansion for the zero-in/zero-out case. > Otherwise, perform a wider bswap plus a right-shift or extend. > > Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2] hw/pci-host/q35: Ignore write of reserved PCIEXBAR LENGTH field

2021-06-21 Thread Alexander Bulekov
On 210526 1624, Philippe Mathieu-Daudé wrote: > libFuzzer triggered the following assertion: > > cat << EOF | qemu-system-i386 -M pc-q35-5.0 \ > -nographic -monitor none -serial none \ > -qtest stdio -d guest_errors -trace pci\* > outl 0xcf8 0xf260 > outl 0xcfc 0x8400056e >

Re: [PATCH 04/28] tcg/arm: Support bswap flags

2021-06-21 Thread Peter Maydell
On Mon, 14 Jun 2021 at 09:49, Richard Henderson wrote: > > Combine the three bswap16 routines, and differentiate via the flags. > Use the correct flags combination from the load/store routines, and > pass along the constant parameter from tcg_out_op. > > Signed-off-by: Richard Henderson > --- >

Re: [PATCH 01/28] tcg: Add flags argument to bswap opcodes

2021-06-21 Thread Peter Maydell
On Mon, 21 Jun 2021 at 15:02, Richard Henderson wrote: > > On 6/21/21 6:51 AM, Peter Maydell wrote: > > On Mon, 21 Jun 2021 at 14:41, Peter Maydell > > wrote: > >> > >> On Mon, 14 Jun 2021 at 09:43, Richard Henderson > >> wrote: > >>> > >>> This will eventually simplify front-end usage, and

[PATCH 1/2] linux-user/s390x: signal with SIGFPE on compare-and-trap

2021-06-21 Thread Jonathan Albrecht
Currently when a compare-and-trap instruction is executed, qemu will always raise a SIGILL signal. On real hardware, a SIGFPE is raised. Change the PGM_DATA case in cpu_loop to follow the behavior in linux kernel /arch/s390/kernel/traps.c. * Only raise SIGILL if DXC == 0 * If DXC matches an

Re: [PATCH 24/26] target/tricore: Use translator_use_goto_tb

2021-06-21 Thread Bastian Koppelmann
On Sun, Jun 20, 2021 at 06:34:37PM -0700, Richard Henderson wrote: > Just use translator_use_goto_tb directly at the one call site, > rather than maintaining a local wrapper. > > Cc: Bastian Koppelmann > Signed-off-by: Richard Henderson > --- > target/tricore/translate.c | 17 ++---

Re: [PATCH] block/rbd: Add support for rbd image encryption

2021-06-21 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210621142103.1417408-1-...@il.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210621142103.1417408-1-...@il.ibm.com Subject: [PATCH] block/rbd: Add support for rbd

Re: [PULL 0/7] x86 queue, 2021-06-18

2021-06-21 Thread Peter Maydell
On Fri, 18 Jun 2021 at 20:52, Eduardo Habkost wrote: > > There's still a lot to review/queue on the list, but I'm flush my > current queue so it doesn't get stale. > > The following changes since commit 18e53dff939898c6dd00d206a3c2f5cd3d6669db: > > Merge remote-tracking branch

[PULL 21/37] s390x/tcg: Implement 32/128 bit for VECTOR FP TEST DATA CLASS IMMEDIATE

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-21-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 2 ++ target/s390x/translate_vx.c.inc | 23 ++--

[PULL 09/37] s390x/tcg: Simplify vfll32() handling

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-9-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 1 - target/s390x/translate_vx.c.inc | 6 +- target/s390x/vec_fpu_helper.c

[PULL 27/37] s390x/cpumodel: Bump up QEMU model to a stripped-down IBM z14 GA2

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand TCG implements everything we need to run basic z14 OS+software. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-27-da...@redhat.com> Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 3 +++

[PULL 35/37] s390x/css: Split out the IRB sense data

2021-06-21 Thread Cornelia Huck
From: Eric Farman Let's move this logic into its own routine, so it can be reused later. Signed-off-by: Eric Farman Reviewed-by: Thomas Huth Message-Id: <20210617232537.1337506-3-far...@linux.ibm.com> Signed-off-by: Cornelia Huck --- hw/s390x/css.c | 19 --- 1 file changed,

Re: [PATCH v2] hw/virtio: Document *_should_notify() are called within rcu_read_lock()

2021-06-21 Thread Philippe Mathieu-Daudé
ping? On 5/23/21 11:40 AM, Philippe Mathieu-Daudé wrote: > Such comments make reviewing this file somehow easier. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: only one space before end of comment (mst) > --- > hw/virtio/virtio.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff

[PULL 34/37] s390x/css: Introduce an ESW struct

2021-06-21 Thread Cornelia Huck
From: Eric Farman The Interrupt Response Block is comprised of several other structures concatenated together, but only the 12-byte Subchannel-Status Word (SCSW) is defined as a proper struct. Everything else is a simple array of 32-bit words. Let's define a proper struct for the 20-byte

[PATCH v6 10/16] qemu-iotests: extend the check script to prepare supporting valgrind for python tests

2021-06-21 Thread Emanuele Giuseppe Esposito
Currently, the check script only parses the option and sets the VALGRIND_QEMU environmental variable to "y". Add another local python variable that prepares the command line, identical to the one provided in the test scripts. Because the python script does not know in advance the valgrind PID to

[PATCH v6 04/16] docs/devel/testing: add debug section to the QEMU iotests chapter

2021-06-21 Thread Emanuele Giuseppe Esposito
Introduce the "Debugging a test case" section, in preparation to the additional flags that will be added in the next patches. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v6 15/16] qemu-iotests: add option to show qemu binary logs on stdout

2021-06-21 Thread Emanuele Giuseppe Esposito
Using the flag -p, allow the qemu binary to print to stdout. Also create the common function _close_qemu_log_file() to avoid accessing machine.py private fields directly and have duplicate code. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy ---

[PULL 3/9] linux-user/trace-events: fix minor typo in format string

2021-06-21 Thread Laurent Vivier
From: Alex Bennée Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Message-Id: <20210614144245.17660-1-alex.ben...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/trace-events | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PULL 8/9] linux-user: Fix incorrect use of feature-test-macros

2021-06-21 Thread Laurent Vivier
From: Michael Forney The _POSIX_C_SOURCE and _XOPEN_SOURCE macros are used by the application to indicate to libc which declarations it should expose. Since qemu does not define them anywhere, it does not make sense to check their value. Instead, since the intent is to determine whether the

[PULL 3/7] docs/tools/virtiofsd: Fix bad rst syntax

2021-06-21 Thread Thomas Huth
For literal blocks, there has to be an empty line after the two colons, and the block itself should be indented. Signed-off-by: Thomas Huth Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Stefan Hajnoczi Message-Id: <20210607180015.924571-1-th...@redhat.com> Signed-off-by: Thomas Huth ---

Re: [PATCH 01/26] accel/tcg: Introduce translator_use_goto_tb

2021-06-21 Thread Philippe Mathieu-Daudé
Hi Richard, On 6/21/21 3:34 AM, Richard Henderson wrote: > Add a generic version of the common use_goto_tb test. > > Signed-off-by: Richard Henderson > --- > include/exec/translator.h | 10 ++ > accel/tcg/translator.c| 11 +++ > 2 files changed, 21 insertions(+) > > diff

Re: [PATCH v3 02/24] modules: collect module meta-data

2021-06-21 Thread Gerd Hoffmann
On Fri, Jun 18, 2021 at 06:09:55PM +0200, Paolo Bonzini wrote: > On 18/06/21 06:53, Gerd Hoffmann wrote: > > +def find_command(src, target, compile_commands): > > +for command in compile_commands: > > +if command['file'] != src: > > +continue > > +if target != ''

[PATCH v2 05/10] target/ppc: Split out ppc_hash64_xlate

2021-06-21 Thread Bruno Larsen (billionai)
From: Richard Henderson Mirror the interface of ppc_radix64_xlate, putting all of the logic for hash64 translation into a single function. Signed-off-by: Richard Henderson --- target/ppc/mmu-hash64.c | 125 +++- 1 file changed, 59 insertions(+), 66

Re: [PATCH 01/28] tcg: Add flags argument to bswap opcodes

2021-06-21 Thread Richard Henderson
On 6/21/21 6:41 AM, Peter Maydell wrote: On Mon, 14 Jun 2021 at 09:43, Richard Henderson wrote: This will eventually simplify front-end usage, and will allow backends to unset TCG_TARGET_HAS_MEMORY_BSWAP without loss of optimization. The argument is added during expansion, not currently

Re: [PATCH 06/28] tcg/ppc: Split out tcg_out_sari{32,64}

2021-06-21 Thread Peter Maydell
On Mon, 14 Jun 2021 at 09:43, Richard Henderson wrote: > > We will shortly require sari in other context; > split out both for cleanliness sake. > > Signed-off-by: Richard Henderson > --- > tcg/ppc/tcg-target.c.inc | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) >

Re: [PATCH 17/28] tcg: Add flags argument to tcg_gen_bswap16_*, tcg_gen_bswap32_i64

2021-06-21 Thread Peter Maydell
On Mon, 14 Jun 2021 at 09:52, Richard Henderson wrote: > > Implement the new semantics in the fallback expansion. > Change all callers to supply the flags that keep the > semantics unchanged locally. > > Signed-off-by: Richard Henderson > diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c > index

Re: [PATCH 23/28] target/i386: Improve bswap translation

2021-06-21 Thread Peter Maydell
On Mon, 14 Jun 2021 at 09:48, Richard Henderson wrote: > > Use a break instead of an ifdefed else. > There's no need to move the values through s->T0. > Remove TCG_BSWAP_IZ and the preceding zero-extension. > > Cc: Paolo Bonzini > Cc: Eduardo Habkost > Signed-off-by: Richard Henderson

[PULL 12/37] s390x/tcg: Implement VECTOR BIT PERMUTE

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-12-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/translate_vx.c.inc |

[PULL 14/37] s390x/tcg: Implement 32/128 bit for VECTOR FP (ADD|DIVIDE|MULTIPLY|SUBTRACT)

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand In case of 128bit, we always have a single element. Add new helpers for reading/writing 32/128 bit floats. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-14-da...@redhat.com> Signed-off-by: Cornelia Huck ---

[PATCH v6 02/16] python: Reduce strictness of pylint's duplicate-code check

2021-06-21 Thread Emanuele Giuseppe Esposito
From: John Snow Pylint prior to 2.8.3 (We pin at >= 2.8.0) includes function and method signatures as part of its duplicate checking algorithm. This check does not listen to pragmas, so the only way to disable it is to turn it off completely or increase the minimum duplicate lines so that it

[PATCH v6 01/16] python: qemu: add timer parameter for qmp.accept socket

2021-06-21 Thread Emanuele Giuseppe Esposito
Also add a new _qmp_timer field to the QEMUMachine class. Let's change the default socket timeout to None, so that if a subclass needs to add a timer, it can be done by modifying this private field. At the same time, restore the timer to be 15 seconds in iotests.py, to give an upper bound to the

[PATCH v6 08/16] qemu-iotests: add gdbserver option to script tests too

2021-06-21 Thread Emanuele Giuseppe Esposito
The only limitation here is that running a script with gdbserver will make the test output mismatch with the expected results, making the test fail. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/common.rc | 8 +++- 1 file

[PATCH v6 05/16] qemu-iotests: add option to attach gdbserver

2021-06-21 Thread Emanuele Giuseppe Esposito
Define -gdb flag and GDB_OPTIONS environment variable to python tests to attach a gdbserver to each qemu instance. This patch only adds and parses this flag, it does not yet add the implementation for it. if -gdb is not provided but $GDB_OPTIONS is set, ignore the environment variable.

[PATCH v6 14/16] docs/devel/testing: add -valgrind option to the debug section of QEMU iotests

2021-06-21 Thread Emanuele Giuseppe Esposito
Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 8b24e6fb47..fa85592a38 100644 ---

Re: [PATCH v2] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option

2021-06-21 Thread Gerd Hoffmann
> > I don't think qemu has to worry much here, and trying to automatically > > adapt to hot-plugged monitors might even have bad interactions with > > whatever the display server is going to do. > > I'm concerned there is a TOCTTOU issue: > > if (opts->u.gtk.has_monitor) { > int

[PULL 4/7] Update documentation to refer to new location for issues

2021-06-21 Thread Thomas Huth
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Alex Bennée Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20210619154253.553446-1...@weilnetz.de> Signed-off-by: Thomas Huth --- .github/lockdown.yml | 6 +++--- README.rst | 6 +++--- 2 files

[PULL 5/7] Remove leading underscores from QEMU defines

2021-06-21 Thread Thomas Huth
From: Ahmed Abouzied Leading underscores followed by a capital letter or underscore are reserved by the C standard. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/369 Signed-off-by: Ahmed Abouzied Message-Id: <20210605174938.13782-1-em...@aabouzied.com> Signed-off-by: Thomas Huth

[PULL 7/7] MAINTAINERS: Add qtest/arm-cpu-features.c to ARM TCG CPUs section

2021-06-21 Thread Thomas Huth
From: Philippe Mathieu-Daudé We want the ARM maintainers and the qemu-arm@ list to be notified when this file is modified. Add an entry to the 'ARM TCG CPUs' section in the MAINTAINERS file. Acked-by: Andrew Jones Reviewed-by: Thomas Huth Reviewed-by: Alex Bennée Signed-off-by: Philippe

Re: [PATCH v2] block/nvme: Fix VFIO_MAP_DMA failed: No space left on device

2021-06-21 Thread Fam Zheng
> On 21 Jun 2021, at 10:32, Philippe Mathieu-Daudé wrote: > > When the NVMe block driver was introduced (see commit bdd6a90a9e5, > January 2018), Linux VFIO_IOMMU_MAP_DMA ioctl was only returning > -ENOMEM in case of error. The driver was correctly handling the > error path to recycle its

Re: [PATCH v2 1/1] accel/tcg: Probe the proper permissions for atomic ops

2021-06-21 Thread Matheus K. Ferst
On 16/06/2021 22:12, Richard Henderson wrote: We had a single ATOMIC_MMU_LOOKUP macro that probed for read+write on all atomic ops. This is incorrect for plain atomic load and atomic store. For user-only, we rely on the host page permissions. Resolves:

[PATCH 0/2] linux-user/s390x: signal with SIGFPE on compare-and-trap

2021-06-21 Thread Jonathan Albrecht
qemu-s390x signals with SIGILL on compare-and-trap instructions. This breaks OpenJDK which expects SIGFPE in its implementation of implicit exceptions. This patch depends on [PATCH v3 0/2] target/s390x: Fix SIGILL psw.addr reporting.

[PATCH 2/2] tests/tcg: Test that compare-and-trap raises SIGFPE

2021-06-21 Thread Jonathan Albrecht
Signed-off-by: Jonathan Albrecht --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/trap.c | 100 2 files changed, 101 insertions(+) create mode 100644 tests/tcg/s390x/trap.c diff --git a/tests/tcg/s390x/Makefile.target

[PATCH] block/rbd: Add support for rbd image encryption

2021-06-21 Thread Or Ozeri
Starting from ceph Pacific, RBD has built-in support for image-level encryption. Currently supported formats are LUKS version 1 and 2. There are 2 new relevant librbd APIs for controlling encryption, both expect an open image context: rbd_encryption_format: formats an image (i.e. writes the LUKS

Re: [PATCH 06/28] tcg/ppc: Split out tcg_out_sari{32,64}

2021-06-21 Thread Richard Henderson
On 6/21/21 7:22 AM, Peter Maydell wrote: On Mon, 14 Jun 2021 at 09:43, Richard Henderson wrote: We will shortly require sari in other context; split out both for cleanliness sake. Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c.inc | 15 --- 1 file changed, 12

Re: [PATCH 16/28] tcg: Handle new bswap flags during optimize

2021-06-21 Thread Peter Maydell
On Mon, 14 Jun 2021 at 09:45, Richard Henderson wrote: > > Notice when the input is known to be zero-extended and force > the TCG_BSWAP_IZ flag on. Honor the TCG_BSWAP_OS bit during > constant folding. Propagate the input to the output mask. > > Signed-off-by: Richard Henderson > --- >

Re: [PATCH 18/28] tcg: Make use of bswap flags in tcg_gen_qemu_ld_*

2021-06-21 Thread Peter Maydell
On Mon, 14 Jun 2021 at 10:02, Richard Henderson wrote: > > We can perform any required sign-extension via TCG_BSWAP_OS. > > Signed-off-by: Richard Henderson > --- Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH 01/26] accel/tcg: Introduce translator_use_goto_tb

2021-06-21 Thread Philippe Mathieu-Daudé
On 6/21/21 3:47 PM, Richard Henderson wrote: > On 6/21/21 5:50 AM, Philippe Mathieu-Daudé wrote: >> I notice various targets do: >> >> #ifdef CONFIG_USER_ONLY >>     return true; >> #else >> >>> +    /* Check for the dest on the same page as the start of the TB.  */ >>> +    return

[PULL 13/37] s390x/tcg: Implement VECTOR MULTIPLY SUM LOGICAL

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand Fortunately, we only need the Doubleword implementation. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-13-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 2 ++

[PULL 03/37] s390x/tcg: Fix instruction name for VECTOR FP LOAD (LENGTHENED|ROUNDED)

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand Let's use the correct name. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-3-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/insn-data.def | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PULL 02/37] s390x/tcg: Fix FP CONVERT TO (LOGICAL) FIXED NaN handling

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand In case we encounter a NaN, we have to return the smallest possible number, corresponding to either 0 or the maximum negative number. This seems to differ from IEEE handling as implemented in softfloat, whereby we return the biggest possible number. While at it, use

[PULL 08/37] s390x/tcg: Simplify vfma64() handling

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-8-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 2 -- target/s390x/translate_vx.c.inc | 8 +++ target/s390x/vec_fpu_helper.c

[PULL 30/37] target/s390x: Do not modify cpu state in s390_cpu_get_psw_mask

2021-06-21 Thread Cornelia Huck
From: Richard Henderson We want to use this function for debugging, and debug should not modify cpu state (even non-architectural cpu state) lest we introduce heisenbugs. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Tested-by: jonathan.albrecht Tested-by: Message-Id:

Re: [PULL v2 00/34] NBD patches through 2021-06-15

2021-06-21 Thread Peter Maydell
On Fri, 18 Jun 2021 at 18:34, Eric Blake wrote: > > The following changes since commit 3ccf6cd0e3e1dfd663814640b3b18b55715d7a75: > > Merge remote-tracking branch > 'remotes/kraxel/tags/audio-20210617-pull-request' into staging (2021-06-18 > 09:54:42 +0100) > > are available in the Git

Re: [PATCH] memory: Display MemoryRegion name in read/write ops trace events

2021-06-21 Thread Philippe Mathieu-Daudé
Hi Laurent, On 6/7/21 1:29 PM, Laurent Vivier wrote: > Le 07/06/2021 à 10:28, Philippe Mathieu-Daudé a écrit : >> On 6/7/21 9:33 AM, Laurent Vivier wrote: >>> Le 02/06/2021 à 12:49, Philippe Mathieu-Daudé a écrit : Cc'ing qemu-trivial@ On 3/18/21 4:39 PM, Philippe Mathieu-Daudé

[PATCH v6 11/16] qemu-iotests: extend QMP socket timeout when using valgrind

2021-06-21 Thread Emanuele Giuseppe Esposito
As with gdbserver, valgrind delays the test execution, so the default QMP socket timeout and the generic class Timeout in iotests.py timeouts too soon. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 6 +++--- 1 file

Re: [PATCH v2] ui/gtk: Allow user to select monitor number to display qemu in full screen through new gtk display option

2021-06-21 Thread Gerd Hoffmann
Hi, > Well, wouldn't it make sense to have monitor= work for both > full-screen=on and full-screen=off cases? > sweeaun: Yes. That will be better option for user. However, I not managed to > find other GTK window API that can set window into monitor rather than >

[PATCH v17 4/6] KVM: arm64: Expose KVM_ARM_CAP_MTE

2021-06-21 Thread Steven Price
It's now safe for the VMM to enable MTE in a guest, so expose the capability to user space. Reviewed-by: Catalin Marinas Signed-off-by: Steven Price --- arch/arm64/kvm/arm.c | 9 + arch/arm64/kvm/reset.c| 4 arch/arm64/kvm/sys_regs.c | 3 +++ 3 files changed, 16

Re: [PATCH 07/26] target/avr: Mark some helpers noreturn

2021-06-21 Thread Philippe Mathieu-Daudé
On 6/21/21 3:34 AM, Richard Henderson wrote: > All of these helpers end with cpu_loop_exit. > > Cc: Michael Rolnik > Signed-off-by: Richard Henderson > --- > target/avr/helper.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH v2 02/10] target/ppc: Use MMUAccessType with *_handle_mmu_fault

2021-06-21 Thread Bruno Larsen (billionai)
From: Richard Henderson These changes were waiting until we didn't need to match the function type of PowerPCCPUClass.handle_mmu_fault. Signed-off-by: Richard Henderson --- target/ppc/mmu-hash32.c | 7 ++- target/ppc/mmu-hash32.h | 4 ++-- target/ppc/mmu-hash64.c | 6 +-

[PATCH v2 08/10] target/ppc: Introduce ppc_xlate

2021-06-21 Thread Bruno Larsen (billionai)
From: Richard Henderson Create one common dispatch for all of the ppc_*_xlate functions. Use ppc64_v3_radix to directly dispatch between ppc_radix64_xlate and ppc_hash64_xlate. Remove the separate *_handle_mmu_fault and *_get_phys_page_debug functions, using common code for ppc_cpu_tlb_fill and

[PATCH v2 10/10] target/ppc: fix address translation bug for radix mmus

2021-06-21 Thread Bruno Larsen (billionai)
This commit attempts to fix the first bug mentioned by Richard Henderson in https://lists.nongnu.org/archive/html/qemu-devel/2021-05/msg06247.html To sumarize the bug here, when radix-style mmus are translating an address, they might need to call a second level of translation, with hypervisor

Re: [PATCH 01/28] tcg: Add flags argument to bswap opcodes

2021-06-21 Thread Peter Maydell
On Mon, 21 Jun 2021 at 14:41, Peter Maydell wrote: > > On Mon, 14 Jun 2021 at 09:43, Richard Henderson > wrote: > > > > This will eventually simplify front-end usage, and will allow > > backends to unset TCG_TARGET_HAS_MEMORY_BSWAP without loss of > > optimization. > > > > The argument is added

Re: [PATCH 01/28] tcg: Add flags argument to bswap opcodes

2021-06-21 Thread Richard Henderson
On 6/21/21 6:51 AM, Peter Maydell wrote: On Mon, 21 Jun 2021 at 14:41, Peter Maydell wrote: On Mon, 14 Jun 2021 at 09:43, Richard Henderson wrote: This will eventually simplify front-end usage, and will allow backends to unset TCG_TARGET_HAS_MEMORY_BSWAP without loss of optimization. The

Re: [PATCH 03/28] tcg/aarch64: Support bswap flags

2021-06-21 Thread Peter Maydell
On Mon, 14 Jun 2021 at 09:41, Richard Henderson wrote: > > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.c.inc | 12 > 1 file changed, 12 insertions(+) > > diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc > index 27cde314a9..f72218b036

Re: [PATCH v9] qapi: introduce 'query-kvm-cpuid' action

2021-06-21 Thread Eduardo Habkost
On Mon, Jun 21, 2021 at 10:07:44AM +0200, Claudio Fontana wrote: > On 6/18/21 10:40 PM, Eduardo Habkost wrote: > > On Fri, Jun 18, 2021 at 07:52:47AM +0200, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >>> On Thu, Jun 17, 2021 at 05:53:11PM +0200, Claudio Fontana wrote: > On

Re: [PATCH 25/26] target/tricore: Use tcg_gen_lookup_and_goto_ptr

2021-06-21 Thread Bastian Koppelmann
On Sun, Jun 20, 2021 at 06:34:38PM -0700, Richard Henderson wrote: > The non-single-step case of gen_goto_tb may use > tcg_gen_lookup_and_goto_ptr to indirectly chain. > > Cc: Bastian Koppelmann > Signed-off-by: Richard Henderson > --- > target/tricore/translate.c | 3 ++- > 1 file changed, 2

[PATCH] block/rbd: Add support for rbd image encryption

2021-06-21 Thread Or Ozeri
Starting from ceph Pacific, RBD has built-in support for image-level encryption. Currently supported formats are LUKS version 1 and 2. There are 2 new relevant librbd APIs for controlling encryption, both expect an open image context: rbd_encryption_format: formats an image (i.e. writes the LUKS

Re: [PATCH 22/28] target/arm: Improve REVSH

2021-06-21 Thread Peter Maydell
On Mon, 14 Jun 2021 at 09:38, Richard Henderson wrote: > > The new bswap flags can implement the semantics exactly. > > Cc: Peter Maydell > Signed-off-by: Richard Henderson > --- > target/arm/translate.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Reviewed-by: Peter Maydell

[PULL 05/37] s390x/tcg: Simplify vop64_2() handling

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand Let's rework our macros and simplify. We still need helper functions in most cases due to the different parameters types. Next, we'll only have 32/128bit variants for vfi and vfsq, so special case the others. Note that for vfsq, the XxC and erm passed in the simd_data()

[PULL 07/37] s390x/tcg: Simplify vftci64() handling

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-7-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 1 - target/s390x/translate_vx.c.inc | 7 ++- target/s390x/vec_fpu_helper.c

[PULL 19/37] s390x/tcg: Implement 128 bit for VECTOR FP LOAD ROUNDED

2021-06-21 Thread Cornelia Huck
From: David Hildenbrand 128 bit -> 64 bit, there is only a single element to process. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20210608092337.12221-19-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/helper.h | 1 +

Re: [PATCH v2] hw/pci-host/q35: Ignore write of reserved PCIEXBAR LENGTH field

2021-06-21 Thread Philippe Mathieu-Daudé
ping? On 6/14/21 1:14 PM, Philippe Mathieu-Daudé wrote: > ping? > > On 5/26/21 4:24 PM, Philippe Mathieu-Daudé wrote: >> libFuzzer triggered the following assertion: >> >> cat << EOF | qemu-system-i386 -M pc-q35-5.0 \ >> -nographic -monitor none -serial none \ >> -qtest stdio -d

[PATCH v6 13/16] qemu-iotests: insert valgrind command line as wrapper for qemu binary

2021-06-21 Thread Emanuele Giuseppe Esposito
If -gdb and -valgrind are both defined, return an error. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py

  1   2   3   4   5   >