Re: [PATCH 2/6] tests/acceptance: add replay kernel test for ppc64

2021-06-22 Thread Willian Rampazzo
On Thu, Jun 10, 2021 at 8:25 AM Pavel Dovgalyuk wrote: > > This patch adds record/replay test which boots Linux > kernel on ppc64 platform. The test uses kernel binaries > taken from boot_linux_console test. > > Signed-off-by: Pavel Dovgalyuk > --- > tests/acceptance/boot_linux_console.py |

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Daniel P . Berrangé
On Tue, Jun 22, 2021 at 05:40:13PM +0200, Igor Mammedov wrote: > On Tue, 22 Jun 2021 16:29:15 +0200 > Andrew Jones wrote: > > > On Tue, Jun 22, 2021 at 03:10:57PM +0100, Daniel P. Berrangé wrote: > > > On Tue, Jun 22, 2021 at 10:04:52PM +0800, wangyanan (Y) wrote: > > > > Hi Daniel, > > > > >

RE: Denormal input handling

2021-06-22 Thread Michael Morrell
OK, I've done more testing. I'm not sure if we need any specialization, but the setting for float_flag_inorm_denormal isn't right for x86. It is set unconditionally when flush_inputs_to_zero is false, but it needs to take into account the other operand(s). Given "denorm / 0" or any

Re: [PATCH 1/6] tests/acceptance: add replay kernel test for s390

2021-06-22 Thread Willian Rampazzo
On Thu, Jun 10, 2021 at 8:24 AM Pavel Dovgalyuk wrote: > > This patch adds record/replay test which boots Linux > kernel on s390x platform. The test uses kernel binaries > taken from boot_linux_console test. > > Signed-off-by: Pavel Dovgalyuk > --- > tests/acceptance/replay_kernel.py | 16

[PATCH 0/1] Add features and cpu models

2021-06-22 Thread Christian Borntraeger
5 new features and 2 new models Christian Borntraeger (1): s390x/cpumodel: add 3931 and 3932 target/s390x/cpu_features_def.h.inc | 5 + target/s390x/cpu_models.c | 6 ++ target/s390x/gen-features.c | 14 ++ 3 files changed, 25 insertions(+) -- 2.31.1

[PATCH 1/1] s390x/cpumodel: add 3931 and 3932

2021-06-22 Thread Christian Borntraeger
This defines 5 new facilities and the new 3931 and 3932 machines. As before the name is not yet known and we do use gen16a and gen16b. The new features are part of the full model. The default model is still empty (same as z15) and will be added in a separate patch at a later point in time. Also

Re: [PATCH v3 7/7] tests/acceptance: Handle cpu tag on x86_cpu_model_versions tests

2021-06-22 Thread Willian Rampazzo
On Fri, Apr 30, 2021 at 10:35 AM Wainer dos Santos Moschetta wrote: > > Some test cases on x86_cpu_model_versions.py are corner cases because they > need to pass extra options to the -cpu argument. Once the avocado_qemu > framework will set -cpu automatically, the value should be reset. This

Re: [PATCH 4/6] tests/acceptance: add replay kernel test for nios2

2021-06-22 Thread Willian Rampazzo
On Thu, Jun 10, 2021 at 8:25 AM Pavel Dovgalyuk wrote: > > This patch adds record/replay test which boots Linux > kernel on nios2 platform. The test uses kernel binaries > taken from boot_linux_console test. > > Signed-off-by: Pavel Dovgalyuk > --- > tests/acceptance/replay_kernel.py | 11

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Andrew Jones
On Tue, Jun 22, 2021 at 06:14:25PM +0100, Daniel P. Berrangé wrote: > On Tue, Jun 22, 2021 at 05:40:13PM +0200, Igor Mammedov wrote: > > On Tue, 22 Jun 2021 16:29:15 +0200 > > Andrew Jones wrote: > > > > > On Tue, Jun 22, 2021 at 03:10:57PM +0100, Daniel P. Berrangé wrote: > > > > On Tue, Jun

Re: [PATCH v1 1/1] migration: Unregister yank if migration setup fails

2021-06-22 Thread Peter Xu
On Mon, Jun 21, 2021 at 11:42:36PM -0300, Leonardo Bras wrote: > Currently, if a qemu instance is started with "-incoming defer" and > an incorect parameter is passed to "migrate_incoming", it will print the > expected error and reply with "duplicate yank instance" for any upcoming >

Re: RFC: Implementation of QMP documentation retrieval command

2021-06-22 Thread Niteesh G. S.
Hi Stefan, On Tue, Jun 22, 2021 at 3:05 PM Stefan Hajnoczi wrote: > On Mon, Jun 21, 2021 at 11:56:30PM +0530, Niteesh G. S. wrote: > > TLDR: The goal of this mail wasn't to review the dummy command I had > posted > > but > > rather start a discussion regarding the implementation of the QMP > >

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Andrew Jones
On Tue, Jun 22, 2021 at 05:40:13PM +0200, Igor Mammedov wrote: > On Tue, 22 Jun 2021 16:29:15 +0200 > Andrew Jones wrote: > > > On Tue, Jun 22, 2021 at 03:10:57PM +0100, Daniel P. Berrangé wrote: > > > On Tue, Jun 22, 2021 at 10:04:52PM +0800, wangyanan (Y) wrote: > > > > Hi Daniel, > > > > >

Re: [PATCH v3 03/24] modules: generate modinfo.c

2021-06-22 Thread Jose R. Ziviani
Hello, Just a small change. On Fri, Jun 18, 2021 at 06:53:32AM +0200, Gerd Hoffmann wrote: > Add script to generate C source with a small > database containing the module meta-data. > > Signed-off-by: Gerd Hoffmann > --- > scripts/modinfo-generate.py | 84 +

Re: [PATCH 3/6] tests/acceptance: add replay kernel test for openrisc

2021-06-22 Thread Willian Rampazzo
On Thu, Jun 10, 2021 at 8:25 AM Pavel Dovgalyuk wrote: > > This patch adds record/replay test which boots Linux > kernel on openrisc platform. The test uses kernel binaries > taken from boot_linux_console test. > > Signed-off-by: Pavel Dovgalyuk > --- > tests/acceptance/replay_kernel.py | 11

[PATCH v2] coreaudio: Lock only the buffer

2021-06-22 Thread Akihiko Odaki
On macOS 11.3.1, Core Audio calls AudioDeviceIOProc after calling an internal function named HALB_Mutex::Lock(), which locks a mutex in HALB_IOThread::Entry(void*). HALB_Mutex::Lock() is also called in AudioObjectGetPropertyData, which is called by coreaudio driver. Therefore, a deadlock will

[Bug 1776920] Re: qemu-img convert on Mac OSX creates corrupt images

2021-06-22 Thread Juan Niño
Hey there! I tested @wkozaczuk's suggested minimal steps and THEY WORKED FOR ME!! The steps executed on my mac: 1. dd if=boot.bin of=image.img > /dev/null 2>&1 2. dd if=lzloader.elf of=image.img conv=notrunc seek=128 > /dev/null 2>&1 3. qemu-img convert image.img -O qcow2 image.qemu 4. qemu-img

Re: [PATCH 3/4] modules: module.h kerneldoc annotations

2021-06-22 Thread Jose R. Ziviani
Hello Gerd, On Tue, Jun 22, 2021 at 02:51:09PM +0200, Gerd Hoffmann wrote: > --- > include/qemu/module.h | 59 +-- > 1 file changed, 45 insertions(+), 14 deletions(-) This header has a copyright date from 2009. Not sure if it requires an update. > >

Re: [RFC PATCH v4 0/7] hw/arm/virt: Introduce cpu topology support

2021-06-22 Thread Daniel P . Berrangé
On Tue, Jun 22, 2021 at 07:29:34PM +0200, Andrew Jones wrote: > On Tue, Jun 22, 2021 at 06:14:25PM +0100, Daniel P. Berrangé wrote: > > On Tue, Jun 22, 2021 at 05:40:13PM +0200, Igor Mammedov wrote: > > > On Tue, 22 Jun 2021 16:29:15 +0200 > > > Andrew Jones wrote: > > > > > > > On Tue, Jun 22,

Re: [PATCH 2/2] target/ppc: Drop PowerPCCPUClass::interrupts_big_endian()

2021-06-22 Thread Fabiano Rosas
Greg Kurz writes: > This isn't used anymore. > > Signed-off-by: Greg Kurz Reviewed-by: Fabiano Rosas > --- > target/ppc/cpu-qom.h | 1 - > target/ppc/cpu_init.c | 17 - > 2 files changed, 18 deletions(-) > > diff --git a/target/ppc/cpu-qom.h b/target/ppc/cpu-qom.h > index

Re: [PATCH v3 6/7] tests/acceptance: Add set_vm_arg() to the Test class

2021-06-22 Thread Willian Rampazzo
On Fri, Apr 30, 2021 at 10:35 AM Wainer dos Santos Moschetta wrote: > > The set_vm_arg method is added to avocado_qemu.Test class on this > change. Use that method to set (or replace) an argument to the list of > arguments given to the QEMU binary. > > Suggested-by: Cleber Rosa > Signed-off-by:

Re: [PATCH] tcg: Avoid including 'trace-tcg.h' in target translate.c

2021-06-22 Thread Richard Henderson
On 6/22/21 9:15 AM, Philippe Mathieu-Daudé wrote: The root trace-events only declares a single TCG event: $ git grep -w tcg trace-events trace-events:115:# tcg/tcg-op.c trace-events:137:vcpu tcg guest_mem_before(TCGv vaddr, uint16_t info) "info=%d", "vaddr=0x%016"PRIx64" info=%d" and

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-22 Thread Vladimir Sementsov-Ogievskiy
22.06.2021 18:38, Kevin Wolf wrote: Am 11.06.2021 um 21:03 hat Eric Blake geschrieben: To save the user from having to check 'qemu-img info --backing-chain' or other followup command to determine which "depth":n goes beyond the chain, add a boolean field "backing" that is set only for

Re: [PATCH 1/2] target/ppc: Introduce ppc_interrupts_little_endian()

2021-06-22 Thread Fabiano Rosas
Greg Kurz writes: > PowerPC CPUs use big endian by default but starting with POWER7, > server grade CPUs use the ILE bit of the LPCR special purpose > register to decide on the endianness to use when handling > interrupts. This gives a clue to QEMU on the endianness the > guest kernel is

Re: [PATCH 3/4] export/fuse: Let permissions be adjustable

2021-06-22 Thread Kevin Wolf
Am 22.06.2021 um 17:22 hat Max Reitz geschrieben: > On 22.06.21 17:02, Kevin Wolf wrote: > > Am 14.06.2021 um 16:44 hat Max Reitz geschrieben: > > > Allow changing the file mode, UID, and GID through SETATTR. > > > > > > This only really makes sense with allow-other, though (because without > > >

Re: [PATCH v3 3/3] avocado_qemu: Add Intel iommu tests

2021-06-22 Thread Peter Xu
Hi, Eric, On Mon, Jun 21, 2021 at 10:08:24AM +0200, Eric Auger wrote: > Add Intel IOMMU functional tests based on fedora 31. > Different configs are checked: > - strict > - caching mode, strict > - passthrough. > > Signed-off-by: Eric Auger Acked-by: Peter Xu Thanks for adding this test! --

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-22 Thread Nir Soffer
On Tue, Jun 22, 2021 at 6:38 PM Kevin Wolf wrote: > > Am 11.06.2021 um 21:03 hat Eric Blake geschrieben: > > To save the user from having to check 'qemu-img info --backing-chain' > > or other followup command to determine which "depth":n goes beyond the > > chain, add a boolean field "backing"

Re: [PATCH v2 2/1] qemu-img: Add "backing":true to unallocated map segments

2021-06-22 Thread Nir Soffer
On Fri, Jun 11, 2021 at 10:03 PM Eric Blake wrote: > > To save the user from having to check 'qemu-img info --backing-chain' > or other followup command to determine which "depth":n goes beyond the > chain, add a boolean field "backing" that is set only for unallocated > portions of the disk. > >

Re: [PULL 0/9] Linux user for 6.1 patches

2021-06-22 Thread Peter Maydell
On Mon, 21 Jun 2021 at 12:07, Laurent Vivier wrote: > > The following changes since commit 1ea06abceec61b6f3ab33dadb0510b6e09fb61e2: > > Merge remote-tracking branch > 'remotes/berrange-gitlab/tags/misc-fixes-pull-request' into staging > (2021-06-14 15:59:13 +0100) > > are available in the

SD/MMC host controller + 64-bit system bus

2021-06-22 Thread Joanne Koong
Hello! I noticed that the default SD/MMC host controller only supports a 32-bit system bus. Is there a reason 64-bit system buses aren't supported by default? Thanks!

Re: [PATCH 5/6] tests/acceptance: add replay kernel test for alpha

2021-06-22 Thread Willian Rampazzo
On Thu, Jun 10, 2021 at 8:25 AM Pavel Dovgalyuk wrote: > > This patch adds record/replay test which boots Linux > kernel on alpha platform. The test uses kernel binaries > taken from boot_linux_console test. > > Signed-off-by: Pavel Dovgalyuk > --- > tests/acceptance/replay_kernel.py | 17

Re: [PATCH v4 6/6] block-copy: atomic .cancelled and .finished fields in BlockCopyCallState

2021-06-22 Thread Emanuele Giuseppe Esposito
On 22/06/2021 12:39, Vladimir Sementsov-Ogievskiy wrote: 22.06.2021 13:20, Paolo Bonzini wrote: On 22/06/21 11:36, Vladimir Sementsov-Ogievskiy wrote: It does.  If it returns true, you still want the load of finished to happen before the reads that follow. Hmm.. The worst case if we use

Re: [PATCH v2] coreaudio: Lock only the buffer

2021-06-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210622201740.38005-1-akihiko.od...@gmail.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210622201740.38005-1-akihiko.od...@gmail.com Subject: [PATCH v2] coreaudio: Lock

Re: SD/MMC host controller + 64-bit system bus

2021-06-22 Thread Philippe Mathieu-Daudé
Hi Joanne, On 6/22/21 8:07 PM, Joanne Koong wrote: > Hello! I noticed that the default SD/MMC host controller only supports a > 32-bit system bus. Is there a reason 64-bit system buses aren't > supported by default? We aim to support the spec v2.00, so this is a bug in the model, 64-bit system

RE: [PATCH v5 10/14] target/hexagon: import parser for idef-parser

2021-06-22 Thread Taylor Simpson
> -Original Message- > From: Alessandro Di Federico > Sent: Saturday, June 19, 2021 3:37 AM > To: qemu-devel@nongnu.org > Cc: Taylor Simpson ; Brian Cain > ; bab...@rev.ng; ni...@rev.ng; phi...@redhat.com; > richard.hender...@linaro.org; Alessandro Di Federico > Subject: [PATCH v5

[v3] migration: fix the memory overwriting risk in add_to_iovec

2021-06-22 Thread Lin Feng
From: Feng Lin When testing migration, a Segmentation fault qemu core is generated. 0 error_free (err=0x1) 1 0x7f8b862df647 in qemu_fclose (f=f@entry=0x55e06c247640) 2 0x7f8b8516d59a in migrate_fd_cleanup (s=s@entry=0x55e06c0e1ef0) 3 0x7f8b8516d66c in migrate_fd_cleanup_bh

Re: [PATCH 0/1] Add features and cpu models

2021-06-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210622201923.150205-1-borntrae...@de.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210622201923.150205-1-borntrae...@de.ibm.com Subject: [PATCH 0/1] Add features and

Re: [PATCH RFC 0/6] i386/pc: Fix creation of >= 1Tb guests on AMD systems with IOMMU

2021-06-22 Thread Alex Williamson
On Tue, 22 Jun 2021 16:48:59 +0100 Joao Martins wrote: > Hey, > > This series lets Qemu properly spawn i386 guests with >= 1Tb with VFIO, > particularly > when running on AMD systems with an IOMMU. > > Since Linux v5.4, VFIO validates whether the IOVA in DMA_MAP ioctl is valid > and it >

Re: [PATCH v1 1/1] migration: Unregister yank if migration setup fails

2021-06-22 Thread Leonardo Bras Soares Passos
On Tue, Jun 22, 2021 at 2:38 PM Peter Xu wrote: [...] > Yes, looks right to me: > > Reviewed-by: Peter Xu > > -- > Peter Xu Thanks Peter!

[PATCH] hw/audio/sb16: Restrict I/O sampling rate range for command 41h/42h

2021-06-22 Thread Qiang Liu
The I/O sampling rate range is enforced to 5000 to 45000HZ according to commit a2cd86a9. Setting I/O sampling rate with command 41h/42h, a guest user can break this assumption and trigger an assertion in audio_calloc via command 0xd4. This patch restricts the I/O sampling rate range for command

Re: [PATCH] target/mips: fix emulation of nanoMIPS BPOSGE32 instruction

2021-06-22 Thread Philippe Mathieu-Daudé
Hi Filip and Aleksandar, On 6/15/21 7:33 PM, Philippe Mathieu-Daudé wrote: > On 6/15/21 7:22 PM, Aleksandar Rikalo wrote: >> Per the "MIPS® Architecture Extension: nanoMIPS32 DSP Technical >> Reference Manual — Revision 0.04" p. 88 "BPOSGE32C", offset argument (imm) >> should be left-shifted

Re: [PATCH v3 03/24] modules: generate modinfo.c

2021-06-22 Thread Jose R. Ziviani
On Fri, Jun 18, 2021 at 06:53:32AM +0200, Gerd Hoffmann wrote: > Add script to generate C source with a small > database containing the module meta-data. > > Signed-off-by: Gerd Hoffmann > --- > scripts/modinfo-generate.py | 84 + > include/qemu/module.h

Re: [PATCH 1/2] linux-user/s390x: signal with SIGFPE on compare-and-trap

2021-06-22 Thread Ilya Leoshkevich
On Mon, 2021-06-21 at 10:14 -0400, Jonathan Albrecht wrote: > Currently when a compare-and-trap instruction is executed, qemu will > always raise a SIGILL signal. On real hardware, a SIGFPE is raised. > > Change the PGM_DATA case in cpu_loop to follow the behavior in > linux kernel

[PATCH qemu] hw/net/vmxnet3: Remove g_assert_not_reached() when VMXNET3_REG_ICR is written

2021-06-22 Thread Qiang Liu
From: cyruscyliu A malicious guest user can write VMXNET3_REG_ICR to crash QEMU. This patch remove the g_aasert_not_reached() there and make the access pass. Fixes: 786fd2b0f87 ("VMXNET3 device implementation") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/309 Buglink:

Re: [PATCH v2 2/2] x86/sev: generate SEV kernel loader hashes in x86_load_linux

2021-06-22 Thread Connor Kuehl
On 6/21/21 2:05 PM, Dov Murik wrote: > If SEV is enabled and a kernel is passed via -kernel, pass the hashes of > kernel/initrd/cmdline in an encrypted guest page to OVMF for SEV > measured boot. > > Co-developed-by: James Bottomley > Signed-off-by: James Bottomley > Signed-off-by: Dov Murik >

Re: [PATCH v2 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-06-22 Thread Connor Kuehl
On 6/21/21 2:05 PM, Dov Murik wrote: > +static void fill_sev_hash_table_entry(SevHashTableEntry *e, const uint8_t > *guid, > + const uint8_t *hash, size_t hash_len) > +{ > +memcpy(e->guid, guid, sizeof(e->guid)); > +e->len = sizeof(*e); > +

Re: [RFC PATCH 0/5] ebpf: Added ebpf helper for libvirtd.

2021-06-22 Thread Jason Wang
在 2021/6/22 下午5:09, Toke Høiland-Jørgensen 写道: Daniel P. Berrangé writes: On Tue, Jun 22, 2021 at 10:25:19AM +0200, Toke Høiland-Jørgensen wrote: Jason Wang writes: 在 2021/6/22 上午11:29, Yuri Benditovich 写道: On Mon, Jun 21, 2021 at 12:20 PM Jason Wang wrote: 在 2021/6/19 上午4:03, Andrew

Re: [PATCH] hw/arm/boot: Use NUMA node ID in memory node name

2021-06-22 Thread Gavin Shan
Hi Drew, On 6/22/21 5:13 PM, Andrew Jones wrote: On Tue, Jun 22, 2021 at 06:53:41PM +1000, Gavin Shan wrote: On 6/3/21 2:48 PM, Gavin Shan wrote: On 6/2/21 9:36 PM, Andrew Jones wrote: On Wed, Jun 02, 2021 at 11:09:32AM +1000, Gavin Shan wrote: On 6/1/21 5:50 PM, Andrew Jones wrote: On

Re: [PATCH v5 0/2] target/s390x: Fix SIGILL/SIGFPE/SIGTRAP psw.addr reporting

2021-06-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210623023250.3667563-1-...@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210623023250.3667563-1-...@linux.ibm.com Subject: [PATCH v5 0/2] target/s390x: Fix

[v2] migration: fix the memory overwriting risk in add_to_iovec

2021-06-22 Thread Lin Feng
From: Feng Lin When testing migration, a Segmentation fault qemu core is generated. 0 error_free (err=0x1) 1 0x7f8b862df647 in qemu_fclose (f=f@entry=0x55e06c247640) 2 0x7f8b8516d59a in migrate_fd_cleanup (s=s@entry=0x55e06c0e1ef0) 3 0x7f8b8516d66c in migrate_fd_cleanup_bh

[PATCH v5 2/2] tests/tcg/s390x: Test SIGILL and SIGSEGV handling

2021-06-22 Thread Ilya Leoshkevich
Verify that s390x-specific uc_mcontext.psw.addr is reported correctly. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/signal.c| 165 2 files changed, 166 insertions(+) create mode 100644

[PATCH v5 1/2] target/s390x: Fix SIGILL/SIGFPE/SIGTRAP psw.addr reporting

2021-06-22 Thread Ilya Leoshkevich
For SIGILL, SIGFPE and SIGTRAP the PSW must point after the instruction, and at the instruction for other signals. Currently under qemu-user it always points at the instruction. Fix by advancing psw.addr for these signals. Buglink: https://gitlab.com/qemu-project/qemu/-/issues/319 Signed-off-by:

[PATCH v5 0/2] target/s390x: Fix SIGILL/SIGFPE/SIGTRAP psw.addr reporting

2021-06-22 Thread Ilya Leoshkevich
qemu-s390x puts a wrong value into SIGILL's siginfo_t's psw.addr: it should be a pointer to the instruction following the illegal instruction, but at the moment it is a pointer to the illegal instruction itself. This breaks OpenJDK, which relies on this value. A similar problem exists for SIGFPE

Re: [PATCH qemu] hw/net/vmxnet3: Remove g_assert_not_reached() when VMXNET3_REG_ICR is written

2021-06-22 Thread Jason Wang
在 2021/6/23 上午10:26, Qiang Liu 写道: From: cyruscyliu A malicious guest user can write VMXNET3_REG_ICR to crash QEMU. This patch remove the g_aasert_not_reached() there and make the access pass. Fixes: 786fd2b0f87 ("VMXNET3 device implementation") Resolves:

Re: Too slow edk2 bios boot?

2021-06-22 Thread Bin Meng
Hi Laszlo, On Wed, Jun 23, 2021 at 12:13 AM Laszlo Ersek wrote: > On 06/18/21 15:06, Bin Meng wrote: > > On Fri, Jun 18, 2021 at 7:46 PM Gerd Hoffmann wrote: > > > >> On Fri, Jun 18, 2021 at 06:46:57PM +0800, Bin Meng wrote: > >>> Hi Laszlo, > >>> > >>> Using the QEMU shipped edk2 bios, for

Re: [PATCH 2/5] usb: drop usb_host_dev_is_scsi_storage hook

2021-06-22 Thread David Gibson
On Tue, Jun 22, 2021 at 02:49:12PM +0200, Gerd Hoffmann wrote: > Introduce an usb device flag instead, set it when usb-host looks at the > device descriptors anyway. Also set it for emulated storage devices, > for consistency. Add an inline helper function to check the flag. > > Signed-off-by:

Re: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-22 Thread chen.zh...@intel.com
On 6/21/21 7:30 PM, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: Zhang Chen writes: Since the real user scenario does not need COLO to monitor all traffic. Add colo-passthrough-add and colo-passthrough-del to maintain a COLO network passthrough list. Add

Re: [PATCH v4 1/6] ACPI ERST: bios-tables-test.c steps 1 and 2

2021-06-22 Thread Igor Mammedov
On Fri, 11 Jun 2021 14:31:18 -0400 Eric DeVolder wrote: > Following the guidelines in tests/qtest/bios-tables-test.c, this > change adds empty placeholder files per step 1 for the new ERST > table, and excludes resulting changed files in bios-tables-test-allowed-diff.h > per step 2. > >

Re: [PATCH v4 1/6] ACPI ERST: bios-tables-test.c steps 1 and 2

2021-06-22 Thread Igor Mammedov
On Tue, 22 Jun 2021 08:34:09 +0200 Igor Mammedov wrote: > On Fri, 11 Jun 2021 14:31:18 -0400 > Eric DeVolder wrote: > > > Following the guidelines in tests/qtest/bios-tables-test.c, this > > change adds empty placeholder files per step 1 for the new ERST > > table, and excludes resulting

Re: [PATCH v1 2/2] tests/acceptance: add OVMF firmware test to cover x86_64 "host" cpu bug

2021-06-22 Thread Claudio Fontana
On 6/4/21 9:12 PM, Eduardo Habkost wrote: > On Fri, Jun 04, 2021 at 08:09:45PM +0200, Claudio Fontana wrote: >> recent refactoring of i386 broke OVMF firmware with a wrong initialization >> order for host cpu. This test covers this issue for potential regressions. >> >> For the actual fixes, see:

Re: [PATCH 13/28] tcg/mips: Support bswap flags in tcg_out_bswap16

2021-06-22 Thread Philippe Mathieu-Daudé
Hi Richard, On 6/14/21 10:37 AM, Richard Henderson wrote: > Merge tcg_out_bswap16 and tcg_out_bswap16s. Use the flags > in the internal uses for loads and stores. > > Signed-off-by: Richard Henderson > --- > tcg/mips/tcg-target.c.inc | 60 ++- > 1 file

Re: [PATCH 21/28] target/arm: Improve vector REV

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/14/21 10:37 AM, Richard Henderson wrote: > We can eliminate the requirement for a zero-extended output, > because the following store will ignore any garbage high bits. > > Cc: Peter Maydell > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 6 ++ > 1 file

Re: [PATCH v2 22/29] target/arm: Improve vector REV

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/22/21 1:18 AM, Richard Henderson wrote: > We can eliminate the requirement for a zero-extended output, > because the following store will ignore any garbage high bits. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 6 ++ > 1 file

Re: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-22 Thread chen.zh...@intel.com
On 6/17/21 7:03 PM, Markus Armbruster wrote: You recently started using Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Please consider anorhter Content-Transfer-Encoding instead. quoted-printable should do. "Zhang, Chen" writes: [...] No,

Re: [PATCH 18/28] tcg: Make use of bswap flags in tcg_gen_qemu_ld_*

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/14/21 10:37 AM, Richard Henderson wrote: > We can perform any required sign-extension via TCG_BSWAP_OS. > > Signed-off-by: Richard Henderson > --- > tcg/tcg-op.c | 24 ++-- > 1 file changed, 10 insertions(+), 14 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 19/29] tcg: Make use of bswap flags in tcg_gen_qemu_ld_*

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/22/21 1:18 AM, Richard Henderson wrote: > We can perform any required sign-extension via TCG_BSWAP_OS. > > Reviewed-by: Peter Maydell > Signed-off-by: Richard Henderson > --- > tcg/tcg-op.c | 24 ++-- > 1 file changed, 10 insertions(+), 14 deletions(-) Reviewed-by:

Re: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-22 Thread Jason Wang
在 2021/6/15 下午7:37, Zhang Chen 写道: Since the real user scenario does not need COLO to monitor all traffic. Add colo-passthrough-add and colo-passthrough-del to maintain a COLO network passthrough list. Add IPFlowSpec struct for all QMP commands. All the fields of IPFlowSpec are optional.

Re: [PATCH] hw/arm/boot: Use NUMA node ID in memory node name

2021-06-22 Thread Andrew Jones
On Tue, Jun 22, 2021 at 06:53:41PM +1000, Gavin Shan wrote: > Hi Drew, > > On 6/3/21 2:48 PM, Gavin Shan wrote: > > On 6/2/21 9:36 PM, Andrew Jones wrote: > > > On Wed, Jun 02, 2021 at 11:09:32AM +1000, Gavin Shan wrote: > > > > On 6/1/21 5:50 PM, Andrew Jones wrote: > > > > > On Tue, Jun 01,

Re: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-22 Thread chen.zh...@intel.com
On 6/22/21 3:04 PM, Jason Wang wrote: 在 2021/6/22 下午2:01, chen.zh...@intel.com 写道: On 6/21/21 7:30 PM, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: Zhang Chen writes: Since the real user scenario does not need COLO to monitor all traffic. Add

Re: [PATCH qemu v21] spapr: Implement Open Firmware client interface

2021-06-22 Thread Alexey Kardashevskiy
On 6/18/21 20:13, BALATON Zoltan wrote: On Fri, 18 Jun 2021, Alexey Kardashevskiy wrote: On 6/17/21 21:29, BALATON Zoltan wrote: On Thu, 17 Jun 2021, Alexey Kardashevskiy wrote: On 17/06/2021 19:16, BALATON Zoltan wrote: On Thu, 17 Jun 2021, Alexey Kardashevskiy wrote: On 16/06/2021

Re: [RFC 0/3] qtest: pick tests that require KVM at runtime

2021-06-22 Thread Thomas Huth
On 22/06/2021 09.26, Philippe Mathieu-Daudé wrote: On 6/22/21 9:20 AM, Thomas Huth wrote: On 16/06/2021 17.24, Igor Mammedov wrote: Sometimes it's necessary to execute a test that depends on KVM, however qtest is not aware if tested QEMU binary supports KVM on the host it the test is

Re: [PATCH v2] block/nvme: Fix VFIO_MAP_DMA failed: No space left on device

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/22/21 9:29 AM, Philippe Mathieu-Daudé wrote: > On 6/21/21 5:36 PM, Fam Zheng wrote: >>> On 21 Jun 2021, at 16:13, Philippe Mathieu-Daudé wrote: >>> On 6/21/21 3:18 PM, Fam Zheng wrote: > On 21 Jun 2021, at 10:32, Philippe Mathieu-Daudé > wrote: > > When the NVMe block

Re: [RFC 0/3] qtest: pick tests that require KVM at runtime

2021-06-22 Thread Alex Bennée
Igor Mammedov writes: > On Fri, 18 Jun 2021 14:43:46 +0200 > Claudio Fontana wrote: > >> On 6/18/21 1:26 PM, Igor Mammedov wrote: >> > On Thu, 17 Jun 2021 18:49:17 +0200 >> > Claudio Fontana wrote: >> > >> >> On 6/16/21 5:24 PM, Igor Mammedov wrote: >> >>> >> >>> Sometimes it's

Re: QEMU PCIe expander bridge with 64kB page guest -> guest BUG_ON()

2021-06-22 Thread Eric Auger
Adding Yubo in the loop as Jiahui's address is bouncing. On 6/21/21 6:22 PM, Eric Auger wrote: > Hi Jiahui, > > I noticed the PCIe expander bridge + PCIe root port does not work with a > 64kB page guest. One hits a kernel BUG at mm/vmalloc.c:96 > (BUG_ON(!pte_none(*pte));)! This happens with an

Re: [RFC PATCH 0/5] ebpf: Added ebpf helper for libvirtd.

2021-06-22 Thread Daniel P . Berrangé
On Tue, Jun 22, 2021 at 10:25:19AM +0200, Toke Høiland-Jørgensen wrote: > Jason Wang writes: > > > 在 2021/6/22 上午11:29, Yuri Benditovich 写道: > >> On Mon, Jun 21, 2021 at 12:20 PM Jason Wang wrote: > >>> > >>> 在 2021/6/19 上午4:03, Andrew Melnichenko 写道: > Hi Jason, > I've checked

Re: [PATCH] coreaudio: Lock only the buffer

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/22/21 3:50 AM, Akihiko Odaki wrote: > On macOS 11.3.1, Core Audio calls AudioDeviceIOProc after calling an > internal function named HALB_Mutex::Lock(), which locks a mutex in > HALB_IOThread::Entry(void*). HALB_Mutex::Lock() is also called in > AudioObjectGetPropertyData, which is called by

Re: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-22 Thread chen.zh...@intel.com
On 6/22/21 3:05 PM, Jason Wang wrote: 在 2021/6/15 下午7:37, Zhang Chen 写道: Since the real user scenario does not need COLO to monitor all traffic. Add colo-passthrough-add and colo-passthrough-del to maintain a COLO network passthrough list. Add IPFlowSpec struct for all QMP commands. All the

Re: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-22 Thread Jason Wang
在 2021/6/22 下午3:38, chen.zh...@intel.com 写道: On 6/22/21 3:04 PM, Jason Wang wrote: 在 2021/6/22 下午2:01, chen.zh...@intel.com 写道: On 6/21/21 7:30 PM, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: Zhang Chen writes: Since the real user scenario does not need

Re: [PATCH v4 6/6] block-copy: atomic .cancelled and .finished fields in BlockCopyCallState

2021-06-22 Thread Paolo Bonzini
On 19/06/21 22:06, Vladimir Sementsov-Ogievskiy wrote: -    assert(call_state->finished); +    assert(qatomic_load_acquire(_state->finished)); Hmm. Here qatomic_load_acquire protects nothing (assertion will crash if not yet finished anyway). So, caller is double sure that block-copy is

Re: [RFC 0/3] qtest: pick tests that require KVM at runtime

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/22/21 10:07 AM, Alex Bennée wrote: > Igor Mammedov writes: >> On Fri, 18 Jun 2021 14:43:46 +0200 >> Claudio Fontana wrote: >>> On 6/18/21 1:26 PM, Igor Mammedov wrote: On Thu, 17 Jun 2021 18:49:17 +0200 Claudio Fontana wrote: > On 6/16/21 5:24 PM, Igor Mammedov wrote:

Re: [PATCH] hw/arm/boot: Use NUMA node ID in memory node name

2021-06-22 Thread Gavin Shan
Hi Drew, On 6/3/21 2:48 PM, Gavin Shan wrote: On 6/2/21 9:36 PM, Andrew Jones wrote: On Wed, Jun 02, 2021 at 11:09:32AM +1000, Gavin Shan wrote: On 6/1/21 5:50 PM, Andrew Jones wrote: On Tue, Jun 01, 2021 at 03:30:04PM +0800, Gavin Shan wrote: We possibly populate empty nodes where memory

Re: [RFC 0/3] qtest: pick tests that require KVM at runtime

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/22/21 9:20 AM, Thomas Huth wrote: > On 16/06/2021 17.24, Igor Mammedov wrote: >> >> Sometimes it's necessary to execute a test that depends on KVM, >> however qtest is not aware if tested QEMU binary supports KVM >> on the host it the test is executed. >> >> For an example: >>   test q35

Re: [PATCH qemu] spapr: tune rtas-size

2021-06-22 Thread Greg Kurz
On Tue, 22 Jun 2021 17:03:36 +1000 Alexey Kardashevskiy wrote: > QEMU reserves space for RTAS via /rtas/rtas-size which tells the client > how much space the RTAS requires to work which includes the RTAS binary > blob implementing RTAS runtime. Because pseries supports FWNMI which > requires

Re: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-22 Thread chen.zh...@intel.com
On 6/22/21 4:03 PM, Jason Wang wrote: 在 2021/6/22 下午3:38, chen.zh...@intel.com 写道: On 6/22/21 3:04 PM, Jason Wang wrote: 在 2021/6/22 下午2:01, chen.zh...@intel.com 写道: On 6/21/21 7:30 PM, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: Zhang Chen writes:

Re: [RFC PATCH v1] vhost-vsock: SOCK_SEQPACKET feature bit support

2021-06-22 Thread Stefano Garzarella
On Mon, Jun 21, 2021 at 05:07:41PM +0300, Arseny Krasnov wrote: This adds processing of VIRTIO_VSOCK_F_SEQPACKET features bit. Guest negotiates it with vhost, thus both will know that SOCK_SEQPACKET supported by peer. Signed-off-by: Arseny Krasnov --- hw/virtio/vhost-vsock.c

Re: [PATCH v2 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-06-22 Thread Dov Murik
I found an issue with this patch when no -initrd is passed, see below. On 21/06/2021 22:05, Dov Murik wrote: > Add the sev_add_kernel_loader_hashes function to calculate the hashes of > the kernel/initrd/cmdline and fill a designated OVMF encrypted hash > table area. For this to work, OVMF

Re: [PATCH v4 4/6] ACPI ERST: create ACPI ERST table for pc/x86 machines.

2021-06-22 Thread Igor Mammedov
On Fri, 11 Jun 2021 14:31:21 -0400 Eric DeVolder wrote: > This change exposes ACPI ERST support for x86 guests. > > Signed-off-by: Eric DeVolder > --- > hw/i386/acpi-build.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index

Re: [PATCH 0/6] More record/replay acceptance tests

2021-06-22 Thread Pavel Dovgalyuk
ping On 10.06.2021 14:24, Pavel Dovgalyuk wrote: The following series adds new record/replay tests to the acceptance group. The provided tests perform kernel boot and disk image boot scenarios. For all of them recording and replaying phases are executed. Tests were borrowed from existing

Re: [PATCH v2 14/29] tcg/mips: Support bswap flags in tcg_out_bswap16

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/22/21 1:18 AM, Richard Henderson wrote: > Merge tcg_out_bswap16 and tcg_out_bswap16s. Use the flags > in the internal uses for loads and stores. > > Signed-off-by: Richard Henderson > --- > tcg/mips/tcg-target.c.inc | 60 ++- > 1 file changed, 28

Re: [RFC 0/3] qtest: pick tests that require KVM at runtime

2021-06-22 Thread Thomas Huth
On 16/06/2021 17.24, Igor Mammedov wrote: Sometimes it's necessary to execute a test that depends on KVM, however qtest is not aware if tested QEMU binary supports KVM on the host it the test is executed. For an example: test q35 machine with intel_iommu This test will run only is KVM is

Re: [RFC PATCH 0/5] ebpf: Added ebpf helper for libvirtd.

2021-06-22 Thread Toke Høiland-Jørgensen
Jason Wang writes: > 在 2021/6/22 上午11:29, Yuri Benditovich 写道: >> On Mon, Jun 21, 2021 at 12:20 PM Jason Wang wrote: >>> >>> 在 2021/6/19 上午4:03, Andrew Melnichenko 写道: Hi Jason, I've checked "kernel.unprivileged_bpf_disabled=0" on Fedora, Ubuntu, and Debian - no need permissions

Re: [RFC 0/3] qtest: pick tests that require KVM at runtime

2021-06-22 Thread Claudio Fontana
On 6/18/21 5:58 PM, Igor Mammedov wrote: > On Fri, 18 Jun 2021 13:26:47 +0200 > Igor Mammedov wrote: > >> On Thu, 17 Jun 2021 18:49:17 +0200 >> Claudio Fontana wrote: > > [...] > >>> Does this series work with --disable-kvm builds? (TCG-only builds?) >> I'll test. But on the first glance it

Re: [PATCH V8 1/6] qapi/net: Add IPFlowSpec and QMP command for COLO passthrough

2021-06-22 Thread Jason Wang
在 2021/6/22 下午2:01, chen.zh...@intel.com 写道: On 6/21/21 7:30 PM, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: Zhang Chen writes: Since the real user scenario does not need COLO to monitor all traffic. Add colo-passthrough-add and colo-passthrough-del to

[PATCH qemu] spapr: tune rtas-size

2021-06-22 Thread Alexey Kardashevskiy
QEMU reserves space for RTAS via /rtas/rtas-size which tells the client how much space the RTAS requires to work which includes the RTAS binary blob implementing RTAS runtime. Because pseries supports FWNMI which requires plenty of space, QEMU reserves more than 2KB which is enough for the RTAS

Re: [PATCH v2] block/nvme: Fix VFIO_MAP_DMA failed: No space left on device

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/21/21 5:36 PM, Fam Zheng wrote: >> On 21 Jun 2021, at 16:13, Philippe Mathieu-Daudé wrote: >> On 6/21/21 3:18 PM, Fam Zheng wrote: On 21 Jun 2021, at 10:32, Philippe Mathieu-Daudé wrote: When the NVMe block driver was introduced (see commit bdd6a90a9e5, January 2018),

Re: [PATCH v17 4/6] KVM: arm64: Expose KVM_ARM_CAP_MTE

2021-06-22 Thread Fuad Tabba
Hi, On Mon, Jun 21, 2021 at 12:18 PM Steven Price wrote: > > It's now safe for the VMM to enable MTE in a guest, so expose the > capability to user space. > > Reviewed-by: Catalin Marinas > Signed-off-by: Steven Price > --- > arch/arm64/kvm/arm.c | 9 + > arch/arm64/kvm/reset.c

Re: [PATCH v4 3/6] block-copy: improve comments of BlockCopyTask and BlockCopyState types and functions

2021-06-22 Thread Vladimir Sementsov-Ogievskiy
21.06.2021 10:59, Emanuele Giuseppe Esposito wrote: On 19/06/2021 17:23, Vladimir Sementsov-Ogievskiy wrote: 14.06.2021 10:33, Emanuele Giuseppe Esposito wrote: As done in BlockCopyCallState, categorize BlockCopyTask and BlockCopyState in IN, State and OUT fields. This is just to understand

Re: [PATCH v2] hw/audio/sb16: Avoid assertion by restricting I/O sampling rate range

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/22/21 10:54 AM, Qiang Liu wrote: > Hi folks, > > With this patch, having tested more, I find another way to trigger the > assertion. > I found it just now such that I did a quick investigation and reported > it to you. I > hope this would prevent merging this patch. No need to prevent

[RFC PATCH v4 6/7] hw/acpi/aml-build: Add Processor hierarchy node structure

2021-06-22 Thread Yanan Wang
Add a generic API to build Processor hierarchy node structure (Type 0), which is strictly consistent with descriptions in ACPI 6.2: 5.2.29.1. This function will be used to build ACPI PPTT table for cpu topology. Co-developed-by: Ying Fang Signed-off-by: Ying Fang Co-developed-by: Henglong Fan

Re: [PATCH v2 1/2] sev/i386: Introduce sev_add_kernel_loader_hashes for measured linux boot

2021-06-22 Thread Philippe Mathieu-Daudé
On 6/22/21 11:44 AM, Dov Murik wrote: > On 21/06/2021 23:32, Philippe Mathieu-Daudé wrote: >> and added qemu_uuid_copy() to complete the API, but that's fine. > > I think simple C assignment works for structs (and hence QemuUUID), > something like: > > SevHashTable *ht = ...; > ht->guid

[RFC v5 02/13] hw/s390x: rename tod-qemu.c to tod-tcg.c

2021-06-22 Thread Cho, Yu-Chen
we stop short of renaming the actual qom object though, so type remains TYPE_QEMU_S390_TOD, ie "s390-tod-qemu". Signed-off-by: Claudio Fontana Reviewed-by: David Hildenbrand Reviewed-by: Cornelia Huck Signed-off-by: Cho, Yu-Chen --- hw/s390x/meson.build | 2 +-

  1   2   3   >